[00:00:19] (03CR) 10BearND: "I mean: I've added ..." [services/mobileapps] - 10https://gerrit.wikimedia.org/r/248995 (owner: 10BearND) [00:00:32] 3DevRel-November-2015: Recruit Google Code-in 2015 mentors - https://phabricator.wikimedia.org/T115409#1755945 (10Aklapper) @petrb, @matmarex, @legoktm: Thanks! This is already pretty motivating, seriously. :) Please check https://www.mediawiki.org/wiki/Google_Code-in_2015#Mentors.27_corner - in short: Add #Goo... [00:01:06] 10WikiProject-X: Implement (anonymous) tracking mechanisms to determine how frequently tools are used - https://phabricator.wikimedia.org/T116675#1755950 (10Harej) [00:02:47] (03CR) 10BryanDavis: [C: 031] Allow setting a custom callback URL [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/248662 (owner: 10Gergő Tisza) [00:05:37] (03CR) 10Niedzielski: [C: 031] "This is perfect. Now if I ever wonder why this directory is needed in the .gitignore file because my tools never generate it, I can look a" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/248995 (owner: 10BearND) [00:06:26] (03PS1) 10Mooeypoo: Allow notification model and widget to show combined notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249031 [00:06:30] (03CR) 10Ori.livneh: [C: 032] Avoid pointless range scan for 'load-recent-authors' [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/248989 (https://phabricator.wikimedia.org/T116557) (owner: 10Aaron Schulz) [00:06:48] (03PS1) 10Ori.livneh: Avoid pointless range scan for 'load-recent-authors' [extensions/AbuseFilter] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/249032 (https://phabricator.wikimedia.org/T116557) [00:07:30] (03Merged) 10jenkins-bot: Displaying search results for multiple wikis [core] - 10https://gerrit.wikimedia.org/r/241129 (https://phabricator.wikimedia.org/T112349) (owner: 10Smalyshev) [00:07:33] (03CR) 10Jdlrobson: [C: 032] "I was testing in stable.. not beta... silly me. Will send a follow up about my other comments for discussion." [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/244149 (https://phabricator.wikimedia.org/T113635) (owner: 10Phuedx) [00:07:35] (03Merged) 10jenkins-bot: Displaying search results for multiple wikis [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/239444 (https://phabricator.wikimedia.org/T112349) (owner: 10Smalyshev) [00:08:34] (03PS1) 10Bmansurov: Fix card heading font-family. [extensions/Cards] - 10https://gerrit.wikimedia.org/r/249033 (https://phabricator.wikimedia.org/T114393) [00:09:30] (03Merged) 10jenkins-bot: Avoid pointless range scan for 'load-recent-authors' [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/248989 (https://phabricator.wikimedia.org/T116557) (owner: 10Aaron Schulz) [00:09:32] (03CR) 10jenkins-bot: [V: 04-1] Add Related Articles section to Minerva [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/244149 (https://phabricator.wikimedia.org/T113635) (owner: 10Phuedx) [00:11:48] (03PS1) 10Jdlrobson: Hygiene: Minor styling improvements [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/249035 [00:11:50] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Minor styling improvements [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/249035 (owner: 10Jdlrobson) [00:12:21] (03CR) 10Sniedzielski: [C: 032 V: 032] Hygiene: Add tmp dir to gitignore [services/mobileapps] - 10https://gerrit.wikimedia.org/r/248995 (owner: 10BearND) [00:13:52] (03PS2) 10Jdlrobson: Hygiene: Minor styling improvements [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/249035 [00:13:54] (03PS15) 10Jdlrobson: Add Related Articles section to Minerva [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/244149 (https://phabricator.wikimedia.org/T113635) (owner: 10Phuedx) [00:14:35] 10MediaWiki-Unit-tests, 10Continuous-Integration-Infrastructure: MediaWiki CI tests should run with allow_url_fopen set to false - https://phabricator.wikimedia.org/T116704#1755977 (10saper) [00:14:36] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Minor styling improvements [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/249035 (owner: 10Jdlrobson) [00:15:16] (03CR) 10Jdlrobson: [C: 032] "See https://gerrit.wikimedia.org/r/249035" [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/244149 (https://phabricator.wikimedia.org/T113635) (owner: 10Phuedx) [00:15:42] (03Merged) 10jenkins-bot: Add Related Articles section to Minerva [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/244149 (https://phabricator.wikimedia.org/T113635) (owner: 10Phuedx) [00:15:52] 10MediaWiki-extensions-RelatedArticles, 10Reading-Community-Engagement, 3Mobile-Web-Design, 5Patch-For-Review, 3reading-web-sprint-58-The-Sixth-Sense: Implement first version of read more - https://phabricator.wikimedia.org/T113635#1755980 (10Jdlrobson) Some follow ups needed but this is mostly done: See... [00:16:15] (03CR) 10Ori.livneh: [C: 032] Avoid pointless range scan for 'load-recent-authors' [extensions/AbuseFilter] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/249032 (https://phabricator.wikimedia.org/T116557) (owner: 10Ori.livneh) [00:19:15] 10MediaWiki-DjVu, 10Wikimedia-Media-storage: Some DjVu files not being rendered in commons (showing up as "0 × 0 pixels", despite the file size in MB being nonzero) - https://phabricator.wikimedia.org/T107664#1755984 (10Vladis13) >>! In T107664#1755581, @Bawolff wrote: >>>! In T107664#1755202, @Rillke wrote: >... [00:19:22] (03Merged) 10jenkins-bot: Avoid pointless range scan for 'load-recent-authors' [extensions/AbuseFilter] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/249032 (https://phabricator.wikimedia.org/T116557) (owner: 10Ori.livneh) [00:19:24] (03PS1) 10Aude: Add --forceParse UpdaterFlag and option in forceSearchIndex script [extensions/CirrusSearch] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/249036 (https://phabricator.wikimedia.org/T116381) [00:21:23] (03CR) 10Mattflaschen: [C: 032] "Merge after branch cut." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245612 (https://phabricator.wikimedia.org/T114620) (owner: 10Catrope) [00:21:48] 10WikiProject-X: Implement (anonymous) tracking mechanisms to determine how frequently tools are used - https://phabricator.wikimedia.org/T116675#1755988 (10Harej) Discussed this matter with @legoktm @bawolff and @yuvipanda. Routing clicks through an external tracking service (even one hosted by Labs) is off th... [00:23:33] 10WikiProject-X: Implement SuggestBot recommendations as a WikiProject module - https://phabricator.wikimedia.org/T106865#1755991 (10Harej) @nettrom, anything else needs to be done before I close this task? [00:23:50] (03Merged) 10jenkins-bot: Adapt to Parsoid/RESTbase renaming scrubWikitext to scrub_wikitext [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245612 (https://phabricator.wikimedia.org/T114620) (owner: 10Catrope) [00:26:33] 10WikiProject-X, 3Team-Practices-This-Week: Team Practices consultation for WikiProject X - https://phabricator.wikimedia.org/T112413#1756000 (10Harej) I consider this task to be complete by WikiProject X's requirements. I will defer to your team to close the task. [00:29:25] (03PS4) 10Gergő Tisza: Convert hooks.txt to hooks.yaml [core] - 10https://gerrit.wikimedia.org/r/248677 (https://phabricator.wikimedia.org/T115388) (owner: 10Akangupt) [00:29:55] 10MediaWiki-General-or-Unknown, 10MediaWiki-Unit-tests: IPTCTest::testIPTCParseForcedUTFButInvalid failure in iptcparse() - https://phabricator.wikimedia.org/T116705#1756005 (10saper) 3NEW [00:31:36] 10Wikimedia-Video: Batch video upload tracking bug - https://phabricator.wikimedia.org/T116510#1756014 (10Pine) Thanks! Can you also add something about the issue that the upload tool should only load small chunks of files a time into the browser's memory so that a 20GB upload doesn't result in the browser attem... [00:33:22] 10MediaWiki-extensions-WikimediaEvents: Exception caught inside exception handler - https://phabricator.wikimedia.org/T116593#1756018 (10TTO) See T112845 for improving that somewhat cryptic error message [00:40:22] (03CR) 10Krinkle: "If we do this, it should remove/replace the existing hooks.txt file." [core] - 10https://gerrit.wikimedia.org/r/248677 (https://phabricator.wikimedia.org/T115388) (owner: 10Akangupt) [00:43:25] (03PS3) 10Yurik: WIP/DONOTMERGE Dynamic interactive graph loading [extensions/Graph] - 10https://gerrit.wikimedia.org/r/242641 [00:43:56] (03CR) 10jenkins-bot: [V: 04-1] WIP/DONOTMERGE Dynamic interactive graph loading [extensions/Graph] - 10https://gerrit.wikimedia.org/r/242641 (owner: 10Yurik) [00:44:41] (03PS1) 10Mattflaschen: Revert "Adapt to Parsoid/RESTbase renaming scrubWikitext to scrub_wikitext" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249039 [00:44:51] (03CR) 10Catrope: [C: 032] Revert "Adapt to Parsoid/RESTbase renaming scrubWikitext to scrub_wikitext" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249039 (owner: 10Mattflaschen) [00:46:33] (03CR) 10Mattflaschen: [C: 032] "Sorry. There may be nothing wrong with it, but I didn't mean to merge it after freeze." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249039 (owner: 10Mattflaschen) [00:47:28] (03Merged) 10jenkins-bot: Revert "Adapt to Parsoid/RESTbase renaming scrubWikitext to scrub_wikitext" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249039 (owner: 10Mattflaschen) [00:50:57] (03CR) 10Mattflaschen: "Let's check the answer to https://phabricator.wikimedia.org/T114620#1756025 before doing this." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245612 (https://phabricator.wikimedia.org/T114620) (owner: 10Catrope) [00:52:18] 10MediaWiki-Search, 6Discovery: Bad search results when you don't write the preposition in your search query - https://phabricator.wikimedia.org/T116706#1756029 (10Savig) 3NEW [00:54:25] (03CR) 10Jdlrobson: [C: 031] "Need to test before merging" [extensions/Cards] - 10https://gerrit.wikimedia.org/r/249033 (https://phabricator.wikimedia.org/T114393) (owner: 10Bmansurov) [00:55:02] (03PS2) 10Mattflaschen: Use flow- prefix for the CSS classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248988 [00:55:54] 10MediaWiki-General-or-Unknown, 10MediaWiki-Unit-tests: IPTCTest::testIPTCParseForcedUTFButInvalid failure in iptcparse() - https://phabricator.wikimedia.org/T116705#1756050 (10saper) [00:56:09] (03CR) 10Mattflaschen: "We should probably wait until after the cut, since this is non-urgent." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248988 (owner: 10Mattflaschen) [00:56:18] (03CR) 10Mattflaschen: Use flow- prefix for the CSS classes (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248988 (owner: 10Mattflaschen) [00:57:41] (03CR) 10Aude: "plan to deploy this tomorrow (with ok from the Cirrus developers)" [extensions/CirrusSearch] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/249036 (https://phabricator.wikimedia.org/T116381) (owner: 10Aude) [00:59:12] 10MediaWiki-Cache, 6Performance-Team, 10hardware-requests, 6operations, 7Availability: Setup a 2 server Kafka instance in both eqiad and codfw for reliable purge streams - https://phabricator.wikimedia.org/T114191#1756057 (10RobH) I meant to get to this today, but other tasks took priority. I'll invest... [01:05:59] (03CR) 10Bmansurov: [C: 032] Hygiene: Introduce Toggler class, kill toggle instance [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/246432 (owner: 10Jdlrobson) [01:06:25] (03CR) 10Aude: [C: 04-1] "i still get " Got explicit BEGIN while atomic sections RefreshLinks::fixLinksFromArticle are still open." errors" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/249000 (https://phabricator.wikimedia.org/T75456) (owner: 10Aude) [01:08:34] (03Merged) 10jenkins-bot: Hygiene: Introduce Toggler class, kill toggle instance [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/246432 (owner: 10Jdlrobson) [01:08:56] (03PS2) 10Aude: Remove begin/commit transaction calls in refreshLinks.php [core] - 10https://gerrit.wikimedia.org/r/249000 (https://phabricator.wikimedia.org/T75456) [01:09:25] (03CR) 10Bmansurov: "question" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/246437 (https://phabricator.wikimedia.org/T114655) (owner: 10Jdlrobson) [01:09:40] (03CR) 10Aaron Schulz: [C: 032] Remove begin/commit transaction calls in refreshLinks.php [core] - 10https://gerrit.wikimedia.org/r/249000 (https://phabricator.wikimedia.org/T75456) (owner: 10Aude) [01:14:47] 5Patch-For-Review, 3Wikipedia-Android-App: Create APKs with app_name, variant, flavour and version in the filename. Example: Wikipedia App-prod-release-132.apk - https://phabricator.wikimedia.org/T116540#1756075 (10Niedzielski) 5Open>3Invalid a:3Niedzielski Related to T105230 Thank you for this change a... [01:19:45] (03Merged) 10jenkins-bot: Remove begin/commit transaction calls in refreshLinks.php [core] - 10https://gerrit.wikimedia.org/r/249000 (https://phabricator.wikimedia.org/T75456) (owner: 10Aude) [01:20:30] 10UI-Standardization, 10OOjs-UI, 5Patch-For-Review: Remove `-ms-transition` & `-ms-animation` from OOjs UI as IE10 final understands unprefixed properties. - https://phabricator.wikimedia.org/T116453#1756084 (10Volker_E) Nice! Together with T116454 nearly 1 KB of savings on minified CSS. :) [01:25:52] 10MediaWiki-General-or-Unknown, 7Security-Core: XMPReader::checkParseSafely requires allow_url_fopen to be set enabled - https://phabricator.wikimedia.org/T116701#1756089 (10Bawolff) huh. It really shouldn't need that. [01:26:58] (03PS1) 10thibaultmarin: [extension-PGFTikZ] Fix errors descriptions [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/249043 (https://phabricator.wikimedia.org/T111103) [01:27:31] 10Wikimedia-Stream: Rewrite RCStream in Node.js - https://phabricator.wikimedia.org/T86803#1756096 (10Krinkle) >>! In T86803#1753740, @Afandian wrote: > This looks like a good opportunity to include diff information. A number of bots are watching the RCStream and immediately fetching relevant diff. This is expen... [01:27:56] 10MediaWiki-General-or-Unknown, 7Security-Core: XMPReader::checkParseSafely requires allow_url_fopen to be set enabled - https://phabricator.wikimedia.org/T116701#1756097 (10Bawolff) Confirmed. Tests fail without allow_url_fopen. [01:29:14] (03PS1) 10Mattflaschen: Implement AbstractCollection::newFromRevisionId [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249044 [01:30:21] (03PS3) 10Aaron Schulz: Remove use of rollback() in WikiPage::doEditContent() [core] - 10https://gerrit.wikimedia.org/r/244334 [01:31:15] (03CR) 10jenkins-bot: [V: 04-1] Implement AbstractCollection::newFromRevisionId [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249044 (owner: 10Mattflaschen) [01:31:34] 10MediaWiki-extensions-GettingStarted, 10MediaWiki-extensions-RelatedArticles, 10Reading Web Sprint 59 7: Migrate gettingstartedgetpages API to RelatedArticles - https://phabricator.wikimedia.org/T114916#1756100 (10Jdlrobson) [01:31:49] 10MediaWiki-extensions-GettingStarted, 10MediaWiki-extensions-RelatedArticles, 10Reading Web Sprint 59 7: Migrate gettingstartedgetpages API to RelatedArticles - https://phabricator.wikimedia.org/T114916#1709519 (10Jdlrobson) [01:32:24] 10MediaWiki-extensions-GettingStarted, 10MediaWiki-extensions-RelatedArticles: Migrate gettingstartedgetpages API to RelatedArticles - https://phabricator.wikimedia.org/T114916#1709519 (10Jdlrobson) [01:33:47] 10MediaWiki-extensions-Other, 5Patch-For-Review: [PGFTikZ] MediaWiki:Pgftikz-error-uploadlocal error verify should be more elaborate. - https://phabricator.wikimedia.org/T111103#1756105 (10thibaultmarin) Sorry for the very long delay and thanks for the bug report. The patch set submitted to gerrit (249043) is... [01:34:08] (03CR) 10Niedzielski: [C: 04-1] Generate apk with app_name, variant, flavour and version number (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/248699 (https://phabricator.wikimedia.org/T116540) (owner: 10Wikinaut) [01:34:31] (03CR) 10Krinkle: [C: 032] Migrate more callers away from $wgMemc [core] - 10https://gerrit.wikimedia.org/r/248815 (owner: 10Aaron Schulz) [01:34:41] 10Reading Web Sprint 59 7: Related Articles should come from GettingStarted API - https://phabricator.wikimedia.org/T116707#1756106 (10Jdlrobson) 3NEW [01:34:51] 10Reading Web Sprint 59 7: Related Articles should come from GettingStarted API - https://phabricator.wikimedia.org/T116707#1756115 (10Jdlrobson) [01:35:16] 10Reading Web Sprint 59 7: Related Articles should come from GettingStarted API - https://phabricator.wikimedia.org/T116707#1756106 (10Jdlrobson) [01:35:18] 10MobileFrontend, 10Reading Web Planning, 6Reading-Admin, 10Reading-Community-Engagement, 3Mobile-Web-Design: [EPIC] Read more related articles after end of current article - https://phabricator.wikimedia.org/T94906#1756117 (10Jdlrobson) [01:40:53] 10MediaWiki-General-or-Unknown, 7Security-Core: XMPReader::checkParseSafely requires allow_url_fopen to be set enabled - https://phabricator.wikimedia.org/T116701#1756120 (10Bawolff) The logging of errors seems to get thrown away in the unit tests. Actual error is: XMLReader::open(): data:// wrapper is disab... [01:44:46] (03Merged) 10jenkins-bot: Migrate more callers away from $wgMemc [core] - 10https://gerrit.wikimedia.org/r/248815 (owner: 10Aaron Schulz) [01:47:23] (03PS3) 10TTO: Removed raw HTML from tags-create-explanation message in SpecialTags.php [core] - 10https://gerrit.wikimedia.org/r/248860 (https://phabricator.wikimedia.org/T111754) (owner: 10Devirk) [01:51:06] (03CR) 10TTO: [C: 04-1] Removed raw HTML from tags-create-explanation message in SpecialTags.php [core] - 10https://gerrit.wikimedia.org/r/248860 (https://phabricator.wikimedia.org/T111754) (owner: 10Devirk) [01:51:26] (03CR) 10TTO: "Whoops, left the comment on PS2 by mistake!" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/248860 (https://phabricator.wikimedia.org/T111754) (owner: 10Devirk) [01:57:27] 10MediaWiki-ResourceLoader, 10Flow, 6Performance-Team, 3Collaboration-Team-Current, and 3 others: wgRelevantPageName is missing on Chinese Wikipedia - https://phabricator.wikimedia.org/T116693#1756128 (10Catrope) This appears to happen because we use non-multibyte-aware truncation for summaries (I think th... [01:57:34] 10MediaWiki-ResourceLoader, 10Flow, 6Performance-Team, 3Collaboration-Team-Current, and 3 others: wgRelevantPageName is missing on Chinese Wikipedia - https://phabricator.wikimedia.org/T116693#1756129 (10Catrope) a:3Catrope [01:58:37] (03PS4) 10EBernhardson: Try to eliminate configuration for interwiki->wikiname using SiteMatrix. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/247015 (owner: 10Smalyshev) [02:01:16] (03PS3) 10Gergő Tisza: Move mwoauth-php lib to Composer, add standard Composer tests [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/248661 [02:01:18] (03PS1) 10Gergő Tisza: Add npm/composer stub [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/249045 [02:02:06] (03PS1) 10EBernhardson: add missing ResultSet::hasInterwikiResults implementation [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/249046 [02:03:48] (03CR) 10EBernhardson: [C: 032] add missing ResultSet::hasInterwikiResults implementation [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/249046 (owner: 10EBernhardson) [02:06:31] (03Merged) 10jenkins-bot: add missing ResultSet::hasInterwikiResults implementation [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/249046 (owner: 10EBernhardson) [02:07:33] (03PS2) 10Tim Landscheidt: Add missing PostgreSQL updater for af_group. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/23933 [02:12:51] (03PS4) 10JGirault: Restore satisfaction schema and fix the performance issue that it had [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/248087 (https://phabricator.wikimedia.org/T116319) (owner: 10EBernhardson) [02:12:53] (03CR) 10jenkins-bot: [V: 04-1] Restore satisfaction schema and fix the performance issue that it had [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/248087 (https://phabricator.wikimedia.org/T116319) (owner: 10EBernhardson) [02:14:58] (03CR) 10Tim Landscheidt: [C: 04-1] "abusefilter.tables.pg.sql still needs to be changed as well as also this has not been tested." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/23933 (owner: 10Tim Landscheidt) [02:15:30] 10Sentry: Update email settings of Sentry puppet role - https://phabricator.wikimedia.org/T116709#1756143 (10Tgr) 3NEW [02:15:44] (03CR) 10Cindy-the-browser-test-bot: "features/update_general_api.feature:45:54:63" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/249046 (owner: 10EBernhardson) [02:21:31] 3Outreachy-Round-11: Make sure all mentors sign up in Outreachy'11 application system - https://phabricator.wikimedia.org/T116589#1756150 (10Nicolas_Raoul) [02:28:11] (03PS5) 10JGirault: Restore satisfaction schema and fix the performance issue that it had [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/248087 (https://phabricator.wikimedia.org/T116319) (owner: 10EBernhardson) [02:28:30] (03CR) 10jenkins-bot: [V: 04-1] Restore satisfaction schema and fix the performance issue that it had [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/248087 (https://phabricator.wikimedia.org/T116319) (owner: 10EBernhardson) [02:32:41] (03CR) 10JGirault: "We need to fix the mobile issue." (032 comments) [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/248087 (https://phabricator.wikimedia.org/T116319) (owner: 10EBernhardson) [02:36:24] (03CR) 10EBernhardson: Restore satisfaction schema and fix the performance issue that it had (031 comment) [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/248087 (https://phabricator.wikimedia.org/T116319) (owner: 10EBernhardson) [02:39:01] 10CirrusSearch, 6Discovery, 3Discovery-Cirrus-Sprint, 5MW-1.27-release-notes, and 4 others: Inform users what happened if their query is forwarded to another wiki because of language detection - https://phabricator.wikimedia.org/T112349#1756158 (10EBernhardson) I reviewed stas's existing code and sent it t... [02:47:11] (03CR) 10Mattflaschen: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249044 (owner: 10Mattflaschen) [02:51:30] huh, OutputPage::lowerCdnMaxage is weird [02:52:00] err, actually it makes sense [02:52:10] 6Phabricator, 6Labs, 7Puppet: phabricator puppet at labs broken - https://phabricator.wikimedia.org/T116442#1756160 (10Negative24) Prod uses some variables from the private puppet repo for setting passwords and such. But the prod class also sets up mail servers and relays that would be complex to manage in l... [02:54:24] (03PS1) 10Tim Landscheidt: Alias sql to mysql [vagrant] - 10https://gerrit.wikimedia.org/r/249047 (https://phabricator.wikimedia.org/T92639) [02:54:50] (03CR) 10jenkins-bot: [V: 04-1] Alias sql to mysql [vagrant] - 10https://gerrit.wikimedia.org/r/249047 (https://phabricator.wikimedia.org/T92639) (owner: 10Tim Landscheidt) [02:55:19] (03PS1) 10Isarra: Add flexbox support mixins to mediawiki.mixins [core] - 10https://gerrit.wikimedia.org/r/249048 [02:55:40] (03PS2) 10Tim Landscheidt: Alias sql to mysql [vagrant] - 10https://gerrit.wikimedia.org/r/249047 (https://phabricator.wikimedia.org/T92639) [02:56:57] (03PS2) 10Mattflaschen: Implement AbstractCollection::newFromRevisionId [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249044 [02:58:00] (03PS3) 10Mattflaschen: Implement AbstractCollection::newFromRevisionId [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249044 [02:59:09] bawolff: I'm glad it made sense :D [02:59:30] (03CR) 10EBernhardson: Restore satisfaction schema and fix the performance issue that it had (031 comment) [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/248087 (https://phabricator.wikimedia.org/T116319) (owner: 10EBernhardson) [02:59:37] I read it too quickly, and thought it was setting the wrong variable [03:02:46] (03CR) 10Gergő Tisza: Allow findHooks.php to compare parameter count of hooks (033 comments) [core] - 10https://gerrit.wikimedia.org/r/239659 (owner: 10Umherirrender) [03:03:25] (03CR) 10Krinkle: Restore satisfaction schema and fix the performance issue that it had (031 comment) [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/248087 (https://phabricator.wikimedia.org/T116319) (owner: 10EBernhardson) [03:08:53] (03CR) 10Krinkle: Restore satisfaction schema and fix the performance issue that it had (032 comments) [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/248087 (https://phabricator.wikimedia.org/T116319) (owner: 10EBernhardson) [03:13:53] 10MediaWiki-ResourceLoader, 6Performance-Team, 5MW-1.26-release, 5Patch-For-Review: Support position "bottom" for addModuleStyles - https://phabricator.wikimedia.org/T97420#1756181 (10Krinkle) [03:14:33] 10MediaWiki-ResourceLoader, 6Performance-Team: Consider removing top/bottom queue distinction - https://phabricator.wikimedia.org/T109837#1756183 (10Krinkle) >>! In T109837#1741621, @saper wrote: > Improvement in the "time to first painted" in T107399 is impressive. But do we have a way to measure how many of... [03:14:52] (03PS1) 10Mattflaschen: Do not attempt to fall back to PHP parser [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249049 (https://phabricator.wikimedia.org/T116699) [03:17:53] (03CR) 10Mattflaschen: "Should we be even more explicit and have something like $wgFlowUseParsoid? We could use that to determine whether to use Parsoid, then ha" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249049 (https://phabricator.wikimedia.org/T116699) (owner: 10Mattflaschen) [03:20:03] (03PS1) 10Catrope: Language::truncate(): don't chop up multibyte characters when input contains newlines [core] - 10https://gerrit.wikimedia.org/r/249050 (https://phabricator.wikimedia.org/T116693) [03:21:17] (03CR) 10Gergő Tisza: Allow findHooks.php to compare parameter references of hooks (031 comment) [core] - 10https://gerrit.wikimedia.org/r/246306 (owner: 10Umherirrender) [03:23:13] (03CR) 10Krinkle: [C: 032] "Woo!" [core] - 10https://gerrit.wikimedia.org/r/249050 (https://phabricator.wikimedia.org/T116693) (owner: 10Catrope) [03:23:22] (03PS1) 10Krinkle: Language::truncate(): don't chop up multibyte characters when input contains newlines [core] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/249051 (https://phabricator.wikimedia.org/T116693) [03:24:07] 6Phabricator, 6Labs, 7Puppet: phabricator puppet at labs broken - https://phabricator.wikimedia.org/T116442#1756194 (10Dzahn) Ok, thanks for the explanation. I see.. I truly wish we could fix all this and really use the same role class in labs and prod. (and then apply changes in labs first for testing lik... [03:25:26] 6Phabricator, 6Labs, 7Puppet: phabricator puppet at labs broken - https://phabricator.wikimedia.org/T116442#1756195 (10Dzahn) The password part we can fix with the labs/private repo. Happy to help. Not so sure about the mail server part though. [03:29:15] (03CR) 10Krinkle: [C: 032] Language::truncate(): don't chop up multibyte characters when input contains newlines [core] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/249051 (https://phabricator.wikimedia.org/T116693) (owner: 10Krinkle) [03:31:19] (03PS1) 10Ori.livneh: Get rid of CSS transitions on form elements in mediawiki.ui [core] - 10https://gerrit.wikimedia.org/r/249053 [03:33:18] (03Merged) 10jenkins-bot: Language::truncate(): don't chop up multibyte characters when input contains newlines [core] - 10https://gerrit.wikimedia.org/r/249050 (https://phabricator.wikimedia.org/T116693) (owner: 10Catrope) [03:34:12] 10MediaWiki-Extension-Requests, 10MediaWiki-Special-pages, 10MobileFrontend, 5Patch-For-Review, 7Technical-Debt: Kill SpecialUserProfile or Move MobileFrontend extension's Special:UserProfile.php and related code to a separate MediaWiki extension - https://phabricator.wikimedia.org/T85929#1756198 (10MZMcB... [03:39:40] 10MediaWiki-extensions-WikibaseRepository, 10DataValues, 10Wikidata: [Task] Investigate quantification of quantity precision (+/- 1 or +/- 0.5) - https://phabricator.wikimedia.org/T105623#1756199 (10kaldari) Are we still investigating this or have we reached the conclusion that +/- 0.5 is the most sensible d... [03:39:42] (03PS1) 10Krinkle: resoureloader: Consolidate styles-only queue at the top [core] - 10https://gerrit.wikimedia.org/r/249054 [03:40:27] (03PS1) 10Krinkle: Remove position default logic [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/249055 [03:40:52] (03Merged) 10jenkins-bot: Language::truncate(): don't chop up multibyte characters when input contains newlines [core] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/249051 (https://phabricator.wikimedia.org/T116693) (owner: 10Krinkle) [03:43:24] (03CR) 10jenkins-bot: [V: 04-1] resoureloader: Consolidate styles-only queue at the top [core] - 10https://gerrit.wikimedia.org/r/249054 (owner: 10Krinkle) [03:47:00] 6Zero: Portal testing feature shows 'NaN' in timer, prevents usage - https://phabricator.wikimedia.org/T116710#1756204 (10DFoy) 3NEW a:3jhobs [03:47:26] (03PS1) 10Krinkle: Remove position default logic [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/249057 [03:47:29] 6Zero: Portal testing feature shows 'NaN' in timer, prevents usage - https://phabricator.wikimedia.org/T116710#1756212 (10DFoy) {F2879461} [03:48:56] (03CR) 10Krinkle: "Requires these two changes to land first:" [core] - 10https://gerrit.wikimedia.org/r/249054 (owner: 10Krinkle) [03:53:11] (03PS1) 10Krinkle: Archive repository [extensions/SyntaxHighlight_Pygments] - 10https://gerrit.wikimedia.org/r/249058 (https://phabricator.wikimedia.org/T103614) [03:55:30] 3Wikipedia-Android-App: Need custom APK for DTAC Thailand - https://phabricator.wikimedia.org/T116711#1756215 (10DFoy) 3NEW [03:56:45] (03CR) 10Krinkle: [C: 032] Reset serialize_precision to stabilize tests [core] - 10https://gerrit.wikimedia.org/r/249018 (https://phabricator.wikimedia.org/T116683) (owner: 10saper) [04:00:38] (03CR) 10Krinkle: Hi-DPI spinner using CSS animation (031 comment) [core] - 10https://gerrit.wikimedia.org/r/223586 (https://phabricator.wikimedia.org/T61699) (owner: 10Brion VIBBER) [04:07:29] (03CR) 10Krinkle: build: Enable remaining jsduck jsDoc rules save 'checkRe{dundantParam,turnType}s' (032 comments) [core] - 10https://gerrit.wikimedia.org/r/236345 (owner: 10Jforrester) [04:07:34] (03Merged) 10jenkins-bot: Reset serialize_precision to stabilize tests [core] - 10https://gerrit.wikimedia.org/r/249018 (https://phabricator.wikimedia.org/T116683) (owner: 10saper) [04:10:26] 10MediaWiki-General-or-Unknown, 10MediaWiki-Unit-tests: IPTCTest::testIPTCParseForcedUTFButInvalid failure in iptcparse() - https://phabricator.wikimedia.org/T116705#1756231 (10PleaseStand) [04:10:28] 10MediaWiki-Unit-tests, 5Patch-For-Review: IPTCTest::testIPTCParseForcedUTFButInvalid failure on PHP with buggy glibc (iconv //IGNORE broken) - https://phabricator.wikimedia.org/T39665#1756232 (10PleaseStand) [04:10:43] (03CR) 10Krinkle: "The code being removed doesn't ensure type attributes are not output. Rather, they are already not output and the removal of this code wil" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/230278 (owner: 10Ori.livneh) [04:11:22] (03PS1) 10Aaron Schulz: Completely defer EditPage::updateWatchlist [core] - 10https://gerrit.wikimedia.org/r/249061 [04:11:44] [13composer-merge-plugin] 15legoktm pushed 2 new commits to 06master: 02https://github.com/wikimedia/composer-merge-plugin/compare/6196fdb001fa...b98b9c3a53b5 [04:11:44] 13composer-merge-plugin/06master 14f706e5c 15Bryan Davis: Handle RootAliasPackage as correctly as we can... [04:11:44] 13composer-merge-plugin/06master 14b98b9c3 15Kunal Mehta: Merge pull request #67 from bd808/issue/62... [04:14:07] (03CR) 10Legoktm: "Can we base this on top of I170b78400385e147e84160018e6c03e507c35fe9 somehow? The position stuff added a ton of now un-needed code..." [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/249057 (owner: 10Krinkle) [04:15:40] wikimedia/composer-merge-plugin#132 (master - b98b9c3 Kunal Mehta): The build passed. - https://travis-ci.org/wikimedia/composer-merge-plugin/builds/87597942 [04:16:57] legoktm: Is https://gerrit.wikimedia.org/r/#/c/219855/1 ready to merge? [04:17:01] Looks good, I'd like to merge it [04:17:24] We need ot keep the modules separate, but sharing the class makes sense [04:17:27] Krinkle: yes, I haven't tested it since I wrote it, but nothing else in th repo has changed [04:17:47] (03CR) 10Krinkle: [C: 032] Get rid of subclassing for user and site modules [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/219855 (owner: 10Legoktm) [04:17:57] why do we still need separate modules? [04:20:25] (03Merged) 10jenkins-bot: Get rid of subclassing for user and site modules [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/219855 (owner: 10Legoktm) [04:20:27] (03Merged) 10jenkins-bot: Add help link to global JavaScript & CSS pages [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/230578 (https://phabricator.wikimedia.org/T108516) (owner: 10Legoktm) [04:20:55] Krinkle: https://gerrit.wikimedia.org/r/#/c/248927/ easy cr [04:21:47] 10GlobalCssJs, 5Patch-For-Review: Add page indicator with help link to [[Special:MyPage/global.js]] - https://phabricator.wikimedia.org/T108516#1756235 (10Legoktm) 5Open>3Resolved [04:26:12] [13composer-merge-plugin] 15bd808 opened pull request #79: Adjust logging of duplicate files (06master...06issue/66) 02https://github.com/wikimedia/composer-merge-plugin/pull/79 [04:28:36] (03CR) 10Legoktm: [C: 032] Improve DBReadOnlyError/DBExpectedError page title [core] - 10https://gerrit.wikimedia.org/r/248681 (owner: 10Aaron Schulz) [04:29:55] [13composer-merge-plugin] 15legoktm pushed 2 new commits to 06master: 02https://github.com/wikimedia/composer-merge-plugin/compare/b98b9c3a53b5...ab2235b27df0 [04:29:55] 13composer-merge-plugin/06master 1430b1414 15Bryan Davis: Adjust logging of duplicate files... [04:29:56] 13composer-merge-plugin/06master 14ab2235b 15Kunal Mehta: Merge pull request #79 from bd808/issue/66... [04:32:54] wikimedia/composer-merge-plugin#134 (master - ab2235b Kunal Mehta): The build passed. - https://travis-ci.org/wikimedia/composer-merge-plugin/builds/87599608 [04:35:25] (03PS1) 10EBernhardson: Styling tweaks for inline interwiki search [core] - 10https://gerrit.wikimedia.org/r/249064 (https://phabricator.wikimedia.org/T112349) [04:39:05] (03Merged) 10jenkins-bot: Improve DBReadOnlyError/DBExpectedError page title [core] - 10https://gerrit.wikimedia.org/r/248681 (owner: 10Aaron Schulz) [04:41:12] (03PS2) 10EBernhardson: Styling tweaks for inline interwiki search [core] - 10https://gerrit.wikimedia.org/r/249064 (https://phabricator.wikimedia.org/T112349) [04:43:42] (03PS2) 10Krinkle: Remove position default logic [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/249057 [04:45:29] (03PS4) 10Krinkle: registration: Support custom classes in "ResourceModules" schema [core] - 10https://gerrit.wikimedia.org/r/228753 (https://phabricator.wikimedia.org/T105236) (owner: 10Legoktm) [04:45:35] (03CR) 10Krinkle: [C: 032] registration: Support custom classes in "ResourceModules" schema [core] - 10https://gerrit.wikimedia.org/r/228753 (https://phabricator.wikimedia.org/T105236) (owner: 10Legoktm) [04:46:05] (03PS2) 10Krinkle: mediawiki.jqueryMsg: Remove 'astCache' [core] - 10https://gerrit.wikimedia.org/r/246940 (https://phabricator.wikimedia.org/T54042) (owner: 10Bartosz Dziewoński) [04:46:45] (03CR) 10Krinkle: [C: 032] mediawiki.jqueryMsg: Remove 'astCache' [core] - 10https://gerrit.wikimedia.org/r/246940 (https://phabricator.wikimedia.org/T54042) (owner: 10Bartosz Dziewoński) [04:47:09] (03PS3) 10Krinkle: mediawiki.jqueryMsg: Lazy-initialize parsers with getFailableParserFn() [core] - 10https://gerrit.wikimedia.org/r/246941 (https://phabricator.wikimedia.org/T115708) (owner: 10Bartosz Dziewoński) [04:47:18] legoktm: would be nice if wfBaseConvert was a library method [04:47:19] 10MediaWiki-Internationalization, 7Easy, 7JavaScript, 5Patch-For-Review, 7Technical-Debt: jqueryMsg uses the same astCache for all parser objects - https://phabricator.wikimedia.org/T54042#1756251 (10Krinkle) 5Open>3Resolved a:3Krinkle [04:48:36] AaronSchulz: so...create one? :) or are you hinting at me to do that? :P [04:48:47] mostly the later [04:49:18] then IP.php could mostly be moved to stuff in /libs (sans the two proxy methods) [04:49:36] which would let redisconnpool and two more bagostuff classes go to libs [04:51:08] (03PS3) 10EBernhardson: Styling tweaks for inline interwiki search [core] - 10https://gerrit.wikimedia.org/r/249064 (https://phabricator.wikimedia.org/T112349) [04:51:18] okay [04:51:57] AaronSchulz: Do you see us making bagostuff into a composer lib soon? What's blocking that currently? We can put the *CacheLRU.php classes in there as wlel eventhough they don't rely on objectcache strictly, it seems related enough to not warrant enother library [04:52:04] what's a more creative name than "base-convert"? [04:52:33] base-conversion ;) [04:52:44] Krinkle: until 2? days ago it didn't have the memcached classes, but I think it's pretty much ready now [04:52:46] not sure if much else can go in there [04:53:38] Afraid to ask but what's wrong with php's base_convert [04:54:01] only works for smallish numbers [04:54:19] not for turning a sha1 from one base to another [04:54:52] orly [04:54:57] * Krinkle does that in RL [04:55:18] https://github.com/wikimedia/mediawiki/blob/master/includes/resourceloader/ResourceLoader.php#L606-L612 [04:55:23] I guess not strictly. [04:55:28] It did that in an earlier version of the patch [04:55:30] but I optimised it [04:55:35] it seemed to work though [04:56:59] (03Merged) 10jenkins-bot: registration: Support custom classes in "ResourceModules" schema [core] - 10https://gerrit.wikimedia.org/r/228753 (https://phabricator.wikimedia.org/T105236) (owner: 10Legoktm) [04:57:03] (03Merged) 10jenkins-bot: mediawiki.jqueryMsg: Remove 'astCache' [core] - 10https://gerrit.wikimedia.org/r/246940 (https://phabricator.wikimedia.org/T54042) (owner: 10Bartosz Dziewoński) [04:57:29] AaronSchulz: Ah, floating point precision is the problem? [04:57:36] I didn't think sha1 numbers were *that* big? [04:59:02] ah yeah, it gets 00 padded [04:59:23] due to the ordering it worked for me as I only needed the first N characters [05:00:37] (03PS4) 10EBernhardson: Styling tweaks for inline interwiki search [core] - 10https://gerrit.wikimedia.org/r/249064 (https://phabricator.wikimedia.org/T112349) [05:02:21] BaseConvert/BaseConvert(...) is a bit lame. [05:02:30] better_base_convert()? in line with php naming :P [05:03:11] 10CirrusSearch, 6Discovery, 3Discovery-Cirrus-Sprint, 5MW-1.27-release-notes, and 4 others: Inform users what happened if their query is forwarded to another wiki because of language detection - https://phabricator.wikimedia.org/T112349#1756262 (10EBernhardson) With the patch above it now looks like this:... [05:06:25] (03PS5) 10EBernhardson: Styling tweaks for inline interwiki search [core] - 10https://gerrit.wikimedia.org/r/249064 (https://phabricator.wikimedia.org/T112349) [05:07:55] (03CR) 10EBernhardson: "can see the results of these styling changes on suggesty (which has full indices for enwiki, dewiki, itwiki and a partial ruwiki import)." [core] - 10https://gerrit.wikimedia.org/r/249064 (https://phabricator.wikimedia.org/T112349) (owner: 10EBernhardson) [05:08:08] hm, if it gets namespaced, then we can use "base_convert" [05:09:14] (03CR) 10Ori.livneh: [C: 032] "Heh @ +4, -95499" [extensions/SyntaxHighlight_Pygments] - 10https://gerrit.wikimedia.org/r/249058 (https://phabricator.wikimedia.org/T103614) (owner: 10Krinkle) [05:10:17] (03CR) 10Krinkle: [C: 032] mediawiki.jqueryMsg: Lazy-initialize parsers with getFailableParserFn() [core] - 10https://gerrit.wikimedia.org/r/246941 (https://phabricator.wikimedia.org/T115708) (owner: 10Bartosz Dziewoński) [05:13:43] https://www.mediawiki.org/wiki/Special:Code/MediaWiki/14777 [05:17:26] 6Discovery, 7Wikimedia-log-errors: Invalid value "submit-form" for enum property "action" (schema:Search) - https://phabricator.wikimedia.org/T116714#1756264 (10Krinkle) 3NEW [05:19:40] (03Merged) 10jenkins-bot: mediawiki.jqueryMsg: Lazy-initialize parsers with getFailableParserFn() [core] - 10https://gerrit.wikimedia.org/r/246941 (https://phabricator.wikimedia.org/T115708) (owner: 10Bartosz Dziewoński) [05:22:05] 6Discovery, 7Wikimedia-log-errors: Invalid value None for required property "timeOffsetSinceStart" (schema:Search) - https://phabricator.wikimedia.org/T116715#1756275 (10Krinkle) 3NEW [05:23:32] 6Design-Research, 5Design Research and product team collaboration: ios5 navigation guerrilla testing & mediawiki report - https://phabricator.wikimedia.org/T116716#1756281 (10dchen) 3NEW a:3dchen [05:39:30] 10MediaWiki-Search, 6Discovery, 5MW-1.27-release-notes, 5Patch-For-Review, and 2 others: BadMethodCallException from line 266 of /srv/mediawiki/php-1.27.0-wmf.2/includes/PrefixSearch.php: Call to a member function getPrefixedText() on a non-object (NULL) - https://phabricator.wikimedia.org/T116029#1756311 (... [05:44:50] (03CR) 10Ori.livneh: Initial commit (033 comments) [RunningStat] - 10https://gerrit.wikimedia.org/r/249013 (owner: 10Ori.livneh) [05:45:33] 10MediaWiki-ResourceLoader, 6Performance-Team: Revise the design of ResourceLoader's MessageBlobStore - https://phabricator.wikimedia.org/T113092#1756316 (10Krinkle) [05:46:42] 10MediaWiki-ResourceLoader, 6Performance-Team: Revise the design of ResourceLoader's MessageBlobStore - https://phabricator.wikimedia.org/T113092#1756323 (10Krinkle) a:3Krinkle [05:46:44] (03PS1) 10Ori.livneh: Small code clean-ups [RunningStat] - 10https://gerrit.wikimedia.org/r/249069 [05:47:31] (03CR) 10Ori.livneh: [C: 032] Small code clean-ups [RunningStat] - 10https://gerrit.wikimedia.org/r/249069 (owner: 10Ori.livneh) [05:47:48] (03Merged) 10jenkins-bot: Small code clean-ups [RunningStat] - 10https://gerrit.wikimedia.org/r/249069 (owner: 10Ori.livneh) [05:56:36] (03CR) 10Krinkle: [V: 032] Archive repository [extensions/SyntaxHighlight_Pygments] - 10https://gerrit.wikimedia.org/r/249058 (https://phabricator.wikimedia.org/T103614) (owner: 10Krinkle) [05:57:38] Krinkle: https://gerrit.wikimedia.org/r/#/c/249053/ [05:59:05] Those transitions are for enabling focus/disable/error/validated etc. states interatively. transitions seems appropiate there. I gather they are triggering on-load? [05:59:15] That probably warrants moving rather than removing. [05:59:40] I wouldn't know where to though, will defer to OOUI maintainers. I'd rather not remove them without their input. [06:01:29] (03CR) 10Krinkle: "@Krenair, @MatmaRex: I suspect these are needed to transition state changes to focus and error states. It seems however that they are also" [core] - 10https://gerrit.wikimedia.org/r/249053 (owner: 10Ori.livneh) [06:03:25] 10Wikimedia-Stream: RCStream: Investigate source of invalid JSON data - https://phabricator.wikimedia.org/T116721#1756340 (10Krinkle) 3NEW [06:03:35] (03CR) 10Krinkle: "Filed as T116721" [services/rcstream] - 10https://gerrit.wikimedia.org/r/214789 (owner: 10Ori.livneh) [06:05:19] Krinkle: hey, good morning. Andy sent you a comment yesterday concerning the bug i was working on and i submitted a patch https://gerrit.wikimedia.org/r/#/c/247990/ [06:05:45] Krinkle: i will like you to look at it and review please :) [06:09:03] (03CR) 10Krinkle: "Also remove from extensions:" [core] - 10https://gerrit.wikimedia.org/r/244407 (owner: 10Aaron Schulz) [06:09:32] 10Dumps-Generation, 7HHVM, 5Patch-For-Review, 7Upstream: HHVM does not recognize compress.bzip2 streams - https://phabricator.wikimedia.org/T113932#1756348 (10ArielGlenn) ori, you said in irc that the new package would be available on the snapshots last night, but I don't see it, or at least, if the new pa... [06:10:06] 10Dumps-Generation, 7HHVM, 5Patch-For-Review, 7Upstream: HHVM does not recognize compress.bzip2 streams - https://phabricator.wikimedia.org/T113932#1756349 (10ori) >>! In T113932#1756348, @ArielGlenn wrote: > ori, you said in irc that the new package would be available on the snapshots last night, but I do... [06:13:39] spagewmf: concerning this https://phabricator.wikimedia.org/T116690 [06:13:52] are the files many? [06:18:05] spagewmf: or are we dealing with the doc folder here in the codebase? [06:19:03] 10MediaWiki-Documentation, 7Documentation, 7Easy: Give text files in Git correct extensions - https://phabricator.wikimedia.org/T116690#1756355 (10Bawolff) Its traditional in unix land that certain files have names without extensions, like README and COPYING. Seems like the real bug here is that doxygen isn... [06:20:37] 10CirrusSearch, 6Discovery, 3Discovery-Cirrus-Sprint, 5MW-1.27-release-notes, and 4 others: Inform users what happened if their query is forwarded to another wiki because of language detection - https://phabricator.wikimedia.org/T112349#1756356 (10Smalyshev) The search above however does not show alternati... [06:22:11] 10MediaWiki-DjVu, 10Wikimedia-Media-storage: Some DjVu files not being rendered in commons (showing up as "0 × 0 pixels", despite the file size in MB being nonzero) - https://phabricator.wikimedia.org/T107664#1756357 (10Bawolff) >>! In T107664#1755984, @Vladis13 wrote: >>>! In T107664#1755581, @Bawolff wrote:... [06:22:27] (03CR) 10Krinkle: [C: 031] "The RL handling seems fine. Though I'm suspicious about CSS selectors" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/246148 (https://phabricator.wikimedia.org/T49673) (owner: 10Tim Starling) [06:23:54] r054l13: I'll check tomorrow morning. I'm signing off now. [06:23:56] Thanks :) [06:24:35] 10MediaWiki-Documentation, 7Documentation, 7Easy: Give text files in Git correct extensions - https://phabricator.wikimedia.org/T116690#1756358 (10rosalieper) @Bawolff, are we taking care of the doc/ folder here or we are looking at files in the whole MediaWiki code base. I understand what is required and al... [06:25:05] r054l13: I have no idea, you'd have to ask spagewmf [06:25:08] Krinkle: ok, have a nice day :) [06:25:29] r054l13: But it should be noted that Makefile is not a text file (Makefile is a "scripting" language for the make program) [06:25:38] bawolff: ok, no problem, it seems spagewmf is kind of busy, so he will surely reply later :) [06:25:42] or not a plain text file, I guess I should say [06:26:04] [23:33] === spagewmf: idle for 3 days, 11 hours, 1 minute, 53 seconds [06:26:17] bawolff: oohh, thats true, for Makefile, that is correct :) [06:26:25] yeah, definitely probably not online right now [06:26:55] wow, he will surely see it anytime he is available [06:27:10] I think S is in the San Francisco office (Not 100% sure), so he's more likely to be online during working hours in san fran [06:27:52] 10MediaWiki-extensions-CentralNotice, 7I18n: Add option (disabled by default) to force untranslated centralnotices - https://phabricator.wikimedia.org/T96552#1756359 (10awight) These are very convincing cases, but by this logic wouldn't you say that all campaigns are important enough to be displayed before the... [06:31:15] bawolff: ok no problem :) [06:31:23] 10MobileFrontend: Very long talk pages unreadable - https://phabricator.wikimedia.org/T116686#1756360 (10Florian) You mean like a messenger app does it? Would make sense, but let me test, how it looks :) [06:32:00] (03CR) 10DanReyLop: Fix saved pages with spaces in their title not being recognized as saved (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/248917 (https://phabricator.wikimedia.org/T108885) (owner: 10DanReyLop) [06:32:10] 10CirrusSearch, 6Discovery, 3Discovery-Cirrus-Sprint, 5MW-1.27-release-notes, and 4 others: Inform users what happened if their query is forwarded to another wiki because of language detection - https://phabricator.wikimedia.org/T112349#1756361 (10EBernhardson) no thats not intentional, it worked the first... [06:32:25] (03PS2) 10DanReyLop: Fix saved pages with spaces in their title not being recognized as saved [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/248917 (https://phabricator.wikimedia.org/T108885) [06:33:21] 10CirrusSearch, 6Discovery, 3Discovery-Cirrus-Sprint, 5MW-1.27-release-notes, and 4 others: Inform users what happened if their query is forwarded to another wiki because of language detection - https://phabricator.wikimedia.org/T112349#1756362 (10EBernhardson) doh, the reason is because thats an actual pa... [06:33:47] 10CirrusSearch, 6Discovery, 3Discovery-Cirrus-Sprint, 5MW-1.27-release-notes, and 4 others: Inform users what happened if their query is forwarded to another wiki because of language detection - https://phabricator.wikimedia.org/T112349#1756363 (10EBernhardson) http://suggesty.wmflabs.org/w/index.php?title... [06:36:03] (03PS3) 10DanReyLop: Fix saved pages with spaces in their title not being recognized as saved [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/248917 (https://phabricator.wikimedia.org/T108885) [06:41:35] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Wikimedia-Fundraising, 3Fundraising Sprint Vengaboys: Announce new banner diet feature - https://phabricator.wikimedia.org/T115783#1756366 (10awight) 5Open>3Resolved [06:43:17] (03CR) 10Yaron Koren: [C: 032] "This is great, thank you!" [extensions/DataTransfer] - 10https://gerrit.wikimedia.org/r/248280 (https://phabricator.wikimedia.org/T101490) (owner: 10Samwilson) [06:43:37] (03Merged) 10jenkins-bot: Add support for Composer [extensions/DataTransfer] - 10https://gerrit.wikimedia.org/r/248280 (https://phabricator.wikimedia.org/T101490) (owner: 10Samwilson) [06:52:00] tonythomas: good morning :) [06:55:29] 5Patch-For-Review, 3Wikipedia-Android-App: Create APKs with app_name, variant, flavour and version in the filename. Example: Wikipedia App-prod-release-132.apk - https://phabricator.wikimedia.org/T116540#1756372 (10Wikinaut) I can simply left out the version numbers in the filename, so that the resulting names... [06:57:15] 10Dumps-Generation, 7HHVM, 5Patch-For-Review, 7Upstream: HHVM does not recognize compress.bzip2 streams - https://phabricator.wikimedia.org/T113932#1756373 (10ori) I am stuck on this error: ``` /home/ori/build-old/hhvm-3.6.5+dfsg1/hphp/runtime/vm/jit/type.cpp: In member function ‘std::string HPHP::jit::Ty... [06:59:46] (03PS8) 10VolkerE: Add `