[00:07:52] (03CR) 10Ori.livneh: "Should this check even exists? If I remember correctly, Psr\Log\LoggerInterface was the first (or one of the first) external libraries to " (031 comment) [core] - 10https://gerrit.wikimedia.org/r/248650 (https://phabricator.wikimedia.org/T115729) (owner: 10BryanDavis) [00:10:38] (03CR) 10Niedzielski: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/248656 (owner: 10Niedzielski) [00:12:44] 10MediaWiki-extensions-OAuth: mwoauth-oauth-exception - https://phabricator.wikimedia.org/T116505#1751211 (10Tgr) 3NEW [00:13:16] (03CR) 10Krinkle: Protect WAN cache sets() against uncommitted data (031 comment) [core] - 10https://gerrit.wikimedia.org/r/247784 (owner: 10Aaron Schulz) [00:13:34] (03PS2) 10Ori.livneh: ObjectFactory: avoid using ReflectionClass [core] - 10https://gerrit.wikimedia.org/r/248636 (https://phabricator.wikimedia.org/T115729) (owner: 10BryanDavis) [00:14:00] (03CR) 10Ori.livneh: [C: 032] "Hahaha. This is awesome. Cf https://github.com/groovy/groovy-core/blob/master/src/main/org/codehaus/groovy/runtime/ArrayUtil.java" [core] - 10https://gerrit.wikimedia.org/r/248636 (https://phabricator.wikimedia.org/T115729) (owner: 10BryanDavis) [00:16:10] (03CR) 10Krinkle: Keep stats on slow function calls (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/248657 (owner: 10Ori.livneh) [00:16:39] (03CR) 10Aaron Schulz: Protect WAN cache sets() against uncommitted data (031 comment) [core] - 10https://gerrit.wikimedia.org/r/247784 (owner: 10Aaron Schulz) [00:16:52] (03CR) 10BryanDavis: "It was the first and there was great wailing and gnashing of teeth by a couple of people when they updated their git clones and got a bank" [core] - 10https://gerrit.wikimedia.org/r/248650 (https://phabricator.wikimedia.org/T115729) (owner: 10BryanDavis) [00:18:19] (03CR) 10Krinkle: Protect WAN cache sets() against uncommitted data (031 comment) [core] - 10https://gerrit.wikimedia.org/r/247784 (owner: 10Aaron Schulz) [00:20:06] (03CR) 10Aaron Schulz: [C: 031] Keep stats on slow function calls [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/248657 (owner: 10Ori.livneh) [00:21:43] (03PS7) 10Aaron Schulz: Protect WAN cache sets() against uncommitted data [core] - 10https://gerrit.wikimedia.org/r/247784 [00:21:48] 10MediaWiki-extensions-ProofreadPage, 10Wikimedia-Site-Requests, 6Wikisource, 5Patch-For-Review, and 2 others: Add Index and Page namespaces to $wgContentNamespaces - https://phabricator.wikimedia.org/T54709#1751218 (10GOIII) >>! In T54709#1744951, @Billinghurst wrote: > Disagree. Both are permanent pages... [00:23:42] (03Merged) 10jenkins-bot: ObjectFactory: avoid using ReflectionClass [core] - 10https://gerrit.wikimedia.org/r/248636 (https://phabricator.wikimedia.org/T115729) (owner: 10BryanDavis) [00:27:01] 6Repository-Ownership-Requests: Requesting access to gerrit group mediawiki for jzerebecki - https://phabricator.wikimedia.org/T116506#1751221 (10JanZerebecki) 3NEW [00:27:54] (03CR) 10Gergő Tisza: "IMO this is like BIOS beep codes. If you are unable to load a class, you log an exception. If you are unable to load the logging system..." [core] - 10https://gerrit.wikimedia.org/r/248650 (https://phabricator.wikimedia.org/T115729) (owner: 10BryanDavis) [00:40:55] (03PS1) 10Gergő Tisza: Include error details in JSON error response [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/248658 (https://phabricator.wikimedia.org/T116505) [00:53:59] (03PS1) 10Gergő Tisza: Return HTTP 400 on errors [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/248660 (https://phabricator.wikimedia.org/T116505) [01:06:08] 10MediaWiki-Vagrant: Anonymous MW-Vagrant usage statistics - https://phabricator.wikimedia.org/T91682#1751241 (10Tgr) [01:06:36] 10MediaWiki-Installer, 6MediaWiki-Stakeholders-Group, 5MW-1.26-release: Provide an opt-in ability to register the user's MediaWiki installation - https://phabricator.wikimedia.org/T56425#584071 (10Tgr) [01:09:48] 10MediaWiki-Vagrant: MediaWiki-Vagrant guest OS clock gets out of sync - https://phabricator.wikimedia.org/T116507#1751249 (10Tgr) 3NEW [01:51:15] 6Phabricator, 6Labs, 7Puppet: phabricator puppet at labs broken - https://phabricator.wikimedia.org/T116442#1751263 (10zhuyifei1999) >>! In T116442#1751011, @Negative24 wrote: > `role::phabricator::main` isn't the right Puppet class to use in Labs. I'm pretty sure the error had to do with the site variables.... [01:55:42] 10MediaWiki-API, 6Analytics-Backlog, 6Developer-Relations, 6Reading-Admin, and 5 others: Metrics about the use of the Wikimedia web APIs - https://phabricator.wikimedia.org/T102079#1751264 (10Spage) >>! In T102079#1713841, @Nuria wrote: > If you are thinking http errors the data is present right now on web... [02:27:25] 6Phabricator, 6Labs, 7Puppet: phabricator puppet at labs broken - https://phabricator.wikimedia.org/T116442#1751267 (10Negative24) Its not documented. But its not hard. Essentially its just: 1. Apply `role::phabricator::labs` and run puppet 2. `cd /srv/phab/phabricator` and run `sudo bin/storage upgrade` 3.... [02:46:10] (03PS2) 10Ori.livneh: Keep stats on slow function calls [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/248657 [03:20:33] (03PS1) 10Gergő Tisza: Move mwoauth-php lib to Composer, add standard Composer tests [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/248661 [03:20:35] (03PS1) 10Gergő Tisza: Allow setting a custom callback URL [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/248662 [03:24:06] 10Wikimedia-Video: Batch video upload tracking bug - https://phabricator.wikimedia.org/T116510#1751286 (10brion) 3NEW [03:25:10] 10MediaWiki-extensions-TimedMediaHandler, 6Commons, 10Internet-Archive: Commons uploads: Support automatic conversion of video formats to free formats - https://phabricator.wikimedia.org/T45150#1751296 (10brion) [03:25:12] 10Wikimedia-Video: Batch video upload tracking bug - https://phabricator.wikimedia.org/T116510#1751293 (10brion) [03:29:08] (03PS2) 10Gergő Tisza: Move mwoauth-php lib to Composer, add standard Composer tests [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/248661 [03:31:03] (03CR) 10Gergő Tisza: "The tests pass locally; looks like Jenkins does not pull in the composer dependencies?" [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/248661 (owner: 10Gergő Tisza) [03:38:12] (03PS1) 10Gergő Tisza: Vagrant role for OAuthAuthentication [vagrant] - 10https://gerrit.wikimedia.org/r/248664 [03:40:59] (03PS1) 10Gergő Tisza: Allow HTTPS port to be configurable [vagrant] - 10https://gerrit.wikimedia.org/r/248665 [03:41:01] (03CR) 10jenkins-bot: [V: 04-1] Allow HTTPS port to be configurable [vagrant] - 10https://gerrit.wikimedia.org/r/248665 (owner: 10Gergő Tisza) [03:55:22] (03PS2) 10Gergő Tisza: Allow HTTPS port to be configurable [vagrant] - 10https://gerrit.wikimedia.org/r/248665 [03:57:12] 10MediaWiki-Codesniffer, 5Patch-For-Review: Add sniff for "if/while ( $a = foo() )" constructs in phpcs - https://phabricator.wikimedia.org/T92744#1751307 (10TasneemLo) @Physikerwelt I think these might be more appropriate and easy to read : ``` $line = fgetcsv( $csv_file ); if ( $line === NULL ) { // th... [04:00:03] (03PS1) 10Aaron Schulz: Measure commitMasterChanges() run time [core] - 10https://gerrit.wikimedia.org/r/248666 [04:00:43] 6Repository-Ownership-Requests: Requesting access to gerrit group mediawiki for jzerebecki - https://phabricator.wikimedia.org/T116506#1751309 (10Krenair) 'hoo said so' isn't a great reason to request this sort of access... are you actively contributing to MediaWiki outside of the Wikidata extensions? [04:10:13] (03PS2) 10Gergő Tisza: Vagrant role for OAuthAuthentication [vagrant] - 10https://gerrit.wikimedia.org/r/248664 [04:25:25] (03CR) 10jenkins-bot: [V: 04-1] Allow HTTPS port to be configurable [vagrant] - 10https://gerrit.wikimedia.org/r/248665 (owner: 10Gergő Tisza) [04:51:29] (03CR) 10Gergő Tisza: "recheck" [vagrant] - 10https://gerrit.wikimedia.org/r/248665 (owner: 10Gergő Tisza) [05:18:18] 10MediaWiki-extensions-UrlShortener: Special:UrlRedirector error message doesn't display properly due to relative paths/url rewrites - https://phabricator.wikimedia.org/T116512#1751312 (10Legoktm) 3NEW [05:20:23] 7Design, 10MediaWiki-extensions-ContentTranslation, 7WorkType-NewFunctionality: Provide help link on Special:ContentTranslation - https://phabricator.wikimedia.org/T70996#1751319 (10Amire80) [05:20:27] 10MediaWiki-extensions-ContentTranslation, 7WorkType-NewFunctionality: Indicate which source languages have Machine Translation enabled - https://phabricator.wikimedia.org/T105334#1751320 (10Amire80) [05:23:56] 10MediaWiki-extensions-ContentTranslation, 7WorkType-NewFunctionality: Explore usefulness of yalign, a sentence aligner for comparable corpora - https://phabricator.wikimedia.org/T67669#1751321 (10Amire80) [05:24:34] 10MediaWiki-extensions-ContentTranslation, 7WorkType-NewFunctionality: Better anticipate the options when translating an existing article - https://phabricator.wikimedia.org/T105278#1751322 (10Amire80) [05:24:42] 10MediaWiki-extensions-ContentTranslation, 7WorkType-NewFunctionality: Make finding articles to translate be more flexible (accepting URL and more) - https://phabricator.wikimedia.org/T105130#1751323 (10Amire80) [05:27:45] 10MediaWiki-extensions-ContentTranslation, 7WorkType-Maintenance: Give feedback link hides below tools if there is no space - https://phabricator.wikimedia.org/T104127#1751324 (10Amire80) [05:27:59] 10MediaWiki-extensions-ContentTranslation, 7I18n, 7WorkType-Maintenance: Make ContentTranslation less Wikipedia-centric - https://phabricator.wikimedia.org/T105587#1751325 (10Amire80) [05:28:05] 10MediaWiki-extensions-ContentTranslation, 7I18n, 7WorkType-Maintenance: add lang and dir attributes to the title in cx-translation-target-page-exists - https://phabricator.wikimedia.org/T105586#1751326 (10Amire80) [05:28:10] 10MediaWiki-extensions-ContentTranslation, 7WorkType-Maintenance: Fix issues found during Wikimania 2015 Hackathon and Workshops - https://phabricator.wikimedia.org/T105923#1751327 (10Amire80) [05:28:21] 10MediaWiki-extensions-ContentTranslation, 7Technical-Debt, 7WorkType-Maintenance: Update categories unit tests to use fake server instead of real Wikipedia API - https://phabricator.wikimedia.org/T88162#1751328 (10Amire80) [05:28:28] 7Design, 10MediaWiki-extensions-ContentTranslation, 7WorkType-NewFunctionality: Designs for translation of partial articles using ContentTranslation - https://phabricator.wikimedia.org/T90164#1751329 (10Amire80) [05:28:31] 10MediaWiki-extensions-ContentTranslation, 7WorkType-NewFunctionality: Use article title when adapting links for languages without MT - https://phabricator.wikimedia.org/T106428#1751330 (10Amire80) [05:28:36] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Analytics, 7WorkType-NewFunctionality: Measure the number of problematic abandoned translations - https://phabricator.wikimedia.org/T106695#1751331 (10Amire80) [05:28:40] 7Design, 10MediaWiki-extensions-ContentTranslation, 7WorkType-Maintenance: There is no comfortable way to move to the next paragraph in Special:ContentTranslation using the keyboard - https://phabricator.wikimedia.org/T109056#1751332 (10Amire80) [05:30:32] (03CR) 10Legoktm: "Last I checked, if you have no libraries at all, you'll hit MediaWiki/suppressWarnings() being undefined in Setup.php before the Psr/Log o" [core] - 10https://gerrit.wikimedia.org/r/248650 (https://phabricator.wikimedia.org/T115729) (owner: 10BryanDavis) [05:31:46] 10MediaWiki-Special-pages, 7Composer, 7Easy: Use /vendor/composer/installed.json for Special:Version & API about installed libraries instead of composer.lock - https://phabricator.wikimedia.org/T106247#1751334 (10Legoktm) [05:32:23] 10MediaWiki-Special-pages, 7Composer, 7Easy: Use /vendor/composer/installed.json for Special:Version & API about installed libraries instead of composer.lock - https://phabricator.wikimedia.org/T106247#1462876 (10Legoktm) Investigated this, we should use installed.json since it's more likely to be correct an... [05:34:02] 10MediaWiki-Special-pages, 7Composer, 7Easy: Use /vendor/composer/installed.json for Special:Version & API about installed libraries instead of composer.lock - https://phabricator.wikimedia.org/T106247#1751339 (10rosalieper) can i do this? [05:35:40] legoktm: can i work on this bug? https://phabricator.wikimedia.org/T106247 [05:37:53] 10MediaWiki-Special-pages, 7Composer, 7Easy: Use /vendor/composer/installed.json for Special:Version & API about installed libraries instead of composer.lock - https://phabricator.wikimedia.org/T106247#1751341 (1001tonythomas) >>! In T106247#1751339, @rosalieper wrote: > can i do this? You can work on any b... [05:38:16] 10Wikimedia-Video: Batch video upload tracking bug - https://phabricator.wikimedia.org/T116510#1751350 (10brion) [05:39:52] 10MediaWiki-Special-pages, 7Composer, 7Easy: Use /vendor/composer/installed.json for Special:Version & API about installed libraries instead of composer.lock - https://phabricator.wikimedia.org/T106247#1751352 (10rosalieper) a:3rosalieper [05:42:54] legoktm: any more thoughts on https://gerrit.wikimedia.org/r/#/c/243089/ ? [05:43:03] 10MediaWiki-Database, 7Easy, 7I18n: Improve MediaWiki:Dberrortext to link to a config-defined status page - https://phabricator.wikimedia.org/T2398#1751353 (10Liuxinyu970226) [05:43:08] 10MediaWiki-Special-pages, 7I18n: User list includes MediaWiki:Viewprevnext without rendering markup. - https://phabricator.wikimedia.org/T13454#1751354 (10Liuxinyu970226) [05:43:18] 10MediaWiki-extensions-GlobalBlocking, 7I18n: Log entries use bad grammar - https://phabricator.wikimedia.org/T17259#1751357 (10Liuxinyu970226) [05:43:25] 10MediaWiki-Interface: Split newarticletext to a separate message shown on empty IP talk pages - https://phabricator.wikimedia.org/T11128#1751358 (10Liuxinyu970226) [05:44:44] 10MediaWiki-Interface, 7I18n: Clean text in MediaWiki:Deletereason-dropdown before creating a select box from them. - https://phabricator.wikimedia.org/T16107#1751360 (10Liuxinyu970226) [05:45:27] legoktm: last brad said was "AaronSchulz: 7/10 seems like it's probably ok, reliably hitting a lag of 7-9 seems like it could be reasonably difficult." [05:49:56] lemme take a look again [05:54:36] r054l13: yes, of course [05:55:50] AaronSchulz: is there a reason the response sent back to the client is different? I'd assume most bots already handle maxlag errors properly with backoffs + retries, if the response was the same no new code would have to be written...unless we want them to have a different behavior? [05:56:12] it's basically just the read-only error with a different message [05:56:39] it used to be based on maxlag, but brad didn't like that since some bots might not expect that (sort of the opposite of what you are saying) [05:56:50] I think it makes sense to use the read-only error that bots can already get now [05:56:51] heh [05:57:04] e.g. due to admin reasons or lagged slaves [05:57:21] well maxlag bots would never see the lagged slaves readonly :) [05:57:53] legoktm: i am also seeing this line of code [05:58:06] $path = "$IP/vendor/composer.lock"; [05:58:14] in both API and Special:Version [05:58:19] should it also be changed? [05:58:24] yes [05:58:29] ok [05:59:06] legoktm: yes they would [05:59:11] the readonly check is first ;) [05:59:19] ahh [05:59:20] also there is dba read-only mode too [05:59:27] even if there is no lag [05:59:58] has that been used on the cluster recently? [06:00:02] legoktm: done, will submit a patch soon :) [06:00:24] (I use it all the time when upgrading wikis) [06:01:38] hmm [06:01:45] looks like pywikibot totally dies if the db is readonly [06:02:04] 10Wikimedia-Video: 1gb file upload limit is too restrictive for conference presentation videos - https://phabricator.wikimedia.org/T116514#1751367 (10brion) 3NEW [06:02:15] we get >10sec spikes a few times every day, so it must be happening [06:02:17] 10Wikimedia-Video: 1gb file upload limit is too restrictive for conference presentation videos - https://phabricator.wikimedia.org/T116514#1751375 (10brion) [06:02:18] 10Wikimedia-Video: Batch video upload tracking bug - https://phabricator.wikimedia.org/T116510#1751374 (10brion) [06:04:50] 6Phabricator: Enable embedding of media from Wikimedia Commons - https://phabricator.wikimedia.org/T116515#1751376 (10Tbayer) 3NEW [06:09:42] 3Outreachy-Round-11: Outreach Proposal for T15303: Implement HTML e-mail support in MediaWiki - https://phabricator.wikimedia.org/T116223#1751385 (10rosalieper) [06:12:25] AaronSchulz: have you read my proposal? [06:12:34] legoktm: and you too, have you taken a look at it? [06:17:12] AaronSchulz: do you have an estimate of how often bots are going to run into the new readonly errors? (how often does lag go that high?) [06:18:03] r054l13: don't think so [06:18:39] legoktm: https://tendril.wikimedia.org/host/view/db1072.eqiad.wmnet/3306 [06:20:02] so twice in the last 12hr (one of those would happen now anyway due to the 10 limit) [06:21:56] of course there are lots of lag fixes in master so who knows what the rate will be next cycle [06:24:28] AaronSchulz: this is the link to it, please comments are welcomed :) [06:24:28] AaronSchulz: https://phabricator.wikimedia.org/T116223 [06:25:09] (03PS1) 10Rosalieper: Absolute file paths changed [core] - 10https://gerrit.wikimedia.org/r/248667 (https://phabricator.wikimedia.org/T106247) [06:25:49] (03CR) 10Legoktm: [C: 031] "LGTM, I think this probably warrants a mediawiki-api-announce email." [core] - 10https://gerrit.wikimedia.org/r/243089 (https://phabricator.wikimedia.org/T95501) (owner: 10Aaron Schulz) [06:27:22] * legoktm filed a bug to make sure pywikibot is updated [06:28:06] legoktm: i submitted the patch, you are up to review :) [06:28:10] 3Outreachy-Round-11: Outreach Proposal for T15303: Implement HTML e-mail support in MediaWiki - https://phabricator.wikimedia.org/T116223#1751406 (10rosalieper) [06:29:38] legoktm: is the pywikibot for me to update? [06:29:46] no [06:30:23] r054l13: have you tested this? [06:30:28] legoktm: ok, i thought it was for me :) [06:30:38] but i submitted a patch though, review it please [06:31:17] I'm asking if you tested the patch to make sure it works [06:32:35] legoktm: how do i do that? [06:32:39] legoktm: i don't think so, i have not [06:32:43] legoktm: but you can test if for me please :) [06:38:50] r054l13: I would recommend using https://www.mediawiki.org/wiki/MediaWiki-Vagrant to install MediaWiki and test your patch. [06:39:17] r054l13: I can already spot what's wrong with your patch, but I think it will be more valuable for you to figure that out on your own [06:44:47] ok [06:44:48] but legoktm, can i test locally? [06:44:56] yes [06:45:02] do you have mediawiki installed locally? [06:45:11] yes i have that [06:45:29] i have gone to the Special:Versions page :) [06:45:40] Special:Version [06:46:09] it is working, i have tested [06:46:39] (03PS1) 10Aaron Schulz: Add ?idempotent=1 flag for API modules [core] - 10https://gerrit.wikimedia.org/r/248668 (https://phabricator.wikimedia.org/T91820) [06:47:20] legoktm: is there someone who usually writes those? [06:47:41] AaronSchulz: anomie :P [06:47:49] I can probably do it if he doesn't want to [06:48:02] legoktm: is that procedure or him just being the only making api changes? ;) [06:48:12] (03PS1) 10Legoktm: build: Configure banana-checker and jsonlint [extensions/ShortUrl] - 10https://gerrit.wikimedia.org/r/248669 [06:48:14] (03CR) 10Legoktm: "check experimental" [extensions/ShortUrl] - 10https://gerrit.wikimedia.org/r/248669 (owner: 10Legoktm) [06:48:16] * AaronSchulz probably isn't even subscribed, heh [06:48:30] the latter lol [06:48:37] legoktm: i got some errors [06:48:41] legoktm: checking now [06:48:55] r054l13: great :) [06:49:59] legoktm: another scary patch for you https://gerrit.wikimedia.org/r/#/c/248642/ ;) [06:50:45] (03CR) 10jenkins-bot: [V: 04-1] Add ?idempotent=1 flag for API modules [core] - 10https://gerrit.wikimedia.org/r/248668 (https://phabricator.wikimedia.org/T91820) (owner: 10Aaron Schulz) [06:51:04] (03CR) 10Legoktm: [C: 032] "We should make all of these links HTTPS since Wikimedia wikis are HTTPS-only now, but consistency is fine for now" [core] - 10https://gerrit.wikimedia.org/r/248568 (https://phabricator.wikimedia.org/T85327) (owner: 10saper) [06:52:41] AaronSchulz: sounds like people clearing their 10k watchlists >.> [06:53:32] legoktm: do i have to modify the installed.json file? [06:53:32] the structure is different from composer.lock [06:54:23] r054l13: no, you need to modify the code that reads it. the installed.json file is generated by another program [06:55:30] legoktm: yeah, but in composer.lock, there is key in the json array called packages, but in installed.json, there is nothing like that [06:56:51] legoktm: "+channel:DBPerformance +message:/writeQueryTime/ -url:*RunJobs* +wiki:enwiki" for last 24 most shows ~1sec events [06:57:20] a few undeletes and Special:EditWatchlist sprinkled in [06:58:23] (03PS2) 10Aaron Schulz: Add ?idempotent=1 flag for API modules [core] - 10https://gerrit.wikimedia.org/r/248668 (https://phabricator.wikimedia.org/T91820) [06:58:24] legoktm: i fixed it :) [06:58:28] its perfect now :) [06:58:28] let me submit a patch [07:00:06] (03CR) 10Legoktm: [C: 032] Remove paranoid title check from RefreshLinksJob::runForTitle [core] - 10https://gerrit.wikimedia.org/r/248595 (owner: 10Aaron Schulz) [07:00:25] 4(no projects): Add elseif to SpaceAfterControlStructureSniff - https://phabricator.wikimedia.org/T116518#1751409 (10TasneemLo) 3NEW [07:00:35] 10MediaWiki-Codesniffer: Add elseif to SpaceAfterControlStructureSniff - https://phabricator.wikimedia.org/T116518#1751415 (10TasneemLo) [07:00:36] (03PS2) 10Rosalieper: Absolute file paths changed [core] - 10https://gerrit.wikimedia.org/r/248667 (https://phabricator.wikimedia.org/T106247) [07:01:15] legoktm: wow, its perfect. I can see the beauty of using installed.json rather than composer.lock. installed.json is even much cleaner :) [07:01:29] 10MediaWiki-Codesniffer: Add elseif to SpaceAfterControlStructureSniff - https://phabricator.wikimedia.org/T116518#1751409 (10TasneemLo) [07:02:07] (03Merged) 10jenkins-bot: Install link to Manual:Combating_spam on the home page [core] - 10https://gerrit.wikimedia.org/r/248568 (https://phabricator.wikimedia.org/T85327) (owner: 10saper) [07:04:20] 10MediaWiki-Vendor, 7Composer: phpcs doesn't work with mediawiki/vendor repo, while phpunit fails with composer-managed vendor. - https://phabricator.wikimedia.org/T115032#1751419 (10Legoktm) > $ phpcs This isn't from mediawiki/vendor, it's probably from a system package. [07:05:07] 10MediaWiki-General-or-Unknown, 10MediaWiki-Installer, 5Patch-For-Review: Link to anti-spam measures from the default mainpage - https://phabricator.wikimedia.org/T85327#1751420 (10Legoktm) I'm guessing you want to backport this to REL1_26? [07:06:12] legoktm: you are up, check it out, do you see anything wrong with the patch again? :) [07:09:20] I like how win10 backups lockup IDEA so badly [07:09:37] r054l13: I'm reviewing some other patches right now, I'll come back to it [07:09:41] AaronSchulz: #windozeproblems [07:10:53] legoktm: ok [07:12:28] (03PS1) 10Legoktm: Add missing @metadata block to aeb-arab.json [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/248670 [07:12:30] (03PS1) 10Legoktm: build: Configure banana-checker and jsonlint [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/248671 [07:12:32] (03CR) 10Legoktm: "check experimental" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/248671 (owner: 10Legoktm) [07:12:44] (03Merged) 10jenkins-bot: Remove paranoid title check from RefreshLinksJob::runForTitle [core] - 10https://gerrit.wikimedia.org/r/248595 (owner: 10Aaron Schulz) [07:13:05] (03PS1) 10Legoktm: build: Configure banana-checker and jsonlint [extensions/Listings] - 10https://gerrit.wikimedia.org/r/248672 [07:13:07] (03CR) 10Legoktm: "check experimental" [extensions/Listings] - 10https://gerrit.wikimedia.org/r/248672 (owner: 10Legoktm) [07:14:50] (03PS1) 10Legoktm: build: Configure banana-checker and jsonlint [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/248673 [07:14:53] (03CR) 10Legoktm: "check experimental" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/248673 (owner: 10Legoktm) [07:15:18] (03PS1) 10Legoktm: build: Configure banana-checker and jsonlint [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/248674 [07:15:20] (03CR) 10Legoktm: "check experimental" [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/248674 (owner: 10Legoktm) [07:15:40] (03PS1) 10Legoktm: build: Configure banana-checker and jsonlint [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/248675 [07:15:42] (03CR) 10Legoktm: "check experimental" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/248675 (owner: 10Legoktm) [07:42:25] (03PS1) 10Aaron Schulz: Check if the DB is read-only in petitionSubmit() [extensions/Petition] - 10https://gerrit.wikimedia.org/r/248676 [07:56:31] 4(no projects): SpaceyParanthesis bug - https://phabricator.wikimedia.org/T116519#1751426 (10TasneemLo) 3NEW [08:01:07] 10MediaWiki-General-or-Unknown, 10VisualEditor: In th Web visual editor, update the refs - https://phabricator.wikimedia.org/T116520#1751433 (10Nnemo) 3NEW [08:02:08] 10MediaWiki-General-or-Unknown, 10VisualEditor: In the Web visual editor, update the refs - https://phabricator.wikimedia.org/T116520#1751441 (10Nnemo) [08:29:33] 10MediaWiki-Internationalization: Let translations add username to Special:Contributions *title* - https://phabricator.wikimedia.org/T51043#1751455 (10Liuxinyu970226) [08:29:49] 10MediaWiki-Internationalization: Update plural data to CLDR version 26 - https://phabricator.wikimedia.org/T64861#1751457 (10Liuxinyu970226) [08:30:31] 10MediaWiki-Interface: Show first pagename character as lowercase in MediaWiki namespace - https://phabricator.wikimedia.org/T31864#1751458 (10Liuxinyu970226) [08:32:55] 10MediaWiki-Internationalization, 7I18n: $namespaceGenderAliases not compatible with $wgExtraNamespaces - https://phabricator.wikimedia.org/T29398#1751459 (10Liuxinyu970226) [08:33:22] 10MediaWiki-Parser: Newline as list item terminator is troublesome - https://phabricator.wikimedia.org/T3115#1751460 (10Liuxinyu970226) [08:34:37] 10MediaWiki-extensions-WikibaseClient, 10ArticlePlaceholder, 10Wikidata, 7Story: [Story] Set the image Property id in configurations - https://phabricator.wikimedia.org/T113957#1751463 (10Liuxinyu970226) [08:36:11] 10MediaWiki-extensions-Translate: Language selector should be treated differently on a translatable page - https://phabricator.wikimedia.org/T39559#1751464 (10Liuxinyu970226) [08:36:31] 10MediaWiki-extensions-ParserFunctions, 7I18n: Add support for non-Arabic number systems - https://phabricator.wikimedia.org/T36193#1751465 (10Liuxinyu970226) [08:37:09] 10Access Policy: Translations for Meta-Wiki gateway to confidentiality agreement - https://phabricator.wikimedia.org/T111307#1751468 (10Liuxinyu970226) [08:47:09] (03PS1) 10Akangupt: Adding hooks.yaml for T115388 [core] - 10https://gerrit.wikimedia.org/r/248677 [09:11:23] 10MediaWiki-General-or-Unknown, 10MobileFrontend: Trying to save an edit triggers "error: the edit has not been saved" without further information - https://phabricator.wikimedia.org/T108683#1751500 (10Aklapper) [09:11:57] (03CR) 10Raimond Spekking: [C: 032] Add missing right-* messages [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/248651 (owner: 10Alex Monk) [09:12:14] (03Merged) 10jenkins-bot: Add missing right-* messages [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/248651 (owner: 10Alex Monk) [09:13:29] 4(no projects): SpaceyParanthesis bug - https://phabricator.wikimedia.org/T116519#1751506 (10Aklapper) Hi @TasneemLo. Please associate at least one [[ https://phabricator.wikimedia.org/project/query/active/ | project ]] with this task, otherwise nobody can find this task when searching in the corresponding proj... [09:14:08] 4(no projects): SpaceyParanthesis bug - https://phabricator.wikimedia.org/T116519#1751507 (10Aklapper) What is a "fixit"? Where in which codebase can this be found? [09:14:25] 4(no projects): SpaceyParanthesis bug - https://phabricator.wikimedia.org/T116519#1751508 (10TasneemLo) Sorry about that - it's part of #Mediawiki-CodeSniffer [09:14:40] 10MediaWiki-Codesniffer: SpaceyParanthesis bug - https://phabricator.wikimedia.org/T116519#1751509 (10TasneemLo) [09:16:06] 10MediaWiki-Special-pages, 7Composer, 7Easy, 5Patch-For-Review: Use /vendor/composer/installed.json for Special:Version & API about installed libraries instead of composer.lock - https://phabricator.wikimedia.org/T106247#1751511 (10Aklapper) >>! In T106247#1751339, @rosalieper wrote: > can i do this? Plea... [09:21:43] 6Phabricator: Enable embedding of media from Wikimedia Commons - https://phabricator.wikimedia.org/T116515#1751512 (10Aklapper) > It would be nice to be able to embed images and other media from Commons, too, e.g. for charts, screenshots, mockups and screencasts. What would you like to accomplish and why is a l... [09:21:57] 10MediaWiki-History-or-Diffs: Page history time stamp inconsistency after DST start: Incorrect time shown for logged-out users only - https://phabricator.wikimedia.org/T94383#1751513 (10Fomafix) The problem still exists for anonymous user: * https://de.wikipedia.org/w/index.php?title=Wikipedia:WikiProjekt_Vorlag... [09:22:54] 10Wikimedia-Media-storage, 10Wikimedia-Video: 1gb file upload limit is too restrictive for conference presentation videos - https://phabricator.wikimedia.org/T116514#1751514 (10Aklapper) [09:27:33] 10MediaWiki-Codesniffer: SpaceyParanthesis bug - https://phabricator.wikimedia.org/T116519#1751517 (10TasneemLo) [09:28:25] 10OCG-General-or-Unknown, 3Outreachy-Round-11: Outreachy proposal for Add ZIM format support to OCG - https://phabricator.wikimedia.org/T116482#1751518 (10Adishaporwal) [09:30:34] 6Discovery, 10Maps, 10Wikimedia-General-or-Unknown: Wikimedia-hosted OpenStreetMap (OSM) / mapnik tileservers wanted for mobile usage - https://phabricator.wikimedia.org/T35980#1751523 (10akosiaris) >>! In T35980#1749467, @Nemo_bis wrote: >> even used in the android beta mobile app successfully > > Are ther... [09:34:41] 6WMDE-Tech-Community-Communication, 3WMDE-TCC-Goal-2015-Developer, 3WMDE-Tech-Community-Communication-Q3-30092015: Jury Briefing/Jury Sheet - https://phabricator.wikimedia.org/T115574#1751525 (10Juscwmde) 5Open>3Resolved [09:34:41] 6WMDE-Tech-Community-Communication, 3WMDE-TCC-Goal-2015-Developer, 3WMDE-Tech-Community-Communication-Q3-30092015: GAME JAM EPIC - https://phabricator.wikimedia.org/T107854#1751526 (10Juscwmde) [09:58:27] 10MediaWiki-extensions-ProofreadPage, 10Wikimedia-Site-Requests, 6Wikisource, 5Patch-For-Review, and 2 others: Add Index and Page namespaces to $wgContentNamespaces - https://phabricator.wikimedia.org/T54709#1751530 (10Billinghurst) >>! In T54709#1751218, @GOIII wrote: >>>! In T54709#1744951, @Billinghurst... [10:04:35] 10MediaWiki-Codesniffer: phplint doesn't run on .inc files - https://phabricator.wikimedia.org/T116524#1751533 (10TasneemLo) 3NEW [10:13:38] 6Revscoring: Edit quality campaign for Ukrainian Wikipedia - https://phabricator.wikimedia.org/T114502#1751551 (10ToAruShiroiNeko) [10:16:06] (03CR) 10Rillke: "just nitpicking, thanks for caring about this, Bawolff" (034 comments) [core] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/248637 (https://phabricator.wikimedia.org/T94562) (owner: 10Brian Wolff) [10:30:55] (03CR) 10Rillke: In UploadStash, prioritize core metadata over file handler metadata (031 comment) [core] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/248637 (https://phabricator.wikimedia.org/T94562) (owner: 10Brian Wolff) [10:35:12] 10MediaWiki-extensions-ProofreadPage, 10Wikimedia-Site-Requests, 6Wikisource, 5Patch-For-Review, and 2 others: Add Index and Page namespaces to $wgContentNamespaces - https://phabricator.wikimedia.org/T54709#1751555 (10Nemo_bis) > If you have an issue with the configuration then it may be better to pull th... [10:41:05] (03PS1) 10Aaron Schulz: Make DBReadOnlyError use a better page title [core] - 10https://gerrit.wikimedia.org/r/248681 [10:41:34] 10MediaWiki-Configuration: Get MW_CONFIG_FILE from env to facilitate virtual hosting - https://phabricator.wikimedia.org/T115432#1751559 (10Liuxinyu970226) [11:03:22] 10MediaWiki-Parser, 7I18n, 7Tracking: GENDER (tracking) - https://phabricator.wikimedia.org/T32443#1751570 (10Nemo_bis) [11:03:24] 10MediaWiki-Internationalization, 7I18n, 7Need-volunteer: Log entries are difficult to localize; convert old style logs to the new code - https://phabricator.wikimedia.org/T26620#1751571 (10Nemo_bis) [11:03:25] 10MediaWiki-Documentation, 7Documentation, 7Technical-Debt, 7Tracking: Documentation is out of date, incomplete (tracking) - https://phabricator.wikimedia.org/T2001#1751572 (10Nemo_bis) [11:03:27] 10MediaWiki-Internationalization, 7Documentation, 7I18n: Create "how to rewrite a log to use the new system" tutorial/manual - https://phabricator.wikimedia.org/T44893#1751569 (10Nemo_bis) 5Resolved>3declined [11:05:33] 10MediaWiki-Templates: Templates should show parameters when not expanded due to preprocessor node count limit - https://phabricator.wikimedia.org/T9043#1751573 (10Nemo_bis) 5Resolved>3Open Again random closures by imported commits... [11:08:27] 10Wikimedia-General-or-Unknown: Make domas' pageviews data available in semi-publicly queryable database format - https://phabricator.wikimedia.org/T44259#1751576 (10Nemo_bis) [11:13:22] 10Wikimedia-General-or-Unknown: Vinculum page does not format any equtions or examples correctly - https://phabricator.wikimedia.org/T9498#1751577 (10Ciencia_Al_Poder) 5Resolved>3declined [11:14:32] (03CR) 10TheDJ: [C: 032] Use the new 'difftotextpst' option of prop=revisions API in live preview script [core] - 10https://gerrit.wikimedia.org/r/247849 (https://phabricator.wikimedia.org/T116178) (owner: 10Majr) [11:18:06] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Regression: [Bug] wbsearchentities API defaults to something else than the given language parameter - https://phabricator.wikimedia.org/T109584#1751579 (10Addshore) So this is due to language fallback. DE falls back to EN. Again I don't see anything in... [11:19:40] 10MediaWiki-extensions-ProofreadPage, 10Wikimedia-Site-Requests, 6Wikisource, 5Patch-For-Review, and 2 others: Add Index and Page namespaces to $wgContentNamespaces - https://phabricator.wikimedia.org/T54709#1751580 (10GOIII) >>! In T54709#1751530, @Billinghurst wrote: > It would seem that you have a diffe... [11:20:05] 3Wikipedia-Android-App, 7WorkType-Maintenance: [2.0.108-alpha-2015-08-12] 'Save page' option displayed as active when viewing saved pages - https://phabricator.wikimedia.org/T108885#1751581 (10DanReyLop) It was introduced in T115412. The PageLead's title (as returned by the MwApi) has spaces instead of undersc... [11:25:00] 10Wikimedia-Site-Requests: $wgCategoryCollation for bs.wikipedia.org - https://phabricator.wikimedia.org/T116527#1751585 (10Srdjan_m) 3NEW [11:25:56] (03CR) 10jenkins-bot: [V: 04-1] Use the new 'difftotextpst' option of prop=revisions API in live preview script [core] - 10https://gerrit.wikimedia.org/r/247849 (https://phabricator.wikimedia.org/T116178) (owner: 10Majr) [11:28:33] 6Phabricator, 10Diffusion: Prevent imported commits from upstream phabricator to close random tasks - https://phabricator.wikimedia.org/T116528#1751592 (10Ciencia_Al_Poder) 3NEW [11:33:07] 10CirrusSearch, 6Discovery, 3Discovery-Cirrus-Sprint, 7WorkType-Maintenance: Reindex namespaces after October 22, 2015 - https://phabricator.wikimedia.org/T115402#1751600 (10Glaisher) Bump. [11:33:23] (03PS4) 10TheDJ: Use the new 'difftotextpst' option of prop=revisions API in live preview script [core] - 10https://gerrit.wikimedia.org/r/247849 (https://phabricator.wikimedia.org/T116178) (owner: 10Majr) [11:39:46] (03CR) 10TheDJ: [C: 032] Use the new 'difftotextpst' option of prop=revisions API in live preview script [core] - 10https://gerrit.wikimedia.org/r/247849 (https://phabricator.wikimedia.org/T116178) (owner: 10Majr) [11:42:36] 10MediaWiki-Page-editing, 7Easy: Use the new 'difftotextpst' option of prop=revisions API in live preview script - https://phabricator.wikimedia.org/T116178#1751608 (10TheDJ) 5Open>3Resolved [11:50:11] (03Merged) 10jenkins-bot: Use the new 'difftotextpst' option of prop=revisions API in live preview script [core] - 10https://gerrit.wikimedia.org/r/247849 (https://phabricator.wikimedia.org/T116178) (owner: 10Majr) [11:54:06] 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7: CX adds non-breaking space in article - https://phabricator.wikimedia.org/T116530#1751612 (10KartikMistry) 3NEW [11:54:33] 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7: CX adds non-breaking space in article - https://phabricator.wikimedia.org/T116530#1751619 (10KartikMistry) [12:03:45] (03PS7) 10Paladox: [WIP] CodeEditor: Add support for Editor themes [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/122085 (https://bugzilla.wikimedia.org/59924) (owner: 10TheDJ) [12:03:56] 6Phabricator, 10Diffusion: Prevent imported commits from upstream phabricator to close random tasks - https://phabricator.wikimedia.org/T116528#1751623 (10Aklapper) Uhm. Thanks for catching that. We had that before in T91488 and we thought it was fixed. Sigh. [12:04:04] (03CR) 10Paladox: "Rebased." [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/122085 (https://bugzilla.wikimedia.org/59924) (owner: 10TheDJ) [12:04:10] (03CR) 10jenkins-bot: [V: 04-1] [WIP] CodeEditor: Add support for Editor themes [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/122085 (https://bugzilla.wikimedia.org/59924) (owner: 10TheDJ) [12:05:41] (03PS8) 10Paladox: [WIP] CodeEditor: Add support for Editor themes [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/122085 (https://bugzilla.wikimedia.org/59924) (owner: 10TheDJ) [12:11:01] (03PS1) 10Paladox: Add jshint and jscs to npm [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/248684 [12:11:43] (03CR) 10jenkins-bot: [V: 04-1] Add jshint and jscs to npm [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/248684 (owner: 10Paladox) [12:11:44] 6Phabricator, 10Diffusion: Prevent imported commits from upstream phabricator to close random tasks - https://phabricator.wikimedia.org/T116528#1751636 (10Aklapper) Starts at https://phabricator.wikimedia.org/feed/?before=6203071778477797250 bottom, use "Prev" button to get more up to 6203077046862287490 [12:12:21] 10MediaWiki-Templates: Templates should show parameters when not expanded due to preprocessor node count limit - https://phabricator.wikimedia.org/T9043#1751638 (10Aklapper) >>! In T9043#1751573, @Nemo_bis wrote: > Again random closures by imported commits... :(. See T116528 [12:12:36] 6Phabricator, 10Diffusion: Prevent imported commits from upstream phabricator to close random tasks - https://phabricator.wikimedia.org/T116528#1751640 (10Aklapper) p:5Triage>3High [12:21:29] (03CR) 10TheDJ: Fixes for video thumbs in gallery packed-hover mode (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/248540 (https://phabricator.wikimedia.org/T77988) (owner: 10Brion VIBBER) [12:27:26] (03PS2) 10Paladox: Add jshint and jscs to npm [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/248684 [12:27:33] (03CR) 10Brion VIBBER: Fixes for video thumbs in gallery packed-hover mode (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/248540 (https://phabricator.wikimedia.org/T77988) (owner: 10Brion VIBBER) [12:32:51] (03CR) 10jenkins-bot: [V: 04-1] Add jshint and jscs to npm [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/248684 (owner: 10Paladox) [12:46:00] 10MediaWiki-extensions-ContentTranslation, 7WorkType-Maintenance: CX adds non-breaking space in article - https://phabricator.wikimedia.org/T116530#1751647 (10Amire80) p:5Triage>3Normal [12:50:09] I am not able to submit my patch for Outreachy microtask due to "Invalid SSH key error". Can someone please help? [12:50:22] (03PS3) 10Paladox: Add jshint and jscs to npm [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/248684 [12:50:48] (03CR) 10jenkins-bot: [V: 04-1] Add jshint and jscs to npm [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/248684 (owner: 10Paladox) [13:03:30] (03PS4) 10Paladox: Add jshint and jscs to npm [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/248684 [13:04:22] (03CR) 10jenkins-bot: [V: 04-1] Add jshint and jscs to npm [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/248684 (owner: 10Paladox) [13:23:33] (03PS1) 10TheDJ: Fix viewport modification to use the right separator [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/248685 [13:32:34] 10MediaWiki-extensions-TimedMediaHandler, 6Multimedia, 5Patch-For-Review: No way in UI to individually re-run missing or new media transcodes - https://phabricator.wikimedia.org/T103116#1751666 (10TheDJ) [13:32:36] 10MediaWiki-extensions-TimedMediaHandler: Missing media transcodes are not shown on File detail page - https://phabricator.wikimedia.org/T103115#1751662 (10TheDJ) 5Open>3Resolved a:3brion [13:32:55] 10MediaWiki-extensions-ContentTranslation, 7WorkType-Maintenance: [Tracker] ContentTranslation issues that affect people who aren't editors or translators - https://phabricator.wikimedia.org/T116533#1751667 (10Amire80) 3NEW [13:37:21] 10MediaWiki-extensions-TimedMediaHandler, 7Accessibility: Improve the keyboard navigation for TMH - https://phabricator.wikimedia.org/T43695#467008 (10TheDJ) This would mostly be fixed when we get T100106 [13:41:49] 10MediaWiki-extensions-TimedMediaHandler: sometimes right buttons missing in menu after finishing playing media - https://phabricator.wikimedia.org/T43928#1751688 (10TheDJ) 5Open>3Invalid a:3TheDJ Unable to reproduce. [13:56:50] 10MediaWiki-extensions-ContentTranslation, 7WorkType-Maintenance: [Tracker] ContentTranslation issues that affect people who aren't editors or translators - https://phabricator.wikimedia.org/T116533#1751694 (10Amire80) [13:56:53] 10MediaWiki-extensions-ContentTranslation, 7WorkType-NewFunctionality: Enable Content Translation in Catalan Wikipedia for all logged-in users - https://phabricator.wikimedia.org/T102107#1751693 (10Amire80) [13:59:35] 10MediaWiki-extensions-TimedMediaHandler, 7Browser-Support-Internet-Explorer: File:Double_slit.theora.ogv doesn't show unsupported browser warning - https://phabricator.wikimedia.org/T62625#1751695 (10TheDJ) [14:00:06] (03PS1) 10DanReyLop: Fix various bugs to improve the offline browsing experience [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/248687 (https://phabricator.wikimedia.org/T85065) [14:00:37] 5Patch-For-Review, 3Wikipedia-Android-App, 7WorkType-Maintenance: Navigating to a saved page should always try using cached copy as last resort before network error - https://phabricator.wikimedia.org/T85065#1751700 (10DanReyLop) Well, this is it. I've just uploaded the first attempt at solving this issue.... [14:00:39] 10MediaWiki-extensions-TimedMediaHandler, 7Browser-Support-Internet-Explorer: File:Double_slit.theora.ogv doesn't show unsupported browser warning - https://phabricator.wikimedia.org/T62625#1751702 (10TheDJ) 5Open>3Resolved a:3TheDJ No longer a practical issue, since we are rolling ogv.js now to these br... [14:03:16] 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release6, 7WorkType-Maintenance: ContentTranslation publishes pages with empty tags - https://phabricator.wikimedia.org/T100847#1751707 (10Amire80) [14:03:20] 7Design, 10MediaWiki-Special-pages, 10MediaWiki-extensions-ContentTranslation, 7WorkType-NewFunctionality: Hide "New contribution" in Special:Contributions - https://phabricator.wikimedia.org/T96170#1751708 (10Amire80) [14:03:23] 10MediaWiki-extensions-ContentTranslation, 7WorkType-NewFunctionality: Enable Content Translation in Catalan Wikipedia for all logged-in users - https://phabricator.wikimedia.org/T102107#1751706 (10Amire80) [14:03:27] 7Design, 10MediaWiki-Special-pages, 10MediaWiki-extensions-ContentTranslation, 7WorkType-NewFunctionality: Hide "New contribution" in Special:Contributions - https://phabricator.wikimedia.org/T96170#1209837 (10Amire80) [14:03:30] 10MediaWiki-extensions-ContentTranslation, 7WorkType-Maintenance: [Tracker] ContentTranslation issues that affect people who aren't editors or translators - https://phabricator.wikimedia.org/T116533#1751709 (10Amire80) [14:03:58] 10MediaWiki-extensions-ContentTranslation, 7WorkType-Maintenance: [Tracker] ContentTranslation issues that affect people who aren't editors or translators - https://phabricator.wikimedia.org/T116533#1751667 (10Amire80) [14:05:38] 10MediaWiki-extensions-ContentTranslation, 7WorkType-Maintenance: English doesn't appear as a target gray interlanguage link in simple.wikipedia.org, but Simple English does - https://phabricator.wikimedia.org/T105072#1751720 (10Amire80) [14:05:42] 7Design, 10MediaWiki-extensions-ContentTranslation, 7WorkType-NewFunctionality: "Contributions" popup/fly-over appears in unexpected moments - https://phabricator.wikimedia.org/T115830#1751719 (10Amire80) [14:06:57] 10MediaWiki-extensions-ContentTranslation, 7Regression, 7WorkType-Maintenance: ContentTranslation call out overlaps Beta call out - https://phabricator.wikimedia.org/T99155#1751725 (10Amire80) [14:06:59] 7Design, 10MediaWiki-extensions-ContentTranslation, 7Easy, 7WorkType-Maintenance: CX new article invitation callout (non-beta users) does not have X to close - https://phabricator.wikimedia.org/T95997#1751726 (10Amire80) [14:07:02] 10MediaWiki-extensions-ContentTranslation, 7WorkType-Maintenance: [Tracker] ContentTranslation issues that affect people who aren't editors or translators - https://phabricator.wikimedia.org/T116533#1751667 (10Amire80) [14:07:05] 10MediaWiki-extensions-ContentTranslation, 7WorkType-Maintenance: CX new article callout (for non-beta users) goes off screen on small screens - https://phabricator.wikimedia.org/T95996#1751727 (10Amire80) [14:07:07] 10MediaWiki-Interface, 7I18n, 7Tracking, 7Voice & Tone: Interface messages needing rewording or documentation and other issues with existing messages (tracking) - https://phabricator.wikimedia.org/T40638#1751734 (10TheDJ) [14:07:10] 7Design, 10MediaWiki-extensions-TimedMediaHandler, 7I18n: TMH player not supported message confusing to users - https://phabricator.wikimedia.org/T62243#1751729 (10TheDJ) 5Open>3declined a:3TheDJ Not a practical problem anymore now that OGV.js was added. Any further improvements here are better spent o... [14:13:07] (03PS5) 10Paladox: Add jshint and jscs to npm [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/248684 [14:13:36] (03CR) 10jenkins-bot: [V: 04-1] Add jshint and jscs to npm [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/248684 (owner: 10Paladox) [14:14:03] (03PS6) 10Paladox: Add jshint and jscs to npm [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/248684 [14:14:33] (03CR) 10jenkins-bot: [V: 04-1] Add jshint and jscs to npm [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/248684 (owner: 10Paladox) [14:14:54] 10MediaWiki-extensions-TimedMediaHandler: Wrong character encoding of URL provided to media player - https://phabricator.wikimedia.org/T58538#1751736 (10TheDJ) 5Open>3Resolved a:3TheDJ Let's consider this fixed. [14:16:15] (03PS7) 10Paladox: Add jshint and jscs to npm [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/248684 [14:16:50] (03CR) 10jenkins-bot: [V: 04-1] Add jshint and jscs to npm [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/248684 (owner: 10Paladox) [14:17:20] (03PS8) 10Paladox: Add jshint and jscs to npm [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/248684 [14:19:14] 6Discovery, 10Maps: Experiment with PostgresSQL tile storage - https://phabricator.wikimedia.org/T116534#1751741 (10Yurik) 3NEW [14:19:36] 10MediaWiki-extensions-TimedMediaHandler: Uncaught TypeError: Cannot read property 'timedText' of undefined - https://phabricator.wikimedia.org/T52177#1751750 (10TheDJ) 5Open>3Resolved a:3TheDJ I haven't seen this problem in a long while. Provisionally closing. Please reopen if you encounter it. [14:20:24] (03PS9) 10Paladox: Add jshint and jscs to npm [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/248684 [14:20:45] 10MediaWiki-extensions-TimedMediaHandler: Don't add code to startup module - https://phabricator.wikimedia.org/T51920#1751753 (10TheDJ) [14:20:47] 10MediaWiki-extensions-TimedMediaHandler, 7Performance: TimedMediaHandler should not add start-up scripts - https://phabricator.wikimedia.org/T60085#1751754 (10TheDJ) [14:20:58] (03CR) 10Paladox: "check experimental" [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/122085 (https://bugzilla.wikimedia.org/59924) (owner: 10TheDJ) [14:22:18] (03CR) 10Paladox: "check experimental" [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/248684 (owner: 10Paladox) [14:24:27] (03CR) 10Paladox: "check experimental" [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/248684 (owner: 10Paladox) [14:26:17] (03PS10) 10Paladox: Add jshint and jscs to npm [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/248684 [14:26:43] (03CR) 10Paladox: "check experimental" [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/248684 (owner: 10Paladox) [14:29:18] 10MediaWiki-File-management, 10MediaWiki-extensions-TimedMediaHandler, 6Multimedia: Support for Opus audio format - https://phabricator.wikimedia.org/T42193#1751763 (10TheDJ) [14:33:04] 10MediaWiki-extensions-ContentTranslation, 7WorkType-Maintenance: The appearance of the translation discarding dialog moves other elements around - https://phabricator.wikimedia.org/T116535#1751767 (10Amire80) 3NEW [14:34:25] (03PS11) 10Paladox: Add jshint and jscs to npm, Also add composer.json [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/248684 [14:34:41] (03CR) 10Paladox: "check experimental" [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/248684 (owner: 10Paladox) [14:40:49] (03CR) 10Paladox: "recheck" [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/139760 (https://bugzilla.wikimedia.org/45850) (owner: 10TheDJ) [14:44:20] (03PS3) 10Paladox: [WIP] Try to split out wikiEditor vs codeEditor toolbar [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/139760 (https://phabricator.wikimedia.org/T47850) (owner: 10TheDJ) [14:44:35] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Try to split out wikiEditor vs codeEditor toolbar [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/139760 (https://phabricator.wikimedia.org/T47850) (owner: 10TheDJ) [14:46:21] 10MediaWiki-extensions-TimedMediaHandler, 7Testme: "Show error" used wrong line feed - https://phabricator.wikimedia.org/T44833#1751783 (10TheDJ) 5Open>3Resolved a:3TheDJ Unable to reproduce. Best I can figure out is that the user was referring to the dialog that pops up when you click an error in the tr... [14:47:03] (03PS4) 10Paladox: [WIP] Try to split out wikiEditor vs codeEditor toolbar [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/139760 (https://phabricator.wikimedia.org/T47850) (owner: 10TheDJ) [14:47:19] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Try to split out wikiEditor vs codeEditor toolbar [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/139760 (https://phabricator.wikimedia.org/T47850) (owner: 10TheDJ) [14:47:28] (03PS22) 10Physikerwelt: Use RESTbase storage for MathML rendering [extensions/Math] - 10https://gerrit.wikimedia.org/r/245478 [14:48:15] 10MediaWiki-extensions-MwEmbedSupport, 10MediaWiki-extensions-TimedMediaHandler: MwEmbedSupport doesn't work with non standard layouts - https://phabricator.wikimedia.org/T47918#1751789 (10TheDJ) Does anyone know if this is still a problem ? [14:49:50] 10MediaWiki-extensions-TimedMediaHandler: Display more information about the existing transcodes - https://phabricator.wikimedia.org/T49488#503260 (10TheDJ) Related is T57942 [14:51:34] Hi, I am new here. I need your help. I am trying to work on media-wiki parser's one easy task. But I don't know how to see output of the code. I am very confused. Please help so that I can properly understand the code culture of mediawiki. I have checkout the code. I have installed vagrant too. [14:57:51] 10MediaWiki-General-or-Unknown: SearchResultSet should implement Iterator - https://phabricator.wikimedia.org/T116536#1751798 (10Physikerwelt) 3NEW [15:06:19] (03PS1) 10Jonas Kress (WMDE): [WIP] Refactor gui.js [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/248689 (https://phabricator.wikimedia.org/T116464) [15:06:39] (03PS1) 10Jonas Kress (WMDE): SPARQL auto completion for keywords and ?variables [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/248690 (https://phabricator.wikimedia.org/T116080) [15:07:00] (03PS1) 10Physikerwelt: Update while style iterators [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/248691 [15:07:07] (03PS1) 10Jonas Kress (WMDE): Created toolbar and cleaned UI [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/248692 (https://phabricator.wikimedia.org/T115837) [15:07:22] 10MediaWiki-extensions-EducationProgram, 10MediaWiki-extensions-TimedMediaHandler, 10MassMessage: Video files are not playing through the embeded player - https://phabricator.wikimedia.org/T98969#1751816 (10TheDJ) This should now work. But it doesn't. That means that whatever method the Education Program is... [15:07:38] 10MediaWiki-extensions-EducationProgram, 10MassMessage: Video files are not playing through the embeded player - https://phabricator.wikimedia.org/T98969#1751817 (10TheDJ) [15:08:00] (03PS2) 10Physikerwelt: Update while style iterators [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/248691 [15:09:35] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Refactor gui.js [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/248689 (https://phabricator.wikimedia.org/T116464) (owner: 10Jonas Kress (WMDE)) [15:11:45] sam___: the parser is not an easy beast. what do you want to achieve ? [15:13:58] (03PS5) 10Paladox: [WIP] Try to split out wikiEditor vs codeEditor toolbar [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/139760 (https://phabricator.wikimedia.org/T47850) (owner: 10TheDJ) [15:14:14] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Try to split out wikiEditor vs codeEditor toolbar [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/139760 (https://phabricator.wikimedia.org/T47850) (owner: 10TheDJ) [15:14:54] (03PS6) 10Paladox: [WIP] Try to split out wikiEditor vs codeEditor toolbar [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/139760 (https://phabricator.wikimedia.org/T47850) (owner: 10TheDJ) [15:20:33] hi everybody :) [15:21:09] legoktm: did you look at the patch? [15:21:23] tinajohnson: sorry i went offline for so long. Hi [15:23:48] (03PS13) 10Paladox: Optional SVG mode with PNG fallback [extensions/Score] - 10https://gerrit.wikimedia.org/r/62243 (https://bugzilla.wikimedia.org/47578) (owner: 10Brion VIBBER) [15:24:08] (03CR) 10Paladox: "Rebased." [extensions/Score] - 10https://gerrit.wikimedia.org/r/62243 (https://bugzilla.wikimedia.org/47578) (owner: 10Brion VIBBER) [15:24:22] (03CR) 10jenkins-bot: [V: 04-1] Optional SVG mode with PNG fallback [extensions/Score] - 10https://gerrit.wikimedia.org/r/62243 (https://bugzilla.wikimedia.org/47578) (owner: 10Brion VIBBER) [15:26:56] 10MediaWiki-Special-pages, 7Composer, 7Easy, 5Patch-For-Review: Use /vendor/composer/installed.json for Special:Version & API about installed libraries instead of composer.lock - https://phabricator.wikimedia.org/T106247#1751819 (10rosalieper) Thanks @Aklapper for the wonderful advice. I will endeavor to d... [15:29:22] (03PS14) 10Paladox: Optional SVG mode with PNG fallback [extensions/Score] - 10https://gerrit.wikimedia.org/r/62243 (https://bugzilla.wikimedia.org/47578) (owner: 10Brion VIBBER) [15:29:50] (03CR) 10jenkins-bot: [V: 04-1] Optional SVG mode with PNG fallback [extensions/Score] - 10https://gerrit.wikimedia.org/r/62243 (https://bugzilla.wikimedia.org/47578) (owner: 10Brion VIBBER) [15:30:48] (03CR) 10Paladox: "recheck" [extensions/Score] - 10https://gerrit.wikimedia.org/r/62243 (https://bugzilla.wikimedia.org/47578) (owner: 10Brion VIBBER) [15:34:15] (03PS15) 10Paladox: Optional SVG mode with PNG fallback [extensions/Score] - 10https://gerrit.wikimedia.org/r/62243 (https://bugzilla.wikimedia.org/47578) (owner: 10Brion VIBBER) [15:36:10] (03CR) 10Paladox: "recheck" [core] - 10https://gerrit.wikimedia.org/r/223586 (https://phabricator.wikimedia.org/T61699) (owner: 10Brion VIBBER) [15:39:36] (03CR) 10jenkins-bot: [V: 04-1] Hi-DPI spinner using CSS animation [core] - 10https://gerrit.wikimedia.org/r/223586 (https://phabricator.wikimedia.org/T61699) (owner: 10Brion VIBBER) [15:48:35] (03CR) 10Rosalieper: "Patch set still pending, i will like it to be reviewed and merged :)" [core] - 10https://gerrit.wikimedia.org/r/248667 (https://phabricator.wikimedia.org/T106247) (owner: 10Rosalieper) [16:17:48] 6Phabricator, 10Diffusion: Prevent imported commits from upstream phabricator to close random tasks - https://phabricator.wikimedia.org/T116528#1751837 (10mmodell) Oversight, imported with autoclose enabled. [16:18:19] (03PS7) 10Paladox: Create render.reference [extensions/Popups] - 10https://gerrit.wikimedia.org/r/139827 (https://phabricator.wikimedia.org/T67114) (owner: 10Prtksxna) [16:18:31] (03CR) 10Paladox: "Rebased." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/139827 (https://phabricator.wikimedia.org/T67114) (owner: 10Prtksxna) [16:19:21] 6Phabricator, 10Diffusion: Prevent imported commits from upstream phabricator to close random tasks - https://phabricator.wikimedia.org/T116528#1751839 (10mmodell) @aklapper: I don't see the transactions in the feed on the page you linked to? [16:19:41] (03CR) 10jenkins-bot: [V: 04-1] Create render.reference [extensions/Popups] - 10https://gerrit.wikimedia.org/r/139827 (https://phabricator.wikimedia.org/T67114) (owner: 10Prtksxna) [16:21:30] (03PS8) 10Paladox: Create render.reference [extensions/Popups] - 10https://gerrit.wikimedia.org/r/139827 (https://phabricator.wikimedia.org/T67114) (owner: 10Prtksxna) [16:23:04] (03CR) 10jenkins-bot: [V: 04-1] Create render.reference [extensions/Popups] - 10https://gerrit.wikimedia.org/r/139827 (https://phabricator.wikimedia.org/T67114) (owner: 10Prtksxna) [16:23:31] (03PS9) 10Paladox: Create render.reference [extensions/Popups] - 10https://gerrit.wikimedia.org/r/139827 (https://phabricator.wikimedia.org/T67114) (owner: 10Prtksxna) [16:23:47] 10Wikimedia-General-or-Unknown: Vinculum page does not format any equtions or examples correctly - https://phabricator.wikimedia.org/T9498#1751840 (10mmodell) [16:24:00] (03CR) 10Anomie: [C: 04-1] "This really doesn't seem like something that API clients should have to have any idea about. If something wants its request to be cached a" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/248668 (https://phabricator.wikimedia.org/T91820) (owner: 10Aaron Schulz) [16:24:21] 10Wikimedia-General-or-Unknown: Update Special:Statistics ({{NUMBEROFARTICLES}}) for newly created wikis - https://phabricator.wikimedia.org/T9476#1751842 (10mmodell) [16:24:35] 10MediaWiki-Special-pages: RSS feed for Watchlist - https://phabricator.wikimedia.org/T9316#1751843 (10mmodell) [16:24:37] 10MediaWiki-extensions-WikiLexicalData-or-OmegaWiki: Expression selection box ignores letters typed during list creation lag on WiktionaryZ - https://phabricator.wikimedia.org/T9145#1751844 (10mmodell) [16:24:46] (03CR) 10jenkins-bot: [V: 04-1] Create render.reference [extensions/Popups] - 10https://gerrit.wikimedia.org/r/139827 (https://phabricator.wikimedia.org/T67114) (owner: 10Prtksxna) [16:25:16] r054l13: hi [16:25:22] 10MediaWiki-User-login-and-signup: Add a system variable for only WikiSysop to be able to create accounts only - https://phabricator.wikimedia.org/T9159#1751845 (10mmodell) 5Resolved>3declined a:3mmodell [16:25:31] 10MediaWiki-User-login-and-signup: Add a system variable for only WikiSysop to be able to create accounts only - https://phabricator.wikimedia.org/T9159#119970 (10mmodell) [16:25:51] qgil: hi [16:26:01] 10MediaWiki-Interface: List marker boxes lost to right of a floated image - https://phabricator.wikimedia.org/T9353#1751848 (10mmodell) [16:26:16] 10MediaWiki-Interface: List marker boxes lost to right of a floated image - https://phabricator.wikimedia.org/T9353#119059 (10mmodell) [16:29:22] (03PS1) 10Paladox: Update gruntfile.js [extensions/Popups] - 10https://gerrit.wikimedia.org/r/248693 [16:29:22] 10MediaWiki-Templates: Templates should show parameters when not expanded due to preprocessor node count limit - https://phabricator.wikimedia.org/T9043#1751851 (10mmodell) [16:29:22] 10MediaWiki-Interface: Error Call to undefined function session_set_cookie_params() - https://phabricator.wikimedia.org/T7215#1751852 (10mmodell) [16:29:22] 10Wikimedia-General-or-Unknown: Image pushes edit links down - https://phabricator.wikimedia.org/T7148#1751853 (10mmodell) [16:29:22] 10Wikimedia-General-or-Unknown: Image pushes edit links down - https://phabricator.wikimedia.org/T7148#96379 (10mmodell) [16:29:22] 10MediaWiki-Internationalization: Update for Portuguese localisation (pt) - https://phabricator.wikimedia.org/T9134#1751855 (10mmodell) [16:29:22] 10Wikimedia-General-or-Unknown: Not all system messages are listed in [[Special:Allmessages]] - https://phabricator.wikimedia.org/T5554#1751856 (10mmodell) [16:29:22] 10MediaWiki-extensions-CategoryTree: i18n for CategoryTree extension (zho series,yue) - https://phabricator.wikimedia.org/T9257#1751857 (10mmodell) [16:29:22] (03PS2) 10Paladox: Update gruntfile.js [extensions/Popups] - 10https://gerrit.wikimedia.org/r/248693 [16:29:22] 10MediaWiki-Interface: Error Call to undefined function session_set_cookie_params() - https://phabricator.wikimedia.org/T7215#1751858 (10mmodell) 5Resolved>3Invalid a:3mmodell [16:29:22] 10OCG-General-or-Unknown, 3Outreachy-Round-11: Outreachy proposal for Add ZIM format support to OCG - https://phabricator.wikimedia.org/T116482#1751860 (10Adishaporwal) a:3Adishaporwal [16:29:30] 10Wikimedia-General-or-Unknown: Not all system messages are listed in [[Special:Allmessages]] - https://phabricator.wikimedia.org/T5554#78720 (10mmodell) [16:29:37] 10Wikimedia-General-or-Unknown: Not all system messages are listed in [[Special:Allmessages]] - https://phabricator.wikimedia.org/T5554#78720 (10mmodell) [16:31:00] (03PS1) 10Paladox: build: Updating development dependencies [extensions/Popups] - 10https://gerrit.wikimedia.org/r/248694 [16:34:12] (03PS10) 10Paladox: Create render.reference [extensions/Popups] - 10https://gerrit.wikimedia.org/r/139827 (https://phabricator.wikimedia.org/T67114) (owner: 10Prtksxna) [16:37:10] (03PS1) 10Paladox: Add composer.json [extensions/Popups] - 10https://gerrit.wikimedia.org/r/248695 [16:39:05] 10MediaWiki-Vendor, 7Composer: phpcs doesn't work with mediawiki/vendor repo, while phpunit fails with composer-managed vendor. - https://phabricator.wikimedia.org/T115032#1751863 (10Anomie) >>! In T115032#1751419, @Legoktm wrote: >> $ phpcs > > This isn't from mediawiki/vendor, it's probably from a system p... [16:40:02] (03CR) 10Paladox: "check experimental" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/248695 (owner: 10Paladox) [16:44:55] adisha: hey, i am reading your proposal right now [16:45:11] adisha: check the About title, it should be About me not About you. [16:45:18] adisha: what do you think? :) [16:45:19] r054l13: ok.. thanks.. [16:45:26] yeah you are right [16:45:31] anything else [16:45:41] Does it sound monotonous?? [16:47:27] adisha: i am reading, i will ping you if i have any infos :) [16:47:27] (03CR) 10Glaisher: Cleanup on Special:AllPages and Special:PrefixIndex (031 comment) [core] - 10https://gerrit.wikimedia.org/r/247312 (https://phabricator.wikimedia.org/T32965) (owner: 10Glaisher) [16:50:21] 3Outreachy-Round-11: Outreach Proposal for T15303: Implement HTML e-mail support in MediaWiki - https://phabricator.wikimedia.org/T116223#1751865 (10rosalieper) [16:51:37] Glaisher: hey, i will like you to do a review of some few patches for me :) [16:51:48] Let me add you as a reviewer [16:51:56] ok [16:55:42] Glaisher: i have added you as review, legoktm was to review the patch but it seems he is quite busy :) [16:56:56] looks like you submitted it only today [16:57:15] well, yes and since in the morning :) [16:57:22] GMT + 01 [16:58:00] Glaisher: i have submitted some CentralNotice realated patches too, can you review that for me? [16:58:18] sadly, sometimes it takes several weeks (or months even) for reviews so you have to be patient [17:02:42] Glaisher: ok, no problem. Thanks [17:03:22] but the thing is i was asked by my mentor to submit more patches for bug fixes so that i can be a stronger candidate for outreachy [17:06:07] Even if you have open patches pending review, you can submit other patches as well [17:08:18] Glaisher: yes, that is what i am doing. Thanks :) [17:10:11] 10Wikimedia-Apache-configuration, 10Wikimedia-DNS: Redirect yue.wikipedia.org to zh-yue.wikipedia.org - https://phabricator.wikimedia.org/T105999#1751871 (10Ochloese) [17:11:58] 10MediaWiki-Codesniffer: phplint doesn't run on .inc files - https://phabricator.wikimedia.org/T116524#1751875 (10Legoktm) Do we have .inc files in the repository? We can add `-e php,inc` to the command to make it include that file extension. [17:12:11] 10OCG-General-or-Unknown, 3Outreachy-Round-11: Outreachy proposal for Add ZIM format support to OCG - https://phabricator.wikimedia.org/T116482#1751876 (10Adishaporwal) [17:20:14] 10MediaWiki-Internationalization, 7Easy, 5MW-1.23-release: "Show"/"Hide" links in recent changes / watchlist / log options box should be localizable per item - https://phabricator.wikimedia.org/T60449#1751884 (10Umar) Somebody deals with this problem? [17:20:23] adisha: nice proposal, expand on it and show it to the mentors :) [17:22:06] 10MediaWiki-Vagrant, 10RESTBase-Cassandra: vagrant role cassandra can not install cassandra package - https://phabricator.wikimedia.org/T116539#1751886 (10Physikerwelt) 3NEW [17:23:45] 10MediaWiki-extensions-UniversalLanguageSelector: In Serbian layout letters Ш, Ђ, Ч, Ћ, Ж are missing - https://phabricator.wikimedia.org/T115704#1751893 (10Milicevic01) [17:25:19] 10MediaWiki-Internationalization, 7Easy, 5MW-1.23-release: "Show"/"Hide" links in recent changes / watchlist / log options box should be localizable per item - https://phabricator.wikimedia.org/T60449#1751896 (10Glaisher) I think we should just get rid of those links and change them to checkboxes or some suc... [17:26:02] 10MediaWiki-Internationalization, 7Easy: "Show"/"Hide" links in recent changes / watchlist / log options box should be localizable per item - https://phabricator.wikimedia.org/T60449#1751897 (10Glaisher) [17:29:35] legoktm: Hi. re that globalrenameuser 50k thing, should it be a client-side check or server side? [17:34:48] r054l13: any changes you think I should make?? [17:36:01] adisha: still reading it, but it is really brief and also very comprehensive [17:36:13] ok [17:36:17] adisha: can you like add more meat to the bone in some points? [17:36:26] like expand on it abit? [17:36:41] I will try to add more to it.. [17:38:15] also adisha i think you should give the meaning of OCG in your proposal [17:38:44] Ohh yeah I think I forgot to add link in synopsis portion [17:39:09] r054l13: I will do the changes and you can review it again [17:42:45] 10MediaWiki-extensions-EducationProgram: [[Special:Log/eparticle]] does not exist - https://phabricator.wikimedia.org/T50495#1751909 (10Milicevic01) >>! In T50495#526213, @AdHuikeshoven wrote: > This has also been found op nl.wp in another case, that is while adding yourself as reviewer to a page a student is wo... [17:44:03] 10MediaWiki-File-management, 10MediaWiki-extensions-TimedMediaHandler, 6Multimedia: Support for Opus audio format - https://phabricator.wikimedia.org/T42193#1751912 (10brion) Ok, so these days everything works with Opus-in-Ogg uploaded as .ogg or .oga extension, but we don't accept the .opus extension. Shoul... [17:45:02] (03PS1) 10Glaisher: Show global edit count on Special:GlobalRenameQueue process form [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/248698 [17:48:35] 10MediaWiki-Logging, 5Patch-For-Review: After switching patrolling off, impossible to effectively hide patrol log entries in Special:Log - https://phabricator.wikimedia.org/T44246#1751919 (10MGChecker) [17:48:37] 10Wikimedia-Site-Requests: Disable patrolling on de.wikipedia - https://phabricator.wikimedia.org/T102818#1751918 (10MGChecker) [17:49:08] Glaisher: server-side. I was thinking submit form, server checks editcount > 50k, deny form and add a new checkbox, submits again, because wpYesIReallYWantToDoThis=1, the form submits properly [17:49:35] ok [17:51:54] * legoktm bbl [17:55:31] 3Wikipedia-Android-App: Create APKs with app_name, variant, flavour and version in the filename. Example: Wikipedia App-prod-release-132.apk - https://phabricator.wikimedia.org/T116540#1751920 (10Wikinaut) 3NEW [17:56:40] (03PS1) 10Wikinaut: Generate apk with app_name, variant, flavour and version number [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/248699 (https://phabricator.wikimedia.org/T116540) [17:57:01] #wikipedia-mobile [18:01:25] (03CR) 10jenkins-bot: [V: 04-1] Generate apk with app_name, variant, flavour and version number [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/248699 (https://phabricator.wikimedia.org/T116540) (owner: 10Wikinaut) [18:01:32] 6Phabricator: Enable embedding of media from Wikimedia Commons - https://phabricator.wikimedia.org/T116515#1751939 (10Negative24) I believe this feature would be very difficult to implement (given that there isn't even a trace of remote image engine support in Phabricator) with very little gain. It isn't that ha... [18:01:33] (03PS2) 10Wikinaut: Generate apk with app_name, variant, flavour and version number [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/248699 (https://phabricator.wikimedia.org/T116540) [18:01:54] 10MediaWiki-Cache: Undefined index errors from MemcachedPhpBagOStuff.php - https://phabricator.wikimedia.org/T116541#1751940 (10Glaisher) 3NEW [18:02:33] (03CR) 10Glaisher: "Did this cause T116541?" [core] - 10https://gerrit.wikimedia.org/r/248652 (owner: 10Aaron Schulz) [18:04:30] (03PS3) 10Wikinaut: Generate apk with app_name, variant, flavour and version number [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/248699 (https://phabricator.wikimedia.org/T116540) [18:09:11] (03CR) 10jenkins-bot: [V: 04-1] Generate apk with app_name, variant, flavour and version number [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/248699 (https://phabricator.wikimedia.org/T116540) (owner: 10Wikinaut) [18:13:56] 10MediaWiki-Vagrant, 10RESTBase-Cassandra: vagrant role cassandra can not install cassandra package - https://phabricator.wikimedia.org/T116539#1751951 (10Physikerwelt) ... I could solve the problem with the manual installation ... ``` 225 2015-10-25 17:30:11 sudo apt-key list | grep expired 226 2015-10... [18:16:16] (03PS1) 10Aaron Schulz: Remove old unused ObjectCache::newMemcached() method [core] - 10https://gerrit.wikimedia.org/r/248701 [18:16:21] (03CR) 10Wikinaut: "The new build scheme (with the new filename) works on my devices, and in the emulator." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/248699 (https://phabricator.wikimedia.org/T116540) (owner: 10Wikinaut) [18:17:14] (03Abandoned) 10Aaron Schulz: Remove old unused ObjectCache::newMemcached() method [core] - 10https://gerrit.wikimedia.org/r/248701 (owner: 10Aaron Schulz) [18:24:42] I am getting this error: ssh: connect to host gerrit.wikimedia.org port 29418: Network is unreachable fatal: Could not read from remote repository. [18:25:17] (03Restored) 10Aaron Schulz: Remove old unused ObjectCache::newMemcached() method [core] - 10https://gerrit.wikimedia.org/r/248701 (owner: 10Aaron Schulz) [18:25:31] (03PS2) 10Aaron Schulz: Update CACHE_MEMCACHED to not used newMemcached [core] - 10https://gerrit.wikimedia.org/r/248701 (https://phabricator.wikimedia.org/T116541) [18:25:59] Can someone tell a solution to this problem. I have tried changing the port but of no help. [18:26:09] Glaisher: ^ [18:27:22] (03PS3) 10Aaron Schulz: Update CACHE_MEMCACHED to not used newMemcached [core] - 10https://gerrit.wikimedia.org/r/248701 (https://phabricator.wikimedia.org/T116541) [18:27:24] (03PS1) 10TheDJ: Add file extension mapping for opus [core] - 10https://gerrit.wikimedia.org/r/248703 (https://phabricator.wikimedia.org/T42193) [18:28:15] (03PS1) 10TheDJ: Add opus to accepted file extensions [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/248704 (https://phabricator.wikimedia.org/T42193) [18:31:23] (03CR) 10Florianschmidtwelzow: [C: 032] Cleanup on Special:AllPages and Special:PrefixIndex (031 comment) [core] - 10https://gerrit.wikimedia.org/r/247312 (https://phabricator.wikimedia.org/T32965) (owner: 10Glaisher) [18:35:50] (03PS1) 10Aaron Schulz: Remove unused fields from User [core] - 10https://gerrit.wikimedia.org/r/248707 [18:39:55] (03CR) 10Niedzielski: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/248699 (https://phabricator.wikimedia.org/T116540) (owner: 10Wikinaut) [18:40:13] (03CR) 10Niedzielski: "@Wikinaut, this is a flaky test we hope to fix soon." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/248699 (https://phabricator.wikimedia.org/T116540) (owner: 10Wikinaut) [18:40:43] (03CR) 10Niedzielski: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/248687 (https://phabricator.wikimedia.org/T85065) (owner: 10DanReyLop) [18:41:49] 3WMUA-WLM-2015: Selecting jury members - https://phabricator.wikimedia.org/T115391#1751978 (10Ahonc) 5Open>3Resolved [18:41:58] (03Merged) 10jenkins-bot: Cleanup on Special:AllPages and Special:PrefixIndex [core] - 10https://gerrit.wikimedia.org/r/247312 (https://phabricator.wikimedia.org/T32965) (owner: 10Glaisher) [18:45:09] (03CR) 10jenkins-bot: [V: 04-1] Fix various bugs to improve the offline browsing experience [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/248687 (https://phabricator.wikimedia.org/T85065) (owner: 10DanReyLop) [18:48:39] 10MediaWiki-extensions-MultimediaViewer: When I open photos, says an error occurred or I do not have permission - https://phabricator.wikimedia.org/T116543#1751981 (10Blazeaglory) 3NEW [18:50:36] (03CR) 10Aaron Schulz: "It's not about cache but locality. Requests that have a payload and can't use GET use POST. If they don't change the DB, there should be s" [core] - 10https://gerrit.wikimedia.org/r/248668 (https://phabricator.wikimedia.org/T91820) (owner: 10Aaron Schulz) [18:51:40] 10MediaWiki-RfCs, 10MediaWiki-Sites, 10MediaWiki-extensions-Interwiki, 10MediaWiki-extensions-SiteMatrix, 10Wikimedia-Developer-Summit-2016: Overhaul Interwiki map, unify with Sites and WikiMap. - https://phabricator.wikimedia.org/T113034#1751988 (10Isarra) >>! In T113034#1709397, @daniel wrote: >>>! In... [18:52:11] 10MediaWiki-extensions-MultimediaViewer: When I open photos, says an error occurred or I do not have permission - https://phabricator.wikimedia.org/T116543#1751989 (10Blazeaglory) [18:53:16] (03PS3) 10Aaron Schulz: Add ?idempotent=1 flag for API modules [core] - 10https://gerrit.wikimedia.org/r/248668 (https://phabricator.wikimedia.org/T91820) [18:54:21] (03CR) 10Wikinaut: "@Niedzielski: ok. Let me know, if you, or others, want to have further changes." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/248699 (https://phabricator.wikimedia.org/T116540) (owner: 10Wikinaut) [18:54:44] I am getting this error:" ssh: connect to host gerrit.wikimedia.org port 29418: Network is unreachable fatal: Could not read from remote repository." Can someone resolve this issue? [19:00:13] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 3Wikidata-Sprint-2015-10-13: [Task] write a maintenance script to migrate properties from string to new identifier datatype - https://phabricator.wikimedia.org/T95686#1751996 (10daniel) XML dumps with histories are indeed an issue: t... [19:01:23] 10MediaWiki-Interface, 10MediaWiki-Parser, 10Parsoid, 10Wikimedia-Developer-Summit-2016, 5Patch-For-Review:
tags for MediaWiki sections - https://phabricator.wikimedia.org/T114072#1751997 (10Isarra) [19:06:01] (03CR) 10Brian Wolff: [C: 04-1] "I seem to have submitted this to the wrong branch somehow..." (031 comment) [core] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/248637 (https://phabricator.wikimedia.org/T94562) (owner: 10Brian Wolff) [19:13:50] (03PS1) 10Brian Wolff: In UploadStash, prioritize core metadata over file handler metadata [core] - 10https://gerrit.wikimedia.org/r/248709 (https://phabricator.wikimedia.org/T94562) [19:14:41] (03Abandoned) 10Brian Wolff: In UploadStash, prioritize core metadata over file handler metadata [core] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/248637 (https://phabricator.wikimedia.org/T94562) (owner: 10Brian Wolff) [19:16:35] (03CR) 10Amire80: Make grammar data loadable as an RL module and usable in JS (037 comments) [core] - 10https://gerrit.wikimedia.org/r/241499 (https://phabricator.wikimedia.org/T115217) (owner: 10Amire80) [19:17:13] (03PS14) 10Amire80: Make grammar data loadable as an RL module and usable in JS [core] - 10https://gerrit.wikimedia.org/r/241499 (https://phabricator.wikimedia.org/T115217) [19:17:36] (03PS15) 10Amire80: Make grammar data loadable as an RL module and usable in JS [core] - 10https://gerrit.wikimedia.org/r/241499 (https://phabricator.wikimedia.org/T115217) [19:27:11] (03PS1) 10TheDJ: Special:Upload Fire wikipage.content hook [core] - 10https://gerrit.wikimedia.org/r/248710 (https://phabricator.wikimedia.org/T51751) [19:27:29] (03PS15) 10Amire80: Make the code for grammar data processing common [core] - 10https://gerrit.wikimedia.org/r/241645 (https://phabricator.wikimedia.org/T115217) [19:27:57] (03PS3) 10Amire80: Move the Ukrainian grammar rules from PHP and JS to JSON [core] - 10https://gerrit.wikimedia.org/r/245184 (https://phabricator.wikimedia.org/T115217) [19:30:35] 10MediaWiki-Documentation, 7Documentation: Change maintenance/findHooks.php to use YAML [Outreachy microtask] - https://phabricator.wikimedia.org/T115959#1752017 (10Shrutika719) @Tgr I am facing some problem in submitting gerrit patch that is why I am submitting the modified findHooks.php file here. Can it be... [19:32:42] Shrutika: hey, what is the problem you are facing to submit patches on gerrit? [19:33:20] 10MediaWiki-Uploading, 10MediaWiki-extensions-TimedMediaHandler, 6Multimedia, 7JavaScript, 5Patch-For-Review: Ajax "This file already exists" doesn't load image related js (e.g. from TMH) - https://phabricator.wikimedia.org/T51751#1752019 (10TheDJ) This is what the upload page generates: ```http://localh... [19:36:57] 10MediaWiki-Uploading, 6Multimedia: Rework Special:Upload JS to use api and serverside upload checks - https://phabricator.wikimedia.org/T26217#1752022 (10TheDJ) @matmarex I know you guys changed quite some things in the upload script pipelines, not sure if this was part of it/came up. [19:38:21] tinajohnson: can we have a small meeting please? [19:38:58] (03PS1) 10TheDJ: Add TMH modules to the upload page. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/248711 (https://phabricator.wikimedia.org/T51751) [19:40:05] 6Repository-Ownership-Requests: Requesting access to gerrit group mediawiki for jzerebecki - https://phabricator.wikimedia.org/T116506#1752026 (10JanZerebecki) Technically if I consider your question in the strict sense (only actual patches in Mediawiki core and extensions that are not related to Wikidata): I on... [19:40:54] 6Repository-Ownership-Requests: Requesting access to gerrit group mediawiki for jzerebecki - https://phabricator.wikimedia.org/T116506#1752027 (10JanZerebecki) [19:41:09] (03CR) 10TheDJ: Fixes for video thumbs in gallery packed-hover mode (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/248540 (https://phabricator.wikimedia.org/T77988) (owner: 10Brion VIBBER) [19:43:30] (03CR) 10Fomafix: [C: 04-1] Special:Upload Fire wikipage.content hook (032 comments) [core] - 10https://gerrit.wikimedia.org/r/248710 (https://phabricator.wikimedia.org/T51751) (owner: 10TheDJ) [19:44:37] (03CR) 10Brion VIBBER: Fixes for video thumbs in gallery packed-hover mode (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/248540 (https://phabricator.wikimedia.org/T77988) (owner: 10Brion VIBBER) [19:45:03] I am getting this error:" ssh: connect to host gerrit.wikimedia.org port 29418: Network is unreachable fatal: Could not read from remote repository." [19:45:52] r054l13: I tried changing the port but of no help. [19:46:18] Shrutika: did you follow the tutorial carefully [19:46:19] ? [19:46:33] i mean the gerrit tutorials, i sent a link :) [19:46:49] Yes I did the same as mentioned [19:47:11] wait, can you send me the output of this command? [19:47:14] My SSH key was added to my gerrit account [19:47:19] git remote -vv [19:47:38] which key was added to your gerrit account, did you add public or private? [19:47:48] public key [19:47:54] ok [19:48:08] type this command and paste the output [19:48:15] "git remote -vv" [19:48:35] fatal: Not a git repository (or any of the parent directories): .git [19:48:50] (03CR) 10Brion VIBBER: "I wonder whether this is the best way to handle this... if any special page that can load wikitext fragments has to know ahead of time wha" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/248711 (https://phabricator.wikimedia.org/T51751) (owner: 10TheDJ) [19:48:55] it means your repository is not even a git repository [19:49:19] But I followed everything in the exact same way as stated [19:49:25] wait [19:49:31] how did you clone the code? [19:49:47] using the command of git clone [19:49:56] paste the command please [19:50:18] $ git clone ssh://shrutika.gulati@gerrit.wikimedia.org:29418/mediawiki/extensions/examples [19:50:44] change directory to the folder of the code and type: git config -l [19:51:55] 10Phabricator-Sprint-Extension: Sprint strikes entrys at burndown, if there are not "open" - https://phabricator.wikimedia.org/T116545#1752030 (10Luke081515) 3NEW [19:52:12] Shrutika: what is the output, paste it :) [19:52:20] but according to the error my connection has not been established [19:52:37] Shrutika: Are you behind a firewall [19:52:38] yes, i know, we are troubleshootin [19:52:58] Shrutika: also it seems the ssh agent process is not running [19:52:59] Shrutika: Or connecting through a proxy, or otherwise have something weird with your internet? [19:53:14] bawolff: could that be another case or problem, when the ssh agent is not running? [19:53:40] I think the error would be different for that [19:53:41] or when the private key has not been used to identify [19:53:48] bawolff: ok [19:54:49] but if Shrutika is not behind a firewall then he is surely missing a step in the tutorials :) [19:55:08] I'm responding to the network unreachable part [19:55:30] bawolff: Ok [19:55:45] Looking back at the logs, Shrutika had previously said [12:50:09] I am not able to submit my patch for Outreachy microtask due to "Invalid SSH key error". Can someone please help? [19:56:00] that part might make more sense for something wrong with the ssh-agent [19:56:37] bawolff: yeah, i think so too. [19:56:57] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Analytics, 7Easy, 7WorkType-Maintenance: add anchors to headings in CXStats - https://phabricator.wikimedia.org/T116546#1752037 (10Amire80) 3NEW [19:57:04] Shrutika: Does the following command work for you? git clone https://github.com/wikimedia/mediawiki.git [19:58:05] Shrutika: you can also try to read something about this: https://www.mediawiki.org/wiki/Talk:Gerrit/Tutorial [19:58:21] bawolff: I got that "Invalid SSH key" part resolved. [19:58:24] i ran a Google query and i got that :) [19:58:51] Shrutika: Just wondering, are you on windows, linux or mac? [19:58:59] windows [19:59:44] I also ran the google query and came across the same link but I already did what was mentioned in the link [19:59:52] * bawolff knows less about windows then the other two [20:00:07] bawolff: :D [20:00:22] Linux is the key to unlock all doors :D [20:00:43] Shrutika: but i think there is also a windows part in the Gerrit tutorials :) [20:01:02] Linux is certainly easier to get ssh/git/apache/etc up and running. (But windows is probably easier for everything else in the world) [20:01:14] Shrutika: If you do [20:01:18] ping gerrit.wikimedia.org [20:01:33] does the command output a succesful response? [20:01:35] bawolff: ok [20:01:39] (03CR) 10TheDJ: "It's more a problem of the uploadwarning system then of Special pages. Most special pages work just fine. Actually, I should check if thos" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/248711 (https://phabricator.wikimedia.org/T51751) (owner: 10TheDJ) [20:01:53] * FlorianSW is a windows user, too, but uses a Linux VM for development... for reasons [20:01:58] I followed Windows part only in gerrit tutorials and I am short of time to switch to linux so kindly help me out with windows [20:02:35] Shrutika: well, i am not really good at windows too [20:02:41] bawolff: Yes there is a successful response [20:02:50] * r054l13 goes closer to bawolff [20:02:59] Shrutika: You should feel free to use whatever operating system you feel more comfortable with. I just personally know less about windows, so I might not be as familar with the things that could go wrong [20:03:18] Shrutika: Well that's good at least [20:03:45] bawolff: What next should I do? [20:04:24] (03PS2) 10TheDJ: Add TMH modules to the upload page. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/248711 (https://phabricator.wikimedia.org/T51751) [20:05:18] Shrutika: Does: ssh gerrit.wikimedia.org -p 29418 'gerrit ls-projects' [20:05:24] give a long list of projects? [20:07:42] I haven't followed the whole conversation bawolff and Shrutika, but if you still get the "Network unreachable" error: Do you have a firewall active, which might block port 29418 (or maybe you're using a proxy?)? [20:08:15] Actually, I guess I should ask if you have an ssh command line client available. On windows you probably don't [20:08:21] bawolff: I get this error: ssh: connect to host gerrit.wikimedia.org port 29418: Network is unreachable [20:08:52] FlorianSW: No firewall is active and I even tried changing the ports but of no help [20:09:35] Shrutika: you don't need to change the port [20:09:51] Everybody uses that same port to connect to gerrit :) [20:10:22] even me :) [20:11:08] The gerrit server only listens for ssh connections on that specific port [20:11:31] Ok. I didn't know that [20:12:04] I wonder if you can clone gerrit over https. I think you can, but I've never tried [20:12:08] Shrutika: that wouldn't make much sense :) like bawolff said, gerrit server only listen on 29418, and if a ping works, but no connection to this port, I would check a firewall or another network hardware, that might block connections through unknown ports :) [20:12:29] 10MediaWiki-Internationalization, 7Easy: "Show"/"Hide" links in recent changes / watchlist / log options box should be localizable per item - https://phabricator.wikimedia.org/T60449#1752048 (10Ciencia_Al_Poder) Using checkboxes would also allow to change several options at once without having to reload the pa... [20:12:37] you could try git clone https://gerrit.wikimedia.org/r/mediawiki/core [20:13:17] Before doing that, try setting a password in the HTTP password section of your gerrit preferences? [20:13:25] (I did not mean to end that with a question mark) [20:13:33] bawolff: I think you don't need that for "just" cloning [20:13:44] right, probably not [20:13:54] but you should be able to submit patches using that [20:15:23] bawolff: ah, ok, thanks for this info, I never tried that :) [20:15:39] FlorianSW: There is a succesfull response to this command [20:15:43] me neither, I wonder if it actually works [20:15:50] This being gerrit, I wouldn't bet money on it [20:16:00] :P [20:16:04] (03CR) 10TheDJ: "T60478 is slightly related." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/248711 (https://phabricator.wikimedia.org/T51751) (owner: 10TheDJ) [20:16:23] Shrutika: ok, then I'm pretty sure, that something in your network blocks request to unknown ports (like gerrit's 29418) [20:17:07] Shrutika: from my own small experience, i think FlorianSW is right :) [20:17:14] could you try to submit a patch using https? So simply change a file, commit it, and run git-review (or, I'm pretty sure, you can't use git-review on windows, git push HEAD:refs/for/master) [20:17:30] 10MediaWiki-File-management, 10MediaWiki-extensions-TimedMediaHandler, 6Multimedia, 10Wikimedia-Video, 7Technical-Debt: Improve interface for MediaHandlers to add JavaScript - https://phabricator.wikimedia.org/T60478#1752058 (10brion) Reviving this & adding projets, as the notion came up while working on... [20:18:11] But I have already checked for firewalls or any other possibility that could block request [20:18:37] Shrutika: Where are you connecting to the internet from? Public wi-fi networks often block things like that [20:19:10] I have a LAN connection [20:19:31] Shrutika: maybe your internet provider? [20:19:44] In that case what should I do? [20:20:16] Well, lets try the clone using https [20:20:25] that goes over a different port, so should not be blocked [20:20:50] Shrutika: ask them, if they can unblock port 29418 for you (but I think, if a network operater blocks ports, they probably dont want to unblock them on requests :/) [20:21:01] bawolff: https://gerrit-review.googlesource.com/Documentation/user-upload.html#http sounds interesting :) [20:21:30] Shrutika: may I ask you, what internet provider you use? [20:21:48] (03PS2) 10Krinkle: installer: Remove additional newline in LocalSettings.php [core] - 10https://gerrit.wikimedia.org/r/248476 (owner: 10saper) [20:21:51] (03PS3) 10Ferdbold: [WIP] Insert new graphs in a page inside VisualEditor [extensions/Graph] - 10https://gerrit.wikimedia.org/r/246726 (https://phabricator.wikimedia.org/T112994) [20:21:52] * bawolff going to guess Jaypee Institute of Information Technology, Noida [20:22:22] Shrutika: in my view, this has to do with your key, and ssh-agent [20:22:26] (03CR) 10Krinkle: [C: 032] installer: Remove additional newline in LocalSettings.php [core] - 10https://gerrit.wikimedia.org/r/248476 (owner: 10saper) [20:22:42] (I forgot, how an agent was used on Windows) [20:22:43] webchat publically displays IP addresses [20:22:58] bawolff: *facepalm* you're right :D [20:23:04] Ah, use the one from Putty! [20:23:36] Shrutika: https://winscp.net/eng/docs/ui_pageant [20:24:00] add your private key. Try then again to git the repo [20:24:26] https://winscp.net/eng/docs/ui_pageant is the link to the agent which is delivered with WinSCP [20:24:50] wikinaut: i thought so too :) [20:25:16] Shrutika: make absolutely sure, that you see your key in the window like https://winscp-static-746341.c.cdn77.org/data/media/screenshots/pageant.png?v=283 [20:25:53] and the comments on the key are the same as on the (public) key in your gerrit/wikitech account [20:26:33] Shrutika: ? [20:26:40] (03CR) 10Rillke: [C: 031] In UploadStash, prioritize core metadata over file handler metadata [core] - 10https://gerrit.wikimedia.org/r/248709 (https://phabricator.wikimedia.org/T94562) (owner: 10Brian Wolff) [20:27:34] wikinaut: I am following your words and adding my private key and trying it again [20:29:04] 10MediaWiki-Gallery, 10MediaWiki-extensions-TimedMediaHandler, 5Patch-For-Review, 7Regression: Video thumbnails not fitting into packed-hover gallery mode - https://phabricator.wikimedia.org/T77988#1752075 (10TheDJ) It seems that the patches work fairly well, but there still seems to be an issue with audio... [20:29:13] 7Design, 10UI-Standardization: Provide a color palette and design for buttons that are purely highlighted links, to distinguish them from actual UI buttons - https://phabricator.wikimedia.org/T116549#1752076 (10Quiddity) 3NEW [20:29:19] (03CR) 10Krinkle: Restore satisfaction schema and fix the performance issue that it had (031 comment) [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/248087 (https://phabricator.wikimedia.org/T116319) (owner: 10EBernhardson) [20:32:19] wikinaut: This is the error: ssh: connect to host gerrit.wikimedia.org port 29418: Network is unreachable fatal: Could not read from remote repository. [20:33:07] (03Merged) 10jenkins-bot: installer: Remove additional newline in LocalSettings.php [core] - 10https://gerrit.wikimedia.org/r/248476 (owner: 10saper) [20:35:35] my connection is kind of disturbing today ;( [20:39:04] wikinaut : ? [20:40:15] Shrutika: that usually means port 29418 is filtered by the firewall [20:40:48] Shrutika: i have something for you [20:40:50] Shrutika: http://zqfan.github.io/openstack/2014/09/23/git-review/ [20:40:51] checkthat out, it might help you so just try it :) [20:41:47] Shrutika: I really don't think that error means something wrong with your ssh-agent. That error sounds like its happening before you even get to your ssh agent step [20:41:59] 7Design, 10UI-Standardization: Provide a color palette and design for buttons that are purely highlighted links, to distinguish them from actual UI buttons - https://phabricator.wikimedia.org/T116549#1752090 (10Quiddity) [20:42:00] Shrutika: Did cloning from the https url work? [20:43:02] yes it is cloning from the https url [20:43:32] Ok. That's a good step in the right direction [20:45:21] 7Design, 10UI-Standardization: Provide a color palette and design for buttons that are purely highlighted links, to distinguish them from actual UI buttons - https://phabricator.wikimedia.org/T116549#1752094 (10Quiddity) [20:49:05] 7Design, 10UI-Standardization: Provide a color palette and design for buttons that are purely highlighted links, to distinguish them from actual UI buttons - https://phabricator.wikimedia.org/T116549#1752095 (10Quiddity) [20:51:17] Shrutika: When it finishes cloning, you should be able to use that to do dev stuff. But submitting patches might be slightly different [20:52:29] Shrutika: You'll probably have to submit patches with the command: git push https://:@gerrit.wikimedia.org/r/mediawiki/core HEAD:refs/for/master [20:53:03] Shrutika: Where username is your gerrit shell name, and password is the http password in your gerrit preferences (Not your normal gerrit password) [20:56:33] shell name: Shrutika and http password: pLTgqH4BlDWW [20:56:48] oh, we don't want to see passwords [20:57:57] make sure to have the correct (upper/lowercase) writing of your username when using it in the command/s [20:58:29] Sorry it's SHRUTIKA [20:58:50] use that in your command [20:59:13] In that case, the command to submit a patch would be git push https://SHRUTIKA:pLTgqH4BlDWW@gerrit.wikimedia.org/r/mediawiki/core HEAD:refs/for/master [20:59:19] yep [20:59:28] same for git:// commands [21:00:01] I always would try a clone command first [21:00:06] however, you might want to switch your http password to something else, since everyone on the channel knows it now (Not a huge deal. Someone could pretend to submit a patch using your name if they know your password) [21:00:17] +1 [21:01:35] (03PS1) 10Paladox: Update grunt-jscs to 2.2.0 [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/248731 [21:02:07] I will try cloning and just be back [21:02:35] (03PS1) 10Paladox: Update grunt-jscs to 2.2.0 [core] - 10https://gerrit.wikimedia.org/r/248733 [21:02:37] (03PS1) 10Aaron Schulz: Make WAN cache HOLDOFF_TTL smaller by combining db/snapshot lag [core] - 10https://gerrit.wikimedia.org/r/248734 [21:02:48] (03CR) 10jenkins-bot: [V: 04-1] Make WAN cache HOLDOFF_TTL smaller by combining db/snapshot lag [core] - 10https://gerrit.wikimedia.org/r/248734 (owner: 10Aaron Schulz) [21:02:58] (03PS2) 10Paladox: Update grunt-jscs to 2.2.0 [core] - 10https://gerrit.wikimedia.org/r/248733 [21:03:03] (03CR) 10Paladox: [C: 032] Update grunt-jscs to 2.2.0 [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/248731 (owner: 10Paladox) [21:03:44] (03Merged) 10jenkins-bot: Update grunt-jscs to 2.2.0 [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/248731 (owner: 10Paladox) [21:05:16] 10MediaWiki-Documentation, 7Documentation: Change maintenance/findHooks.php to use YAML [Outreachy microtask] - https://phabricator.wikimedia.org/T115959#1752097 (10Tgr) @Shrutika719: no, code review (and the eventual merging of new code) needs to happen on gerrit. Can you describe your difficulties? [21:06:18] wikinaut: error: failed to push some refs to 'https://SHRUTIKA:pLTgqH4BlDWW@gerrit.wikimedia.org/r/mediawiki/core' [21:06:25] (03CR) 10jenkins-bot: [V: 04-1] Update grunt-jscs to 2.2.0 [core] - 10https://gerrit.wikimedia.org/r/248733 (owner: 10Paladox) [21:07:41] tgr: The ongoing conversation is about the difficulties I am facing, kindly have a look.. [21:08:01] oh, that's probably lack of change-id hook [21:08:36] (03CR) 10Gergő Tisza: [C: 04-1] "Looks good, apart from commit message formatting." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/248677 (owner: 10Akangupt) [21:08:42] 10Wikimedia-General-or-Unknown: Audit inline styling in the main namespace on the English Wikipedia - https://phabricator.wikimedia.org/T115228#1752098 (10MZMcBride) The XML dump reader script is probably largely finished now: . The patte... [21:09:07] Shrutika: Just for testing right now, can you make the very last line of your commit message be something like: [21:09:25] Change-Id: I8aed6a1a5343252343ad23d8429791f58c4 [21:09:51] bash: Change-Id:: command not found [21:10:20] (03PS3) 10Paladox: Update grunt-jscs to 2.2.0 [core] - 10https://gerrit.wikimedia.org/r/248733 [21:10:24] I mean in your commit message, not a command to do at the command line [21:10:37] Like the message that you would write when doing git commit --amend [21:10:45] Shrutika: that's described on https://www.mediawiki.org/wiki/Gerrit/Tutorial#Push_using_HTTPS [21:11:02] Oops, sorry. [21:11:51] the Change-Id: is something you'll need to put on the commit message manually [21:12:18] however, you might want to switch your http password to something else, since everyone on the channel knows it now (Not a huge deal. Someone could pretend to submit a patch using your name if they know your password) [21:12:22] Don't some repos allow direct pushing? [21:12:37] A few [21:13:09] Well its not like Shrutika actually has any special rights beyond what a brand new account would have [21:13:21] Shrutika: use "-f" (force) with the push command [21:13:55] I don't think you should use the -f command [21:14:01] bawolff: yes, sorry!!! [21:14:21] bawolff: https://gerrit.wikimedia.org/r/#/c/248701/ [21:14:22] I correct: do > not < use push -f with git [21:14:28] on mediawiki projects [21:14:31] sorry [21:15:12] although I don't think it overly makes a difference. I doubt gerrit would let you do the sort of things that -f is meant to override [21:15:16] (03CR) 10jenkins-bot: [V: 04-1] Update grunt-jscs to 2.2.0 [core] - 10https://gerrit.wikimedia.org/r/248733 (owner: 10Paladox) [21:15:19] AaronSchulz: [21:15:30] Shrutika: could you clone a project, or extension ?It looks so, what was the earlier problem, your USERNAME ? [21:16:40] wikinaut: His earlier problem is that the ssh port was blocked [21:16:58] s/his/his\/her [21:16:59] I am able to clone a project using https url [21:17:15] bawolff: her [21:17:35] ah, ok [21:17:36] (03PS2) 10TheDJ: Special:Upload Fire wikipage.content hook [core] - 10https://gerrit.wikimedia.org/r/248710 (https://phabricator.wikimedia.org/T51751) [21:18:01] Shrutika: Sorry about that. I have a bad habit of defaulting to masculine pronouns when I don't know the gender of the person. I'm trying to stop doing that [21:18:01] (sorry again for the push "pseudo tip". here we use gerrit....) [21:19:17] (03PS4) 10Paladox: Update grunt-jscs to 2.2.0 [core] - 10https://gerrit.wikimedia.org/r/248733 [21:22:33] (03CR) 10Brian Wolff: [C: 032] Update CACHE_MEMCACHED to not used newMemcached [core] - 10https://gerrit.wikimedia.org/r/248701 (https://phabricator.wikimedia.org/T116541) (owner: 10Aaron Schulz) [21:23:19] (03CR) 10jenkins-bot: [V: 04-1] Update grunt-jscs to 2.2.0 [core] - 10https://gerrit.wikimedia.org/r/248733 (owner: 10Paladox) [21:33:06] (03Merged) 10jenkins-bot: Update CACHE_MEMCACHED to not used newMemcached [core] - 10https://gerrit.wikimedia.org/r/248701 (https://phabricator.wikimedia.org/T116541) (owner: 10Aaron Schulz) [21:39:31] 10MediaWiki-Debug-Logger, 7Upstream: Monolog microsecond timestamps cost milliseconds of runtime with heavy log usage - https://phabricator.wikimedia.org/T116550#1752103 (10bd808) 3NEW a:3bd808 [21:51:19] 10Dumps-Generation, 10Wikimedia-Developer-Summit-2016: Dumps 2.0 for realz (planning/architecture session) - https://phabricator.wikimedia.org/T114019#1752112 (10ArielGlenn) it's not done yet, sorry, making the diagram digital killed me today. rest of the notes (not much left) tomorrow. [22:06:28] 3Outreachy-Round-11: Outreach Proposal for T15303: Implement HTML e-mail support in MediaWiki - https://phabricator.wikimedia.org/T116223#1752115 (10DaBPunkt) While it is definitively a bad idea to send HTML-emails in general: MIME is not another email-format. It’s a way to define blocks in emails. These blocks... [22:07:10] (03PS1) 10BryanDavis: MonologSpi: add support for customizing Monolog\Logger instances [core] - 10https://gerrit.wikimedia.org/r/248800 (https://phabricator.wikimedia.org/T116550) [22:08:03] (03PS2) 10Krinkle: Tweak packed-hover gallery mode for better video compat [core] - 10https://gerrit.wikimedia.org/r/248572 (https://phabricator.wikimedia.org/T77988) (owner: 10Brion VIBBER) [22:16:32] 10MediaWiki-Debug-Logger, 5Patch-For-Review, 7Performance, 7Upstream: Monolog microsecond timestamps cost milliseconds of runtime with heavy log usage - https://phabricator.wikimedia.org/T116550#1752120 (10bd808) [22:35:07] 10MediaWiki-extensions-SmiteSpam: System message missing - https://phabricator.wikimedia.org/T116551#1752122 (10Kghbln) 3NEW a:3polybuildr [22:38:23] (03CR) 10BryanDavis: [C: 04-1] Absolute file paths changed (033 comments) [core] - 10https://gerrit.wikimedia.org/r/248667 (https://phabricator.wikimedia.org/T106247) (owner: 10Rosalieper) [22:40:35] (03PS1) 10Ori.livneh: Improve error reporting for missing classes [core] - 10https://gerrit.wikimedia.org/r/248801 [22:40:42] bd808, tgr: ^ [22:41:28] I think we have extensions that sort of expect missing classes. I wrote about this on some bug at some point... [22:42:19] * bd808 tries to find previous research [22:43:34] ori: found it -- https://phabricator.wikimedia.org/T74777#800397 [22:44:03] (03CR) 10jenkins-bot: [V: 04-1] Improve error reporting for missing classes [core] - 10https://gerrit.wikimedia.org/r/248801 (owner: 10Ori.livneh) [22:44:18] bd808: syntaxhighlight_geshi doesn't do that any more [22:44:26] ugh [22:44:29] git grep -l class_exists [22:44:31] but your latter point is good [22:44:32] yeah [22:44:33] sigh. [22:47:26] (03CR) 10Ori.livneh: "It's still Psr\Log\LoggerInterface for me. But the fact that this is a question at all highlights the fact that this is contingent and sho" [core] - 10https://gerrit.wikimedia.org/r/248650 (https://phabricator.wikimedia.org/T115729) (owner: 10BryanDavis) [22:51:12] 4(no projects): maps-test200{2-4} PostgreSQL replication needs rebuilding - https://phabricator.wikimedia.org/T116553#1752146 (10Yurik) 3NEW [22:51:44] ori: seems like AbuseFilterVariableHolder calls prepareContentForEdit() but it's not always reusing the process cache and parses (according to xenon) [22:51:53] * AaronSchulz wonders if that can be fixed [22:52:04] AaronSchulz: yeah, i noticed that [22:52:08] (03CR) 10BryanDavis: [C: 04-1] "I tried this before. See comments at T74777#800397 and try a `git grep -l class_exists` to see some things that would also need to be upda" [core] - 10https://gerrit.wikimedia.org/r/248801 (owner: 10Ori.livneh) [22:52:34] (03Abandoned) 10Ori.livneh: Improve error reporting for missing classes [core] - 10https://gerrit.wikimedia.org/r/248801 (owner: 10Ori.livneh) [22:55:14] 'load-recent-authors' also sometimes randomly slow, not sure why [22:55:52] shows up there and also in logs (Lost connection to MySQL server during query (10.64.32.21)) [22:59:28] 10CirrusSearch, 6Discovery, 3Discovery-Cirrus-Sprint, 7WorkType-Maintenance: Reindex namespaces after October 22, 2015 - https://phabricator.wikimedia.org/T115402#1752162 (10EBernhardson) 5Open>3Resolved a:3EBernhardson reindexed the namespaces, then reindexed the content indices and re-copied those... [23:04:35] AaronSchulz: that is a problem. It is also a symptom of a bigger problem, which is that there exists no good feedback mechanism for indicating which rules are actually effective. In the absence of that, rules will become rococo. [23:06:06] AaronSchulz: I don't think that we need to go back to having hit counters for rules, but a one-time audit of the various variables that AbuseFilter makes available and their signal-value would be good -- we might find that some of the more expensive ones are worthless and could be eliminated. [23:06:31] (03PS1) 10PleaseStand: Database::__construct(): Don't set $mTrxAtomicLevels to an SplStack [core] - 10https://gerrit.wikimedia.org/r/248802 [23:06:50] (03PS4) 10Tim Starling: Consolidate common Preprocessor caching code [core] - 10https://gerrit.wikimedia.org/r/244586 (owner: 10Ori.livneh) [23:06:57] (03CR) 10Tim Starling: [C: 032] Consolidate common Preprocessor caching code [core] - 10https://gerrit.wikimedia.org/r/244586 (owner: 10Ori.livneh) [23:07:56] (03CR) 10Aaron Schulz: [C: 032] Database::__construct(): Don't set $mTrxAtomicLevels to an SplStack [core] - 10https://gerrit.wikimedia.org/r/248802 (owner: 10PleaseStand) [23:14:34] (03PS3) 10Rosalieper: Absolute file paths changed [core] - 10https://gerrit.wikimedia.org/r/248667 (https://phabricator.wikimedia.org/T106247) [23:17:50] (03Merged) 10jenkins-bot: Consolidate common Preprocessor caching code [core] - 10https://gerrit.wikimedia.org/r/244586 (owner: 10Ori.livneh) [23:17:53] (03Merged) 10jenkins-bot: Database::__construct(): Don't set $mTrxAtomicLevels to an SplStack [core] - 10https://gerrit.wikimedia.org/r/248802 (owner: 10PleaseStand) [23:18:00] (03CR) 10Gergő Tisza: "> If PHP allowed monkey patching built-in functions we could hijack explicit calls to class_exists() and make them somehow disable the err" [core] - 10https://gerrit.wikimedia.org/r/248801 (owner: 10Ori.livneh) [23:23:18] 10MobileFrontend: Replace mobile.toast with mw.notification? - https://phabricator.wikimedia.org/T116555#1752165 (10Florian) 3NEW [23:27:22] 10MediaWiki-extensions-MultimediaViewer: Can't access photos - https://phabricator.wikimedia.org/T116556#1752173 (10Kate2016) 3NEW [23:48:35] (03CR) 10Tim Starling: [C: 04-1] "Do you know what the overhead is? It does two memcached queries on every #invoke, which could be expensive if there are a lot of #invoke c" (032 comments) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/248657 (owner: 10Ori.livneh) [23:50:32] 4(no projects): AFComputedVariable::compute query timeouts - https://phabricator.wikimedia.org/T116557#1752181 (10aaron) 3NEW [23:50:46] 10MediaWiki-extensions-AbuseFilter, 6Performance-Team, 7Database: AFComputedVariable::compute query timeouts - https://phabricator.wikimedia.org/T116557#1752187 (10aaron) [23:55:33] 10MediaWiki-extensions-AbuseFilter, 6Performance-Team, 7Database: AFComputedVariable::compute query timeouts - https://phabricator.wikimedia.org/T116557#1752189 (10aaron) p:5Triage>3High [23:56:12] 10MediaWiki-extensions-AbuseFilter, 6Performance-Team, 7Database: AFComputedVariable::compute query timeouts - https://phabricator.wikimedia.org/T116557#1752181 (10aaron) [23:56:53] 10MediaWiki-extensions-AbuseFilter, 6Performance-Team, 7Database: AFComputedVariable::compute query timeouts - https://phabricator.wikimedia.org/T116557#1752181 (10aaron) [23:59:49] (03Abandoned) 10Rosalieper: Absolute file paths changed [core] - 10https://gerrit.wikimedia.org/r/248667 (https://phabricator.wikimedia.org/T106247) (owner: 10Rosalieper)