[00:03:18] 10MediaWiki-RfCs, 10Wikimedia-Developer-Summit-2016: RfC: Dependency injection - https://phabricator.wikimedia.org/T384#1701146 (10Tgr) There is a [[ http://www.php-fig.org/psr/psr-7/#3-2-1-psr-http-message-serverrequestinterface | PSR standard ]] for a request context; the problem is MediaWiki's RequestContex... [00:21:57] 10MobileFrontend, 3Reading-Web-Sprint-57-The Fifth Element: Investigate reports of broken section toggling - https://phabricator.wikimedia.org/T114622#1701147 (10Jdlrobson) 3NEW [00:31:00] 10MobileFrontend, 3Reading-Web-Sprint-57-The Fifth Element: Investigate reports of broken section toggling - https://phabricator.wikimedia.org/T114622#1701160 (10MZMcBride) I wonder if T114599 is related. [00:31:45] 10MediaWiki-RfCs, 10MediaWiki-User-login-and-signup, 7I18n, 5Patch-For-Review: Allow user login with email address in addition to username - https://phabricator.wikimedia.org/T30085#1701162 (10Tgr) The RFC discourages case-sensitive email addresses (StackExchange has [[ http://programmers.stackexchange.com... [00:43:50] 10MediaWiki-RfCs, 10EventBus, 6Services, 10Wikipedia-iOS-App-Product-Backlog: Implementation sketch for reliable event bus using Kafka - https://phabricator.wikimedia.org/T88459#1701164 (10Spage) Cool stuff! >>! In T88459#1690504, @GWicke wrote: > @Neil_P._Quinn_WMF brought up some good points about the st... [00:50:15] 10MediaWiki-Email, 10MediaWiki-Extension-Requests, 10MediaWiki-extensions-GPGMail, 6Collaboration-Team-Backlog, and 3 others: Encrypt emails with GnuPG (GPG) - https://phabricator.wikimedia.org/T12453#1701165 (10Tgr) >>! In T12453#1697845, @Anomie wrote: > How so? AlternateUserMailer gets $headers, $to, $f... [00:51:04] 10MediaWiki-extensions-Other, 7Easy: [Convert2Wiki] PHP Parse error in extensions/Convert2Wiki/src/test/api/APITest.php on line 22 - https://phabricator.wikimedia.org/T70707#1701166 (10Liuxinyu970226) [00:58:58] 10MediaWiki-General-or-Unknown, 10Analytics, 6Discovery, 10EventBus, and 6 others: EventBus MVP - https://phabricator.wikimedia.org/T114443#1701171 (10Nuria) >@Ottomata, main reason would be the ability to work with $simple_queue, $binary_kafka, $amazon_queue and so on without changes in MW code. This isn'... [00:59:29] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-Other: Update DisableAccount to use AuthManager - https://phabricator.wikimedia.org/T110765#1701172 (10Liuxinyu970226) [01:00:36] 6Wikisource: Advanced editor toolbar doesn't load the Proofreading tools portion on first try - https://phabricator.wikimedia.org/T114553#1701174 (10Ineuw) In Xubuntu 14.04 I opened about 10 pages in sequence in edit mode and it was OK. In Windows, I disabled the MS antivirus, rebooted and it didn't make a dif... [01:12:00] 6Phabricator, 5Release: Next phabricator upgrade - 2015-09-02 - https://phabricator.wikimedia.org/T110443#1701180 (10MZMcBride) Did this upgrade happen? Has a future upgrade been scheduled? I'm trying to answer T109956#1700793. [01:12:37] 10MediaWiki-extensions-GPGMail, 10Security-Reviews: Security review for GPGMail - https://phabricator.wikimedia.org/T114341#1701183 (10Liuxinyu970226) [01:14:43] 10MediaWiki-extensions-OpenStackManager, 6Labs, 10wikitech.wikimedia.org: Adding a user to a project results in a blank page with the user added to the project but no shell access - https://phabricator.wikimedia.org/T114229#1688874 (10Krenair) [01:17:03] 10MediaWiki-General-or-Unknown, 10Analytics, 6Discovery, 10EventBus, and 6 others: EventBus MVP - https://phabricator.wikimedia.org/T114443#1701193 (10GWicke) @Nuria, see the task description, heading "Initial use cases". [01:18:42] (03PS1) 10Alex Monk: Don't record members on bastion project page [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/243603 (https://phabricator.wikimedia.org/T114229) [01:19:27] 10MediaWiki-General-or-Unknown, 10Analytics, 6Discovery, 10EventBus, and 6 others: EventBus MVP - https://phabricator.wikimedia.org/T114443#1701197 (10ori) >>! In T114443#1701193, @GWicke wrote: > @Nuria, see the task description, heading "Initial use cases". Potential applications are one thing; a concis... [01:19:40] 10MediaWiki-extensions-TestLanguageNameGrammar: add ULS for language selection to TestLanguageNameGrammar - https://phabricator.wikimedia.org/T105594#1701198 (10Liuxinyu970226) [01:24:11] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-OAuthAuthentication, 6Reading-Infrastructure-Team: Update OAuthAuthentication to use AuthManager - https://phabricator.wikimedia.org/T110460#1701201 (10Liuxinyu970226) [01:25:00] 10MediaWiki-extensions-OpenStackManager, 6Labs, 10wikitech.wikimedia.org, 5Patch-For-Review: Adding a user to a project results in a blank page with the user added to the project but no shell access - https://phabricator.wikimedia.org/T114229#1701202 (10Krenair) The patch above is live hacked, uncommitted,... [01:27:33] (03CR) 10Alex Monk: "If someone would like to review this, we can get it backported to the current deployment branch and the copy on tin sorted out (and proper" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/243603 (https://phabricator.wikimedia.org/T114229) (owner: 10Alex Monk) [01:49:31] 10MediaWiki-General-or-Unknown, 10Analytics, 6Discovery, 10EventBus, and 6 others: EventBus MVP - https://phabricator.wikimedia.org/T114443#1701206 (10GWicke) [01:53:29] 10MediaWiki-General-or-Unknown, 10Analytics, 6Discovery, 10EventBus, and 6 others: EventBus MVP - https://phabricator.wikimedia.org/T114443#1701209 (10GWicke) [01:53:41] 10MediaWiki-General-or-Unknown, 10Analytics, 6Discovery, 10EventBus, and 6 others: EventBus MVP - https://phabricator.wikimedia.org/T114443#1695470 (10GWicke) @ori, I changed the text to clarify which of those are potential, and which are concrete plans for this quarter. Please follow the provided links if... [01:59:23] (03CR) 10Subramanya Sastry: "Agree with Gabriel here. This should point to a combo of DOM spec version + API version (since both are important and can change independe" [core] - 10https://gerrit.wikimedia.org/r/243269 (https://phabricator.wikimedia.org/T108226) (owner: 10Florianschmidtwelzow) [02:07:29] (03CR) 10GWicke: "We expose the expected mime type in the RESTBase swagger spec, which is available at https://en.wikipedia.org/api/rest_v1/?spec." [core] - 10https://gerrit.wikimedia.org/r/243269 (https://phabricator.wikimedia.org/T108226) (owner: 10Florianschmidtwelzow) [02:10:16] 10MediaWiki-extensions-OpenStackManager, 6Labs, 10wikitech.wikimedia.org, 5Patch-For-Review: Adding a user to a project results in a blank page with the user added to the project but no shell access - https://phabricator.wikimedia.org/T114229#1701214 (10scfc) Thanks. Just to recap: The slowness comes not... [03:00:21] 4(no projects): Add 'Translation' namespace for bnwikisource - https://phabricator.wikimedia.org/T114623#1701216 (10jayantanth) 3NEW [03:02:05] 4(no projects): Add 'Translation' namespace for bnwikisource - https://phabricator.wikimedia.org/T114623#1701222 (10jayantanth) [03:04:33] 4(no projects): Add 'Translation' namespace for bnwikisource - https://phabricator.wikimedia.org/T114623#1701224 (10jayantanth) [03:04:34] 10Wikimedia-General-or-Unknown, 7Tracking: Bengali Wiki projects (tracking) - https://phabricator.wikimedia.org/T42760#1701225 (10jayantanth) [03:31:23] 6Wikisource: Add 'Translation' namespace for bnwikisource - https://phabricator.wikimedia.org/T114623#1701226 (10jayantanth) [03:43:29] 10Wikimedia-General-or-Unknown, 7Tracking: Bengali Wiki projects (tracking) - https://phabricator.wikimedia.org/T42760#1701228 (10Liuxinyu970226) [03:48:30] 10MediaWiki-extensions-ContentTranslation: Incorrect permission error on direct Special:ContentTranslation link - https://phabricator.wikimedia.org/T114497#1701231 (10KartikMistry) Is CX enabled in Beta preferences? [04:01:02] (03PS1) 10Majr: Fix mw.notify not being visible if first loaded when scrolled down [core] - 10https://gerrit.wikimedia.org/r/243605 (https://phabricator.wikimedia.org/T114606) [04:01:38] (03CR) 10jenkins-bot: [V: 04-1] Fix mw.notify not being visible if first loaded when scrolled down [core] - 10https://gerrit.wikimedia.org/r/243605 (https://phabricator.wikimedia.org/T114606) (owner: 10Majr) [04:04:29] 10Wikimedia-Site-Requests, 6Wikisource: Add 'Translation' namespace for bnwikisource - https://phabricator.wikimedia.org/T114623#1701237 (10Mattflaschen) [04:13:29] (03PS2) 10Majr: Fix mw.notify not being visible if first loaded when scrolled down [core] - 10https://gerrit.wikimedia.org/r/243605 (https://phabricator.wikimedia.org/T114606) [04:38:19] 3Outreachy-Round-11: Select #Possible-Tech-Projects ready for Outreachy Round 11 - https://phabricator.wikimedia.org/T112620#1701266 (10NiharikaKohli) I don't see a need for "Featured in Grants", why would anyone apply for a grant instead of Outreachy? And anyway, this board is for mentorship program only, right... [04:39:03] 10MediaWiki-RfCs, 10MediaWiki-User-login-and-signup, 7I18n, 5Patch-For-Review: Allow user login with email address in addition to username - https://phabricator.wikimedia.org/T30085#1701267 (10devunt) @Tgr Then keeping old email addresses as same as now and only saving new email addresses as lowercase woul... [04:45:03] 3Outreachy-Round-11: Select #Possible-Tech-Projects ready for Outreachy Round 11 - https://phabricator.wikimedia.org/T112620#1701269 (10TasneemLo) @NiharikaKohli, The reason I brought this up was because of this task : T91748 [04:46:03] (03PS23) 10devunt: [WIP] Make users can login with their email address [core] - 10https://gerrit.wikimedia.org/r/229140 (https://phabricator.wikimedia.org/T30085) [04:46:06] 10MediaWiki-RfCs, 10MediaWiki-User-login-and-signup, 7I18n, 5Patch-For-Review: Allow user login with email address in addition to username - https://phabricator.wikimedia.org/T30085#1701271 (10DanielFriesen) >>! In T30085#1701267, @devunt wrote: > @Tgr Then keeping old email addresses as same as now and on... [04:46:10] (03PS1) 10Aaron Schulz: Cleanups to MigrateFileRepoLayout [core] - 10https://gerrit.wikimedia.org/r/243606 [04:56:36] (03PS24) 10devunt: [WIP] Make users can login with their email address [core] - 10https://gerrit.wikimedia.org/r/229140 (https://phabricator.wikimedia.org/T30085) [05:00:50] 10MediaWiki-Vendor, 7Software-Licensing: License and author information missing from Vendor repo - https://phabricator.wikimedia.org/T114580#1701276 (10Legoktm) > Both are listed in https://github.com/kzykhys/Pygments.php/blob/master/composer.json so for some reason our vendor repo isn't picking them up They'... [05:04:00] (03PS25) 10devunt: [WIP] Make users can login with their email address [core] - 10https://gerrit.wikimedia.org/r/229140 (https://phabricator.wikimedia.org/T30085) [05:07:56] 10MediaWiki-Codesniffer, 5Patch-For-Review: @codingStandardsIgnoreStart Generic.Files.LineLength.TooLong doesn't seem to work in tests/phpunit/includes/password/BcryptPasswordTest.php - https://phabricator.wikimedia.org/T114213#1701283 (10Legoktm) >>! In T114213#1699845, @Umherirrender wrote: > maybe this comm... [05:08:59] (03CR) 10devunt: "PS25: `FetchUserIdsByEmailAddr` hook has added." [core] - 10https://gerrit.wikimedia.org/r/229140 (https://phabricator.wikimedia.org/T30085) (owner: 10devunt) [05:15:46] (03PS1) 10Aaron Schulz: Enforce $wgReadOnly on the DB layer [core] - 10https://gerrit.wikimedia.org/r/243609 [05:16:50] (03PS1) 10Aaron Schulz: Remove setting of $wgReadOnly in LBFactoryMulti [core] - 10https://gerrit.wikimedia.org/r/243610 [05:18:12] (03CR) 10jenkins-bot: [V: 04-1] Enforce $wgReadOnly on the DB layer [core] - 10https://gerrit.wikimedia.org/r/243609 (owner: 10Aaron Schulz) [05:22:42] 6Education-Collab: Mark education portal pages on Outreach wiki for translation - https://phabricator.wikimedia.org/T111383#1701287 (10Selsharbaty-WMF) Thanks for your comment, @Base. That's a good idea to be considered by the one who will claim this task: Marking major pages before minor ones. [05:23:50] (03PS2) 10Aaron Schulz: Enforce $wgReadOnly on the DB layer [core] - 10https://gerrit.wikimedia.org/r/243609 [05:23:57] (03PS12) 10Mooeypoo: Add browser test for notifications in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242016 (https://phabricator.wikimedia.org/T113081) [05:24:31] (03PS2) 10Aaron Schulz: Update various @params from DatabaseBase to IDatabase [core] - 10https://gerrit.wikimedia.org/r/243488 [05:29:12] 6Education-Collab: Fix the wikicode templates at Outreach:Wikimedia:Starting an education program so new education program plans are not created as subpages of Education Portal/Program Plans/ but rather as subpages of Education/Program plans/ and move existing pl... - https://phabricator.wikimedia.org/T114588#1699967 [05:41:21] (03PS3) 10Aaron Schulz: Enforce lagged-slave read-only mode on the DB layer [core] - 10https://gerrit.wikimedia.org/r/243609 [05:44:35] 6Education-Collab: Managing the WEP Facebook group (July:September 2015) - https://phabricator.wikimedia.org/T111397#1701294 (10Selsharbaty-WMF) @Shangkuanlc You are right. I will mark it resolved. @Vojtech.dostal Thank you for supporting the group so far! [05:44:54] 6Education-Collab: Managing the WEP Facebook group (July:September 2015) - https://phabricator.wikimedia.org/T111397#1701295 (10Selsharbaty-WMF) 5Open>3Resolved [05:46:05] 10MediaWiki-General-or-Unknown, 10Analytics, 6Discovery, 10EventBus, and 6 others: EventBus MVP - https://phabricator.wikimedia.org/T114443#1701296 (10Joe) Apart from the concerns on a practical use case which I agree with, I have a big doubt about the implementation idea: I am in general a fan of the par... [05:47:25] (03PS4) 10TTO: Allow change tags to be added via API action=delete [core] - 10https://gerrit.wikimedia.org/r/230526 (https://phabricator.wikimedia.org/T108654) [05:48:35] (03CR) 10TTO: "The reason why I shifted around some of this logic is so that, if the user has neither permission to delete nor to tag, the delete permiss" [core] - 10https://gerrit.wikimedia.org/r/230526 (https://phabricator.wikimedia.org/T108654) (owner: 10TTO) [05:48:36] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Technical-Debt: Problematic inline script - https://phabricator.wikimedia.org/T95329#1701298 (10Ricordisamoa) 5duplicate>3Invalid a:3Ricordisamoa >>! In T95329#1601552, @thiemowmde wrote: > Since I started working on Wikibase it was going through... [05:48:54] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Technical-Debt: Problematic inline script - https://phabricator.wikimedia.org/T95329#1701301 (10Ricordisamoa) a:5Ricordisamoa>3None [05:49:16] (03PS1) 10devunt: [WIP] Add `FetchUserNamesByEmail` hook support [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/243612 [05:49:58] 6Education-Collab: Managing the WEP Facebook group (October:December 2015) - https://phabricator.wikimedia.org/T114627#1701303 (10Selsharbaty-WMF) 3NEW a:3Roxana [05:52:33] 10MediaWiki-General-or-Unknown, 10Analytics, 6Discovery, 10EventBus, and 6 others: EventBus MVP - https://phabricator.wikimedia.org/T114443#1701312 (10Joe) >>! In T114443#1698223, @GWicke wrote: > @ottomata, main reason would be the ability to work with $simple_queue, $binary_kafka, $amazon_queue and so on... [05:52:40] 10MediaWiki-File-management, 10MediaWiki-RfCs, 6Multimedia: Provide semantic wiki-configurable styles for media display - https://phabricator.wikimedia.org/T90914#1701313 (10Nihiltres) Off the top of my head, my thoughts for the key kinds of styles are: * **Generic thumbnails**. The default. Fills more or l... [05:53:36] (03PS26) 10devunt: [WIP] Make users can login with their email address [core] - 10https://gerrit.wikimedia.org/r/229140 (https://phabricator.wikimedia.org/T30085) [05:55:13] 6Education-Collab: Determine if Phabricator training is needed/wanted by Education Collab members, and if so, plan and lead this training - https://phabricator.wikimedia.org/T114573#1701316 (10Selsharbaty-WMF) Added to 10/5 Collab meeting agenda. Thanks, Anna! [05:55:52] (03PS2) 10devunt: [WIP] Add `FetchUserNamesByEmail` hook support [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/243612 [05:56:59] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Make users can login with their email address [core] - 10https://gerrit.wikimedia.org/r/229140 (https://phabricator.wikimedia.org/T30085) (owner: 10devunt) [05:57:35] 10MediaWiki-API: Improve API's "permission denied" error message - https://phabricator.wikimedia.org/T114628#1701317 (10TTO) 3NEW [05:57:53] (03PS27) 10devunt: [WIP] Make users can login with their email address [core] - 10https://gerrit.wikimedia.org/r/229140 (https://phabricator.wikimedia.org/T30085) [05:58:57] 10Wikimedia-General-or-Unknown, 7Database, 7Regression: User skin preference changed to default skin (Vector) on when it was set to MonoBook on small and medium wikis (about 95% of wikis) - https://phabricator.wikimedia.org/T114208#1701324 (10Nemo_bis) a:3jcrespo Thanks. There can only be one assignee, hen... [05:59:00] (03CR) 10devunt: "PS27: Hook name `FetchUserIdsByEmailAddr` has been changed to `FetchUserNamesByEmail`" [core] - 10https://gerrit.wikimedia.org/r/229140 (https://phabricator.wikimedia.org/T30085) (owner: 10devunt) [05:59:59] 6Education-Collab: Managing the WEP Facebook group (July:September 2015) - https://phabricator.wikimedia.org/T111397#1701326 (10Shangkuanlc) I may able to help this, I think. And also, this makes me wondering, does it make sense we make collaborative member list in the group to show which fb account is which wik... [06:01:41] 6Education-Collab: Recruit a Collab member from Asia - https://phabricator.wikimedia.org/T111401#1701327 (10Selsharbaty-WMF) @Shangkuanlc Thanks for flagging this topic and discussing it with Anna. Floor and I have also been discussing it last week. I think it would be great to discuss it in our next online mee... [06:08:29] 10MediaWiki-Special-pages, 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-cxserver, 10Parsoid, and 3 others: Special:Version should show the versions of services that a wiki uses - https://phabricator.wikimedia.org/T108226#1701328 (10Florian) I think, that Special:Version should show the c... [06:08:42] 10MediaWiki-Special-pages, 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-cxserver, 10Parsoid, and 2 others: Special:Version should show the versions of services that a wiki uses - https://phabricator.wikimedia.org/T108226#1701329 (10Florian) [06:09:12] 6Education-Collab: Get all Collab members onto Phabricator and subscribed to the Education-Collab project - https://phabricator.wikimedia.org/T114572#1701331 (10Selsharbaty-WMF) I'd not encourage getting everyone subscribed to the Collab project on phabricator because subscribers get email messages for every cha... [06:10:08] 10MediaWiki-File-management, 10MediaWiki-RfCs, 6Multimedia: Provide semantic wiki-configurable styles for media display - https://phabricator.wikimedia.org/T90914#1701333 (10Nihiltres) An annoying case I forgot: * **Overlapping/composite images**, e.g. as with {{[[ https://en.wikipedia.org/wiki/Template:Loc... [06:10:21] 6Education-Collab: Get all Collab members onto Phabricator and subscribed to the Education-Collab project - https://phabricator.wikimedia.org/T114572#1701334 (10Selsharbaty-WMF) I'd not encourage getting everyone subscribed to the Collab project on phabricator because subscribers get email messages for every cha... [06:12:01] 6Education-Collab: Recruit a Collab member from Asia - https://phabricator.wikimedia.org/T111401#1701341 (10Shangkuanlc) >>! In T111401#1701327, @Selsharbaty-WMF wrote: > @Shangkuanlc Thanks for flagging this topic and discussing it with Anna. Floor and I have also been discussing it last week. I think it would... [06:16:28] 10OpenBadges, 10Wikimedia-Developer-Summit-2016: WikiBadge - https://phabricator.wikimedia.org/T114400#1701343 (10Nasirkhan) There is no direct relation with the [[https://phabricator.wikimedia.org/tag/openbadges|OpenBadges]] and there are some major differences with that. For example this tool will be a stand... [06:19:07] 6Education-Collab: Recruit a Collab member from Asia - https://phabricator.wikimedia.org/T111401#1701344 (10Selsharbaty-WMF) Sorry to hear that you're not able to join us but so happy that you'll be having nice time (hopefully) in Alcatraz!!! :D I'm not in SF at the moment. I work remotely from Egypt. But since... [06:22:50] 6Education-Collab: Managing the WEP Facebook group (July:September 2015) - https://phabricator.wikimedia.org/T111397#1701345 (10Selsharbaty-WMF) I don't understand what you mean by "make collaborative member list in the group"? BTW, I have created a new task, [[ https://phabricator.wikimedia.org/T114627 | here... [06:34:55] 6Education-Collab: Updating WEP honor board page on Ar.Wiki - https://phabricator.wikimedia.org/T114070#1701346 (10Selsharbaty-WMF) Thanks for updating! Awesome as usual, @Walaa! [06:36:04] 7Design, 6Community-Tech: Prototype for RevisionSlider - https://phabricator.wikimedia.org/T114335#1701347 (10Qgil) [06:47:59] 10Wikimedia-Site-Requests, 6Wikisource: Add 'Translation' namespace for bnwikisource - https://phabricator.wikimedia.org/T114623#1701352 (10Billinghurst) can I suggest ns:114/115 as per enWS's implementation of that concept. May as well look to a pseudo-standard. [06:49:53] 6Education-Collab: Creating a twitter account for Wikipedia Education Program - https://phabricator.wikimedia.org/T113951#1701353 (10Selsharbaty-WMF) I'd, personally, go for a "Wikipedia Education Program" account for some reasons. For example: 1. More activity to post: if it's a WEP account there will be update... [06:51:14] 6Education-Collab: Contribute posts to the Education Newsletter - https://phabricator.wikimedia.org/T111350#1701354 (10Selsharbaty-WMF) @SaraMortsell Yes, please do! [06:52:03] 10Wikimedia-Site-Requests, 6Wikisource: Add 'Translation' namespace for bnwikisource - https://phabricator.wikimedia.org/T114623#1701357 (10Aklapper) @jayantanth: For future reference how to request these kinds of changes, please see https://meta.wikimedia.org/wiki/Requesting_wiki_configuration_changes - thanks! [06:59:29] (03CR) 10Aude: Add more test cases to OldChangesListTest (031 comment) [core] - 10https://gerrit.wikimedia.org/r/157661 (owner: 10Aude) [06:59:43] 6Wikisource: Advanced editor toolbar doesn't load the Proofreading tools portion on first try - https://phabricator.wikimedia.org/T114553#1701359 (10Billinghurst) It is less likely to be the 'hiding' as that would hide the items after they have been identified on the sub-toolbar. It is the sub-toolbar component... [07:03:25] (03PS28) 10devunt: [WIP] Make users can login with their email address [core] - 10https://gerrit.wikimedia.org/r/229140 (https://phabricator.wikimedia.org/T30085) [07:04:22] 6Education-Collab: Managing the WEP Facebook group (October:December 2015) - https://phabricator.wikimedia.org/T114627#1701362 (10Shangkuanlc) [07:05:28] 6Education-Collab: Managing the WEP Facebook group (July:September 2015) - https://phabricator.wikimedia.org/T111397#1701363 (10Shangkuanlc) Thank you. What I mean is like[[ https://www.facebook.com/notes/wikipedia-education-program/facebook-wikimedia-user-account-list/1182869765061004 | this link ]], we make a... [07:07:20] 6Education-Collab: Open an EDU event calendar - https://phabricator.wikimedia.org/T111968#1701365 (10Shangkuanlc) how about google calendar? maybe we can make a public calendar just like [[https://meta.wikimedia.org/wiki/IRC_office_hours|office-hour]]'s effort. [07:10:12] (03PS29) 10devunt: [WIP] Make users can login with their email address [core] - 10https://gerrit.wikimedia.org/r/229140 (https://phabricator.wikimedia.org/T30085) [07:11:36] 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release6, 3LE-CX6-Sprint break, 5Patch-For-Review, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): Execute fix-stats.php on production - https://phabricator.wikimedia.org/T112626#1701367 (10Arrbee) To be available this Thursday [07:13:29] 10Wikimedia-Site-Requests, 6Wikisource: Add 'Translation' namespace for bnwikisource - https://phabricator.wikimedia.org/T114623#1701372 (10Revi) Please point the local discussion about this? Thanks! [07:14:14] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Make users can login with their email address [core] - 10https://gerrit.wikimedia.org/r/229140 (https://phabricator.wikimedia.org/T30085) (owner: 10devunt) [07:15:26] (03PS6) 10Aude: Register Wikibase coordinates as GeoData in ParserOutput [WIP] [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/243158 (https://phabricator.wikimedia.org/T75482) [07:20:50] 3Outreachy-Round-11: Select #Possible-Tech-Projects ready for Outreachy Round 11 - https://phabricator.wikimedia.org/T112620#1701381 (10Qgil) How I think the workboard should work. I think we need to leave IEG out of the equation. "Featured for GSoC and Outreachy" (software development) and "Featured for Outrea... [07:23:58] 10OpenBadges, 10Wikimedia-Developer-Summit-2016: WikiBadge - https://phabricator.wikimedia.org/T114400#1701382 (10Aklapper) As this is proposed for Wikimedia-Developer-Summit-2016 I'm curious if there are already some architectural drafts for this tool that one could take a look at, or even code? [07:26:50] 10MediaWiki-Page-editing, 5Patch-For-Review: Inform author of successful edit conflict resolution - https://phabricator.wikimedia.org/T76997#1701383 (10Schnark) Yet another example, only a few days old: [[https://de.wikipedia.org/w/index.php?title=Wikipedia:Vandalismusmeldung&diff=prev&oldid=146627055|first ed... [07:28:37] (03PS30) 10devunt: [WIP] Make users can login with their email address [core] - 10https://gerrit.wikimedia.org/r/229140 (https://phabricator.wikimedia.org/T30085) [07:32:11] (03PS3) 10devunt: Add `FetchUserNamesByEmail` hook support [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/243612 [07:32:27] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Make users can login with their email address [core] - 10https://gerrit.wikimedia.org/r/229140 (https://phabricator.wikimedia.org/T30085) (owner: 10devunt) [07:33:41] (03PS31) 10devunt: [WIP] Make users can login with their email address [core] - 10https://gerrit.wikimedia.org/r/229140 (https://phabricator.wikimedia.org/T30085) [07:35:40] 10MediaWiki-RfCs, 10Wikimedia-Developer-Summit-2016: RfC: Dependency injection - https://phabricator.wikimedia.org/T384#1701395 (10daniel) @Tgr thanks for the excellent explanation of what's wrong with RequetsContext! [07:40:44] (03CR) 10Bene: [C: 04-1] "I don't think it's a good idea to make yet another extension using Wikibase stuff. Imo we should do this within Wikibase.git and let it op" [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/243158 (https://phabricator.wikimedia.org/T75482) (owner: 10Aude) [07:50:37] (03CR) 10TTO: "Ping @Legoktm again :)" [core] - 10https://gerrit.wikimedia.org/r/230998 (https://phabricator.wikimedia.org/T108427) (owner: 10TTO) [07:54:54] 6Wikisource: Advanced editor toolbar doesn't load the Proofreading tools portion on first try - https://phabricator.wikimedia.org/T114553#1701403 (10Ineuw) I am using Windows at this moment and tested Chrome and Opera extensively. It works fine in bot browsers, so the problem seems to be with Firefox. Another us... [08:05:19] 7HHVM, 7Performance: Performance issue in HHVM with output buffer? - https://phabricator.wikimedia.org/T87553#1701409 (10Joe) Since we long ago deployed an output streaming support patch to HHVM, I guess this is resolved? [08:05:26] 7HHVM, 7Performance: Performance issue in HHVM with output buffer? - https://phabricator.wikimedia.org/T87553#1701410 (10Joe) 5Open>3Resolved [08:08:17] 6Wikisource: Advanced editor toolbar doesn't load the Proofreading tools portion on first try - https://phabricator.wikimedia.org/T114553#1701412 (10Aklapper) >>! In T114553#1701403, @Ineuw wrote: > Could this be cause by a Firefox extension (addon)? I don't know as I did not write your Firefox extensions/addon... [08:15:45] 10MediaWiki-Documentation, 10Possible-Tech-Projects, 6WMF-Legal, 10Web-APIs-Hub, 7Documentation: technology to transclude git content into wiki pages - https://phabricator.wikimedia.org/T91626#1701413 (10Spage) >>! In T91626#1701012, @Aklapper wrote: > Hi @Laucon, thanks for your interest! Yes, that's g... [08:17:11] 4(no projects): Access to WMDE BLOG Jan-Julia - https://phabricator.wikimedia.org/T105336#1701414 (10Aklapper) @johl: Any news? This has been stalled for more than two months. [08:18:20] (03CR) 10Aude: "easy enough to put this in Wikibase if that's what everyone prefers, though not totally sure that's a good idea :)" [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/243158 (https://phabricator.wikimedia.org/T75482) (owner: 10Aude) [08:18:57] 10MediaWiki-extensions-OpenStackManager, 6Labs, 10wikitech.wikimedia.org, 5Patch-For-Review: Adding a user to a project results in a blank page with the user added to the project but no shell access - https://phabricator.wikimedia.org/T114229#1701416 (10Krenair) Yep. [08:19:28] 10MediaWiki-extensions-Collection: Generating PDFs for books with more than one page fails horribly at pl.wikisource - https://phabricator.wikimedia.org/T49575#1701419 (10Aklapper) 5Open>3Resolved a:3Aklapper Works now with https://pl.wikisource.org/wiki/Wiki%C5%BAr%C3%B3d%C5%82a:Ksi%C4%85%C5%BCki/Copp%C3%... [08:23:12] 10MediaWiki-Codesniffer, 5Patch-For-Review: @codingStandardsIgnoreStart only works with // comments - https://phabricator.wikimedia.org/T114213#1701423 (10Amire80) [08:23:57] (03CR) 10Hoo man: "re" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/157661 (owner: 10Aude) [08:24:53] 10MediaWiki-extensions-Collection: Collection should process redirects - https://phabricator.wikimedia.org/T43046#1701424 (10Aklapper) I go to https://de.wikipedia.org/wiki/Benutzer:Wikinaut/B%C3%BCcher/Dresden and click "PDF". The result does include the content of the article "Hochwasser in Mitteleuropa 2002"... [08:26:09] 10MediaWiki-extensions-GeoData, 7Testme: Duplicate primary tags - https://phabricator.wikimedia.org/T55539#1701426 (10Aklapper) >>! In T55539#574689, @MaxSem wrote: > (In reply to comment #5) >> Is this fixed (the patch was merged)? > > We'll see. > >> Also how do I test. > > You can't Could somebody pleas... [08:26:16] (03PS1) 10Amire80: Re-enable Generic.Files.LineLength and exclude failing files [core] - 10https://gerrit.wikimedia.org/r/243616 (https://phabricator.wikimedia.org/T102614) [08:27:05] 10MediaWiki-extensions-GlobalBlocking, 7IPv6: Local Special:GlobalBlockStatus does not work at all - https://phabricator.wikimedia.org/T56496#1701431 (10Aklapper) p:5High>3Low >>! In T56496#593799, @csteipp wrote: > So deleting and re-issuing the whitelist should work. I'm guessing the global block was iss... [08:32:11] 10MediaWiki-extensions-Translate, 5Patch-For-Review: Autosuggest feature to access operators - https://phabricator.wikimedia.org/T98559#1701434 (10Nikerabbit) 5Open>3Resolved [08:32:24] (03PS1) 10MarcoAurelio: Localization updates for Scribunto.namespaces from Meta [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/243617 [08:32:53] (03PS5) 10Matt Fitzpatrick: Whitelist additional WAI-ARIA attributes, implement a role whitelist [core] - 10https://gerrit.wikimedia.org/r/243383 (https://phabricator.wikimedia.org/T26659) [08:34:28] 10Wikimedia-General-or-Unknown, 7Database, 7Regression: User skin preference changed to default skin (Vector) on when it was set to MonoBook on small and medium wikis (about 95% of wikis) - https://phabricator.wikimedia.org/T114208#1701437 (10jcrespo) a:5jcrespo>3None Will send a private mail to @greg why. [08:36:01] 10MediaWiki-extensions-ContentTranslation: ContentTranslation triggers JavaScript error (TypeError: $.uls is undefined: load.php:157:1) - https://phabricator.wikimedia.org/T114610#1701439 (10TTO) [08:36:03] 10MediaWiki-extensions-ContentTranslation: Unable to get property 'data' of undefined or null reference File: ext.cx.interlanguagelink.js, Line: 54, Column: 4 - https://phabricator.wikimedia.org/T114462#1701440 (10TTO) [08:36:24] (03CR) 10Amire80: "This is an alternative approach to I7343e1cf662c5bf12a5e4385646c5c2c4a798260 ." [core] - 10https://gerrit.wikimedia.org/r/243616 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [08:36:31] 10SyntaxHighlight: "cpp-qt" entry missing in SyntaxHighlight_GeSHi.langs.php - https://phabricator.wikimedia.org/T114630#1701442 (10Tomikais) 3NEW [08:37:25] (03CR) 10Amire80: "The alternative suggestion committed as Ia991239ba20ebf86e83780ad95c0d056d632eaa1" [core] - 10https://gerrit.wikimedia.org/r/243418 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [08:39:06] (03CR) 10Hashar: "Not sure whom. There is a lot of changes and the extension is deployed on production wiki so that is potentially dangerous." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/241712 (owner: 10Siebrand) [08:39:32] 10MediaWiki-extensions-Collection: Collection should process redirects - https://phabricator.wikimedia.org/T43046#1701449 (10Wikinaut) @Aklapper: yes,confirmed. The problem appears to be solved now. (pls. close the issue). [08:40:03] (03CR) 10MarcoAurelio: "check zend" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/243617 (owner: 10MarcoAurelio) [08:41:17] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Performance, 7Story: [Story] Sane Lua label access in user language - https://phabricator.wikimedia.org/T75460#1701453 (10hoo) [08:43:43] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Performance, 7Story: [Story] Sane Lua label access in user language - https://phabricator.wikimedia.org/T75460#1701459 (10hoo) [08:45:13] (03CR) 10Matt Fitzpatrick: "Differences in patch set 5, per Daniel Kinzler's comments on patch set 4:" [core] - 10https://gerrit.wikimedia.org/r/243383 (https://phabricator.wikimedia.org/T26659) (owner: 10Matt Fitzpatrick) [08:46:22] (03PS5) 10Gergő Tisza: [WIP] MVP [extensions/GPGMail] - 10https://gerrit.wikimedia.org/r/242000 (https://phabricator.wikimedia.org/T12453) [08:46:38] 10Possible-Tech-Projects: Implement wikicode linting framework / library - https://phabricator.wikimedia.org/T114631#1701460 (10Petrb) 3NEW [08:48:40] 10Gerrit: check zend access - https://phabricator.wikimedia.org/T114632#1701467 (10MarcoAurelio) 3NEW [08:50:06] 6WMDE-Tech-Community-Communication, 3WMDE-TCC-Goal-2015-FOSS, 3WMDE-Tech-Community-Communication-Q3-30092015: Present GameJam at GameScienceCenter - https://phabricator.wikimedia.org/T113948#1701475 (10Juscwmde) 5Open>3Resolved [08:50:53] 10MediaWiki-Email, 10MediaWiki-Extension-Requests, 10MediaWiki-extensions-GPGMail, 6Collaboration-Team-Backlog, and 3 others: Encrypt emails with GnuPG (GPG) - https://phabricator.wikimedia.org/T12453#1701476 (10Tgr) Added PGP/MIME. Also tested both with Mailvelope, the results are somewhat mixed: * inline... [08:52:07] (03CR) 10TTO: Whitelist additional WAI-ARIA attributes, implement a role whitelist (032 comments) [core] - 10https://gerrit.wikimedia.org/r/243383 (https://phabricator.wikimedia.org/T26659) (owner: 10Matt Fitzpatrick) [08:56:19] 10MediaWiki-Authentication-and-authorization, 6Reading-Infrastructure-Team: Update UserThrottle to use AuthManager - https://phabricator.wikimedia.org/T110473#1701478 (10Liuxinyu970226) [08:56:45] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-Configure, 6Reading-Infrastructure-Team: Update Configure to (not) use AuthManager - https://phabricator.wikimedia.org/T110296#1701481 (10Liuxinyu970226) [08:57:08] (03PS1) 10Thiemo Mättig (WMDE): ApiBase::PARAM_DFLT => null is the default anyway [core] - 10https://gerrit.wikimedia.org/r/243618 [08:58:07] 10MediaWiki-Authentication-and-authorization, 6Reading-Infrastructure-Team: Update NewSignupPage to use AuthManager - https://phabricator.wikimedia.org/T110455#1701483 (10Liuxinyu970226) [08:58:44] 10MediaWiki-Email, 10MediaWiki-Extension-Requests, 10MediaWiki-extensions-GPGMail, 6Collaboration-Team-Backlog, and 3 others: Encrypt emails with GnuPG (GPG) - https://phabricator.wikimedia.org/T12453#1701486 (10Tgr) FWIW the email sources are in P2151. [09:00:13] (03CR) 10TheDJ: "Probably needs to be tested with Tidy and Parsoid ?" [core] - 10https://gerrit.wikimedia.org/r/243383 (https://phabricator.wikimedia.org/T26659) (owner: 10Matt Fitzpatrick) [09:01:16] (03CR) 10TTO: "Are you sure? The string is super super generic: "Please help translate to your language". It's not really a grammatical sentence in Engli" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/206482 (https://phabricator.wikimedia.org/T93782) (owner: 10Nemo bis) [09:05:12] 10MediaWiki-RfCs, 10Wikimedia-Developer-Summit-2016: [RFC] Hygienic templates - https://phabricator.wikimedia.org/T114445#1701496 (10Arlolra) Should hygiene have anything to say about nested anchor tags? Different document fragments, ```

this is a testis another testover here

``` vs ``... [09:05:47] 10MediaWiki-Codesniffer: Handle comments with multiple # - https://phabricator.wikimedia.org/T114633#1701497 (10TasneemLo) 3NEW a:3TasneemLo [09:06:01] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: [Bug] Labels used via mw.wikibase.label are not tracked - https://phabricator.wikimedia.org/T114634#1701507 (10hoo) 3NEW a:3hoo [09:11:00] (03PS2) 10Gergő Tisza: Add UserMailerTransformContent and UserMailerSplitTo hooks [core] - 10https://gerrit.wikimedia.org/r/242791 (https://phabricator.wikimedia.org/T12453) [09:11:10] (03CR) 10jenkins-bot: [V: 04-1] Add UserMailerTransformContent and UserMailerSplitTo hooks [core] - 10https://gerrit.wikimedia.org/r/242791 (https://phabricator.wikimedia.org/T12453) (owner: 10Gergő Tisza) [09:17:49] (03CR) 10Hashar: "check experimental" [extensions/timeline] - 10https://gerrit.wikimedia.org/r/72948 (owner: 10Hashar) [09:17:54] (03PS1) 10Phuedx: Use extension registration [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/243620 (https://phabricator.wikimedia.org/T87965) [09:17:56] (03PS6) 10Matt Fitzpatrick: Whitelist additional WAI-ARIA attributes, implement a role whitelist [core] - 10https://gerrit.wikimedia.org/r/243383 (https://phabricator.wikimedia.org/T26659) [09:18:11] 10MediaWiki-extensions-RelatedArticles, 5Patch-For-Review: Convert RelatedArticles to use extension registration - https://phabricator.wikimedia.org/T87965#1701527 (10phuedx) a:3phuedx [09:18:41] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: [Bug] Labels used via mw.wikibase.label are not tracked - https://phabricator.wikimedia.org/T114634#1701530 (10hoo) 5Open>3Invalid They are tracked, but we apparently no longer update usages on view (but in a job). [09:19:24] 10MediaWiki-API, 6operations, 7HHVM, 7Pywikibot-tests, 7Wikimedia-log-errors: internal_api_error_BadMethodCallException: [xxx] Exception Caught: Call to a member function getNames() on a non-object (NULL) - https://phabricator.wikimedia.org/T109929#1701532 (10Joe) 5Open>3Resolved [09:21:50] MatmaRex: I'll merge https://gerrit.wikimedia.org/r/#/c/243403/? Did you only +1 for a reason? [09:22:16] prtksxna: no, i mostly wanted you to see it first :) [09:28:37] 10Possible-Tech-Projects: Implement wikicode linting framework / library - https://phabricator.wikimedia.org/T114631#1701543 (10Petrb) [09:30:57] 10MediaWiki-extensions-GWToolset, 6Multimedia: Could GWToolset upload faster please? - https://phabricator.wikimedia.org/T114099#1701569 (10Hansmuller) My GWToolset job halted tonight from 04:24 - 07:40 5 October. Sometimes it helps to submit a tiny job (5 records throttle 1), at 07:57. Repeating this procedur... [09:34:08] (03PS7) 10Matt Fitzpatrick: Whitelist additional WAI-ARIA attributes, implement a role whitelist [core] - 10https://gerrit.wikimedia.org/r/243383 (https://phabricator.wikimedia.org/T26659) [09:38:26] (03CR) 10Hashar: [C: 04-1] "There must be a good reason for that autoload statement to be around. What kind of error have you experienced? You might want to explain" [extensions/cldr] - 10https://gerrit.wikimedia.org/r/243381 (owner: 10Paladox) [09:39:22] 10MediaWiki-Categories, 10MediaWiki-Special-pages, 10MediaWiki-extensions-ProofreadPage, 6Wikisource, 7Wikimedia-log-errors: Special:Categories on wikisource.org -> "Exception encountered, of type "Wikimedia\Assert\ParameterAssertionException" error - https://phabricator.wikimedia.org/T99736#1701594 (10TT... [09:41:51] (03CR) 10TTO: "Thanks. Just "@since 1.27" is enough :)" [core] - 10https://gerrit.wikimedia.org/r/243383 (https://phabricator.wikimedia.org/T26659) (owner: 10Matt Fitzpatrick) [09:45:27] (03PS8) 10Matt Fitzpatrick: Whitelist additional WAI-ARIA attributes, implement a role whitelist [core] - 10https://gerrit.wikimedia.org/r/243383 (https://phabricator.wikimedia.org/T26659) [09:47:00] 10MediaWiki-General-or-Unknown, 7Tracking: Database replication lag issues (tracking) - https://phabricator.wikimedia.org/T3268#1701609 (10jcrespo) [09:47:33] (03CR) 10Hashar: "Paladox, when you upload a new patchset doing modifications, you want to explain what you did in Gerrit :-D In this case:" [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/243117 (owner: 10Siebrand) [09:47:36] 6WMDE-Tech-Community-Communication, 3WMDE-TCC-Goal-2015-Outreach, 3WMDE-Tech-Community-Communication-Q3-30092015: (General) Make Wikidata Birthday Eventbrite Registration - https://phabricator.wikimedia.org/T114468#1701615 (10Juscwmde) 5Open>3Resolved [09:48:14] 10Possible-Tech-Projects: Implement wikicode linting framework / library - https://phabricator.wikimedia.org/T114631#1701618 (10Fannon) I think it's a great idea and I can immediately see the benefits of having a linter for wikitext! Some thoughts on it from my side: - Officially, every wikitext is valid. S... [09:49:05] (03CR) 10Hashar: [C: 031] "Will get it merged by a +2 after I have deployed the CI change https://gerrit.wikimedia.org/r/#/c/243156/" [extensions/InviteSignup] - 10https://gerrit.wikimedia.org/r/243110 (owner: 10Siebrand) [09:49:10] (03CR) 10Hashar: [C: 031] Add tests [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/243117 (owner: 10Siebrand) [09:51:47] (03CR) 10Hashar: [C: 031] "Will get it merged by a +2 after I have deployed the CI change https://gerrit.wikimedia.org/r/#/c/243156/" [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/243119 (owner: 10Siebrand) [09:53:23] (03CR) 10Matt Fitzpatrick: "Patch set 6 moves the role restriction logic out of validateAttributes() and into roleWhitelist()." [core] - 10https://gerrit.wikimedia.org/r/243383 (https://phabricator.wikimedia.org/T26659) (owner: 10Matt Fitzpatrick) [09:54:29] (03CR) 10Hashar: [C: 031] "Will get it merged by a +2 after I have deployed the CI change https://gerrit.wikimedia.org/r/#/c/243156/" [extensions/ContributionScores] - 10https://gerrit.wikimedia.org/r/242881 (owner: 10Siebrand) [09:54:31] (03CR) 10Paladox: "Need to re upload this patch and then re do check experiment." [extensions/timeline] - 10https://gerrit.wikimedia.org/r/72948 (owner: 10Hashar) [09:56:49] (03CR) 10Hashar: [C: 04-1] "This has too many impact. We should not bother running phpcs for now. Can you repurpose this change without phpcs please? Ie just introduc" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242934 (owner: 10Siebrand) [09:58:29] (03PS2) 10Paladox: Remove autoload from composer.json [extensions/cldr] - 10https://gerrit.wikimedia.org/r/243381 [09:59:39] 6WMDE-Tech-Community-Communication, 3WMDE-TCC-Goal-2015-Developer, 3WMDE-Tech-Community-Communication-Q3-30092015: Contact Pizza Delivery - https://phabricator.wikimedia.org/T111755#1701627 (10Juscwmde) 5Open>3Resolved [09:59:40] 6WMDE-Tech-Community-Communication, 3WMDE-TCC-Goal-2015-Developer, 3WMDE-Tech-Community-Communication-Q3-30092015: GAME JAM EPIC - https://phabricator.wikimedia.org/T107854#1701628 (10Juscwmde) [09:59:49] (03Abandoned) 10Aude: Register Wikibase coordinates as GeoData in ParserOutput [WIP] [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/243158 (https://phabricator.wikimedia.org/T75482) (owner: 10Aude) [10:01:38] 10Possible-Tech-Projects: Implement wikicode linting framework / library - https://phabricator.wikimedia.org/T114631#1701632 (10Petrb) Is really every wikitext valid? Even that which results in MediaWiki large red syntax errors after save? https://test.wikipedia.org/wiki/Broken_text [10:07:37] (03CR) 10Hashar: [C: 032] Add tests [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/243117 (owner: 10Siebrand) [10:07:43] (03CR) 10Hashar: [C: 032] Add tests [extensions/InviteSignup] - 10https://gerrit.wikimedia.org/r/243110 (owner: 10Siebrand) [10:07:48] (03CR) 10Hashar: [C: 032] Add tests [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/243119 (owner: 10Siebrand) [10:07:57] (03CR) 10Hashar: [C: 032] Add tests [extensions/ContributionScores] - 10https://gerrit.wikimedia.org/r/242881 (owner: 10Siebrand) [10:10:24] (03Merged) 10jenkins-bot: Add tests [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/243117 (owner: 10Siebrand) [10:10:26] (03Merged) 10jenkins-bot: Add tests [extensions/InviteSignup] - 10https://gerrit.wikimedia.org/r/243110 (owner: 10Siebrand) [10:10:43] (03PS9) 10Matt Fitzpatrick: Whitelist additional WAI-ARIA attributes, implement a role whitelist [core] - 10https://gerrit.wikimedia.org/r/243383 (https://phabricator.wikimedia.org/T26659) [10:11:55] 10MediaWiki-extensions-Collection, 10MediaWiki-extensions-Translate, 10OCG-General-or-Unknown: Make extension Translate compatible with extension Collection - https://phabricator.wikimedia.org/T114578#1701636 (10Kghbln) [10:13:13] (03Merged) 10jenkins-bot: Add tests [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/243119 (owner: 10Siebrand) [10:13:15] (03Merged) 10jenkins-bot: Add tests [extensions/ContributionScores] - 10https://gerrit.wikimedia.org/r/242881 (owner: 10Siebrand) [10:18:37] 10MediaWiki-extensions-TwnMainPage, 5Patch-For-Review, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): Allow "go" search feature to reach messages - https://phabricator.wikimedia.org/T62570#1701641 (10Nikerabbit) 5Open>3Resolved [10:21:12] Krenair: hey [10:21:53] 6Education-Collab: Create categories on outreach portal to help distinguish between K-12 collaborations vs. higher education ones - https://phabricator.wikimedia.org/T114011#1701646 (10Esh77) @Selsharbaty-WMF, shouldn't this task be claimed (if not done)..? [10:26:08] (03CR) 10Siebrand: "Please define "impact"?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242934 (owner: 10Siebrand) [10:47:30] (03CR) 10Hashar: "check experimental" [extensions/ActivityMonitor] - 10https://gerrit.wikimedia.org/r/224761 (owner: 10Hashar) [10:48:26] 10MediaWiki-extensions-ParserFunctions: #expr does not work properly - https://phabricator.wikimedia.org/T114516#1701677 (10XXN) >>! In T114516#1701027, @Aklapper wrote: > Isn't that a case for https://www.mediawiki.org/wiki/Help:Extension:ParserFunctions#.23ifexist ? > I'm not sure if there's actually a bug her... [10:49:03] (03PS2) 10Phuedx: Include foreign files in ApiQueryPageImages [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/243124 (https://phabricator.wikimedia.org/T98791) [10:50:16] 6Phabricator: Rename phabricator account from Revi to revi - https://phabricator.wikimedia.org/T110970#1701679 (10Revi) Hello? Any updates? What phabricator administrator have to do is just {nav icon=home, name=Home > icon=user, name=Revi > icon=tag, name=Change Username}. Does this take a month? [10:53:32] 10MediaWiki-RfCs: RFC: make Parser::getTargetLanguage aware of multilingual wikis - https://phabricator.wikimedia.org/T114640#1701681 (10daniel) 3NEW [10:54:16] 10MediaWiki-Parser, 10Wikidata, 5Patch-For-Review: [Task] Consistently and correctly get target or 'cached' language in ParserOptions when userlang option is used - https://phabricator.wikimedia.org/T109705#1701688 (10daniel) [10:54:38] 10MediaWiki-RfCs: RFC: make Parser::getTargetLanguage aware of multilingual wikis - https://phabricator.wikimedia.org/T114640#1701681 (10daniel) [10:55:27] 10MobileFrontend: Missing watchlist stars, search suggestions and more on English Wikipedia mobile site - https://phabricator.wikimedia.org/T114599#1701696 (10HairyDude) Update: Chrome and Naked Browser are now broken too. I guess I had old styles and scripts cached or something. [10:58:39] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: [Bug] Labels used via mw.wikibase.label are not tracked - https://phabricator.wikimedia.org/T114634#1701701 (10daniel) I think such updates got pushed to the job queue due to Aaron's work to get rid of all database writes on GET requests. [10:59:45] (03PS1) 10Beta16: Typo in Apihelp-linksuggest-example-1/en message [extensions/LinkSuggest] - 10https://gerrit.wikimedia.org/r/243633 [11:01:36] 10MobileFrontend: Missing watchlist stars, search suggestions and more on English Wikipedia mobile site - https://phabricator.wikimedia.org/T114599#1701704 (10HairyDude) >>! In T114599#1700811, @Jesant13 wrote: >>>! In T114599#1700297, @MZMcBride wrote: >> This sounds like a JavaScript issue of some kind. Are yo... [11:01:40] (03CR) 10Phuedx: [C: 04-1] "Commit message needs updating." [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/243124 (https://phabricator.wikimedia.org/T98791) (owner: 10Phuedx) [11:01:41] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: [Bug] Labels used via mw.wikibase.label are not tracked - https://phabricator.wikimedia.org/T114634#1701707 (10aude) @daniel T103429 :) [11:04:23] 10MediaWiki-extensions-ParserFunctions: #expr does not work properly - https://phabricator.wikimedia.org/T114516#1701710 (10TTO) 5Open>3Invalid a:3TTO [[https://ro.wikipedia.org/w/index.php?title=Categorie:2044&diff=10061020&oldid=10054057|Fixed]], there were invisible characters (U+200E and U+200F bidi ma... [11:04:33] 10Possible-Tech-Projects: Implement wikicode linting framework / library - https://phabricator.wikimedia.org/T114631#1701713 (10Aklapper) [11:06:02] 6Education-Collab: Decide how our Facebook group should be managed - https://phabricator.wikimedia.org/T111966#1701717 (10Esh77) I've created [[ https://www.facebook.com/groups/WikipediaEducationProgram/permalink/1182942511720396/?qa_ref=qd | a FB poll ]] and pinned it at the top of the Wikipedia Education Progr... [11:06:36] 10Possible-Tech-Projects: Implement wikicode linting framework / library - https://phabricator.wikimedia.org/T114631#1701718 (10Aklapper) CC'ing @ssastry and @cscott who might also be able to provide input on this project idea. See Also: * {T48705} (Parsoid) * {T94370} (Huggle) [11:08:00] 10Gerrit: Provide access to "check zend" - https://phabricator.wikimedia.org/T114632#1701720 (10Aklapper) [11:09:17] (03CR) 10Hashar: "check experimental" [extensions/ActivityMonitor] - 10https://gerrit.wikimedia.org/r/224761 (owner: 10Hashar) [11:09:24] (03CR) 10Hashar: "recheck" [extensions/ActivityMonitor] - 10https://gerrit.wikimedia.org/r/224761 (owner: 10Hashar) [11:27:50] 10Possible-Tech-Projects: Implement wikicode linting framework / library - https://phabricator.wikimedia.org/T114631#1701749 (10Qgil) [11:32:29] 6Developer-Relations, 3DevRel-December-2015, 3DevRel-November-2015, 3DevRel-October-2015: Organize and coordinate Wikimedia's participation in Google Code-In 2015 - https://phabricator.wikimedia.org/T111520#1701752 (10Aklapper) p:5Low>3Normal [11:33:15] 6Developer-Relations, 3DevRel-December-2015, 3DevRel-November-2015, 3DevRel-October-2015: Goal: Plan to prioritize code review of patches submitted by volunteers - https://phabricator.wikimedia.org/T78768#1701754 (10Aklapper) p:5Low>3Normal [11:39:20] 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release6, 5Patch-For-Review: Starting a new translation from a red link is not opening the right article - https://phabricator.wikimedia.org/T105915#1701772 (10santhosh) a:5santhosh>3None [11:39:28] 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release6: Starting a new translation from a red link is not opening the right article - https://phabricator.wikimedia.org/T105915#1454559 (10santhosh) [11:42:59] 10Possible-Tech-Projects, 7I18n: Linguistic Version Control for Polygraphia - https://phabricator.wikimedia.org/T94160#1701776 (10Qgil) Hi @sandsub95, what is the situation of this project? Are you working on it? [11:44:22] 3Outreachy-Round-11: Select #Possible-Tech-Projects ready for Outreachy Round 11 - https://phabricator.wikimedia.org/T112620#1701778 (10Qgil) Backlog column clean! still 16 tasks under "Re-check in September 2015". [11:46:02] 10MediaWiki-Documentation, 10Possible-Tech-Projects, 6WMF-Legal, 10Web-APIs-Hub, 7Documentation: technology to transclude git content into wiki pages - https://phabricator.wikimedia.org/T91626#1701779 (10Qgil) [11:48:37] need some help on this bug [11:48:52] https://phabricator.wikimedia.org/T113974 [11:49:19] i have been looking at it for a while and i have an algorithm but don't know how to implement it. :) [11:55:31] 10MediaWiki-extensions-WikibaseRepository, 10Wikibase-DataModel-Serialization, 10Wikidata, 7RfC, 3Wikidata-Sprint-2015-09-29: [RFC] Represent derived values in the data model, and allow for deferred deserialization - https://phabricator.wikimedia.org/T112550#1701786 (10JeroenDeDauw) Still waiting for an... [12:04:04] d3r1ck, hi [12:04:22] d3r1ck, have you found where the changeemail-text message is used? [12:05:25] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/243066 (https://phabricator.wikimedia.org/T59153) (owner: 10Mattflaschen) [12:06:38] 10MediaWiki-User-preferences, 7Tracking: User preferences in MediaWiki to be added or removed (tracking) - https://phabricator.wikimedia.org/T54807#1701793 (10siebrand) [12:06:41] (03CR) 10Siebrand: "@Catrope: Can you take another look at this, please?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/223213 (https://phabricator.wikimedia.org/T58845) (owner: 10Legoktm) [12:06:57] (03CR) 10Esanders: [C: 032] "Merged, but see inline comment for minor existing issue." (031 comment) [extensions/Score] - 10https://gerrit.wikimedia.org/r/243216 (https://phabricator.wikimedia.org/T114227) (owner: 10Tchanders) [12:07:24] (03Merged) 10jenkins-bot: Improve the score inspector interface [extensions/Score] - 10https://gerrit.wikimedia.org/r/243216 (https://phabricator.wikimedia.org/T114227) (owner: 10Tchanders) [12:07:32] 10MediaWiki-Special-pages: ChangeEmail should show password-required message only if $wgRequirePasswordforEmailChange is true - https://phabricator.wikimedia.org/T113974#1701796 (10Krenair) [12:07:54] Krenair: yes i have [12:08:11] 10MediaWiki-Special-pages: ChangeEmail should show password-required message only if $wgRequirePasswordforEmailChange is true - https://phabricator.wikimedia.org/T113974#1681565 (10Krenair) Doesn't look as easy as it sounds. This is added by FormSpecialPage::getForm which leaves no control of it to the subclass. [12:08:28] infact i have seen where the changeemail is implemented. But to be specific, the changeemail-text is only in the en.json file and no where else [12:08:43] Krenair: so i am suppose to work on it and check the condition. [12:08:56] (03CR) 10Esanders: Improve the score inspector interface (031 comment) [extensions/Score] - 10https://gerrit.wikimedia.org/r/243216 (https://phabricator.wikimedia.org/T114227) (owner: 10Tchanders) [12:09:45] 10MediaWiki-Special-pages, 7Easy: ChangeEmail should show password-required message only if $wgRequirePasswordforEmailChange is true - https://phabricator.wikimedia.org/T113974#1701802 (10Krenair) Actually, maybe it's still easy enough to be considered #Easy [12:10:03] d3r1ck, I think what you want to do is introduce a new function to FormSpecialPage [12:10:03] Krenair: it is not as easy as it look. Sure. I worked on it the whole night but nothing. But i understood a partern. The changeemail-text is found only in the json files and there is not check for rendering it. [12:10:37] Krenair: exactly something like that. But i don't know how to go about it. Also, how do pages get rendered in wiki? because i need to know how [12:10:47] If it returns true, add the header. Default implementation should be returning true, can be overridden by ChangeEmail [12:10:59] I don't think you do [12:12:30] d3r1ck, actually, I think what we really want is a bit more complex [12:12:31] Krenair: you don't think i do what? [12:12:45] I don't think you need to know "how pages get rendered" [12:13:00] Krenair: ok [12:13:14] The message is "Complete this form to change your email address. You will need to enter your password to confirm this change. If you would like to remove the association of any email address from your account, leave the new email address blank when submitting the form." [12:13:23] Krenair: normally, $wgRequirePasswordforChangeEmail is true by default [12:13:30] We want to break this into parts and only add the second sentence if $wgRequirePasswordforChangeEmail is true [12:13:53] Krenair: yes i understand that [12:14:04] 10MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), 5Patch-For-Review: Convert ConfirmEdit extension to use extension registration - https://phabricator.wikimedia.org/T88047#1701815 (10Aklapper) Looks like this is the only task left to also solve the tracking task T94758... [12:14:09] meaning we need to make the second part a variable that depends on some function [12:14:17] Krenair: Or maybe not. Have one message with it, and one without it. Then you're just varying on the bool for msg1 or msg2 [12:14:31] We don't like patchwork messages [12:14:41] or that [12:14:46] Reedy: yeah, that also makes sense [12:14:52] though that's more translation [12:15:11] 10MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), 5MW-1.25-release: ReCaptcha, and ReCaptchNoCaptcha do not display in MediaWiki 1.25.1 - https://phabricator.wikimedia.org/T106992#1701817 (10Aklapper) 5Open>3Resolved a:3Aklapper @Eadthem: Have you checked [[ https://www.mediawiki.org/wiki/Download... [12:15:13] I probably wouldn't worry about that too mcuh [12:15:14] Now the point is, which should we use and how do we do it.? [12:15:24] If part of it's verbatim, the translation is easy [12:15:41] d3r1ck, here's my suggestion: Change FormSpecialPage::getForm to call addHeaderMessage instead of doing the message itself [12:15:57] Then you can override it in SpecialChangeEmail to do what we want instead for this specific page [12:16:42] you'll need to pass the HTMLForm object into this new function [12:16:49] (03PS2) 10Hashar: Remove jshint from package.json [extensions/Echo] - 10https://gerrit.wikimedia.org/r/243502 (owner: 10Paladox) [12:17:32] (03CR) 10Hashar: [C: 032] Remove jshint from package.json [extensions/Echo] - 10https://gerrit.wikimedia.org/r/243502 (owner: 10Paladox) [12:17:41] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/214023 (owner: 10Microchip08) [12:18:57] Krenair: not clear. [12:19:09] 10MediaWiki-Configuration, 5MW-1.25-release: Convert all skins and extensions bundled with the tarball to use extension registration - https://phabricator.wikimedia.org/T94758#1701821 (10Florian) [12:19:21] 10MediaWiki-Internationalization, 7I18n, 7JavaScript: jqueryMsg can not parse wikilink with parameters in page name - https://phabricator.wikimedia.org/T49395#1701822 (10matmarex) [12:19:55] Krenair: i can see this $headerMsg = $this->msg( $this->getMessagePrefix() . '-text' ); [12:20:08] (03Merged) 10jenkins-bot: Remove jshint from package.json [extensions/Echo] - 10https://gerrit.wikimedia.org/r/243502 (owner: 10Paladox) [12:20:26] yes [12:20:52] Krenair: is that what we need to change? [12:21:06] yes, move this out to a function that you can override in SpecialChangeEmail [12:21:20] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/189178 (https://phabricator.wikimedia.org/T85372) (owner: 10Cenarium) [12:21:53] (03CR) 10Siebrand: [C: 032] Change special page title to be more human-friendly by default [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/243165 (owner: 10Jack Phoenix) [12:22:00] Krenair: meaning i need to create a new function in FormSpecialPage? [12:22:08] (03Merged) 10jenkins-bot: Change special page title to be more human-friendly by default [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/243165 (owner: 10Jack Phoenix) [12:22:10] (03PS1) 10Bartosz Dziewoński: Refactor handling of replacements/parameters in links [core] - 10https://gerrit.wikimedia.org/r/243637 (https://phabricator.wikimedia.org/T49395) [12:22:32] yes [12:22:35] 10MediaWiki-Internationalization, 7I18n, 7JavaScript: jqueryMsg can not handle external links/wikilinks with dollar signs in the URL/target - https://phabricator.wikimedia.org/T45510#1701831 (10matmarex) [12:23:36] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/243141 (owner: 10Ljonka) [12:23:39] Krenair: ok. let me write something [12:23:40] 10MediaWiki-Internationalization, 7I18n, 7JavaScript: jqueryMsg can not handle external links/wikilinks with dollar signs in the URL/target - https://phabricator.wikimedia.org/T45510#1701833 (10matmarex) This applies equally to wikilinks, like `[[US$|United States dollar]]`. Since T49395, parameters in link... [12:24:04] Krenair: meaning i have to remove all this [12:24:05] $headerMsg = $this->msg( $this->getMessagePrefix() . '-text' ); [12:24:05] if ( !$headerMsg->isDisabled() ) { [12:24:05] $form->addHeaderText( $headerMsg->parseAsBlock() ); [12:24:06] } [12:24:12] yes [12:25:07] Krenair: what name should we give to your new function :) [12:25:09] ? [12:25:38] whatever name you think describes what it does [12:26:41] Krenair: what about getChangeEmailText() [12:26:46] no [12:26:46] Krenair: is that one ok? [12:26:51] no [12:27:04] Krenair: can you help? [12:27:11] 10MediaWiki-Internationalization, 7I18n, 7JavaScript: Add wikitext bold and italic support to jqueryMsg - https://phabricator.wikimedia.org/T45512#1701838 (10matmarex) p:5Normal>3Low This is lower priority now that we replaced just about all uses of `'''foo'''` and `''foo''` with `foo` a... [12:27:12] it needs to be something applicable to all FormSpecialPage classes [12:27:23] 10MediaWiki-Internationalization, 7I18n, 7JavaScript, 5Patch-For-Review, 7Technical-Debt: Don't include mediaWiki_htmlEmitter in jqueryMsg output - https://phabricator.wikimedia.org/T50064#1701843 (10matmarex) a:3matmarex [12:27:37] something like addFormHeader [12:27:48] Krenair: ok [12:28:00] Krenair: ok, i will use addFormHeader then [12:28:01] :) [12:29:52] 10MediaWiki-Internationalization, 7I18n, 7JavaScript: jqueryMsg should not throw on input similar to external link syntax (whitespace in input ([ $1 $2 ] causes exceptions, [$1 $2] works) - https://phabricator.wikimedia.org/T53563#1701844 (10matmarex) 5Open>3Resolved a:3matmarex I don't think it's wor... [12:30:05] Krenair: so the test in the getForm should be there now right? [12:30:15] (03CR) 10Siebrand: [C: 032] Fix the last Generic.Files.LineLength phpcs failures [core] - 10https://gerrit.wikimedia.org/r/243418 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [12:30:23] yes [12:30:44] Krenair: just like that with no change? [12:30:52] 10MediaWiki-Internationalization, 7I18n, 7JavaScript, 5Patch-For-Review: jqueryMsg can not parse wikilink with parameters in page name - https://phabricator.wikimedia.org/T49395#1701848 (10matmarex) [12:30:53] 10MediaWiki-General-or-Unknown, 6Multimedia, 5MW-1.27-release-notes, 5Patch-For-Review, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): Improve error handling UX in the mw.ForeignStructuredUpload.BookletLayout - https://phabricator.wikimedia.org/T114130#1701847 (10matmarex) [12:30:58] (03CR) 10Siebrand: [C: 04-1] Re-enable Generic.Files.LineLength and exclude failing files (031 comment) [core] - 10https://gerrit.wikimedia.org/r/243616 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [12:31:36] d3r1ck, how about you do what you think is right and get it to work, and then we can discuss whether it's right when you've put it up for code review? [12:32:07] Krenair: i am still learning the Wiki core [12:32:18] so its quite tough for me [12:32:35] Krenair: once i get this done, i then i will know what to do in the next core task :) [12:32:50] Krenair: i need help in this one :) [12:33:00] It doesn't exactly work like that [12:33:11] Unless you're doing the same thing somewhere else, the solution may be completely different [12:33:13] Reedy: ok then how does it work? :) [12:33:45] (03CR) 10Amire80: Re-enable Generic.Files.LineLength and exclude failing files (031 comment) [core] - 10https://gerrit.wikimedia.org/r/243616 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [12:33:48] It's good you're asking questions, but you should try and work things out by yourself [12:33:56] As otherwise, Krenair might aswell just fix it himself [12:34:41] Reedy: seriously i worked yesterday like a beef :) [12:34:51] Reedy: the cores is still not flowing in me [12:35:08] Reedy: i am still learning it. But i need help. [12:35:09] Even most experienced MW devs won't be familiar with a lot of core [12:35:47] Reedy: ok, then once i fix this one(if i only fix it) i won't work with core code anymore :) [12:35:52] 10MediaWiki-Internationalization: mediawiki.jqueryMsg double escapes HTML entities when using mw.message(key).parse() on a message containing a link - https://phabricator.wikimedia.org/T55576#1701853 (10matmarex) >>! In T55576#580253, @Nemo_bis wrote: > Do we have concrete examples? Perhaps I have one, from Uplo... [12:36:18] Reedy: so, i need to write another function in FormSpecialPage and override it in SpecialChangeEmail [12:36:29] 3DevRel-October-2015: Lessons learned from the first Gerrit Cleanup Day - https://phabricator.wikimedia.org/T113378#1701856 (10Aklapper) [12:36:30] Yes, that's what you've been told already [12:36:35] None of that is MediaWiki specific [12:36:39] 10MediaWiki-Internationalization: mediawiki.jqueryMsg double escapes HTML entities when using mw.message(key).parse() on a message containing a link - https://phabricator.wikimedia.org/T55576#1701863 (10matmarex) [12:36:49] Reedy: the point is in the json files, the changeemail-text is already there [12:36:55] It's basic OOPs [12:36:57] And? [12:37:09] how do i send a different header text? [12:37:40] $headerMsg = $this->msg( $this->getMessagePrefix() . '-text' ); [12:37:40] if ( !$headerMsg->isDisabled() ) { [12:37:40] $form->addHeaderText( $headerMsg->parseAsBlock() ); [12:37:40] } [12:37:47] You change what is in that first line [12:39:07] 3DevRel-October-2015: Lessons learned from the first Gerrit Cleanup Day - https://phabricator.wikimedia.org/T113378#1701868 (10Aklapper) [12:39:27] (03Merged) 10jenkins-bot: Fix the last Generic.Files.LineLength phpcs failures [core] - 10https://gerrit.wikimedia.org/r/243418 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [12:41:06] (03Abandoned) 10Amire80: Re-enable Generic.Files.LineLength and exclude failing files [core] - 10https://gerrit.wikimedia.org/r/243616 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [12:41:22] (03PS21) 10Amire80: Reenable LineLength phpcs check [core] - 10https://gerrit.wikimedia.org/r/241501 (https://phabricator.wikimedia.org/T102614) [12:41:55] Reedy: my problem is that there are many function calls and i need to know what all of them do [12:42:04] No you don't [12:42:06] 10MediaWiki-Codesniffer, 5Patch-For-Review: @codingStandardsIgnoreStart only works with // comments - https://phabricator.wikimedia.org/T114213#1701882 (10Amire80) [12:42:07] 10MediaWiki-Codesniffer, 5MW-1.27-release-notes, 5Patch-For-Review, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): @codingStandardsIgnoreStart doesn't seem to help avoid phpcs errors inside comments - https://phabricator.wikimedia.org/T113852#1701883 (10Amire80) [12:42:10] 10MediaWiki-Codesniffer, 10MediaWiki-General-or-Unknown, 5MW-1.26-release, 5MW-1.27-release-notes, and 3 others: Fix Generic.Files.LineLength errors in MediaWiki core by breaking long lines - https://phabricator.wikimedia.org/T102614#1701881 (10Amire80) [12:42:28] Trying to learn "all of core" is a pointless exercise. You're going to confuse yourself, and not learn anything [12:42:31] 3DevRel-October-2015: Lessons learned from the first Gerrit Cleanup Day - https://phabricator.wikimedia.org/T113378#1701884 (10hashar) @cscott the Gerrit clean up day has been taken in account by #releng and extra care is taken for the deployment train that follow. We definitely want to keep it in mind for the... [12:42:37] Most things should make sense if read like a sentence [12:42:44] if ( !$headerMsg->isDisabled() ) { [12:42:50] if the header message is not disable [12:42:59] 10MediaWiki-Codesniffer, 10MediaWiki-General-or-Unknown, 5MW-1.26-release, 5MW-1.27-release-notes, and 3 others: Fix Generic.Files.LineLength errors in MediaWiki core by breaking long lines - https://phabricator.wikimedia.org/T102614#1678517 (10Amire80) Merging https://gerrit.wikimedia.org/r/#/c/241501/ wi... [12:43:04] *disabled [12:43:08] 10MediaWiki-Internationalization: mediawiki.jqueryMsg double escapes HTML entities when using mw.message(key).parse() on a message containing a link - https://phabricator.wikimedia.org/T55576#1701886 (10matmarex) I don't think we should burden mediawiki.jqueryMsg with understanding all possible HTML entities tha... [12:43:09] Reedy: ok [12:43:34] Reedy: public function addFormHeader() { [12:43:34] $headerMsg = $this->msg( $this->getMessagePrefix() . '-text' ); [12:43:34] if ( !$headerMsg->isDisabled() ) { [12:43:34] $form->addHeaderText( $headerMsg->parseAsBlock() ); [12:43:34] } [12:43:37] } [12:43:54] thats the new function we have defined :) [12:44:09] (03PS3) 10Phuedx: Include foreign files in ApiQueryPageImages [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/243124 (https://phabricator.wikimedia.org/T98791) [12:44:11] 10MediaWiki-Codesniffer, 7Upstream: @codingStandardsIgnoreStart only works with // comments - https://phabricator.wikimedia.org/T114213#1701887 (10Amire80) [12:44:17] 10MediaWiki-General-or-Unknown, 6Multimedia, 5MW-1.27-release-notes, 5Patch-For-Review, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): Improve error handling UX in the mw.ForeignStructuredUpload.BookletLayout - https://phabricator.wikimedia.org/T114130#1701888 (10matmarex) I think I figured out T49395 (patch pen... [12:44:22] Reedy: this line adds the headers [12:44:24] $form->addHeaderText( $headerMsg->parseAsBlock() ); [12:44:40] (03CR) 10Phuedx: Include foreign files in ApiQueryPageImages (032 comments) [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/243124 (https://phabricator.wikimedia.org/T98791) (owner: 10Phuedx) [12:45:00] (03PS2) 10Bartosz Dziewoński: mediawiki.jqueryMsg: Refactor handling of replacements/parameters in links [core] - 10https://gerrit.wikimedia.org/r/243637 (https://phabricator.wikimedia.org/T49395) [12:45:44] Reedy: whats this $this->getMessagePrefix() suppose to do? [12:51:47] Reedy, Krenair, I need the HTMLForm::factory too right? [12:52:30] 3Reading-Web-Sprint-57-The Fifth Element: Demonstrate impact of loading just lead sections of a group of static pages - https://phabricator.wikimedia.org/T113649#1701894 (10phuedx) a:3phuedx [12:52:43] 3Reading-Web-Sprint-57-The Fifth Element: Demonstrate impact of loading just lead sections of a group of static pages - https://phabricator.wikimedia.org/T113649#1672271 (10phuedx) a:5phuedx>3Jdlrobson [12:52:45] 10MediaWiki-extensions-TimedMediaHandler, 5Patch-For-Review: Convert TimedText to make use of ContentHandler - https://phabricator.wikimedia.org/T111651#1701897 (10Liuxinyu970226) [12:55:12] 3Reading-Web-Sprint-57-The Fifth Element: Demonstrate impact of loading just lead sections of a group of static pages - https://phabricator.wikimedia.org/T113649#1701900 (10phuedx) > Someone should feel free to pick up where I left off and run them against webpage test. @bmansurov @phuedx ? @Peter: Is this a jo... [12:55:25] 10Hovercards, 3Reading-Web-Sprint-57-The Fifth Element: Spike: Alternative to TextExtracts for Popups, Gather, Read more - https://phabricator.wikimedia.org/T113633#1701902 (10phuedx) a:3phuedx [13:04:39] (03PS1) 10Bartosz Dziewoński: mediawiki.jqueryMsg: Always parse messages with '&' [core] - 10https://gerrit.wikimedia.org/r/243641 (https://phabricator.wikimedia.org/T55576) [13:05:43] 10MediaWiki-Internationalization, 5Patch-For-Review: mediawiki.jqueryMsg double escapes HTML entities when using mw.message(key).parse() on a message containing a link - https://phabricator.wikimedia.org/T55576#1701915 (10matmarex) >>! In T55576#1701886, @matmarex wrote: > Currently, it can correctly handle: `... [13:11:41] Reedy, Krenair, i have written something [13:16:01] 10MediaWiki-extensions-BounceHandler, 10Beta-Cluster: Beta config needs update (Undefined variable: wmgVERPsecret) - https://phabricator.wikimedia.org/T75757#1701924 (1001tonythomas) I see two occurrences of $wgVERPsecret in which the labs one is commented out. In production, it gets copied as $wmgVERPSecret.... [13:16:14] (03PS1) 10D3r1ck01: Merged my review branch with master [core] - 10https://gerrit.wikimedia.org/r/243642 [13:16:16] (03PS1) 10D3r1ck01: ChangeEmail should show password-required message [core] - 10https://gerrit.wikimedia.org/r/243643 (https://phabricator.wikimedia.org/T113974) [13:16:24] Reedy: submitted a review [13:16:37] (03CR) 10jenkins-bot: [V: 04-1] Merged my review branch with master [core] - 10https://gerrit.wikimedia.org/r/243642 (owner: 10D3r1ck01) [13:16:48] 10MediaWiki-RfCs, 10Continuous-Integration-Infrastructure, 5Patch-For-Review: [RFC] Optional Travis integration for Jenkins - https://phabricator.wikimedia.org/T114421#1701928 (10hashar) I have seen the npm-travis change and vetoed it on the basis that relying on Gerrit/Github replication to trigger build in... [13:16:58] (03CR) 10jenkins-bot: [V: 04-1] ChangeEmail should show password-required message [core] - 10https://gerrit.wikimedia.org/r/243643 (https://phabricator.wikimedia.org/T113974) (owner: 10D3r1ck01) [13:17:26] (03Abandoned) 10D3r1ck01: Merged my review branch with master [core] - 10https://gerrit.wikimedia.org/r/243642 (owner: 10D3r1ck01) [13:17:56] (03PS2) 10D3r1ck01: ChangeEmail should show password-required message [core] - 10https://gerrit.wikimedia.org/r/243643 (https://phabricator.wikimedia.org/T113974) [13:19:33] Krenair: http://pastebin.com/QSXVtJUf [13:19:37] Reedy: http://pastebin.com/QSXVtJUf [13:19:38] 10MediaWiki-extensions-ContentTranslation: "Start translation" initially grayed out with prefilled title - https://phabricator.wikimedia.org/T114511#1701932 (10Amire80) p:5Triage>3Low [13:20:50] 10MediaWiki-extensions-ContentTranslation: Unable to get property 'data' of undefined or null reference File: ext.cx.interlanguagelink.js, Line: 54, Column: 4 - https://phabricator.wikimedia.org/T114462#1701934 (10Endo999) I am now able to get the GoogleTrans gadget loaded onto the main enwiki page in both Chrom... [13:21:46] 10MediaWiki-extensions-ContentTranslation: Content Translation can't get through AbuseFilter warning - https://phabricator.wikimedia.org/T114621#1701936 (10Amire80) > Visiting an URL like https://it.wikipedia.org/w/index.php?title=Speciale:TraduzioneContenuti&campaign=newarticle-wmit&targettitle=Gero%20Kretschme... [13:22:03] Krenair, Reedy, my problem is actually calling the addFormHeader() and also where to call it. [13:22:15] i have submitted a review [13:23:30] 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release6: permission error without groups when using Special:ContentTranslation with campaign and without enabling the beta feature - https://phabricator.wikimedia.org/T102729#1701939 (10Amire80) [13:23:32] 10MediaWiki-extensions-ContentTranslation: Incorrect permission error on direct Special:ContentTranslation link - https://phabricator.wikimedia.org/T114497#1701940 (10Amire80) [13:24:08] 10MediaWiki-extensions-ContentTranslation: Incorrect permission error on direct Special:ContentTranslation link - https://phabricator.wikimedia.org/T114497#1697635 (10Amire80) [13:24:15] 10MediaWiki-extensions-ContentTranslation: Incorrect permission error on direct Special:ContentTranslation link - https://phabricator.wikimedia.org/T114497#1697635 (10Amire80) [13:24:17] 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release6: permission error without groups when using Special:ContentTranslation with campaign and without enabling the beta feature - https://phabricator.wikimedia.org/T102729#1372526 (10Amire80) [13:24:53] 10MediaWiki-extensions-ContentTranslation: Content Translation can't get through AbuseFilter warning - https://phabricator.wikimedia.org/T114621#1701946 (10Amire80) p:5Triage>3Normal [13:26:42] 10MediaWiki-API: Improve API's "permission denied" error message - https://phabricator.wikimedia.org/T114628#1701950 (10Anomie) p:5Triage>3Low API error reporting in general needs a major overhaul, and {T47843} is on my TODO list. All the examples you cite, BTW, are something deeper in MediaWiki returning '... [13:28:35] (03PS3) 10Mglaser: 506 Logging of BSP actions in MW Log [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/239317 (owner: 10Lilu) [13:33:52] (03CR) 10Tchanders: [C: 031] Consistently use spaces inside brackets in CSS [extensions/Score] - 10https://gerrit.wikimedia.org/r/243524 (owner: 10Esanders) [13:34:47] (03CR) 10Polybuildr: [C: 031] "Wow! Merge merge merge!" [core] - 10https://gerrit.wikimedia.org/r/241501 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [13:40:47] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Performance, 7Story: [Story] Make DataAccess functions default to the user's language on multilingual wikis - https://phabricator.wikimedia.org/T75460#1701958 (10hoo) [13:41:06] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review: Remove assertTag usages from tests - https://phabricator.wikimedia.org/T69122#1701960 (10daniel) Quick update on my take on this: If DOMTestUtils::assertTagSimple() implements a subset of PHPUnit's assertTag(), and doesn't (contrary to... [13:41:21] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Performance, 7Story: [Story] Make Lua functions default to the user's language on multilingual wikis - https://phabricator.wikimedia.org/T75460#1701961 (10hoo) [13:51:05] 10MediaWiki-API: expose revisions.rev_sha1 as query field - https://phabricator.wikimedia.org/T51136#1701966 (10matmarex) I think it is the same value, just written differently. A SHA-1 hash is just a 160-bit number, which is usually displayed as 40 digits in base 16 (e.g. 2fd4e1c67a2d28fced849ee1bb76e7391b93eb1... [13:52:13] 10UI-Standardization: [Goal] Standardize MediaWiki components - https://phabricator.wikimedia.org/T113560#1701970 (10matmarex) [13:55:43] 10Possible-Tech-Projects: Implement wikicode linting framework / library - https://phabricator.wikimedia.org/T114631#1701971 (10Fannon) @Petrb That what I ment, you may freely write broken wikitext and it's still accepted because it's technically valid. There are no "syntax" errors which would prevent basic erro... [13:56:22] (03PS1) 10Amire80: Change "Subject/headline" to "Subject" [core] - 10https://gerrit.wikimedia.org/r/243647 [13:58:26] 10Possible-Tech-Projects: Implement wikicode linting framework / library - https://phabricator.wikimedia.org/T114631#1701973 (10ssastry) >>! In T114631#1701632, @Petrb wrote: > Is really every wikitext valid? Yes, it is. That said, Cite gives you the red errors in some scenarios (ex: T85386 ) and maybe some ot... [14:01:07] (03PS3) 10D3r1ck01: ChangeEmail should show password-required message [core] - 10https://gerrit.wikimedia.org/r/243643 (https://phabricator.wikimedia.org/T113974) [14:01:29] (03CR) 10jenkins-bot: [V: 04-1] ChangeEmail should show password-required message [core] - 10https://gerrit.wikimedia.org/r/243643 (https://phabricator.wikimedia.org/T113974) (owner: 10D3r1ck01) [14:01:49] 10MediaWiki-API: expose revisions.rev_sha1 as query field - https://phabricator.wikimedia.org/T51136#1701975 (10Anomie) >>! In T51136#1701966, @matmarex wrote: > I think it is the same value, just written differently. You are correct. [14:02:30] (03PS4) 10D3r1ck01: ChangeEmail should show password-required message [core] - 10https://gerrit.wikimedia.org/r/243643 (https://phabricator.wikimedia.org/T113974) [14:03:25] (03PS1) 10Amire80: Change "Topic subject" to "Subject" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/243649 [14:03:39] Did a fix to the bug but the proble now is the translation [14:03:42] *problem [14:04:32] (03CR) 10Pwirth: [C: 031] 506 Logging of BSP actions in MW Log (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/239317 (owner: 10Lilu) [14:08:47] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-Other, 6Reading-Infrastructure-Team: Update PluggableAuth to use AuthManager - https://phabricator.wikimedia.org/T110464#1701982 (10cicalese) With respect to the timing of this change, which MediaWiki release is anticipated to include the A... [14:09:57] (03CR) 10Anomie: "I'm not seeing the point here. What's the harm in reiterating the default?" [core] - 10https://gerrit.wikimedia.org/r/243618 (owner: 10Thiemo Mättig (WMDE)) [14:14:05] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review: Remove assertTag usages from tests - https://phabricator.wikimedia.org/T69122#1701985 (10Ricordisamoa) >>! In T69122#1701960, @daniel wrote: > * DOMTestUtils would be "born deprecated". We don't want to encourage more usages of it, we... [14:14:58] (03PS6) 10Bartosz Dziewoński: UploadBase: Return 'was-deleted' warning in addition to 'exists-normalized', not instead of [core] - 10https://gerrit.wikimedia.org/r/237725 (https://phabricator.wikimedia.org/T48741) [14:22:17] 10Possible-Tech-Projects: Implement wikicode linting framework / library - https://phabricator.wikimedia.org/T114631#1701994 (10ssastry) See https://phabricator.wikimedia.org/T94370#1701988 about current status of this project in Parsoid. I think what would be ideal is to take this forward and finish up the inte... [14:23:42] 10MediaWiki-General-or-Unknown, 10Analytics, 6Discovery, 10EventBus, and 6 others: EventBus MVP - https://phabricator.wikimedia.org/T114443#1701995 (10Nuria) >EventLogging: Decode, validate and enqueue JSON events for EL. mmm..I am not sure who would be the users of this endpoint at this time, do you have... [14:25:26] (03PS20) 10DCausse: Enable communication with multiple datacenters [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/237264 (https://phabricator.wikimedia.org/T86781) (owner: 10EBernhardson) [14:31:45] (03PS7) 10Bartosz Dziewoński: UploadBase: Return 'was-deleted' warning in addition to 'exists-normalized', not instead of [core] - 10https://gerrit.wikimedia.org/r/237725 (https://phabricator.wikimedia.org/T48741) [14:31:49] (03CR) 10Bartosz Dziewoński: "Done both. Thanks." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/237725 (https://phabricator.wikimedia.org/T48741) (owner: 10Bartosz Dziewoński) [14:36:08] 10MediaWiki-API, 6Analytics-Backlog, 6Research-and-Data, 5Patch-For-Review: log user agent in api.log - https://phabricator.wikimedia.org/T108618#1702008 (10Nuria) >would be a pretty easy to then add a Monolog processor that added this bit of data to all log events that MediaWiki generated. We could also p... [14:36:12] (03CR) 10DCausse: "LGTM, I tested :" (033 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/237264 (https://phabricator.wikimedia.org/T86781) (owner: 10EBernhardson) [14:37:25] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "features/update_weight_api.feature:37" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/237264 (https://phabricator.wikimedia.org/T86781) (owner: 10EBernhardson) [14:37:40] (03PS1) 10Niedzielski: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/243656 [14:39:34] (03CR) 10DCausse: "minor phpdoc edit" (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/237264 (https://phabricator.wikimedia.org/T86781) (owner: 10EBernhardson) [14:40:43] 10MediaWiki-extensions-ContentTranslation, 7JavaScript, 5Patch-For-Review, 5WMF-deploy-2015-09-29_(1.27.0-wmf.1): ContentTranslation causes "TypeError: $.uls is undefined" since 1.26wmf24 - https://phabricator.wikimedia.org/T113650#1702015 (10FcoLeonSaudanha) @ori the bug is resolved ;-). Greetings :-)! [14:42:02] (03PS21) 10DCausse: Enable communication with multiple datacenters [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/237264 (https://phabricator.wikimedia.org/T86781) (owner: 10EBernhardson) [14:42:59] (03CR) 10Anomie: [C: 04-1] "Welcome to MediaWiki development!" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/243643 (https://phabricator.wikimedia.org/T113974) (owner: 10D3r1ck01) [14:43:35] (03CR) 10Sniedzielski: [C: 032] Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/243656 (owner: 10Niedzielski) [14:48:23] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/243656 (owner: 10Niedzielski) [14:50:15] 10MediaWiki-API, 6Analytics-Backlog, 6Research-and-Data, 5Patch-For-Review: log user agent in api.log - https://phabricator.wikimedia.org/T108618#1702049 (10Anomie) >>! In T108618#1702008, @Nuria wrote: > This describes a "session identifier" No, it describes a "request identifier". A "session identifier... [14:50:44] anomie: hey, i saw your comment. Thanks [14:50:55] d3r1ck: You're welcome [14:51:02] 10MediaWiki-RfCs, 10Wikimedia-Developer-Summit-2016: [RFC] Hygienic templates - https://phabricator.wikimedia.org/T114445#1702053 (10ssastry) >>! In T114445#1701496, @Arlolra wrote: > Should hygiene have anything to say about nested anchor tags? I think this is a more generic concern about HTML5 content model... [14:51:04] anomie: so please how do i fix this problem in the SpecialChangeEmail? [14:52:43] anomie: i have tried with it but that is the only fix i can come up with. [14:53:05] d3r1ck: You'd want to be editing SpecialChangeEmail.php, and likely you'd need to add another i18n message as documented on the Localisation page I linked you to. If you can find some other FormSpecialPage subclass that varies the header message based on something you might be able to use it as an example. [14:53:08] Reedy, and Krenair told me something but implementing it is no clear to me. [14:53:32] 7HHVM: Segfault in strtr() - https://phabricator.wikimedia.org/T109540#1702071 (10Joe) [14:54:14] (03CR) 10Isarra: "I would like to give this a proper look-over soon, but I'm currently on holiday for the next week and trains apparently don't work well fo" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/243226 (owner: 10Jdlrobson) [14:55:46] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/237264 (https://phabricator.wikimedia.org/T86781) (owner: 10EBernhardson) [14:56:44] (03PS1) 10JanZerebecki: Add .gitreview [data-values/value-view] - 10https://gerrit.wikimedia.org/r/243667 [14:56:51] 10MediaWiki-Unit-tests, 10MediaWiki-Vagrant, 7HHVM, 5Patch-For-Review, 7Upstream: Mocking abstract objects fails on HHVM - https://phabricator.wikimedia.org/T95864#1702089 (10Joe) Since the package has been built and deployed, is this resolved? [14:57:06] (03CR) 10Jforrester: [C: 032] Consistently use spaces inside brackets in CSS [extensions/Score] - 10https://gerrit.wikimedia.org/r/243524 (owner: 10Esanders) [14:58:04] 10MediaWiki-Special-pages, 7Easy, 5Patch-For-Review: ChangeEmail should show password-required message only if $wgRequirePasswordforEmailChange is true - https://phabricator.wikimedia.org/T113974#1702092 (10Glaisher) >>! In T113974#1701796, @Krenair wrote: > Doesn't look as easy as it sounds. This is added b... [14:58:28] (03CR) 10Jforrester: [C: 032] Add grunt linting tasks [extensions/Score] - 10https://gerrit.wikimedia.org/r/243523 (owner: 10Esanders) [14:58:51] anomie: can you as a comment, tell me what to do step by step so that i can work on it? [14:58:58] (03CR) 10jenkins-bot: [V: 04-1] Add grunt linting tasks [extensions/Score] - 10https://gerrit.wikimedia.org/r/243523 (owner: 10Esanders) [14:59:01] (03CR) 10jenkins-bot: [V: 04-1] Consistently use spaces inside brackets in CSS [extensions/Score] - 10https://gerrit.wikimedia.org/r/243524 (owner: 10Esanders) [14:59:13] 3Mobile-App-Android-Sprint-67-Holmium, 3Wikipedia-Android-App, 7WorkType-NewFunctionality: Saving image to device should pop a notification the user can click to open it and a button to share it too - https://phabricator.wikimedia.org/T104529#1702096 (10Mholloway) a:3Mholloway [14:59:57] d3r1ck: No, I can't. At that point I'd have to do all the work myself, so I may as well just do it myself. But I don't have time to deal with that bug at the moment anyway. Sorry. [15:00:20] anomie: ok, i will try my best :) [15:00:52] (03CR) 10Glaisher: "Please see my proposed solution at https://phabricator.wikimedia.org/T113974#1702092 Also is there a reason for changing the default of th" [core] - 10https://gerrit.wikimedia.org/r/243643 (https://phabricator.wikimedia.org/T113974) (owner: 10D3r1ck01) [15:01:28] (03CR) 10Glaisher: [C: 04-1] ChangeEmail should show password-required message [core] - 10https://gerrit.wikimedia.org/r/243643 (https://phabricator.wikimedia.org/T113974) (owner: 10D3r1ck01) [15:01:48] (03CR) 10Dbrant: [C: 032] Hygiene: remove code for unsupported old devices [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/242642 (https://phabricator.wikimedia.org/T112310) (owner: 10Niedzielski) [15:02:30] 10MediaWiki-Special-pages, 7Easy, 5Patch-For-Review: ChangeEmail should show password-required message only if $wgRequirePasswordforEmailChange is true - https://phabricator.wikimedia.org/T113974#1702099 (10D3r1ck01) Thanks and i will work on it. [15:04:37] (03CR) 10JanZerebecki: [C: 032 V: 032] Add .gitreview [data-values/value-view] - 10https://gerrit.wikimedia.org/r/243667 (owner: 10JanZerebecki) [15:06:43] 10MediaWiki-Unit-tests, 10MediaWiki-Vagrant, 7HHVM, 5Patch-For-Review, 7Upstream: Mocking abstract objects fails on HHVM - https://phabricator.wikimedia.org/T95864#1702113 (10Anomie) The reproduction given in https://github.com/facebook/hhvm/issues/5170 is now giving the correct result when run on HHVM o... [15:06:44] (03Merged) 10jenkins-bot: Hygiene: remove code for unsupported old devices [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/242642 (https://phabricator.wikimedia.org/T112310) (owner: 10Niedzielski) [15:08:21] 10MediaWiki-Special-pages: Allow filtering by namespace on [[Special:WantedTemplates]] - https://phabricator.wikimedia.org/T114200#1702116 (10Glaisher) I also think that this page should only be showing real templates (i.e. Templates and Modules) at least until there is a mechanism to add filters to cached expen... [15:08:23] (03CR) 10Dbrant: [C: 032] Rename nav menu "More" item to "Settings" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/243238 (https://phabricator.wikimedia.org/T108532) (owner: 10Mholloway) [15:08:25] (03CR) 10jenkins-bot: [V: 04-1] Rename nav menu "More" item to "Settings" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/243238 (https://phabricator.wikimedia.org/T108532) (owner: 10Mholloway) [15:09:56] 10Possible-Tech-Projects: Implement wikicode linting framework / library - https://phabricator.wikimedia.org/T114631#1702120 (10cscott) As @ssastry said, there is the basic infrastructure for this already in Parsoid, which gets automatically run after every edit. The missing components are: # Integration with p... [15:10:18] (03CR) 10Niedzielski: [C: 04-1] Rename nav menu "More" item to "Settings" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/243238 (https://phabricator.wikimedia.org/T108532) (owner: 10Mholloway) [15:10:34] (03CR) 10Thcipriani: [C: 032] "SWAT" [extensions/Flow] (wmf/1.27.0-wmf.1) - 10https://gerrit.wikimedia.org/r/243337 (https://phabricator.wikimedia.org/T111494) (owner: 10Mattflaschen) [15:13:09] 10MediaWiki-Parser, 10Wikidata, 5Patch-For-Review: [Task] Consistently and correctly get target or 'cached' language in ParserOptions when userlang option is used - https://phabricator.wikimedia.org/T109705#1702132 (10hoo) [15:13:11] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 5Patch-For-Review, 7Performance, 7Story: [Story] Make Lua functions default to the user's language on multilingual wikis - https://phabricator.wikimedia.org/T75460#1702131 (10hoo) [15:14:29] (03Merged) 10jenkins-bot: Fix exception on board and topic history pages [extensions/Flow] (wmf/1.27.0-wmf.1) - 10https://gerrit.wikimedia.org/r/243337 (https://phabricator.wikimedia.org/T111494) (owner: 10Mattflaschen) [15:14:36] 10MediaWiki-API, 6Analytics-Backlog, 6Developer-Relations, 6Reading-Infrastructure-Team, and 4 others: Metrics about the use of the Wikimedia web APIs - https://phabricator.wikimedia.org/T102079#1702135 (10EBernhardson) The avro encoder in php doesn't look to directly support json encoding, but i don't thi... [15:16:38] 10MediaWiki-Special-pages, 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-cxserver, 10Parsoid, and 2 others: Special:Version should show the versions of services that a wiki uses - https://phabricator.wikimedia.org/T108226#1702140 (10cscott) From gerrit (moving discussion here): @gwicke:... [15:17:16] (03CR) 10Cscott: "Moving discussion to the phab ticket (T108226) so that gerrit stays focused on code issues." [core] - 10https://gerrit.wikimedia.org/r/243269 (https://phabricator.wikimedia.org/T108226) (owner: 10Florianschmidtwelzow) [15:17:33] Hi [15:18:29] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Performance: [Task] Profile entity deserialization - https://phabricator.wikimedia.org/T90706#1702144 (10hoo) [15:18:31] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 5Patch-For-Review, 7Story: [Story] Allow usage of more entities on client pages via Lua - https://phabricator.wikimedia.org/T111780#1702143 (10hoo) [15:18:56] (03PS5) 10D3r1ck01: ChangeEmail should show password-required message [core] - 10https://gerrit.wikimedia.org/r/243643 (https://phabricator.wikimedia.org/T113974) [15:19:13] anomie: i have used combinations of many approaches including that of Glaisher [15:19:23] (03CR) 10jenkins-bot: [V: 04-1] ChangeEmail should show password-required message [core] - 10https://gerrit.wikimedia.org/r/243643 (https://phabricator.wikimedia.org/T113974) (owner: 10D3r1ck01) [15:19:32] Glaisher: you can check the review i submitted to see if it makes sense [15:19:32] 10Hovercards, 3Reading-Web-Sprint-57-The Fifth Element: Spike: Alternative to TextExtracts for Popups, Gather, Read more - https://phabricator.wikimedia.org/T113633#1702146 (10phuedx) > What is a summary of the existing bugs? The most common pain points of the #TextExtracts extension seem to be: * How it han... [15:22:09] 10MediaWiki-Special-pages, 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-cxserver, 10Parsoid, and 2 others: Special:Version should show the versions of services that a wiki uses - https://phabricator.wikimedia.org/T108226#1702166 (10cscott) Adding to the above: I agree that the DOM spec... [15:22:15] 10Possible-Tech-Projects: Implement wikicode linting framework / library - https://phabricator.wikimedia.org/T114631#1702167 (10Petrb) >>! In T114631#1702120, @cscott wrote: > As @ssastry said, there is the basic infrastructure for this already in Parsoid, which gets automatically run after every edit. > > The... [15:22:44] I can't rebase my patch? [15:22:49] cherry pick is not working [15:23:08] (03PS3) 10TheDJ: jquery.tablesorter: Support rowspan in tfoot [core] - 10https://gerrit.wikimedia.org/r/243525 (https://phabricator.wikimedia.org/T114604) (owner: 10Gerrit Patch Uploader) [15:24:42] 10MediaWiki-jQuery-Tablesorter, 7JavaScript, 5Patch-For-Review: jquery.tablesorter.js: tfoot with rowspans - https://phabricator.wikimedia.org/T114604#1702175 (10TheDJ) Where is this a problem right now ? theoretical, practical ? In wikicode, or in an extension ? Also, will need a qunit testcase to verify t... [15:24:55] (03CR) 10DCausse: [C: 032] Enable communication with multiple datacenters [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/237264 (https://phabricator.wikimedia.org/T86781) (owner: 10EBernhardson) [15:25:08] (03PS6) 10D3r1ck01: ChangeEmail should show password-required message [core] - 10https://gerrit.wikimedia.org/r/243643 (https://phabricator.wikimedia.org/T113974) [15:25:32] (03CR) 10jenkins-bot: [V: 04-1] ChangeEmail should show password-required message [core] - 10https://gerrit.wikimedia.org/r/243643 (https://phabricator.wikimedia.org/T113974) (owner: 10D3r1ck01) [15:25:53] 10MediaWiki-RfCs: RFC: make Parser::getTargetLanguage aware of multilingual wikis - https://phabricator.wikimedia.org/T114640#1702178 (10cscott) What about pages which contain text in multiple languages? Can we add "current" to the description of the target language? Just like the HTML 'lang' attribute, which... [15:26:05] 10MediaWiki-jQuery-Tablesorter, 7JavaScript, 5Patch-For-Review: jquery.tablesorter.js: tfoot with rowspans - https://phabricator.wikimedia.org/T114604#1702179 (10Cblair91) Practical. A sortable table exists on one of my wikis, and is causing this issue currently. And yes, on a page using wikicode =] [15:26:12] (03Merged) 10jenkins-bot: Enable communication with multiple datacenters [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/237264 (https://phabricator.wikimedia.org/T86781) (owner: 10EBernhardson) [15:26:30] (03CR) 10jenkins-bot: [V: 04-1] jquery.tablesorter: Support rowspan in tfoot [core] - 10https://gerrit.wikimedia.org/r/243525 (https://phabricator.wikimedia.org/T114604) (owner: 10Gerrit Patch Uploader) [15:27:06] (03CR) 10Anomie: "Now at least we have reason stated for doing this." [core] - 10https://gerrit.wikimedia.org/r/243089 (https://phabricator.wikimedia.org/T95501) (owner: 10Aaron Schulz) [15:28:44] (03PS7) 10D3r1ck01: ChangeEmail should show password-required message [core] - 10https://gerrit.wikimedia.org/r/243643 (https://phabricator.wikimedia.org/T113974) [15:29:06] (03CR) 10jenkins-bot: [V: 04-1] ChangeEmail should show password-required message [core] - 10https://gerrit.wikimedia.org/r/243643 (https://phabricator.wikimedia.org/T113974) (owner: 10D3r1ck01) [15:29:35] anomie: i can't cherry-pick my patch? [15:29:38] what is wrong? [15:30:02] (03CR) 10EBernhardson: "@bd808" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/240614 (https://phabricator.wikimedia.org/T108618) (owner: 10EBernhardson) [15:30:39] (03PS8) 10D3r1ck01: ChangeEmail should show password-required message [core] - 10https://gerrit.wikimedia.org/r/243643 (https://phabricator.wikimedia.org/T113974) [15:31:02] (03CR) 10jenkins-bot: [V: 04-1] ChangeEmail should show password-required message [core] - 10https://gerrit.wikimedia.org/r/243643 (https://phabricator.wikimedia.org/T113974) (owner: 10D3r1ck01) [15:31:34] (03Abandoned) 10D3r1ck01: ChangeEmail should show password-required message [core] - 10https://gerrit.wikimedia.org/r/243643 (https://phabricator.wikimedia.org/T113974) (owner: 10D3r1ck01) [15:32:24] (03CR) 10Anomie: Enforce stricter slave lag limits for bot API requests (032 comments) [core] - 10https://gerrit.wikimedia.org/r/243089 (https://phabricator.wikimedia.org/T95501) (owner: 10Aaron Schulz) [15:32:39] 10MediaWiki-jQuery-Tablesorter, 7JavaScript, 5Patch-For-Review: jquery.tablesorter.js: tfoot with rowspans - https://phabricator.wikimedia.org/T114604#1702198 (10TheDJ) Please give the EXACT piece of code so that the patch can be verified for correctness. [15:33:16] 10Wikimedia-General-or-Unknown: Sitenotice malfunctioning - https://phabricator.wikimedia.org/T114652#1702201 (10Taketa) 3NEW [15:33:23] d3r1ck: I have no idea. You should look at whatever error messages you're receiving, and then search for help regarding those error messages. [15:34:00] 10Wikimedia-General-or-Unknown: Sitenotice malfunctioning - https://phabricator.wikimedia.org/T114652#1702209 (10Taketa) Also tested by a user I cannot remember the name of :P. Did work for them. [15:34:02] (03PS1) 10D3r1ck01: ChangeEmail should show password-required message [core] - 10https://gerrit.wikimedia.org/r/243676 (https://phabricator.wikimedia.org/T113974) [15:34:25] (03CR) 10jenkins-bot: [V: 04-1] ChangeEmail should show password-required message [core] - 10https://gerrit.wikimedia.org/r/243676 (https://phabricator.wikimedia.org/T113974) (owner: 10D3r1ck01) [15:34:35] 10MediaWiki-jQuery-Tablesorter, 7JavaScript, 5Patch-For-Review: jquery.tablesorter.js: tfoot with rowspans - https://phabricator.wikimedia.org/T114604#1702215 (10Cblair91) ``` {| class="wikitable sortable" ! Month ! Content |- ! January | rowspan="2" | '''Added some stuff.''' |- ! February |} ``` The follow... [15:35:18] 10Hovercards, 3Reading-Web-Sprint-57-The Fifth Element: Article name hover popup sometimes gets stuck open - https://phabricator.wikimedia.org/T92932#1702219 (10phuedx) I've been unable to reproduce this but I'll keep my eyes peeled… [15:36:03] 10Wikimedia-General-or-Unknown: nl.wikipedia.org sitenotice not displaying - https://phabricator.wikimedia.org/T114652#1702220 (10NDKilla) [15:36:23] (03PS3) 10Niedzielski: Hygiene: remove unused resources [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/242599 [15:37:13] 10MediaWiki-extensions-DismissableSiteNotice: nl.wikipedia.org sitenotice not displaying - https://phabricator.wikimedia.org/T114652#1702224 (10Sjoerddebruin) [15:37:59] (03PS1) 10JanZerebecki: Add composer test and npm test entry point [data-values/value-view] - 10https://gerrit.wikimedia.org/r/243677 [15:38:04] (03CR) 10jenkins-bot: [V: 04-1] Add composer test and npm test entry point [data-values/value-view] - 10https://gerrit.wikimedia.org/r/243677 (owner: 10JanZerebecki) [15:39:02] (03CR) 10Niedzielski: "r4r" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/238747 (https://phabricator.wikimedia.org/T109879) (owner: 10Mholloway) [15:41:45] (03CR) 10Niedzielski: "rebased. r4r" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/242599 (owner: 10Niedzielski) [15:42:30] (03PS2) 10JanZerebecki: Add composer test and npm test entry point [data-values/value-view] - 10https://gerrit.wikimedia.org/r/243677 [15:42:54] (03CR) 10jenkins-bot: [V: 04-1] Add composer test and npm test entry point [data-values/value-view] - 10https://gerrit.wikimedia.org/r/243677 (owner: 10JanZerebecki) [15:43:01] (03CR) 10Paladox: Use extension registration (031 comment) [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/243620 (https://phabricator.wikimedia.org/T87965) (owner: 10Phuedx) [15:43:28] 10MediaWiki-extensions-DismissableSiteNotice, 6Performance-Team, 7Regression: [1.26-wmf17 Regression] Dismissed site notice flashes briefly on page load - https://phabricator.wikimedia.org/T108513#1702245 (10Taketa) The sitenotice on nlwiki is now only being displayed to some. https://phabricator.wikimedia.o... [15:46:27] (03PS1) 10Paladox: Add composer.json [extensions/Echo] - 10https://gerrit.wikimedia.org/r/243678 [15:46:53] (03CR) 10Anomie: [C: 031] UploadBase: Return 'was-deleted' warning in addition to 'exists-normalized', not instead of [core] - 10https://gerrit.wikimedia.org/r/237725 (https://phabricator.wikimedia.org/T48741) (owner: 10Bartosz Dziewoński) [15:46:56] d3r1ck: Hi. Your new patch has a dependency on an abandoned patch. [15:47:16] Glaisher: that is what i want to fix and then submit [15:47:28] (03PS3) 10JanZerebecki: Add composer test and npm test entry point [data-values/value-view] - 10https://gerrit.wikimedia.org/r/243677 [15:47:30] d3r1ck: Do you need help with that? [15:47:33] but i think that one will solve the problem. But how will it be translated for all the other pages? [15:47:51] Glaisher: i tried cherry-pick but it did not work. I will submit a new patch [15:47:53] (03CR) 10jenkins-bot: [V: 04-1] Add composer test and npm test entry point [data-values/value-view] - 10https://gerrit.wikimedia.org/r/243677 (owner: 10JanZerebecki) [15:47:56] Let's not think about that for now. Can you first fix the merging issue? [15:48:04] d3r1ck: You don't need to cherry pick [15:48:16] (03Abandoned) 10D3r1ck01: ChangeEmail should show password-required message [core] - 10https://gerrit.wikimedia.org/r/243676 (https://phabricator.wikimedia.org/T113974) (owner: 10D3r1ck01) [15:48:22] First, create a new branch basing on origin/master [15:49:00] You didn't really have to abandon that one.. but oh well :) [15:49:01] Let's start all over again [15:49:01] Glaisher: ok [15:49:12] yes i will submit a new patch now. [15:49:52] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Performance: [Task] Delete by primary key in EntityUsageTable::pruneStaleUsages and EntityUsageTable::removeEntities - https://phabricator.wikimedia.org/T114654#1702263 (10hoo) 3NEW [15:50:19] 10Reading Web Planning: Measure readers reading habits - https://phabricator.wikimedia.org/T114655#1702274 (10Jdlrobson) 3NEW [15:50:40] (03PS4) 10JanZerebecki: Add composer test and npm test entry point [data-values/value-view] - 10https://gerrit.wikimedia.org/r/243677 [15:50:52] 10Reading Web Planning: Measure readers reading habits - https://phabricator.wikimedia.org/T114655#1702283 (10Jdlrobson) [15:50:53] 10Reading Web Planning, 7Tracking: [EPIC] Barack Obama article on English Wikipedia on 2G connection should fully load in under 15s (down from 50s) - https://phabricator.wikimedia.org/T113066#1702282 (10Jdlrobson) [15:51:03] (03CR) 10jenkins-bot: [V: 04-1] Add composer test and npm test entry point [data-values/value-view] - 10https://gerrit.wikimedia.org/r/243677 (owner: 10JanZerebecki) [15:51:38] (03CR) 10Dbrant: [C: 032] Update link preview dimensions on rotation [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/238747 (https://phabricator.wikimedia.org/T109879) (owner: 10Mholloway) [15:52:13] 10MediaWiki-extensions-Mailgun, 7Easy, 7I18n: Add i18n files - https://phabricator.wikimedia.org/T113969#1702285 (1001tonythomas) [15:52:23] (03PS5) 10JanZerebecki: Add composer test and npm test entry point [data-values/value-view] - 10https://gerrit.wikimedia.org/r/243677 [15:52:32] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Wikimedia-log-errors: [Bug] Frequent "request has exceeded memory limit" fatals in EntityUsageTable::extractProperty - https://phabricator.wikimedia.org/T114656#1702286 (10hoo) 3NEW [15:52:49] (03CR) 10jenkins-bot: [V: 04-1] Add composer test and npm test entry point [data-values/value-view] - 10https://gerrit.wikimedia.org/r/243677 (owner: 10JanZerebecki) [15:53:43] (03PS1) 10Thiemo Mättig (WMDE): Add null to @return tags if a method can return null [core] - 10https://gerrit.wikimedia.org/r/243680 [15:54:11] (03PS6) 10JanZerebecki: Add composer test and npm test entry point [data-values/value-view] - 10https://gerrit.wikimedia.org/r/243677 [15:54:42] (03CR) 10jenkins-bot: [V: 04-1] Add composer test and npm test entry point [data-values/value-view] - 10https://gerrit.wikimedia.org/r/243677 (owner: 10JanZerebecki) [15:55:16] (03PS1) 10D3r1ck01: ChangeEmail should show password-required message [core] - 10https://gerrit.wikimedia.org/r/243681 (https://phabricator.wikimedia.org/T113974) [15:55:45] Glaisher: new patch submitted [15:55:49] Glaisher: check it out :) [15:55:53] (03CR) 10Anomie: Add UserMailerTransformContent and UserMailerSplitTo hooks (031 comment) [core] - 10https://gerrit.wikimedia.org/r/242791 (https://phabricator.wikimedia.org/T12453) (owner: 10Gergő Tisza) [15:55:58] 10Beta-Cluster-Infrastructure, 10MobileFrontend, 7Easy, 7Mobile: Beta Cluster login (desktop and mobile) should have a warning that it is not a Wikimedia site - https://phabricator.wikimedia.org/T114552#1702306 (10Jdlrobson) Logo can be changed with $wgMobileFrontendLogo I'd suggest doing that before closi... [15:56:33] d3r1ck: You don't need to modify FormSpecialPage.php [15:56:39] (03Merged) 10jenkins-bot: Update link preview dimensions on rotation [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/238747 (https://phabricator.wikimedia.org/T109879) (owner: 10Mholloway) [15:57:44] d3r1ck: And you should still never be hard coding english inline [15:58:22] Reedy: so i should create another key in the en.json file? [15:58:33] Yes [15:58:41] Glaisher: ok, let me put pack the function [15:58:44] Glaisher, you don't need to modify FormSpecialPage? [15:58:57] Yes, alterForm() can be used. [15:59:10] We have to get rid of the "changeemail-text" message [15:59:11] What and just clear all header text to add the new text? :/ [15:59:19] hm, I guess that would work [15:59:26] Well, the current message has the password required message [15:59:28] leave the default disabled, then add custom ones [15:59:29] 10MediaWiki-extensions-BounceHandler, 10Beta-Cluster-Infrastructure: Beta config needs update (Undefined variable: wmgVERPsecret) - https://phabricator.wikimedia.org/T75757#1702309 (10bd808) 5Open>3Resolved >>! In T75757#1701087, @Krenair wrote: > Change was not committed, just left live hacked in the priv... [15:59:31] that's what we're trying to remove [15:59:37] yep [16:00:26] (03PS7) 10JanZerebecki: Add composer test and npm test entry point [data-values/value-view] - 10https://gerrit.wikimedia.org/r/243677 [16:00:27] 3Wikipedia-Android-App: Crash: RuntimeException (Canvas: trying to use a recycled bitmap) in... somewhere. - https://phabricator.wikimedia.org/T114658#1702311 (10Dbrant) 3NEW [16:00:34] 10Beta-Cluster-Infrastructure, 10QuickSurveys, 7I18n, 7Wikimedia-log-errors: QuickSurveys throws exception on non-HTTPS - https://phabricator.wikimedia.org/T114485#1702323 (10Jdlrobson) Hopefully this is what is causing T113534 ... and we can finally get that resolved too. [16:00:36] (03PS3) 10Matthias Mullie: [WIP] Dump Flow data [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242569 (https://phabricator.wikimedia.org/T89398) [16:00:52] (03CR) 10jenkins-bot: [V: 04-1] Add composer test and npm test entry point [data-values/value-view] - 10https://gerrit.wikimedia.org/r/243677 (owner: 10JanZerebecki) [16:02:00] 10MediaWiki-RfCs: RFC: make Parser::getTargetLanguage aware of multilingual wikis - https://phabricator.wikimedia.org/T114640#1702325 (10daniel) @cscott We should be careful to distinguish between: 1. the user's preferred language. 2. the page content language, i.e. the language of the text actually stored on th... [16:02:00] (03PS2) 10D3r1ck01: ChangeEmail should show password-required message [core] - 10https://gerrit.wikimedia.org/r/243681 (https://phabricator.wikimedia.org/T113974) [16:02:22] (03CR) 10Florianschmidtwelzow: [C: 032] Change "Topic subject" to "Subject" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/243649 (owner: 10Amire80) [16:02:52] (03PS3) 10D3r1ck01: ChangeEmail should show password-required message [core] - 10https://gerrit.wikimedia.org/r/243681 (https://phabricator.wikimedia.org/T113974) [16:03:01] Glaisher: FormSpecialPage needs to be modified a little [16:03:21] No, it doesn't have to be. [16:03:32] Let me add a comment to the change [16:03:41] ok [16:03:44] 10MediaWiki-API, 6Analytics-Backlog, 6Research-and-Data, 5Patch-For-Review: log user agent in api.log - https://phabricator.wikimedia.org/T108618#1702327 (10EBernhardson) I'd just like to add that I've used this request identifier in $dayjob-1 and it was incredibly useful for debugging issues across services. [16:03:46] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Dump Flow data [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242569 (https://phabricator.wikimedia.org/T89398) (owner: 10Matthias Mullie) [16:04:17] (03CR) 10Reedy: ChangeEmail should show password-required message (032 comments) [core] - 10https://gerrit.wikimedia.org/r/243681 (https://phabricator.wikimedia.org/T113974) (owner: 10D3r1ck01) [16:04:26] Reedy: even if i succeed in making this cchange work, how will the translation be handled? [16:04:36] d3r1ck: you don't need to worry about tht :) [16:04:50] (03Merged) 10jenkins-bot: Change "Topic subject" to "Subject" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/243649 (owner: 10Amire80) [16:05:36] 10MediaWiki-jQuery-Tablesorter, 7JavaScript, 5Patch-For-Review: jquery.tablesorter.js: tfoot with rowspans - https://phabricator.wikimedia.org/T114604#1702339 (10TheDJ) This doesn't look correct. The point of the code is that any row containing a disqualifies the row for inclusion into the tfoot. Inste... [16:05:53] (03CR) 10Reedy: ChangeEmail should show password-required message (032 comments) [core] - 10https://gerrit.wikimedia.org/r/243681 (https://phabricator.wikimedia.org/T113974) (owner: 10D3r1ck01) [16:05:56] Reedy: let me submit a new patch now. [16:07:04] (03PS4) 10D3r1ck01: ChangeEmail should show password-required message [core] - 10https://gerrit.wikimedia.org/r/243681 (https://phabricator.wikimedia.org/T113974) [16:07:10] (03CR) 10Glaisher: ChangeEmail should show password-required message (032 comments) [core] - 10https://gerrit.wikimedia.org/r/243681 (https://phabricator.wikimedia.org/T113974) (owner: 10D3r1ck01) [16:08:14] (03PS8) 10JanZerebecki: Add composer test and npm test entry point [data-values/value-view] - 10https://gerrit.wikimedia.org/r/243677 [16:08:35] 10MediaWiki-Interface, 7JavaScript, 5Patch-For-Review: Add generic personal toolbar links for IP users to MediaWiki core - https://phabricator.wikimedia.org/T112724#1702344 (10Trizek-WMF) The poll is finished on frwp, with a very large majority for the adoption of this tollbar. What are the plans for the fu... [16:08:42] 10Possible-Tech-Projects: Implement wikicode linting framework / library - https://phabricator.wikimedia.org/T114631#1702346 (10Krenair) Can you provide examples of "broken wikitext"? [16:09:45] 3Mobile-App-Android-Sprint-67-Holmium, 3Wikipedia-Android-App, 7WorkType-Maintenance: Resurrect the Session Funnel. - https://phabricator.wikimedia.org/T111541#1702360 (10Dbrant) a:3Dbrant [16:09:45] (03CR) 10jenkins-bot: [V: 04-1] Add composer test and npm test entry point [data-values/value-view] - 10https://gerrit.wikimedia.org/r/243677 (owner: 10JanZerebecki) [16:11:04] 10MediaWiki-extensions-ZeroPortal, 10Traffic, 6Zero, 6operations, 5Patch-For-Review: zerofetcher in production is getting throttled for API logins - https://phabricator.wikimedia.org/T111045#1702382 (10BBlack) 5Open>3Resolved a:3BBlack [16:11:12] Glaisher: the last comment you gave me has a small problem with the code [16:11:18] if the variable is true [16:11:20] 10MediaWiki-General-or-Unknown, 10Analytics, 6Discovery, 10EventBus, and 6 others: EventBus MVP - https://phabricator.wikimedia.org/T114443#1702384 (10GWicke) I guess we have slightly different ideas about what a message bus should be: 1) a way to get blobs from a to b, and 2) a way to expose a stream of... [16:11:28] we shall have two message displayed [16:11:39] that for when password is not required and that for password requiered [16:11:45] but i have fixed it [16:11:48] Why is that a problem? [16:11:50] it is fine now let me submit a review [16:12:15] Glaisher: $form->addHeaderText( $this->msg( 'changeemail-text' )->parseAsBlock() ); [16:12:22] 10Beta-Cluster-Infrastructure, 10MobileFrontend, 7Easy, 7Mobile: Beta Cluster login (desktop and mobile) should have a warning that it is not a Wikimedia site - https://phabricator.wikimedia.org/T114552#1702388 (10Thnidu) OHHH yeah. I think that's the page that I tried to log in on. [16:12:30] will be executed when it is false [16:12:34] that is very correct [16:12:37] but wwhen it is true [16:12:39] $form->addHeaderText( $this->msg( 'changeemail-text' )->parseAsBlock() ); [16:12:53] will be executed and also [16:12:54] if ( $wgRequirePasswordforEmailChange ) { [16:12:54] $form->addHeaderText( $this->msg( 'changeemail-passwordrequired' )->parseAsBlock() ); [16:12:57] } [16:13:01] (03PS9) 10JanZerebecki: Add composer test and npm test entry point [data-values/value-view] - 10https://gerrit.wikimedia.org/r/243677 [16:13:15] since there is no check to make sure that $form->addHeaderText( $this->msg( 'changeemail-text' )->parseAsBlock() ); [16:13:24] should only be executed when the variable is set to falsse [16:13:25] d3r1ck: Can you submit a new patch with your changes? I'm not sure I understand what you're saying. :) [16:13:29] but i have fixed that already [16:13:55] 4(no projects): make critical icinga services always send email but keep honoring timezones for pages - https://phabricator.wikimedia.org/T114661#1702389 (10Dzahn) 3NEW [16:13:59] (03PS5) 10D3r1ck01: ChangeEmail should show password-required message [core] - 10https://gerrit.wikimedia.org/r/243681 (https://phabricator.wikimedia.org/T113974) [16:14:07] Glaisher: patch submitted. [16:14:11] looking [16:14:26] FormSpecialPage change is still there :/ [16:14:58] 10MediaWiki-RfCs, 10Continuous-Integration-Infrastructure, 5Patch-For-Review: [RFC] Optional Travis integration for Jenkins - https://phabricator.wikimedia.org/T114421#1702398 (10greg) @cscott: You only describe what you see as things that'd be "fixed" with Travis integration while not taking a critical look... [16:15:06] Glaisher: yes [16:15:16] 10MediaWiki-RfCs: RFC: per-language URLs for pages of multilingual wikis. - https://phabricator.wikimedia.org/T114662#1702399 (10daniel) 3NEW [16:15:24] it has to be there so that it won't cause multiple display of the header message [16:15:27] 10MediaWiki-RfCs: RFC: per-language URLs for pages of multilingual wikis. - https://phabricator.wikimedia.org/T114662#1702409 (10daniel) a:3daniel [16:15:28] its fine [16:15:44] 10MediaWiki-RfCs: RFC: make Parser::getTargetLanguage aware of multilingual wikis - https://phabricator.wikimedia.org/T114640#1702411 (10daniel) a:3daniel [16:15:57] 10MediaWiki-extensions-DismissableSiteNotice: nl.wikipedia.org sitenotice not displaying - https://phabricator.wikimedia.org/T114652#1702413 (10Aklapper) p:5Triage>3High This is about https://nl.wikipedia.org/wiki/MediaWiki:Sitenotice I assume. It does not show in Firefox 41 when I'm not logged in. But it w... [16:16:08] (03PS3) 10Esanders: Add grunt linting tasks [extensions/Score] - 10https://gerrit.wikimedia.org/r/243523 [16:16:10] (03PS3) 10Esanders: Consistently use spaces inside brackets in CSS [extensions/Score] - 10https://gerrit.wikimedia.org/r/243524 [16:16:25] (03CR) 10Glaisher: ChangeEmail should show password-required message (031 comment) [core] - 10https://gerrit.wikimedia.org/r/243681 (https://phabricator.wikimedia.org/T113974) (owner: 10D3r1ck01) [16:16:26] 10Possible-Tech-Projects: Implement wikicode linting framework / library - https://phabricator.wikimedia.org/T114631#1702417 (10ssastry) >>! In T114631#1702346, @Krenair wrote: > Can you provide examples of "broken wikitext"? T94370#1701988 [16:16:27] 3Wikipedia-Android-App: Crash: RuntimeException (Canvas: trying to use a recycled bitmap) in... somewhere. - https://phabricator.wikimedia.org/T114658#1702420 (10Niedzielski) :/ The only thing that comes to mind for this error is 3235488, specifically removing the Bitmap copying in getBitmapFromView(). I can put... [16:16:59] (03CR) 10BearND: [C: 031] Hygiene: remove unused resources [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/242599 (owner: 10Niedzielski) [16:17:08] d3r1ck: Please read all the comments before submitting. I don't think you read my comment in the en.json file before.. [16:17:23] (03PS1) 10Tchanders: Append error container to inspector [extensions/Math] - 10https://gerrit.wikimedia.org/r/243684 (https://phabricator.wikimedia.org/T113172) [16:18:20] 10Possible-Tech-Projects: Implement wikicode linting framework / library - https://phabricator.wikimedia.org/T114631#1702427 (10ssastry) >>! In T114631#1702417, @ssastry wrote: >>>! In T114631#1702346, @Krenair wrote: >> Can you provide examples of "broken wikitext"? > > T94370#1701988 or the any number of cas... [16:18:23] Glaisher: i read all the comments [16:18:31] and also i understood what you said. [16:18:45] what i am wondering is that if you do this [16:18:58] $form->addHeaderText( $this->msg( 'changeemail-text' )->parseAsBlock() ); [16:19:06] if ( $wgRequirePasswordforEmailChange ) { [16:19:18] d3r1ck: Sorry, that key should be something else [16:19:26] changeemail-text contains old translations [16:19:51] Just add a new message copied from 'changeemail-text' without the password required message [16:20:05] And then show another message if the config is true [16:20:19] I am suggesting to split it into two messages [16:20:43] Glaisher: is this ok? [16:20:44] "changeemail-text": "Complete this form to change your email address.", [16:20:54] (03CR) 10Dbrant: [C: 032] Hygiene: remove unused resources [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/242599 (owner: 10Niedzielski) [16:21:01] Nope. [16:21:03] Needs a new key [16:21:25] "changeemail-passwordnotrequired": "Complete this form to change your email address.", [16:21:30] is that fine now? [16:21:38] 10Reading Web Planning: [placeholder] build web app - https://phabricator.wikimedia.org/T114663#1702431 (10Jdlrobson) 3NEW [16:22:21] Glaisher: or what do you suggest i put? :) [16:22:42] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: [Bug] Show more meaningful messages on the client wiki when a relevant sitelink is changed on the repo - https://phabricator.wikimedia.org/T114664#1702441 (10daniel) 3NEW a:3Jonas [16:23:00] "changeemail-header": "Complete this form to change your email address. If you would like to remove the association of any email address from your account, leave the new email address blank when submitting the form." [16:23:02] Show that message always [16:23:07] "changeemail-passwordrequired": "You will need to enter your password to confirm this change." [16:23:15] ^ That one should only be shown if config is true [16:24:03] 10Reading Web Planning: [placeholder] build web app - https://phabricator.wikimedia.org/T114663#1702449 (10Jdlrobson) a:3Jhernandez [16:24:07] 10Reading Web Planning: Measure readers reading habits - https://phabricator.wikimedia.org/T114655#1702451 (10KLans_WMF) @jkatzwmf may have some additional questions to add here. [16:24:44] 3Reading-Web-Sprint-57-The Fifth Element: Spike: Scope the first version of JavaScript-based prototype on existing Parsoid service - https://phabricator.wikimedia.org/T113769#1702455 (10Jdlrobson) Please output findings/proposal in T114663 [16:25:00] 3Reading-Web-Sprint-57-The Fifth Element: Spike: Scope the first version of JavaScript-based prototype on existing Parsoid service - https://phabricator.wikimedia.org/T113769#1702460 (10Jdlrobson) [16:25:55] Glaisher: ok let me submit something [16:25:57] (03Merged) 10jenkins-bot: Hygiene: remove unused resources [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/242599 (owner: 10Niedzielski) [16:26:33] Glaisher: check it out now. [16:26:40] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: [Bug] Repo should generate a meaningful log message when an entity is deleted. - https://phabricator.wikimedia.org/T114665#1702464 (10daniel) 3NEW a:3Jonas [16:26:50] 10Reading Web Planning: Measure readers reading habits - https://phabricator.wikimedia.org/T114655#1702472 (10Jhernandez) @jdlrobson wouldn't getting the user-agent data from #analytics give us info about Service Worker && more? How do we know how to bucket the EL to not break EL servers? [16:27:17] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: [Bug] Repo should generate a meaningful log message when an entity is deleted. - https://phabricator.wikimedia.org/T114665#1702464 (10daniel) a:5Jonas>3None [16:27:19] 3Reading-Web-Sprint-57-The Fifth Element: Spike (2 hours): How do we measure the success of read more? - https://phabricator.wikimedia.org/T113670#1702478 (10Jdlrobson) [16:27:33] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: [Bug] Show more meaningful messages on the client wiki when a relevant sitelink is changed on the repo - https://phabricator.wikimedia.org/T114664#1702481 (10daniel) a:5Jonas>3None [16:27:39] d3r1ck: Ah, great. That's what I have been saying all this time. :) [16:27:49] Glaisher: hmmmm, i see [16:27:54] You now need to remove the changes to FormSpecialPage [16:28:08] Glaisher: the core of wiki is easy to understand and i hope you know that. [16:28:12] and then add/remove documentation to qqq.json file [16:28:22] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: [Bug] Repo should generate a meaningful log message when an entity is restored - https://phabricator.wikimedia.org/T114666#1702489 (10daniel) 3NEW [16:28:39] 10Reading Web Planning: [placeholder] Add EventLogging to read more - https://phabricator.wikimedia.org/T114303#1702495 (10KLans_WMF) @jkatzwmf and @jdlrobson will chat about his today [16:28:50] Glaisher: wait, so i have to put FormSpecialPage the way it was originally? [16:28:55] yep [16:29:18] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: [Bug] Repo should generate a meaningful log message when an entity is restored - https://phabricator.wikimedia.org/T114666#1702489 (10daniel) p:5High>3Normal [16:29:43] 10Beta-Cluster-Infrastructure, 10MobileFrontend, 7Easy, 7Mobile: Beta Cluster login (desktop and mobile) should have a warning that it is not a Wikimedia site - https://phabricator.wikimedia.org/T114552#1702499 (10greg) a:5Luke081515>3Jdlrobson >>! In T114552#1702306, @Jdlrobson wrote: > Logo can be ch... [16:30:02] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: [Bug] Repo should generate a meaningful log message when an entity is deleted. - https://phabricator.wikimedia.org/T114665#1702502 (10daniel) p:5High>3Normal [16:30:05] 10MediaWiki-extensions-RelatedArticles, 10Gather, 10Reading Web Planning: Changes to card design for Gather and RelatedArticles - https://phabricator.wikimedia.org/T113768#1702504 (10Jdlrobson) a:3KHammerstein [16:30:13] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: [Bug] Repo should generate a meaningful log message when an entity is restored - https://phabricator.wikimedia.org/T114666#1702489 (10daniel) [16:30:21] (03CR) 10Glaisher: ChangeEmail should show password-required message (031 comment) [core] - 10https://gerrit.wikimedia.org/r/243681 (https://phabricator.wikimedia.org/T113974) (owner: 10D3r1ck01) [16:30:29] Glaisher: but we removed changeemail-text [16:30:45] d3r1ck: yes and? [16:30:52] 10GitHub-Mirrors: operations/apache-config is not replicated to github - https://phabricator.wikimedia.org/T114667#1702509 (10valhallasw) 3NEW [16:30:54] so why put back the original test in FormSpecialPage? [16:31:03] Glaisher: is it useful? [16:31:20] It's used by other FormSpecialPages not just SpecialChangeEmail. [16:31:26] If you remove it, others would break. [16:31:27] 10MediaWiki-extensions-RelatedArticles, 10Gather, 10Reading Web Planning: Finalise RelatedArticles design - https://phabricator.wikimedia.org/T113768#1702518 (10Jdlrobson) [16:31:33] 10GitHub-Mirrors: operations/apache-config is not replicated to github - https://phabricator.wikimedia.org/T114667#1702521 (10Krenair) p:5Triage>3Lowest Meh, this is an obsolete repository IIRC [16:32:11] Glaisher: i get the whole idea now. :) [16:32:20] Awesome [16:32:35] 10MediaWiki-extensions-DismissableSiteNotice: nl.wikipedia.org sitenotice not displaying - https://phabricator.wikimedia.org/T114652#1702525 (10Umherirrender) When it works for non nlwp users, this could be a issue with the sitenotice id. Please retest, because the edit https://nl.wikipedia.org/w/index.php?title... [16:32:45] (03CR) 10Niedzielski: L10npalooza! Make various UI elements consistent with the article language (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/242893 (https://phabricator.wikimedia.org/T109385) (owner: 10Mholloway) [16:33:05] have just changed the variable to $this->getConfig()->get( 'RequirePasswordforEmailChange' ) [16:33:21] 10MediaWiki-extensions-RelatedArticles, 10Gather, 10Reading Web Planning: Finalise RelatedArticles design - https://phabricator.wikimedia.org/T113768#1702528 (10JKatzWMF) [16:33:32] its fine now. Let me add documentation to qqq.json. I know that one since i have done it before and then submit the final patch :) [16:33:36] 10MediaWiki-extensions-RelatedArticles, 10Gather, 10Reading Web Planning: Finalise RelatedArticles design - https://phabricator.wikimedia.org/T113768#1702530 (10KLans_WMF) @khammerstein, looks like we're moving forward with this for next sprint. Can you talk to @jkatzwmf about specifics? [16:33:56] 10GitHub-Mirrors: operations/apache-config is not replicated to github - https://phabricator.wikimedia.org/T114667#1702531 (10valhallasw) (although it has been discontinued, it would be good to have it accessible so the README which tells you where to look next is actually available...) [16:34:24] 10MediaWiki-extensions-DismissableSiteNotice: nl.wikipedia.org sitenotice not displaying - https://phabricator.wikimedia.org/T114652#1702533 (10Taketa) Did what you suggested. Does not work. [16:34:40] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: [Bug] Show meaningful message on the client when a used (but not connected) entity is deleted or restored. - https://phabricator.wikimedia.org/T114668#1702534 (10daniel) 3NEW [16:34:41] (03Abandoned) 10Bartosz Dziewoński: [WIP] SpecialBlock: Switch to OOUI form [core] - 10https://gerrit.wikimedia.org/r/218281 (https://phabricator.wikimedia.org/T107036) (owner: 10Bartosz Dziewoński) [16:34:56] 10UI-Standardization: Convert Special:Block and Special:Unblock to OOUI - https://phabricator.wikimedia.org/T107036#1702541 (10matmarex) a:5matmarex>3None [16:35:24] 10MediaWiki-extensions-ParserFunctions: #expr does not work properly - https://phabricator.wikimedia.org/T114516#1702545 (10XXN) Thank you TTO! [16:35:59] Glaisher: i can just put same documentations for the other keys right? [16:36:00] "Text of [[Special:ChangeEmail]].", [16:36:14] like that for the changeemail-header and changeemail-passwordrequired [16:37:13] (03PS7) 10D3r1ck01: ChangeEmail should show password-required message [core] - 10https://gerrit.wikimedia.org/r/243681 (https://phabricator.wikimedia.org/T113974) [16:37:21] 10QuickSurveys, 7Beta-Cluster-reproducible, 7I18n, 7Wikimedia-log-errors: QuickSurveys throws exception on non-HTTPS - https://phabricator.wikimedia.org/T114485#1702549 (10greg) [16:37:33] 6Discovery, 10Gather, 10PageImages, 7Beta-Cluster-reproducible, and 2 others: Fatal error: Invalid operand type was used: cannot perform this operation with arrays in /srv/mediawiki/php-master/extensions/PageImages/ApiQueryPageImages.php on line 39 - https://phabricator.wikimedia.org/T114417#1702550 (10greg) [16:38:19] 4(no projects): Spike: Understand how Wikistats Traffic reports are computed {lama} [8 pts] - https://phabricator.wikimedia.org/T114669#1702551 (10Milimetric) 3NEW [16:38:38] Glaisher: you are up now. start the review [16:38:49] if it is fine, you can possible merge [16:39:04] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: [Bug] Improve display of relevant item ID in RecentChanges/Watchlist display on the client. - https://phabricator.wikimedia.org/T114670#1702561 (10daniel) 3NEW [16:39:12] will review in a bit [16:39:47] ok [16:40:44] 10Wikimedia-Mailing-lists: Create affiliates-l mailing list for Wikimedia Movement Affiliates - https://phabricator.wikimedia.org/T113867#1702579 (10JohnLewis) With the new naming scheme, 'affiliates' seems fine with me. Can I have an email(s) for the listadmins? [16:42:13] (03CR) 10Niedzielski: [C: 04-1] L10npalooza! Make various UI elements consistent with the article language (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/242893 (https://phabricator.wikimedia.org/T109385) (owner: 10Mholloway) [16:43:23] 10MediaWiki-Parser: Wrong squashing of blank lines when category link is "removed" from wikitext - https://phabricator.wikimedia.org/T114603#1702596 (10Umherirrender) There is no newline trim at the begin of wikitext, which can also results in this output for html comments, see T25698, which is talking about T61... [16:43:25] 6Discovery, 10Gather, 10PageImages, 7Beta-Cluster-reproducible, and 3 others: Fatal error: Invalid operand type was used: cannot perform this operation with arrays in /srv/mediawiki/php-master/extensions/PageImages/ApiQueryPageImages.php on line 39 - https://phabricator.wikimedia.org/T114417#1702599 (10greg) [16:43:54] Glaisher: i prefer working with extensions, core code is not easy to deal with. Reedy told me about that and even i have discovered that. I spend less time when fixing a bug in an extenstion [16:45:19] (03PS1) 10BearND: Beta: turn on/off RB service remotely plus fallback [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/243689 [16:46:17] (03CR) 10jenkins-bot: [V: 04-1] Beta: turn on/off RB service remotely plus fallback [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/243689 (owner: 10BearND) [16:46:37] 10Wikimedia-Site-Requests, 6Wikisource: Add 'Translation' namespace for bnwikisource - https://phabricator.wikimedia.org/T114623#1702613 (10jayantanth) [[ https://bn.wikisource.org/wiki/%E0%A6%89%E0%A6%87%E0%A6%95%E0%A6%BF%E0%A6%B8%E0%A6%82%E0%A6%95%E0%A6%B2%E0%A6%A8:%E0%A6%B8%E0%A7%8D%E0%A6%95%E0%A7%8D%E0%A6%... [16:47:34] 10Wikimedia-Site-Requests, 6Wikisource: Add 'Translation' namespace for bnwikisource - https://phabricator.wikimedia.org/T114623#1702623 (10jayantanth) [16:49:04] d3r1ck: You still have the change in FormSpecialPage :/ [16:50:32] 10Beta-Cluster-Infrastructure, 10MobileFrontend, 7Easy, 7Mobile: Beta Cluster login (desktop and mobile) should have a warning that it is not a Wikimedia site - https://phabricator.wikimedia.org/T114552#1702625 (10Jdlrobson) The logo or the message? The logo will require a config change and my config chang... [16:51:24] 10MediaWiki-extensions-CentralAuth, 10GlobalRename: Global rename logs lost or never logged - https://phabricator.wikimedia.org/T111847#1702626 (10Glaisher) Legoktm just ran the script (or still running) and https://meta.wikimedia.org/w/index.php?title=Special:Log&type=gblrename&user=Kaare is now populated wit... [16:52:20] 10Beta-Cluster-Infrastructure, 10MobileFrontend, 7Easy, 7Mobile: Beta Cluster login (desktop and mobile) should have a warning that it is not a Wikimedia site - https://phabricator.wikimedia.org/T114552#1702631 (10Krenair) >>! In T114552#1702625, @Jdlrobson wrote: > The logo or the message? The logo will r... [16:52:28] 10MediaWiki-extensions-CentralAuth, 10GlobalRename: Global rename logs lost or never logged - https://phabricator.wikimedia.org/T111847#1702632 (10Glaisher) 5Open>3Resolved a:3Glaisher It has finished running. Thanks again. [16:52:43] 10MediaWiki-extensions-CentralAuth, 10GlobalRename: Global rename logs lost or never logged - https://phabricator.wikimedia.org/T111847#1702636 (10Glaisher) a:5Glaisher>3Legoktm [16:53:04] (03PS2) 10BearND: Beta: turn on/off RB service remotely plus fallback [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/243689 [16:53:20] 10MediaWiki-extensions-CentralAuth, 10GlobalRename, 6Reading-Infrastructure-Team, 10SUL-Finalization, 5Patch-For-Review: Back-fill log entries from GlobalRenameQueue renames that promoted to a global account - https://phabricator.wikimedia.org/T93214#1702638 (10Glaisher) The script has been run on metawi... [16:54:04] 10CirrusSearch, 6Discovery, 7Epic: [EPIC] Relevance Lab - https://phabricator.wikimedia.org/T114673#1702641 (10EBernhardson) 3NEW [16:54:29] Glaisher: which change agian? [16:54:39] i have undone everything to original [16:54:43] that is the original file [16:54:51] 10Wikimedia-Developer-Summit-2016: What can the Search API do for you? - https://phabricator.wikimedia.org/T113540#1702649 (10Tfinc) @dr0ptp4kt: I'd like to meet this week to discuss. Can you make sure you have your team discussion before? [16:55:22] d3r1ck: https://gerrit.wikimedia.org/r/#/c/243681/ still lists FormSpecialPage [16:55:34] Please leave it as it was originally untouched. [16:55:52] 10MediaWiki-ResourceLoader: Remove @nomin comment from output - https://phabricator.wikimedia.org/T114674#1702651 (10Umherirrender) 3NEW [16:56:06] Glaisher: yes, it is back to original i am serious. It was because of my commit but it is ok now [16:56:50] Glaisher: it waas because of my previous commits. It is fine now. It is exactly like the original. [16:56:55] d3r1ck: If it hasn't been changed, it won't be shown there.. [16:57:05] https://gerrit.wikimedia.org/r/#/c/243681/7/includes/specialpage/FormSpecialPage.php [16:57:55] Glaisher: it is just the position. Sorry [16:57:58] let me put it back [16:58:03] Thanks for the correction [16:58:23] Extensions aren't necesserily easier [16:58:26] They depend on core a lot [16:58:33] (03PS8) 10D3r1ck01: ChangeEmail should show password-required message [core] - 10https://gerrit.wikimedia.org/r/243681 (https://phabricator.wikimedia.org/T113974) [16:59:13] Reedy: yes that is true. But as compared to the core itself, i love extensions. MobileFront End is my best [16:59:39] Glaisher: you are up now. Is it ok? [17:00:41] (03CR) 10Reedy: [C: 031] ChangeEmail should show password-required message (031 comment) [core] - 10https://gerrit.wikimedia.org/r/243681 (https://phabricator.wikimedia.org/T113974) (owner: 10D3r1ck01) [17:00:42] 10MediaWiki-extensions-DismissableSiteNotice: nl.wikipedia.org sitenotice not displaying - https://phabricator.wikimedia.org/T114652#1702670 (10Umherirrender) I am seeing sitenotice logged in and as anon (other browser) The sitenotice needs javascript. If javascript is disabled, the sitenotice is not visible. M... [17:00:47] (03CR) 10Reedy: [C: 04-1] ChangeEmail should show password-required message [core] - 10https://gerrit.wikimedia.org/r/243681 (https://phabricator.wikimedia.org/T113974) (owner: 10D3r1ck01) [17:01:56] Reedy: which leading space? [17:01:58] (03CR) 10Glaisher: [C: 04-1] ChangeEmail should show password-required message (032 comments) [core] - 10https://gerrit.wikimedia.org/r/243681 (https://phabricator.wikimedia.org/T113974) (owner: 10D3r1ck01) [17:02:06] I see a space then 3 tabs [17:02:13] gerrit is showing it as a bright read highlighting [17:02:15] (03PS1) 10Niedzielski: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/243693 [17:02:23] 10MediaWiki-extensions-DismissableSiteNotice: nl.wikipedia.org sitenotice not displaying - https://phabricator.wikimedia.org/T114652#1702675 (10Taketa) I cannot open te source. I have no options there. [17:02:35] Reedy: which line? [17:02:46] 123 [17:03:01] Do you not see a bright red block on https://gerrit.wikimedia.org/r/#/c/243681/8/includes/specials/SpecialChangeEmail.php,unified ? [17:03:02] 10MediaWiki-extensions-Translate: Special:Translate in mediawiki.org is shows empty list - https://phabricator.wikimedia.org/T114239#1702678 (10Kaganer) I'm sorry :) JavaScript Console result: - JavaScript parse error: Parse error: Unexpected token; token 3 expected in file 'MediaWiki:Gadget-ajaxrecentchanges.... [17:04:19] 10MediaWiki-Parser: Use the new Tidy in the MW parser to perform HTML 5 parsing/reserialization. - https://phabricator.wikimedia.org/T113976#1702681 (10MarkAHershberger) 5Open>3declined a:3MarkAHershberger Lack of interest in using libtidy and lack of interest in libtidy devs to accomodate the needs of MW. [17:05:17] (03PS9) 10D3r1ck01: ChangeEmail should show password-required message [core] - 10https://gerrit.wikimedia.org/r/243681 (https://phabricator.wikimedia.org/T113974) [17:05:37] Reedy, Glaisher, review [17:06:04] d3r1ck: It's still there... [17:06:47] also https://gerrit.wikimedia.org/r/#/c/243681/9/languages/i18n/qqq.json has a typo [17:06:50] of -> if [17:07:12] 10MediaWiki-extensions-Translate: Special:Translate in mediawiki.org is shows empty list - https://phabricator.wikimedia.org/T114239#1702690 (10Kaganer) Disabling Gadget-ajaxrecentchanges.js and Gadget-oldeditor.js is resolved this problem. But maybe need to study the cause of the conflict? [17:07:49] (03PS11) 10BearND: Add link to spoken version of article, if available [services/mobileapps] - 10https://gerrit.wikimedia.org/r/241756 (https://phabricator.wikimedia.org/T108372) (owner: 10Mholloway) [17:07:54] (03CR) 10Sniedzielski: [C: 032] Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/243693 (owner: 10Niedzielski) [17:08:05] 10MediaWiki-RfCs, 10EventBus, 6Services, 10Wikipedia-iOS-App-Product-Backlog: Implementation option for reliable event bus: Kafka - https://phabricator.wikimedia.org/T88459#1702693 (10GWicke) [17:08:52] 10MediaWiki-RfCs, 6Services, 10Wikimedia-Developer-Summit-2016: RFC: Requirements for change propagation - https://phabricator.wikimedia.org/T102476#1702694 (10GWicke) [17:09:11] 10Wikimedia-Developer-Summit-2016: What can the Search API do for you? - https://phabricator.wikimedia.org/T113540#1702695 (10dr0ptp4kt) @tfinc - yep. CC @jdlrobson, @dbrant, @niedzielski, @bearnd, @bgerstle-wmf. [17:09:14] (03CR) 10jenkins-bot: [V: 04-1] Add link to spoken version of article, if available [services/mobileapps] - 10https://gerrit.wikimedia.org/r/241756 (https://phabricator.wikimedia.org/T108372) (owner: 10Mholloway) [17:10:19] 4(no projects): Anonymize data in pageview_hourly to comply with privacy policy - https://phabricator.wikimedia.org/T114675#1702699 (10Nuria) 3NEW [17:10:43] 4(no projects): Anonymize data in pageview_hourly to comply with privacy policy - https://phabricator.wikimedia.org/T114675#1702705 (10Nuria) [17:11:27] (03PS10) 10D3r1ck01: ChangeEmail should show password-required message [core] - 10https://gerrit.wikimedia.org/r/243681 (https://phabricator.wikimedia.org/T113974) [17:11:36] Glaisher: i don't understand the space you are talking about. [17:11:44] Reedy: can you send me a link so i can see it? [17:11:58] https://gerrit.wikimedia.org/r/#/c/243681/10/includes/specials/SpecialChangeEmail.php is there no red block here? [17:12:10] oh wait.. I think it's a preference [17:12:34] (03CR) 10BearND: [C: 04-1] "@Mholloway I would prefer to have an extra level in there so we have the flexibility to add more to the spoken object, e.g. like author in" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/241756 (https://phabricator.wikimedia.org/T108372) (owner: 10Mholloway) [17:12:36] Can you click on the "Preferences" link and check whitespace errors and save it? [17:12:37] 4(no projects): Anonymize data in pageview_hourly to comply with privacy policy - https://phabricator.wikimedia.org/T114675#1702707 (10Nuria) p:5Triage>3High [17:12:43] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/243693 (owner: 10Niedzielski) [17:14:07] Glaisher: i don't understand what is causing it. [17:14:43] You only need 3 tabs there. [17:14:57] 10MobileFrontend: Missing watchlist stars, search suggestions and more on English Wikipedia mobile site - https://phabricator.wikimedia.org/T114599#1702709 (10Jdlrobson) p:5Triage>3Unbreak! [17:15:07] 10MobileFrontend, 3Reading-Web-Sprint-57-The Fifth Element: Missing watchlist stars, search suggestions and more on English Wikipedia mobile site - https://phabricator.wikimedia.org/T114599#1700274 (10Jdlrobson) [17:15:50] 3Reading-Web-Sprint-57-The Fifth Element: Spike: Scope the first version of JavaScript-based prototype on existing Parsoid service - https://phabricator.wikimedia.org/T113769#1702712 (10Jhernandez) 5stalled>3Open a:3Jhernandez [17:16:04] (03CR) 10Alex Monk: [C: 032] Add grunt linting tasks [extensions/Score] - 10https://gerrit.wikimedia.org/r/243523 (owner: 10Esanders) [17:16:35] 10MediaWiki-extensions-CentralAuth, 10GlobalRename, 6Reading-Infrastructure-Team, 10SUL-Finalization, 5Patch-For-Review: Back-fill log entries from GlobalRenameQueue renames that promoted to a global account - https://phabricator.wikimedia.org/T93214#1702716 (10Glaisher) p:5Unbreak!>3Normal [17:17:44] 10MobileFrontend: Entry field obscured - https://phabricator.wikimedia.org/T114567#1702720 (10Jdlrobson) I'm a little confused. Hi @rpetruzzelli to clarify is this an issue in the app? I think when you talk about uploads you are talking about phabricator? @jminor @mhurd does this make any sense to you? [17:18:13] (03Merged) 10jenkins-bot: Add grunt linting tasks [extensions/Score] - 10https://gerrit.wikimedia.org/r/243523 (owner: 10Esanders) [17:18:15] (03Merged) 10jenkins-bot: Consistently use spaces inside brackets in CSS [extensions/Score] - 10https://gerrit.wikimedia.org/r/243524 (owner: 10Esanders) [17:18:24] Glaisher: ohhh, there waas a space [17:18:29] before the three tabs [17:18:35] 10MediaWiki-extensions-DismissableSiteNotice: nl.wikipedia.org sitenotice not displaying - https://phabricator.wikimedia.org/T114652#1702727 (10Taketa) Btw, after this change https://nl.wikipedia.org/w/index.php?title=MediaWiki%3AAnonnotice&type=revision&diff=45034632&oldid=43699350 I can now see it in explorer... [17:18:48] Ohhh, i am sorry Glaisher and also jenkins, pardon me for my slow observation [17:19:27] (03PS11) 10D3r1ck01: ChangeEmail should show password-required message [core] - 10https://gerrit.wikimedia.org/r/243681 (https://phabricator.wikimedia.org/T113974) [17:19:40] Glaisher: you are up now. [17:20:22] 10MediaWiki-extensions-DismissableSiteNotice: nl.wikipedia.org sitenotice not displaying - https://phabricator.wikimedia.org/T114652#1702730 (10NDKilla) I too now see this on google chrome, logged in and logged out [17:20:43] https://gerrit.wikimedia.org/r/#/c/243681/11/languages/i18n/qqq.json changeemail-text not removed [17:20:47] sorry I missed it before [17:21:13] Glaisher: so i should remove changeemail-text? [17:21:15] 10Wikimedia-Developer-Summit-2016: Next Generation Content Loading and Routing, in Practice - https://phabricator.wikimedia.org/T114542#1702735 (10dr0ptp4kt) @qgil, thank you for the update. For the plan documentation, is there a particular format you'd recommend? Or is it somewhat open ended? I should ask: is t... [17:21:28] yes [17:21:43] ok [17:21:46] done [17:21:50] submitting right now [17:21:51] (03CR) 10Spage: "Thanks for the review." (031 comment) [skins/Blueprint] - 10https://gerrit.wikimedia.org/r/240632 (https://phabricator.wikimedia.org/T113566) (owner: 10Spage) [17:22:13] (03PS12) 10D3r1ck01: ChangeEmail should show password-required message [core] - 10https://gerrit.wikimedia.org/r/243681 (https://phabricator.wikimedia.org/T113974) [17:22:35] 10Reading-Community-Engagement: Investigate if other Wikipedias would like to try the new Wikivoyage banner - https://phabricator.wikimedia.org/T113617#1702743 (10JKatzWMF) @khammerstein and @mosuhira, The reluctance we saw with Catalan, seemed to be rooted in it being perceived as a wikivoyage thing. The pri... [17:26:03] (03PS13) 10Glaisher: Show password-required message only if $wgRequirePasswordforEmailChange = true [core] - 10https://gerrit.wikimedia.org/r/243681 (https://phabricator.wikimedia.org/T113974) (owner: 10D3r1ck01) [17:26:41] (03CR) 10Glaisher: [C: 031] Show password-required message only if $wgRequirePasswordforEmailChange = true [core] - 10https://gerrit.wikimedia.org/r/243681 (https://phabricator.wikimedia.org/T113974) (owner: 10D3r1ck01) [17:26:54] 4(no projects): EXTERNAL: Email info referenced on Merchant Reference 2 field - https://phabricator.wikimedia.org/T114678#1702776 (10Ppena) 3NEW [17:28:10] (03CR) 10Alex Monk: [C: 031] VE: Move hash changes to the rendering hash [extensions/Math] - 10https://gerrit.wikimedia.org/r/242895 (owner: 10Esanders) [17:29:03] 4(no projects): EXTERNAL: Email info referenced on Merchant Reference 2 field - https://phabricator.wikimedia.org/T114678#1702812 (10Krenair) Fundraising task of some sort? Maybe CiviCRM? [17:29:25] 10Reading-Community-Engagement: Investigate if other Wikipedias would like to try the new Wikivoyage banner - https://phabricator.wikimedia.org/T113617#1702813 (10Moushira) Thanks a lot @JKatzWMF! This makes more sense to be how we move forward. Am sure it is a typo, but Spanish WP is where the suggestion... [17:34:37] 10MediaWiki-Documentation, 10Possible-Tech-Projects, 6WMF-Legal, 10Web-APIs-Hub, 7Documentation: technology to transclude git content into wiki pages - https://phabricator.wikimedia.org/T91626#1702875 (10Laucon) Great! So how should I get started? [17:39:59] (03PS5) 10Dduvall: Remove GM engine from thumbor role [vagrant] - 10https://gerrit.wikimedia.org/r/239989 (owner: 10Gilles) [17:40:58] (03CR) 10Dduvall: [C: 032] Remove GM engine from thumbor role [vagrant] - 10https://gerrit.wikimedia.org/r/239989 (owner: 10Gilles) [17:41:15] (03Merged) 10jenkins-bot: Remove GM engine from thumbor role [vagrant] - 10https://gerrit.wikimedia.org/r/239989 (owner: 10Gilles) [17:42:01] 6Discovery, 10Gather, 10PageImages, 7Beta-Cluster-reproducible, and 3 others: Fatal error: Invalid operand type was used: cannot perform this operation with arrays in /srv/mediawiki/php-master/extensions/PageImages/ApiQueryPageImages.php on line 39 - https://phabricator.wikimedia.org/T114417#1702881 (10Jdlr... [17:42:09] Glaisher: all the test was successful. Jenkins is happy :) [17:42:36] (03PS1) 10Florianschmidtwelzow: Split CategorySelector widget to it's own module [core] - 10https://gerrit.wikimedia.org/r/243701 (https://phabricator.wikimedia.org/T108733) [17:45:48] 10MediaWiki-extensions-TimedMediaHandler, 6operations: Update ffmpeg2theora package to fix additional ogv transcode failures - https://phabricator.wikimedia.org/T114557#1699347 (10brion) (Note last major update to our ffmpeg2theora package was for T69953 -- just need to swap out the patch file for newer one.) [17:46:01] (03CR) 10Florianschmidtwelzow: [C: 04-1] Split CategorySelector widget to it's own module (031 comment) [core] - 10https://gerrit.wikimedia.org/r/243701 (https://phabricator.wikimedia.org/T108733) (owner: 10Florianschmidtwelzow) [17:46:31] (03PS12) 10Mholloway: Add link to spoken version of article, if available [services/mobileapps] - 10https://gerrit.wikimedia.org/r/241756 (https://phabricator.wikimedia.org/T108372) [17:46:39] (03CR) 10Aaron Schulz: [C: 032] Add null to @return tags if a method can return null [core] - 10https://gerrit.wikimedia.org/r/243680 (owner: 10Thiemo Mättig (WMDE)) [17:47:14] (03CR) 10jenkins-bot: [V: 04-1] Add link to spoken version of article, if available [services/mobileapps] - 10https://gerrit.wikimedia.org/r/241756 (https://phabricator.wikimedia.org/T108372) (owner: 10Mholloway) [17:47:49] 10MediaWiki-extensions-EducationProgram, 10Possible-Tech-Projects: Education Program, outreach and projects - https://phabricator.wikimedia.org/T89136#1702914 (10Shrutika719) I request the mentors to kindly give a list of the sub-tasks involved in this project so that we can get a clear idea of the work we nee... [17:50:04] 4(no projects): EXTERNAL: Email info referenced on Merchant Reference 2 field - https://phabricator.wikimedia.org/T114678#1702929 (10DStrine) [17:50:14] (03CR) 10Keegan: "I'm trying to get Elitre to comment, this is/was her idea I believe." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/206482 (https://phabricator.wikimedia.org/T93782) (owner: 10Nemo bis) [17:51:17] (03PS1) 10Florianschmidtwelzow: Split out UserInputWidgets from mediawiki.widgets [core] - 10https://gerrit.wikimedia.org/r/243702 (https://phabricator.wikimedia.org/T108733) [17:52:55] (03PS2) 10Florianschmidtwelzow: Split CategorySelector widget to it's own module [core] - 10https://gerrit.wikimedia.org/r/243701 (https://phabricator.wikimedia.org/T108733) [17:52:57] (03CR) 10Mattflaschen: [C: 04-1] "You should explain why and tag with related bugs, and probably say what the initial composer.json will do (will it have an effect immediat" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/243678 (owner: 10Paladox) [17:53:16] (03CR) 10Mattflaschen: "E,g, changes to Jenkins config repo." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/243678 (owner: 10Paladox) [17:56:02] (03Merged) 10jenkins-bot: Add null to @return tags if a method can return null [core] - 10https://gerrit.wikimedia.org/r/243680 (owner: 10Thiemo Mättig (WMDE)) [17:56:27] (03CR) 10Aaron Schulz: Enforce stricter slave lag limits for bot API requests (032 comments) [core] - 10https://gerrit.wikimedia.org/r/243089 (https://phabricator.wikimedia.org/T95501) (owner: 10Aaron Schulz) [17:58:38] (03CR) 10Aaron Schulz: "It can't be 'max lag' since the whole point is for it to be *lower* than maxlag. Since it's bot specific I don't want use more global stat" [core] - 10https://gerrit.wikimedia.org/r/243089 (https://phabricator.wikimedia.org/T95501) (owner: 10Aaron Schulz) [17:58:53] 10GoogleLogin: BadMethodCallException in SpecialGoogleLogin.php on line 452 - https://phabricator.wikimedia.org/T114686#1702992 (10Florian) 3NEW a:3Florian [18:00:09] (03PS1) 10BearND: Fix tests after testwiki protection has changed [services/mobileapps] - 10https://gerrit.wikimedia.org/r/243705 [18:00:22] (03CR) 10Aaron Schulz: "Sure, it could be moved to a separate method called by checkExecutePermissions() where the read-only check is." [core] - 10https://gerrit.wikimedia.org/r/243089 (https://phabricator.wikimedia.org/T95501) (owner: 10Aaron Schulz) [18:00:23] mdholloway: ^ [18:01:31] (03PS1) 10Ori.livneh: Small optimization for FileContentsHasher [core] - 10https://gerrit.wikimedia.org/r/243707 [18:01:49] (03CR) 10Anomie: [C: 031] "Tested, seems to work." [extensions/GPGMail] - 10https://gerrit.wikimedia.org/r/242000 (https://phabricator.wikimedia.org/T12453) (owner: 10Gergő Tisza) [18:01:52] (03PS1) 10Florianschmidtwelzow: Check, if the User object was created before accessing functions on it [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/243708 (https://phabricator.wikimedia.org/T114686) [18:02:09] 10MediaWiki-RfCs: RFC: make Parser::getTargetLanguage aware of multilingual wikis - https://phabricator.wikimedia.org/T114640#1703042 (10cscott) @daniel sounds right. >>! In T114640#1702325, @daniel wrote: > For pages that have sections in different languages, the page content language and the display language... [18:02:14] (03CR) 10jenkins-bot: [V: 04-1] Check, if the User object was created before accessing functions on it [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/243708 (https://phabricator.wikimedia.org/T114686) (owner: 10Florianschmidtwelzow) [18:02:18] (03PS2) 10Ori.livneh: Small optimization for FileContentsHasher [core] - 10https://gerrit.wikimedia.org/r/243707 [18:02:48] (03PS2) 10Florianschmidtwelzow: Check, if the User object was created before accessing functions on it [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/243708 (https://phabricator.wikimedia.org/T114686) [18:03:33] (03PS1) 10Ori.livneh: Small optimization for FileContentsHasher [core] (wmf/1.27.0-wmf.1) - 10https://gerrit.wikimedia.org/r/243709 [18:03:55] (03CR) 10Ori.livneh: [C: 032] Small optimization for FileContentsHasher [core] (wmf/1.27.0-wmf.1) - 10https://gerrit.wikimedia.org/r/243709 (owner: 10Ori.livneh) [18:04:16] (03CR) 10Mholloway: [C: 032] Fix tests after testwiki protection has changed [services/mobileapps] - 10https://gerrit.wikimedia.org/r/243705 (owner: 10BearND) [18:04:48] (03CR) 10jenkins-bot: [V: 04-1] Small optimization for FileContentsHasher [core] - 10https://gerrit.wikimedia.org/r/243707 (owner: 10Ori.livneh) [18:04:52] (03PS3) 10Gergő Tisza: Add UserMailerTransformContent and UserMailerSplitTo hooks [core] - 10https://gerrit.wikimedia.org/r/242791 (https://phabricator.wikimedia.org/T12453) [18:05:04] (03CR) 10jenkins-bot: [V: 04-1] Small optimization for FileContentsHasher [core] (wmf/1.27.0-wmf.1) - 10https://gerrit.wikimedia.org/r/243709 (owner: 10Ori.livneh) [18:05:31] (03Merged) 10jenkins-bot: Fix tests after testwiki protection has changed [services/mobileapps] - 10https://gerrit.wikimedia.org/r/243705 (owner: 10BearND) [18:06:29] (03PS3) 10Ori.livneh: Small optimization for FileContentsHasher [core] - 10https://gerrit.wikimedia.org/r/243707 [18:06:31] (03CR) 10Jforrester: "Is this another thing we need to back-port to REL1_26 to avoid making a breaking change?" [core] - 10https://gerrit.wikimedia.org/r/243701 (https://phabricator.wikimedia.org/T108733) (owner: 10Florianschmidtwelzow) [18:06:45] (03PS3) 10Florianschmidtwelzow: Add a "back to top" button to the bottom right of the page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/242185 (https://phabricator.wikimedia.org/T98701) [18:07:53] (03PS2) 10Ori.livneh: Small optimization for FileContentsHasher [core] (wmf/1.27.0-wmf.1) - 10https://gerrit.wikimedia.org/r/243709 [18:07:59] (03PS13) 10Mholloway: Add link to spoken version of article, if available [services/mobileapps] - 10https://gerrit.wikimedia.org/r/241756 (https://phabricator.wikimedia.org/T108372) [18:08:29] (03PS6) 10Gergő Tisza: [WIP] MVP [extensions/GPGMail] - 10https://gerrit.wikimedia.org/r/242000 (https://phabricator.wikimedia.org/T12453) [18:08:47] (03CR) 10Ori.livneh: [C: 032] Small optimization for FileContentsHasher [core] (wmf/1.27.0-wmf.1) - 10https://gerrit.wikimedia.org/r/243709 (owner: 10Ori.livneh) [18:09:19] (03CR) 10jenkins-bot: [V: 04-1] Add link to spoken version of article, if available [services/mobileapps] - 10https://gerrit.wikimedia.org/r/241756 (https://phabricator.wikimedia.org/T108372) (owner: 10Mholloway) [18:10:16] (03CR) 10Florianschmidtwelzow: "It depends on, if the CategorySelector will be used in extensions, e.g., or if "only" the ForeignStructuredUpload.BookletLayout module is " [core] - 10https://gerrit.wikimedia.org/r/243701 (https://phabricator.wikimedia.org/T108733) (owner: 10Florianschmidtwelzow) [18:10:42] (03CR) 10jenkins-bot: [V: 04-1] Small optimization for FileContentsHasher [core] - 10https://gerrit.wikimedia.org/r/243707 (owner: 10Ori.livneh) [18:11:37] (03CR) 10jenkins-bot: [V: 04-1] Small optimization for FileContentsHasher [core] (wmf/1.27.0-wmf.1) - 10https://gerrit.wikimedia.org/r/243709 (owner: 10Ori.livneh) [18:11:43] 10MediaWiki-extensions-TimedMediaHandler, 6operations: Update ffmpeg2theora package to fix additional ogv transcode failures - https://phabricator.wikimedia.org/T114557#1703089 (10brion) Updated patch: {F2660426} drop into the debian/patches/ replacing the old fix-resample-sefault.patch. [18:12:01] (03CR) 10Florianschmidtwelzow: "ping :)" [core] - 10https://gerrit.wikimedia.org/r/238497 (https://phabricator.wikimedia.org/T78373) (owner: 10Florianschmidtwelzow) [18:12:02] jdlrobson: ping [18:12:04] 10MediaWiki-RfCs, 10EventBus, 6Services, 10Wikipedia-iOS-App-Product-Backlog: Implementing the reliable event bus using Kafka - https://phabricator.wikimedia.org/T88459#1703090 (10GWicke) [18:12:40] 10Reading Web Planning: Measure readers reading habits - https://phabricator.wikimedia.org/T114655#1703091 (10Jdlrobson) Possibly could use user agent but I'd rather make this easier to filter by given its importance in answering the question of do people that read post lead have service worker. Going forward we... [18:13:28] 10Reading Web Planning: Measure readers reading habits - https://phabricator.wikimedia.org/T114655#1703092 (10Jdlrobson) [18:13:52] (03PS4) 10Ori.livneh: Small optimization for FileContentsHasher [core] - 10https://gerrit.wikimedia.org/r/243707 [18:13:55] (03PS14) 10Mholloway: Add link(s) to spoken version of article, if available [services/mobileapps] - 10https://gerrit.wikimedia.org/r/241756 (https://phabricator.wikimedia.org/T108372) [18:13:57] 7Availability: Make and document DC switch-over scripts - https://phabricator.wikimedia.org/T114398#1703094 (10aaron) [18:14:12] (03PS3) 10Ori.livneh: Small optimization for FileContentsHasher [core] (wmf/1.27.0-wmf.1) - 10https://gerrit.wikimedia.org/r/243709 [18:14:29] 10MediaWiki-Email, 10MediaWiki-Extension-Requests, 10MediaWiki-extensions-GPGMail, 6Collaboration-Team-Backlog, and 3 others: Encrypt emails with GnuPG (GPG) - https://phabricator.wikimedia.org/T12453#1703096 (10Anomie) Testing with mutt: * PGP/MIME with plaintext is detected and automatically decrypts. *... [18:14:30] (03CR) 10Ori.livneh: [C: 032] Small optimization for FileContentsHasher [core] (wmf/1.27.0-wmf.1) - 10https://gerrit.wikimedia.org/r/243709 (owner: 10Ori.livneh) [18:15:21] 10MediaWiki-General-or-Unknown, 10Analytics, 6Discovery, 10EventBus, and 6 others: EventBus MVP - https://phabricator.wikimedia.org/T114443#1703097 (10Eevans) >>! In T114443#1701296, @Joe wrote: > Apart from the concerns on a practical use case which I agree with, I have a big doubt about the implementatio... [18:18:50] (03PS2) 10Paladox: Add composer.json [extensions/Echo] - 10https://gerrit.wikimedia.org/r/243678 [18:19:37] (03CR) 10Paladox: "I doint think there a bug for this because it isent replacing the phpcs test." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/243678 (owner: 10Paladox) [18:19:40] 6Reading-Admin: Reading-wmf mailing list name should start with "Reading-Internal" - https://phabricator.wikimedia.org/T102421#1703103 (10Niedzielski) I'm not sure how, but @dr0ptp4kt's change is now showing up as "Internal communication for WMF Reading team" again. It might just be my Gmail client but I've not... [18:20:15] 10MediaWiki-Page-editing, 6Performance-Team: [Research] Investigate regression Save Timing as of 2015-09-10 - https://phabricator.wikimedia.org/T114339#1703106 (10Krinkle) p:5Triage>3Normal [18:21:47] 10MediaWiki-extensions-GPGMail: GPGMail should store keys in a custom table - https://phabricator.wikimedia.org/T114692#1703108 (10Tgr) 3NEW [18:22:03] (03PS7) 10Gergő Tisza: MVP [extensions/GPGMail] - 10https://gerrit.wikimedia.org/r/242000 (https://phabricator.wikimedia.org/T12453) [18:23:02] (03CR) 10Gergő Tisza: "On second thought this is good enough for an MVP (small wikis might not care about the problems). I opened T114692 about the key storage i" [extensions/GPGMail] - 10https://gerrit.wikimedia.org/r/242000 (https://phabricator.wikimedia.org/T12453) (owner: 10Gergő Tisza) [18:23:04] (03CR) 10Anomie: Enforce stricter slave lag limits for bot API requests (032 comments) [core] - 10https://gerrit.wikimedia.org/r/243089 (https://phabricator.wikimedia.org/T95501) (owner: 10Aaron Schulz) [18:23:59] 7Design, 10VisualEditor, 10VisualEditor-MediaWiki-Links: The link dialog expands over the visible part of the page - https://phabricator.wikimedia.org/T114614#1703116 (10Spage) p:5Triage>3High I'm seeing this too on mw.org. The list wasn't that long before, it fit within the window. I'm also having the... [18:25:14] (03CR) 10Florianschmidtwelzow: [C: 04-2] "Creating a copy of a file from core (or any other extension) looks very strange and isn't a Hack anymore, it's a bad code style. If you ha" (031 comment) [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/241471 (https://phabricator.wikimedia.org/T113860) (owner: 10Paladox) [18:27:02] (03CR) 10Mattflaschen: "Does it affect which runs in Jenkins, or only locally?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/243678 (owner: 10Paladox) [18:28:25] (03CR) 10Mattflaschen: "Also, wrap your commit message lines so they don't overflow like that (about 76 characters)." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/243678 (owner: 10Paladox) [18:30:43] (03Abandoned) 10Ori.livneh: resourceloader: Make ObjectCache instance configurable [core] - 10https://gerrit.wikimedia.org/r/243210 (owner: 10Ori.livneh) [18:30:56] (03CR) 10Anomie: "One tiny nitpick" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/242791 (https://phabricator.wikimedia.org/T12453) (owner: 10Gergő Tisza) [18:31:32] 6Discovery: Create deployment for wikimedia/portals - https://phabricator.wikimedia.org/T114694#1703137 (10Smalyshev) 3NEW [18:31:57] 6Discovery: Create deployment for wikimedia/portals - https://phabricator.wikimedia.org/T114694#1703146 (10Smalyshev) [18:32:39] 6Discovery: Create deployment for wikimedia/portals - https://phabricator.wikimedia.org/T114694#1703137 (10Smalyshev) [18:32:40] 6Discovery, 10Wikimedia-General-or-Unknown, 3Discovery-Cirrus-Sprint, 5Patch-For-Review, 7WorkType-NewFunctionality: Investigate moving the www.wikipedia.org portal to Git/Gerrit - https://phabricator.wikimedia.org/T110070#1568690 (10Smalyshev) [18:33:25] (03CR) 10Paladox: "Well no not really it does the same thing as phplint only that it is done from composer so that we can add php code sniffer in the future." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/243678 (owner: 10Paladox) [18:33:28] (03CR) 10Jforrester: "CategorySelector is already used in e.g. UploadWizard." [core] - 10https://gerrit.wikimedia.org/r/243701 (https://phabricator.wikimedia.org/T108733) (owner: 10Florianschmidtwelzow) [18:33:32] (03PS3) 10Paladox: Add composer.json [extensions/Echo] - 10https://gerrit.wikimedia.org/r/243678 [18:35:54] 10MediaWiki-extensions-DismissableSiteNotice: nl.wikipedia.org sitenotice not displaying - https://phabricator.wikimedia.org/T114652#1703165 (10Aklapper) Thanks Umherirrender for your help (and to Glaisher on IRC too)! >>! In T114652#1702727, @Taketa wrote: > I can still not see it in Chrome logged in or out.... [18:37:24] 3Mobile-App-Android-Sprint-67-Holmium, 5Patch-For-Review, 3Wikipedia-Android-App: Make app elements align to correct keylines - https://phabricator.wikimedia.org/T110685#1703175 (10Etonkovidova) Re-checked with 2.0.131-alpha-2015-10-05 build. [18:37:29] (03CR) 10Florianschmidtwelzow: "Uohh, I missed that while I looked for usages, sorry :/" [core] - 10https://gerrit.wikimedia.org/r/243701 (https://phabricator.wikimedia.org/T108733) (owner: 10Florianschmidtwelzow) [18:38:04] (03CR) 10Jforrester: "Need to do this as backwards-compat then." [core] - 10https://gerrit.wikimedia.org/r/243701 (https://phabricator.wikimedia.org/T108733) (owner: 10Florianschmidtwelzow) [18:38:22] 10MediaWiki-General-or-Unknown, 10MediaWiki-ResourceLoader: Split mediawiki.skinning.interface css files into separate modules - https://phabricator.wikimedia.org/T114695#1703180 (10Paladox) 3NEW [18:38:38] 10MediaWiki-General-or-Unknown, 10MediaWiki-ResourceLoader: Split mediawiki.skinning.interface css files into separate modules - https://phabricator.wikimedia.org/T114695#1703187 (10Paladox) [18:38:58] 4(no projects): Add link to Discovery landing page on data dash. - https://phabricator.wikimedia.org/T114696#1703190 (10Wwes) 3NEW a:3Deskana [18:39:16] 10MediaWiki-General-or-Unknown, 10MediaWiki-ResourceLoader: Split mediawiki.skinning.interface css files into separate modules - https://phabricator.wikimedia.org/T114695#1703180 (10Paladox) Added @florian per https://gerrit.wikimedia.org/r/#/c/241471/ who ask me to file a task. Please remove your self if I s... [18:39:31] (03CR) 10Paladox: "Ok filed here T114695" [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/241471 (https://phabricator.wikimedia.org/T113860) (owner: 10Paladox) [18:39:44] 7Design, 10VisualEditor, 10VisualEditor-MediaWiki-Links: Maximum height of the link editor should take into account the toolbar height too - https://phabricator.wikimedia.org/T114614#1703206 (10Jdforrester-WMF) p:5High>3Normal [18:40:09] 10MediaWiki-General-or-Unknown, 10MediaWiki-ResourceLoader: Split mediawiki.skinning.interface css files into separate modules - https://phabricator.wikimedia.org/T114695#1703211 (10Paladox) [18:41:09] (03PS3) 10Florianschmidtwelzow: Split CategorySelector widget to it's own module [core] - 10https://gerrit.wikimedia.org/r/243701 (https://phabricator.wikimedia.org/T108733) [18:41:24] (03CR) 10Aaron Schulz: Enforce stricter slave lag limits for bot API requests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/243089 (https://phabricator.wikimedia.org/T95501) (owner: 10Aaron Schulz) [18:42:19] 6Discovery: Add link to Discovery landing page on data dash. - https://phabricator.wikimedia.org/T114696#1703214 (10Deskana) p:5Triage>3Normal [18:42:50] (03PS1) 10Ori.livneh: Tiny optimization to ResourceLoader::isValidModuleName() [core] - 10https://gerrit.wikimedia.org/r/243717 [18:44:02] 6Education-Collab: Get all Collab members onto Phabricator and subscribed to the Education-Collab project - https://phabricator.wikimedia.org/T114572#1703222 (10FloorKoudijs) @selsharbaty-wmf: Phabricator allows you to change the settings for notifications, so even if Collab members subscribe to the Collab proje... [18:44:08] (03PS1) 10Ori.livneh: Tiny optimization to ResourceLoader::isValidModuleName() [core] (wmf/1.27.0-wmf.1) - 10https://gerrit.wikimedia.org/r/243718 [18:44:36] (03CR) 10jenkins-bot: [V: 04-1] Split CategorySelector widget to it's own module [core] - 10https://gerrit.wikimedia.org/r/243701 (https://phabricator.wikimedia.org/T108733) (owner: 10Florianschmidtwelzow) [18:45:49] (03CR) 10Anomie: Allow change tags to be added via API action=delete (032 comments) [core] - 10https://gerrit.wikimedia.org/r/230526 (https://phabricator.wikimedia.org/T108654) (owner: 10TTO) [18:46:05] (03CR) 10Ori.livneh: [C: 032] Tiny optimization to ResourceLoader::isValidModuleName() [core] (wmf/1.27.0-wmf.1) - 10https://gerrit.wikimedia.org/r/243718 (owner: 10Ori.livneh) [18:46:10] (03PS1) 10Paladox: Split module mediawiki.skinning.interface into three different modules [core] - 10https://gerrit.wikimedia.org/r/243719 [18:46:31] (03CR) 10Ori.livneh: [V: 032] Tiny optimization to ResourceLoader::isValidModuleName() [core] (wmf/1.27.0-wmf.1) - 10https://gerrit.wikimedia.org/r/243718 (owner: 10Ori.livneh) [18:46:38] (03PS2) 10Paladox: Split module mediawiki.skinning.interface into three different modules [core] - 10https://gerrit.wikimedia.org/r/243719 (https://phabricator.wikimedia.org/T114695) [18:47:17] 3Mobile-App-Android-Sprint-67-Holmium, 3Wikipedia-Android-App: Add button to navigate to geo-location of the article. - https://phabricator.wikimedia.org/T114523#1703230 (10Dbrant) [18:47:28] 6Education-Collab: Decide how our Facebook group should be managed - https://phabricator.wikimedia.org/T111966#1703231 (10FloorKoudijs) Thanks for creating that poll, @esh77. I'm curious to see what people will say. I would want to make sure we are mindful of our admin's time. So if the decision will be that we... [18:47:33] 3Mobile-App-Android-Sprint-67-Holmium, 3Wikipedia-Android-App: Add button to play recorded audio pronunciation of the article. - https://phabricator.wikimedia.org/T114524#1703232 (10Dbrant) [18:48:21] 6Education-Collab: Get all Collab members onto Phabricator and subscribed to the Education-Collab project - https://phabricator.wikimedia.org/T114572#1703235 (10AKoval_WMF) [18:49:15] (03CR) 10Paladox: "Done here https://gerrit.wikimedia.org/r/#/c/243719/" [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/241471 (https://phabricator.wikimedia.org/T113860) (owner: 10Paladox) [18:49:41] 10MediaWiki-RfCs, 10Architecture, 7Service-Architecture: RFC: Clean frontend - backend separation; make all frontends API consumers - https://phabricator.wikimedia.org/T88301#1703237 (10Jhernandez) [18:49:51] (03CR) 10Esanders: [C: 031] "Blocked by dependency, but good to go" [extensions/Math] - 10https://gerrit.wikimedia.org/r/243684 (https://phabricator.wikimedia.org/T113172) (owner: 10Tchanders) [18:50:58] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Wikimedia-log-errors: [Bug] Frequent "request has exceeded memory limit" fatals in EntityUsageTable::extractProperty - https://phabricator.wikimedia.org/T114656#1703244 (10hoo) 5Open>3Resolved a:3hoo [18:51:00] 6Education-Collab: Creating a twitter account for Wikipedia Education Program - https://phabricator.wikimedia.org/T113951#1703249 (10FloorKoudijs) I prefer Wikipedia Education Program too. That way, we get a chance to highlight anything that we learn about Wikipedia Education Programs, also outside of the Collab... [18:51:07] 3Mobile-App-Android-Sprint-67-Holmium, 5Patch-For-Review, 3Wikipedia-Android-App, 7WorkType-Maintenance: Link preview is horizontally truncated on rotation from landscape to portrait - https://phabricator.wikimedia.org/T109879#1703251 (10Etonkovidova) Checked with 2.0.131-alpha-2015-10-05 on Samsung Tablet... [18:51:26] 10MediaWiki-extensions-DismissableSiteNotice, 6Performance-Team, 7Regression: [1.26-wmf17 Regression] Dismissed site notice flashes briefly on page load - https://phabricator.wikimedia.org/T108513#1703255 (10Aklapper) >>! In T108513#1702245, @Taketa wrote: > The sitenotice on nlwiki is now only being display... [18:52:01] (03CR) 10Esanders: [C: 04-1] "Needs a rebase after more tabs were added to the inspector" [extensions/Score] - 10https://gerrit.wikimedia.org/r/243601 (https://phabricator.wikimedia.org/T113172) (owner: 10Tchanders) [18:53:57] 10MediaWiki-extensions-DismissableSiteNotice: nl.wikipedia.org sitenotice not displaying - https://phabricator.wikimedia.org/T114652#1703258 (10Taketa) @Aklapper, I cleared my browser cache. I cannot see it on chrome. On nl.wikipedia Ymnes says they can see the sitenotice using Windows with Explorer, Safari, Chr... [18:56:51] (03PS4) 10Florianschmidtwelzow: Split CategorySelector widget to it's own module [core] - 10https://gerrit.wikimedia.org/r/243701 (https://phabricator.wikimedia.org/T108733) [18:57:10] (03CR) 10Gergő Tisza: "> I suppose my worry there is that any changes to the processor then have to happen to all possible schema's at the same time." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/240614 (https://phabricator.wikimedia.org/T108618) (owner: 10EBernhardson) [18:57:37] (03PS1) 10Mholloway: Rename nav menu "More" item to "Settings" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/243720 (https://phabricator.wikimedia.org/T108532) [18:57:47] (03CR) 10Daniel Friesen: Split module mediawiki.skinning.interface into three different modules (031 comment) [core] - 10https://gerrit.wikimedia.org/r/243719 (https://phabricator.wikimedia.org/T114695) (owner: 10Paladox) [18:58:15] (03CR) 10Florianschmidtwelzow: [C: 04-1] Split module mediawiki.skinning.interface into three different modules (031 comment) [core] - 10https://gerrit.wikimedia.org/r/243719 (https://phabricator.wikimedia.org/T114695) (owner: 10Paladox) [18:59:36] (03CR) 10Paladox: Split module mediawiki.skinning.interface into three different modules (031 comment) [core] - 10https://gerrit.wikimedia.org/r/243719 (https://phabricator.wikimedia.org/T114695) (owner: 10Paladox) [18:59:38] (03Abandoned) 10Mholloway: Rename nav menu "More" item to "Settings" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/243238 (https://phabricator.wikimedia.org/T108532) (owner: 10Mholloway) [18:59:50] (03CR) 10Florianschmidtwelzow: Split module mediawiki.skinning.interface into three different modules (031 comment) [core] - 10https://gerrit.wikimedia.org/r/243719 (https://phabricator.wikimedia.org/T114695) (owner: 10Paladox) [19:00:29] (03PS1) 10EBernhardson: test patch do not merge [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/243721 [19:00:37] (03CR) 10Florianschmidtwelzow: Split module mediawiki.skinning.interface into three different modules (031 comment) [core] - 10https://gerrit.wikimedia.org/r/243719 (https://phabricator.wikimedia.org/T114695) (owner: 10Paladox) [19:00:47] 10MediaWiki-extensions-RelatedArticles, 10Reading-Community-Engagement, 3Mobile-Web-Design, 3Reading-Web-Sprint-57-The Fifth Element: Implement first version of read more - https://phabricator.wikimedia.org/T113635#1703271 (10phuedx) a:3phuedx [19:00:49] (03Abandoned) 10EBernhardson: test patch do not merge [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/243721 (owner: 10EBernhardson) [19:01:43] 10MediaWiki-extensions-DismissableSiteNotice, 6Performance-Team, 7Regression: [1.26-wmf17 Regression] Dismissed site notice flashes briefly on page load - https://phabricator.wikimedia.org/T108513#1703272 (10Taketa) >>! In T108513#1703255, @Aklapper wrote: >>>! In T108513#1702245, @Taketa wrote: >> The siten... [19:02:26] (03CR) 10Gergő Tisza: [C: 04-1] "The double call to the split hook still irks me." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/242791 (https://phabricator.wikimedia.org/T12453) (owner: 10Gergő Tisza) [19:02:35] 10MediaWiki-RfCs, 10Continuous-Integration-Infrastructure, 5Patch-For-Review: [RFC] Optional Travis integration for Jenkins - https://phabricator.wikimedia.org/T114421#1703273 (10cscott) It is indeed "pretty easy to solve" -- I just run `npm run travis` locally before I C+2 any patch. And other projects jus... [19:03:34] (03CR) 10Paladox: Split module mediawiki.skinning.interface into three different modules (031 comment) [core] - 10https://gerrit.wikimedia.org/r/243719 (https://phabricator.wikimedia.org/T114695) (owner: 10Paladox) [19:06:54] (03PS3) 10Paladox: Split module mediawiki.skinning.interface into three different modules [core] - 10https://gerrit.wikimedia.org/r/243719 (https://phabricator.wikimedia.org/T114695) [19:07:55] (03PS5) 10Jforrester: mw.widgets: Split CategorySelector widget to its own module [core] - 10https://gerrit.wikimedia.org/r/243701 (https://phabricator.wikimedia.org/T108733) (owner: 10Florianschmidtwelzow) [19:08:06] (03CR) 10Jforrester: [C: 032] mw.widgets: Split CategorySelector widget to its own module [core] - 10https://gerrit.wikimedia.org/r/243701 (https://phabricator.wikimedia.org/T108733) (owner: 10Florianschmidtwelzow) [19:09:17] 10MediaWiki-RfCs, 10Continuous-Integration-Infrastructure, 5Patch-For-Review: [RFC] Optional Travis integration for Jenkins - https://phabricator.wikimedia.org/T114421#1703276 (10greg) >>! In T114421#1703273, @cscott wrote: > It is indeed "pretty easy to solve" -- I just run `npm run travis` locally before I... [19:10:37] 10MediaWiki-Parser: Wrong squashing of blank lines when category link is "removed" from wikitext - https://phabricator.wikimedia.org/T114603#1703280 (10Lahwaacz) Related, but not the same. Category/language links are not handled equivalently to comments w.r.t. whitespace squashing. Consider the first snippet abo... [19:11:04] (03CR) 10Paladox: Split module mediawiki.skinning.interface into three different modules (031 comment) [core] - 10https://gerrit.wikimedia.org/r/243719 (https://phabricator.wikimedia.org/T114695) (owner: 10Paladox) [19:11:25] 10MediaWiki-RfCs, 10Continuous-Integration-Infrastructure, 5Patch-For-Review: [RFC] Optional Travis integration for Jenkins - https://phabricator.wikimedia.org/T114421#1703284 (10greg) So, summary: For this RFC to go forward, as any RFC, there should be a breakdown of costs/benefits by the proposer. [19:15:32] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: [Bug] wbc_entity_usage table gets new rows with ancient eu_touched date - https://phabricator.wikimedia.org/T114697#1703289 (10daniel) 3NEW a:3Jonas [19:17:29] (03Merged) 10jenkins-bot: mw.widgets: Split CategorySelector widget to its own module [core] - 10https://gerrit.wikimedia.org/r/243701 (https://phabricator.wikimedia.org/T108733) (owner: 10Florianschmidtwelzow) [19:18:35] (03CR) 10Daniel Friesen: [C: 04-1] "Personally I feel like this is whole idea an ugly hack. But to try and make it at least look less like we're just throwing a hack into cor" [core] - 10https://gerrit.wikimedia.org/r/243719 (https://phabricator.wikimedia.org/T114695) (owner: 10Paladox) [19:18:40] 10MediaWiki-RfCs, 10Continuous-Integration-Infrastructure, 5Patch-For-Review: [RFC] Optional Travis integration for Jenkins - https://phabricator.wikimedia.org/T114421#1703298 (10cscott) FWIW, a "travis bot" like the existing `jenkins-bot` could also be run as an unsupported service on labs. My assumption i... [19:21:15] 3Wikipedia-Android-App: [Regression 2.0.131-alpha-2015-10-05] Image Gallery displays frequent 'Could not draw the image' warnings - https://phabricator.wikimedia.org/T114698#1703299 (10Etonkovidova) 3NEW [19:22:03] 3Mobile-App-Android-Sprint-67-Holmium, 5Patch-For-Review, 3Wikipedia-Android-App, 7WorkType-Maintenance: Link preview overflow menu should include "open in new tab" - https://phabricator.wikimedia.org/T111862#1703307 (10Etonkovidova) Checked with 2.0.131-alpha-2015-10-05 on Samsung Tablet Ce0168(Android 4.... [19:23:35] 10Education-Program-Dashboard, 10Possible-Tech-Projects: Make the Education program dashboard usable for all languages and projects - https://phabricator.wikimedia.org/T91676#1703309 (10Shrutika719) I request the mentors to kindly give a list of the sub-tasks involved in this project so that we can get a clear... [19:24:39] 10Reading-Community-Engagement: Create 90s instructional video strategy process - https://phabricator.wikimedia.org/T113604#1670716 (10Moushira) [19:24:59] 3Wikipedia-Android-App: [Regression 2.0.131-alpha-2015-10-05] Image Gallery displays frequent 'Could not draw the image' warnings - https://phabricator.wikimedia.org/T114698#1703316 (10Dbrant) [19:25:50] 10Reading-Community-Engagement: Test different ways of soliciting feedback - https://phabricator.wikimedia.org/T113609#1670775 (10Moushira) [19:27:15] (03CR) 10Aaron Schulz: Enforce stricter slave lag limits for bot API requests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/243089 (https://phabricator.wikimedia.org/T95501) (owner: 10Aaron Schulz) [19:27:16] 10MediaWiki-extensions-UniversalLanguageSelector, 6WMF-Design, 7Easy, 5Patch-For-Review: Polish : Language tools disable input tools button should have some margin below, and other cleanups - https://phabricator.wikimedia.org/T1169#1703322 (10Nemo_bis) [19:29:10] 10MediaWiki-extensions-RelatedArticles, 10Reading-Community-Engagement, 3Mobile-Web-Design, 3Reading-Web-Sprint-57-The Fifth Element: Implement "Cards" extension for generating uniform cards - https://phabricator.wikimedia.org/T114393#1703326 (10Moushira) When is this likely to be implemented? I would lik... [19:32:57] 10Wikimedia-Site-Requests: Activate Extension:WikidataPageBanner in all namespaces in Russian Wikivoyage - https://phabricator.wikimedia.org/T114566#1703329 (10Jdlrobson) [19:33:41] 10Wikimedia-Site-Requests: Activate Extension:WikidataPageBanner in all namespaces in Russian Wikivoyage - https://phabricator.wikimedia.org/T114566#1703331 (10Atsirlin) @Jdlrobson: yep! [19:33:43] 10MediaWiki-extensions-GuidedTour, 7Technical-Debt: GuidedTour: Remove use of sync XHR - use mw.Api and async for parsing - https://phabricator.wikimedia.org/T46925#1703332 (10Krinkle) [19:34:52] (03PS2) 10Krinkle: resourceloader: Tiny optimization to ResourceLoader::isValidModuleName() [core] - 10https://gerrit.wikimedia.org/r/243717 (owner: 10Ori.livneh) [19:34:58] (03CR) 10Krinkle: [C: 032] resourceloader: Tiny optimization to ResourceLoader::isValidModuleName() [core] - 10https://gerrit.wikimedia.org/r/243717 (owner: 10Ori.livneh) [19:35:19] (03PS2) 10Krinkle: Remove mismatched COMMIT from FileDeleteForm [core] - 10https://gerrit.wikimedia.org/r/243361 (owner: 10Aaron Schulz) [19:36:01] 6Editing-Analysis: Create an editing data request process - https://phabricator.wikimedia.org/T114699#1703339 (10Neil_P._Quinn_WMF) 3NEW a:3Neil_P._Quinn_WMF [19:36:14] AaronSchulz: Regarding https://gerrit.wikimedia.org/r/#/c/243361 - so the problem is that the query may have failed before it started, so it would be committing when there was no transaction yet? [19:36:39] e.g. logic inside delete() ? [19:38:13] 10UI-Standardization, 10OOjs-UI: ToggleSwitchWidget shouldn't be solid blue - https://phabricator.wikimedia.org/T113225#1703350 (10violetto) @matmarex, your implementation was right. Under "mock up history," it tells you which is the current revision. {F2660471} We made the decision here T88973 started by @... [19:38:41] 10Wikimedia-Site-Requests, 5Patch-For-Review: Activate Extension:WikidataPageBanner in all namespaces in Russian Wikivoyage - https://phabricator.wikimedia.org/T114566#1703352 (10Jdlrobson) Thanks for the speedy reply :) Scheduled for 4pm PST https://wikitech.wikimedia.org/w/index.php?title=Deployments&type=re... [19:39:02] (03CR) 10Krinkle: [C: 04-1] Remove ?maxlag check in index.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/243471 (owner: 10Aaron Schulz) [19:39:05] 10Phlogiston: Chart or query to answer "recent work has been in which categories?" - https://phabricator.wikimedia.org/T113424#1703353 (10JAufrecht) 5Open>3Resolved [19:40:33] 10MediaWiki-RfCs, 10Continuous-Integration-Infrastructure, 5Patch-For-Review: [RFC] Optional Travis integration for Jenkins - https://phabricator.wikimedia.org/T114421#1703355 (10cscott) >>! In T114421#1703284, @greg wrote: > So, summary: For this RFC to go forward, as any RFC, there should be a breakdown of... [19:41:31] 10MediaWiki-extensions-GeoCrumbs, 10Reading-Community-Engagement: Should be possible to print breadcrumbs above the heading - https://phabricator.wikimedia.org/T113642#1703359 (10Jdlrobson) [19:41:51] 10MediaWiki-General-or-Unknown, 10OOjs-UI, 5MW-1.27-release-notes, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): TitleInputWidget description no longer styled correctly - https://phabricator.wikimedia.org/T114565#1703362 (10Jdforrester-WMF) [19:41:54] (03CR) 10Krinkle: Added BagOStuff::getWithSetCallback() convenience method (031 comment) [core] - 10https://gerrit.wikimedia.org/r/243428 (owner: 10Aaron Schulz) [19:42:13] 10MediaWiki-extensions-GeoCrumbs, 10Reading-Community-Engagement: Should be possible to print breadcrumbs above the heading - https://phabricator.wikimedia.org/T113642#1672008 (10Jdlrobson) There's a JS hack now in place. Would be good to work out a way forward for this. @moushira can you help work out what th... [19:42:14] 10MediaWiki-Debug-Logger: Monolog added "ip" is REMOTE_ADDR and does not honor XFF headers - https://phabricator.wikimedia.org/T114700#1703366 (10bd808) 3NEW [19:42:42] (03CR) 10Krinkle: [C: 032] Make generalizeSQL() protected [core] - 10https://gerrit.wikimedia.org/r/243492 (owner: 10Aaron Schulz) [19:42:59] 10UI-Standardization, 10OOjs-UI: ToggleSwitchWidget shouldn't be solid blue - https://phabricator.wikimedia.org/T113225#1703375 (10violetto) A note about color, we've iterated the color in task T109915 to #165C91. Perhaps you can feel better that this color is less bright. [19:44:30] (03Merged) 10jenkins-bot: resourceloader: Tiny optimization to ResourceLoader::isValidModuleName() [core] - 10https://gerrit.wikimedia.org/r/243717 (owner: 10Ori.livneh) [19:44:33] 10MediaWiki-extensions-GuidedTour, 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): GuidedTour referencing a VE-MW renamed class - viewPageTarget - https://phabricator.wikimedia.org/T111842#1703377 (10Jdforrester-WMF) p:5Triage>3Normal [19:44:52] (03PS4) 10Paladox: Split module mediawiki.skinning.interface into three different modules [core] - 10https://gerrit.wikimedia.org/r/243719 (https://phabricator.wikimedia.org/T114695) [19:45:21] (03CR) 10Paladox: "Ok done. and thanks for helping to clarify what the name should be like." [core] - 10https://gerrit.wikimedia.org/r/243719 (https://phabricator.wikimedia.org/T114695) (owner: 10Paladox) [19:47:23] (03PS2) 10Krinkle: Database debug log cleanup (remove wgDebugDumpSqlLength/wgDebugDBTransactions) [core] - 10https://gerrit.wikimedia.org/r/243526 (owner: 10Aaron Schulz) [19:47:34] (03CR) 10Krinkle: "Added to release notes when they were deprecated." [core] - 10https://gerrit.wikimedia.org/r/243526 (owner: 10Aaron Schulz) [19:47:41] (03CR) 10Krinkle: [C: 032] Database debug log cleanup (remove wgDebugDumpSqlLength/wgDebugDBTransactions) [core] - 10https://gerrit.wikimedia.org/r/243526 (owner: 10Aaron Schulz) [19:48:12] (03CR) 10Krinkle: [C: 031] Start rename of DatabaseBase => Database [core] - 10https://gerrit.wikimedia.org/r/243528 (owner: 10Aaron Schulz) [19:49:12] (03PS1) 10Jforrester: Update extensions/VisualEditor to wmf/1.27.0-wmf.1 HEAD [core] (wmf/1.27.0-wmf.1) - 10https://gerrit.wikimedia.org/r/243729 [19:49:39] (03PS5) 10Paladox: Split module mediawiki.skinning.interface into three different modules [core] - 10https://gerrit.wikimedia.org/r/243719 (https://phabricator.wikimedia.org/T114695) [19:49:41] (03CR) 10Krinkle: [C: 032] Update various @params from DatabaseBase to IDatabase [core] - 10https://gerrit.wikimedia.org/r/243488 (owner: 10Aaron Schulz) [19:50:41] (03CR) 10Krinkle: [C: 032] Remove unused checkExecutePermissions() return value [extensions/ListSignup] - 10https://gerrit.wikimedia.org/r/243591 (owner: 10Aaron Schulz) [19:51:54] (03PS1) 10Krinkle: Remove unused checkExecutePermissions() return value [core] - 10https://gerrit.wikimedia.org/r/243731 [19:52:31] (03CR) 10Krinkle: [C: 04-1] Don't output type= attributes on link and script tags [core] - 10https://gerrit.wikimedia.org/r/230278 (owner: 10Ori.livneh) [19:53:00] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 5Patch-For-Review: Implement recurring logic in Amazon gateway adapter - https://phabricator.wikimedia.org/T111430#1703391 (10awight) The patches look good so far! *ahemming* a bit about sprintliness, though... [19:53:06] (03Merged) 10jenkins-bot: Make generalizeSQL() protected [core] - 10https://gerrit.wikimedia.org/r/243492 (owner: 10Aaron Schulz) [19:55:20] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 5Patch-For-Review: Implement recurring logic in Amazon gateway adapter - https://phabricator.wikimedia.org/T111430#1703401 (10atgo) @ejegg we had this task already to deal with this (currently "unscheduled") we should decide if this is a priori... [19:56:02] (03CR) 10BryanDavis: "Added comments inline about possible mappings of context additions to Analytics schema conventions." (039 comments) [core] - 10https://gerrit.wikimedia.org/r/240614 (https://phabricator.wikimedia.org/T108618) (owner: 10EBernhardson) [19:56:15] (03CR) 10Krinkle: Lower CDN cache TTL when slave lag is high (031 comment) [core] - 10https://gerrit.wikimedia.org/r/242812 (https://phabricator.wikimedia.org/T113204) (owner: 10Aaron Schulz) [19:56:26] 6Editing-Analysis: What is the total number of users to make an edit as of Sept 15 - https://phabricator.wikimedia.org/T113808#1703404 (10jrbs) [19:56:29] 6WMF-Communications, 10Wikimedia-Blog-Content: Write blogpost for 5,000,000 enwp articles - https://phabricator.wikimedia.org/T113799#1703403 (10jrbs) [19:57:19] (03CR) 10BearND: [C: 032] Add link(s) to spoken version of article, if available [services/mobileapps] - 10https://gerrit.wikimedia.org/r/241756 (https://phabricator.wikimedia.org/T108372) (owner: 10Mholloway) [19:57:48] (03Merged) 10jenkins-bot: Database debug log cleanup (remove wgDebugDumpSqlLength/wgDebugDBTransactions) [core] - 10https://gerrit.wikimedia.org/r/243526 (owner: 10Aaron Schulz) [19:58:05] 10Beta-Cluster-Infrastructure, 10MobileFrontend, 7Easy, 7Mobile, 5Patch-For-Review: Beta Cluster login (desktop and mobile) should have a warning that it is not a Wikimedia site - https://phabricator.wikimedia.org/T114552#1703410 (10Jdlrobson) Message changes made. I've not tested above patch at all but... [19:58:23] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-blocking, 6Community-Advocacy, 6Community-Tech, 5Patch-For-Review: Send a cookie with each block? - https://phabricator.wikimedia.org/T5233#1703418 (10Slowking4) is it in compliance with EU Cookie Law? https://econsultancy.com/blog/63118-17-u... [19:59:10] 10Beta-Cluster-Infrastructure, 10MobileFrontend, 7Easy, 7Mobile, 5Patch-For-Review: Beta Cluster login (desktop and mobile) should have a warning that it is not a Wikimedia site - https://phabricator.wikimedia.org/T114552#1703421 (10Jdlrobson) To set expectations I haven't got time to do anything more th... [19:59:23] (03Merged) 10jenkins-bot: Update various @params from DatabaseBase to IDatabase [core] - 10https://gerrit.wikimedia.org/r/243488 (owner: 10Aaron Schulz) [19:59:27] (03Merged) 10jenkins-bot: Remove unused checkExecutePermissions() return value [extensions/ListSignup] - 10https://gerrit.wikimedia.org/r/243591 (owner: 10Aaron Schulz) [19:59:29] (03Merged) 10jenkins-bot: Add link(s) to spoken version of article, if available [services/mobileapps] - 10https://gerrit.wikimedia.org/r/241756 (https://phabricator.wikimedia.org/T108372) (owner: 10Mholloway) [19:59:39] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 5Patch-For-Review: Implement recurring logic in Amazon gateway adapter - https://phabricator.wikimedia.org/T111430#1703423 (10Ejegg) Yeah, I cheated a bit here. I needed to figure out what I could assume about recurring donation gateway IDs in... [20:00:07] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 5Patch-For-Review: Implement recurring logic in Amazon gateway adapter - https://phabricator.wikimedia.org/T111430#1703428 (10awight) Makes sense! Thanks for the lookahead algorithm :) [20:00:09] 10MobileFrontend, 3Reading-Web-Sprint-57-The Fifth Element: Missing watchlist stars, search suggestions and more on English Wikipedia mobile site - https://phabricator.wikimedia.org/T114599#1700274 (10Jdlrobson) Possibly related to T114622 ? [20:00:49] (03CR) 10Krinkle: "Haven't tested yet but would be easier with a unit test. Looks good at first sight. This is gonna help a lot!" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/243426 (owner: 10Aaron Schulz) [20:02:02] (03CR) 10Daniel Friesen: [C: 04-1] Split module mediawiki.skinning.interface into three different modules (031 comment) [core] - 10https://gerrit.wikimedia.org/r/243719 (https://phabricator.wikimedia.org/T114695) (owner: 10Paladox) [20:04:45] 10Wikimedia-General-or-Unknown, 7JavaScript: de.wikipedia.org script calls isAnon() without loading mediawiki.user (mediawiki.ui.anchor load-callback) - https://phabricator.wikimedia.org/T113575#1703434 (10Jdlrobson) I can replicate a similar bug when Zero is enabled.. T114128 [20:04:58] 10UI-Standardization, 10OOjs-UI: ToggleSwitchWidget shouldn't be solid blue - https://phabricator.wikimedia.org/T113225#1703436 (10Volker_E) @matmarex In a side-note: It's great, that you're working on it on the weekend, but please give us, @violetto and myself time on Monday to respond to you before merging w... [20:06:03] 6Zero, 5Patch-For-Review, 3Reading-Web-Sprint-57-The Fifth Element, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): [Zero] Banner broken occasionally on article link tap - https://phabricator.wikimedia.org/T114128#1685361 (10Jdlrobson) @yurik can you confirm you will be lightning deploying this today? I don't see a... [20:08:48] 6Developer-Relations, 3Outreachy-Round-11: Clean up Mentorship wiki pages now we're running these on Phabricator - https://phabricator.wikimedia.org/T114704#1703460 (10Spage) 3NEW [20:08:55] (03PS6) 10Anomie: WIP: Add SessionManager [core] - 10https://gerrit.wikimedia.org/r/243223 [20:09:06] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add SessionManager [core] - 10https://gerrit.wikimedia.org/r/243223 (owner: 10Anomie) [20:10:26] (03CR) 10Krinkle: [C: 032] Fix DatabaseMysqlBase.php IDEA errors [core] - 10https://gerrit.wikimedia.org/r/243477 (owner: 10Aaron Schulz) [20:10:49] 10UI-Standardization, 10OOjs-UI: ToggleSwitchWidget shouldn't be solid blue - https://phabricator.wikimedia.org/T113225#1703467 (10Volker_E) @Esanders The most recent mockup with inputs by @TheDJ includes solid color on active (switched on) widgets (ToggleSwitch, Radio, Checkbox...) to help users. This one was... [20:11:16] (03PS7) 10Anomie: WIP: Add SessionManager [core] - 10https://gerrit.wikimedia.org/r/243223 [20:12:11] (03PS4) 10Mattflaschen: Add composer.json [extensions/Echo] - 10https://gerrit.wikimedia.org/r/243678 (owner: 10Paladox) [20:12:51] ebernhardson: since you were mostly being nice by starting that api logging patch, would you like me to take it over for the bikeshed changes that are being suggested? [20:14:12] 10UI-Standardization, 10OOjs-UI: ToggleSwitchWidget shouldn't be solid blue - https://phabricator.wikimedia.org/T113225#1703471 (10matmarex) Both @violetto and @esanders agreed that the blue mockup for toggle, which I pointed out as correct, was the wrong one, and that seemed reasonable single the blue mockup... [20:14:26] 10UI-Standardization: [Goal] Standardize MediaWiki components - https://phabricator.wikimedia.org/T113560#1703473 (10matmarex) [20:14:29] 10UI-Standardization, 10OOjs-UI: ToggleSwitchWidget shouldn't be solid blue - https://phabricator.wikimedia.org/T113225#1703472 (10matmarex) 5Resolved>3Open [20:14:40] 6Education-Collab: Creating a twitter account for Wikipedia Education Program - https://phabricator.wikimedia.org/T113951#1703474 (10SaraMortsell) Thanks for your input guys! I've now set up an account, and had to shorten the name, does it work in English? WikiEduProgram? https://twitter.com/WikiEduProgram I... [20:15:02] 10UI-Standardization, 10OOjs-UI: ToggleSwitchWidget shouldn't be solid blue - https://phabricator.wikimedia.org/T113225#1657826 (10matmarex) …okay, I guess we're going all blue. Whatever. Nice to know! [20:16:50] 10MediaWiki-Special-pages, 10UI-Standardization: Make Special:ListFiles follow OOjs UI - https://phabricator.wikimedia.org/T113436#1703481 (10matmarex) I am increasingly concerned about continuously increasing the scope of the project without ever completing any part of it. [20:17:54] 10MobileFrontend, 3Reading-Web-Sprint-57-The Fifth Element: Missing watchlist stars, search suggestions and more on English Wikipedia mobile site - https://phabricator.wikimedia.org/T114599#1703487 (10Jdlrobson) I am still unable to replicate this :( :(. If anyone is tech savvy could they debug this and see if... [20:18:14] 10MediaWiki-extensions-GeoData, 7Testme: Duplicate primary tags - https://phabricator.wikimedia.org/T55539#1703488 (10MaxSem) ``` MariaDB [enwiki_p]> select count(*) num, page_id from page, geo_tags where gt_page_id=page_id and gt_primary=1 having num>1 order by num desc; +--------+---------+ | num | page_i... [20:20:20] (03Merged) 10jenkins-bot: Fix DatabaseMysqlBase.php IDEA errors [core] - 10https://gerrit.wikimedia.org/r/243477 (owner: 10Aaron Schulz) [20:22:50] 10UI-Standardization, 10OOjs-UI: ToggleSwitchWidget shouldn't be solid blue - https://phabricator.wikimedia.org/T113225#1703496 (10violetto) If anyone is confused about what version they might be looking at, you can see under "Mock history," the current one will be labelled as "Current revision" (pictured belo... [20:25:12] 6Developer-Relations, 3DevRel-December-2015, 3DevRel-November-2015, 3DevRel-October-2015, 3Outreachy-Round-11: Goal: Organize the start of Outreachy round 11 - https://phabricator.wikimedia.org/T112267#1703502 (10Spage) I may be a mentor for proposal(s) for T91626, and especially if this round won't have... [20:26:46] 6Education-Collab: Routine for managing the twitter account - https://phabricator.wikimedia.org/T114706#1703509 (10SaraMortsell) 3NEW a:3SaraMortsell [20:26:51] (03PS6) 10Paladox: Split module mediawiki.skinning.interface into three different modules [core] - 10https://gerrit.wikimedia.org/r/243719 (https://phabricator.wikimedia.org/T114695) [20:27:53] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 5Patch-For-Review: Implement recurring logic in Amazon gateway adapter - https://phabricator.wikimedia.org/T111430#1703520 (10Ejegg) [20:27:56] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 5Patch-For-Review: Implement Amazon recurring widget client-side - https://phabricator.wikimedia.org/T111428#1703521 (10Ejegg) [20:29:22] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 10Unplanned-Sprint-Work, 3Fundraising Sprint UB40, 5Patch-For-Review: Implement Amazon recurring widget client-side - https://phabricator.wikimedia.org/T111428#1603672 (10Ejegg) [20:29:55] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 10Unplanned-Sprint-Work, 3Fundraising Sprint UB40, 5Patch-For-Review: Implement recurring logic in Amazon gateway adapter - https://phabricator.wikimedia.org/T111430#1703539 (10Ejegg) [20:30:06] 10MobileFrontend, 3Reading-Web-Sprint-57-The Fifth Element: Missing watchlist stars, search suggestions and more on English Wikipedia mobile site - https://phabricator.wikimedia.org/T114599#1703545 (10Jdlrobson) [20:30:17] 10MobileFrontend, 3Reading-Web-Sprint-57-The Fifth Element: Investigate reports of broken section toggling - https://phabricator.wikimedia.org/T114622#1703546 (10Jdlrobson) [20:30:18] 10MobileFrontend, 3Reading-Web-Sprint-57-The Fifth Element: Missing watchlist stars, search suggestions and more on English Wikipedia mobile site - https://phabricator.wikimedia.org/T114599#1700274 (10Jdlrobson) [20:31:01] SqlBagOStuff on master is broken :S [20:35:08] 10MobileFrontend, 3Reading-Web-Sprint-57-The Fifth Element: Missing watchlist stars, search suggestions and more on English Wikipedia mobile site - https://phabricator.wikimedia.org/T114599#1703549 (10Jdlrobson) The only thing I can think of is this is caused by T99096. We recently pushed a fix for T113289 whi... [20:37:08] (03CR) 10Siebrand: [C: 032] Reenable LineLength phpcs check [core] - 10https://gerrit.wikimedia.org/r/241501 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [20:39:39] bd808: yea actually i was kinda thinking about that :) would appreciate it [20:41:08] 3Mobile-App-Android-Sprint-67-Holmium, 5Patch-For-Review, 3Wikipedia-Android-App, 7WorkType-Maintenance: Link preview overflow menu should include "open in new tab" - https://phabricator.wikimedia.org/T111862#1703558 (10Etonkovidova) Checked with 2.0.131-alpha-2015-10-05 on Samsung Tablet Ce0168(Android 4.... [20:42:10] 10Wikimedia-Developer-Summit-2016: Semantic image styles / beautiful layout - https://phabricator.wikimedia.org/T112991#1703560 (10violetto) [[ https://www.mediawiki.org/wiki/Wikimedia_User_Interface/Use_cases/Images | I collected some screenshots ]] with a more complete look on how our contributors are using im... [20:42:18] (03PS1) 10Yurik: Fix deprecation warnings [extensions/ZeroBanner] (wmf/1.27.0-wmf.1) - 10https://gerrit.wikimedia.org/r/243801 (https://phabricator.wikimedia.org/T114128) [20:42:21] (03CR) 10Mattflaschen: [C: 032] "Looks good! Fixing two old bugs and simplifying and shortening the code. :)" [core] - 10https://gerrit.wikimedia.org/r/243637 (https://phabricator.wikimedia.org/T49395) (owner: 10Bartosz Dziewoński) [20:43:14] (03PS1) 10Hoo man: Fix DatabaseSqlite::__toString [core] - 10https://gerrit.wikimedia.org/r/243802 [20:43:25] (03CR) 10Yurik: [C: 032] Fix deprecation warnings [extensions/ZeroBanner] (wmf/1.27.0-wmf.1) - 10https://gerrit.wikimedia.org/r/243801 (https://phabricator.wikimedia.org/T114128) (owner: 10Yurik) [20:43:36] AaronSchulz: Your change to SqlBagOStuff made it call DatabaseSqlite::__toString [20:43:43] Please merge the above change to fix that [20:46:09] 10MediaWiki-Extension-Requests, 6Editing-Department, 10Possible-Tech-Projects, 7Documentation: An extension to edit a DocBook documentation on MediaWiki - https://phabricator.wikimedia.org/T63047#1703576 (10Spage) As @Nemo_bis remarked, > I don't understand if you're trying to say this bug is also/mainly a... [20:46:33] (03CR) 10jenkins-bot: [V: 04-1] Reenable LineLength phpcs check [core] - 10https://gerrit.wikimedia.org/r/241501 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [20:46:49] 10MediaWiki-extensions-GeoData, 7Testme: Duplicate primary tags - https://phabricator.wikimedia.org/T55539#1703584 (10MaxSem) ``` select count(*) from(select count(*) num, page_id from page, geo_tags where gt_page_id=page_id and gt_primary=1 group by page_id having num>1 order by num desc) x; +----------+ | co... [20:47:30] 10MediaWiki-extensions-GeoData: Duplicate primary tags - https://phabricator.wikimedia.org/T55539#1703589 (10MaxSem) [20:49:04] (03CR) 10MaxSem: [C: 031] "Would +2 if the commit message explained what failed where." [core] - 10https://gerrit.wikimedia.org/r/243802 (owner: 10Hoo man) [20:49:10] hoo, ^^^ [20:49:49] MaxSem: Oh, sorry [20:50:01] Will make a ticket [20:51:32] (03Merged) 10jenkins-bot: mediawiki.jqueryMsg: Refactor handling of replacements/parameters in links [core] - 10https://gerrit.wikimedia.org/r/243637 (https://phabricator.wikimedia.org/T49395) (owner: 10Bartosz Dziewoński) [20:51:35] (03Merged) 10jenkins-bot: Fix deprecation warnings [extensions/ZeroBanner] (wmf/1.27.0-wmf.1) - 10https://gerrit.wikimedia.org/r/243801 (https://phabricator.wikimedia.org/T114128) (owner: 10Yurik) [20:51:48] 10MediaWiki-Database: SqlBagOStuff will cause a fatal if used with SQLite - https://phabricator.wikimedia.org/T114709#1703597 (10hoo) 3NEW [20:52:46] (03PS2) 10Hoo man: Fix DatabaseSqlite::__toString [core] - 10https://gerrit.wikimedia.org/r/243802 [20:54:12] (03PS3) 10MaxSem: Fix DatabaseSqlite::__toString [core] - 10https://gerrit.wikimedia.org/r/243802 (https://phabricator.wikimedia.org/T114709) (owner: 10Hoo man) [20:54:27] (03CR) 10MaxSem: [C: 032] "Thanks!" [core] - 10https://gerrit.wikimedia.org/r/243802 (https://phabricator.wikimedia.org/T114709) (owner: 10Hoo man) [20:54:48] 3Mobile-App-Android-Sprint-67-Holmium, 3Wikipedia-Android-App: Reduce usage of full-bleed dividers. - https://phabricator.wikimedia.org/T110686#1703613 (10Etonkovidova) Checked with 2.0.131-alpha-2015-10-05 on Nexus 5(Android 5.1.1) and Samsung Tablet Ce0168(Android 4.0.4). There is a little discrepancy betw... [20:55:05] 3Mobile-App-Android-Sprint-67-Holmium, 3Wikipedia-Android-App, 7WorkType-Maintenance: Resurrect the Session Funnel. - https://phabricator.wikimedia.org/T111541#1703615 (10Dbrant) [20:55:15] hoo, any ideas if other backends are affected? [20:55:29] jhobs, just deployed, please check [20:55:35] MySQL is fine AFAICT [20:55:41] despite of that, I don't know [20:56:36] yurik: looks good, thanks [20:56:37] 10MediaWiki-Internationalization, 10Wikimedia-Developer-Summit-2016, 7I18n: Move special page alias translations to JSON - https://phabricator.wikimedia.org/T89947#1703620 (10siebrand) [20:56:59] 10Wikimedia-Developer-Summit-2016: i18n and L10n best practices for developers - https://phabricator.wikimedia.org/T114708#1703621 (10siebrand) [20:57:19] jhobs, getting tons of errors, rollicking back [20:57:35] yurik: really? not seeing any in js console [20:57:37] hoo, only SQLite uses PDO, so we're seem to be fine for now. if it breaks something exotic - oh well:P [20:58:51] jhobs, check logstash [20:58:53] php errors [21:00:58] jhobs, Fatal error: Class undefined: ZeroBanner\ResourceLoader in /srv/mediawiki/php-1.27.0-wmf.1/extensions/ZeroBanner/includes/ZeroSpecialPage.php on line 519 [21:01:50] 6Revscoring: Train/deploy "damaging" and "goodfaith" models from data collected through (finished) "edit quality" campaigns - https://phabricator.wikimedia.org/T108679#1527147 (10Halfak) Deployed enwiki, ptwiki and fawiki models on 10/4. [21:02:26] ebernhardson: cool. I'll see if I can make some updates today/tomorrow and get Andrew and others to take another look. I appreciate you taking the first stab at it for sure. I love to see people thinking about logging :) [21:03:01] 3Reading-Web-Sprint-57-The Fifth Element: Demonstrate impact of loading just lead sections of a group of static pages - https://phabricator.wikimedia.org/T113649#1703639 (10Jdlrobson) So I want to run this for the following pages but have no idea how to use the script. @peter I see you set something up for Thurs... [21:03:42] (03Merged) 10jenkins-bot: Fix DatabaseSqlite::__toString [core] - 10https://gerrit.wikimedia.org/r/243802 (https://phabricator.wikimedia.org/T114709) (owner: 10Hoo man) [21:04:04] 10MediaWiki-General-or-Unknown, 10Analytics, 6Discovery, 10EventBus, and 6 others: EventBus MVP - https://phabricator.wikimedia.org/T114443#1703643 (10Nuria) >a way to expose a stream of events in a defined format that can be consumed easily by a range of clients. This talks about consumption, not producti... [21:04:08] 10MediaWiki-API, 6Analytics-Backlog, 6Research-and-Data, 5Patch-For-Review: log user agent in api.log - https://phabricator.wikimedia.org/T108618#1703644 (10bd808) a:3bd808 [21:04:57] 10MediaWiki-Database: SqlBagOStuff will cause a fatal if used with SQLite - https://phabricator.wikimedia.org/T114709#1703647 (10hoo) a:3hoo [21:05:01] 10MediaWiki-Database: SqlBagOStuff will cause a fatal if used with SQLite - https://phabricator.wikimedia.org/T114709#1703650 (10hoo) 5Open>3Resolved [21:07:19] (03PS1) 10Yurik: Fixed missing ns ref for ResourceLoader [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/243808 [21:07:43] (03CR) 10Yurik: [C: 032] Fixed missing ns ref for ResourceLoader [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/243808 (owner: 10Yurik) [21:07:59] jhobs, ^ [21:08:42] hoo: which change? [21:09:14] AaronSchulz: a88df43d3f068b75f4d50c3c599ad2ccaf589f94 [21:09:22] but all resolved now [21:09:41] ahh, didn't know that was merged yet [21:10:01] (03Merged) 10jenkins-bot: Fixed missing ns ref for ResourceLoader [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/243808 (owner: 10Yurik) [21:10:30] (03PS1) 10Yurik: Fixed missing ns ref for ResourceLoader [extensions/ZeroBanner] (wmf/1.27.0-wmf.1) - 10https://gerrit.wikimedia.org/r/243809 [21:10:35] hoo: still trying to see the connection [21:10:58] ahh I see [21:11:00] (03CR) 10Yurik: [C: 032] Fixed missing ns ref for ResourceLoader [extensions/ZeroBanner] (wmf/1.27.0-wmf.1) - 10https://gerrit.wikimedia.org/r/243809 (owner: 10Yurik) [21:11:13] the broken code from before was hit in general after that [21:11:18] (03PS1) 10Gilles: Upgrade Varnish role to Varnish 4 [vagrant] - 10https://gerrit.wikimedia.org/r/243810 (https://phabricator.wikimedia.org/T114702) [21:11:42] (03CR) 10jenkins-bot: [V: 04-1] Upgrade Varnish role to Varnish 4 [vagrant] - 10https://gerrit.wikimedia.org/r/243810 (https://phabricator.wikimedia.org/T114702) (owner: 10Gilles) [21:11:55] (03CR) 10Gilles: [C: 04-1] "Needs to be rebased on top of I48f4994ac74753fdfdece4c8a2245f8aef188f0b" [vagrant] - 10https://gerrit.wikimedia.org/r/238187 (https://phabricator.wikimedia.org/T111721) (owner: 10Gilles) [21:13:25] (03CR) 10Aaron Schulz: Added BagOStuff::getWithSetCallback() convenience method (031 comment) [core] - 10https://gerrit.wikimedia.org/r/243428 (owner: 10Aaron Schulz) [21:13:27] (03Merged) 10jenkins-bot: Fixed missing ns ref for ResourceLoader [extensions/ZeroBanner] (wmf/1.27.0-wmf.1) - 10https://gerrit.wikimedia.org/r/243809 (owner: 10Yurik) [21:13:41] (03PS2) 10Gilles: Upgrade Varnish role to Varnish 4 [vagrant] - 10https://gerrit.wikimedia.org/r/243810 (https://phabricator.wikimedia.org/T114702) [21:18:25] 3Wikipedia-Android-App: Crash: RuntimeException (Canvas: trying to use a recycled bitmap) in... somewhere. - https://phabricator.wikimedia.org/T114658#1703658 (10Mholloway) I just got this crash. I believe it happened as I was returning to the app from the Twitter app via the back button after (not) sharing an... [21:21:36] 6Community-Liaison: Create Design/Development Principles - https://phabricator.wikimedia.org/T114321#1703660 (10Rdicerb) a:3Keegan [21:21:57] 6Community-Liaison: Create Design/Development Principles - https://phabricator.wikimedia.org/T114321#1691405 (10Rdicerb) p:5Triage>3Normal [21:22:02] 10Phlogiston: Figure out why the edge refactor shrunk the VE Q4 tranche by 2/3rds without affecting the rest very much - https://phabricator.wikimedia.org/T114272#1703664 (10JAufrecht) 5Open>3Resolved [21:22:36] 3Wikipedia-Android-App: Crash: RuntimeException (Canvas: trying to use a recycled bitmap) in... somewhere. - https://phabricator.wikimedia.org/T114658#1703673 (10Mholloway) In fact, i'm able to reproduce it without fail that way. [21:24:15] (03PS11) 10Gilles: Enable far-future expires [vagrant] - 10https://gerrit.wikimedia.org/r/238187 (https://phabricator.wikimedia.org/T111721) [21:24:48] 10MediaWiki-extensions-ZeroBanner: Zerobanner #/zeroinfo/ route broken - https://phabricator.wikimedia.org/T114416#1703676 (10Jdlrobson) We should keep this task open. Removing it is a suitable fix for the raised problem. Go for it :) [21:26:03] (03PS2) 10Aaron Schulz: Lower CDN cache TTL when slave lag is high [core] - 10https://gerrit.wikimedia.org/r/242812 (https://phabricator.wikimedia.org/T113204) [21:26:11] (03PS12) 10Gilles: Enable far-future expires [vagrant] - 10https://gerrit.wikimedia.org/r/238187 (https://phabricator.wikimedia.org/T111721) [21:26:14] (03CR) 10jenkins-bot: [V: 04-1] Lower CDN cache TTL when slave lag is high [core] - 10https://gerrit.wikimedia.org/r/242812 (https://phabricator.wikimedia.org/T113204) (owner: 10Aaron Schulz) [21:26:57] 10Reading-Community-Engagement: Investigate if other Wikipedias would like to try the new Wikivoyage banner - https://phabricator.wikimedia.org/T113617#1703688 (10JKatzWMF) @moushira Thanks for the clarification (I did have it mixed up in my head--very bad timing given the recent election) [21:27:06] (03CR) 10Mattflaschen: [C: 032] "Needs more plaintive WHY?'s." [core] - 10https://gerrit.wikimedia.org/r/243641 (https://phabricator.wikimedia.org/T55576) (owner: 10Bartosz Dziewoński) [21:29:31] 10MediaWiki-Internationalization, 10Beta-Cluster-Infrastructure: Viewing beta's en_rtlwiki just throws a fatal exception - https://phabricator.wikimedia.org/T106125#1703692 (10Krenair) It seems to throw this exception when you try to use certain messages (perhaps only ones that contains {{SITENAME}}? that happ... [21:30:14] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: [Bug] Show more meaningful messages on the client wiki when a relevant sitelink is changed on the repo - https://phabricator.wikimedia.org/T114664#1703696 (10hoo) `SiteLinkCommentCreator` doesn't know about which page it is currently formatting a comment for,... [21:33:32] (03CR) 10Dduvall: [C: 04-1] Upgrade Varnish role to Varnish 4 (033 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/243810 (https://phabricator.wikimedia.org/T114702) (owner: 10Gilles) [21:34:29] (03CR) 10Krinkle: [C: 031] Make WANObjectCache sets account for slave lag [core] - 10https://gerrit.wikimedia.org/r/242783 (https://phabricator.wikimedia.org/T113204) (owner: 10Aaron Schulz) [21:34:42] (03CR) 10Aaron Schulz: Remove ?maxlag check in index.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/243471 (owner: 10Aaron Schulz) [21:36:48] (03CR) 10Gilles: Upgrade Varnish role to Varnish 4 (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/243810 (https://phabricator.wikimedia.org/T114702) (owner: 10Gilles) [21:36:50] (03Merged) 10jenkins-bot: mediawiki.jqueryMsg: Always parse messages with '&' [core] - 10https://gerrit.wikimedia.org/r/243641 (https://phabricator.wikimedia.org/T55576) (owner: 10Bartosz Dziewoński) [21:38:05] (03PS4) 10Gergő Tisza: Add UserMailerTransformX and UserMailerSplitTo hooks [core] - 10https://gerrit.wikimedia.org/r/242791 (https://phabricator.wikimedia.org/T12453) [21:39:55] (03PS1) 10Krinkle: Title: Fix @param for TS_MW to be string instead of int [core] - 10https://gerrit.wikimedia.org/r/243813 [21:40:12] (03CR) 10Krinkle: Avoid parser cache miss that often occurs post-save (031 comment) [core] - 10https://gerrit.wikimedia.org/r/216880 (owner: 10Aaron Schulz) [21:40:27] AaronSchulz: https://gerrit.wikimedia.org/r/#/c/216880/1/includes/Title.php cq. - https://gerrit.wikimedia.org/r/243813 [21:40:34] Both seem fine, but right now it seems wrong. [21:41:37] 10MediaWiki-Internationalization, 10Beta-Cluster-Infrastructure: Viewing beta's en_rtlwiki just throws a fatal exception - https://phabricator.wikimedia.org/T106125#1703735 (10Krenair) Given that numberofviews was removed in https://gerrit.wikimedia.org/r/#/c/150699/ I suspect that we're getting outdated data... [21:42:08] (03PS3) 10Aaron Schulz: Lower CDN cache TTL when slave lag is high [core] - 10https://gerrit.wikimedia.org/r/242812 (https://phabricator.wikimedia.org/T113204) [21:43:07] (03CR) 10Aaron Schulz: [C: 032] Title: Fix @param for TS_MW to be string instead of int [core] - 10https://gerrit.wikimedia.org/r/243813 (owner: 10Krinkle) [21:43:10] 10MediaWiki-General-or-Unknown: Undefined index: function in MWExceptionHandler.php on line 386 - https://phabricator.wikimedia.org/T114715#1703737 (10Yurik) 3NEW [21:45:29] (03PS3) 10Gilles: Upgrade Varnish role to Varnish 4 [vagrant] - 10https://gerrit.wikimedia.org/r/243810 (https://phabricator.wikimedia.org/T114702) [21:45:31] (03CR) 10Gergő Tisza: Structured api request logging (031 comment) [core] - 10https://gerrit.wikimedia.org/r/240614 (https://phabricator.wikimedia.org/T108618) (owner: 10EBernhardson) [21:45:34] (03CR) 10Gilles: Upgrade Varnish role to Varnish 4 (032 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/243810 (https://phabricator.wikimedia.org/T114702) (owner: 10Gilles) [21:45:51] (03CR) 10jenkins-bot: [V: 04-1] Upgrade Varnish role to Varnish 4 [vagrant] - 10https://gerrit.wikimedia.org/r/243810 (https://phabricator.wikimedia.org/T114702) (owner: 10Gilles) [21:46:21] (03CR) 10Dduvall: Upgrade Varnish role to Varnish 4 (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/243810 (https://phabricator.wikimedia.org/T114702) (owner: 10Gilles) [21:47:25] (03PS4) 10Gilles: Upgrade Varnish role to Varnish 4 [vagrant] - 10https://gerrit.wikimedia.org/r/243810 (https://phabricator.wikimedia.org/T114702) [21:50:23] (03PS1) 10Krinkle: Clean up in mobile.contentOverlays module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/243815 [21:50:48] bd808: https://gerrit.wikimedia.org/r/#/c/243529/ [21:51:22] 10MediaWiki-extensions-UrlShortener, 10Security-Reviews: Security review for UrlShortener extension - https://phabricator.wikimedia.org/T112950#1703754 (10dpatrick) a:3dpatrick [21:51:37] 10MediaWiki-extensions-UrlShortener, 10Security-Reviews, 6Security-Team: Security review for UrlShortener extension - https://phabricator.wikimedia.org/T112950#1650795 (10dpatrick) [21:52:55] (03Merged) 10jenkins-bot: Title: Fix @param for TS_MW to be string instead of int [core] - 10https://gerrit.wikimedia.org/r/243813 (owner: 10Krinkle) [21:54:34] 10MediaWiki-extensions-UrlShortener, 10Security-Reviews, 6Security-Team: Security review for UrlShortener extension - https://phabricator.wikimedia.org/T112950#1703763 (10dpatrick) I'm about to start on this review. Should I look at master, or some other branch? [21:55:09] 7Design, 10MediaWiki-extensions-ApiSandbox, 10UI-Standardization, 10Web-APIs-Hub, 5Patch-For-Review: Update ApiSandbox to MediaWiki appearance using OOjs UI - https://phabricator.wikimedia.org/T92893#1703766 (10Volker_E) [21:55:21] 10MediaWiki-API, 6Analytics-Backlog, 6Research-and-Data, 5Patch-For-Review: log user agent in api.log - https://phabricator.wikimedia.org/T108618#1703767 (10GWicke) Several services including RESTBase and Parsoid already set and forward a v1 uuid in the `X-Request-Id` header. This header is also set in sub... [21:57:00] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: [Bug] Show more meaningful messages on the client wiki when a relevant sitelink is changed on the repo - https://phabricator.wikimedia.org/T114664#1703768 (10daniel) @hoo or we could just not call SiteLinkCommentCreator if the affected page isn't the connected... [21:58:16] (03CR) 10Krinkle: Improved personal toolbar for logged-out users (031 comment) [core] - 10https://gerrit.wikimedia.org/r/239649 (https://phabricator.wikimedia.org/T112724) (owner: 10TTO) [21:58:18] (03CR) 10Krinkle: Improved personal toolbar for logged-out users (032 comments) [core] - 10https://gerrit.wikimedia.org/r/239649 (https://phabricator.wikimedia.org/T112724) (owner: 10TTO) [22:00:48] (03CR) 10Krinkle: ServiceWorker caching ResourceLoader requests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/219960 (https://phabricator.wikimedia.org/T101732) (owner: 10Gilles) [22:00:56] (03PS2) 10Tchanders: Append error container to inspector [extensions/Score] - 10https://gerrit.wikimedia.org/r/243601 (https://phabricator.wikimedia.org/T113172) [22:01:03] 6Research-and-Data, 7Surveys: Feedback on editor time investment micro-survey - https://phabricator.wikimedia.org/T114242#1703782 (10egalvezwmf) @Halfak, a few comments: **Describe the steps you took to arrive at this edit** What do you mean by "arrive"? What do you mean by "edit"? Do you mean specifically c... [22:01:06] (03CR) 10Gilles: Upgrade Varnish role to Varnish 4 (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/243810 (https://phabricator.wikimedia.org/T114702) (owner: 10Gilles) [22:01:42] 10Reading Web Planning, 10Reading-Community-Engagement: Measure readers reading habits - https://phabricator.wikimedia.org/T114655#1703783 (10Moushira) [22:04:06] (03CR) 10Dduvall: Upgrade Varnish role to Varnish 4 (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/243810 (https://phabricator.wikimedia.org/T114702) (owner: 10Gilles) [22:07:42] 6Reading-Admin: Reading-wmf mailing list name should start with "Reading-Internal" - https://phabricator.wikimedia.org/T102421#1703787 (10MBinder_WMF) @Niedzielski it could be that the sender has that in their Gmail contacts. Regardless of what mailman has set, the Gmail sender's title will override anything els... [22:08:40] 10MediaWiki-extensions-ZeroBanner: Zerobanner #/zeroinfo/ route broken - https://phabricator.wikimedia.org/T114416#1703789 (10jhobs) Yes, but it's technically incorrect. #/zeroinfo is not broken, it's just unused. The task should either be renamed and repurposed to dismantling ZeroInfo.js or closed as Invalid an... [22:09:26] 6Increasing content coverage: provide feedback to the second round of mockups for article recommendation - https://phabricator.wikimedia.org/T114717#1703791 (10leila) 3NEW a:3leila [22:10:37] (03PS3) 10Aaron Schulz: Added CentralAuthUser::setLoadFromMasterFlag() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/232322 [22:11:00] (03PS4) 10Aaron Schulz: Add CentralAuthUser::setLoadFromMasterFlag() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/232322 [22:11:35] (03CR) 10Mglaser: [C: 032] 506 Logging of BSP actions in MW Log [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/239317 (owner: 10Lilu) [22:11:42] 6Increasing content coverage: provide feedback to the second round of mockups for article recommendation - https://phabricator.wikimedia.org/T114717#1703801 (10leila) @Cervisiarius, @Milimetric, @ellery, please review and let me know if you see things that need to be changed, ideally by the end of today. I revie... [22:12:03] 6Increasing content coverage: provide feedback to the second round of mockups for article recommendation - https://phabricator.wikimedia.org/T114717#1703803 (10leila) [22:12:21] (03CR) 10Gilles: Upgrade Varnish role to Varnish 4 (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/243810 (https://phabricator.wikimedia.org/T114702) (owner: 10Gilles) [22:13:13] 10UI-Standardization, 10OOjs-UI: Consolidate `oo-ui-buttonElement-active` and `-pressed` CSS Classes in OOjs UI - https://phabricator.wikimedia.org/T114718#1703805 (10Volker_E) 3NEW [22:15:26] (03PS1) 10Aaron Schulz: Add missing read-only check [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/243818 [22:16:58] 6WMF-Design-Research, 6Increasing content coverage, 7Article-Recommendation, 5Design Research and product team collaboration: article recommendation user testing recruitment - https://phabricator.wikimedia.org/T113393#1703817 (10leila) @SBecker, update: I have sent out 4 emails, talk page messages about th... [22:17:43] (03CR) 10Krinkle: "Caused by https://github.com/sebastianbergmann/phpunit/issues/1898" [at-ease] - 10https://gerrit.wikimedia.org/r/239321 (owner: 10Ori.livneh) [22:19:59] 10UI-Standardization, 10OOjs-UI: Consolidate `oo-ui-buttonElement-active` and `-pressed` CSS Classes in OOjs UI - https://phabricator.wikimedia.org/T114718#1703820 (10Volker_E) [22:20:02] 10UI-Standardization: [Goal] Standardize MediaWiki components - https://phabricator.wikimedia.org/T113560#1703819 (10Volker_E) [22:21:22] (03PS2) 10Aaron Schulz: Add missing read-only check [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/243818 [22:22:37] (03CR) 10Hoo man: [C: 032] Add missing read-only check [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/243818 (owner: 10Aaron Schulz) [22:22:57] (03Merged) 10jenkins-bot: Add missing read-only check [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/243818 (owner: 10Aaron Schulz) [22:27:27] 10UI-Standardization, 10OOjs-UI: OOjs UI Widgets with dropdown menus doesn't receive a CSS class when menu is opened. - https://phabricator.wikimedia.org/T113116#1703824 (10Volker_E) @matmarex Added blocked task T114718 to consolidate classes `-pressed` and `-active`, but there's more to that with `-active` so... [22:28:01] (03PS1) 10BearND: Ensure that we have a full URL for pronunciations [services/mobileapps] - 10https://gerrit.wikimedia.org/r/243819 [22:28:02] 10MediaWiki-Internationalization, 10Beta-Cluster-Infrastructure: Viewing beta's en_rtlwiki just throws a fatal exception - https://phabricator.wikimedia.org/T106125#1703826 (10Krenair) I just unbroke (and manually ran) l10nupdate on deployment-prep to see if it rebuilds en-rtl, looks like it does not. [22:29:03] 10MediaWiki-ResourceLoader, 6Performance-Team, 5MW-1.26-release, 5Patch-For-Review: Make addModuleStyles modules marked as "bottom" actually load at the bottom - https://phabricator.wikimedia.org/T97420#1703829 (10Krinkle) Per T109837 and (currently temporarily reverted) b7c0e537ebb7, further research show... [22:30:29] 10MediaWiki-extensions-UrlShortener, 10Security-Reviews, 6Security-Team: Security review for UrlShortener extension - https://phabricator.wikimedia.org/T112950#1703832 (10yuvipanda) Look at master! :) [22:32:55] 3Reading-Web-Sprint-57-The Fifth Element: Spike (2 hours): How do we measure the success of read more? - https://phabricator.wikimedia.org/T113670#1703836 (10JKatzWMF) @jdlrobson, I suggest we do the following, given that we do not have uniques on web: Minimum Send an event when the Read More section is first s... [22:34:43] 10UI-Standardization, 10OOjs-UI: Consolidate `oo-ui-buttonElement-active` and `-pressed` CSS Classes in OOjs UI - https://phabricator.wikimedia.org/T114718#1703838 (10Volker_E) Adding comment by @matmarex in T113116#1688533: > In T113116#1662160, @Volker_E wrote: > Right now, there are several kinds of semant... [22:36:26] (03PS1) 10Llbraughler: Added autopatrol parameter to MarkPatrolled and MarkPatrolledComplete hooks [core] - 10https://gerrit.wikimedia.org/r/243821 [22:37:45] 10MediaWiki-ResourceLoader, 6Performance-Team: Consider removing top/bottom queue distinction - https://phabricator.wikimedia.org/T109837#1703844 (10Krinkle) Aside from the top/bottom distinction for javascript, there is a similar distinction for stylesheets. However, that distinction was only recently introd... [22:37:59] 10MediaWiki-Internationalization, 10Beta-Cluster-Infrastructure: Viewing beta's en_rtlwiki just throws a fatal exception - https://phabricator.wikimedia.org/T106125#1703850 (10Luke081515) But the error message has now only 21 lines, not 24 like at the task description. [22:38:46] 10MediaWiki-ResourceLoader, 10Sentry, 5Patch-For-Review: Use source urls in mw.loader.store - https://phabricator.wikimedia.org/T90524#1703854 (10Krinkle) a:3Krinkle [22:38:51] (03PS14) 10Krinkle: [WIP] resourceloader: Set sourceURL in eval calls for mw.loader.store [core] - 10https://gerrit.wikimedia.org/r/156544 (https://phabricator.wikimedia.org/T90524) [22:39:59] 10MediaWiki-Internationalization, 10Beta-Cluster-Infrastructure: Viewing beta's en_rtlwiki just throws a fatal exception - https://phabricator.wikimedia.org/T106125#1703856 (10Krenair) I don't think that really matters. Before it was because my account was being unified, now it's just from normal page views. [22:45:01] 10UI-Standardization, 10OOjs-UI: Consolidate `oo-ui-buttonElement-active` and `-pressed` CSS Classes in OOjs UI - https://phabricator.wikimedia.org/T114718#1703879 (10Volker_E) @Prtksxna I've seen in history.md there's been a "counter-movement" renaming `@active` to `@pressed`. Please explain the reasons behin... [22:45:05] 6Wikisource: Advanced editor toolbar doesn't load the Proofreading tools portion on first try - https://phabricator.wikimedia.org/T114553#1703882 (10Ineuw) Good reply. :-) Being well versed with Firefox: 1. Created a new profile before I posted initially. 2. Tested it in safe mode and the problem persists. [22:45:45] (03CR) 10Cscott: "I'm not sure it's actually possible to write a parsertest for this, since I don't think there's any way to get %5B into the sanitizer here" [core] - 10https://gerrit.wikimedia.org/r/234536 (owner: 10Cscott) [22:47:58] 10MediaWiki-Documentation, 10Possible-Tech-Projects, 6WMF-Legal, 10Web-APIs-Hub, 7Documentation: technology to transclude git content into wiki pages - https://phabricator.wikimedia.org/T91626#1703893 (10Tgr) @Laucon you should write an application first. The process is described at https://www.mediawiki... [22:49:40] 4(no projects): Convert Git2Pages to use extension registration - https://phabricator.wikimedia.org/T114719#1703901 (10Spage) 3NEW [22:50:07] (03CR) 10Llbraughler: "The purpose of this addition is for extensions who need to know whether a patrol was automatic versus manual - for instance, keeping track" [core] - 10https://gerrit.wikimedia.org/r/243821 (owner: 10Llbraughler) [22:51:55] (03CR) 10BearND: [C: 031] "When this is merged then I recommend Stephen do a TWN sync so the translators have enough time to translate the new strings." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/243720 (https://phabricator.wikimedia.org/T108532) (owner: 10Mholloway) [22:52:54] 10MediaWiki-extensions-Git2Pages: Convert Git2Pages to use extension registration - https://phabricator.wikimedia.org/T114719#1703917 (10Krenair) [22:53:29] 10MediaWiki-extensions-Git2Pages, 7Easy: Convert Git2Pages to use extension registration - https://phabricator.wikimedia.org/T114719#1703920 (10Spage) [22:54:39] (03CR) 10Dbrant: [C: 032] Rename nav menu "More" item to "Settings" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/243720 (https://phabricator.wikimedia.org/T108532) (owner: 10Mholloway) [22:54:41] (03PS3) 10Esanders: Append error container to inspector [extensions/Score] - 10https://gerrit.wikimedia.org/r/243601 (https://phabricator.wikimedia.org/T113172) (owner: 10Tchanders) [22:55:17] (03CR) 10Esanders: Append error container to inspector (031 comment) [extensions/Score] - 10https://gerrit.wikimedia.org/r/243601 (https://phabricator.wikimedia.org/T113172) (owner: 10Tchanders) [22:55:25] (03CR) 10Esanders: [C: 032] Append error container to inspector [extensions/Score] - 10https://gerrit.wikimedia.org/r/243601 (https://phabricator.wikimedia.org/T113172) (owner: 10Tchanders) [22:56:10] (03CR) 10Esanders: [C: 032] Append error container to inspector [extensions/Math] - 10https://gerrit.wikimedia.org/r/243684 (https://phabricator.wikimedia.org/T113172) (owner: 10Tchanders) [22:56:21] (03PS1) 10Mooeypoo: Replace old editor with new in no-js view with js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/243825 (https://phabricator.wikimedia.org/T114448) [22:56:27] (03Abandoned) 10Legoktm: Add script to back-populate promote to global logs from the rename queue [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/237169 (https://phabricator.wikimedia.org/T93214) (owner: 10Legoktm) [22:59:01] (03CR) 10MaxSem: [C: 032] Move php class files to /includes subdirectory [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/242876 (owner: 10Aude) [22:59:19] (03Merged) 10jenkins-bot: Rename nav menu "More" item to "Settings" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/243720 (https://phabricator.wikimedia.org/T108532) (owner: 10Mholloway) [22:59:22] (03Merged) 10jenkins-bot: Append error container to inspector [extensions/Score] - 10https://gerrit.wikimedia.org/r/243601 (https://phabricator.wikimedia.org/T113172) (owner: 10Tchanders) [22:59:25] (03Merged) 10jenkins-bot: Append error container to inspector [extensions/Math] - 10https://gerrit.wikimedia.org/r/243684 (https://phabricator.wikimedia.org/T113172) (owner: 10Tchanders) [23:01:40] 10MediaWiki-extensions-MultimediaViewer, 5Patch-For-Review: Show image annotations - https://phabricator.wikimedia.org/T58666#1703988 (10Tgr) MediaViewer tries to support all the useful reader-facing functionality of file pages that's accessible in a structured form, and annotations are one major missing piece... [23:02:07] (03CR) 10Alex Monk: [C: 032] Update extensions/VisualEditor to wmf/1.27.0-wmf.1 HEAD [core] (wmf/1.27.0-wmf.1) - 10https://gerrit.wikimedia.org/r/243729 (owner: 10Jforrester) [23:03:15] 10MediaWiki-RfCs: RFC: per-language URLs for pages of multilingual wikis. - https://phabricator.wikimedia.org/T114662#1703989 (10Legoktm) > Make the Linker class aware of the target language (probably needs a complete refactoring) https://www.mediawiki.org/wiki/Requests_for_comment/Linker_refactor has already b... [23:03:16] (03PS3) 10Krinkle: objectcache: Add BagOStuff::READ_VERIFIED flag to get() [core] - 10https://gerrit.wikimedia.org/r/243426 (owner: 10Aaron Schulz) [23:03:23] (03CR) 10Krinkle: [C: 032] objectcache: Add BagOStuff::READ_VERIFIED flag to get() [core] - 10https://gerrit.wikimedia.org/r/243426 (owner: 10Aaron Schulz) [23:04:43] (03PS1) 10Jhobs: Fix banner injection [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/243827 [23:07:01] 10MediaWiki-Gallery, 10Math, 10Score, 10VisualEditor, and 3 others: With extension editors, show rendering errors inside the inspector, not the ce node - https://phabricator.wikimedia.org/T113172#1703999 (10Jdforrester-WMF) 5Open>3Resolved [23:07:02] (03CR) 10Jdlrobson: [C: 032] Fix banner injection [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/243827 (owner: 10Jhobs) [23:07:03] 10MediaWiki-Email, 7Documentation: Minor bot edits don't trigger email notifications even with "E-mail me also for minor edits of pages" selected - https://phabricator.wikimedia.org/T40874#1704001 (10Quiddity) [23:07:07] 10MediaWiki-Gallery, 10Math, 10Score, 10VisualEditor, and 3 others: With extension editors, show rendering errors inside the inspector, not the ce node - https://phabricator.wikimedia.org/T113172#1656767 (10Jdforrester-WMF) Nice. [23:09:00] (03PS1) 10Legoktm: build: Pin to specific version of mediawiki-codesniffer [wikimedia/slimapp] - 10https://gerrit.wikimedia.org/r/243829 [23:09:09] 10MediaWiki-Email: Changing page from protected to unprotected send "New page" email - https://phabricator.wikimedia.org/T63313#1704017 (10Quiddity) [23:09:10] 10MediaWiki-Email: Email notification mistakes most log actions for new page creation - https://phabricator.wikimedia.org/T44457#1704018 (10Quiddity) [23:09:23] (03PS1) 10Niedzielski: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/243830 [23:09:40] (03CR) 10Niedzielski: "it's a shame there's so much overhead to do something so simple. i hope everyone will do their best to not be discouraged from making thes" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/243720 (https://phabricator.wikimedia.org/T108532) (owner: 10Mholloway) [23:10:24] 10MediaWiki-RfCs, 10Architecture, 6Editing-Department, 10Parsoid, 10Wikimedia-Developer-Summit-2016: Page components / content widgets - https://phabricator.wikimedia.org/T105845#1704026 (10GWicke) >>! In T105845#1683163, @GWicke wrote: >> The primary thing to figure out is how do we get that information... [23:11:25] (03CR) 10Krinkle: [C: 032] Remove ?maxlag check in index.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/243471 (owner: 10Aaron Schulz) [23:12:04] (03Merged) 10jenkins-bot: Update extensions/VisualEditor to wmf/1.27.0-wmf.1 HEAD [core] (wmf/1.27.0-wmf.1) - 10https://gerrit.wikimedia.org/r/243729 (owner: 10Jforrester) [23:12:34] 10MediaWiki-Email, 10MediaWiki-Watchlist: Email notification for every single change to a page on watchlist - https://phabricator.wikimedia.org/T114587#1704027 (10Quiddity) [23:12:36] 10MediaWiki-Email: Enable users to set their preferences to receive watchlist notifications regardless of whether the page has been visited - https://phabricator.wikimedia.org/T33928#1704028 (10Quiddity) [23:13:26] (03Merged) 10jenkins-bot: objectcache: Add BagOStuff::READ_VERIFIED flag to get() [core] - 10https://gerrit.wikimedia.org/r/243426 (owner: 10Aaron Schulz) [23:13:28] (03Merged) 10jenkins-bot: Fix banner injection [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/243827 (owner: 10Jhobs) [23:14:15] 10MediaWiki-Email: Enable users to set their preferences to receive watchlist notifications regardless of whether the page has been visited - https://phabricator.wikimedia.org/T33928#352933 (10Quiddity) I've merged the duplicate task, but there are some good comments in there. {T114587} for future reference. [23:15:00] (03CR) 10Krinkle: [C: 032] Remove mismatched COMMIT from FileDeleteForm [core] - 10https://gerrit.wikimedia.org/r/243361 (owner: 10Aaron Schulz) [23:15:18] (03CR) 10Sniedzielski: [C: 032] Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/243830 (owner: 10Niedzielski) [23:19:26] 3Reading-Web-Sprint-57-The Fifth Element: Demonstrate impact of loading just lead sections of a group of static pages - https://phabricator.wikimedia.org/T113649#1704048 (10Jdlrobson) I thought using https://github.com/marcelduran/webpagetest-api would be easy enough but it doesnt seem to support connection spee... [23:19:29] 10Reading-Web, 10Wikimedia-Extension-setup, 10Wikimedia-Site-Requests, 5Patch-For-Review: Install WikidataPageBanner on Catalan Wiki - https://phabricator.wikimedia.org/T114392#1704049 (10Krenair) [23:19:33] 10Reading-Web, 10Wikimedia-Extension-setup, 10Wikimedia-Site-Requests, 5Patch-For-Review: Install WikidataPageBanner on Catalan Wiki - https://phabricator.wikimedia.org/T114392#1704052 (10Krenair) 5Open>3Resolved a:3Krenair [23:19:41] 10Reading-Web, 10Wikimedia-Extension-setup, 5Patch-For-Review: Install WikidataPageBanner on Catalan Wiki - https://phabricator.wikimedia.org/T114392#1694046 (10Krenair) [23:19:50] (03Draft2) 10Aude: Move php class files to /includes subdirectory [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/242876 [23:19:53] 10Reading-Web, 10Wikimedia-Extension-setup, 5Patch-For-Review: Enable Extension:WikidataPageBanner on Chinese Wikivoyage - https://phabricator.wikimedia.org/T114334#1704055 (10Krenair) 5Open>3Resolved a:3Krenair [23:19:59] (03CR) 10MaxSem: [C: 032] Move php class files to /includes subdirectory [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/242876 (owner: 10Aude) [23:20:27] 10MediaWiki-jQuery-Tablesorter: Table sorting broken by use of expand-child class - https://phabricator.wikimedia.org/T114721#1704057 (10Postdlf) 3NEW [23:21:12] 6Education-Collab: Recruit a Collab member from Asia - https://phabricator.wikimedia.org/T111401#1704065 (10Shangkuanlc) Oh, the collaborative is very efficient, there are already 6 feedback on the [[ https://outreach.wikimedia.org/wiki/Talk:Education/Wikipedia_Education_Collaborative/Tasks#Continue_the_on-wiki_... [23:21:40] (03Merged) 10jenkins-bot: Remove ?maxlag check in index.php [core] - 10https://gerrit.wikimedia.org/r/243471 (owner: 10Aaron Schulz) [23:22:04] (03CR) 10BryanDavis: "I'm ok with pinning but I'm not sure why it is needed." [wikimedia/slimapp] - 10https://gerrit.wikimedia.org/r/243829 (owner: 10Legoktm) [23:23:29] (03CR) 10Legoktm: "Because 0.4.0 satisfies ~0.3. If you run "composer update && composer test" without my patch, phpcs will fail." [wikimedia/slimapp] - 10https://gerrit.wikimedia.org/r/243829 (owner: 10Legoktm) [23:23:31] (03PS1) 10Jdlrobson: Fix banner injection [extensions/ZeroBanner] (wmf/1.27.0-wmf.1) - 10https://gerrit.wikimedia.org/r/243833 [23:23:41] 10MediaWiki-extensions-RelatedArticles, 10Gather, 10Reading Web Planning: Finalise RelatedArticles design - https://phabricator.wikimedia.org/T113768#1704072 (10KHammerstein) [23:24:27] (03PS2) 10Alex Monk: Fix banner injection [extensions/ZeroBanner] (wmf/1.27.0-wmf.1) - 10https://gerrit.wikimedia.org/r/243833 (owner: 10Jdlrobson) [23:24:47] 10MediaWiki-RfCs, 10Architecture, 6Editing-Department, 10Parsoid, 10Wikimedia-Developer-Summit-2016: Page components / content widgets - https://phabricator.wikimedia.org/T105845#1704073 (10Tgr) Navcolumns are often used as a table of contents over articles, and their placement reflects that. https://en.... [23:24:56] (03Merged) 10jenkins-bot: Remove mismatched COMMIT from FileDeleteForm [core] - 10https://gerrit.wikimedia.org/r/243361 (owner: 10Aaron Schulz) [23:24:59] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/243830 (owner: 10Niedzielski) [23:25:01] (03Merged) 10jenkins-bot: Move php class files to /includes subdirectory [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/242876 (owner: 10Aude) [23:25:33] (03PS1) 10Ori.livneh: Add MemoizedCallable for APC-backed function memoization [core] - 10https://gerrit.wikimedia.org/r/243834 [23:25:57] 10Hovercards, 3Reading-Web-Sprint-57-The Fifth Element: Spike: Alternative to TextExtracts for Popups, Gather, Read more - https://phabricator.wikimedia.org/T113633#1704076 (10Jdlrobson) >>! In T113633#1702146, @phuedx wrote: >> What is a summary of the existing bugs? > > The most common pain points of the #T... [23:26:01] (03CR) 10Alex Monk: [C: 032] Fix banner injection [extensions/ZeroBanner] (wmf/1.27.0-wmf.1) - 10https://gerrit.wikimedia.org/r/243833 (owner: 10Jdlrobson) [23:26:30] 10Wikimedia-Site-Requests, 5Patch-For-Review: Activate Extension:WikidataPageBanner in all namespaces in Russian Wikivoyage - https://phabricator.wikimedia.org/T114566#1704078 (10Krenair) Was this discussed on-wiki? [23:26:59] 10MediaWiki-extensions-RelatedArticles, 10Gather, 10Reading Web Planning: Finalise RelatedArticles design - https://phabricator.wikimedia.org/T113768#1704079 (10KHammerstein) [23:27:27] (03CR) 10CSteipp: [C: 032] Add ability to login user without password check [wikimedia/slimapp] - 10https://gerrit.wikimedia.org/r/236683 (owner: 10BryanDavis) [23:28:09] (03CR) 10jenkins-bot: [V: 04-1] Add MemoizedCallable for APC-backed function memoization [core] - 10https://gerrit.wikimedia.org/r/243834 (owner: 10Ori.livneh) [23:28:21] (03Merged) 10jenkins-bot: Fix banner injection [extensions/ZeroBanner] (wmf/1.27.0-wmf.1) - 10https://gerrit.wikimedia.org/r/243833 (owner: 10Jdlrobson) [23:28:23] (03CR) 10jenkins-bot: [V: 04-1] Add ability to login user without password check [wikimedia/slimapp] - 10https://gerrit.wikimedia.org/r/236683 (owner: 10BryanDavis) [23:28:41] 10Wikimedia-Site-Requests, 5Patch-For-Review: Activate Extension:WikidataPageBanner in all namespaces in Russian Wikivoyage - https://phabricator.wikimedia.org/T114566#1704085 (10Jdlrobson) @krenair this is a regression. I didn't realise the Russian Wikivoyage community were using it on talk pages and didn't w... [23:29:52] 10MediaWiki-extensions-OAuth, 10Beta-Cluster-Infrastructure, 10Pywikibot-OAuth, 5Patch-For-Review, and 2 others: "Nonce already used" regularly occurring on beta cluster - https://phabricator.wikimedia.org/T109173#1704087 (10jayvdb) >>! In T109173#1666826, @XZise wrote: > Not sure if that patch helped but... [23:31:37] (03CR) 10Krinkle: [C: 031] Lower CDN cache TTL when slave lag is high [core] - 10https://gerrit.wikimedia.org/r/242812 (https://phabricator.wikimedia.org/T113204) (owner: 10Aaron Schulz) [23:33:24] (03PS2) 10Ori.livneh: Add MemoizedCallable for APC-backed function memoization [core] - 10https://gerrit.wikimedia.org/r/243834 [23:34:19] 10OCG-General-or-Unknown: PDFs failing to render - https://phabricator.wikimedia.org/T114722#1704101 (10Reedy) 3NEW [23:35:23] 10OCG-General-or-Unknown: PDFs failing to render - https://phabricator.wikimedia.org/T114722#1704108 (10Reedy) [23:35:44] (03CR) 10Krinkle: [C: 032] Make WANObjectCache sets account for slave lag [core] - 10https://gerrit.wikimedia.org/r/242783 (https://phabricator.wikimedia.org/T113204) (owner: 10Aaron Schulz) [23:35:52] (03CR) 10jenkins-bot: [V: 04-1] Make WANObjectCache sets account for slave lag [core] - 10https://gerrit.wikimedia.org/r/242783 (https://phabricator.wikimedia.org/T113204) (owner: 10Aaron Schulz) [23:35:59] (03CR) 10Mooeypoo: "I am not seeing what this is changing. Is this a visual change that I'm missing or more of a consistency one?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/243376 (owner: 10Esanders) [23:36:02] (03CR) 10Krinkle: [C: 032] Start rename of DatabaseBase => Database [core] - 10https://gerrit.wikimedia.org/r/243528 (owner: 10Aaron Schulz) [23:36:38] (03PS5) 10Gilles: Upgrade Varnish role to Varnish 4 [vagrant] - 10https://gerrit.wikimedia.org/r/243810 (https://phabricator.wikimedia.org/T114702) [23:36:55] (03CR) 10jenkins-bot: [V: 04-1] Upgrade Varnish role to Varnish 4 [vagrant] - 10https://gerrit.wikimedia.org/r/243810 (https://phabricator.wikimedia.org/T114702) (owner: 10Gilles) [23:37:07] (03CR) 10jenkins-bot: [V: 04-1] Add MemoizedCallable for APC-backed function memoization [core] - 10https://gerrit.wikimedia.org/r/243834 (owner: 10Ori.livneh) [23:38:08] (03PS3) 10Ori.livneh: Add MemoizedCallable for APC-backed function memoization [core] - 10https://gerrit.wikimedia.org/r/243834 [23:38:26] (03PS6) 10Gilles: Upgrade Varnish role to Varnish 4 [vagrant] - 10https://gerrit.wikimedia.org/r/243810 (https://phabricator.wikimedia.org/T114702) [23:38:36] (03PS1) 10BryanDavis: Update code standard to mediawiki/mediawiki-codesniffer 0.4.0 [wikimedia/slimapp] - 10https://gerrit.wikimedia.org/r/243835 [23:39:06] 10Possible-Tech-Projects: Implement wikicode linting framework / library - https://phabricator.wikimedia.org/T114631#1704122 (10MZMcBride) https://en.wikipedia.org/wiki/User:BracketBot may be of interest to people here. [23:39:46] (03CR) 10Esanders: "This should fix the horizontal alignment of the two action buttons at the bottom, and remove a bit of space beneath them." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/243376 (owner: 10Esanders) [23:39:49] (03CR) 10Gilles: "This time tested on a brand new VM" [vagrant] - 10https://gerrit.wikimedia.org/r/243810 (https://phabricator.wikimedia.org/T114702) (owner: 10Gilles) [23:40:06] (03CR) 10BryanDavis: [C: 04-1] "See I5669361d99cfdc41619f8d73e5bb083f6477a4e4 which bumps the minimum version of the code standard to 0.4.0 and fixes the differences from" [wikimedia/slimapp] - 10https://gerrit.wikimedia.org/r/243829 (owner: 10Legoktm) [23:40:20] (03PS13) 10Gilles: Enable far-future expires [vagrant] - 10https://gerrit.wikimedia.org/r/238187 (https://phabricator.wikimedia.org/T111721) [23:41:03] (03CR) 10Legoktm: [C: 032] Update code standard to mediawiki/mediawiki-codesniffer 0.4.0 [wikimedia/slimapp] - 10https://gerrit.wikimedia.org/r/243835 (owner: 10BryanDavis) [23:41:20] 10MediaWiki-extensions-RelatedArticles, 10Gather, 10Reading Web Planning: Finalise RelatedArticles design - https://phabricator.wikimedia.org/T113768#1704123 (10KHammerstein) @Jdlrobson design added [23:41:35] (03CR) 10Krinkle: [C: 032] Cleanups to MigrateFileRepoLayout [core] - 10https://gerrit.wikimedia.org/r/243606 (owner: 10Aaron Schulz) [23:41:41] (03CR) 10BryanDavis: "The failing unit test is running "composer update --ansi --no-progress --prefer-dist --profile -v" which is not really the correct behavio" [wikimedia/slimapp] - 10https://gerrit.wikimedia.org/r/236683 (owner: 10BryanDavis) [23:41:47] (03CR) 10Krinkle: [C: 032] Clean up Special:Undelete read-only checks [core] - 10https://gerrit.wikimedia.org/r/243593 (owner: 10Aaron Schulz) [23:42:11] 10MobileFrontend: Entry field obscured - https://phabricator.wikimedia.org/T114567#1704124 (10JMinor) Hello @rpetruzzelli, this screenshot looks a third-party wikipedia reader app. Please note that the foundation only works on this official app; https://itunes.apple.com/us/app/wikipedia-mobile/id324715238?mt=8... [23:42:53] legoktm: I see why you wanted the fix now, but that test harness is broken too. You can't just blindly run `composer update` if the composer.lock is versioned [23:43:35] yeah [23:44:00] I'll file a CI bug about that...if composer.lock is checked in, we should be running composer install, not update [23:44:12] my composer.lock pins lots of libraries at particular versions and running an unbounded update could pull them all up to newer versions that are not really desired [23:44:59] (03CR) 10Krinkle: [C: 032] Remove setting of $wgReadOnly in LBFactoryMulti [core] - 10https://gerrit.wikimedia.org/r/243610 (owner: 10Aaron Schulz) [23:45:03] I think we figured out how to handle that in mw-vagrant's update script. I think we just checked to see if the lock was versioned [23:45:29] 10MediaWiki-Documentation, 10Possible-Tech-Projects, 6WMF-Legal, 10Web-APIs-Hub, 7Documentation: technology to transclude git content into wiki pages - https://phabricator.wikimedia.org/T91626#1704127 (10Laucon) @Tgr. Perfect. Thanks so much! [23:45:36] (03CR) 10Krinkle: [C: 032] Remove return value from FormSpecialPage::checkExecutePermissions [core] - 10https://gerrit.wikimedia.org/r/243590 (owner: 10Aaron Schulz) [23:45:38] (03PS12) 10Aaron Schulz: Make WANObjectCache sets account for slave lag [core] - 10https://gerrit.wikimedia.org/r/242783 (https://phabricator.wikimedia.org/T113204) [23:45:40] (03Merged) 10jenkins-bot: Start rename of DatabaseBase => Database [core] - 10https://gerrit.wikimedia.org/r/243528 (owner: 10Aaron Schulz) [23:45:42] (03Merged) 10jenkins-bot: Update code standard to mediawiki/mediawiki-codesniffer 0.4.0 [wikimedia/slimapp] - 10https://gerrit.wikimedia.org/r/243835 (owner: 10BryanDavis) [23:45:44] (03Abandoned) 10Krinkle: Remove unused checkExecutePermissions() return value [core] - 10https://gerrit.wikimedia.org/r/243731 (owner: 10Krinkle) [23:45:44] is there a git command for that? [23:45:59] * bd808 is looking for the script.... [23:46:50] git ls-files --error-unmatch composer.lock [23:47:28] legoktm: https://github.com/wikimedia/mediawiki-vagrant/blob/master/puppet/modules/mediawiki/templates/run-git-update.erb#L105-L111 [23:47:44] (03CR) 10Mooeypoo: "I think I am missing the existing issue, then? I look at the pages with master and this commit side by side and I see no difference." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/243376 (owner: 10Esanders) [23:49:32] 6WMF-Design-Research, 5Design Research and product team collaboration: gather list of CX users to contact re: Article Recommendations study - https://phabricator.wikimedia.org/T114724#1704132 (10Capt_Swing) 3NEW a:3Capt_Swing [23:50:01] (03CR) 10Jdlrobson: [C: 031] "I need to replicate the issue that caused the fatal with the old patch and then try this again." [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/243124 (https://phabricator.wikimedia.org/T98791) (owner: 10Phuedx) [23:50:15] 6WMF-Design-Research, 3Collaboration-Team-Current, 5Design Research and product team collaboration: Curation tools user interviews {raven} - https://phabricator.wikimedia.org/T112027#1704139 (10Capt_Swing) [23:50:41] (03Merged) 10jenkins-bot: Cleanups to MigrateFileRepoLayout [core] - 10https://gerrit.wikimedia.org/r/243606 (owner: 10Aaron Schulz) [23:51:00] (03Merged) 10jenkins-bot: Clean up Special:Undelete read-only checks [core] - 10https://gerrit.wikimedia.org/r/243593 (owner: 10Aaron Schulz) [23:51:33] (03PS2) 10BryanDavis: Add ability to login user without password check [wikimedia/slimapp] - 10https://gerrit.wikimedia.org/r/236683 [23:51:45] (03Abandoned) 10Legoktm: build: Pin to specific version of mediawiki-codesniffer [wikimedia/slimapp] - 10https://gerrit.wikimedia.org/r/243829 (owner: 10Legoktm) [23:51:45] 6WMF-Design-Research, 5Design Research recruitment process: define process for integrating fr list - https://phabricator.wikimedia.org/T114060#1704140 (10Capt_Swing) [23:51:51] (03CR) 10BryanDavis: [C: 032] "Tests should be fixed now" [wikimedia/slimapp] - 10https://gerrit.wikimedia.org/r/236683 (owner: 10BryanDavis) [23:52:27] 6WMF-Design-Research, 5Design Research Project Documentation 2015Q2: add CC user testing participant videos to commons - https://phabricator.wikimedia.org/T108212#1704143 (10Capt_Swing) [23:52:30] 10MediaWiki-RfCs, 10Architecture, 6Editing-Department, 10Parsoid, 10Wikimedia-Developer-Summit-2016: Page components / content widgets - https://phabricator.wikimedia.org/T105845#1704144 (10Quiddity) There are also the articles which have multiple infoboxes. E.g. [[https://en.wikipedia.org/wiki/Mini |w:e... [23:52:43] 10MediaWiki-General-or-Unknown, 10Continuous-Integration-Infrastructure: mediawiki-config needs better coverage - https://phabricator.wikimedia.org/T114725#1704146 (10MaxSem) 3NEW [23:52:52] 6WMF-Design-Research, 5Design Research Project Documentation 2015Q2: convert Wikimania mobile videos to open format and upload them to Commons {corgi} - https://phabricator.wikimedia.org/T113548#1704153 (10Capt_Swing) [23:53:35] 6Design Research Backlog, 6Increasing content coverage, 7Article-Recommendation, 5Design Research and product team collaboration: User testing of article recommendations - https://phabricator.wikimedia.org/T110355#1704155 (10Capt_Swing) [23:53:57] 6Design Research Backlog, 5Design Research and product team collaboration: Investigate Latin American pageview drops - https://phabricator.wikimedia.org/T109114#1704159 (10Capt_Swing) [23:54:09] 10MediaWiki-General-or-Unknown, 10MediaWiki-Unit-tests: mediawiki-config needs better coverage - https://phabricator.wikimedia.org/T114725#1704160 (10greg) [23:54:58] 6Design Research Backlog, 5Design Research and product team collaboration: Placeholder research for iterating vector - https://phabricator.wikimedia.org/T108218#1704165 (10Capt_Swing) [23:55:11] 6Design Research Backlog, 5Design Research and product team collaboration: Link recommendations user testing - https://phabricator.wikimedia.org/T112030#1704166 (10Capt_Swing) [23:56:24] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-EducationProgram, 10Librarization, 10Wikidata: Extract/Remove ORM from MediaWiki core and move to Vendor repo - https://phabricator.wikimedia.org/T114538#1704167 (10Reedy) [23:56:46] 10MediaWiki-General-or-Unknown, 10MediaWiki-Unit-tests: mediawiki-config needs better test coverage - https://phabricator.wikimedia.org/T114725#1704168 (10MaxSem) [23:57:41] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-EducationProgram, 10Librarization, 10Wikidata: Extract/Remove ORM from MediaWiki core and move to Vendor repo - https://phabricator.wikimedia.org/T114538#1698839 (10Reedy) EducationProgram and Wikidata/Wikibase seem to be the only real users of this co...