[00:21:19] (03PS1) 10Yoonghm: Modify code due to code quality check [core] - 10https://gerrit.wikimedia.org/r/241488 [00:29:51] 10Wikimedia-Site-Requests, 7I18n: Change default font for EasyTimeline on zh projects to something that actually has glyphs for Chinese characters - https://phabricator.wikimedia.org/T22825#1678767 (10Liuxinyu970226) Per above, #Upstream? [00:33:02] (03CR) 10Ricordisamoa: "Please read https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change_.28your_own_or_someone_else.27s.29 and amend I0bae67355ac6152" [core] - 10https://gerrit.wikimedia.org/r/241488 (owner: 10Yoonghm) [00:44:05] (03PS4) 10Yoonghm: Fix "pg_send_query(): There are results on this connection..." [core] - 10https://gerrit.wikimedia.org/r/241357 (https://phabricator.wikimedia.org/T52091) [00:54:27] 10Wikimedia-Mailing-lists: Create affiliates-l mailing list for Wikimedia Movement Affiliates - https://phabricator.wikimedia.org/T113867#1678778 (10Revi) Per the (proposed) [[ https://meta.wikimedia.org/wiki/Mailing_lists/Standardization | mailing list name convention ]], listname should not have -l suffix. [00:58:11] 10Wikimedia-Mailing-lists: Create affiliates-l mailing list for Wikimedia Movement Affiliates - https://phabricator.wikimedia.org/T113867#1678780 (10Revi) Also, activities such as wlm is already organized on wikilovesmonuments@l.wm.o, why does it need to be organized on the affliations@l.wm.o? Also, for the mem... [01:02:54] 10Wikimedia-Extension-setup: Add Extension:Variables to en.wikiversity - https://phabricator.wikimedia.org/T113859#1678782 (10Revi) [01:05:45] 10Wikimedia-Mailing-lists: Create affiliates-l mailing list for Wikimedia Movement Affiliates - https://phabricator.wikimedia.org/T113867#1678783 (10Varnent) WLM is one example - there are many other community-wide activities. Also, this can be a way to draw people to participate in wikilovesmonuments@l.wm.o whe... [01:16:35] 10Wikimedia-Extension-setup: Enable Extension:ShortUrl for Bhojpuri wikipedia (bh.wikipedia) - https://phabricator.wikimedia.org/T113348#1678784 (10Liuxinyu970226) [01:17:53] 10MediaWiki-extensions-PageCuration, 6Collaboration-Team-Backlog, 7I18n: Make PageTriage wiki agnostic - https://phabricator.wikimedia.org/T50552#1678785 (10Liuxinyu970226) [01:19:48] 10MediaWiki-extensions-Other: [OfflineImportLexicon] Add right and action message for user right offlineimportlexicon - https://phabricator.wikimedia.org/T113793#1678786 (10Liuxinyu970226) [01:19:58] 10MediaWiki-extensions-Other: Rewrite Special:CreateRedirect with FormSpecialPage - https://phabricator.wikimedia.org/T113150#1678787 (10Liuxinyu970226) [01:20:07] 10MediaWiki-extensions-Other: [Video] PHP Fatal Error: Access level to SpecialUndeleteWithVideoSupport::isAllowed() must be protected (as in class SpecialUndelete) or weaker - https://phabricator.wikimedia.org/T112444#1678788 (10Liuxinyu970226) [01:26:58] 10Wikimedia-General-or-Unknown, 6Wikisource, 7Tracking: [NO NOT USE. Please use the Wikisource project] Wikisource related bugs and enhancements (tracking) - https://phabricator.wikimedia.org/T37925#1678789 (10Billinghurst) [01:28:05] 10MediaWiki-extensions-ContributionTracking, 5Patch-For-Review: Convert ContributionTracking to use extension registration - https://phabricator.wikimedia.org/T87903#1678790 (10Liuxinyu970226) [01:29:31] 6Wikisource: Namespace number for custom namespaces differs between bnwikisource and enwikisource - https://phabricator.wikimedia.org/T113861#1678795 (10Billinghurst) [01:29:35] 10Wikimedia-General-or-Unknown, 6Wikisource, 7Tracking: [NO NOT USE. Please use the Wikisource project] Wikisource related bugs and enhancements (tracking) - https://phabricator.wikimedia.org/T37925#1678794 (10Billinghurst) [01:32:49] 6Wikisource: Namespace number for custom namespaces differs between bnwikisource and enwikisource - https://phabricator.wikimedia.org/T113861#1678797 (10Ricordisamoa) [01:33:43] 6Wikisource: Namespace number for custom namespaces differs between bnwikisource and enwikisource - https://phabricator.wikimedia.org/T113861#1678801 (10Billinghurst) There is a difference, and that does cause some issues for those who copy enWS templates where we have referenced NS directly. It is not specifica... [01:35:06] 6Wikisource: Namespace number for custom namespaces differs between bnwikisource and enwikisource - https://phabricator.wikimedia.org/T113861#1678802 (10Billinghurst) [01:49:59] hi! new user here :s if anyone is able to help that'd be awesome - im just trying to setup the mediawiki vagrant and after doing 'vagrant up' it seems stuck at: notice: /Stage[main]/Mediawiki/Git::Clone[mediawiki/core]/File[vagrant/mediawiki]/ensure: created [01:50:13] should i just ctrl+c out of it...its been like that for at least an hour, but i dont want to mess up any installation D: [01:52:44] fmf: so, two things :) the first is that sadly whatever puppet is doing now is probably not the 'ensure' portion [01:53:08] fmf: the second is i would probably ssh into the box (vagrant ssh from another shell) and use `ps axf | less` to see what it is doing [01:53:27] if i had to guess, perhaps its download mediawiki core (~500MB ) and your network isnt very fast(guessing)? [01:53:41] the core is only 500M because of the git history [01:56:48] yep! was trying to do that, but network is kind of slow [01:56:58] will try sshing into the box as you mentioned! [01:57:11] (very new to vagrant etc., ty for the help!) [01:57:16] np [02:04:19] theres one process with /usr/sbin/mysqld [02:04:44] along with many others of course [02:04:58] but most of them have a time of 00:00 [02:13:58] hm and now when i ssh into it from another shell, the mediawiki sign/unicorn shows up lol. guess its doing something right. [02:20:47] welcome, fmf [02:31:54] thx! [02:34:39] 10MediaWiki-Database: Database tables in PostgreSQL and Oracle are treated differently from other tables in other database. Why? - https://phabricator.wikimedia.org/T113445#1678807 (10Yoonghm) Hi @Aklapper, I am not sure besides Semantic MediaWiki, which extension needs to use cloneTableStructure(). I performed... [02:44:31] I assume you've read all of the introductory guides? [02:50:13] was following https://www.mediawiki.org/wiki/MediaWiki-Vagrant#Basic_usage and [02:50:15] https://www.mediawiki.org/wiki/Gerrit/Tutorial [02:59:39] 10MediaWiki-ResourceLoader, 6Performance-Team: File dependency tracking for ResourceLoader modules is broken - https://phabricator.wikimedia.org/T113868#1678809 (10ori) 3NEW [03:00:39] (03CR) 10Ori.livneh: "Caused T113868" [core] - 10https://gerrit.wikimedia.org/r/155442 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [03:01:45] 10MediaWiki-ResourceLoader, 6Performance-Team: File dependency tracking for ResourceLoader modules is broken - https://phabricator.wikimedia.org/T113868#1678818 (10ori) [03:05:30] 10MediaWiki-ResourceLoader, 6Performance-Team, 5Patch-For-Review: Fix intermittend ghost entries in FileModule 'fileHashes' data - https://phabricator.wikimedia.org/T111481#1678824 (10ori) I think there is a good chance that this is caused by {T113868}. But if that were true, this would happen regularly, and... [03:05:35] (03PS4) 10EBernhardson: Include additional analytics in Special:Search [core] - 10https://gerrit.wikimedia.org/r/240889 (https://phabricator.wikimedia.org/T113291) [03:09:00] (03PS1) 10Yoonghm: In PostgresSQL a) Temp tables are automatically deleted upon end of session b) Same temp table name hides existing table for current session [core] - 10https://gerrit.wikimedia.org/r/241489 [03:09:21] 10MediaWiki-ResourceLoader, 10MediaWiki-Unit-tests: ResourceLoaderModuleTest::testGetVersionHash is flaky - https://phabricator.wikimedia.org/T109394#1678832 (10ori) [03:10:35] Have you set up a phabricator account? [03:15:59] (03PS1) 10Niedzielski: Increase lead text shadow [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/241490 [03:17:03] (03CR) 10jenkins-bot: [V: 04-1] Increase lead text shadow [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/241490 (owner: 10Niedzielski) [03:19:10] yep [03:22:56] Have you decided which bug you want to work on? [03:26:21] 10PageImages: Thumbnail of the specific image is not created - https://phabricator.wikimedia.org/T113853#1678835 (10Comseong) Reproduced. Could you check it one more? It's not "missing" but "no prop", even though the image exists in the page. http://en.samarkandtour.org/index.php/Special:ApiSandbox#action=query&... [03:35:24] 10PageImages: Thumbnail of the specific image is not created - https://phabricator.wikimedia.org/T113853#1678836 (10Comseong) 5Invalid>3Open [03:37:37] 10MediaWiki-General-or-Unknown: Patrolling pages is having issues (working though clicking states failure) - https://phabricator.wikimedia.org/T25132#1678837 (10Billinghurst) 5Invalid>3Resolved a:3Billinghurst Long resolved by other processes. [03:58:54] (03PS3) 10EBernhardson: Add new fields to TestSearchSatisfaction [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/240924 (https://phabricator.wikimedia.org/T113291) [03:59:23] (03CR) 10jenkins-bot: [V: 04-1] Add new fields to TestSearchSatisfaction [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/240924 (https://phabricator.wikimedia.org/T113291) (owner: 10EBernhardson) [04:01:52] 3Discovery-Cirrus-Sprint, 5Patch-For-Review, 7WorkType-NewFunctionality: Add new fields to searchsatisfaction2 schema - https://phabricator.wikimedia.org/T113291#1678842 (10EBernhardson) Patch above adds all requested fields. It also goes a little bit further than requested: This adds wprov=srpw1_N to all se... [04:04:09] 10CirrusSearch, 6Discovery: Stemming highlights the wrong terms in search results - https://phabricator.wikimedia.org/T113838#1678844 (10Cpiral) [04:15:29] 6Discovery, 10Maps, 10Performance-Metrics-Dashboard, 3Discovery-Maps-Sprint, 3Wikipedia-Android-App: KPI - Identify maps traffic from Mobile App - https://phabricator.wikimedia.org/T113829#1678856 (10Ironholds_backup) So we have a phabricator task marked "urgent" not because solving it is urgent but beca... [04:16:05] 6Discovery, 10Maps, 10Performance-Metrics-Dashboard, 3Discovery-Maps-Sprint, 3Wikipedia-Android-App: KPI - Identify maps traffic from Mobile App - https://phabricator.wikimedia.org/T113829#1678857 (10Ironholds_backup) [04:16:29] 6Discovery, 10Maps, 10Performance-Metrics-Dashboard, 3Discovery-Maps-Sprint, 3Wikipedia-Android-App: KPI - Identify maps traffic from Mobile App - https://phabricator.wikimedia.org/T113829#1677023 (10Ironholds_backup) So my next comment would be; again, why Apps specifically? I.E. why does this need to b... [04:24:39] (03PS7) 10Brian Wolff: Use personalised tokens for logged-out users that have a session already [core] - 10https://gerrit.wikimedia.org/r/76458 (https://bugzilla.wikimedia.org/38417) (owner: 10Parent5446) [04:35:01] (03CR) 10EBernhardson: "I don't know if its better, but here is what i've done:" (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/237264 (https://phabricator.wikimedia.org/T86781) (owner: 10EBernhardson) [04:50:46] 10PageImages: Thumbnail of the specific image is not created - https://phabricator.wikimedia.org/T113853#1678860 (10Comseong) I started to look into database. I found follows at mw_categorylinks table. cl_from:2738 cl_to:Pages_with_broken_file_links cl_sortkey:RUKHABAD MAUSOLEUM When and why is the "Pages_with... [05:01:58] * ebernhardson looks around to figure out what changed and disabled uploading images to fake-commons inside vagrant [05:05:32] (03PS5) 10EBernhardson: Include additional analytics in Special:Search [core] - 10https://gerrit.wikimedia.org/r/240889 (https://phabricator.wikimedia.org/T113291) [05:14:45] (03Abandoned) 10Yoonghm: Update as per code quality [core] - 10https://gerrit.wikimedia.org/r/241458 (owner: 10Yoonghm) [05:15:26] (03Abandoned) 10Yoonghm: Fix "pg_send_query(): There are results on this connection..." [core] - 10https://gerrit.wikimedia.org/r/241357 (https://phabricator.wikimedia.org/T52091) (owner: 10Yoonghm) [05:15:36] (03PS1) 10Aaron Schulz: Optimized wfIsBadImage() redirect check [core] - 10https://gerrit.wikimedia.org/r/241491 [05:16:34] (03Abandoned) 10Yoonghm: Modify code due to code quality check [core] - 10https://gerrit.wikimedia.org/r/241488 (owner: 10Yoonghm) [05:18:21] (03PS1) 10BryanDavis: composer.json: alphabetize sections [core] - 10https://gerrit.wikimedia.org/r/241492 [05:30:14] (03PS1) 10BryanDavis: Alphabetize require section entries [vendor] - 10https://gerrit.wikimedia.org/r/241493 [05:30:14] 10MediaWiki-Email, 10MediaWiki-Extension-Requests, 6Collaboration-Team-Backlog, 10Echo, 7Privacy: Encrypt emails with GnuPG (GPG) - https://phabricator.wikimedia.org/T12453#1678866 (10Tgr) [05:30:16] (03PS1) 10BryanDavis: Update to monolog 1.17.1 [vendor] - 10https://gerrit.wikimedia.org/r/241494 [05:30:16] 10MediaWiki-Email: Create GPG wrapper library - https://phabricator.wikimedia.org/T109542#1678863 (10Tgr) 5Open>3Resolved a:3Tgr https://github.com/tgr/php-gpglib [05:30:18] (03PS2) 10Niedzielski: Increase lead text shadow [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/241490 [05:31:48] (03PS1) 10BryanDavis: composer.json: Bump Monolog to 1.17.1 [core] - 10https://gerrit.wikimedia.org/r/241495 [05:33:10] (03PS1) 10Yoonghm: For PostgreSQL database: a) Temp tables are automatically deleted upon end of session b) Same Temp table name hides existing table for current session [core] - 10https://gerrit.wikimedia.org/r/241496 [05:35:51] (03CR) 10jenkins-bot: [V: 04-1] composer.json: Bump Monolog to 1.17.1 [core] - 10https://gerrit.wikimedia.org/r/241495 (owner: 10BryanDavis) [05:51:44] (03Abandoned) 10Yoonghm: For PostgreSQL database: a) Temp tables are automatically deleted upon end of session b) Same Temp table name hides existing table for current session [core] - 10https://gerrit.wikimedia.org/r/241496 (owner: 10Yoonghm) [05:57:37] (03PS1) 10Yoonghm: Clear previously left-over PQresult before calling pg_get_result() [core] - 10https://gerrit.wikimedia.org/r/241497 [06:00:02] 10MediaWiki-Email, 10Librarization: Create GPG wrapper library - https://phabricator.wikimedia.org/T109542#1678868 (10Legoktm) [06:07:41] (03CR) 10Aaron Schulz: "Commit summary should explain what happens when they are not cleared." [core] - 10https://gerrit.wikimedia.org/r/241497 (owner: 10Yoonghm) [06:11:45] 10MediaWiki-extensions-Other: Some bluespice messages have grammar problems. - https://phabricator.wikimedia.org/T111606#1678871 (10Liuxinyu970226) [06:14:11] 10Wikimedia-General-or-Unknown: harmonize namespaces towards languages and projects - https://phabricator.wikimedia.org/T45934#1678881 (10Liuxinyu970226) [06:24:53] 10MediaWiki-Debug-Logger, 10Wikimedia-Logstash, 6operations: Set up a service IP for logstash - https://phabricator.wikimedia.org/T113104#1678882 (10bd808) The need for udp "stream" re-assembly for GELF is a major reason that I never bothered to try and get LVS setup in front of the Logstash cluster. The way... [06:32:45] (03PS1) 10Lilu: 1291 PermissionManager: Lockout of all users possible [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/241498 [06:34:45] (03CR) 10Yoonghm: "Otherwise, calling multiple doQuery() within a session generate message: "Call pg_get_result() until it returns FALSE"" [core] - 10https://gerrit.wikimedia.org/r/241497 (owner: 10Yoonghm) [06:38:15] Reedy: Another CS rule that we can disable after https://gerrit.wikimedia.org/r/#/c/241485/. Disabled at https://gerrit.wikimedia.org/r/#/c/241481/ [06:38:23] somebody merge please [06:41:42] (03PS2) 10Aaron Schulz: Clear previously left-over PQresult before calling pg_get_result() [core] - 10https://gerrit.wikimedia.org/r/241497 (https://phabricator.wikimedia.org/T52091) (owner: 10Yoonghm) [06:45:27] (03CR) 10jenkins-bot: [V: 04-1] Clear previously left-over PQresult before calling pg_get_result() [core] - 10https://gerrit.wikimedia.org/r/241497 (https://phabricator.wikimedia.org/T52091) (owner: 10Yoonghm) [06:52:24] (03PS1) 10Amire80: Make grammar data loadable as an RL module and usable in JS [core] - 10https://gerrit.wikimedia.org/r/241499 [06:52:26] (03CR) 10Legoktm: [C: 032] Add space after "//" to pass SpaceBeforeSingleLineComment sniff [core] - 10https://gerrit.wikimedia.org/r/241485 (owner: 10Polybuildr) [06:56:24] (03CR) 10jenkins-bot: [V: 04-1] Make grammar data loadable as an RL module and usable in JS [core] - 10https://gerrit.wikimedia.org/r/241499 (owner: 10Amire80) [06:58:38] (03CR) 10Yoonghm: "I do not understand the log in https://integration.wikimedia.org/ci/job/mediawiki-extensions-qunit/13324/console" [core] - 10https://gerrit.wikimedia.org/r/241497 (https://phabricator.wikimedia.org/T52091) (owner: 10Yoonghm) [06:59:21] 10MediaWiki-extensions-Translate, 5Patch-For-Review: Translation memory lost in Meta Wiki - https://phabricator.wikimedia.org/T113711#1678893 (10Nikerabbit) p:5Triage>3High [07:00:20] 10MediaWiki-extensions-Translate, 5Patch-For-Review: Translation memory lost in Meta Wiki - https://phabricator.wikimedia.org/T113711#1678894 (10Nikerabbit) a:3Nikerabbit I will schedule this for SWAT on Monday if nobody else does. [07:02:48] (03Merged) 10jenkins-bot: Add space after "//" to pass SpaceBeforeSingleLineComment sniff [core] - 10https://gerrit.wikimedia.org/r/241485 (owner: 10Polybuildr) [07:04:50] (03PS2) 10Amire80: Make grammar data loadable as an RL module and usable in JS [core] - 10https://gerrit.wikimedia.org/r/241499 [07:08:29] (03CR) 10jenkins-bot: [V: 04-1] Make grammar data loadable as an RL module and usable in JS [core] - 10https://gerrit.wikimedia.org/r/241499 (owner: 10Amire80) [07:09:23] 10MediaWiki-extensions-ContentTranslation: "null" is sometimes shown in language filters when going to the ContentTranslation Suggestions tab - https://phabricator.wikimedia.org/T113715#1678897 (10Nikerabbit) a:3santhosh Santhosh' ULS integration patch supposedly fixes this. [07:10:20] (03CR) 10Aaron Schulz: "recheck" [core] - 10https://gerrit.wikimedia.org/r/241497 (https://phabricator.wikimedia.org/T52091) (owner: 10Yoonghm) [07:11:21] (03CR) 10Legoktm: [C: 032] "Nice work :)" [core] - 10https://gerrit.wikimedia.org/r/241481 (owner: 10Polybuildr) [07:15:28] legoktm: Does the phpcs job run on gate-and-submit? [07:15:35] yes [07:16:01] hrmmmmmmm [07:16:03] https://integration.wikimedia.org/zuul/ [07:16:10] yeah.. I can't see it ther [07:16:12] *there [07:16:49] - name: ^.*-phpcs(-HEAD)?$ [07:16:49] files: [07:16:49] - '^.*\.(json|php|php5|phtml|inc|xml)$' [07:17:25] oh wtf [07:20:26] (03CR) 10Legoktm: Re-enable WhiteSpace.SpaceBeforeSingleLineComment sniff [core] - 10https://gerrit.wikimedia.org/r/241481 (owner: 10Polybuildr) [07:22:25] (03CR) 10Legoktm: [C: 032] Re-enable WhiteSpace.SpaceBeforeSingleLineComment sniff [core] - 10https://gerrit.wikimedia.org/r/241481 (owner: 10Polybuildr) [07:22:38] polybuildr: it's running now [07:23:58] (03PS3) 10Amire80: Make grammar data loadable as an RL module and usable in JS [core] - 10https://gerrit.wikimedia.org/r/241499 [07:25:52] legoktm: awesome [07:28:54] (03PS1) 10Amire80: WIP Reenable LineLength phpcs check [core] - 10https://gerrit.wikimedia.org/r/241501 (https://phabricator.wikimedia.org/T102614) [07:30:07] 10MediaWiki-Codesniffer, 10MediaWiki-General-or-Unknown: Figure out why PHPCS is unable to parse FormatMetadata.php - https://phabricator.wikimedia.org/T113871#1678902 (10Legoktm) 3NEW [07:32:03] (03Merged) 10jenkins-bot: Re-enable WhiteSpace.SpaceBeforeSingleLineComment sniff [core] - 10https://gerrit.wikimedia.org/r/241481 (owner: 10Polybuildr) [07:32:52] (03CR) 10jenkins-bot: [V: 04-1] WIP Reenable LineLength phpcs check [core] - 10https://gerrit.wikimedia.org/r/241501 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [07:38:51] 10MediaWiki-General-or-Unknown, 7Easy, 7JavaScript: Auto-collapsed templates displace anchor tag targets - https://phabricator.wikimedia.org/T110770#1678910 (10TTO) >>! In T110770#1615318, @Jdlrobson wrote: > We do this on MobileFrontend after collapsing sections. What code does that collapsing for Vector -... [07:41:29] (03CR) 10Yoonghm: "This bug was discovdred during automated testing of smw 2.2 using podtgresql." [core] - 10https://gerrit.wikimedia.org/r/241489 (owner: 10Yoonghm) [07:42:26] (03PS1) 10Amire80: Make lines short to pass phpcs in files under maintenance/ [core] - 10https://gerrit.wikimedia.org/r/241502 (https://phabricator.wikimedia.org/T102614) [07:42:58] (03CR) 10Yoonghm: "composer phpunit" [core] - 10https://gerrit.wikimedia.org/r/241489 (owner: 10Yoonghm) [07:46:36] (03PS1) 10Amire80: Make lines short to pass phpcs in Language.php [core] - 10https://gerrit.wikimedia.org/r/241503 (https://phabricator.wikimedia.org/T102614) [07:49:04] Can you have a "statement" over multiple lines in php docblocks? [07:49:43] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer: Creating non-item discussion pages should be disallowed - https://phabricator.wikimedia.org/T59827#1678913 (10matej_suchanek) [07:49:58] (03CR) 10Galorefitz: "Oh okay, so I only need to fix it for TS_ISO_8601? PNG metadata only uses one format? I wasn't sure of that, so I thought I may have to fi" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/239292 (https://phabricator.wikimedia.org/T58064) (owner: 10Galorefitz) [07:51:03] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer: Creating non-item discussion pages should be disallowed - https://phabricator.wikimedia.org/T59827#636372 (10matej_suchanek) FYI, now we use [[ https://www.wikidata.org/wiki/MediaWiki:Titleblacklist | TitleBlacklist ]] instead (also for... [07:52:24] (03PS1) 10Amire80: Make lines short to pass phpcs in profileinfo.php [core] - 10https://gerrit.wikimedia.org/r/241504 (https://phabricator.wikimedia.org/T102614) [07:53:14] (03PS2) 10Galorefitz: [WIP] Handle timezone specifiers in MWTimestamp [core] - 10https://gerrit.wikimedia.org/r/239292 (https://phabricator.wikimedia.org/T58064) [07:59:07] (03PS1) 10Amire80: Make lines short to pass phpcs in OutputPage.php [core] - 10https://gerrit.wikimedia.org/r/241505 (https://phabricator.wikimedia.org/T102614) [08:04:03] (03PS1) 10Amire80: Make lines short to pass phpcs in KafkaHandler.php [core] - 10https://gerrit.wikimedia.org/r/241506 (https://phabricator.wikimedia.org/T102614) [08:07:27] (03PS1) 10Amire80: Make lines short to pass phpcs in files under includes/resourceloader [core] - 10https://gerrit.wikimedia.org/r/241507 (https://phabricator.wikimedia.org/T102614) [08:11:02] (03PS1) 10Amire80: Make lines short to pass phpcs in files under includes/ [core] - 10https://gerrit.wikimedia.org/r/241508 (https://phabricator.wikimedia.org/T102614) [08:15:37] (03PS1) 10Amire80: Make lines short to pass phpcs in files under includes/db/ [core] - 10https://gerrit.wikimedia.org/r/241509 (https://phabricator.wikimedia.org/T102614) [08:52:35] (03PS1) 10Amire80: Update grammar rules and test for Ukrainian [core] - 10https://gerrit.wikimedia.org/r/241511 [09:10:39] 10MediaWiki-Watchlist, 10Wikidata, 5MW-1.26-release, 5WMF-deploy-2015-09-22_(1.26wmf24): [Task] Linker::formatComment should support comments that refer to another wiki. - https://phabricator.wikimedia.org/T111676#1678942 (10matej_suchanek) [09:10:43] 10MediaWiki-Special-pages, 10Wikidata, 6Wikisource: For the Wikisources, remove each languages Page: namespace from Special:UnconnectedPages - https://phabricator.wikimedia.org/T113444#1665123 (10Glaisher) [09:10:59] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3Wikidata-Sprint-2015-09-15: [Bug] Item links on normal wiki pages sometimes prepended by label (in a random language) - https://phabricator.wikimedia.org/T111346#1678946 (10matej_suchanek) [09:13:14] (03CR) 10TheDJ: [C: 032] Show the globally blocked range in block message [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/134043 (https://phabricator.wikimedia.org/T40367) (owner: 10Gerrit Patch Uploader) [09:13:37] (03Merged) 10jenkins-bot: Show the globally blocked range in block message [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/134043 (https://phabricator.wikimedia.org/T40367) (owner: 10Gerrit Patch Uploader) [09:14:13] 10MediaWiki-extensions-GlobalBlocking, 7Easy, 7I18n: MediaWiki:Globalblocking-block-intro should match MediaWiki:Blockiptext - https://phabricator.wikimedia.org/T20098#1678959 (10TheDJ) [09:14:14] 10MediaWiki-extensions-GlobalBlocking, 7Easy, 7I18n: MediaWiki:Globalblocking-blocked should tell the IP range - https://phabricator.wikimedia.org/T40367#1678952 (10TheDJ) 5Open>3Resolved a:3PiRSquared17 [09:19:53] (03CR) 10TheDJ: [C: 04-2] "This will not get merged without a proper explanation about why it should be merged... What problem is it solving ?" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/234912 (owner: 10Paladox) [09:22:25] (03CR) 10Paladox: "Hi tested this. Blue box still are shown." [core] - 10https://gerrit.wikimedia.org/r/241482 (https://phabricator.wikimedia.org/T112383) (owner: 10PleaseStand) [09:23:20] (03CR) 10TheDJ: renderer: Use NavigationPopups settings where available (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/137897 (https://bugzilla.wikimedia.org/64234) (owner: 10Prtksxna) [09:25:19] 10Wiki-Loves-Monuments-Database: Source links in the monuments database get too long and are truncated - https://phabricator.wikimedia.org/T112460#1678963 (10Multichill) [09:25:58] 10Wiki-Loves-Monuments-Database: Source links in the monuments database get too long and are truncated - https://phabricator.wikimedia.org/T112460#1635234 (10Multichill) I hope @jcrespo can answer your question JeanFred. [09:26:18] (03PS3) 10Toniher: [WIP] Adding a new magic word: SCOREPAGE [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/117599 [09:28:19] (03CR) 10Paladox: "It solves people who are on low speed broadband such as 0.5mb or 1mb to be able to watch a video." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/234912 (owner: 10Paladox) [09:29:33] (03CR) 10TheDJ: [C: 031] "OK in principle, but I suggest we wait a bit longer until things like: T113284 are settled a bit." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/240446 (https://phabricator.wikimedia.org/T109658) (owner: 10Brion VIBBER) [09:32:10] 10MediaWiki-General-or-Unknown, 10Wikimedia-Interwiki-links: Allow to specify on each project if a non-local interwiki should add an external link icon or not - https://phabricator.wikimedia.org/T76205#1678966 (10TTO) p:5Normal>3Lowest [09:32:54] 10MediaWiki-General-or-Unknown, 10Wikimedia-Interwiki-links: Allow to specify on each project if a non-local interwiki should add an external link icon or not - https://phabricator.wikimedia.org/T76205#1678971 (10TTO) Better to fix T20562, I think. No need for inconsistency. [09:34:21] (03PS4) 10TheDJ: Enable WebP uploads by default [core] - 10https://gerrit.wikimedia.org/r/221737 (https://phabricator.wikimedia.org/T27397) [09:34:39] (03CR) 10jenkins-bot: [V: 04-1] Enable WebP uploads by default [core] - 10https://gerrit.wikimedia.org/r/221737 (https://phabricator.wikimedia.org/T27397) (owner: 10TheDJ) [09:35:55] (03PS5) 10TheDJ: Enable WebP uploads by default [core] - 10https://gerrit.wikimedia.org/r/221737 (https://phabricator.wikimedia.org/T27397) [09:36:22] 10MediaWiki-extensions-Other: [DisableAccount] Write a script to migrate disabled accounts with DisableAccount to blocked account - https://phabricator.wikimedia.org/T109060#1678973 (10Glaisher) a:3Glaisher [09:41:41] (03CR) 10Paladox: "Missing css code for" [core] - 10https://gerrit.wikimedia.org/r/241482 (https://phabricator.wikimedia.org/T112383) (owner: 10PleaseStand) [09:43:37] 10Wiki-Loves-Monuments-Database: Source links in the monuments database get too long and are truncated - https://phabricator.wikimedia.org/T112460#1678983 (10jcrespo) > The effective maximum length of a VARCHAR in MySQL 5.0.3 and later is subject to the maximum > row size (65,535 bytes, which is shared among al... [09:44:12] (03PS1) 10Glaisher: Add script to migrate disabled accounts to blocked accounts [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/241512 [09:44:38] (03PS2) 10Glaisher: Add script to migrate disabled accounts to blocked accounts [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/241512 (https://phabricator.wikimedia.org/T109060) [09:49:27] (03CR) 10Paladox: "Missing css for .config-help-field-container" [core] - 10https://gerrit.wikimedia.org/r/231742 (owner: 10Ori.livneh) [09:50:57] (03PS1) 10Glaisher: Add missing 'action-disableaccount' i18n message [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/241513 [09:52:35] 10Wikimedia-Developer-Summit-2016: WikiDev16: Next generation video for Wikipedia and friends - https://phabricator.wikimedia.org/T112695#1678987 (10TheDJ) [09:54:27] 10Wikimedia-Developer-Summit-2016: WikiDev16: Next generation video for Wikipedia and friends - https://phabricator.wikimedia.org/T112695#1642926 (10TheDJ) [09:57:51] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Story: [Story] improve Special:UnconnectedPages - https://phabricator.wikimedia.org/T102816#1678991 (10matej_suchanek) [10:13:25] 6Design Research Backlog, 10Wikimedia-Developer-Summit-2016, 7Mobile: Enable off line editing (particularly for mobile) to support people with intermittent internet access - https://phabricator.wikimedia.org/T106898#1678995 (10TheDJ) Slightly related to offline editing might be this ticket, for local autosav... [10:46:59] (03PS1) 10Paladox: Fix path to config.js for mw-config [core] - 10https://gerrit.wikimedia.org/r/241515 [10:49:55] (03CR) 10Paladox: "Dosent need css but dosent seem js is being applied to the page since display:inline and display:block are not being applied to css. when " [core] - 10https://gerrit.wikimedia.org/r/241482 (https://phabricator.wikimedia.org/T112383) (owner: 10PleaseStand) [10:51:54] 10MediaWiki-General-or-Unknown, 10MediaWiki-Installer, 10MediaWiki-ResourceLoader, 10Vector, 5Patch-For-Review: mw-config now dosent show any styles - https://phabricator.wikimedia.org/T113843#1679008 (10Paladox) [10:52:06] 10MediaWiki-API, 10MediaWiki-Documentation, 7Documentation: Undocumented usage of generator=revisions - https://phabricator.wikimedia.org/T113876#1679009 (10Lahwaacz) 3NEW [10:52:09] 10MediaWiki-Installer, 10MediaWiki-ResourceLoader, 10Vector, 5Patch-For-Review: mw-config now dosent show any styles - https://phabricator.wikimedia.org/T113843#1677393 (10Paladox) [10:53:31] 10MediaWiki-Installer, 5Patch-For-Review: "Select language" blue boxes are shown on mw-config - https://phabricator.wikimedia.org/T112383#1679018 (10Paladox) It seems js is broken since help button is hidden and display: inline isent being applied causing help to be hidden. also display none isent being applie... [10:58:22] 10MediaWiki-Gallery, 6Multimedia: Change size for gallery previews for sv.wp to 150px - https://phabricator.wikimedia.org/T113877#1679019 (10Josve05a) 3NEW [11:03:24] 10MediaWiki-Installer, 10MediaWiki-ResourceLoader, 5Patch-For-Review: "Select language" blue boxes are shown on mw-config - https://phabricator.wikimedia.org/T112383#1679027 (10Paladox) [11:08:33] (03PS34) 10TheDJ: Improve live loading and ResourceLoader behavior [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/172421 (https://phabricator.wikimedia.org/T74675) [11:09:49] (03PS7) 10TheDJ: Turn MwEmbed loaderscripts into modules [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/172556 (https://phabricator.wikimedia.org/T74675) [11:49:34] (03PS6) 10Paladox: Fix user menu issue [skins/Blueprint] - 10https://gerrit.wikimedia.org/r/239878 (https://phabricator.wikimedia.org/T110844) [11:49:39] (03CR) 10jenkins-bot: [V: 04-1] Fix user menu issue [skins/Blueprint] - 10https://gerrit.wikimedia.org/r/239878 (https://phabricator.wikimedia.org/T110844) (owner: 10Paladox) [11:49:53] (03CR) 10Paladox: "Testing to see if jshint is fixed yet." [skins/Blueprint] - 10https://gerrit.wikimedia.org/r/239878 (https://phabricator.wikimedia.org/T110844) (owner: 10Paladox) [11:57:06] Does the WMF offer summer internships for volunteer contributors? (And if there's a better channel to ask about this, please tell me which) [11:59:15] 10MediaWiki-Installer: Inatallation script: Allow to set page titles etc. to lowercase-allowed - https://phabricator.wikimedia.org/T113879#1679044 (10Purodha) 3NEW [12:09:29] (03CR) 10TheDJ: Improve live loading and ResourceLoader behavior (034 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/172421 (https://phabricator.wikimedia.org/T74675) (owner: 10TheDJ) [12:09:45] 10PageImages: Thumbnail of the specific image is not created - https://phabricator.wikimedia.org/T113853#1679051 (10Comseong) Since I have looked into database, some more strange things are being discovered. When I use this API(/api.php?action=query&prop=revisions&rvprop=content&format=json&generator=categorymem... [12:09:54] (03PS35) 10TheDJ: Improve live loading and ResourceLoader behavior [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/172421 (https://phabricator.wikimedia.org/T74675) [12:10:28] (03CR) 10jenkins-bot: [V: 04-1] Improve live loading and ResourceLoader behavior [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/172421 (https://phabricator.wikimedia.org/T74675) (owner: 10TheDJ) [12:13:58] (03PS3) 10Paladox: Fix sql errors [extensions/DownloadCounter] - 10https://gerrit.wikimedia.org/r/239210 (https://phabricator.wikimedia.org/T70968) [12:14:38] (03PS4) 10Paladox: Fix sql errors [extensions/DownloadCounter] - 10https://gerrit.wikimedia.org/r/239210 (https://phabricator.wikimedia.org/T70968) [12:15:19] (03PS5) 10Paladox: Fix sql errors [extensions/DownloadCounter] - 10https://gerrit.wikimedia.org/r/239210 (https://phabricator.wikimedia.org/T70968) [12:15:42] (03PS6) 10Paladox: Fix sql errors [extensions/DownloadCounter] - 10https://gerrit.wikimedia.org/r/239210 (https://phabricator.wikimedia.org/T70968) [12:17:26] (03PS7) 10Paladox: Fix sql errors [extensions/DownloadCounter] - 10https://gerrit.wikimedia.org/r/239210 (https://phabricator.wikimedia.org/T70968) [12:26:13] (03PS36) 10TheDJ: Improve live loading and ResourceLoader behavior [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/172421 (https://phabricator.wikimedia.org/T74675) [12:26:44] (03CR) 10jenkins-bot: [V: 04-1] Improve live loading and ResourceLoader behavior [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/172421 (https://phabricator.wikimedia.org/T74675) (owner: 10TheDJ) [12:28:26] 10MediaWiki-Gallery, 6Multimedia: Change size for gallery previews for sv.wp to 150px - https://phabricator.wikimedia.org/T113877#1679060 (10Krenair) Unless there's already a setting for this, you need one ticket against #MediaWiki-Gallery to get a setting created to allow for it, and a separate ticket against... [12:29:09] (03PS1) 10Amire80: Update Ukrainian grammar rules and tests [core] - 10https://gerrit.wikimedia.org/r/241517 [12:29:11] (03PS1) 10Amire80: Remove an unnecessary condition from Ukrainian grammar rules [core] - 10https://gerrit.wikimedia.org/r/241518 [12:37:57] 10grrrit-wm: Add npm test command to grrrit and have it to lint js/yaml files - https://phabricator.wikimedia.org/T95891#1679061 (10hashar) grrrit folks any clue how to write a npm based test that lints the yaml files in Grrrit? I would like to phase out the python based Jenkins job 'yamllint'. [12:41:57] (03PS10) 10Hashar: Update CheckUser tests [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/225149 (owner: 10Paladox) [12:42:20] (03CR) 10Hashar: "check experimental" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/225149 (owner: 10Paladox) [12:43:27] (03PS4) 10Paladox: Make DatabaseBz2 an abstract class [extensions/Offline] - 10https://gerrit.wikimedia.org/r/239176 (https://phabricator.wikimedia.org/T112398) [12:43:54] (03PS5) 10Paladox: Make DatabaseBz2 an abstract class [extensions/Offline] - 10https://gerrit.wikimedia.org/r/239176 (https://phabricator.wikimedia.org/T112398) [12:44:31] 10grrrit-wm: Add npm test command to grrrit and have it to lint js/yaml files - https://phabricator.wikimedia.org/T95891#1679064 (10polybuildr) You're looking for some configuration of npm modules such that when you run `npm test`, the YAML files get linted? [12:45:11] (03CR) 10Paladox: "One of the files were too big to do so did some. I will upload a patch after this to do some more in that file since the classes need to b" [extensions/Offline] - 10https://gerrit.wikimedia.org/r/239176 (https://phabricator.wikimedia.org/T112398) (owner: 10Paladox) [12:46:54] (03CR) 10Paladox: "@Hashar could you recheck this and merge if it passes please. jenkings keep failing because some php code creates a different sql table to" [extensions/SacredText] - 10https://gerrit.wikimedia.org/r/239173 (https://phabricator.wikimedia.org/T112400) (owner: 10Paladox) [12:48:38] 10MediaWiki-Installer: Installation script: Allow to set page titles etc. to 'lowercase-allowed' - https://phabricator.wikimedia.org/T113879#1679065 (10Purodha) [12:48:52] (03CR) 10Paladox: [C: 031] "Passes" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/225149 (owner: 10Paladox) [12:49:52] (03CR) 10TheDJ: "The test doesn't fail for me locally..." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/172421 (https://phabricator.wikimedia.org/T74675) (owner: 10TheDJ) [12:50:40] (03PS11) 10Hashar: Add jshint and jscs test to npm [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/225149 (owner: 10Paladox) [12:51:15] (03PS6) 10Paladox: Update ConfirmAccountUpdater.hooks, Add missing sql [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/237711 [12:54:01] 10MediaWiki-extensions-ContentTranslation: broken wikilinks in source text column - https://phabricator.wikimedia.org/T113880#1679068 (10Laotinant) 3NEW [12:54:37] 10grrrit-wm: Add npm test command to grrrit and have it to lint js/yaml files - https://phabricator.wikimedia.org/T95891#1679075 (10polybuildr) If that's what you're looking for, [[ https://www.npmjs.com/package/js-yaml | js-yaml ]] is a very easy-to-use node module. Running `js-yaml file.yaml` prints out the J... [12:54:53] (03CR) 10Paladox: "@Hashar please recheck this and merge if it passes." [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/236207 (owner: 10Paladox) [12:55:35] (03PS12) 10Hashar: Add jshint and jscs test to npm [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/225149 (owner: 10Paladox) [12:56:32] (03CR) 10Hashar: "Removed most of the things in .jshintignore it is now:" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/225149 (owner: 10Paladox) [12:58:54] 10MediaWiki-General-or-Unknown: The messages panel cannot be closed anymore - https://phabricator.wikimedia.org/T113881#1679076 (10Nnemo) 3NEW [12:59:10] (03PS13) 10Hashar: Add jshint and jscs test to npm [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/225149 (https://phabricator.wikimedia.org/T63589) (owner: 10Paladox) [13:00:17] (03CR) 10Paladox: Add jshint and jscs test to npm (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/225149 (https://phabricator.wikimedia.org/T63589) (owner: 10Paladox) [13:01:45] (03CR) 10Hashar: Add jshint and jscs test to npm (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/225149 (https://phabricator.wikimedia.org/T63589) (owner: 10Paladox) [13:02:12] (03CR) 10Hashar: [C: 032] "00:00:26.955 Running "jshint:all" (jshint) task" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/225149 (https://phabricator.wikimedia.org/T63589) (owner: 10Paladox) [13:03:00] 10MediaWiki-extensions-CheckUser, 5Patch-For-Review: CheckUser should pass jshint - https://phabricator.wikimedia.org/T63589#1679086 (10hashar) https://gerrit.wikimedia.org/r/#/c/225149/ add the npm integration https://gerrit.wikimedia.org/r/#/c/225182/ makes it voting [13:04:18] (03Merged) 10jenkins-bot: Add jshint and jscs test to npm [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/225149 (https://phabricator.wikimedia.org/T63589) (owner: 10Paladox) [13:04:58] (03CR) 10Paladox: "Thanks." [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/225149 (https://phabricator.wikimedia.org/T63589) (owner: 10Paladox) [13:07:30] (03PS1) 10Amire80: Make lines short to pass phpcs in files under includes/api/ [core] - 10https://gerrit.wikimedia.org/r/241520 (https://phabricator.wikimedia.org/T102614) [13:11:46] 10MediaWiki-Page-editing, 7JavaScript, 7Technical-Debt: Live Preview adds an empty "in other languages" section in Vector - https://phabricator.wikimedia.org/T113882#1679093 (10Ciencia_Al_Poder) 3NEW [13:12:17] 10MediaWiki-Page-editing, 7JavaScript, 7Technical-Debt: Live Preview adds an empty "in other languages" section in Vector - https://phabricator.wikimedia.org/T113882#1679101 (10Ciencia_Al_Poder) [13:12:19] 10MediaWiki-Page-editing, 7JavaScript, 7Tracking: Live preview (requires JavaScript) feature bugs (tracking) - https://phabricator.wikimedia.org/T41272#1679100 (10Ciencia_Al_Poder) [13:13:16] (03PS1) 10Amire80: Make lines short to pass phpcs in files in ParserOutput.php [core] - 10https://gerrit.wikimedia.org/r/241521 (https://phabricator.wikimedia.org/T102614) [13:14:04] (03PS20) 10Paladox: Add php code sniffer to SyntaxHighlight_GeSHi [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/225034 [13:14:56] (03CR) 10Paladox: "@Hashar please recheck." [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/225034 (owner: 10Paladox) [13:15:11] (03CR) 10Hashar: "recheck" [skins/Slate] - 10https://gerrit.wikimedia.org/r/229173 (owner: 10Paladox) [13:16:08] (03PS1) 10Paladox: Registered users should only be able to v+1 not v+2 [extensions/SyntaxHighlight_GeSHi] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/241522 [13:16:46] (03CR) 10Paladox: [V: 032] Add php code sniffer to SyntaxHighlight_GeSHi [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/225034 (owner: 10Paladox) [13:16:56] (03CR) 10jenkins-bot: [V: 04-1] Make lines short to pass phpcs in files in ParserOutput.php [core] - 10https://gerrit.wikimedia.org/r/241521 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [13:16:59] (03CR) 10Paladox: Add php code sniffer to SyntaxHighlight_GeSHi [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/225034 (owner: 10Paladox) [13:17:06] Where can I find integration/slave-scripts ? [13:19:48] 10MediaWiki-API, 10MediaWiki-Documentation, 7Documentation: Undocumented usage of generator=revisions - https://phabricator.wikimedia.org/T113876#1679104 (10Anomie) > # It is supposed to be possible to use the revisions module as a generator since 1.25, but this use case is not documented anywhere. It's doc... [13:20:20] (03PS15) 10Paladox: Add support for new tests in Jenkins [extensions/Theme] - 10https://gerrit.wikimedia.org/r/224943 [13:21:14] (03PS16) 10Paladox: Add support for new tests in Jenkins [extensions/Theme] - 10https://gerrit.wikimedia.org/r/224943 [13:22:42] (03CR) 10Paladox: ".js and less are being updated in separate patch so this can be merged. since the other ones include updates from vector so much bigger ch" [skins/Slate] - 10https://gerrit.wikimedia.org/r/229173 (owner: 10Paladox) [13:22:45] 10MediaWiki-General-or-Unknown: The messages panel cannot be closed anymore - https://phabricator.wikimedia.org/T113881#1679076 (10Nnemo) I have Safari on iOS 8.2 on an iPad in landscape, with the reading list open on the left. [13:23:17] (03PS2) 10Amire80: Make lines short to pass phpcs in files in ParserOutput.php [core] - 10https://gerrit.wikimedia.org/r/241521 (https://phabricator.wikimedia.org/T102614) [13:23:39] (03CR) 10Paladox: "Oh yes I updated some in this patch since less needed to be updated since in one of the .js files a code was removed and instead added to " [skins/Slate] - 10https://gerrit.wikimedia.org/r/229173 (owner: 10Paladox) [13:23:56] (03CR) 10Paladox: "These updates come from vector so should work." [skins/Slate] - 10https://gerrit.wikimedia.org/r/229173 (owner: 10Paladox) [13:25:27] 10MediaWiki-General-or-Unknown: The messages panel cannot be closed anymore - https://phabricator.wikimedia.org/T113881#1679108 (10Nnemo) [13:25:50] (03PS1) 10Polybuildr: Use `npm test` to lint YAML [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/241523 (https://phabricator.wikimedia.org/T95891) [13:25:55] 10MediaWiki-General-or-Unknown: The messages panel cannot be closed anymore - https://phabricator.wikimedia.org/T113881#1679076 (10Nnemo) I expect to have a way to close the messages panel. [13:25:58] 10MediaWiki-extensions-CheckUser: Convert CheckUser to use extension registration - https://phabricator.wikimedia.org/T87891#1679114 (10Paladox) [13:26:45] (03PS3) 10Amire80: Bidi-isolate user right name code on Special:ListGroupRights [core] - 10https://gerrit.wikimedia.org/r/159684 [13:29:29] (03PS39) 10Paladox: Add extensions.json, empty PHP entry point [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210176 (https://phabricator.wikimedia.org/T87981) [13:29:31] 10MediaWiki-API, 10MediaWiki-Documentation, 7Documentation: Undocumented usage of generator=revisions - https://phabricator.wikimedia.org/T113876#1679117 (10Ciencia_Al_Poder) I was expecting it could feed other queries like information about users that edit a given page, but that doesn't seem to be the case:... [13:30:44] 10grrrit-wm, 5Patch-For-Review: Add npm test command to grrrit and have it to lint js/yaml files - https://phabricator.wikimedia.org/T95891#1679119 (10polybuildr) The project was already using `js-yaml` as a dependency, so I gave this a shot by putting in a `js-yaml config.yaml` as the `npm test` script. [13:31:26] (03PS1) 10Paladox: Change message timedmedia-desc to timedmediahandler-desc [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/241524 [13:32:41] (03PS5) 10Reedy: [DO NOT MERGE] Re-enable all phpcs rules [core] - 10https://gerrit.wikimedia.org/r/241345 [13:35:46] (03CR) 10Polybuildr: [C: 04-1] "Just checked, this doesn't work unless you have js-yaml installed globally." [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/241523 (https://phabricator.wikimedia.org/T95891) (owner: 10Polybuildr) [13:36:27] (03CR) 10jenkins-bot: [V: 04-1] [DO NOT MERGE] Re-enable all phpcs rules [core] - 10https://gerrit.wikimedia.org/r/241345 (owner: 10Reedy) [13:36:47] (03CR) 10Paladox: "Module mw.TimedText.loader does not exist looking throught the hooks file there is no module called that." (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/172421 (https://phabricator.wikimedia.org/T74675) (owner: 10TheDJ) [13:37:09] (03CR) 10Anomie: "You've also got 8 changes in here that are not within the scope of the linked task: it says "Line length should not be more than 100 chara" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/241520 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [13:38:27] (03PS1) 10TheDJ: Remove duplicate definition of mw.mergeConfig [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/241525 [13:40:09] 10MediaWiki-API, 10MediaWiki-Documentation, 7Documentation: Undocumented usage of generator=revisions - https://phabricator.wikimedia.org/T113876#1679123 (10Anomie) User generators do not exist. See {T16027} for the feature request. [13:40:20] 10MediaWiki-Interface, 7I18n, 7Tracking: Interface messages needing rewording or documentation and other issues with existing messages (tracking) - https://phabricator.wikimedia.org/T40638#1679125 (10MarcoAurelio) I wonder if it would be worth changing this tracking bug into a Phabricator project. What do yo... [13:40:35] (03CR) 10Polybuildr: "Okay, it does work. My bad." [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/241523 (https://phabricator.wikimedia.org/T95891) (owner: 10Polybuildr) [13:41:59] (03CR) 10TheDJ: "There is such a module, it's just dynamically created by MwEmbedSupport" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/172421 (https://phabricator.wikimedia.org/T74675) (owner: 10TheDJ) [13:42:05] polybuildr: You sound like Paladox [13:42:06] xD [13:43:27] Reedy: I made a stupid mistake and so I CR-1ed my own patch because I thought it didn't work. :P [13:43:44] But it turns out it does work! :P [13:43:55] (03CR) 10Paladox: "Oh then that might be the reason the problem is showing. Because the module isent created using the resource modules setting in the hooks " [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/172421 (https://phabricator.wikimedia.org/T74675) (owner: 10TheDJ) [13:44:21] (03CR) 10Paladox: "Maybe add it using the resource module setting instead of dynamically." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/172421 (https://phabricator.wikimedia.org/T74675) (owner: 10TheDJ) [13:45:13] (03PS2) 10Paladox: Fix jquery warnings [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/240741 [13:46:27] (03CR) 10Paladox: "jslint errors have been fixed." [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/240741 (owner: 10Paladox) [13:54:26] (03CR) 10Hashar: "Ah that is not so hard after all :-}" [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/241523 (https://phabricator.wikimedia.org/T95891) (owner: 10Polybuildr) [13:54:55] 10grrrit-wm, 5Patch-For-Review: Add npm test command to grrrit and have it to lint js/yaml files - https://phabricator.wikimedia.org/T95891#1679126 (10hashar) Whatever works :-} Seems using the already provided js-yaml will do. Thank you! [13:55:28] (03CR) 10Amire80: "I did wrap a few lines that weren't longer than 100 for consistency with the lines before or after them." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/241520 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [13:56:10] (03CR) 10Bartosz Dziewoński: [C: 04-1] Adjust MediaWiki images that have been renamed (031 comment) [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/240876 (https://phabricator.wikimedia.org/T113655) (owner: 10Paladox) [13:56:54] (03CR) 10Paladox: [C: 032] "Tested seems to work." [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/241348 (https://phabricator.wikimedia.org/T113183) (owner: 10Paladox) [13:57:14] (03CR) 10Paladox: [C: 032] "Not tested but in metrolook it works." [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/241350 (https://phabricator.wikimedia.org/T113183) (owner: 10Paladox) [13:57:21] (03Merged) 10jenkins-bot: Set $wgMetrolookFeatures in extension.json [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/241348 (https://phabricator.wikimedia.org/T113183) (owner: 10Paladox) [13:57:43] (03Merged) 10jenkins-bot: Set $wgCollapsibleVectorFeatures in extension.json [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/241350 (https://phabricator.wikimedia.org/T113183) (owner: 10Paladox) [13:58:15] 10MediaWiki-extensions-CollapsibleVector, 10MediaWiki-skins-Metrolook, 10WikiEditor: Add array_plus_2d - https://phabricator.wikimedia.org/T113183#1679131 (10Paladox) [13:58:22] 10MediaWiki-extensions-CollapsibleVector, 10MediaWiki-skins-Metrolook, 10WikiEditor: Add array_plus_2d - https://phabricator.wikimedia.org/T113183#1679133 (10Paladox) 5Open>3Resolved [14:00:06] 10MediaWiki-API, 10MediaWiki-Documentation, 7Documentation: Undocumented usage of generator=revisions - https://phabricator.wikimedia.org/T113876#1679136 (10Lahwaacz) > The last, https://wiki.archlinux.org/api.php?action=query&generator=revisions&titles=Main%20page, does not give an empty result. To be more... [14:01:02] (03PS3) 10Martineznovo: [WIP] Version 1.9: AJAX functions rewritten as an API module [extensions/LinkSuggest] - 10https://gerrit.wikimedia.org/r/239675 (owner: 10Jack Phoenix) [14:01:04] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Version 1.9: AJAX functions rewritten as an API module [extensions/LinkSuggest] - 10https://gerrit.wikimedia.org/r/239675 (owner: 10Jack Phoenix) [14:01:58] (03PS8) 10Paladox: Adjust MediaWiki images that have been renamed [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/240876 (https://phabricator.wikimedia.org/T113655) [14:02:01] (03CR) 10jenkins-bot: [V: 04-1] Adjust MediaWiki images that have been renamed [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/240876 (https://phabricator.wikimedia.org/T113655) (owner: 10Paladox) [14:02:35] (03PS9) 10Paladox: Adjust MediaWiki images that have been renamed [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/240876 (https://phabricator.wikimedia.org/T113655) [14:02:49] 10Wikimedia-General-or-Unknown: PrivateSettings.php should be in a repo - https://phabricator.wikimedia.org/T69818#1679141 (10Reedy) a:5Reedy>3None [14:03:36] (03PS1) 10Polybuildr: Fix indentation in config.yaml.sample [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/241527 [14:03:54] (03CR) 10Paladox: "Ok done." [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/240876 (https://phabricator.wikimedia.org/T113655) (owner: 10Paladox) [14:04:04] (03PS2) 10Polybuildr: Use `npm test` to lint YAML [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/241523 (https://phabricator.wikimedia.org/T95891) [14:05:01] (03CR) 10Martineznovo: "My pleasure :) this one was easy. I've even enabled strict mode on the script without issues" [extensions/LinkSuggest] - 10https://gerrit.wikimedia.org/r/239675 (owner: 10Jack Phoenix) [14:05:48] 10Wikimedia-General-or-Unknown: Private repository should be pushed to somewhere remote - https://phabricator.wikimedia.org/T69818#1679145 (10Krenair) [14:06:37] (03CR) 10Reedy: Make lines short to pass phpcs in files under includes/api/ (031 comment) [core] - 10https://gerrit.wikimedia.org/r/241520 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [14:07:11] (03CR) 10Reedy: [C: 032] Make lines short to pass phpcs in Language.php [core] - 10https://gerrit.wikimedia.org/r/241503 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [14:12:51] (03PS4) 10Martineznovo: [WIP] Version 1.9: AJAX functions rewritten as an API module [extensions/LinkSuggest] - 10https://gerrit.wikimedia.org/r/239675 (owner: 10Jack Phoenix) [14:14:30] (03CR) 10Bartosz Dziewoński: [C: 032] Adjust MediaWiki images that have been renamed [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/240876 (https://phabricator.wikimedia.org/T113655) (owner: 10Paladox) [14:14:33] (03PS2) 10Paladox: Clean up code a bit [extensions/PipeEscape] - 10https://gerrit.wikimedia.org/r/240870 [14:14:54] (03PS16) 10EBernhardson: Enable communication with multiple datacenters [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/237264 (https://phabricator.wikimedia.org/T86781) [14:15:34] (03CR) 10jenkins-bot: [V: 04-1] Enable communication with multiple datacenters [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/237264 (https://phabricator.wikimedia.org/T86781) (owner: 10EBernhardson) [14:15:48] (03PS3) 10Cscott: Hook up npm-travis. [extensions/Collection/OfflineContentGenerator/zim_renderer] - 10https://gerrit.wikimedia.org/r/241369 [14:15:50] (03PS3) 10Cscott: Add node 4.1 to travis test targets. [extensions/Collection/OfflineContentGenerator/zim_renderer] - 10https://gerrit.wikimedia.org/r/241368 [14:17:11] (03CR) 10Reedy: [C: 04-1] Update ConfirmAccountUpdater.hooks, Add missing sql (035 comments) [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/237711 (owner: 10Paladox) [14:17:24] (03Merged) 10jenkins-bot: Make lines short to pass phpcs in Language.php [core] - 10https://gerrit.wikimedia.org/r/241503 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [14:17:26] (03Merged) 10jenkins-bot: Adjust MediaWiki images that have been renamed [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/240876 (https://phabricator.wikimedia.org/T113655) (owner: 10Paladox) [14:18:09] 10MediaWiki-Gallery, 6Multimedia: Change size for gallery previews for sv.wp to 150px - https://phabricator.wikimedia.org/T113877#1679154 (10matmarex) The task to implement the ability to change the default image size in is T3340. Unfortunately it is currently impossible. [14:18:15] 7Design, 10MediaWiki-Gallery, 10MediaWiki-Parser: Size thumbnails in galleries according to user preferences - https://phabricator.wikimedia.org/T3340#54890 (10matmarex) [14:18:16] 10MediaWiki-Gallery, 6Multimedia: Change size for gallery previews for sv.wp to 150px - https://phabricator.wikimedia.org/T113877#1679156 (10matmarex) [14:18:36] 10Wikimedia-Site-Requests: Change size for gallery previews for sv.wp to 150px - https://phabricator.wikimedia.org/T113877#1679158 (10matmarex) 5Open>3stalled [14:19:10] (03PS2) 10Reedy: Make lines short to pass phpcs in KafkaHandler.php [core] - 10https://gerrit.wikimedia.org/r/241506 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [14:19:13] (03CR) 10Paladox: "Thanks." [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/240876 (https://phabricator.wikimedia.org/T113655) (owner: 10Paladox) [14:19:15] (03CR) 10Reedy: [C: 032] Make lines short to pass phpcs in KafkaHandler.php [core] - 10https://gerrit.wikimedia.org/r/241506 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [14:19:57] 10MediaWiki-skins-Metrolook, 10Vector, 7Browser-Support-Internet-Explorer: Watchlist icon does not spin on internet explorer - https://phabricator.wikimedia.org/T113849#1679163 (10matmarex) [14:20:18] 10MediaWiki-extensions-OpenStackManager, 10Continuous-Integration-Infrastructure: OpenStackManager fails the mwext-testextension-zend test - https://phabricator.wikimedia.org/T113655#1679164 (10Paladox) 5Open>3Resolved [14:29:18] 10Wikimedia-Developer-Summit-2016: The end of shared hosting support? - https://phabricator.wikimedia.org/T113210#1679168 (10Anomie) >>! In T113210#1678303, @ssastry wrote: > But, I wanted to at least clarify that there are good reasons why some functionality (like Parsoid) will never get support in shared hosti... [14:30:01] (03Merged) 10jenkins-bot: Make lines short to pass phpcs in KafkaHandler.php [core] - 10https://gerrit.wikimedia.org/r/241506 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [14:30:30] 10Wikimedia-Site-Requests: Change size for gallery previews for sv.wp to 150px - https://phabricator.wikimedia.org/T113877#1679170 (10Hangsna) @matmarex Are you sure that marking is correct? We are not discussing changing it for individual users, its a discussion about changing it in LocalSettings for a specific... [14:36:11] 10Wikimedia-Site-Requests: Change size for gallery previews for sv.wp to 150px - https://phabricator.wikimedia.org/T113877#1679175 (10matmarex) 5stalled>3Open Whoops, I'm sorry, it seems that it is indeed possible to set it for the whole wiki using `$wgGalleryOptions`. I wasn't aware that this option exists.... [14:36:20] 7Design, 10MediaWiki-Gallery, 10MediaWiki-Parser: Size thumbnails in galleries according to user preferences - https://phabricator.wikimedia.org/T3340#1679178 (10matmarex) [14:36:21] 10Wikimedia-Site-Requests: Change size for gallery previews for sv.wp to 150px - https://phabricator.wikimedia.org/T113877#1679177 (10matmarex) [14:37:30] 10MediaWiki-Installer: Installation script: Allow $wgCapitalLinks to be set to false - https://phabricator.wikimedia.org/T113879#1679179 (10Reedy) p:5Triage>3Normal [14:39:35] (03PS2) 10Reedy: Make lines short to pass phpcs in OutputPage.php [core] - 10https://gerrit.wikimedia.org/r/241505 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [14:39:40] (03CR) 10Reedy: [C: 032] Make lines short to pass phpcs in OutputPage.php [core] - 10https://gerrit.wikimedia.org/r/241505 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [14:40:13] (03CR) 10Paladox: "@Reedy I will do a follow-up that will remove some duplicate files that are already added by confirmaccount." (031 comment) [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/237711 (owner: 10Paladox) [14:40:26] Doesn't mean I'm gonna merge itt [14:41:19] (03CR) 10Paladox: Update ConfirmAccountUpdater.hooks, Add missing sql (032 comments) [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/237711 (owner: 10Paladox) [14:41:57] (03PS7) 10Paladox: Update ConfirmAccountUpdater.hooks, Add missing sql [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/237711 [14:42:48] (03PS2) 10Reedy: composer.json: alphabetize sections [core] - 10https://gerrit.wikimedia.org/r/241492 (owner: 10BryanDavis) [14:42:55] (03CR) 10Reedy: [C: 032] composer.json: alphabetize sections [core] - 10https://gerrit.wikimedia.org/r/241492 (owner: 10BryanDavis) [14:43:41] (03PS2) 10Reedy: Optimized wfIsBadImage() redirect check [core] - 10https://gerrit.wikimedia.org/r/241491 (owner: 10Aaron Schulz) [14:43:46] (03CR) 10Reedy: [C: 032] Optimized wfIsBadImage() redirect check [core] - 10https://gerrit.wikimedia.org/r/241491 (owner: 10Aaron Schulz) [14:49:03] (03CR) 10Reedy: [C: 032] Add missing 'action-disableaccount' i18n message [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/241513 (owner: 10Glaisher) [14:49:18] (03Merged) 10jenkins-bot: Make lines short to pass phpcs in OutputPage.php [core] - 10https://gerrit.wikimedia.org/r/241505 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [14:51:38] (03CR) 10Reedy: [C: 032] Alphabetize require section entries [vendor] - 10https://gerrit.wikimedia.org/r/241493 (owner: 10BryanDavis) [14:55:41] 10MediaWiki-API, 10MediaWiki-Documentation, 7Documentation: Undocumented usage of generator=revisions - https://phabricator.wikimedia.org/T113876#1679183 (10Lahwaacz) All in all, there may just be a missing module like `list=allrevisions` to complete the functionality of `prop=revisions`, `prop=deletedrevisi... [14:57:20] I seem to have numerous dead repos checked out [14:57:42] (03CR) 10Brian Wolff: [WIP] Handle timezone specifiers in MWTimestamp (032 comments) [core] - 10https://gerrit.wikimedia.org/r/239292 (https://phabricator.wikimedia.org/T58064) (owner: 10Galorefitz) [14:57:53] (03CR) 10Brian Wolff: [WIP] Handle timezone specifiers in MWTimestamp (031 comment) [core] - 10https://gerrit.wikimedia.org/r/239292 (https://phabricator.wikimedia.org/T58064) (owner: 10Galorefitz) [14:58:39] (03Merged) 10jenkins-bot: composer.json: alphabetize sections [core] - 10https://gerrit.wikimedia.org/r/241492 (owner: 10BryanDavis) [15:01:51] (03PS2) 10Reedy: composer.json: Bump Monolog to 1.17.1 [core] - 10https://gerrit.wikimedia.org/r/241495 (owner: 10BryanDavis) [15:03:11] (03Merged) 10jenkins-bot: Optimized wfIsBadImage() redirect check [core] - 10https://gerrit.wikimedia.org/r/241491 (owner: 10Aaron Schulz) [15:03:13] (03Merged) 10jenkins-bot: Add missing 'action-disableaccount' i18n message [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/241513 (owner: 10Glaisher) [15:03:15] (03Merged) 10jenkins-bot: Alphabetize require section entries [vendor] - 10https://gerrit.wikimedia.org/r/241493 (owner: 10BryanDavis) [15:03:50] 10MediaWiki-extensions-Other: Create a special page for DeletePagesForGood extension - https://phabricator.wikimedia.org/T113883#1679186 (10Paladox) 3NEW [15:04:20] (03PS2) 10Amire80: WIP Reenable LineLength phpcs check [core] - 10https://gerrit.wikimedia.org/r/241501 (https://phabricator.wikimedia.org/T102614) [15:06:12] (03CR) 10jenkins-bot: [V: 04-1] composer.json: Bump Monolog to 1.17.1 [core] - 10https://gerrit.wikimedia.org/r/241495 (owner: 10BryanDavis) [15:08:22] (03CR) 10jenkins-bot: [V: 04-1] WIP Reenable LineLength phpcs check [core] - 10https://gerrit.wikimedia.org/r/241501 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [15:08:30] (03CR) 10Reedy: [C: 04-1] "Will fix" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/241495 (owner: 10BryanDavis) [15:08:44] (03PS1) 10MarcoAurelio: Add $namespaceGenderAliases for catalan language [core] - 10https://gerrit.wikimedia.org/r/241530 (https://phabricator.wikimedia.org/T113616) [15:08:57] (03PS3) 10Reedy: composer.json: Bump Monolog to 1.17.1 [core] - 10https://gerrit.wikimedia.org/r/241495 (owner: 10BryanDavis) [15:09:39] 6Revscoring, 10bwds: Omit the interwikilinks from stop words - https://phabricator.wikimedia.org/T109844#1679196 (10Ladsgroup) @He7d3r: Dos this look good to you? https://meta.wikimedia.org/wiki/Research:Revision_scoring_as_a_service/Word_lists/pt [15:09:57] (03PS2) 10MarcoAurelio: Add $namespaceGenderAliases for catalan language [core] - 10https://gerrit.wikimedia.org/r/241530 (https://phabricator.wikimedia.org/T113616) [15:13:33] 10MediaWiki-API, 10MediaWiki-Documentation, 7Documentation: Undocumented usage of generator=revisions - https://phabricator.wikimedia.org/T113876#1679201 (10Anomie) >>! In T113876#1679136, @Lahwaacz wrote: >> The last, https://wiki.archlinux.org/api.php?action=query&generator=revisions&titles=Main%20page, do... [15:16:42] (03PS1) 10MarcoAurelio: Normalizing namespaces for Spanish language [core] - 10https://gerrit.wikimedia.org/r/241531 (https://phabricator.wikimedia.org/T113499) [15:17:15] (03CR) 10Florianschmidtwelzow: "@TheDJ: I think the module is added by the dependency (Ib3360fa9271b9)? If so, the tests will fail as long the dependency hasn't been merg" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/172421 (https://phabricator.wikimedia.org/T74675) (owner: 10TheDJ) [15:17:47] 10MediaWiki-Internationalization, 5Patch-For-Review: Investigate and fix namespace name inconsistency at eswiki - https://phabricator.wikimedia.org/T113499#1679205 (10MarcoAurelio) a:3MarcoAurelio [15:18:22] 10MediaWiki-API: generator=recentchanges should be able to generate revids - https://phabricator.wikimedia.org/T113884#1679206 (10Anomie) 3NEW a:3Anomie [15:18:49] 10MediaWiki-Database, 6operations: Compress data at external storage - https://phabricator.wikimedia.org/T106386#1679216 (10jcrespo) [15:18:56] (03CR) 10MarcoAurelio: "Not sure if we will have to run https://wikitech.wikimedia.org/wiki/Adding_Namespaces on Spanish projects due to this change." [core] - 10https://gerrit.wikimedia.org/r/241531 (https://phabricator.wikimedia.org/T113499) (owner: 10MarcoAurelio) [15:20:17] (03CR) 10MarcoAurelio: "Not sure if we will have to run https://wikitech.wikimedia.org/wiki/Adding_Namespaces before this on Catalan-language projects." [core] - 10https://gerrit.wikimedia.org/r/241530 (https://phabricator.wikimedia.org/T113616) (owner: 10MarcoAurelio) [15:20:26] (03CR) 10jenkins-bot: [V: 04-1] Normalizing namespaces for Spanish language [core] - 10https://gerrit.wikimedia.org/r/241531 (https://phabricator.wikimedia.org/T113499) (owner: 10MarcoAurelio) [15:22:01] (03PS1) 10Anomie: API: Allow generator=recentchanges to generate revids [core] - 10https://gerrit.wikimedia.org/r/241532 (https://phabricator.wikimedia.org/T113884) [15:22:11] 10MediaWiki-Database, 6operations: Compress data at external storage - https://phabricator.wikimedia.org/T106386#1679221 (10jcrespo) p:5Normal>3High We should start by creating a new cluster (enwiki table has surpased the 1 TB size). Inserting to a separate table will be faster. I can own this, but I need... [15:26:17] 10MediaWiki-API: Create list=allrevisions module - https://phabricator.wikimedia.org/T113885#1679225 (10Anomie) 3NEW a:3Anomie [15:31:40] (03PS2) 10MarcoAurelio: Normalizing namespaces for Spanish language [core] - 10https://gerrit.wikimedia.org/r/241531 (https://phabricator.wikimedia.org/T113499) [15:34:36] (03CR) 10Florianschmidtwelzow: [C: 04-1] "I'm pretty sure there is nothing that needs to be fixed. Can you explain what you want to fix and why? Is there a task in phabricator?" [core] - 10https://gerrit.wikimedia.org/r/241515 (owner: 10Paladox) [15:35:09] 10MediaWiki-Codesniffer, 5Patch-For-Review: Add sniff to avoid if/else/while/foreach without curly braces - https://phabricator.wikimedia.org/T113863#1679239 (10Umherirrender) It is valid syntax, where phpcs should not add an error (In my opinion, see also the implementation of the linked change set in the bug... [15:36:05] (03PS2) 10MarcoAurelio: Modify [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/237888 [15:36:49] (03PS3) 10MarcoAurelio: Modify [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/237888 [15:37:15] (03PS4) 10MarcoAurelio: Modify [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/237888 [15:39:10] (03PS4) 10MarcoAurelio: Modify [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/237890 [15:39:26] 10PageImages: Thumbnail of the specific image is not created - https://phabricator.wikimedia.org/T113853#1679240 (10Umherirrender) For the example page I have done a action=purge with forcelinkupdate. After that the pageimage is shown again. There seems to be a server fault on the last save, which does not foun... [15:43:17] (03CR) 10Paladox: "There is no task as far as I can tell but if you look at" [core] - 10https://gerrit.wikimedia.org/r/241515 (owner: 10Paladox) [15:48:58] (03PS2) 10Umherirrender: Make lines short to pass phpcs in files under maintenance/ [core] - 10https://gerrit.wikimedia.org/r/241502 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [15:49:06] (03CR) 10Umherirrender: [C: 032] Make lines short to pass phpcs in files under maintenance/ [core] - 10https://gerrit.wikimedia.org/r/241502 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [15:49:32] (03CR) 10Florianschmidtwelzow: "Html::linkedScript() will add a script-tag [1] with the given url as the src-attribute. So, the output will be:" [core] - 10https://gerrit.wikimedia.org/r/241515 (owner: 10Paladox) [15:52:13] 10MediaWiki-extensions-AbuseFilter, 10Wikimedia-Site-Requests, 5Patch-For-Review: AbuseFilter in ukwiki - https://phabricator.wikimedia.org/T113848#1679249 (10Krenair) 5Open>3Resolved a:3Krenair [15:52:29] 10MediaWiki-extensions-AbuseFilter, 10Wikimedia-Site-Requests, 5Patch-For-Review: AbuseFilter in ukwiki - https://phabricator.wikimedia.org/T113848#1678241 (10Krenair) a:5Krenair>3Se4598 [15:54:09] (03Abandoned) 10Paladox: Fix path to config.js for mw-config [core] - 10https://gerrit.wikimedia.org/r/241515 (owner: 10Paladox) [15:56:15] (03CR) 10Paladox: "js dosent seem to be working in mw-config/" [core] - 10https://gerrit.wikimedia.org/r/241515 (owner: 10Paladox) [15:56:49] 10MediaWiki-Interface, 7I18n, 7Tracking: Interface messages needing rewording or documentation and other issues with existing messages (tracking) - https://phabricator.wikimedia.org/T40638#1679254 (10Aklapper) >>! In T40638#1679125, @MarcoAurelio wrote: > I wonder if it would be worth changing this tracking... [15:58:52] (03Merged) 10jenkins-bot: Make lines short to pass phpcs in files under maintenance/ [core] - 10https://gerrit.wikimedia.org/r/241502 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [15:59:02] 10MediaWiki-extensions-Other: [DisableAccount] Title::newFromText: $text must be a string from DisableAccount - https://phabricator.wikimedia.org/T113887#1679259 (10Glaisher) 3NEW [15:59:25] (03PS2) 10Umherirrender: Make lines short to pass phpcs in files under includes/db/ [core] - 10https://gerrit.wikimedia.org/r/241509 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [15:59:32] (03CR) 10Umherirrender: [C: 032] Make lines short to pass phpcs in files under includes/db/ [core] - 10https://gerrit.wikimedia.org/r/241509 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [16:00:37] 10MediaWiki-General-or-Unknown, 5Patch-For-Review, 7Wikimedia-log-errors: Title::newFromText: $text must be a string - https://phabricator.wikimedia.org/T76305#1679265 (10Glaisher) [16:04:22] (03CR) 10MarcoAurelio: "What's the progress on this?" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/145156 (https://bugzilla.wikimedia.org/25377) (owner: 10Legoktm) [16:09:06] (03Merged) 10jenkins-bot: Make lines short to pass phpcs in files under includes/db/ [core] - 10https://gerrit.wikimedia.org/r/241509 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [16:11:02] (03PS2) 10Umherirrender: Make lines short to pass phpcs in files under includes/ [core] - 10https://gerrit.wikimedia.org/r/241508 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [16:11:09] (03CR) 10Umherirrender: [C: 032] Make lines short to pass phpcs in files under includes/ [core] - 10https://gerrit.wikimedia.org/r/241508 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [16:13:20] 6Wikisource: Edit Modus Alert - https://phabricator.wikimedia.org/T113855#1679279 (10Aklapper) 5Open>3stalled That error message refers to a local script on your computer, not a script on Wikisource. Hence currently not yet possible to tell what triggers it... You could open your browser's web developer to... [16:13:23] (03CR) 10Florianschmidtwelzow: "> js dosent seem to be working in mw-config/" [core] - 10https://gerrit.wikimedia.org/r/241515 (owner: 10Paladox) [16:15:40] (03PS2) 10Cscott: Remove support for node 0.8.x. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/241132 [16:15:42] (03PS1) 10Cscott: Turn on jscs and clean up source code to make it pass. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/241533 [16:16:17] (03CR) 10jenkins-bot: [V: 04-1] Turn on jscs and clean up source code to make it pass. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/241533 (owner: 10Cscott) [16:16:24] (03CR) 10jenkins-bot: [V: 04-1] Remove support for node 0.8.x. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/241132 (owner: 10Cscott) [16:16:27] (03PS1) 10Glaisher: SpecialDisableAccount: Move username validation to submit() [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/241534 (https://phabricator.wikimedia.org/T113887) [16:17:13] (03PS1) 10Isarra: Mobile funky menus (WIP) [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/241535 [16:17:15] (03CR) 10jenkins-bot: [V: 04-1] Mobile funky menus (WIP) [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/241535 (owner: 10Isarra) [16:17:32] (03PS2) 10Isarra: Mobile funky menus (WIP) [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/241535 [16:18:45] 10Phabricator-Upstream: Continous error messages blocking browser - https://phabricator.wikimedia.org/T113889#1679288 (10PerfektesChaos) 3NEW [16:19:31] (03PS3) 10Cscott: Remove support for node 0.8.x. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/241132 [16:19:33] (03PS2) 10Cscott: Turn on jscs and clean up source code to make it pass. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/241533 [16:20:20] 10MediaWiki-Internationalization, 7I18n: Setting $namespaceGenderAliases for Aragonese (an) - https://phabricator.wikimedia.org/T113890#1679295 (10MarcoAurelio) 3NEW a:3MarcoAurelio [16:21:42] (03Merged) 10jenkins-bot: Make lines short to pass phpcs in files under includes/ [core] - 10https://gerrit.wikimedia.org/r/241508 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [16:24:10] (03PS2) 10Umherirrender: Make lines short to pass phpcs in files under includes/resourceloader [core] - 10https://gerrit.wikimedia.org/r/241507 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [16:24:16] (03CR) 10Umherirrender: [C: 032] Make lines short to pass phpcs in files under includes/resourceloader [core] - 10https://gerrit.wikimedia.org/r/241507 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [16:25:26] (03CR) 10Glaisher: [C: 04-1] HistoryAction: Implement HistoryPageAddLink hook for adding more links (032 comments) [core] - 10https://gerrit.wikimedia.org/r/120811 (https://phabricator.wikimedia.org/T28934) (owner: 10Tinaj1234) [16:31:36] (03CR) 10Reedy: [C: 032] Update to monolog 1.17.1 [vendor] - 10https://gerrit.wikimedia.org/r/241494 (owner: 10BryanDavis) [16:31:40] (03PS4) 10Reedy: composer.json: Bump Monolog to 1.17.1 [core] - 10https://gerrit.wikimedia.org/r/241495 (owner: 10BryanDavis) [16:31:46] (03CR) 10Reedy: [C: 032] composer.json: Bump Monolog to 1.17.1 [core] - 10https://gerrit.wikimedia.org/r/241495 (owner: 10BryanDavis) [16:34:16] (03Merged) 10jenkins-bot: Make lines short to pass phpcs in files under includes/resourceloader [core] - 10https://gerrit.wikimedia.org/r/241507 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [16:41:00] (03Merged) 10jenkins-bot: Update to monolog 1.17.1 [vendor] - 10https://gerrit.wikimedia.org/r/241494 (owner: 10BryanDavis) [16:43:50] (03Merged) 10jenkins-bot: composer.json: Bump Monolog to 1.17.1 [core] - 10https://gerrit.wikimedia.org/r/241495 (owner: 10BryanDavis) [16:44:51] (03PS1) 10Reedy: Actually update to monolog 1.17.1 [vendor] - 10https://gerrit.wikimedia.org/r/241536 [16:48:21] (03CR) 10jenkins-bot: [V: 04-1] Actually update to monolog 1.17.1 [vendor] - 10https://gerrit.wikimedia.org/r/241536 (owner: 10Reedy) [16:50:05] (03CR) 10Reedy: "Well, this isn't good..." [vendor] - 10https://gerrit.wikimedia.org/r/241536 (owner: 10Reedy) [16:53:16] (03PS1) 10Reedy: Revert "Update to monolog 1.17.1" [vendor] - 10https://gerrit.wikimedia.org/r/241538 [16:53:23] (03PS1) 10Reedy: Revert "composer.json: Bump Monolog to 1.17.1" [core] - 10https://gerrit.wikimedia.org/r/241539 [16:53:35] bd808: ^^ :/ [16:54:00] Did they change their minimum php version requirements? :/ [16:54:06] $foo = []; [16:57:55] 5.4! [17:02:15] 10Phabricator-Upstream: Continous error messages blocking browser - https://phabricator.wikimedia.org/T113889#1679312 (10Aklapper) Cannot reproduce in Firefox 40 or 41 (don't have 39 anymore). Need better criteria how to reproduce... :-/ What's exactly "open in another tab" when it comes to Phab? [17:06:08] (03PS2) 10Umherirrender: Make lines short to pass phpcs in profileinfo.php [core] - 10https://gerrit.wikimedia.org/r/241504 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [17:06:16] (03CR) 10Umherirrender: [C: 032] Make lines short to pass phpcs in profileinfo.php [core] - 10https://gerrit.wikimedia.org/r/241504 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [17:09:42] (03PS3) 10DCausse: Return null when getInterwikiResults() [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/239048 (https://phabricator.wikimedia.org/T96881) (owner: 10Nemo bis) [17:13:21] (03PS5) 10Umherirrender: Allow findHooks.php to compare parameter count of hooks [core] - 10https://gerrit.wikimedia.org/r/239659 [17:20:54] (03CR) 10DCausse: "Thanks, left one minor comment about cache. I think we just need the CirrusSearch.php change and we can leave InterwikiSearcher.php unchan" (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/239048 (https://phabricator.wikimedia.org/T96881) (owner: 10Nemo bis) [17:21:16] (03CR) 10jenkins-bot: [V: 04-1] Allow findHooks.php to compare parameter count of hooks [core] - 10https://gerrit.wikimedia.org/r/239659 (owner: 10Umherirrender) [17:23:14] 10MediaWiki-extensions-Diff, 10Wikidata: Add "diff only" links to navigation on diff view - https://phabricator.wikimedia.org/T113891#1679317 (10Scott) 3NEW [17:26:12] (03PS6) 10Umherirrender: Allow findHooks.php to compare parameter count of hooks [core] - 10https://gerrit.wikimedia.org/r/239659 [17:26:39] (03CR) 10Umherirrender: "Patch Set 6: Fixed spacing for phpcs" [core] - 10https://gerrit.wikimedia.org/r/239659 (owner: 10Umherirrender) [17:28:15] 10MediaWiki-History-or-Diffs: Add "diff only" links to navigation on diff view - https://phabricator.wikimedia.org/T113891#1679325 (10Ciencia_Al_Poder) [17:31:34] 3DevRel-October-2015: Lessons learned from the first Gerrit Cleanup Day - https://phabricator.wikimedia.org/T113378#1679327 (10Aklapper) [17:32:08] 10MediaWiki-ContentHandler, 7Wikimedia-log-errors: Exception error occurs when editing JSON pages on th.wp/th.wikt - https://phabricator.wikimedia.org/T108663#1679330 (10Glaisher) See https://th.wikipedia.org/w/index.php?title=%E0%B8%9C%E0%B8%B9%E0%B9%89%E0%B9%83%E0%B8%8A%E0%B9%89:Octahedron80/legacyThaiPUA.js... [17:32:58] 10MediaWiki-ContentHandler, 7Wikimedia-log-errors: Exception error occurs when editing JSON pages on th.wp/th.wikt - https://phabricator.wikimedia.org/T108663#1679333 (10Glaisher) See T73163 for root issue. [17:46:04] 10MediaWiki-extensions-Other: [WatchSubpages] Do not reuse watchlistredir class - https://phabricator.wikimedia.org/T111817#1679339 (10Umherirrender) 5Open>3Resolved a:3Umherirrender WatchSubpages already loads 'mediawiki.special', so the moved style from https://gerrit.wikimedia.org/r/#/c/236815/ will als... [17:48:07] (03CR) 10Legoktm: "1.17.1 is broken, but 1.17.0 should be fine: https://github.com/Seldaek/monolog/commit/18013a5e7d97137177590c1ae62a3ac411fa07d7#diff-606e7" [vendor] - 10https://gerrit.wikimedia.org/r/241536 (owner: 10Reedy) [17:48:24] (03CR) 10Legoktm: [C: 032] Revert "Update to monolog 1.17.1" [vendor] - 10https://gerrit.wikimedia.org/r/241538 (owner: 10Reedy) [17:49:19] (03PS1) 10Umherirrender: Load style for class="allpagesredirect" [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/241541 (https://phabricator.wikimedia.org/T111816) [17:49:47] (03CR) 10Legoktm: [C: 032] Revert "composer.json: Bump Monolog to 1.17.1" [core] - 10https://gerrit.wikimedia.org/r/241539 (owner: 10Reedy) [17:50:22] (03PS2) 10Umherirrender: Load style for class="allpagesredirect" [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/241541 (https://phabricator.wikimedia.org/T111816) [17:50:43] (03PS2) 10Umherirrender: Move italic redirect link styles to modules [core] - 10https://gerrit.wikimedia.org/r/236815 [17:50:47] 6Education-Collab: Discussuing having evaluation rubric for the education program in Egypt - https://phabricator.wikimedia.org/T111370#1679345 (10Reem_Al-Kashif) 5Open>3Resolved [17:57:24] (03Merged) 10jenkins-bot: Revert "Update to monolog 1.17.1" [vendor] - 10https://gerrit.wikimedia.org/r/241538 (owner: 10Reedy) [18:00:51] (03Merged) 10jenkins-bot: Revert "composer.json: Bump Monolog to 1.17.1" [core] - 10https://gerrit.wikimedia.org/r/241539 (owner: 10Reedy) [18:02:02] (03CR) 10Paladox: "Hi I did https://phabricator.wikimedia.org/T112383 blue boxes are shown and help button hidden." [core] - 10https://gerrit.wikimedia.org/r/241515 (owner: 10Paladox) [18:08:32] (03PS1) 10Gergő Tisza: [WIP] Add user parameter to EmailUser and EmailUserCC [core] - 10https://gerrit.wikimedia.org/r/241542 (https://phabricator.wikimedia.org/T12453) [18:08:51] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add user parameter to EmailUser and EmailUserCC [core] - 10https://gerrit.wikimedia.org/r/241542 (https://phabricator.wikimedia.org/T12453) (owner: 10Gergő Tisza) [18:10:56] 10MediaWiki-ResourceLoader, 6Performance-Team: File dependency tracking for ResourceLoader modules is broken - https://phabricator.wikimedia.org/T113868#1679358 (10ori) Since this is going to take a bit of time to fix properly, we should consider having a temporary workaround in place to mitigate the performan... [18:13:00] (03PS2) 10Gergő Tisza: [WIP] Add user parameter to EmailUser and EmailUserCC [core] - 10https://gerrit.wikimedia.org/r/241542 (https://phabricator.wikimedia.org/T12453) [18:13:20] (03CR) 10TheDJ: "@florian Right so used to things breaking in this extension.. ;)" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/172421 (https://phabricator.wikimedia.org/T74675) (owner: 10TheDJ) [18:18:14] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "features/update_redirect_api.feature:12" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/239048 (https://phabricator.wikimedia.org/T96881) (owner: 10Nemo bis) [18:20:19] (03Abandoned) 10TheDJ: [WIP] Move edit-section out of h1-h6 [core] - 10https://gerrit.wikimedia.org/r/200312 (https://phabricator.wikimedia.org/T13555) (owner: 10TheDJ) [18:22:25] (03CR) 10Paladox: [C: 031] Remove duplicate definition of mw.mergeConfig [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/241525 (owner: 10TheDJ) [18:23:55] (03CR) 10Umherirrender: "you can use the following code to get the corresponding users inside the hook:" [core] - 10https://gerrit.wikimedia.org/r/241542 (https://phabricator.wikimedia.org/T12453) (owner: 10Gergő Tisza) [18:24:00] (03CR) 10TheDJ: [C: 04-1] "@Paladox" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/241524 (owner: 10Paladox) [18:25:48] (03PS2) 10Paladox: Change message timedmedia-desc to timedmediahandler-desc [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/241524 [18:26:28] (03PS3) 10Paladox: Change message timedmedia-desc to timedmediahandler-desc [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/241524 [18:26:29] 10MediaWiki-Debug-Logger, 5MW-1.26-release, 5Patch-For-Review: Stacktraces missing from exception.log on fluorine - https://phabricator.wikimedia.org/T107440#1679368 (10Krinkle) Status? [18:26:43] (03CR) 10Paladox: "Ok done." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/241524 (owner: 10Paladox) [18:27:06] (03PS1) 10D3r1ck01: Update call to deprecated module [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/241543 [18:27:36] 6Developer-Relations, 3DevRel-September-2015: What to do with old open patches for unmaintained/inactive repositories when not even the uploader responds - https://phabricator.wikimedia.org/T102920#1679370 (10Aklapper) p:5Normal>3High [18:27:43] 3DevRel-October-2015: Lessons learned from the first Gerrit Cleanup Day - https://phabricator.wikimedia.org/T113378#1679372 (10Aklapper) p:5Normal>3High [18:28:38] (03PS4) 10TheDJ: Change message timedmedia-desc to timedmediahandler-desc [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/241524 (owner: 10Paladox) [18:29:11] (03PS2) 10D3r1ck01: Update call to deprecated module [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/241543 [18:29:35] (03CR) 10TheDJ: [C: 031] "Fine with me, but i18n ppl should do the +2, because i'm not sure if there is impact for translatewiki.net" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/241524 (owner: 10Paladox) [18:29:42] (03CR) 10Umherirrender: "Just an idea" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/241521 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [18:29:57] (03CR) 10Paladox: "This is the start of the migration theres a task for this T113631" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/241524 (owner: 10Paladox) [18:30:06] (03PS5) 10Paladox: Change message timedmedia-desc to timedmediahandler-desc [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/241524 (https://phabricator.wikimedia.org/T113631) [18:30:16] 10MediaWiki-extensions-OpenStackManager, 10Continuous-Integration-Config: OpenStackManager fails the mwext-testextension-zend test - https://phabricator.wikimedia.org/T113655#1679382 (10hashar) [18:33:04] !class DatabaseBase [18:33:04] See https://doc.wikimedia.org/mediawiki-core/master/php/html/classDatabaseBase.html [18:33:42] (03CR) 10Hashar: "recheck" [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/240741 (owner: 10Paladox) [18:39:46] legoktm: I guess I should file an issue upstream? [18:40:59] 10MediaWiki-extensions-Narayam, 10Continuous-Integration-Config, 5Patch-For-Review: Archive extensions Narayam and WebFonts - https://phabricator.wikimedia.org/T110178#1679392 (10Paladox) I can remove the files from the repo but what should I do what should I say. Meaning what should I say in php file. [18:41:21] 10MobileFrontend, 7Easy: Watchlist shouldn't re-render - https://phabricator.wikimedia.org/T113667#1679394 (10D3r1ck01) Will work on the bug soon. [18:42:36] legoktm: https://github.com/Seldaek/monolog/commit/5785a9ac4aab1511baf2a1547fc0ca8e89631c38 [18:42:53] 10MediaWiki-extensions-Narayam, 10Continuous-Integration-Config, 5Patch-For-Review: Archive extensions Narayam and WebFonts - https://phabricator.wikimedia.org/T110178#1679395 (10Paladox) When we remove the files the repo should temporarily be opened then readonly. [18:43:42] (03CR) 10Reedy: "He fixed it in https://github.com/Seldaek/monolog/commit/5785a9ac4aab1511baf2a1547fc0ca8e89631c38" [vendor] - 10https://gerrit.wikimedia.org/r/241536 (owner: 10Reedy) [18:44:17] (03CR) 10Umherirrender: "recheck" [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/191245 (https://bugzilla.wikimedia.org/66650) (owner: 10Jjanes) [18:44:40] (03PS5) 10D3r1ck01: Removing deprecated modules(9) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/241084 (https://phabricator.wikimedia.org/T113289) [18:45:57] bd808: legoktm We need 1.17.2 :P [18:47:54] (03CR) 10Hashar: [C: 04-1] "I am not a JavaScript guy, but I don't think the click event should be registered to ''." (031 comment) [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/240741 (owner: 10Paladox) [18:48:04] (03CR) 10Umherirrender: [C: 032] "Resubmit to give jenkins a second chance" [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/191245 (https://bugzilla.wikimedia.org/66650) (owner: 10Jjanes) [18:48:33] 10MediaWiki-Vendor: Update to Monolog 1.17.2 when available - https://phabricator.wikimedia.org/T113893#1679399 (10Reedy) 3NEW [18:49:12] (03CR) 10Hashar: "check experimental" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/240876 (https://phabricator.wikimedia.org/T113655) (owner: 10Paladox) [18:52:17] (03CR) 10Umherirrender: "Seems to need https://gerrit.wikimedia.org/r/#/c/240951/ or https://gerrit.wikimedia.org/r/#/c/240952/ for succesful test run" [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/191245 (https://bugzilla.wikimedia.org/66650) (owner: 10Jjanes) [18:52:19] (03CR) 10Hashar: "Depends on https://gerrit.wikimedia.org/r/#/c/240951/ "composer.json: Downgrade PHPUnit to 3.7.37 (temporarily)"" [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/191245 (https://bugzilla.wikimedia.org/66650) (owner: 10Jjanes) [18:52:27] (03CR) 10Martineznovo: "The replacement is correct. See: http://api.jquery.com/live/" [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/240741 (owner: 10Paladox) [18:52:52] 10MediaWiki-Vendor: Update to Monolog 1.17.2 when available - https://phabricator.wikimedia.org/T113893#1679408 (10Reedy) [18:52:54] (03PS1) 10Paladox: Add translatible description, Add url to extension, Add license field [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/241556 [18:53:23] (03Abandoned) 10Reedy: Actually update to monolog 1.17.1 [vendor] - 10https://gerrit.wikimedia.org/r/241536 (owner: 10Reedy) [18:54:03] (03Restored) 10Hashar: validate jenkins job (do not submit) [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/37433 (owner: 10Hashar) [18:54:07] 10PageImages: Thumbnail of the specific image is not created - https://phabricator.wikimedia.org/T113853#1679410 (10Comseong) It works since you have done a action=purge. Thank you. But still because the category API doesn't work normally, I need to find a method to rebuild a broken database. Anyway, this issue... [18:54:10] (03CR) 10Hashar: "recheck" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/37433 (owner: 10Hashar) [18:54:32] 10Wikimedia-Developer-Summit-2016: The end of shared hosting support? - https://phabricator.wikimedia.org/T113210#1679412 (10Vituzzu) >>! In T113210#1666410, @Ckoerner wrote: > What is MediaWiki? To many people it's just the core installation, sans any extensions or services. To me, it's all the extensions you n... [18:54:43] (03PS4) 10Umherirrender: Make Special:ConfirmEmail load the user from the master [core] (REL1_25) - 10https://gerrit.wikimedia.org/r/233109 (https://phabricator.wikimedia.org/T105896) (owner: 10Lewis Cawte) [18:54:55] (03CR) 10jenkins-bot: [V: 04-1] validate jenkins job (do not submit) [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/37433 (owner: 10Hashar) [18:55:32] (03CR) 10Umherirrender: [C: 032] "Resubmit after rebase of release notes" [core] (REL1_25) - 10https://gerrit.wikimedia.org/r/233109 (https://phabricator.wikimedia.org/T105896) (owner: 10Lewis Cawte) [18:57:15] (03CR) 10jenkins-bot: [V: 04-1] PostgreSQL: Fix text search on moved pages [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/191245 (https://bugzilla.wikimedia.org/66650) (owner: 10Jjanes) [18:58:01] 10MediaWiki-extensions-Comments, 10Social-Tools: Running rebuildall.php maintenance script, there is an error. - https://phabricator.wikimedia.org/T113894#1679414 (10Comseong) 3NEW [18:58:17] (03CR) 10Paladox: "@Martineznovo or @Hashar do you what I should change it too." [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/240741 (owner: 10Paladox) [18:58:46] 10PageImages: Thumbnail of the specific image is not created - https://phabricator.wikimedia.org/T113853#1679422 (10Umherirrender) 5Open>3Invalid You can purge (or linkupdate) all the pages in the broken file category or run refreshLinks.php as maintenance script (hopefully that will fix the database) [18:59:00] 6Education-Collab: Update Collab mentoring page - https://phabricator.wikimedia.org/T111358#1679424 (10Reem_Al-Kashif) 5Open>3Resolved [18:59:24] (03CR) 10Martineznovo: "Change what?" [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/240741 (owner: 10Paladox) [19:00:07] (03CR) 10Paladox: "I read through the google search on one of those very popular ask question forums I think it is stack or something like that but say if yo" [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/240741 (owner: 10Paladox) [19:00:32] (03CR) 10Paladox: "@Hashar says I carnt use body but I doint know what to use instead." [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/240741 (owner: 10Paladox) [19:02:49] 10MediaWiki-extensions-Comments, 10Social-Tools: Running rebuildall.php maintenance script, there is an error. - https://phabricator.wikimedia.org/T113894#1679425 (10Comseong) [19:03:10] (03CR) 10Martineznovo: "body will work perfectly. As you've done is correct. It will listen to all events that happen on body (and descendants), and will check th" [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/240741 (owner: 10Paladox) [19:03:40] Reedy: doh [19:03:46] :D [19:04:09] bd808: Also begs the question why he doesn't have PHP 5.3 linting... [19:04:26] (03CR) 10Paladox: "Ok thanks and thanks for feedback." [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/240741 (owner: 10Paladox) [19:04:41] (03Merged) 10jenkins-bot: Make Special:ConfirmEmail load the user from the master [core] (REL1_25) - 10https://gerrit.wikimedia.org/r/233109 (https://phabricator.wikimedia.org/T105896) (owner: 10Lewis Cawte) [19:04:43] (03CR) 10Paladox: [C: 031] "@Hashar it should work." [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/240741 (owner: 10Paladox) [19:05:06] The travis config tests on 5.3.3 but it's just phpunit and no linter [19:05:26] So his phpunit tests don't cover all of his code? [19:05:28] haha [19:05:44] Paladox, gerrit is not a chat :S [19:06:14] (03CR) 10Hashar: "recheck" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/37433 (owner: 10Hashar) [19:06:14] 6Education-Collab: Defining strategies for teh first WEP in Syria with Lamees - https://phabricator.wikimedia.org/T113895#1679430 (10Reem_Al-Kashif) 3NEW a:3Reem_Al-Kashif [19:06:22] 6Education-Collab: Defining strategies for teh first WEP in Syria with Lamees - https://phabricator.wikimedia.org/T113895#1679440 (10Reem_Al-Kashif) 5Open>3Resolved [19:06:42] teh [19:06:47] (03Abandoned) 10Hashar: validate jenkins job (do not submit) [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/37433 (owner: 10Hashar) [19:07:02] 10MediaWiki-Email, 10MediaWiki-Tarball-Backports, 10MediaWiki-extensions-ConfirmAccount, 5MW-1.25-release, and 2 others: Invalid confirmation code. The code may have expired in email confirmation (Special:ConfirmEmail) - https://phabricator.wikimedia.org/T105896#1679445 (10Umherirrender) 5Open>3Resolved... [19:08:45] 10MediaWiki-Maintenance-scripts, 5MW-1.25-release, 5Patch-For-Review: maintenance/updateSearchIndex.php gives Error: 1100 Table 'page_restrictions' was not locked with LOCK TABLES - https://phabricator.wikimedia.org/T86156#1679449 (10Umherirrender) 5Open>3Resolved a:3Umherirrender [19:09:15] 6Education-Collab: Setting up a WEP extension page for Lamees and showing her how it works - https://phabricator.wikimedia.org/T113896#1679451 (10Reem_Al-Kashif) 3NEW a:3Reem_Al-Kashif [19:10:06] (03CR) 10Hashar: "Isn't it overkill to attach it to body instead of just "#lexiconList a" ?" [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/240741 (owner: 10Paladox) [19:10:18] 6Education-Collab: Showing Lamees how to apply for grants - https://phabricator.wikimedia.org/T113897#1679460 (10Reem_Al-Kashif) 3NEW a:3Reem_Al-Kashif [19:12:38] 6Education-Collab: Showing Lamees how the extension page works - https://phabricator.wikimedia.org/T113896#1679470 (10Reem_Al-Kashif) [19:13:36] 6Education-Collab: Setting up a WEP extension page for Lamees - https://phabricator.wikimedia.org/T113898#1679472 (10Reem_Al-Kashif) 3NEW a:3Reem_Al-Kashif [19:13:44] 6Education-Collab: Setting up a WEP extension page for Lamees - https://phabricator.wikimedia.org/T113898#1679481 (10Reem_Al-Kashif) 5Open>3Resolved [19:14:31] 6Education-Collab: Defining strategies for the first WEP in Syria with Lamees - https://phabricator.wikimedia.org/T113895#1679483 (10Reem_Al-Kashif) [19:16:45] (03CR) 10Hashar: Add php code sniffer to SyntaxHighlight_GeSHi (031 comment) [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/225034 (owner: 10Paladox) [19:17:01] (03PS21) 10Hashar: Add php code sniffer to SyntaxHighlight_GeSHi [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/225034 (owner: 10Paladox) [19:17:44] 10MediaWiki-Page-editing, 10MediaWiki-Tarball-Backports, 7JavaScript, 5MW-1.25-release, and 2 others: EditWarning notification not shown in 1.25 installation - https://phabricator.wikimedia.org/T102564#1679485 (10Umherirrender) 5Open>3Resolved a:3TheDJ [19:18:10] (03CR) 10Martineznovo: "@Hashar: No if the "#lexiconList a" element is created after this code is executed (which I don't know). If we can *assure* the element wi" [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/240741 (owner: 10Paladox) [19:18:55] (03CR) 10Legoktm: "Yeah, but that's not in a tagged release yet." [vendor] - 10https://gerrit.wikimedia.org/r/241536 (owner: 10Reedy) [19:18:56] 10MediaWiki-Maintenance-scripts, 5MW-1.25-release, 5Patch-For-Review: maintenance/updateSearchIndex.php gives Error: 1100 Table 'page_restrictions' was not locked with LOCK TABLES - https://phabricator.wikimedia.org/T86156#1679487 (10Umherirrender) a:5Umherirrender>3lcawte [19:19:37] 10MediaWiki-Email, 10MediaWiki-Tarball-Backports, 10MediaWiki-extensions-ConfirmAccount, 5MW-1.25-release, and 2 others: Invalid confirmation code. The code may have expired in email confirmation (Special:ConfirmEmail) - https://phabricator.wikimedia.org/T105896#1679488 (10Umherirrender) a:5Umherirrender... [19:20:06] (03CR) 10Reedy: "Aye, but per Bryan we're not in a rush to update (no new features or fixes we really care about), so I philed https://phabricator.wikimedi" [vendor] - 10https://gerrit.wikimedia.org/r/241536 (owner: 10Reedy) [19:21:18] (03CR) 10Hashar: [C: 032] Add php code sniffer to SyntaxHighlight_GeSHi [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/225034 (owner: 10Paladox) [19:21:24] (03CR) 10Luke081515: [C: 031] Add script to migrate disabled accounts to blocked accounts [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/241512 (https://phabricator.wikimedia.org/T109060) (owner: 10Glaisher) [19:21:47] (03Merged) 10jenkins-bot: Add php code sniffer to SyntaxHighlight_GeSHi [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/225034 (owner: 10Paladox) [19:22:43] Reedy: https://github.com/Seldaek/monolog/pull/656 :) [19:23:13] heh [19:23:17] I just filed an issue asking for it [19:23:56] great minds [19:24:16] I had a quick google, as was wondering about doing it as a PR [19:24:22] but couldn't see anything obvious on how to do it [19:24:23] :) [19:24:34] heh, build failed [19:24:42] * Reedy looks [19:25:17] https://travis-ci.org/Seldaek/monolog/builds/82450414 [19:26:09] looks like a failing test "1) Monolog\Handler\RavenHandlerTest::testUserContext null does not match expected type "array"." [19:26:51] https://travis-ci.org/Seldaek/monolog/builds [19:26:58] Been failing for the last couple of PR [19:27:51] looks like it passes with an older version of the libs [19:28:50] Reedy: if you're submitting a PR upstream, wanna do one for https://gerrit.wikimedia.org/r/#/c/238668/ too? [19:29:22] we were spending a stupid amount of time in \DateTime::createFromFormat('U.u', sprintf('%.6F', microtime(true)), static::$timezone)->setTi mezone(static::$timezone), [19:29:38] because it's evaluated for every log message, including ones that are blackholed [19:30:00] (03CR) 10Luke081515: [C: 031] Allow CheckUser for IPv6 ranges up to /32 [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/203679 (https://phabricator.wikimedia.org/T95857) (owner: 10saper) [19:30:05] bd808: welcome back :D [19:30:11] helpful :/ [19:30:13] We could probably at least get that upstreamed behind a feature flag [19:30:21] o/ legoktm [19:30:30] ori: bd808 is submitting the PR ;D [19:30:31] bd808: yeah, welcome back! [19:30:50] bd808: I don't think we should go the feature flag approach -- it's just a silly decision [19:31:30] We can certainly try a PR and see what Jordi thinks [19:31:36] 10MediaWiki-Codesniffer, 10MediaWiki-General-or-Unknown, 5MW-1.26-release, 5Patch-For-Review: Don't check languages/messages for Generic.Files.LineLength - https://phabricator.wikimedia.org/T103806#1679495 (10Umherirrender) 5Open>3Resolved [19:32:05] bd808: I followed the trail of git-blame and it looks like the microsecond precision thing basically evolved unthinkingly from an innocent-looking microtime( true ) [19:32:27] 10MediaWiki-Internationalization, 6Language-Engineering, 7I18n, 5MW-1.26-release, and 2 others: Add {{bidi:}} syntax for directionality-safe arguments - https://phabricator.wikimedia.org/T104472#1679497 (10Umherirrender) 5Open>3Resolved [19:32:27] so i think it may be that no one stopped to think about the implication for performance at scale [19:32:46] but that never happens ;) [19:33:15] "No one will use this in a big site" [19:34:12] thinking about the cost of every function call is too hard. You just write code, try not to do anything obviously dumb and then fix the hot paths when you find them [19:34:30] 10MediaWiki-Codesniffer, 10Possible-Tech-Projects: Improving static analysis tools for MediaWiki - https://phabricator.wikimedia.org/T89682#1679500 (10Simmimourya3107) I saw previous comment made by @TasneemLo But still curious. Is this a potential project for Outreachy-round-11 (Dec 2015 to March 2016)? [19:34:56] see the way I doubled load on the app servers by adding CIDR support for XFF [19:35:13] and the effort it took from Brandon to fix it with good perfomance [19:35:15] 6Education-Collab: Wikimetrics training for Tunisian Wikipedians - https://phabricator.wikimedia.org/T113899#1679501 (10Reem_Al-Kashif) 3NEW a:3Reem_Al-Kashif [19:36:18] bd808: remembering about cheap short circuiting ;D [19:39:29] ori: do we have any perf graphs showing the time spent on DateTime::createFromFormat? [19:42:31] 10MediaWiki-Watchlist, 7Wikimedia-log-errors: MW 1.26wmf24 shows BadMethodCallException instead of (Enhanced) Watchlist - https://phabricator.wikimedia.org/T113418#1679513 (10Umherirrender) [19:42:32] 10MediaWiki-Recent-changes, 5MW-1.26-release, 5Patch-For-Review, 5WMF-deploy-2015-09-22_(1.26wmf24): https://www.mediawiki.org/wiki/Special:RecentChanges returns Exception encountered, of type "BadMethodCallException" - https://phabricator.wikimedia.org/T112738#1679514 (10Umherirrender) [19:43:08] 10MediaWiki-Watchlist, 7Wikimedia-log-errors: MW 1.26wmf24 shows BadMethodCallException instead of (Enhanced) Watchlist - https://phabricator.wikimedia.org/T113418#1664518 (10Umherirrender) Acording to the stacktrace this gets fixed by https://gerrit.wikimedia.org/r/#/c/240336/, which was for T112738, so marke... [19:43:37] 10MediaWiki-API, 10MediaWiki-Documentation, 7Documentation: Undocumented usage of generator=revisions - https://phabricator.wikimedia.org/T113876#1679519 (10Lahwaacz) Thank you for your input. The problem with `generator=recentchanges` is that it is affected by `$wgRCMaxAge`, but for the purpose of increment... [19:47:11] 10MediaWiki-Database, 7Wikimedia-log-errors: mysql_*(): expects parameter 2 to be resource, boolean given - https://phabricator.wikimedia.org/T46906#1679525 (10Umherirrender) After https://gerrit.wikimedia.org/r/#/c/221055/ all the places would throw an exception instead of given a bool to the mysql_* function [19:47:18] 10MediaWiki-Database, 7Wikimedia-log-errors: mysql_*(): expects parameter 2 to be resource, boolean given - https://phabricator.wikimedia.org/T46906#1679527 (10Umherirrender) 5Open>3Resolved [19:49:26] 10MediaWiki-File-management, 10MediaWiki-Uploading, 6Multimedia: Prevent upload of new version of a file when it's the same as the current version - https://phabricator.wikimedia.org/T113900#1679530 (10Reedy) 3NEW [19:52:33] 10MediaWiki-Interface, 7I18n, 7Tracking: Interface messages needing rewording or documentation and other issues with existing messages (tracking) - https://phabricator.wikimedia.org/T40638#1679540 (10Nemo_bis) >>! In T40638#1679125, @MarcoAurelio wrote: > I wonder if it would be worth changing this tracking... [19:55:42] 10CirrusSearch, 6Discovery: Stemming highlights the wrong terms in search results - https://phabricator.wikimedia.org/T113838#1679544 (10Cpiral) [19:55:59] 10MediaWiki-extensions-Translate, 10Wikimedia-Site-Requests, 5Patch-For-Review: Translation memory lost in Meta Wiki - https://phabricator.wikimedia.org/T113711#1679546 (10Nemo_bis) This is a WMF-specific issue, right? [20:00:51] (03PS2) 10Paladox: Add translatible description, Add url to extension, Add license field [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/241556 [20:01:09] (03CR) 10Paladox: "Testing jsonlint" [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/241556 (owner: 10Paladox) [20:02:27] (03PS4) 10Paladox: PLURAL support for MediaWiki:Safedelete-cannotdelete [extensions/SafeDelete] - 10https://gerrit.wikimedia.org/r/236248 (owner: 10Purodha) [20:02:30] (03CR) 10jenkins-bot: [V: 04-1] PLURAL support for MediaWiki:Safedelete-cannotdelete [extensions/SafeDelete] - 10https://gerrit.wikimedia.org/r/236248 (owner: 10Purodha) [20:02:49] (03CR) 10Paladox: "Jenkins tests added. Running the test." [extensions/SafeDelete] - 10https://gerrit.wikimedia.org/r/236248 (owner: 10Purodha) [20:03:13] 7Database: Odd plan for simple query on revisions + page - https://phabricator.wikimedia.org/T113901#1679553 (10Anomie) 3NEW [20:03:33] 7Database: Odd plan for simple query on revisions + page - https://phabricator.wikimedia.org/T113901#1679561 (10Anomie) [20:03:39] 7Database: Odd plan for simple query on revisions + page - https://phabricator.wikimedia.org/T113901#1679553 (10Anomie) [20:03:40] 10MediaWiki-API: Create list=allrevisions module - https://phabricator.wikimedia.org/T113885#1679563 (10Anomie) [20:03:44] (03CR) 10Paladox: PLURAL support for MediaWiki:Safedelete-cannotdelete (031 comment) [extensions/SafeDelete] - 10https://gerrit.wikimedia.org/r/236248 (owner: 10Purodha) [20:04:07] (03PS1) 10Anomie: API: Add ApiQueryListAllRevisions [core] - 10https://gerrit.wikimedia.org/r/241559 (https://phabricator.wikimedia.org/T113885) [20:04:42] (03CR) 10Anomie: [C: 04-1] "Something is weird with the queries here, see T113901." [core] - 10https://gerrit.wikimedia.org/r/241559 (https://phabricator.wikimedia.org/T113885) (owner: 10Anomie) [20:04:50] (03PS3) 10Paladox: Clean up code a bit [extensions/PipeEscape] - 10https://gerrit.wikimedia.org/r/240870 [20:05:58] (03PS2) 10Anomie: API: Allow generator=recentchanges to generate revids [core] - 10https://gerrit.wikimedia.org/r/241532 (https://phabricator.wikimedia.org/T113884) [20:07:29] (03CR) 10Paladox: "Thanks." [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/225034 (owner: 10Paladox) [20:08:08] (03CR) 10jenkins-bot: [V: 04-1] API: Add ApiQueryListAllRevisions [core] - 10https://gerrit.wikimedia.org/r/241559 (https://phabricator.wikimedia.org/T113885) (owner: 10Anomie) [20:10:44] (03PS1) 10Anomie: API: Fix some unclosed tags in en.json [core] - 10https://gerrit.wikimedia.org/r/241560 [20:11:49] 10MediaWiki-extensions-CollapsibleVector, 10MediaWiki-skins-Metrolook, 10WikiEditor: Update extensions to use array_plus_2d in extension.json - https://phabricator.wikimedia.org/T113183#1679583 (10Legoktm) [20:12:43] (03PS10) 10Hashar: Update Interwiki tests [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/225314 (owner: 10Paladox) [20:13:14] (03PS2) 10Anomie: API: Add ApiQueryAllRevisions [core] - 10https://gerrit.wikimedia.org/r/241559 (https://phabricator.wikimedia.org/T113885) [20:13:39] 10MediaWiki-Codesniffer, 10Continuous-Integration-Config, 7Easy, 5Patch-For-Review: Convert existing legacy phpcs jobs to use composer entry point + versioning - https://phabricator.wikimedia.org/T90943#1679584 (10Paladox) [20:13:57] 10MediaWiki-Codesniffer, 10Continuous-Integration-Config, 7Easy, 5Patch-For-Review: Convert existing legacy phpcs jobs to use composer entry point + versioning - https://phabricator.wikimedia.org/T90943#1071445 (10Paladox) [20:14:50] 10MediaWiki-Codesniffer, 10Continuous-Integration-Config, 7Easy, 5Patch-For-Review: Convert existing legacy phpcs jobs to use composer entry point + versioning - https://phabricator.wikimedia.org/T90943#1071445 (10Paladox) [20:15:16] (03CR) 10jenkins-bot: [V: 04-1] API: Fix some unclosed tags in en.json [core] - 10https://gerrit.wikimedia.org/r/241560 (owner: 10Anomie) [20:15:41] 10MediaWiki-Codesniffer, 10Continuous-Integration-Config, 7Easy, 5Patch-For-Review: Convert existing legacy phpcs jobs to use composer entry point + versioning - https://phabricator.wikimedia.org/T90943#1679589 (10Paladox) [20:16:07] 10MediaWiki-Codesniffer, 10Continuous-Integration-Config, 7Easy, 5Patch-For-Review: Convert existing legacy phpcs jobs to use composer entry point + versioning - https://phabricator.wikimedia.org/T90943#1071445 (10Paladox) [20:17:55] 10MediaWiki-extensions-CollapsibleVector, 10MediaWiki-skins-Metrolook, 10WikiEditor: Update extensions to use array_plus_2d in extension.json - https://phabricator.wikimedia.org/T113183#1679591 (10Paladox) [20:18:17] (03CR) 10Gergő Tisza: "Ah, thanks. I just assumed those are strings since the documentation did not mention otherwise." [core] - 10https://gerrit.wikimedia.org/r/241542 (https://phabricator.wikimedia.org/T12453) (owner: 10Gergő Tisza) [20:18:29] (03PS3) 10Gergő Tisza: Do not reuse text parameter between EmailUser and EmailUserCC [core] - 10https://gerrit.wikimedia.org/r/241542 (https://phabricator.wikimedia.org/T12453) [20:24:22] (03CR) 10Ricordisamoa: "recheck" [core] - 10https://gerrit.wikimedia.org/r/241560 (owner: 10Anomie) [20:27:13] (03CR) 10Paladox: "Needs merging since test was merged so will fail unless this is merged." [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/225314 (owner: 10Paladox) [20:28:17] (03PS1) 10Aaron Schulz: Removed onRejectParserCacheValue function [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/241561 [20:37:09] (03PS5) 10Purodha: PLURAL support for MediaWiki:Safedelete-cannotdelete [extensions/SafeDelete] - 10https://gerrit.wikimedia.org/r/236248 [20:37:34] (03PS11) 10Hashar: Update Interwiki tests [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/225314 (owner: 10Paladox) [20:37:58] (03CR) 10Hashar: "Rebased and updated .gitignore to ignore /vendor and composer.lock" [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/225314 (owner: 10Paladox) [20:39:00] (03CR) 10Hashar: [C: 032] "That is great Paladox :-) Will review more of your patches this coming week." [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/225314 (owner: 10Paladox) [20:39:32] (03Merged) 10jenkins-bot: Update Interwiki tests [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/225314 (owner: 10Paladox) [20:42:00] (03CR) 10Ricordisamoa: [C: 031] API: Fix some unclosed tags in en.json [core] - 10https://gerrit.wikimedia.org/r/241560 (owner: 10Anomie) [20:43:10] (03CR) 10Paladox: "Ok thankyou." [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/225314 (owner: 10Paladox) [20:48:02] (03CR) 10Hashar: "check experimental" [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/225310 (owner: 10Paladox) [20:53:07] (03PS11) 10Paladox: Update ConfirmAccount tests [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/225310 [20:59:29] 10MediaWiki-extensions-Narayam, 10Continuous-Integration-Config, 5Patch-For-Review: Archive extensions Narayam and WebFonts - https://phabricator.wikimedia.org/T110178#1679612 (10hashar) 5Open>3Resolved Both repositories are read-only in Gerrit. CI configuration has been removed https://gerrit.wikimedia... [21:04:23] 10MediaWiki-Codesniffer, 10Continuous-Integration-Config, 7Easy, 5Patch-For-Review: Convert existing legacy phpcs jobs to use composer entry point + versioning - https://phabricator.wikimedia.org/T90943#1679618 (10hashar) a:3Paladox Assigning this task to @Paladox since he is doing an excellent job at re... [21:21:16] hi ive a question if anyones able to help - would be much appreciated. ive got mediawiki/vagrant set up all set, and wanted to run the test suite [21:22:46] 10CirrusSearch, 6Discovery: Investigate collecting click through for all search result hits - https://phabricator.wikimedia.org/T113816#1679641 (10EBernhardson) Found an interesting slideshow[1] on integrating click results with search in solr. Much of this is likely relevant to us as well. [1] http://www.sl... [21:23:39] im using the windows powershell and im able to run the databaseless test cases - (but can't run make databaseless....says could not read "/suite.xml") [21:24:05] Guest49967: you should be running the tests from inside the VM [21:24:47] ah but they mention to cd to the tests directory to run these things [21:25:06] something like: vagrant ssh; cd /vagrant/mediawiki/tests; ... [21:25:26] ahhhh okay will try [21:26:14] There is a custom `vagrant run-tests` too [21:26:40] which should run the test suite from the host machine using ssh under the hood [21:28:18] !! was able to cd into the tests thank you, am currently trying to run the 'php phpunit.php' cmd and will see what happens [21:28:18] bla [21:28:35] ah okay will keep that 'vagrant run-tests' in mind as well [21:29:06] ah im getting database connection errors for php phpunit.php [21:29:40] hmmm... is the wiki in the VM working generally? [21:30:18] it seemed to be - what would be the best way to check? (sorry very new at this) [21:31:17] error in particular is: DB connection error: cant connect to local mysql server through socket 'dev/null' (111) () [21:31:34] do i need to modify the localsettings.php? [21:31:56] mediawiki-vagrant should already account for that. :/ [21:32:42] our hhvm builds don't have mysql domain socket support. you need to use 127.0.0.1 as the database host [21:35:31] okay thanks, modified to $wgDBserver = "127.0.0.1"; in localsettings.php and it seems to be running! [21:35:43] cool [21:35:45] (running php phpunit.php) [21:35:49] thanks so much! [21:36:30] LOL oh man. ended with 'segmentation fault' [21:36:54] yikes [21:37:08] welp thats not normal is it [21:37:25] (03CR) 10BryanDavis: "Submitted upstream as https://github.com/Seldaek/monolog/pull/658" [vendor] - 10https://gerrit.wikimedia.org/r/238668 (owner: 10Ori.livneh) [21:37:55] (03CR) 10Raimond Spekking: "remove myself as reviewer" [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/241556 (owner: 10Paladox) [21:39:01] am trying 'make databaseless' [21:39:22] (03PS3) 10Galorefitz: [WIP] Handle timezone specifiers in MWTimestamp [core] - 10https://gerrit.wikimedia.org/r/239292 (https://phabricator.wikimedia.org/T58064) [21:39:51] hm same issue - segmentation fault. is there anything i can do for this? [21:40:03] (03PS4) 10Galorefitz: Handle timezone specifiers in MWTimestamp [core] - 10https://gerrit.wikimedia.org/r/239292 (https://phabricator.wikimedia.org/T58064) [21:40:49] (03CR) 10Galorefitz: "Also, any other formats that are to be accounted for?" [core] - 10https://gerrit.wikimedia.org/r/239292 (https://phabricator.wikimedia.org/T58064) (owner: 10Galorefitz) [21:41:29] Guest49967: I'm trying locally now to see if I can reproduce the crash [21:42:20] ah ok, ty [21:43:56] blerg. I get a different failure because of my mw-vagrant config. The CentralAuth extension causes problems with some tests in the main suite. [21:44:43] * bd808 tries `make safe` [21:45:50] man. im trying will smaller test coverages and its fine for those. just cant handle large sizes on mine i guess. [21:46:44] memory? [21:47:34] my laptop just has 4gigs D: [21:49:23] How much has the vm got? [21:49:45] It shouldn't segfault though [21:50:03] Maybe [21:51:05] nothing should ever segfault really but Guest49967 may have found a new to us hhvm bug [21:51:28] segfault == double free == sloppy pointer management [21:51:32] "nothing should ever segfault really" << I want that one as a poster :P [21:51:43] free -g says 1gig... [21:52:09] woo, hhvm bug [21:52:13] hoo: maybe that should be my next t-shirt run :) [21:52:22] ohhh man [21:52:38] i literally just started with wikimedia yesterday :P [21:53:00] I'd totally wear taht :D [21:53:28] Guest49967: Well, you've apparently found a bug in code written/reviewed by facebook : [21:54:50] hm i still have a suspicious feeling im probably doing something wrong on my end. [22:10:10] 6Discovery, 10Maps: Buffer for Metatiles - https://phabricator.wikimedia.org/T112567#1679649 (10Pnorman) Vector tile stacks don't traditionally use metatiles, and there's already a buffer set on a per-layer basis on the vector style. This seems to be a duplicate of existing clipped label issues, with less inf... [22:11:38] 10MediaWiki-Email, 10MediaWiki-Extension-Requests, 6Collaboration-Team-Backlog, 10Echo, and 2 others: Encrypt emails with GnuPG (GPG) - https://phabricator.wikimedia.org/T12453#1679650 (10Tgr) There are two widespread formats for encrypting email: traditional (just replace the text of the email with the GP... [22:15:02] 10MediaWiki-Documentation, 7Documentation: Translations markup for editors - https://phabricator.wikimedia.org/T113907#1679651 (10Cpiral) 3NEW [22:28:52] (03PS1) 10Ori.livneh: mediawiki.toolbar: temporary workaround for T113868 [core] - 10https://gerrit.wikimedia.org/r/241571 (https://phabricator.wikimedia.org/T113868) [22:30:49] MatmaRex: ^ (gross, I know) [22:31:25] (03PS1) 10Ori.livneh: mediawiki.toolbar: temporary workaround for T113868 [core] (wmf/1.26wmf24) - 10https://gerrit.wikimedia.org/r/241572 (https://phabricator.wikimedia.org/T113868) [22:31:42] (03CR) 10Ori.livneh: [C: 032] mediawiki.toolbar: temporary workaround for T113868 [core] (wmf/1.26wmf24) - 10https://gerrit.wikimedia.org/r/241572 (https://phabricator.wikimedia.org/T113868) (owner: 10Ori.livneh) [22:32:41] ori: heh [22:34:06] ori: is this problem that bad [22:34:07] ? [22:35:19] (03PS1) 10Gergő Tisza: Add a FormatEchoEmail hook for final changes to email content [extensions/Echo] - 10https://gerrit.wikimedia.org/r/241573 (https://phabricator.wikimedia.org/T12453) [22:41:25] (03CR) 10Florianschmidtwelzow: [C: 032] "This fixes the problem for me and it's a reasonable change." [core] - 10https://gerrit.wikimedia.org/r/241482 (https://phabricator.wikimedia.org/T112383) (owner: 10PleaseStand) [22:41:33] (03Merged) 10jenkins-bot: mediawiki.toolbar: temporary workaround for T113868 [core] (wmf/1.26wmf24) - 10https://gerrit.wikimedia.org/r/241572 (https://phabricator.wikimedia.org/T113868) (owner: 10Ori.livneh) [22:42:26] 10MediaWiki-Installer, 10MediaWiki-ResourceLoader, 5Patch-For-Review: "Select language" blue boxes are shown on mw-config - https://phabricator.wikimedia.org/T112383#1679676 (10Florian) a:3PleaseStand The change of @PleaseStand fixes the problem for me. @Paladox: Please recheck (clear browser cache, e.g.) :) [22:45:09] 6Discovery, 10Maps: Name style - https://phabricator.wikimedia.org/T113909#1679679 (10Pnorman) 3NEW [22:47:46] 6Discovery, 10Maps: Move styles to their own organization - https://phabricator.wikimedia.org/T113910#1679686 (10Pnorman) 3NEW [22:50:56] (03Merged) 10jenkins-bot: Web installer: Fix collapsing of field help text [core] - 10https://gerrit.wikimedia.org/r/241482 (https://phabricator.wikimedia.org/T112383) (owner: 10PleaseStand) [22:52:45] 6Discovery, 10Maps: Don't use plpgsql for functions - https://phabricator.wikimedia.org/T113911#1679696 (10Pnorman) 3NEW [22:53:12] (03PS3) 10Isarra: Mobile funky menus (WIP) [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/241535 [22:57:39] (03PS10) 10Niedzielski: Replace ACRA with HockeyApp [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/237874 (https://phabricator.wikimedia.org/T108420) [22:57:40] 6Discovery, 10Maps: Outline cartographic goal for style - https://phabricator.wikimedia.org/T113912#1679702 (10Pnorman) 3NEW [22:59:50] (03PS1) 10Niedzielski: Hygiene: mark icon as RTL identical [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/241574 [23:00:13] 10MediaWiki-extensions-WikibaseRepository, 10Wikibase-DataModel-Serialization, 10Wikidata, 7RfC, 3Wikidata-Sprint-2015-09-15: [RFC] Decide how to represent derived values in the data model - https://phabricator.wikimedia.org/T112550#1679709 (10JeroenDeDauw) Where is the list of "derived values" we need t... [23:01:09] 10MediaWiki-Installer, 10Vector, 5Patch-For-Review: mw-config now dosent show any styles - https://phabricator.wikimedia.org/T113843#1679710 (10Krinkle) [23:03:49] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: mark icon as RTL identical [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/241574 (owner: 10Niedzielski) [23:05:03] 6Discovery, 10Maps: Add oneway arrows - https://phabricator.wikimedia.org/T113913#1679713 (10Pnorman) 3NEW [23:08:34] 10MediaWiki-ResourceLoader, 6Performance-Team, 5Patch-For-Review: File dependency tracking unstable (varies by language) - https://phabricator.wikimedia.org/T113868#1679731 (10Krinkle) [23:09:55] 10MediaWiki-ResourceLoader, 6Performance-Team, 5Patch-For-Review: File dependency tracking unstable (varies by language) - https://phabricator.wikimedia.org/T113868#1678809 (10Krinkle) Let's prioritise migration of module_deps to use one of the standard object stash or object cache interfaces. Adding extra f... [23:11:34] 10MediaWiki-extensions-Semantic-MediaWiki, 10Possible-Tech-Projects: Multilingual SemanticMediaWiki - https://phabricator.wikimedia.org/T48522#1679734 (10Yaron_Koren) I don't do Outreachy, so this project might be a no-go for now. However, it might be worth re-discussing this project (@Nikerabbit - presumably... [23:12:23] 6Phabricator, 10Access Policy, 10Legalpad: Delete L6 Legalpad document - https://phabricator.wikimedia.org/T113915#1679738 (10Varnent) 3NEW [23:14:14] MatmaRex: yes; it invalidates the module every 10-30 minutes, causing a resource cache bust [23:18:41] 6Phabricator, 10Access Policy, 10Legalpad: Delete L6 Legalpad document - https://phabricator.wikimedia.org/T113915#1679755 (10Jalexander) For the record it appears to delete requires a cli script: https://secure.phabricator.com/D9775 [23:19:33] 10MediaWiki-ResourceLoader: Revise the design of ResourceLoader's MessageBlobStore - https://phabricator.wikimedia.org/T113092#1679757 (10Krinkle) [23:25:09] 10MediaWiki-ResourceLoader, 6Performance-Team: Redesign ResourceLoader's file dependency tracking (module_deps) - https://phabricator.wikimedia.org/T113916#1679759 (10Krinkle) 3NEW [23:25:22] 10MediaWiki-ResourceLoader, 6Performance-Team: Redesign ResourceLoader's file dependency tracking (module_deps) - https://phabricator.wikimedia.org/T113916#1679772 (10Krinkle) [23:25:38] 10MediaWiki-ResourceLoader, 6Performance-Team: Redesign ResourceLoader's file dependency tracking (module_deps) - https://phabricator.wikimedia.org/T113916#1679759 (10Krinkle) [23:25:40] 10MediaWiki-ResourceLoader, 6Performance-Team, 5Patch-For-Review: File dependency tracking unstable (varies by language) - https://phabricator.wikimedia.org/T113868#1679773 (10Krinkle) [23:30:33] (03PS8) 10Krinkle: resourceloader: Placeholderize all the things [core] - 10https://gerrit.wikimedia.org/r/240301 (https://phabricator.wikimedia.org/T111481) [23:34:32] (03CR) 10jenkins-bot: [V: 04-1] resourceloader: Placeholderize all the things [core] - 10https://gerrit.wikimedia.org/r/240301 (https://phabricator.wikimedia.org/T111481) (owner: 10Krinkle) [23:47:38] 10MediaWiki-Special-pages: Special:PermanentLink is not listed on Special:SpecialPages - https://phabricator.wikimedia.org/T113917#1679779 (10Scott) 3NEW [23:47:55] 10MediaWiki-Special-pages: Special:PermanentLink is not listed on Special:SpecialPages - https://phabricator.wikimedia.org/T113917#1679786 (10Scott) p:5Triage>3Normal [23:57:57] (03PS4) 10Isarra: Mobile popup menus, for maximum js whackiness [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/241535