[00:00:16] (03PS9) 10Awight: Support reading and writing the 0.10 XML schema [tools/mwdumper] - 10https://gerrit.wikimedia.org/r/192174 [00:00:22] (03PS10) 10Awight: [WIP] Support reading and writing the 0.10 XML schema [tools/mwdumper] - 10https://gerrit.wikimedia.org/r/192174 [00:00:50] (03CR) 10Awight: [C: 04-1] "Not ready for re-review, I need to deal with the "deleted" flag." [tools/mwdumper] - 10https://gerrit.wikimedia.org/r/192174 (owner: 10Awight) [00:03:07] (03PS2) 10Aaron Schulz: Assorted WANObjectCache doc tweaks [core] - 10https://gerrit.wikimedia.org/r/240886 [00:06:02] (03CR) 10Awight: [C: 04-1] "CR-1 per previous comment" [core] - 10https://gerrit.wikimedia.org/r/201928 (https://phabricator.wikimedia.org/T58849) (owner: 10Awight) [00:06:55] (03Abandoned) 10Awight: WIP Use bare PHP flag when rendering Mustache [core] - 10https://gerrit.wikimedia.org/r/204023 (owner: 10Awight) [00:09:13] (03PS3) 10Awight: [WIP] Peck at strict puppet [vagrant] - 10https://gerrit.wikimedia.org/r/209855 [00:09:15] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Peck at strict puppet [vagrant] - 10https://gerrit.wikimedia.org/r/209855 (owner: 10Awight) [00:09:34] (03CR) 10Awight: [C: 04-1] "Needs rebase. Don't escape line continuations." [vagrant] - 10https://gerrit.wikimedia.org/r/209855 (owner: 10Awight) [00:12:30] 3Wikipedia-Android-App: In nearby, show on the map which item was touched in the list - https://phabricator.wikimedia.org/T113827#1676977 (10Yurik) 3NEW [00:13:24] (03PS2) 10Awight: Correct some API text [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/224380 [00:13:47] 3Wikipedia-Android-App: In nearby, show on the map which item was touched in the list - https://phabricator.wikimedia.org/T113827#1676985 (10Yurik) [00:14:37] (03PS2) 10Awight: Enable minor DonationInterface feature so we can debug it [vagrant] - 10https://gerrit.wikimedia.org/r/229175 [00:15:21] 10UI-Standardization, 10MobileFrontend, 6Performance-Team, 5MW-1.26-release, 5Patch-For-Review: MediaWiki UI styles loaded in head but unused on most pages - https://phabricator.wikimedia.org/T98395#1676987 (10Jdlrobson) 5Open>3declined a:3Jdlrobson Given the buttons are 1.2kb and with a page with... [00:15:22] (03PS2) 10Awight: Strip out deprecated parameters [vagrant] - 10https://gerrit.wikimedia.org/r/230235 [00:15:28] (03PS3) 10Awight: Strip out deprecated parameters [vagrant] - 10https://gerrit.wikimedia.org/r/230235 [00:24:49] Deskana:hi [00:30:03] 10Wiki-Loves-Monuments-Toolbox: Add tag to the "source" link - https://phabricator.wikimedia.org/T57657#1677012 (10JeanFred) 5Open>3Resolved a:3JeanFred Closing this one as Resolved. T112461 is slightly different. [00:30:31] 10Wiki-Loves-Monuments-Toolbox: Source link does not recognise https protocol - https://phabricator.wikimedia.org/T57657#1677017 (10JeanFred) [00:31:02] 10Wiki-Loves-Monuments-API: Source link does not recognise https protocol - https://phabricator.wikimedia.org/T57657#625651 (10JeanFred) [00:31:39] 10Wiki-Loves-Monuments-API, 5Patch-For-Review: Api html output doesn't produce url for source because of new URL format - https://phabricator.wikimedia.org/T112461#1677019 (10JeanFred) 5duplicate>3Resolved a:3JeanFred [00:36:08] 6Discovery, 10Maps, 10Performance-Metrics-Dashboard, 3Discovery-Maps-Sprint, 3Wikipedia-Android-App: KPI - Identify maps traffic from Mobile App - https://phabricator.wikimedia.org/T113829#1677023 (10Yurik) 3NEW [00:41:52] 10Reading Web Planning: Cleanup styles loaded without JavaScript that are not needed - https://phabricator.wikimedia.org/T113830#1677040 (10Jdlrobson) 3NEW a:3Jhernandez [00:42:51] 10Reading-Web, 7Performance: Epic: Make mobile web more performant - https://phabricator.wikimedia.org/T98987#1677052 (10Jdlrobson) [00:42:53] 10Reading Web Planning, 7Epic, 7Performance: [EPIC] Improve the status quo of mobile web performance - https://phabricator.wikimedia.org/T98986#1677053 (10Jdlrobson) [00:46:02] 10MobileFrontend, 5Patch-For-Review, 7Technical-Debt: Completely remove api.js and ForeignApi.js, their functionality has been upstreamed - https://phabricator.wikimedia.org/T110102#1677055 (10Jdlrobson) [00:46:03] 10MobileFrontend, 5Patch-For-Review: Convert WatchstarApi to gateway class - https://phabricator.wikimedia.org/T113753#1677056 (10Jdlrobson) [00:46:04] 10MobileFrontend, 5Patch-For-Review: Convert PageApi to PageGateway pattern - https://phabricator.wikimedia.org/T113752#1677057 (10Jdlrobson) [00:46:07] 10MobileFrontend, 5Patch-For-Review, 7Technical-Debt: Completely remove api.js and ForeignApi.js, their functionality has been upstreamed - https://phabricator.wikimedia.org/T110102#1677058 (10Jdlrobson) 5Open>3stalled [00:54:19] 10Wiki-Loves-Monuments-API, 5Patch-For-Review: Api html output doesn't produce url for register - https://phabricator.wikimedia.org/T112462#1677064 (10JeanFred) 5Open>3Resolved a:3JeanFred [00:54:34] 10Wiki-Loves-Monuments-API, 5Patch-For-Review: Api html output doesn't produce url for register - https://phabricator.wikimedia.org/T112462#1635248 (10JeanFred) p:5Triage>3Normal [00:55:47] 6Editing-Analysis: Calculate editing metrics for the WMF quarterly report - https://phabricator.wikimedia.org/T113824#1677069 (10Tbayer) ([[ https://commons.wikimedia.org/w/index.php?title=File:Wikimedia_Foundation_Quarterly_Report,_FY_2014-15_Q4_(April-June).pdf&page=3 | Shortcut link to last quarter's scorecar... [01:03:01] 6Revscoring: Build ORES support debs, store objects and sources in WMF repos - https://phabricator.wikimedia.org/T108556#1677071 (10yuvipanda) It's me! I will try to get more of this going next week - I'm trying to import all of them into gerrit... [01:07:17] 10Wiki-Loves-Monuments-Database: Source links in the monuments database get too long and are truncated - https://phabricator.wikimedia.org/T112460#1677072 (10JeanFred) Hmmm. ``` CREATE TABLE `monuments_all_tmp` ( ... `source` varchar(255) NOT NULL DEFAULT '', ... ``` Shall I just up that value? Looks lik... [01:08:34] 6Editing-Analysis: Calculate editing metrics for the WMF quarterly report about July-September 2015 - https://phabricator.wikimedia.org/T113824#1677075 (10Tbayer) [01:20:30] (03CR) 10Catrope: [C: 031] Ignore null edits for topic title, post, description, and summary [extensions/Flow] - 10https://gerrit.wikimedia.org/r/241142 (https://phabricator.wikimedia.org/T60975) (owner: 10Sbisson) [01:28:30] 10MediaWiki-Database, 7Technical-Debt: Kill MSSQL support with fire - https://phabricator.wikimedia.org/T113831#1677080 (10MaxSem) 3NEW [02:01:46] (03PS1) 10Bearloga: Adds script for fetching server-side tile statistics. [wikimedia/discovery/golden] - 10https://gerrit.wikimedia.org/r/241261 (https://phabricator.wikimedia.org/T112337) [02:03:10] 6Discovery, 3Discovery-Analysis-Sprint, 3Discovery-Maps-Sprint, 5Patch-For-Review: Display maps server-side usage metrics on maps dashboard - https://phabricator.wikimedia.org/T112337#1632676 (10mpopov) [02:04:17] 6Discovery, 3Discovery-Analysis-Sprint, 3Discovery-Maps-Sprint, 5Patch-For-Review: Write scripts for fetching server-side usage statistics - https://phabricator.wikimedia.org/T113832#1677094 (10mpopov) 3NEW a:3mpopov [02:04:28] (03PS2) 10Bearloga: Adds script for fetching server-side tile statistics. [wikimedia/discovery/golden] - 10https://gerrit.wikimedia.org/r/241261 (https://phabricator.wikimedia.org/T113832) [02:04:47] 6Discovery, 3Discovery-Analysis-Sprint, 3Discovery-Maps-Sprint, 5Patch-For-Review: Write scripts for fetching server-side usage statistics - https://phabricator.wikimedia.org/T113832#1677102 (10mpopov) [02:06:18] 3Mobile-Content-Service, 5Patch-For-Review, 3Wikipedia-Android-App: App: Store etag value in PageProperties and send it back if the same page gets sent - https://phabricator.wikimedia.org/T111124#1677107 (10bearND) 5Open>3declined I just learned that this task is not needed since OkHttp and Retrofit take... [02:11:47] (03CR) 10Krinkle: [C: 04-1] Tidy up ResourceLoader to make ResourceLoaderEditToolbarModule simpler (032 comments) [core] - 10https://gerrit.wikimedia.org/r/241113 (owner: 10Ori.livneh) [02:12:03] (03PS1) 10Krinkle: mediawiki.notification: Use CSS tranforms for in/out animations [core] - 10https://gerrit.wikimedia.org/r/241262 [02:12:50] 10MediaWiki-Database, 7Technical-Debt: Kill MSSQL support with fire - https://phabricator.wikimedia.org/T113831#1677110 (10Legoktm) [02:14:36] 10MediaWiki-Database, 7Technical-Debt: Kill MSSQL support with fire - https://phabricator.wikimedia.org/T113831#1677080 (10Legoktm) @Skizzerz is the maintainer for mssql (cc'd him), we've started drafting up https://www.mediawiki.org/wiki/Requests_for_comment/Moving_database_abstractions_out_of_MediaWiki_core... [02:15:09] (03PS3) 10Bearloga: Adds script for fetching server-side tile statistics. [wikimedia/discovery/golden] - 10https://gerrit.wikimedia.org/r/241261 (https://phabricator.wikimedia.org/T112337) [02:15:46] (03PS4) 10Bearloga: Adds script for fetching server-side tile statistics. [wikimedia/discovery/golden] - 10https://gerrit.wikimedia.org/r/241261 (https://phabricator.wikimedia.org/T113832) [02:21:53] 10MediaWiki-Database, 7Technical-Debt: Kill MSSQL support with fire - https://phabricator.wikimedia.org/T113831#1677118 (10Skizzerz) Cut the offensive tone @MaxSem, that was incredibly uncalled for. I spent at least 100 hours developing and testing making sure that it worked for far more than just "basic stuff... [02:31:59] (03CR) 10Legoktm: [C: 032] "Thanks for the quick response :)" [core] - 10https://gerrit.wikimedia.org/r/241103 (https://phabricator.wikimedia.org/T113765) (owner: 10EBernhardson) [02:41:21] (03CR) 10jenkins-bot: [V: 04-1] Include phpunit license for backported classes [core] - 10https://gerrit.wikimedia.org/r/241103 (https://phabricator.wikimedia.org/T113765) (owner: 10EBernhardson) [02:54:45] (03CR) 10Legoktm: [C: 032] "...bogus failure" [core] - 10https://gerrit.wikimedia.org/r/241103 (https://phabricator.wikimedia.org/T113765) (owner: 10EBernhardson) [03:04:36] (03CR) 10jenkins-bot: [V: 04-1] Include phpunit license for backported classes [core] - 10https://gerrit.wikimedia.org/r/241103 (https://phabricator.wikimedia.org/T113765) (owner: 10EBernhardson) [03:45:21] 7Design, 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Analytics, 7Tracking: [Master] Improved analytics page for CX - https://phabricator.wikimedia.org/T99230#1677148 (10santhosh) [03:51:00] (03CR) 10Ori.livneh: Tidy up ResourceLoader to make ResourceLoaderEditToolbarModule simpler (032 comments) [core] - 10https://gerrit.wikimedia.org/r/241113 (owner: 10Ori.livneh) [03:51:20] (03PS2) 10Ori.livneh: Tidy up ResourceLoader to make ResourceLoaderEditToolbarModule simpler [core] - 10https://gerrit.wikimedia.org/r/241113 [03:54:12] (03CR) 10jenkins-bot: [V: 04-1] Tidy up ResourceLoader to make ResourceLoaderEditToolbarModule simpler [core] - 10https://gerrit.wikimedia.org/r/241113 (owner: 10Ori.livneh) [03:56:02] 7Design, 6Design Research Backlog: Make all wiki-facing error pages consistent - https://phabricator.wikimedia.org/T113114#1677150 (10Nirzar) >quite strong differences compared the results of the current discussion at T110376 Differences in? [03:56:42] (03PS3) 10Ori.livneh: Tidy up ResourceLoader to make ResourceLoaderEditToolbarModule simpler [core] - 10https://gerrit.wikimedia.org/r/241113 [03:56:53] 7Design, 6WMF-Design-Research: Evaluate usability of the non-MediaWiki 404 page - https://phabricator.wikimedia.org/T110376#1677152 (10Nirzar) Would like to just link to this https://phabricator.wikimedia.org/T113114#1675456 for reference [03:59:21] (03CR) 10jenkins-bot: [V: 04-1] Tidy up ResourceLoader to make ResourceLoaderEditToolbarModule simpler [core] - 10https://gerrit.wikimedia.org/r/241113 (owner: 10Ori.livneh) [04:03:03] (03PS4) 10Ori.livneh: Tidy up ResourceLoader to make ResourceLoaderEditToolbarModule simpler [core] - 10https://gerrit.wikimedia.org/r/241113 [04:06:06] (03CR) 10jenkins-bot: [V: 04-1] Tidy up ResourceLoader to make ResourceLoaderEditToolbarModule simpler [core] - 10https://gerrit.wikimedia.org/r/241113 (owner: 10Ori.livneh) [04:07:06] (03PS5) 10Ori.livneh: Tidy up ResourceLoader to make ResourceLoaderEditToolbarModule simpler [core] - 10https://gerrit.wikimedia.org/r/241113 [04:09:53] (03CR) 10jenkins-bot: [V: 04-1] Tidy up ResourceLoader to make ResourceLoaderEditToolbarModule simpler [core] - 10https://gerrit.wikimedia.org/r/241113 (owner: 10Ori.livneh) [04:10:00] not my night [04:13:20] 10MediaWiki-ResourceLoader, 10MediaWiki-Unit-tests: ResourceLoaderModuleTest::testGetVersionHash is flaky - https://phabricator.wikimedia.org/T109394#1677164 (10Legoktm) > It happens about 1 every 50 runs Maybe I just have bad luck, but I keep running into it when merging patches. What's the plan to fix this?... [04:13:21] (03PS6) 10Ori.livneh: Tidy up ResourceLoader to make ResourceLoaderEditToolbarModule simpler [core] - 10https://gerrit.wikimedia.org/r/241113 [04:15:23] 10MediaWiki-ResourceLoader, 10MediaWiki-Unit-tests: ResourceLoaderModuleTest::testGetVersionHash is flaky - https://phabricator.wikimedia.org/T109394#1677168 (10ori) >>! In T109394#1677164, @Legoktm wrote: >> It happens about 1 every 50 runs > > Maybe I just have bad luck, but I keep running into it when merg... [04:16:14] (03CR) 10Legoktm: [C: 032] "Third time's the charm? :|" [core] - 10https://gerrit.wikimedia.org/r/241103 (https://phabricator.wikimedia.org/T113765) (owner: 10EBernhardson) [04:17:18] (03CR) 10jenkins-bot: [V: 04-1] Tidy up ResourceLoader to make ResourceLoaderEditToolbarModule simpler [core] - 10https://gerrit.wikimedia.org/r/241113 (owner: 10Ori.livneh) [04:17:42] 6Parsing-Team, 5WMF-deploy-2015-09-22_(1.26wmf24): ParsoidBatchAPI doesn't normalize file titles - https://phabricator.wikimedia.org/T113318#1677169 (10ssastry) 5Open>3Resolved p:5Triage>3Normal a:3tstarling [04:23:44] (03CR) 10Polybuildr: [C: 031] "Great idea! Lets us work incrementally." [core] - 10https://gerrit.wikimedia.org/r/241085 (owner: 10Legoktm) [04:25:06] (03PS7) 10Ori.livneh: Tidy up ResourceLoader to make ResourceLoaderEditToolbarModule simpler [core] - 10https://gerrit.wikimedia.org/r/241113 [04:26:11] (03Merged) 10jenkins-bot: Include phpunit license for backported classes [core] - 10https://gerrit.wikimedia.org/r/241103 (https://phabricator.wikimedia.org/T113765) (owner: 10EBernhardson) [04:28:38] (03CR) 10jenkins-bot: [V: 04-1] Tidy up ResourceLoader to make ResourceLoaderEditToolbarModule simpler [core] - 10https://gerrit.wikimedia.org/r/241113 (owner: 10Ori.livneh) [04:30:10] (03PS8) 10Ori.livneh: Tidy up ResourceLoader to make ResourceLoaderEditToolbarModule simpler [core] - 10https://gerrit.wikimedia.org/r/241113 [04:37:56] (03PS3) 10Aaron Schulz: Added $opts to WANObjectCache::set() to detect snapshot lag [core] - 10https://gerrit.wikimedia.org/r/240908 [04:40:54] ori: heh, I previously forgot the examples in that patch [04:41:51] time to call the WANbulance [04:54:01] (03PS3) 10Ori.livneh: Assorted WANObjectCache doc tweaks [core] - 10https://gerrit.wikimedia.org/r/240886 (owner: 10Aaron Schulz) [04:54:17] (03CR) 10Ori.livneh: [C: 032] Assorted WANObjectCache doc tweaks [core] - 10https://gerrit.wikimedia.org/r/240886 (owner: 10Aaron Schulz) [04:56:28] 10MobileFrontend, 7Easy, 3Reading-Web-Sprint-56-Four Lions: Regression: h1 elements inside content area are Helvetica not Linux Libertine/Georgia - https://phabricator.wikimedia.org/T113759#1677192 (10phuedx) And here I was thinking that I'd simplified `headings.less`… [05:04:13] 10MediaWiki-Codesniffer, 10MediaWiki-General-or-Unknown: Make MediaWiki core pass mediawiki-codesniffer - https://phabricator.wikimedia.org/T102609#1677195 (10Legoktm) https://lists.wikimedia.org/pipermail/wikitech-l/2015-September/083383.html [05:04:25] (03Merged) 10jenkins-bot: Assorted WANObjectCache doc tweaks [core] - 10https://gerrit.wikimedia.org/r/240886 (owner: 10Aaron Schulz) [05:58:12] (03PS1) 10Aaron Schulz: Made convertNamespace() use APC [core] - 10https://gerrit.wikimedia.org/r/241265 [06:08:57] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed. See https://www.mediawiki.org/wiki/Manual:Coding_conventions for all details on coding conventions." (031 comment) [extensions/PipeEscape] - 10https://gerrit.wikimedia.org/r/241069 (owner: 10Purodha) [06:11:14] (03CR) 10Siebrand: [C: 032] Convert spaces to tab and clear up a bit of code [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/239117 (owner: 10Paladox) [06:11:33] (03Merged) 10jenkins-bot: Convert spaces to tab and clear up a bit of code [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/239117 (owner: 10Paladox) [06:11:47] (03CR) 10Siebrand: [C: 032] Update namemsg to convention [skins/Slate] - 10https://gerrit.wikimedia.org/r/241088 (https://phabricator.wikimedia.org/T113632) (owner: 10Paladox) [06:12:01] (03Merged) 10jenkins-bot: Update namemsg to convention [skins/Slate] - 10https://gerrit.wikimedia.org/r/241088 (https://phabricator.wikimedia.org/T113632) (owner: 10Paladox) [06:12:13] (03CR) 10Siebrand: [C: 032] Update namemsg to convention [skins/Vector] - 10https://gerrit.wikimedia.org/r/241089 (https://phabricator.wikimedia.org/T113632) (owner: 10Paladox) [06:12:14] 6Discovery, 10Maps: maps.wikimedia.org not rendering highway=construction and railway=construction properly - https://phabricator.wikimedia.org/T113836#1677200 (10Jc86035) 3NEW [06:12:32] (03Merged) 10jenkins-bot: Update namemsg to convention [skins/Vector] - 10https://gerrit.wikimedia.org/r/241089 (https://phabricator.wikimedia.org/T113632) (owner: 10Paladox) [06:13:28] 6Discovery, 10Maps: maps.wikimedia.org not rendering highway=construction or railway=construction properly - https://phabricator.wikimedia.org/T113836#1677212 (10Jc86035) [06:13:31] (03CR) 10Siebrand: [C: 032] Update namemsg to convention [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/241091 (https://phabricator.wikimedia.org/T113632) (owner: 10Paladox) [06:13:50] (03CR) 10Siebrand: [C: 032] Update namemsg to convention [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/241093 (https://phabricator.wikimedia.org/T113632) (owner: 10Paladox) [06:14:05] (03CR) 10jenkins-bot: [V: 04-1] Update namemsg to convention [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/241091 (https://phabricator.wikimedia.org/T113632) (owner: 10Paladox) [06:14:34] (03CR) 10Siebrand: [C: 032] Update namemsg to convention [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/241095 (https://phabricator.wikimedia.org/T113632) (owner: 10Paladox) [06:14:58] (03Merged) 10jenkins-bot: Update namemsg to convention [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/241093 (https://phabricator.wikimedia.org/T113632) (owner: 10Paladox) [06:15:02] (03Merged) 10jenkins-bot: Update namemsg to convention [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/241095 (https://phabricator.wikimedia.org/T113632) (owner: 10Paladox) [06:15:11] 6Discovery, 10Maps: maps.wikimedia.org not rendering highway=construction or railway=construction properly - https://phabricator.wikimedia.org/T113836#1677200 (10Jc86035) p:5Low>3Triage [06:29:01] (03CR) 10Legoktm: [C: 04-1] Handle revisions with different content models in EditPage (034 comments) [core] - 10https://gerrit.wikimedia.org/r/237988 (https://phabricator.wikimedia.org/T73163) (owner: 10Wctaiwan) [06:31:14] (03PS1) 10Revi: Add License [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/241269 [06:33:28] (03PS1) 10PleaseStand: QueryPage::fetchFromCache: Remove redundant $db->resultObject() call [core] - 10https://gerrit.wikimedia.org/r/241270 [06:33:30] (03PS2) 10Siebrand: Update namemsg to convention [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/241091 (https://phabricator.wikimedia.org/T113632) (owner: 10Paladox) [06:33:47] (03CR) 10Siebrand: [C: 032] Update namemsg to convention [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/241091 (https://phabricator.wikimedia.org/T113632) (owner: 10Paladox) [06:34:15] (03CR) 10jenkins-bot: [V: 04-1] Update namemsg to convention [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/241091 (https://phabricator.wikimedia.org/T113632) (owner: 10Paladox) [06:35:17] (03PS3) 10Purodha: Add translatable extensionname [extensions/PipeEscape] - 10https://gerrit.wikimedia.org/r/241069 [06:38:08] (03PS1) 10Siebrand: Update skinname to convention [skins/Blueprint] - 10https://gerrit.wikimedia.org/r/241271 [06:39:19] (03PS1) 10Siebrand: Update namemsg to convention [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/241272 [06:40:25] (03PS1) 10Siebrand: Update namemsg to convention [skins/Example] - 10https://gerrit.wikimedia.org/r/241273 [06:42:10] (03PS1) 10Siebrand: Update namemsg to convention [skins/Modern] - 10https://gerrit.wikimedia.org/r/241274 [06:42:49] (03PS2) 10Siebrand: Update namemsg to convention [skins/Blueprint] - 10https://gerrit.wikimedia.org/r/241271 [06:42:56] (03CR) 10Siebrand: [C: 032] Update namemsg to convention [skins/Blueprint] - 10https://gerrit.wikimedia.org/r/241271 (owner: 10Siebrand) [06:43:01] (03CR) 10Siebrand: [C: 032] Update namemsg to convention [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/241272 (owner: 10Siebrand) [06:43:06] (03CR) 10Siebrand: [C: 032] Update namemsg to convention [skins/Example] - 10https://gerrit.wikimedia.org/r/241273 (owner: 10Siebrand) [06:43:12] (03CR) 10Siebrand: [C: 032] Update namemsg to convention [skins/Modern] - 10https://gerrit.wikimedia.org/r/241274 (owner: 10Siebrand) [06:43:33] (03Merged) 10jenkins-bot: Update namemsg to convention [skins/Blueprint] - 10https://gerrit.wikimedia.org/r/241271 (owner: 10Siebrand) [06:43:36] (03Merged) 10jenkins-bot: Update namemsg to convention [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/241272 (owner: 10Siebrand) [06:43:38] (03Merged) 10jenkins-bot: Update namemsg to convention [skins/Example] - 10https://gerrit.wikimedia.org/r/241273 (owner: 10Siebrand) [06:43:40] (03Merged) 10jenkins-bot: Update namemsg to convention [skins/Modern] - 10https://gerrit.wikimedia.org/r/241274 (owner: 10Siebrand) [06:44:06] (03CR) 10Siebrand: [C: 032] Add translatable extensionname [extensions/PipeEscape] - 10https://gerrit.wikimedia.org/r/241069 (owner: 10Purodha) [06:45:46] (03PS1) 10PleaseStand: Remove redundant $db->resultObject() call [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/241275 [06:46:14] (03CR) 10jenkins-bot: [V: 04-1] Remove redundant $db->resultObject() call [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/241275 (owner: 10PleaseStand) [06:50:11] (03CR) 10Siebrand: [V: 032] Add translatable extensionname [extensions/PipeEscape] - 10https://gerrit.wikimedia.org/r/241069 (owner: 10Purodha) [06:51:14] (03CR) 10Siebrand: [V: 032] "Teset fail not related to this patch set:" [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/241091 (https://phabricator.wikimedia.org/T113632) (owner: 10Paladox) [06:53:37] (03PS1) 10PleaseStand: Remove redundant $db->resultObject() calls [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/241276 [06:53:49] (03CR) 10Siebrand: [C: 032 V: 032] Consistency tweaks in preparation for translatewiki.net [extensions/AccessibilitySimulation] - 10https://gerrit.wikimedia.org/r/230518 (owner: 10Raimond Spekking) [07:01:08] (03CR) 10Siebrand: "I doubt that this is the right way to go for this. I'd rather have something with string replacement using CLDR and a single base string." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/240964 (https://phabricator.wikimedia.org/T112349) (owner: 10Smalyshev) [07:07:19] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Story: [Story] On all items about living people, the first suggestions are often "date of death" and "place of death" - https://phabricator.wikimedia.org/T93799#1677238 (10matej_suchanek) [07:10:41] 10CirrusSearch, 6Discovery: Stemming highlights the wrong terms in search results - https://phabricator.wikimedia.org/T113838#1677239 (10Cpiral) 3NEW [07:20:34] (03PS3) 10Gerrit Patch Uploader: Add utility method for language fallback chain handling in JavaScript [core] - 10https://gerrit.wikimedia.org/r/204719 [07:20:36] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/204719 (owner: 10Gerrit Patch Uploader) [07:24:59] (03CR) 10Smalyshev: "See https://gerrit.wikimedia.org/r/#/c/241126/ for alternative approach." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/240964 (https://phabricator.wikimedia.org/T112349) (owner: 10Smalyshev) [07:26:13] (03CR) 10Schnark: Add utility method for language fallback chain handling in JavaScript (032 comments) [core] - 10https://gerrit.wikimedia.org/r/204719 (owner: 10Gerrit Patch Uploader) [07:28:52] 10Wikimedia-Developer-Summit-2016: The end of shared hosting support? - https://phabricator.wikimedia.org/T113210#1677250 (10Purodha) >>! In T113210#1676649, @ssastry wrote: > > 1. The architectural and engineering considerations that go into running mediawiki installations the size, scale, and complexity of Wi... [07:30:11] (03CR) 10OliverKeyes: Adds script for fetching server-side tile statistics. (034 comments) [wikimedia/discovery/golden] - 10https://gerrit.wikimedia.org/r/241261 (https://phabricator.wikimedia.org/T113832) (owner: 10Bearloga) [07:30:45] (03CR) 10OliverKeyes: [C: 032 V: 032] Fixes dashboard titles [wikimedia/discovery/wetzel] - 10https://gerrit.wikimedia.org/r/241120 (owner: 10Bearloga) [07:31:35] (03CR) 10OliverKeyes: [C: 032 V: 032] "Hmph. A LIKELY STORY." [wikimedia/discovery/polloi] - 10https://gerrit.wikimedia.org/r/241083 (owner: 10Bearloga) [07:33:38] 10Wikimedia-Developer-Summit-2016: The end of shared hosting support? - https://phabricator.wikimedia.org/T113210#1677252 (10hashar) My bit from the thread http://markmail.org/thread/tjig2g4hunth3s6s (January 2015, LARGE) still stand. I slightly edited my grammar errors.. 2015-01-16, Bryan Davis wrote: > There... [07:35:37] (03CR) 10OliverKeyes: Adds augmented clickthroughs to dashboard + Adds 'user engagement' KPI summary box + Adds 'user engagement' KPI time series + Adds page visi (034 comments) [wikimedia/discovery/rainbow] - 10https://gerrit.wikimedia.org/r/241115 (https://phabricator.wikimedia.org/T113637) (owner: 10Bearloga) [07:55:48] Niharika: hi [08:22:44] (03Abandoned) 10Aklapper: untest [extensions/examples] - 10https://gerrit.wikimedia.org/r/241023 (owner: 10Ciprian) [08:32:40] 6Wikisource: Building a query for Quarry that counts index ns: and compares with what is count through special:IndexPages - https://phabricator.wikimedia.org/T113673#1677258 (10Glaisher) Looks like the table is not populated if there's no corresponding Page ns pages at the time of last edit for the index page. S... [08:40:52] 6Wikisource: Building a query for Quarry that counts index ns: and compares with what is count through special:IndexPages - https://phabricator.wikimedia.org/T113673#1677259 (10Glaisher) It looks like `pr_index` is not replicated to Labs public databases. It might be useful to request it to be available there on... [08:43:23] 10MediaWiki-skins-Metrolook: Stylesheets should not both specify "media" and contain @media - https://phabricator.wikimedia.org/T113839#1677260 (10PleaseStand) 3NEW [08:51:35] (03CR) 10PleaseStand: "Test failure is unrelated, tracked at T113839" [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/241275 (owner: 10PleaseStand) [08:52:59] 10MediaWiki-Database, 7Technical-Debt: Kill MSSQL support with fire - https://phabricator.wikimedia.org/T113831#1677267 (10Aklapper) Starting a discussion about the future of MSSQL backend support on a technical mailing list (and spending time trying to identify a list of potential problems created by the curr... [09:00:15] 10CirrusSearch, 6Discovery: Stemming highlights the wrong terms in search results - https://phabricator.wikimedia.org/T113838#1677270 (10dcausse) Could you give an example query where stemmed terms are highlighted please? Concerning the "researchers" use case, could you elaborate a bit more? Is it just counti... [09:00:42] (03PS1) 10PleaseStand: Remove redundant $db->resultObject() call [extensions/Video] - 10https://gerrit.wikimedia.org/r/241278 [09:01:01] (03CR) 10jenkins-bot: [V: 04-1] Remove redundant $db->resultObject() call [extensions/Video] - 10https://gerrit.wikimedia.org/r/241278 (owner: 10PleaseStand) [09:05:57] (03Abandoned) 10Physikerwelt: Fix: Set default MathStyle to inlineDisplaystyle [extensions/Math] (wmf/1.26wmf17) - 10https://gerrit.wikimedia.org/r/229352 (owner: 10Physikerwelt) [09:08:31] (03PS1) 10PleaseStand: Remove redundant $db->resultObject() call [extensions/OAI] - 10https://gerrit.wikimedia.org/r/241279 [09:08:49] (03CR) 10jenkins-bot: [V: 04-1] Remove redundant $db->resultObject() call [extensions/OAI] - 10https://gerrit.wikimedia.org/r/241279 (owner: 10PleaseStand) [09:27:07] (03PS14) 10Amire80: Add new grammar forms for language names in Russian [core] - 10https://gerrit.wikimedia.org/r/172501 [09:27:16] (03PS5) 10Amire80: Convert Russian grammar cases from PHP to JSON [core] - 10https://gerrit.wikimedia.org/r/239980 [09:31:30] 10MediaWiki-Parser, 10MediaWiki-extensions-ContentTranslation, 10Cite, 5ContentTranslation-Release6: ContentTranslation created a reference that renders as UNIQ--nowiki-00000007-QINU at [[Google Cardboard]] in he.wikipedia - https://phabricator.wikimedia.org/T107303#1677276 (10Amire80) And another example:... [09:34:48] 10MediaWiki-extensions-GettingStarted, 10Browser-Tests: Upgrade GettingStarted browser tests to use mediawiki_selenium 1.x - https://phabricator.wikimedia.org/T99655#1295863 (10zeljkofilipin) Could not find value of MEDIAWIKI_CAPTCHA_BYPASS_PASSWORD. I do not see it at https://office.wikimedia.org/wiki/Seleniu... [09:41:31] 10MediaWiki-Database, 7Technical-Debt: Kill MSSQL support with fire - https://phabricator.wikimedia.org/T113831#1677279 (10Qgil) For a good restart of this discussion, I propose to make it private while the interested parties figure out the next technical steps. The tone is disrespectful indeed, and @Skizzerz... [09:46:37] (03PS1) 10Amire80: WebStart.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241280 [09:50:08] 10CirrusSearch, 6Discovery: User option to remove contextual lines from search results - https://phabricator.wikimedia.org/T113840#1677280 (10Cpiral) 3NEW [09:51:34] (03PS1) 10Amire80: WebRequest.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241281 [10:00:26] (03PS1) 10Amire80: ImagePage.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241285 [10:03:41] 10CirrusSearch, 6Discovery: Search results consisting of titles only - https://phabricator.wikimedia.org/T113840#1677290 (10Cpiral) [10:19:54] Nas [10:22:47] 6Revscoring, 10bwds: Omit the interwikilinks from stop words - https://phabricator.wikimedia.org/T109844#1677294 (10Ladsgroup) I tried your suggestion on Vietnamese Wikipedia and it took 27632.947533369064 seconds to finish (7h40m) which is acceptable for me. I will re-run this for all wikis :) [10:27:58] (03CR) 10Polybuildr: [C: 031] WebRequest.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241281 (owner: 10Amire80) [10:30:55] 10MediaWiki-Codesniffer, 7Upstream: phpcs doesnt exit when timed out in composer - https://phabricator.wikimedia.org/T112280#1677296 (10polybuildr) 5Open>3Invalid a:3polybuildr Closing as invalid since we're unable to reproduce it. Feel free to re-open if it occurs again! [10:33:49] (03CR) 10Polybuildr: "The string was earlier broken on the basis of sentences. While this fixes the long line issue, maybe we should still ensure that the strin" [core] - 10https://gerrit.wikimedia.org/r/241280 (owner: 10Amire80) [10:43:46] 10MediaWiki-Codesniffer: Release version 0.4.0 of mediawiki/tools/codesniffer - https://phabricator.wikimedia.org/T113516#1677302 (10polybuildr) @Legoktm and I spoke about this on IRC a while back - we do need to update to v0.4.0 also because of 62bddfe5ed8b2 and 0735677425. However, maybe it's a good idea to r... [10:48:45] (03PS1) 10PleaseStand: Database: Remove resultObject() from the public interface [core] - 10https://gerrit.wikimedia.org/r/241286 [10:50:38] (03PS2) 10PleaseStand: Database: Remove resultObject() from the public interface [core] - 10https://gerrit.wikimedia.org/r/241286 [11:04:31] 10MediaWiki-extensions-GettingStarted, 10Browser-Tests, 6Collaboration-Team-Backlog, 10Continuous-Integration-Infrastructure, and 2 others: Pass MEDIAWIKI_CAPTCHA_BYPASS_PASSWORD in on Jenkins so GettingStarted browser tests pass - https://phabricator.wikimedia.org/T91220#1677318 (10zeljkofilipin) [11:11:28] (03CR) 10Amire80: "Not really, the second sentence was broken anyway. I'm biased, but I think that it's readable enough the way I made it ;)" [core] - 10https://gerrit.wikimedia.org/r/241280 (owner: 10Amire80) [11:16:39] (03PS1) 10Amire80: phpunit.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241289 [11:19:09] (03CR) 10Reedy: [C: 04-1] phpunit.php: Make lines shorter to make phpcs happier (031 comment) [core] - 10https://gerrit.wikimedia.org/r/241289 (owner: 10Amire80) [11:19:12] (03CR) 10jenkins-bot: [V: 04-1] phpunit.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241289 (owner: 10Amire80) [11:20:35] (03PS1) 10Amire80: MaintenanceTest.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241290 [11:22:04] (03PS2) 10Amire80: phpunit.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241289 [11:26:01] 10MediaWiki-skins-Metrolook: Stylesheets should not both specify "media" and contain @media - https://phabricator.wikimedia.org/T113839#1677326 (10Paladox) [11:27:25] (03PS1) 10Amire80: MediaWikiTestCase.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241291 [11:35:24] 10MediaWiki-skins-Metrolook: Stylesheets should not both specify "media" and contain @media - https://phabricator.wikimedia.org/T113839#1677329 (10Paladox) I think this is to do with https://git.wikimedia.org/blob/mediawiki%2Fskins%2FMetrolook/b9185c73b7a6d64f0f00067e078a6b5c4bca1af0/skin.json#L61 and https://gi... [11:37:50] (03CR) 10Jforrester: [C: 032] Don't try to redirect to Special:MobileEditor on a POST request [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/241250 (https://phabricator.wikimedia.org/T111894) (owner: 10Alex Monk) [11:39:34] (03CR) 10Hashar: "recheck" [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/241275 (owner: 10PleaseStand) [11:40:07] 10MediaWiki-skins-Metrolook: Stylesheets should not both specify "media" and contain @media - https://phabricator.wikimedia.org/T113839#1677330 (10Paladox) And could be to do with extension-unittests-generic test added recently to metrolook. [11:40:09] (03Merged) 10jenkins-bot: Don't try to redirect to Special:MobileEditor on a POST request [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/241250 (https://phabricator.wikimedia.org/T111894) (owner: 10Alex Monk) [11:40:29] 10MediaWiki-skins-Metrolook: Stylesheets should not both specify "media" and contain @media - https://phabricator.wikimedia.org/T113839#1677333 (10Paladox) Not sure how to fix this problem. [11:41:23] (03CR) 10Paladox: "Thanks." [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/239117 (owner: 10Paladox) [11:44:49] 10MediaWiki-skins-Metrolook: Stylesheets should not both specify "media" and contain @media - https://phabricator.wikimedia.org/T113839#1677260 (10hashar) [11:45:00] 10MediaWiki-skins-Metrolook: Stylesheets should not both specify "media" and contain @media - https://phabricator.wikimedia.org/T113839#1677260 (10hashar) The root cause is T113841 , the skins are not deleted between runs. [11:46:20] 10UI-Standardization, 5Patch-For-Review: DateInputWidget: Rounded corders are internally and externally inconsistent - https://phabricator.wikimedia.org/T113740#1677353 (10Jdforrester-WMF) p:5Triage>3Normal a:3Esanders [11:46:57] 10UI-Standardization, 5Patch-For-Review: DateInputWidget: popup shouldn't have a blue border - https://phabricator.wikimedia.org/T113741#1677357 (10Jdforrester-WMF) p:5Triage>3Normal a:3Esanders [11:50:24] (03PS1) 10Zfilipin: WIP Upgrade browser tests to use mediawiki_selenium 1.x Ruby gem [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/241293 (https://phabricator.wikimedia.org/T99655) [11:51:45] (03CR) 10jenkins-bot: [V: 04-1] WIP Upgrade browser tests to use mediawiki_selenium 1.x Ruby gem [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/241293 (https://phabricator.wikimedia.org/T99655) (owner: 10Zfilipin) [11:51:59] (03CR) 10Jforrester: [C: 032] mediawiki.widgets: Create TitleSearchWidget [core] - 10https://gerrit.wikimedia.org/r/241228 (https://phabricator.wikimedia.org/T101169) (owner: 10Esanders) [11:52:53] (03PS1) 10Paladox: TEST: DO NOT MERGE [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/241294 [11:53:26] (03CR) 10Paladox: "@Hashar please could you recheck this." [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/241294 (owner: 10Paladox) [11:53:29] * Lcawte merges [11:53:57] (03CR) 10Zfilipin: WIP Upgrade browser tests to use mediawiki_selenium 1.x Ruby gem (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/241293 (https://phabricator.wikimedia.org/T99655) (owner: 10Zfilipin) [11:56:47] (03PS2) 10Zfilipin: WIP Upgrade browser tests to use mediawiki_selenium 1.x Ruby gem [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/241293 (https://phabricator.wikimedia.org/T99655) [11:59:34] (03CR) 10Zfilipin: WIP Upgrade browser tests to use mediawiki_selenium 1.x Ruby gem (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/241293 (https://phabricator.wikimedia.org/T99655) (owner: 10Zfilipin) [12:01:12] (03CR) 10Hashar: "recheck" [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/241294 (owner: 10Paladox) [12:01:38] (03CR) 10jenkins-bot: [V: 04-1] TEST: DO NOT MERGE [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/241294 (owner: 10Paladox) [12:01:47] (03Merged) 10jenkins-bot: mediawiki.widgets: Create TitleSearchWidget [core] - 10https://gerrit.wikimedia.org/r/241228 (https://phabricator.wikimedia.org/T101169) (owner: 10Esanders) [12:02:20] (03CR) 10Paladox: "Seems it is an error" [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/241294 (owner: 10Paladox) [12:02:41] (03CR) 10Paladox: "I am not sure how to fix that." [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/241294 (owner: 10Paladox) [12:04:23] (03CR) 10Zfilipin: "And the jenkins jobs fails with this :(" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/241293 (https://phabricator.wikimedia.org/T99655) (owner: 10Zfilipin) [12:07:07] (03PS1) 10Paladox: Testing fix for jenkings errors DO NOT MERGE [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/241295 [12:08:51] (03Abandoned) 10Paladox: Testing fix for jenkings errors DO NOT MERGE [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/241295 (owner: 10Paladox) [12:09:09] (03CR) 10Paladox: "recheck" [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/241295 (owner: 10Paladox) [12:10:17] (03Abandoned) 10Paladox: TEST: DO NOT MERGE [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/241294 (owner: 10Paladox) [12:13:07] 10MediaWiki-Watchlist, 7Wikimedia-log-errors: MW 1.26wmf24 shows BadMethodCallException instead of (Enhanced) Watchlist - https://phabricator.wikimedia.org/T113418#1677375 (10Lydia_Pintscher) I am seeing this on my watchlist too. [12:23:35] 10MediaWiki-Watchlist, 7Wikimedia-log-errors: MW 1.26wmf24 shows BadMethodCallException instead of (Enhanced) Watchlist - https://phabricator.wikimedia.org/T113418#1677390 (10Reedy) >>! In T113418#1664544, @hoo wrote: > Probably: > > > ``` > 2015-09-22 21:53:35 mw1183 mediawikiwiki exception ERROR: [c710fdf... [12:34:52] 10MediaWiki-General-or-Unknown: mw-config now dosent show any styles - https://phabricator.wikimedia.org/T113843#1677393 (10Paladox) 3NEW [12:36:42] o_0 [12:38:45] (03PS1) 10Jforrester: Begin 1.27 development cycle [core] - 10https://gerrit.wikimedia.org/r/241297 [12:39:05] (03CR) 10Jforrester: "Not entirely sure why this wasn't done on Tuesday…" [core] - 10https://gerrit.wikimedia.org/r/241297 (owner: 10Jforrester) [12:39:50] (03CR) 10Reedy: [C: 04-1] Begin 1.27 development cycle (031 comment) [core] - 10https://gerrit.wikimedia.org/r/241297 (owner: 10Jforrester) [12:40:09] (03CR) 10Jforrester: Begin 1.27 development cycle (031 comment) [core] - 10https://gerrit.wikimedia.org/r/241297 (owner: 10Jforrester) [12:40:33] (03CR) 10Reedy: Begin 1.27 development cycle (031 comment) [core] - 10https://gerrit.wikimedia.org/r/241297 (owner: 10Jforrester) [12:40:37] (03PS2) 10Jforrester: Begin 1.27 development cycle [core] - 10https://gerrit.wikimedia.org/r/241297 [12:41:32] (03PS3) 10Jforrester: Begin 1.27 development cycle [core] - 10https://gerrit.wikimedia.org/r/241297 [12:42:17] Reedy: I was wondering if it hadn't been done yet for a reason, or if we'd just forgotten; [12:42:23] (03CR) 10Jforrester: Begin 1.27 development cycle (031 comment) [core] - 10https://gerrit.wikimedia.org/r/241297 (owner: 10Jforrester) [12:42:45] I presume the latter [12:43:33] Maybe. [12:43:49] For 1.25 I did it earlier than certain people expected and got shouted at. [12:43:56] * James_F is worried it'll happen all again. :-) [12:44:13] Find out who shouted at you, and get them to +2 it ;D [12:45:43] (03CR) 10Reedy: [C: 031] "Just +1-ing for now... Any reason to hold back from merging this?" [core] - 10https://gerrit.wikimedia.org/r/241297 (owner: 10Jforrester) [12:45:53] Reedy: :-) [12:47:55] (03CR) 10Alex Monk: Begin 1.27 development cycle (031 comment) [core] - 10https://gerrit.wikimedia.org/r/241297 (owner: 10Jforrester) [12:48:39] Mmm [12:48:46] What's the hhvm version equivalents? [12:48:54] (03CR) 10Jforrester: Begin 1.27 development cycle (031 comment) [core] - 10https://gerrit.wikimedia.org/r/241297 (owner: 10Jforrester) [12:48:57] Also, we don't actually check for specific hhvm versions do we? [12:50:28] No idea. [12:50:35] (03CR) 10Alex Monk: Begin 1.27 development cycle (031 comment) [core] - 10https://gerrit.wikimedia.org/r/241297 (owner: 10Jforrester) [12:50:51] Which begs the question, should we be imposing a hhvm version limiit? [12:51:05] Is there versions that MW won't run on? [12:51:58] Also, for the "libraries" section of RELEASE NOTES, should we be doing 1.25.2..1.26.0, or 1.25.0..1.26.0? [12:52:15] I was under the impression that Wikimedia has had to apply some patches to its HHVM installs in the past to make it work with some more obscure features? [12:52:41] Krenair: I vaguely understood those were mostly farm-specific features, rather than single-wiki ones, BICBW? [12:54:50] certainly someone was talking about backporting hhvm patches [12:55:47] https://github.com/wikimedia/operations-debs-hhvm/commits/master [12:55:49] ori and _joe_ ;) [12:56:14] and Bryan [12:59:41] Shock. :-) [13:00:45] Certainly worth a discussion :) [13:01:47] 10Wiki-Loves-Monuments-Database: Source links in the monuments database get too long and are truncated - https://phabricator.wikimedia.org/T112460#1677406 (10Ahonc) and what about storing permalinks curids/oldid of page? It will be less than 255 chars [13:02:50] (03PS3) 10Jforrester: Add RELEASE-NOTES entries for PHP library upgrades and additions [core] - 10https://gerrit.wikimedia.org/r/235676 (owner: 10Legoktm) [13:02:57] 10MediaWiki-Database: infoAction::pageCounts use rev_user instead of rev_user_text - https://phabricator.wikimedia.org/T67332#1677407 (10Krenair) a:5Springle>3None [13:06:29] (03PS4) 10Jforrester: Add RELEASE-NOTES entries for PHP library upgrades and additions [core] - 10https://gerrit.wikimedia.org/r/235676 (owner: 10Legoktm) [13:07:36] (03PS1) 10Amire80: SpecialSearchTest.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241299 [13:08:07] (03CR) 10Jforrester: [C: 031] "PS3: Rebase of PS2." [core] - 10https://gerrit.wikimedia.org/r/235676 (owner: 10Legoktm) [13:09:42] (03PS1) 10Amire80: StatusTest.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241300 [13:16:32] (03CR) 10Reedy: Convert Russian grammar cases from PHP to JSON (031 comment) [core] - 10https://gerrit.wikimedia.org/r/239980 (owner: 10Amire80) [13:18:40] (03CR) 10Amire80: Convert Russian grammar cases from PHP to JSON (031 comment) [core] - 10https://gerrit.wikimedia.org/r/239980 (owner: 10Amire80) [13:21:23] (03PS2) 10Reedy: MaintenanceTest.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241290 (owner: 10Amire80) [13:21:29] (03CR) 10Reedy: [C: 032] MaintenanceTest.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241290 (owner: 10Amire80) [13:21:42] I wonder how many files he plans on changnig.. :P [13:27:35] (03PS5) 10Jforrester: Disable failing sniffs in phpcs.xml [core] - 10https://gerrit.wikimedia.org/r/241085 (https://phabricator.wikimedia.org/T102609) (owner: 10Legoktm) [13:27:46] (03PS6) 10Jforrester: phpcs: Disable failing sniffs in phpcs.xml [core] - 10https://gerrit.wikimedia.org/r/241085 (https://phabricator.wikimedia.org/T102609) (owner: 10Legoktm) [13:31:41] (03Merged) 10jenkins-bot: MaintenanceTest.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241290 (owner: 10Amire80) [13:32:12] (03PS1) 10Jforrester: package.json: Indicate that this is a private package (for now) [core] - 10https://gerrit.wikimedia.org/r/241302 [13:32:27] 10MediaWiki-General-or-Unknown: mw-config now dosent show any styles - https://phabricator.wikimedia.org/T113843#1677424 (10Paladox) Traced it back to vendor folder. It seems it is to do with the files that load the folder like composer.json or one of those [13:32:53] (03CR) 10Jforrester: [C: 032] "Let's do this." [core] - 10https://gerrit.wikimedia.org/r/241085 (https://phabricator.wikimedia.org/T102609) (owner: 10Legoktm) [13:37:34] (03CR) 10Reedy: "Do we have an idea of the scale of this?" [core] - 10https://gerrit.wikimedia.org/r/241290 (owner: 10Amire80) [13:37:50] 10MediaWiki-Page-editing, 6Editing-Department, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Mobile: Make the edit conflict screen nicer to use on mobile - https://phabricator.wikimedia.org/T113844#1677429 (10Jdforrester-WMF) 3NEW [13:37:59] 7Design, 10MediaWiki-Page-editing, 6Editing-Department, 10VisualEditor, and 2 others: Make the edit conflict screen nicer to use on mobile - https://phabricator.wikimedia.org/T113844#1677436 (10Jdforrester-WMF) [13:42:12] Reedy: https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs/76/console quite a bunch of files (see full log) [13:42:52] only 419 [13:43:00] Instances, not files [13:43:04] (03Merged) 10jenkins-bot: phpcs: Disable failing sniffs in phpcs.xml [core] - 10https://gerrit.wikimedia.org/r/241085 (https://phabricator.wikimedia.org/T102609) (owner: 10Legoktm) [13:44:32] (03PS3) 10Reedy: phpunit.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241289 (owner: 10Amire80) [13:44:39] (03CR) 10Reedy: [C: 032] phpunit.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241289 (owner: 10Amire80) [13:44:46] many files get only 1 or 2 warnings [13:45:41] 178 files have errors/warning [13:46:01] doesn't sound too bad in total [13:46:10] * Reedy starts merging [13:47:19] It'd be nice to get https://gerrit.wikimedia.org/r/#/c/228993/ merged and released. [13:47:23] To help with this. :-) [13:47:31] Vulpix: James_F just broke that report though [13:47:32] xD [13:47:39] * James_F is unhelpful. ;-) [13:47:50] heh [13:48:04] Pick a rule, delete its override, fix all instances, profit. [13:49:12] 10MediaWiki-Codesniffer, 10MediaWiki-General-or-Unknown: Make MediaWiki core pass mediawiki-codesniffer - https://phabricator.wikimedia.org/T102609#1677454 (10Jdforrester-WMF) [13:49:29] James_F: If we get these long line issues fixed up... It's doable [13:49:34] It seems to account for most of the errors [13:49:37] * James_F nods [13:49:41] So then doing the others should be smaller [13:49:43] I'd recommend working on other rules first. [13:49:57] It's much more fun to fix 20 instances than 200 in one go. :-) [13:50:02] heh [13:50:14] Well, Amir is making patches, so might aswell merge them before they're stale [13:50:19] * James_F nods. [13:51:42] * Reedy looks at the sniffer [13:52:46] I guess I'd have to test it :P [13:53:21] 10MediaWiki-General-or-Unknown: mw-config now dosent show any styles - https://phabricator.wikimedia.org/T113843#1677461 (10Paladox) It was probably caching problem. But mw-config wont show properly since changing less.php packages. [13:54:12] 10MediaWiki-General-or-Unknown, 10Vector: mw-config now dosent show any styles - https://phabricator.wikimedia.org/T113843#1677464 (10Paladox) [13:54:36] (03Merged) 10jenkins-bot: phpunit.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241289 (owner: 10Amire80) [13:55:53] (03PS2) 10Reedy: ImagePage.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241285 (owner: 10Amire80) [13:55:59] (03CR) 10Reedy: [C: 032] ImagePage.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241285 (owner: 10Amire80) [14:00:25] !table page [14:00:25] For help on creating tables in wikitext, see and [14:00:30] !db page [14:00:30] See http://www.mediawiki.org/wiki/Manual:page_table [14:00:57] 10MediaWiki-extensions-GettingStarted, 10Browser-Tests, 5Patch-For-Review: Upgrade GettingStarted browser tests to use mediawiki_selenium 1.x - https://phabricator.wikimedia.org/T99655#1677482 (10zeljkofilipin) Found the password by adding `echo $MEDIAWIKI_CAPTCHA_BYPASS_PASSWORD` to the jenkins job. (I have... [14:01:13] 10MediaWiki-General-or-Unknown, 10Vector: mw-config now dosent show any styles - https://phabricator.wikimedia.org/T113843#1677483 (10Paladox) Found the trace it was caused by https://gerrit.wikimedia.org/r/#/c/240316/ [14:05:51] (03Merged) 10jenkins-bot: ImagePage.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241285 (owner: 10Amire80) [14:07:09] (03PS2) 10Reedy: StatusTest.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241300 (owner: 10Amire80) [14:07:11] (03PS1) 10Paladox: Revert "resourceloader: Improve caching for LESS file compilation" [core] - 10https://gerrit.wikimedia.org/r/241306 [14:07:22] (03CR) 10Reedy: [C: 032] StatusTest.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241300 (owner: 10Amire80) [14:07:37] (03CR) 10Paladox: "Causing styles to not be applied to mw-config" [core] - 10https://gerrit.wikimedia.org/r/241306 (owner: 10Paladox) [14:07:57] (03CR) 10jenkins-bot: [V: 04-1] Revert "resourceloader: Improve caching for LESS file compilation" [core] - 10https://gerrit.wikimedia.org/r/241306 (owner: 10Paladox) [14:08:07] (03PS2) 10Paladox: Revert "resourceloader: Improve caching for LESS file compilation" [core] - 10https://gerrit.wikimedia.org/r/241306 (https://phabricator.wikimedia.org/T113843) [14:08:25] (03CR) 10jenkins-bot: [V: 04-1] Revert "resourceloader: Improve caching for LESS file compilation" [core] - 10https://gerrit.wikimedia.org/r/241306 (https://phabricator.wikimedia.org/T113843) (owner: 10Paladox) [14:11:44] 10Wikimedia-Developer-Summit-2016: The end of shared hosting support? - https://phabricator.wikimedia.org/T113210#1677780 (10MarkAHershberger) >>! In T113210#1676649, @ssastry wrote: > Wikitext with all its complexity has gotten its visual editing because of Parsoid. PHP, even to this day, does not have a HTML5... [14:16:54] (03Merged) 10jenkins-bot: StatusTest.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241300 (owner: 10Amire80) [14:19:04] (03PS2) 10Reedy: WebRequest.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241281 (owner: 10Amire80) [14:19:12] (03CR) 10Reedy: [C: 032] WebRequest.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241281 (owner: 10Amire80) [14:28:43] c'mon jenkins [14:29:40] (03Merged) 10jenkins-bot: WebRequest.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241281 (owner: 10Amire80) [14:31:56] (03PS2) 10Reedy: MediaWikiTestCase.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241291 (owner: 10Amire80) [14:32:01] (03CR) 10Reedy: [C: 032] MediaWikiTestCase.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241291 (owner: 10Amire80) [14:41:42] (03Merged) 10jenkins-bot: MediaWikiTestCase.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241291 (owner: 10Amire80) [14:42:28] (03PS2) 10Reedy: SpecialSearchTest.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241299 (owner: 10Amire80) [14:42:35] (03CR) 10Reedy: [C: 032] SpecialSearchTest.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241299 (owner: 10Amire80) [14:44:09] (03CR) 10Zfilipin: "The correct link: https://integration.wikimedia.org/ci/job/browsertests-GettingStarted-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce-T" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/241293 (https://phabricator.wikimedia.org/T99655) (owner: 10Zfilipin) [14:44:53] 10MediaWiki-extensions-GettingStarted, 10Browser-Tests, 5Patch-For-Review: Upgrade GettingStarted browser tests to use mediawiki_selenium 1.x - https://phabricator.wikimedia.org/T99655#1678199 (10zeljkofilipin) https://integration.wikimedia.org/ci/job/browsertests-GettingStarted-en.wikipedia.beta.wmflabs.org... [14:45:11] 10MediaWiki-extensions-GettingStarted, 10Browser-Tests, 5Patch-For-Review: Upgrade GettingStarted browser tests to use mediawiki_selenium 1.x - https://phabricator.wikimedia.org/T99655#1678200 (10zeljkofilipin) The tests run fine on my machine, but they break on Jenkins. [14:52:17] (03Merged) 10jenkins-bot: SpecialSearchTest.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241299 (owner: 10Amire80) [14:53:00] (03PS1) 10Reedy: Re-enable MediaWiki.VariableAnalysis.UnusedGlobalVariables [core] - 10https://gerrit.wikimedia.org/r/241307 [14:53:15] * Reedy wonders [14:54:22] 10Wiki-Loves-Monuments-Database: ErfgoedBot should not add a category if it is a subcategory of a category alraedy there - https://phabricator.wikimedia.org/T113847#1678222 (10JeanFred) 3NEW [14:54:31] 10Wikimedia-Developer-Summit-2016: The end of shared hosting support? - https://phabricator.wikimedia.org/T113210#1678229 (10Anomie) >>! In T113210#1676649, @ssastry wrote: > So to summarize: (a) figure out if we do indeed agree that shared hosting wikis and wikpedia wikis are not the same beast except in name (... [14:55:40] (03PS11) 10Amire80: Add talk link to excontentauthor [core] - 10https://gerrit.wikimedia.org/r/124158 [14:56:37] (03CR) 10Jforrester: [C: 032] Re-enable MediaWiki.VariableAnalysis.UnusedGlobalVariables [core] - 10https://gerrit.wikimedia.org/r/241307 (owner: 10Reedy) [14:58:17] (03CR) 10Jforrester: "We're now blocked on this for I2932c9df544 which requires it (dependency on code merged into MW after the last alpha of 1.26 was released)" [core] - 10https://gerrit.wikimedia.org/r/241297 (owner: 10Jforrester) [14:59:09] (03PS1) 10Reedy: Re-enable Generic.Files.EndFileNewline.NotFound [core] - 10https://gerrit.wikimedia.org/r/241308 [15:00:57] (03PS15) 10Amire80: Add new grammar forms for language names in Russian [core] - 10https://gerrit.wikimedia.org/r/172501 [15:01:14] (03PS1) 10Reedy: Re-enable Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines [core] - 10https://gerrit.wikimedia.org/r/241309 [15:03:18] (03PS1) 10Reedy: Re-enable PSR2.Methods.MethodDeclaration.StaticBeforeVisibility [core] - 10https://gerrit.wikimedia.org/r/241310 [15:04:12] 10MediaWiki-extensions-UrlShortener, 10Wikimedia-Extension-setup, 10Wikimedia-General-or-Unknown: Review and deploy UrlShortener extension to Wikimedia wikis - https://phabricator.wikimedia.org/T108557#1678232 (10Boshomi) shortcode: Please fix bug T73578. If this bug is fixed the page_id become a peramlink s... [15:04:18] (03CR) 10Jforrester: [C: 032] Re-enable Generic.Files.EndFileNewline.NotFound [core] - 10https://gerrit.wikimedia.org/r/241308 (owner: 10Reedy) [15:04:48] (03PS1) 10Reedy: Re-enable PSR2.Methods.MethodDeclaration.AbstractAfterVisibility [core] - 10https://gerrit.wikimedia.org/r/241311 [15:05:04] (03CR) 10Amire80: [C: 032] Re-enable Generic.Files.EndFileNewline.NotFound [core] - 10https://gerrit.wikimedia.org/r/241308 (owner: 10Reedy) [15:05:09] That's a third of them fixed [15:05:10] :D [15:05:46] 10CirrusSearch, 6Discovery: Stemming highlights the wrong terms in search results - https://phabricator.wikimedia.org/T113838#1678238 (10Cpiral) [15:06:35] [15:06:36] [15:06:40] (03Merged) 10jenkins-bot: Re-enable MediaWiki.VariableAnalysis.UnusedGlobalVariables [core] - 10https://gerrit.wikimedia.org/r/241307 (owner: 10Reedy) [15:06:42] They seem to almost fight against each otehr [15:06:42] (03CR) 10jenkins-bot: [V: 04-1] Add new grammar forms for language names in Russian [core] - 10https://gerrit.wikimedia.org/r/172501 (owner: 10Amire80) [15:09:16] (03CR) 10Jforrester: [C: 032] Re-enable PSR2.Methods.MethodDeclaration.StaticBeforeVisibility [core] - 10https://gerrit.wikimedia.org/r/241310 (owner: 10Reedy) [15:09:44] (03CR) 10Jforrester: [C: 032] Re-enable PSR2.Methods.MethodDeclaration.AbstractAfterVisibility [core] - 10https://gerrit.wikimedia.org/r/241311 (owner: 10Reedy) [15:10:14] (03PS1) 10Reedy: Re-enable PSR2.Namespaces.NamespaceDeclaration.BlankLineAfter [core] - 10https://gerrit.wikimedia.org/r/241313 [15:10:22] (03CR) 10Jforrester: [C: 032] Re-enable Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines [core] - 10https://gerrit.wikimedia.org/r/241309 (owner: 10Reedy) [15:10:26] 10MediaWiki-extensions-AbuseFilter: AbuseFilter in ukwiki - https://phabricator.wikimedia.org/T113848#1678241 (10Green_Zero) 3NEW [15:10:34] 10MediaWiki-skins-Metrolook: Watchlist icon does not spin in metrolook - https://phabricator.wikimedia.org/T113849#1678248 (10Paladox) 3NEW [15:10:48] 10MediaWiki-skins-Metrolook: Watchlist icon does not spin in metrolook - https://phabricator.wikimedia.org/T113849#1678255 (10Paladox) @Ashley can I add you to this task please. [15:11:01] 10MediaWiki-skins-Metrolook: Watchlist icon does not spin in metrolook - https://phabricator.wikimedia.org/T113849#1678258 (10Paladox) [15:12:43] * Reedy waits for Jenkin [15:12:44] s [15:13:30] lots of space indent [15:14:27] (03Merged) 10jenkins-bot: Re-enable Generic.Files.EndFileNewline.NotFound [core] - 10https://gerrit.wikimedia.org/r/241308 (owner: 10Reedy) [15:15:16] Aye. [15:15:33] 10MediaWiki-Codesniffer, 10MediaWiki-General-or-Unknown: Make MediaWiki core pass mediawiki-codesniffer - https://phabricator.wikimedia.org/T102609#1678260 (10Jdforrester-WMF) [15:15:36] Those can be fixed by the script presuambly [15:16:02] Yes. [15:16:13] https://phabricator.wikimedia.org/T112261 you mean? [15:16:44] Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed [15:17:55] 10MediaWiki-Codesniffer, 10MediaWiki-General-or-Unknown: Make MediaWiki core pass mediawiki-codesniffer - https://phabricator.wikimedia.org/T102609#1678261 (10Jdforrester-WMF) [15:17:59] (03PS2) 10Amire80: Re-enable PSR2.Namespaces.NamespaceDeclaration.BlankLineAfter [core] - 10https://gerrit.wikimedia.org/r/241313 (owner: 10Reedy) [15:18:04] (03CR) 10Amire80: [C: 032] Re-enable PSR2.Namespaces.NamespaceDeclaration.BlankLineAfter [core] - 10https://gerrit.wikimedia.org/r/241313 (owner: 10Reedy) [15:18:17] Oh, hmm. I'd have thought so. [15:18:24] Can you use phpcbf? [15:18:45] There's probably a few ways of fixing it [15:19:18] (03Merged) 10jenkins-bot: Re-enable PSR2.Methods.MethodDeclaration.StaticBeforeVisibility [core] - 10https://gerrit.wikimedia.org/r/241310 (owner: 10Reedy) [15:19:20] (03CR) 10jenkins-bot: [V: 04-1] Re-enable PSR2.Methods.MethodDeclaration.AbstractAfterVisibility [core] - 10https://gerrit.wikimedia.org/r/241311 (owner: 10Reedy) [15:19:59] Guess that was gonna happen :P [15:20:20] (03Merged) 10jenkins-bot: Re-enable Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines [core] - 10https://gerrit.wikimedia.org/r/241309 (owner: 10Reedy) [15:22:45] (03PS16) 10Amire80: Add new grammar forms for language names in Russian [core] - 10https://gerrit.wikimedia.org/r/172501 [15:23:26] (03PS2) 10Jforrester: Re-enable PSR2.Methods.MethodDeclaration.AbstractAfterVisibility [core] - 10https://gerrit.wikimedia.org/r/241311 (owner: 10Reedy) [15:23:39] I was about to do that [15:23:43] (03CR) 10Jforrester: [C: 032] Re-enable PSR2.Methods.MethodDeclaration.AbstractAfterVisibility [core] - 10https://gerrit.wikimedia.org/r/241311 (owner: 10Reedy) [15:23:49] Or had, done that, but git fetch needed etc [15:23:50] ffs [15:23:50] Reedy: Sorry. ;-) [15:24:17] I should sort it so I don't need both the origin and the gerrit remotes [15:24:54] Yes. [15:25:02] (Why do you have that?) [15:26:40] 4(no projects): UploadWizard Flickr does not display the images during Step 4 - https://phabricator.wikimedia.org/T113850#1678267 (10JeanFred) 3NEW [15:26:56] James_F: legacy [15:27:02] Ah, yeah. [15:27:02] I should dig up the fix [15:27:08] I used to have it too. [15:27:16] But I re-cloned the world and it went away. [15:27:27] Oh? Just recloning is enough? [15:27:34] I think so. [15:27:47] Normally if I didn't know I'd ask you, so… ;-) [15:28:03] (03Merged) 10jenkins-bot: Re-enable PSR2.Namespaces.NamespaceDeclaration.BlankLineAfter [core] - 10https://gerrit.wikimedia.org/r/241313 (owner: 10Reedy) [15:28:05] (03CR) 10jenkins-bot: [V: 04-1] Re-enable PSR2.Methods.MethodDeclaration.AbstractAfterVisibility [core] - 10https://gerrit.wikimedia.org/r/241311 (owner: 10Reedy) [15:28:09] 10Wikimedia-Developer-Summit-2016: The end of shared hosting support? - https://phabricator.wikimedia.org/T113210#1678280 (10ssastry) >>! In T113210#1677780, @MarkAHershberger wrote: >>>! In T113210#1676649, @ssastry wrote: >> Wikitext with all its complexity has gotten its visual editing because of Parsoid. PHP... [15:28:22] DAMN IT JENINS [15:28:26] JENKINS [15:28:29] Meh. [15:28:33] Again. [15:28:42] Reedy: In future, just chain all the commits on top of one another. ;-) [15:28:46] I should've probably done them as a chain [15:28:47] Yeah [15:28:51] Snap. [15:28:53] Want me to rebase [15:28:58] Sure. [15:31:30] (03PS3) 10Reedy: Re-enable PSR2.Methods.MethodDeclaration.AbstractAfterVisibility [core] - 10https://gerrit.wikimedia.org/r/241311 [15:33:30] (03PS1) 10Amire80: Cleanup LanguageTyv.php [core] - 10https://gerrit.wikimedia.org/r/241316 [15:33:59] (03CR) 10Jforrester: [C: 032] Re-enable PSR2.Methods.MethodDeclaration.AbstractAfterVisibility [core] - 10https://gerrit.wikimedia.org/r/241311 (owner: 10Reedy) [15:34:01] (03PS1) 10Zfilipin: Updated RuboCop to the latest version [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/241317 [15:36:10] (03CR) 10jenkins-bot: [V: 04-1] Updated RuboCop to the latest version [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/241317 (owner: 10Zfilipin) [15:36:51] (03PS1) 10Amire80: Make the comment in the beginning of LanguageFi.php shorter [core] - 10https://gerrit.wikimedia.org/r/241319 [15:37:36] 6Revscoring: (Reading) Thesis: Detecting Vandalism on Wikipedia across Multiple Languages - https://phabricator.wikimedia.org/T113851#1678286 (10ToAruShiroiNeko) 3NEW [15:37:37] (03CR) 10Jforrester: [C: 031] Add wfWaitForSlaves() call in DatabaseUpdater::runUpdates() [core] - 10https://gerrit.wikimedia.org/r/141049 (https://phabricator.wikimedia.org/T68887) (owner: 10Reedy) [15:38:20] 7Design, 10MediaWiki-Page-editing, 6Editing-Department, 10VisualEditor, and 2 others: Make the mobile edit conflict screen nicer to use - https://phabricator.wikimedia.org/T113844#1678294 (10matmarex) [15:39:17] (03PS1) 10Zfilipin: Fixed Style/IndentationWidth RuboCop offense [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/241320 (https://phabricator.wikimedia.org/T113846) [15:39:19] (03PS1) 10Zfilipin: Fixed Style/SpaceInsideStringInterpolation RuboCop offense [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/241321 (https://phabricator.wikimedia.org/T113846) [15:39:21] (03PS1) 10Zfilipin: Fixed Style/StringLiterals RuboCop offense [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/241322 (https://phabricator.wikimedia.org/T113846) [15:39:23] (03PS1) 10Zfilipin: Fixed Style/Tab RuboCop offense [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/241323 (https://phabricator.wikimedia.org/T113846) [15:39:59] (03PS1) 10Reedy: Re-enable Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed [core] - 10https://gerrit.wikimedia.org/r/241324 [15:40:04] That ones nasty [15:40:59] Yeah, I don't like it [15:41:05] (03Abandoned) 10Reedy: Re-enable Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed [core] - 10https://gerrit.wikimedia.org/r/241324 (owner: 10Reedy) [15:41:34] OK. :-) [15:41:58] The really naieve way I did it just messed up the indenting [15:42:16] Needs a bit more care [15:42:17] Did you s/ /\t/ or something? [15:42:49] find -P . -type f -regextype egrep -regex '.*\.(php)$' -print0 | xargs -0 sed -i"" -e ':repeat; s/^\(\t*\) /\1\t/; t repeat' [15:43:02] hallo [15:43:05] (03CR) 10jenkins-bot: [V: 04-1] Fixed Style/Tab RuboCop offense [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/241323 (https://phabricator.wikimedia.org/T113846) (owner: 10Zfilipin) [15:43:08] Ha. [15:43:24] Shall I do "Line exceeds 100 characters"? [15:43:33] I have enough examples at https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs/60/consoleFull [15:43:51] Oh dear. [15:43:52] (I mean, the rest of "Line exceeds 100 characters" - I already did a bunch.) [15:43:53] Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 72 bytes) in /Users/jdforrester/Documents/git/vagrant/mediawiki/vendor/squizlabs/php_codesniffer/CodeSniffer/Tokenizers/PHP.php on line 692 [15:44:02] aharoni: If you want. :-) [15:44:05] (03Merged) 10jenkins-bot: Re-enable PSR2.Methods.MethodDeclaration.AbstractAfterVisibility [core] - 10https://gerrit.wikimedia.org/r/241311 (owner: 10Reedy) [15:44:21] * James_F goes for a walk. [15:44:40] I've been with the baby all day, he got me tired, it's a good way to rest. [15:45:30] * Reedy does SingleSpaceAfterOpenParenthesis [15:45:40] Fixing some BeforeClose if they're on the same lines too [15:45:58] (03PS3) 10Zfilipin: WIP Upgrade browser tests to use mediawiki_selenium 1.x Ruby gem [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/241293 (https://phabricator.wikimedia.org/T99655) [15:47:11] (03CR) 10jenkins-bot: [V: 04-1] WIP Upgrade browser tests to use mediawiki_selenium 1.x Ruby gem [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/241293 (https://phabricator.wikimedia.org/T99655) (owner: 10Zfilipin) [15:48:37] (03PS1) 10Reedy: Re-enable MediaWiki.WhiteSpace.SpaceyParenthesis.SingleSpaceAfterOpenParenthesis [core] - 10https://gerrit.wikimedia.org/r/241325 [15:48:47] I think that one might be missing a few, so jenkins will fail it [15:53:41] 10Wikimedia-Developer-Summit-2016: The end of shared hosting support? - https://phabricator.wikimedia.org/T113210#1678303 (10ssastry) >>! In T113210#1678229, @Anomie wrote: >>>! In T113210#1676649, @ssastry wrote: >> So to summarize: (a) figure out if we do indeed agree that shared hosting wikis and wikpedia wik... [15:54:08] (03PS1) 10Reedy: Re-eanble Squiz.WhiteSpace.ScopeClosingBrace.Indent [core] - 10https://gerrit.wikimedia.org/r/241326 [15:54:49] (03PS1) 10Amire80: WIP Fix LineLength in includes/media [core] - 10https://gerrit.wikimedia.org/r/241327 [15:54:57] (03CR) 10Reedy: [C: 04-1] "Fixing" [core] - 10https://gerrit.wikimedia.org/r/241325 (owner: 10Reedy) [15:57:11] (03PS2) 10Reedy: Re-enable MediaWiki.WhiteSpace.SpaceyParenthesis.SingleSpaceAfterOpenParenthesis [core] - 10https://gerrit.wikimedia.org/r/241325 [16:00:02] Reedy: https://gerrit.wikimedia.org/r/#/c/241327/ [16:00:13] XMP.php still fails [16:00:30] @codingStandardsIgnoreStart doesn't help [16:00:43] is there some other way to do it? [16:01:20] That's what I did in another file [16:01:31] And it seemed to work [16:01:33] 10Wikimedia-Developer-Summit-2016: The end of shared hosting support? - https://phabricator.wikimedia.org/T113210#1678304 (10ssastry) >>! In T113210#1678280, @ssastry wrote: >>>! In T113210#1677780, @MarkAHershberger wrote: >>>>! In T113210#1676649, @ssastry wrote: >>> Wikitext with all its complexity has gotten... [16:03:23] 10Wikimedia-General-or-Unknown, 6Wikisource: Special:IndexPages not shown total Index Pages in Bengali Wikisource ( https://bn.wikisource.org/) - https://phabricator.wikimedia.org/T111235#1678305 (10Zdzislaw) @Billinghurst as I mentioned in T93397, if we want to make //Special:IndexPages// showing the **curren... [16:03:27] Reedy: well, that's not what https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs/100/consoleFull says. [16:04:18] (03PS3) 10Reedy: Re-enable MediaWiki.WhiteSpace.SpaceyParenthesis.SingleSpaceAfterOpenParenthesis [core] - 10https://gerrit.wikimedia.org/r/241325 [16:05:24] aharoni: I don't see any codingStandardsIgnoreStart in your patch.. Does it exist already? [16:05:32] 10MediaWiki-Codesniffer, 10MediaWiki-General-or-Unknown, 5MW-1.26-release, 5Patch-For-Review: Fix Generic.Files.LineLength errors in MediaWiki core by breaking long lines - https://phabricator.wikimedia.org/T102614#1678307 (10Amire80) I'd actually go for fixing all the errors under the languages/ directory... [16:05:39] Yes, it was already there. [16:05:44] mmm [16:05:51] Reedy: line 1284 [16:05:58] see https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs/100/consoleFull [16:06:52] I wonder if it's cause it's in /* */ block? [16:08:49] Does it work if you just put // @ [16:10:16] aharoni: My current 2 are ready to go... [16:10:34] (03CR) 10OliverKeyes: [C: 032 V: 032] Fixes dashboard titles [wikimedia/discovery/twilightsparql] - 10https://gerrit.wikimedia.org/r/241119 (owner: 10Bearloga) [16:13:14] (03PS4) 10Reedy: Re-enable MediaWiki.WhiteSpace.SpaceyParenthesis.SingleSpaceAfterOpenParenthesis [core] - 10https://gerrit.wikimedia.org/r/241325 [16:13:57] (03CR) 10jenkins-bot: [V: 04-1] Re-enable Squiz.WhiteSpace.ScopeClosingBrace.Indent [core] - 10https://gerrit.wikimedia.org/r/241326 (owner: 10Reedy) [16:14:02] lol [16:14:17] (03CR) 10Reedy: "recheck" [core] - 10https://gerrit.wikimedia.org/r/241326 (owner: 10Reedy) [16:17:03] (03PS1) 10Reedy: [WIP] Re-enable MediaWiki.WhiteSpace.SpaceyParenthesis.SingleSpaceBeforeCloseParenthesis [core] - 10https://gerrit.wikimedia.org/r/241331 [16:19:35] (03CR) 10Amire80: [C: 032] Re-enable MediaWiki.WhiteSpace.SpaceyParenthesis.SingleSpaceAfterOpenParenthesis [core] - 10https://gerrit.wikimedia.org/r/241325 (owner: 10Reedy) [16:19:40] :D [16:20:55] (03CR) 10Amire80: [C: 032] Re-enable Squiz.WhiteSpace.ScopeClosingBrace.Indent [core] - 10https://gerrit.wikimedia.org/r/241326 (owner: 10Reedy) [16:23:55] 10MediaWiki-Codesniffer, 10MediaWiki-General-or-Unknown, 5MW-1.26-release, 5Patch-For-Review: @codingStandardsIgnoreStart doesn't seem to help avoid phpcs errors inside comments - https://phabricator.wikimedia.org/T113852#1678312 (10Amire80) 3NEW [16:24:12] 10MediaWiki-Codesniffer, 10MediaWiki-General-or-Unknown, 5MW-1.26-release, 5Patch-For-Review: @codingStandardsIgnoreStart doesn't seem to help avoid phpcs errors inside comments - https://phabricator.wikimedia.org/T113852#1678312 (10Amire80) [16:24:34] 10MediaWiki-Codesniffer, 10MediaWiki-General-or-Unknown, 5MW-1.26-release, 5Patch-For-Review: Fix Generic.Files.LineLength errors in MediaWiki core by breaking long lines - https://phabricator.wikimedia.org/T102614#1678320 (10Amire80) a:3Amire80 [16:24:47] (03PS2) 10Amire80: WIP Fix LineLength in includes/media [core] - 10https://gerrit.wikimedia.org/r/241327 (https://phabricator.wikimedia.org/T102614) [16:25:55] (03PS3) 10Amire80: Fix LineLength in includes/media [core] - 10https://gerrit.wikimedia.org/r/241327 (https://phabricator.wikimedia.org/T102614) [16:26:23] (03PS2) 10Reedy: Re-enable MediaWiki.WhiteSpace.SpaceyParenthesis.SingleSpaceBeforeCloseParenthesis [core] - 10https://gerrit.wikimedia.org/r/241331 [16:26:25] 6Discovery, 10Maps, 10Performance-Metrics-Dashboard, 3Discovery-Maps-Sprint, 3Wikipedia-Android-App: KPI - Identify maps traffic from Mobile App - https://phabricator.wikimedia.org/T113829#1678324 (10Ironholds_backup) Is this actually a KPI? That is, specifically that we're tracking App stuff? And, Tomas... [16:29:53] (03Merged) 10jenkins-bot: Re-enable MediaWiki.WhiteSpace.SpaceyParenthesis.SingleSpaceAfterOpenParenthesis [core] - 10https://gerrit.wikimedia.org/r/241325 (owner: 10Reedy) [16:33:20] 10MediaWiki-Codesniffer, 10MediaWiki-General-or-Unknown, 5Patch-For-Review: @codingStandardsIgnoreStart doesn't seem to help avoid phpcs errors inside comments - https://phabricator.wikimedia.org/T113852#1678328 (10Reedy) [16:35:27] (03CR) 10Jforrester: [C: 04-1] "Need to fix it everywhere to make the patch pass phpcs." [core] - 10https://gerrit.wikimedia.org/r/241327 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [16:35:33] 10MediaWiki-Codesniffer, 10MediaWiki-General-or-Unknown: Make MediaWiki core pass mediawiki-codesniffer - https://phabricator.wikimedia.org/T102609#1678330 (10Jdforrester-WMF) [16:37:25] (03CR) 10Jforrester: [C: 04-1] Re-enable MediaWiki.WhiteSpace.SpaceyParenthesis.SingleSpaceBeforeCloseParenthesis (031 comment) [core] - 10https://gerrit.wikimedia.org/r/241331 (owner: 10Reedy) [16:39:14] 10MediaWiki-Codesniffer: @codingStandardsIgnoreStart doesn't seem to help avoid phpcs errors inside comments - https://phabricator.wikimedia.org/T113852#1678331 (10Jdforrester-WMF) [16:39:19] (03PS3) 10Reedy: Re-enable MediaWiki.WhiteSpace.SpaceyParenthesis.SingleSpaceBeforeCloseParenthesis [core] - 10https://gerrit.wikimedia.org/r/241331 [16:39:25] (03Merged) 10jenkins-bot: Re-enable Squiz.WhiteSpace.ScopeClosingBrace.Indent [core] - 10https://gerrit.wikimedia.org/r/241326 (owner: 10Reedy) [16:39:53] 10Wikimedia-General-or-Unknown, 7JavaScript: Move code in enwiki MediaWiki:Common.js and Gadgets to MediaWiki software - https://phabricator.wikimedia.org/T71550#1678332 (10He7d3r) [16:42:25] (03PS1) 10Reedy: Re-enable Squiz.WhiteSpace.SemicolonSpacing.Incorrect [core] - 10https://gerrit.wikimedia.org/r/241334 [16:42:26] Some of these are seriously easy to fix :P [16:43:06] (03CR) 10Jforrester: [C: 032] Re-enable MediaWiki.WhiteSpace.SpaceyParenthesis.SingleSpaceBeforeCloseParenthesis [core] - 10https://gerrit.wikimedia.org/r/241331 (owner: 10Reedy) [16:45:41] (03PS1) 10Reedy: Re-enable Generic.CodeAnalysis.ForLoopWithTestFunctionCall.NotAllowed [core] - 10https://gerrit.wikimedia.org/r/241335 [16:46:12] (03CR) 10Jforrester: [C: 032] Re-enable Squiz.WhiteSpace.SemicolonSpacing.Incorrect [core] - 10https://gerrit.wikimedia.org/r/241334 (owner: 10Reedy) [16:46:56] 10MediaWiki-Codesniffer, 10MediaWiki-General-or-Unknown: Make MediaWiki core pass mediawiki-codesniffer - https://phabricator.wikimedia.org/T102609#1678334 (10Jdforrester-WMF) [16:49:04] (03PS1) 10Amire80: Linker.php: Make long lines shorter to pass phpcs [core] - 10https://gerrit.wikimedia.org/r/241336 (https://phabricator.wikimedia.org/T102614) [16:51:41] (03PS7) 10Ferdbold: [WIP] Add padding support to graph editing [extensions/Graph] - 10https://gerrit.wikimedia.org/r/228984 [16:52:26] (03CR) 10Jforrester: [C: 032] Re-enable Generic.CodeAnalysis.ForLoopWithTestFunctionCall.NotAllowed [core] - 10https://gerrit.wikimedia.org/r/241335 (owner: 10Reedy) [16:53:06] (03Merged) 10jenkins-bot: Re-enable MediaWiki.WhiteSpace.SpaceyParenthesis.SingleSpaceBeforeCloseParenthesis [core] - 10https://gerrit.wikimedia.org/r/241331 (owner: 10Reedy) [16:58:00] (03CR) 10Raimond Spekking: [C: 04-1] "I have the same doubt as Siebrand. I would like to see a combination of 1 translatable string and a variable for the language: i.e. "Showi" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/240964 (https://phabricator.wikimedia.org/T112349) (owner: 10Smalyshev) [16:59:10] 10MediaWiki-Codesniffer, 10MediaWiki-General-or-Unknown: Make MediaWiki core pass mediawiki-codesniffer - https://phabricator.wikimedia.org/T102609#1678336 (10Jdforrester-WMF) [17:00:06] 10PageImages: Thumbnail of the specific image is not created - https://phabricator.wikimedia.org/T113853#1678337 (10Comseong) 3NEW [17:00:08] * James_F wonders if legoktm will be online today to make the job voting so we don't have any regressions. [17:00:12] (03CR) 10Smalyshev: "The results can be from any wiki, not necessarily Wikipedia, and as far as I know there's no way to identify a particular wiki as "Wikiped" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/240964 (https://phabricator.wikimedia.org/T112349) (owner: 10Smalyshev) [17:00:14] (03PS1) 10Amire80: Make long lines shorter to pass phpcs in 6 files [core] - 10https://gerrit.wikimedia.org/r/241337 (https://phabricator.wikimedia.org/T102614) [17:00:33] 10CirrusSearch, 6Discovery: Stemming highlights the wrong terms in search results - https://phabricator.wikimedia.org/T113838#1678346 (10Cpiral) [[https://www.mediawiki.org/wiki/special:search/%22cloud%22%20prefix:user:cpiral | "cloud" prefix:user:cpiral ]] As for the "researchers" use case, I'll respond at T... [17:01:09] (03Merged) 10jenkins-bot: Re-enable Squiz.WhiteSpace.SemicolonSpacing.Incorrect [core] - 10https://gerrit.wikimedia.org/r/241334 (owner: 10Reedy) [17:01:42] (03PS4) 10Amire80: Fix LineLength in includes/media [core] - 10https://gerrit.wikimedia.org/r/241327 (https://phabricator.wikimedia.org/T102614) [17:04:47] (03PS1) 10Reedy: Re-enable MediaWiki.WhiteSpace.SpaceAfterControlStructure.Incorrect [core] - 10https://gerrit.wikimedia.org/r/241338 [17:04:59] James_F: I think that's the last of the easy ones :P [17:05:12] Reedy: Impressed there were so many. [17:05:52] (03Merged) 10jenkins-bot: Re-enable Generic.CodeAnalysis.ForLoopWithTestFunctionCall.NotAllowed [core] - 10https://gerrit.wikimedia.org/r/241335 (owner: 10Reedy) [17:06:59] (03PS2) 10Amire80: Linker.php: Make long lines shorter to pass phpcs [core] - 10https://gerrit.wikimedia.org/r/241336 (https://phabricator.wikimedia.org/T102614) [17:07:07] (03CR) 10Raimond Spekking: "@Smalyshev: You wrote: "The results can be from any wiki, not necessarily Wikipedia..." but all ~ 280 new messages refers to Wikipedia. Th" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/240964 (https://phabricator.wikimedia.org/T112349) (owner: 10Smalyshev) [17:07:09] (03PS2) 10Amire80: Make long lines shorter to pass phpcs in 6 files [core] - 10https://gerrit.wikimedia.org/r/241337 (https://phabricator.wikimedia.org/T102614) [17:07:46] https://github.com/wikimedia/mediawiki-tools-codesniffer/blob/master/MediaWiki/Sniffs/NamingConventions/PrefixedGlobalFunctionsSniff.php [17:07:54] That would just needs disabling for maintenance/ [17:08:06] (03CR) 10Smalyshev: "Yes, I only imported wikipedia ones because *right now* we just need a limited number for the test. If that works, we'll import more." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/240964 (https://phabricator.wikimedia.org/T112349) (owner: 10Smalyshev) [17:09:19] 10CirrusSearch, 6Discovery: Search results consisting of titles only - https://phabricator.wikimedia.org/T113840#1678352 (10Cpiral) [17:10:48] 6WMF-Design-Research, 6Editing-Department, 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10VisualEditor-MediaWiki-Mobile: Sometimes in mobile, link suggestions open up in the wrong place, off to the side and not attached to the text box - https://phabricator.wikimedia.org/T113643#1678355 (10Esanders) F... [17:11:02] 6WMF-Design-Research, 6Editing-Department, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: In mobile, link suggestions only show on focus, go away when you close the keyboard (e.g. to see more of them) - https://phabricator.wikimedia.org/T113636#1678359 (10Esanders) Fixing T101169 will resolve this [17:11:05] (03CR) 10Jforrester: [C: 032] Fix LineLength in includes/media [core] - 10https://gerrit.wikimedia.org/r/241327 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [17:11:33] (03CR) 10Jforrester: [C: 032] Linker.php: Make long lines shorter to pass phpcs [core] - 10https://gerrit.wikimedia.org/r/241336 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [17:12:22] (03CR) 10Jforrester: [C: 032] Make long lines shorter to pass phpcs in 6 files [core] - 10https://gerrit.wikimedia.org/r/241337 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [17:12:33] (03CR) 10Jforrester: [C: 032] WebStart.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241280 (owner: 10Amire80) [17:14:31] (03CR) 10Jforrester: [C: 032] Re-enable MediaWiki.WhiteSpace.SpaceAfterControlStructure.Incorrect [core] - 10https://gerrit.wikimedia.org/r/241338 (owner: 10Reedy) [17:14:51] 10MediaWiki-Codesniffer, 10MediaWiki-General-or-Unknown: Make MediaWiki core pass mediawiki-codesniffer - https://phabricator.wikimedia.org/T102609#1678361 (10Jdforrester-WMF) [17:16:01] 10CirrusSearch, 6Discovery: Decide how to handle avro schemas changes - https://phabricator.wikimedia.org/T113795#1678362 (10EBernhardson) It looks like, at least in theory (untested), we just create external tables in hive that point at the files camus creates, with the right avro schema, and it will "just wo... [17:19:34] 10PageImages: Thumbnail of the specific image is not created - https://phabricator.wikimedia.org/T113853#1678363 (10Comseong) [17:19:41] Reedy: TBF `git log --oneline --no-merges --format='* %s (%aN)' phpcs.xml` makes you look like a bit of an over-achiever. ;-) [17:19:47] (03PS1) 10Amire80: Make lines shorter to pass phpcs in some files under includes/parser [core] - 10https://gerrit.wikimedia.org/r/241339 (https://phabricator.wikimedia.org/T102614) [17:21:51] (03Merged) 10jenkins-bot: Fix LineLength in includes/media [core] - 10https://gerrit.wikimedia.org/r/241327 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [17:21:55] (03Merged) 10jenkins-bot: Linker.php: Make long lines shorter to pass phpcs [core] - 10https://gerrit.wikimedia.org/r/241336 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [17:22:33] (03CR) 10jenkins-bot: [V: 04-1] Make lines shorter to pass phpcs in some files under includes/parser [core] - 10https://gerrit.wikimedia.org/r/241339 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [17:23:09] (03PS8) 10Ferdbold: [WIP] Add padding support to graph editing [extensions/Graph] - 10https://gerrit.wikimedia.org/r/228984 [17:23:39] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add padding support to graph editing [extensions/Graph] - 10https://gerrit.wikimedia.org/r/228984 (owner: 10Ferdbold) [17:23:59] (03PS1) 10Paladox: Revert "Backport I1ff61153d and I8e4c3d5a5" [core] (wmf/1.26wmf24) - 10https://gerrit.wikimedia.org/r/241340 [17:24:42] 10MediaWiki-General-or-Unknown, 10Vector, 5Patch-For-Review: mw-config now dosent show any styles - https://phabricator.wikimedia.org/T113843#1678370 (10Paladox) [17:24:48] (03PS2) 10Paladox: Revert "Backport I1ff61153d and I8e4c3d5a5" [core] (wmf/1.26wmf24) - 10https://gerrit.wikimedia.org/r/241340 (https://phabricator.wikimedia.org/T113843) [17:25:01] (03CR) 10Aaron Schulz: [C: 032] Add wfWaitForSlaves() call in DatabaseUpdater::runUpdates() [core] - 10https://gerrit.wikimedia.org/r/141049 (https://phabricator.wikimedia.org/T68887) (owner: 10Reedy) [17:25:05] 10MediaWiki-General-or-Unknown, 10MediaWiki-ResourceLoader, 10Vector, 5Patch-For-Review: mw-config now dosent show any styles - https://phabricator.wikimedia.org/T113843#1678372 (10Paladox) [17:25:19] (03CR) 10Reedy: "Does this actually break anything in WMF wikis?" [core] (wmf/1.26wmf24) - 10https://gerrit.wikimedia.org/r/241340 (https://phabricator.wikimedia.org/T113843) (owner: 10Paladox) [17:25:43] (03PS1) 10Reedy: Swap leading spaces for tabs in ResourceLoaderStartUpModuleTest.php [core] - 10https://gerrit.wikimedia.org/r/241341 [17:25:49] (03CR) 10Paladox: "Woops wrong one. I was meant to do it on master." [core] (wmf/1.26wmf24) - 10https://gerrit.wikimedia.org/r/241340 (https://phabricator.wikimedia.org/T113843) (owner: 10Paladox) [17:26:34] (03PS1) 10Paladox: Revert "resourceloader: Use FileContentsHasher in safeFileHash()" [core] - 10https://gerrit.wikimedia.org/r/241342 [17:26:48] (03PS2) 10Paladox: Revert "resourceloader: Use FileContentsHasher in safeFileHash()" [core] - 10https://gerrit.wikimedia.org/r/241342 (https://phabricator.wikimedia.org/T113843) [17:26:55] (03Abandoned) 10Paladox: Revert "Backport I1ff61153d and I8e4c3d5a5" [core] (wmf/1.26wmf24) - 10https://gerrit.wikimedia.org/r/241340 (https://phabricator.wikimedia.org/T113843) (owner: 10Paladox) [17:27:02] (03CR) 10Reedy: [C: 04-1] Swap leading spaces for tabs in ResourceLoaderStartUpModuleTest.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/241341 (owner: 10Reedy) [17:28:51] 10MediaWiki-General-or-Unknown, 10MediaWiki-ResourceLoader, 10Vector, 5Patch-For-Review: mw-config now dosent show any styles - https://phabricator.wikimedia.org/T113843#1678375 (10Paladox) Unless it is a extension which is unlikely since when the wmf1.26wmf24 was created I downloaded it and uploaded it to... [17:29:24] (03PS2) 10Reedy: Swap leading spaces for tabs in ResourceLoaderStartUpModuleTest.php [core] - 10https://gerrit.wikimedia.org/r/241341 [17:30:26] Hmm... Do I fix the leading spaces in embedded xml files? [17:30:42] tests/phpunit/maintenance/backupTextPassTest.php [17:30:51] (03Merged) 10jenkins-bot: Make long lines shorter to pass phpcs in 6 files [core] - 10https://gerrit.wikimedia.org/r/241337 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [17:30:55] (03Merged) 10jenkins-bot: WebStart.php: Make lines shorter to make phpcs happier [core] - 10https://gerrit.wikimedia.org/r/241280 (owner: 10Amire80) [17:30:57] (03CR) 10jenkins-bot: [V: 04-1] Re-enable MediaWiki.WhiteSpace.SpaceAfterControlStructure.Incorrect [core] - 10https://gerrit.wikimedia.org/r/241338 (owner: 10Reedy) [17:31:01] do i dare to eat a peach? [17:31:13] come again? [17:31:19] i shall wear white flannel trousers, and walk upon the beach. [17:31:19] 10MediaWiki-General-or-Unknown, 10MediaWiki-ResourceLoader, 10Vector, 5Patch-For-Review: mw-config now dosent show any styles - https://phabricator.wikimedia.org/T113843#1678378 (10Paladox) Js only broke if you reverted one patch. So doing the other one fixed it. [17:32:04] paladox being ploblematic [17:32:35] (03CR) 10jenkins-bot: [V: 04-1] Swap leading spaces for tabs in ResourceLoaderStartUpModuleTest.php [core] - 10https://gerrit.wikimedia.org/r/241341 (owner: 10Reedy) [17:32:40] twist: paladox is Tim Starling's alter-ego [17:32:42] (03PS2) 10Reedy: Re-enable MediaWiki.WhiteSpace.SpaceAfterControlStructure.Incorrect [core] - 10https://gerrit.wikimedia.org/r/241338 [17:35:10] (03Merged) 10jenkins-bot: Add wfWaitForSlaves() call in DatabaseUpdater::runUpdates() [core] - 10https://gerrit.wikimedia.org/r/141049 (https://phabricator.wikimedia.org/T68887) (owner: 10Reedy) [17:36:32] (03CR) 10Jforrester: [C: 032] Re-enable MediaWiki.WhiteSpace.SpaceAfterControlStructure.Incorrect [core] - 10https://gerrit.wikimedia.org/r/241338 (owner: 10Reedy) [17:36:40] (03CR) 10Ori.livneh: [C: 032] Re-enable MediaWiki.WhiteSpace.SpaceAfterControlStructure.Incorrect [core] - 10https://gerrit.wikimedia.org/r/241338 (owner: 10Reedy) [17:36:44] doh [17:37:58] 10MediaWiki-Codesniffer, 10MediaWiki-General-or-Unknown: Fix Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed - https://phabricator.wikimedia.org/T113854#1678385 (10Reedy) 3NEW [17:39:09] 10CirrusSearch, 6Discovery: Investigate collecting click through for all search result hits - https://phabricator.wikimedia.org/T113816#1678391 (10EBernhardson) I wonder if we could also use googles referrer information to improve our own search results. We wouldn't know the position of the rankings but we cou... [17:40:32] (03CR) 10Aaron Schulz: [C: 032] Remove redundant $db->resultObject() call [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/241275 (owner: 10PleaseStand) [17:42:00] (03CR) 10Aaron Schulz: [C: 032] Remove redundant $db->resultObject() calls [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/241276 (owner: 10PleaseStand) [17:42:37] (03CR) 10Aaron Schulz: "recheck" [extensions/Video] - 10https://gerrit.wikimedia.org/r/241278 (owner: 10PleaseStand) [17:42:40] (03CR) 10Aaron Schulz: "recheck" [extensions/OAI] - 10https://gerrit.wikimedia.org/r/241279 (owner: 10PleaseStand) [17:44:35] (03CR) 10Aaron Schulz: [C: 032] Remove redundant $db->resultObject() call [extensions/OAI] - 10https://gerrit.wikimedia.org/r/241279 (owner: 10PleaseStand) [17:46:24] (03Merged) 10jenkins-bot: Re-enable MediaWiki.WhiteSpace.SpaceAfterControlStructure.Incorrect [core] - 10https://gerrit.wikimedia.org/r/241338 (owner: 10Reedy) [17:46:28] (03CR) 10jenkins-bot: [V: 04-1] Remove redundant $db->resultObject() call [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/241275 (owner: 10PleaseStand) [17:46:32] (03Merged) 10jenkins-bot: Remove redundant $db->resultObject() calls [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/241276 (owner: 10PleaseStand) [17:46:34] (03CR) 10jenkins-bot: [V: 04-1] Remove redundant $db->resultObject() call [extensions/OAI] - 10https://gerrit.wikimedia.org/r/241279 (owner: 10PleaseStand) [17:46:54] (03CR) 10Aaron Schulz: "recheck" [extensions/Video] - 10https://gerrit.wikimedia.org/r/241278 (owner: 10PleaseStand) [17:47:32] (03CR) 10Reedy: [C: 032 V: 032] "Test failures are unrelated. Forcing" [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/241275 (owner: 10PleaseStand) [17:49:35] (03CR) 10Aaron Schulz: "recheck" [extensions/OAI] - 10https://gerrit.wikimedia.org/r/241279 (owner: 10PleaseStand) [17:50:13] 10MediaWiki-Internationalization, 10MediaWiki-Page-editing, 7Epic, 7Upstream: Vertical writing support in MediaWiki - https://phabricator.wikimedia.org/T11436#1678393 (10brion) This one's been on the back burner... note that the just-released Firefox 41 has enabled vertical layout support, making this inve... [17:51:02] (03CR) 10Aaron Schulz: [C: 032 V: 032] Remove redundant $db->resultObject() call [extensions/Video] - 10https://gerrit.wikimedia.org/r/241278 (owner: 10PleaseStand) [17:51:19] (03Merged) 10jenkins-bot: Remove redundant $db->resultObject() call [extensions/Video] - 10https://gerrit.wikimedia.org/r/241278 (owner: 10PleaseStand) [17:51:21] (03CR) 10Aaron Schulz: [V: 032] Remove redundant $db->resultObject() call [extensions/OAI] - 10https://gerrit.wikimedia.org/r/241279 (owner: 10PleaseStand) [17:52:22] 10Gerrit, 10SyntaxHighlight: Rename git repo to "SyntaxHighlight" - https://phabricator.wikimedia.org/T103614#1678394 (10Paladox) Hi do you know when would we be ready to do the migration. [17:53:50] 10Phabricator-Upstream: Send a regular email with a saved search (like Bugzilla's "whining" for saved searches) - https://phabricator.wikimedia.org/T76825#1678398 (10scfc) [17:54:31] (03PS2) 10Amire80: Make lines shorter to pass phpcs in some files under includes/parser [core] - 10https://gerrit.wikimedia.org/r/241339 (https://phabricator.wikimedia.org/T102614) [17:55:09] (03PS1) 10Aaron Schulz: Removed used of resultObject() in QueryPage [core] - 10https://gerrit.wikimedia.org/r/241343 [17:55:22] (03PS1) 10Reedy: Swap leading spaces to tabs in backup phpunit tests [core] - 10https://gerrit.wikimedia.org/r/241344 [17:55:31] Reedy: https://gerrit.wikimedia.org/r/241343 [17:55:58] (03PS3) 10Amire80: Make lines shorter to pass phpcs in some files under includes/parser [core] - 10https://gerrit.wikimedia.org/r/241339 (https://phabricator.wikimedia.org/T102614) [17:56:16] (03CR) 10Reedy: [C: 032] Removed used of resultObject() in QueryPage [core] - 10https://gerrit.wikimedia.org/r/241343 (owner: 10Aaron Schulz) [17:56:40] 6Wikisource: Edit Modus Alert - https://phabricator.wikimedia.org/T113855#1678399 (10Starshollow) 3NEW [17:56:50] 10MediaWiki-Codesniffer, 10MediaWiki-General-or-Unknown: Fix Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed - https://phabricator.wikimedia.org/T113854#1678407 (10Reedy) Trying the xml dump/backup tests spaces -> tabs in https://gerrit.wikimedia.org/r/#/c/241344/ .... [17:58:30] (03CR) 10Bartosz Dziewoński: [C: 032] Use a constructive button on Special:MovePage [core] - 10https://gerrit.wikimedia.org/r/241072 (https://phabricator.wikimedia.org/T113493) (owner: 10Florianschmidtwelzow) [17:58:37] (03PS9) 10Ferdbold: [WIP] Add padding support to graph editing [extensions/Graph] - 10https://gerrit.wikimedia.org/r/228984 [17:59:44] 10MediaWiki-extensions-Graph-VE: Edit graph padding in VisualEditor - https://phabricator.wikimedia.org/T113856#1678408 (10ferdbold) 3NEW a:3ferdbold [18:00:11] (03PS10) 10Ferdbold: [WIP] Add padding support to graph editing [extensions/Graph] - 10https://gerrit.wikimedia.org/r/228984 (https://phabricator.wikimedia.org/T113856) [18:02:03] (03PS2) 10Ori.livneh: Updated key WANObjectCache::delete() callers to avoid races [core] - 10https://gerrit.wikimedia.org/r/240913 (owner: 10Aaron Schulz) [18:02:11] (03CR) 10Ori.livneh: [C: 032] Updated key WANObjectCache::delete() callers to avoid races [core] - 10https://gerrit.wikimedia.org/r/240913 (owner: 10Aaron Schulz) [18:03:57] (03CR) 10Martineznovo: [C: 04-1] "It needs to check if the new XML elements exist, in case the dump was generated with an older MediaWiki version. Crash when reading a dump" [tools/mwdumper] - 10https://gerrit.wikimedia.org/r/192174 (owner: 10Awight) [18:05:10] (03PS1) 10Reedy: [DO NOT MERGE] Re-enable all phpcs rules [core] - 10https://gerrit.wikimedia.org/r/241345 [18:06:42] (03Abandoned) 10Aaron Schulz: QueryPage::fetchFromCache: Remove redundant $db->resultObject() call [core] - 10https://gerrit.wikimedia.org/r/241270 (owner: 10PleaseStand) [18:07:22] (03PS1) 10Amire80: Make lines shorter to pass phpcs under includes/libs [core] - 10https://gerrit.wikimedia.org/r/241346 (https://phabricator.wikimedia.org/T102614) [18:07:33] (03CR) 10Bartosz Dziewoński: [C: 031] "Sounds like very reasonable changes. Didn't review or test." [core] - 10https://gerrit.wikimedia.org/r/241113 (owner: 10Ori.livneh) [18:10:14] (03PS1) 10Amire80: Make line shorter to pass phpcs in LinkerTest.php [core] - 10https://gerrit.wikimedia.org/r/241347 (https://phabricator.wikimedia.org/T102614) [18:10:46] (03CR) 10Aaron Schulz: [C: 032] Database: Remove resultObject() from the public interface [core] - 10https://gerrit.wikimedia.org/r/241286 (owner: 10PleaseStand) [18:12:22] 10MediaWiki-Parser, 6Wikisource: Space before/after »guillemets« (»/«) converted to non-breaking space ( ) (French spaces) - https://phabricator.wikimedia.org/T14752#1678423 (10matmarex) Still an issue, see the previous comment here for a more detailed summary. [18:12:28] (03CR) 10Reedy: "Reckon we can merge this one?" [core] - 10https://gerrit.wikimedia.org/r/241344 (owner: 10Reedy) [18:14:10] (03PS1) 10Paladox: Set $wgMetrolookFeatures in extension.json [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/241348 [18:14:23] 10MediaWiki-extensions-Graph-VE, 10VisualEditor, 5Patch-For-Review: Edit graph padding in VisualEditor - https://phabricator.wikimedia.org/T113856#1678424 (10Jdforrester-WMF) [18:14:49] 10MediaWiki-extensions-Graph-VE, 10VisualEditor: Bar charts are not displaying properly directly after a save in VisualEditor - https://phabricator.wikimedia.org/T109645#1678426 (10Jdforrester-WMF) [18:14:51] (03PS3) 10Aaron Schulz: Database: Remove resultObject() from the public interface [core] - 10https://gerrit.wikimedia.org/r/241286 (owner: 10PleaseStand) [18:14:51] 10MediaWiki-extensions-Graph-VE, 10VisualEditor: Edit graph size in VisualEditor - https://phabricator.wikimedia.org/T109631#1678427 (10Jdforrester-WMF) [18:14:55] 10MediaWiki-extensions-Graph-VE, 10VisualEditor: Edit axis captions in graphs from VisualEditor - https://phabricator.wikimedia.org/T109630#1678428 (10Jdforrester-WMF) [18:14:57] 10MediaWiki-extensions-Graph-VE, 10VisualEditor: Edit graph colors in VisualEditor - https://phabricator.wikimedia.org/T109629#1678429 (10Jdforrester-WMF) [18:15:00] 10MediaWiki-extensions-Graph-VE, 10VisualEditor: Weekly reports for "Enable VisualEditor support in Graph extension" - https://phabricator.wikimedia.org/T101119#1678432 (10Jdforrester-WMF) [18:15:41] 10MediaWiki-extensions-CollapsibleVector, 10MediaWiki-skins-Metrolook: Add array_plus_2d - https://phabricator.wikimedia.org/T113183#1656962 (10Paladox) It has now been done in wikieditor in patch https://gerrit.wikimedia.org/r/#/c/240961/ [18:16:07] (03PS2) 10Paladox: Set $wgMetrolookFeatures in extension.json [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/241348 (https://phabricator.wikimedia.org/T113183) [18:16:33] 10MediaWiki-Codesniffer, 10MediaWiki-General-or-Unknown: Make MediaWiki core pass mediawiki-codesniffer - https://phabricator.wikimedia.org/T102609#1678453 (10Reedy) For some testing... https://gerrit.wikimedia.org/r/#/c/241345/ is P2096 [18:16:57] (03Merged) 10jenkins-bot: Use a constructive button on Special:MovePage [core] - 10https://gerrit.wikimedia.org/r/241072 (https://phabricator.wikimedia.org/T113493) (owner: 10Florianschmidtwelzow) [18:17:15] 10MediaWiki-extensions-Graph-VE, 10VisualEditor, 5Patch-For-Review: Edit graph padding in VisualEditor - https://phabricator.wikimedia.org/T113856#1678408 (10Jdforrester-WMF) [18:17:19] 10MediaWiki-extensions-Graph-VE, 10Graph, 10VisualEditor, 10VisualEditor-MediaWiki: Be able to insert new Graph nodes with VisualEditor - https://phabricator.wikimedia.org/T112994#1678470 (10Jdforrester-WMF) [18:17:24] 10MediaWiki-extensions-Graph-VE, 10VisualEditor: Edit graph size in VisualEditor - https://phabricator.wikimedia.org/T109631#1554745 (10Jdforrester-WMF) [18:17:37] 10MediaWiki-extensions-Graph-VE, 10VisualEditor: Bar charts are not displaying properly directly after a save in VisualEditor - https://phabricator.wikimedia.org/T109645#1678472 (10Jdforrester-WMF) p:5Triage>3High [18:17:46] 10MediaWiki-extensions-Graph-VE, 10VisualEditor: Edit axis captions in graphs from VisualEditor - https://phabricator.wikimedia.org/T109630#1554735 (10Jdforrester-WMF) [18:17:52] 10MediaWiki-extensions-Graph-VE, 10VisualEditor: Edit graph colors in VisualEditor - https://phabricator.wikimedia.org/T109629#1554710 (10Jdforrester-WMF) [18:17:59] 10MediaWiki-extensions-Graph-VE, 6Developer-Relations, 10VisualEditor, 3DevRel-September-2015, and 3 others: End-term evaluation for "Graph editing in VE" - https://phabricator.wikimedia.org/T109305#1545363 (10Jdforrester-WMF) [18:18:04] (03CR) 10jenkins-bot: [V: 04-1] Database: Remove resultObject() from the public interface [core] - 10https://gerrit.wikimedia.org/r/241286 (owner: 10PleaseStand) [18:18:09] 10MediaWiki-extensions-Graph-VE, 10VisualEditor: Weekly reports for "Enable VisualEditor support in Graph extension" - https://phabricator.wikimedia.org/T101119#1330046 (10Jdforrester-WMF) [18:18:14] 10MediaWiki-extensions-Graph-VE, 6Developer-Relations, 10VisualEditor, 3DevRel-September-2015, and 2 others: Wrap-up report for "Graph editing in VE" - https://phabricator.wikimedia.org/T109291#1545064 (10Jdforrester-WMF) [18:18:52] 10MediaWiki-extensions-Graph-VE, 10VisualEditor, 5Patch-For-Review: Basic UI for bar chart editing - https://phabricator.wikimedia.org/T100353#1310883 (10Jdforrester-WMF) [18:18:58] 10MediaWiki-extensions-Graph-VE, 6Project-Creators, 10VisualEditor: VisualEditor module in Graph extension - https://phabricator.wikimedia.org/T97847#1678481 (10Jdforrester-WMF) [18:19:04] 10MediaWiki-extensions-Graph-VE, 10VisualEditor: Community bonding evaluation for "Enable VisualEditor support in Graph extension" - https://phabricator.wikimedia.org/T97502#1678483 (10Jdforrester-WMF) [18:19:09] 10MediaWiki-extensions-Graph-VE, 10VisualEditor, 5Patch-For-Review: Reload Vega display on change - https://phabricator.wikimedia.org/T99938#1678484 (10Jdforrester-WMF) [18:19:13] (03PS4) 10Reedy: Make lines shorter to pass phpcs in some files under includes/parser [core] - 10https://gerrit.wikimedia.org/r/241339 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [18:19:21] 10MediaWiki-extensions-Graph-VE, 10VisualEditor, 7user-notice: Enable basic Vega display in VisualEditor - https://phabricator.wikimedia.org/T99936#1302212 (10Jdforrester-WMF) [18:19:28] (03CR) 10Aaron Schulz: "recheck" [core] - 10https://gerrit.wikimedia.org/r/241286 (owner: 10PleaseStand) [18:19:34] (03CR) 10Reedy: [C: 032] Make lines shorter to pass phpcs in some files under includes/parser [core] - 10https://gerrit.wikimedia.org/r/241339 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [18:19:44] (03PS1) 10Amire80: Make lines short to pass phpcs in six files under includes/ [core] - 10https://gerrit.wikimedia.org/r/241349 (https://phabricator.wikimedia.org/T102614) [18:20:13] (03PS2) 10Reedy: Make line shorter to pass phpcs in LinkerTest.php [core] - 10https://gerrit.wikimedia.org/r/241347 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [18:20:19] (03CR) 10Reedy: [C: 032] Make line shorter to pass phpcs in LinkerTest.php [core] - 10https://gerrit.wikimedia.org/r/241347 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [18:20:36] (03PS2) 10Reedy: Make lines shorter to pass phpcs under includes/libs [core] - 10https://gerrit.wikimedia.org/r/241346 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [18:20:42] (03CR) 10Reedy: [C: 032] Make lines shorter to pass phpcs under includes/libs [core] - 10https://gerrit.wikimedia.org/r/241346 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [18:22:03] (03PS1) 10Paladox: Set $wgCollapsibleVectorFeatures in extension.json [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/241350 (https://phabricator.wikimedia.org/T113183) [18:22:28] 10MediaWiki-extensions-CollapsibleVector, 10MediaWiki-skins-Metrolook, 10WikiEditor, 5Patch-For-Review: Add array_plus_2d - https://phabricator.wikimedia.org/T113183#1678491 (10Paladox) [18:24:35] (03PS3) 10Paladox: Set $wgMetrolookFeatures in extension.json [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/241348 (https://phabricator.wikimedia.org/T113183) [18:24:45] (03CR) 10Aaron Schulz: [C: 032] Swap leading spaces to tabs in backup phpunit tests [core] - 10https://gerrit.wikimedia.org/r/241344 (owner: 10Reedy) [18:25:44] 10PageImages: Thumbnail of the specific image is not created - https://phabricator.wikimedia.org/T113853#1678493 (10Umherirrender) You have no page on your wiki calling "Registon supermarket", but you have a page calling "Registon Supermarket" which gives a thumb, when used in the query, of the page image select... [18:28:00] 10MediaWiki-extensions-AbuseFilter, 10Wikimedia-Site-Requests: AbuseFilter in ukwiki - https://phabricator.wikimedia.org/T113848#1678495 (10Se4598) Which filter triggers the block? Google translate mentions it could be [[https://uk.wikipedia.org/wiki/%D0%A1%D0%BF%D0%B5%D1%86%D1%96%D0%B0%D0%BB%D1%8C%D0%BD%D0%B0... [18:28:21] (03PS4) 10Aaron Schulz: Added $opts to WANObjectCache::set() to detect snapshot lag [core] - 10https://gerrit.wikimedia.org/r/240908 [18:28:38] (03PS5) 10Aaron Schulz: Added $opts to WANObjectCache::set() to detect snapshot lag [core] - 10https://gerrit.wikimedia.org/r/240908 [18:31:34] 10MediaWiki-General-or-Unknown: non consistent X-Frame-Options - https://phabricator.wikimedia.org/T48560#1678505 (10Nikki) I've been seeing something similar on enwiki while using https://tools.wmflabs.org/wikidata-todo/duplicity.php The tool displays a Wikipedia article in an iframe on the left. Most of the ti... [18:32:43] (03PS1) 10Aaron Schulz: Fixed DatabaseBase references in IDatabase docs [core] - 10https://gerrit.wikimedia.org/r/241352 [18:33:19] aharoni: Seems mw core has about 10% of the phpcs warnings it did back in july [18:35:28] (03CR) 10Hashar: [C: 032] Fixed DatabaseBase references in IDatabase docs [core] - 10https://gerrit.wikimedia.org/r/241352 (owner: 10Aaron Schulz) [18:36:10] (03Merged) 10jenkins-bot: Make lines shorter to pass phpcs in some files under includes/parser [core] - 10https://gerrit.wikimedia.org/r/241339 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [18:36:13] Reedy: with the same rules? [18:36:23] Presumably not :P [18:36:32] ah ^^ [18:39:09] (03CR) 10Cscott: [C: 032] Update README to use `--host` instead of `--prefix`. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/241116 (owner: 10Cscott) [18:39:22] (03CR) 10Cscott: [C: 032] Update README to use `--host` instead of `--prefix` and clarify the path. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/241117 (owner: 10Cscott) [18:39:35] (03CR) 10Cscott: [C: 032] Update README to use `--host` instead of `--prefix` and clarify the path. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/241118 (owner: 10Cscott) [18:40:48] (03CR) 10Nikerabbit: [C: 031] "I have already argued in the bug that this is the right approach (for time being). Let's keep the discussion there." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/240964 (https://phabricator.wikimedia.org/T112349) (owner: 10Smalyshev) [18:41:02] (03PS2) 10Reedy: Make lines short to pass phpcs in six files under includes/ [core] - 10https://gerrit.wikimedia.org/r/241349 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [18:41:09] (03CR) 10Reedy: [C: 032] Make lines short to pass phpcs in six files under includes/ [core] - 10https://gerrit.wikimedia.org/r/241349 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [18:43:40] (03CR) 10Nikerabbit: [C: 04-1] Cleanup LanguageTyv.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/241316 (owner: 10Amire80) [18:45:46] (03Merged) 10jenkins-bot: Make line shorter to pass phpcs in LinkerTest.php [core] - 10https://gerrit.wikimedia.org/r/241347 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [18:45:50] (03Merged) 10jenkins-bot: Make lines shorter to pass phpcs under includes/libs [core] - 10https://gerrit.wikimedia.org/r/241346 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [18:46:16] (03PS1) 10Cscott: Update commander, sqlite3, jshint, and mocha dependencies. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/241353 [18:47:16] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Story: [Story] Replace text in toolbars with icons - https://phabricator.wikimedia.org/T87757#1678519 (10Jonas) @Ricordisamoa could you please explain why you gave a thumps down? Should the page stay text only? Or would you prefer to have icons in addi... [18:47:20] (03CR) 10Nemo bis: [C: 04-1] "If lego needed be, this would not be ready as is. At a minimum, qqq needs to state the exact context/sentence in which the name is used so" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/241126 (https://phabricator.wikimedia.org/T113098) (owner: 10Smalyshev) [18:47:25] (03PS2) 10Amire80: Cleanup LanguageTyv.php [core] - 10https://gerrit.wikimedia.org/r/241316 [18:47:37] (03PS3) 10Amire80: Cleanup LanguageTyv.php [core] - 10https://gerrit.wikimedia.org/r/241316 [18:47:39] 10MediaWiki-extensions-AbuseFilter, 10Wikimedia-Site-Requests, 5Patch-For-Review: AbuseFilter in ukwiki - https://phabricator.wikimedia.org/T113848#1678520 (10Green_Zero) Yes, it filter 41. Now he disabled (after wrong actions). [18:49:21] James_F: still about? [18:49:28] Aye. [18:49:34] (03CR) 10Umherirrender: [C: 032] API: Correct 'from_namespace' logic in ApiQueryBacklinksprop [core] - 10https://gerrit.wikimedia.org/r/240362 (https://phabricator.wikimedia.org/T113453) (owner: 10Anomie) [18:49:59] Just wondering who I should poke about the test failures in https://gerrit.wikimedia.org/r/#/c/241341/ [18:50:06] It's just whitespace crap [18:50:15] And we use tabs in real code [18:50:21] So I'm guessing it's just some flag [18:50:36] (03CR) 10Aaron Schulz: Tidy up ResourceLoader to make ResourceLoaderEditToolbarModule simpler (031 comment) [core] - 10https://gerrit.wikimedia.org/r/241113 (owner: 10Ori.livneh) [18:50:42] Reedy: Probably ori/Krinkle. [18:50:48] (03CR) 10Aaron Schulz: [C: 031] Tidy up ResourceLoader to make ResourceLoaderEditToolbarModule simpler [core] - 10https://gerrit.wikimedia.org/r/241113 (owner: 10Ori.livneh) [18:53:24] (03Merged) 10jenkins-bot: Swap leading spaces to tabs in backup phpunit tests [core] - 10https://gerrit.wikimedia.org/r/241344 (owner: 10Reedy) [18:53:26] (03PS1) 10Jack Phoenix: Initial commit [extensions/CookiePolicy] - 10https://gerrit.wikimedia.org/r/241356 [18:53:31] (03Merged) 10jenkins-bot: Fixed DatabaseBase references in IDatabase docs [core] - 10https://gerrit.wikimedia.org/r/241352 (owner: 10Aaron Schulz) [18:53:33] (03Merged) 10jenkins-bot: Update README to use `--host` instead of `--prefix`. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/241116 (owner: 10Cscott) [18:53:46] (03CR) 10Jack Phoenix: [C: 032] Initial commit [extensions/CookiePolicy] - 10https://gerrit.wikimedia.org/r/241356 (owner: 10Jack Phoenix) [18:53:58] (03PS1) 10Yoonghm: It fixes the error "pg_send_query(): There are results on this connection. Call pg_get_result() until it returns FALSE." [core] - 10https://gerrit.wikimedia.org/r/241357 [18:54:00] (03Merged) 10jenkins-bot: Update README to use `--host` instead of `--prefix` and clarify the path. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/241118 (owner: 10Cscott) [18:54:32] (03CR) 10Jack Phoenix: [V: 032] Initial commit [extensions/CookiePolicy] - 10https://gerrit.wikimedia.org/r/241356 (owner: 10Jack Phoenix) [18:54:39] 10MediaWiki-skins-Metrolook: Watchlist icon does not spin in metrolook - https://phabricator.wikimedia.org/T113849#1678525 (10Paladox) [18:57:47] 10MediaWiki-skins-Metrolook: Watchlist icon does not spin in metrolook - https://phabricator.wikimedia.org/T113849#1678527 (10Paladox) [18:58:46] (03PS2) 10Nemo bis: Return null when getInterwikiResults() [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/239048 (https://phabricator.wikimedia.org/T96881) [18:58:52] (03CR) 10Nemo bis: "True, that makes sense either way; done in PS2. However, am I reading correctly that core actually runs getInterwikiResults() twice, first" (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/239048 (https://phabricator.wikimedia.org/T96881) (owner: 10Nemo bis) [18:59:22] 10MediaWiki-skins-Metrolook: Watchlist icon does not spin in metrolook - https://phabricator.wikimedia.org/T113849#1678531 (10ashley) @Paladox I updated all skins (and extensions) on my [[http://social-tools.wmflabs.org/wiki/Main_Page|Labs wiki]] and it's working for me there -- maybe try purging your caches? It... [19:00:58] 10MediaWiki-skins-Metrolook: Watchlist icon does not spin in metrolook - https://phabricator.wikimedia.org/T113849#1678533 (10Paladox) Oh yes. It works in chrome but not internet explorer 11. [19:01:12] 10MediaWiki-skins-Metrolook: Watchlist icon does not spin in metrolook - https://phabricator.wikimedia.org/T113849#1678534 (10Paladox) Woulden that mean it dosent work in vector. [19:01:32] 10MediaWiki-skins-Metrolook, 10Vector: Watchlist icon does not spin in metrolook - https://phabricator.wikimedia.org/T113849#1678535 (10Paladox) [19:01:45] 10MediaWiki-skins-Metrolook, 10Vector: Watchlist icon does not spin in metrolook - https://phabricator.wikimedia.org/T113849#1678248 (10Paladox) Adding vector do to the problem also being in vector. [19:03:33] 10MediaWiki-Database: PostgreSQL misuse of pg_get_result - https://phabricator.wikimedia.org/T52091#1678538 (10Yoonghm) It takes a lot of effort and knowledge to contribute via https://gerrit.wikimedia.org I have created a branch, **`T52091_postgresql_read_PQresult`** ``` $ git review -R Your change was commi... [19:04:15] (03Merged) 10jenkins-bot: Make lines short to pass phpcs in six files under includes/ [core] - 10https://gerrit.wikimedia.org/r/241349 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [19:04:22] (03Merged) 10jenkins-bot: API: Correct 'from_namespace' logic in ApiQueryBacklinksprop [core] - 10https://gerrit.wikimedia.org/r/240362 (https://phabricator.wikimedia.org/T113453) (owner: 10Anomie) [19:07:25] (03PS2) 10Brian Wolff: Fix "pg_send_query(): There are results on this connection..." [core] - 10https://gerrit.wikimedia.org/r/241357 (https://phabricator.wikimedia.org/T52091) (owner: 10Yoonghm) [19:08:40] (03PS2) 10Reedy: [DO NOT MERGE] Re-enable all phpcs rules [core] - 10https://gerrit.wikimedia.org/r/241345 [19:08:51] 10MediaWiki-API, 5Patch-For-Review: Using rdnamespace parameter for prop=redirects results in database error when miser mode is not enabled - https://phabricator.wikimedia.org/T113453#1678549 (10Umherirrender) 5Open>3Resolved [19:08:57] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "features/bad_syntax_api.feature:4:9:19:20:21:22:31:32:33:34:35:37:46:47:48:49:50:51:52:53:54:55:56:57:65:66:67:68:69:70:71:72:79:80:83:103" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/239048 (https://phabricator.wikimedia.org/T96881) (owner: 10Nemo bis) [19:09:11] (03PS1) 10Cscott: Update commander, sqlite3, jshint, and mocha dependencies. [extensions/Collection/OfflineContentGenerator/zim_renderer] - 10https://gerrit.wikimedia.org/r/241367 [19:09:13] (03PS1) 10Cscott: Add node 4.1 to travis test targets. [extensions/Collection/OfflineContentGenerator/zim_renderer] - 10https://gerrit.wikimedia.org/r/241368 [19:09:15] (03PS1) 10Cscott: Hook up npm-travis. [extensions/Collection/OfflineContentGenerator/zim_renderer] - 10https://gerrit.wikimedia.org/r/241369 [19:09:39] 10CirrusSearch, 6Discovery, 3Discovery-Cirrus-Sprint, 5Patch-For-Review, 7WorkType-NewFunctionality: Inform users what happened if their query is forwarded to another wiki because of language detection - https://phabricator.wikimedia.org/T112349#1678551 (10Amire80) I feel uncomfortable with the brute for... [19:10:20] (03CR) 10Amire80: [C: 04-1] "I feel uncomfortable about nearly 300 messages with only one different word when better approaches exist. See the comment at the bug." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/240964 (https://phabricator.wikimedia.org/T112349) (owner: 10Smalyshev) [19:10:38] (03PS2) 10Cscott: Hook up npm-travis. [extensions/Collection/OfflineContentGenerator/zim_renderer] - 10https://gerrit.wikimedia.org/r/241369 [19:10:40] (03PS2) 10Cscott: Add node 4.1 to travis test targets. [extensions/Collection/OfflineContentGenerator/zim_renderer] - 10https://gerrit.wikimedia.org/r/241368 [19:10:42] (03PS2) 10Cscott: Update commander, sqlite3, jshint, and mocha dependencies. [extensions/Collection/OfflineContentGenerator/zim_renderer] - 10https://gerrit.wikimedia.org/r/241367 [19:12:17] 10PageImages: Thumbnail of the specific image is not created - https://phabricator.wikimedia.org/T113853#1678553 (10Comseong) As you mentioned, this just looks like that by mis-spelling. But even when I tested a few times this API with auto-generated page title("Registon Supermarket") parsed by programming code,... [19:15:32] 10MediaWiki-Installer: MediaWiki CLI installer need an option to not inject detected skins in LocalSettings.php - https://phabricator.wikimedia.org/T113858#1678555 (10hashar) 3NEW [19:16:02] 10MediaWiki-Database, 5Patch-For-Review: PostgreSQL misuse of pg_get_result - https://phabricator.wikimedia.org/T52091#1678564 (10Bawolff) >Change 241357 had a related patch set uploaded (by Brian Wolff): The gerritbot is buggy and gets confused when people edit the commit message. I obviously was not the one... [19:21:31] (03PS1) 10Amire80: Make lines shorter to pass phpcs in thumb.php [core] - 10https://gerrit.wikimedia.org/r/241453 (https://phabricator.wikimedia.org/T102614) [19:22:25] 4(no projects): Add Extension:Variables to en.wikiversity - https://phabricator.wikimedia.org/T113859#1678566 (10Dave_Braunschweig) 3NEW [19:24:04] lol, no [19:24:41] 10PageImages: Thumbnail of the specific image is not created - https://phabricator.wikimedia.org/T113853#1678572 (10Umherirrender) 5Open>3Invalid a:3Umherirrender The "missing: ''" in the result is from the query module, because there was no page found. If pageimage extension does not found a image on the... [19:25:07] 4(no projects): Add Extension:Variables to en.wikiversity - https://phabricator.wikimedia.org/T113859#1678576 (10Bawolff) This is unlikely to happen. Variables has been rejected in the past, and I'm given to understand would cause large problems for certain extensions (VisualEditor) [19:25:40] (03PS3) 10Yoonghm: Fix "pg_send_query(): There are results on this connection..." [core] - 10https://gerrit.wikimedia.org/r/241357 (https://phabricator.wikimedia.org/T52091) [19:26:49] 10Wikimedia-Site-Requests: Add Extension:Variables to en.wikiversity - https://phabricator.wikimedia.org/T113859#1678583 (10Bawolff) [19:27:05] 10Wikimedia-Site-Requests: Add Extension:Variables to en.wikiversity - https://phabricator.wikimedia.org/T113859#1678586 (10Dave_Braunschweig) Thanks for the fast response. Are there any alternatives that might provide similar functionality? [19:27:20] (03Abandoned) 10Yoonghm: Fix "pg_send_query(): There are results on this connection..." [core] - 10https://gerrit.wikimedia.org/r/241357 (https://phabricator.wikimedia.org/T52091) (owner: 10Yoonghm) [19:28:12] (03PS1) 10Reedy: Leading spaces to tabs [core] - 10https://gerrit.wikimedia.org/r/241454 [19:28:46] (03PS1) 10Hashar: Fix autoloader for EruditeTemplate [skins/erudite] - 10https://gerrit.wikimedia.org/r/241455 (https://phabricator.wikimedia.org/T113860) [19:28:48] (03PS1) 10Hashar: Fix autoloader for ExampleTemplate [skins/Example] - 10https://gerrit.wikimedia.org/r/241456 (https://phabricator.wikimedia.org/T113860) [19:28:58] (03PS1) 10Hashar: Fix autoloader for SplashTemplate [skins/Splash] - 10https://gerrit.wikimedia.org/r/241457 (https://phabricator.wikimedia.org/T113860) [19:29:23] (03PS1) 10Yoonghm: Update as per code quality [core] - 10https://gerrit.wikimedia.org/r/241458 [19:29:40] 10MediaWiki-Codesniffer, 10MediaWiki-General-or-Unknown: Fix Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed - https://phabricator.wikimedia.org/T113854#1678592 (10Reedy) So, speaking to @legoktm, he was going to file an upstream issue about "leading spaces" when they were in strings... Might be worth rever... [19:30:56] 10MediaWiki-skins-BlueSky, 10Continuous-Integration-Infrastructure, 5Patch-For-Review: Fix structure tests for all skins - https://phabricator.wikimedia.org/T113860#1678594 (10hashar) [19:31:34] (03PS17) 10Amire80: Add new grammar forms for language names in Russian [core] - 10https://gerrit.wikimedia.org/r/172501 [19:31:43] (03PS6) 10Amire80: Convert Russian grammar cases from PHP to JSON [core] - 10https://gerrit.wikimedia.org/r/239980 [19:33:08] 10Wikimedia-Site-Requests: Add Extension:Variables to en.wikiversity - https://phabricator.wikimedia.org/T113859#1678595 (10Bawolff) >>! In T113859#1678586, @Dave_Braunschweig wrote: > Thanks for the fast response. Are there any alternatives that might provide similar functionality? To be clear, my previous co... [19:34:37] (03PS1) 10Reedy: Wrap some long lines... [core] - 10https://gerrit.wikimedia.org/r/241459 [19:38:01] (03PS7) 10Amire80: Convert Russian grammar cases from PHP to JSON [core] - 10https://gerrit.wikimedia.org/r/239980 [19:40:49] (03CR) 10Umherirrender: [C: 032] Make lines shorter to pass phpcs in thumb.php [core] - 10https://gerrit.wikimedia.org/r/241453 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [19:42:09] 10CirrusSearch, 6Discovery, 3Discovery-Cirrus-Sprint, 5Patch-For-Review, 7WorkType-NewFunctionality: Inform users what happened if their query is forwarded to another wiki because of language detection - https://phabricator.wikimedia.org/T112349#1678598 (10Nikerabbit) Amir, they need a solution that work... [19:42:47] 4(no projects): Namespace definition to BNWS is difference from other WS like english - https://phabricator.wikimedia.org/T113861#1678599 (10jayantanth) 3NEW [19:46:35] 4(no projects): Namespace number for custom namespaces differs between bnwikisource and enwikisource - https://phabricator.wikimedia.org/T113861#1678605 (10Bawolff) [19:46:51] 6Discovery, 10Maps, 10Performance-Metrics-Dashboard, 3Discovery-Maps-Sprint, 3Wikipedia-Android-App: KPI - Identify maps traffic from Mobile App - https://phabricator.wikimedia.org/T113829#1678607 (10Yurik) Oliver, the urgency is only with deciding if we need to urgently take an action or not ) if all tr... [19:47:30] 4(no projects): Namespace number for custom namespaces differs between bnwikisource and enwikisource - https://phabricator.wikimedia.org/T113861#1678599 (10Bawolff) Is this causing a problem in someway? Its like this because that's what someone set it to once upon a time. [19:48:25] 10MediaWiki-skins-BlueSky, 10Continuous-Integration-Infrastructure, 5Patch-For-Review: Fix structure tests for all skins - https://phabricator.wikimedia.org/T113860#1678610 (10hashar) #MediaWiki-skins-BlueSky fails with: ``` 1) Warning The data provider specified for ResourcesTest::testFileExistence is inva... [19:48:32] (03PS1) 10Reedy: Wrap some long strings in tests/ [core] - 10https://gerrit.wikimedia.org/r/241460 [19:50:06] (03Restored) 10Yoonghm: Fix "pg_send_query(): There are results on this connection..." [core] - 10https://gerrit.wikimedia.org/r/241357 (https://phabricator.wikimedia.org/T52091) (owner: 10Yoonghm) [19:50:33] (03CR) 10Umherirrender: "Is this for phpcs? Than the question is, why phpcs is looking into multiline strings. That is wrong." (035 comments) [core] - 10https://gerrit.wikimedia.org/r/241454 (owner: 10Reedy) [19:51:32] 6Wikisource: Namespace number for custom namespaces differs between bnwikisource and enwikisource - https://phabricator.wikimedia.org/T113861#1678613 (10jayantanth) [19:51:46] (03Merged) 10jenkins-bot: Make lines shorter to pass phpcs in thumb.php [core] - 10https://gerrit.wikimedia.org/r/241453 (https://phabricator.wikimedia.org/T102614) (owner: 10Amire80) [19:51:59] (03CR) 10Brian Wolff: "I'm not sure what you're trying to do with the abandon button, but if your confused about anything in the gerrit interface, feel free to p" [core] - 10https://gerrit.wikimedia.org/r/241357 (https://phabricator.wikimedia.org/T52091) (owner: 10Yoonghm) [19:52:10] (03CR) 10Reedy: "Yup T113854..." [core] - 10https://gerrit.wikimedia.org/r/241454 (owner: 10Reedy) [19:52:42] (03Abandoned) 10Reedy: Leading spaces to tabs [core] - 10https://gerrit.wikimedia.org/r/241454 (owner: 10Reedy) [19:53:02] (03CR) 10jenkins-bot: [V: 04-1] Wrap some long strings in tests/ [core] - 10https://gerrit.wikimedia.org/r/241460 (owner: 10Reedy) [19:53:10] (03PS1) 10Reedy: Revert "Swap leading spaces to tabs in backup phpunit tests" [core] - 10https://gerrit.wikimedia.org/r/241461 [19:53:16] (03PS2) 10Reedy: Revert "Swap leading spaces to tabs in backup phpunit tests" [core] - 10https://gerrit.wikimedia.org/r/241461 [19:53:22] (03CR) 10Reedy: [C: 032] Revert "Swap leading spaces to tabs in backup phpunit tests" [core] - 10https://gerrit.wikimedia.org/r/241461 (owner: 10Reedy) [19:54:04] 6Wikisource: Namespace number for custom namespaces differs between bnwikisource and enwikisource - https://phabricator.wikimedia.org/T113861#1678617 (10jayantanth) [19:54:07] 10Wikimedia-General-or-Unknown, 6Wikisource, 7Tracking: Wikisource related bugs and enhancements (tracking) - https://phabricator.wikimedia.org/T37925#1678616 (10jayantanth) [19:56:19] (03CR) 10Brian Wolff: [C: 04-1] "If you want to modify a commit that you previously submitted, don't submit the changes as a new commit, but instead take the old commit (D" [core] - 10https://gerrit.wikimedia.org/r/241458 (owner: 10Yoonghm) [19:57:46] (03PS2) 10Reedy: Wrap some long strings in tests/ [core] - 10https://gerrit.wikimedia.org/r/241460 [19:59:47] (03CR) 10Jforrester: [C: 032] Wrap some long lines... [core] - 10https://gerrit.wikimedia.org/r/241459 (owner: 10Reedy) [20:00:00] (03CR) 10jenkins-bot: [V: 04-1] Wrap some long strings in tests/ [core] - 10https://gerrit.wikimedia.org/r/241460 (owner: 10Reedy) [20:01:34] 10WikiProject-X: Implement error logging/reporting across Python scripts - https://phabricator.wikimedia.org/T113862#1678618 (10Harej) 3NEW a:3XZise [20:01:42] 6Wikisource: Namespace number for custom namespaces differs between bnwikisource and enwikisource - https://phabricator.wikimedia.org/T113861#1678626 (10jayantanth) I face/found the issues where I am wanting return the value of Index talk page with [[{{ns:107}}:{{PAGENAME}}]] in a template. I can assign the as... [20:02:32] (03PS3) 10Reedy: Wrap some long strings in tests/ [core] - 10https://gerrit.wikimedia.org/r/241460 [20:02:52] (03Merged) 10jenkins-bot: Revert "Swap leading spaces to tabs in backup phpunit tests" [core] - 10https://gerrit.wikimedia.org/r/241461 (owner: 10Reedy) [20:07:31] 6Wikisource: Namespace number for custom namespaces differs between bnwikisource and enwikisource - https://phabricator.wikimedia.org/T113861#1678627 (10jayantanth) I have not checked to other wikisource, Are not all custom namespace assign to same number to all Wikisource? [20:07:34] hey to all my fellow wiki members [20:07:55] hello to everyone, how day [20:10:29] 10MediaWiki-Codesniffer, 10MediaWiki-General-or-Unknown: Make MediaWiki core pass mediawiki-codesniffer - https://phabricator.wikimedia.org/T102609#1678630 (10Reedy) [20:10:30] 10MediaWiki-Codesniffer, 10MediaWiki-General-or-Unknown: Fix Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed - https://phabricator.wikimedia.org/T113854#1678628 (10Reedy) 5Open>3stalled Filed an issue for leading spaces in strings showing as a warning https://github.com/squizlabs/PHP_CodeSniffer/issues/... [20:12:09] (03Merged) 10jenkins-bot: Wrap some long lines... [core] - 10https://gerrit.wikimedia.org/r/241459 (owner: 10Reedy) [20:16:36] (03CR) 10Umherirrender: [C: 04-1] "The spaces are part of multi line strings, so phpcs should not have a look at these string - Should be handled as Ic96c686a00c40fec1080313" [core] - 10https://gerrit.wikimedia.org/r/241341 (owner: 10Reedy) [20:17:14] (03CR) 10Reedy: "Issued filed upstream too" [core] - 10https://gerrit.wikimedia.org/r/241341 (owner: 10Reedy) [20:17:18] (03Abandoned) 10Reedy: Swap leading spaces for tabs in ResourceLoaderStartUpModuleTest.php [core] - 10https://gerrit.wikimedia.org/r/241341 (owner: 10Reedy) [20:29:29] (03PS1) 10Amire80: Fix a spelling mistake in a test description [core] - 10https://gerrit.wikimedia.org/r/241462 [20:30:16] (03CR) 10Reedy: [C: 032] Fix a spelling mistake in a test description [core] - 10https://gerrit.wikimedia.org/r/241462 (owner: 10Amire80) [20:31:17] 6Wikisource: Namespace number for custom namespaces differs between bnwikisource and enwikisource - https://phabricator.wikimedia.org/T113861#1678636 (10Bawolff) >>! In T113861#1678627, @jayantanth wrote: > I have not checked to other wikisource, Are not all custom namespace assign to same number to all Wikisour... [20:33:22] (03CR) 10Hashar: [C: 04-1] "Pending CI configuration at https://gerrit.wikimedia.org/r/#/c/240952/" [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/240951 (https://phabricator.wikimedia.org/T90303) (owner: 10Legoktm) [20:34:14] 6Wikisource: Namespace number for custom namespaces differs between bnwikisource and enwikisource - https://phabricator.wikimedia.org/T113861#1678639 (10Reedy) Should this become a dupe of T74525, which is to normalise wikisource namespaces? [20:34:29] (03PS1) 10Umherirrender: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/241463 [20:39:58] 10MediaWiki-skins-BlueSky, 10Continuous-Integration-Infrastructure, 5Patch-For-Review: Fix structure tests for all skins - https://phabricator.wikimedia.org/T113860#1678641 (10Paladox) Should we just rename the style name to skin.skinanme.style and same for script in same format but instead of it being style... [20:40:06] (03CR) 10Hashar: "recheck" [extensions/SpamDiffTool] - 10https://gerrit.wikimedia.org/r/228625 (owner: 10Paladox) [20:40:19] (03Merged) 10jenkins-bot: Fix a spelling mistake in a test description [core] - 10https://gerrit.wikimedia.org/r/241462 (owner: 10Amire80) [20:41:27] (03Abandoned) 10Hashar: Adjust MediaWiki images that have been renamed [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/240875 (https://phabricator.wikimedia.org/T113655) (owner: 10Hashar) [20:41:30] 10MediaWiki-skins-BlueSky, 10Continuous-Integration-Infrastructure, 5Patch-For-Review: Fix structure tests for all skins - https://phabricator.wikimedia.org/T113860#1678643 (10Paladox) If you look at https://git.wikimedia.org/blob/mediawiki%2Fskins%2FBlueSky/ebab0051ce0700477cac85e96be2f5dcda902623/BlueSky.p... [20:42:15] (03PS6) 10Hashar: Adjust MediaWiki images that have been renamed [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/240876 (https://phabricator.wikimedia.org/T113655) (owner: 10Paladox) [20:42:21] (03PS7) 10Hashar: Adjust MediaWiki images that have been renamed [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/240876 (https://phabricator.wikimedia.org/T113655) (owner: 10Paladox) [20:42:34] (03CR) 10Hashar: "check experimental" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/240876 (https://phabricator.wikimedia.org/T113655) (owner: 10Paladox) [20:43:08] (03CR) 10Hashar: "I have rephrased the commit message. "Fix Jenkins tests" is not very helpful." [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/240876 (https://phabricator.wikimedia.org/T113655) (owner: 10Paladox) [20:43:16] (03PS1) 10Umherirrender: Add curly braces to if statement [core] - 10https://gerrit.wikimedia.org/r/241464 [20:44:15] (03PS2) 10Reedy: Add curly braces to if statement [core] - 10https://gerrit.wikimedia.org/r/241464 (owner: 10Umherirrender) [20:44:20] (03CR) 10Reedy: [C: 032] Add curly braces to if statement [core] - 10https://gerrit.wikimedia.org/r/241464 (owner: 10Umherirrender) [20:44:56] (03PS2) 10Reedy: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/241463 (owner: 10Umherirrender) [20:45:46] 10MediaWiki-Codesniffer: Add sniff to avoid if/else/while/foreach without curly braces - https://phabricator.wikimedia.org/T113863#1678644 (10Umherirrender) 3NEW [20:46:37] (03CR) 10Reedy: [C: 032] Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/241463 (owner: 10Umherirrender) [20:46:48] (03CR) 10Paladox: "Thankyou." [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/240876 (https://phabricator.wikimedia.org/T113655) (owner: 10Paladox) [20:51:47] 10Wikimedia-Site-Requests: Add Extension:Variables to en.wikiversity - https://phabricator.wikimedia.org/T113859#1678657 (10Dave_Braunschweig) We have a number of pages where we have sequential numbers on content, but the numbers need to sent to templates to be rendered rather than numbering the content using #.... [20:53:19] 10MediaWiki-Codesniffer: @codingStandardsIgnoreStart doesn't seem to help avoid phpcs errors inside comments - https://phabricator.wikimedia.org/T113852#1678658 (10Reedy) I guess an upstream issue needs to be filed about this? [20:53:48] (03Merged) 10jenkins-bot: Add curly braces to if statement [core] - 10https://gerrit.wikimedia.org/r/241464 (owner: 10Umherirrender) [20:57:09] 10MediaWiki-Codesniffer: @codingStandardsIgnoreStart doesn't seem to help avoid phpcs errors inside comments - https://phabricator.wikimedia.org/T113852#1678659 (10Amire80) Maybe, I'm not really a phpcs expert. [20:58:12] 10MediaWiki-extensions-TitleBlacklist: PHP Notice: Use of undefined constant - https://phabricator.wikimedia.org/T113864#1678660 (10Kghbln) 3NEW [21:00:25] (03PS1) 10Paladox: empty php entry point, remove non existing css files [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/241465 [21:00:29] (03CR) 10jenkins-bot: [V: 04-1] empty php entry point, remove non existing css files [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/241465 (owner: 10Paladox) [21:01:05] (03PS2) 10Paladox: empty php entry point, remove non existing css files [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/241465 (https://phabricator.wikimedia.org/T113860) [21:01:07] (03CR) 10jenkins-bot: [V: 04-1] empty php entry point, remove non existing css files [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/241465 (https://phabricator.wikimedia.org/T113860) (owner: 10Paladox) [21:02:09] (03PS3) 10Paladox: empty php entry point, remove non existing css files [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/241465 (https://phabricator.wikimedia.org/T113860) [21:02:41] (03Merged) 10jenkins-bot: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/241463 (owner: 10Umherirrender) [21:04:28] (03PS1) 10Paladox: Add support for translating description [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/241466 [21:06:16] (03PS2) 10Paladox: Add support for translating description [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/241466 [21:06:58] (03CR) 10Paladox: [C: 031] Fix autoloader for EruditeTemplate [skins/erudite] - 10https://gerrit.wikimedia.org/r/241455 (https://phabricator.wikimedia.org/T113860) (owner: 10Hashar) [21:07:56] (03CR) 10Paladox: [C: 031] Fix autoloader for ExampleTemplate [skins/Example] - 10https://gerrit.wikimedia.org/r/241456 (https://phabricator.wikimedia.org/T113860) (owner: 10Hashar) [21:08:17] (03CR) 10Paladox: [C: 031] Fix autoloader for SplashTemplate [skins/Splash] - 10https://gerrit.wikimedia.org/r/241457 (https://phabricator.wikimedia.org/T113860) (owner: 10Hashar) [21:11:22] 10MediaWiki-Codesniffer, 10MediaWiki-General-or-Unknown: Fix Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed - https://phabricator.wikimedia.org/T113854#1678674 (10polybuildr) I tested this by updating CodeSniffer, and the issue was gone. `Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed`'s code has changed... [21:11:57] Reedy: If you can confirm ^, then we can mark the upstream issue as resolved. [21:12:24] Ooh [21:12:32] I'm not actually setup for testing locally [21:13:24] Reedy: Do you want to try it out? :P [21:15:15] You can do a composer install in a repo that has mw-codesniffer as a dependency, and then you can replace the codesniffer that gets installed with PHP_CodeSniffer's master. [21:16:10] it'd be useful if we put it in our vendor repo :P [21:17:16] ok, I'm back [21:17:29] * legoktm hugs polybuildr [21:18:01] Reedy: Just looked it up, it was filed as https://github.com/squizlabs/PHP_CodeSniffer/issues/515 and then was fixed. :D All we need to do is update our dependencies. :) [21:18:16] * polybuildr hugs legoktm back [21:18:20] but why am I getting a hug? :P [21:18:25] because you're awesome! [21:18:39] so it's fixed in 2.3.4? [21:18:50] yeah it is :) [21:19:01] Closed my upstream task [21:19:58] ok, lemme see what we wanted to do prior to 0.4.0 [21:20:08] I commented that somewhere [21:20:30] legoktm: right, here: https://phabricator.wikimedia.org/T113516#1677302 [21:20:31] (03CR) 10Hashar: "recheck" [extensions/Josa] - 10https://gerrit.wikimedia.org/r/236067 (owner: 10Paladox) [21:21:44] legoktm: or we could just cut it now and do this for 0.5.0, not too much lost :P [21:21:52] (03PS5) 10Hashar: Add jshint and jscs in npm [extensions/Josa] - 10https://gerrit.wikimedia.org/r/236067 (owner: 10Paladox) [21:22:01] I already started reviewing :P [21:22:34] legoktm: yay :D that works too :P [21:25:17] How do we get MediaWiki-Codesniffer project notifications on #releng too, like Gerrit does? Half here half there is a little confusing [21:25:36] that's fairly easy [21:25:56] !link [[mw:wikibugs]] [21:25:56] http://www.mediawiki.org/wiki/%5b%5bmw:wikibugs%5d%5d [21:26:04] * legoktm pets wm-bot [21:27:27] (03CR) 10Hashar: "recheck" [extensions/Josa] - 10https://gerrit.wikimedia.org/r/236067 (owner: 10Paladox) [21:27:41] ^^ that didn't work too well :P [21:28:19] !link wikibugs [21:28:19] http://www.mediawiki.org/wiki/wikibugs [21:28:26] there. [21:28:38] I used the awesome search feature we have and found it. :P [21:29:25] hrm, the tests are failing [21:29:38] ok, lets do 0.4.0 now [21:30:09] what's with the errors at https://gerrit.wikimedia.org/r/#/c/237733/? [21:30:26] `Class MediaWiki_Sniffs_ControlStructures_IfElseStructureSniff does not exist`? [21:30:50] the class is not named the same as the file [21:30:56] Oops. Okay. :P [21:31:05] I'm going to do the release first [21:31:12] yeah, sounds good [21:31:39] (03CR) 10Hashar: "recheck" [extensions/Josa] - 10https://gerrit.wikimedia.org/r/236067 (owner: 10Paladox) [21:32:08] Should codesniffer gerrit notifs not go to #releng (but to #dev) or should phab MediaWiki-CodeSniffer go only to #releng? :P [21:32:45] (03CR) 10Hashar: [C: 032] "Sorry for the spam." [extensions/Josa] - 10https://gerrit.wikimedia.org/r/236067 (owner: 10Paladox) [21:33:11] (03Merged) 10jenkins-bot: Add jshint and jscs in npm [extensions/Josa] - 10https://gerrit.wikimedia.org/r/236067 (owner: 10Paladox) [21:33:48] 10MediaWiki-Vendor, 10Security-Reviews, 6Security-Team: Security review for oyejorge/less.php - https://phabricator.wikimedia.org/T112329#1678676 (10ori) >>! In T112329#1673621, @dpatrick wrote: > == General Observations == > - Positive > - Evaluation of JavaScript via backticks is not supported > - Exte... [21:37:40] legoktm: now that 0.4.0 is done, we can update core's dependency, and also merge in those two patches I had that specified the ignore lists for our sniffs [21:38:43] 10MediaWiki-Special-pages, 10UI-Standardization: Button on Special:MovePage should be constructive - https://phabricator.wikimedia.org/T113493#1678677 (10Ricordisamoa) 5Open>3Resolved [21:40:33] Reedy, polybuildr: packagist updated with 0.4.0 [21:40:42] <3 [21:40:45] :D [21:41:10] (03PS2) 10Legoktm: phpcs: Add ignoreList for prefixed functions sniff in phpcs.xml [core] - 10https://gerrit.wikimedia.org/r/237269 (https://phabricator.wikimedia.org/T104501) (owner: 10Polybuildr) [21:41:22] (03CR) 10Legoktm: [C: 04-1] "Needs rebase" [core] - 10https://gerrit.wikimedia.org/r/237269 (https://phabricator.wikimedia.org/T104501) (owner: 10Polybuildr) [21:41:28] (03CR) 10jenkins-bot: [V: 04-1] phpcs: Add ignoreList for prefixed functions sniff in phpcs.xml [core] - 10https://gerrit.wikimedia.org/r/237269 (https://phabricator.wikimedia.org/T104501) (owner: 10Polybuildr) [21:42:07] Who's doing the 0.4.0 dependency update for core? [21:42:08] legoktm: I'll do the rebases [21:42:16] Be nice to get core done and then we can update the working report... [21:42:24] James_F: There are a couple of patches that need to be merged before that [21:42:30] OK. [21:42:35] James_F: https://gerrit.wikimedia.org/r/#/c/241460/ [21:43:10] (03CR) 10Jforrester: [C: 032] Wrap some long strings in tests/ [core] - 10https://gerrit.wikimedia.org/r/241460 (owner: 10Reedy) [21:43:23] ty [21:43:39] Thank you. :-) [21:45:08] legoktm: okay, my master isn't up to date. pulling and then rebasing. unless you're doing it? :P [21:45:34] polybuildr: I'm not. I'm reviewing James_F's change to make phpcs voting [21:45:41] I can do it. [21:46:06] legoktm, James_F, master updated. I'll take care of it now [21:46:11] Kk. [21:51:07] (03CR) 10Ori.livneh: Tidy up ResourceLoader to make ResourceLoaderEditToolbarModule simpler (031 comment) [core] - 10https://gerrit.wikimedia.org/r/241113 (owner: 10Ori.livneh) [21:52:16] (03PS2) 10Polybuildr: Add ignoreList for valid global variable name sniff in phpcs.xml [core] - 10https://gerrit.wikimedia.org/r/237329 (https://phabricator.wikimedia.org/T104501) [21:52:18] (03PS3) 10Polybuildr: Add ignoreList for prefixed functions sniff in phpcs.xml [core] - 10https://gerrit.wikimedia.org/r/237269 (https://phabricator.wikimedia.org/T104501) [21:52:45] (03Merged) 10jenkins-bot: Wrap some long strings in tests/ [core] - 10https://gerrit.wikimedia.org/r/241460 (owner: 10Reedy) [21:52:45] How did I do that ^ ... [21:52:48] two commits? [21:53:08] oh. dependencies. [21:53:28] polybuildr: Yeah. [21:53:53] James_F: If not busy, could you please take a look at those two? It's rather late here, so I might have made a mistake in the rebase :P [21:54:00] * James_F has a gander. [21:54:05] (03PS9) 10Ori.livneh: Tidy up ResourceLoader to make ResourceLoaderEditToolbarModule simpler [core] - 10https://gerrit.wikimedia.org/r/241113 [21:54:25] (03CR) 10jenkins-bot: [V: 04-1] Tidy up ResourceLoader to make ResourceLoaderEditToolbarModule simpler [core] - 10https://gerrit.wikimedia.org/r/241113 (owner: 10Ori.livneh) [21:55:30] polybuildr: It looks sane, but I'm not entirely au faît with how to configure phpcs. [21:56:26] hmm, okay [21:56:33] (03PS10) 10Ori.livneh: Tidy up ResourceLoader to make ResourceLoaderEditToolbarModule simpler [core] - 10https://gerrit.wikimedia.org/r/241113 [21:56:37] we shall wait for the judgement of legoktm then. :P [21:56:50] * James_F grins. [21:56:51] which patch? [21:56:59] right honourable legoktm [21:57:00] https://gerrit.wikimedia.org/r/237329 [21:57:04] And v [21:57:05] The core ones involving ignore lists. https://gerrit.wikimedia.org/r/#/c/237269/ [21:57:06] Err [21:57:08] And https://gerrit.wikimedia.org/r/237269 [21:57:33] oh yeah, the silly comma lists [21:57:37] (03CR) 10Legoktm: [C: 032] Add ignoreList for prefixed functions sniff in phpcs.xml [core] - 10https://gerrit.wikimedia.org/r/237269 (https://phabricator.wikimedia.org/T104501) (owner: 10Polybuildr) [21:57:41] 10MediaWiki-skins-Metrolook, 10Vector: Watchlist icon does not spin in metrolook - https://phabricator.wikimedia.org/T113849#1678686 (10Paladox) It works in Microsoft Edge. Watchlist worked a while back in internet explorer. [21:57:52] (03CR) 10Legoktm: [C: 032] Add ignoreList for valid global variable name sniff in phpcs.xml [core] - 10https://gerrit.wikimedia.org/r/237329 (https://phabricator.wikimedia.org/T104501) (owner: 10Polybuildr) [21:58:32] 10MediaWiki-skins-Metrolook, 10Vector: Watchlist icon does not spin on internet explorer - https://phabricator.wikimedia.org/T113849#1678687 (10Paladox) [21:58:38] The honourable legoktm judges them to be worthy of CR+2 in 4 seconds :P [21:58:49] snap judgment [21:58:51] well, I already reviewed them when you originally wrote them [21:59:04] predestination [21:59:09] I remember someone once saying on #labs, I think. "I'm fast, but I'm not yuvipanda/legoktm fast." :P [21:59:12] (03CR) 10jenkins-bot: [V: 04-1] Tidy up ResourceLoader to make ResourceLoaderEditToolbarModule simpler [core] - 10https://gerrit.wikimedia.org/r/241113 (owner: 10Ori.livneh) [21:59:46] :o [21:59:57] denied [22:00:17] Can I do the version upgrade in core patch? ^_^ [22:00:34] (03PS11) 10Ori.livneh: Tidy up ResourceLoader to make ResourceLoaderEditToolbarModule simpler [core] - 10https://gerrit.wikimedia.org/r/241113 [22:00:47] Reedy: this one will pass, for the love of god merge it or i will go insane [22:00:56] it has +1s from bartosz and aaron and i addressed timo's comment [22:01:07] Jenkins is being a dick today [22:01:16] every day [22:01:29] * James_F grins. [22:02:34] (03PS1) 10Polybuildr: Update mediawiki-codesniffer dependency [core] - 10https://gerrit.wikimedia.org/r/241469 [22:03:12] legoktm, Reedy, James_F ^ :D [22:03:19] * Reedy rebases [22:03:36] polybuildr: You need to do a patch to mediawiki/vendor too. [22:03:38] (03PS1) 10Ricordisamoa: Remove excess newlines at the end of files [core] - 10https://gerrit.wikimedia.org/r/241470 [22:03:39] (03PS2) 10Reedy: Update mediawiki-codesniffer dependency [core] - 10https://gerrit.wikimedia.org/r/241469 (owner: 10Polybuildr) [22:03:42] polybuildr: Or I can if you prefer? [22:03:48] errr [22:03:51] no mediawiki/vendor patch [22:03:54] No? [22:03:55] it's a dev dependency [22:03:56] we don't have it in vendor [22:03:59] Oh, dev-dep… [22:03:59] Yeah. [22:04:05] (Meh.) [22:04:22] ori: your patch is failing phpcs :( [22:04:24] (03CR) 10Reedy: [C: 032] "For Sparta!" [core] - 10https://gerrit.wikimedia.org/r/241469 (owner: 10Polybuildr) [22:04:30] legoktm: lol. [22:04:35] whatttt is going on [22:04:42] SPAH-TAH! [22:04:47] Hey MatmaRex. [22:04:51] Reedy: Wait, why was the rebase necessary, I thought I *just* pulled from remote :P [22:04:59] Hello MatmaRex. :D [22:05:01] The button was live [22:05:03] So I pressed it [22:05:06] That's how it works [22:05:28] (03PS12) 10Ori.livneh: Tidy up ResourceLoader to make ResourceLoaderEditToolbarModule simpler [core] - 10https://gerrit.wikimedia.org/r/241113 [22:05:34] Careful. That logic leads down the path to becoming paladox ;) [22:05:36] legoktm: Oh, yeah, you OK with my change in https://gerrit.wikimedia.org/r/#/c/235676/ ? [22:05:42] Tsk. :-) [22:06:23] Everybody, say hello to kind MatmaRex who helped me work on a task so controversial, it got so many comments that we started seeing phab bugs and then finally people got so annoyed my commit got reverted. :P [22:06:36] (03CR) 10Jforrester: [C: 031] Tidy up ResourceLoader to make ResourceLoaderEditToolbarModule simpler [core] - 10https://gerrit.wikimedia.org/r/241113 (owner: 10Ori.livneh) [22:06:41] James_F: yep, looks good to me [22:06:44] :o [22:06:45] Kk. [22:06:45] bawolff: it's a perfectly legitimate paladigm [22:06:53] ori: xD [22:07:02] (03CR) 10Jforrester: [C: 032] Add RELEASE-NOTES entries for PHP library upgrades and additions [core] - 10https://gerrit.wikimedia.org/r/235676 (owner: 10Legoktm) [22:07:05] bawolff: Don't worry, I'm gonna spend tomorrow reverting oris patches [22:07:26] noooooooo [22:07:32] James_F: now i'll have to manually rebase again [22:07:33] (03Merged) 10jenkins-bot: Add ignoreList for prefixed functions sniff in phpcs.xml [core] - 10https://gerrit.wikimedia.org/r/237269 (https://phabricator.wikimedia.org/T104501) (owner: 10Polybuildr) [22:07:39] gj James_F [22:07:44] thanks obama [22:07:45] ori: I doubt it very much. [22:07:55] ori: we can call paladox to help you out if you'd like [22:08:04] ori: Unless you're doing something odd about the file hash of RELEASE-NOTES being hard-coded? [22:08:23] bawolff: just noticed https://phabricator.wikimedia.org/T58064 is waiting for your review :P [22:08:30] i just enjoy that there is someone quicker on the draw than i am [22:08:39] Wait, since when did paladox become a running joke here? :P [22:08:41] * James_F grins. [22:08:47] polybuildr: Too long ago. :-( [22:08:55] polybuildr: I'd say about 4 months ago [22:09:18] I remember PMing legoktm and asking him if he knew who Paladox was and why he makes so many patches. :P [22:09:19] although I usually don't make comments like that in public... [22:09:27] probably shouldn't... [22:09:45] That's true. Though this is basically private, since paladox never comes to IRC. [22:09:49] He doesn't, right? [22:09:50] ... [22:09:55] Not that we know of [22:10:00] it's not nice either way [22:10:04] and the logs are public [22:10:04] (03CR) 10Ricordisamoa: "This patch actually adds an empty newline at the end, in addition to the classic Unix-style newline." [core] - 10https://gerrit.wikimedia.org/r/241308 (owner: 10Reedy) [22:10:34] legoktm: phpcs is happy https://gerrit.wikimedia.org/r/#/c/241113/ [22:10:44] Yeah, we should respect contributors, regardless. [22:10:50] (03CR) 10Legoktm: [C: 032] Remove excess newlines at the end of files [core] - 10https://gerrit.wikimedia.org/r/241470 (owner: 10Ricordisamoa) [22:10:55] ori: woot [22:10:58] *contlibutors [22:11:10] I'm going to make phpcs voting now [22:11:39] Fair point. Sorry, Paladox. If you're reading this, know that you're doing a great job! :D I'd miss so many dependency upgrades if it weren't for you. [22:11:43] legoktm: woot [22:11:58] Yay. [22:12:05] How long have people waited for this to happen? :') [22:12:16] Then only 2000 lines to shorten to fewer than 100 characters and we're set! ;-) [22:12:18] Ah, I was hoping hashar was here. :P [22:12:47] polybuildr: He left IRC an hour ago, sorry. [22:13:06] James_F: I always avoided counting so that I could tell myself it was all possible. Ignorance was bliss. :P [22:13:25] Amir has fixed a lot today [22:13:49] Reedy: Yes! So so so many emails. :o [22:14:27] (03CR) 10Paladox: [C: 031] "Can be merged now. test passes." [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/240876 (https://phabricator.wikimedia.org/T113655) (owner: 10Paladox) [22:14:38] Though it might be more convenient if each commit had little batches of changes. [22:15:01] (03CR) 10Florianschmidtwelzow: [C: 032] Fix autoloader for EruditeTemplate [skins/erudite] - 10https://gerrit.wikimedia.org/r/241455 (https://phabricator.wikimedia.org/T113860) (owner: 10Hashar) [22:15:35] (03CR) 10Florianschmidtwelzow: [C: 032] Fix autoloader for ExampleTemplate [skins/Example] - 10https://gerrit.wikimedia.org/r/241456 (https://phabricator.wikimedia.org/T113860) (owner: 10Hashar) [22:16:01] (03CR) 10Florianschmidtwelzow: [C: 032] Fix autoloader for SplashTemplate [skins/Splash] - 10https://gerrit.wikimedia.org/r/241457 (https://phabricator.wikimedia.org/T113860) (owner: 10Hashar) [22:16:09] polybuildr: If only mediawiki-codesniffer could fix line lengths. :-) [22:16:33] That's what substring is for [22:16:49] Who's +2ing the "make phpcs voting" job? https://gerrit.wikimedia.org/r/#/c/241312/ [22:16:54] (03Merged) 10jenkins-bot: Add ignoreList for valid global variable name sniff in phpcs.xml [core] - 10https://gerrit.wikimedia.org/r/237329 (https://phabricator.wikimedia.org/T104501) (owner: 10Polybuildr) [22:17:01] polybuildr: legoktm will. [22:17:06] he's just rebased [22:17:10] okay :) [22:17:21] CI counts as operations, so people self-+2. [22:17:23] (Tsk.) [22:17:34] Other people take too long [22:17:39] * James_F grins. [22:18:02] 10CirrusSearch, 6Discovery: Stemming highlights the wrong terms in search results - https://phabricator.wikimedia.org/T113838#1678692 (10Cpiral) [22:18:16] (03Merged) 10jenkins-bot: Update mediawiki-codesniffer dependency [core] - 10https://gerrit.wikimedia.org/r/241469 (owner: 10Polybuildr) [22:18:21] (03Merged) 10jenkins-bot: Add RELEASE-NOTES entries for PHP library upgrades and additions [core] - 10https://gerrit.wikimedia.org/r/235676 (owner: 10Legoktm) [22:18:21] James_F, Reedy: We could actually give it a shot, couldn't we? Get PHPCBF to split at periods or at random places. Could see how it looks, and if it works, hooray. [22:18:32] It'll be easier than manually editing all 2000 lines. [22:18:36] polybuildr: I'd rather do it based on a style. [22:18:40] polybuildr: There's not 2000 [22:18:43] (03CR) 10Florianschmidtwelzow: "Please don't mix up several things into one change. It would be easier to review one change for each of your fixed topics:" [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/241465 (https://phabricator.wikimedia.org/T113860) (owner: 10Paladox) [22:18:46] Reedy: https://gerrit.wikimedia.org/r/#/c/240779/ [22:18:59] foo ( bar, baz ) => foo ( \n\tbar,\n\tbaz\n) [22:19:00] Etc. [22:19:10] Oh [22:19:16] Yeah, that'd be easy, ish.. [22:19:19] Comments are a pita [22:19:40] James_F: Fair point. I was talking about long strings, though, which make up quite a bit. [22:19:50] * James_F nods. [22:19:52] Yeah. [22:20:08] One of the things I like about jscs is the line length fixing. [22:20:11] * Reedy waits for Jenkins to merge the bump [22:21:02] * polybuildr wonders if this is a historic moment in the development of MediaWiki :P [22:21:33] (03PS3) 10Paladox: Revert "resourceloader: Improve caching for LESS file compilation" [core] - 10https://gerrit.wikimedia.org/r/241306 (https://phabricator.wikimedia.org/T113843) [22:21:37] polybuildr: In the sense that it will be recorded in the git log for all time, sure. :-) [22:21:41] Ohai Paladox [22:22:23] James_F: Oh, come on. Not that sense. :P [22:23:19] When I started working on the codebase some time in December last year, I saw quite a few patchsets by new contributors (including me) that involved fixing minor style issues [22:23:44] The issue was that we had to wait for a contributor to find the time to review the patch, and then it would just be: hey, one space missing :P [22:24:44] * James_F nods. [22:25:03] https://github.com/squizlabs/PHP_CodeSniffer/wiki/Reporting#printing-a-checkstyle-report [22:25:12] we should be able to make jenkins read that [22:25:51] (03Merged) 10jenkins-bot: Remove excess newlines at the end of files [core] - 10https://gerrit.wikimedia.org/r/241470 (owner: 10Ricordisamoa) [22:25:53] (03PS1) 10Paladox: Remove non existing css file reference [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/241471 [22:25:56] (03Merged) 10jenkins-bot: Fix autoloader for EruditeTemplate [skins/erudite] - 10https://gerrit.wikimedia.org/r/241455 (https://phabricator.wikimedia.org/T113860) (owner: 10Hashar) [22:25:58] (03Merged) 10jenkins-bot: Fix autoloader for ExampleTemplate [skins/Example] - 10https://gerrit.wikimedia.org/r/241456 (https://phabricator.wikimedia.org/T113860) (owner: 10Hashar) [22:26:00] (03Merged) 10jenkins-bot: Fix autoloader for SplashTemplate [skins/Splash] - 10https://gerrit.wikimedia.org/r/241457 (https://phabricator.wikimedia.org/T113860) (owner: 10Hashar) [22:26:18] I really need to fix this damn gerrit/origin remote issue [22:26:23] And PHPCS is now voting! :D [22:26:38] (03PS3) 10Reedy: [DO NOT MERGE] Re-enable all phpcs rules [core] - 10https://gerrit.wikimedia.org/r/241345 [22:26:42] (03PS2) 10Paladox: Remove non existing css file reference [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/241471 (https://phabricator.wikimedia.org/T113860) [22:26:50] Oh, wait, no. Jenkins will need an update, won't it? [22:26:59] [15:26:25] !log deploying https://gerrit.wikimedia.org/r/241312 [22:27:03] Reedy: `for DIR in extensions do; git remote rm gerrit; done` or whatever? [22:27:05] it's deployed now \o/ [22:27:05] s/it/he/c :P [22:27:07] Yay. [22:27:30] James_F: Is just removing the remote enough [22:27:35] Reedy: No further need to command people not to merge it; CI now won't let you. [22:27:38] gitreview won't want to readd it? [22:27:44] (03PS1) 10Paladox: empty php entry point [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/241472 [22:27:52] Reedy: Assuming origin is set correctly? What's your .gitreview say? [22:28:24] Which one? [22:28:29] I haven't changed any... [22:28:39] The one in MW-core on master, to start with. [22:28:53] Same as on the remote repo, or do you have local changes? [22:28:59] No local changes [22:29:22] Then yes, deleting the `gerrit` remote and leaving `origin` should Just Work™. [22:29:24] https://phabricator.wikimedia.org/P2101 [22:29:38] (03Abandoned) 10Paladox: empty php entry point, remove non existing css files [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/241465 (https://phabricator.wikimedia.org/T113860) (owner: 10Paladox) [22:29:41] What does master track? [22:30:02] um, something seems wrong [22:30:24] Reedy: The patch you submitted to core to test the phpcs job, it should have used the updated version of codesniffer, right? [22:30:35] polybuildr: Yeah, I rebased it [22:30:35] (03CR) 10jenkins-bot: [V: 04-1] [DO NOT MERGE] Re-enable all phpcs rules [core] - 10https://gerrit.wikimedia.org/r/241345 (owner: 10Reedy) [22:30:40] There's a line in the Jenkins failed log that goes: [22:30:40] 19:12:37 FILE: ...src/tests/phpunit/includes/resourceloader/ResourceLoaderTest.php [22:30:48] mediawiki-core-phpcs FAILURE in 2m 47s [22:30:59] The same indentation by space issue [22:31:01] Yay. [22:31:02] even if within string. [22:31:12] Oh, wait. Let me check now. [22:31:20] https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs/163/consoleFull [22:31:38] I think we need to disable a few more tests [22:31:40] Gone. :D [22:31:45] By default [22:31:46] 22:29:43 68 | WARNING | [x] Single space expected between "//" and comment [22:31:47] etc [22:31:52] Okay, nothing is wrong. Sorry for the scare. :P [22:32:05] Yup [22:32:09] * Reedy disables MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.EmptyComment by default [22:32:13] and [22:32:23] MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.SingleSpaceBeforeSingleLineComment [22:32:30] wait, why? [22:32:54] Because core is full of unfixed errors? [22:33:14] So any new patches will get V-1'd due to latent errors still in core [22:33:23] But phpcbf autofixes most errors found by that sniff. [22:33:25] oh. [22:33:29] wait, how did that happen? [22:33:29] But they're not fixed [22:33:40] There's 104 of MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.EmptyComment [22:33:50] How'd we miss that one? [22:33:51] umm, wait what [22:33:55] 491 ediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.SingleSpaceBeforeSingleLineComment [22:34:31] Is the disablement not working? [22:34:40] are you looking at the output of your patch that re-enables the failing rules? [22:35:10] legoktm: Those rules aren't disabled [22:35:11] https://gerrit.wikimedia.org/r/#/c/241345/3/phpcs.xml,unified [22:35:35] (03PS1) 10Legoktm: jenkins job validation, do not submit [core] - 10https://gerrit.wikimedia.org/r/241473 [22:36:07] Did I screw up when I rebased?... [22:37:38] erp [22:37:48] something slipped through :/ [22:37:53] https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs/164/console is bad [22:37:58] (03PS1) 10Reedy: Disable EmptyComment and SingleSpaceBeforeSingleLineComment code sniffers [core] - 10https://gerrit.wikimedia.org/r/241474 [22:38:01] ^ [22:38:03] We need that [22:38:13] s/Disable/Exclude/ [22:38:36] legoktm: https://gerrit.wikimedia.org/r/#/c/241085/6/phpcs.xml [22:38:39] are the ones you had disabled [22:38:43] but not all of them are there now [22:38:54] polybuildr: Cause I fixed a lot of them today [22:39:05] Reedy: Phew, okay. [22:39:05] (03CR) 10jenkins-bot: [V: 04-1] jenkins job validation, do not submit [core] - 10https://gerrit.wikimedia.org/r/241473 (owner: 10Legoktm) [22:39:10] ^ oops. [22:39:25] Yeah, that's the one. [22:39:39] (03PS1) 10Paladox: Update mediawiki/mediawiki-codesniffer to 0.4.0 [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/241475 [22:39:44] (03CR) 10Polybuildr: [C: 031] Disable EmptyComment and SingleSpaceBeforeSingleLineComment code sniffers [core] - 10https://gerrit.wikimedia.org/r/241474 (owner: 10Reedy) [22:39:50] Somebody +2 ^ [22:40:09] (03CR) 10Paladox: [C: 032] Update mediawiki/mediawiki-codesniffer to 0.4.0 [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/241475 (owner: 10Paladox) [22:40:14] Just need to wait for jenkins polybuildr to confirm that's it [22:40:30] ie there's not any more that need doing too [22:40:30] yeah, I'm waiting on https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs/165/console [22:40:43] (03Merged) 10jenkins-bot: Update mediawiki/mediawiki-codesniffer to 0.4.0 [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/241475 (owner: 10Paladox) [22:40:45] (03CR) 10Florianschmidtwelzow: [C: 04-2] "Really: Fixing a problem is always a better solution as reverting an otherwise good change :) Remember, that reverts should only be used, " [core] - 10https://gerrit.wikimedia.org/r/241306 (https://phabricator.wikimedia.org/T113843) (owner: 10Paladox) [22:40:53] Hahahahaha [22:41:36] legoktm: success [22:41:37] 10MediaWiki-General-or-Unknown, 10MediaWiki-ResourceLoader, 10Vector, 5Patch-For-Review: mw-config now dosent show any styles - https://phabricator.wikimedia.org/T113843#1678703 (10Florian) a:3Florian [22:41:47] (03CR) 10Legoktm: [C: 032] Disable EmptyComment and SingleSpaceBeforeSingleLineComment code sniffers [core] - 10https://gerrit.wikimedia.org/r/241474 (owner: 10Reedy) [22:42:28] How does it take ~2 minutes when jenkins runs it but ~6 minutes when I run it locally? Less powerful machine than Jenkins? [22:42:36] Yeah [22:42:41] SSD, ram, CPU etc [22:42:48] Hmm. [22:43:06] (03PS1) 10Paladox: Update mediawiki/mediawiki-codesniffer to 0.4.0 [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/241476 [22:43:30] (03CR) 10Paladox: [C: 032] Update mediawiki/mediawiki-codesniffer to 0.4.0 [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/241476 (owner: 10Paladox) [22:43:33] And there goes Paladox, [22:43:40] legoktm: polybuildr: Maybe we need to document somewhere about this... Add a snipper to mediawiki/tools/codesniffer, disable it by default in core if it doesn't pas ;) [22:43:44] *sniffer [22:44:23] 10MediaWiki-General-or-Unknown, 10MediaWiki-ResourceLoader, 10Vector, 5Patch-For-Review: mw-config now dosent show any styles - https://phabricator.wikimedia.org/T113843#1678704 (10Paladox) It is also not only mw-config but whole site. [22:44:53] He's only just noticed? [22:45:04] (03CR) 10Brian Wolff: "Personally, I would only worry about supporting it in the timestamp formats that are needed to fix the bug. If someone wants to add the ti" [core] - 10https://gerrit.wikimedia.org/r/239292 (https://phabricator.wikimedia.org/T58064) (owner: 10Galorefitz) [22:45:35] (03PS1) 10Florianschmidtwelzow: Disable hash object cache for the installer [core] - 10https://gerrit.wikimedia.org/r/241477 (https://phabricator.wikimedia.org/T113843) [22:45:43] Reedy: want to review ^ :P [22:45:44] (03PS1) 10Ori.livneh: Tidy up ResourceLoader to make ResourceLoaderEditToolbarModule simpler [core] (wmf/1.26wmf24) - 10https://gerrit.wikimedia.org/r/241478 [22:45:53] polybuildr: do you have extensions checked out in your core directory? [22:46:03] legoktm: yeah [22:46:05] I think the phpcs file iterator thing is slow [22:46:21] and it lists everything, then adds exclusion rules or something [22:46:28] (03CR) 10Reedy: [C: 031] Disable hash object cache for the installer [core] - 10https://gerrit.wikimedia.org/r/241477 (https://phabricator.wikimedia.org/T113843) (owner: 10Florianschmidtwelzow) [22:46:46] Oh. Hmm. The git clone mw-core isn't recursive when jenkins does it? [22:46:47] (03CR) 10Florianschmidtwelzow: "Follow up: I1c1938b3fac395dd" [core] - 10https://gerrit.wikimedia.org/r/240316 (https://phabricator.wikimedia.org/T112035) (owner: 10Ori.livneh) [22:47:21] (03CR) 10Legoktm: "Can't we use HashBagOStuff here?" [core] - 10https://gerrit.wikimedia.org/r/241477 (https://phabricator.wikimedia.org/T113843) (owner: 10Florianschmidtwelzow) [22:47:33] no, it doesn't fetch extensions or skins [22:47:59] (03CR) 10Ori.livneh: [C: 04-1] "Yeah, there's no reason this can't be 'hash' => array( 'class' => 'HashBagOStuff' )," [core] - 10https://gerrit.wikimedia.org/r/241477 (https://phabricator.wikimedia.org/T113843) (owner: 10Florianschmidtwelzow) [22:49:12] (03CR) 10jenkins-bot: [V: 04-1] Disable hash object cache for the installer [core] - 10https://gerrit.wikimedia.org/r/241477 (https://phabricator.wikimedia.org/T113843) (owner: 10Florianschmidtwelzow) [22:50:21] Okay. 4 AM is late enough. Goodnight! o/ [22:50:29] (03PS2) 10Florianschmidtwelzow: Add 'hash' object cache for installer [core] - 10https://gerrit.wikimedia.org/r/241477 (https://phabricator.wikimedia.org/T113843) [22:51:01] https://github.com/squizlabs/PHP_CodeSniffer/wiki/Reporting#printing-a-git-blame-report heh [22:51:04] good night polybuildr :) [22:51:33] legoktm: hahahaha :D that's just evil :P [22:51:43] but would be a lot of fun to use [22:51:45] legoktm: you can create a wall of shame at wmf hq [22:51:56] (03CR) 10Paladox: "Tested does not work." [core] - 10https://gerrit.wikimedia.org/r/241477 (https://phabricator.wikimedia.org/T113843) (owner: 10Florianschmidtwelzow) [22:51:59] (03Merged) 10jenkins-bot: Disable EmptyComment and SingleSpaceBeforeSingleLineComment code sniffers [core] - 10https://gerrit.wikimedia.org/r/241474 (owner: 10Reedy) [22:52:01] (03CR) 10Ori.livneh: [C: 04-1] "Comment is inaccurate." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/241477 (https://phabricator.wikimedia.org/T113843) (owner: 10Florianschmidtwelzow) [22:52:03] (03Merged) 10jenkins-bot: Update mediawiki/mediawiki-codesniffer to 0.4.0 [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/241476 (owner: 10Paladox) [22:53:17] James_F: [22:53:17] reedy@ubuntu64-web-esxi:/var/www/wiki/mediawiki/core$ git review -d 241345 [22:53:18] Creating a git remote called "gerrit" that maps to: [22:53:21] fu---------- [22:53:31] (03CR) 10Paladox: [C: 04-1] Add 'hash' object cache for installer [core] - 10https://gerrit.wikimedia.org/r/241477 (https://phabricator.wikimedia.org/T113843) (owner: 10Florianschmidtwelzow) [22:53:51] Reedy: What does `git remote -v` say? [22:53:53] (03CR) 10Ori.livneh: [C: 032] "Avert this:" [core] (wmf/1.26wmf24) - 10https://gerrit.wikimedia.org/r/241478 (owner: 10Ori.livneh) [22:54:05] (03CR) 10Florianschmidtwelzow: Add 'hash' object cache for installer (031 comment) [core] - 10https://gerrit.wikimedia.org/r/241477 (https://phabricator.wikimedia.org/T113843) (owner: 10Florianschmidtwelzow) [22:54:28] (03PS4) 10Reedy: [DO NOT MERGE] Re-enable all phpcs rules [core] - 10https://gerrit.wikimedia.org/r/241345 [22:54:30] (03CR) 10jenkins-bot: [V: 04-1] Add 'hash' object cache for installer [core] - 10https://gerrit.wikimedia.org/r/241477 (https://phabricator.wikimedia.org/T113843) (owner: 10Florianschmidtwelzow) [22:54:47] (03PS3) 10Florianschmidtwelzow: Add 'hash' object cache for installer [core] - 10https://gerrit.wikimedia.org/r/241477 (https://phabricator.wikimedia.org/T113843) [22:55:00] James_F: shows both remotes, gerrit has username, origin doesn't [22:55:05] same protocol [22:55:08] Ah. [22:55:31] (03CR) 10Ori.livneh: [C: 032] Add 'hash' object cache for installer [core] - 10https://gerrit.wikimedia.org/r/241477 (https://phabricator.wikimedia.org/T113843) (owner: 10Florianschmidtwelzow) [22:55:43] Reedy: `git checkout master && git branch -u origin/master` [22:55:47] (03CR) 10Polybuildr: "phpcs failure is due to something else - was fixed in https://gerrit.wikimedia.org/r/#/c/241474/" [core] - 10https://gerrit.wikimedia.org/r/241477 (https://phabricator.wikimedia.org/T113843) (owner: 10Florianschmidtwelzow) [22:56:14] master is already tracking origin master [22:56:15] reedy@ubuntu64-web-esxi:/var/www/wiki/mediawiki/core$ git checkout master [22:56:15] Switched to branch 'master' [22:56:15] Your branch is up-to-date with 'origin/master'. [22:56:23] (from after my last push above) [22:56:47] In that case I've no idea. [22:56:53] lol [22:57:40] (03CR) 10Paladox: [C: 04-1] "Does not work." [core] - 10https://gerrit.wikimedia.org/r/241477 (https://phabricator.wikimedia.org/T113843) (owner: 10Florianschmidtwelzow) [22:57:40] There's no way to merge in core if Jenkins V-2s, is there? [22:57:58] polybuildr: Remove the -2 and force [22:57:58] :D [22:58:10] oh. right. :P [22:58:16] Oh, but wait. [22:58:21] (03CR) 10jenkins-bot: [V: 04-1] [DO NOT MERGE] Re-enable all phpcs rules [core] - 10https://gerrit.wikimedia.org/r/241345 (owner: 10Reedy) [22:58:24] * FlorianSW grins [22:58:35] Oh, right. So not just CR+2 V+2, but also "submit patch", not just "comment". [22:58:55] James_F: https://github.com/openstack-infra/git-review/commit/44707a1e7990c23b49f00d75fedb0e29e2bd8a88 [23:00:00] Reedy: https://github.com/legoktm/grr [23:00:06] (03CR) 10Florianschmidtwelzow: [C: 04-2] "Like I wrote in:" [core] - 10https://gerrit.wikimedia.org/r/241342 (https://phabricator.wikimedia.org/T113843) (owner: 10Paladox) [23:00:16] (03CR) 10Brian Wolff: "Is there a reason this is marked [WIP]?" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/239292 (https://phabricator.wikimedia.org/T58064) (owner: 10Galorefitz) [23:00:18] (03PS3) 10Polybuildr: [WIP] Fix issues identified by SpaceBeforeSingleLineComment sniff [core] - 10https://gerrit.wikimedia.org/r/237647 [23:00:38] legoktm: nice! [23:00:46] (03Abandoned) 10Paladox: Revert "resourceloader: Use FileContentsHasher in safeFileHash()" [core] - 10https://gerrit.wikimedia.org/r/241342 (https://phabricator.wikimedia.org/T113843) (owner: 10Paladox) [23:00:52] Isn't there a fix for this though? [23:00:59] I seem to recall something [23:01:03] yes [23:01:21] (03CR) 10Paladox: "@Florianschmidtwelzow I have tested it and still causing no styles to be applied to mw-config." [core] - 10https://gerrit.wikimedia.org/r/241477 (https://phabricator.wikimedia.org/T113843) (owner: 10Florianschmidtwelzow) [23:01:24] ~/.config/git-review/git-review.conf [23:01:29] [gerrit] [23:01:29] defaultremote = origin [23:01:50] If someone has the time to review massive commits, please take a look at the one above ([WIP] Fix issues identified by SpaceBeforeSingleLineComment sniff [core] - https://gerrit.wikimedia.org/r/237647) [23:02:05] ori: Thankyou! [23:02:08] Reedy, legoktm, James_F ^^ [23:02:12] oh huh. the wikitech logo lives on in the installer [23:02:15] That makes me happy [23:02:45] polybuildr: I thought you were oging to bed? :P [23:03:19] Reedy: The time tells me I should go, but I'm not sleepy yet. :P I just thought I'd take a look at my pending patches and remembered that one. [23:03:30] It's massive. :o [23:03:32] polybuildr: how did you make the fixes? [23:03:36] by hand, or automatically? [23:03:43] ori: Automatically. [23:03:51] (03CR) 10Florianschmidtwelzow: "@Paladox: Then you doing something wrong :P I tested it and it's working fine. What do you see in the browsers network tab, especially the" [core] - 10https://gerrit.wikimedia.org/r/241477 (https://phabricator.wikimedia.org/T113843) (owner: 10Florianschmidtwelzow) [23:04:02] using phpcs or some sed / python / perl / ruby hackery? [23:04:06] (03Merged) 10jenkins-bot: Tidy up ResourceLoader to make ResourceLoaderEditToolbarModule simpler [core] (wmf/1.26wmf24) - 10https://gerrit.wikimedia.org/r/241478 (owner: 10Ori.livneh) [23:04:17] phpcs! [23:04:21] ori: Using https://gerrit.wikimedia.org/r/#/c/228993/ (phpcbf) [23:04:31] I just sent an email to wikitech-l about this ~30 seconds ago :P [23:04:35] why is it WIP? [23:04:53] FlorianSW: Are you the same as Florianschmidtwelzow? [23:05:07] bawolff: yep, FlorianSchmidtWelzow -> FlorianSW :) [23:05:08] 10MediaWiki-General-or-Unknown, 10MediaWiki-ResourceLoader, 10Vector, 5Patch-For-Review: mw-config now dosent show any styles - https://phabricator.wikimedia.org/T113843#1678707 (10Paladox) {F2639048} [23:05:18] ori: because I didn't want anyone to merge it without taking a close look at it :P [23:05:29] have I misunderstood [WIP]? :P [23:05:29] polybuildr: You should probably enable to the sniff again to check you got them all :P [23:05:37] (03Merged) 10jenkins-bot: Add 'hash' object cache for installer [core] - 10https://gerrit.wikimedia.org/r/241477 (https://phabricator.wikimedia.org/T113843) (owner: 10Florianschmidtwelzow) [23:05:39] Does it mean don't merge, or don't review? [23:05:44] FlorianSW: just for what its worth, I can confirm paladox's report that css is borked in the installer on current master [23:05:49] [WIP] is work-in-progress, which I interpret as "I'm not done with this yet" [23:06:03] bawolff: have you applied the change? :/ [23:06:09] (03CR) 10Paladox: "Ok moved to task. I have uploaded a photo on what it looks like." [core] - 10https://gerrit.wikimedia.org/r/241477 (https://phabricator.wikimedia.org/T113843) (owner: 10Florianschmidtwelzow) [23:06:13] Oh, hmm. [23:06:15] I'm only half following the conversation [23:06:37] bawolff: yes, master doesn't has styles for the installer, but it should be fixed with the mentioned change :) [23:06:46] bawolff: -> https://gerrit.wikimedia.org/r/#/c/241477/ [23:06:53] (03PS4) 10Polybuildr: Fix issues identified by SpaceBeforeSingleLineComment sniff [core] - 10https://gerrit.wikimedia.org/r/237647 [23:07:20] ori: there ^ :P removed [WIP] [23:07:26] FlorianSW: change being 6018ec28a7dd9393 [23:07:37] add hash object for installer? [23:07:57] (03CR) 10Ori.livneh: [C: 032] Fix issues identified by SpaceBeforeSingleLineComment sniff [core] - 10https://gerrit.wikimedia.org/r/237647 (owner: 10Polybuildr) [23:08:06] bawolff: correct, this should fix the problem. Let me test again :) [23:08:12] still broken for me [23:08:17] ori: wait, you looked at all of them? :o [23:08:25] yes [23:08:28] it didn't take much time [23:08:38] wow. :P [23:08:39] just visually confirm //foo => // foo [23:08:53] There were some weird edge cases. [23:09:21] like // @} ? [23:09:38] ori: yeah. more at https://phabricator.wikimedia.org/T112261#1630423 [23:09:44] bawolff: just to be sure we talk about the same: if you open http://localhost/w/mw-config/ you get the installer without styles? I'll get it with styles :/ Can you check the requests the browser does for the page? What happens with the one to index.php?css=1 ? [23:10:02] ori: or rather, https://phabricator.wikimedia.org/T112261#1630449 [23:10:12] and [23:10:16] ################# [23:10:16] 10MediaWiki-General-or-Unknown, 10MediaWiki-ResourceLoader, 10Vector, 5Patch-For-Review: mw-config now dosent show any styles - https://phabricator.wikimedia.org/T113843#1678712 (10Paladox) Tested it on a different site and works. Thanks for fixing it. [23:10:19] to [23:10:20] Oh, here we go [23:10:24] Exception encountered, of type "Less_Exception_Chunk"
[23:10:25] # ############# [23:10:26] [633b9d2f] /w/git/mw-config/index.php?css=1 Less_Exception_Chunk from line 543 of /var/www/w/git/vendor/oyejorge/less.php/lib/Less/Parser.php: ParseError: Unexpected input in watchstar.less on line 1, column [23:10:33] heh [23:10:34] bawolff: you need to update vector [23:10:35] bawolff: update Vector ;) [23:10:53] (03CR) 10jenkins-bot: [V: 04-1] Fix issues identified by SpaceBeforeSingleLineComment sniff [core] - 10https://gerrit.wikimedia.org/r/237647 (owner: 10Polybuildr) [23:10:59] thanks for the fix, FlorianSW [23:11:12] FlorianSW: yeah, that fixes it [23:11:34] it'd be nice if the cause of that issue was more discoverable [23:11:41] ori: np :P Thanks for the work! :) (my fix is really small compared with ti ;)) [23:12:03] but i guess people aren't going to be downloading wrong version of vector when its bundled with the installer [23:12:14] ti? [23:12:18] ori: I thought the phpcs job would fail for my patch, not qunit :P What does "Expected 24 assertions, but 25 were run" mean? [23:12:45] 10MediaWiki-General-or-Unknown, 10MediaWiki-ResourceLoader, 10Vector, 5Patch-For-Review: mw-config now dosent show any styles - https://phabricator.wikimedia.org/T113843#1678713 (10Florian) @Paladox: Please check the request to the styles and what error messages you get (browser, web server, ...). And plea... [23:12:54] a lot of javascript is asynchronous, which can be tricky to test because the test framework doesn't know when to stop waiting [23:13:05] since a callback doesn't execute in the context of the test [23:13:07] (03Abandoned) 10Florianschmidtwelzow: Revert "resourceloader: Improve caching for LESS file compilation" [core] - 10https://gerrit.wikimedia.org/r/241306 (https://phabricator.wikimedia.org/T113843) (owner: 10Paladox) [23:13:20] so with qunit, for each test, you specify how many asserts there are [23:13:33] if something failed to fire, the test framework will give up eventually [23:13:43] it's usually caused by a badly-written test [23:13:50] ori: hmm. so I go "recheck"? [23:13:55] might as well [23:14:32] (03CR) 10Polybuildr: "recheck" [core] - 10https://gerrit.wikimedia.org/r/237647 (owner: 10Polybuildr) [23:15:04] 10MediaWiki-General-or-Unknown, 10MediaWiki-ResourceLoader, 10Vector, 5Patch-For-Review: mw-config now dosent show any styles - https://phabricator.wikimedia.org/T113843#1678716 (10Paladox) Hi it works now because I was using parts of the patches I reverted. I just uploaded a new copy of files and then add... [23:15:38] 10MediaWiki-General-or-Unknown, 10MediaWiki-ResourceLoader, 10Vector, 5Patch-For-Review: mw-config now dosent show any styles - https://phabricator.wikimedia.org/T113843#1678717 (10Florian) 5Open>3Resolved [23:17:22] (03CR) 10Florianschmidtwelzow: [C: 032] Hygiene: Remove deprecated mobile.templates module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/241110 (owner: 10Jdlrobson) [23:18:08] (03Merged) 10jenkins-bot: Fix issues identified by SpaceBeforeSingleLineComment sniff [core] - 10https://gerrit.wikimedia.org/r/237647 (owner: 10Polybuildr) [23:18:10] (03CR) 10PleaseStand: Add 'hash' object cache for installer (031 comment) [core] - 10https://gerrit.wikimedia.org/r/241477 (https://phabricator.wikimedia.org/T113843) (owner: 10Florianschmidtwelzow) [23:18:41] ori: it got merged :D [23:18:57] (03CR) 10Florianschmidtwelzow: [C: 04-1] "You need to update the Thanks extension, too:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/241084 (https://phabricator.wikimedia.org/T113289) (owner: 10D3r1ck01) [23:19:40] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove deprecated mobile.templates module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/241110 (owner: 10Jdlrobson) [23:23:07] (03PS1) 10Florianschmidtwelzow: Use the new module name for eventlogging module [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/241480 (https://phabricator.wikimedia.org/T113289) [23:23:16] (03CR) 10Paladox: Add 'hash' object cache for installer (031 comment) [core] - 10https://gerrit.wikimedia.org/r/241477 (https://phabricator.wikimedia.org/T113843) (owner: 10Florianschmidtwelzow) [23:23:25] (03CR) 10Florianschmidtwelzow: "-> Ie53dcd6e4031727" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/241084 (https://phabricator.wikimedia.org/T113289) (owner: 10D3r1ck01) [23:25:15] (03CR) 10Florianschmidtwelzow: Add a way to use different tab indexes for CAPTCHA input form (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/240306 (https://phabricator.wikimedia.org/T113432) (owner: 10Florianschmidtwelzow) [23:25:21] (03CR) 10jenkins-bot: [V: 04-1] Use the new module name for eventlogging module [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/241480 (https://phabricator.wikimedia.org/T113289) (owner: 10Florianschmidtwelzow) [23:29:25] (03PS3) 10Florianschmidtwelzow: Add a way to use different tab indexes for CAPTCHA input form [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/240306 (https://phabricator.wikimedia.org/T113432) [23:30:59] (03PS1) 10Polybuildr: Re-enable MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment sniff [core] - 10https://gerrit.wikimedia.org/r/241481 [23:31:05] (03CR) 10Legoktm: [C: 032] "Thanks. Can you file a follow up bug so we don't forget about the FIXME: hardcoded index?" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/240306 (https://phabricator.wikimedia.org/T113432) (owner: 10Florianschmidtwelzow) [23:31:29] (03CR) 10Polybuildr: "The job is almost certainly going to fail for PS1. Should be able to correct and merge after PS2." [core] - 10https://gerrit.wikimedia.org/r/241481 (owner: 10Polybuildr) [23:32:30] 10MediaWiki-Codesniffer, 10Continuous-Integration-Config: Set up checkstyle report for mediawiki-core-phpcs job - https://phabricator.wikimedia.org/T113865#1678719 (10Legoktm) 3NEW [23:33:37] 10MediaWiki-Codesniffer: Release version 0.4.0 of mediawiki/tools/codesniffer - https://phabricator.wikimedia.org/T113516#1678728 (10Legoktm) 5Open>3Resolved a:3Legoktm Released and announcement sent to wikitech-l: * {0104c7063441e179ee0a6598e0a028223bf480dd} * https://lists.wikimedia.org/pipermail/wikitec... [23:33:53] 10MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension): Remove hardcoded tabindex for UserLogin form - https://phabricator.wikimedia.org/T113866#1678732 (10Florian) 3NEW [23:33:59] (03CR) 10Florianschmidtwelzow: "-> Bug: T113866" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/240306 (https://phabricator.wikimedia.org/T113432) (owner: 10Florianschmidtwelzow) [23:34:20] (03CR) 10jenkins-bot: [V: 04-1] Re-enable MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment sniff [core] - 10https://gerrit.wikimedia.org/r/241481 (owner: 10Polybuildr) [23:34:40] (03CR) 10Florianschmidtwelzow: Add 'hash' object cache for installer (031 comment) [core] - 10https://gerrit.wikimedia.org/r/241477 (https://phabricator.wikimedia.org/T113843) (owner: 10Florianschmidtwelzow) [23:34:53] (03Merged) 10jenkins-bot: Add a way to use different tab indexes for CAPTCHA input form [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/240306 (https://phabricator.wikimedia.org/T113432) (owner: 10Florianschmidtwelzow) [23:35:19] 10MediaWiki-General-or-Unknown, 10MediaWiki-ResourceLoader, 10Vector, 5Patch-For-Review: mw-config now dosent show any styles - https://phabricator.wikimedia.org/T113843#1678740 (10Florian) 5Resolved>3Open @PleaseStand mentions, that the problem isn't fixed completely, e.g. if you enable APC(u): https:... [23:35:22] 10MediaWiki-Codesniffer: Add sniff to avoid if/else/while/foreach without curly braces - https://phabricator.wikimedia.org/T113863#1678744 (10Legoktm) I *think* this is https://github.com/squizlabs/PHP_CodeSniffer/blob/master/CodeSniffer/Standards/Generic/Sniffs/ControlStructures/InlineControlStructureSniff.php ? [23:35:34] (03CR) 10Polybuildr: "Hmm. Lots and lots of empty comments." [core] - 10https://gerrit.wikimedia.org/r/241481 (owner: 10Polybuildr) [23:38:08] (03PS2) 10Polybuildr: Re-enable WhiteSpace.SpaceBeforeSingleLineComment sniff [core] - 10https://gerrit.wikimedia.org/r/241481 [23:38:20] (03PS1) 10PleaseStand: Installer: Fix collapsing of field help text [core] - 10https://gerrit.wikimedia.org/r/241482 [23:39:21] (03PS2) 10PleaseStand: Web installer: Fix collapsing of field help text [core] - 10https://gerrit.wikimedia.org/r/241482 [23:40:59] (03CR) 10Paladox: "This may fix this bug T112383" [core] - 10https://gerrit.wikimedia.org/r/241482 (owner: 10PleaseStand) [23:41:15] (03CR) 10Paladox: "Should include T112383 in comment." [core] - 10https://gerrit.wikimedia.org/r/241482 (owner: 10PleaseStand) [23:42:03] (03CR) 10jenkins-bot: [V: 04-1] Re-enable WhiteSpace.SpaceBeforeSingleLineComment sniff [core] - 10https://gerrit.wikimedia.org/r/241481 (owner: 10Polybuildr) [23:43:23] (03CR) 10jenkins-bot: [V: 04-1] Web installer: Fix collapsing of field help text [core] - 10https://gerrit.wikimedia.org/r/241482 (owner: 10PleaseStand) [23:43:54] (03PS1) 10Florianschmidtwelzow: Don't overwrite all available object caches [core] - 10https://gerrit.wikimedia.org/r/241484 (https://phabricator.wikimedia.org/T113843) [23:44:25] (03PS1) 10Polybuildr: Add space after "//" to pass SpaceBeforeSingleLineComment sniff [core] - 10https://gerrit.wikimedia.org/r/241485 [23:44:47] (03PS3) 10Polybuildr: Re-enable WhiteSpace.SpaceBeforeSingleLineComment sniff [core] - 10https://gerrit.wikimedia.org/r/241481 [23:45:07] Reedy, legoktm ^ those two should be good to go, one after the other. [23:45:16] (03PS2) 10Florianschmidtwelzow: Don't overwrite all available object caches [core] - 10https://gerrit.wikimedia.org/r/241484 (https://phabricator.wikimedia.org/T113843) [23:45:40] (03CR) 10Florianschmidtwelzow: Add 'hash' object cache for installer (031 comment) [core] - 10https://gerrit.wikimedia.org/r/241477 (https://phabricator.wikimedia.org/T113843) (owner: 10Florianschmidtwelzow) [23:47:47] okay bye bye o/ [23:50:11] 10Wikimedia-Mailing-lists: Create affiliates-l mailing list for Wikimedia Movement Affiliates - https://phabricator.wikimedia.org/T113867#1678751 (10Varnent) 3NEW [23:50:32] 10MediaWiki-Codesniffer, 5Patch-For-Review: Add sniff to avoid if/else/while/foreach without curly braces - https://phabricator.wikimedia.org/T113863#1678758 (10Legoktm) The test run against MediaWiki core found https://phabricator.wikimedia.org/diffusion/MW/browse/master/includes/SquidPurgeClient.php;19d5f55c... [23:51:04] (03CR) 10Paladox: [C: 031] "Thank you for fixing problem now works on my other site too." [core] - 10https://gerrit.wikimedia.org/r/241484 (https://phabricator.wikimedia.org/T113843) (owner: 10Florianschmidtwelzow) [23:51:20] (03CR) 10Florianschmidtwelzow: Remove non existing css file reference (031 comment) [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/241471 (https://phabricator.wikimedia.org/T113860) (owner: 10Paladox) [23:55:50] (03CR) 10Paladox: Remove non existing css file reference (031 comment) [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/241471 (https://phabricator.wikimedia.org/T113860) (owner: 10Paladox) [23:56:50] (03CR) 10Paladox: Remove non existing css file reference (031 comment) [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/241471 (https://phabricator.wikimedia.org/T113860) (owner: 10Paladox) [23:57:15] (03PS3) 10PleaseStand: Web installer: Fix collapsing of field help text [core] - 10https://gerrit.wikimedia.org/r/241482 (https://phabricator.wikimedia.org/T112383)