[00:00:12] (03PS1) 10Mooeypoo: Correct 'primaryLink' to 'primaryUrl' everywhere [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235643 [00:00:43] (03CR) 10Jdlrobson: "Interesting. I'll have a think about this some more. It seems we could provide buttons in the top that provide the correct sizes, colours " [core] - 10https://gerrit.wikimedia.org/r/235297 (https://phabricator.wikimedia.org/T98395) (owner: 10Jdlrobson) [00:00:57] (03CR) 10Catrope: [C: 032] Correct 'primaryLink' to 'primaryUrl' everywhere [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235643 (owner: 10Mooeypoo) [00:01:44] (03PS6) 10Legoktm: Load mediawiki.ui.button anchor and icon styles at bottom of page. [core] - 10https://gerrit.wikimedia.org/r/235297 (https://phabricator.wikimedia.org/T98395) (owner: 10Jdlrobson) [00:02:57] 10MobileFrontend, 3Reading-Web-Sprint-55-π: Remove mobile.experiments module from MobileFrontend - https://phabricator.wikimedia.org/T111287#1600373 (10Jdlrobson) 3NEW [00:03:22] (03PS3) 10Aaron Schulz: Set watchlisttoken preference on account creation [core] - 10https://gerrit.wikimedia.org/r/235174 (https://phabricator.wikimedia.org/T92357) [00:04:13] (03PS1) 10Mooeypoo: [wip] Toggle the save button when there are changes to the content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235646 [00:05:28] (03CR) 10jenkins-bot: [V: 04-1] QA: Run ui links tests per commit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/235635 (owner: 10Jdlrobson) [00:05:30] (03CR) 10jenkins-bot: [V: 04-1] Correct 'primaryLink' to 'primaryUrl' everywhere [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235643 (owner: 10Mooeypoo) [00:06:08] (03CR) 10jenkins-bot: [V: 04-1] QA: Run language browser tests per commit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/235636 (https://phabricator.wikimedia.org/T107910) (owner: 10Jdlrobson) [00:06:43] (03PS2) 10Mooeypoo: [wip] Toggle the save button when there are changes to the content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235646 [00:07:51] (03CR) 10Sniedzielski: [C: 032] Developer preference for RESTBase base URI [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/235524 (owner: 10BearND) [00:08:00] (03CR) 10jenkins-bot: [V: 04-1] tests: Remove "install" target from makefile documentation [core] - 10https://gerrit.wikimedia.org/r/235640 (owner: 10Jberkel) [00:09:15] (03CR) 10jenkins-bot: [V: 04-1] [wip] Toggle the save button when there are changes to the content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235646 (owner: 10Mooeypoo) [00:09:56] (03PS1) 10Aaron Schulz: Default the "watchlisttoken" value to a derived HMAC value [core] - 10https://gerrit.wikimedia.org/r/235647 (https://phabricator.wikimedia.org/T92357) [00:10:08] 3Wikipedia-iOS-App-Development, 7WorkType-NewFunctionality: Update search field - https://phabricator.wikimedia.org/T110726#1600391 (10Mhurd) https://github.com/wikimedia/wikipedia-ios/pull/105 [00:10:45] 10Wiki-Loves-Monuments-Sources: WLM lists in (es,es) link to Commons categories using categoría-Commons, not commonscat - https://phabricator.wikimedia.org/T111288#1600392 (10JeanFred) 3NEW a:3JeanFred [00:11:07] ori: I guess https://gerrit.wikimedia.org/r/#/c/234836/ is the last of that batch [00:11:25] hmm, needs rebase [00:12:00] AaronSchulz: re: zhwiki memcached ERROR: Memcached error for key "zhwiki:preprocess-hash:b878bc90c624257155bc0aa0e4b4e0c5:1" [00:12:12] I have a dump of the serialized value it is trying to write [00:12:15] it is 29 megs [00:12:40] very repetitive (compresses to 1.5 mb) [00:12:56] not that i think gzip is the answer; just citing it as an indication of how repetitive the data is [00:13:16] (03PS11) 10Bmansurov: Add browser tests for external surveys [extensions/QuickSurveys] (dev) - 10https://gerrit.wikimedia.org/r/233933 (https://phabricator.wikimedia.org/T110225) [00:13:25] (03CR) 10jenkins-bot: [V: 04-1] Add browser tests for external surveys [extensions/QuickSurveys] (dev) - 10https://gerrit.wikimedia.org/r/233933 (https://phabricator.wikimedia.org/T110225) (owner: 10Bmansurov) [00:13:46] ori: is broken or just huge? [00:13:57] define broken [00:14:24] do we really not have a task for this btw?! [00:15:19] 10MediaWiki-extensions-UploadWizard, 6Multimedia, 5Patch-For-Review: Chunked/stashed uploads fail for some pdf and djvu files: "No specifications provided to ArchivedFile constructor." - https://phabricator.wikimedia.org/T94562#1600403 (103BRBS) @Tgr, sorry for asking this, but where can I access the Special... [00:15:32] (03CR) 10Niedzielski: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/235281 (https://phabricator.wikimedia.org/T108377) (owner: 10Mholloway) [00:16:45] (03CR) 10Niedzielski: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/212922 (https://phabricator.wikimedia.org/T100315) (owner: 10Aude) [00:17:16] 10MediaWiki-Parser, 7Wikimedia-log-errors: Frequent memcached error for *:preprocess-hash:*:* keys - https://phabricator.wikimedia.org/T111289#1600408 (10ori) 3NEW [00:18:06] (03PS3) 10Aaron Schulz: Avoid MessageCache rebuilds if replace() was called recently [core] - 10https://gerrit.wikimedia.org/r/234836 [00:19:25] (03CR) 10Aaron Schulz: "rebased" [core] - 10https://gerrit.wikimedia.org/r/234836 (owner: 10Aaron Schulz) [00:20:09] 10MediaWiki-Parser, 7Wikimedia-log-errors: Frequent memcached error for *:preprocess-hash:*:* keys - https://phabricator.wikimedia.org/T111289#1600424 (10ori) The file below is the string value that MediaWiki is attempting to store under the key `zhwiki:preprocess-hash:b878bc90c624257155bc0aa0e4b4e0c5`: {F253... [00:20:17] ^ AaronSchulz [00:20:18] (03Merged) 10jenkins-bot: Developer preference for RESTBase base URI [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/235524 (owner: 10BearND) [00:21:18] 10MediaWiki-extensions-UploadWizard, 6Multimedia, 5Patch-For-Review: Chunked/stashed uploads fail for some pdf and djvu files: "No specifications provided to ArchivedFile constructor." - https://phabricator.wikimedia.org/T94562#1600425 (10Tgr) Just type in `Special:Upload` in the search box. [00:24:13] 6Editing-Analysis: Follow up on users from the visual editor experiment - https://phabricator.wikimedia.org/T111290#1600426 (10Neil_P._Quinn_WMF) 3NEW [00:24:34] (03PS4) 10Aaron Schulz: Avoid MessageCache rebuilds if replace() was called recently [core] - 10https://gerrit.wikimedia.org/r/234836 [00:26:34] (03PS1) 10BearND: Avoid exceptions when there is an API error. [services/mobileapps] - 10https://gerrit.wikimedia.org/r/235649 (https://phabricator.wikimedia.org/T111114) [00:27:59] (03PS1) 10Ori.livneh: Decline to cache preprocessor items larger than 1 Mb [core] - 10https://gerrit.wikimedia.org/r/235650 (https://phabricator.wikimedia.org/T111289) [00:28:10] AaronSchulz: ^ [00:28:21] AaronSchulz: see the commit msg; i intend for that to be temporary [00:28:34] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add map to nearby fragment [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/212922 (https://phabricator.wikimedia.org/T100315) (owner: 10Aude) [00:30:42] (03PS1) 10Ori.livneh: Decline to cache preprocessor items larger than 1 Mb [core] (wmf/1.26wmf21) - 10https://gerrit.wikimedia.org/r/235651 (https://phabricator.wikimedia.org/T111289) [00:31:00] (03CR) 10Ori.livneh: [C: 032] Decline to cache preprocessor items larger than 1 Mb [core] (wmf/1.26wmf21) - 10https://gerrit.wikimedia.org/r/235651 (https://phabricator.wikimedia.org/T111289) (owner: 10Ori.livneh) [00:31:29] (03PS1) 10Ori.livneh: Decline to cache preprocessor items larger than 1 Mb [core] (wmf/1.26wmf20) - 10https://gerrit.wikimedia.org/r/235652 (https://phabricator.wikimedia.org/T111289) [00:31:38] (03CR) 10Ori.livneh: [C: 032] Decline to cache preprocessor items larger than 1 Mb [core] (wmf/1.26wmf20) - 10https://gerrit.wikimedia.org/r/235652 (https://phabricator.wikimedia.org/T111289) (owner: 10Ori.livneh) [00:33:45] (03PS7) 10Bmansurov: Add an option to load a specific survey [extensions/QuickSurveys] (dev) - 10https://gerrit.wikimedia.org/r/233930 (https://phabricator.wikimedia.org/T110225) [00:34:14] 10MediaWiki-extensions-UploadWizard, 6Multimedia, 5Patch-For-Review: Chunked/stashed uploads fail for some pdf and djvu files: "No specifications provided to ArchivedFile constructor." - https://phabricator.wikimedia.org/T94562#1600471 (103BRBS) Thanks, I already tried this option with chunk upload (didn't k... [00:34:43] 10QuickSurveys, 3Reading-Web-Sprint-55-π: Don't load Mustache and Hogan on mobile - https://phabricator.wikimedia.org/T111292#1600472 (10Jdlrobson) 3NEW [00:34:46] (03CR) 10Ori.livneh: [V: 032] Decline to cache preprocessor items larger than 1 Mb [core] (wmf/1.26wmf21) - 10https://gerrit.wikimedia.org/r/235651 (https://phabricator.wikimedia.org/T111289) (owner: 10Ori.livneh) [00:34:53] (03CR) 10Ori.livneh: [V: 032] Decline to cache preprocessor items larger than 1 Mb [core] (wmf/1.26wmf20) - 10https://gerrit.wikimedia.org/r/235652 (https://phabricator.wikimedia.org/T111289) (owner: 10Ori.livneh) [00:35:45] (03PS1) 10Jdlrobson: Do not load Mustache and Hogan on mobile [extensions/QuickSurveys] (dev) - 10https://gerrit.wikimedia.org/r/235655 (https://phabricator.wikimedia.org/T111292) [00:36:49] 10QuickSurveys, 5Patch-For-Review, 3Reading-Web-Sprint-55-π: Don't load Mustache and Hogan on mobile - https://phabricator.wikimedia.org/T111292#1600486 (10Jdlrobson) a:3Jdlrobson [00:36:54] (03PS12) 10Bmansurov: Add browser tests for external surveys [extensions/QuickSurveys] (dev) - 10https://gerrit.wikimedia.org/r/233933 (https://phabricator.wikimedia.org/T110225) [00:37:18] (03CR) 10jenkins-bot: [V: 04-1] Do not load Mustache and Hogan on mobile [extensions/QuickSurveys] (dev) - 10https://gerrit.wikimedia.org/r/235655 (https://phabricator.wikimedia.org/T111292) (owner: 10Jdlrobson) [00:37:33] 10QuickSurveys, 5Patch-For-Review, 3Reading-Web-Sprint-55-π: Add basic browser tests: external surveys - https://phabricator.wikimedia.org/T110225#1600488 (10bmansurov) @jdlrobson, thanks! I've squashed the patches. [00:37:36] (03PS2) 10Jdlrobson: Suggested improvements to browser tests [extensions/QuickSurveys] (dev) - 10https://gerrit.wikimedia.org/r/235618 [00:37:54] 3Discovery-Cirrus-Sprint: insource cannot find repeating words - https://phabricator.wikimedia.org/T111293#1600490 (10Cpiral) 3NEW [00:38:58] (03CR) 10Jdlrobson: [C: 031] "I'll +2 when I see the tests pass :)" [extensions/QuickSurveys] (dev) - 10https://gerrit.wikimedia.org/r/233933 (https://phabricator.wikimedia.org/T110225) (owner: 10Bmansurov) [00:39:37] (03CR) 10jenkins-bot: [V: 04-1] Add browser tests for external surveys [extensions/QuickSurveys] (dev) - 10https://gerrit.wikimedia.org/r/233933 (https://phabricator.wikimedia.org/T110225) (owner: 10Bmansurov) [00:41:40] 10Wiki-Loves-Monuments-Database: Add continuous integration on labs/tools/heritage with flake8 - https://phabricator.wikimedia.org/T111294#1600499 (10JeanFred) 3NEW a:3JeanFred [00:42:39] (03PS13) 10Bmansurov: Add browser tests for external surveys [extensions/QuickSurveys] (dev) - 10https://gerrit.wikimedia.org/r/233933 (https://phabricator.wikimedia.org/T110225) [00:43:13] AndyRussG: does the centralnotice deploy do anything to change the usage of cookies for centralnotice_buckets_by_campaign ? [00:43:14] 10Wikipedia-iOS-App-Product-Backlog: Recent searches is recording each keystroke, creates cluttered useless recent list - https://phabricator.wikimedia.org/T111093#1600507 (10Mhurd) [00:44:37] (03CR) 10Jdlrobson: [C: 032] "Tests are passing in follow up commit." [extensions/QuickSurveys] (dev) - 10https://gerrit.wikimedia.org/r/233930 (https://phabricator.wikimedia.org/T110225) (owner: 10Bmansurov) [00:44:46] 10Wikipedia-iOS-App-Product-Backlog: Recent searches is recording each keystroke, creates cluttered useless recent list - https://phabricator.wikimedia.org/T111093#1594162 (10Mhurd) [00:45:16] 10Wikipedia-iOS-App-Product-Backlog: Recent searches is recording each keystroke, creates cluttered useless recent list - https://phabricator.wikimedia.org/T111093#1594162 (10Mhurd) [00:45:30] 10Wikipedia-iOS-App-Product-Backlog: Recent searches is recording each keystroke, creates cluttered useless recent list - https://phabricator.wikimedia.org/T111093#1600510 (10Mhurd) [00:45:50] (03CR) 10jenkins-bot: [V: 04-1] Add browser tests for external surveys [extensions/QuickSurveys] (dev) - 10https://gerrit.wikimedia.org/r/233933 (https://phabricator.wikimedia.org/T110225) (owner: 10Bmansurov) [00:45:58] 10Wikipedia-iOS-App-Product-Backlog: Recent searches is recording each keystroke, creates cluttered useless recent list - https://phabricator.wikimedia.org/T111093#1594162 (10Mhurd) [00:46:29] (03PS14) 10Bmansurov: Add browser tests for external surveys [extensions/QuickSurveys] (dev) - 10https://gerrit.wikimedia.org/r/233933 (https://phabricator.wikimedia.org/T110225) [00:46:45] 10MobileFrontend, 5Patch-For-Review, 3Reading-Web-Sprint-55-π: Migrate languages and ui links browser tests to JJB - https://phabricator.wikimedia.org/T107910#1506924 (10Jdlrobson) Anyone have any ideas with how to get https://gerrit.wikimedia.org/r/235635 to pass? What am I doing wrong in the LocalSettings.... [00:50:01] (03Merged) 10jenkins-bot: Add an option to load a specific survey [extensions/QuickSurveys] (dev) - 10https://gerrit.wikimedia.org/r/233930 (https://phabricator.wikimedia.org/T110225) (owner: 10Bmansurov) [00:52:53] (03PS5) 10Jdlrobson: QA: Run ui links tests per commit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/235635 [00:53:13] 10MobileFrontend, 5Patch-For-Review, 3Reading-Web-Sprint-55-π: Migrate languages and ui links browser tests to JJB - https://phabricator.wikimedia.org/T107910#1506924 (10Jdlrobson) ^ Might have worked it out. Fingers crossed. [00:53:35] (03CR) 10Jdlrobson: [C: 032] "\o/" [extensions/QuickSurveys] (dev) - 10https://gerrit.wikimedia.org/r/233933 (https://phabricator.wikimedia.org/T110225) (owner: 10Bmansurov) [00:53:47] jdlrobson, thanks [00:54:32] 10QuickSurveys, 5Patch-For-Review, 3Reading-Web-Sprint-55-π: Add basic browser tests: external surveys - https://phabricator.wikimedia.org/T110225#1572595 (10Jdlrobson) (Will move back if it doesn't merge for whatever reason) [00:55:11] (03CR) 10Ori.livneh: [C: 032] Avoid MessageCache rebuilds if replace() was called recently [core] - 10https://gerrit.wikimedia.org/r/234836 (owner: 10Aaron Schulz) [00:55:58] 10MediaWiki-extensions-UploadWizard, 6Multimedia, 5Patch-For-Review: Chunked/stashed uploads fail for some pdf and djvu files: "No specifications provided to ArchivedFile constructor." - https://phabricator.wikimedia.org/T94562#1600538 (103BRBS) Oki, I tried again without chunk upload. The file I amuploading... [00:56:47] (03Merged) 10jenkins-bot: Add browser tests for external surveys [extensions/QuickSurveys] (dev) - 10https://gerrit.wikimedia.org/r/233933 (https://phabricator.wikimedia.org/T110225) (owner: 10Bmansurov) [01:00:03] (03CR) 10Krinkle: Avoid MessageCache rebuilds if replace() was called recently (031 comment) [core] - 10https://gerrit.wikimedia.org/r/234836 (owner: 10Aaron Schulz) [01:01:30] (03CR) 10Bmansurov: "Removing the -1 per Jdlrobson's comment." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/234852 (https://phabricator.wikimedia.org/T98829) (owner: 10Adishaporwal) [01:01:32] (03CR) 10jenkins-bot: [V: 04-1] QA: Run ui links tests per commit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/235635 (owner: 10Jdlrobson) [01:02:20] (03PS1) 10BearND: Safer RbService error handling [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/235658 [01:03:29] (03CR) 10jenkins-bot: [V: 04-1] Avoid MessageCache rebuilds if replace() was called recently [core] - 10https://gerrit.wikimedia.org/r/234836 (owner: 10Aaron Schulz) [01:03:50] (03CR) 10Krinkle: ""validateOldUser" is only used by validation-callback, I'd say the problem is there, not in the validate method. The validate method shoul" [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/235446 (https://phabricator.wikimedia.org/T101681) (owner: 10Glaisher) [01:05:44] (03PS5) 10Aaron Schulz: Avoid MessageCache rebuilds if replace() was called recently [core] - 10https://gerrit.wikimedia.org/r/234836 [01:06:07] 10Wiki-Loves-Monuments-Database, 5Patch-For-Review: Add continuous integration on labs/tools/heritage with flake8 - https://phabricator.wikimedia.org/T111294#1600555 (10JeanFred) 5Open>3Resolved Done. Will open a new taks for more linting / tests. [01:06:24] (03PS6) 10Aaron Schulz: Avoid MessageCache rebuilds if replace() was called recently [core] - 10https://gerrit.wikimedia.org/r/234836 [01:08:11] (03CR) 10Krinkle: [C: 032] Avoid MessageCache rebuilds if replace() was called recently [core] - 10https://gerrit.wikimedia.org/r/234836 (owner: 10Aaron Schulz) [01:08:34] AaronSchulz: btw, not sure why Jenkins -1'ed. Looks like a flaky test in Flow-qunit [01:08:40] 10MediaWiki-Authentication-and-authorization, 6Reading-Infrastructure-Team: Get rid of FauxRequest support in AuthManager - https://phabricator.wikimedia.org/T111296#1600560 (10Tgr) 3NEW [01:11:36] (03PS1) 10Mooeypoo: Separate 'seen time' for alerts and messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235659 (https://phabricator.wikimedia.org/T111285) [01:13:05] (03CR) 10jenkins-bot: [V: 04-1] Separate 'seen time' for alerts and messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235659 (https://phabricator.wikimedia.org/T111285) (owner: 10Mooeypoo) [01:14:23] 10MediaWiki-Documentation, 6WMF-Legal, 10Web-APIs-Hub, 7Documentation: technology to transclude git content into wiki pages - https://phabricator.wikimedia.org/T91626#1600572 (10Spage) p:5Low>3Normal a:5hashar>3None [01:15:53] (03PS2) 10Mooeypoo: Separate 'seen time' for alerts and messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235659 (https://phabricator.wikimedia.org/T111285) [01:17:20] (03CR) 10jenkins-bot: [V: 04-1] Separate 'seen time' for alerts and messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235659 (https://phabricator.wikimedia.org/T111285) (owner: 10Mooeypoo) [01:17:26] (03Merged) 10jenkins-bot: Avoid MessageCache rebuilds if replace() was called recently [core] - 10https://gerrit.wikimedia.org/r/234836 (owner: 10Aaron Schulz) [01:18:07] (03PS3) 10Mooeypoo: Separate 'seen time' for alerts and messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235659 (https://phabricator.wikimedia.org/T111285) [01:19:00] 10Wikimedia-Interwiki-links, 10Wikimedia-Site-Requests: Update interwiki.cdb - https://phabricator.wikimedia.org/T111297#1600583 (10Billinghurst) 3NEW [01:19:05] (03CR) 10Mooeypoo: [C: 032] "..." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235643 (owner: 10Mooeypoo) [01:19:15] (03CR) 10jenkins-bot: [V: 04-1] Separate 'seen time' for alerts and messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235659 (https://phabricator.wikimedia.org/T111285) (owner: 10Mooeypoo) [01:20:13] 10Wikimedia-Interwiki-links, 10Wikimedia-Site-Requests: Update interwiki.cdb - https://phabricator.wikimedia.org/T111297#1600592 (10Billinghurst) @slaporte fyi [01:20:33] (03CR) 10Catrope: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235659 (https://phabricator.wikimedia.org/T111285) (owner: 10Mooeypoo) [01:20:55] (03CR) 10jenkins-bot: [V: 04-1] Correct 'primaryLink' to 'primaryUrl' everywhere [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235643 (owner: 10Mooeypoo) [01:21:45] (03CR) 10Mattflaschen: [C: 04-1] "The assertEquals should have expected first." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/235458 (https://phabricator.wikimedia.org/T111138) (owner: 10Matthias Mullie) [01:23:55] (03CR) 10Tim Starling: "I haven't migrated the tests away from the old configuration globals or introduced convenient defaults for the $wgTidyConfig parameters si" [core] - 10https://gerrit.wikimedia.org/r/235401 (owner: 10Tim Starling) [01:25:27] 10MediaWiki-Documentation, 7Documentation: make doc files in git more useful - https://phabricator.wikimedia.org/T111298#1600599 (10Spage) 3NEW [01:27:56] 10Architecture, 7Documentation: Replace docs/design.txt with a reasonably complete summary of mw:Architectural_guidelines - https://phabricator.wikimedia.org/T111283#1600615 (10Spage) Sounds good. doxgen turns this into garbled https://doc.wikimedia.org/mediawiki-core/master/php/design_8txt.html , aggh. I cre... [01:30:45] ori: no it doesn't. That cookie works exactly the same way as before [01:31:36] Most everything works as before, but does it in a more organized and encapsulated way [01:32:46] That was more or less on purpose: don't change functionality, but refactor and reorganize, check that everything still works, and then build out new functionality with less tech debt :) [01:33:10] 10Wikimedia-Interwiki-links, 10Wikimedia-Site-Requests: Update interwiki.cdb - https://phabricator.wikimedia.org/T111297#1600620 (10Krenair) 5Open>3Resolved a:3Krenair 01:32:51 Synchronized wmf-config/interwiki.cdb: Updating interwiki cache (duration: 00m 12s) [01:33:13] Though yes, we did build out some more stuff! [01:33:47] ori: I understand excess cookie trafic is a performance issue, right? [01:39:32] 10ReleaseTaggerBot, 5Patch-For-Review: forrestbot's logging should include timestamps - https://phabricator.wikimedia.org/T103416#1600629 (10Jdforrester-WMF) p:5Triage>3Normal a:3Jdforrester-WMF [01:43:25] 3Discovery-Cirrus-Sprint: insource cannot find repeating words - https://phabricator.wikimedia.org/T111293#1600641 (10Cpiral) [01:43:55] AndyRussG: yes [01:44:42] ori: yeah, I was just noticing that it's a pretty big amount of data going back and forth with cookies [01:45:29] AndyRussG: I see some mention of storing errors in cookies now, too -- is that new? [01:45:49] 10Wikimedia-Interwiki-links, 10Wikimedia-Site-Requests: Update interwiki.cdb - https://phabricator.wikimedia.org/T111297#1600644 (10Billinghurst) magic! Thanks @Krenair (if there is a better means to do this, then please let me know) [01:46:12] 10MediaWiki-extensions-UploadWizard, 6Multimedia, 5Patch-For-Review: Chunked/stashed uploads fail for some pdf and djvu files: "No specifications provided to ArchivedFile constructor." - https://phabricator.wikimedia.org/T94562#1600645 (10waldyrious) >>! In T94562#1591248, @3BRBS wrote: > I couldn't manage t... [01:46:39] ori: yes... but it should only be a small number of users. It's just to make a note of when there's been a problem with LocalStorage [01:46:44] 10MediaWiki-Authentication-and-authorization: Create convenience base classes for AuthManager providers - https://phabricator.wikimedia.org/T111299#1600646 (10Tgr) 3NEW [01:47:42] AndyRussG: ok, subscribing/ext.centralNotice.kvStore.js has to change [01:47:54] in what way? [01:47:56] not cool: [01:47:59] // Don't let the cookie hold toooooooooo many errors [01:48:03] not cool: [01:48:04] // Store in the cookie; 2 years expiry should be sufficient [01:48:15] not cool: [01:48:21] // Limit the length of the value to store [01:48:22] value: JSON.stringify( value ).substring( 0, 50 ), [01:48:50] you shouldn't subject even a small number of users to that [01:49:00] and i don't see how you can be confident that it will only affect a small number of users [01:49:23] hmmm [01:49:32] well yes we can cut down the size, for sure [01:49:45] no, this is not an appropriate use of cookies [01:50:28] hmmm [01:50:42] would you suggest we eliminate it completely? or just try to make it really teeny? [01:51:04] eliminate it completely [01:51:17] OK [01:51:19] you can fire an eventlogging event for malformed values if you want [01:52:19] 10Wikimedia-Interwiki-links, 10Wikimedia-Site-Requests: Update interwiki.cdb - https://phabricator.wikimedia.org/T111297#1600661 (10Krenair) Might be easier if we got ops to run `updateinterwikicache` on a regular cron on tin (usually terbium is the host for maintenance scripts, but this script needs to be run... [01:52:59] ori: it's not malformed values per se. It's any problem with localStorage that would make the stats processing of banner history need to eliminate a given element from the sample [01:53:32] AndyRussG: "Changes that are liable to affect site performance or infrastructure should be announced on the ops mailing list. This includes anything that alters caching behavior, introduces cookies, substantially increases the static asset payload, or adds new and complicated query patterns." (https://wikitech.wikimedia.org/wiki/Deployments) [01:53:37] your e-mail made no mention of the new cookie [01:54:35] just off the top of my head, a less dataful but quite likely OK alternative would be just to try writing and reading to local storage before sending the log, and marking logs as invalid if there were any error at that time [01:54:52] re ^ that policy, yes I missed that, sorry [01:55:25] Note that the feature is actually not activated on any campaign yet, though yes given that policy it should have been mentioned [01:55:36] AndyRussG: i don't know in what universe it's ok to tag the next two years' worth of requests because they had some malformed value in localstorage [01:56:07] ori: its _not_ 2 years worth of request [01:56:08] s [01:56:27] I mean, not for any substantially active user [01:56:56] ori: I'll send up a patch to get rid of it right away [01:57:00] thanks [01:57:16] np [01:58:19] ori: can I also just mention that quite _a lot_ of thought went into improving performance here, even though we got this part wrong? [01:58:25] AndyRussG: It seems this sets keys in localStorage directly (eg. not wrapped in a single cn/kvstore object). Beware that there is no TTL or LRU in localStorage. a key set not unset, will persist indefinitely. [01:58:37] I don't see anything that garbage collects these at any point. [01:59:48] Especailly after the banner using it is no longer live [02:00:05] Krinkle: correct, there is not global garbage collection for the kvStore. There is garbage collection for the log, though [02:00:24] Krinkle: OK, that's also a good idea [02:00:35] 10MediaWiki-extensions-UploadWizard, 6Multimedia, 5Patch-For-Review: Chunked/stashed uploads fail for some pdf and djvu files: "No specifications provided to ArchivedFile constructor." - https://phabricator.wikimedia.org/T94562#1600679 (10Tgr) > NS_ERROR_DOM_QUOTA_REACHED: Persistent storage maximum size rea... [02:00:48] what's the point of storing errors in localStorage anyway? [02:01:26] paravoid: no, errors were being stored in a cookie. LocalStorage is for the log of banner impressions [02:01:39] AndyRussG: I appreciate that, but we're grown ups, and you don't get a gold star for effort. There are norms of quality to meet and this doesn't meet them, IMO. It is a little surprising. [02:02:20] or rather were to be stored in a cookie, to be removed in a short bit [02:02:41] ok, why are banner impressions logged in localStorage then? :) [02:02:57] paravoid: To ensure you don't see the same one too often. [02:04:01] ori: I disagree. This code is way better organized and easier to read than what preceeded it. That's something that's sorely lacking in many parts of our codebase, and also contributes to something that's on par with performance in terms of importance: maintainability [02:04:16] I'm not asking for a gold star. [02:04:41] Also lots of people were added as reviewers to this code and input was solicited many times [02:05:01] AndyRussG: it's not just performance, either -- the privacy implications are terrifying too. You call logError from kvStore.setItem with both the key and value [02:05:08] and you don't clear that when a user logs out [02:06:58] ori: the privacy implications are no more nor less terrifying than localstorage itself. It's a framework to make localstorage easier to for CN code, and the reason for making it a framework was in part to have a path to getting rid of a bunch of things that are being stored haphazardly in cookies currently [02:07:25] AndyRussG: look, I'm sorry. My tone is probably out-of-line. I don't have an opinion about the set of changes in their entirety; they may be otherwise excellent. This particular issue struck me as pretty crazy but I have made my share of severe mistakes. [02:07:30] Just please fix it. [02:08:18] ori: Krinkle: I'll get rid of the cookie and also make a global GC mechanism for the KVstore right away [02:08:53] I did skim through the rest of the change and the emphasis on modularity and single-responsibility looks great, so kudos for that. [02:09:49] ori: np :) and thanks, yeah that was a major goal... I'm not convinced that the whole thing is excellent, either, and I do appreciate hearing about this and any other issues! [02:10:18] (03PS1) 10Krinkle: minerva: Let background-color of last-modified-bar transition [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/235665 [02:10:48] (03PS2) 10Krinkle: minerva: Let background-color of last-modified-bar transition [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/235665 [02:13:47] ori: again not to ask for any gold stars, but on the count of privacy, I also do want to say we thought about it a lot: for example, in banner history, we fuzz the timestamps of the banner log to make it impossible to ever correlate with web server logs. Also, it's a way to get FR analytics info they've been asking for for a long time without resorting to persistent uinque IDs [02:17:25] (03CR) 10Jforrester: [C: 031] "Seems reasonable from a 'freshness of editing' product perspective, but this is a call for Reading product." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/235665 (owner: 10Krinkle) [02:32:11] 10Wikimedia-Site-Requests, 7Community-consensus-needed: Change Kannada Wikisource logo and project title - https://phabricator.wikimedia.org/T110806#1600702 (10Omshivaprakash) Dear Marco, 3 people have voted for the community discussion so far. Wiki source is a small community around Kannada wiki projects. W... [02:33:08] 10MediaWiki-extensions-Scribunto, 10Wikimedia-Site-Requests, 7Community-consensus-needed: Change of namespaces on kannada wikisource - https://phabricator.wikimedia.org/T103650#1600703 (10Omshivaprakash) [02:33:10] 10Wikimedia-Site-Requests, 7Community-consensus-needed: Change Kannada Wikisource logo and project title - https://phabricator.wikimedia.org/T110806#1600705 (10Omshivaprakash) [02:35:40] 4(no projects): pmtpa remnants in trebuchet redis - https://phabricator.wikimedia.org/T111301#1600707 (10Dzahn) 3NEW [02:36:25] 10MediaWiki-Authentication-and-authorization, 6Reading-Infrastructure-Team: Handle central user IDs in AuthManager - https://phabricator.wikimedia.org/T111302#1600717 (10Tgr) 3NEW [02:37:05] 10MediaWiki-extensions-UploadWizard, 6Multimedia, 5Patch-For-Review: Chunked/stashed uploads fail for some pdf and djvu files: "No specifications provided to ArchivedFile constructor." - https://phabricator.wikimedia.org/T94562#1600725 (103BRBS) @Tgr, I already tried all the methods, this is: URL2Commons, Ch... [02:39:41] 6Phabricator, 6operations, 7Database, 5Patch-For-Review: Phabricator creates MySQL connection spikes - https://phabricator.wikimedia.org/T109279#1600727 (10mmodell) I think the configuration change is a sensible one, at least for now, until we find a better solution. [02:44:26] 10MediaWiki-Authentication-and-authorization: Create password verification API with AuthManager - https://phabricator.wikimedia.org/T111303#1600730 (10Tgr) 3NEW [02:44:41] 10MediaWiki-API, 10MediaWiki-Authentication-and-authorization, 6Reading-Infrastructure-Team: Create user name verification API with AuthManager - https://phabricator.wikimedia.org/T110751#1600738 (10Tgr) See also T111303. [02:52:04] 10MediaWiki-General-or-Unknown, 5MW-1.26-release, 5Patch-For-Review, 5WMF-deploy-2015-08-25_(1.26wmf20), and 2 others: xml_parser_free: Parser cannot be freed while it is parsing - https://phabricator.wikimedia.org/T89532#1600752 (10mmodell) I'm not seeing this one in production anymore. Safe to resolve t... [02:52:31] msg test steven [02:54:58] 6Phabricator: Not all Phabricator tasks are crawled by search engines - https://phabricator.wikimedia.org/T76991#1600755 (10mmodell) @nemo_bis: only workboards are blocked, the crawlers can still find all of the projects and from there they can find all tasks via the projects' task lists. Additionally, There is... [02:56:20] 10Wikimedia-Interwiki-links, 10Wikimedia-Site-Requests: Update interwiki.cdb - https://phabricator.wikimedia.org/T111297#1600758 (10Billinghurst) It isn't updated that regularly, so it can be manual, just looking for direction on what is best. [02:57:34] 10MediaWiki-Authentication-and-authorization: Handle multiple session "traits" in AuthManager - https://phabricator.wikimedia.org/T111305#1600761 (10Tgr) 3NEW [02:57:51] 3Discovery-Cirrus-Sprint: insource cannot find repeating words - https://phabricator.wikimedia.org/T111293#1600769 (10Krinkle) I'm not sure if this is useful, but it seems `insource:/""/` does correctly return results where two `` tags were used next to each other. [[https://en.wikipedia.org/w/in... [02:59:23] ostriches: https://gerrit.wikimedia.org/r/#/c/235021/ [02:59:44] (03PS3) 10Krinkle: resourceloader: Don't create empty objects for every module [core] - 10https://gerrit.wikimedia.org/r/234696 (https://phabricator.wikimedia.org/T105162) [02:59:59] (03CR) 10Krinkle: "Rebase out of outdated parent commit." [core] - 10https://gerrit.wikimedia.org/r/234696 (https://phabricator.wikimedia.org/T105162) (owner: 10Krinkle) [03:02:42] 10Wikimedia-General-or-Unknown, 7Tracking: Steward, global sysop and SWMT tasks bugs (tracking) - https://phabricator.wikimedia.org/T43492#1600774 (10Billinghurst) [03:02:44] 10MediaWiki-extensions-UploadWizard, 6Multimedia, 5Patch-For-Review: Special:UploadWizard needs to notify globally blocked users at the beginning of the process, and provide a standard block message - https://phabricator.wikimedia.org/T111174#1600773 (10Billinghurst) [03:05:09] (03CR) 10Krinkle: [C: 04-1] "This regresses print styles by applying only in javascript runtime. The styles are moved out of an addModuleStyles-loaded module (which is" [core] - 10https://gerrit.wikimedia.org/r/197107 (owner: 10Gerrit Patch Uploader) [03:06:29] 10MediaWiki-extensions-UploadWizard, 6Multimedia, 5Patch-For-Review: Chunked/stashed uploads fail for some pdf and djvu files: "No specifications provided to ArchivedFile constructor." - https://phabricator.wikimedia.org/T94562#1600777 (10Tgr) Well, if you are using chunked upload, then //Request Entity Too... [03:07:22] (03CR) 10Krinkle: [C: 04-1] Fix late rendering of TOC toggles (031 comment) [core] - 10https://gerrit.wikimedia.org/r/196135 (owner: 10Ori.livneh) [03:07:53] 10MediaWiki-extensions-Scribunto, 10Wikimedia-Site-Requests, 7Community-consensus-needed: Change of namespaces on kannada wikisource - https://phabricator.wikimedia.org/T103650#1600781 (10Krenair) Not a duplicate [03:08:07] 10MediaWiki-extensions-Scribunto, 10Wikimedia-Site-Requests, 7Community-consensus-needed: Change of namespaces on kannada wikisource - https://phabricator.wikimedia.org/T103650#1600782 (10Krenair) 5duplicate>3Open [03:10:11] (03CR) 10Krinkle: "Status?" [core] - 10https://gerrit.wikimedia.org/r/220965 (owner: 10Ori.livneh) [03:11:03] 10Wikimedia-Interwiki-links, 10Wikimedia-Site-Requests: Update interwiki.cdb - https://phabricator.wikimedia.org/T111297#1600783 (10Krenair) Phabricator task in #wikimedia-site-requests and #wikimedia-interwiki-links is fine with me. I watch #wikimedia-site-requests so will usually see them reasonably quickly. [03:14:22] (03CR) 10Krinkle: "Shall we close this?" [core] - 10https://gerrit.wikimedia.org/r/198657 (owner: 10Ori.livneh) [03:15:10] 10MediaWiki-API, 10OOjs-UI, 7Wikimedia-log-errors: Fatal error: Call to undefined method OOUI\Element::serializeForApiResult() in /srv/mediawiki/php-1.26wmf21/vendor/oojs/oojs-ui/php/Element.php on line 117 - https://phabricator.wikimedia.org/T111304#1600785 (10Krenair) There was some discussion about this i... [03:19:13] 4(no projects): Assign event scout for November IETF meeting in preparation for WDS 2016 - https://phabricator.wikimedia.org/T111306#1600787 (10RobLa-WMF) 3NEW a:3Qgil [03:22:01] 10MediaWiki-API, 10MediaWiki-Search, 6Discovery, 10VisualEditor, and 4 others: Prefix search API doesn't return "index" field when "redirects" is enabled. - https://phabricator.wikimedia.org/T92796#1600796 (10Deskana) >>! In T92796#1599220, @ksmith wrote: > I spoke with @anomie, and while he would prefer a... [03:22:25] 10Wikimedia-Developer-Summit-2016: Assign event scout for November IETF meeting in preparation for WDS 2016 - https://phabricator.wikimedia.org/T111306#1600800 (10RobLa) [03:22:27] (03CR) 10Krinkle: "So perhaps we can put APC and MapCacheLRU in front of Revision::loadText? (or wherever the most appropiate place is); as additional layer " [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/226260 (owner: 10Ori.livneh) [03:26:41] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Documentation: do not have a copy of Wikibase.git/docs editable elsewhere - https://phabricator.wikimedia.org/T97139#1600812 (10Ricordisamoa) [03:29:11] 10Wikimedia-Developer-Summit-2016: Assign event scout for November IETF meeting in preparation for WDS 2016 - https://phabricator.wikimedia.org/T111306#1600814 (10RobLa-WMF) [03:32:24] ori: https://gerrit.wikimedia.org/r/#/c/235667/ [03:36:19] (03CR) 10EBernhardson: [C: 032] "Works as intended, seeing the same results for a few different queries for the original groovy and for this (pretty much as expected)." [search/extra] - 10https://gerrit.wikimedia.org/r/234985 (https://phabricator.wikimedia.org/T110883) (owner: 10DCausse) [03:38:59] (03Merged) 10jenkins-bot: LevenshteinDistanceScore score function [search/extra] - 10https://gerrit.wikimedia.org/r/234985 (https://phabricator.wikimedia.org/T110883) (owner: 10DCausse) [04:08:44] (03CR) 10Chad: [C: 032] Support empty string for wgEmergencyContact/wgPasswordSender [core] - 10https://gerrit.wikimedia.org/r/235021 (https://phabricator.wikimedia.org/T104142) (owner: 10Krinkle) [04:17:27] (03Merged) 10jenkins-bot: Support empty string for wgEmergencyContact/wgPasswordSender [core] - 10https://gerrit.wikimedia.org/r/235021 (https://phabricator.wikimedia.org/T104142) (owner: 10Krinkle) [04:19:24] 10MediaWiki-extensions-UploadWizard, 6Multimedia, 5Patch-For-Review: Chunked/stashed uploads fail for some pdf and djvu files: "No specifications provided to ArchivedFile constructor." - https://phabricator.wikimedia.org/T94562#1600837 (103BRBS) I runned the code in the snipet and got this: Code: > var a =... [04:20:11] is anyone able to advise me on what should be where for a personal Git access point? [04:23:06] I have Git installed on my server, and I have a HTTPS address to use, but I don't know where I should be saving my Gits so that I can create plugins without spamming the Gerrit workflow [04:25:33] ... am tinkering, so please PM if you can offer help or links to help [04:25:37] 10MediaWiki-Page-deletion, 10MediaWiki-Redirects, 6Wiktionary: AutoRedirect displays "This page has been deleted" before redirecting to the relevant page - https://phabricator.wikimedia.org/T111109#1600842 (10zhuyifei1999) Probably caused by (near) line 300 of [[https://en.wiktionary.org/wiki/MediaWiki:Gadge... [04:26:27] kstingel, make your git repositories accessible over ssh or https, pull/push to them over that? [04:27:27] (03CR) 10Aaron Schulz: [C: 032] IEUrlExtension: Add tests for the main use case the lib exists for [core] - 10https://gerrit.wikimedia.org/r/234506 (owner: 10Krinkle) [04:28:12] kstingel, if you just want to host git repositories somewhere remote, you don't need to have git installed on the host [04:29:50] Krenair:they are accessible by SSH .... I want to make them accessible via HTTPS, so I can push to https://git.kstingel.com and others can pull down even if I have PC off [04:31:27] kstingel, you should already be able to push via SSH then [04:31:29] Krenair: so if I just FTPup the local repo into subdomain root, that would work? [04:31:34] yeah [04:31:50] that won't enable other people to push to it though [04:32:22] unless they can also ssh to your host [04:33:59] Krenair: not a drama .... I only want to be able to setup pull access, so I can send a pull request to any Plugins I patch and use my host as src [04:36:09] (03Merged) 10jenkins-bot: IEUrlExtension: Add tests for the main use case the lib exists for [core] - 10https://gerrit.wikimedia.org/r/234506 (owner: 10Krinkle) [04:37:07] am trying to write a full install MW via Composer so I can reuse steps taken, if can make it work, will publish to GitHub for collaboration and advice [04:38:02] (03PS8) 10Smalyshev: [WIP] Allow search in different language [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/235141 [04:40:08] (03CR) 10Aaron Schulz: "Do we still need this or does Tim's batch parse API avoid the re-fetches from parsoid API parse queries?" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/226260 (owner: 10Ori.livneh) [04:40:41] 6Access Policy: Translations for Meta-Wiki gateway to confidentiality agreement - https://phabricator.wikimedia.org/T111307#1600870 (10Varnent) 3NEW a:3Varnent [04:40:45] 4(no projects): Truly rename MediaWiki Developer Summit to Wikimedia Developer Summit - https://phabricator.wikimedia.org/T111308#1600878 (10RobLa-WMF) 3NEW [04:41:16] 10Wikimedia-General-or-Unknown, 7Tracking: Steward, global sysop and SWMT tasks bugs (tracking) - https://phabricator.wikimedia.org/T43492#1600890 (10Glaisher) [04:41:18] 10MediaWiki-extensions-UploadWizard, 6Multimedia, 5Patch-For-Review: Special:UploadWizard needs to notify globally blocked users at the beginning of the process, and provide a standard block message - https://phabricator.wikimedia.org/T111174#1600889 (10Glaisher) [04:41:20] (03PS1) 10Tim Starling: Use /document as the path instead of /depurate [services/html5depurate] - 10https://gerrit.wikimedia.org/r/235669 [04:41:39] 10Wikimedia-Developer-Summit-2016: Truly rename MediaWiki Developer Summit to Wikimedia Developer Summit - https://phabricator.wikimedia.org/T111308#1600892 (10Krenair) [04:42:26] 10Wikimedia-Developer-Summit-2016: Truly rename MediaWiki Developer Summit to Wikimedia Developer Summit - https://phabricator.wikimedia.org/T111308#1600878 (10Krenair) [04:42:36] 6Access Policy: Contract translate volunteers about translation on Meta-Wiki for confidentiality agreement related pages - https://phabricator.wikimedia.org/T111309#1600896 (10Varnent) 3NEW a:3Varnent [04:42:57] 6Access Policy: Contact translate volunteers about translation on Meta-Wiki for confidentiality agreement related pages - https://phabricator.wikimedia.org/T111309#1600905 (10Varnent) [04:43:40] (03CR) 10Aaron Schulz: [C: 032] Decline to cache preprocessor items larger than 1 Mb [core] - 10https://gerrit.wikimedia.org/r/235650 (https://phabricator.wikimedia.org/T111289) (owner: 10Ori.livneh) [04:43:55] 10Wikimedia-Developer-Summit-2016: Truly rename MediaWiki Developer Summit to Wikimedia Developer Summit - https://phabricator.wikimedia.org/T111308#1600908 (10Krenair) Looks like this was originally proposed in T104346. [04:44:05] 10MediaWiki-extensions-UploadWizard, 6Multimedia, 5Patch-For-Review: Special:UploadWizard needs to notify globally blocked users at the beginning of the process, and provide a standard block message - https://phabricator.wikimedia.org/T111174#1600910 (10Billinghurst) I added the blocking task purposefully fo... [04:44:41] 10MediaWiki-extensions-UploadWizard, 6Multimedia, 5Patch-For-Review: Special:UploadWizard needs to notify globally blocked users at the beginning of the process, and provide a standard block message - https://phabricator.wikimedia.org/T111174#1600915 (10Billinghurst) [04:44:44] 10Wikimedia-General-or-Unknown, 7Tracking: Steward, global sysop and SWMT tasks bugs (tracking) - https://phabricator.wikimedia.org/T43492#1600916 (10Billinghurst) [04:46:04] 6Access Policy: Write and post on Meta-Wiki message/email to volunteers needing to sign confidentiality agreement - https://phabricator.wikimedia.org/T111273#1600918 (10Varnent) [04:46:06] 6Access Policy: Translate Meta-Wiki message/email to volunteers needing to sign confidentiality agreement - https://phabricator.wikimedia.org/T111275#1600917 (10Varnent) [04:47:21] 10MediaWiki-extensions-UploadWizard, 6Multimedia, 5Patch-For-Review: Special:UploadWizard needs to notify globally blocked users at the beginning of the process, and provide a standard block message - https://phabricator.wikimedia.org/T111174#1600920 (10Glaisher) > Billinghurst added a blocking task: T43492:... [04:48:14] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "features/bad_syntax_api.feature:9:46:47:48:49:50:51:52:53:54:55:56:57:65:66:67:68:69:70:71:72:103:104 features/combined_filters_api.featur" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/235141 (owner: 10Smalyshev) [04:50:14] 10MediaWiki-extensions-UploadWizard, 6Multimedia, 5Patch-For-Review: Special:UploadWizard needs to notify globally blocked users at the beginning of the process, and provide a standard block message - https://phabricator.wikimedia.org/T111174#1600927 (10Glaisher) [04:50:33] 10MediaWiki-extensions-UploadWizard, 6Multimedia, 5Patch-For-Review: Special:UploadWizard needs to notify globally blocked users at the beginning of the process, and provide a standard block message - https://phabricator.wikimedia.org/T111174#1596668 (10Glaisher) [04:50:41] 10Wikimedia-General-or-Unknown, 7Tracking: Steward, global sysop and SWMT tasks bugs (tracking) - https://phabricator.wikimedia.org/T43492#846974 (10Glaisher) [04:52:04] (03Merged) 10jenkins-bot: Decline to cache preprocessor items larger than 1 Mb [core] - 10https://gerrit.wikimedia.org/r/235650 (https://phabricator.wikimedia.org/T111289) (owner: 10Ori.livneh) [04:52:05] 10MediaWiki-extensions-UploadWizard, 6Multimedia, 5Patch-For-Review: Special:UploadWizard needs to notify globally blocked users at the beginning of the process, and provide a standard block message - https://phabricator.wikimedia.org/T111174#1596668 (10Glaisher) It finally worked. I don't know why that was... [04:52:54] (03PS1) 10Tim Starling: Add Html5Depurate tidy driver [core] - 10https://gerrit.wikimedia.org/r/235670 [04:53:20] 6Access Policy: Build gateway on Meta-Wiki to signing confidentiality agreement on Phabricator - https://phabricator.wikimedia.org/T111272#1600935 (10Varnent) [04:53:22] 6Access Policy: Translations for Meta-Wiki gateway to confidentiality agreement - https://phabricator.wikimedia.org/T111307#1600934 (10Varnent) [04:55:33] (03PS9) 10Smalyshev: [WIP] Allow search in different language [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/235141 [04:55:48] 6Access Policy: Write and post on Meta-Wiki message/email to volunteers needing to sign confidentiality agreement - https://phabricator.wikimedia.org/T111273#1600942 (10Varnent) [04:55:49] 6Access Policy: Contact translate volunteers about translation on Meta-Wiki for confidentiality agreement related pages - https://phabricator.wikimedia.org/T111309#1600941 (10Varnent) [04:55:51] 6Access Policy: Build gateway on Meta-Wiki to signing confidentiality agreement on Phabricator - https://phabricator.wikimedia.org/T111272#1600943 (10Varnent) [04:55:56] 10Wikimedia-Developer-Summit-2016: Assign event scout for November IETF meeting in preparation for WDS 2016 - https://phabricator.wikimedia.org/T111306#1600787 (10RobLa-WMF) [04:56:48] 6Access Policy: Contact translate volunteers about translation on Meta-Wiki for confidentiality agreement related pages - https://phabricator.wikimedia.org/T111309#1600896 (10Varnent) [04:56:50] 6Access Policy: Build gateway on Meta-Wiki to signing confidentiality agreement on Phabricator - https://phabricator.wikimedia.org/T111272#1599979 (10Varnent) [04:56:52] 6Access Policy: Translations for Meta-Wiki gateway to confidentiality agreement - https://phabricator.wikimedia.org/T111307#1600948 (10Varnent) [04:56:54] 6Access Policy: Write and post on Meta-Wiki message/email to volunteers needing to sign confidentiality agreement - https://phabricator.wikimedia.org/T111273#1599988 (10Varnent) [04:56:56] 6Access Policy: Translate Meta-Wiki message/email to volunteers needing to sign confidentiality agreement - https://phabricator.wikimedia.org/T111275#1600949 (10Varnent) [04:56:58] 6Access Policy: Send out initial email notification to volunteers regarding need to sign confidentiality agreement - https://phabricator.wikimedia.org/T111276#1600946 (10Varnent) [04:57:59] 6Access Policy: Send out initial email notification to volunteers regarding need to sign confidentiality agreement - https://phabricator.wikimedia.org/T111276#1600036 (10Varnent) [04:58:00] 6Access Policy: October follow-up email to volunteers needing to sign confidentiality agreement - https://phabricator.wikimedia.org/T111277#1600953 (10Varnent) [04:58:13] 6Access Policy: October follow-up email to volunteers needing to sign confidentiality agreement - https://phabricator.wikimedia.org/T111277#1600047 (10Varnent) [04:58:16] 10MediaWiki-Parser, 10Parsoid: Allow | in wikitext tables attributes - https://phabricator.wikimedia.org/T110268#1600958 (10Arlolra) Similarly T97157 for `>` in html element attributes. [04:58:18] 10Wikimedia-Developer-Summit-2016: Assign event scout for November IETF meeting in preparation for WDS 2016 - https://phabricator.wikimedia.org/T111306#1600787 (10RobLa-WMF) [04:58:37] 6Access Policy: Weekly follow-up emails to volunteers needing to sign confidentiality agreement - https://phabricator.wikimedia.org/T111279#1600962 (10Varnent) [04:58:38] 6Access Policy: November follow-up email to volunteers needing to sign confidentiality agreement - https://phabricator.wikimedia.org/T111278#1600057 (10Varnent) [04:58:52] 6Access Policy: Weekly follow-up emails to volunteers needing to sign confidentiality agreement - https://phabricator.wikimedia.org/T111279#1600065 (10Varnent) [04:58:53] 6Access Policy: Daily follow-up emails to volunteers needing to sign confidentiality agreement - https://phabricator.wikimedia.org/T111280#1600964 (10Varnent) [04:59:40] 6Access Policy: Confidentiality agreement in Portuguese, Spanish, Japanese, German, French and Chinese - https://phabricator.wikimedia.org/T111268#1600968 (10Varnent) [04:59:42] 6Access Policy, 10Legalpad: Set up translated confidentiality agreements on Phabricator - https://phabricator.wikimedia.org/T111271#1600967 (10Varnent) [04:59:44] 6Access Policy: Send out initial email notification to volunteers regarding need to sign confidentiality agreement - https://phabricator.wikimedia.org/T111276#1600966 (10Varnent) [05:00:31] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer, 7Performance: [Task] Remove "wb-entity-spinner" - https://phabricator.wikimedia.org/T108365#1600972 (10Ricordisamoa) [05:00:59] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Technical-Debt: Problematic inline script - https://phabricator.wikimedia.org/T95329#1600975 (10Ricordisamoa) [05:01:01] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer, 7Performance: [Task] Remove "wb-entity-spinner" - https://phabricator.wikimedia.org/T108365#1519251 (10Ricordisamoa) [05:04:03] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Technical-Debt: Problematic inline script - https://phabricator.wikimedia.org/T95329#1600978 (10Ricordisamoa) By the way, it hasn't been loaded inline since https://gerrit.wikimedia.org/r/229680. [05:05:52] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "features/frozen_index_api.feature:3:14:27" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/235141 (owner: 10Smalyshev) [05:12:28] (03PS1) 10Ottomata: [WIP] eventlogging processor as a service via HTTP [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/235671 [05:13:06] (03PS1) 10Aaron Schulz: Avoid PHP warning if key is not set in getValidationHash() [core] - 10https://gerrit.wikimedia.org/r/235672 [05:13:54] 10MediaWiki-extensions-SubPageList: Convert SubPageList3 extension to use extension registration - https://phabricator.wikimedia.org/T88062#1600987 (10Liuxinyu970226) [05:14:14] 10MediaWiki-extensions-FundraiserLandingPage: Convert FundraiserLandingPage to use extension registration - https://phabricator.wikimedia.org/T87917#1600988 (10Liuxinyu970226) [05:14:23] 10MediaWiki-extensions-PagedTiffHandler, 6Multimedia: Convert PagedTiffHandler to use extension registration - https://phabricator.wikimedia.org/T87952#1600995 (10Liuxinyu970226) [05:15:04] 10MediaWiki-extensions-SubpageSortkey: Convert SubpageSortkey to use extension registration - https://phabricator.wikimedia.org/T87975#1601000 (10Liuxinyu970226) [05:16:35] (03CR) 10jenkins-bot: [V: 04-1] Avoid PHP warning if key is not set in getValidationHash() [core] - 10https://gerrit.wikimedia.org/r/235672 (owner: 10Aaron Schulz) [05:16:58] 10MediaWiki-Extension-Requests, 10MediaWiki-extensions-SmiteSpam, 6Editing-Department, 3Google-Summer-of-Code-2015, 5Patch-For-Review: Extension to identify and delete spam pages - https://phabricator.wikimedia.org/T90238#1601006 (10NiharikaKohli) @polybuildr, sounds good. [05:17:02] (03Abandoned) 10Aaron Schulz: Set watchlisttoken preference on account creation [core] - 10https://gerrit.wikimedia.org/r/235174 (https://phabricator.wikimedia.org/T92357) (owner: 10Aaron Schulz) [05:18:29] 4(no projects): MediaWiki:Pgftikz-error-uploadlocal error verify should be more elaborate. - https://phabricator.wikimedia.org/T111103#1601008 (10Liuxinyu970226) [05:19:07] (03CR) 10Pastakhov: [C: 032] Use UID generator from core, whitespace fixes [extensions/MyVariables] - 10https://gerrit.wikimedia.org/r/225345 (owner: 10tosfos) [05:19:14] (03CR) 10Legoktm: "recheck" [core] - 10https://gerrit.wikimedia.org/r/235640 (owner: 10Jberkel) [05:19:23] (03Merged) 10jenkins-bot: Use UID generator from core, whitespace fixes [extensions/MyVariables] - 10https://gerrit.wikimedia.org/r/225345 (owner: 10tosfos) [05:19:34] 10MediaWiki-Interface, 7I18n, 7Tracking: Interface messages needing rewording or documentation and other issues with existing messages (tracking) - https://phabricator.wikimedia.org/T40638#1601009 (10Liuxinyu970226) [05:20:33] 10MediaWiki-General-or-Unknown, 5MW-1.26-release, 5Patch-For-Review, 5WMF-deploy-2015-08-25_(1.26wmf20), and 2 others: xml_parser_free: Parser cannot be freed while it is parsing - https://phabricator.wikimedia.org/T89532#1601015 (10bd808) 5Open>3Resolved Team effort for the win. [05:21:20] 10MediaWiki-extensions-LinkFilter, 10Social-Tools, 7I18n: Untranslatable timestamps in linkfilter-ago - https://phabricator.wikimedia.org/T69964#1601020 (10Liuxinyu970226) [05:22:21] Niharika: Thanks for https://github.com/mzmcbride/database-reports/pull/16 :-) [05:22:25] 10MediaWiki-API, 10OOjs-UI, 7Wikimedia-log-errors: Fatal error: Call to undefined method OOUI\Element::serializeForApiResult() in /srv/mediawiki/php-1.26wmf21/vendor/oojs/oojs-ui/php/Element.php on line 117 - https://phabricator.wikimedia.org/T111304#1601024 (10Legoktm) The traceback pointed to `OOUI\\IconWi... [05:22:49] Katie: You're welcome. :) [05:22:49] Niharika: Hopefully you figured out everything under the dbreps account? If not, feel free to ping me or Lego and one of us can probably help out. [05:23:01] Katie: More or less, yes. [05:23:16] (Though it got a bit complicated/convoluted for me and I just run a few reports under another account now.) [05:23:24] Have been bothering lego all day yesterday. :P [05:23:28] Nice. [05:23:49] Katie: Ah! That's why a few files are missing? Forgotten Articles, for one. [05:24:02] Some other people contributed reports. [05:24:13] Hopefully the source code is on-wiki or elsewhere on GitHub. [05:24:41] Okay. [05:24:47] Most reports (like over 100) are in mzmcbride/database-reports [05:24:54] A few weird ones aren't. [05:24:56] Right. [05:25:11] There's an overall config page too. [05:25:19] On wiki? [05:25:20] https://en.wikipedia.org/wiki/Wikipedia:Database_reports/Configuration [05:25:25] 10MediaWiki-Parser, 5MW-1.26-release, 5Patch-For-Review, 5WMF-deploy-2015-08-25_(1.26wmf20), and 3 others: Frequent memcached error for *:preprocess-hash:*:* keys - https://phabricator.wikimedia.org/T111289#1601029 (10demon) p:5Triage>3Normal [05:25:25] o/ [05:25:31] 10MediaWiki-extensions-Translate, 7Wikimedia-log-errors: Warning: OutputPage::getModuleStyles: style module should define its position explicitly: ext.translate.special.translate.styles - https://phabricator.wikimedia.org/T111262#1601031 (10demon) p:5Triage>3Normal [05:25:49] synctab was some silly alias I had. [05:26:38] Katie: Ah. If I want to add a cronjob, should I be editing crontab.tools file? [05:26:49] https://en.wikipedia.org/wiki/Wikipedia:Database_reports/Files_with_conflicting_categorization/Configuration seems like another easy one to fix up. [05:27:03] Niharika: I'm not sure totally sure which exact file is being used, but in general, yeah. [05:27:16] We do "crontab /path/to/file/name" to sync it. [05:27:22] So that it's more easily backed up and recovered. [05:27:25] And maybe versioned. [05:27:35] crontab -e and crontab -r are too easy to mix up. [05:27:54] Right. Okay. What do the -e and -r do? [05:28:03] -e for edit, -r for remove (without warning). [05:28:14] The keys are next to each other. It's great. [05:28:18] Ouch. [05:28:26] :P /me makes a mental note [05:28:32] Instead of using edit mode, you can just provide a file path. [05:28:37] And that file gets synced as your crontab. [05:29:00] Okay. Got it. [05:29:07] There's some jsub layer now as well. [05:29:13] That's Labs-specific. [05:30:03] (03PS3) 10Glaisher: Only pass strings to User::newFromName on Special:UserMerge [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/235446 (https://phabricator.wikimedia.org/T101681) [05:30:25] Katie: Yeah. I began looking into what all those flags meant but ended up copying the existing syntax and changing file names. [05:30:45] (03CR) 10Legoktm: [C: 032] "Let's try again..." [core] - 10https://gerrit.wikimedia.org/r/235640 (owner: 10Jberkel) [05:30:56] Katie: When one edits the Configuration pages on wiki - does that update the files on labs as well? [05:31:28] (03PS4) 10Glaisher: Only pass strings to User::newFromName on Special:UserMerge [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/235446 (https://phabricator.wikimedia.org/T101681) [05:31:49] Niharika: Nope. They're just backup copies, really. [05:32:00] The on-wiki pages are just to make sure the code is always available somewhere. [05:32:13] They probably pre-date the use of GitHub. [05:32:41] Wikimedia wikis get dumped and backed up a bit more than most places. :-) [05:32:46] Ah. Okay. [05:32:47] So putting content there is fairly safe. [05:32:59] As opposed to like SourceForge or whatever. [05:33:03] Google Code. [05:33:08] Yeah. [05:39:19] (03Merged) 10jenkins-bot: tests: Remove "install" target from makefile documentation [core] - 10https://gerrit.wikimedia.org/r/235640 (owner: 10Jberkel) [05:46:08] (03CR) 10Chad: [C: 032] Avoid passing anything but a string to Title::newFromText in UploadBase::getTitle [core] - 10https://gerrit.wikimedia.org/r/233209 (https://phabricator.wikimedia.org/T109974) (owner: 10Alex Monk) [05:46:42] 10Architecture, 7Documentation: Replace docs/design.txt with a reasonably complete summary of mw:Architectural_guidelines - https://phabricator.wikimedia.org/T111283#1601058 (10MZMcBride) Just make `design.txt` a pointer to the wiki page? [05:48:15] 10Architecture, 7Documentation: Replace docs/design.txt with a reasonably complete summary of mw:Architectural_guidelines - https://phabricator.wikimedia.org/T111283#1601060 (10demon) [05:50:41] 10MediaWiki-Documentation, 7Documentation: make doc files in git more useful - https://phabricator.wikimedia.org/T111298#1601068 (10MZMcBride) As I said on T111283, if we keep these files around in Git, I think we should consider just making them pointers to mediawiki.org. If nothing else, MediaWiki is actuall... [05:52:35] (03CR) 10Aaron Schulz: "recheck" [core] - 10https://gerrit.wikimedia.org/r/235672 (owner: 10Aaron Schulz) [05:54:06] 7HHVM: Segfault in strtr() - https://phabricator.wikimedia.org/T109540#1601070 (10EBernhardson) Looks like tim was on the right track for the crasher. This script consistently segfaults hhvm on the 11th request after a restart: ``` (03Merged) 10jenkins-bot: Avoid passing anything but a string to Title::newFromText in UploadBase::getTitle [core] - 10https://gerrit.wikimedia.org/r/233209 (https://phabricator.wikimedia.org/T109974) (owner: 10Alex Monk) [05:57:20] (03PS1) 10Chad: PrefixSearch: Avoid passing non-strings to Title::newFromText() [core] - 10https://gerrit.wikimedia.org/r/235675 (https://phabricator.wikimedia.org/T109975) [06:02:47] (03CR) 10Legoktm: "minor" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235659 (https://phabricator.wikimedia.org/T111285) (owner: 10Mooeypoo) [06:08:07] (03PS2) 10BearND: Safer RbService error handling [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/235658 [06:13:29] (03PS1) 10Legoktm: Add RELEASE-NOTES entries for PHP library upgrades and additions [core] - 10https://gerrit.wikimedia.org/r/235676 [06:13:54] 10MobileFrontend, 7Easy, 7I18n: GENDER support for mobile-frontend-logged-in-homepage-notification - https://phabricator.wikimedia.org/T110950#1601092 (10Nemo_bis) p:5Low>3Normal Respect of GENDER is policy and the maintainer's responsibility. [06:14:01] (03PS2) 10Legoktm: Add RELEASE-NOTES entries for PHP library upgrades and additions [core] - 10https://gerrit.wikimedia.org/r/235676 [06:14:12] 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release6: CX creates span tags with cx-highlight class - https://phabricator.wikimedia.org/T111000#1601094 (10Magioladitis) Again https://en.wikipedia.org/w/index.php?title=Instituto_Superior_de_Ci%C3%AAncias_Sociais_e_Pol%C3%ADticas&action=edit&o... [06:14:25] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235659 (https://phabricator.wikimedia.org/T111285) (owner: 10Mooeypoo) [06:15:00] 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7: CX creates templates leaving the prefix - https://phabricator.wikimedia.org/T111003#1601095 (10Magioladitis) Again https://en.wikipedia.org/w/index.php?title=Shyla_Stylez&action=edit&oldid=679181533 [06:15:57] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/234705 (https://phabricator.wikimedia.org/T100366) (owner: 10Jdlrobson) [06:17:04] 10MediaWiki-extensions-ContentTranslation: CX creates empty references tags - https://phabricator.wikimedia.org/T111311#1601096 (10Magioladitis) 3NEW [06:17:13] (03PS1) 10Legoktm: MessageCache: Don't try to log a ContentHandler object [core] - 10https://gerrit.wikimedia.org/r/235677 [06:17:20] (03CR) 10jenkins-bot: [V: 04-1] Add RELEASE-NOTES entries for PHP library upgrades and additions [core] - 10https://gerrit.wikimedia.org/r/235676 (owner: 10Legoktm) [06:18:55] (03CR) 10Legoktm: "recheck" [core] - 10https://gerrit.wikimedia.org/r/235676 (owner: 10Legoktm) [06:19:00] (03CR) 10Aaron Schulz: [C: 032] MessageCache: Don't try to log a ContentHandler object [core] - 10https://gerrit.wikimedia.org/r/235677 (owner: 10Legoktm) [06:21:41] (03PS1) 10BearND: Add extra properties to lead request [services/mobileapps] - 10https://gerrit.wikimedia.org/r/235678 [06:22:31] (03PS2) 10Legoktm: Default the "watchlisttoken" value to a derived HMAC value [core] - 10https://gerrit.wikimedia.org/r/235647 (https://phabricator.wikimedia.org/T92357) (owner: 10Aaron Schulz) [06:24:23] (03CR) 10Tim Starling: [C: 032 V: 032] Use /document as the path instead of /depurate [services/html5depurate] - 10https://gerrit.wikimedia.org/r/235669 (owner: 10Tim Starling) [06:25:18]