[00:04:49] (03CR) 10BryanDavis: "One trivial comment inline" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/215032 (owner: 10Krinkle) [00:10:39] (03CR) 10Jdlrobson: [V: 031] Hygiene: Make PageList take an array of pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203266 (https://phabricator.wikimedia.org/T97592) (owner: 10Jdlrobson) [00:12:51] (03CR) 10Jdlrobson: [C: 031] Hygiene: Make PageList take an array of pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203266 (https://phabricator.wikimedia.org/T97592) (owner: 10Jdlrobson) [00:13:00] (03CR) 10Jdlrobson: "yo" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203266 (https://phabricator.wikimedia.org/T97592) (owner: 10Jdlrobson) [00:13:02] (03PS5) 10Krinkle: HttpStatus: Implement header() method [core] - 10https://gerrit.wikimedia.org/r/215032 [00:13:16] (03CR) 10Krinkle: HttpStatus: Implement header() method (031 comment) [core] - 10https://gerrit.wikimedia.org/r/215032 (owner: 10Krinkle) [00:13:46] (03CR) 10Jdlrobson: "yo 234" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203266 (https://phabricator.wikimedia.org/T97592) (owner: 10Jdlrobson) [00:18:48] (03Abandoned) 10Jforrester: Add extension.json, empty PHP entry point [extensions/Graph] (REL1_25) - 10https://gerrit.wikimedia.org/r/210048 (owner: 10Paladox) [00:19:58] (03CR) 10Jdlrobson: ""testing from the command line"" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203266 (https://phabricator.wikimedia.org/T97592) (owner: 10Jdlrobson) [00:20:11] (03CR) 10Jdlrobson: [C: 04-1] ""testing from the command line"" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203266 (https://phabricator.wikimedia.org/T97592) (owner: 10Jdlrobson) [00:20:27] (03CR) 10Jdlrobson: "testing from the command line" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203266 (https://phabricator.wikimedia.org/T97592) (owner: 10Jdlrobson) [00:20:32] (03CR) 10Jdlrobson: [C: 031] "testing from the command line" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203266 (https://phabricator.wikimedia.org/T97592) (owner: 10Jdlrobson) [00:24:38] (03CR) 10Jdlrobson: "testing from the command line" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203266 (https://phabricator.wikimedia.org/T97592) (owner: 10Jdlrobson) [00:24:48] (03CR) 10Jdlrobson: "testing from the command line" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203266 (https://phabricator.wikimedia.org/T97592) (owner: 10Jdlrobson) [00:25:03] (03CR) 10Jdlrobson: "testing from the command line" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203266 (https://phabricator.wikimedia.org/T97592) (owner: 10Jdlrobson) [00:26:42] (03CR) 10Jdlrobson: "testing from the command line" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203266 (https://phabricator.wikimedia.org/T97592) (owner: 10Jdlrobson) [00:27:50] (03CR) 10Jdlrobson: "testing from the command line" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203266 (https://phabricator.wikimedia.org/T97592) (owner: 10Jdlrobson) [00:28:59] (03CR) 10Jdlrobson: "foo" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203266 (https://phabricator.wikimedia.org/T97592) (owner: 10Jdlrobson) [00:29:07] (03CR) 10Jdlrobson: "foo bar YESS" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203266 (https://phabricator.wikimedia.org/T97592) (owner: 10Jdlrobson) [00:29:22] (03CR) 10Jdlrobson: Hygiene: Make PageList take an array of pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203266 (https://phabricator.wikimedia.org/T97592) (owner: 10Jdlrobson) [00:44:57] ori, what do you think about turning off the RL localStorage caching until you/someone has time to write the IndexedDB replacement (or we come up with something better)? [00:48:23] matt_flaschen: the users who are affected by the cache filling up are: logged in users who visit multiple wikimedia projects and don't often log out and that use a particular range of firefox versions [00:48:53] ori, oh, did they expand the limit in later Firefox? [00:48:54] why do you ask? [00:48:59] And what happens if you log out? [00:49:33] ori, no big development, just that the issue is still present. [00:49:34] it gets reset [00:50:02] when it does get full (which is the issue) it falls back to fetching from the server, like it would without localstorage caching. [00:50:30] Krinkle, that's not the issue. The issue is that it blocks every other piece of code from using localStorage reliably. [00:51:09] It's not ideal to have console errors either, but that's not the main thing. [00:51:29] it looks like it hasn't been fixed in newer versions of firefox; i was wrong about that [00:51:32] Yeah I've spent the past year or so shooting down every suggestion to use localStorage with "but it's full on Firefox" [00:51:52] we could disable it for logged-in users on FF [00:52:12] I dont think it's limited to Firefox though [00:52:18] Or logged-in users? [00:52:39] what is limited to firefox is the fact that the allocation is shared by all subdomains [00:52:42] rather than origin [00:52:50] Right [00:53:05] so fr.wikipedia.org and en.wikipedia.org count toward the same quota, but javascript code on either site can't clear the other's [00:53:49] it's not limited to logged-in users, but anons are less likely to be visiting multiple projects ({{citation needed}}, but that's my hunch) [00:54:43] ori, blacklisting Firefox would be an improvement. Obviously, browser sniffing is not ideal, but it's hard to feature sniff this, and if it's really just Firefox, fair enough. [00:54:48] How credible is the suggestion that we should use IndexedDB instead of localStorage? [00:55:00] I mean in general terms (browser support etc) but also in terms of does it have the same Firefox bug [00:55:47] the problem with indexedb is that it does not have a synchronous API [00:56:01] and resourceloader needs the load to be syncronous [00:56:08] Oh, meh [00:56:20] but we could resort to polling [00:56:25] I guess for the top queue you do [00:56:30] (need it to be sync) [00:57:10] Depending on implementation, though, busy looping will not work [00:57:23] Ah, IndexedDB is sync? [00:57:26] Arrr. didn't know that [00:57:29] No, async [00:57:33] With no way to be sync [00:57:36] yeah, async, that's what I meant [00:57:50] It makes sense, since things really ought to not be sync [00:57:56] But in this case we kind of want it [00:58:46] ... you know... we could split the store based on syncness [00:58:59] sync in ls and async in idb [00:59:26] we could also exclude VE [00:59:32] that would also suck [00:59:42] But IDB still has other problems though, like the fact that it requires a terabyte of code to bootstrap and communicate with [00:59:57] heheh [01:00:09] VE is gargantuan, if you don't cache VE the problem goes away effectively [01:00:22] (03CR) 10Jdlrobson: [C: 04-1] "$msg" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203266 (https://phabricator.wikimedia.org/T97592) (owner: 10Jdlrobson) [01:00:39] ori: We can also just put a cap on the store size [01:00:45] regardless of which module [01:00:56] ori: As a general policy, would "only cache it if it loads during startup" make sense? [01:01:08] The gargantuan part of VE is all in modules that are loaded on demand [01:01:21] Where the UI has already been designed around the possibility that fetching all that code can take a while [01:01:24] there is still plenty of benefit to having them cached [01:01:33] Yeah [01:01:40] It'll have 304 caching [01:01:41] I guess you do still make that faster [01:01:48] but less effective due to fragmentation [01:02:03] But yeah as Krinkle says, things that are loaded on-demand are more likely to experience 304 caching with little fragmentation [01:02:29] Oh right, because it's on-demand, it's not influenced by page variance in the queue [01:02:33] it has its own request [01:02:33] Well, or maybe not so little fragmentation, that depends on what the dependencies are in practice [01:02:36] I'm trying to construct a query to feed into QueryPage:getQueryInfo(). Is there anywhere that shows equivalent SQL queries and the array-formatted query getQueryInfo wants? [01:02:37] Yeah [01:02:39] predictiable composition [01:02:50] I mean as long as you don't depend on things that are sometimes loaded on the page but sometimes not [01:03:11] Making exceptions for that is gonna be ugly though [01:03:24] What we really need is better caching systems in the browser. [01:03:28] fhocutt: Are you writing a subclass of QueryPage and figuring out what your getQueryInfo() should return? [01:03:38] RoanKattouw, yes [01:03:38] Yeah, HTTP/2 et [01:03:39] c [01:03:54] The implications of HTTP/2 are basically "undo half of RL's client-side" [01:04:05] In the future, we can use HTTP/2 and split it all up in separate requests. And potentially use fetch() and web manifest to intercept requests and batch them that way. [01:04:05] RoanKattouw: I'm learning how extensions work [01:04:21] fhocutt: I swear I documented this somewhere in ~2011 [01:04:55] RoanKattouw: searching for "QueryPage" on mw didn't bring anything like that up [01:05:17] fhocutt: Aha, QueryPage.php has reasonable-ish docs where it defines getQueryInfo() [01:05:21] QueryPage.php line 144 [01:05:29] This should also be somewhere in the depths of docs.wm.o then [01:06:02] RoanKattouw, this? https://doc.wikimedia.org/mediawiki-core/master/php/classQueryPage.html#a83d3f453528ce1a1b775528272a94b66 [01:06:28] fhocutt: https://doc.wikimedia.org/mediawiki-core/master/php/classQueryPage.html#a83d3f453528ce1a1b775528272a94b66 [01:06:35] Yes that [01:07:39] RoanKattouw: I'm not familiar enough with SQL to be able to translate that to the actual query I need [01:07:45] OK [01:07:51] I can explain [01:08:12] RoanKattouw, that would be useful, thanks. [01:08:41] So the general form of an SQL query (without joins, for now) is SELECT field1, field2, ... FROM table1, table2, ... WHERE field3=value3 AND field4 IN (value4, value5) ORDER BY field5 DESC; [01:08:58] That's about as complex as you'll get without joins [01:09:05] ok. [01:09:06] Does that make sense so far? [01:09:14] yes. [01:10:04] So getQueryInfo() encodes that as array( 'tables' => array( 'table1', 'table2' ), 'fields' => array( 'field1', 'field2' ), 'conds' => array( 'field3' => 'value3', 'field4' => array( 'value4', 'value5' ) ), 'options' => array( 'ORDER BY' => 'DESC' ) ) [01:10:53] So tables and fields are just an array, which is turned into a comma-separated list in SQL (there is additional advanced syntax to do aliases here) [01:11:22] conds is fieldname => value or fieldname => array of values with automatic IN(...) for arrays and automatic escaping of values [01:11:23] hm, ok [01:11:49] so conds is your WHERE? [01:12:10] Yeah [01:12:18] ok, that makes more sense [01:12:22] I just found fuller documentation of this structure, it's at https://doc.wikimedia.org/mediawiki-core/master/php/classDatabaseBase.html#a76f9e6cb7b145a3d9020baebf94b499e [01:12:46] Which is trying to be linked from the QueryPage docs except someone renamed Database to DatabaseBase after I wrote those docs [01:13:08] right! Thanks. [01:14:16] So yeah, the main reasons for having this weird structure are 1) SQL isn't a real standard, different DBs represent things differently and this lets us abstract that, and 2) abstracting SQL escaping makes security of code more obvious [01:14:57] so we can change the DB we use without major code changes? [01:15:42] Yeah, or support different DBs based on what the site admin configured, and write each query only once [01:15:55] right [01:16:27] In the past MW theoretically supported PostgreSQL which has nontrivial syntactic incompatibilities with MySQL, and the code that turns these array structures into SQL could just magically paper over this problem [01:16:38] (I think postgres support was dropped at some point, but I forget) [01:17:26] (03PS1) 10Jdlrobson: QA: Fix selector for anoynmous editor warning box [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/215837 [01:17:30] (03CR) 10jenkins-bot: [V: 04-1] QA: Fix selector for anoynmous editor warning box [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/215837 (owner: 10Jdlrobson) [01:18:43] I think nowadays the only other officially supported DB backend is SQLite which actually works properly (as opposed to postgres which hardly ever did) and its syntactic differences with MySQL aren't that bad [01:19:01] (03PS2) 10Jdlrobson: QA: Fix selector for anoynmous editor warning box [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/215837 [01:19:05] (03CR) 10jenkins-bot: [V: 04-1] QA: Fix selector for anoynmous editor warning box [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/215837 (owner: 10Jdlrobson) [01:19:07] AIUI its syntax is mostly a subset of MySQL's and for almost all operations it's possible to write SQL that works in both [01:19:44] (03Abandoned) 10Jdlrobson: QA: Fix selector for anoynmous editor warning box [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/215837 (owner: 10Jdlrobson) [01:24:00] (03PS1) 10Catrope: Only change editor preference if user makes a change [extensions/Flow] - 10https://gerrit.wikimedia.org/r/215838 (https://phabricator.wikimedia.org/T94852) [01:34:29] (03CR) 10Krinkle: "This class should be used in some way somewhere in this repo so that it can be visually verified (even without infusion)." [core] - 10https://gerrit.wikimedia.org/r/213504 (owner: 10Catrope) [01:35:52] (03PS1) 10Jdlrobson: QA: Fix create collection selector [extensions/Gather] - 10https://gerrit.wikimedia.org/r/215841 [01:36:19] (03CR) 10Jdlrobson: [C: 032] QA: Fix create collection selector [extensions/Gather] - 10https://gerrit.wikimedia.org/r/215841 (owner: 10Jdlrobson) [01:36:36] (03CR) 10Jdlrobson: [C: 032] Track collection item counts [extensions/Gather] - 10https://gerrit.wikimedia.org/r/210884 (https://phabricator.wikimedia.org/T97061) (owner: 10Gergő Tisza) [01:36:41] (03CR) 10Jdlrobson: [C: 032] Add (gli_gl_id, gli_namespace, gli_title) index [extensions/Gather] - 10https://gerrit.wikimedia.org/r/209502 (https://phabricator.wikimedia.org/T98490) (owner: 10Gergő Tisza) [01:38:10] (03Merged) 10jenkins-bot: QA: Fix create collection selector [extensions/Gather] - 10https://gerrit.wikimedia.org/r/215841 (owner: 10Jdlrobson) [01:38:29] (03Merged) 10jenkins-bot: Track collection item counts [extensions/Gather] - 10https://gerrit.wikimedia.org/r/210884 (https://phabricator.wikimedia.org/T97061) (owner: 10Gergő Tisza) [01:38:31] (03CR) 10jenkins-bot: [V: 04-1] Add (gli_gl_id, gli_namespace, gli_title) index [extensions/Gather] - 10https://gerrit.wikimedia.org/r/209502 (https://phabricator.wikimedia.org/T98490) (owner: 10Gergő Tisza) [01:40:35] (03CR) 10Krinkle: Only change editor preference if user makes a change (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/215838 (https://phabricator.wikimedia.org/T94852) (owner: 10Catrope) [01:57:39] (03PS1) 10Krinkle: resourceloader: Optimise Title query in ResourceLoaderWikiModule::getTitleInfo [core] - 10https://gerrit.wikimedia.org/r/215857 [01:58:05] (03PS11) 10Gergő Tisza: [WIP] Implement flagging backend [extensions/Gather] - 10https://gerrit.wikimedia.org/r/212593 (https://phabricator.wikimedia.org/T97704) [02:00:57] (03PS6) 10Gergő Tisza: Add (gli_gl_id, gli_namespace, gli_title) index [extensions/Gather] - 10https://gerrit.wikimedia.org/r/209502 (https://phabricator.wikimedia.org/T98490) [02:04:18] (03CR) 10Gergő Tisza: [C: 032] "Self-merge per Jon's +2, rebase was trivial." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/209502 (https://phabricator.wikimedia.org/T98490) (owner: 10Gergő Tisza) [02:06:00] (03Merged) 10jenkins-bot: Add (gli_gl_id, gli_namespace, gli_title) index [extensions/Gather] - 10https://gerrit.wikimedia.org/r/209502 (https://phabricator.wikimedia.org/T98490) (owner: 10Gergő Tisza) [02:06:49] (03PS8) 10Gergő Tisza: Filter lists by item count [extensions/Gather] - 10https://gerrit.wikimedia.org/r/210885 (https://phabricator.wikimedia.org/T97061) [02:07:06] (03PS12) 10Gergő Tisza: [WIP] Implement flagging backend [extensions/Gather] - 10https://gerrit.wikimedia.org/r/212593 (https://phabricator.wikimedia.org/T97704) [02:08:15] (03PS1) 10Jdlrobson: QA: Adjustments to make tests pass [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/215859 [02:08:32] (03CR) 10Jdlrobson: [C: 032] QA: Adjustments to make tests pass [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/215859 (owner: 10Jdlrobson) [02:09:19] (03PS2) 10Krinkle: resourceloader: Optimise Title query in ResourceLoaderWikiModule::getTitleInfo [core] - 10https://gerrit.wikimedia.org/r/215857 [02:10:08] (03Merged) 10jenkins-bot: QA: Adjustments to make tests pass [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/215859 (owner: 10Jdlrobson) [02:13:18] (03CR) 10jenkins-bot: [V: 04-1] resourceloader: Optimise Title query in ResourceLoaderWikiModule::getTitleInfo [core] - 10https://gerrit.wikimedia.org/r/215857 (owner: 10Krinkle) [02:14:36] (03PS3) 10Krinkle: resourceloader: Optimise Title query in ResourceLoaderWikiModule::getTitleInfo [core] - 10https://gerrit.wikimedia.org/r/215857 [02:15:41] (03PS6) 10BryanDavis: HttpStatus: Implement header() method [core] - 10https://gerrit.wikimedia.org/r/215032 (owner: 10Krinkle) [02:15:48] (03CR) 10BryanDavis: [C: 032] HttpStatus: Implement header() method [core] - 10https://gerrit.wikimedia.org/r/215032 (owner: 10Krinkle) [02:19:23] (03CR) 10Jdlrobson: "Will we have to manually run updateCounts.php. on production / beta labs?" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/210885 (https://phabricator.wikimedia.org/T97061) (owner: 10Gergő Tisza) [02:24:05] (03Merged) 10jenkins-bot: HttpStatus: Implement header() method [core] - 10https://gerrit.wikimedia.org/r/215032 (owner: 10Krinkle) [02:24:36] bd808: thx [02:24:42] yw [02:26:06] (03CR) 10BryanDavis: [C: 031] WebResponse: Implement statusHeader() using the new HttpStatus::header() [core] - 10https://gerrit.wikimedia.org/r/215033 (owner: 10Krinkle) [02:26:24] (03CR) 10BryanDavis: [C: 031] Use HttpStatus::header instead of manually crafting header() [core] - 10https://gerrit.wikimedia.org/r/215034 (owner: 10Krinkle) [02:27:31] (03PS4) 10Krinkle: WebResponse: Implement statusHeader() using the new HttpStatus::header() [core] - 10https://gerrit.wikimedia.org/r/215033 [02:27:37] (03PS4) 10Krinkle: Use HttpStatus::header instead of manually crafting header() [core] - 10https://gerrit.wikimedia.org/r/215034 [02:27:42] rebases cleanly still, yay [02:47:06] (03PS5) 10Krinkle: resourceloader: Enable module content version for data modules [core] - 10https://gerrit.wikimedia.org/r/215364 [02:50:21] (03PS4) 10Krinkle: resourceloader: Replace ResourceLoaderWikiModule mtime queries with content hash [core] - 10https://gerrit.wikimedia.org/r/215857 [02:53:42] (03CR) 10jenkins-bot: [V: 04-1] resourceloader: Replace ResourceLoaderWikiModule mtime queries with content hash [core] - 10https://gerrit.wikimedia.org/r/215857 (owner: 10Krinkle) [02:53:52] (03CR) 10Jforrester: "Grandchild commit uses this as a key part of the interface." [core] - 10https://gerrit.wikimedia.org/r/213504 (owner: 10Catrope) [03:02:36] (03PS5) 10Krinkle: resourceloader: Replace ResourceLoaderWikiModule mtime queries with content hash [core] - 10https://gerrit.wikimedia.org/r/215857 [03:23:58] (03PS1) 10Krinkle: modules: Add position=top to style module [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/215862 [03:26:54] (03CR) 10Krinkle: [C: 032] Remove double line break from the end of a line [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/214048 (owner: 10Amire80) [03:27:06] (03Merged) 10jenkins-bot: Remove double line break from the end of a line [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/214048 (owner: 10Amire80) [03:34:19] (03PS2) 10BryanDavis: modules: Add position=top to style module [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/215862 (owner: 10Krinkle) [03:34:26] (03CR) 10BryanDavis: [C: 032] modules: Add position=top to style module [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/215862 (owner: 10Krinkle) [03:34:41] (03Merged) 10jenkins-bot: modules: Add position=top to style module [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/215862 (owner: 10Krinkle) [03:36:33] (03PS25) 10Mattflaschen: [wip] Create an OOUI ToC widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/209671 (owner: 10Mooeypoo) [03:38:24] (03CR) 10jenkins-bot: [V: 04-1] [wip] Create an OOUI ToC widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/209671 (owner: 10Mooeypoo) [03:41:54] (03CR) 10Mattflaschen: "Sorry, that kind of became a bigger update than planned. :) I was just going to fix the issue you were having with gaps not triggering th" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/209671 (owner: 10Mooeypoo) [03:54:44] (03PS1) 10Krinkle: resourceloader: Make ResourceLoader logger aware [core] - 10https://gerrit.wikimedia.org/r/215863 [03:54:46] (03PS1) 10Krinkle: resourceloader: Log "private module denied" as 'debug' instead of 'info' [core] - 10https://gerrit.wikimedia.org/r/215864 [04:00:31] (03CR) 10Hammertkh: [C: 031] Chinese Conversion Table Update 2015-4 [core] - 10https://gerrit.wikimedia.org/r/215301 (owner: 10Chiefwei) [05:16:26] (03PS3) 10BryanDavis: Convert MWExceptionHandler to use structured logging [core] - 10https://gerrit.wikimedia.org/r/213348 (https://phabricator.wikimedia.org/T88649) [05:16:40] (03CR) 10jenkins-bot: [V: 04-1] Convert MWExceptionHandler to use structured logging [core] - 10https://gerrit.wikimedia.org/r/213348 (https://phabricator.wikimedia.org/T88649) (owner: 10BryanDavis) [05:21:41] (03PS4) 10BryanDavis: Convert MWExceptionHandler to use structured logging [core] - 10https://gerrit.wikimedia.org/r/213348 (https://phabricator.wikimedia.org/T88649) [05:22:07] (03CR) 10BryanDavis: Convert MWExceptionHandler to use structured logging (033 comments) [core] - 10https://gerrit.wikimedia.org/r/213348 (https://phabricator.wikimedia.org/T88649) (owner: 10BryanDavis) [05:28:59] (03PS5) 10BryanDavis: Convert MWExceptionHandler to use structured logging [core] - 10https://gerrit.wikimedia.org/r/213348 (https://phabricator.wikimedia.org/T88649) [05:45:44] (03CR) 10BryanDavis: resourceloader: Make ResourceLoader logger aware (038 comments) [core] - 10https://gerrit.wikimedia.org/r/215863 (owner: 10Krinkle) [06:01:29] (03PS13) 10Umherirrender: [schema] Make column user_properties.up_user an unsigned int [core] - 10https://gerrit.wikimedia.org/r/191124 [06:04:56] (03CR) 10Yaron Koren: "Are you planning to create another version of this patch? The i18n stuff could still use some work..." [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/214303 (owner: 10Polybuildr) [06:54:19] (03CR) 10Polybuildr: "Yes, several patch sets more by my estimate, before I merge this in. i18n, class structuring, reusing code from core, etc. are pending." [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/214303 (owner: 10Polybuildr) [07:51:55] (03PS4) 10Physikerwelt: Add mathtex as default to the LaTeXML options [extensions/Math] - 10https://gerrit.wikimedia.org/r/214328 [08:01:04] (03CR) 10Marcoil: T86782: Use CSS to style Parsoid's Cite HTML (033 comments) [extensions/Cite] - 10https://gerrit.wikimedia.org/r/207474 (owner: 10Marcoil) [08:01:33] (03PS6) 10Marcoil: T86782: Use CSS to style Parsoid's Cite HTML [extensions/Cite] - 10https://gerrit.wikimedia.org/r/207474 [08:06:48] (03PS26) 10Mooeypoo: [wip] Create an OOUI ToC widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/209671 [08:09:02] (03CR) 10Mooeypoo: "Oh noes! I didn't notice you pushed something, Matt!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/209671 (owner: 10Mooeypoo) [08:09:15] (03CR) 10jenkins-bot: [V: 04-1] [wip] Create an OOUI ToC widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/209671 (owner: 10Mooeypoo) [08:10:30] Crap. Anyone knows how to revert a patchset? I accidentally pushed something, not noticing someone else pushed another. Is there a way to revert back one patchset in gerrit? [08:18:01] * mooeypoo shines the git light on the clouds [08:18:11] mooeypoo: go to that change, click the 'revert' button and +2 that new change [08:18:36] I don't want to +2 anything, just to revert my working copy [08:19:21] ok, terminology confusion. 'pushed' is typically used to move something to the public repository [08:19:34] in your case, you have just committed something locally? [08:19:53] because you're also speaking about gerrit [08:20:06] valhallasw, sorry, let me rephrase more clearly. I have a commit in Gerrit. I worked on a patchset and sent it to review, but that "ate up" a patchset someone else wrote, and that patchset is better. [08:20:25] I want to essentially get rid of the patchset I sent to gerrit, and have the one before mine as the working copy [08:20:28] if that makes sense [08:20:53] mooeypoo: right. In gerrit, click the 'abandon' button [08:20:57] https://gerrit.wikimedia.org/r/#/c/209671/ <-- patchset 25 should be the one we're working on, not ps26. PS26 was a mistake. Any way to get rid of it? [08:21:04] oh! [08:21:06] The abandon will abandon the entire commit chain [08:21:08] sorry, now I get it [08:21:20] git checkout 0cfbcf531f713ea3b6396c1b6494789f4d8277dd && git review [08:21:28] gotcha [08:21:30] * mooeypoo attempts [08:22:30] no "HEAD^" ? (I know nothing, John Snow... just used to seeing that next to patchset ids so verifying) [08:23:16] mooeypoo: HEAD^ is the 'parent commit', in this case 6466a03f78552f754992bc25e06046d6f337af13 Create a basic data model layer for Flow JS [08:23:28] hm "fatal: reference is not a tree: 0cfbcf531f713ea3b6396c1b6494789f4d8277dd" [08:24:18] I updated that commit ('git checkout master && git pull && git review -d 209671') so it *should* know that patchset now .. [08:24:37] no, because -d 209671 just downloads the last one, not ps25 [08:24:53] git fetch https://gerrit.wikimedia.org/r/mediawiki/extensions/Flow refs/changes/71/209671/25 && git checkout FETCH_HEAD [08:24:59] ^ that, then git review [08:25:16] (this is what you get if you expand PS25, under 'download', with 'checkout' selected) [08:25:28] ooh [08:25:44] "You are in 'detached HEAD' state..." [08:25:49] that's supposed ot happen ,I assume? [08:25:56] yeah [08:26:40] ooh and when I 'git show --stat' I see the "commit 0cfbcf531f713ea3b6396c1b6494789f4d8277dd" which is right [08:27:05] * mooeypoo crosses git fingers [08:27:29] eh [08:27:31] "! [remote rejected] HEAD -> refs/publish/master/(detached (no new changes)" [08:27:43] Do I need to commit this? it was clean. [08:28:00] uuuuuh [08:28:07] that's just gerrit being annoying, I think [08:28:20] try git commit --amend, and add a comma or period in the commit message [08:28:20] I can make a small change and then commit... [08:28:46] (03PS27) 10Mooeypoo: [WIP] Create an OOUI ToC widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/209671 [08:28:49] \o/ [08:28:51] \o/ [08:28:56] THANK YOUUUUU! [08:28:57] \o/ [08:29:03] (i'm just going with the crowds) [08:29:11] ori, good timing [08:30:29] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Create an OOUI ToC widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/209671 (owner: 10Mooeypoo) [08:33:42] valhallasw, woot thank you very much, that saved my day, quite literally. :) [08:39:47] (03CR) 10Krinkle: [C: 031] T86782: Use CSS to style Parsoid's Cite HTML [extensions/Cite] - 10https://gerrit.wikimedia.org/r/207474 (owner: 10Marcoil) [08:59:56] (03PS2) 10Krinkle: resourceloader: Make ResourceLoader logger aware [core] - 10https://gerrit.wikimedia.org/r/215863 [09:00:08] (03PS2) 10Krinkle: resourceloader: Log "private module denied" as 'debug' instead of 'info' [core] - 10https://gerrit.wikimedia.org/r/215864 [09:11:06] What's the convention for linux file permissions in a mediawiki repository? [09:11:08] umask 0022? [09:12:33] (03CR) 10Florianschmidtwelzow: [C: 04-1] Use HTMLForm for Special:Export (031 comment) [core] - 10https://gerrit.wikimedia.org/r/204805 (https://phabricator.wikimedia.org/T73434) (owner: 10Florianschmidtwelzow) [09:12:54] (03PS9) 10Polybuildr: [WIP] Initial work on SmiteSpam extension [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/214303 [09:20:18] (03PS3) 10Krinkle: resourceloader: Make ResourceLoader logger aware [core] - 10https://gerrit.wikimedia.org/r/215863 [09:20:20] (03PS3) 10Krinkle: resourceloader: Audit debug log channels and messages [core] - 10https://gerrit.wikimedia.org/r/215864 [09:20:23] (03CR) 10Krinkle: resourceloader: Make ResourceLoader logger aware (038 comments) [core] - 10https://gerrit.wikimedia.org/r/215863 (owner: 10Krinkle) [09:20:54] polybuildr: Shouldn't matter much, as long as the webserver has read access to the php files, and write access to cache/ and upload/ [09:21:04] it's up to you [09:21:16] Krinkle: git stores file permissions too, right? [09:21:20] So if I'm developing an extension [09:21:22] Yes [09:21:28] what should the file's permissions be? [09:21:30] in the repo [09:21:52] By default files should be 644 and directories 755 [09:21:57] nothing fancy [09:22:04] Sorry, when I said mediawiki repo, I meant mediawiki-related repo :P [09:22:06] alright, thanks :) [09:22:42] polybuildr: Organisations that manage servers with multiple people (e.g. WMF), tend to use umask to enforce that common files are read/writable by the group, not just the owner. [09:23:00] And git allows overriding that at run time, it honours that [09:23:00] Krinkle: I see, so umask 0022 is preferred. [09:23:10] oh. [09:23:20] git lets umask override the earlier set permissions? [09:23:22] Files in source control should be plain as 644/755 though [09:23:31] Hi [09:23:41] polybuildr: Well, not beyond its intention (executable or not) [09:23:53] But yeah, owner/group that's flexible and not up to git afaik [09:24:02] alright :) 0022 it is, then. [09:24:03] Thanks! [09:24:26] im new to media wiki , I want to know where user defined css will be stored [09:24:54] Saravanan: Users themselves, when changing their css, is stored on wiki pages in the user namespace. [09:24:55] example: title=User:Saravanan/test/test.css [09:25:10] okay [09:25:11] which are saved as revisions in the database, like anything else. [09:25:28] on which table it will get stored? [09:25:55] (03CR) 10Krinkle: "check experimental" [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/214303 (owner: 10Polybuildr) [09:26:31] okay [09:27:06] Saravanan: meta data in 'page' and 'revision'. Content in 'text'. [09:27:16] okay.. [09:27:19] But why are you concerned about the db tables? [09:27:21] Use the API [09:27:30] okay [09:28:50] if you're inside a mediawiki extension context, use the php interface instead of writing queries. Those queries will break and perform less well then the optimised ones. If outside php execution, use the API yeah. [09:33:41] (03CR) 10Polybuildr: "recheck" [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/214303 (owner: 10Polybuildr) [09:36:19] (03PS7) 10Florianschmidtwelzow: Add basic support for patrolling on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/213203 (https://phabricator.wikimedia.org/T55684) [09:44:43] (03CR) 10Polybuildr: "Yaron, Jan: not ready for another review yet. I shall ping when the next "review-worthy" patch is submitted." [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/214303 (owner: 10Polybuildr) [09:48:09] Krinkle: Since the topic is being discussed, the extension I'm build will is going analyse all existing pages on a wiki to search for spam [09:48:27] I'm getting most of the metadata by using the DB wrapper [09:48:37] will the PHP interface certainly be more efficient? [09:48:55] polybuildr: define "DB wrapper" and "PHP interface" [09:49:28] Krenair: $dbr = wfGetDB( DB_SLAVE ); $dbr->select* [09:49:34] vs [09:49:48] $a = new WikiPage(); $a->get* [09:49:59] Ouch, sorry Krenair. Had to ping Krinkle. [09:50:20] (03PS1) 10Pastakhov: add gitignore and gitreview files [extensions/PhpTagsStorage] - 10https://gerrit.wikimedia.org/r/215872 [09:50:35] polybuildr: It depends. [09:50:48] polybuildr: If you're doing one page at a time, the PHP inteface will likely use better constructs and caching layers. [09:50:51] (03CR) 10Pastakhov: [C: 032 V: 032] add gitignore and gitreview files [extensions/PhpTagsStorage] - 10https://gerrit.wikimedia.org/r/215872 (owner: 10Pastakhov) [09:51:14] polybuildr: Using direct DB access may help improve speed if you're doing a lot at once. [09:52:16] polybuildr: Take a look at existing maintenance scripts in mediawiki-core [09:52:28] Krinkle: All of the pages need to be processed, but the question was memory vs speed. I can't possibly load all the data into PHP memory. [09:52:44] So I resorted to doing it page by page, at least in the current version of the patch. [09:52:46] yeah, btu you can batch [09:53:02] https://github.com/wikimedia/mediawiki/blob/master/maintenance/cleanupSpam.php [09:53:25] You probably don't need WikiPage. [09:53:31] Title and Revision get you to the content [09:53:48] Thoguh you'll need Page to do edit [09:54:03] Well, actually, a couple of issues. [09:54:09] https://github.com/wikimedia/mediawiki/blob/master/maintenance/cleanupSpam.php#L100-L122 [09:54:14] that section is what you want [09:54:22] something like it [09:54:25] Firstly, there is nothing common I'm looking for in the pages. It's manual content analysis. [09:54:27] Okay, looking. [09:55:40] Krinkle: Right, so those lines are using the Title and Revision classes, while I'm not. I'm currently selecting the revisions with a manual select join, for example. [09:56:36] And all the extension is going to do is check the page using certain heuristics. Number of links (which I found I can't use externallinks for, because repeated links aren't differentiated there) [09:56:50] s/Number of links/Number of external links [09:57:17] Then repeated external links. Edit history (fully formed page in one go). Amount of wikitext (almost none is red flag) [09:57:20] etc. [09:57:32] For tasks like these, the pages certainly need to be analysed individually. [09:57:57] So I don't really know what the optimal balance between speed and memory would be. [09:58:03] Krinkle: Could certainly use some help there. [09:58:52] polybuildr: OK. So I'd use the classes for making pages, titles and revisions. [09:58:53] one by one [09:59:03] all you then need is a source of page titles [09:59:21] You can use the TableCleanup maintenance class (I assume this runs from the command line your clean up script, not from the web) [09:59:24] which I've already taken with a $dbr->select [09:59:35] which queries the page table in batches of 200 page ids [10:00:02] (The extension? It's supposed to work on the web, not on command line.) [10:00:20] polybuildr: Iterating over all pages one by one via the web? [10:00:29] Krinkle: Um, yeah. :P [10:00:37] How long does that browser socket stay open? [10:00:41] It times out after 30 seconds [10:00:46] (or should anyway) [10:01:19] AJAX call. [10:01:27] From the main special page to another page. [10:01:28] Why would you do that? [10:01:46] If you want to trigger it from the web, use the JobQueue [10:01:50] So that the processing could happen in the background. [10:01:58] which is properly in the background [10:02:06] Yes, I do intend to switch to that. [10:02:06] or approximation at least [10:02:07] Oh. [10:02:10] So a normal special page [10:02:14] can create Jobs [10:02:22] and it happens (sort of) in the background? [10:02:26] Every time you save an edit on Wikipedia, tons of jobs are created. [10:02:35] for many different purposes [10:02:59] polybuildr: Use the special page to verify the user has the proper user rights (I assume you don't wnat random users to triger this) [10:03:11] Krinkle: Will be checking that, yes. [10:03:31] polybuildr: But why do it from the web? [10:03:39] I think you'll be better off writing it as a maintennace script [10:03:56] Well, the intention was to let people perform those actions without having shell access [10:04:02] If you need this frequently, it's probably the wrong approach. [10:04:04] just a normal sysop or 'crat account [10:04:26] no, not frequently [10:04:29] Use AbuseFilter to prevent such things. [10:04:33] maybe twice a year, for third party wikis? [10:04:48] And a "viral" user group of trusted users that can bypass it. [10:05:00] AbuseFilter, iirc stops new spam. [10:05:06] This extension attempts to remove existing spam. [10:05:08] Yes [10:05:15] So you run it once. [10:05:31] True, probably. [10:05:40] So why not just a maintenance script is what you're asking? [10:05:50] doing it via the web is gonna take you more time to develop then it takes to run it twice a year, for the next 20 years. [10:06:06] Well, one issue is interactivity. [10:06:16] The admin is allowed to select, group, filter [10:06:20] which ones he thinks are spam [10:06:23] which ones are not [10:06:24] etc. [10:06:33] I'm not sure how well that can be done with a utility script. [10:06:41] So can't use AbuseFilter, then? [10:06:55] There is Nuke extension to mass-delete pages [10:07:06] if you've got certain accounts that created lots of pages [10:07:06] Yes, but Nuke deletes based on IP. [10:07:16] This extension tries to find spam. [10:07:26] Not just delete known offending pages. [10:07:38] Should be doable with AbuseFilter and other extensions [10:07:45] SpamBlacklist [10:07:53] Wikipedia uses a dozen of them or so [10:08:08] Existing spam> [10:08:12] s/>/? [10:08:14] All of those stop new spam. [10:08:22] Yes, so you run it once. [10:08:37] maybe take a look at https://phabricator.wikimedia.org/T90238#1307846, the earlier task description [10:08:40] Yes, run it once. [10:08:47] And after that use all those extensions. [10:08:52] AbuseFilter, SpamBlacklist, etc. [10:09:19] But for the once, when user interaction is required, isn't a web view easier than the command line? [10:09:23] An extension to do a one-time clean up of a polluted wiki? [10:09:43] That's what it looks like, yes. [10:10:21] If it needs much user interaction, then I don't think it's batching or querying you should be worried about. But instead this needs a user friendly UI to provide lots of data to the user and allow the user to filter and match and mass delete easily. [10:10:38] True. [10:10:49] So you're saying that I should be using whatever is most convenient? [10:10:59] For the developers, I mean. [10:11:18] Since the bottleneck, or the main feature, isn't going to be the efficiency in any case. [10:11:19] Yeah, don't worry about performance. Use the proper interfaces MediaWiki provides. [10:11:34] Hmm. [10:11:42] That'll end up wasting time when not improving your core product. [10:11:44] Also, are you currently thinking that this is a waste? :P [10:11:59] Once everythign is finished and working lovely, you can worry about that. [10:12:28] Trying to figure out all the database models, caching and serialisation formats is gonna eat up time [10:13:12] True. So might as well keep that part as easy as possible. [10:13:55] Also, ^^^^? [10:14:03] the kind of things that come to mind would be to gather user names, external link domain names (query external_link database, it optimises for queries on prefix, so could find all domain names used and how many links count(*)) [10:14:33] and a bunch of other factors in drop down menus and generating lists and allowing the user to delete it (after verifying the list of pages) [10:14:54] polybuildr: Well, I've had to clean up wikis in the past, I know it's annoying to deal with [10:14:57] and time consuming [10:15:08] Such diplomacy. :P [10:15:18] Do you see a good reason for such an extension to exist? [10:15:35] but if it's only for polluted wikis to do clan up once, I'm not sure it's worth creating an extension for. It would have to be a lot of spam to justify not deleting a few pages manually. [10:16:01] hmm, I see. [10:16:42] And I imagine the typical non-shell user would probably take forever to do it with an extension, no matter how good the interface. [10:17:17] I'd do it manaully each time. Use phpMyAdmin (what!?) to get a sense of the pages in the database and external links, and just take a bunch of them at a time manually or via the db directly. [10:17:18] Right, okay. :P [10:17:46] And if it's for a client, you should be able to bill your time for it. And you'd be more effective at it then them. [10:17:57] And of course set up prevention systems for the future. [10:18:28] Well, this is a GSoC project. :P So I'm guessing some people thought it has use. [10:18:49] proposed or approved? [10:18:53] approved. [10:18:54] ongong. [10:19:00] * Krinkle shrugs. [10:19:00] s/ongong/ongoing [10:19:03] Ask the mentor in that case. [10:20:19] (03CR) 10QEDK: "I'm pretty damn sure, I don't want to inconvenience thousands of challenged users accessing Wikipedia." [skins/Vector] - 10https://gerrit.wikimedia.org/r/164712 (https://bugzilla.wikimedia.org/70004) (owner: 10Isarra) [10:21:22] polybuildr: One last idea: You might be able to take pages/edits and replay them against the abuse filter / spam extensions and if they signal a prevention, perform a revert/delete accordingly. Like a reflection of sorts. [10:21:45] That sounds rather interesting. [10:23:52] is anybody able to tell me when failed jobs will be reattempted to be run again? [10:24:02] Krinkle: Thanks a lot for all your help. :) [10:24:42] (03CR) 10Krinkle: [C: 04-1] "Actually, from quick checking it seems browser do not execute the script if the server responded with an http status code of 4xx or 5xx. W" [core] - 10https://gerrit.wikimedia.org/r/212935 (https://phabricator.wikimedia.org/T87175) (owner: 10Parent5446) [10:32:40] (03PS1) 10Marcoil: Expose ResourceLoader modules in action=expandtemplates [core] - 10https://gerrit.wikimedia.org/r/215874 (https://phabricator.wikimedia.org/T69540) [10:41:06] (03CR) 10Steinsplitter: [C: 031] Show log entries of previous renames on the GlobalRenameQueue [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/215280 (https://phabricator.wikimedia.org/T101080) (owner: 10Legoktm) [10:50:19] (03CR) 10TheDJ: "for global variables, you also need jsconfigvars:" [core] - 10https://gerrit.wikimedia.org/r/215874 (https://phabricator.wikimedia.org/T69540) (owner: 10Marcoil) [10:56:56] (03CR) 10Jhernandez: Remove button with spinner to fix iOS tap not capturing (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/215002 (https://phabricator.wikimedia.org/T98654) (owner: 10Jhernandez) [11:18:46] (03CR) 10Mooeypoo: [WIP] Create an OOUI ToC widget (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/209671 (owner: 10Mooeypoo) [11:30:43] (03CR) 10Krinkle: "Weird. This was moved in https://gerrit.wikimedia.org/r/#/c/204851/2/MathTexvc.php, but in a broken way. It checks $wgHooks, but doesn't i" [extensions/Math] - 10https://gerrit.wikimedia.org/r/211401 (https://phabricator.wikimedia.org/T99212) (owner: 10Physikerwelt) [11:33:58] (03CR) 10Deskana: [C: 031] "Search & Discovery is ready for this to be merged. Thanks for working on it!" [core] - 10https://gerrit.wikimedia.org/r/207262 (https://phabricator.wikimedia.org/T97310) (owner: 10Bmansurov) [11:40:17] (03PS2) 10Marcoil: Expose RL modules and js config vars in action=expandtemplates [core] - 10https://gerrit.wikimedia.org/r/215874 (https://phabricator.wikimedia.org/T69540) [11:43:18] thedj: it was easy to add jsconfigvars, thanks for the pointer. Although I don't think we'll expose them in Parsoid right away… [11:43:54] (03CR) 10jenkins-bot: [V: 04-1] Expose RL modules and js config vars in action=expandtemplates [core] - 10https://gerrit.wikimedia.org/r/215874 (https://phabricator.wikimedia.org/T69540) (owner: 10Marcoil) [11:45:52] (03PS3) 10Krinkle: mediawiki.searchSuggest: Add track event on search form submission [core] - 10https://gerrit.wikimedia.org/r/207262 (https://phabricator.wikimedia.org/T97310) (owner: 10Bmansurov) [11:46:35] (03CR) 10Krinkle: Expose RL modules and js config vars in action=expandtemplates (031 comment) [core] - 10https://gerrit.wikimedia.org/r/215874 (https://phabricator.wikimedia.org/T69540) (owner: 10Marcoil) [11:47:15] (03CR) 10ArielGlenn: "This looks great to me. Sorry I forgot to add the numbers here. I tested on an uncompressed file of 67G, with mx=4 it compressed to 743M " [core] - 10https://gerrit.wikimedia.org/r/186347 (owner: 10Nemo bis) [11:48:31] (03PS28) 10Mooeypoo: [WIP] Create an OOUI ToC widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/209671 [11:49:05] Krinkle: would it be better to just implement 'modules' and output both modules and jsconfigvars there? [11:50:35] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Create an OOUI ToC widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/209671 (owner: 10Mooeypoo) [11:50:53] marcoil: Yeah [11:51:18] Krinkle: what about encodedjsconfigvars? I have no idea where that's used, tbh [11:51:20] when a parser tag adds modules to a page, it may also add config variables. [11:51:30] Loading only one but not the other is unsupported. [11:51:52] makes sense [11:51:54] marcoil: ask anomie. I don't know either. All I care about is that the jsconfig is exported as a proper object in JSON mode. What XML does i don't care. [11:52:06] OK :) [11:52:15] I'd take the bold approach and make jsconfig json-only, and then in xml mode export it as encoded string. [11:52:30] no hybrid mode where we encode each property as a node in xml [11:53:16] (03PS1) 10Matthias Mullie: Generate mention notifications in more cases [extensions/Echo] - 10https://gerrit.wikimedia.org/r/215885 (https://phabricator.wikimedia.org/T101385) [11:55:01] (03CR) 10jenkins-bot: [V: 04-1] Generate mention notifications in more cases [extensions/Echo] - 10https://gerrit.wikimedia.org/r/215885 (https://phabricator.wikimedia.org/T101385) (owner: 10Matthias Mullie) [11:58:47] (03CR) 10TheDJ: Expose RL modules and js config vars in action=expandtemplates (031 comment) [core] - 10https://gerrit.wikimedia.org/r/215874 (https://phabricator.wikimedia.org/T69540) (owner: 10Marcoil) [11:59:04] (03PS29) 10Mooeypoo: [WIP] Create an OOUI ToC widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/209671 (https://phabricator.wikimedia.org/T96890) [12:01:11] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Create an OOUI ToC widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/209671 (https://phabricator.wikimedia.org/T96890) (owner: 10Mooeypoo) [12:04:01] (03PS30) 10Mooeypoo: [WIP] Create an OOUI ToC widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/209671 (https://phabricator.wikimedia.org/T96890) [12:04:39] (03CR) 10Krinkle: [C: 032] "Note that form submission still leaves ambiguity over two things:" [core] - 10https://gerrit.wikimedia.org/r/207262 (https://phabricator.wikimedia.org/T97310) (owner: 10Bmansurov) [12:05:13] (03CR) 10Krinkle: "(See Phabricator task)" [core] - 10https://gerrit.wikimedia.org/r/207262 (https://phabricator.wikimedia.org/T97310) (owner: 10Bmansurov) [12:06:55] (03PS3) 10Marcoil: Expose RL modules and js config vars in action=expandtemplates [core] - 10https://gerrit.wikimedia.org/r/215874 (https://phabricator.wikimedia.org/T69540) [12:08:36] (03PS31) 10Mooeypoo: [WIP] Create an OOUI ToC widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/209671 (https://phabricator.wikimedia.org/T96890) [12:10:55] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Create an OOUI ToC widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/209671 (https://phabricator.wikimedia.org/T96890) (owner: 10Mooeypoo) [12:11:43] (03CR) 10Mooeypoo: "See comment on PS27" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/209671 (https://phabricator.wikimedia.org/T96890) (owner: 10Mooeypoo) [12:15:03] (03PS2) 10Physikerwelt: Add required arguments to ParserAfterParse hook call [extensions/Math] - 10https://gerrit.wikimedia.org/r/211401 (https://phabricator.wikimedia.org/T99212) [12:15:47] Krinkle: could you please review this? https://gerrit.wikimedia.org/r/#/c/213468/ [12:16:39] (03Merged) 10jenkins-bot: mediawiki.searchSuggest: Add track event on search form submission [core] - 10https://gerrit.wikimedia.org/r/207262 (https://phabricator.wikimedia.org/T97310) (owner: 10Bmansurov) [12:19:46] (03PS3) 10Physikerwelt: Add required arguments to ParserAfterParse hook call [extensions/Math] - 10https://gerrit.wikimedia.org/r/211401 (https://phabricator.wikimedia.org/T99212) [12:20:29] (03CR) 10Physikerwelt: [C: 04-2] Add required arguments to ParserAfterParse hook call [extensions/Math] - 10https://gerrit.wikimedia.org/r/211401 (https://phabricator.wikimedia.org/T99212) (owner: 10Physikerwelt) [12:21:29] (03PS4) 10Physikerwelt: Add required arguments to ParserAfterParse hook call [extensions/Math] - 10https://gerrit.wikimedia.org/r/211401 (https://phabricator.wikimedia.org/T99212) [12:25:34] galorefitz: I don't maintain that area of the code. I can give basic feedback, but won't approve it [12:26:06] Krinkle: Alright :) [12:26:11] (03CR) 10Physikerwelt: "missing the global is an embarrassing mistake..." [extensions/Math] - 10https://gerrit.wikimedia.org/r/211401 (https://phabricator.wikimedia.org/T99212) (owner: 10Physikerwelt) [12:27:54] (03CR) 10Krinkle: "There wouldn't be any warning since isset() guards against that." [extensions/Math] - 10https://gerrit.wikimedia.org/r/211401 (https://phabricator.wikimedia.org/T99212) (owner: 10Physikerwelt) [12:28:13] (03CR) 10Krinkle: "btw, how does it "save" the PNG by running a hook? Is there some global state outside of these parameters? Can we call the thing directly?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/211401 (https://phabricator.wikimedia.org/T99212) (owner: 10Physikerwelt) [12:30:51] legoktm: can you please review this? https://gerrit.wikimedia.org/r/#/c/213468/ [12:42:38] Hi, there is a bug with tag ref, see table of content in http://en.wikipedia.org/wiki/Ambernac. Is it a known issue? [12:56:00] rotpunkt: Hm, can't see that in Phabricator. Is it new? [12:56:12] Oh I see you're asking whether it is a known issue :) [12:56:42] If it was an old issue I'd find it hard to believe it wasn't in Phabricator => I guess it's a new bug [13:02:11] tto: hi, actually I was looking for confirmation, because it is quite visibile as a bug but I had not found it in Phabricator [13:04:02] Phab's search leaves a lot to be desired. If I were you I'd go ahead and file it, and if it turns out to be a dupe, don't feel too bad [13:04:16] You can use https://test.wikipedia.org/wiki/Destination as a testcase if you like [13:07:34] rotpunkt, hmm, it works correctly on other pages, e.g. https://en.wikipedia.org/wiki/Allenwiller#Neighbouring_communes_and_villages.5B1.5D [13:07:38] wondering what triggers this [13:10:40] rotpunkt, ah. An ?action=purge on https://en.wikipedia.org/wiki/Allenwiller shows the same error now. So looks like a new problem, could you file a task in Phabricator? [13:10:42] andre__ after refreshing the cache (action=purge) the problem is also there [13:10:48] yeah [13:10:55] so looks like a regression [13:15:04] I was hoping the task was filed by someone more expert than me with MediaWiki internals :) [13:20:49] rotpunkt, andre__: At a quick check, it looks like https://gerrit.wikimedia.org/r/#/c/181112/ slightly changed the behavior of in headings, and https://gerrit.wikimedia.org/r/#/c/213313/ really changed it in response to T99787. [13:22:02] This might be the right moment to say: anomie, I seriously adore your git log grep/research skills. [13:23:12] andre__: It helps that I had seen those Cite patches go through Gerrit recently, so I already knew they existed and just had to find them and verify that they actually did change behavior ;) [13:24:30] heh [13:25:05] rotpunkt: did you file a task or shall I try? Tasks do not need to be written by experts, and tasks do not need to perfect from the beginning. They evolve. [13:26:51] andre__ no I haven't. Thanks. [13:27:01] will do then [13:29:43] eheh nice andre__ thanks [13:29:53] np [13:30:52] (03CR) 10Krinkle: [C: 032] Track the 'submit-form' event [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/207263 (https://phabricator.wikimedia.org/T97310) (owner: 10Bmansurov) [13:31:40] (03Merged) 10jenkins-bot: Track the 'submit-form' event [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/207263 (https://phabricator.wikimedia.org/T97310) (owner: 10Bmansurov) [13:33:27] (03CR) 10Krinkle: "(Ref T97410)" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/215862 (owner: 10Krinkle) [13:46:30] marcoil: jsconfigvars is pretty new, only got merged 3 weeks ago, so i wanted to make sure it was on your radar :) [13:50:15] it is now ;) [13:55:46] (03CR) 10Fjalapeno: [C: 032] Fix for wonky spacing around text beneath widened images. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/215827 (https://phabricator.wikimedia.org/T101186) (owner: 10Mhurd) [13:56:50] thedj: Are you familiar yet with the RL changes with regards to version hashes? [13:57:29] Would be nice to have test-drive explaining it to someone (or have it be self-explanatory) [13:57:51] e.g. would https://gerrit.wikimedia.org/r/#/c/215391/ make sense to you (see the dependent commit mentioned in the commit message) [13:58:40] And changes like https://gerrit.wikimedia.org/r/#/c/215631/1/VisualEditorDataModule.php (this one is more interesting, then the other one that only removes one line) [13:59:10] Krinkle: reading... [13:59:13] (03CR) 10Fjalapeno: [C: 031] "small comments… can address or not…" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/215817 (https://phabricator.wikimedia.org/T101269) (owner: 10Bgerstle) [13:59:23] and no, i did not know about this yet :) [14:13:25] (03PS1) 10Matthias Mullie: Make sure correct request user is used when rendering page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/215908 (https://phabricator.wikimedia.org/T101388) [14:13:29] (03PS1) 10Matthias Mullie: Be stricter when checking user [extensions/Flow] - 10https://gerrit.wikimedia.org/r/215909 [14:15:54] (03CR) 10jenkins-bot: [V: 04-1] Be stricter when checking user [extensions/Flow] - 10https://gerrit.wikimedia.org/r/215909 (owner: 10Matthias Mullie) [14:18:36] (03CR) 10Fjalapeno: [C: 04-1] "Don't take the -1 as bad… overall looks very good. Basically now that we changed how image caching works, we can do a bit more clean up an" (037 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/215812 (owner: 10Mhurd) [14:19:13] (03CR) 10Gergő Tisza: "Yes." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/210885 (https://phabricator.wikimedia.org/T97061) (owner: 10Gergő Tisza) [14:22:22] Krinkle: right, it makes sense, but linking to the doc.wikimedia.org of includes/resourceloader/ResourceLoaderModule.php [14:22:42] will be useful for sure :) [14:25:10] Hi. Someone on #wikipedia-fr asks information about this kind of reports: http://safebrowsing.clients.google.com/safebrowsing/diagnostic?site=AS:14907 [14:25:31] Hi asks if Google is paranoid or if users could really exploit Wikimedia sites to propagate virii. [14:25:57] So short summary. getModifiedTime and getModifiedHash, getHashMtime and getDefinitionMtime are all deprecated, but still functional. [14:26:08] "Diagnostic page for AS14907 (WIKIMEDIA)" [14:26:20] "Of the 104 site(s) we tested on this network over the past 90 days, 5 site(s), including, for example, thehimalayantimes.com/, xinhuanet.com/, incheonbus.or.kr/" [14:26:21] (03PS1) 10Sbisson: Show unpatrolled flag in watchlist and recent changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/215912 (https://phabricator.wikimedia.org/T95025) [14:26:21] ... wot? [14:26:35] if you need more variance on the cache you should append your variance in getDefinitionSummary [14:26:37] Dereckson, google crazy, these are not wikimedia-hosted sites [14:26:57] What kind of variance is good and bad is nicely documented there. [14:27:23] getVersionHash gobbles it all together, and should not be overridden by subclasses. [14:27:38] and it all results in a weak etag. [14:27:42] although I don't like that section below [14:28:09] http://safebrowsing.clients.google.com/safebrowsing/diagnostic?site=wikimedia.org/ seems at domain level [14:29:06] I wonder what it means by infecting other sites [14:29:46] Dereckson, we should probably contact someone with google webmaster tools access for wikimedia domains [14:30:01] Krenair: a more detailled report is accessible to [14:30:30] Has csteipp access to that for example? [14:30:46] I doubt it [14:31:06] Webmaster tools access is quite frankly ridiculous [14:32:05] Ops have access though [14:32:46] (03PS1) 10Manybubbles: Make regexes easier to use from other plugins [search/extra] - 10https://gerrit.wikimedia.org/r/215913 [14:33:22] the only thing i can imagine are fragments of viruses, that people posted, that the google tools match on, but that probably (due to our strict content checking) wouldn't actually run. [14:33:45] (03CR) 10JanZerebecki: [C: 04-1] "Yes, what Bryan said. Otherwise it will not pick up changes when composer.lock is not versioned like in Wikidata." [vagrant] - 10https://gerrit.wikimedia.org/r/215815 (owner: 10Mattflaschen) [14:33:45] and the other thing is files, with potential virii in it. [14:34:03] (03CR) 10jenkins-bot: [V: 04-1] Make regexes easier to use from other plugins [search/extra] - 10https://gerrit.wikimedia.org/r/215913 (owner: 10Manybubbles) [14:34:42] (03CR) 10Isarra: "If there are specific reasons why different colours shouldn't be used at all, please put them on the phabricator (especially since if colo" [skins/Vector] - 10https://gerrit.wikimedia.org/r/164712 (https://bugzilla.wikimedia.org/70004) (owner: 10Isarra) [14:41:12] (03CR) 10Manybubbles: "recheck" [search/extra] - 10https://gerrit.wikimedia.org/r/215913 (owner: 10Manybubbles) [14:43:23] (03PS1) 10Manybubbles: Fix randomized test failure [search/extra] - 10https://gerrit.wikimedia.org/r/215915 [14:46:07] (03CR) 10Anomie: [C: 04-1] Expose RL modules and js config vars in action=expandtemplates (036 comments) [core] - 10https://gerrit.wikimedia.org/r/215874 (https://phabricator.wikimedia.org/T69540) (owner: 10Marcoil) [14:46:25] (03CR) 10Bgerstle: "FJalapeno I addressed your last sticking point. It took me getting away from the keyboard to realize what you meant. I removed the superf" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/215326 (https://phabricator.wikimedia.org/T100687) (owner: 10Bgerstle) [14:48:21] (03CR) 10Bgerstle: "will change showDebugMenu method now..." (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/215817 (https://phabricator.wikimedia.org/T101269) (owner: 10Bgerstle) [14:48:27] (03CR) 10Bgerstle: [C: 04-2] move hockeyapp & debug menu config to info.plist [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/215817 (https://phabricator.wikimedia.org/T101269) (owner: 10Bgerstle) [14:54:18] (03CR) 10Isarra: Add logo image to banner (031 comment) [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/214801 (owner: 10Isarra) [14:55:19] (03PS2) 10Isarra: Fix typo in 'mediawiki.skinning.logo' module name [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/215313 (owner: 10Bartosz Dziewoński) [14:55:34] (03CR) 10Isarra: [C: 032] Fix typo in 'mediawiki.skinning.logo' module name [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/215313 (owner: 10Bartosz Dziewoński) [14:55:36] (03Merged) 10jenkins-bot: Fix typo in 'mediawiki.skinning.logo' module name [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/215313 (owner: 10Bartosz Dziewoński) [14:55:44] (03CR) 10Isarra: "Also thanks. >.<" [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/215313 (owner: 10Bartosz Dziewoński) [14:58:23] (03PS1) 10KartikMistry: Update ContentTranslation to 9db7974 [core] (wmf/1.26wmf8) - 10https://gerrit.wikimedia.org/r/215916 [14:58:43] (03CR) 10Sbisson: [C: 04-1] Only change editor preference if user makes a change (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/215838 (https://phabricator.wikimedia.org/T94852) (owner: 10Catrope) [15:00:03] (03PS1) 10Krinkle: Revert "Add 'mediawiki.skinning.logo' module" [core] - 10https://gerrit.wikimedia.org/r/215917 [15:00:55] (03PS2) 10Bgerstle: move hockeyapp & debug menu config to info.plist [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/215817 (https://phabricator.wikimedia.org/T101269) [15:01:17] (03CR) 10Bgerstle: "Fjalapeno changed the method name" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/215817 (https://phabricator.wikimedia.org/T101269) (owner: 10Bgerstle) [15:02:00] (03PS3) 10Bgerstle: move hockeyapp & debug menu config to info.plist [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/215817 (https://phabricator.wikimedia.org/T101269) [15:02:33] (03PS1) 10Krinkle: Re-use ResourceLoaderSkinModule instead of extra logo modules [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/215919 [15:02:43] (03PS1) 10Daniel Kinzler: Avoid data loss if compression fails [core] - 10https://gerrit.wikimedia.org/r/215920 [15:03:14] (03PS12) 10Florianschmidtwelzow: Use HTMLForm for Special:Export [core] - 10https://gerrit.wikimedia.org/r/204805 (https://phabricator.wikimedia.org/T73434) [15:03:33] (03CR) 10Krinkle: "Example: https://gerrit.wikimedia.org/r/215919" [core] - 10https://gerrit.wikimedia.org/r/215917 (owner: 10Krinkle) [15:05:27] Isarra: https://gerrit.wikimedia.org/r/215919. Let me know if that works. [15:09:12] (03PS1) 10Ori.livneh: awful hack: disable fss on zhwiki only, except on mw1017 [core] - 10https://gerrit.wikimedia.org/r/215921 [15:09:30] (03PS1) 10Ori.livneh: awful hack: disable fss on zhwiki only, except on mw1017 [core] (wmf/1.26wmf8) - 10https://gerrit.wikimedia.org/r/215922 [15:09:40] (03PS2) 10Florianschmidtwelzow: Use HTMLForm for Special:Search [core] - 10https://gerrit.wikimedia.org/r/200827 [15:10:17] (03CR) 10Fjalapeno: [C: 032] Fetch site info to get main page [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/215326 (https://phabricator.wikimedia.org/T100687) (owner: 10Bgerstle) [15:10:42] (03CR) 10Giuseppe Lavagetto: [C: 031] "Awful but useful." [core] (wmf/1.26wmf8) - 10https://gerrit.wikimedia.org/r/215922 (owner: 10Ori.livneh) [15:10:51] (03CR) 10BBlack: [C: 031] awful hack: disable fss on zhwiki only, except on mw1017 [core] (wmf/1.26wmf8) - 10https://gerrit.wikimedia.org/r/215922 (owner: 10Ori.livneh) [15:11:52] (03CR) 10Ori.livneh: [C: 032 V: 032] awful hack: disable fss on zhwiki only, except on mw1017 [core] (wmf/1.26wmf8) - 10https://gerrit.wikimedia.org/r/215922 (owner: 10Ori.livneh) [15:12:31] (03Abandoned) 10Florianschmidtwelzow: Use HTMLForm for Special:Search [core] - 10https://gerrit.wikimedia.org/r/200827 (owner: 10Florianschmidtwelzow) [15:14:29] (03Abandoned) 10Ori.livneh: awful hack: disable fss on zhwiki only, except on mw1017 [core] - 10https://gerrit.wikimedia.org/r/215921 (owner: 10Ori.livneh) [15:15:29] (03PS1) 10BearND: Fix backstack and editing issues introduced in experimental page content service patch [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/215924 [15:19:26] Krinkle: Right, on it. [15:19:32] (03CR) 10Florianschmidtwelzow: [C: 031] Convert Special:Search to OOUI (031 comment) [core] - 10https://gerrit.wikimedia.org/r/214821 (https://phabricator.wikimedia.org/T100898) (owner: 10Bartosz Dziewoński) [15:24:54] (03PS10) 10Florianschmidtwelzow: Hygiene: Use Config object instead of globals [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/210649 (https://phabricator.wikimedia.org/T87614) [15:37:00] (03CR) 10Fjalapeno: [C: 032] move hockeyapp & debug menu config to info.plist [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/215817 (https://phabricator.wikimedia.org/T101269) (owner: 10Bgerstle) [15:37:10] (03PS2) 10BearND: Fix backstack and editing issues from last patch [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/215924 [15:39:02] (03PS1) 10Matthias Mullie: Add small comments to clarify page-creation during import [extensions/Flow] - 10https://gerrit.wikimedia.org/r/215926 [15:39:13] (03PS2) 10Anomie: jobqueue: Record stats on how long it takes before a job is run [core] (wmf/1.26wmf8) - 10https://gerrit.wikimedia.org/r/215748 (https://phabricator.wikimedia.org/T101054) (owner: 10Legoktm) [15:39:21] (03CR) 10Anomie: [C: 032] "SWAT" [core] (wmf/1.26wmf8) - 10https://gerrit.wikimedia.org/r/215748 (https://phabricator.wikimedia.org/T101054) (owner: 10Legoktm) [15:40:53] (03CR) 10Paladox: [C: 031] Add support for 4K videos [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210407 (https://phabricator.wikimedia.org/T98694) (owner: 10Paladox) [15:41:01] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Hmm, i haven't thought about a drawer *facepalm*, thanks kaldari, i think that would be the better solution :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/210950 (https://phabricator.wikimedia.org/T95305) (owner: 10Florianschmidtwelzow) [15:41:04] (03CR) 10Paladox: Add support for 4K videos [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210407 (https://phabricator.wikimedia.org/T98694) (owner: 10Paladox) [15:42:40] (03PS5) 10Florianschmidtwelzow: Show a better error message, when the user can't edit a page due to the false group [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/210950 (https://phabricator.wikimedia.org/T95305) [15:43:12] 10Wikipedia-Android-App, 3Mobile-App-Sprint-57-Android, 5Patch-For-Review: Investigate why some MobileWikiAppSearch events have a negative timeToDisplayResults field - https://phabricator.wikimedia.org/T99577#1337793 (10Matanya) [15:43:12] (03CR) 10Krinkle: "Those two cases where it's set, shouldn't be setting it. These getter methods are essentially abusing a global variable to store singleton" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/210649 (https://phabricator.wikimedia.org/T87614) (owner: 10Florianschmidtwelzow) [15:43:27] 10MediaWiki-Configuration, 7Documentation: wgShowEXIF controls reading behavior not display behavior - https://phabricator.wikimedia.org/T98325#1337795 (10Bawolff) I don't really understand the point of even having this. I'd be a fan of removing it, and just looking at extension_loaded to determine if we use e... [15:43:56] 10Continuous-Integration-Config: Trigger PHPUnit job for MediaWiki extensions with HHVM instead of Zend in 'test' pipeline - https://phabricator.wikimedia.org/T101392#1337798 (10Legoktm) [15:44:17] (03CR) 10jenkins-bot: [V: 04-1] Show a better error message, when the user can't edit a page due to the false group [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/210950 (https://phabricator.wikimedia.org/T95305) (owner: 10Florianschmidtwelzow) [15:46:45] (03CR) 10Mholloway: [C: 031] Fix backstack and editing issues from last patch [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/215924 (owner: 10BearND) [15:47:03] (03PS1) 10Florianschmidtwelzow: Fix composer phpcs test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/215927 [15:47:45] 10MediaWiki-Page-protection, 10Wikipedia-Android-App, 10Wikipedia-iOS-App: Unable to edit semi-protected articles - https://phabricator.wikimedia.org/T100322#1337803 (10Matanya) It is actually a bit worse, since you can't edit even pages that are only protected from moving, but allow full editing. [15:48:09] (03Merged) 10jenkins-bot: jobqueue: Record stats on how long it takes before a job is run [core] (wmf/1.26wmf8) - 10https://gerrit.wikimedia.org/r/215748 (https://phabricator.wikimedia.org/T101054) (owner: 10Legoktm) [15:48:38] (03CR) 10Legoktm: "Is there PHP code in node_modules?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/215927 (owner: 10Florianschmidtwelzow) [15:51:16] (03PS6) 10Florianschmidtwelzow: Show a better error message, when the user can't edit a page due to the false group [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/210950 (https://phabricator.wikimedia.org/T95305) [15:53:22] 10Wikipedia-Android-App: clicking on a user name that has a global page coming from meta results in "this page doesn't exist" - https://phabricator.wikimedia.org/T101407#1337817 (10Matanya) 3NEW [15:54:02] (03CR) 10Aaron Schulz: [C: 032] Avoid data loss if compression fails [core] - 10https://gerrit.wikimedia.org/r/215920 (owner: 10Daniel Kinzler) [15:54:14] 10MediaWiki-Configuration, 10MediaWiki-RfCs: Improving extension management - https://phabricator.wikimedia.org/T88596#1337825 (10bd808) >>! In T88596#1337745, @MarkAHershberger wrote: > If there are extension use cases that are not compatible with Composer, > it would be good to make those explicit now so tha... [15:55:41] (03CR) 10Dbrant: [C: 032] Fix backstack and editing issues from last patch [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/215924 (owner: 10BearND) [15:56:43] 10MediaWiki-Configuration, 5MW-1.25-release, 5MW-1.26-release, 5Patch-For-Review, 5WMF-deploy-2015-06-09_(1.26wmf9): Extension registration does not let you use a global to override a setting to a falsity value in LocalSettings.php - https://phabricator.wikimedia.org/T100767#1337833 (10Paladox) But what... [15:57:32] 10MediaWiki-Configuration: Extension configuration settings that have 2d (or greater) arrays do not work in extension registration - https://phabricator.wikimedia.org/T99257#1337836 (10Paladox) p:5Triage>3Unbreak! [15:57:46] 10Wikimedia-Site-requests: Disable local file upload to all users on mr.wikipedia on 2015-06-08 - https://phabricator.wikimedia.org/T92633#1337837 (10greg) [15:57:49] 10MediaWiki-Configuration: Extension configuration settings that have 2d (or greater) arrays do not work in extension registration - https://phabricator.wikimedia.org/T99257#1288249 (10Paladox) Setting as unbreak since it doesent work and needs fixing. [15:58:26] 10Wikimedia-Site-requests: Disable local file upload to all users on mr.wikipedia on 2015-06-08 - https://phabricator.wikimedia.org/T92633#1116777 (10greg) The time has come for this to be done, well, on Monday. I'll sponsor it in the Monday June 8th morning SWAT window. [15:59:41] 10Gather, 6Mobile-Web, 10MobileFrontend, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned: Create a bot that can talk to Gerrit - https://phabricator.wikimedia.org/T101068#1337841 (10Jhernandez) Awesome @jdlrobson ! [16:00:32] 10MediaWiki-Configuration, 10MediaWiki-RfCs: Improving extension management - https://phabricator.wikimedia.org/T88596#1337842 (10Legoktm) >>! In T88596#1337745, @MarkAHershberger wrote: > If there are extension use cases that are not compatible with Composer, > it would be good to make those explicit now so t... [16:01:04] (03CR) 10Florianschmidtwelzow: [C: 032] Sandbox alpha and beta styles from stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/213802 (https://phabricator.wikimedia.org/T98400) (owner: 10Jdlrobson) [16:01:56] (03CR) 10Isarra: [C: 032] "Yup, works, is simpler, etc." [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/215919 (owner: 10Krinkle) [16:03:12] (03CR) 10Isarra: [C: 031] "Makes sense. Pity the documentation is so bad that nobody's apt to actually find this very easily." [core] - 10https://gerrit.wikimedia.org/r/215917 (owner: 10Krinkle) [16:03:20] (03Merged) 10jenkins-bot: Avoid data loss if compression fails [core] - 10https://gerrit.wikimedia.org/r/215920 (owner: 10Daniel Kinzler) [16:03:48] (03CR) 10KartikMistry: [C: 032] Update ContentTranslation to 9db7974 [core] (wmf/1.26wmf8) - 10https://gerrit.wikimedia.org/r/215916 (owner: 10KartikMistry) [16:04:29] (03CR) 10BearND: [C: 04-1] "With the updated css files the collapsed infobox titles and some images are too wide. Example: [[Pacific War]]: first infobox; first image" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/213465 (owner: 10Dbrant) [16:04:50] 10Wikipedia-Android-App: App crashes when clicking on blue link pointing nowhere - https://phabricator.wikimedia.org/T101408#1337847 (10Matanya) 3NEW [16:05:42] 10Wikipedia-Android-App: App crashes when clicking on blue link pointing to a redirect - https://phabricator.wikimedia.org/T101408#1337847 (10Matanya) [16:05:44] 7Design, 6Collaboration-Team, 10Collaboration-Team-Sprint-C-2015-06-17, 10Flow, and 2 others: C2. Implement patrolling other people's edits in Flow - https://phabricator.wikimedia.org/T94452#1337859 (10DannyH) [16:06:32] (03CR) 10Krinkle: [C: 032] Revert "Add 'mediawiki.skinning.logo' module" [core] - 10https://gerrit.wikimedia.org/r/215917 (owner: 10Krinkle) [16:08:53] 10Gather, 6Mobile-Web, 10MobileFrontend, 7Epic, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned: Setup script that runs browser tests and on failure posts to Gerrit - https://phabricator.wikimedia.org/T101346#1337868 (10Jhernandez) What doesn't work in there? Seems like it should work fine. [16:10:12] (03Merged) 10jenkins-bot: Sandbox alpha and beta styles from stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/213802 (https://phabricator.wikimedia.org/T98400) (owner: 10Jdlrobson) [16:10:15] (03Merged) 10jenkins-bot: Re-use ResourceLoaderSkinModule instead of extra logo modules [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/215919 (owner: 10Krinkle) [16:10:19] 10MediaWiki-Configuration, 5MW-1.25-release, 5MW-1.26-release, 5Patch-For-Review, 5WMF-deploy-2015-06-09_(1.26wmf9): Extension registration does not let you use a global to override a setting to a falsity value in LocalSettings.php - https://phabricator.wikimedia.org/T100767#1337871 (10Legoktm) >>! In T1... [16:10:53] (03CR) 10Catrope: Only change editor preference if user makes a change (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/215838 (https://phabricator.wikimedia.org/T94852) (owner: 10Catrope) [16:11:16] apergos: AFAIK you have +2 on mediawiki https://gerrit.wikimedia.org/r/186347 and the deployment will be taken care of together with all the MediaWiki stuff [16:12:04] yes but I should not jut be merging stuff I think... at least it's always been the assumption that ops does not just merge stuff into mw core [16:12:13] now that there is no mw core maybe we have to rethink that [16:12:16] I plan to ask aroun [16:12:17] d [16:12:19] what? [16:12:25] what do you mean there is no mw core? [16:12:32] well I mean is there a mw core team? [16:12:38] at the foundation? [16:12:45] not so much, it's been re-orged out of existence afaik [16:12:47] why would that change whether you should be able to merge things into core or not? [16:13:29] so technically, I am able to. that's a matter of whether I am granted a certain right in gerrit. proceurally, am I supposed to? that's ot really been the case for opsen [16:13:42] not generally [16:13:45] changes should have been eyeballed by a dev on he other side [16:13:53] so now I need to see what's up with that [16:14:01] apergos: what are the deploy concerns with the patch? [16:14:05] can it just roll out with the train? [16:14:12] (03CR) 10Marcoil: Expose RL modules and js config vars in action=expandtemplates (036 comments) [core] - 10https://gerrit.wikimedia.org/r/215874 (https://phabricator.wikimedia.org/T69540) (owner: 10Marcoil) [16:14:17] 10MediaWiki-extensions-WikibaseRepository, 6Mobile-Apps, 10Wikidata: Add an instruction field for Wikidata items - https://phabricator.wikimedia.org/T97566#1337875 (10Lydia_Pintscher) I tried to add John Katz to the ticket but couldn't find his username. Can someone who knows please do? IMHO the following... [16:14:17] for this one, I don't see why not [16:14:26] for others I'll have to stare at them I guess [16:14:30] (03CR) 10Legoktm: [C: 032] Use a faster 7z command line by default [core] - 10https://gerrit.wikimedia.org/r/186347 (owner: 10Nemo bis) [16:14:34] but I'll deal with them when I get there [16:14:38] ok :) [16:14:40] ah! [16:14:41] 7Design, 10VisualEditor, 3VisualEditor 2014/15 Q4 blockers: Increase width of inspectors on desktop - https://phabricator.wikimedia.org/T101290#1337879 (10Esanders) Are we running out of space in many examples? At 400 there's a lot of whitespace... [16:14:44] the existence or lack thereof of a team at wmf should not change the rules for mediawiki master [16:14:47] thank you very much [16:15:28] apergos: generally I think if there are no deploy concerns and you've tested it, you should feel free to +2 it [16:15:44] ohhh... [16:15:48] * apergos rubs hands gleefully [16:15:57] 10MediaWiki-Configuration, 5MW-1.25-release, 5MW-1.26-release, 5Patch-For-Review, 5WMF-deploy-2015-06-09_(1.26wmf9): Extension registration does not let you use a global to override a setting to a falsity value in LocalSettings.php - https://phabricator.wikimedia.org/T100767#1337884 (10Paladox) Tested wi... [16:16:04] no this will not lead to a sudden +2 spree :-) but it is good to know! [16:16:07] 10MediaWiki-extensions-WikibaseRepository, 6Mobile-Apps, 10Wikidata: Add an instruction field for Wikidata items - https://phabricator.wikimedia.org/T97566#1337885 (10Lydia_Pintscher) Ah Jon - not John. Sorry... [16:16:58] (03Merged) 10jenkins-bot: Update ContentTranslation to 9db7974 [core] (wmf/1.26wmf8) - 10https://gerrit.wikimedia.org/r/215916 (owner: 10KartikMistry) [16:17:01] (03Merged) 10jenkins-bot: Revert "Add 'mediawiki.skinning.logo' module" [core] - 10https://gerrit.wikimedia.org/r/215917 (owner: 10Krinkle) [16:17:31] (03CR) 10Physikerwelt: "Krinkle: I had the same thought, but could not figure what the hook actually does. Maybe Aaron knows that?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/211401 (https://phabricator.wikimedia.org/T99212) (owner: 10Physikerwelt) [16:20:04] (03CR) 10Bgerstle: [C: 04-1] "please address comments about threading & MobileCoreServices. some other nit-picky things about method naming & legacy code (placeholders," (0322 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/215812 (owner: 10Mhurd) [16:20:15] (03CR) 10Aaron Schulz: [C: 032] Add required arguments to ParserAfterParse hook call [extensions/Math] - 10https://gerrit.wikimedia.org/r/211401 (https://phabricator.wikimedia.org/T99212) (owner: 10Physikerwelt) [16:22:30] 10MediaWiki-Search, 10MediaWiki-Special-pages, 10UI-Standardization, 6Search-and-Discovery, and 2 others: Convert Special:Search to OOUI - https://phabricator.wikimedia.org/T100898#1337896 (10Manybubbles) [16:23:07] (03Merged) 10jenkins-bot: Use a faster 7z command line by default [core] - 10https://gerrit.wikimedia.org/r/186347 (owner: 10Nemo bis) [16:23:10] (03Merged) 10jenkins-bot: Add required arguments to ParserAfterParse hook call [extensions/Math] - 10https://gerrit.wikimedia.org/r/211401 (https://phabricator.wikimedia.org/T99212) (owner: 10Physikerwelt) [16:23:48] 10MediaWiki-Core-Team, 6Security, 6Security-Team, 5Patch-For-Review, and 2 others: XSS in language converter when used with Html class's tricky escaping - https://phabricator.wikimedia.org/T73394#1337901 (10dpatrick) [16:25:46] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 5ContentTranslation-Release5, 3LE-Sprint-87, and 2 others: Content Translation beta-feature deployment on the Dzongkha (dz) Wikipedia - https://phabricator.wikimedia.org/T100622#1337907 (10Jdforrester-WMF) 5Open>3Resolved [16:25:49] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 7Tracking: [Tracker] New language requests for Content Translation - https://phabricator.wikimedia.org/T88408#1337909 (10Jdforrester-WMF) [16:25:52] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 7Tracking: [Tracker] New language requests for Content Translation - https://phabricator.wikimedia.org/T88408#1010838 (10Jdforrester-WMF) [16:25:55] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 5ContentTranslation-Release5, 3LE-Sprint-87, and 3 others: Content Translation beta-feature deployment on Thai (th) Wikipedia - https://phabricator.wikimedia.org/T100623#1337910 (10Jdforrester-WMF) 5Open>3Resolved [16:26:02] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 7Tracking: [Tracker] New language requests for Content Translation - https://phabricator.wikimedia.org/T88408#1010838 (10Jdforrester-WMF) [16:26:05] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 5ContentTranslation-Release5, 3LE-Sprint-87, and 3 others: Content Translation beta-feature deployment on Lao (lo) Wikipedia - https://phabricator.wikimedia.org/T100624#1337912 (10Jdforrester-WMF) 5Open>3Resolved [16:26:11] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 5ContentTranslation-Release5, 3LE-Sprint-87, and 3 others: Deployment of Content Translation beta-feature on Khmer (km) Wikipedia - https://phabricator.wikimedia.org/T100625#1337915 (10Jdforrester-WMF) 5Open>3Resolved [16:26:14] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 7Tracking: [Tracker] New language requests for Content Translation - https://phabricator.wikimedia.org/T88408#1010838 (10Jdforrester-WMF) [16:26:19] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 7Tracking: [Tracker] New language requests for Content Translation - https://phabricator.wikimedia.org/T88408#1010843 (10Jdforrester-WMF) [16:26:22] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 5ContentTranslation-Release5, 3LE-Sprint-87, and 3 others: Content Translation beta-feature deployment on Burmese (my) Wikipedia - https://phabricator.wikimedia.org/T100626#1337917 (10Jdforrester-WMF) 5Open>3Resolved [16:26:27] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 5ContentTranslation-Release5, 3LE-Sprint-87, and 2 others: Content Translation beta-feature deployment on Indic language Wikipedias - https://phabricator.wikimedia.org/T100621#1337921 (10Jdforrester-WMF) [16:26:29] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 5ContentTranslation-Release5, 3LE-Sprint-87, 5Patch-For-Review: Content Translation beta-feature deployment on Assamese (as) Wikipedia - https://phabricator.wikimedia.org/T100752#1337919 (10Jdforrester-WMF) 5Open>3Resolved [16:26:41] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 5ContentTranslation-Release5, 3LE-Sprint-87, 5Patch-For-Review: Content Translation beta-feature deployment on Odia Wikipedia - https://phabricator.wikimedia.org/T100753#1337922 (10Jdforrester-WMF) 5Open>3Resolved [16:26:44] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 5ContentTranslation-Release5, 3LE-Sprint-87, and 2 others: Content Translation beta-feature deployment on Indic language Wikipedias - https://phabricator.wikimedia.org/T100621#1316768 (10Jdforrester-WMF) [16:26:48] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 5ContentTranslation-Release5, 3LE-Sprint-87, 5Patch-For-Review: Content Translation beta-feature deployment on Malayalam (ml) Wikipedia - https://phabricator.wikimedia.org/T100754#1337925 (10Jdforrester-WMF) 5Open>3Resolved [16:26:51] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 5ContentTranslation-Release5, 3LE-Sprint-87, and 2 others: Content Translation beta-feature deployment on Indic language Wikipedias - https://phabricator.wikimedia.org/T100621#1316768 (10Jdforrester-WMF) [16:26:56] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 5ContentTranslation-Release5, 3LE-Sprint-87, 5Patch-For-Review: Content Translation beta-feature deployment on the Bengali (bn) Wikipedia - https://phabricator.wikimedia.org/T100755#1337928 (10Jdforrester-WMF) 5Open>3Resolved [16:26:58] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 5ContentTranslation-Release5, 3LE-Sprint-87, and 2 others: Content Translation beta-feature deployment on Indic language Wikipedias - https://phabricator.wikimedia.org/T100621#1316768 (10Jdforrester-WMF) [16:27:03] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 5ContentTranslation-Release5, 3LE-Sprint-87, and 2 others: Content Translation beta-feature deployment on Indic language Wikipedias - https://phabricator.wikimedia.org/T100621#1316768 (10Jdforrester-WMF) [16:27:10] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 5ContentTranslation-Release5, 3LE-Sprint-87, and 2 others: Content Translation beta-feature deployment on Indic language Wikipedias - https://phabricator.wikimedia.org/T100621#1316768 (10Jdforrester-WMF) [16:27:13] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 5ContentTranslation-Release5, 3LE-Sprint-87, 5Patch-For-Review: Content Translation beta-feature deployment for the Marathi (mr) Wikipedia - https://phabricator.wikimedia.org/T100758#1337934 (10Jdforrester-WMF) 5Open>3Resolved [16:27:18] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 5ContentTranslation-Release5, 3LE-Sprint-87, and 2 others: Content Translation beta-feature deployment on Indic language Wikipedias - https://phabricator.wikimedia.org/T100621#1316768 (10Jdforrester-WMF) [16:27:21] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 5ContentTranslation-Release5, 3LE-Sprint-87, 5Patch-For-Review: Content Translation beta-feature deployment for Nepal Bhasa Wikipedia - https://phabricator.wikimedia.org/T100759#1337937 (10Jdforrester-WMF) 5Open>3Resolved [16:27:24] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 5ContentTranslation-Release5, 3LE-Sprint-87, and 2 others: Content Translation beta-feature deployment on Indic language Wikipedias - https://phabricator.wikimedia.org/T100621#1316768 (10Jdforrester-WMF) [16:27:27] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 5ContentTranslation-Release5, 3LE-Sprint-87, 5Patch-For-Review: Content Translation beta-feature deployment for Telugu Wikipedia - https://phabricator.wikimedia.org/T100760#1337940 (10Jdforrester-WMF) 5Open>3Resolved [16:27:30] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 5ContentTranslation-Release5, 3LE-Sprint-87, and 2 others: Content Translation beta-feature deployment on Indic language Wikipedias - https://phabricator.wikimedia.org/T100621#1316768 (10Jdforrester-WMF) [16:27:33] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 5ContentTranslation-Release5, 3LE-Sprint-87, 5Patch-For-Review: Content Translation beta-feature deployment for Pali Wikipedia - https://phabricator.wikimedia.org/T100761#1337943 (10Jdforrester-WMF) 5Open>3Resolved [16:27:37] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 5ContentTranslation-Release5, 3LE-Sprint-87, 5Patch-For-Review: Content Translation beta-feature availability for Bishnupriya Manipuri Wikipedia - https://phabricator.wikimedia.org/T100762#1337946 (10Jdforrester-WMF) 5Open>3R... [16:27:40] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 5ContentTranslation-Release5, 3LE-Sprint-87, and 2 others: Content Translation beta-feature deployment on Indic language Wikipedias - https://phabricator.wikimedia.org/T100621#1316768 (10Jdforrester-WMF) [16:27:45] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 5ContentTranslation-Release5, 3LE-Sprint-87, 5Patch-For-Review: Content Translation beta-feature availability for Sinhalese Wikipedia - https://phabricator.wikimedia.org/T100763#1337949 (10Jdforrester-WMF) 5Open>3Resolved [16:27:47] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 5ContentTranslation-Release5, 3LE-Sprint-87, and 2 others: Content Translation beta-feature deployment on Indic language Wikipedias - https://phabricator.wikimedia.org/T100621#1316768 (10Jdforrester-WMF) [16:29:01] 10MediaWiki-extensions-WikibaseRepository, 6Mobile-Apps, 10Wikidata: Add an instruction field for Wikidata items - https://phabricator.wikimedia.org/T97566#1337952 (10Lydia_Pintscher) https://www.wikidata.org/wiki/Wikidata:Project_chat#Coming_to_a_decision_for_usage_instructions_in_descriptions [16:29:37] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-58-iOS, 3Roadmap, 7notice: iOS Release 4.1.4 (130) - https://phabricator.wikimedia.org/T100685#1337954 (10greg) ping? All the checkboxes are checked and I think this was done yesterday? [16:30:13] 6WMF-Design-Research: Button sizes - https://phabricator.wikimedia.org/T101409#1337957 (10aripstra) 3NEW a:3aripstra [16:30:29] 10MediaWiki-Configuration, 5MW-1.25-release, 5MW-1.26-release, 5Patch-For-Review, 5WMF-deploy-2015-06-09_(1.26wmf9): Extension registration does not let you use a global to override a setting to a falsity value in LocalSettings.php - https://phabricator.wikimedia.org/T100767#1337972 (10Bawolff) I've test... [16:31:12] 10MediaWiki-Configuration, 5MW-1.25-release, 5MW-1.26-release, 5Patch-For-Review, 5WMF-deploy-2015-06-09_(1.26wmf9): Extension registration does not let you use a global to override a setting to a falsity value in LocalSettings.php - https://phabricator.wikimedia.org/T100767#1337974 (10Paladox) Oh sorry... [16:32:35] 10MediaWiki-extensions-ContentTranslation: Invoke automatic wikidata linking only if the article published to Main namespace - https://phabricator.wikimedia.org/T101410#1337975 (10santhosh) 3NEW [16:32:46] (03PS2) 10BryanDavis: Display AntiSpoof conflicts in the GlobalRenameQueue [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/215073 (https://phabricator.wikimedia.org/T97525) (owner: 10Legoktm) [16:32:52] (03CR) 10BryanDavis: [C: 032] Display AntiSpoof conflicts in the GlobalRenameQueue [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/215073 (https://phabricator.wikimedia.org/T97525) (owner: 10Legoktm) [16:33:27] 6WMF-Design-Research: Button sizes - https://phabricator.wikimedia.org/T101409#1337984 (10violetto) @Volker_E, @aripstra and I were talking about creating prototypes on beta labs to get these two button heights tested on both mobile and desktop. One of [[ https://phabricator.wikimedia.org/M31 | 36px with this... [16:33:36] 3ECT-June-2015: Metrics to analyze the impact of the Wikimedia Hackathon 2015 - https://phabricator.wikimedia.org/T88521#1337985 (10Sylvain_WMFr) There was a problem with my export file, people with several email addresses in the database (namely Jean-Frédéric, Sébastien, Pierre-Selim, Caroline and I) appeared s... [16:33:40] 6Mobile-Web, 10MobileFrontend, 6Performance-Team: Trim down CSS loaded in the head on mobile - https://phabricator.wikimedia.org/T97289#1337987 (10Jdlrobson) [16:33:42] 6Mobile-Web, 10MobileFrontend, 6Performance-Team, 5Patch-For-Review: Alpha styles loaded for all users in head - https://phabricator.wikimedia.org/T98400#1337986 (10Jdlrobson) 5Open>3Resolved [16:33:52] (03Merged) 10jenkins-bot: Display AntiSpoof conflicts in the GlobalRenameQueue [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/215073 (https://phabricator.wikimedia.org/T97525) (owner: 10Legoktm) [16:33:55] (03PS4) 10Marcoil: Expose RL modules and js config vars in action=expandtemplates [core] - 10https://gerrit.wikimedia.org/r/215874 (https://phabricator.wikimedia.org/T69540) [16:35:53] 10MediaWiki-extensions-ContentTranslation, 3LE-Sprint-88: Invoke automatic wikidata linking only if the article published to Main namespace - https://phabricator.wikimedia.org/T101410#1337993 (10Pginer-WMF) [16:36:27] 10MediaWiki-extensions-OAuth, 6Reading-Infrastructure-Team, 5Patch-For-Review: OAuth: Authorisation should not fail because you don't have an account on central wiki - https://phabricator.wikimedia.org/T74469#1337995 (10Ragesoss) What's the blocker on this? Tgr's patch has been waiting for a while now. [16:37:50] (03CR) 10jenkins-bot: [V: 04-1] Expose RL modules and js config vars in action=expandtemplates [core] - 10https://gerrit.wikimedia.org/r/215874 (https://phabricator.wikimedia.org/T69540) (owner: 10Marcoil) [16:38:17] 10MediaWiki-Core-Team, 6Security, 5Patch-For-Review, 10Security-Core, 7Vuln-XSS: XSS in language converter when used with Html class's tricky escaping - https://phabricator.wikimedia.org/T73394#1337996 (10dpatrick) [16:38:24] 6Mobile-Web, 10MobileFrontend, 6Performance-Team, 5Patch-For-Review: Alert styles should be conditionally loaded - https://phabricator.wikimedia.org/T98877#1337997 (10Jdlrobson) 5Open>3Resolved [16:38:26] 6Mobile-Web, 10MobileFrontend, 6Performance-Team: Trim down CSS loaded in the head on mobile - https://phabricator.wikimedia.org/T97289#1337998 (10Jdlrobson) [16:42:08] (03PS5) 10Marcoil: Expose RL modules and js config vars in action=expandtemplates [core] - 10https://gerrit.wikimedia.org/r/215874 (https://phabricator.wikimedia.org/T69540) [16:43:18] 10MediaWiki-General-or-Unknown: Crazy modal box shows up out of the blue - https://phabricator.wikimedia.org/T101323#1338022 (10bmansurov) I see. I didn't expect to see a modal box there. If that's normal then we can close the bug. [16:43:49] (03PS2) 10BryanDavis: Show log entries of previous renames on the GlobalRenameQueue [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/215280 (https://phabricator.wikimedia.org/T101080) (owner: 10Legoktm) [16:44:05] (03CR) 10BryanDavis: [C: 032] Show log entries of previous renames on the GlobalRenameQueue [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/215280 (https://phabricator.wikimedia.org/T101080) (owner: 10Legoktm) [16:44:54] (03CR) 10BryanDavis: [C: 032] Add exiftool to multimedia role [vagrant] - 10https://gerrit.wikimedia.org/r/215605 (https://phabricator.wikimedia.org/T100976) (owner: 10Gilles) [16:44:56] (03Merged) 10jenkins-bot: Show log entries of previous renames on the GlobalRenameQueue [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/215280 (https://phabricator.wikimedia.org/T101080) (owner: 10Legoktm) [16:45:21] (03Merged) 10jenkins-bot: Add exiftool to multimedia role [vagrant] - 10https://gerrit.wikimedia.org/r/215605 (https://phabricator.wikimedia.org/T100976) (owner: 10Gilles) [16:52:55] 6WMF-Design-Research: Qualitative research triangulated with Oliver's quantitative measures of search success - https://phabricator.wikimedia.org/T101412#1338055 (10aripstra) 3NEW [16:57:00] 10ReleaseTaggerBot: ForrestBot should run for WMF-deployed extensions as well as MediaWiki core - https://phabricator.wikimedia.org/T100347#1338067 (10Legoktm) [16:57:35] 10Hovercards: Article name hover popup sometimes gets stuck open - https://phabricator.wikimedia.org/T92932#1338069 (10JanZerebecki) Also experienced a stuck Hovercard a few times. Just now on mediawiki.org. I'll try to remember to check JS errors next time. [17:00:39] 10MediaWiki-JobQueue: Job queue items from 1.20 get lost – need exit strategy for upgrade - https://phabricator.wikimedia.org/T48934#1338070 (10Nemo_bis) >>! In T48934#1335735, @aaron wrote: > Does this affect 1.26? How to test? [17:03:28] 6Mobile-Web, 7Epic, 5Patch-For-Review, 7Performance: Only load the lead section on page load - https://phabricator.wikimedia.org/T100258#1338072 (10Jdlrobson) [17:07:34] (03CR) 10Bmansurov: "@kaldari states in the bug ticket that the patch doesn't fix the problem. Do we still want to merge this?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/215568 (https://phabricator.wikimedia.org/T98505) (owner: 10Kaldari) [17:08:15] (03CR) 10Jdlrobson: [C: 032] "Yeh there can be.. due to the grunt-phpdocumentor" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/215927 (owner: 10Florianschmidtwelzow) [17:09:55] (03Merged) 10jenkins-bot: Fix composer phpcs test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/215927 (owner: 10Florianschmidtwelzow) [17:11:26] 10Gather: API: Allow sorting of a users collections by last modified - https://phabricator.wikimedia.org/T94762#1338093 (10Jdlrobson) @tgr how difficult is this now? [17:14:16] 10MediaWiki-Configuration: Extension configuration settings that have 2d (or greater) arrays do not work in extension registration - https://phabricator.wikimedia.org/T99257#1338107 (10Paladox) And setting for example $wgConfirmAccountRequestFormItems['Biography']['minWords'] = false; in localsetting doesent... [17:18:51] 10crosswatch: Minimum viable product [tracking] - https://phabricator.wikimedia.org/T99930#1338111 (10Sitic) [17:18:53] 10crosswatch, 5Patch-For-Review: Add logevents support - https://phabricator.wikimedia.org/T100339#1338110 (10Sitic) 5Open>3Resolved [17:20:16] (03CR) 10Jdlrobson: [C: 032] "Tested on Special:GatherLists after running script worked as expected" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/210885 (https://phabricator.wikimedia.org/T97061) (owner: 10Gergő Tisza) [17:20:36] WOO first command line merge tgr|away :) [17:21:01] 6Repository-Ownership-Requests: Request for +2 in core for language converter - https://phabricator.wikimedia.org/T98386#1338113 (10Nemo_bis) p:5Triage>3Normal [17:22:02] (03Merged) 10jenkins-bot: Filter lists by item count [extensions/Gather] - 10https://gerrit.wikimedia.org/r/210885 (https://phabricator.wikimedia.org/T97061) (owner: 10Gergő Tisza) [17:22:20] jdlrobson2: neat [17:23:30] 6Phabricator, 6operations, 7database: Add Story points (from Sprint Extension) to the phabricator data dump - https://phabricator.wikimedia.org/T100846#1338122 (10JAufrecht) Is there any transaction history for story points? E.g., if a story is changed from 8 points on March 2 to 13 points on March 3, I'd... [17:26:55] jdlrobson2: in hindsight, manual update on beta was a stupid idea [17:27:22] 10MediaWiki-User-blocking: Block message for account creation if central auth autocreation of an account fails on a local project because of an account creation blocked block - https://phabricator.wikimedia.org/T37170#1338128 (10Nemo_bis) 5Open>3stalled Is this superseded by T38939? Autocreation should neve... [17:27:30] I was assuming gather is only enabled on beta en [17:27:34] 10Datasets-General-or-Unknown, 5Patch-For-Review: Add GeoData to dumps - https://phabricator.wikimedia.org/T53225#1338132 (10MaxSem) It's for reusers. [17:27:47] 10MediaWiki-User-blocking, 10SUL-Finalization: Block message for account creation if central auth autocreation of an account fails on a local project because of an account creation blocked block - https://phabricator.wikimedia.org/T37170#1338133 (10Nemo_bis) [17:28:40] should have just included setting the initial count in the sql patch, probably [17:30:20] 10Gather, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned, 5Patch-For-Review, 7Schema-change: API: Allow filtering of collections - https://phabricator.wikimedia.org/T97061#1338136 (10Tgr) Should have been tagged as a schema change, duh. [17:30:39] 10MediaWiki-API, 10MediaWiki-File-management, 6Multimedia: This result was truncated because it would otherwise be larger than the limit of 12,582,912 bytes - https://phabricator.wikimedia.org/T101400#1338139 (10XZise) Here is a relatively simple request: http://commons.wikimedia.org/w/api.php?action=query&... [17:31:58] 10Wikimania-Hackathon-2015, 10Wikimedia-General-or-Unknown, 7Tracking: Steward, global sysop and SWMT tasks bugs (tracking) - https://phabricator.wikimedia.org/T43492#1338158 (10Nemo_bis) [17:31:59] 10MediaWiki-extensions-SpamBlacklist: Rename Spam blacklist to "Disallowed websites" - https://phabricator.wikimedia.org/T16719#1338155 (10Nemo_bis) 5Open>3declined a:3Nemo_bis Closing per Brion. Request specific to a very narrow usecase of one wiki. [17:32:05] (03PS1) 10Krinkle: board: Use 'ease' instead of 'linear' for transition [extensions/Flow] - 10https://gerrit.wikimedia.org/r/215938 [17:32:14] (03CR) 10Paladox: "@Brian Wolff I have removed the 8k now." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210407 (https://phabricator.wikimedia.org/T98694) (owner: 10Paladox) [17:32:24] 10MediaWiki-extensions-SpamBlacklist: Rename Spam blacklist to "Disallowed websites" - https://phabricator.wikimedia.org/T16719#1338162 (10Nemo_bis) [17:33:10] (03CR) 10Krinkle: [C: 031] git-review: configure 'origin' as the default remote [vagrant] - 10https://gerrit.wikimedia.org/r/146014 (https://bugzilla.wikimedia.org/57680) (owner: 10Ori.livneh) [17:33:28] 10MediaWiki-Internationalization: Make a multilingual wiki aware of localised names of its namespaces - https://phabricator.wikimedia.org/T43845#1338166 (10Nemo_bis) 5Open>3declined a:3Nemo_bis All the supposedly blocked bugs have been closed, looks like there is no demand for this any longer? [17:33:30] 10MediaWiki-Internationalization, 7Accessibility: Multilingual user page rewrite rules or redirections - https://phabricator.wikimedia.org/T22798#1338171 (10Nemo_bis) [17:33:32] 10MediaWiki-Special-pages: Option for circumventing automatic localized special-namespace as well as names for special pages - https://phabricator.wikimedia.org/T11040#1338170 (10Nemo_bis) [17:33:34] 10MediaWiki-Internationalization: Use user language for namespace names - https://phabricator.wikimedia.org/T12342#1338169 (10Nemo_bis) [17:35:03] (03CR) 10Jdlrobson: Remove jquery ui button dependency (031 comment) [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/212855 (https://phabricator.wikimedia.org/T92893) (owner: 10Jdlrobson) [17:35:12] (03PS2) 10Jdlrobson: Remove jquery.spinner dependency [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/212856 [17:35:17] (03PS2) 10Jdlrobson: Enable ApiSandbox on mobile [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/212857 [17:36:28] 7Design, 10MediaWiki-Interface: Move "View history" to dropdown menu - https://phabricator.wikimedia.org/T53529#1338178 (10Nemo_bis) 5Open>3declined a:3Nemo_bis It's not a specialised feature, it's the whole point of being a wiki. See WikiDesignPrinciples Incremental, Universal and (most of all) Observab... [17:36:41] 10MediaWiki-extensions-Translate: When deleting a translation page I get a blank page - https://phabricator.wikimedia.org/T100043#1338182 (10Nikerabbit) Can you give an exact time when you are seeing this next time? Maybe I can find something in the logs. [17:36:49] (03CR) 10Krinkle: "I have this locally (outside Vagrant) and works great. The only catch is that you need to "git remote rm origin" before "git review -s" in" [vagrant] - 10https://gerrit.wikimedia.org/r/146014 (https://bugzilla.wikimedia.org/57680) (owner: 10Ori.livneh) [17:38:14] 10Gather: Gather viewing broken - https://phabricator.wikimedia.org/T101349#1338185 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson False alarm. Not seeing this today. [17:39:55] (03CR) 10Krinkle: "Note this will use the class from the legacy shared.css stylesheet." (031 comment) [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/212856 (owner: 10Jdlrobson) [17:40:56] 10MediaWiki-extensions-TranslationNotifications, 5Patch-For-Review: <languages> should be - https://phabricator.wikimedia.org/T54157#1338193 (10Nemo_bis) The message itself seems pointless: https://translatewiki.net/wiki/MediaWiki:Translationnotifications-generic-languages/qqq I'd just kill the... [17:41:46] 10MediaWiki-History-or-Diffs, 10MediaWiki-Special-pages, 7Regression: Special:Contributions no longer shows contributions by name - problems listing contributions stored with user ID = 0 - https://phabricator.wikimedia.org/T36873#1338194 (10Nemo_bis) [17:42:19] 10Maps: Implement Tiles Storage - https://phabricator.wikimedia.org/T101320#1338198 (10MaxSem) [17:43:02] 10MediaWiki-extensions-CentralAuth: Accounts magically unattached despite being recently created - https://phabricator.wikimedia.org/T41996#1338200 (10Nemo_bis) [17:43:04] 10MediaWiki-extensions-CentralAuth, 7Testme: Phantom autocreated CentralAuth accounts on some Wikimedia wikis? - https://phabricator.wikimedia.org/T19032#1338199 (10Nemo_bis) [17:44:08] 10Gather, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned, 5Patch-For-Review, 7Schema-change: API: Allow filtering of collections - https://phabricator.wikimedia.org/T97061#1338203 (10Tgr) [17:46:10] (03CR) 10Krinkle: Remove jquery ui button dependency (031 comment) [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/212855 (https://phabricator.wikimedia.org/T92893) (owner: 10Jdlrobson) [17:46:57] Gosh. I update vagrant and now I have huge orange banners telling me "Warning: Cannot modify header information - headers already sent" in the middle of the page. [17:47:02] Progress, clearly. :-) [17:47:38] 10Gather, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned, 5Patch-For-Review, 7Schema-change: API: Allow filtering of collections - https://phabricator.wikimedia.org/T97061#1338206 (10Tgr) Added deploy instructions. If Gather gets used more widely, this will probably need an index on `gl_item_count`. As long a... [17:48:18] James_F: That's a cascading failure. It happens when code tries to echo content in PHP before MediaWiki starts output page. [17:48:30] 10Gather: Research - Is collections more useful than random? - https://phabricator.wikimedia.org/T101332#1338207 (10KHammerstein) [17:48:32] James_F: do you have CentralAuth enabled? [17:48:32] maybe a loose line break at the start of your localsetings? [17:48:36] Krinkle: You mean, after? [17:49:17] James_F: No, before. When you "echo" that defines the end of the http header, so php sends them. Then when mediawiki creates the html doctype etc. and starts another, it fails. [17:49:20] 6WMF-Design-Research: Testing onboarding flow for collections - https://phabricator.wikimedia.org/T101416#1338210 (10aripstra) 3NEW [17:49:32] tgr: No. apex, betafeatures, checkuser, codeeditor, echo, flow, gadgets, geshi, math, monobook, popups, visualeditor, wikihiero, wikimediaevents and zend. [17:49:48] That isn't a bug. It's a side effect of an actual bug. Look at view-source to see what is being out put before the doctype [17:49:53] 10MediaWiki-API, 6Mobile-Web: API mobileview "protection" sometimes returns object, sometimes returns empty array in JSON output - https://phabricator.wikimedia.org/T69054#1338217 (10Jdlrobson) So I guess this is actionable now? [17:49:59] (03CR) 10Aaron Schulz: [C: 032] language: Use item 'fallbackSequence' instead of duplicating logic [core] - 10https://gerrit.wikimedia.org/r/215225 (owner: 10Krinkle) [17:50:13] Krinkle: The orange bars appear part-way through the stream, after a bunch of content has already been output. [17:50:23] 10Gather: Research - Is collections more useful than random? - https://phabricator.wikimedia.org/T101332#1336063 (10KHammerstein) @JKatzWMF I just spoke with Abbey and Daisy about this. They argue that this would need both qualitative and quantitative, and that spending all those resources would take away from m... [17:50:26] Ah, right. [17:50:40] That mean something that isn't meidawiki outputpage tries to send http headers [17:50:43] that's weird [17:50:49] Yeah. [17:50:53] yeah, toggle extensions until you find the mole. [17:51:24] 6WMF-Design-Research: Testing onboarding flow for collections - https://phabricator.wikimedia.org/T101416#1338219 (10KHammerstein) [17:51:43] no need for that, the error message should have a stack trace pointing to the line which tried to set a header [17:51:54] 7Design, 10UI-Standardization, 6WMF-Design, 6Mobile-Web, 10OOjs-UI: OOjs UI and MediaWiki UI buttons are different sizes - https://phabricator.wikimedia.org/T91473#1338222 (10Jdlrobson) Where did we land with this? Will OOjs ui buttons be increasing in size? [17:52:29] No extension in the stack trace. [17:53:13] index.php -> MediaWiki.php -> MWExceptionHandler.php -> OutputPage.php -> WebResponse.php. [17:54:57] ha [17:54:57] (03CR) 10Bmansurov: [C: 04-1] "Looks good! A couple of things:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/210950 (https://phabricator.wikimedia.org/T95305) (owner: 10Florianschmidtwelzow) [17:55:18] James_F: Can you paste? [17:55:42] Krinkle: https://phabricator.wikimedia.org/P730 [17:56:10] 10MediaWiki-Configuration, 10MediaWiki-RfCs: Improving extension management - https://phabricator.wikimedia.org/T88596#1338230 (10MarkAHershberger) I wrote a request for help for the one issue I am most familiar with in Composer: https://github.com/composer/composer/issues/4109 I think this is the same issue... [17:56:43] James_F: Oh, this from doPostOutputShutdown() [17:56:57] so after the shutdown, another exception happens and it wants to create a new output page [17:57:08] Yeah, there are eight of these on the page at once. [17:57:19] ori: ^ [17:57:44] AaronSchulz: ^ [17:57:54] 10Wikimedia-Site-requests: Disable local file upload to all users on mr.wikipedia on 2015-06-08 - https://phabricator.wikimedia.org/T92633#1338232 (10tomasz) Thanks very much for taking care of this, @greg. [17:58:05] Hmm. [17:58:06] (03Merged) 10jenkins-bot: language: Use item 'fallbackSequence' instead of duplicating logic [core] - 10https://gerrit.wikimedia.org/r/215225 (owner: 10Krinkle) [17:58:06] 10MediaWiki-General-or-Unknown, 6Parsing-Team: Replace FastStringSearch - https://phabricator.wikimedia.org/T101418#1338240 (10faidon) 3NEW [17:58:16] Also " ***** GIT PULL failed in /vagrant/mediawiki/extensions/SyntaxHighlight_GeSHi for branch 'master' " on vagrant git-update, which is… interesting. [17:58:17] ori: ^ [17:58:46] 10MediaWiki-API, 10MediaWiki-File-management, 6Multimedia: This result was truncated because it would otherwise be larger than the limit of 12,582,912 bytes - https://phabricator.wikimedia.org/T101400#1338251 (10Tgr) Large metadata in API responses can be troublesome (T86611) but 500 is definitely not expec... [17:59:00] (03CR) 10Anomie: [C: 04-1] "Looking good, a few critiques left." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/215874 (https://phabricator.wikimedia.org/T69540) (owner: 10Marcoil) [17:59:51] James_F: that's normal if the repo is in a dirty state [18:00:02] James_F: What is the actual exception? [18:00:25] 7Design, 10UI-Standardization, 6WMF-Design, 6Mobile-Web, 10OOjs-UI: OOjs UI and MediaWiki UI buttons are different sizes - https://phabricator.wikimedia.org/T91473#1338253 (10Nirzar) We can match up the OOJS UI buttons to mediawiki buttons. whatever mediawiki buttons are. The patch for that got reverted... [18:00:27] the one it's failing to report to the screen [18:00:31] tgr: Sure, but it's on master with no changes. And also no, vagrant git-update cleanly auto-rebases dirty HEAD onto origin/master I think? [18:00:53] presumably the exception is still printed after that notice. [18:01:09] (I guess vagrant has notices on by default and print to html instead of just to log) [18:01:34] by dirty I mean uncommitted changes [18:02:11] 10Gather, 6Mobile-Web: Gather modules should not load on non-gather special pages - https://phabricator.wikimedia.org/T101284#1338255 (10Florian) a:3Florian [18:02:36] Aha. "[63a97b63] /wiki/Main_Page JobQueueError from line 714 of /vagrant/mediawiki/includes/jobqueue/JobQueueRedis.php: Redis server error: Could not insert 1 enqueue job(s)." [18:02:37] and you probably also get that error if it tries to auto-rebase and runs into a conflict, although I never tried that [18:02:52] 7Design, 10UI-Standardization, 6WMF-Design, 6Mobile-Web, 10OOjs-UI: OOjs UI and MediaWiki UI buttons are different sizes - https://phabricator.wikimedia.org/T91473#1338259 (10Nirzar) [18:03:48] Also " ***** GIT PULL failed in /vagrant/mediawiki/extensions/SyntaxHighlight_GeSHi for branch 'master' " on vagrant git-update, which is… interesting. [18:03:51] ^ MaxSem [18:04:17] ori: Found the bug for that one. [18:04:25] 10Wikimania-Hackathon-2015: Create and put editable schedule up at least 3 weeks in advance of the hackathon - https://phabricator.wikimedia.org/T101355#1338265 (10Rfarrand) Sounds good, I am in the process of getting it! [18:04:33] ori, James_F: I ain't no maintainer of it:P [18:04:46] ori: It was using ssh://gerrit.wm.org, not ssh://jforrester@gerrit.wm.org…; fixed now. [18:04:51] (03CR) 10Bmansurov: [C: 04-1] "Just a minor inline comment. Also, can we make the link .mw-ui-progressive and get rid of the square brackets?" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/213203 (https://phabricator.wikimedia.org/T55684) (owner: 10Florianschmidtwelzow) [18:05:13] but yeah, I might become one in the future:D [18:06:23] 10MediaWiki-extensions-ContentTranslation, 7JavaScript: TypeError: $trigger.data(...).$dialog is undefined - https://phabricator.wikimedia.org/T101421#1338280 (10He7d3r) 3NEW [18:07:06] (03CR) 10Aaron Schulz: [C: 032] Use HttpStatus::header instead of manually crafting header() [core] - 10https://gerrit.wikimedia.org/r/215034 (owner: 10Krinkle) [18:07:30] (03CR) 10Aaron Schulz: [C: 032] resourceloader: Add unit test for validateScriptFile() [core] - 10https://gerrit.wikimedia.org/r/215540 (owner: 10Krinkle) [18:07:35] 10MediaWiki-RfCs, 10Architecture, 10RESTBase, 10Traffic, and 6 others: RFC: Re-evaluate varnish-level request-restart behavior on 5xx - https://phabricator.wikimedia.org/T97206#1338292 (10BBlack) The current state of affairs is now this updated table: | cluster/layer | retry5xx | retry503 | text fe | 0 |... [18:08:12] 10MediaWiki-extensions-CentralNotice, 3Fundraising Sprint Lou Reed, 10Fundraising-Backlog: Few/no banners shown on 1 June? - https://phabricator.wikimedia.org/T101265#1338293 (10AndyRussG) [18:09:16] (03PS5) 10Jhernandez: WIP: Show related pages when editing 1 item collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/214320 (https://phabricator.wikimedia.org/T100634) [18:09:51] 10MediaWiki-Internationalization: Use user language for namespace names - https://phabricator.wikimedia.org/T12342#1338301 (10He7d3r) [18:09:53] 10MediaWiki-Internationalization, 7Accessibility: Multilingual user page rewrite rules or redirections - https://phabricator.wikimedia.org/T22798#1338297 (10He7d3r) [18:09:55] 10MediaWiki-Internationalization: Make a multilingual wiki aware of localised names of its namespaces - https://phabricator.wikimedia.org/T43845#1338298 (10He7d3r) [18:09:57] 10MediaWiki-User-preferences: Name spaces and Local wiki - https://phabricator.wikimedia.org/T12624#1338300 (10He7d3r) [18:09:59] 10MediaWiki-Internationalization: While Using English interface, Namespace in dropdown must use English equivalents. - https://phabricator.wikimedia.org/T36439#1338299 (10He7d3r) [18:10:15] (03CR) 10Krinkle: [C: 04-1] Deprecated $wgEnableParserCache (031 comment) [core] - 10https://gerrit.wikimedia.org/r/212199 (owner: 10Aaron Schulz) [18:10:17] (03CR) 10jenkins-bot: [V: 04-1] WIP: Show related pages when editing 1 item collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/214320 (https://phabricator.wikimedia.org/T100634) (owner: 10Jhernandez) [18:12:02] (03CR) 10Krinkle: [C: 031] Removed broken "visible" flag for profiler text output [core] - 10https://gerrit.wikimedia.org/r/215563 (owner: 10Aaron Schulz) [18:13:08] 10UI-Standardization, 6Mobile-Web, 10OOjs-UI, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned: oojs ui icon name conflict ('cancel') on overlay close buttons on mobile beta/alpha - https://phabricator.wikimedia.org/T98518#1338309 (10bmansurov) a:3bmansurov [18:13:09] (03CR) 10Chad: Deprecated $wgEnableParserCache (031 comment) [core] - 10https://gerrit.wikimedia.org/r/212199 (owner: 10Aaron Schulz) [18:13:12] 10Wikipedia-Android-App, 3Mobile-App-Sprint-58-Android, 3Mobile-App-Sprint-58-iOS, 5Patch-For-Review: Link App FAQ from the More menu - https://phabricator.wikimedia.org/T99783#1338308 (10Moushira) [18:13:41] (03PS1) 10Florianschmidtwelzow: Don't load Gather on all pages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/215948 (https://phabricator.wikimedia.org/T101284) [18:14:18] (03PS3) 10Chad: Deprecated $wgEnableParserCache [core] - 10https://gerrit.wikimedia.org/r/212199 (owner: 10Aaron Schulz) [18:14:46] (03PS6) 10Jhernandez: WIP: Show related pages when editing 1 item collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/214320 (https://phabricator.wikimedia.org/T100634) [18:15:16] (03CR) 10Aaron Schulz: [C: 032] resourceloader: Remove redundant getModifiedTime implementations [core] - 10https://gerrit.wikimedia.org/r/215381 (https://phabricator.wikimedia.org/T94074) (owner: 10Krinkle) [18:15:28] (03CR) 10Chad: "PS3 only sets $wgParserCacheType if $wgEnableParserCache is explicitly set to false. This avoids having to change the default to null (my " [core] - 10https://gerrit.wikimedia.org/r/212199 (owner: 10Aaron Schulz) [18:15:31] Krinkle: ^ [18:15:59] (03CR) 10Krinkle: Fixed race condition in MessageCache::replace (032 comments) [core] - 10https://gerrit.wikimedia.org/r/212242 (owner: 10Aaron Schulz) [18:16:11] (03Merged) 10jenkins-bot: resourceloader: Add unit test for validateScriptFile() [core] - 10https://gerrit.wikimedia.org/r/215540 (owner: 10Krinkle) [18:16:29] 10MediaWiki-extensions-VipsScaler, 6Multimedia, 7Performance: Generate JPG thumbnails with ImageMagick + mozjpeg instead of IM alone - https://phabricator.wikimedia.org/T70145#1338314 (10Nemo_bis) A closed task is not a very good way to track an open todo. :) I thought that RfC (or another) was more generic... [18:16:32] ostriches: Oh hey you. [18:16:35] 10Gather, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned: Introduce a random collection - https://phabricator.wikimedia.org/T101422#1338315 (10Jdlrobson) 3NEW [18:16:39] I thought you were german [18:16:41] 10Gather, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned: Introduce a random collection - https://phabricator.wikimedia.org/T101422#1338323 (10Jdlrobson) a:3Jdlrobson [18:16:47] Krinkle: lol wut? [18:16:52] Your nick [18:16:55] it sounds German [18:17:30] (03PS2) 10Jdlrobson: The random collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/215235 (https://phabricator.wikimedia.org/T101422) [18:17:32] (03PS1) 10Jdlrobson: Hygiene: Refactor how we generate collections from api [extensions/Gather] - 10https://gerrit.wikimedia.org/r/215950 [18:17:36] Krinkle: I was referring to the flightless bird. [18:17:37] :p [18:17:59] * Krinkle looks up [18:18:02] ostriches, so that's your nick [18:18:07] Wow, ostrich is a word [18:18:13] How do Americans even pronounce that [18:18:17] * AaronSchulz lines up the patches j/k [18:18:38] Krinkle: os (as in boss) [18:18:47] trich as in "rich" with a T in front [18:18:50] (03CR) 10Legoktm: "Just because it generates invalid html doesn't mean it should be removed. It's a developer feature, so if devs don't want invalid html, th" [core] - 10https://gerrit.wikimedia.org/r/215563 (owner: 10Aaron Schulz) [18:18:56] osstridge [18:19:01] Basically [18:19:02] Yeah [18:19:06] According to Mac speeach [18:19:28] (03CR) 10jenkins-bot: [V: 04-1] The random collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/215235 (https://phabricator.wikimedia.org/T101422) (owner: 10Jdlrobson) [18:19:54] Krinkle, ostrich is a word in traditional English as well :p [18:20:00] ostrich in German is Strauß [18:20:10] one of the words using the special char [18:20:11] In Germanic languages, it is natural spelling for something sounding like òah (short o) striggh [18:20:25] And I'd expect English to pronounce it oustrick [18:20:57] Yeah, -ch is tricky. [18:21:12] 10MediaWiki-API, 10MediaWiki-File-management, 6Multimedia: This result was truncated because it would otherwise be larger than the limit of 12,582,912 bytes - https://phabricator.wikimedia.org/T101400#1338334 (10Anomie) >>! In T101400#1338251, @Tgr wrote: > Also, can you get the response text (body) for the... [18:22:05] "estridges" [18:22:36] /nick melissa_etheridge [18:23:00] 10Wikipedia-Android-App, 3Mobile-App-Sprint-58-Android, 3Mobile-App-Sprint-58-iOS, 5Patch-For-Review: Link App FAQ from the More menu - https://phabricator.wikimedia.org/T99783#1338336 (10Mholloway) Noted the change, will update. [18:23:05] (03Merged) 10jenkins-bot: resourceloader: Remove redundant getModifiedTime implementations [core] - 10https://gerrit.wikimedia.org/r/215381 (https://phabricator.wikimedia.org/T94074) (owner: 10Krinkle) [18:23:06] All furnish'd, all in arms; All plum'd, like estridges that with the wind ; Baited, like eagles having lately bath'd. [18:23:15] William Shakespeare, Henry IV [18:23:16] (03CR) 10Bgerstle: "forgot to replace all occurrences of ZeroStateChanged notification" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/215812 (owner: 10Mhurd) [18:23:18] (03PS4) 10Krinkle: Deprecate $wgEnableParserCache [core] - 10https://gerrit.wikimedia.org/r/212199 (owner: 10Aaron Schulz) [18:23:29] ostriches: +1? [18:24:06] why do you keep changing nicknames by the way, ostriches? [18:24:22] 10Gather, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned, 5Patch-For-Review, 7Schema-change: API: Allow filtering of collections - https://phabricator.wikimedia.org/T97061#1338344 (10Jdlrobson) @tgr who is responsible for making sure those instructions get followed during deploy? [18:24:23] wasn't AaronSchulz doing that as well? [18:24:30] Krenair: This is a new thing [18:24:34] I think I'm gonna keep this one [18:24:35] 10Gather: No way to query API for 3 most recent public collections from user x - https://phabricator.wikimedia.org/T98503#1338347 (10Jdlrobson) [18:24:37] 10Gather, 6Mobile-Web, 3Mobile-Web-Design, 3Mobile-Web-Sprint-49-W___________: Add a new public collection feed view - https://phabricator.wikimedia.org/T96222#1338346 (10Jdlrobson) [18:24:39] 10Gather, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned, 5Patch-For-Review, 7Schema-change: API: Allow filtering of collections - https://phabricator.wikimedia.org/T97061#1338345 (10Jdlrobson) 5Open>3Resolved [18:24:44] reminds me of Katie :p [18:24:53] 3App-Process-Improvement: Proto-roadmap for Q1 Readership planning - https://phabricator.wikimedia.org/T101423#1338350 (10KLans_WMF) 3NEW [18:24:59] (03PS1) 10Bmansurov: Fix oojs ui icon naming conflict [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/215953 (https://phabricator.wikimedia.org/T98518) [18:25:09] (03CR) 10Krinkle: [C: 032] Deprecate $wgEnableParserCache [core] - 10https://gerrit.wikimedia.org/r/212199 (owner: 10Aaron Schulz) [18:25:35] 3App-Process-Improvement: Explore Kanban - https://phabricator.wikimedia.org/T97652#1338364 (10KLans_WMF) Kanban chat w/Readership scheduled for 06/08 [18:25:59] 3App-Process-Improvement: Proto-roadmap for Q1 Readership planning - https://phabricator.wikimedia.org/T101423#1338365 (10Fjalapeno) [18:26:02] (03CR) 10Chad: [C: 031] "PS4 was just a minor rel-notes fix, ok by me." [core] - 10https://gerrit.wikimedia.org/r/212199 (owner: 10Aaron Schulz) [18:26:20] (03CR) 10Jdlrobson: [C: 032] "merging from the commandline \o/" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/215948 (https://phabricator.wikimedia.org/T101284) (owner: 10Florianschmidtwelzow) [18:27:36] 10MediaWiki-Internationalization: Make a multilingual wiki aware of localised names of its namespaces - https://phabricator.wikimedia.org/T43845#1338368 (10daniel) @He7d3r considering T12342 was declined in 2007, and did not discuss multilingual wikis as far as I can tell, perhaps it makes sense to discuss this... [18:27:53] (03PS1) 10Kji: Implemented optional inclusion of title icons when viewing hierarchies. Placement of title icons when numbering is enabled may need to change. [extensions/HierarchyBuilder] - 10https://gerrit.wikimedia.org/r/215954 [18:28:25] (03PS7) 10Jhernandez: Show related pages when editing 1 to 3 items collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/214320 (https://phabricator.wikimedia.org/T100634) [18:28:38] 10Shop-Theme: [Mobile] Text looks too big on mobile. - https://phabricator.wikimedia.org/T97318#1338380 (10HuiZSF) Added rule to solve this problem: ``` @media (max-width: 767px) { /*97318*/ .intro { font: bold 1.4em/1.2em "Georgia",serif; } } ``` [18:30:26] 6Phabricator: Shrink memes - https://phabricator.wikimedia.org/T99758#1338382 (10Dzahn) testing audio {F174592} [18:30:54] ostriches: Krinkle: https://phabricator.wikimedia.org/T99758#1338382 [18:31:08] (03CR) 10Jdlrobson: [C: 04-1] "The button has now disappeared in stable. Please update the css rule (whilst there would be great if you could stop it using a legacy png." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/215953 (https://phabricator.wikimedia.org/T98518) (owner: 10Bmansurov) [18:32:02] mutante: nice :D - sounds so weird to me. It's like writing "中文中文 "and telling me it's pronounced "Bob". [18:32:05] ostriches: ^ [18:32:29] lol [18:32:56] But I do love this (for me) new word for the strauss animal [18:32:56] all i did was drag/drop an .ogx from wiktionary :) [18:33:13] (03PS4) 10Jdlrobson: Hygiene: Separate watchstar from content overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/212585 [18:33:31] (03Merged) 10jenkins-bot: Deprecate $wgEnableParserCache [core] - 10https://gerrit.wikimedia.org/r/212199 (owner: 10Aaron Schulz) [18:33:33] (03Merged) 10jenkins-bot: Don't load Gather on all pages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/215948 (https://phabricator.wikimedia.org/T101284) (owner: 10Florianschmidtwelzow) [18:34:09] 10MediaWiki-ResourceLoader, 7JavaScript: mw.loader.store should not occupy all of localStorage - https://phabricator.wikimedia.org/T66721#1338397 (10Mattflaschen) Yesterday, we talked on IRC about a few possibilities: * Blacklisting Firefox (only seems to be an issue due to how it calculates quotas) * Blackli... [18:36:14] 3Mobile-Web-Sprint-48-Voyage-of-the-Damned, 5Patch-For-Review: Show related articles when user is editing a collection - https://phabricator.wikimedia.org/T100634#1338400 (10Jhernandez) > Change 214320 had a related patch set uploaded (by Jhernandez): > Show related pages when editing 1 to 3 items collections... [18:36:21] 10MediaWiki-General-or-Unknown: Bots must not write to unattended user talk pages. - https://phabricator.wikimedia.org/T101360#1338401 (10Purodha) Please do not mix the reporter of the problem with any of the many users that in various ways may suffer from it, especially not by picking some specifics of any spec... [18:36:25] (03PS1) 10Ori.livneh: Don't try to smart_delete() null [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/215956 (https://phabricator.wikimedia.org/T101395) [18:37:20] 3Mobile-Web-Sprint-48-Voyage-of-the-Damned, 5Patch-For-Review: Show related articles when user is editing a collection - https://phabricator.wikimedia.org/T100634#1317046 (10Jhernandez) Sorry about the length of the patch, there's a few moving parts and our code is fairly verbose. [18:37:42] 10Gather, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned, 5Patch-For-Review: Show related articles when user is editing a collection - https://phabricator.wikimedia.org/T100634#1338405 (10Jhernandez) [18:38:07] (03CR) 10BBlack: [C: 031] Don't try to smart_delete() null [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/215956 (https://phabricator.wikimedia.org/T101395) (owner: 10Ori.livneh) [18:38:24] (03PS4) 10Jdlrobson: Delegate watchstar loading to Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/210874 (https://phabricator.wikimedia.org/T98519) [18:38:26] (03CR) 10jenkins-bot: [V: 04-1] Delegate watchstar loading to Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/210874 (https://phabricator.wikimedia.org/T98519) (owner: 10Jdlrobson) [18:39:51] (03PS5) 10Jdlrobson: Hygiene: Separate watchstar from content overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/212585 [18:39:53] (03PS5) 10Jdlrobson: Delegate watchstar loading to Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/210874 (https://phabricator.wikimedia.org/T98519) [18:40:13] (03CR) 10Anomie: [C: 031] "Looks sane. Haven't tested." [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/215956 (https://phabricator.wikimedia.org/T101395) (owner: 10Ori.livneh) [18:40:16] (03PS6) 10Krinkle: resourceloader: Replace ResourceLoaderWikiModule mtime queries with content hash [core] - 10https://gerrit.wikimedia.org/r/215857 [18:40:45] (03CR) 10Krinkle: "Rebased to resolve conflict with (merged) https://gerrit.wikimedia.org/r/215381" [core] - 10https://gerrit.wikimedia.org/r/215857 (owner: 10Krinkle) [18:42:34] (03CR) 10Ori.livneh: [C: 032] Don't try to smart_delete() null [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/215956 (https://phabricator.wikimedia.org/T101395) (owner: 10Ori.livneh) [18:42:50] (03Merged) 10jenkins-bot: Don't try to smart_delete() null [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/215956 (https://phabricator.wikimedia.org/T101395) (owner: 10Ori.livneh) [18:43:51] (03PS3) 10Jdlrobson: Tooling: Setup karma:main job [extensions/Gather] - 10https://gerrit.wikimedia.org/r/212007 [18:44:47] (03CR) 10Krinkle: Don't try to smart_delete() null (031 comment) [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/215956 (https://phabricator.wikimedia.org/T101395) (owner: 10Ori.livneh) [18:46:40] (03CR) 10Krinkle: "It doesn't work like that. Run karma from mediawiki-core, not the other way around. We don't add phpunit bootstrapping in MediaWiki extens" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/212007 (owner: 10Jdlrobson) [18:49:14] (03CR) 10Krinkle: "Aren't there plenty of other ways to render the profiler data already, though? How does this add value?" [core] - 10https://gerrit.wikimedia.org/r/215563 (owner: 10Aaron Schulz) [18:49:23] (03CR) 10Ori.livneh: Don't try to smart_delete() null (031 comment) [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/215956 (https://phabricator.wikimedia.org/T101395) (owner: 10Ori.livneh) [18:51:20] (03CR) 10Krinkle: Don't try to smart_delete() null (031 comment) [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/215956 (https://phabricator.wikimedia.org/T101395) (owner: 10Ori.livneh) [18:53:17] (03CR) 10Legoktm: [C: 04-1] "This is going to break GlobalCssJs...why does isKnownEmpty() need to actually get the page content? Isn't page_len sufficient?" [core] - 10https://gerrit.wikimedia.org/r/215857 (owner: 10Krinkle) [18:53:39] 10Gather, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned, 5Patch-For-Review, 7Schema-change: API: Allow filtering of collections - https://phabricator.wikimedia.org/T97061#1338432 (10Tgr) >>! In T97061#1338344, @Jdlrobson wrote: > @tgr who is responsible for making sure those instructions get followed during d... [18:55:36] (03CR) 10Anomie: [C: 04-1] API: Give block details along with errors (031 comment) [core] - 10https://gerrit.wikimedia.org/r/209974 (https://phabricator.wikimedia.org/T95072) (owner: 10Alex Monk) [18:56:24] 10MediaWiki-General-or-Unknown: Google ignores canonical url in search results (index.pho?curid=, index.php?title=, etc.) - https://phabricator.wikimedia.org/T48424#1338446 (10Krinkle) [18:56:34] (03CR) 10Kevstoy: "Going to abandon this change as there is a newer patch that incorporates this change as well as others. So this change will be present in " [extensions/JSBreadCrumbs] - 10https://gerrit.wikimedia.org/r/192190 (owner: 10Cicalese) [18:56:56] 10Gather, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned, 5Patch-For-Review, 7Schema-change: API: Allow filtering of collections - https://phabricator.wikimedia.org/T97061#1338452 (10Tgr) >>! In T97061#1338432, @Tgr wrote: > Although if that's unwanted, they could be done at any time before/after the deploy -... [18:57:04] (03Abandoned) 10Kevstoy: added support for SemanticTitle (does not require SemanticTitle to be present) [extensions/JSBreadCrumbs] - 10https://gerrit.wikimedia.org/r/192190 (owner: 10Cicalese) [18:58:35] 10MediaWiki-General-or-Unknown: Google ignores canonical url in search results (index.pho?curid=, index.php?title=, etc.) - https://phabricator.wikimedia.org/T48424#1338455 (10Krinkle) Updating to also mention `title` query parameter. https://www.google.co.uk/search?q=navigation+popups 1. Wikipedia:Tools/Navig... [19:00:41] 10Wikipedia-Android-App, 3Mobile-App-Sprint-58-Android, 5Patch-For-Review: Confirm dialog before mass-refresh of saved pages is not necessary - https://phabricator.wikimedia.org/T69057#1338462 (10Mholloway) I've been looking into it this morning. I can get the refresh process to stop in its tracks, but some... [19:01:02] (03PS1) 10Filippo Giunchedi: new debian release [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/215957 [19:01:04] (03CR) 10Umherirrender: [C: 032] Fix i18n setting [extensions/ConfirmAccount] (REL1_23) - 10https://gerrit.wikimedia.org/r/215774 (https://phabricator.wikimedia.org/T73300) (owner: 10Paladox) [19:01:13] (03PS1) 10Kevstoy: Added capability to support additional skins. Added capability for sidebar view vice topbar view Added support for SemanticTitle (does not require SemanticTitle to be present) [extensions/JSBreadCrumbs] - 10https://gerrit.wikimedia.org/r/215958 [19:01:14] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-cxserver, 5ContentTranslation-Release5, 3LE-Sprint-87: MT Api - provide an identification mechanism to allow requests only from a valid MW context - https://phabricator.wikimedia.org/T97113#1338472 (10csteipp) Gwicke and I talked about impleme... [19:01:19] (03Merged) 10jenkins-bot: Fix i18n setting [extensions/ConfirmAccount] (REL1_23) - 10https://gerrit.wikimedia.org/r/215774 (https://phabricator.wikimedia.org/T73300) (owner: 10Paladox) [19:01:41] 10MediaWiki-extensions-DonationInterface, 3Fundraising Sprint Kraftwerk, 3Fundraising Sprint Lou Reed, 10Fundraising Tech Backlog: Revoke ActiveMQ read permissions for payments cluster - https://phabricator.wikimedia.org/T92923#1338479 (10Jgreen) I took a very quick look at this and afaict this requires a... [19:01:52] (03CR) 10Filippo Giunchedi: [C: 032 V: 032] new debian release [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/215957 (owner: 10Filippo Giunchedi) [19:01:57] (03CR) 10Umherirrender: [C: 032] Fix i18n setting [extensions/ConfirmAccount] (REL1_24) - 10https://gerrit.wikimedia.org/r/215773 (https://phabricator.wikimedia.org/T73300) (owner: 10Paladox) [19:02:08] (03Merged) 10jenkins-bot: Fix i18n setting [extensions/ConfirmAccount] (REL1_24) - 10https://gerrit.wikimedia.org/r/215773 (https://phabricator.wikimedia.org/T73300) (owner: 10Paladox) [19:02:16] (03CR) 10Kevstoy: [C: 031 V: 031] "Submitting +1 for our Review Process." [extensions/JSBreadCrumbs] - 10https://gerrit.wikimedia.org/r/215958 (owner: 10Kevstoy) [19:02:50] 10MediaWiki-Vagrant: Error: invalid byte sequence in US-ASCII at /tmp/vagrant-puppet-5/modules-0/hhvm/manifests/init.pp:1 on node mediawiki-vagrant.dev - https://phabricator.wikimedia.org/T86282#1338485 (10Tgr) I still get this every once in a while (maybe one in five times I install a box from scratch?). Not co... [19:03:03] (03CR) 10Legoktm: "Because I don't have to view the source of the page to see the profiling data, I can just scroll down a bit more." [core] - 10https://gerrit.wikimedia.org/r/215563 (owner: 10Aaron Schulz) [19:03:23] (03PS1) 10Mattflaschen: Handle no pageids response field in MessagePoster factory [core] - 10https://gerrit.wikimedia.org/r/215959 [19:04:16] (03CR) 10Krinkle: "It's not about being enough. It's about being stable and not requiring estimation techniques when measuring the actual content eliminates " [core] - 10https://gerrit.wikimedia.org/r/215857 (owner: 10Krinkle) [19:04:32] 10MediaWiki-Configuration: Extension registration: GroupPermissions seems to only accept one sub-parameter - https://phabricator.wikimedia.org/T98347#1338488 (10Paladox) 5stalled>3Open p:5Triage>3Unbreak! [19:04:33] (03PS4) 10Jdlrobson: Allow view to be the template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/208137 (https://phabricator.wikimedia.org/T97663) [19:05:04] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-59-iOS: Standardize image fetch/cache/fallback logic - https://phabricator.wikimedia.org/T95350#1338490 (10BGerstle-WMF) consider this cookie licked 😜 [19:05:18] legoktm: isKnownEmpty() is called in OutputPage, but getVersionHash is as well (for the url) [19:05:33] 10MediaWiki-extensions-DonationInterface, 3Fundraising Sprint Kraftwerk, 3Fundraising Sprint Lou Reed, 10Fundraising Tech Backlog: Revoke ActiveMQ read permissions for payments cluster - https://phabricator.wikimedia.org/T92923#1338491 (10awight) OK great news, well great that it's possible at all. How sh... [19:05:39] and when the rest of the stack lands, it will retrieve the content for the version hash, so might as well re-use it in isKnownEmpty. [19:06:07] Krinkle: I'm concerned about fetching the page text for 5-6 pages on every single page hit [19:06:19] (03CR) 10jenkins-bot: [V: 04-1] Allow view to be the template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/208137 (https://phabricator.wikimedia.org/T97663) (owner: 10Jdlrobson) [19:06:23] 10MassMessage: MassMessage mail takes a long time to be fully performed - https://phabricator.wikimedia.org/T101427#1338497 (10Romaine) 3NEW [19:06:28] (03PS2) 10Mholloway: Add link to Wikimedia Apps FAQ to preferences menu. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/215363 (https://phabricator.wikimedia.org/T99783) [19:06:39] legoktm: I am as well. We'll figure it out [19:06:51] Note that it's not that different from fetching messages and transclusion [19:07:05] messages are cached differently [19:08:12] (03PS5) 10Jdlrobson: Allow view to be the template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/208137 (https://phabricator.wikimedia.org/T97663) [19:08:34] (03PS6) 10Jdlrobson: Allow view to be the template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/208137 (https://phabricator.wikimedia.org/T97663) [19:08:40] 6Search-and-Discovery: Metrics Meeting presentation on Wikipedia Search - https://phabricator.wikimedia.org/T101183#1338506 (10Tfinc) @Deskana, k. get Sarah to put something on the calendar for Monday then [19:09:03] 10MediaWiki-Configuration: Extension registration: GroupPermissions seems to only accept one sub-parameter - https://phabricator.wikimedia.org/T98347#1338507 (10Paladox) To reproduce Download this patch https://gerrit.wikimedia.org/r/#/c/208523 patch number 10 Reason 10 because I removed group permission and... [19:09:09] (03PS12) 10Jdlrobson: Hygiene: Make PageList take an array of pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203266 (https://phabricator.wikimedia.org/T97592) [19:09:24] (03CR) 10Jdlrobson: "Ignore above I was playing with git review ssh api" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203266 (https://phabricator.wikimedia.org/T97592) (owner: 10Jdlrobson) [19:10:22] 10MediaWiki-General-or-Unknown: Stale pages after saved edit - https://phabricator.wikimedia.org/T101224#1338512 (10TheDJ) p:5Triage>3Normal [19:11:37] 10MediaWiki-General-or-Unknown, 7Regression: Stale pages after saved edit - https://phabricator.wikimedia.org/T101224#1332967 (10TheDJ) [19:12:00] 6Research-and-Data: Spain recurring fundraising test - https://phabricator.wikimedia.org/T99199#1338517 (10ggellerman) 5Open>3Invalid [19:12:14] 10MassMessage: MassMessage mail takes a long time to be fully performed - https://phabricator.wikimedia.org/T101427#1338520 (10Sitic) Same thing happend two days ago on dewiki as well, it took 29 hours to deliver 280 messages: https://de.wikipedia.org/wiki/Wikipedia_Diskussion:Bots#Benutzer:MediaWiki_message_del... [19:13:19] 10MediaWiki-API, 7JavaScript: MessagePoster should support cross-wiki posting - https://phabricator.wikimedia.org/T101428#1338521 (10Mattflaschen) 3NEW [19:13:37] 6Research-and-Data: Fundraising "wikigrok" style data question - https://phabricator.wikimedia.org/T99186#1338528 (10ellery) There are too few recurring payments in this test to detect a difference in recurring donations rates. The rate at which people opt into recurring payments may be to low to be able able to... [19:13:41] 10MediaWiki-API, 7JavaScript: WikitextMessagePoster should support cross-wiki posting - https://phabricator.wikimedia.org/T101429#1338529 (10Mattflaschen) 3NEW [19:14:26] (03PS29) 10Paladox: Add extension.json, empty PHP entry point [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/208523 (https://phabricator.wikimedia.org/T100425) [19:16:19] (03PS8) 10Paladox: Convert to globals and add composer support [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/190027 (https://phabricator.wikimedia.org/T86476) [19:18:00] 10MediaWiki-General-or-Unknown, 7Documentation: replace 537 subpages of Manual:Hooks/ with generated doc - https://phabricator.wikimedia.org/T93043#1338546 (10Ciencia_Al_Poder) It's good if we can provide automatic documentation on wiki pages. But I'd like to also have the ability to expand such pages with exa... [19:19:51] 10MassMessage: Bots must not write to unattended user talk pages. - https://phabricator.wikimedia.org/T101360#1338547 (10Legoktm) [19:21:28] 6Research-and-Data: Quality analysis for anonymous mobile editors - https://phabricator.wikimedia.org/T99188#1338551 (10Halfak) [19:22:53] (03PS9) 10Paladox: Convert to globals and add composer support [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/190027 (https://phabricator.wikimedia.org/T86476) [19:23:45] (03CR) 10Paladox: "@Legoktm please review to see if this works now please." [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/190027 (https://phabricator.wikimedia.org/T86476) (owner: 10Paladox) [19:24:10] 10Continuous-Integration-Config: Jenkins check for vulnerable libraries in all node.js repos - https://phabricator.wikimedia.org/T96078#1338553 (10csteipp) And for the record, this is for running a check on our node.js services, as opposed to checking composer. That's another task. :) I've heard that we don't c... [19:24:18] 10MassMessage: Bots must not write to unattended user talk pages. - https://phabricator.wikimedia.org/T101360#1338555 (10Legoktm) 5Open>3Invalid a:3Legoktm > It is not even readable on the page. Yes it is, you just need to scroll down a little further because someone added a bunch of empty lines to the pa... [19:24:24] 10MediaWiki-Change-tagging, 10MediaWiki-RfCs, 5Patch-For-Review: Automatically tag edits that make a redirect, that converts a redirected page to a normal page, moves across namespaces and others - https://phabricator.wikimedia.org/T73236#1338558 (10Ciencia_Al_Poder) [[ https://gerrit.wikimedia.org/r/#/c/194... [19:24:28] 6Research-and-Data: [Q2] Measuring quality/productivity - https://phabricator.wikimedia.org/T99172#1338559 (10Halfak) Substantial progress at the hackathon thanks to Ansgar. We worked out some methods for weighting contributions to pages that don't have enough follow-up revisions to evaluate persistence. [19:25:15] (03PS10) 10Paladox: Convert to globals and add composer support [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/190027 (https://phabricator.wikimedia.org/T86476) [19:25:52] 6Research-and-Data: [mid] Wikimedia dark traffic - https://phabricator.wikimedia.org/T99174#1338563 (10Halfak) I just got a push from Joe @ CrossRef about this. How close are we to being able to make this change? [19:26:15] (03CR) 10Paladox: "https://phabricator.wikimedia.org/T67188" [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/190027 (https://phabricator.wikimedia.org/T86476) (owner: 10Paladox) [19:26:17] (03PS3) 10Ferdbold: Add ability to swap between bar, area and line charts within VE [extensions/Graph] - 10https://gerrit.wikimedia.org/r/215531 (https://phabricator.wikimedia.org/T99939) [19:26:19] (03PS2) 10Ferdbold: Add basic edition of Vega graphs within VisualEditor [extensions/Graph] - 10https://gerrit.wikimedia.org/r/215669 (https://phabricator.wikimedia.org/T99937) [19:28:22] (03CR) 10Anomie: "> Generally it is preferred for the actual provision of identities to be separate from the authentication workflow. Is there a way to sepa" [core] - 10https://gerrit.wikimedia.org/r/195297 (https://phabricator.wikimedia.org/T91699) (owner: 10Anomie) [19:29:06] !e CreatePage [19:29:06] https://www.mediawiki.org/wiki/Extension:CreatePage [19:29:10] 10MediaWiki-Configuration, 10MediaWiki-RfCs: Improving extension management - https://phabricator.wikimedia.org/T88596#1338568 (10mwjames) > Composer is great, perfect and awesome as a library management tool that allows freezing dependencies associated with a deployment. It is not however a general purpose pl... [19:30:23] 6Research-and-Data: Fundraising April 2015 repeat test analysis - https://phabricator.wikimedia.org/T99185#1338570 (10ggellerman) Closing this task. If new work associated with this issue comes up, let's open a new task for it. [19:31:20] 10MediaWiki-extensions-ConfirmAccount, 7I18n, 5Patch-For-Review: Message strings from i18n files are no longer showing in Special:AllMessages with MW 1.23.3 - https://phabricator.wikimedia.org/T73300#769921 (10Kghbln) Great. Thanks a ton! [19:33:06] 6Research-and-Data: Fundraising "wikigrok" style data question - https://phabricator.wikimedia.org/T99186#1338578 (10ggellerman) a:3ellery [19:33:07] (03PS4) 10Ferdbold: Add ability to swap between bar, area and line charts within VE [extensions/Graph] - 10https://gerrit.wikimedia.org/r/215531 (https://phabricator.wikimedia.org/T99939) [19:33:09] (03PS3) 10Ferdbold: Add basic edition of Vega graphs within VisualEditor [extensions/Graph] - 10https://gerrit.wikimedia.org/r/215669 (https://phabricator.wikimedia.org/T99937) [19:33:19] 6Research-and-Data: Fundraising "wikigrok" style data question - https://phabricator.wikimedia.org/T99186#1338581 (10ellery) The analytics team and Ori have built a system called EventLogging which lets you log arbitrary ui interactions on MediaWiki. It is quite easy to set up and the data we need gets saved to... [19:33:38] 10Continuous-Integration-Config: Jenkins check for vulnerable libraries in all node.js repos - https://phabricator.wikimedia.org/T96078#1338582 (10mobrovac) >>! In T96078#1338553, @csteipp wrote: > I've heard that we don't currently manage services in our CI infrastructure (although it looks like parsoid, and ma... [19:34:56] 6Phabricator, 6operations: Moving procurement from RT to Phabricator - https://phabricator.wikimedia.org/T93760#1338589 (10RobH) p:5High>3Normal [19:35:39] 6Research-and-Data: Quality analysis for anonymous mobile editors - https://phabricator.wikimedia.org/T99188#1338591 (10ggellerman) a:3Halfak [19:37:54] 6Research-and-Data: Fundraising add notebooks to google drive folder - https://phabricator.wikimedia.org/T99192#1338597 (10ellery) a:3ellery [19:39:47] 10MediaWiki-Special-pages, 7I18n: Chinese dropdown value strings show up on Protection page even though user prefers English - https://phabricator.wikimedia.org/T101225#1338602 (10Umherirrender) The drop down values are in content language because there are going into log and page history as written there. To... [19:40:11] 6Research-and-Data: Behavioral Automata Classifier - https://phabricator.wikimedia.org/T99050#1338603 (10ellery) 5Open>3Invalid [19:40:47] (03CR) 10Paladox: "Thanks." [extensions/ConfirmAccount] (REL1_23) - 10https://gerrit.wikimedia.org/r/215774 (https://phabricator.wikimedia.org/T73300) (owner: 10Paladox) [19:40:57] 10MediaWiki-extensions-AbuseFilter: Maximum nesting level reached in AbuseFilter - https://phabricator.wikimedia.org/T101431#1338605 (10UltrasonicNXT) 3NEW [19:41:12] 6Research-and-Data: Identifying automata - https://phabricator.wikimedia.org/T99189#1338612 (10DarTar) add to a new project [19:41:20] 10MediaWiki-extensions-ConfirmAccount, 7I18n, 5Patch-For-Review: Message strings from i18n files are no longer showing in Special:AllMessages with MW 1.23.3 - https://phabricator.wikimedia.org/T73300#1338613 (10Paladox) Ok. [19:41:30] 6Research-and-Data: Fundraising recurring estimate fiscal year 2015 - 2016 - https://phabricator.wikimedia.org/T99190#1338615 (10ggellerman) a:3ellery [19:42:05] 10MediaWiki-extensions-ConfirmAccount, 7I18n, 5Patch-For-Review: Message strings from i18n files are no longer showing in Special:AllMessages with MW 1.23.3 - https://phabricator.wikimedia.org/T73300#1338620 (10Paladox) Hi does it work for you. Just making sure that it works as the task describes it should be. [19:42:47] 6Research-and-Data: Fundraising how to calculate confidence on future recurring donations - https://phabricator.wikimedia.org/T99191#1338622 (10ggellerman) a:3ellery [19:43:47] 3Team-Practices-This-Week: Configure #wikimedia-teampractices to allow color - https://phabricator.wikimedia.org/T100547#1338627 (10Awjrichards) [19:46:01] 6Research-and-Data: Fundraising how to calculate confidence on future recurring donations - https://phabricator.wikimedia.org/T99191#1338629 (10ellery) Right now when we compare the the dollar amount per impression, we do not factor in recurring donations. When you optimize for recurring payments, you might trad... [19:46:59] 6Research-and-Data: US mobile traffic projections - https://phabricator.wikimedia.org/T99183#1338630 (10ellery) Both Dario and I modeled pageviews per month as a linear function. That means we assume the absolute number of additional pageviews per month is constant and we try to estimate what that absolute gain... [19:47:24] 6Research-and-Data: US mobile traffic projections - https://phabricator.wikimedia.org/T99183#1338631 (10ellery) a:3ellery [19:47:24] (03PS63) 10Paladox: WikiEditor: Add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) [19:48:46] (03CR) 10Paladox: "@Umherirrender please review. This re adds the svg images they have all been tested in chrome, internet explorer and Microsoft edge. Pleas" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox) [19:48:49] (03CR) 10Mattflaschen: [C: 032] "Looks good. You can self-+2 comment only changes if you want (or not, if you prefer someone look at them). See https://www.mediawiki.org" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/215926 (owner: 10Matthias Mullie) [19:49:26] 10Shop-Theme: [Mobile] Footer isn't organized properly. - https://phabricator.wikimedia.org/T97317#1338634 (10HuiZSF) @MNguyen Updated CSS. Now it looks better on mobile screen! :D [19:49:41] (03CR) 10Paladox: "@Umherirrender please review." [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/190027 (https://phabricator.wikimedia.org/T86476) (owner: 10Paladox) [19:50:08] 10MediaWiki-extensions-WikibaseRepository, 6Mobile-Apps, 10Wikidata: Add an instruction field for Wikidata items - https://phabricator.wikimedia.org/T97566#1338640 (10aude) @Lydia_Pintscher "it is already developed for Android" (you mean iOS?) android is coming also. agree that it makes sense to see how i... [19:50:35] (03Merged) 10jenkins-bot: Add small comments to clarify page-creation during import [extensions/Flow] - 10https://gerrit.wikimedia.org/r/215926 (owner: 10Matthias Mullie) [19:51:27] 10MediaWiki-extensions-WikibaseRepository, 6Mobile-Apps, 10Wikidata: Add an instruction field for Wikidata items - https://phabricator.wikimedia.org/T97566#1338642 (10Lydia_Pintscher) @aude Doh! Yeah iOS of course. [19:51:31] 10MediaWiki-Installer, 10MediaWiki-Parser, 10MediaWiki-extensions-Babel: Installer: MagicWord.php: Error: invalid magic word 'babel' when upgrading an existing wiki - https://phabricator.wikimedia.org/T69877#1338643 (10Ciencia_Al_Poder) [19:51:40] 10FINCH, 6Research-and-Data: Define user segments in a way that Product and Analytics can actually use in database queries - https://phabricator.wikimedia.org/T76908#1338646 (10ggellerman) Removing Research & Data project [19:51:48] 10FINCH: Define user segments in a way that Product and Analytics can actually use in database queries - https://phabricator.wikimedia.org/T76908#1338647 (10ggellerman) [19:51:59] 6Research-and-Data, 7Documentation: Rewrite m:Research:Data "IRC Feeds" section for RCStream - https://phabricator.wikimedia.org/T99743#1338649 (10DarTar) @spage: agreed this is an important data source in need of documentation, removing the Research and Data tag because the team is unlikely to work on this, b... [19:52:10] 7Documentation: Rewrite m:Research:Data "IRC Feeds" section for RCStream - https://phabricator.wikimedia.org/T99743#1338650 (10DarTar) [19:52:12] 10Shop-Theme: [Mobile] Text looks too big on mobile. - https://phabricator.wikimedia.org/T97318#1338651 (10HuiZSF) 5Open>3Resolved [19:52:58] (03CR) 10Mattflaschen: [C: 032] board: Use 'ease' instead of 'linear' for transition [extensions/Flow] - 10https://gerrit.wikimedia.org/r/215938 (owner: 10Krinkle) [19:54:02] (03PS12) 10Paladox: Move all configuration into ConfirmAccount.php [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/209051 [19:54:37] 10MediaWiki-Installer, 10MediaWiki-Parser, 10MediaWiki-extensions-Babel: Installer: MagicWord.php: Error: invalid magic word 'babel' when upgrading an existing wiki - https://phabricator.wikimedia.org/T69877#1338662 (10Ciencia_Al_Poder) This is happening also for [[ https://www.mediawiki.org/wiki/Extension:C... [19:54:41] (03Merged) 10jenkins-bot: board: Use 'ease' instead of 'linear' for transition [extensions/Flow] - 10https://gerrit.wikimedia.org/r/215938 (owner: 10Krinkle) [19:55:16] !class Parser [19:55:16] See https://doc.wikimedia.org/mediawiki-core/master/php/html/classParser.html [19:56:56] (03CR) 10Paladox: "@Umherirrender please review and merge because this way is much cleaner istead of having multiple files to hold code whereas it could just" [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/209051 (owner: 10Paladox) [19:58:06] (03PS8) 10Paladox: Move deprecated HTML attributes to CSS [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/209046 [19:58:10] 10FINCH, 6Research-and-Data: Skin and active editor correlation - https://phabricator.wikimedia.org/T47179#1338671 (10DarTar) @aripstra removing this from R&D but please look into this if it's of any relevance for design standardization. [19:58:22] 10FINCH: Skin and active editor correlation - https://phabricator.wikimedia.org/T47179#1338673 (10DarTar) [19:58:45] (03PS4) 10Paladox: Add web updater support for sql [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/211735 [19:59:11] 10MediaWiki-Page-protection: Split the right protect in two new rights - https://phabricator.wikimedia.org/T101309#1338675 (10Umherirrender) I am not sure, but I sounds that for this use case the right "editprotected" (or "editeditorprotected") already exists. Editing cascade protected pages is protected by use... [20:02:22] (03CR) 10Umherirrender: "(Removing myself as reviewer)" [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/209051 (owner: 10Paladox) [20:02:51] (03CR) 10Umherirrender: "@Paladox: Sorry, I cannot review the addition of extension.json and/or composer" [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/190027 (https://phabricator.wikimedia.org/T86476) (owner: 10Paladox) [20:03:44] 10Security-Core: Create a whitelist of commands which HHVM may execute - https://phabricator.wikimedia.org/T101354#1338678 (10csteipp) That makes a lot of sense to me. Do we have enough logging in production that we would spot violations if we missed a legitimate command? [20:04:10] 10MediaWiki-extensions-CentralNotice, 3Fundraising Sprint Lou Reed, 10Fundraising-Backlog: Few/no banners shown on 1 June? - https://phabricator.wikimedia.org/T101265#1338679 (10AndyRussG) Supposing that there were no known outages in our infrastructure that correspond to that period, maybe let's explore the... [20:04:21] (03CR) 10Umherirrender: "@Paladox: Sorry, I have not enough knowledge about svg to review this patch set" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox) [20:04:45] 10MediaWiki-API, 6Multimedia, 7Technical-Debt: ApiQueryImageInfo is crufty, needs rewrite - https://phabricator.wikimedia.org/T89971#1338681 (10Anomie) [20:04:48] 10MediaWiki-API, 10MediaWiki-File-management, 6Multimedia: This result was truncated because it would otherwise be larger than the limit of 12,582,912 bytes - https://phabricator.wikimedia.org/T101400#1338680 (10Anomie) [20:05:01] (03PS2) 10Bmansurov: Fix oojs ui icon naming conflict [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/215953 (https://phabricator.wikimedia.org/T98518) [20:05:41] !class Preferences [20:05:41] See https://doc.wikimedia.org/mediawiki-core/master/php/html/classPreferences.html [20:06:29] (03PS1) 10Paladox: Remove i18n shim [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/215963 [20:06:44] (03PS2) 10Paladox: Remove i18n shim [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/215963 [20:07:14] (03CR) 10Paladox: "@Umherirrender please review." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/215963 (owner: 10Paladox) [20:09:19] (03CR) 10Jdouglas: [C: 032] Fix randomized test failure [search/extra] - 10https://gerrit.wikimedia.org/r/215915 (owner: 10Manybubbles) [20:10:34] (03Merged) 10jenkins-bot: Fix randomized test failure [search/extra] - 10https://gerrit.wikimedia.org/r/215915 (owner: 10Manybubbles) [20:10:41] 10MediaWiki-ResourceLoader, 7Performance: ResourceLoader module version must only change when effective output would change - https://phabricator.wikimedia.org/T98087#1338685 (10Krinkle) [20:11:04] 10MediaWiki-ResourceLoader, 5MW-1.26-release, 5Patch-For-Review, 5WMF-deploy-2015-06-09_(1.26wmf9): Refactor ResourceLoader versioning system to use hashes instead of timestamps - https://phabricator.wikimedia.org/T94074#1338689 (10Krinkle) 5Open>3Resolved The main version system is hash-based. Most in... [20:11:23] 6Research-and-Data: Identifying automata - https://phabricator.wikimedia.org/T99189#1338693 (10ggellerman) Removing Research & Data and moving to Research Ideas board [20:11:26] (03PS7) 10Krinkle: resourceloader: Replace ResourceLoaderWikiModule mtime queries with content hash [core] - 10https://gerrit.wikimedia.org/r/215857 (https://phabricator.wikimedia.org/T98087) [20:11:36] 10Research Ideas: Identifying automata - https://phabricator.wikimedia.org/T99189#1338697 (10ggellerman) [20:11:50] (03PS12) 10Krinkle: resourceloader: Move packaging to a new getModuleContent() method [core] - 10https://gerrit.wikimedia.org/r/210942 (https://phabricator.wikimedia.org/T98087) [20:11:57] (03PS13) 10Krinkle: resourceloader: Move packaging to a new getModuleContent() method [core] - 10https://gerrit.wikimedia.org/r/210942 (https://phabricator.wikimedia.org/T98087) [20:12:13] (03PS6) 10Krinkle: resourceloader: Enable module content version for data modules [core] - 10https://gerrit.wikimedia.org/r/215364 (https://phabricator.wikimedia.org/T98087) [20:12:30] (03CR) 10jenkins-bot: [V: 04-1] resourceloader: Enable module content version for data modules [core] - 10https://gerrit.wikimedia.org/r/215364 (https://phabricator.wikimedia.org/T98087) (owner: 10Krinkle) [20:13:16] (03PS4) 10BryanDavis: resourceloader: Make ResourceLoader logger aware [core] - 10https://gerrit.wikimedia.org/r/215863 (owner: 10Krinkle) [20:13:23] (03CR) 10BryanDavis: [C: 032] resourceloader: Make ResourceLoader logger aware [core] - 10https://gerrit.wikimedia.org/r/215863 (owner: 10Krinkle) [20:15:39] (03CR) 10BryanDavis: "Maybe change the info() call in __construct that used to be a wfDebug() to debug()?" [core] - 10https://gerrit.wikimedia.org/r/215864 (owner: 10Krinkle) [20:16:19] (03PS5) 10Paladox: Add web updater support for sql [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/211735 [20:16:26] (03CR) 10Aaron Schulz: [C: 032] WebResponse: Implement statusHeader() using the new HttpStatus::header() [core] - 10https://gerrit.wikimedia.org/r/215033 (owner: 10Krinkle) [20:17:36] (03PS7) 10Krinkle: resourceloader: Enable module content version for data modules [core] - 10https://gerrit.wikimedia.org/r/215364 (https://phabricator.wikimedia.org/T98087) [20:17:44] (03CR) 10Krinkle: "Rebased to resolve conflict." [core] - 10https://gerrit.wikimedia.org/r/215364 (https://phabricator.wikimedia.org/T98087) (owner: 10Krinkle) [20:18:03] (03CR) 10Jdouglas: [C: 032] Make regexes easier to use from other plugins [search/extra] - 10https://gerrit.wikimedia.org/r/215913 (owner: 10Manybubbles) [20:18:06] (03PS6) 10Paladox: Add web updater support for sql [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/211735 [20:18:42] 10MediaWiki-Configuration: Extension registration: GroupPermissions seems to only accept one sub-parameter - https://phabricator.wikimedia.org/T98347#1338703 (10Aklapper) @Paladox: Please explain what exactly changed with the urgency of this bug that made you set the priority to "Unbreak Now!". [20:19:01] (03CR) 10Paladox: "Parts based on https://gerrit.wikimedia.org/r/#/c/215255/2" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/211735 (owner: 10Paladox) [20:19:07] (03Merged) 10jenkins-bot: Make regexes easier to use from other plugins [search/extra] - 10https://gerrit.wikimedia.org/r/215913 (owner: 10Manybubbles) [20:19:33] 7Performance: Use APC for caching slave lag times - https://phabricator.wikimedia.org/T101433#1338704 (10aaron) 3NEW [20:19:59] 10MediaWiki-ResourceLoader, 5Patch-For-Review, 7Performance: ResourceLoader module version must only change when effective output would change - https://phabricator.wikimedia.org/T98087#1338712 (10Krinkle) [20:20:43] 6Phabricator, 6operations, 7database: Add Story points (from Sprint Extension) to the phabricator data dump - https://phabricator.wikimedia.org/T100846#1338714 (10chasemp) 5Open>3Resolved >>! In T100846#1338122, @JAufrecht wrote: > Is there any transaction history for story points? E.g., if a story is... [20:20:50] (03CR) 10Paladox: "@Krinkle please review since there should be some support if a user wants to keep on the same MySQL database and not on a different one. A" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/211735 (owner: 10Paladox) [20:21:34] (03CR) 10Jdouglas: [C: 031] "I prefer not to commit commented-out code, but not strongly enough to -1. Feel free to either delete it, or just self +2 this one." [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/215523 (owner: 10Smalyshev) [20:21:39] 6Phabricator, 10Traffic, 6operations, 7Blocked-on-Operations: Phabricator needs to expose ssh and notification daemon (websocket) - https://phabricator.wikimedia.org/T100519#1338718 (10BBlack) Basically we need something like this for the websockets through nginx: http://nginx.org/en/docs/http/websocket.html [20:21:43] (03PS7) 10Paladox: Add web updater support for sql [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/211735 [20:21:51] (03Merged) 10jenkins-bot: resourceloader: Make ResourceLoader logger aware [core] - 10https://gerrit.wikimedia.org/r/215863 (owner: 10Krinkle) [20:22:12] (03PS8) 10Krinkle: resourceloader: Enable module content version for data modules [core] - 10https://gerrit.wikimedia.org/r/215364 (https://phabricator.wikimedia.org/T98087) [20:23:58] 10MediaWiki-Configuration: Extension registration: GroupPermissions seems to only accept one sub-parameter - https://phabricator.wikimedia.org/T98347#1338720 (10Paladox) Because it is broken if you do more then one sub parameter for example this "GroupPermissions": { "bureaucrat": { "confirmaccount"... [20:24:15] (03Merged) 10jenkins-bot: WebResponse: Implement statusHeader() using the new HttpStatus::header() [core] - 10https://gerrit.wikimedia.org/r/215033 (owner: 10Krinkle) [20:24:50] (03CR) 10Paladox: "Oh ok." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox) [20:25:06] (03CR) 10Paladox: "@TheDJ please review." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox) [20:25:21] (03CR) 10Krinkle: "I was giving feedback per your request so you understand the problem. However I do not maintain this extension, and don't have time to rev" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/211735 (owner: 10Paladox) [20:25:23] (03CR) 10Gergő Tisza: "navigator.connection.type is implemented fairly widely (mobile Chrome, mobile FF, FF OS) but not very useful as far as I can see. navigato" [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/132915 (https://phabricator.wikimedia.org/T76814) (owner: 10Gergő Tisza) [20:25:40] (03Merged) 10jenkins-bot: Use HttpStatus::header instead of manually crafting header() [core] - 10https://gerrit.wikimedia.org/r/215034 (owner: 10Krinkle) [20:25:57] legoktm: Hm.. so the only reason GlobalCssJs modules work is because getContent is only invoked on the target wiki, right? [20:26:23] 10MediaWiki-Configuration: Extension configuration settings that have 2d (or greater) arrays do not work in extension registration - https://phabricator.wikimedia.org/T99257#1338724 (10Aklapper) p:5Unbreak!>3High > Setting as unbreak since it doesent work and needs fixing. @Paladox: By that definition every... [20:26:28] (03PS8) 10Gergő Tisza: [HOLD] Add network information from navigator.connection [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/132915 (https://phabricator.wikimedia.org/T76814) [20:26:48] (03CR) 10Gergő Tisza: [C: 04-2] [HOLD] Add network information from navigator.connection [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/132915 (https://phabricator.wikimedia.org/T76814) (owner: 10Gergő Tisza) [20:27:24] 6Mobile-Web: Promote references beta dialog to stable - https://phabricator.wikimedia.org/T101434#1338726 (10Jdlrobson) 3NEW [20:27:31] 10MediaWiki-History-or-Diffs, 10MediaWiki-Interface, 10MediaWiki-Patrolling, 10Vector: MediaWiki difference view doesn't show emoji - https://phabricator.wikimedia.org/T101219#1338735 (10Platonides) A few tests under Linux (Firefox 38, Chromium 43.0.2357.81. midori 0.5.10) all show the collision symbol (ak... [20:28:05] (03CR) 10Anomie: [C: 04-1] "A few nitpicks. Also, needs rebase." (038 comments) [core] - 10https://gerrit.wikimedia.org/r/206156 (https://phabricator.wikimedia.org/T94774) (owner: 10CSteipp) [20:30:14] 6Performance-Team, 10Security-General: Logged-in script traffic isn't gzipped - https://phabricator.wikimedia.org/T101435#1338736 (10Gilles) 3NEW [20:30:17] 10MediaWiki-General-or-Unknown: Crazy modal box shows up out of the blue - https://phabricator.wikimedia.org/T101323#1338744 (10Aklapper) p:5Triage>3Lowest [20:30:18] (03CR) 10Jdlrobson: [C: 032] "This can be simplified even more. Please watch for my follow up." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/215953 (https://phabricator.wikimedia.org/T98518) (owner: 10Bmansurov) [20:30:21] 3Mobile-App-Sprint-59-Android, 3Mobile-App-Sprint-59-iOS: Extract exact license info for share a fact cards - https://phabricator.wikimedia.org/T101436#1338746 (10Moushira) 3NEW [20:31:14] 10MediaWiki-General-or-Unknown, 7Documentation: replace 537 subpages of Manual:Hooks/ with generated doc - https://phabricator.wikimedia.org/T93043#1338762 (10Tgr) Just talked about this with @bd808 recently. hooks.txt could be migrated to YAML; that's still readable (arguable more readable), close enough that... [20:31:30] (03CR) 10Paladox: "@Yurik please review. or @Umherirrender please review." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/211735 (owner: 10Paladox) [20:31:32] (03CR) 10Bmansurov: [C: 04-1] "looks good, just a minor documentation fix is needed" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/208137 (https://phabricator.wikimedia.org/T97663) (owner: 10Jdlrobson) [20:31:35] 10MediaWiki-Configuration: Extension configuration settings that have 2d (or greater) arrays do not work in extension registration - https://phabricator.wikimedia.org/T99257#1338766 (10Krinkle) >>! In T99257#1337836, @Paladox wrote: > Setting as unbreak since it doesent work and needs fixing. This is not unbrea... [20:32:04] (03CR) 10Paladox: "@Yurik please review. or @Umherirrender please review." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/211735 (owner: 10Paladox) [20:32:08] (03Merged) 10jenkins-bot: Fix oojs ui icon naming conflict [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/215953 (https://phabricator.wikimedia.org/T98518) (owner: 10Bmansurov) [20:32:13] 10MediaWiki-Configuration: Extension registration: GroupPermissions seems to only accept one sub-parameter - https://phabricator.wikimedia.org/T98347#1338770 (10Aklapper) @Paladox: Please explain what exactly changed with the urgency of this bug that made you set the priority to "Unbreak Now!". "It is broken" is... [20:32:26] 10MediaWiki-Configuration: Extension registration: GroupPermissions seems to only accept one sub-parameter - https://phabricator.wikimedia.org/T98347#1338773 (10Aklapper) p:5Unbreak!>3High [20:33:23] 10MediaWiki-Configuration: Extension configuration settings that have 2d (or greater) arrays do not work in extension registration - https://phabricator.wikimedia.org/T99257#1338774 (10Paladox) Ok yes I have a workaround by using callback. [20:33:58] 5MW-1.25-release: No patch download for 1.25.1 - https://phabricator.wikimedia.org/T101404#1338780 (10greg) [20:34:13] 5MW-1.25-release: No patch download for 1.25.1 - https://phabricator.wikimedia.org/T101404#1337669 (10greg) (not all MW release tasks need to be in releng) [20:35:05] 10MediaWiki-Configuration: Extension configuration settings that have 2d (or greater) arrays do not work in extension registration - https://phabricator.wikimedia.org/T99257#1338784 (10Paladox) Well if it was never broken and never implanted then this could be a feature report to suggest that be added to extensi... [20:36:08] (03CR) 10Mjbmr: "Do this for now. Let Siebrand know to don't make variants." [core] - 10https://gerrit.wikimedia.org/r/206083 (https://phabricator.wikimedia.org/T96468) (owner: 10Mjbmr) [20:36:28] 10MediaWiki-Configuration: Extension registration: GroupPermissions seems to only accept one sub-parameter - https://phabricator.wikimedia.org/T98347#1338785 (10Paladox) Sorry that I set it unbreak now I wont do it unless I say why I changed the status. [20:37:10] 10crosswatch: Integrate with translatewiki - https://phabricator.wikimedia.org/T101438#1338786 (10Sitic) 3NEW a:3Sitic [20:37:33] 4(no projects): Error with unknown units for {val|} template - https://phabricator.wikimedia.org/T101401#1338795 (10Aklapper) 5Open>3Invalid a:3Aklapper Hi @Marcnadrelm. Thanks for taking the time to report this. Templates are local features and managed on wiki. Phabricator/Maniphest is used for MediaWiki... [20:38:24] 4(no projects): What should we be doing for our Readers - https://phabricator.wikimedia.org/T100261#1338799 (10Aklapper) a:3Tnegrin @TNegrin: Please associate a project with this task. [20:38:48] 10Wikimedia-General-or-Unknown: Make Wikimedia project titles more user-friendly - https://phabricator.wikimedia.org/T100692#1338801 (10Aklapper) [20:39:15] 10Wikimedia-General-or-Unknown: Make Wikimedia project titles more user-friendly - https://phabricator.wikimedia.org/T100692#1338802 (10Aklapper) 5Open>3stalled Unclear steps to reproduce; setting status "stalled" until @egalvezwmf clarifies [20:39:33] (03CR) 10Paladox: "@Krinkle please could you review. Comment above will redirect you to website where you can test the svg icons." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox) [20:41:46] 10MediaWiki-Configuration: Extension configuration settings that have 2d (or greater) arrays do not work in extension registration - https://phabricator.wikimedia.org/T99257#1338806 (10Aklapper) p:5High>3Normal [20:43:28] 10crosswatch: wikidata support - https://phabricator.wikimedia.org/T101439#1338813 (10Sitic) 3NEW a:3Sitic [20:43:43] 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: Goal: Successful mid-term and end-term evaluations for all GSoC and Outreachy projects - https://phabricator.wikimedia.org/T101393#1338823 (10Qgil) What about something a bit more ambitious, like all GSoC & Outreachy projects have their code merged and deployed... [20:43:51] 6Performance-Team, 10Security-General: Logged-in script traffic isn't gzipped - https://phabricator.wikimedia.org/T101435#1338824 (10csteipp) [20:44:25] 10dev.wikimedia.org, 7Epic: integrate new Developer hub with mediawiki.org - https://phabricator.wikimedia.org/T101441#1338834 (10Spage) 3NEW a:3Spage [20:45:06] 5MW-1.25-release: No patch download for 1.25.1 - https://phabricator.wikimedia.org/T101404#1338845 (10Ciencia_Al_Poder) (Adding a few cc, since I don't know what project I could add to this task apart from MediaWiki 1.25) Although 1.25.1 contains only a fix for a bundled extension, MediaWiki version was bumped... [20:45:09] 10MediaWiki-Internationalization: Creating Gujarati (Hindu) Calendar - https://phabricator.wikimedia.org/T101442#1338846 (10Dsvyas) 3NEW [20:46:44] 6Mobile-Web: Promote references beta dialog to stable - https://phabricator.wikimedia.org/T101434#1338854 (10KHammerstein) @Jdlrobson Oh no! Another feature that I thought was already in stable. Nothing stopping it, should be pushed now. [20:46:52] 10dev.wikimedia.org: Deploy SkinPerNamespace extension on mediawiki.org - https://phabricator.wikimedia.org/T98897#1338856 (10Spage) [20:46:54] 10MediaWiki-skins-Blueprint: Deploy Blueprint on mediawiki.org as optional and experimental skin - https://phabricator.wikimedia.org/T93613#1338857 (10Spage) [20:46:57] 10dev.wikimedia.org: Future of the current Developer Hub at mediawiki.org - https://phabricator.wikimedia.org/T313#1338859 (10Spage) [20:46:59] 10MediaWiki-skins-Blueprint, 10dev.wikimedia.org: Define the look&feel of the Developer Hub - https://phabricator.wikimedia.org/T301#1338858 (10Spage) [20:47:02] 10dev.wikimedia.org, 7Epic: integrate new Developer hub with mediawiki.org - https://phabricator.wikimedia.org/T101441#1338855 (10Spage) [20:48:17] (03PS1) 10Jdlrobson: Hygiene: Use invert to generate light coloured close icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/215967 [20:48:47] (03CR) 10Umherirrender: "@Paladox: It is okay to add me as reviewer to patch set, but there is no need to add a comment and ask for explicit review, I am a volunte" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/211735 (owner: 10Paladox) [20:49:16] 6Performance-Team, 10Security-General: Logged-in script traffic isn't gzipped - https://phabricator.wikimedia.org/T101435#1338870 (10csteipp) We've mitigated breach for csrf tokens using variable tokens. Iirc, when breach was first announced, ops had said turning off gzip wasn't an option. Do we know when gzi... [20:49:58] (03PS7) 10Jdlrobson: Allow view to be the template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/208137 (https://phabricator.wikimedia.org/T97663) [20:50:13] (03CR) 10Paladox: "Oh ok sorry." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/211735 (owner: 10Paladox) [20:50:49] (03PS18) 10Jdlrobson: Beta: Serve only lead section on page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/212945 (https://phabricator.wikimedia.org/T100258) [20:51:44] (03PS19) 10Jdlrobson: Beta: Serve only lead section on page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/212945 (https://phabricator.wikimedia.org/T100258) [20:52:22] (03CR) 10Jdlrobson: "On progressive stuff: The link comes from core. I'm not touching that with a barge pole." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/213203 (https://phabricator.wikimedia.org/T55684) (owner: 10Florianschmidtwelzow) [20:52:32] (03PS3) 10Paladox: Remove i18n shim [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/215963 [20:53:11] (03PS6) 10Aaron Schulz: Fixed race condition in MessageCache::replace [core] - 10https://gerrit.wikimedia.org/r/212242 [20:53:34] (03PS8) 10Jdlrobson: Add basic support for patrolling on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/213203 (https://phabricator.wikimedia.org/T55684) (owner: 10Florianschmidtwelzow) [20:53:36] (03CR) 10jenkins-bot: [V: 04-1] Beta: Serve only lead section on page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/212945 (https://phabricator.wikimedia.org/T100258) (owner: 10Jdlrobson) [20:53:50] (03CR) 10Jdlrobson: [C: 032] "Fixed documentation issue myself and merging" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/213203 (https://phabricator.wikimedia.org/T55684) (owner: 10Florianschmidtwelzow) [20:55:19] (03CR) 10jenkins-bot: [V: 04-1] Add basic support for patrolling on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/213203 (https://phabricator.wikimedia.org/T55684) (owner: 10Florianschmidtwelzow) [20:56:24] (03CR) 10Jdlrobson: "Needs a rebase now but apart from that should be good to go." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190728 (https://phabricator.wikimedia.org/T54165) (owner: 10Florianschmidtwelzow) [20:58:18] (03PS3) 10Jdlrobson: The random collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/215235 (https://phabricator.wikimedia.org/T101422) [20:58:56] (03PS8) 10Jdlrobson: Show related pages when editing 1 to 3 items collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/214320 (https://phabricator.wikimedia.org/T100634) (owner: 10Jhernandez) [20:59:00] 10dev.wikimedia.org, 7Epic: integrate new Developer hub with mediawiki.org - https://phabricator.wikimedia.org/T101441#1338892 (10Spage) [21:01:17] 10dev.wikimedia.org, 5Patch-For-Review: Decide a namespace in mediawiki.org to host the developer hub - https://phabricator.wikimedia.org/T369#1338906 (10Spage) [21:01:18] 10dev.wikimedia.org, 7Epic: integrate new Developer hub with mediawiki.org - https://phabricator.wikimedia.org/T101441#1338905 (10Spage) [21:03:03] (03PS13) 10Paladox: Move function to CentralAuthHook [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/209288 [21:03:38] (03PS6) 10Paladox: Add extension.json, empty PHP entry point [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/213825 (https://phabricator.wikimedia.org/T88047) [21:04:02] (03CR) 10Gergő Tisza: Convert MWExceptionHandler to use structured logging (033 comments) [core] - 10https://gerrit.wikimedia.org/r/213348 (https://phabricator.wikimedia.org/T88649) (owner: 10BryanDavis) [21:04:13] (03PS5) 10Paladox: empty php entry point [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/213956 [21:04:31] (03PS2) 10Catrope: Only change editor preference if user makes a change [extensions/Flow] - 10https://gerrit.wikimedia.org/r/215838 (https://phabricator.wikimedia.org/T94852) [21:04:34] 10UI-Standardization, 6Mobile-Web, 10OOjs-UI, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned, 5Patch-For-Review: oojs ui icon name conflict ('cancel') on overlay close buttons on mobile beta/alpha - https://phabricator.wikimedia.org/T98518#1338911 (10KHammerstein) @Jdlrobson @Florian Do we have the ability t... [21:04:49] (03PS31) 10Paladox: Update sql [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/190660 [21:05:16] (03PS8) 10Krinkle: resourceloader: Clean up ResourceLoaderWikiModule.php::getModifiedTime leftover [core] - 10https://gerrit.wikimedia.org/r/215857 (https://phabricator.wikimedia.org/T98087) [21:05:58] (03PS1) 10Filippo Giunchedi: add missing hhvm dependency [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/215968 [21:06:43] (03CR) 10Ori.livneh: [C: 031] add missing hhvm dependency [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/215968 (owner: 10Filippo Giunchedi) [21:06:48] (03CR) 10Filippo Giunchedi: [C: 032 V: 032] add missing hhvm dependency [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/215968 (owner: 10Filippo Giunchedi) [21:08:14] (03CR) 10Bmansurov: [C: 032] Allow view to be the template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/208137 (https://phabricator.wikimedia.org/T97663) (owner: 10Jdlrobson) [21:09:14] 3Team-Practices-This-Week: Share Q3 health check results with EMGT - https://phabricator.wikimedia.org/T98524#1338927 (10ggellerman) 5Open>3Resolved [21:09:48] 3Team-Practices-This-Week: Configure #wikimedia-teampractices to allow color - https://phabricator.wikimedia.org/T100547#1338930 (10ggellerman) 5Open>3Resolved [21:09:57] (03Merged) 10jenkins-bot: Allow view to be the template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/208137 (https://phabricator.wikimedia.org/T97663) (owner: 10Jdlrobson) [21:10:54] 3Team-Practices-This-Week: Define a TPG library of diagnostic charts/metrics - https://phabricator.wikimedia.org/T97737#1338937 (10ggellerman) Reviewed by Grace. New tasks will cover new work. Closing [21:11:02] 3Team-Practices-This-Week: Define a TPG library of diagnostic charts/metrics - https://phabricator.wikimedia.org/T97737#1338938 (10ggellerman) 5Open>3Resolved [21:11:31] 3Team-Practices-This-Week: TPG definition of Kanban - https://phabricator.wikimedia.org/T97572#1338939 (10ggellerman) 5Open>3Resolved [21:12:08] 3Team-Practices-This-Week: Add more entries to glossary - https://phabricator.wikimedia.org/T95484#1338940 (10ggellerman) 5Open>3Resolved [21:12:47] 3Team-Practices-This-Week: Redraft TPG task SOPs to catch up on all notes from 28 May discussions - https://phabricator.wikimedia.org/T100713#1338943 (10ggellerman) 5Open>3Resolved [21:13:38] Krinkle: yep. [21:13:57] (03CR) 10Brian Wolff: [C: 04-2] "Same reason as legoktm's original comment. The web updater is usually not used to update shared tables" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/211735 (owner: 10Paladox) [21:14:37] Krinkle: that said, ori was suggesting we work on loading the module from the local wiki's load.php end point so we're not blocking with a request to a separate domain [21:15:16] Krinkle: https://phabricator.wikimedia.org/T100619 probably with an API request to meta server-side or something [21:15:48] (03CR) 10Paladox: "Maybe but echo does the same and this setting is to say if the database is hosted somewere else then it will not run the sql u" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/211735 (owner: 10Paladox) [21:15:56] (03CR) 10Paladox: "update." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/211735 (owner: 10Paladox) [21:16:07] legoktm: Yeah, we can look into that later. [21:16:12] legoktm: I'm not convinced of that benefit per se. [21:16:22] It also means cache is not properly shared [21:16:29] global cssjs is a power user feature [21:16:32] those users jump wikis [21:16:38] 3Team-Practices-This-Week: Schedule next check-in with RelEng re: testing best practices initiative. - https://phabricator.wikimedia.org/T96876#1338954 (10ggellerman) Dan Duval and Grace meeting 2015-06-16 [21:16:40] I don't want to re-fetch the same content every wiki I visit. [21:16:55] yeah [21:17:06] legoktm: I've updated it back to use title info [21:17:06] (03CR) 10Paladox: "But His reasons was because I didn't implant anything to stop database updating if it is hosted somewhere else whereas the new patch does " [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/211735 (owner: 10Paladox) [21:17:14] but it's annoying that when I change my js and then revert, it's still a bum[ [21:17:16] bump* [21:17:22] could we share the cache somehow with the local storage caching? [21:17:24] even if I use rev_id instead of timestamp, rev id bumps [21:17:32] Maybe I can do a join to rev_sha1 [21:17:44] But I always forget how to do that. [21:18:04] 10MediaWiki-extensions-CentralAuth, 6Mobile-Web, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned: "You are centrally logged in." toast on every page view on commons - https://phabricator.wikimedia.org/T100413#1338958 (10kaldari) @csteipp Any update on this bug? Is there anything that we can do on our end (in Mobi... [21:18:21] legoktm: https://gerrit.wikimedia.org/r/#/c/215857/8/includes/resourceloader/ResourceLoaderWikiModule.php [21:18:55] I'll try to get rev_sha1 there instead of page_latest [21:20:17] was there a reason we used page_latest instead of rev_timestamp? I don't think JS expands templates or any types of links... [21:20:25] (03PS11) 10Florianschmidtwelzow: Hygiene: Use Config object instead of globals [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/210649 (https://phabricator.wikimedia.org/T87614) [21:20:59] legoktm: what do you mean? [21:21:16] page_latest is just a shortcut for rev_timestamp [21:21:20] no it's not [21:21:22] I know it's not the same but that's the reason for it [21:21:32] page_latest is updated whenever templates or page links change [21:21:53] er wait [21:21:54] 10Wikipedia-Store: Left/Right Margins of Artist Profile Content - https://phabricator.wikimedia.org/T98792#1338961 (10HuiZSF) @MNguyen Updated `padding` of `.vendor_container` to `2em 0.1em` to achieve this request. [21:21:59] do not confuse by page_touched? [21:22:00] I'm thinking of page_touched [21:22:02] yeah [21:22:16] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use Config object instead of globals [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/210649 (https://phabricator.wikimedia.org/T87614) (owner: 10Florianschmidtwelzow) [21:22:52] legoktm: well, it was using page_touched :P [21:22:56] it is in master [21:23:05] (03PS12) 10Florianschmidtwelzow: Hygiene: Use Config object instead of globals [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/210649 (https://phabricator.wikimedia.org/T87614) [21:23:14] I'm changing it to page_latest (rev_id) at least, but I want to take it further and use sha1 [21:23:23] I think that should be fine [21:23:24] (03CR) 10Kaldari: [C: 031] Clarify that gender-unknown option is gender neutral [core] - 10https://gerrit.wikimedia.org/r/106179 (https://phabricator.wikimedia.org/T61643) (owner: 10Jackmcbarn) [21:23:32] just have to figure out the join [21:24:07] 3Team-Practices-This-Week: Update Team Health Check email invitation template to match new focus areas - https://phabricator.wikimedia.org/T93963#1338962 (10ggellerman) [21:24:20] (03CR) 10Brian Wolff: "Echo is doing something rather different, and in the default config (I believe) would make local tables where a db updater hook makes sens" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/211735 (owner: 10Paladox) [21:24:30] 3Team-Practices-This-Week: Schedule Q4 Team Health Checks - https://phabricator.wikimedia.org/T100675#1338963 (10ggellerman) [21:24:33] legoktm: LinkBath is involved as well [21:24:42] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use Config object instead of globals [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/210649 (https://phabricator.wikimedia.org/T87614) (owner: 10Florianschmidtwelzow) [21:24:50] LinkBatch is just being used to construct the where part of the query [21:25:31] Yeah, which I need to change to include page_latest=rev_id [21:25:36] array( 'revision' => array( 'INNER JOIN', 'page_latest=rev_id' ) ) should be the join condition [21:25:39] oh [21:25:43] I guess that works too [21:25:59] in Revision.php the join with page is done less explicit [21:26:08] 3Team-Practices-This-Week: Document plans for improving the tech debt situation - https://phabricator.wikimedia.org/T96071#1338966 (10ggellerman) [21:26:58] 3Team-Practices-This-Week: Consult on Kanban for Readership - https://phabricator.wikimedia.org/T96340#1338971 (10ggellerman) [21:27:02] hmm, that's doing array( 'INNER JOIN', array( 'page_id = rev_page' ) ) [21:27:19] (03CR) 10Gergő Tisza: [C: 04-1] "It does break git-update: https://phabricator.wikimedia.org/P731" [vagrant] - 10https://gerrit.wikimedia.org/r/146014 (https://bugzilla.wikimedia.org/57680) (owner: 10Ori.livneh) [21:27:21] (03CR) 10Bmansurov: [C: 04-1] Hygiene: Use invert to generate light coloured close icon (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/215967 (owner: 10Jdlrobson) [21:27:24] * @param string|array $join_conds [21:27:25] * [21:27:25] * Optional associative array of table-specific join conditions. In the [21:27:26] * most common case, this is unnecessary, since the join condition can be [21:27:28] * in $conds. However, it is useful for doing a LEFT JOIN. [21:27:30] * [21:27:35] inner join is the default? [21:27:53] (03CR) 10Isarra: "As long as the skin class isn't apt to randomly change, I don't see it being much different either way, really." [core] - 10https://gerrit.wikimedia.org/r/215917 (owner: 10Krinkle) [21:28:29] We're dealing with multiple page_tiltle/page_namespace selections [21:28:34] using an IN() [21:29:02] 6Performance-Team, 10Security-General: Logged-in script traffic isn't gzipped - https://phabricator.wikimedia.org/T101435#1338972 (10Gilles) Actually now that I'm looking more into it, it seems like it might be a Firefox-only issue. [21:29:20] Hm.. yeah, should we join from reivsion to page or the other way around [21:29:27] 3Team-Practices-This-Week: Implement new sequence for Team Health Check focus areas - https://phabricator.wikimedia.org/T95495#1338973 (10ksmith) [21:29:35] We want to basically have rows from page table with extra data from revision [21:29:50] 6Performance-Team, 10Security-General: Logged-in script traffic isn't gzipped for Firefox - https://phabricator.wikimedia.org/T101435#1338975 (10Gilles) [21:32:25] 6Performance-Team: Logged-in script traffic isn't gzipped for Firefox - https://phabricator.wikimedia.org/T101435#1338984 (10Gilles) [21:32:30] RoanKattouw_away: brt [21:32:55] ori: Ping me when you're there, I'm not there yet [21:33:40] (03CR) 10Jforrester: [C: 032] Use a valid "license" in package.json [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/213803 (owner: 10Ricordisamoa) [21:34:15] (03Abandoned) 10Jforrester: Remove i18n shim [extensions/UploadWizard] (REL1_25) - 10https://gerrit.wikimedia.org/r/214008 (owner: 10Paladox) [21:34:32] (03CR) 10Brian Wolff: "Well you're still tying it into a new config instead of the existing config (And the new configs docs doesn't really make sense in this ex" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/211735 (owner: 10Paladox) [21:34:34] (03CR) 10Paladox: "Ok but echo is doing something similar because if the user has the database on a different server or database then the upgraded will disab" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/211735 (owner: 10Paladox) [21:34:46] (03Merged) 10jenkins-bot: Use a valid "license" in package.json [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/213803 (owner: 10Ricordisamoa) [21:35:30] 7Epic, 3Team-Practices-This-Week: Review Team Health Check retrospective for possible Q4 improvements - https://phabricator.wikimedia.org/T101444#1338996 (10ksmith) 3NEW [21:35:57] (03CR) 10Paladox: Add web updater support for sql (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/211735 (owner: 10Paladox) [21:38:40] (03PS1) 10Ori.livneh: Revert "awful hack: disable fss on zhwiki only, except on mw1017" [core] (wmf/1.26wmf8) - 10https://gerrit.wikimedia.org/r/215978 [21:39:22] (03CR) 10Smalyshev: [C: 032] Fix munger to not produce millisecond dates [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/215523 (owner: 10Smalyshev) [21:43:10] (03PS2) 10Ori.livneh: Revert "awful hack: disable fss on zhwiki only, except on mw1017" [core] (wmf/1.26wmf8) - 10https://gerrit.wikimedia.org/r/215978 [21:43:10] (03CR) 10Ori.livneh: [C: 032 V: 032] Revert "awful hack: disable fss on zhwiki only, except on mw1017" [core] (wmf/1.26wmf8) - 10https://gerrit.wikimedia.org/r/215978 (owner: 10Ori.livneh) [21:43:11] (03Merged) 10jenkins-bot: Fix munger to not produce millisecond dates [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/215523 (owner: 10Smalyshev) [21:43:11] (03CR) 10Sn1per: "Hmm. Well, I guess revert makes sense in that case." [core] - 10https://gerrit.wikimedia.org/r/215345 (https://phabricator.wikimedia.org/T89648) (owner: 10Sn1per) [21:43:11] (03Abandoned) 10Sn1per: mediawiki.Title: Load messages for specific MalformedTitleExceptions [core] - 10https://gerrit.wikimedia.org/r/215345 (https://phabricator.wikimedia.org/T89648) (owner: 10Sn1per) [21:43:38] (03PS1) 10Sn1per: Revert "Implement MalformedTitleException for JS and use in constructor" [core] - 10https://gerrit.wikimedia.org/r/215981 [21:43:52] 10MediaWiki-Parser, 7Epic: The newline added to a template, magic word, variable, or parser function that returns line-start wikicode formatting (*#:; {|) causes unexpected parsing - https://phabricator.wikimedia.org/T14974#1339005 (10Jdforrester-WMF) [21:43:53] 10MediaWiki-Parser: Parser inserts invalid   in the middle of style attribute (French spaces) - https://phabricator.wikimedia.org/T5158#1339007 (10Jdforrester-WMF) [21:43:55] 10MediaWiki-extensions-ParserFunctions: ifexist function uses pagelinks table in lieu of better options - https://phabricator.wikimedia.org/T14019#1339006 (10Jdforrester-WMF) [21:43:58] 10MediaWiki-Parser: pre over multiple lines in lists - https://phabricator.wikimedia.org/T3581#1339009 (10Jdforrester-WMF) [21:44:00] 10MediaWiki-Parser: Table summary should render HTML5 - https://phabricator.wikimedia.org/T43917#1339011 (10Jdforrester-WMF) [21:44:02] 10MediaWiki-Parser, 7Accessibility: Colon (:) & semicolon (;) shouldn't output as HTML definition list when used for indentation, boldfacing - https://phabricator.wikimedia.org/T6521#1339010 (10Jdforrester-WMF) [21:44:04] 10MediaWiki-Templates: tilde signatures inside nowiki tags sometimes get expanded (~~~~) - https://phabricator.wikimedia.org/T2093#1339015 (10Jdforrester-WMF) [21:44:06] 10MediaWiki-Parser, 10Parsoid: Avoid nested definition lists - https://phabricator.wikimedia.org/T8569#1339014 (10Jdforrester-WMF) [21:44:09] 10MediaWiki-Parser, 10MediaWiki-Templates: Template misses its parameter when containing a link with "=" (equal sign) character in the URL, or HTML attributes - https://phabricator.wikimedia.org/T16235#1339013 (10Jdforrester-WMF) [21:44:32] 10MediaWiki-Parser: Leading spaces in 
 block render incorrectly when block preceded by another 
 - https://phabricator.wikimedia.org/T5230#1339034 (10Jdforrester-WMF)
[21:44:35] 	 6Mobile-Web, 5Patch-For-Review, 5WMF-deploy-2015-06-09_(1.26wmf9): Template should be in the View (?) - https://phabricator.wikimedia.org/T97663#1339038 (10Jdlrobson) 5Open>3Resolved
[21:44:37] 	 6Mobile-Web, 10MobileFrontend, 5Patch-For-Review, 7notice, 7user-notice: Links to talk pages in mobile view - https://phabricator.wikimedia.org/T54165#1339044 (10Jdlrobson)
[21:44:39] 	 10UI-Standardization, 6Mobile-Web, 10OOjs-UI, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned, 5Patch-For-Review: oojs ui icon name conflict ('cancel') on overlay close buttons on mobile beta/alpha - https://phabricator.wikimedia.org/T98518#1339042 (10Jdlrobson) 5Open>3Resolved @khammerstein yes.
[21:44:43] 	 6Mobile-Web, 7Accessibility, 7Mobile, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned, 5Patch-For-Review: In the mobile Web wikicode editor, saving the edit is almost impossible, because the button Suivant (Next) is missing - https://phabricator.wikimedia.org/T98505#1339045 (10kaldari) @Nnemo I would be fine...
[21:45:11] 	 (03PS2) 10Sn1per: Revert "Implement MalformedTitleException for JS and use in constructor" [core] - 10https://gerrit.wikimedia.org/r/215981 
[21:45:26] 	 10ReleaseTaggerBot: ForrestBot should run for WMF-deployed extensions as well as MediaWiki core - https://phabricator.wikimedia.org/T100347#1339055 (10Legoktm) 5Open>3Resolved Example: T97663#1339048  https://github.com/valhallasw/forrestbot/commit/902f6c4e97e28c25cef45289b6fd2c92db1cbd3a
[21:45:32] 	 10Wikimedia-Site-requests: Add Rollback and Auto-patrolled  access levels to Arabic Wikisource and wiktionary - https://phabricator.wikimedia.org/T97271#1339060 (10Mohamed.Ouda) Dear @Dereckson   could you please help
[21:45:35] 	 3Team-Practices-This-Week: Consult on Kanban for Readership - https://phabricator.wikimedia.org/T96340#1339061 (10ksmith) a:3ksmith
[21:46:25] 	 (03CR) 10Brian Wolff: Add web updater support for sql (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/211735 (owner: 10Paladox)
[21:47:13] 	 7Epic, 3Team-Practices-This-Week: Review Team Health Check retrospective for possible Q4 improvements - https://phabricator.wikimedia.org/T101444#1339064 (10ksmith) a:3ggellerman
[21:47:23] 	 10Wikipedia-iOS-App, 3Mobile-App-Sprint-58-iOS: Vertical whitespace between image and caption needs to be fixed - https://phabricator.wikimedia.org/T101186#1339066 (10Vibhabamba) Signed off by Design
[21:47:45] 	 10MediaWiki-extensions-UploadWizard, 6Multimedia: Special:UploadWizard gives undescriptive error message upon too long filename - https://phabricator.wikimedia.org/T87314#1339069 (10Sn1per)
[21:47:48] 	 10MediaWiki-Parser, 5MW-1.26-release, 5Patch-For-Review, 5WMF-deploy-2015-06-09_(1.26wmf9): Implement MalformedTextException in JS and throw from mw.Title construtor - https://phabricator.wikimedia.org/T89648#1339067 (10Sn1per) 5Resolved>3declined No use case (see https://gerrit.wikimedia.org/r/#/c/211...
[21:48:01] 	 3Team-Practices-This-Week: Update Team Health Check email invitation template to match new focus areas - https://phabricator.wikimedia.org/T93963#1339073 (10ksmith) a:3DStrine
[21:48:25] 	 (03PS13) 10Florianschmidtwelzow: Hygiene: Use Config object instead of globals [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/210649 (https://phabricator.wikimedia.org/T87614) 
[21:48:57] 	 (03PS1) 10Ottomata: [WIP] Allow Kafka writers topic and message keys to be configured using event information [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/215982 
[21:49:15] 	 (03PS9) 10Krinkle: resourceloader: Refactor ResourceLoaderWikiModule to reduce database queries [core] - 10https://gerrit.wikimedia.org/r/215857 (https://phabricator.wikimedia.org/T98087) 
[21:50:26] 	 10MediaWiki-API, 7JavaScript: mw.api.saveOption() should stringify bools in PHP style, not JS style - https://phabricator.wikimedia.org/T101322#1339078 (10Legoktm) > Forrestbot added a subscriber: matmarex.  Err, oops. That was me logged into the forrestbot account.
[21:51:15] 	 3Team-Practices-This-Week: Identify teams for Q4 health check, and facilitiators for those - https://phabricator.wikimedia.org/T101445#1339081 (10ksmith) 3NEW a:3Awjrichards
[21:51:31] 	 legoktm: Oh.. now it's querying all revisions of that page I think ;/
[21:52:08] 	 3Team-Practices-This-Week: Document plans for improving the tech debt situation - https://phabricator.wikimedia.org/T96071#1339090 (10ksmith) a:3ggellerman
[21:52:28] 	 Krinkle: you're missing the empty array for $options before $join_conds
[21:52:32] 	 10Wikipedia-iOS-App, 3Mobile-App-Sprint-58-iOS: Add CSS styling for the display title on lead image - https://phabricator.wikimedia.org/T101175#1339092 (10Vibhabamba) Verified by Design. No Patch needed.
[21:53:09] 	 ah
[21:53:11] 	 :)
[21:53:16] 	 details
[21:53:23] 	 (03CR) 10Bartosz Dziewoński: ":(" [core] - 10https://gerrit.wikimedia.org/r/215981 (owner: 10Sn1per)
[21:53:33] 	 legoktm: k, that did it.
[21:53:36] 	 inner join and left join do the same for me though.
[21:53:47] 	 so given the result is the same, does it matter?
[21:53:58] 	 3Team-Practices-This-Week: Update Team Practices page on mediawiki - https://phabricator.wikimedia.org/T97486#1339094 (10ksmith) a:3mbinder
[21:54:17] 	 3Team-Practices-This-Week: declutter/organize Team Practices Group team page on mediawiki.org - https://phabricator.wikimedia.org/T98520#1339097 (10ksmith) a:3mbinder
[21:54:31] 	 3Team-Practices-This-Week: Triage tasks in Radar column - https://phabricator.wikimedia.org/T99960#1339099 (10ksmith) a:3JAufrecht
[21:54:44] 	 the inner join will drop the page row if the revision was missing from the table
[21:54:52] 	 (03PS1) 10Kaldari: Fix the last modified bar regression for cached pages [extensions/MobileFrontend] (wmf/1.26wmf8) - 10https://gerrit.wikimedia.org/r/215983 (https://phabricator.wikimedia.org/T100429) 
[21:54:53] 	 dunno if we need to consider that?
[21:55:10] 	 sounds good
[21:57:02] 	 10MediaWiki-Vagrant, 5Patch-For-Review: git-review should be set up so it uses a single remote - https://phabricator.wikimedia.org/T59680#1339111 (10Tgr) As noted on the commit, I think this cannot be made to work without either making things insecure (e.g. storing the gerrit password on the VM) or requiring c...
[21:57:29] 	 3Team-Practices-This-Week: Document readership quarterly planning process - https://phabricator.wikimedia.org/T101446#1339112 (10KLans_WMF) 3NEW a:3KLans_WMF
[21:57:41] 	 3Team-Practices-This-Week: Identify teams for Q4 health check, and facilitiators for those - https://phabricator.wikimedia.org/T101445#1339121 (10KLans_WMF) a:5Awjrichards>3KLans_WMF
[21:57:58] 	 10MediaWiki-extensions-CentralNotice, 3Fundraising Sprint Lou Reed, 10Fundraising-Backlog: Few/no banners shown on 1 June? - https://phabricator.wikimedia.org/T101265#1339123 (10atgo)
[21:58:16] 	 10MediaWiki-extensions-CentralNotice, 3Fundraising Sprint Lou Reed, 10Fundraising-Backlog: Few/no banners shown on 1 June? - https://phabricator.wikimedia.org/T101265#1333901 (10atgo) Unplanned work doesn't get story points
[21:58:19] 	 10Shop-Theme: [Ipad] "Men" link missing from left slide menu - https://phabricator.wikimedia.org/T88608#1339126 (10HuiZSF) This problem has been resolved. It does not exist on the new theme anymore...
[21:58:28] 	 10Shop-Theme: [Ipad] "Men" link missing from left slide menu - https://phabricator.wikimedia.org/T88608#1339127 (10HuiZSF) 5Open>3Resolved
[21:58:41] 	 (03CR) 10Paladox: Add web updater support for sql (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/211735 (owner: 10Paladox)
[21:58:51] 	 10Shop-Theme: [Ipad & Mobile] Lapel Pin page description overlaps footer - https://phabricator.wikimedia.org/T88607#1339128 (10HuiZSF) 5Open>3Resolved
[22:00:35] 	 10Wikipedia-iOS-App, 3Mobile-App-Sprint-58-iOS, 3Roadmap, 7notice: iOS Release 4.1.4 (130) - https://phabricator.wikimedia.org/T100685#1339131 (10greg) 5Open>3Resolved a:3greg > Fjalapeno moved this task to Done on the Wikipedia-iOS-App workboard.  Taking that as closing (curious, are you purposefull...
[22:02:02] 	 6Search-and-Discovery: Create a document listing potential customers of maps - https://phabricator.wikimedia.org/T101448#1339146 (10ksmith) 3NEW
[22:02:18] 	 7Tracking: Improve mobile uploads (tracking) - https://phabricator.wikimedia.org/T70376#1339165 (10Jdlrobson)
[22:02:21] 	 6Mobile-Web: Cannot easily retry upload - https://phabricator.wikimedia.org/T47377#1339162 (10Jdlrobson) 5Open>3declined a:3Jdlrobson Upload feature was removed.
[22:02:32] 	 7Design, 6Mobile-Web: Rethink the upload summaries for photo uploads from mobile - https://phabricator.wikimedia.org/T60983#1339166 (10Jdlrobson) 5Open>3declined a:3Jdlrobson Upload feature was removed.
[22:02:34] 	 7Tracking: Improve mobile uploads (tracking) - https://phabricator.wikimedia.org/T70376#736937 (10Jdlrobson)
[22:02:40] 	 6Mobile-Web: Upload page-action button sometimes visible, sometimes not - https://phabricator.wikimedia.org/T87075#1339170 (10Jdlrobson) 5Open>3declined a:3Jdlrobson Upload feature was removed.
[22:02:48] 	 7Tracking: Improve mobile uploads (tracking) - https://phabricator.wikimedia.org/T70376#736937 (10Jdlrobson)
[22:02:51] 	 6Mobile-Web: File upload token errors - https://phabricator.wikimedia.org/T64587#1339173 (10Jdlrobson) 5Open>3declined a:3Jdlrobson Upload feature was removed.
[22:03:01] 	 6Mobile-Web: Uploads: cannot upload a photo - https://phabricator.wikimedia.org/T86348#1339178 (10Jdlrobson) 5Open>3declined a:3Jdlrobson Upload feature was removed.
[22:03:43] 	 6Mobile-Web: Image taken in portrait mode is uploaded as landscape - https://phabricator.wikimedia.org/T71962#1339184 (10Jdlrobson) 5Open>3declined a:3Jdlrobson Upload feature was removed.
[22:04:07] 	 10MediaWiki-General-or-Unknown, 10Librarization, 5MW-1.26-release, 5Patch-For-Review, 5WMF-deploy-2015-06-09_(1.26wmf9): Standardise HttpStatus header handling - https://phabricator.wikimedia.org/T100984#1339188 (10Krinkle) 5Open>3Resolved
[22:04:17] 	 (03CR) 10Brian Wolff: "For the shared part. If DatabaseUpdater was changed so that a second hook was run when it was started in shared mode (e.g. LoadExtensionSc" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/211735 (owner: 10Paladox)
[22:05:19] 	 6Search-and-Discovery: Publicly announce plans for WDQS - https://phabricator.wikimedia.org/T101450#1339192 (10ksmith) 3NEW
[22:06:26] 	 10Gather: API: Allow sorting of a users collections by last modified - https://phabricator.wikimedia.org/T94762#1339199 (10Tgr) Easy, just change the ORDER BY clause and the continuation. We don't expect users to have thousands of lists, so no need to add another index, IMO.
[22:07:36] 	 10MediaWiki-extensions-UploadWizard, 6Commons, 6Multimedia, 5Patch-For-Review, and 2 others: Remove Flickr checking from client side - https://phabricator.wikimedia.org/T100062#1339201 (10Bawolff)
[22:07:41] 	 10MediaWiki-extensions-MultimediaViewer, 6Commons, 6Multimedia: Filename unreadable when browsing Commons categories - https://phabricator.wikimedia.org/T101391#1339205 (10Tgr) Can you make a full-window screenshot? It's hard to tell from this what's going on. Normally, filename should not be visible at all...
[22:08:23] 	 (03PS1) 10Ferdbold: Edit graph name within VisualEditor [extensions/Graph] - 10https://gerrit.wikimedia.org/r/215987 
[22:10:52] 	 10Gather: Research - Is collections more useful than random? - https://phabricator.wikimedia.org/T101332#1339208 (10JKatzWMF) @khammerstein okay, but we wont be able to compare it to the random unless we start out without the tipsy in hamburger...I'm inclined to start with the tipsy rather than moving it up--sin...
[22:11:48] 	 (03PS2) 10Ferdbold: Edit graph name within VisualEditor [extensions/Graph] - 10https://gerrit.wikimedia.org/r/215987 
[22:12:51] 	 10Shop-Theme: [Desktop - Safari] "scroll up" shows a secondary menu (see image) - https://phabricator.wikimedia.org/T98250#1339210 (10HuiZSF) I have restricted the `off-navigation` layer not to show on width > 992px of screen. Could you please try again on safari @vshchepakina @goenning?
[22:13:02] 	 6Mobile-Web: Error toast rather than AbuseFilterPanel when photo upload itself triggers AbuseFilter - https://phabricator.wikimedia.org/T63975#1339214 (10Jdlrobson) 5Open>3declined a:3Jdlrobson Feature was removed.
[22:13:04] 	 7Tracking: Improve mobile uploads (tracking) - https://phabricator.wikimedia.org/T70376#1339217 (10Jdlrobson)
[22:13:11] 	 6Mobile-Web: AbuseFilterPanel on lead photo upload is too easy too ignore. - https://phabricator.wikimedia.org/T63976#1339219 (10Jdlrobson) 5Open>3declined a:3Jdlrobson Feature was removed.
[22:14:17] 	 10Wikimedia-General-or-Unknown, 10Wikimedia-Mailing-lists: Protect outgoing emails with SMTP STARTLS - https://phabricator.wikimedia.org/T101451#1339223 (10Platonides) 3NEW
[22:14:29] 	 10Wikimedia-General-or-Unknown, 10Wikimedia-Mailing-lists: Protect incoming emails with SMTP STARTLS - https://phabricator.wikimedia.org/T101452#1339230 (10Platonides) 3NEW
[22:17:22] 	 (03CR) 10Catrope: [C: 032] Be stricter when checking user [extensions/Flow] - 10https://gerrit.wikimedia.org/r/215909 (owner: 10Matthias Mullie)
[22:19:32] 	 6Mobile-Web: Cannot see entire contents of Special:EditWatchlist - https://phabricator.wikimedia.org/T101453#1339245 (10Jdlrobson) 3NEW
[22:19:52] 	 6Search-and-Discovery: Publicly announce plans for WDQS - https://phabricator.wikimedia.org/T101450#1339253 (10ksmith) Stas pointed out that we should reveal our plans for both WQS (Magnus's tool) and WDQS (the newfangled thing).
[22:20:01] 	 6Mobile-Web, 10MobileFrontend: Add 'more' button at end of watch list feed, to look further in history - https://phabricator.wikimedia.org/T70368#1339254 (10Jdlrobson)
[22:20:41] 	 (03CR) 10Catrope: [C: 04-1] "These newly added exceptions trigger 7 times in the tests, that's why Jenkins V-1ed" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/215909 (owner: 10Matthias Mullie)
[22:20:44] 	 (03PS1) 10Chad: Phabricator role: Don't need to set upload-size-limit anymore [vagrant] - 10https://gerrit.wikimedia.org/r/215989 
[22:21:40] 	 6Mobile-Web: Cannot see entire contents of Special:EditWatchlist - https://phabricator.wikimedia.org/T101453#1339245 (10Jdlrobson)
[22:21:43] 	 6Mobile-Web: Infinite scrolling Special:EditWatchlist on mobile incorrectly identifies pages as not existing. - https://phabricator.wikimedia.org/T94505#1339257 (10Jdlrobson)
[22:21:56] 	 6Mobile-Web: Infinite scrolling Special:EditWatchlist on mobile incorrectly identifies pages as not existing. - https://phabricator.wikimedia.org/T94505#1165345 (10Jdlrobson) Cannot verify if this is still happening as the infinite scroll seems to be broken.
[22:22:24] 	 (03PS4) 10Bartosz Dziewoński: Move '@media print' rules to separate file [extensions/Cite] - 10https://gerrit.wikimedia.org/r/212009 (https://phabricator.wikimedia.org/T93746) 
[22:23:54] 	 6Mobile-Web, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned: Zoom problem when adding by search in gather on iOS - https://phabricator.wikimedia.org/T101454#1339261 (10JKatzWMF) 3NEW
[22:24:31] 	 6Mobile-Web, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned: Zoom problem when adding by search in gather on iOS - https://phabricator.wikimedia.org/T101454#1339269 (10JKatzWMF)
[22:24:59] 	 6Mobile-Web, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned: Zoom problem when adding by search in gather on iOS - https://phabricator.wikimedia.org/T101454#1339261 (10JKatzWMF)
[22:25:22] 	 10Shop-Theme: [Desktop - Safari] "scroll up" shows a secondary menu (see image) - https://phabricator.wikimedia.org/T98250#1339272 (10goenning) It worked @HuiZSF! Many thanks!
[22:25:29] 	 (03CR) 10Bartosz Dziewoński: "This is just extracted from ve.ui.MWTitleInputWidget in VE, not new code. Presumably this works correctly there." [core] - 10https://gerrit.wikimedia.org/r/206404 (owner: 10Jforrester)
[22:26:46] 	 (03CR) 10Bartosz Dziewoński: "(grandchild = https://gerrit.wikimedia.org/r/#/c/214821/)" [core] - 10https://gerrit.wikimedia.org/r/213504 (owner: 10Catrope)
[22:26:58] 	 10crosswatch: patrol support - https://phabricator.wikimedia.org/T101455#1339275 (10Sitic) 3NEW a:3Sitic
[22:27:27] 	 10MediaWiki-extensions-GWToolset, 6Commons, 6Multimedia: GWToolset needs cancel functionality - https://phabricator.wikimedia.org/T100972#1339284 (10Tgr) @aaron, what do you think? Do you see value in having some generic job kill functionality?
[22:27:56] 	 6Mobile-Web: Uploads AbuseFilter styling regression - https://phabricator.wikimedia.org/T65332#1339286 (10Jdlrobson) 5Open>3declined a:3Jdlrobson Upload feature has been removed from MobileFrontend.
[22:27:58] 	 7Tracking: Improve mobile uploads (tracking) - https://phabricator.wikimedia.org/T70376#1339289 (10Jdlrobson)
[22:28:00] 	 6Mobile-Web: Show duplicate error message - https://phabricator.wikimedia.org/T70296#1339290 (10Jdlrobson) Upload feature has been removed from MobileFrontend.
[22:28:07] 	 10crosswatch: flaggedrevs support - https://phabricator.wikimedia.org/T101456#1339291 (10Sitic) 3NEW a:3Sitic
[22:28:13] 	 10MediaWiki-extensions-UploadWizard, 6Multimedia: UploadWizard should not use jquery ui - https://phabricator.wikimedia.org/T97203#1339300 (10Jdlrobson)
[22:28:31] 	 10MediaWiki-extensions-UploadWizard, 6Mobile-Web, 6Multimedia: [EPIC] Enable UploadWizard on mobile - https://phabricator.wikimedia.org/T97169#1339302 (10Jdlrobson)
[22:29:20] 	 7Tracking: Improve mobile uploads (tracking) - https://phabricator.wikimedia.org/T70376#736937 (10Jdlrobson)
[22:29:22] 	 6Mobile-Web: Show duplicate error message - https://phabricator.wikimedia.org/T70296#1339308 (10Jdlrobson) 5Open>3declined a:3Jdlrobson
[22:31:00] 	 (03CR) 10BryanDavis: [C: 032] Phabricator role: Don't need to set upload-size-limit anymore [vagrant] - 10https://gerrit.wikimedia.org/r/215989 (owner: 10Chad)
[22:31:03] 	 6Search-and-Discovery: Publicly announce plans for WDQS - https://phabricator.wikimedia.org/T101450#1339316 (10ksmith) Erm. I think Magnus's tool is WDQ, not WQS.
[22:31:22] 	 (03Merged) 10jenkins-bot: Phabricator role: Don't need to set upload-size-limit anymore [vagrant] - 10https://gerrit.wikimedia.org/r/215989 (owner: 10Chad)
[22:32:37] 	 10MediaWiki-extensions-GWToolset, 6Commons, 6Multimedia: GWToolset needs cancel functionality - https://phabricator.wikimedia.org/T100972#1339317 (10aaron) I'd stick with the GWT specific solution of some key to check (perhaps using memcached).
[22:32:53] 	 6Mobile-Web, 3Mobile-Web-Design: Move lead paragraph above other article content - https://phabricator.wikimedia.org/T91712#1339320 (10KHammerstein)
[22:33:27] 	 6Mobile-Web, 3Mobile-Web-Design: Move lead paragraph above other article content - https://phabricator.wikimedia.org/T91712#1094185 (10KHammerstein) Changed the title based on @mhurd's comment:  On apps we started moving infoboxes down, but found it's much better (fewer edge case etc) to move the first "good"...
[22:34:36] 	 (03CR) 10Legoktm: Make sure correct request user is used when rendering page (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/215908 (https://phabricator.wikimedia.org/T101388) (owner: 10Matthias Mullie)
[22:35:15] 	 10Shop-Theme: [Desktop - Safari] "scroll up" shows a secondary menu (see image) - https://phabricator.wikimedia.org/T98250#1339334 (10HuiZSF) 5Open>3Resolved
[22:39:01] 	 10MediaWiki-extensions-UploadWizard, 6Mobile-Web, 6Multimedia, 7Epic: [EPIC] Enable UploadWizard on mobile - https://phabricator.wikimedia.org/T97169#1339349 (10Tgr)
[22:41:02] 	 10Gather, 6Mobile-Web, 10MobileFrontend, 7Epic, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned: [EPIC] Create a formal release process for MobileFrontend/Gather - https://phabricator.wikimedia.org/T100296#1339355 (10Tgr)
[22:41:32] 	 6Mobile-Web, 7Epic, 7Technical-Debt, 7Tracking: [EPIC] Repurpose MobileFrontend as Minerva skin - https://phabricator.wikimedia.org/T71366#1339363 (10Tgr)
[22:41:47] 	 10Gather, 6Mobile-Web, 10MobileFrontend, 7Epic, and 2 others: [EPIC] Turn off alpha - https://phabricator.wikimedia.org/T100297#1339365 (10Tgr)
[22:42:07] 	 3Mobile-App-Sprint-59-Android, 3Mobile-App-Sprint-59-iOS: Extract exact license info for share a fact cards - https://phabricator.wikimedia.org/T101436#1339368 (10Moushira) a:3Slaporte
[22:42:26] 	 3Mobile-Web-Sprint-48-Voyage-of-the-Damned: [MobileWebEditing] Missing or empty schema - https://phabricator.wikimedia.org/T101195#1339371 (10bmansurov) Can you add steps to reproduce? Or at least a link to where this is happening?
[22:42:41] 	 (03CR) 10Paladox: "This was never merge either needs redoing or doing verified manually." [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/214433 (https://phabricator.wikimedia.org/T99949) (owner: 10Christopher Johnson (WMDE))
[22:43:14] 	 spagewmf: http://devhub.wmflabs.org/wiki/API:Data_and_developer_hub :-*
[22:43:57] 	 6Mobile-Web: Promote 'Link preview' to beta - https://phabricator.wikimedia.org/T100726#1339378 (10Jdlrobson) Renaming to Hovercards would at least give product consistency..
[22:44:14] 	 6Mobile-Web: Create a tutorial (similar to edit tutorial, or gather tutorial) about how to use the quickLookup feature - https://phabricator.wikimedia.org/T100679#1339380 (10Jdlrobson) What would this look like?
[22:44:17] 	 James_F: I'm not sure what your emoticon connotes (denotes? conveys?)
[22:44:29] 	 10MediaWiki-extensions-DonationInterface, 3Fundraising Sprint Lou Reed, 10Fundraising Tech Backlog, 10Wikimedia-Fundraising, 5Patch-For-Review: Bad gateway error should be more helpful - https://phabricator.wikimedia.org/T100584#1339383 (10Ejegg) 5Open>3Resolved
[22:44:48] 	 spagewmf: Shock and sadness about creating yet another damn wiki after the last four community conversations were all in agreement about never doing it again.
[22:45:18] 	 10Gather, 5Patch-For-Review, 7Schema-change: Add (list, title) index for Gather lists - https://phabricator.wikimedia.org/T98490#1339384 (10Tgr)
[22:45:30] 	 James_F: thanks for your support.  T101441
[22:45:31] 	 integrate new Developer hub with mediawiki.org
[22:45:46] 	 10Gather, 7I18n, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned: GENDER support in gather-no-public-lists-description - https://phabricator.wikimedia.org/T99058#1339386 (10Jdlrobson) a:3Jdlrobson
[22:46:20] 	 (03PS2) 10Paladox: Add gitreview config file to repo [phabricator/tools] - 10https://gerrit.wikimedia.org/r/179090 (owner: 10Gilles)
[22:46:21] 	 James_F: qgil and I went back and forth whether to soft-launch it here or at https://www.mediawiki.org/wiki/API:Data_and_developer_hub
[22:46:32] 	 spagewmf: mw.org!
[22:46:40] 	 10dev.wikimedia.org, 7Epic: integrate new Developer hub with mediawiki.org - https://phabricator.wikimedia.org/T101441#1339392 (10Jdforrester-WMF) +1
[22:47:20] 	 10MediaWiki-General-or-Unknown, 10Librarization, 5MW-1.26-release, 5Patch-For-Review, 5WMF-deploy-2015-06-09_(1.26wmf9): Standardise HttpStatus header handling - https://phabricator.wikimedia.org/T100984#1339394 (10Krinkle) >>! In T100984#1326227, @Anomie wrote: >>>! In T100984#1326036, @Krinkle wrote: >...
[22:47:23] 	 James_F: third-party developers *tune out* Wikimedia goodness when they see yet another shitty crapp[py goddamn Vector-skinned wiiki site from 1998.
[22:47:39] 	 James_F: not my attitude, but it's theirs.
[22:47:57] 	 (03PS2) 10Paladox: Crude mingle migration script [phabricator/tools] - 10https://gerrit.wikimedia.org/r/179091 (owner: 10Gilles)
[22:47:58] 	 spagewmf: We could just not run MW.org with Vector.
[22:48:17] 	 6Mobile-Web: Create a tutorial (similar to edit tutorial, or gather tutorial) about how to use the quickLookup feature - https://phabricator.wikimedia.org/T100679#1339395 (10bmansurov) Just a couple of sentences that tells the user how to use the feature. Something like: "Did you know that you can flick wiki lin...
[22:48:18] 	 spagewmf: [ box ] think. ;-)
[22:48:19] 	 James_F: if you want to help, support getting the Living Style Guide on mw.org, along withthe Blueprint skin
[22:48:31] 	 (03PS1) 10Chad: APCU: Be more explicit with package, tune for developers [vagrant] - 10https://gerrit.wikimedia.org/r/215996 
[22:48:56] 	 spagewmf: Has it gone through a security review?
[22:49:25] 	 (03PS3) 10Bartosz Dziewoński: Convert Special:Search to OOUI [core] - 10https://gerrit.wikimedia.org/r/214821 (https://phabricator.wikimedia.org/T100898) 
[22:49:33] 	 James_F: I assume not.  We should ask prtksxna and werdna_  :), or really :(  https://phabricator.wikimedia.org/T93610 is the bug
[22:49:34] 	 spagewmf: If so, adding it shouldn't be much work.
[22:49:53] 	 spagewmf: Fun.
[22:50:17] 	 ostriches: php-apc doesn't install apcu?
[22:50:25] 	 It does
[22:50:35] 	 But I prefer explicitness
[22:50:39] 	 10MediaWiki-API: imageinfo should return info for other files when one file gets a iiurlparamnormal error. - https://phabricator.wikimedia.org/T101457#1339400 (10Ragesoss) 3NEW
[22:50:40] 	 since I was there
[22:50:50] 	 And I had to grep the wrong thing
[22:50:54] 	 James_F: are you the PM for http://livingstyleguide.wmflabs.org ? You can make it happen!
[22:51:10] 	 (03PS1) 10Jdlrobson: i18n: Add gender support to no public view [extensions/Gather] - 10https://gerrit.wikimedia.org/r/215997 (https://phabricator.wikimedia.org/T99058) 
[22:51:23] 	 10Wikipedia-iOS-App, 3Mobile-App-Sprint-58-iOS: Improve the lead image load in performance - https://phabricator.wikimedia.org/T101188#1339410 (10Vibhabamba) Discussed this with mhurd after reviewing a lot of BLP articles. Don't delay loading of the image for face detection. Ok to load and then move the y posi...
[22:51:55] 	 3Mobile-App-Sprint-59-Android, 3Mobile-App-Sprint-59-iOS: Extract exact license info for share a fact cards - https://phabricator.wikimedia.org/T101436#1339413 (10Moushira) a:5Slaporte>3None
[22:52:13] 	 legoktm: yay, the exact load url is perserved when making an edit and doing another edit that makes the contnet the same as before
[22:52:21] 	 woo :D
[22:52:25] 	 spagewmf: L&F is a Reading not Editing area.
[22:52:28] 	 (03CR) 10Aaron Schulz: resourceloader: Refactor ResourceLoaderWikiModule to reduce database queries (032 comments) [core] - 10https://gerrit.wikimedia.org/r/215857 (https://phabricator.wikimedia.org/T98087) (owner: 10Krinkle)
[22:52:41] 	 (03PS10) 10Krinkle: resourceloader: Refactor ResourceLoaderWikiModule to reduce database queries [core] - 10https://gerrit.wikimedia.org/r/215857 (https://phabricator.wikimedia.org/T98087) 
[22:52:46] 	 spagewmf: So no, ask Jon Katz.
[22:52:58] 	 10Wikipedia-iOS-App, 3Mobile-App-Sprint-58-iOS: Improve the lead image load in performance - https://phabricator.wikimedia.org/T101188#1339415 (10Vibhabamba) We tested both android and ios on the same network - using this patch (https://phabricator.wikimedia.org/T97730) Seems to be speed up lead image display...
[22:53:02] 	 (03CR) 10Aaron Schulz: resourceloader: Refactor ResourceLoaderWikiModule to reduce database queries (031 comment) [core] - 10https://gerrit.wikimedia.org/r/215857 (https://phabricator.wikimedia.org/T98087) (owner: 10Krinkle)
[22:53:33] 	 James_F: thanks.  I use {{dev hub}} to link to the pages, maybe the template can do sentiment analysis to figure out if the reader wants to see consistency or novelty
[22:53:49] 	 10Wikipedia-iOS-App, 3Mobile-App-Sprint-58-iOS: Improve the lead image load in performance - https://phabricator.wikimedia.org/T101188#1339417 (10Vibhabamba) We also increased the height of the lead image display by a small amount to match Android (which was based on golden ratio)
[22:53:52] 	 spagewmf: :-)
[22:54:49] 	 AaronSchulz: hold on, WIP.
[22:54:54] 	 Those cache fields aren't used.
[22:55:15] 	 based on legoktm's feedback in relation to GlobalCssJs extension, I;m changing the approach
[22:55:28] 	 (03PS1) 10Chad: Phab config: don't pass $deploy_dir, just full qualify it [vagrant] - 10https://gerrit.wikimedia.org/r/215998 
[22:55:38] 	 had some local debugging vars to dump rows 
[22:55:59] 	 AaronSchulz: Regarding revision join key, why is it easier to read from revision instead of page? Just curious, I'll update it .
[22:56:30] 	 (03PS1) 10Chad: Phabricator: Turn on developer mode [vagrant] - 10https://gerrit.wikimedia.org/r/215999 
[22:56:36] 	 (03CR) 10Mattflaschen: [C: 04-1] "Per Legoktm, not sure this is the right solution." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/215908 (https://phabricator.wikimedia.org/T101388) (owner: 10Matthias Mullie)
[22:58:09] 	 (03PS1) 10Chad: Phabricator config: Whitespace cleanup [vagrant] - 10https://gerrit.wikimedia.org/r/216000 
[22:59:29] 	 6Research-and-Data: Fundraising recurring estimate fiscal year 2015 - 2016 - https://phabricator.wikimedia.org/T99190#1339434 (10ellery) How much can we expect to raise from existing recurring donations in the 2015-2016 fiscal year?
[23:00:29] 	 (03CR) 10Krinkle: resourceloader: Refactor ResourceLoaderWikiModule to reduce database queries (033 comments) [core] - 10https://gerrit.wikimedia.org/r/215857 (https://phabricator.wikimedia.org/T98087) (owner: 10Krinkle)
[23:01:06] 	 (03CR) 10Bmansurov: [C: 04-1] "Looks good. The documentation needs to be updated though." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203266 (https://phabricator.wikimedia.org/T97592) (owner: 10Jdlrobson)
[23:01:34] 	 10Wikimedia-General-or-Unknown, 7Schema-change, 7Tracking: Schema changes for Wikimedia wikis (tracking) - https://phabricator.wikimedia.org/T51188#1339454 (10Tgr)
[23:02:42] 	 10Wikimedia-General-or-Unknown, 7Schema-change, 7Tracking: Schema changes for Wikimedia wikis (tracking) - https://phabricator.wikimedia.org/T51188#552702 (10Tgr) How is this related to the #schema-change project? Is that project supposed to cover all schema changes, whether the extension is deployed on WMF...
[23:02:49] 	 6Mobile-Web, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned: Zoom problem when adding by search in gather on iOS - https://phabricator.wikimedia.org/T101454#1339459 (10Jdlrobson) Zoom usually happens when text is too small. Can you confirm if this also happens on the standard Wikipedia search interface?
[23:03:11] 	 (03CR) 10Kaldari: [C: 032] Fix the last modified bar regression for cached pages [extensions/MobileFrontend] (wmf/1.26wmf8) - 10https://gerrit.wikimedia.org/r/215983 (https://phabricator.wikimedia.org/T100429) (owner: 10Kaldari)
[23:04:46] 	 10Gather, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned, 5Patch-For-Review, 7Schema-change: API: Allow filtering of collections - https://phabricator.wikimedia.org/T97061#1339460 (10Tgr)
[23:04:55] 	 (03Merged) 10jenkins-bot: Fix the last modified bar regression for cached pages [extensions/MobileFrontend] (wmf/1.26wmf8) - 10https://gerrit.wikimedia.org/r/215983 (https://phabricator.wikimedia.org/T100429) (owner: 10Kaldari)
[23:05:14] 	 10Gather, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned, 7Schema-change: Add gather_list.gl_item_count - https://phabricator.wikimedia.org/T101460#1339463 (10Tgr) 3NEW a:3Tgr
[23:05:16] 	 10Gather, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned: Updating my Gather collection with additional articles and saving made it empty. - https://phabricator.wikimedia.org/T99922#1339470 (10Jdlrobson) I can't replicate this so far.... and cannot find any exceptions in logstash. Not sure how to debug this withou...
[23:05:35] 	 10Gather, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned, 7Schema-change: Add gather_list.gl_item_count - https://phabricator.wikimedia.org/T101460#1339475 (10Tgr)
[23:05:38] 	 10Wikimedia-General-or-Unknown, 7Schema-change, 7Tracking: Schema changes for Wikimedia wikis (tracking) - https://phabricator.wikimedia.org/T51188#1339474 (10Tgr)
[23:06:23] 	 Krinkle, it's natural to read select from 'page' where  JOIN on 'revision' 
[23:06:33] 	 6Phabricator, 6operations: Moving procurement from RT to Phabricator - https://phabricator.wikimedia.org/T93760#1339479 (10Qgil) Is or could be {T823} a blocker for this task?
[23:06:46] 	 since the conds are for the page table
[23:06:51] 	 10Continuous-Integration-Config, 10Gather, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned, 5Patch-For-Review: PHPUnit tests do not get run by Jenkins for Gather commits - https://phabricator.wikimedia.org/T96904#1339481 (10Jdlrobson) Any updates on this? @tgr were you able to take a look?
[23:07:14] 	 AaronSchulz: Right.
[23:07:30] 	 AaronSchulz: But the way out interface abstract it, it might as well be select from revision where conds JOIN on page
[23:07:43] 	 does it change the query?
[23:08:02] 	 I guess it would make a difference if it wasn't inner join
[23:08:56] 	 query is the same
[23:09:08] 	 and the planner will reorder it to start with page
[23:09:14] 	 it's just style
[23:09:17] 	 OK
[23:09:42] 	 (03PS11) 10Krinkle: resourceloader: Refactor ResourceLoaderWikiModule to reduce database queries [core] - 10https://gerrit.wikimedia.org/r/215857 (https://phabricator.wikimedia.org/T98087) 
[23:09:44] 	 (03PS1) 10Kaldari: Update MobileFrontend [core] (wmf/1.26wmf8) - 10https://gerrit.wikimedia.org/r/216001 
[23:10:14] 	 6Research-and-Data: Fundraising recurring estimate fiscal year 2015 - 2016 - https://phabricator.wikimedia.org/T99190#1339482 (10ellery) We can expect to raise approximately 3.7 million from our current set recurring donors in the  2015-2016 fiscal year. For reference, last calendar year (2014) we raised 2.8 mil...
[23:10:22] 	 AaronSchulz: OK. PS11 is ready now.
[23:10:47] 	 10Gather, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned: Updating my Gather collection with additional articles and saving made it empty. - https://phabricator.wikimedia.org/T99922#1339484 (10Moushira) Sorry late reply.  I did check,  couldn't find anything significant as far as my Hebrew could help.   @Ijon?
[23:12:56] 	 (03CR) 10Kaldari: [C: 032] Update MobileFrontend [core] (wmf/1.26wmf8) - 10https://gerrit.wikimedia.org/r/216001 (owner: 10Kaldari)
[23:14:38] 	 3Mobile-Web-Sprint-48-Voyage-of-the-Damned: [MobileWebEditing] Missing or empty schema - https://phabricator.wikimedia.org/T101195#1339485 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson Can not longer replicate this on beta labs. Guess it was a blip.
[23:18:09] 	 7Design, 10UI-Standardization, 10OOjs-UI, 5Patch-For-Review: OOjs UI ComboBox design needed - https://phabricator.wikimedia.org/T87832#1339490 (10Mattflaschen)
[23:18:20] 	 (03CR) 10Krinkle: resourceloader: Refactor ResourceLoaderWikiModule to reduce database queries (031 comment) [core] - 10https://gerrit.wikimedia.org/r/215857 (https://phabricator.wikimedia.org/T98087) (owner: 10Krinkle)
[23:18:50] 	 7Design, 10UI-Standardization, 10OOjs-UI, 5Patch-For-Review: OOjs UI ComboBox design needed (MediaWiki theme) - https://phabricator.wikimedia.org/T87832#1000204 (10Mattflaschen)
[23:18:53] 	 6Phabricator, 6Research-and-Data, 6Team-Practices: Migration of Research & Data to Phabricator - https://phabricator.wikimedia.org/T826#1339492 (10ggellerman) Research team is in Phab.  Per @DarTar the remaining Trello boards do not need to be migrated.
[23:19:49] 	 10MediaWiki-extensions-ProofreadPage: Automatically fill the proofreading user on API edit - https://phabricator.wikimedia.org/T101461#1339496 (10Tpt) 3NEW
[23:19:52] 	 10UI-Standardization, 10VisualEditor: Save dialog should use OOJS-UI (MW-UI) checkboxes - https://phabricator.wikimedia.org/T86617#1339504 (10Mattflaschen) Maybe it could use OO.ui.infuse (with some custom code to transform it pre-infuse if needed)?
[23:20:02] 	 10UI-Standardization, 10VisualEditor: Save dialog should use OOJS-UI checkboxes - https://phabricator.wikimedia.org/T86617#1339505 (10Mattflaschen)
[23:20:29] 	 10Gather, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned: Updating my Gather collection with additional articles and saving made it empty. - https://phabricator.wikimedia.org/T99922#1339507 (10Jdlrobson) a:3Jdlrobson
[23:21:14] 	 6Research-and-Data: Move #Research and Data tasks from Trello to Phabricator - https://phabricator.wikimedia.org/T772#1339509 (10ggellerman) Research is in Phab- no need to migrate the remaining Trello boards
[23:21:21] 	 6Research-and-Data: Move #Research and Data tasks from Trello to Phabricator - https://phabricator.wikimedia.org/T772#1339510 (10ggellerman) 5Open>3Resolved
[23:21:23] 	 6Phabricator, 6Research-and-Data, 6Team-Practices: Migration of Research & Data to Phabricator - https://phabricator.wikimedia.org/T826#1339511 (10ggellerman)
[23:21:27] 	 10Gather, 6Mobile-Web, 10MobileFrontend, 7Epic, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned: [EPIC] Run browser tests against every MobileFrontend/Gather patch - https://phabricator.wikimedia.org/T100293#1339514 (10Jdlrobson)
[23:21:40] 	 10UI-Standardization, 6Mobile-Web, 7Technical-Debt: OOjs UI uses different class names to mobile - leads to duplicate CSS - https://phabricator.wikimedia.org/T66973#1339517 (10Mattflaschen) Don't think this is a bug in OOjs UI.  OOjs UI is a standalone library, so it can't remove rules just because Mobile ha...
[23:22:09] 	 (03PS5) 10Catrope: Automatically infuse any infusable OOUI widgets present on the page [core] - 10https://gerrit.wikimedia.org/r/213505 
[23:22:19] 	 (03Merged) 10jenkins-bot: Update MobileFrontend [core] (wmf/1.26wmf8) - 10https://gerrit.wikimedia.org/r/216001 (owner: 10Kaldari)
[23:22:50] 	 hello
[23:23:34] 	 6Mobile-Web: [EPIC] Merge OOJS UI library and Mobile unnamed library. - https://phabricator.wikimedia.org/T101462#1339519 (10Jdlrobson) 3NEW
[23:23:46] 	 6Mobile-Web: [EPIC] Merge OOJS UI library and Mobile unnamed library. - https://phabricator.wikimedia.org/T101462#1339527 (10Jdlrobson)
[23:24:29] 	 6Mobile-Web: [EPIC] Merge OOJS UI library and Mobile unnamed library. - https://phabricator.wikimedia.org/T101462#1339519 (10Jdlrobson)
[23:24:30] 	 10UI-Standardization, 6Mobile-Web, 7Technical-Debt: OOjs UI uses different class names to mobile - leads to duplicate CSS - https://phabricator.wikimedia.org/T66973#1339529 (10Jdlrobson)
[23:24:40] 	 10MediaWiki-extensions-MultimediaViewer, 10UI-Standardization, 6Multimedia: Standardize MultimediaViewer styles - https://phabricator.wikimedia.org/T77290#1339532 (10Mattflaschen)
[23:25:04] 	 i have been tryin to setup my development environment, i managed to setup mediawiki on my machine. so i do not know what to do next. any help please
[23:26:14] 	 10Gather, 6Mobile-Web, 10MobileFrontend, 7Epic, and 2 others: [EPIC] Turn off alpha - https://phabricator.wikimedia.org/T100297#1339534 (10Jdlrobson)
[23:26:15] 	 6Mobile-Web, 7Technical-Debt, 7Tracking: [Tracking] Getting rid of own login page - https://phabricator.wikimedia.org/T74910#1339535 (10Jdlrobson)
[23:26:30] 	 7Design, 10UI-Standardization, 6Collaboration-Team, 10Flow, and 2 others: Upstream menu to mediawiki ui and document so it appears in the styleguide - https://phabricator.wikimedia.org/T70748#1339539 (10Mattflaschen) If we're deprecating MW UI ({T100270}, we probably shouldn't be adding new features.  Sinc...
[23:26:41] 	 7Design, 10UI-Standardization, 6Collaboration-Team, 10Flow, and 2 others: Upstream menu to OOjs UI and document so it appears in the styleguide - https://phabricator.wikimedia.org/T70748#1339543 (10Mattflaschen)
[23:26:46] 	 Dagy: hi! what are you trying to do?
[23:27:14] 	 i want to fix moile web bugs
[23:27:27] 	 i want to fix mobile web bugs
[23:28:03] 	 irc://freenode/legoktm,isnick so i do not know what to do next
[23:28:04] 	 10UI-Standardization: Use OOjs UI elements on Special:AllMessages - https://phabricator.wikimedia.org/T73254#1339544 (10Mattflaschen)
[23:28:27] 	 10Shop-Theme: [Mobile] Footer isn't organized properly. - https://phabricator.wikimedia.org/T97317#1339545 (10HuiZSF) 5Open>3Resolved
[23:28:41] 	 Dagy: unfortunately, I don't see any mobile web bugs that are marked as "easy", so it might not be the best place to get started. You could try working on some easy MediaWiki bugs though
[23:28:54] 	 (03CR) 10Krinkle: Automatically infuse any infusable OOUI widgets present on the page (031 comment) [core] - 10https://gerrit.wikimedia.org/r/213505 (owner: 10Catrope)
[23:29:14] 	 3Team-Practices-This-Week: Document Best Practices for tracking and working with Epics - https://phabricator.wikimedia.org/T99956#1339547 (10ksmith) a:5ksmith>3JAufrecht I have a few issues with the current state. Maybe we should do another 30-minute real-time collaboration to try to refine it.   For the TBD...
[23:29:19] 	 7Design, 10MediaWiki-History-or-Diffs, 7JavaScript: Use  instead of