[16:56:51] 4(no projects): distribution upgrade for wikitech-static instance - https://phabricator.wikimedia.org/T94585#1167475 (10Dzahn) 3NEW [16:58:31] (03PS1) 10Aaron Schulz: Added simple stat caching to safeFilemtime to speed up complex modules [core] - 10https://gerrit.wikimedia.org/r/200884 [17:03:59] (03PS7) 10Alex Monk: WIP - clean up JS and change action=ajax stuff into API modules [extensions/Collection] - 10https://gerrit.wikimedia.org/r/183228 [17:04:27] legoktm: does using [[Category:Opted-out of message delivery]] on a wiki with a localized version of it opt out the user? [17:04:34] 6Repository-Ownership-Requests: Grant ownership to dr0ptp4kt on apps/ios, apps/ios/wikipedia, apps/ios/commons - https://phabricator.wikimedia.org/T94587#1167494 (10dr0ptp4kt) 3NEW [17:04:51] (03PS20) 10EBernhardson: Editor switcher [extensions/Flow] - 10https://gerrit.wikimedia.org/r/197817 (https://phabricator.wikimedia.org/T90763) [17:05:00] (03CR) 10EBernhardson: "Ps20 is manual rebase" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/197817 (https://phabricator.wikimedia.org/T90763) (owner: 10EBernhardson) [17:05:31] 6Repository-Ownership-Requests: Grant ownership to dr0ptp4kt on apps/ios, apps/ios/wikipedia, apps/ios/commons - https://phabricator.wikimedia.org/T94587#1167501 (10dr0ptp4kt) [17:05:44] (03CR) 10jenkins-bot: [V: 04-1] WIP - clean up JS and change action=ajax stuff into API modules [extensions/Collection] - 10https://gerrit.wikimedia.org/r/183228 (owner: 10Alex Monk) [17:05:54] (03PS15) 10Krinkle: Convert mediawiki.toc and mediawiki.user to using mw.cookie [core] - 10https://gerrit.wikimedia.org/r/176948 (https://phabricator.wikimedia.org/T67384) (owner: 10Yamelnychuk) [17:10:33] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: property label doesn't scroll with viewport anymore - https://phabricator.wikimedia.org/T94588#1167504 (10JanZerebecki) 3NEW [17:10:59] (03PS3) 10BryanDavis: resourceloader: Cut down on file stat time in safeFilemtime() [core] - 10https://gerrit.wikimedia.org/r/200821 (owner: 10Aaron Schulz) [17:11:05] 6Repository-Ownership-Requests: Grant ownership to dr0ptp4kt on apps/ios, apps/ios/wikipedia, apps/ios/commons - https://phabricator.wikimedia.org/T94587#1167513 (10Deskana) I'm Dan, the product owner for the Mobile Apps Team, and I approve this message. [17:11:05] (03CR) 10BryanDavis: [C: 032] resourceloader: Cut down on file stat time in safeFilemtime() [core] - 10https://gerrit.wikimedia.org/r/200821 (owner: 10Aaron Schulz) [17:11:21] (03CR) 10Ori.livneh: [C: 032] resourceloader: Cut down on file stat time in safeFilemtime() [core] - 10https://gerrit.wikimedia.org/r/200821 (owner: 10Aaron Schulz) [17:11:43] (03CR) 10Ricordisamoa: "#3 is not feasible. Some wikis already use indicators' IDs in CSS rules." [core] - 10https://gerrit.wikimedia.org/r/186757 (https://phabricator.wikimedia.org/T87557) (owner: 10Gerrit Patch Uploader) [17:11:52] CR +4 [17:12:02] *2 [17:12:15] (03PS2) 10Aaron Schulz: Added slave/master fallback logic in Revision [core] - 10https://gerrit.wikimedia.org/r/200810 (https://phabricator.wikimedia.org/T93866) [17:12:23] (03CR) 10Ricordisamoa: [C: 031] LivePreview: Update page status indicators [core] - 10https://gerrit.wikimedia.org/r/186757 (https://phabricator.wikimedia.org/T87557) (owner: 10Gerrit Patch Uploader) [17:12:44] 6MediaWiki-API-Team, 10MediaWiki-extensions-OAuth, 5Patch-For-Review: Message describing OAuth activities is confusing to end user (in context of Wikidata Game) - https://phabricator.wikimedia.org/T69082#1167521 (10Peteforsyth) >>! In T69082#1167473, @Ricordisamoa wrote: >>>! In T69082#738278, @Peteforsyth w... [17:12:53] Nikerabbit: what's the reason for ULS having a custom tooltip hover UI? [17:13:02] (03PS8) 10Alex Monk: WIP - clean up JS and change action=ajax stuff into API modules [extensions/Collection] - 10https://gerrit.wikimedia.org/r/183228 [17:13:15] ori: because we need to have a link in the tooltip. rest is for consistency [17:13:33] there's a link in the tooltip? [17:13:47] i can't click on it if there is one, it disappears if i move the cursor towards the text [17:14:13] ori: only when you change language [17:14:26] 7Design, 10UI-Standardization, 10OOjs-UI, 5Patch-For-Review: ButtonWidget (frameless…)‎ to be styled like quiet buttons/normal anchors - https://phabricator.wikimedia.org/T88622#1167522 (10violetto) @matmarex @TrevorParscal bump! Just wondering if you guys found a way to change icon svg colors. [17:14:37] (03PS4) 10Niharika29: [WIP] Fix aggregated reports to work on the new reviews system [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/198233 (https://phabricator.wikimedia.org/T93251) [17:14:56] 10MediaWiki-extensions-DismissableSiteNotice, 7Regression: "[dismiss]" shown on all desktop/mobile pages regardless of the wiki having any sitenotice at the time - https://phabricator.wikimedia.org/T94536#1167524 (10PleaseStand) It looks like mediawiki.org uses a similar hack (`

`). I'm working on a core... [17:15:07] (03CR) 10BryanDavis: Rely less on file stat cache in FileDependency (031 comment) [core] - 10https://gerrit.wikimedia.org/r/200823 (owner: 10Aaron Schulz) [17:15:57] ori: I believe we had this discussion before ;) [17:17:03] 6MediaWiki-Core-Team, 10CirrusSearch: Fix highlighting for phrase prefix queries - https://phabricator.wikimedia.org/T93014#1167528 (10Jdouglas) On enwiki, this does indeed appear to be problematic: {F107483} [17:17:18] 10Wikimedia-Site-requests: Wiktionary namespace translation for Odia / or.wiktionary - https://phabricator.wikimedia.org/T94142#1167530 (10Glaisher) >>! In T94142#1165973, @Sipun wrote: > > No, very few people are active there. That's why, i think, there is no need of community consensus. Hi, even if only a fe... [17:17:48] Nikerabbit: quite probable. But the end state is still a custom tooltip library loaded for no really good reason that I can discern [17:17:55] (03PS2) 10Aaron Schulz: Rely less on file stat cache in FileDependency [core] - 10https://gerrit.wikimedia.org/r/200823 [17:19:40] (03Merged) 10jenkins-bot: resourceloader: Cut down on file stat time in safeFilemtime() [core] - 10https://gerrit.wikimedia.org/r/200821 (owner: 10Aaron Schulz) [17:20:25] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Fix "Unknown dependency: jquery.ui.EditableTemplatedWidget" error - https://phabricator.wikimedia.org/T94589#1167533 (10Krinkle) 3NEW [17:20:43] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Fix "Unknown dependency: jquery.ui.EditableTemplatedWidget" error - https://phabricator.wikimedia.org/T94589#1167541 (10Krinkle) [17:21:05] ori: instead of I telling my team that you said this and that, would you have time to report a bug where you make your case and I will make sure it is acted on? [17:21:29] 3Outreachy-Round-10: Reinvent Translation Search - https://phabricator.wikimedia.org/T92929#1167544 (10Phoenix303) [17:22:33] (03PS3) 10BryanDavis: Rely less on file stat cache in FileDependency [core] - 10https://gerrit.wikimedia.org/r/200823 (owner: 10Aaron Schulz) [17:22:57] (03CR) 10BryanDavis: [C: 032] Rely less on file stat cache in FileDependency [core] - 10https://gerrit.wikimedia.org/r/200823 (owner: 10Aaron Schulz) [17:23:34] (03CR) 10Krinkle: "In what cases of "complex modules" does safeFilemmtime get invoked repeatedly for the same file path? I might miss something, but this see" [core] - 10https://gerrit.wikimedia.org/r/200884 (owner: 10Aaron Schulz) [17:23:43] (03PS2) 10Aaron Schulz: Added simple stat caching to safeFilemtime to speed up complex modules [core] - 10https://gerrit.wikimedia.org/r/200884 [17:26:33] (03PS3) 10Aaron Schulz: Added stat caching to safeFilemtime to speed up module loading [core] - 10https://gerrit.wikimedia.org/r/200884 [17:26:58] Krinkle: it definitely happens, do you want to debug that? [17:28:04] aspiecat: I don't want to debug it, I'd like to code to explain to the next maintainer why it's doing what it's doing. Intuitively I would not expect this scenario to exist. [17:28:13] Hence it seems appropiate to document when this happens. [17:28:26] Otherwise it will likely end up being removed in a future refactor if there's no obvious reason for it to be there [17:31:10] 10MediaWiki-extensions-BounceHandler, 7Wikimedia-log-errors: Undefined index in BounceHandler - https://phabricator.wikimedia.org/T93112#1167559 (10Krenair) ```Undefined index: 1 in /srv/mediawiki/php-1.25wmf23/extensions/BounceHandler/includes/ProcessBounceEmails.php on line 108 Undefined index: 2 in /srv/med... [17:33:21] (03CR) 10Phoenix303: Enable Save button in collection on changing its content (031 comment) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/181953 (https://phabricator.wikimedia.org/T62574) (owner: 10Phoenix303) [17:34:36] 10TextExtracts, 7Regression: Hovercard for article Baden-Württemberg shows error message as text extract - https://phabricator.wikimedia.org/T94012#1167562 (10Fomafix) The error message is generated in [[https://git.wikimedia.org/blob/mediawiki%2Fcore.git/f772fc34e5862d170c657b30888f6314b0d0c926/includes%2Fpag... [17:34:36] Glaisher: no, it has to use the localized version. [17:34:45] Krinkle: seems to mostly be for geshi [17:34:53] (03PS5) 10Niharika29: [WIP] Fix aggregated reports to work on the new reviews system [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/198233 (https://phabricator.wikimedia.org/T93251) [17:34:59] ok, thnx [17:35:00] 10Wikimedia-General-or-Unknown: English Wikipedia user talk page shown as blue link but displays: revision #0 does not exist - https://phabricator.wikimedia.org/T92046#1167564 (10Anomie) There seems to be more than one thing going on here: * All the titles listed by Earwig were last touched over a year ago and h... [17:35:14] the same few files many many times [17:35:44] I'm only requesting startup load.php, not a main page that triggers various requests [17:36:34] (03PS1) 10Anomie: Add checks to try to catch T92046 [core] - 10https://gerrit.wikimedia.org/r/200894 (https://phabricator.wikimedia.org/T92046) [17:37:24] (03CR) 10Anomie: Enable Save button in collection on changing its content (031 comment) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/181953 (https://phabricator.wikimedia.org/T62574) (owner: 10Phoenix303) [17:37:34] (03PS2) 10Matthias Mullie: Disallow revisions in deleted boards [extensions/Flow] - 10https://gerrit.wikimedia.org/r/200854 (https://phabricator.wikimedia.org/T90969) [17:38:27] (03Merged) 10jenkins-bot: Rely less on file stat cache in FileDependency [core] - 10https://gerrit.wikimedia.org/r/200823 (owner: 10Aaron Schulz) [17:39:45] 6MediaWiki-Core-Team, 10CirrusSearch: Fix highlighting for phrase prefix queries - https://phabricator.wikimedia.org/T93014#1167586 (10Manybubbles) Ok - so this is an error in the highlighter I think. It must not know what to do with these queries. Its actually a reasonably fix - we reproduce it with the uni... [17:39:49] 10Programs-Evaluation: Read-throughs - https://phabricator.wikimedia.org/T94582#1167587 (10Abit) [17:39:50] Krinkle: well some of the files actually are different, like the per-language ones [17:40:07] it does seem like a bug somewhere [17:40:51] I see .less files getting hit too [17:41:21] Krinkle: http://pastebin.com/SSCgQREH [17:42:19] (03CR) 10jenkins-bot: [V: 04-1] Disallow revisions in deleted boards [extensions/Flow] - 10https://gerrit.wikimedia.org/r/200854 (https://phabricator.wikimedia.org/T90969) (owner: 10Matthias Mullie) [17:42:24] (03CR) 10Aaron Schulz: "http://pastebin.com/SSCgQREH is an excerpt (probably bugs going on there)" [core] - 10https://gerrit.wikimedia.org/r/200884 (owner: 10Aaron Schulz) [17:42:33] 10MediaWiki-extensions-Translate, 7I18n, 3LE-Sprint-85: Not able to mark big pages for translation at mediawiki.org - https://phabricator.wikimedia.org/T90704#1167592 (10Nikerabbit) [17:43:50] (03CR) 10Anomie: [C: 032] Fixed {{REVISION(TIMESTAMP|USER|SIZE)}} on new revisions [core] - 10https://gerrit.wikimedia.org/r/200805 (https://phabricator.wikimedia.org/T94407) (owner: 10Aaron Schulz) [17:46:22] 7Design, 10UI-Standardization, 10OOjs-UI, 5Patch-For-Review: ButtonWidget (frameless…)‎ to be styled like quiet buttons/normal anchors - https://phabricator.wikimedia.org/T88622#1167605 (10matmarex) >>! In T88622#1148104, @Prtksxna wrote: >>>! In T88622#1120055, @matmarex wrote: >> There isn't, because it... [17:46:28] 6MediaWiki-Core-Team, 10CirrusSearch, 10Wikimedia-Site-requests, 7Easy: Remove "this wiki is using a new search" - https://phabricator.wikimedia.org/T77920#1167606 (10Manybubbles) https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=151438&oldid=151399 [17:47:14] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: allow editing of more languages in the in other languages box than the ones defined via babel boxes - https://phabricator.wikimedia.org/T92759#1167608 (10Nemo_bis) "All" is easy, "More" hard. Cf. https://www.mediawiki.org/wiki/Talk:Universal_Language_Selec... [17:47:21] 10Wikimedia-General-or-Unknown: SpamBlacklist is not working on Wikimedia wikis - https://phabricator.wikimedia.org/T94591#1167610 (10Glaisher) 3NEW [17:47:25] (03PS1) 10PleaseStand: Allow setting the anonnotice to the empty string [core] - 10https://gerrit.wikimedia.org/r/200900 (https://phabricator.wikimedia.org/T94536) [17:48:05] 10Wikimedia-General-or-Unknown: SpamBlacklist is not working on Wikimedia wikis - https://phabricator.wikimedia.org/T94591#1167620 (10Glaisher) p:5Triage>3Unbreak! we'll get lots and lots of spambot edits if it's not working [17:50:12] 10Wikimania-Hackathon-2015, 10Wikimedia-General-or-Unknown, 7Tracking: Steward, global sysop and SWMT tasks bugs (tracking) - https://phabricator.wikimedia.org/T43492#1167624 (10Glaisher) [17:50:13] 10Wikimedia-General-or-Unknown: SpamBlacklist is not working on Wikimedia wikis - https://phabricator.wikimedia.org/T94591#1167625 (10Glaisher) [17:50:30] 10MediaWiki-extensions-SpamBlacklist, 10Wikimedia-General-or-Unknown: SpamBlacklist is not working on Wikimedia wikis - https://phabricator.wikimedia.org/T94591#1167610 (10Glaisher) [17:51:01] (03CR) 10Krinkle: "Adding a 'var_dump($this->getName(), $files);' in ResourceLoaderFileModule::getModifiedTime shows that quite often the same file is multip" [core] - 10https://gerrit.wikimedia.org/r/200884 (owner: 10Aaron Schulz) [17:51:21] 6MediaWiki-Core-Team, 10CirrusSearch: Fix highlighting for phrase prefix queries - https://phabricator.wikimedia.org/T93014#1167627 (10Jdouglas) Now I'm having trouble reproducing this locally with the patch in https://gerrit.wikimedia.org/r/#/c/197397/: {F107495} [17:51:52] (03PS2) 10BryanDavis: Made text profiling actually work with load.php [core] - 10https://gerrit.wikimedia.org/r/200818 (owner: 10Aaron Schulz) [17:51:57] (03CR) 10BryanDavis: [C: 032] Made text profiling actually work with load.php [core] - 10https://gerrit.wikimedia.org/r/200818 (owner: 10Aaron Schulz) [17:56:03] (03CR) 10Manybubbles: "I'm neutral to +1 on it. We'll have issues with the snippets being cut off but if we can live with that then so be it. I'm spinning it u" (033 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt) [17:56:13] 10MediaWiki-extensions-SpamBlacklist, 10Wikimedia-General-or-Unknown: SpamBlacklist is not working on Wikimedia wikis - https://phabricator.wikimedia.org/T94591#1167642 (10Dzahn) So why could it not just be https:// ? [17:56:48] 10MediaWiki-extensions-SpamBlacklist, 10Wikimedia-General-or-Unknown: SpamBlacklist is not working on Wikimedia wikis - https://phabricator.wikimedia.org/T94591#1167644 (10Dzahn) Oh, the preg_match would have to be adjusted. ok. [17:57:26] 10MediaWiki-extensions-SpamBlacklist, 10Wikimedia-General-or-Unknown: SpamBlacklist is not working on Wikimedia wikis - https://phabricator.wikimedia.org/T94591#1167646 (10Glaisher) p:5Unbreak!>3Normal https://gerrit.wikimedia.org/r/#/c/200901/ Krenair has reverted it so no longer unbreak now! Spam Blackli... [17:58:12] 10MediaWiki-extensions-SpamBlacklist, 10Wikimedia-General-or-Unknown: SpamBlacklist is not working on Wikimedia wikis - https://phabricator.wikimedia.org/T94591#1167648 (10Glaisher) and https as well, ofc [17:58:35] 10MediaWiki-extensions-SpamBlacklist, 10Wikimedia-General-or-Unknown: SpamBlacklist should support protocol-relative files - https://phabricator.wikimedia.org/T94591#1167650 (10Glaisher) [17:59:48] 10Programs-Evaluation: Read-throughs - https://phabricator.wikimedia.org/T94582#1167653 (10Abit) [18:00:11] 10SUL-Finalization: GlobalRename tool is corrupting CheckUser data - https://phabricator.wikimedia.org/T94516#1167654 (10Legoktm) These actions are made via the job queue, and we don't even have the performers IP at the time. This only applies to the local log entries caused by global rename. The global rename l... [18:00:23] 10SUL-Finalization: GlobalRename tool is corrupting CheckUser data - https://phabricator.wikimedia.org/T94516#1167656 (10Legoktm) p:5Unbreak!>3Triage a:5Legoktm>3None [18:00:32] (03Merged) 10jenkins-bot: Fixed {{REVISION(TIMESTAMP|USER|SIZE)}} on new revisions [core] - 10https://gerrit.wikimedia.org/r/200805 (https://phabricator.wikimedia.org/T94407) (owner: 10Aaron Schulz) [18:00:51] 7Design, 10UI-Standardization, 10OOjs-UI, 5Patch-For-Review: ButtonWidget (frameless…)‎ to be styled like quiet buttons/normal anchors - https://phabricator.wikimedia.org/T88622#1167659 (10violetto) @matmarex, prior to going down svg route vs. icon font, there was a list of requirements communicated [[ htt... [18:01:20] (03PS9) 10Alex Monk: Clean up JS and change action=ajax stuff into API modules [extensions/Collection] - 10https://gerrit.wikimedia.org/r/183228 [18:01:57] 10WMF-Product-Strategy: Perform a Wikidata gap analysis - https://phabricator.wikimedia.org/T91423#1167660 (10Ironholds) Update: We met with Lydia (thanks Lydia!) yesterday and had a really awesome meeting; I'm just making sure my notes captured the essence of what was said before formally writing them up. @Des... [18:01:59] 10Programs-Evaluation: Read-throughs - https://phabricator.wikimedia.org/T94582#1167661 (10Abit) [18:02:29] (03PS1) 10Gergő Tisza: Update ImageMetrics submodule [core] (wmf/1.25wmf23) - 10https://gerrit.wikimedia.org/r/200902 [18:02:41] 7Design, 6Collaboration-Team, 10Flow, 3Roadmap, 7notice: Move Flow "header" to right rail, add toggle for full-width + link to archives - https://phabricator.wikimedia.org/T88114#1167663 (10Pginer-WMF) I created [a quick prototype to illustrate the right rail toggling and templates](http://pauginer.githu... [18:02:42] (03PS1) 10Krinkle: resourceloader: De-duplicate $files in ResourceLoaderFileModule::getModifiedTime() [core] - 10https://gerrit.wikimedia.org/r/200903 [18:02:53] (03CR) 10Krinkle: "Icd2c11d93d649166" [core] - 10https://gerrit.wikimedia.org/r/200884 (owner: 10Aaron Schulz) [18:03:30] (03PS6) 10Niharika29: [WIP] Fix aggregated reports to work on the new reviews system [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/198233 (https://phabricator.wikimedia.org/T93251) [18:06:21] (03CR) 10Arlolra: Enable Save button in collection on changing its content (031 comment) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/181953 (https://phabricator.wikimedia.org/T62574) (owner: 10Phoenix303) [18:08:21] (03Merged) 10jenkins-bot: Made text profiling actually work with load.php [core] - 10https://gerrit.wikimedia.org/r/200818 (owner: 10Aaron Schulz) [18:12:58] (03CR) 10Cscott: "Gerrit doesn't make it easy to review patches with a lot of renames. I'll download this locally and use 'git diff -C -C' but it would rea" (039 comments) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/183228 (owner: 10Alex Monk) [18:13:50] anomie, have you ever had a discussion on implementing "continuing in reverse"? E.g. if UI wants to show a pagination interface, and needs a way to get "previous" page as well as "next" [18:16:41] 10MediaWiki-Vagrant: create qunit vagrant role - https://phabricator.wikimedia.org/T94594#1167699 (10JanZerebecki) 3NEW [18:17:56] (03PS1) 10Legoktm: Use wfLoadExtension() / wfLoadSkin() directly [vagrant] - 10https://gerrit.wikimedia.org/r/200906 [18:18:05] 7Design, 10UI-Standardization, 10OOjs-UI, 5Patch-For-Review: ButtonWidget (frameless…)‎ to be styled like quiet buttons/normal anchors - https://phabricator.wikimedia.org/T88622#1167715 (10matmarex) I am aware that requirements were communicated. This one, however, wasn't. (There is nothing even in M37 abo... [18:18:49] 10MediaWiki-extensions-Collection, 7Technical-Debt: Remove AjaxDispatcher from Collection - https://phabricator.wikimedia.org/T94005#1167718 (10cscott) a:3cscott I'm adopting Krenair's patch to split it apart, get it reviewed, and push it over the finish line. [18:19:22] 10Fundraising-Backlog, 3Fundraising Sprint Grandmaster Flash: Catalan donate flow is not retaining language data - https://phabricator.wikimedia.org/T94506#1167720 (10atgo) [18:19:28] 10Fundraising-Backlog, 3Fundraising Sprint Grandmaster Flash: Catalan donate flow is not retaining language data - https://phabricator.wikimedia.org/T94506#1167721 (10atgo) p:5High>3Unbreak! [18:19:33] (03PS1) 10JoelKP: Ignore empty values, and other minor changes to value handling (v1.4.1) [extensions/PhpTagsSMW] - 10https://gerrit.wikimedia.org/r/200907 [18:20:33] (03PS1) 10Krinkle: resourceloader: Simplify getHashMtime() to merely a timestamp [core] - 10https://gerrit.wikimedia.org/r/200908 [18:20:41] 3Team-Practices-This-Week: Agree on best practice for phabricator issue resolution - https://phabricator.wikimedia.org/T94189#1167722 (10ksmith) On https://www.mediawiki.org/wiki/Bug_management/Bug_report_life_cycle I just noticed this: A report is given the Resolved status when a code change that fixes the rep... [18:23:03] 3Fundraising Sprint H, 10Fundraising-Backlog: Catalan donate flow is not retaining language data - https://phabricator.wikimedia.org/T94506#1167723 (10atgo) p:5Unbreak!>3High [18:23:26] (03CR) 10JoelKP: [C: 032 V: 032] Ignore empty values, and other minor changes to value handling (v1.4.1) [extensions/PhpTagsSMW] - 10https://gerrit.wikimedia.org/r/200907 (owner: 10JoelKP) [18:23:34] 10Wikimedia-General-or-Unknown, 7HTTPS: Add Forward Secrecy - https://phabricator.wikimedia.org/T55259#1167727 (10Dzahn) T83471 - seems like a duplicate of this but was resolved and not visibally public, fixed that T91504 - OTRS SSL config (this is ticket.wikimedia.org in the linked list above) T86655 - re:... [18:24:07] (03PS1) 10Krinkle: profiler: Consolidate duplicate branches in ProfilerOutputText [core] - 10https://gerrit.wikimedia.org/r/200909 [18:25:20] 10Co-op: Review FormWizard code - https://phabricator.wikimedia.org/T94595#1167733 (10Capt_Swing) 3NEW [18:25:32] (03CR) 10Legoktm: "Renameuser patch is Ic47c72cdb84a683818b8cf8d1a30a7fff9d3cb13" [core] - 10https://gerrit.wikimedia.org/r/200726 (https://phabricator.wikimedia.org/T78575) (owner: 10Legoktm) [18:26:10] (03CR) 10Nikerabbit: [C: 04-1] resourceloader: De-duplicate $files in ResourceLoaderFileModule::getModifiedTime() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/200903 (owner: 10Krinkle) [18:26:13] 10Co-op: Review FormWizard code - https://phabricator.wikimedia.org/T94595#1167740 (10Mattflaschen) a:3Mattflaschen [18:26:23] 10Co-op, 10Collaboration-Team-Sprint-T-2015-04-08: Review FormWizard code - https://phabricator.wikimedia.org/T94595#1167733 (10Mattflaschen) [18:27:20] (03CR) 10PleaseStand: Allow setting the anonnotice to the empty string (031 comment) [core] - 10https://gerrit.wikimedia.org/r/200900 (https://phabricator.wikimedia.org/T94536) (owner: 10PleaseStand) [18:27:27] 7Design, 10UI-Standardization, 10OOjs-UI, 5Patch-For-Review: ButtonWidget (frameless…)‎ to be styled like quiet buttons/normal anchors - https://phabricator.wikimedia.org/T88622#1167743 (10violetto) Wondering how you guys are fulfilling the requirement for icon color change that was listed as part of the r... [18:28:10] (03CR) 10Aaron Schulz: [C: 032] profiler: Consolidate duplicate branches in ProfilerOutputText [core] - 10https://gerrit.wikimedia.org/r/200909 (owner: 10Krinkle) [18:28:51] (03PS2) 10Krinkle: resourceloader: De-duplicate $files in ResourceLoaderFileModule::getModifiedTime() [core] - 10https://gerrit.wikimedia.org/r/200903 [18:28:53] (03CR) 10Krinkle: resourceloader: De-duplicate $files in ResourceLoaderFileModule::getModifiedTime() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/200903 (owner: 10Krinkle) [18:29:55] (03CR) 10Aaron Schulz: [C: 032] resourceloader: De-duplicate $files in ResourceLoaderFileModule::getModifiedTime() [core] - 10https://gerrit.wikimedia.org/r/200903 (owner: 10Krinkle) [18:30:10] yurik: No, haven't had such a discussion that I recall. Why would something want to do that when it can't just twiddle the dir and start/end parameters in the query? [18:31:56] anomie, you can, but that means that you don't use continue anymore - instead you have to manually construct the query and ignore first result row, and you probably would want to do it for both directions because if you go back by one page and than want to go forward again you need to switch dir again [18:32:32] in other words, you switch from automatic continue to manual one, which is not as clean [18:34:44] (03CR) 10Phoenix303: Enable Save button in collection on changing its content (031 comment) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/181953 (https://phabricator.wikimedia.org/T62574) (owner: 10Phoenix303) [18:34:48] (03PS1) 10TheDJ: Fix native ogg audio playback on Android [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/200910 (https://phabricator.wikimedia.org/T74975) [18:37:03] (03PS1) 10Krinkle: ResourceLoaderGeSHiModule: Use GESHI_VERSION instead of file mtime [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/200913 [18:37:20] (03PS2) 10Krinkle: ResourceLoaderGeSHiModule: Use GESHI_VERSION instead of file mtime [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/200913 [18:37:24] (03CR) 10Martineznovo: Special:LinkSearch: display links to pages in content language (031 comment) [core] - 10https://gerrit.wikimedia.org/r/200843 (https://phabricator.wikimedia.org/T66064) (owner: 10AYUSH GARG) [18:39:20] (03CR) 10Krinkle: "And I1c2040ca9b87." [core] - 10https://gerrit.wikimedia.org/r/200884 (owner: 10Aaron Schulz) [18:39:58] 10MediaWiki-Page-editing, 7JavaScript: Prevent double submitting - https://phabricator.wikimedia.org/T94429#1167774 (10Subfader) Main edit form, discussion on the support desk. Sure it should be a browser feature, but it isn't. At least not in Chrome. [18:40:13] (03CR) 10Anomie: [C: 032] Add SpecialLog::getLogTypesOnUser() [core] - 10https://gerrit.wikimedia.org/r/200726 (https://phabricator.wikimedia.org/T78575) (owner: 10Legoktm) [18:40:45] 10MediaWiki-extensions-Quiz, 7I18n: ResourceLoader-ify Quiz CSS - https://phabricator.wikimedia.org/T40372#1167780 (10Krinkle) [18:40:47] 10MediaWiki-extensions-General-or-Unknown, 7Tracking: Extensions that need resource loader-ifying (tracking) - https://phabricator.wikimedia.org/T31713#1167779 (10Krinkle) [18:40:54] 10MediaWiki-extensions-General-or-Unknown, 7Tracking: Extensions that need resource loader-ifying (tracking) - https://phabricator.wikimedia.org/T31713#1167781 (10Krinkle) 5Open>3Resolved a:3Krinkle [18:40:57] 7Tracking: Tracking bug (tracking) - https://phabricator.wikimedia.org/T4007#1167783 (10Krinkle) [18:41:15] 10MediaWiki-extensions-General-or-Unknown, 7Tracking: Extensions that need resource loader-ifying (tracking) - https://phabricator.wikimedia.org/T31713#324917 (10Krinkle) a:5Krinkle>3None [18:41:27] 10Co-op, 10Collaboration-Team-Sprint-T-2015-04-08: Review FormWizard code - https://phabricator.wikimedia.org/T94595#1167790 (10Capt_Swing) p:5Normal>3Triage [18:41:47] 3Mobile-Web-Sprint-44-R_________: Don't log page-impressions or widget-impressions in WikiGrok - https://phabricator.wikimedia.org/T94443#1167795 (10bmansurov) @phuedx, I think @kaldari maybe able to answer your question about why we're not removing the code. I followed the bug description, which says: `comment... [18:42:00] (03PS1) 10Legoktm: Fix capitaliation of UtfNormal namespace [core] - 10https://gerrit.wikimedia.org/r/200915 [18:42:07] James_F: ^ [18:42:09] (03Merged) 10jenkins-bot: profiler: Consolidate duplicate branches in ProfilerOutputText [core] - 10https://gerrit.wikimedia.org/r/200909 (owner: 10Krinkle) [18:42:14] (03Merged) 10jenkins-bot: resourceloader: De-duplicate $files in ResourceLoaderFileModule::getModifiedTime() [core] - 10https://gerrit.wikimedia.org/r/200903 (owner: 10Krinkle) [18:42:28] 3Fundraising Sprint H, 10Fundraising-Backlog: Catalan donate flow is not retaining language data - https://phabricator.wikimedia.org/T94506#1167806 (10CCogdill_WMF) Update: tested this in Spanish as well and it does not seem to be a problem there. This may be isolated to Catalan only. [18:44:11] RoanKattouw: my patch had a small typo: https://gerrit.wikimedia.org/r/#/c/200915/ [18:44:29] (03CR) 10Jforrester: [C: 032] "Oy." [core] - 10https://gerrit.wikimedia.org/r/200915 (owner: 10Legoktm) [18:44:32] (03CR) 10Catrope: [C: 032] Fix capitaliation of UtfNormal namespace [core] - 10https://gerrit.wikimedia.org/r/200915 (owner: 10Legoktm) [18:44:41] legoktm: Forum-shopper. :-P [18:44:51] :P [18:45:23] (03CR) 10Anomie: [C: 032] Update more log entries that are specifically about users [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/200727 (https://phabricator.wikimedia.org/T78575) (owner: 10Legoktm) [18:45:48] (03CR) 10Aaron Schulz: [C: 032] ResourceLoaderGeSHiModule: Use GESHI_VERSION instead of file mtime [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/200913 (owner: 10Krinkle) [18:46:04] (03CR) 10Legoktm: "Follow up: I18f68da0e36ef148a8235516f2ed72b4b3190208" [core] - 10https://gerrit.wikimedia.org/r/195026 (https://phabricator.wikimedia.org/T90825) (owner: 10Legoktm) [18:46:10] 4(no projects): DOIs when they fall back to dx.doi.org should still be considered journals - https://phabricator.wikimedia.org/T94597#1167808 (10Jdforrester-WMF) 3NEW [18:47:15] 6MediaWiki-Core-Team, 10VisualEditor, 10VisualEditor-Performance, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-04-01_(1.25wmf24): Stash VisualEditor edits using edit stash - https://phabricator.wikimedia.org/T90040#1167818 (10Jdforrester-WMF) 5Open>3Resolved [18:50:14] 10Co-op, 10Collaboration-Team-Sprint-T-2015-04-08: Review FormWizard code - https://phabricator.wikimedia.org/T94595#1167828 (10Capt_Swing) [18:51:43] (03Merged) 10jenkins-bot: Add SpecialLog::getLogTypesOnUser() [core] - 10https://gerrit.wikimedia.org/r/200726 (https://phabricator.wikimedia.org/T78575) (owner: 10Legoktm) [18:52:32] (03Merged) 10jenkins-bot: Fix capitaliation of UtfNormal namespace [core] - 10https://gerrit.wikimedia.org/r/200915 (owner: 10Legoktm) [18:52:37] (03Merged) 10jenkins-bot: Update more log entries that are specifically about users [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/200727 (https://phabricator.wikimedia.org/T78575) (owner: 10Legoktm) [18:52:39] (03Merged) 10jenkins-bot: ResourceLoaderGeSHiModule: Use GESHI_VERSION instead of file mtime [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/200913 (owner: 10Krinkle) [18:52:56] 10Wikimedia-General-or-Unknown, 7HTTPS: Add Forward Secrecy - https://phabricator.wikimedia.org/T55259#1167839 (10JanZerebecki) In this case server load is the least of the concerns. Enabling non-EC DHE ciphers may be acceptable. It is necessary if we want to disable no-FS ciphers, which is desirable. Work on... [18:53:07] (03CR) 10Krinkle: [C: 032] ResourceLoaderImage: Throw exception if files don't exist [core] - 10https://gerrit.wikimedia.org/r/200483 (owner: 10Bartosz Dziewoński) [18:59:59] 4(no projects): Missing namespace 'Topic' in Telugu Wikipedia (te.wikipedia.org) - https://phabricator.wikimedia.org/T94601#1167871 (10tuxnani) 3NEW [19:02:04] 6MediaWiki-API-Team, 10MediaWiki-extensions-Renameuser, 6Collaboration-Team, 10SUL-Finalization, and 3 others: Move more log types to new user name when renaming a user (for example thanks logs) - https://phabricator.wikimedia.org/T78575#1167890 (10Legoktm) 5Open>3Resolved [19:03:38] 6MediaWiki-API-Team, 10MediaWiki-extensions-CentralAuth, 10SUL-Finalization: GlobalRenameQueue needs a means (status) to set "on hold" function on a rename request - https://phabricator.wikimedia.org/T94321#1167906 (10bd808) What workflow changes would the "hold" feature add? Are you just looking for a way t... [19:04:06] 4(no projects): Missing namespace 'Topic' in Telugu Wikipedia (te.wikipedia.org) - https://phabricator.wikimedia.org/T94601#1167908 (10tuxnani) [19:04:58] (03PS7) 10Niharika29: [WIP] Fix aggregated reports to work on the new reviews system [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/198233 (https://phabricator.wikimedia.org/T93251) [19:05:05] 4(no projects): Unexpanded character entity references - https://phabricator.wikimedia.org/T94603#1167911 (10SamB) 3NEW [19:05:51] (03PS10) 10Cscott: T94005: Clean up JS and change action=ajax stuff into API modules [extensions/Collection] - 10https://gerrit.wikimedia.org/r/183228 (owner: 10Alex Monk) [19:05:53] (03PS1) 10Cscott: Code style fixes to check_load_from_localstorage.js [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200921 [19:05:55] (03PS1) 10Cscott: Use message parameters instead of string replace. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200922 [19:05:58] (03PS1) 10Cscott: Rename Proposals to CollectionProposals [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200923 [19:06:00] (03PS1) 10Cscott: Rename js/ to modules/ [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200924 [19:06:01] (03CR) 10He7d3r: T94005: Clean up JS and change action=ajax stuff into API modules (032 comments) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/183228 (owner: 10Alex Monk) [19:06:39] 10Wikimedia-Wikimania-Scholarships: Cannot filter Phase 2 export list - https://phabricator.wikimedia.org/T94373#1167920 (10NiharikaKohli) p:5Triage>3High [19:06:41] (03Merged) 10jenkins-bot: ResourceLoaderImage: Throw exception if files don't exist [core] - 10https://gerrit.wikimedia.org/r/200483 (owner: 10Bartosz Dziewoński) [19:06:44] (03Merged) 10jenkins-bot: ResourceLoaderImage: Some cleanup, typo fixes and tweaks [core] - 10https://gerrit.wikimedia.org/r/200613 (owner: 10Bartosz Dziewoński) [19:07:34] (03PS2) 10PleaseStand: Allow setting the anonnotice to "-" for the empty string [core] - 10https://gerrit.wikimedia.org/r/200900 (https://phabricator.wikimedia.org/T94536) [19:12:07] (03CR) 10Umherirrender: Update more log entries that are specifically about users (031 comment) [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/200727 (https://phabricator.wikimedia.org/T78575) (owner: 10Legoktm) [19:12:08] 10Fundraising-Backlog: Language error in "Transaction could not be accepted" page - https://phabricator.wikimedia.org/T94604#1167927 (10CCogdill_WMF) 3NEW a:3atgo [19:13:27] 10MediaWiki-Parser: Unexpanded character entity references - https://phabricator.wikimedia.org/T94603#1167940 (10SamB) [19:13:39] 10Wikimedia-Wikimania-Scholarships: Cannot filter Phase 2 export list - https://phabricator.wikimedia.org/T94373#1167943 (10bd808) I think the problem is triggered by the language community size option independent of any other settings for the report. [19:15:55] (03CR) 10Legoktm: Update more log entries that are specifically about users (031 comment) [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/200727 (https://phabricator.wikimedia.org/T78575) (owner: 10Legoktm) [19:19:08] 10Wikimedia-Wikimania-Scholarships: Cannot filter Phase 2 export list - https://phabricator.wikimedia.org/T94373#1167980 (10NiharikaKohli) I haven't been able to replicate this on my local instance. Could it be because of large amount of data? (Seems unlikely) [19:21:02] 10Wikimedia-Wikimania-Scholarships: Cannot filter Phase 2 export list - https://phabricator.wikimedia.org/T94373#1167982 (10bd808) a:3bd808 [19:23:29] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 7Tracking: Implement complete RDF mapping for entities (tracking) - https://phabricator.wikimedia.org/T50143#1167985 (10Smalyshev) [19:23:49] (03PS2) 10Cscott: Rename js/ to modules/ [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200924 [19:23:51] (03PS2) 10Cscott: Use message parameters instead of string replace. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200922 [19:23:53] (03PS2) 10Cscott: Rename Proposals to CollectionProposals [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200923 [19:23:55] (03PS11) 10Cscott: T94005: Clean up JS and change action=ajax stuff into API modules [extensions/Collection] - 10https://gerrit.wikimedia.org/r/183228 (owner: 10Alex Monk) [19:23:57] (03PS1) 10Cscott: Rename modules to use consistent ext.collection.* prefix. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200932 [19:26:40] (03CR) 10Anomie: T94005: Clean up JS and change action=ajax stuff into API modules (0325 comments) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/183228 (owner: 10Alex Monk) [19:27:36] 10MediaWiki-General-or-Unknown: Watchlist notification bubble changed appearance on enwiki - https://phabricator.wikimedia.org/T94518#1167997 (10Quiddity) It's now visible at beta: http://en.wikipedia.beta.wmflabs.org/wiki/Main_Page No longer visible at enwiki. Screenshotted: {F107508} {F107509} [19:27:45] (03PS6) 10BryanDavis: Implement support for the src_dir argument in mediawiki::wiki [vagrant] - 10https://gerrit.wikimedia.org/r/200335 (https://phabricator.wikimedia.org/T78739) (owner: 1020after4) [19:27:47] (03PS1) 10BryanDavis: Ensure the uid/gid used for shared files exists in the VM [vagrant] - 10https://gerrit.wikimedia.org/r/200935 [19:27:49] (03PS1) 10BryanDavis: Fix quote style [vagrant] - 10https://gerrit.wikimedia.org/r/200936 [19:28:04] (03CR) 10Anomie: [C: 04-1] "The API modules you're creating here are pretty bad. Much of it seems to involve constructing HTML blobs on the server, which in modern co" [extensions/Collection] - 10https://gerrit.wikimedia.org/r/183228 (owner: 10Alex Monk) [19:28:33] 10MediaWiki-Email, 10Wikimedia-General-or-Unknown, 6operations: Get mail relay out of Yahoo! blacklist: apply to Yahoo for whitelisting bulk mail - https://phabricator.wikimedia.org/T58414#1168003 (10SamB) [19:29:27] 10MediaWiki-ResourceLoader, 10MediaWiki-Vagrant, 10Continuous-Integration, 10Wikidata, and 4 others: qunit test broken without explicitly setting $wgResourceLoaderMaxQueryLength - https://phabricator.wikimedia.org/T90453#1168004 (10JanZerebecki) [19:30:22] (03PS1) 10Yaron Koren: Added main MW DB prefix before "cargo__" prefix [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/200939 [19:31:29] (03PS1) 10Mjbmr: Language based default font-family [core] - 10https://gerrit.wikimedia.org/r/200940 [19:31:52] (03CR) 10Yaron Koren: [C: 032 V: 031] Added main MW DB prefix before "cargo__" prefix [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/200939 (owner: 10Yaron Koren) [19:32:13] (03CR) 10Umherirrender: Update more log entries that are specifically about users (031 comment) [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/200727 (https://phabricator.wikimedia.org/T78575) (owner: 10Legoktm) [19:33:33] (03CR) 10Physikerwelt: Render math tags in search results (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt) [19:34:07] (03Merged) 10jenkins-bot: Added main MW DB prefix before "cargo__" prefix [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/200939 (owner: 10Yaron Koren) [19:34:14] Anyone know the proper mw-ocg-bundler syntax for a wiki on localhost? [19:34:42] I tried bin/mw-ocg-bundler -v -o bundle.zip --prefix localhost "Main Page" and got "Prefix not found: localhost [19:35:00] 3ToolLabs-Goals-Q4: Reinstall labstore1001 with Jessie - https://phabricator.wikimedia.org/T94609#1168026 (10coren) 3NEW [19:35:14] 10MediaWiki-ResourceLoader, 10MediaWiki-Vagrant, 10Continuous-Integration, 10Wikidata, and 4 others: qunit test broken without explicitly setting $wgResourceLoaderMaxQueryLength - https://phabricator.wikimedia.org/T90453#1168035 (10JanZerebecki) 5Open>3Resolved [19:36:52] 10MediaWiki-User-preferences: Date format option should have "other" text field for date format strings - https://phabricator.wikimedia.org/T94610#1168039 (10MarkTraceur) 3NEW [19:37:54] (03PS3) 10Cscott: Rename js/ to modules/ [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200924 [19:37:56] (03PS3) 10Cscott: Use message parameters instead of string replace. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200922 [19:37:58] (03PS3) 10Cscott: Rename Proposals to CollectionProposals [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200923 [19:38:00] (03PS2) 10Cscott: Rename modules to use consistent ext.collection.* prefix. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200932 [19:38:02] (03PS12) 10Cscott: T94005: Clean up JS and change action=ajax stuff into API modules [extensions/Collection] - 10https://gerrit.wikimedia.org/r/183228 (owner: 10Alex Monk) [19:41:28] 3Team-Practices-This-Week: Schedule tech talk on Q2 health check survey results - https://phabricator.wikimedia.org/T85821#1168055 (10Rfarrand) Hi @awjrichards, sorry for not updating Phabricator. I decided it might be a bit better to announce the talk closer to the event so I have a reminder set for myself to a... [19:41:57] 3Team-Practices-This-Week: Schedule tech talk on Q2 health check survey results - https://phabricator.wikimedia.org/T85821#1168056 (10Rfarrand) Haha! I signed that as though I was writing an email... too many email today.. [19:42:00] (03CR) 10Cscott: "I'm going through and refactoring out unrelated pieces of this patch, to make the core API changes easier to see and review." [extensions/Collection] - 10https://gerrit.wikimedia.org/r/183228 (owner: 10Alex Monk) [19:43:59] (03CR) 10Hashar: [C: 032] Update RuboCop version and configuration file [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/200554 (https://phabricator.wikimedia.org/T94401) (owner: 10Zfilipin) [19:44:30] (03PS1) 10Hashar: Regenerated RuboCop TODO file [extensions/CentralAuth] (refs/changes/54/200554/4) - 10https://gerrit.wikimedia.org/r/200960 (https://phabricator.wikimedia.org/T94401) [19:44:32] (03CR) 10jenkins-bot: [V: 04-1] Regenerated RuboCop TODO file [extensions/CentralAuth] (refs/changes/54/200554/4) - 10https://gerrit.wikimedia.org/r/200960 (https://phabricator.wikimedia.org/T94401) (owner: 10Hashar) [19:45:03] (03Merged) 10jenkins-bot: Update RuboCop version and configuration file [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/200554 (https://phabricator.wikimedia.org/T94401) (owner: 10Zfilipin) [19:45:19] (03Abandoned) 10Hashar: Regenerated RuboCop TODO file [extensions/CentralAuth] (refs/changes/54/200554/4) - 10https://gerrit.wikimedia.org/r/200960 (https://phabricator.wikimedia.org/T94401) (owner: 10Hashar) [19:45:27] (03PS8) 10Niharika29: [WIP] Fix aggregated reports to work on the new reviews system [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/198233 (https://phabricator.wikimedia.org/T93251) [19:45:42] (03PS3) 10Hashar: Regenerated RuboCop TODO file [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/200556 (https://phabricator.wikimedia.org/T94401) (owner: 10Zfilipin) [19:47:08] (03CR) 10BryanDavis: "This is close to working but still needs some fixes. I do end up with a http://fundraising.wiki.local.wmftest.net:8080 vhost that is using" [vagrant] - 10https://gerrit.wikimedia.org/r/200335 (https://phabricator.wikimedia.org/T78739) (owner: 1020after4) [19:49:37] (03PS9) 10Niharika29: Fix aggregated reports to work on the new reviews system [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/198233 (https://phabricator.wikimedia.org/T93251) [19:49:49] where is wmftest.net hosted? [19:50:54] <^demon|away> mutante: In your local vagrant machine [19:50:58] <^demon|away> :) [19:51:28] (03CR) 10Hashar: [C: 04-1] "This change claims to refresh the todo file but it has a mistake/side effect of changing the string literal style." (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/200556 (https://phabricator.wikimedia.org/T94401) (owner: 10Zfilipin) [19:52:22] (03CR) 10Cscott: "Responding to some of the review comments, since I guess I'm adopting this patch?" (036 comments) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/183228 (owner: 10Alex Monk) [19:52:32] (03CR) 10Hashar: "Just leave them as single quotes? The ruby style on mediawiki.org allows both." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/200557 (https://phabricator.wikimedia.org/T94401) (owner: 10Zfilipin) [19:53:16] (03PS13) 10Cscott: WIP: T94005: Clean up JS and change action=ajax stuff into API modules [extensions/Collection] - 10https://gerrit.wikimedia.org/r/183228 (owner: 10Alex Monk) [19:53:18] (03CR) 10Niharika29: "I decided to go with a new template but I attempted to keep the basic reports system same. So this report is somewhat stuck in limbo. All " [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/198233 (https://phabricator.wikimedia.org/T93251) (owner: 10Niharika29) [19:53:44] (03CR) 10Hashar: [C: 04-1] "The resulting indentation/alignement looks totally off to me :(" (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/200558 (https://phabricator.wikimedia.org/T94401) (owner: 10Zfilipin) [19:53:49] ^demon|away: because labs is too unstable for testing? [19:54:29] <^demon|away> No, it's meant to point to your local development VM by design. [19:54:37] <^demon|away> So you don't have to use IP addresses and crap :) [19:54:40] <^demon|away> Nice URLs [19:55:14] Toolserver had copies of the enwiki database right? Does Labs have that/similar access? [19:55:25] <^demon|away> Yes [20:00:12] 10Wikimedia-Wikimania-Scholarships: Cannot filter Phase 2 export list - https://phabricator.wikimedia.org/T94373#1168098 (10bd808) >>! In T94373#1167980, @NiharikaKohli wrote: > I haven't been able to replicate this on my local instance. Could it be because of large amount of data? (Seems unlikely) Yeah I think... [20:01:43] marxarelli: I think folks will see strangely broken git cloning in mw-v without https://gerrit.wikimedia.org/r/#/c/200935/ [20:02:17] I did some clean vm builds last night and ran into very confusing ruby stacktraces without that fix [20:02:26] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Performance: Drop referenced entities from JS config - https://phabricator.wikimedia.org/T88428#1168105 (10hoo) 5Open>3Resolved [20:04:06] (03CR) 10Anomie: "Code seems generally sane, a few edge cases though." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/197978 (owner: 10Aaron Schulz) [20:04:46] thedj: Do you know why #siteSub is display inline? https://en.wikipedia.org/w/index.php?title=MediaWiki:Vector.css&diff=prev&oldid=300913899 [20:04:52] thedj: I'd like to make this block [20:05:28] (03CR) 10Manybubbles: "Ok! I still haven't had a chance to run it locally but I'm almost there! Darn meetings." (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt) [20:05:29] visually it seems to have only like 1px difference. Due to line height actually applying without collapsing [20:05:42] margins still collapse the same [20:07:20] (03CR) 10Krinkle: [C: 032] Code style fixes to check_load_from_localstorage.js [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200921 (owner: 10Cscott) [20:08:02] (03Merged) 10jenkins-bot: Code style fixes to check_load_from_localstorage.js [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200921 (owner: 10Cscott) [20:09:32] (03PS4) 10Cscott: Rename js/ to modules/ [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200924 [20:09:34] (03PS4) 10Cscott: Use message parameters instead of string replace. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200922 [20:09:36] (03PS4) 10Cscott: Rename Proposals to CollectionProposals [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200923 [20:09:38] (03PS3) 10Cscott: Rename modules to use consistent ext.collection.* prefix. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200932 [20:09:41] (03PS14) 10Cscott: WIP: T94005: Clean up JS and change action=ajax stuff into API modules [extensions/Collection] - 10https://gerrit.wikimedia.org/r/183228 (owner: 10Alex Monk) [20:09:42] (03PS1) 10Cscott: The transition ext.collection.jquery.jstore module is no longer needed [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200997 [20:09:44] (03PS1) 10Cscott: Alphabetize resource modules [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200998 [20:10:32] (03PS5) 10Krinkle: Use message parameters instead of string replace [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200922 (owner: 10Cscott) [20:10:50] (03CR) 10Krinkle: [C: 032] "Fixed space and removed trailing dot from subject line." [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200922 (owner: 10Cscott) [20:10:54] manybubbles: sorry i'm late, just back from lunch. in room in 1 min [20:11:18] ebernhardson: no big deal - I'm just in the hangout writing emails [20:11:52] 6MediaWiki-API-Team, 10MediaWiki-extensions-CentralAuth, 10SUL-Finalization, 7Easy: Log promote to global renames in the global rename log - https://phabricator.wikimedia.org/T93235#1168116 (10Legoktm) a:3Legoktm [20:12:41] Krinkle: thanks [20:14:04] (03Merged) 10jenkins-bot: Use message parameters instead of string replace [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200922 (owner: 10Cscott) [20:16:06] (03PS1) 10Legoktm: jenkins job validation, do not submit [extensions/Echo] - 10https://gerrit.wikimedia.org/r/201001 [20:16:15] (03PS5) 10Cscott: Rename js/ to modules/ [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200924 [20:16:17] (03PS2) 10Cscott: Alphabetize resource modules [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200998 [20:16:19] (03PS5) 10Cscott: Rename Proposals to CollectionProposals [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200923 [20:16:21] (03PS2) 10Cscott: The transition ext.collection.jquery.jstore module is no longer needed [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200997 [20:16:23] (03PS4) 10Cscott: Rename modules to use consistent ext.collection.* prefix. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200932 [20:16:25] (03PS15) 10Cscott: WIP: T94005: Clean up JS and change action=ajax stuff into API modules [extensions/Collection] - 10https://gerrit.wikimedia.org/r/183228 (owner: 10Alex Monk) [20:16:27] (03CR) 10Mattflaschen: [C: 032] "Good catch." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/200852 (owner: 10Matthias Mullie) [20:18:17] (03CR) 10Anomie: Fixed bug where catching DB errors left ignoreErrors() on (031 comment) [core] - 10https://gerrit.wikimedia.org/r/197978 (owner: 10Aaron Schulz) [20:18:18] 10MediaWiki-Codesniffer: Allow shebang before opening 3Fundraising Sprint H, 10Fundraising-Backlog, 3Fundraising Sprint Grandmaster Flash: Catalan donate flow is not retaining language data - https://phabricator.wikimedia.org/T94506#1168125 (10atgo) @ccogdill_WMF were these all credit card donors? [20:19:48] (03CR) 10jenkins-bot: [V: 04-1] jenkins job validation, do not submit [extensions/Echo] - 10https://gerrit.wikimedia.org/r/201001 (owner: 10Legoktm) [20:20:10] (03Merged) 10jenkins-bot: Fix missing var $type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/200852 (owner: 10Matthias Mullie) [20:21:41] 3Fundraising Sprint H, 10Fundraising-Backlog, 3Fundraising Sprint Grandmaster Flash: BUG: Catalan donate flow is not retaining language data - https://phabricator.wikimedia.org/T94506#1168130 (10atgo) [20:22:21] (03Abandoned) 10Legoktm: jenkins job validation, do not submit [extensions/Echo] - 10https://gerrit.wikimedia.org/r/201001 (owner: 10Legoktm) [20:23:44] (03PS1) 10Krinkle: Don't force ext.wikiEditor.init in a separate cache group [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/201004 [20:24:07] (03PS2) 10Krinkle: Don't force a separate http request for ext.wikiEditor.init [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/201004 [20:26:02] 6Zero: Disable banner testing on portal with non-admin group account - https://phabricator.wikimedia.org/T94614#1168140 (10DFoy) 3NEW a:3jhobs [20:26:08] (03PS2) 10TheDJ: Fix native ogg audio playback on Android [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/200910 (https://phabricator.wikimedia.org/T74975) [20:27:40] (03CR) 10Krinkle: [C: 032] Rename Proposals to CollectionProposals [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200923 (owner: 10Cscott) [20:27:54] 6Zero: Sort list of partners in group config pulldown - https://phabricator.wikimedia.org/T94615#1168149 (10DFoy) 3NEW a:3jhobs [20:28:11] (03Merged) 10jenkins-bot: Rename Proposals to CollectionProposals [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200923 (owner: 10Cscott) [20:28:18] Krinkle: hmm, lemme try and figure out why that was made like that. [20:28:26] (03CR) 10Krinkle: [C: 032] Rename js/ to modules/ [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200924 (owner: 10Cscott) [20:28:52] 10MediaWiki-extensions-ContentTranslation: Red link to Catalan Wikipedia instead of interwiki links after publishing a page in ukwiki - https://phabricator.wikimedia.org/T94254#1168158 (10Piramidion) @Amire80: Thanks for the answer! Catalan definitely isn't set in my browser language preferences. I don't remembe... [20:29:00] (03Merged) 10jenkins-bot: Rename js/ to modules/ [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200924 (owner: 10Cscott) [20:29:17] (03CR) 10Catrope: [C: 032] Don't force a separate http request for ext.wikiEditor.init [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/201004 (owner: 10Krinkle) [20:30:02] Krinkle: possibly it had something to do with vertical margin collapsing.... [20:30:29] 10MediaWiki-Codesniffer: Allow shebang before opening (03Merged) 10jenkins-bot: Don't force a separate http request for ext.wikiEditor.init [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/201004 (owner: 10Krinkle) [20:30:46] (03CR) 10Krinkle: "The module name makes sense, but files are preferred without prefixes. The majority of our repos do still prefix, but that's on the way ou" [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200932 (owner: 10Cscott) [20:31:01] 6Zero: Change Admin behavior - home link - https://phabricator.wikimedia.org/T94091#1168161 (10DFoy) p:5Normal>3High [20:31:37] (03PS3) 10Krinkle: The transition ext.collection.jquery.jstore module is no longer needed [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200997 (owner: 10Cscott) [20:31:42] (03CR) 10Krinkle: [C: 032] The transition ext.collection.jquery.jstore module is no longer needed [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200997 (owner: 10Cscott) [20:32:13] (03Merged) 10jenkins-bot: The transition ext.collection.jquery.jstore module is no longer needed [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200997 (owner: 10Cscott) [20:34:10] (03CR) 10Cscott: "Krinkle: so do you think this patch should just be dropped on the floor, or is there anything here worth keeping?" [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200932 (owner: 10Cscott) [20:36:19] (03CR) 10Krinkle: "check_load_from_localstorage.js -> checkLoadFromLocalstorage.js (or checklocalstorage.js) would be nice, but yeah, I think the rest is bet" [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200932 (owner: 10Cscott) [20:36:24] 10Fundraising Tech Backlog: DonationInterface config should be less of a snowflake - https://phabricator.wikimedia.org/T94477#1168174 (10awight) [20:37:55] 10MediaWiki-extensions-ContentTranslation: Unable to reenter the ongoing translation in ukwiki - https://phabricator.wikimedia.org/T94402#1168176 (10Piramidion) [20:38:03] 6MediaWiki-API-Team, 10MediaWiki-extensions-OAuth, 5Patch-For-Review: Message describing OAuth activities is confusing to end user (in context of Wikidata Game) - https://phabricator.wikimedia.org/T69082#1168179 (10Peteforsyth) >>! In T69082#1164512, @MarkTraceur wrote: > Patch incoming, thanks! Hi M... [20:38:16] Krinkle: hmm, it's when vector got added, so i likely copied it from monobook.css [20:38:21] (03CR) 10Legoktm: "One PHP class per file please" (031 comment) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/183228 (owner: 10Alex Monk) [20:39:08] thedj: Hm... I miss a "browse tree" button that lets me view other pages from around that same time. Without having to dig through by timetamp. [20:39:23] Like how https://github.com/wikimedia/mediawiki/commit/01ef3c1df4f8f556 has "Browse files" [20:39:27] :) [20:39:31] Krinkle: it's been display:inline on monobook since before 2004 :) [20:39:37] Right [20:39:44] OK.I'm changing it [20:41:00] (03PS2) 10Mattflaschen: Autofocus into edit header form [extensions/Flow] - 10https://gerrit.wikimedia.org/r/199283 (https://phabricator.wikimedia.org/T90460) (owner: 10EBernhardson) [20:41:12] (03CR) 10Mattflaschen: "Changed the bug, since it was a duplicate." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/199283 (https://phabricator.wikimedia.org/T90460) (owner: 10EBernhardson) [20:41:28] 10MediaWiki-extensions-ZeroBanner, 6Zero: Zero needs to stop using mobile.templates dependency - https://phabricator.wikimedia.org/T94462#1168212 (10Yurik) [20:41:30] thedj: Modern.css actually does block https://en.wikipedia.org/wiki/MediaWiki:Modern.css [20:42:06] Krinkle: k, see no reason why it should be a problem. unless someone actually is trying to put content to the right of it (which we do with relative positioning coordinates, but that should be fine) [20:42:22] Yeah, that uses mw-indicators now right? [20:42:27] Or does enwiki not utilise that yet [20:42:31] no, not coordinates. [20:42:41] because we have thus under the header, instead of above [20:42:51] those [20:45:14] 10Fundraising Tech Backlog: DonationInterface config should be less of a snowflake - https://phabricator.wikimedia.org/T94477#1168236 (10awight) [20:46:55] (03PS1) 10CSteipp: [TEST] Ignore this [core] - 10https://gerrit.wikimedia.org/r/201007 [20:47:16] (03Abandoned) 10CSteipp: [TEST] Ignore this [core] - 10https://gerrit.wikimedia.org/r/201007 (owner: 10CSteipp) [20:47:56] cscott: [13:17] welterkj_ Anyone know the proper mw-ocg-bundler syntax for a wiki on localhost? I tried bin/mw-ocg-bundler -v -o bundle.zip --prefix localhost "Main Page" and got "Prefix not found: localhost" [20:48:00] cscott: Over in #wikimedia-tech [20:48:11] (03CR) 10Anomie: WIP: T94005: Clean up JS and change action=ajax stuff into API modules (035 comments) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/183228 (owner: 10Alex Monk) [20:48:41] (03CR) 10Mobrovac: [C: 031] Ensure the uid/gid used for shared files exists in the VM [vagrant] - 10https://gerrit.wikimedia.org/r/200935 (owner: 10BryanDavis) [20:51:40] 3Mobile-Web-Sprint-44-R_________: Filter out retired WikiGrok tags from WikiGrok pages - https://phabricator.wikimedia.org/T94445#1168246 (10bmansurov) a:3bmansurov [20:56:53] 10MediaWiki-General-or-Unknown: Watchlist notification bubble changed appearance on enwiki - https://phabricator.wikimedia.org/T94518#1168252 (10Aklapper) Confirming, and on en.wp in Vector skin I see this CSS for positioning: .mediawiki .mw-notification-area-layout { top: 7em; } while I don't see that C... [20:57:10] (03PS2) 10Ori.livneh: resourceloader: Simplify getHashMtime() to merely a timestamp [core] - 10https://gerrit.wikimedia.org/r/200908 (owner: 10Krinkle) [20:57:20] (03CR) 10Ori.livneh: [C: 032] resourceloader: Simplify getHashMtime() to merely a timestamp [core] - 10https://gerrit.wikimedia.org/r/200908 (owner: 10Krinkle) [20:57:27] 10MediaWiki-extensions-ContentTranslation: show adapted templates more clearly in ContentTranslation - https://phabricator.wikimedia.org/T94622#1168253 (10Amire80) 3NEW [20:58:04] 3Fundraising Sprint H, 10Fundraising-Backlog, 3Fundraising Sprint Grandmaster Flash: BUG: Catalan donate flow is not retaining language data - https://phabricator.wikimedia.org/T94506#1168262 (10awight) a:3awight [20:58:32] 10Hovercards, 7Beta-Feature, 5Patch-For-Review: Hovercards: Create access point for user survey in hovercards - https://phabricator.wikimedia.org/T1005#1168263 (10Jaredzimmerman-WMF) I'd like to fix this, but I'm not going to consider it a blocker for the test. [20:58:34] (03CR) 10EBernhardson: "This can't be done before reinitializeContainer, because the act of focusing is actually what triggers the editor to load. Before focusin" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/199283 (https://phabricator.wikimedia.org/T90460) (owner: 10EBernhardson) [20:59:37] (03CR) 10EBernhardson: "i should add that the reason we currently only load the editor on focus is that many" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/199283 (https://phabricator.wikimedia.org/T90460) (owner: 10EBernhardson) [21:00:06] (03CR) 10EBernhardson: "i should add that the reason we currently only load the editor on focus is that many forms, like new topic and topic replys, do not want a" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/199283 (https://phabricator.wikimedia.org/T90460) (owner: 10EBernhardson) [21:04:05] 3Fundraising Sprint H, 10Fundraising-Backlog, 3Fundraising Sprint Grandmaster Flash: BUG: Catalan donate flow is not retaining language data - https://phabricator.wikimedia.org/T94506#1168269 (10CCogdill_WMF) @atgo yes, all the reports we've gotten have been from GC donors. [21:05:15] 10MediaWiki-Page-editing, 7JavaScript: Prevent double submitting - https://phabricator.wikimedia.org/T94429#1168271 (10TheDJ) the workaround you proposed would break live preview submit. My gut feeling says, 'broken browser extension'.. do you have any browser extensions enabled ? [21:05:59] (03PS3) 10Ori.livneh: mw.track: Add test suite [core] - 10https://gerrit.wikimedia.org/r/200270 (owner: 10Krinkle) [21:06:08] (03CR) 10Ori.livneh: [C: 031] mw.track: Add test suite [core] - 10https://gerrit.wikimedia.org/r/200270 (owner: 10Krinkle) [21:07:06] 10MediaWiki-extensions-ZeroBanner, 6Zero: Zero needs to stop using mobile.templates dependency - https://phabricator.wikimedia.org/T94462#1168279 (10DFoy) p:5Triage>3Normal a:3jhobs [21:08:22] (03CR) 10Krinkle: [C: 031] "Thx. The difference in size doesn't really matter." [core] - 10https://gerrit.wikimedia.org/r/200270 (owner: 10Krinkle) [21:09:25] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 7Tracking: Implement complete RDF mapping for entities (tracking) - https://phabricator.wikimedia.org/T50143#1168289 (10Smalyshev) [21:11:29] 3ECT-March-2015: Clarify MediaWiki and WMF Backporting requests process with regard to Phabricator tasks - https://phabricator.wikimedia.org/T91251#1168292 (10Aklapper) 5Open>3Resolved T40865 was closed as superseded by #WMF-Server-Backports (though it only lists greg as watcher, not sure if that's "enough")... [21:13:15] 10MediaWiki-extensions-ZeroPortal, 6Zero: Images uploaded to Zerowiki used on landing page are not accessible by anonymous users - https://phabricator.wikimedia.org/T85548#1168294 (10DFoy) a:3jhobs [21:13:26] 6Security: MediaWiki Security release 1.24.2 - https://phabricator.wikimedia.org/T87275#1168295 (10csteipp) [21:13:54] 6MediaWiki-Core-Team, 6Security, 5Patch-For-Review: Custom JavaScript may yield privilege escalation - https://phabricator.wikimedia.org/T85855#1168298 (10csteipp) [21:14:34] 6Security: MediaWiki is vulnerable to XML quadratic blowup attacks - https://phabricator.wikimedia.org/T71210#1168301 (10csteipp) [21:14:47] 6MediaWiki-Core-Team, 6Security: xml_parse doesn't expand internal entities sometimes - https://phabricator.wikimedia.org/T88310#1168307 (10csteipp) [21:14:59] 10MediaWiki-extensions-Scribunto, 6Security, 7Vuln-XSS: Function names aren't sanitized in Lua error backtraces - https://phabricator.wikimedia.org/T85113#1168310 (10csteipp) [21:15:17] 6MediaWiki-Core-Team, 6Security: Billion Laughs attack in SVG and XMP Metadata - https://phabricator.wikimedia.org/T85848#1168313 (10csteipp) [21:15:30] 10MediaWiki-API, 6MediaWiki-Core-Team, 6Security, 7HHVM, 7Vuln-XSS: Reflected XSS in api.php using wddx formatting - https://phabricator.wikimedia.org/T85851#1168316 (10csteipp) [21:15:42] 6Security, 7Vuln-XSS: SVG @import style validation bypass - https://phabricator.wikimedia.org/T85349#1168319 (10csteipp) [21:15:49] 10MediaWiki-extensions-Collection: Load colletion link not showing up in saved Collection pages - https://phabricator.wikimedia.org/T94624#1168322 (10Srcjunior) 3NEW [21:15:56] 6MediaWiki-Core-Team, 6Security, 5Patch-For-Review, 7Vuln-XSS: XSS in language converter when used with Html class's tricky escaping - https://phabricator.wikimedia.org/T73394#1168329 (10csteipp) [21:16:08] 6Security, 5Patch-For-Review: Extremely large passwords as DoS - https://phabricator.wikimedia.org/T64685#1168331 (10csteipp) [21:16:18] 10MediaWiki-extensions-CheckUser, 6Security: Check User page lacks CSRF protection - https://phabricator.wikimedia.org/T85858#1168334 (10csteipp) [21:16:30] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review: Revision slave does not belong to entity Q139 - https://phabricator.wikimedia.org/T91517#1168337 (10hoo) No more such exceptions since we deployed the new exception message. [21:16:36] 6MediaWiki-Core-Team, 6Security: Stored XSS in SVG via embedded SVG - https://phabricator.wikimedia.org/T85850#1168338 (10csteipp) [21:16:46] 6MediaWiki-Core-Team, 6Security, 7Vuln-XSS: Fix SVG blacklist for animate - https://phabricator.wikimedia.org/T86711#1168341 (10csteipp) [21:18:22] (03Merged) 10jenkins-bot: resourceloader: Simplify getHashMtime() to merely a timestamp [core] - 10https://gerrit.wikimedia.org/r/200908 (owner: 10Krinkle) [21:18:35] (03PS2) 10BryanDavis: Ensure the uid/gid used for shared files exists in the VM [vagrant] - 10https://gerrit.wikimedia.org/r/200935 [21:18:53] (03CR) 10BryanDavis: [C: 032] "Things are broken without this." [vagrant] - 10https://gerrit.wikimedia.org/r/200935 (owner: 10BryanDavis) [21:19:11] (03Merged) 10jenkins-bot: Ensure the uid/gid used for shared files exists in the VM [vagrant] - 10https://gerrit.wikimedia.org/r/200935 (owner: 10BryanDavis) [21:20:10] 10MediaWiki-extensions-ContentTranslation: Unable to reenter the ongoing translation in ukwiki - https://phabricator.wikimedia.org/T94402#1168352 (10Amire80) p:5Triage>3High Yes, I indeed opened T94567 when I was trying to reproduce this one. That one is self-contained and easy to reproduce. I'm not so sure... [21:20:46] 10TextExtracts, 7Regression: Hovercard for article Baden-Württemberg shows error message as text extract - https://phabricator.wikimedia.org/T94012#1168354 (10Fomafix) This problem occurs often: https://www.google.de/search?q=%22Die+Version+0+der+Seite+namens%22 has currently 1.540 findings. [21:21:00] 10MediaWiki-extensions-ZeroBanner, 10Wikimedia-Apache-configuration, 6Zero, 7Mobile: m.wikipedia.org incorrectly redirects to en.m.wikipedia.org - https://phabricator.wikimedia.org/T69015#1168355 (10DFoy) a:3Yurik [21:22:20] (03PS1) 10CSteipp: SECURITY: Make SVG @import checking case insensitive [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/201011 (https://phabricator.wikimedia.org/T85349) [21:22:22] (03PS1) 10CSteipp: SECURITY: Don't allow embedded application/xml in SVG's [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/201012 (https://phabricator.wikimedia.org/T85850) [21:22:24] (03PS1) 10CSteipp: SECURITY: Fix animate blacklist [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/201013 (https://phabricator.wikimedia.org/T86711) [21:22:26] (03PS1) 10CSteipp: SECURITY: Set maximal password length for DoS [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/201014 (https://phabricator.wikimedia.org/T64685) [21:22:28] (03PS1) 10CSteipp: SECURITY: Don't execute another user's CSS or JS on preview [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/201015 (https://phabricator.wikimedia.org/T85855) [21:22:30] (03PS1) 10CSteipp: SECURITY: Escape > in Html::expandAttributes [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/201016 (https://phabricator.wikimedia.org/T73394) [21:22:32] (03PS1) 10CSteipp: SECURITY: Always expand xml entities when checking SVG's [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/201017 (https://phabricator.wikimedia.org/T88310) [21:22:34] (03PS1) 10CSteipp: SECURITY: Don't allow directly calling Xml::isWellFormed [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/201018 (https://phabricator.wikimedia.org/T85848) [21:22:36] (03PS1) 10CSteipp: SECURITY: Don't allow entities in XMP [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/201019 (https://phabricator.wikimedia.org/T85848) [21:22:38] (03PS1) 10CSteipp: SECURITY: Fix reflected XSS in API with wddx output under HHVM [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/201020 (https://phabricator.wikimedia.org/T85851) [21:22:40] (03PS1) 10CSteipp: Updated release notes and version number for MediaWiki 1.24.2 [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/201021 [21:25:56] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review: Revision slave does not belong to entity Q139 - https://phabricator.wikimedia.org/T91517#1168384 (10aude) could it be something in core was causing some (or most) of these that we had last week? and it... [21:26:19] 10MediaWiki-extensions-ZeroPortal, 6Zero: Move proxy IP lists to META for Varnish XFF decoding - https://phabricator.wikimedia.org/T89838#1168393 (10DFoy) a:3Yurik [21:26:42] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Wiktionary: Phase 1: Represent Wiktionary lexicon using structured data - https://phabricator.wikimedia.org/T988#1168396 (10jberkel) Is there an easy way to set up one (or even several) WikiData / Wiktionary integration sandboxes where interested partie... [21:27:15] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review: Revision slave does not belong to entity Q139 - https://phabricator.wikimedia.org/T91517#1168397 (10hoo) Possible... let's keep this open for another few days and check back then. [21:27:57] 10MediaWiki-extensions-ZeroBanner, 6Zero, 7Documentation, 7Easy: ZeroBanner doc still reference X-CS header when it is now X-CS2 - https://phabricator.wikimedia.org/T72162#1168399 (10DFoy) a:3Yurik [21:28:24] 10MediaWiki-extensions-ZeroPortal, 6Zero: Images uploaded to Zerowiki used on landing page are not accessible by anonymous users - https://phabricator.wikimedia.org/T85548#1168400 (10jhobs) We're uploading to Commons, currently awaiting verification of attribution. [21:29:02] 10MediaWiki-API: API's "Reverse continue" ability - https://phabricator.wikimedia.org/T94626#1168401 (10Yurik) 3NEW [21:30:00] (03PS1) 10CSteipp: SECURITY: Make SVG @import checking case insensitive [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/201023 (https://phabricator.wikimedia.org/T85349) [21:30:02] (03PS1) 10CSteipp: SECURITY: Don't allow embedded application/xml in SVG's [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/201024 (https://phabricator.wikimedia.org/T85850) [21:30:04] (03PS1) 10CSteipp: SECURITY: Fix animate blacklist [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/201025 (https://phabricator.wikimedia.org/T86711) [21:30:06] (03PS1) 10CSteipp: SECURITY: Don't execute another user's CSS or JS on preview [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/201026 (https://phabricator.wikimedia.org/T85855) [21:30:08] (03PS1) 10CSteipp: SECURITY: Escape > in Html::expandAttributes [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/201027 (https://phabricator.wikimedia.org/T73394) [21:30:10] (03PS1) 10CSteipp: SECURITY: Always expand xml entities when checking SVG's [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/201028 (https://phabricator.wikimedia.org/T88310) [21:30:12] (03PS1) 10CSteipp: SECURITY: Don't allow directly calling Xml::isWellFormed [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/201029 (https://phabricator.wikimedia.org/T85848) [21:30:14] (03PS1) 10CSteipp: SECURITY: Don't allow entities in XMP [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/201030 (https://phabricator.wikimedia.org/T85848) [21:30:16] (03PS1) 10CSteipp: Updated release notes and version number for MediaWiki 1.23.9 [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/201031 [21:31:53] (03CR) 10Mattflaschen: [C: 04-1] "Mostly these are pretty straightforward. Also, Matthias's comments still apply." (0319 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/197817 (https://phabricator.wikimedia.org/T90763) (owner: 10EBernhardson) [21:32:13] 10MediaWiki-API: API's "Reverse continue" ability - https://phabricator.wikimedia.org/T94626#1168423 (10Anomie) p:5Triage>3Low [21:34:22] (03CR) 10EBernhardson: "talked to danny, and for this first version the wikitext switcher while not exactly the same is ok for now, doesn't need to look exactly l" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/197817 (https://phabricator.wikimedia.org/T90763) (owner: 10EBernhardson) [21:34:26] 10MediaWiki-API: API's "Reverse continue" ability - https://phabricator.wikimedia.org/T94626#1168431 (10Anomie) I note this would likely require significant additional complexity in nearly all API query modules, so a real use case (beyond "someone might want a 'prev' button") would be helpful. [21:34:38] (03CR) 10EBernhardson: "the icon that is" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/197817 (https://phabricator.wikimedia.org/T90763) (owner: 10EBernhardson) [21:35:31] (03PS1) 10CSteipp: SECURITY: Make SVG @import checking case insensitive [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/201033 (https://phabricator.wikimedia.org/T85349) [21:35:33] (03PS1) 10CSteipp: SECURITY: Don't allow embedded application/xml in SVG's [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/201034 (https://phabricator.wikimedia.org/T85850) [21:35:35] (03PS1) 10CSteipp: SECURITY: Fix animate blacklist [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/201035 (https://phabricator.wikimedia.org/T86711) [21:35:37] (03PS1) 10CSteipp: SECURITY: Don't execute another user's CSS or JS on preview [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/201036 (https://phabricator.wikimedia.org/T85855) [21:35:39] (03PS1) 10CSteipp: SECURITY: Escape > in Html::expandAttributes [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/201037 (https://phabricator.wikimedia.org/T73394) [21:35:41] (03PS1) 10CSteipp: SECURITY: Always expand xml entities when checking SVG's [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/201038 (https://phabricator.wikimedia.org/T88310) [21:35:43] (03PS1) 10CSteipp: SECURITY: Don't allow entities in XMP [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/201039 (https://phabricator.wikimedia.org/T85848) [21:35:45] (03PS1) 10CSteipp: Updated release notes and version number for MediaWiki 1.19.24 [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/201040 [21:37:08] (03CR) 10CSteipp: [C: 032] SECURITY: Make SVG @import checking case insensitive [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/201011 (https://phabricator.wikimedia.org/T85349) (owner: 10CSteipp) [21:37:24] (03CR) 10CSteipp: [C: 032] SECURITY: Don't allow embedded application/xml in SVG's [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/201012 (https://phabricator.wikimedia.org/T85850) (owner: 10CSteipp) [21:37:34] (03CR) 10CSteipp: [C: 032] SECURITY: Fix animate blacklist [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/201013 (https://phabricator.wikimedia.org/T86711) (owner: 10CSteipp) [21:37:47] (03CR) 10CSteipp: [C: 032] SECURITY: Set maximal password length for DoS [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/201014 (https://phabricator.wikimedia.org/T64685) (owner: 10CSteipp) [21:37:59] (03CR) 10CSteipp: [C: 032] SECURITY: Don't execute another user's CSS or JS on preview [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/201015 (https://phabricator.wikimedia.org/T85855) (owner: 10CSteipp) [21:38:09] (03CR) 10CSteipp: [C: 032] SECURITY: Escape > in Html::expandAttributes [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/201016 (https://phabricator.wikimedia.org/T73394) (owner: 10CSteipp) [21:38:20] (03CR) 10CSteipp: [C: 032] SECURITY: Always expand xml entities when checking SVG's [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/201017 (https://phabricator.wikimedia.org/T88310) (owner: 10CSteipp) [21:38:29] (03CR) 10CSteipp: [C: 032] SECURITY: Don't allow directly calling Xml::isWellFormed [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/201018 (https://phabricator.wikimedia.org/T85848) (owner: 10CSteipp) [21:38:43] (03CR) 10CSteipp: [C: 032] SECURITY: Don't allow entities in XMP [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/201019 (https://phabricator.wikimedia.org/T85848) (owner: 10CSteipp) [21:39:07] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 7Tracking: Implement complete RDF mapping for entities (tracking) - https://phabricator.wikimedia.org/T50143#1168454 (10Smalyshev) [21:40:23] (03CR) 10CSteipp: [C: 032] SECURITY: Fix reflected XSS in API with wddx output under HHVM [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/201020 (https://phabricator.wikimedia.org/T85851) (owner: 10CSteipp) [21:40:34] (03CR) 10CSteipp: [C: 032] Updated release notes and version number for MediaWiki 1.24.2 [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/201021 (owner: 10CSteipp) [21:41:11] (03CR) 10CSteipp: [C: 032] SECURITY: Make SVG @import checking case insensitive [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/201023 (https://phabricator.wikimedia.org/T85349) (owner: 10CSteipp) [21:41:19] (03CR) 10CSteipp: [C: 032] SECURITY: Don't allow embedded application/xml in SVG's [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/201024 (https://phabricator.wikimedia.org/T85850) (owner: 10CSteipp) [21:41:26] (03CR) 10CSteipp: [C: 032] SECURITY: Fix animate blacklist [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/201025 (https://phabricator.wikimedia.org/T86711) (owner: 10CSteipp) [21:41:36] (03CR) 10CSteipp: [C: 032] SECURITY: Don't execute another user's CSS or JS on preview [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/201026 (https://phabricator.wikimedia.org/T85855) (owner: 10CSteipp) [21:41:43] (03CR) 10CSteipp: [C: 032] SECURITY: Escape > in Html::expandAttributes [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/201027 (https://phabricator.wikimedia.org/T73394) (owner: 10CSteipp) [21:41:49] 10MediaWiki-Uploading, 6Commons, 6Multimedia, 6operations, 5Patch-For-Review: http-bad-status - 403 Forbidden when trying to upload file from tools.wikimedia.pl by URL to Commons - https://phabricator.wikimedia.org/T75200#1168461 (10saper) Last time I tried was when I commented on this bug - it just time... [21:41:56] (03CR) 10CSteipp: [C: 032] SECURITY: Always expand xml entities when checking SVG's [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/201028 (https://phabricator.wikimedia.org/T88310) (owner: 10CSteipp) [21:42:12] (03CR) 10CSteipp: [C: 032] SECURITY: Don't allow directly calling Xml::isWellFormed [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/201029 (https://phabricator.wikimedia.org/T85848) (owner: 10CSteipp) [21:42:24] (03CR) 10CSteipp: [C: 032] SECURITY: Don't allow entities in XMP [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/201030 (https://phabricator.wikimedia.org/T85848) (owner: 10CSteipp) [21:42:30] cscott: hmm, did we thoroughly test the SVG changes to all our svgs ? [21:42:34] (03CR) 10CSteipp: [C: 032] Updated release notes and version number for MediaWiki 1.23.9 [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/201031 (owner: 10CSteipp) [21:42:45] csteipp: eh did we thoroughly test the SVG changes to all our svgs ? [21:42:53] ah. i was confused. [21:43:01] (03CR) 10CSteipp: [C: 032] SECURITY: Make SVG @import checking case insensitive [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/201033 (https://phabricator.wikimedia.org/T85349) (owner: 10CSteipp) [21:43:11] (03CR) 10CSteipp: [C: 032] SECURITY: Don't allow embedded application/xml in SVG's [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/201034 (https://phabricator.wikimedia.org/T85850) (owner: 10CSteipp) [21:43:15] everyone should have unique first two letters for tab completion reasons :) [21:43:27] (03CR) 10CSteipp: [C: 032] SECURITY: Fix animate blacklist [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/201035 (https://phabricator.wikimedia.org/T86711) (owner: 10CSteipp) [21:43:48] (03CR) 10CSteipp: [C: 032] SECURITY: Don't execute another user's CSS or JS on preview [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/201036 (https://phabricator.wikimedia.org/T85855) (owner: 10CSteipp) [21:43:52] because it took a shitload of tries to get them all working the first time round (and of course that was before we did unit tests :) [21:45:39] (03CR) 10CSteipp: [C: 032] SECURITY: Escape > in Html::expandAttributes [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/201037 (https://phabricator.wikimedia.org/T73394) (owner: 10CSteipp) [21:45:46] (03CR) 10CSteipp: [C: 032] SECURITY: Always expand xml entities when checking SVG's [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/201038 (https://phabricator.wikimedia.org/T88310) (owner: 10CSteipp) [21:45:55] (03CR) 10CSteipp: [C: 032] SECURITY: Don't allow entities in XMP [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/201039 (https://phabricator.wikimedia.org/T85848) (owner: 10CSteipp) [21:45:58] (03Merged) 10jenkins-bot: SECURITY: Make SVG @import checking case insensitive [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/201011 (https://phabricator.wikimedia.org/T85349) (owner: 10CSteipp) [21:46:03] (03CR) 10CSteipp: [C: 032] Updated release notes and version number for MediaWiki 1.19.24 [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/201040 (owner: 10CSteipp) [21:46:08] (03Merged) 10jenkins-bot: SECURITY: Don't allow embedded application/xml in SVG's [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/201012 (https://phabricator.wikimedia.org/T85850) (owner: 10CSteipp) [21:46:11] (03Merged) 10jenkins-bot: SECURITY: Fix animate blacklist [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/201013 (https://phabricator.wikimedia.org/T86711) (owner: 10CSteipp) [21:46:34] thedj: probably best to comment on the relevant task than in here, chris is a bit busy with the release [21:46:39] Tarballs don't have tests in right? [21:49:56] Lcawte: they do now [21:51:08] thedj: I ran the svg changes through about 20k svg files that I have locally [21:51:48] thedj: And they've been deployed on commons for about a month, and I hadn't noticed any bugs opened... if there were, do point me at them [21:51:59] legoktm: So since 1.24.1 or .2? [21:52:12] 6Phabricator, 6Labs: Phab-02 sending old stylesheet copies - https://phabricator.wikimedia.org/T94413#1168477 (10yuvipanda) So sendfile is turned on, however since it is just proxying things I do not know if that's actually causing this issue or not. [21:52:16] csteipp: ok, wanted to make sure we had been that thorough with the content :) [21:52:28] Lcawte: .2 I believe [21:53:25] Is there a way that tests can be removed from the patch files when they're generated? It's really noisey trying to patch my 1.24.0 tarball install when all there are patches for tests that weren't included... [21:53:32] also, this is why no one uses Xml anymore :) [21:53:46] 6Phabricator, 6Labs: Phab-02 sending old stylesheet copies - https://phabricator.wikimedia.org/T94413#1168478 (10yuvipanda) (I don't mind turning it off if needed since shouldn't affect our usecase, but I am not sure if that'll help you) [21:53:48] thedj: Seriously!! [21:55:36] when it tries to apply patches for tests that weren't included. * [21:55:56] <^demon|away> No, they won't be excluded. It was a mistake to start excluding them [21:56:12] 6Phabricator, 6Labs: Phab-02 sending old stylesheet copies - https://phabricator.wikimedia.org/T94413#1168487 (10Negative24) >>! In T94413#1168478, @yuvipanda wrote: > (I don't mind turning it off if needed since shouldn't affect our usecase, but I am not sure if that'll help you) Do you mind turning it off f... [21:57:16] 10MediaWiki-API: API's "Reverse continue" ability - https://phabricator.wikimedia.org/T94626#1168489 (10Yurik) The use case would be any kind of paging user interface with lists. For example, if we were to replace [[ https://en.wikipedia.org/wiki/Special:AllPages | Special:AllPages ]] with a dynamic one, we woul... [21:59:18] 6MediaWiki-API-Team, 10MediaWiki-extensions-OAuth, 5Patch-For-Review: Message describing OAuth activities is confusing to end user (in context of Wikidata Game) - https://phabricator.wikimedia.org/T69082#1168493 (10Krinkle) I suppose it would also be desirable to allow tools to request authorisation with OAu... [21:59:48] (03Merged) 10jenkins-bot: SECURITY: Set maximal password length for DoS [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/201014 (https://phabricator.wikimedia.org/T64685) (owner: 10CSteipp) [21:59:51] (03Merged) 10jenkins-bot: SECURITY: Don't execute another user's CSS or JS on preview [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/201015 (https://phabricator.wikimedia.org/T85855) (owner: 10CSteipp) [21:59:54] (03Merged) 10jenkins-bot: SECURITY: Escape > in Html::expandAttributes [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/201016 (https://phabricator.wikimedia.org/T73394) (owner: 10CSteipp) [22:01:20] (03CR) 10Gergő Tisza: [C: 032] mw.track: Add test suite [core] - 10https://gerrit.wikimedia.org/r/200270 (owner: 10Krinkle) [22:02:17] 10MediaWiki-API: API's "Reverse continue" ability - https://phabricator.wikimedia.org/T94626#1168500 (10Anomie) So nothing yet that's not hypothetical? [22:04:23] oh the irony of csteipp now DoS'ing our jenkins setup with anti-DoS [22:04:27] patches :) [22:05:05] (03Merged) 10jenkins-bot: SECURITY: Always expand xml entities when checking SVG's [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/201017 (https://phabricator.wikimedia.org/T88310) (owner: 10CSteipp) [22:05:08] (03Merged) 10jenkins-bot: SECURITY: Don't allow directly calling Xml::isWellFormed [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/201018 (https://phabricator.wikimedia.org/T85848) (owner: 10CSteipp) [22:05:22] 10Wikimedia-Hackathon-2015: Topic: Antivandalism mini-con - https://phabricator.wikimedia.org/T94627#1168508 (10Petrb) 3NEW [22:05:29] (03Merged) 10jenkins-bot: SECURITY: Don't allow entities in XMP [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/201019 (https://phabricator.wikimedia.org/T85848) (owner: 10CSteipp) [22:05:32] (03Merged) 10jenkins-bot: SECURITY: Fix reflected XSS in API with wddx output under HHVM [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/201020 (https://phabricator.wikimedia.org/T85851) (owner: 10CSteipp) [22:05:34] (03Merged) 10jenkins-bot: Updated release notes and version number for MediaWiki 1.24.2 [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/201021 (owner: 10CSteipp) [22:07:07] Isarra: yo! yt? [22:08:03] 10MediaWiki-extensions-Other: HTMLTags code hacks to WikiEditor - https://phabricator.wikimedia.org/T49585#1168535 (10Mvolz) [22:10:44] 10LiquidThreads: Dependent on WikiEditor Extension - https://phabricator.wikimedia.org/T40654#1168540 (10Mvolz) [22:10:52] ori: Hi. [22:11:49] Isarra: it seems wmf-config was never updated after https://gerrit.wikimedia.org/r/#/c/195195/ landed ; is there any reason not to use $wgLogoHD to configure (for example) enwiki's HD logo alternates, as opposed to hacking them in Common.css? [22:12:28] Not that I know of. Or did anyone ever decide where to actually get the versions from? [22:12:31] Thanks for the security patch :) [22:12:34] (03PS1) 10Cscott: Add --php-api option to allow manually specifying PHP API endpoint. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/201049 [22:13:35] Isarra: what do you mean? [22:14:54] 6Phabricator, 6Project-Creators: Create MobileFrontend project - https://phabricator.wikimedia.org/T94629#1168556 (10Krenair) You're requesting: * A "MobileFrontend" project * A herald rule to automatically add #Mobile-web to any task in this project ? [22:14:58] ori: The common.css specifies two sizes of thumbs from commons. [22:15:21] Is that how we want to do all of them? Do we want to automate it more for the different projects? [22:15:37] Or do we need to manually set all of them for all of them? [22:16:19] Isarra: yeah, we probably want to automate it somehow. [22:16:56] Isarra: could you sanity-check https://gerrit.wikimedia.org/r/#/c/201050/ and +1 it if it looks good? (Yes, we should automate it, but this is OK for now, I think.) [22:17:39] 6MediaWiki-API-Team, 10MediaWiki-extensions-OAuth, 5Patch-For-Review: Message describing OAuth activities is confusing to end user (in context of Wikidata Game) - https://phabricator.wikimedia.org/T69082#1168572 (10Anomie) >>! In T69082#1168493, @Krinkle wrote: > I suppose it would also be desirable to allow... [22:18:13] Gerrit sucks. [22:18:21] * Isarra punches it in the face. [22:19:14] ^demon|away: Okay, so ignoring the opinions on whether or not tests should be in tarballs, what's your reasoning for test changes to sit on top of a release that didn't initially contain them? Because they won't apply at all, and the small changes to the odd file will be pretty useless if you do apply them... [22:19:40] ori: It seems reasonable for now. If I ever get it to actually load I'll +1 it. >.> [22:20:32] anomie, you've brought up a lot of real issues at https://gerrit.wikimedia.org/r/#/c/183228/9/ApiCollection.php - but I also think that a few of the things you've commented on are existing issues. [22:20:37] I really want to get rid of the action=ajax stuff [22:20:39] I think those modules should all be marked as internal, at least for now. [22:21:45] (03Merged) 10jenkins-bot: SECURITY: Make SVG @import checking case insensitive [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/201023 (https://phabricator.wikimedia.org/T85349) (owner: 10CSteipp) [22:21:48] (03Merged) 10jenkins-bot: SECURITY: Don't allow embedded application/xml in SVG's [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/201024 (https://phabricator.wikimedia.org/T85850) (owner: 10CSteipp) [22:21:51] (03Merged) 10jenkins-bot: SECURITY: Fix animate blacklist [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/201025 (https://phabricator.wikimedia.org/T86711) (owner: 10CSteipp) [22:21:53] 4(no projects): puppet compiler broken - https://phabricator.wikimedia.org/T94631#1168582 (10Dzahn) 3NEW [22:21:54] (03Merged) 10jenkins-bot: SECURITY: Don't execute another user's CSS or JS on preview [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/201026 (https://phabricator.wikimedia.org/T85855) (owner: 10CSteipp) [22:21:57] (03Merged) 10jenkins-bot: SECURITY: Escape > in Html::expandAttributes [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/201027 (https://phabricator.wikimedia.org/T73394) (owner: 10CSteipp) [22:22:00] (03Merged) 10jenkins-bot: SECURITY: Always expand xml entities when checking SVG's [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/201028 (https://phabricator.wikimedia.org/T88310) (owner: 10CSteipp) [22:22:03] (03Merged) 10jenkins-bot: SECURITY: Don't allow directly calling Xml::isWellFormed [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/201029 (https://phabricator.wikimedia.org/T85848) (owner: 10CSteipp) [22:22:07] (03Merged) 10jenkins-bot: SECURITY: Don't allow entities in XMP [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/201030 (https://phabricator.wikimedia.org/T85848) (owner: 10CSteipp) [22:22:09] (03Merged) 10jenkins-bot: Updated release notes and version number for MediaWiki 1.23.9 [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/201031 (owner: 10CSteipp) [22:22:11] (03Merged) 10jenkins-bot: SECURITY: Make SVG @import checking case insensitive [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/201033 (https://phabricator.wikimedia.org/T85349) (owner: 10CSteipp) [22:22:14] (03Merged) 10jenkins-bot: SECURITY: Don't allow embedded application/xml in SVG's [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/201034 (https://phabricator.wikimedia.org/T85850) (owner: 10CSteipp) [22:22:16] (03Merged) 10jenkins-bot: SECURITY: Fix animate blacklist [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/201035 (https://phabricator.wikimedia.org/T86711) (owner: 10CSteipp) [22:22:19] (03Merged) 10jenkins-bot: SECURITY: Don't execute another user's CSS or JS on preview [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/201036 (https://phabricator.wikimedia.org/T85855) (owner: 10CSteipp) [22:22:22] (03Merged) 10jenkins-bot: SECURITY: Escape > in Html::expandAttributes [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/201037 (https://phabricator.wikimedia.org/T73394) (owner: 10CSteipp) [22:22:34] lol [22:22:45] good job jenkins [22:23:11] (03PS2) 10MaxSem: Role for Disambiguator [vagrant] - 10https://gerrit.wikimedia.org/r/200606 [22:24:10] 6MediaWiki-API-Team, 10MediaWiki-extensions-OAuth: Only show grants that the user has permission to use, to avoid confusion - https://phabricator.wikimedia.org/T94478#1168626 (10Anomie) Something else that came to mind: would you show a grant like "Delete pages, revisions, and log entries" (see [[https://www.m... [22:26:43] (03CR) 10Kaldari: [C: 031] Role for Disambiguator [vagrant] - 10https://gerrit.wikimedia.org/r/200606 (owner: 10MaxSem) [22:27:30] 10Wikimedia-Git-or-Gerrit: Document how to tag extensions in git - https://phabricator.wikimedia.org/T94412#1168633 (10Krenair) [22:28:12] (03Merged) 10jenkins-bot: SECURITY: Don't allow entities in XMP [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/201039 (https://phabricator.wikimedia.org/T85848) (owner: 10CSteipp) [22:28:28] (03Merged) 10jenkins-bot: Updated release notes and version number for MediaWiki 1.19.24 [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/201040 (owner: 10CSteipp) [22:28:30] (03CR) 10Dduvall: [C: 032] Role for Disambiguator [vagrant] - 10https://gerrit.wikimedia.org/r/200606 (owner: 10MaxSem) [22:29:18] (03CR) 10Dzahn: "puppet/modules/role/manifests/" [vagrant] - 10https://gerrit.wikimedia.org/r/200606 (owner: 10MaxSem) [22:29:34] (03CR) 10Aaron Schulz: Fixed bug where catching DB errors left ignoreErrors() on (033 comments) [core] - 10https://gerrit.wikimedia.org/r/197978 (owner: 10Aaron Schulz) [22:30:34] (03CR) 10MaxSem: "@Dzahn, yep! Seems like operations/puppet needs this too? :)" [vagrant] - 10https://gerrit.wikimedia.org/r/200606 (owner: 10MaxSem) [22:31:37] (03CR) 10MaxSem: [C: 04-2] "Eh, has an unrelated change." [vagrant] - 10https://gerrit.wikimedia.org/r/200606 (owner: 10MaxSem) [22:33:13] 10MediaWiki-API, 6MediaWiki-API-Team, 10MediaWiki-User-login-and-signup, 6CA-team, 10Wikipedia-App-Android-App: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1168645 (10Mattflaschen) Are you testing in the production environment? Maybe it has something to... [22:33:22] (03PS3) 10MaxSem: Role for Disambiguator [vagrant] - 10https://gerrit.wikimedia.org/r/200606 [22:33:37] Isarra: thanks! [22:33:38] MaxSem: sorry, did i jump the gun on merging your ps? [22:33:47] (03CR) 10MaxSem: [C: 032] Role for Disambiguator [vagrant] - 10https://gerrit.wikimedia.org/r/200606 (owner: 10MaxSem) [22:34:13] marxarelli, I managed to commit an unrelated submodulle update, had to undo it quickly:) [22:34:20] (03Merged) 10jenkins-bot: Role for Disambiguator [vagrant] - 10https://gerrit.wikimedia.org/r/200606 (owner: 10MaxSem) [22:35:55] 10MediaWiki-extensions-Scribunto, 6Security, 7Vuln-XSS: Function names aren't sanitized in Lua error backtraces - https://phabricator.wikimedia.org/T85113#1168651 (10Kghbln) Admittedly I am a bit confused here. The patches date from December 22, 2014 though the REL1_23 and REL1_24 branches were last touched... [22:38:13] 6MediaWiki-API-Team, 10MediaWiki-extensions-CentralAuth, 10SUL-Finalization: GlobalRenameQueue needs a means (status) to set "on hold" function on a rename request - https://phabricator.wikimedia.org/T94321#1168652 (10Billinghurst) Pretty much the case that there would be no need to change the workflow. I th... [22:38:40] (03Merged) 10jenkins-bot: mw.track: Add test suite [core] - 10https://gerrit.wikimedia.org/r/200270 (owner: 10Krinkle) [22:39:13] (03PS1) 10CSteipp: SECURITY: Sanitize the content of Lua backtraces [extensions/Scribunto] (REL1_24) - 10https://gerrit.wikimedia.org/r/201055 (https://phabricator.wikimedia.org/T85113) [22:40:57] (03CR) 10CSteipp: [C: 032] "Deployed security patch" [extensions/Scribunto] (REL1_24) - 10https://gerrit.wikimedia.org/r/201055 (https://phabricator.wikimedia.org/T85113) (owner: 10CSteipp) [22:42:03] (03PS1) 10CSteipp: SECURITY: Sanitize the content of Lua backtraces [extensions/Scribunto] (REL1_23) - 10https://gerrit.wikimedia.org/r/201056 (https://phabricator.wikimedia.org/T85113) [22:42:26] (03CR) 10CSteipp: [C: 032] "deployed security patch" [extensions/Scribunto] (REL1_23) - 10https://gerrit.wikimedia.org/r/201056 (https://phabricator.wikimedia.org/T85113) (owner: 10CSteipp) [22:43:18] (03CR) 10CSteipp: [V: 032] SECURITY: Sanitize the content of Lua backtraces [extensions/Scribunto] (REL1_24) - 10https://gerrit.wikimedia.org/r/201055 (https://phabricator.wikimedia.org/T85113) (owner: 10CSteipp) [22:43:30] (03CR) 10CSteipp: [V: 032] SECURITY: Sanitize the content of Lua backtraces [extensions/Scribunto] (REL1_23) - 10https://gerrit.wikimedia.org/r/201056 (https://phabricator.wikimedia.org/T85113) (owner: 10CSteipp) [22:44:02] 10MediaWiki-extensions-Scribunto, 6Security, 5Patch-For-Review, 7Vuln-XSS: Function names aren't sanitized in Lua error backtraces - https://phabricator.wikimedia.org/T85113#1168672 (10csteipp) >>! In T85113#1168651, @Kghbln wrote: > Admittedly I am a bit confused here. The patches date from December 22, 2... [22:44:31] (03PS1) 10CSteipp: SECURITY: Add an edit token to Special:CheckUser [extensions/CheckUser] (REL1_23) - 10https://gerrit.wikimedia.org/r/201057 (https://phabricator.wikimedia.org/T85858) [22:45:07] (03PS1) 10CSteipp: SECURITY: Add an edit token to Special:CheckUser [extensions/CheckUser] (REL1_24) - 10https://gerrit.wikimedia.org/r/201058 (https://phabricator.wikimedia.org/T85858) [22:45:13] 6Phabricator, 6Mobile-Web, 6Project-Creators: MobileFrontend needs a generic component - https://phabricator.wikimedia.org/T91373#1168681 (10Aklapper) [22:45:18] 7Design, 6Collaboration-Team: When the user opens the Notifications Messages panel, reset the number in the red bubble, but keep the read/unread state as is. Includes a "new" symbol for new unread notifications. - https://phabricator.wikimedia.org/T94634#1168686 (10DannyH) 3NEW [22:45:19] 10Programs-Evaluation: Read-throughs - https://phabricator.wikimedia.org/T94582#1168694 (10Abit) [22:45:47] (03CR) 10CSteipp: [C: 032] SECURITY: Add an edit token to Special:CheckUser [extensions/CheckUser] (REL1_24) - 10https://gerrit.wikimedia.org/r/201058 (https://phabricator.wikimedia.org/T85858) (owner: 10CSteipp) [22:46:57] (03CR) 10CSteipp: [V: 032] SECURITY: Add an edit token to Special:CheckUser [extensions/CheckUser] (REL1_24) - 10https://gerrit.wikimedia.org/r/201058 (https://phabricator.wikimedia.org/T85858) (owner: 10CSteipp) [22:47:32] (03CR) 10CSteipp: SECURITY: Add an edit token to Special:CheckUser (031 comment) [extensions/CheckUser] (REL1_24) - 10https://gerrit.wikimedia.org/r/201058 (https://phabricator.wikimedia.org/T85858) (owner: 10CSteipp) [22:49:28] (03PS1) 10Aaron Schulz: Some cleanups to handleException [core] - 10https://gerrit.wikimedia.org/r/201059 [22:50:42] (03PS1) 10CSteipp: Whitespace fix for en.json [extensions/CheckUser] (REL1_24) - 10https://gerrit.wikimedia.org/r/201060 [22:51:03] (03CR) 10CSteipp: [C: 032 V: 032] Whitespace fix for en.json [extensions/CheckUser] (REL1_24) - 10https://gerrit.wikimedia.org/r/201060 (owner: 10CSteipp) [22:51:20] 10MediaWiki-API, 6MediaWiki-API-Team, 10MediaWiki-User-login-and-signup, 6CA-team, and 2 others: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1168697 (10Dbrant) I have a patch that implements assert=user, but it's still only theoretical, since I can't repro... [22:52:40] (03PS2) 10CSteipp: SECURITY: Add an edit token to Special:CheckUser [extensions/CheckUser] (REL1_23) - 10https://gerrit.wikimedia.org/r/201057 (https://phabricator.wikimedia.org/T85858) [22:52:55] 10MediaWiki-API, 6MediaWiki-API-Team, 10MediaWiki-User-login-and-signup, 6CA-team, and 2 others: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1168700 (10bearND) I think an important step is missing: 5. Wait for x hours/days. Not sure how long, but it'll tak... [22:53:06] 4(no projects): A request to control the height of images (especially for wikibooks) - https://phabricator.wikimedia.org/T94635#1168701 (10Ellywa) 3NEW [22:53:15] (03CR) 10CSteipp: [C: 032 V: 032] SECURITY: Add an edit token to Special:CheckUser [extensions/CheckUser] (REL1_23) - 10https://gerrit.wikimedia.org/r/201057 (https://phabricator.wikimedia.org/T85858) (owner: 10CSteipp) [22:53:58] 10WMF-Product-Strategy: Publish WMF Quarterly Report for Jan-Mar 2015 - https://phabricator.wikimedia.org/T94636#1168720 (10Tbayer) 3NEW a:3Tbayer [22:54:12] (03CR) 10Mattflaschen: [C: 04-1] "Per previous. We need to decide whether and when to do this product-wise before resolving the details with the patch." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/198538 (https://phabricator.wikimedia.org/T59790) (owner: 10Amire80) [22:54:43] 10MediaWiki-API, 6MediaWiki-API-Team, 10MediaWiki-User-login-and-signup, 6CA-team, and 2 others: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1168731 (10bearND) Never mind. Got your updates after I wrote my comment. [22:55:38] MaxSem: ah, my mistake. i thought that was intentional [22:55:58] nope, I don't even know what that is:) [22:56:15] me neither :) [22:56:45] (03PS1) 10Jforrester: Bump VisualEditor for Idc8dd653 [core] (wmf/1.25wmf23) - 10https://gerrit.wikimedia.org/r/201061 [22:57:42] (03PS21) 10EBernhardson: Editor switcher [extensions/Flow] - 10https://gerrit.wikimedia.org/r/197817 (https://phabricator.wikimedia.org/T90763) [23:02:24] (03PS22) 10EBernhardson: Editor switcher [extensions/Flow] - 10https://gerrit.wikimedia.org/r/197817 (https://phabricator.wikimedia.org/T90763) [23:03:47] (03CR) 10EBernhardson: "All comments addressed in PS21 and 22." (0318 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/197817 (https://phabricator.wikimedia.org/T90763) (owner: 10EBernhardson) [23:04:26] 3Editing Department 2014/15 Q4 blockers: How many active editors are using VisualEditor at large Wikipedias? - https://phabricator.wikimedia.org/T94637#1168750 (10Whatamidoing-WMF) 3NEW [23:04:45] 6Community-Liaison, 3Editing Department 2014/15 Q4 blockers: How many active editors are using VisualEditor at large Wikipedias? - https://phabricator.wikimedia.org/T94637#1168758 (10Whatamidoing-WMF) [23:10:22] (03CR) 10Catrope: [C: 032] Bump VisualEditor for Idc8dd653 [core] (wmf/1.25wmf23) - 10https://gerrit.wikimedia.org/r/201061 (owner: 10Jforrester) [23:13:59] 3Fundraising Sprint H, 10Fundraising-Backlog, 3Fundraising Sprint Grandmaster Flash: BUG: Catalan donate flow is not retaining language data - https://phabricator.wikimedia.org/T94506#1168765 (10awight) The problem is in DonationInterface's GlobalCollect module. We're normalizing the language down to what t... [23:15:23] (03PS23) 10EBernhardson: Editor switcher [extensions/Flow] - 10https://gerrit.wikimedia.org/r/197817 (https://phabricator.wikimedia.org/T90763) [23:16:01] (03CR) 10Tim Landscheidt: "TL&DR: There are a number of on-wiki gadgets/user JavaScript that have custom code to leave messages on other users' talk pages. Does thi" [core] - 10https://gerrit.wikimedia.org/r/200801 (https://phabricator.wikimedia.org/T91805) (owner: 10Mattflaschen) [23:16:56] 10MediaWiki-Vagrant, 10Wikimedia-Fundraising, 3Fundraising Sprint Grandmaster Flash, 5Patch-For-Review: Vagrant Fundraising role needs to be able to run a specific MediaWiki branch - https://phabricator.wikimedia.org/T78739#1168771 (10mmodell) awight: additional port forwarding isn't needed - you simply m... [23:24:49] (03CR) 10Catrope: [C: 032] Update ImageMetrics submodule [core] (wmf/1.25wmf23) - 10https://gerrit.wikimedia.org/r/200902 (owner: 10Gergő Tisza) [23:25:22] (03PS3) 10Cscott: Alphabetize resource modules [extensions/Collection] - 10https://gerrit.wikimedia.org/r/200998 [23:25:24] (03PS16) 10Cscott: WIP: T94005: Clean up JS and change action=ajax stuff into API modules [extensions/Collection] - 10https://gerrit.wikimedia.org/r/183228 (owner: 10Alex Monk) [23:25:26] (03PS1) 10Cscott: Javascript whitespace and code style cleanup [extensions/Collection] - 10https://gerrit.wikimedia.org/r/201066 [23:28:01] (03Merged) 10jenkins-bot: Bump VisualEditor for Idc8dd653 [core] (wmf/1.25wmf23) - 10https://gerrit.wikimedia.org/r/201061 (owner: 10Jforrester) [23:29:16] (03CR) 10Mattflaschen: Editor switcher (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/197817 (https://phabricator.wikimedia.org/T90763) (owner: 10EBernhardson) [23:30:17] (03PS2) 10Aaron Schulz: Some cleanups to MWExceptionHandler::handleException [core] - 10https://gerrit.wikimedia.org/r/201059 [23:31:40] 10Wikimedia-Wikimania-Scholarships: Cannot filter Phase 2 export list - https://phabricator.wikimedia.org/T94373#1168785 (10bd808) Hideous SQL: ``` SELECT s.id, s.fname, s.lname, s.email, s.residence, s.exclude, s.gender, YEAR(NOW()) - YEAR(s.dob) AS age, c.country_name, COALESCE(p1score, 0) AS... [23:31:57] thanks RoanKattouw :) [23:33:40] (03CR) 10EBernhardson: "This looks safe to merge now? This is the last one blocking flow's search work, it would be great if we can get search into our next spri" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/183533 (owner: 10Matthias Mullie) [23:33:42] (03Abandoned) 10Aaron Schulz: Re-populate shared cache after saving settings [core] - 10https://gerrit.wikimedia.org/r/198760 (https://phabricator.wikimedia.org/T92232) (owner: 10Nikerabbit) [23:34:47] ^demon|away: it looks like matthias's last cirrussearch patch was almost ready to merge, based on your last comment. If you get a chance this week can you review again? [23:35:18] <^demon|away> Ah gah yes. [23:35:21] <^demon|away> There was 1 more! [23:37:32] <^demon|away> ebernhardson: Yes, it's probably fine with tests now :) [23:37:55] ^demon|away: thanks, awsome [23:39:27] * ^demon|away will have his afternoon coffee and then confirm [23:39:30] (03PS3) 10Ori.livneh: Added slave/master fallback logic in Revision [core] - 10https://gerrit.wikimedia.org/r/200810 (https://phabricator.wikimedia.org/T93866) (owner: 10Aaron Schulz) [23:39:42] (03CR) 10Ori.livneh: [C: 032] Added slave/master fallback logic in Revision [core] - 10https://gerrit.wikimedia.org/r/200810 (https://phabricator.wikimedia.org/T93866) (owner: 10Aaron Schulz) [23:40:20] (03PS2) 10Ori.livneh: Set $wgDBservers to reveal some slag lag issues in testing [vagrant] - 10https://gerrit.wikimedia.org/r/200813 (owner: 10Aaron Schulz) [23:40:26] (03CR) 10Ori.livneh: [C: 032] Set $wgDBservers to reveal some slag lag issues in testing [vagrant] - 10https://gerrit.wikimedia.org/r/200813 (owner: 10Aaron Schulz) [23:40:30] (03PS1) 10Catrope: Update Gather for cherry-pick [core] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/201068 [23:40:39] (03CR) 10Catrope: [C: 032] Update Gather for cherry-pick [core] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/201068 (owner: 10Catrope) [23:41:38] (03Merged) 10jenkins-bot: Update ImageMetrics submodule [core] (wmf/1.25wmf23) - 10https://gerrit.wikimedia.org/r/200902 (owner: 10Gergő Tisza) [23:42:30] (03PS1) 10Catrope: Update Gather for cherry-pick [core] (wmf/1.25wmf23) - 10https://gerrit.wikimedia.org/r/201069 [23:42:44] (03CR) 10Catrope: [C: 032] Update Gather for cherry-pick [core] (wmf/1.25wmf23) - 10https://gerrit.wikimedia.org/r/201069 (owner: 10Catrope) [23:43:12] (03CR) 10BryanDavis: [C: 04-1] "Moving 100% of the reporting logic into a twig template is not a great idea. I know why you did it but I think you can do better." [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/198233 (https://phabricator.wikimedia.org/T93251) (owner: 10Niharika29) [23:44:46] 10SUL-Finalization: GlobalRename tool is corrupting CheckUser data - https://phabricator.wikimedia.org/T94516#1168789 (10csteipp) p:5Triage>3High In talking with James about this, it's something we should fix soonish to keep CU's happy. Feel free to drop to normal priority if there's a big backlog at the mom... [23:45:43] (03PS1) 10BryanDavis: Improve performance of phase2 report query [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/201070 (https://phabricator.wikimedia.org/T94373) [23:49:11] (03PS3) 10Ori.livneh: Made InfoAction::invalidateCache() use READ_LATEST [core] - 10https://gerrit.wikimedia.org/r/200779 (owner: 10Aaron Schulz) [23:50:03] (03CR) 10Ori.livneh: [C: 032] Made InfoAction::invalidateCache() use READ_LATEST [core] - 10https://gerrit.wikimedia.org/r/200779 (owner: 10Aaron Schulz) [23:52:53] (03Merged) 10jenkins-bot: Set $wgDBservers to reveal some slag lag issues in testing [vagrant] - 10https://gerrit.wikimedia.org/r/200813 (owner: 10Aaron Schulz) [23:56:49] 10SUL-Finalization: GlobalRename tool is corrupting CheckUser data - https://phabricator.wikimedia.org/T94516#1168818 (10Legoktm) We can probably use scoped sessions to handle this... [23:58:05] 4(no projects): Jobs in the jobqueue should have their context's IP address set to the initiating request's IP by default - https://phabricator.wikimedia.org/T94639#1168819 (10csteipp) 3NEW [23:58:07] 7HTTPS: Opportunistic Encryption - https://phabricator.wikimedia.org/T94640#1168825 (10CesarB) 3NEW [23:59:16] (03CR) 10Kaldari: [C: 04-1] Add Tatar LanguageConverter (031 comment) [core] - 10https://gerrit.wikimedia.org/r/164049 (owner: 10Qdinar) [23:59:36] (03Abandoned) 10Kaldari: Adding LanguageConverter files for Tatar Language [core] - 10https://gerrit.wikimedia.org/r/185090 (https://phabricator.wikimedia.org/T27537) (owner: 10Kaldari) [23:59:53] 10SUL-Finalization: GlobalRename tool should not list IP address of the user performing renames as 127.0.0.1 - https://phabricator.wikimedia.org/T94516#1168833 (10Deskana)