[00:01:03] (03PS6) 10Tim Starling: In namespaceDupes.php, fix link tables [core] - 10https://gerrit.wikimedia.org/r/190416 [00:01:38] (03CR) 10Tim Starling: "Thanks for the review, especially for spotting the rd_interwiki thing. I assumed that field was nullable for an actual reason instead of j" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/190416 (owner: 10Tim Starling) [00:05:43] (03CR) 10jenkins-bot: [V: 04-1] In namespaceDupes.php, fix link tables [core] - 10https://gerrit.wikimedia.org/r/190416 (owner: 10Tim Starling) [00:17:33] 10MediaWiki-extensions-Cargo, 5Patch-For-Review: Special:Drilldown in Cargo should display a text input, not a message, for a large number of filters - https://phabricator.wikimedia.org/T91092#1099416 (10Yaron_Koren) @polybuildr - it looks like you've discovered a bug in Cargo - Special:Drilldown breaks when a... [00:22:58] (03PS3) 10Tim Starling: Add RateLimit check for false CAPTCHAs [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/182551 (https://phabricator.wikimedia.org/T48292) (owner: 10Florianschmidtwelzow) [00:23:05] (03CR) 10Tim Starling: [C: 032] Add RateLimit check for false CAPTCHAs [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/182551 (https://phabricator.wikimedia.org/T48292) (owner: 10Florianschmidtwelzow) [00:24:14] (03CR) 10jenkins-bot: [V: 04-1] Add RateLimit check for false CAPTCHAs [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/182551 (https://phabricator.wikimedia.org/T48292) (owner: 10Florianschmidtwelzow) [00:28:26] (03CR) 10Tim Starling: "Did you test it?" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/179838 (owner: 10Florianschmidtwelzow) [00:29:37] (03CR) 10Tim Starling: "Looks fine otherwise, just needs testing or a statement that testing was done." [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/179838 (owner: 10Florianschmidtwelzow) [00:44:45] (03PS1) 10BryanDavis: Fix errors and warnings from PHP_CodeSniffer [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/195189 [00:45:15] (03PS1) 10BryanDavis: Add "composer test" command to lint, check style and run tests [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/195190 [00:53:41] (03PS2) 10BryanDavis: Insert new proposals against the currently active campaign [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/195039 (https://phabricator.wikimedia.org/T90605) (owner: 10Niharika29) [00:53:48] (03CR) 10BryanDavis: [C: 032] Insert new proposals against the currently active campaign [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/195039 (https://phabricator.wikimedia.org/T90605) (owner: 10Niharika29) [00:53:50] (03Merged) 10jenkins-bot: Insert new proposals against the currently active campaign [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/195039 (https://phabricator.wikimedia.org/T90605) (owner: 10Niharika29) [01:22:20] (03PS1) 10Gnosygnu: v2.3.2.1 [xowa] - 10https://gerrit.wikimedia.org/r/195191 [01:23:14] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own changes for v2.3.2.1" [xowa] - 10https://gerrit.wikimedia.org/r/195191 (owner: 10Gnosygnu) [01:26:51] (03PS4) 10Phoenix303: Separate message for Summary field with 4 tildes [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/182757 (https://phabricator.wikimedia.org/T45496) [01:29:13] (03CR) 10Phoenix303: "Nemo bis: Not a problem :)" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/182757 (https://phabricator.wikimedia.org/T45496) (owner: 10Phoenix303) [01:36:26] (03PS1) 10BryanDavis: Remove UI references to IEG [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/195193 (https://phabricator.wikimedia.org/T89731) [01:36:28] (03PS1) 10BryanDavis: Rename application "Wikimedia Grants Review" [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/195194 (https://phabricator.wikimedia.org/T89731) [01:36:44] 10Wikimedia-IEG-grant-review, 5Patch-For-Review: Update wording of tool to be more general ("Grants" instead of "IEG") - https://phabricator.wikimedia.org/T89731#1099428 (10bd808) a:3bd808 [01:52:07] (03CR) 10Alex Monk: [C: 04-1] "phpcs (non-voting) does complain about some line length issues in the new file. docs issues in-line." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/193826 (https://phabricator.wikimedia.org/T89066) (owner: 10Mobrovac) [01:57:23] 10Wikimedia-Site-requests: Please restrict anonymous users from creating new pages at sw.wikipedia - https://phabricator.wikimedia.org/T44894#1099433 (10Jalexander) [01:58:22] 10Wikimedia-Site-requests: Please restrict anonymous users from creating new pages at sw.wikipedia - https://phabricator.wikimedia.org/T44894#1099435 (10Jalexander) 5declined>3Open [01:58:43] (03CR) 10Alex Monk: "Other than that, +1" [core] - 10https://gerrit.wikimedia.org/r/193826 (https://phabricator.wikimedia.org/T89066) (owner: 10Mobrovac) [01:59:58] (03PS1) 10Isarra: Add support for HD versions of the wiki logo in MonoBook-like skins. [core] - 10https://gerrit.wikimedia.org/r/195195 [02:01:02] 10Wikimedia-Site-requests: Please restrict anonymous users from creating new pages at sw.wikipedia - https://phabricator.wikimedia.org/T44894#1099438 (10Jalexander) I was approached a couple months ago about this again (By Asaf who was approached by members of the swWiki community). They still want it and [[ htt... [02:04:44] (03CR) 10jenkins-bot: [V: 04-1] Add support for HD versions of the wiki logo in MonoBook-like skins. [core] - 10https://gerrit.wikimedia.org/r/195195 (owner: 10Isarra) [02:11:39] 10Wikimedia-Site-requests, 5Patch-For-Review: Please restrict anonymous users from creating new pages at sw.wikipedia - https://phabricator.wikimedia.org/T44894#1099443 (10Jalexander) For the record the patch I submitted does not disable talk page creation to allow IPs to leave comments about articles etc. [02:24:01] anyone from the flow team around? [02:27:14] 10Wikimedia-Site-requests, 5Patch-For-Review: Please restrict anonymous users from creating new pages at sw.wikipedia - https://phabricator.wikimedia.org/T44894#1099451 (10Jorm) Do you mean "disable anonymous mainspace creation" or "disable anonymous page creation (talk + main)", or what the original request w... [02:27:17] (03PS1) 10BryanDavis: Display campaign status [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/195198 [02:30:47] apparently all premerge tests are broken due to a merged test failure in Flow [02:32:12] 10Wikimedia-Site-requests, 5Patch-For-Review: Please restrict anonymous users from creating new pages at sw.wikipedia - https://phabricator.wikimedia.org/T44894#1099454 (10Jalexander) >>! In T44894#1099451, @Jorm wrote: > Do you mean "disable anonymous mainspace creation" or "disable anonymous page creation (t... [02:32:39] 10Phabricator-Upstream: The screen “Change Details” cuts the line in the middle of a word - https://phabricator.wikimedia.org/T91929#1099455 (10Aklapper) p:5Triage>3Lowest [02:36:54] 6Phabricator: The advanced search fails to find my tasks and its form fails to find me in some fields - https://phabricator.wikimedia.org/T91945#1099457 (10Aklapper) 5Open>3stalled Cannot reproduce the problem in Firefox 36 on Fedora 21. I get your tasks listed in https://phabricator.wikimedia.org/search/que... [02:36:56] 10Wikimedia-Site-requests, 3HTTPS-by-default, 5Patch-For-Review: Russian Wiktionary forces HTTPS even while logged out, regardless of my preferences - https://phabricator.wikimedia.org/T91352#1099459 (10KPu3uC_B_Poccuu) Okay, tell me, do you still consider this is not a bug and why the title is still mislead... [02:37:33] 6Phabricator, 6Engineering-Community: Enable slowvote application - https://phabricator.wikimedia.org/T89906#1099460 (10Aklapper) p:5Triage>3Low [02:38:47] 6Phabricator: Measure how Phabricator search is used - https://phabricator.wikimedia.org/T88863#1099461 (10Aklapper) p:5Triage>3Low I'd be also curious about this but I have no idea if anyone plans to commit time... [02:55:41] (03PS1) 10Yaron Koren: Fixed Special:Drilldown when there's more than one list field [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/195199 [02:58:28] 10MediaWiki-extensions-MultimediaViewer, 6Multimedia: Right clicking on an image in the MediaViewer causes a dialogue to pop up as well as the right click dialogue - https://phabricator.wikimedia.org/T91950#1099463 (10Deskana) 3NEW [03:02:10] (03CR) 10Yaron Koren: [C: 032 V: 032] Fixed Special:Drilldown when there's more than one list field [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/195199 (owner: 10Yaron Koren) [03:29:03] (03PS2) 10Isarra: Add support for HD versions of the wiki logo in MonoBook-like skins. [core] - 10https://gerrit.wikimedia.org/r/195195 [03:33:40] (03CR) 10jenkins-bot: [V: 04-1] Add support for HD versions of the wiki logo in MonoBook-like skins. [core] - 10https://gerrit.wikimedia.org/r/195195 (owner: 10Isarra) [03:59:18] 10MediaWiki-Parser, 7HHVM: Parser::doBlockLevels performs poorly under HHVM - https://phabricator.wikimedia.org/T74205#1099492 (10tstarling) 5Open>3Resolved This was fixed by implementing an LRU cache for compiled PCRE patterns in HHVM. [04:01:47] 6MediaWiki-Core-Team, 10MediaWiki-User-blocking, 7Performance: ipb_range_start and ipb_range_end should be blank for single-IP blocks - https://phabricator.wikimedia.org/T51504#1099494 (10tstarling) a:5tstarling>3None [04:07:44] (03PS2) 10Mattflaschen: Validate input as hex string [extensions/Flow] - 10https://gerrit.wikimedia.org/r/194566 (https://phabricator.wikimedia.org/T91647) (owner: 10EBernhardson) [04:09:30] (03CR) 10Mattflaschen: [C: 032] "Commit message was out of date. Fixed now." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/194566 (https://phabricator.wikimedia.org/T91647) (owner: 10EBernhardson) [04:10:20] (03Merged) 10jenkins-bot: Validate input as hex string [extensions/Flow] - 10https://gerrit.wikimedia.org/r/194566 (https://phabricator.wikimedia.org/T91647) (owner: 10EBernhardson) [04:39:29] 10MediaWiki-extensions-ContentTranslation, 3LE-Sprint-83, 5Patch-For-Review: Show warnings on the new translation dialog when an article already exists (regression) - https://phabricator.wikimedia.org/T91629#1099505 (10santhosh) a:3santhosh [04:41:54] 10Wikimedia-IEG-grant-review: Add a new form method to expect array - https://phabricator.wikimedia.org/T90387#1099507 (10bd808) a:3bd808 [04:42:22] (03PS1) 10BryanDavis: Add require and array methods to Form [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/195204 (https://phabricator.wikimedia.org/T90387) [04:59:24] (03PS1) 10BryanDavis: Use Form array methods in Campaign validation [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/195208 (https://phabricator.wikimedia.org/T90387) [05:11:32] 10Wikimedia-Site-requests, 5Patch-For-Review: Add Draft namespace on zhwiki - https://phabricator.wikimedia.org/T91223#1099514 (10Liuxinyu970226) >>! In T91223#1099125, @Glaisher wrote: > Why does zhwiki use English names for namespaces instead of localized ones? Same question was asked by @tomasz at T61077,... [05:19:35] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/182551 (https://phabricator.wikimedia.org/T48292) (owner: 10Florianschmidtwelzow) [05:29:04] 10MediaWiki-extensions-Collection, 7I18n: Rectangle shape appears whenever a word splits for another line in generated pdf - https://phabricator.wikimedia.org/T91657#1099520 (10Praveenp) From our google+ and mailing list discussions and other follow ups: Hyphen doesn't use as a connector as used here. However... [05:53:32] 6MediaWiki-Core-Team: CSS validator survey and design work - https://phabricator.wikimedia.org/T989#1099526 (10tstarling) I reviewed HTML Purifier, which uses [[http://csstidy.sourceforge.net/|CSSTidy]] for its CSS tokenizer. * CSSTidy's style is quite dated, it seems to be written for PHP 4. It has hardly been... [06:18:21] (03CR) 10Mattflaschen: [C: 04-1] "I reviewed it in detail again, so please refrain from changing things that are not mentioned in the comments." (038 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [06:22:58] (03CR) 10Mattflaschen: "Neither of my comments from Feb 13 have been answered." [core] - 10https://gerrit.wikimedia.org/r/183903 (owner: 10Paladox) [06:44:19] 10MediaWiki-Interface, 10UI-Standardization, 6WMF-Design: toaster overlay for watchlisting is inconsistent between mobile and desktop - https://phabricator.wikimedia.org/T67983#1099532 (10Jaredzimmerman-WMF) [06:59:27] 10MediaWiki-extensions-UniversalLanguageSelector, 6Project-Creators: Create a Phabricator project for ULS compact links to supersede T66793 - https://phabricator.wikimedia.org/T86536#1099536 (10Arrbee) @Aklapper is the information ok for the project to be created? Thanks. [07:10:14] 10Wikimedia-Site-requests, 5Patch-For-Review: Add Draft namespace on zhwiki - https://phabricator.wikimedia.org/T91223#1099541 (10Liuxinyu970226) But IMO, as only one translation "草稿" avaliable and can be blended between hans & hant, I feel still using English name is coy. [07:21:41] 10Wikimedia-Site-requests, 5Patch-For-Review: Add Draft namespace on zhwiki - https://phabricator.wikimedia.org/T91223#1099548 (10Chiefwei) I think "草稿" is better than English, as we already have "模块" Instead of "Module". [07:38:49] (03PS1) 10Robert Vogel: ExtensionInfo: Fixed group title [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/195217 [08:01:32] 10Wikimania-Hackathon-2015, 10Wikimedia-General-or-Unknown: Allow users to edit via Tor while still being able to fight abuse - https://phabricator.wikimedia.org/T71333#1099577 (10Qgil) [08:04:17] 6MediaWiki-Core-Team, 10Analytics, 10Wikimedia-Site-requests: Ran out of captcha images - https://phabricator.wikimedia.org/T91760#1099579 (10matthiasmullie) 5Open>3Resolved a:3matthiasmullie Seems like someone has already fixed this. Special:UserLogin&type=signup works again and the exception is no lo... [08:06:34] (03PS4) 10Florianschmidtwelzow: Getting rid of some globals [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/179838 [08:07:37] (03CR) 10jenkins-bot: [V: 04-1] Getting rid of some globals [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/179838 (owner: 10Florianschmidtwelzow) [08:10:44] (03CR) 10Florianschmidtwelzow: "PS4 is a Rebase and a fix for some errors." [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/179838 (owner: 10Florianschmidtwelzow) [08:16:23] 10Wikimedia-Site-requests, 5Patch-For-Review: Add Draft namespace on zhwiki - https://phabricator.wikimedia.org/T91223#1099588 (10Wong128hk) 草稿 is fine, because these two words are the same in both traditional and simplified Chinese. The problem of 模块 should be discussed then. [08:20:51] (03PS1) 10Florianschmidtwelzow: Hygiene: Follow up change in ConfirmEdit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/195218 [08:21:27] (03CR) 10Florianschmidtwelzow: "Follow up for Flow: I9b8a0851624d931b8db9063b4fee749f55f45af0" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/179838 (owner: 10Florianschmidtwelzow) [08:21:38] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Follow up change in ConfirmEdit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/195218 (owner: 10Florianschmidtwelzow) [08:31:42] 10MediaWiki-extensions-VoteNY, 10Social-Tools: Support rational & subjective ratings - https://phabricator.wikimedia.org/T91644#1099592 (10Vev) [08:32:38] (03CR) 10Matthias Mullie: [C: 032] Split out a minimal resource set for initializing flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/194145 (owner: 10EBernhardson) [08:33:33] (03Merged) 10jenkins-bot: Split out a minimal resource set for initializing flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/194145 (owner: 10EBernhardson) [08:34:45] (03CR) 10Mobrovac: Introduce the Restbase Virtual REST Service class (032 comments) [core] - 10https://gerrit.wikimedia.org/r/193826 (https://phabricator.wikimedia.org/T89066) (owner: 10Mobrovac) [08:35:18] (03PS7) 10Mobrovac: Introduce the Restbase Virtual REST Service class [core] - 10https://gerrit.wikimedia.org/r/193826 (https://phabricator.wikimedia.org/T89066) [08:39:55] (03CR) 10jenkins-bot: [V: 04-1] Introduce the Restbase Virtual REST Service class [core] - 10https://gerrit.wikimedia.org/r/193826 (https://phabricator.wikimedia.org/T89066) (owner: 10Mobrovac) [08:43:04] 10Wikimedia-Git-or-Gerrit: Remove obvious mistakenly added refs in mediawiki/core repo - https://phabricator.wikimedia.org/T90900#1099606 (10matthiasmullie) [08:43:20] 10Wikimedia-Git-or-Gerrit: Remove obvious mistakenly added refs in mediawiki/core repo - https://phabricator.wikimedia.org/T90900#1099608 (10matthiasmullie) p:5Low>3High [08:44:29] (03CR) 10Gilles: "Might be good to combine it with the commons role, I'm just not familiar with GlobalUsage enough yet to know if it's enough as-is with Ins" [vagrant] - 10https://gerrit.wikimedia.org/r/195082 (owner: 10Gilles) [08:45:57] 10Wikimedia-Git-or-Gerrit: Remove obvious mistakenly added refs in mediawiki/core repo - https://phabricator.wikimedia.org/T90900#1099612 (10matthiasmullie) p:5High>3Low Whoops; I got this ticket mixed up with another; resetting priority. Sorry! [09:00:53] 10MediaWiki-Uploading, 6Multimedia, 10Wikimedia-Site-requests: Allow the upload of .psd .pdn [...] files - https://phabricator.wikimedia.org/T91914#1099629 (10Gilles) My knowledge regarding this might be a little bit stale (2 years old), but last time I wrote support for PSD uploading/thumbnailing using open... [09:04:43] 10MediaWiki-extensions-MultimediaViewer, 6Multimedia: Right clicking on an image in the MediaViewer causes a dialogue to pop up as well as the right click dialogue - https://phabricator.wikimedia.org/T91950#1099632 (10Gilles) This is by design. It's helped greatly increase the amount of people downloading the... [09:04:52] 10MediaWiki-extensions-MultimediaViewer, 6Multimedia: Right clicking on an image in the MediaViewer causes a dialogue to pop up as well as the right click dialogue - https://phabricator.wikimedia.org/T91950#1099634 (10Gilles) 5Open>3Invalid a:3Gilles [09:19:01] (03CR) 10Matthias Mullie: [C: 04-1] Hygiene: Split the giant show function in Flow\View (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/194146 (owner: 10EBernhardson) [09:23:45] (03PS7) 10Matthias Mullie: Hygiene: Split the giant show function in Flow\View [extensions/Flow] - 10https://gerrit.wikimedia.org/r/194146 (owner: 10EBernhardson) [09:23:52] (03CR) 10Gilles: [C: 04-1] "I've gone through the comments and versions, but I don't see Gergo's concern that it doesn't use OOUI popups answered. Maybe it was discus" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/194565 (https://phabricator.wikimedia.org/T89765) (owner: 10MarkTraceur) [09:26:35] (03CR) 10Matthias Mullie: [C: 032] Hygiene: Split the giant show function in Flow\View [extensions/Flow] - 10https://gerrit.wikimedia.org/r/194146 (owner: 10EBernhardson) [09:27:53] (03Merged) 10jenkins-bot: Hygiene: Split the giant show function in Flow\View [extensions/Flow] - 10https://gerrit.wikimedia.org/r/194146 (owner: 10EBernhardson) [09:38:49] 10MediaWiki-Interface, 10MediaWiki-RfCs, 7Design, 7Documentation, and 2 others: Section headings should have some clickable anchor for passing links - https://phabricator.wikimedia.org/T18691#1099665 (10Cwek) Here (https://zh.wikipedia.org/wiki/Wikipedia:%E4%BA%92%E5%8A%A9%E5%AE%A2%E6%A0%88/%E6%8A%80%E6%9C... [09:45:08] 10service-template-node: Service template documentation - https://phabricator.wikimedia.org/T91953#1099670 (10mobrovac) 3NEW a:3mobrovac [09:49:48] 6Wiktionary, 7Tracking: Wiktionnaire / fr.wiktionary bugs (tracking) - https://phabricator.wikimedia.org/T76447#1099678 (10Darkdadaah) [09:50:11] 10MediaWiki-extensions-ContentTranslation, 3LE-Sprint-83, 5Patch-For-Review: Show warnings on the new translation dialog when an article already exists (regression) - https://phabricator.wikimedia.org/T91629#1099680 (10santhosh) [10:13:46] 10Gather: Listing collections in API blows for format=xml - https://phabricator.wikimedia.org/T91494#1099686 (10Jhernandez) 5Open>3Resolved a:3Jhernandez This was solved. [10:17:31] 6Editing, 6Language-Engineering, 10Possible-Tech-Projects, 7I18n: Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T89107#1099697 (10Mdshekh) Hello everyone !! Can you provide the specific bug links for microtask. [10:46:03] 3HTTPS-by-default, 5Patch-For-Review: Do not offer to disable "Always use a secure connection when logged in" when that won't work - https://phabricator.wikimedia.org/T91938#1099742 (10Aklapper) p:5Triage>3Normal [11:19:19] 10MediaWiki-Vagrant: Slow performance of MediaWiki vagrant eating up all CPU allocated to VM - https://phabricator.wikimedia.org/T91956#1099770 (10Rillke) 3NEW [12:21:29] grrrit-wm died. [12:23:37] I guess I brought it back. [12:23:55] (03CR) 10jenkins-bot: [V: 04-1] Upload form: Show or hide form controls dependent on existence of destination [core] - 10https://gerrit.wikimedia.org/r/195230 (https://phabricator.wikimedia.org/T91889) (owner: 10Rillke) [12:23:56] YuviPanda: bigbrother, eh. [12:24:24] Fiona: no, redis was full. I resurrected it. [12:24:27] 15G filled up [12:24:37] Full? [12:25:01] yup [12:25:05] redis can’t hold more data than RAM [12:25:11] and that machine has only 16G of RAM [12:25:13] How did it fill up? [12:25:30] Fiona: not sure. I’m going to investigate that now. I suspect a runaway tool that’s just filling it with crap without a ttl [12:25:48] Wait, there's a shared queue? [12:26:03] ? [12:26:07] redis is shared across all tools [12:26:09] (03CR) 10Matthias Mullie: [C: 032] Split preview into feature file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/194408 (owner: 10EBernhardson) [12:26:13] Interesting. [12:26:32] I guess I'm surprised it doesn't fill up more often, then. [12:26:32] but there’s some precautionary measures in place to prevent one tool from trampling on another's [12:26:59] https://wikitech.wikimedia.org/wiki/Help:Tool_Labs#Security [12:33:49] someone updated a translation and this broke php unit tests? [12:39:41] rillke: looks like we have some test which is as silly as that, yes [12:40:07] (03PS1) 10Rillke: Make PHP unit parser tests pass again after translation update [core] - 10https://gerrit.wikimedia.org/r/195245 [12:46:08] (03CR) 10Nemo bis: "Thanks. This test is getting even more unreliable that the tests... Is its goal just to check that "Naslov" isn't converted to c" [core] - 10https://gerrit.wikimedia.org/r/195245 (owner: 10Rillke) [12:55:38] (03CR) 10Rillke: "With 38abb23f9ff07899803cf3dd37df8cdf2f5fa00c this was touched 4 days ago for a similar reason. Trying to find the original author now." [core] - 10https://gerrit.wikimedia.org/r/195245 (owner: 10Rillke) [13:07:10] (03CR) 10Jdlrobson: "It shouldn't effect all skins- only those when mediawiki.ui.radio styles are loaded via UseMediaWikiUIEverywhere" [core] - 10https://gerrit.wikimedia.org/r/194383 (owner: 10Jdlrobson) [13:07:42] (03CR) 10Jdlrobson: Enable mw-ui-radio styles on Special:Preferences (031 comment) [core] - 10https://gerrit.wikimedia.org/r/194383 (owner: 10Jdlrobson) [13:16:49] (03CR) 10Catrope: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/194437 (https://phabricator.wikimedia.org/T90486) (owner: 10Mattflaschen) [13:19:32] (03CR) 10jenkins-bot: [V: 04-1] Notify the user that their thanks are public [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/194437 (https://phabricator.wikimedia.org/T90486) (owner: 10Mattflaschen) [13:24:30] (03CR) 10MarkTraceur: "@gi11es I was under the impression that our little arrow-dialogs didn't exist in OOUI, but I will look again." [core] - 10https://gerrit.wikimedia.org/r/194565 (https://phabricator.wikimedia.org/T89765) (owner: 10MarkTraceur) [13:24:58] (03CR) 10Florianschmidtwelzow: "@Luis Felipe Schenone: Do you understood what legoktm/I mean? Can I help you with something? :)" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/193529 (owner: 10Luis Felipe Schenone) [13:27:00] (03CR) 10Catrope: "FIXME: caused T91967, breaking merge pipelines for VE and Thanks." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/192608 (https://phabricator.wikimedia.org/T88321) (owner: 10EBernhardson) [13:33:23] superm401: Your entry for this morning's SWAT seems to have already been done on Friday. [13:46:19] (03CR) 10Rillke: "So after a long time of searching, I found https://github.com/wikimedia/mediawiki/commit/5b2a644f2e3ff010d06789167f43d9c37d940269#diff-aaa" [core] - 10https://gerrit.wikimedia.org/r/195245 (owner: 10Rillke) [13:48:00] (03CR) 10Rillke: "Fix for failing unit tests pending review: I7dfc9bcea2be85dd42d344858ce02246432f7fe1" [core] - 10https://gerrit.wikimedia.org/r/195230 (https://phabricator.wikimedia.org/T91889) (owner: 10Rillke) [13:57:51] (03PS6) 10MarkTraceur: [WIP] Add framework for file warnings [core] - 10https://gerrit.wikimedia.org/r/194565 (https://phabricator.wikimedia.org/T89765) [14:02:16] hello i was installing Translate extension through https://www.mediawiki.org/wiki/MediaWiki_Language_Extension_Bundle#Installation, [14:02:26] while i updated the script i got this error: require_once(/var/www/html/core/extensions/cldr/cldr.php): failed to open stream: No such file or directory in /var/www/html/core/LocalSettings.php on line 137 [14:02:36] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add framework for file warnings [core] - 10https://gerrit.wikimedia.org/r/194565 (https://phabricator.wikimedia.org/T89765) (owner: 10MarkTraceur) [14:02:46] is the path correct? [14:03:08] yes i placed it in the mediawiki directory [14:03:18] does the path exist then? [14:03:27] (03PS7) 10MarkTraceur: [WIP] Add framework for file warnings [core] - 10https://gerrit.wikimedia.org/r/194565 (https://phabricator.wikimedia.org/T89765) [14:04:18] sorry i didnt understand the path is the same as in given in the installation page [14:07:13] rits: check whether there is a such file at that path [14:07:48] if not, figure out where did you extract them and/or correct the path in LocalSettings.php [14:08:04] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add framework for file warnings [core] - 10https://gerrit.wikimedia.org/r/194565 (https://phabricator.wikimedia.org/T89765) (owner: 10MarkTraceur) [14:08:46] ok i just check it [14:13:52] (03PS8) 10Catrope: [WIP] Add framework for file warnings [core] - 10https://gerrit.wikimedia.org/r/194565 (https://phabricator.wikimedia.org/T89765) (owner: 10MarkTraceur) [14:17:22] Nikerabbit : the error was due to the wrong path,thank you :) [14:18:47] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add framework for file warnings [core] - 10https://gerrit.wikimedia.org/r/194565 (https://phabricator.wikimedia.org/T89765) (owner: 10MarkTraceur) [14:19:07] (03CR) 10Niharika29: [C: 032] "Works well. Thanks Bryan!" [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/195204 (https://phabricator.wikimedia.org/T90387) (owner: 10BryanDavis) [14:19:10] (03Merged) 10jenkins-bot: Add require and array methods to Form [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/195204 (https://phabricator.wikimedia.org/T90387) (owner: 10BryanDavis) [14:19:15] (03PS9) 10MarkTraceur: [WIP] Add framework for file warnings [core] - 10https://gerrit.wikimedia.org/r/194565 (https://phabricator.wikimedia.org/T89765) [14:21:18] (03CR) 10Matthias Mullie: [C: 04-1] "AFAICT, API doesn't (yet) work & we use no-JS workflow." (0314 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/194047 (owner: 10EBernhardson) [14:23:58] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add framework for file warnings [core] - 10https://gerrit.wikimedia.org/r/194565 (https://phabricator.wikimedia.org/T89765) (owner: 10MarkTraceur) [14:26:55] (03CR) 10Niharika29: Use Form array methods in Campaign validation (031 comment) [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/195208 (https://phabricator.wikimedia.org/T90387) (owner: 10BryanDavis) [14:29:08] (03CR) 10Anomie: Upload form: Show or hide form controls dependent on existence of destination (032 comments) [core] - 10https://gerrit.wikimedia.org/r/195230 (https://phabricator.wikimedia.org/T91889) (owner: 10Rillke) [14:38:12] (03CR) 10Rillke: Upload form: Show or hide form controls dependent on existence of destination (032 comments) [core] - 10https://gerrit.wikimedia.org/r/195230 (https://phabricator.wikimedia.org/T91889) (owner: 10Rillke) [14:42:24] (03CR) 10Anomie: Upload form: Show or hide form controls dependent on existence of destination (032 comments) [core] - 10https://gerrit.wikimedia.org/r/195230 (https://phabricator.wikimedia.org/T91889) (owner: 10Rillke) [14:47:02] hello while restarting the installation through https://www.mediawiki.org/wiki/MediaWiki_Language_Extension_Bundle#Web_browser [14:47:13] ,got this MagicWord.php error [c98406d8] /core/mw-config/?page=ExistingWiki MWException from line 337 of /var/www/html/core/includes/MagicWord.php: Error: invalid magic word 'noexternallanglinks' [14:49:25] (03CR) 10Rillke: Upload form: Show or hide form controls dependent on existence of destination (031 comment) [core] - 10https://gerrit.wikimedia.org/r/195230 (https://phabricator.wikimedia.org/T91889) (owner: 10Rillke) [15:02:02] (03CR) 10Anomie: In namespaceDupes.php, fix link tables (032 comments) [core] - 10https://gerrit.wikimedia.org/r/190416 (owner: 10Tim Starling) [15:07:05] hello i am stuck on this https://www.mediawiki.org/wiki/MediaWiki_Language_Extension_Bundle#Web_browser, as i restart the Mediawiki 1.25 alpha installation it gives the following error /core/mw-config/ MWException from line 337 of /var/www/html/core/includes/MagicWord.php: Error: invalid magic word 'noexternallanglinks' [15:10:02] rits: that's stuff for the automated inclusion of Wikidata interlanguage links [15:10:04] https://www.mediawiki.org/wiki/Extension:Wikibase_Client#noexternallanglinks [15:10:16] I wonder if it's really related to MLEB, not sure [15:14:24] (03CR) 10Anomie: [C: 032] "Let's unbreak stuff now, and you should file a Phab task for the Language folks to make the test more robust." [core] - 10https://gerrit.wikimedia.org/r/195245 (owner: 10Rillke) [15:14:37] (03CR) 10Chad: [C: 032] Update CirrusSearch to 1.25wmf20 [core] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/194726 (owner: 10Jdouglas) [15:15:27] i was restarting the installation for the SemanticMediaWiki extension , i a, unable to understand the error through this https://www.mediawiki.org/wiki/Extension:Wikibase_Client#noexternallanglinks [15:17:41] (03CR) 10BryanDavis: Use Form array methods in Campaign validation (031 comment) [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/195208 (https://phabricator.wikimedia.org/T90387) (owner: 10BryanDavis) [15:17:49] andre__:i was restarting the installation for the SemanticMediaWiki extension , i am unable to understand the error through this https://www.mediawiki.org/wiki/Extension:Wikibase_Client#noexternallanglinks [15:22:05] (03PS27) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 [15:23:18] (03Merged) 10jenkins-bot: Make PHP unit parser tests pass again after translation update [core] - 10https://gerrit.wikimedia.org/r/195245 (owner: 10Rillke) [15:24:58] (03CR) 10Chad: [V: 032] Update CirrusSearch to 1.25wmf20 [core] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/194726 (owner: 10Jdouglas) [15:45:40] (03PS28) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 [15:47:11] (03CR) 10Paladox: "Ok sorry for moving them up and down wont happend again. i have done what use said in the comment." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [15:47:33] (03CR) 10Paladox: "@Mattflaschen please review." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [15:58:24] (03PS2) 10Niharika29: Display campaign status [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/195198 (owner: 10BryanDavis) [16:00:00] (03CR) 10Niharika29: "Fixed a couple of things:" [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/195198 (owner: 10BryanDavis) [16:03:09] (03CR) 10Niharika29: [C: 032] Use Form array methods in Campaign validation (031 comment) [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/195208 (https://phabricator.wikimedia.org/T90387) (owner: 10BryanDavis) [16:03:11] (03Merged) 10jenkins-bot: Use Form array methods in Campaign validation [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/195208 (https://phabricator.wikimedia.org/T90387) (owner: 10BryanDavis) [16:07:55] (03CR) 10Rillke: "Done with T91982." [core] - 10https://gerrit.wikimedia.org/r/195245 (owner: 10Rillke) [16:13:38] (03PS2) 10Pwirth: [WIP] Review: Notifications [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/194328 [16:29:43] (03PS1) 10Jforrester: Revert "Upgrade Pimple to 2.x" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/195291 [16:29:47] (03CR) 10jenkins-bot: [V: 04-1] Revert "Upgrade Pimple to 2.x" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/195291 (owner: 10Jforrester) [16:30:02] (03PS1) 10Anomie: Add SimpleMessageSpecifier [core] - 10https://gerrit.wikimedia.org/r/195292 (https://phabricator.wikimedia.org/T91985) [16:30:04] (03PS1) 10Anomie: Allow constructing a Message from a MessageSpecifier [core] - 10https://gerrit.wikimedia.org/r/195293 (https://phabricator.wikimedia.org/T91986) [16:33:14] (03PS1) 10Matthias Mullie: Quick test [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/195296 [16:33:19] (03PS1) 10Anomie: WIP: AuthManager skeleton [core] - 10https://gerrit.wikimedia.org/r/195297 (https://phabricator.wikimedia.org/T91699) [16:35:13] (03CR) 10jenkins-bot: [V: 04-1] WIP: AuthManager skeleton [core] - 10https://gerrit.wikimedia.org/r/195297 (https://phabricator.wikimedia.org/T91699) (owner: 10Anomie) [16:37:04] (03PS2) 10Matthias Mullie: Quick test [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/195296 [16:38:29] (03CR) 10Matthias Mullie: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/195296 (owner: 10Matthias Mullie) [16:41:26] (03PS3) 10Matthias Mullie: Don't override existing Pimple container thingy, unset it first [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/195296 (https://phabricator.wikimedia.org/T91967) [16:50:38] (03CR) 10Aude: Split SiteLookup interface from SiteStore (0312 comments) [core] - 10https://gerrit.wikimedia.org/r/188965 (https://phabricator.wikimedia.org/T77990) (owner: 10Aude) [16:52:33] (03Abandoned) 10Jforrester: Revert "Upgrade Pimple to 2.x" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/195291 (owner: 10Jforrester) [16:52:44] (03PS3) 10Aude: Split SiteLookup interface from SiteStore [core] - 10https://gerrit.wikimedia.org/r/188965 (https://phabricator.wikimedia.org/T77990) [16:57:33] (03CR) 10jenkins-bot: [V: 04-1] Split SiteLookup interface from SiteStore [core] - 10https://gerrit.wikimedia.org/r/188965 (https://phabricator.wikimedia.org/T77990) (owner: 10Aude) [17:05:10] Hi RoanKattouw! Quick question: is there a standard way for a php-based RL module to know if it's been added to a page as a dependency of a QUnit test? https://github.com/wikimedia/mediawiki-extensions-CentralNotice/blob/d36be33412cb55ec58a1febe528591bac7d17c00/includes/CNBannerChoiceDataResourceLoaderModule.php [17:06:04] or otherwise avoid an error that's not relevant when running qunit? [17:07:24] * rillke thinks it's a horrific idea to code something in a way that it has to check whether it's being part of a unit test or not [17:08:56] (03CR) 10Brion VIBBER: Introducing a new variable $wgAllowExternalSVG (031 comment) [core] - 10https://gerrit.wikimedia.org/r/184337 (https://phabricator.wikimedia.org/T65806) (owner: 10ImPacific) [17:09:09] rillke: well, yes that would be mixing testing code into production stuff. Ideally there would be some setup and teardown hooks available in PHP for qunit tests [17:09:13] * rillke furthermore believes that such a coding style would turn the purposes of unit tests ad absurdum [17:10:11] rillke: in this case the code that would have to detect it is not under test. It's something that should be mocked for the test, really, but I don't see any way to do that since in PHP and the test framework is for JS [17:11:24] Another route would be to add hooks for that in SpecialJavaScriptTest, that would indeed be better [17:11:47] AndyRussG: What is your problem exactly? [17:12:15] RoanKattouw: https://phabricator.wikimedia.org/T91763 [17:12:21] (03PS1) 10Yaron Koren: Fixed Drilldown handling of null dates [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/195302 [17:13:09] AndyRussG: Eww. I have no good recommendations there [17:13:21] (03CR) 10EBernhardson: [C: 04-1] "This just needs to call Flow\Container::reset() to make sure the test starts with a clean slate." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/195296 (https://phabricator.wikimedia.org/T91967) (owner: 10Matthias Mullie) [17:13:25] RoanKattouw: indeed it does get kinda gross, sadly [17:13:28] AndyRussG: Other than, why is $wgCentralDBName not lazy-initialized centrally somewhere? [17:14:47] (03PS4) 10EBernhardson: Don't override existing Pimple container thingy, unset it first [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/195296 (https://phabricator.wikimedia.org/T91967) (owner: 10Matthias Mullie) [17:14:48] RoanKattouw: well, it's not a required config var, rather either that one or $wgCentralNoticeApiUrl should be set, and in prod it makes sense to throw an error if neither one is [17:15:11] (03PS5) 10EBernhardson: Flow container needs to be reset before each test [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/195296 (https://phabricator.wikimedia.org/T91967) (owner: 10Matthias Mullie) [17:15:57] (03CR) 10Yaron Koren: [C: 032 V: 032] Fixed Drilldown handling of null dates [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/195302 (owner: 10Yaron Koren) [17:16:04] In the patch for review (https://gerrit.wikimedia.org/r/#/c/195200/) the PHP test error shows up 2 issues [17:16:42] 1) that ResourceLoaderTestModules isn't only called when JS tests are run, so nothing like PHP-based JS-test setup can go there [17:17:00] and 2) that there are issues in the PHP tests in that they depend on the value of that config var [17:17:23] The second issue I'll deal with separately, first I'm trying to look at a solution to the first one [17:17:35] (03CR) 10jenkins-bot: [V: 04-1] Flow container needs to be reset before each test [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/195296 (https://phabricator.wikimedia.org/T91967) (owner: 10Matthias Mullie) [17:17:41] It may not seem important but it's blocking some stuff [17:18:54] RoanKattouw: what do you think of the solution I suggesed following rillke's observations--some PHP QUnit set up and tear down hooks in core, maybe to be called from SpecialJavaScriptTest? [17:19:47] Hmm [17:19:53] What unit test even depends on that RL module then? [17:21:49] (03PS6) 10EBernhardson: Flow container needs to be reset before each test [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/195296 (https://phabricator.wikimedia.org/T91967) (owner: 10Matthias Mullie) [17:22:03] RoanKattouw: rather that module is a dependency of modules under test [17:22:15] Right [17:23:02] ext.centralNotice.bannerController [17:23:33] So also if in some QUnit setup code I could futz with the dependencies (maybe a bad idea tho?) that might be nice [17:23:38] or at least workable [17:24:27] RoanKattouw: https://github.com/wikimedia/mediawiki-extensions-CentralNotice/blob/d36be33412cb55ec58a1febe528591bac7d17c00/CentralNotice.modules.php#L126 [17:27:02] (03PS7) 10EBernhardson: Flow container needs to be reset before each test [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/195296 (https://phabricator.wikimedia.org/T91967) (owner: 10Matthias Mullie) [17:27:56] RoanKattouw_away: rillke: maybe a simpler option would be just to move the test that's throwing the error elsewhere... [17:30:05] (03PS8) 10ImPacific: Introducing a new variable $wgAllowExternalSVG [core] - 10https://gerrit.wikimedia.org/r/184337 (https://phabricator.wikimedia.org/T65806) [17:30:24] (03CR) 10Krinkle: [C: 04-1] "Needs to update getModifiedHash() as well to ensure cache is updated when the configuration changes." [core] - 10https://gerrit.wikimedia.org/r/195195 (owner: 10Isarra) [17:30:50] (03CR) 10Krinkle: Add support for HD versions of the wiki logo in MonoBook-like skins. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/195195 (owner: 10Isarra) [17:31:02] (03CR) 10Jforrester: [C: 031] "Should we merge this pronto?" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/195296 (https://phabricator.wikimedia.org/T91967) (owner: 10Matthias Mullie) [17:32:24] (03CR) 10Aude: Split SiteLookup interface from SiteStore (031 comment) [core] - 10https://gerrit.wikimedia.org/r/188965 (https://phabricator.wikimedia.org/T77990) (owner: 10Aude) [17:34:50] (03CR) 10ImPacific: Introducing a new variable $wgAllowExternalSVG (031 comment) [core] - 10https://gerrit.wikimedia.org/r/184337 (https://phabricator.wikimedia.org/T65806) (owner: 10ImPacific) [17:49:04] (03CR) 10Parent5446: [C: 031] Allow constructing a Message from a MessageSpecifier [core] - 10https://gerrit.wikimedia.org/r/195293 (https://phabricator.wikimedia.org/T91986) (owner: 10Anomie) [17:49:56] (03CR) 10Parent5446: [C: 04-1] "I know it's a small class, but every class should be in its own file." [core] - 10https://gerrit.wikimedia.org/r/195292 (https://phabricator.wikimedia.org/T91985) (owner: 10Anomie) [17:53:40] (03CR) 10Mattflaschen: [C: 032] "Looks good. I believe this is also now picking up container-test.php from Flow." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/195296 (https://phabricator.wikimedia.org/T91967) (owner: 10Matthias Mullie) [17:56:37] (03Merged) 10jenkins-bot: Flow container needs to be reset before each test [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/195296 (https://phabricator.wikimedia.org/T91967) (owner: 10Matthias Mullie) [17:57:08] (03PS2) 10Anomie: WIP: AuthManager skeleton [core] - 10https://gerrit.wikimedia.org/r/195297 (https://phabricator.wikimedia.org/T91699) [17:58:44] (03CR) 10BryanDavis: [C: 031] Display campaign status [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/195198 (owner: 10BryanDavis) [17:59:12] (03CR) 10Anomie: "On the other hand, that would mean that someone wanting the whole "MessageSpecifier" feature needs to know to take both files. I'm willing" [core] - 10https://gerrit.wikimedia.org/r/195292 (https://phabricator.wikimedia.org/T91985) (owner: 10Anomie) [18:00:34] (03CR) 10Mattflaschen: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/194437 (https://phabricator.wikimedia.org/T90486) (owner: 10Mattflaschen) [18:09:33] (03CR) 10Krinkle: "The script did not do a copy, only a symlink. For local developers, they can just use the new entry point instead. For Jenkins, the test p" [core] - 10https://gerrit.wikimedia.org/r/195098 (owner: 10Krinkle) [18:09:36] (03CR) 10Niharika29: [C: 032] Display campaign status [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/195198 (owner: 10BryanDavis) [18:09:40] (03CR) 10Krinkle: "recheck" [core] - 10https://gerrit.wikimedia.org/r/195098 (owner: 10Krinkle) [18:09:42] (03Merged) 10jenkins-bot: Display campaign status [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/195198 (owner: 10BryanDavis) [18:10:02] (03PS4) 10Krinkle: Rename JSDuck config to standard 'jsduck' [core] - 10https://gerrit.wikimedia.org/r/195098 [18:10:09] (03PS3) 10Krinkle: jsduck: Refactor example iframe to catch uncaught errors [core] - 10https://gerrit.wikimedia.org/r/195099 [18:12:59] (03PS4) 10Jdouglas: Factor out insource fallthrough [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/194950 [18:18:48] (03CR) 10Legoktm: Allow constructing a Message from a MessageSpecifier (031 comment) [core] - 10https://gerrit.wikimedia.org/r/195293 (https://phabricator.wikimedia.org/T91986) (owner: 10Anomie) [18:19:37] (03CR) 10Legoktm: "They could both be in their own subdirectory?" [core] - 10https://gerrit.wikimedia.org/r/195292 (https://phabricator.wikimedia.org/T91985) (owner: 10Anomie) [18:25:45] (03PS3) 10Isarra: Add support for HD versions of the wiki logo in MonoBook-like skins. [core] - 10https://gerrit.wikimedia.org/r/195195 (https://phabricator.wikimedia.org/T37337) [18:27:57] brion: hi... made the changes https://gerrit.wikimedia.org/r/#/c/184337/8 can you please review it? [18:28:13] impacific: great! moment... [18:29:01] (03CR) 10Brion VIBBER: [C: 031] "*poking to run tests*" [core] - 10https://gerrit.wikimedia.org/r/184337 (https://phabricator.wikimedia.org/T65806) (owner: 10ImPacific) [18:32:28] (03CR) 10Jforrester: [C: 032] Rename JSDuck config to standard 'jsduck' [core] - 10https://gerrit.wikimedia.org/r/195098 (owner: 10Krinkle) [18:33:46] (03PS1) 10EBernhardson: Store parsoid content exactly as recieved [extensions/Flow] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195326 (https://phabricator.wikimedia.org/T90461) [18:33:56] (03PS1) 10EBernhardson: Store parsoid content exactly as recieved [extensions/Flow] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/195327 (https://phabricator.wikimedia.org/T90461) [18:34:54] (03CR) 10Aaron Schulz: [C: 032 V: 032] Added clarifying comments to IContextSource [core] - 10https://gerrit.wikimedia.org/r/195068 (owner: 10Aaron Schulz) [18:35:25] (03PS4) 10Aaron Schulz: Clean up $wgSQLiteDataDir handling and removed standalone sqlite class [core] - 10https://gerrit.wikimedia.org/r/195033 [18:37:08] (03CR) 10Ori.livneh: [WIP] Split out chron tasks from job spawner as another daemon (038 comments) [services/jobrunner] - 10https://gerrit.wikimedia.org/r/192207 (owner: 10Aaron Schulz) [18:39:20] (03CR) 10Brion VIBBER: "Hrm, thought I'd had that seeking issue fixed. I'll take another pass at it tonight..." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165478 (https://phabricator.wikimedia.org/T63823) (owner: 10Brion VIBBER) [18:42:15] (03Merged) 10jenkins-bot: Rename JSDuck config to standard 'jsduck' [core] - 10https://gerrit.wikimedia.org/r/195098 (owner: 10Krinkle) [18:43:03] (03CR) 10Brion VIBBER: "Looks workable, though it's a bit awkward (will test shortly). One alternative I was thinking was making an alternate logo option that re" [core] - 10https://gerrit.wikimedia.org/r/195195 (https://phabricator.wikimedia.org/T37337) (owner: 10Isarra) [18:44:16] (03Merged) 10jenkins-bot: Added clarifying comments to IContextSource [core] - 10https://gerrit.wikimedia.org/r/195068 (owner: 10Aaron Schulz) [18:45:58] (03CR) 10Aude: "fixed the tests, but not patient enough for gerrit's horribly slow (at the moment) patch upload speed." [core] - 10https://gerrit.wikimedia.org/r/188965 (https://phabricator.wikimedia.org/T77990) (owner: 10Aude) [18:46:38] (03CR) 10Legoktm: [C: 032] If no secret key is available, don't try to use cache [core] - 10https://gerrit.wikimedia.org/r/194213 (owner: 10Kaldari) [18:47:28] (03PS1) 10EBernhardson: Ensure squid cache is purged after successfull submissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/195330 (https://phabricator.wikimedia.org/T91897) [18:47:54] (03PS4) 10Aude: Split SiteLookup interface from SiteStore [core] - 10https://gerrit.wikimedia.org/r/188965 (https://phabricator.wikimedia.org/T77990) [18:48:31] (03CR) 10Aude: "using a proxy via the US to gerrit helps...." [core] - 10https://gerrit.wikimedia.org/r/188965 (https://phabricator.wikimedia.org/T77990) (owner: 10Aude) [18:50:45] (03CR) 10Jjanes: [C: 031] [schema] Make column user_properties.up_user an unsigned int [core] - 10https://gerrit.wikimedia.org/r/191124 (owner: 10Umherirrender) [18:51:35] (03CR) 10Jjanes: [C: 031] [schema] Make column page_props.pp_page an unsigned int [core] - 10https://gerrit.wikimedia.org/r/195102 (owner: 10Umherirrender) [18:52:15] (03CR) 10jenkins-bot: [V: 04-1] Split SiteLookup interface from SiteStore [core] - 10https://gerrit.wikimedia.org/r/188965 (https://phabricator.wikimedia.org/T77990) (owner: 10Aude) [18:54:54] (03Merged) 10jenkins-bot: If no secret key is available, don't try to use cache [core] - 10https://gerrit.wikimedia.org/r/194213 (owner: 10Kaldari) [18:57:58] (03PS5) 10Aude: Split SiteLookup interface from SiteStore [core] - 10https://gerrit.wikimedia.org/r/188965 (https://phabricator.wikimedia.org/T77990) [19:02:05] (03CR) 10Isarra: "Problem is, unless the logo is a vector (and not all can be), how do you have multiple sizes without having multiple files? You could have" [core] - 10https://gerrit.wikimedia.org/r/195195 (https://phabricator.wikimedia.org/T37337) (owner: 10Isarra) [19:15:30] (03PS3) 10Aaron Schulz: Split out chron tasks from job spawner as another daemon [services/jobrunner] - 10https://gerrit.wikimedia.org/r/192207 [19:21:27] (03PS2) 10Legoktm: Add liuggio/statsd-php-client [vendor] - 10https://gerrit.wikimedia.org/r/192252 (https://phabricator.wikimedia.org/T90409) (owner: 10Ori.livneh) [19:23:15] (03PS3) 10Legoktm: Add liuggio/statsd-php-client [vendor] - 10https://gerrit.wikimedia.org/r/192252 (owner: 10Ori.livneh) [19:23:22] (03CR) 10Legoktm: [C: 032] Add liuggio/statsd-php-client [vendor] - 10https://gerrit.wikimedia.org/r/192252 (owner: 10Ori.livneh) [19:29:46] (03CR) 10jenkins-bot: [V: 04-1] Split out chron tasks from job spawner as another daemon [services/jobrunner] - 10https://gerrit.wikimedia.org/r/192207 (owner: 10Aaron Schulz) [19:39:12] (03CR) 10Jjanes: [C: 031] [schema] Make column page_restrictions.pr_page an unsigned int [core] - 10https://gerrit.wikimedia.org/r/195103 (owner: 10Umherirrender) [19:40:32] (03CR) 10Legoktm: [C: 031] "Do we have to worry about revdel?" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/194507 (owner: 10Alex Monk) [19:40:52] (03CR) 10Brion VIBBER: [C: 04-1] "Warning: preg_match(): Empty regular expression in /vagrant/mediawiki/includes/parser/Parser.php on line" [core] - 10https://gerrit.wikimedia.org/r/184337 (https://phabricator.wikimedia.org/T65806) (owner: 10ImPacific) [19:40:54] (03CR) 10Legoktm: [C: 032] Load anonymous users by name [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/194448 (https://phabricator.wikimedia.org/T91416) (owner: 10Alex Monk) [19:42:59] (03CR) 10Krinkle: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/194408 (owner: 10EBernhardson) [19:43:08] (03CR) 10jenkins-bot: [V: 04-1] Split preview into feature file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/194408 (owner: 10EBernhardson) [19:43:22] (03CR) 10Brion VIBBER: Introducing a new variable $wgAllowExternalSVG (031 comment) [core] - 10https://gerrit.wikimedia.org/r/184337 (https://phabricator.wikimedia.org/T65806) (owner: 10ImPacific) [19:43:24] (03Merged) 10jenkins-bot: Add liuggio/statsd-php-client [vendor] - 10https://gerrit.wikimedia.org/r/192252 (owner: 10Ori.livneh) [19:43:28] (03Merged) 10jenkins-bot: Load anonymous users by name [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/194448 (https://phabricator.wikimedia.org/T91416) (owner: 10Alex Monk) [19:44:19] (03CR) 10Krinkle: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/195330 (https://phabricator.wikimedia.org/T91897) (owner: 10EBernhardson) [19:46:27] (03CR) 10Alex Monk: "The rest of the related code does not appear to. I think that should all be fixed in one go" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/194507 (owner: 10Alex Monk) [19:47:39] (03CR) 10Legoktm: [C: 032] Show summary instead of $7 when viewing an old EPRevision [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/194507 (owner: 10Alex Monk) [19:47:48] (03CR) 10Brion VIBBER: [C: 031] "Yeah, sizing things is Hard(TM). :( Anyway this seems to work on my retina macbook, so def +1 at least. :D" [core] - 10https://gerrit.wikimedia.org/r/195195 (https://phabricator.wikimedia.org/T37337) (owner: 10Isarra) [19:47:58] (03Merged) 10jenkins-bot: Show summary instead of $7 when viewing an old EPRevision [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/194507 (owner: 10Alex Monk) [19:48:06] (03CR) 10Legoktm: Add support for HD versions of the wiki logo in MonoBook-like skins. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/195195 (https://phabricator.wikimedia.org/T37337) (owner: 10Isarra) [19:51:03] (03PS9) 10ImPacific: Introducing a new variable $wgAllowExternalSVG [core] - 10https://gerrit.wikimedia.org/r/184337 (https://phabricator.wikimedia.org/T65806) [19:51:52] (03CR) 10Anomie: Allow constructing a Message from a MessageSpecifier (031 comment) [core] - 10https://gerrit.wikimedia.org/r/195293 (https://phabricator.wikimedia.org/T91986) (owner: 10Anomie) [19:52:16] James_F: What was the job count last week 3400? It's 3012 now [19:52:29] (03CR) 10Brion VIBBER: Add support for HD versions of the wiki logo in MonoBook-like skins. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/195195 (https://phabricator.wikimedia.org/T37337) (owner: 10Isarra) [19:52:41] (03CR) 10TheDJ: "I didn't get very far with reviewing, perhaps some of this has already been addressed, and some of this is equally wrong in many other are" (034 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165478 (https://phabricator.wikimedia.org/T63823) (owner: 10Brion VIBBER) [19:58:10] (03CR) 10Bartosz Dziewoński: [C: 031] "I was thinking that we could maybe extend $wgLogo to be either a string (like it is now) or an array in this format (with '1x' representin" [core] - 10https://gerrit.wikimedia.org/r/195195 (https://phabricator.wikimedia.org/T37337) (owner: 10Isarra) [19:58:14] (03CR) 10EBernhardson: "The problem is the set we need isn't based on the block, but on the action. Most things need everything but the various undo actions need" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/194230 (owner: 10EBernhardson) [19:58:19] (03PS3) 10Andrew Bogott: Don't bomb out if a VM uses an image that glance doesn't know about. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/194358 [19:58:21] (03PS1) 10Andrew Bogott: Set memc expire for tokens to 30 days [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/195350 [20:01:01] (03CR) 10Brion VIBBER: "Yeah, turning $wgLogo into an optional array is just likely to break custom skins. Whee! :)" [core] - 10https://gerrit.wikimedia.org/r/195195 (https://phabricator.wikimedia.org/T37337) (owner: 10Isarra) [20:05:24] (03PS10) 10ImPacific: Introducing a new variable $wgAllowExternalSVG [core] - 10https://gerrit.wikimedia.org/r/184337 (https://phabricator.wikimedia.org/T65806) [20:06:32] Krinkle: 3600 I think. [20:32:30] (03CR) 10Aaron Schulz: "recheck" [services/jobrunner] - 10https://gerrit.wikimedia.org/r/192207 (owner: 10Aaron Schulz) [20:34:39] (03PS4) 10Isarra: Add support for HD versions of the wiki logo in MonoBook-like skins. [core] - 10https://gerrit.wikimedia.org/r/195195 (https://phabricator.wikimedia.org/T37337) [20:35:42] (03PS1) 10Cmcmahon: QA: update ruby gems [extensions/Flow] - 10https://gerrit.wikimedia.org/r/195362 [20:36:19] (03PS1) 10Gerrit Patch Uploader: mediawiki.jqueryMsg: Implement a new function $.fn.appendMsg() [core] - 10https://gerrit.wikimedia.org/r/195363 [20:36:21] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/195363 (owner: 10Gerrit Patch Uploader) [20:37:49] (03CR) 10EBernhardson: [C: 032] QA: update ruby gems [extensions/Flow] - 10https://gerrit.wikimedia.org/r/195362 (owner: 10Cmcmahon) [20:40:50] (03CR) 10jenkins-bot: [V: 04-1] Introducing a new variable $wgAllowExternalSVG [core] - 10https://gerrit.wikimedia.org/r/184337 (https://phabricator.wikimedia.org/T65806) (owner: 10ImPacific) [20:47:59] (03PS11) 10ImPacific: Introducing a new variable $wgAllowExternalSVG [core] - 10https://gerrit.wikimedia.org/r/184337 (https://phabricator.wikimedia.org/T65806) [20:49:24] (03CR) 10Brion VIBBER: [C: 031] "I like it; it gets the job we need for now done simply without a lot of extra infrastructure, and we can still improve on it later with an" [core] - 10https://gerrit.wikimedia.org/r/195195 (https://phabricator.wikimedia.org/T37337) (owner: 10Isarra) [20:50:49] (03PS12) 10ImPacific: Introducing a new variable $wgAllowExternalSVG [core] - 10https://gerrit.wikimedia.org/r/184337 (https://phabricator.wikimedia.org/T65806) [20:53:31] (03Merged) 10jenkins-bot: QA: update ruby gems [extensions/Flow] - 10https://gerrit.wikimedia.org/r/195362 (owner: 10Cmcmahon) [20:55:50] (03PS1) 10Gerrit Patch Uploader: mediawiki.jqueryMsg: Fix examples in comments [core] - 10https://gerrit.wikimedia.org/r/195374 [20:55:52] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/195374 (owner: 10Gerrit Patch Uploader) [20:58:12] (03CR) 10Alex Monk: [C: 031] "Test failures look unrelated." [core] - 10https://gerrit.wikimedia.org/r/193826 (https://phabricator.wikimedia.org/T89066) (owner: 10Mobrovac) [20:59:36] (03CR) 10Nikerabbit: "Message class supports various types of parameters (raw, numbers...) which isn't addressed in the documentation in any way." [core] - 10https://gerrit.wikimedia.org/r/195292 (https://phabricator.wikimedia.org/T91985) (owner: 10Anomie) [21:05:04] no wikibugs? [21:06:20] Vulpix, legoktm was looking at it [21:06:21] (03PS8) 10Mobrovac: Introduce the Restbase Virtual REST Service class [core] - 10https://gerrit.wikimedia.org/r/193826 (https://phabricator.wikimedia.org/T89066) [21:06:32] k, thanks [21:10:07] Vulpix: it's having issues joining channels and my workaround from last time didn't work, I probably won't have time to debug until tonight (6-7 hours) [21:10:59] so the standard "reboot it" option doesn't work here? oh, how deceiving... [21:14:14] Vulpix: already did that :P lets see if the live hack I just put in will work [21:15:47] oh you gotta be kidding me [21:15:58] I put in my live hack and then it all starts working again??/ [21:16:48] 6Phabricator: Measure how Phabricator search is used - https://phabricator.wikimedia.org/T88863#1101551 (10Tgr) >>! In T88863#1099461, @Aklapper wrote: > I'd be also curious about this but I have no idea if anyone plans to commit time... How would someone who does get access to the data? I imagine we could eit... [21:17:18] (03PS1) 10EBernhardson: Reset container prior to running PurgeAction [extensions/Flow] - 10https://gerrit.wikimedia.org/r/195438 (https://phabricator.wikimedia.org/T91901) [21:17:24] (03PS1) 10Rits: T64998Internal links containing umlauts working now [core] - 10https://gerrit.wikimedia.org/r/195439 [21:17:28] lol [21:22:28] (03PS2) 10Rits: T64998 Internal links containing umlauts working now [core] - 10https://gerrit.wikimedia.org/r/195439 [21:23:17] 10MediaWiki-Vagrant: Add sqlite role for vagrant - https://phabricator.wikimedia.org/T67843#1101619 (10Yurik) Strongly support - I had no idea my sql changes were not passing until Jenkns complained [21:24:24] (03PS2) 10Mobrovac: Use $wgCanonicalServer instead of $wgServer [extensions/RestBaseUpdateJobs] - 10https://gerrit.wikimedia.org/r/193829 (https://phabricator.wikimedia.org/T87520) [21:24:41] hello please review my patch https://gerrit.wikimedia.org/r/#/c/195439/ [21:24:42] (03CR) 10Andrew Bogott: [C: 04-2] "this may be rendered moot by https://phabricator.wikimedia.org/T92014. Indeed, if that is the fix I'm looking for we may revert 4ee211149" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/195350 (owner: 10Andrew Bogott) [21:27:34] 10MediaWiki-API, 10MediaWiki-Patrolling: Provide a way to query if a given revision was patrolled or not - https://phabricator.wikimedia.org/T92018#1101642 (10He7d3r) 3NEW [21:27:50] 10MediaWiki-API, 10MediaWiki-Patrolling: Provide a way to query if a given revision was patrolled or not - https://phabricator.wikimedia.org/T92018#1101650 (10He7d3r) PS: sorry for the duplicate in case someone else created a task for T36646#386081 - I didn't find one when I searched. [21:28:31] 10MediaWiki-API, 10MediaWiki-Patrolling: Provide a way to query if a given revision was patrolled or not - https://phabricator.wikimedia.org/T92018#1101653 (10He7d3r) [21:30:03] 10MediaWiki-extensions-Html2Wiki: Add cancel button / hook into PHP session for upload - https://phabricator.wikimedia.org/T92019#1101660 (10freephile) 3NEW [21:32:16] 4(no projects): revoke/delete SSL cert techblog.wikimedia.org - https://phabricator.wikimedia.org/T92021#1101688 (10Dzahn) 3NEW [21:32:20] (03CR) 10GWicke: [C: 032] Use $wgCanonicalServer instead of $wgServer [extensions/RestBaseUpdateJobs] - 10https://gerrit.wikimedia.org/r/193829 (https://phabricator.wikimedia.org/T87520) (owner: 10Mobrovac) [21:32:50] 10WMF-Product-Strategy: Make a final run of the sampled log files, using the newest definition - https://phabricator.wikimedia.org/T92022#1101701 (10Ironholds) 3NEW a:3Ironholds [21:33:34] (03PS1) 10Andrew Bogott: Log a user out if they have no current keystone token. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/195445 [21:35:45] (03CR) 10GWicke: [V: 032] Use $wgCanonicalServer instead of $wgServer [extensions/RestBaseUpdateJobs] - 10https://gerrit.wikimedia.org/r/193829 (https://phabricator.wikimedia.org/T87520) (owner: 10Mobrovac) [21:36:19] 10Gather, 5Patch-For-Review: Responsive design for Special:Gather - https://phabricator.wikimedia.org/T91384#1101755 (10Jdlrobson) Flexbox - if it makes your life easier go for it. We only really need to support IE10 for Windows phones, we can always fix older browsers later. Build for the future not the past... [21:37:22] (03CR) 10Jforrester: [C: 031] Introduce the Restbase Virtual REST Service class [core] - 10https://gerrit.wikimedia.org/r/193826 (https://phabricator.wikimedia.org/T89066) (owner: 10Mobrovac) [21:37:24] (03PS1) 10Gergő Tisza: Update ImageMetrics submodule [core] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/195447 [21:39:08] 5Patch-For-Review: revoke/delete SSL cert techblog.wikimedia.org - https://phabricator.wikimedia.org/T92021#1101797 (10Dzahn) [21:39:09] 6Phabricator: Process to request a private project - https://phabricator.wikimedia.org/T823#1101796 (10DarTar) @Qgil: I understand the mid-term solution is becoming long-term, how do we move forward with the short term approach? [21:40:41] 6Phabricator, 10Phabricator-Upstream: Assign due date to task and have tasks with due dates displayed on a calendar (similar to Trello) - https://phabricator.wikimedia.org/T76094#1101807 (10DarTar) Any update on this? [21:41:10] 6Phabricator: Process to request a private project - https://phabricator.wikimedia.org/T823#1101810 (10Qgil) @DarTar, I would say that as soon as @atgo confirms that she is happy with {T88762} we could create the same type of setup for other teams. [21:42:07] 7Design: Reconsider use of colored buttons used in the body of the page. - https://phabricator.wikimedia.org/T92028#1101817 (10TrevorParscal) 3NEW [21:42:07] (03PS1) 10Legoktm: [WIP] Add script to notify people who are going to be renamed [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/195448 [21:42:25] (03PS1) 10Gergő Tisza: Update ImageMetrics submodule [core] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195449 [21:44:01] brion: please review my patch https://gerrit.wikimedia.org/r/#/c/195439/ [21:44:27] 10Gather: On render of Special:Gather, .collection-card-title element flashes over page title - https://phabricator.wikimedia.org/T92029#1101833 (10rmoen) 3NEW [21:47:14] 6Phabricator: Process to request a private project - https://phabricator.wikimedia.org/T823#1101859 (10DarTar) @Qgil, great – can you let me know when that happens and open a similar request for R&D? [21:48:00] 6Phabricator, 10Phabricator-Upstream: Assign due date to task and have tasks with due dates displayed on a calendar (similar to Trello) - https://phabricator.wikimedia.org/T76094#1101862 (10Qgil) Was it @greg who was also missing date fields in tasks? There are two problems here, and none of them is to have... [21:50:02] 10MediaWiki-extensions-SocialProfile, 10Social-Tools: SocialProfile shows date of birth even when not enabled - https://phabricator.wikimedia.org/T88912#1101876 (10lcawte) [21:50:59] 10MediaWiki-extensions-Comments, 10Social-Tools: Comments extension does not support SQLite as database backend // Error: 1 no such function: UNIX_TIMESTAMP - https://phabricator.wikimedia.org/T64708#1101886 (10lcawte) p:5Triage>3Low [21:52:53] (03CR) 10jenkins-bot: [V: 04-1] Update ImageMetrics submodule [core] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195449 (owner: 10Gergő Tisza) [21:54:12] (03CR) 10Brion VIBBER: [C: 04-1] T64998 Internal links containing umlauts working now (031 comment) [core] - 10https://gerrit.wikimedia.org/r/195439 (owner: 10Rits) [21:54:15] (03CR) 10Gergő Tisza: "recheck" [core] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195449 (owner: 10Gergő Tisza) [21:55:05] (03PS1) 10Cmcmahon: QA: insert one-second sleep for Chrome workaround [extensions/Echo] - 10https://gerrit.wikimedia.org/r/195453 [21:56:10] (03PS2) 10Cmcmahon: QA: insert one-second sleep for Chrome workaround [extensions/Echo] - 10https://gerrit.wikimedia.org/r/195453 [21:58:18] 10Grantmaking-IdeaLab: page created by user null - https://phabricator.wikimedia.org/T92032#1101911 (10Capt_Swing) 3NEW a:3Jephpaul [21:58:20] (03CR) 10Rits: "just for including the umlauts can i just use this àáâçčʒǯđðéèêëǧǥȟíìîïıǩŋñóòôõßšŧúùûýÿüžþæøåäö or their respective regex" [core] - 10https://gerrit.wikimedia.org/r/195439 (owner: 10Rits) [21:59:58] 10Fundraising-Backlog, 3Fundraising Sprint G: Update unsubscribe link in TY email header - https://phabricator.wikimedia.org/T91476#1101927 (10atgo) [22:00:16] 10Fundraising-Backlog: Recurring Payments Reporting - https://phabricator.wikimedia.org/T90630#1101929 (10atgo) @ellery ping again [22:01:39] (03CR) 10Anomie: "> Message class" [core] - 10https://gerrit.wikimedia.org/r/195292 (https://phabricator.wikimedia.org/T91985) (owner: 10Anomie) [22:02:43] (03PS7) 10Ori.livneh: Add StatsD metric logging [core] - 10https://gerrit.wikimedia.org/r/191854 [22:02:54] 3Gather Sprint C_: A user can delete their own collection - https://phabricator.wikimedia.org/T91776#1101933 (10rmoen) a:3rmoen [22:04:19] (03CR) 10Cscott: [C: 04-1] "Some questions." (0311 comments) [core] - 10https://gerrit.wikimedia.org/r/181777 (owner: 10Arlolra) [22:04:21] 6MediaWiki-Core-Team: Investigate a better alternative for making user_newtalk talk updates - https://phabricator.wikimedia.org/T92007#1101941 (10bd808) [22:05:11] (03CR) 10Cscott: Tidy up tidy usage (031 comment) [core] - 10https://gerrit.wikimedia.org/r/181777 (owner: 10Arlolra) [22:08:02] 10Gather, 3Gather Sprint C_: Anon CTA not showing - https://phabricator.wikimedia.org/T91998#1101956 (10Jdlrobson) a:3Jdlrobson [22:09:55] bd808: It looks like you deprecated using wfErrorLog(), but none of the documentation around doing MediaWiki debug logging has been updated (https://www.mediawiki.org/wiki/Manual:How_to_debug#Logging). Is MWLoggerLegacyLogger::emit() effectively a plug-in replacement for wfErrorLog()? [22:10:07] 10Gather, 3Gather Sprint C_: No visual feedback when creating new collection - https://phabricator.wikimedia.org/T92034#1101958 (10Jdlrobson) 3NEW [22:10:53] kaldari: Yes, it is, but ... why would anyone log like that? It seems pretty nasty [22:11:08] bd808: what do you mean nasty? [22:11:18] A better way would be to use wfDebugLog(), name a channel and direct it someehere [22:11:57] Direct use of wfErrorLog is nasty because it makes that log call very special [22:12:07] bd808: I just use wfErrorLog() when I need to do a quick debug of something that doesn’t have output, like a hook or API [22:12:08] not a part of the more normal logging systems [22:12:44] Like as a temporary printf sort of thing? [22:12:46] bd808: exactly, I only use it for debugging, not normal logging [22:13:00] yeah like a temporary printf sort of thing [22:13:17] 10Gather: On render of Special:Gather, .collection-card-title element flashes over page title - https://phabricator.wikimedia.org/T92029#1101976 (10Jdlrobson) {F69280} Video demonstrating issue (around 2s) The issue is likely to be CSS styles loaded via JavaScript. [22:13:30] 10Gather, 3Gather Sprint C_: On render of Special:Gather, .collection-card-title element flashes over page title - https://phabricator.wikimedia.org/T92029#1101978 (10Jdlrobson) [22:13:54] 10Gather, 3Gather Sprint C_: On render of Special:Gather, .collection-card-title element flashes over page title - https://phabricator.wikimedia.org/T92029#1101833 (10Jdlrobson) @JKatzWMF please prioritise this in ready for dev if you want it fixed. [22:14:09] bd808: anyway, just curious if I can abuse MWLoggerLegacyLogger::emit() the same way :) [22:14:21] yeah, you should be able to [22:14:30] 10Gather, 3Gather Sprint C_, 5Patch-For-Review: Special:Gather shows blank page when no manifest exists - https://phabricator.wikimedia.org/T91777#1101986 (10Jdlrobson) 5Open>3Resolved [22:14:45] it's the guts from the old wfErrorLog() implementation [22:15:01] bd808: Thanks. Also, should I ping S about updating https://www.mediawiki.org/wiki/Manual:How_to_debug#Logging, or do you want to mess with that? [22:15:04] I'll try to update that wiki page too [22:15:09] cool [22:15:30] * bd808 will not be telling people to use emit() :) [22:16:12] I have a long treatise in my head on how to log in a way that is useful [22:16:20] Someday I'll get it written out [22:17:31] db808: I would love to read it [22:17:40] Basically PSR-3 logging should be what people are doing and if the information being logged is only good for local debugging then they should log as debug() level. But even then the log events should have useful context information. [22:17:57] info() == useful to debug in prod [22:18:12] warning() == something not right [22:18:24] error() == something broken [22:19:38] 10Gather, 3Gather Sprint C_: Watchlist collection shows up twice under existing collections - https://phabricator.wikimedia.org/T92035#1101995 (10Jdlrobson) 3NEW [22:19:38] Our codebase is like many in that the log messages we have often don't give enough context to determine what actually caused things to go wrong [22:20:01] 10Gather, 3Gather Sprint C_: On render of Special:Gather, .collection-card-title element flashes over page title - https://phabricator.wikimedia.org/T92029#1102005 (10JKatzWMF) done thanks! [22:20:16] bd808: do we support firephp logging by default? [22:20:36] that would be the obvious replacement for writing debug info to a tempfile [22:20:40] bd808, ori, is destroy/up with roles already enabled expected to work? [22:20:45] by default, no. Not that I know [22:20:49] Or is initial 'up' only safe with no roles enabled. [22:21:06] I hit some bugs with that scenario, wondering whether to report them. [22:21:16] superm401: you should be able to have any roles enabled on the first up [22:21:32] there is a monolog handler for it, so it's just a question of defining the channel [22:21:48] superm401: we may have a few roles with bugs in that need to be tracked down where they don't define their ordering well [22:21:52] bd808, ok, I also have some non-Puppet settings.d which is part of the interaction. But it should work, I think. [22:22:23] 6Phabricator, 6Engineering-Community, 3ECT-March-2015, 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: Enable Conpherence for all Wikimedia Phabricator users - https://phabricator.wikimedia.org/T91392#1102010 (10Memeht) I think it is a good idea to keep it open to all Phabricator users. It's a great wa... [22:23:04] (03PS1) 10EBernhardson: Add some debugging info for NoIndexException with topic_root_id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/195461 (https://phabricator.wikimedia.org/T91916) [22:24:09] bd808: just keep in mind that lack of simple debugging tools is a serious deterant to volunteer devs. Having more robust tools is great, but there shouldn’t be a leanring curve to figure out basic debugging. If you have to debug your debugging, your head will likely explode :) [22:24:12] !log doing a refreshGlobalimagelinks.php --pages=nonexistent test run on aawiki [22:24:27] 6MediaWiki-Core-Team, 6CA-team, 10SUL-Finalization, 6operations: db1068 (s4/commonswiki slave) is missing data about at least 6 users - https://phabricator.wikimedia.org/T91920#1102019 (10Philippe-WMF) [22:24:41] tgr: wrong channel :) [22:24:57] !log doesn't work here? [22:25:09] where would it go? [22:26:00] Prod SAL is in -operations, releng SAL is in -releng, others are in -labs [22:26:05] I thought it went to the server admin log from any channel that's not qa/releng/etc [22:26:43] kaldari: out of the box all you need to do is point $wgDebugLogFile somewhere [22:26:49] 10MediaWiki-Vagrant: Destroy then re-up with roles already enabled gives 'undefined constant' but should be defined. - https://phabricator.wikimedia.org/T92036#1102021 (10Mattflaschen) 3NEW [22:27:27] bd808: That sounds simple enough :) [22:27:51] (03PS1) 10Jforrester: Update VisualEditor for I588a4df0 [core] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195462 [22:27:55] 10MediaWiki-Vagrant: Destroy then re-up with roles already enabled gives 'undefined constant' but should be defined. - https://phabricator.wikimedia.org/T92036#1102028 (10Mattflaschen) This then recurs for other actions, such as mediawiki_user_Selenium_user. [22:28:43] superm401: where does that constant come from? Something in the Flow extension? [22:29:38] (03PS1) 10Legoktm: Add b:, q:, n: etc as interwiki prefixes for all projects [extensions/WikimediaMaintenance] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195464 (https://phabricator.wikimedia.org/T2955) [22:29:38] bd808, yes, it's defined in Flow: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FFlow.git/d9d4681f37622587feeeb0a332e73473b65dcf88/Flow.php#L34 then https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FFlow.git/d9d4681f37622587feeeb0a332e73473b65dcf88/defines.php [22:30:20] (03PS1) 10Legoktm: Add b:, q:, n: etc as interwiki prefixes for all projects [extensions/WikimediaMaintenance] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/195465 (https://phabricator.wikimedia.org/T2955) [22:30:53] (03CR) 10Legoktm: [C: 032] Add b:, q:, n: etc as interwiki prefixes for all projects [extensions/WikimediaMaintenance] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/195465 (https://phabricator.wikimedia.org/T2955) (owner: 10Legoktm) [22:31:01] (03CR) 10Legoktm: [C: 032] Add b:, q:, n: etc as interwiki prefixes for all projects [extensions/WikimediaMaintenance] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195464 (https://phabricator.wikimedia.org/T2955) (owner: 10Legoktm) [22:31:03] superm401: hmm... ok [22:31:03] (03Merged) 10jenkins-bot: Add b:, q:, n: etc as interwiki prefixes for all projects [extensions/WikimediaMaintenance] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/195465 (https://phabricator.wikimedia.org/T2955) (owner: 10Legoktm) [22:31:17] (03Merged) 10jenkins-bot: Add b:, q:, n: etc as interwiki prefixes for all projects [extensions/WikimediaMaintenance] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195464 (https://phabricator.wikimedia.org/T2955) (owner: 10Legoktm) [22:31:24] I think I know why/how that could blow up [22:31:28] bd808, and normally all the Puppet-defined setting.d should execute before it even starts the non-Puppet settings.d. [22:31:48] yeah... but when you destroy that all gets erased [22:32:23] and the wiki installer would need to run before the extension shows back up [22:32:31] (03PS1) 10Legoktm: Update WikimediaMaintenance to 1.25wmf19 HEAD [core] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/195466 [22:32:41] (03PS1) 10Legoktm: Update WikimediaMaintenance to 1.25wmf20 HEAD [core] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195467 [22:33:15] so it's lame, but if you are making local settings changes like that you probably need to guard them for a destroy->up cycle to work [22:33:33] bd808, but the installer should already have run by this point, since it's adding a page to the wiki. [22:34:19] hmm... true. So maybe it is just an ordering bug [22:34:20] bd808, there's also https://phabricator.wikimedia.org/P377 , which is probably same underlying cause (I had a non-Puppet PHP loader for navigationtiming, probably because the role didn't exist yet. I can just get rid of it now, though). [22:34:41] that the page add should wait until after all the extensions are done being configured [22:35:08] Yeah, it already waits for copy_LocalSettings, but it doesn't look like that ties into the roles directly. [22:35:21] bd808: is there any documentation about running maintenance scripts? [22:35:23] But it does require MediaWiki::Wiki[$wiki_name], so not sure. [22:35:27] * bd808 looks at import_text [22:35:46] I'm trying to piece things together from wikitech but it's not very useful [22:35:59] 10Gather, 3Gather Sprint C_: Watchlist collection shows up twice under existing collections - https://phabricator.wikimedia.org/T92035#1102056 (10Jdlrobson) a:3Jdlrobson [22:36:19] 10Gather: design tweaks - https://phabricator.wikimedia.org/T92037#1102057 (10JKatzWMF) 3NEW [22:36:42] tgr: what kind of documentation? [22:36:52] any kind :) [22:37:33] right now I'm using mwscript to run extensions/GlobalUsage/refreshGlobalimagelinks.php and apprantly the extension does not get loaded [22:37:57] which wiki? which host? [22:38:01] so probably there is some option to parse LocalSettings that I am missing? [22:38:07] terbium, aawiki [22:38:30] the exact command was "mwscript extensions/GlobalUsage/refreshGlobalimagelinks.php --wiki=aawiki --pages=nonexisting" [22:39:02] 10Gather, 3Gather Sprint C_, 5Patch-For-Review: Adding to new collection workflow - https://phabricator.wikimedia.org/T91296#1102069 (10JKatzWMF) @jdlrobson, @mSyed and I reviewed and put together a list of existing issues preventing signoff Functional: * [] overlay should have scroll, scroll starts on lin... [22:39:49] tgr: That looks right [22:40:01] and wmgUseGlobalUsage looks to be true for aawiki [22:40:16] it should be enabled for all wikis [22:40:32] all public wikis [22:41:02] (03CR) 10jenkins-bot: [V: 04-1] Update VisualEditor for I588a4df0 [core] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195462 (owner: 10Jforrester) [22:41:33] all public ones, yeah [22:41:39] 10Gather, 3Gather Sprint C_, 5Patch-For-Review: Adding to new collection workflow - https://phabricator.wikimedia.org/T91296#1102081 (10Jdlrobson) Best to file as separate bugs and check the other bugs in sign off quickly before doing so. Point 2 for example was fixed recently (see https://phabricator.wikime... [22:41:46] hm, https://aa.wikipedia.org/wiki/Special:Version does not list it though [22:41:48] tgr: Found the problem. aawiki is in the closed.dblist [22:41:53] (03PS3) 10Mattflaschen: QA: insert one-second sleep for Chrome workaround [extensions/Echo] - 10https://gerrit.wikimedia.org/r/195453 (owner: 10Cmcmahon) [22:41:57] so don't use it [22:42:27] 10Gather: design tweaks - https://phabricator.wikimedia.org/T92037#1102083 (10Jdlrobson) What does gray out mean? Which stars are you talking about? The big one in the overlay or the one in the menu Please be more verbose in bug reports like this using screenshots where necessary. [22:42:33] 10Gather, 3Gather Sprint C_: design tweaks - https://phabricator.wikimedia.org/T92037#1102084 (10Jdlrobson) [22:42:36] thanks [22:42:40] 10Wikimedia-Site-requests, 3HTTPS-by-default, 5Patch-For-Review: Russian projects force HTTPS regardless of preferences - https://phabricator.wikimedia.org/T91352#1102086 (10KPu3uC_B_Poccuu) Why? [22:42:48] is there another customary test wiki to use? [22:43:16] 10Gather, 3Gather Sprint C_: design tweaks - https://phabricator.wikimedia.org/T92037#1102057 (10Jdlrobson) Also maybe merge into T91634 for design tweaks? [22:43:16] tgr, test.wikipedia.org [22:43:24] well, testwiki if it's a test [22:43:27] xD [22:43:29] (03PS4) 10Mattflaschen: QA: insert one-second sleep for Chrome workaround [extensions/Echo] - 10https://gerrit.wikimedia.org/r/195453 (owner: 10Cmcmahon) [22:43:30] or test2wiki [22:43:33] test as in... [22:43:45] (03CR) 10Mattflaschen: [C: 032] "Thanks. I added a brief note about the workaround." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/195453 (owner: 10Cmcmahon) [22:43:49] 6Phabricator, 6Engineering-Community, 3ECT-March-2015, 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: Enable Conpherence for all Wikimedia Phabricator users - https://phabricator.wikimedia.org/T91392#1102091 (10Qgil) >>! In T91392#1102010, @Memeht wrote: > The only drawback is that a lot of people don... [22:44:19] 3Gather Sprint C_, 5Patch-For-Review: Edit and delete an existing collection UI - https://phabricator.wikimedia.org/T90990#1102092 (10JKatzWMF) @jhernandez, @msyed and I just identified some blockers to signoff: Functional: * [] I should be able to trigger edit in non-watchlist list (see bug above) * [] sho... [22:44:52] (03Merged) 10jenkins-bot: QA: insert one-second sleep for Chrome workaround [extensions/Echo] - 10https://gerrit.wikimedia.org/r/195453 (owner: 10Cmcmahon) [22:47:47] (03PS1) 10Jforrester: Flow container needs to be reset before each test [extensions/Thanks] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195470 (https://phabricator.wikimedia.org/T91967) [22:48:09] (03CR) 10Gergő Tisza: "The errors can be ignored, they are all from Flow and MobileFrontend tests. This patch does not affect them in any way." [core] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195449 (owner: 10Gergő Tisza) [22:48:55] (03CR) 10jenkins-bot: [V: 04-1] Flow container needs to be reset before each test [extensions/Thanks] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195470 (https://phabricator.wikimedia.org/T91967) (owner: 10Jforrester) [22:49:03] (03CR) 10Gergő Tisza: "(Actually all from Flow.)" [core] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195449 (owner: 10Gergő Tisza) [22:50:56] 10LiquidThreads, 7JavaScript, 7Wikimedia-log-errors: LQT doesn't handle error conditions from the api - https://phabricator.wikimedia.org/T30132#1102107 (10greg) 5Open>3declined a:3greg Closing because of age, lack of clear test case, lack of error message and silentness. [22:51:15] (03CR) 10Catrope: [C: 032 V: 032] Flow container needs to be reset before each test [extensions/Thanks] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195470 (https://phabricator.wikimedia.org/T91967) (owner: 10Jforrester) [22:52:20] 10LiquidThreads, 7Wikimedia-log-errors: Undefined property: WikiImporter::$nodeType in /mediawiki/trunk/extensions/LiquidThreads/classes/Hooks.php on line 614 - https://phabricator.wikimedia.org/T30284#1102113 (10greg) Not a WMF production error, removing wikimedia-log-errors [22:52:27] 10LiquidThreads: Undefined property: WikiImporter::$nodeType in /mediawiki/trunk/extensions/LiquidThreads/classes/Hooks.php on line 614 - https://phabricator.wikimedia.org/T30284#1102114 (10greg) [22:53:51] (03PS2) 10Jforrester: Update VisualEditor for I588a4df0 and Thanks for Ic80b137e [core] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195462 [22:56:29] (03PS4) 10Andrew Bogott: Don't bomb out if a VM uses an image that glance doesn't know about. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/194358 [22:56:31] (03PS2) 10Andrew Bogott: Log a user out if they have no current keystone token. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/195445 [22:56:33] (03PS1) 10Andrew Bogott: Support 2048 byte Keystone tokens [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/195472 [22:56:54] (03PS1) 10JoelKP: Add 'WSemanticData' and 'WSemanticProperty' objects (v1.3.0) [extensions/PhpTagsSMW] - 10https://gerrit.wikimedia.org/r/195473 [23:00:36] 10MediaWiki-Vagrant: Destroy then re-up with roles already enabled gives 'undefined constant' but should be defined. - https://phabricator.wikimedia.org/T92036#1102131 (10bd808) Related {P377} Basically Mediawiki::Import_text is firing before all of Mediawiki::Extension and Mediawiki::Settings invocations. When... [23:01:37] (03CR) 10Mattflaschen: "Do you know why VE threw an exception here (https://integration.wikimedia.org/ci/job/mwext-Thanks-qunit/22/consoleFull)?" [extensions/Thanks] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195470 (https://phabricator.wikimedia.org/T91967) (owner: 10Jforrester) [23:02:16] (03CR) 10Jforrester: "> Do you know why VE threw an exception here (https://integration.wikimedia.org/ci/job/mwext-Thanks-qunit/22/consoleFull)?" [extensions/Thanks] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195470 (https://phabricator.wikimedia.org/T91967) (owner: 10Jforrester) [23:06:46] (03CR) 10Aaron Schulz: Add StatsD metric logging (032 comments) [core] - 10https://gerrit.wikimedia.org/r/191854 (owner: 10Ori.livneh) [23:06:56] (03CR) 10Legoktm: [C: 032] Update ImageMetrics submodule [core] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/195447 (owner: 10Gergő Tisza) [23:07:02] (03CR) 10Legoktm: [C: 032] Update ImageMetrics submodule [core] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195449 (owner: 10Gergő Tisza) [23:07:23] (03CR) 10Legoktm: [V: 032] Update ImageMetrics submodule [core] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195449 (owner: 10Gergő Tisza) [23:08:13] (03CR) 10Legoktm: [V: 032] Update ImageMetrics submodule [core] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/195447 (owner: 10Gergő Tisza) [23:12:12] (03CR) 10Legoktm: [C: 032] Update VisualEditor for I588a4df0 and Thanks for Ic80b137e [core] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195462 (owner: 10Jforrester) [23:13:48] (03CR) 10Legoktm: [C: 032] Update WikimediaMaintenance to 1.25wmf19 HEAD [core] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/195466 (owner: 10Legoktm) [23:13:50] (03CR) 10Legoktm: [C: 032] Update WikimediaMaintenance to 1.25wmf20 HEAD [core] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195467 (owner: 10Legoktm) [23:14:16] (03PS1) 10BryanDavis: Provision all extensions before importing text [vagrant] - 10https://gerrit.wikimedia.org/r/195478 (https://phabricator.wikimedia.org/T92036) [23:14:22] 10MediaWiki-extensions-GuidedTour, 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 3Editing Department 2014/15 Q4 blockers: Create a guided tour for VisualEditor using GuidedTour guiders - https://phabricator.wikimedia.org/T89074#1102155 (10Jdforrester-WMF) [23:15:19] superm401: https://gerrit.wikimedia.org/r/#/c/195478/ should fix your destroy && up race I think [23:15:21] (03CR) 10Mattflaschen: "Krinkle, do you know the right way to document this? I tried some things, e.g.:" [core] - 10https://gerrit.wikimedia.org/r/191660 (owner: 10EBernhardson) [23:15:43] 10Fundraising-Backlog: Recurring Payments Reporting - https://phabricator.wikimedia.org/T90630#1102156 (10ellery) I don't know how you guys process recurring payments. Is there documentation on this? If not, I would prefer if whoever knows the most about recurring payments were to tackle some of these question... [23:17:48] (03PS1) 10Gergő Tisza: Fix deleted page handling in update script [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/195479 (https://phabricator.wikimedia.org/T65594) [23:17:59] bd808, looks right, does that basically mean "All MediaWiki::Extension resources must come before the first Mediawiki::Import_text resource? [23:18:50] 10MediaWiki-Vagrant, 5Patch-For-Review: Destroy then re-up with roles already enabled gives 'undefined constant' but should be defined. - https://phabricator.wikimedia.org/T92036#1102169 (10bd808) a:3bd808 [23:19:30] 4(no projects): revoke/delete bugzilla ssl certs - https://phabricator.wikimedia.org/T92041#1102171 (10Dzahn) 3NEW [23:20:12] (03CR) 10Aaron Schulz: Add StatsD metric logging (031 comment) [core] - 10https://gerrit.wikimedia.org/r/191854 (owner: 10Ori.livneh) [23:20:54] (03CR) 10Legoktm: [V: 032] Update VisualEditor for I588a4df0 and Thanks for Ic80b137e [core] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195462 (owner: 10Jforrester) [23:20:58] (03CR) 10Legoktm: [V: 032] Update WikimediaMaintenance to 1.25wmf19 HEAD [core] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/195466 (owner: 10Legoktm) [23:21:30] 3Team-Practices-This-Week: Schedule Q3 health checks (Kristen) - https://phabricator.wikimedia.org/T90607#1102196 (10Awjrichards) 5Open>3Resolved [23:21:31] 3Team-Practices-This-Week: Schedule next round of health check surveys - https://phabricator.wikimedia.org/T88326#1102198 (10Awjrichards) [23:21:36] 3Team-Practices-This-Week: Prepare EMGT presentation of Q2 health check data - https://phabricator.wikimedia.org/T90014#1102199 (10Awjrichards) 5Open>3Resolved [23:21:41] 3Team-Practices-This-Week: Update Team Practices Group's Q3 quarterly goals - https://phabricator.wikimedia.org/T88327#1102201 (10Awjrichards) 5Open>3Resolved [23:21:46] (03CR) 10Legoktm: [V: 032] Update WikimediaMaintenance to 1.25wmf20 HEAD [core] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195467 (owner: 10Legoktm) [23:21:47] 3Team-Practices-This-Week: Publish overall trends and health from Q2 health check - https://phabricator.wikimedia.org/T90012#1102202 (10Awjrichards) 5Open>3Resolved [23:21:48] 3Team-Practices-This-Week: Quality check Q2 health check data - https://phabricator.wikimedia.org/T90013#1102204 (10Awjrichards) [23:21:53] 3Team-Practices-This-Week: Quality check Q2 health check data - https://phabricator.wikimedia.org/T90013#1051467 (10Awjrichards) [23:21:54] 3Team-Practices-This-Week: Q2 health check megamatix - https://phabricator.wikimedia.org/T90011#1102205 (10Awjrichards) 5Open>3Resolved [23:21:57] 3Team-Practices-This-Week: Schedule next round of health check surveys - https://phabricator.wikimedia.org/T88326#1009494 (10Awjrichards) [23:21:58] 3Team-Practices-This-Week: Schedule Q3 health checks (Arthur) - https://phabricator.wikimedia.org/T90609#1102208 (10Awjrichards) 5Open>3Resolved [23:22:28] (03CR) 10Se4598: [C: 04-1] "Missing instructions for update: $wgHooks['LoadExtensionSchemaUpdates']/function efOpenStackSchemaUpdates." [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/195472 (owner: 10Andrew Bogott) [23:23:27] (03PS1) 10Dduvall: plugin: Refactor functional tests to simulate CLI [vagrant] - 10https://gerrit.wikimedia.org/r/195480 [23:23:45] (03CR) 10Andrew Bogott: "I'm well out of my depth, and about to punch out for the evening. Do you mind writing this patch, presuming it's quick?" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/195472 (owner: 10Andrew Bogott) [23:25:54] superm401: Yeah, basically [23:26:32] 4(no projects): revoke / delete etherpad.wikimedia.org SSL cert - https://phabricator.wikimedia.org/T92045#1102226 (10Dzahn) 3NEW [23:26:37] 6Phabricator, 3Team-Practices-This-Week: Feasibility study for using Phabricator for burndown charts - https://phabricator.wikimedia.org/T88328#1102232 (10KLans_WMF) Changing scope a bit; going to set up burndown chart for App projects. [23:26:45] I thought about only making it wait on extensions with matching wikidbs but that seemed like more magic than was needed [23:27:01] 3Team-Practices-This-Week: Burndown chart training and support - VE release support with Editing Team - https://phabricator.wikimedia.org/T88365#1102237 (10Awjrichards) 5Open>3Resolved [23:28:47] Can somebody please merge that stuck changeset in? It has already C+2, V+2: https://gerrit.wikimedia.org/r/182551 [23:29:33] (03CR) 10Bartosz Dziewoński: [C: 032] "poking jenkins" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/182551 (https://phabricator.wikimedia.org/T48292) (owner: 10Florianschmidtwelzow) [23:30:07] se4598, I though everybody could in these circumstances, by clicking on "Submit Patch Set 3". do you have this button? [23:30:38] OuKB: Please do *not* submit patches bypassing Jenkins. [23:30:44] No, but I neither have +2 [23:30:55] James_F, it's not;) [23:31:15] OuKB: The "submit and merge" button bypasses Jenkins. [23:31:38] OuKB: se4598: yeah, that is only available to people with +2 rights. [23:31:44] Is it just me noticing more or has the gate pipeline been a bit flakey the last month or so? [23:31:50] nah. unless you also override it with a V+2 [23:32:00] bd808: heh heh [23:32:09] bd808: It's been slower, because we've been doing proper cross-repo testing before merge. [23:32:13] i can't remember when it has not! [23:32:20] bd808: To an extent this is a hardware problem. [23:32:26] *nod* [23:32:52] I've been whining about the testing hardware allocation for a while [23:32:59] bd808: But the 2^N issue becomes irritating when N=200 extensions. [23:33:13] the box that is running jenkins is less powerful than my laptop [23:33:27] bd808: (We're not currently parallel-testing all 200, only about 8 or 10 that are important.) [23:33:47] (03PS8) 10Ori.livneh: Add StatsD metric logging [core] - 10https://gerrit.wikimedia.org/r/191854 [23:33:51] bd808: This is more a topic of -releng, BTW. [23:34:16] also, our unit tests suck because they use the DB and do other fun stuff [23:34:31] if they were faster... [23:35:00] (03CR) 10Dduvall: "Test suite build now takes < 10s on a warm gem cache." [vagrant] - 10https://gerrit.wikimedia.org/r/195480 (owner: 10Dduvall) [23:35:07] You mean, they actually test the system including the database? That's hardly a bad thing. :-) [23:35:40] Running integration tests in a unit test runner and pipeline is sucky [23:35:49] considering that they test the DB we don't even run in prod... [23:35:56] 10MediaWiki-General-or-Unknown: English Wikipedia user talk page simultaneously exists and doesn't exist - https://phabricator.wikimedia.org/T92046#1102261 (10Harej) 3NEW [23:36:00] (03CR) 10jenkins-bot: [V: 04-1] Add StatsD metric logging [core] - 10https://gerrit.wikimedia.org/r/191854 (owner: 10Ori.livneh) [23:36:01] it leads to people not running and bypassing tests [23:36:14] one flappy test is here, but it isn't exactly known if it is a problem of the test itself or the maschine running it ;) https://phabricator.wikimedia.org/T88554 [23:36:15] but mediawiki and mocking are not good friends yet [23:37:19] wfGetDB() is convenient though, hahaha [23:37:50] 10MediaWiki-General-or-Unknown: English Wikipedia user talk page simultaneously exists and doesn't exist - https://phabricator.wikimedia.org/T92046#1102280 (10Earwig) There appear to be sixteen affected pages in total, given by the following query. Note that NS 3 is User_talk and NS 4 is Wikipedia. ``` MariaDB... [23:38:29] insert schroedinger joke here [23:39:31] (03CR) 10Krinkle: "Documented methods need a containing class. In this case the singleton mw as defined in mediawiki.js." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/191660 (owner: 10EBernhardson) [23:39:35] 10MediaWiki-extensions-UniversalLanguageSelector, 10VisualEditor, 10VisualEditor-ContentLanguage, 3Editing Department 2014/15 Q4 blockers: Make ULS input methods work in content editable divs of VisualEditor - https://phabricator.wikimedia.org/T51569#1102286 (10Jdforrester-WMF) [23:40:00] (03PS9) 10Ori.livneh: Add StatsD metric logging [core] - 10https://gerrit.wikimedia.org/r/191854 [23:40:29] hehe, zuul: ETA: unknown, queued -1 hr -1 min ago xD [23:40:55] MC8: Schrödinger gets pulled over for speeding. The officer looks over the car and asks Schrödinger if he has anything in the trunk. "A cat," Schrödinger replies. The cop opens the trunk and yells "Hey! This cat is dead." Schrödinger angrily replies, "Well he is now." [23:41:01] (03PS3) 10Mattflaschen: Don't log missing user-locators [extensions/Echo] - 10https://gerrit.wikimedia.org/r/190019 (owner: 10EBernhardson) [23:41:11] (03CR) 10Mattflaschen: [C: 032] Don't log missing user-locators [extensions/Echo] - 10https://gerrit.wikimedia.org/r/190019 (owner: 10EBernhardson) [23:41:38] kaldari: heh [23:42:16] (03CR) 10JoelKP: [C: 032] Add 'WSemanticData' and 'WSemanticProperty' objects (v1.3.0) [extensions/PhpTagsSMW] - 10https://gerrit.wikimedia.org/r/195473 (owner: 10JoelKP) [23:42:29] (03CR) 10JoelKP: [V: 032] Add 'WSemanticData' and 'WSemanticProperty' objects (v1.3.0) [extensions/PhpTagsSMW] - 10https://gerrit.wikimedia.org/r/195473 (owner: 10JoelKP) [23:42:40] 10Wikimedia-Interwiki-links, 5Patch-For-Review: b: doesn't work from Wikibooks; neither n: from Wikinews nor q: from Wikiquote, etc. - https://phabricator.wikimedia.org/T2955#1102317 (10Legoktm) [16:34:51] !log legoktm Synchronized wmf-config/interwiki.cdb: Updating interwiki cache (duration: 00m 05s) [23:43:03] 10GlobalUserPage, 10Wikimedia-Interwiki-links, 5Patch-For-Review: Enable special interwiki link prefix for each WMF project - https://phabricator.wikimedia.org/T89546#1102320 (10Legoktm) [16:34:51] !log legoktm Synchronized wmf-config/interwiki.cdb: Updating interwiki cache (duration: 00m 05s) @... [23:43:06] (03CR) 10Krinkle: "In code, the following line would do it:" [core] - 10https://gerrit.wikimedia.org/r/191660 (owner: 10EBernhardson) [23:44:05] (03PS4) 10Dduvall: plugin: Acceptance tests for `vagrant roles` [vagrant] - 10https://gerrit.wikimedia.org/r/194982 [23:45:15] (03PS10) 10Ori.livneh: Add StatsD metric logging [core] - 10https://gerrit.wikimedia.org/r/191854 [23:45:58] (03CR) 10Mattflaschen: [C: 032] Specify max compatible kss version [core] - 10https://gerrit.wikimedia.org/r/194785 (https://phabricator.wikimedia.org/T91725) (owner: 10Spage) [23:50:09] 3Team-Practices-This-Week: tech talk - https://phabricator.wikimedia.org/T85821#1102337 (10KLans_WMF) Landed on a talk to communicate Q2 health check survey results to the org. Yey! [23:50:13] (03CR) 10Mattflaschen: [C: 032] Provision all extensions before importing text [vagrant] - 10https://gerrit.wikimedia.org/r/195478 (https://phabricator.wikimedia.org/T92036) (owner: 10BryanDavis) [23:51:03] (03PS5) 10Dduvall: plugin: Acceptance tests for `vagrant roles` [vagrant] - 10https://gerrit.wikimedia.org/r/194982 [23:51:52] (03Merged) 10jenkins-bot: Provision all extensions before importing text [vagrant] - 10https://gerrit.wikimedia.org/r/195478 (https://phabricator.wikimedia.org/T92036) (owner: 10BryanDavis) [23:52:12] 3Team-Practices-This-Week: tech talk on health check survey results - https://phabricator.wikimedia.org/T85821#1102355 (10KLans_WMF) [23:52:59] 3Team-Practices-This-Week: Release Engineering & Team Practices Group focus on reducing technical debt and increasing test coverage - https://phabricator.wikimedia.org/T92038#1102356 (10Awjrichards) [23:53:14] 3Team-Practices-This-Week: Schedule Q3 health check followup meetings - https://phabricator.wikimedia.org/T91714#1102357 (10Awjrichards) [23:53:33] 3Team-Practices-This-Week: Update 'task tracking' docs for Team Practices Group - https://phabricator.wikimedia.org/T91604#1102359 (10Awjrichards) [23:53:40] 3Team-Practices-This-Week: Create TPG list of terms and practices - https://phabricator.wikimedia.org/T75785#1102361 (10Awjrichards) [23:54:17] 3Team-Practices-This-Week: tech talk on Q2 health check survey results - https://phabricator.wikimedia.org/T85821#1102363 (10KLans_WMF) [23:54:38] 10MediaWiki-Categories, 6Mobile-Web, 5Patch-For-Review: Categories should not be rendered in a table (do not display well on mobile) - https://phabricator.wikimedia.org/T55130#1102370 (10PeterBowman) I may have spotted another issue: expanding subcategories make other elements "jump" between columns, sometim... [23:56:35] 3Team-Practices-This-Week: Update 'task tracking' docs for Team Practices Group - https://phabricator.wikimedia.org/T91604#1102377 (10ggellerman) a:3ggellerman [23:57:23] (03PS11) 10Ori.livneh: Add StatsD metric logging [core] - 10https://gerrit.wikimedia.org/r/191854 [23:59:28] 10Wikimedia-Site-requests, 5Patch-For-Review: Please restrict anonymous users from creating new pages at sw.wikipedia - https://phabricator.wikimedia.org/T44894#1102383 (10Dzahn) >>! In T44894#1099454, @Jalexander wrote: > While in the original request they talked about anonymous editing in general because of... [23:59:31] 3Team-Practices-This-Week: Create TPG list of terms and practices - https://phabricator.wikimedia.org/T75785#1102384 (10Awjrichards) Goal here is to have a common list of terms and definitions to be shared across the organization. For now, let's blurt out a bunch of common terms on a page on mediawiki.org, then...