[00:01:12] 3MediaWiki-extensions-TimedMediaHandler, Multimedia: Attempting to play a video when fullscreen mode is previously enabled on an element nested below the element will cause the video to be played but not being visible - https://phabricator.wikimedia.org/T89684#1042631 (10Rillke) - We could possibly use ht... [00:03:09] Krinkle o/ [00:04:33] James_F: I meant 'top of my list' for when I return. it clearly wasn't atop my list the past 48 hours. [00:05:34] 3Wikibugs, Tool-Labs, Phabricator: wikibugs test bug - https://phabricator.wikimedia.org/T1152#1042643 (10Krinkle) 5stalled>3Invalid a:3Krinkle Bazinga! [00:05:43] Krinkle: You merged it after leaving IRC, so eh. :-) [00:06:28] Yeah, I had 2 more minutes so figured I'd check it out and look through the diff top to biottom quickly [00:08:20] Krinkle: did you test that sqlite timeout patch? [00:08:25] TimStarling: I did not [00:08:31] I'll do it then [00:08:39] TimStarling: Though the main test will happen automatically by having it run through Jenkins [00:08:54] TimStarling: I'm downloading the build artefact now to see if it has (m)any errors [00:09:20] I mostly want to know if it does time out after 3 seconds on concurrent write access [00:09:35] I'm just going to open a file twice with eval.php and see what happens [00:09:46] TimStarling: The mediawiki-core-qunit-karma non-voting build specifically. Then back up to ../ and download artefacts. The other jobs run on prod slaves and have less failures anyway. The ones that run in labs have the most overlap due to request sbeing slower [00:09:54] TimStarling: Ah, cool. [00:09:55] Thanks :) [00:10:31] TimStarling: Wow, there isn't a single db lock error in that build [00:10:41] so that's pretty good :) [00:14:04] The "LoadBalancer::getConnection: using server for group" messages seem pretty useless [00:14:06] https://integration.wikimedia.org/ci/job/mediawiki-core-qunit-karma/485/artifact/log/mw-debug-www.log/*view*/ [00:14:17] Take up like 60% of the log [00:14:25] (not including resourceloader) [00:15:09] I tested it, it works as advertised [00:15:46] (03PS2) 10Tim Starling: db: Enable ATTR_TIMEOUT for DatabaseSqlite [core] - 10https://gerrit.wikimedia.org/r/190851 (https://phabricator.wikimedia.org/T89180) (owner: 10Krinkle) [00:21:57] the tests that were failing, were they running under HHVM or PHP? [00:27:21] (03PS1) 10Se4598: Add license name to credits and add minor config code comment [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/190958 [00:28:44] Krinkle, PM [00:34:54] (03PS3) 10Se4598: Add extension.json [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/190761 (https://phabricator.wikimedia.org/T87876) [00:43:05] (03CR) 10Tim Starling: [C: 04-1] "I tested it with eval.php under both HHVM and PHP PHP. With the patch, it waits for 3 seconds. Without the patch, it waits for 60 seconds." [core] - 10https://gerrit.wikimedia.org/r/190851 (https://phabricator.wikimedia.org/T89180) (owner: 10Krinkle) [00:46:01] TimStarling: I actually saw just now that all todays build for that job had 0 database errors [00:46:05] Another mystery [00:48:23] TimStarling: That build uses HHVM 3.3.1 (PHP/5.5.9-1ubuntu4.5) [01:01:59] (03PS1) 10Krinkle: resourceloader: Simplify log message for getDefinitionMtime() cache miss [core] - 10https://gerrit.wikimedia.org/r/190965 [01:02:46] (03PS2) 10Krinkle: resourceloader: Simplify log message for getDefinitionMtime() cache miss [core] - 10https://gerrit.wikimedia.org/r/190965 [01:07:45] (03CR) 10Krinkle: [C: 031] CPB: Add class to notification (032 comments) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/190384 (https://phabricator.wikimedia.org/T67178) (owner: 10Phoenix303) [01:21:23] 3Librarization, Wikidata, MediaWiki-Vendor, Wikibase-DataModel-JavaScript: Add data-values/javascript 0.6.0 to mediawiki/vendor - https://phabricator.wikimedia.org/T88436#1042729 (10Krinkle) Jobs will no longer use mediawiki/vendor in the near future. But until we're there, if the relevant extension here is Wiki... [01:24:33] 3Possible-Tech-Projects, MediaWiki-extensions-CentralAuth: Global preferences - https://phabricator.wikimedia.org/T16950#1042731 (10Legoktm) To create an extension of sufficient quality to be deployed in WMF production (which IMO the end goal should be), there will need to be refactoring to the preferences syste... [01:27:19] (03CR) 10Krinkle: Rewrite error handling to avoid OutputPage::addInlineScript (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/186503 (owner: 10Anomie) [01:28:48] Krinkle: Hi, I just noticed extensions/examples set up mw.libs..Should all extensions switch over to this instead of top-level mw. ? [01:34:00] 3Community-Engagement: Track # of participants in weekly VisualEditor triage meetings - https://phabricator.wikimedia.org/T89523#1042732 (10Rdicerb) [01:43:38] 3MediaWiki-Uploading, Possible-Tech-Projects, Multimedia: Add support for KML/KMZ filetype - https://phabricator.wikimedia.org/T28059#1042735 (10Rschen7754) It is hard to say, since this is (according to my understanding) a security issue, and because it is not clear how Wikidata will affect this. [01:47:11] 3Labs, Labs-Vagrant, Wikimedia-Labs-Other, Wikimedia-Labs-wikistats, Wikimedia-Labs-wikitech-interface, Wikimedia-Labs-General, Beta-Cluster, Project-Creators, Wikimedia-Labs-Infrastructure, Tool-Labs-tools-Article-request, Tool-Labs, Wikimedia-Labs-extdist, MediaW... - https://phabricator.wikimedia.org/T89270#1042736 [01:51:51] (03CR) 10Krinkle: Rewrite error handling to avoid OutputPage::addInlineScript (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/186503 (owner: 10Anomie) [01:51:58] (03CR) 10Krinkle: Rewrite error handling to avoid OutputPage::addInlineScript [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/186503 (owner: 10Anomie) [01:52:04] (03CR) 10Krinkle: "https://gist.github.com/Krinkle/fd9148e9551121e82013" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/186503 (owner: 10Anomie) [01:52:30] spagewmf: No [01:52:44] spagewmf: I still have my examples patch pending locally. Not had time to do it [01:53:35] spagewmf: I can hand it over to you if you like and go over gerrit further? [01:53:58] Krinkle: then should anyone be using mw.libs. ? I see ve and a few others using it [01:54:11] spagewmf: It's actually documented [01:54:15] it's for third-party libs [01:54:22] standalone libraries being exposed [01:54:34] for cases where you don't want to add a new global, or the global is bad and needs containment or wrapping [01:54:48] mw.libs.ve != ve [01:54:49] Krinkle: I'd be happy to take a look at your examples patch, do you want to submit as a draft? [01:55:15] spagewmf: https://gist.github.com/Krinkle/2208e5994a6ae8be6e55 [01:56:23] (03PS7) 10Phoenix303: CPB: Add class to notification [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/190384 (https://phabricator.wikimedia.org/T67178) [01:58:16] (03CR) 10Krinkle: [C: 031] "(I think there may be an extra tab somewhere, though jscs isn't being enforced on this repo yet)." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/190384 (https://phabricator.wikimedia.org/T67178) (owner: 10Phoenix303) [02:04:08] Krinkle: mediawiki.js says of mw.libs only "Empty object that plugins can be installed in." [02:04:14] (03PS1) 10Spage: Document mw.libs better [core] - 10https://gerrit.wikimedia.org/r/190968 [02:04:20] ^ :) [02:05:57] (03PS8) 10Phoenix303: CPB: Add class to notification [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/190384 (https://phabricator.wikimedia.org/T67178) [02:06:15] (03CR) 10Krinkle: [C: 032] Document mw.libs better [core] - 10https://gerrit.wikimedia.org/r/190968 (owner: 10Spage) [02:07:35] (03PS9) 10Phoenix303: CPB: Add class to notification [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/190384 (https://phabricator.wikimedia.org/T67178) [02:07:53] AaronS: Hm.. seeing "SQL ERROR (ignored): no such table: hitcounter " as error on recent jenkins builds [02:08:09] From update.php [02:08:41] Krinkle: https://gist.github.com/Krinkle/2208e5994a6ae8be6e55#file-examples-diff-staged-diff-L139 <-- should we be adding an explicit dependency on codesniffer? Or should it just use whatever version that mw-codesniffer depends upon? [02:09:17] legoktm: I didn't know mw-codesniffer provides phpcs itself [02:09:20] Interesting [02:09:30] I suppose we should add it directly [02:09:38] because we're invoking it and depending on a version as well [02:09:45] if mw-codesniffer would get aheadof that, we'd want an error [02:10:05] and semantically, we need it in vendor/phpcs not vendor/mw-codesniffer/phpcs [02:10:30] unless mw-codesniffer provides its own wrapped bin [02:10:41] well composer would install it to vendor/phpcs [02:11:01] But it'd be for mw-codesniffer to use, not for users of mw-codesniffer [02:11:18] it's kind of silly, but I'd still say it's outside the separated concerns. [02:11:27] ok :P [02:11:30] I also created a tag for mw-codesniffer, so you can depend on "0.1.0" instead of dev-master [02:11:31] also, we shouldn't be using dev-master [02:11:33] Yeah [02:11:38] That example diff is from 2 weeks ago [02:11:41] (03Merged) 10jenkins-bot: Document mw.libs better [core] - 10https://gerrit.wikimedia.org/r/190968 (owner: 10Spage) [02:11:44] :) [02:12:02] legoktm: update https://www.mediawiki.org/wiki/Continuous_integration/Test_entry_points ? [02:12:27] I see wikimedia/cdb uses it, cool :) [02:12:39] {{done}} [02:13:13] 3Community-Engagement: Track # of participants in weekly VisualEditor triage meetings - https://phabricator.wikimedia.org/T89523#1042741 (10Rdicerb) Here are the results of the first weekly Triage meeting (Feb 11, 2015) https://lists.wikimedia.org/pipermail/wikitech-l/2015-February/080803.html [02:16:50] Missing info on T78424 - https://phabricator.wikimedia.org/T89690#1042742 (10Redrose64) 3NEW [02:22:07] Missing info on T78424 - https://phabricator.wikimedia.org/T89690#1042757 (10Legoktm) [02:27:34] TimStarling: Okay, so while the mediawiki-core builds have not timed out for at least 2 days, the builds that install a bunch of extensions, are still (as recent as 2 minutes ago) shown 'database is locked' errors. [02:27:49] e.g. https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit-karma/253/artifact/log/mw-debug-www.log/*view*/ [02:27:58] (filtered) https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit-karma/253/artifact/log/mw-dberror.log/*view*/ [02:34:08] (03PS3) 10Krinkle: db: Enable ATTR_TIMEOUT for DatabaseSqlite [core] - 10https://gerrit.wikimedia.org/r/190851 (https://phabricator.wikimedia.org/T89180) [02:34:46] the question is whether they timed out after 0 seconds or after 60 [02:34:49] (03CR) 10Krinkle: "Added debugging to use in manually triggered build of https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit-karma/ using this " [core] - 10https://gerrit.wikimedia.org/r/190851 (https://phabricator.wikimedia.org/T89180) (owner: 10Krinkle) [02:34:54] TimStarling: Yeah, after 0 [02:34:59] TimStarling: Can be clearly seen from the db failure [02:35:13] it includes a timestamp value in the array of values trying to be stored [02:35:17] the same second offset [02:35:24] Tue Feb 17 1:40:06 UTC 2015 integration-slave1008 build253 MessageBlobStore::insertMessageBlob/single-row 5 database is locked INSERT OR IGNORE INTO msg_resource (mr_lang,mr_resource,mr_blob,mr_timestamp) VALUES ('en','jquery.ui.button','{}','20150217014006') [02:35:25] Tue Feb 17 1:40:07 UTC 2015 integration-slave1008 build253 MessageBlobStore::insertMessageBlob/single-row 5 database is locked INSERT OR IGNORE INTO msg_resource (mr_lang,mr_resource,mr_blob,mr_timestamp) VALUES ('en','Base64.js','{}','20150217014007') [02:35:56] Right, so there's no point in the manual build. It's not using it [02:37:25] (03PS4) 10Krinkle: db: Enable ATTR_TIMEOUT for DatabaseSqlite [core] - 10https://gerrit.wikimedia.org/r/190851 (https://phabricator.wikimedia.org/T89180) [02:39:55] 3 seconds may be too short [02:40:16] the lock is held for the duration of the transaction [02:40:36] and considering we are apparently reducing it from 60 to 3 [02:41:19] TimStarling: the 60 is set in the PDO layer, or in sqlite itself? [02:41:26] PDO [02:42:32] http://git.php.net/?p=php-src.git;a=blob;f=ext/pdo_sqlite/sqlite_driver.c;h=decc9dc43845ad6100ef0bb6716970ba7c57f080;hb=HEAD#l789 [02:43:18] on line 820 the third parameter to pdo_attr_lval() is the default if that key is not in the array [02:44:42] that is master, but the code is the same in 5.3 [02:45:21] basically I am not convinced that we have identified the problem [02:45:31] https://github.com/php/php-src/blob/dfe6aea9cab6df556049ec2c9867d97a97e0fe09/ext/pdo_sqlite/sqlite_driver.c#L789-L820 [02:45:33] Yeah [02:45:37] sqlite3_busy_timeout [02:46:02] I'm not convinced that the proposed patch will fix it [02:46:22] and, like I say, on the face of it it seems to be reducing the timeout from 60 to 3, contrary to the comment and commit message [02:46:28] hhvm's code is much cleaner, but yeah, same thing [02:46:32] and that might not be a good idea [02:46:39] https://github.com/facebook/hhvm/blob/4d9b5b19afc0581856c79298f0672d7b55df9339/hphp/runtime/ext/pdo_sqlite.cpp#L117 [02:46:39] https://github.com/facebook/hhvm/blob/4d9b5b19afc0581856c79298f0672d7b55df9339/hphp/runtime/ext/pdo_sqlite.cpp#L247 [02:46:46] yeah, I've seen it [02:47:24] TimStarling: Hm.. perhaps tmpfs? [02:47:53] what about tmpfs? [02:48:08] TimStarling: Is there a reasonable chance sqlite might not deal with that well? [02:48:14] We use tmpfs to store the sql files [02:49:11] I doubt it, but it's nice to have theories [02:50:03] I'm pretty much out of ideas from my perspective. [02:50:20] We've not identified the problem, and the proposed patch does not resolve it. [02:50:42] are there other ways SQLite can return SQLITE_BUSY? [02:51:18] TimStarling: Uncommitted transactions perhaps? [02:52:05] 3MediaWiki-extensions-CentralAuth: Locked accounts should have mail-based notifications ~~receipt~~ disabled - https://phabricator.wikimedia.org/T87559#1042766 (10Rich_Farmbrough) I strongly disagree with this. There is no purpose to be served other than vindictiveness in denying locked users the ability to... [02:52:18] sqlite src mentions something about outstanding prepared statements raising SQLITE_BUSY as well [02:52:48] Hm.. I don't think we're using that [02:53:40] sqlite3Error(db, SQLITE_BUSY, [02:53:40] In core anyway, but maybe one of the extensions bundled with the test suite. That would explain why it doesn't seem to be happening on plain core anymore. Although that could just be a lucky race as core makes less queries than core+extensions. [02:53:40] "unable to delete/modify user-function due to active statements"); [02:53:50] I wonder how we get the third parameter in that call [02:54:33] 3MediaWiki-extensions-CentralAuth: Locked accounts should have mail-based notifications ~~receipt~~ disabled - https://phabricator.wikimedia.org/T87559#1042768 (10Jackmcbarn) >>! In T87559#1042766, @Rich_Farmbrough wrote: > I strongly disagree with this. There is no purpose to be served other than vindictive... [02:58:04] maybe http://php.net/manual/en/pdo.errorinfo.php [02:59:29] no, we use that already [03:01:43] Yeah, lastErrno/lastError > reportQueryError > 5 database is locked [03:02:05] I don't see a path from sqlite's pErr to php user land [03:02:47] unless that is the path [03:03:23] Nah, it's not the path. sqlite replaces it with a constant string mapped to SQLITE_BUSY in sqlite3ErrStr [03:03:44] regardless of the err https://github.com/smparkes/sqlite/blob/8caf9219240123fbe6cff67b1e0da778c62d7621/src/main.c#L812 [03:04:11] sqlite3_errmsg() will return the mapped string, "database is locked" [03:04:30] 3Phabricator: Phabricator should only notify changes to the "Security" field if it is indeed changed - https://phabricator.wikimedia.org/T87135#1042769 (10Quiddity) >>! In T87135#986352, @mmodell wrote: > I'm not really sure what could be the cause of this but it's likely an upstream issue. :-/ The last change... [03:06:19] Hm... seems like sqlite3_errmsg will passthru the original pErr in some cases https://github.com/smparkes/sqlite/blob/8caf921/src/main.c#L1445-L1457 are we not hitting that block? [03:06:22] 3Possible-Tech-Projects, MediaWiki-extensions-CentralAuth: Global preferences - https://phabricator.wikimedia.org/T16950#1042772 (10NiharikaKohli) >>! In T16950#1042731, @Legoktm wrote: > To create an extension of sufficient quality to be deployed in WMF production (which IMO the end goal should be), there will... [03:07:54] it may be that sqlite3Error() is called with zFormat=NULL [03:08:36] 3Multimedia, MediaWiki-extensions-CommonsMetadata, WMF-Legal: CommonsMetadata cannot differentiate between license of the image and other licenses - https://phabricator.wikimedia.org/T89692#1042773 (10Tgr) 3NEW [03:09:39] 3Multimedia, MediaWiki-extensions-CommonsMetadata, WMF-Legal: CommonsMetadata cannot differentiate between license of the image and other licenses - https://phabricator.wikimedia.org/T89692#1042782 (10Tgr) [03:10:10] I'm going to try to test what happens if it is called with a non-null format [03:11:28] 3Wikimedia-Extension-setup, GlobalUserPage: Review and deploy GlobalUserPage extension to Wikimedia wikis - https://phabricator.wikimedia.org/T72576#1042785 (10Eloquence) @Legoktm I am noticing that the username in my personal bar is still a red link on wikis that have a GUP, while recent changes/contribs have b... [03:13:05] yeah, pretty sure it works as expected [03:13:36] e.g. if you do a DB query error, MW will give you information about what was wrong with the query, which presumably came from a non-null format [03:16:50] TimStarling: Hm.. I lost track. [03:17:05] well, I was wondering if there was more error information [03:17:11] answer: no, we have it all already [03:17:14] zFormat is both input from a caller requesting the last error and passed by sqlite when emitting the error? [03:17:28] for a normal timeout, it looks like zFormat will be NULL [03:17:28] I'm reading that wrong [03:17:34] Right [03:17:49] in some of the more exotic cases, it is non-NULL, so we know we don't have any of those cases [03:17:53] So the information is lost within sqlite, or there is no extra info to begin with at the moemnt? [03:17:58] Right, ok [03:18:04] there is no extra info to begin with [03:18:06] Yeah [03:18:43] Oh, I see it now [03:18:48] it passes the null as a 0 [03:20:00] I didn't know that cpp'ism [03:20:43] 3Community-Engagement: Track # of participants in weekly VisualEditor triage meetings - https://phabricator.wikimedia.org/T89523#1042800 (10Rdicerb) [03:20:54] Arr, not cpp. ignore that [03:21:35] it's not normal style but it is allowed [03:21:37] (03CR) 10Gergő Tisza: "Is a purge enough? If so, the script could just "untouch" the page so it's regenerated on next visit, as a horrible short-term hack." [vagrant] - 10https://gerrit.wikimedia.org/r/189182 (https://phabricator.wikimedia.org/T88356) (owner: 10Gergő Tisza) [03:21:55] Thanks [03:25:16] maybe the sleep is interrupted by a signal and sqlite is buggy in that case, will test that [03:27:49] don't think so [03:29:44] you can't reproduce it right now, correct? [03:30:13] I don't have any more ideas apart from reproducing and figuring out what is going on with it [03:30:49] 3GlobalUserPage: When you have a global user page but no local user page, the personal portlet user page link appears red - https://phabricator.wikimedia.org/T89549#1042802 (10Legoktm) [03:31:13] 3Wikimedia-Extension-setup, GlobalUserPage: Review and deploy GlobalUserPage extension to Wikimedia wikis - https://phabricator.wikimedia.org/T72576#1042806 (10Legoktm) >>! In T72576#1042785, @Eloquence wrote: > @Legoktm I am noticing that the username in my personal bar is still a red link on wikis that have a... [03:31:36] maybe just abandon the timeout patch for now if we are sure it doesn't help [03:31:52] if we see the issue again, we can test it and see if it helps [03:34:18] TimStarling: I can repro it. It's still happening every build of mediawiki with extensions [03:34:22] But not locally [03:34:55] https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit-karma/ https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit-karma/259/artifact/log/mw-dberror.log/*view*/ [03:35:24] and none of the patch set versions of our patch had any influence on that [03:35:31] failing after 0 seconds [03:35:43] That one's from 10 min ago [03:36:18] do you know how to run tests from the command line? [03:36:28] 3Possible-Tech-Projects, MediaWiki-extensions-CentralAuth: Global preferences - https://phabricator.wikimedia.org/T16950#1042808 (10Legoktm) >>! In T16950#1042772, @NiharikaKohli wrote: > Could we make "Refactoring core" into a different project altogether, in that case? Maybe combine it with other smaller tasks... [03:36:28] I do [03:36:34] on the actual CI servers? [03:36:37] TimStarling: Yep [03:36:48] TimStarling: Want me to tell you, or me to do what you have in mind [03:37:05] 3MediaWiki-extensions-Extensions-requests, Possible-Tech-Projects, GlobalPreferences: Global preferences - https://phabricator.wikimedia.org/T16950#1042809 (10Legoktm) [03:37:23] please tell me [03:37:36] TimStarling: k [03:37:44] TimStarling: adding you to contint-admins via wikitech first [03:37:57] TimStarling: You'll be logging into integration-slave1009 (I depooled it just now) [03:38:57] will ping you in a sec [03:39:06] integration-slave1009.eqiad.wmflabs ? [03:39:11] Yeah [03:39:20] Maybe it allows root, not sure [03:40:07] Permission denied (publickey). [03:40:15] TimStarling: what's your labs username? [03:40:44] "Tim Starling" probably [03:40:49] with a space [03:40:56] Ah, right [03:41:03] that is the LDAP username, the UNIX username is tstarling [03:41:06] It's not sudo? [03:41:20] Nevermind, sorry [03:41:24] it may be, but when I log in as myself it says: Connection closed by UNKNOWN [03:41:36] TimStarling: k, added and made admin so you can sudo [03:41:52] works [03:41:56] May wanna go in #wikimedia-releng , quiet there [03:45:37] (03CR) 10Legoktm: "Sorry, late review. We need to somehow specify a central database and then run the updater there, so that if a second wiki is added, the p" [vagrant] - 10https://gerrit.wikimedia.org/r/178138 (https://phabricator.wikimedia.org/T76835) (owner: 10Prtksxna) [04:07:17] 3MediaWiki-extensions-CentralAuth: Locked accounts should have mail-based notifications ~~receipt~~ disabled - https://phabricator.wikimedia.org/T87559#1042848 (10Billinghurst) This is about locked accounts, and locked accounts for the gamut of reasons that accounts are locked. It was highlighted by the recen... [04:07:48] 3MediaWiki-extensions-CentralAuth: Locked accounts should have mail-based notifications ~~receipt~~ disabled - https://phabricator.wikimedia.org/T87559#1042849 (10Billinghurst) [04:17:18] (03CR) 10Krinkle: "recheck" [core] - 10https://gerrit.wikimedia.org/r/190953 (https://phabricator.wikimedia.org/T70653) (owner: 10QChris) [05:36:07] 3: Can't go back from anchors in Android Beta Wikipedia App - https://phabricator.wikimedia.org/T89693#1042867 (10Jidanni) 3NEW [05:38:47] 3: Put current page name in box at top, instead of just "Search", on Android Beta Wikipedia App - https://phabricator.wikimedia.org/T89694#1042874 (10Jidanni) 3NEW [05:39:01] 3: Can't go back from anchors in Android Beta Wikipedia App - https://phabricator.wikimedia.org/T89693#1042881 (10Deskana) @Jidanni Thanks for the report. Is this about the mobile website or the mobile app? [05:40:24] 3: Can't go back from anchors in Android Beta Wikipedia App - https://phabricator.wikimedia.org/T89693#1042882 (10Deskana) It's clear from the task title that you mean the app. I only saw the description. Sorry about that. [05:40:50] 3MediaWiki-Interface: Section headings should have some clickable anchor for passing links - https://phabricator.wikimedia.org/T18691#1042886 (10polybuildr) I updated MonoBook's `main.css` to use a smaller width for the anchors. Still very tight, but doesn't look slightly broken (as it currently does with MonoBo... [05:43:29] 3GlobalUserPage: Redlink for my username in personal toolbar when using a GlobalUserPage - https://phabricator.wikimedia.org/T85550#1042890 (10Eloquence) 5Invalid>3Open [05:44:07] 3Phabricator: Missing info on T78424 - https://phabricator.wikimedia.org/T89690#1042892 (10Krenair) [05:46:19] 3GlobalUserPage: Redlink for my username in personal toolbar when using a GlobalUserPage - https://phabricator.wikimedia.org/T85550#1042894 (10Eloquence) It's generally bad design to have a UI act in one way in one context, and in a different way in another. Redlinks should be used to indicate the non-existence... [05:46:45] 3GlobalUserPage: Redlink for my username in personal toolbar when using a GlobalUserPage - https://phabricator.wikimedia.org/T85550#1042895 (10Eloquence) [06:11:41] 3MediaWiki-extensions-ContentTranslation: Suggest the possibility of translating after an article has been created - https://phabricator.wikimedia.org/T89697#1042918 (10Pginer-WMF) 3NEW [06:11:43] 3Phabricator: Phabricator project display names use awkward capitalization and hyphenation - https://phabricator.wikimedia.org/T911#1042926 (10Jaredzimmerman-WMF) obviously I would prefer projects have normal sentence style structure, without hyphens underscores, etc. [06:23:20] 3Phabricator.org: image viewer close button moves with view scroll - https://phabricator.wikimedia.org/T78077#1042928 (10Jaredzimmerman-WMF) 5stalled>3Resolved a:3Jaredzimmerman-WMF Seems resolved. [06:28:35] 3Math: Non-rendering of archaic Greek letters - https://phabricator.wikimedia.org/T89620#1042932 (10Physikerwelt) @Michael_Hardy you are right, that's a bug that needs to be fixed. [06:29:13] 3Math: Non-rendering of archaic Greek letters - https://phabricator.wikimedia.org/T89620#1042933 (10Physikerwelt) a:3Physikerwelt [06:30:07] 3MediaWiki-extensions-Quiz: GIFT format - https://phabricator.wikimedia.org/T24475#1042935 (10jayvdb) There was a GSoC 2010 proposal for this task. https://en.wikiversity.org/wiki/Google/Summer_of_Code_2010_Proposal:_GIFT_Conversion Do we want to recycle that into a GSoC 2015 project? [06:32:53] 3Math: Math extension unit tests should not attempt to connect to wmflabs.org - https://phabricator.wikimedia.org/T87389#1042937 (10Physikerwelt) @AKlapper How can we ensure that this change is chained for being reviewed at some point in time, even though it's not top priority. [06:36:59] 3ContentTranslation-Deployments, MediaWiki-extensions-ContentTranslation, Language-Engineering: Deploy Content Translation tool to CEE language Wikipedias for regional project this spring - https://phabricator.wikimedia.org/T88030#1042942 (10Arrbee) Hello, we need a little help to evaluate the quality of the mac... [06:42:06] 3GlobalUserPage: Redlink for my username in personal toolbar when using a GlobalUserPage - https://phabricator.wikimedia.org/T85550#1042947 (10Ricordisamoa) What about introducing a new link color meaning "shadow page" (that could also apply to local non-existing file description pages)? [06:43:25] 3MediaWiki-extensions-Quiz: GIFT format - https://phabricator.wikimedia.org/T24475#1042949 (10jayvdb) Here is a gift to qti converter https://github.com/csev/gift2qti (PHP). Even if we are not interested in QTI format, the gift parser may be instructive. [06:54:09] 3Datasets-General-or-Unknown, Possible-Tech-Projects, MediaWiki-extensions-Quiz: Accuracy review - https://phabricator.wikimedia.org/T89416#1042952 (10jayvdb) I see that GIFT isnt supported by #MediaWiki-extensions-Quiz (T24475) , but it is supported by http://tools.wmflabs.org/magnustools/wikisoba.html . I hav... [06:56:21] jzerebecki: I don't want to self merge :( [06:56:39] jzerebecki: I changed it quite a bit. [06:56:56] jzerebecki: Maybe werdna could merge it. [06:59:17] jzerebecki: I'll make those bugs blockers for T88164 so that we don't forget them! [07:01:53] 3Popups: Make hovercards default for Chinese, Catalan and Greek Wikipedias - https://phabricator.wikimedia.org/T88164#1042957 (10Prtksxna) [07:16:43] (03CR) 10Gergő Tisza: "Sentry (the error-logging server) won't be production-ready for several weeks at least, but it is being tested on beta, which would be har" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/188328 (https://phabricator.wikimedia.org/T513) (owner: 10Gergő Tisza) [07:17:05] (03PS11) 10Gergő Tisza: Wrap asynchronous callbacks with error logging [core] - 10https://gerrit.wikimedia.org/r/188328 (https://phabricator.wikimedia.org/T513) [07:20:49] 3MediaWiki-extensions-Quiz: TestWiki (multiple choice test similar to Quiz) - https://phabricator.wikimedia.org/T19129#1042965 (10jayvdb) 5Open>3declined a:3jayvdb fwiw, the full text of that URL is still visible at http://wiki.laptop.org/index.php?title=User:Fasten/TestWiki&oldid=223978 But, I agree that... [07:24:03] (03CR) 10Hoo man: [C: 032] Add license name to credits and add minor config code comment [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/190958 (owner: 10Se4598) [07:25:02] (03Merged) 10jenkins-bot: Add license name to credits and add minor config code comment [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/190958 (owner: 10Se4598) [07:32:34] I am working on a EducationProgram bug in which a select list needed to be changed to a checkbox and need some help. I am unable to pass the value of the checkbox i.e if it is checked or unchecked [07:35:01] (03CR) 10Giuseppe Lavagetto: "recheck" [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/190789 (owner: 10Giuseppe Lavagetto) [07:38:23] (03CR) 10Hoo man: [C: 04-1] "Changing this to plain Exception is not the way to go... I've annotated better sub classes to use where I thought it'd make sense." (037 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/184027 (owner: 10Ori.livneh) [07:43:37] 3MediaWiki-Uploading, Possible-Tech-Projects, Multimedia: Add support for KML/KMZ filetype - https://phabricator.wikimedia.org/T28059#1042975 (10TheDJ) @Qgil, I note this is not an easy task, since there are some security aspects to it... That's the reason why it stalled. The task itself is easy, but the backgro... [07:51:48] 3UI-Standardization, Multimedia, MediaWiki-extensions-MultimediaViewer: Adjust Media Viewer download menu colors - https://phabricator.wikimedia.org/T89520#1042976 (10Pginer-WMF) @Tgr, after updating core and refreshing I see a different picture now. I see two issues: - When hovering the selected element, the ro... [07:51:50] 3Math: Non-rendering of archaic Greek letters - https://phabricator.wikimedia.org/T89620#1042980 (10Pkra) @Michael_Hardy which browsers are you experiencing this with? [07:52:35] API function wbsetqualifier blocks frontend - https://phabricator.wikimedia.org/T89698#1042981 (10Balu) 3NEW [07:58:19] 3MediaWiki-extensions-WikibaseRepository: API function wbsetqualifier blocks frontend - https://phabricator.wikimedia.org/T89698#1042989 (10Balu) [08:01:02] (03PS6) 10Hoo man: add filter option for local rules only on central wiki [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/181805 (https://phabricator.wikimedia.org/T78495) (owner: 10Se4598) [08:01:42] (03CR) 10Hoo man: add filter option for local rules only on central wiki (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/181805 (https://phabricator.wikimedia.org/T78495) (owner: 10Se4598) [08:03:01] (03CR) 10Hoo man: "Rebased, added a missing space" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/181805 (https://phabricator.wikimedia.org/T78495) (owner: 10Se4598) [08:03:50] (03CR) 10Hoo man: [C: 032] add filter option for local rules only on central wiki [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/181805 (https://phabricator.wikimedia.org/T78495) (owner: 10Se4598) [08:04:38] (03CR) 10Tpt: [C: 031] UserMerge: duplicate array keys in makeList. [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/190724 (https://phabricator.wikimedia.org/T68463) (owner: 10AYUSH GARG) [08:04:52] (03Merged) 10jenkins-bot: add filter option for local rules only on central wiki [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/181805 (https://phabricator.wikimedia.org/T78495) (owner: 10Se4598) [08:05:50] 3MediaWiki-extensions-AbuseFilter: Allow searching for local filters only and global filters only on Meta. - https://phabricator.wikimedia.org/T78495#1042993 (10hoo) 5Open>3Resolved a:3hoo Patch approved [08:10:29] 3WMF-Legal: Clarify concerns about AGPL use - https://phabricator.wikimedia.org/T76158#1042997 (10Nemo_bis) [08:17:14] 3WMF-Legal: Clarify concerns about AGPL use - https://phabricator.wikimedia.org/T76158#1043001 (10Nemo_bis) [08:17:52] 3WMF-Legal: Clarify concerns about AGPL use - https://phabricator.wikimedia.org/T76158#792116 (10Nemo_bis) [08:18:14] 3MediaWiki-General-or-Unknown, WMF-Legal: Clarify concerns about AGPL use - https://phabricator.wikimedia.org/T76158#792116 (10Nemo_bis) [08:19:03] 3MediaWiki-extensions-WikibaseRepository, Wikidata: API function wbsetqualifier blocks frontend - https://phabricator.wikimedia.org/T89698#1043009 (10Lydia_Pintscher) p:5Triage>3Unbreak! [08:19:34] (03CR) 10Hoo man: "Yes, you're supposed to keep both in sync. Also most of the comments should IMO also be copied over as the .php version will go away at so" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/190761 (https://phabricator.wikimedia.org/T87876) (owner: 10Se4598) [08:19:36] 3MediaWiki-extensions-WikibaseRepository, Wikidata: API function wbsetqualifier blocks frontend - https://phabricator.wikimedia.org/T89698#1042981 (10Lydia_Pintscher) Set to unbreak now for investigation to see how bad this is. [08:23:06] (03CR) 10Giuseppe Lavagetto: [C: 032] Make the ini file be installed/linked via the php5enmod/dismod mechanism. [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/190789 (owner: 10Giuseppe Lavagetto) [08:23:27] (03Merged) 10jenkins-bot: Make the ini file be installed/linked via the php5enmod/dismod mechanism. [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/190789 (owner: 10Giuseppe Lavagetto) [08:23:46] (03CR) 10Giuseppe Lavagetto: [C: 032] Make the ini file be installed/linked via the php5enmod/dismod mechanism. [php/luasandbox] - 10https://gerrit.wikimedia.org/r/190794 (owner: 10Giuseppe Lavagetto) [08:24:27] (03Merged) 10jenkins-bot: Make the ini file be installed/linked via the php5enmod/dismod mechanism. [php/luasandbox] - 10https://gerrit.wikimedia.org/r/190794 (owner: 10Giuseppe Lavagetto) [08:36:15] 3MediaWiki-extensions-SpamBlacklist: regex expressions starting with caret (^) not functioning as per instructions say - https://phabricator.wikimedia.org/T66541#1043028 (10seth) Actually the instructions at mw:Extension:SpamBlacklist#Blacklist syntax ~~are~~were wrong, because all blacklisted domains will be... [08:54:33] 3MediaWiki-Uploading, Possible-Tech-Projects, Multimedia: Add support for KML/KMZ filetype - https://phabricator.wikimedia.org/T28059#1043031 (10Qgil) Thank you for the quick feedback. Ok, I will remove the Possible-Tech-Projects tag. Feel free to bring it back if/when this task is a good candidate for GSoC/Outr... [08:54:43] 3MediaWiki-Uploading, Multimedia: Add support for KML/KMZ filetype - https://phabricator.wikimedia.org/T28059#1043032 (10Qgil) [08:55:02] 3MediaWiki-extensions-SpamBlacklist: already used URLs on a page should not trigger spam blacklist - https://phabricator.wikimedia.org/T89699#1043034 (10seth) 3NEW [08:55:24] 3MediaWiki-extensions-Extensions-requests, Possible-Tech-Projects, GlobalPreferences: Global preferences - https://phabricator.wikimedia.org/T16950#1043041 (10Qgil) Thank you for the quick feedback. I will remove this task from Possible-Tech-Projects, then. [08:55:32] 3MediaWiki-extensions-Extensions-requests, GlobalPreferences: Global preferences - https://phabricator.wikimedia.org/T16950#1043042 (10Qgil) [08:55:59] 3MediaWiki-extensions-ContentTranslation, ContentTranslation-Analytics: Represent key metrics in the CX analytics dashboard - https://phabricator.wikimedia.org/T86532#1043045 (10Pginer-WMF) [08:56:01] 3MediaWiki-extensions-ContentTranslation, Language-Engineering, ContentTranslation-Analytics: Rewrite Special:ContentTranslationStats to query common database to make useful - https://phabricator.wikimedia.org/T87709#1043043 (10Pginer-WMF) 5Resolved>3Open > Table for each specific metric (with links to lists... [08:56:57] 3MediaWiki-extensions-WikibaseRepository, Wikidata: API function wbsetqualifier blocks frontend - https://phabricator.wikimedia.org/T89698#1043046 (10hoo) Ok, this is worse than I initially thought... the problem here is the calendar model URL used, it should be /entity/ not /wiki/. But the actual root problem i... [08:58:06] 3Phabricator.org, Phabricator: Phabricator should only notify changes to the "Security" field if it is indeed changed - https://phabricator.wikimedia.org/T87135#1043048 (10Qgil) The Security field is a "custom field" in Phabricator language, and the report should request something like "Custom fields not changin... [09:00:11] 3Math: Math extension unit tests should not attempt to connect to wmflabs.org - https://phabricator.wikimedia.org/T87389#1043051 (10Aklapper) @Physikerwelt: What is "this change"? https://gerrit.wikimedia.org/r/186581/ ? How is that one related to https://gerrit.wikimedia.org/r/189355 which you self-merged? Gene... [09:02:05] (03CR) 10Prtksxna: "I know this is a problem, but I'd really rather see Ie340648 merged. I'll try and see if someone can review it." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/190209 (owner: 10Thiemo Mättig (WMDE)) [09:02:55] 3MediaWiki-extensions-WikibaseRepository, Wikidata: API function wbsetqualifier blocks frontend - https://phabricator.wikimedia.org/T89698#1043053 (10hoo) Example: https://test.wikidata.org/wiki/Special:EntityData/Q68.json (`"calendarmodel":"http://www.foo.bar/wtf"`) [09:03:39] 3MediaWiki-extensions-WikibaseRepository, Wikidata: API function wbsetqualifier blocks frontend - https://phabricator.wikimedia.org/T89698#1043054 (10thiemowmde) I tried but can't reproduce it. What exactly does "something goes wrong" mean? There is really, really not enough information given to do anything for... [09:04:07] 3Math: Math extension unit tests should not attempt to connect to wmflabs.org - https://phabricator.wikimedia.org/T87389#1043056 (10Physikerwelt) The self merged change is on the debug branch. I maintaining this branch to test if the proposed changes interact without problems. [09:05:13] (03CR) 10Prtksxna: [C: 031] "Don't want to self merge." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/146477 (https://phabricator.wikimedia.org/T70039) (owner: 10Se4598) [09:05:31] (03PS2) 10Jhernandez: Hygiene: Fix phpdoc on models\Collection constructor [extensions/Gather] - 10https://gerrit.wikimedia.org/r/190800 [09:05:38] (03CR) 10Jhernandez: Hygiene: Fix phpdoc on models\Collection constructor (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/190800 (owner: 10Jhernandez) [09:07:01] (03CR) 10Florianschmidtwelzow: [C: 031] Hygiene: Fix phpdoc on models\Collection constructor [extensions/Gather] - 10https://gerrit.wikimedia.org/r/190800 (owner: 10Jhernandez) [09:11:52] (03PS7) 10Prtksxna: core: Better article link detection [extensions/Popups] - 10https://gerrit.wikimedia.org/r/146477 (https://phabricator.wikimedia.org/T70039) (owner: 10Se4598) [09:12:41] (03CR) 10Prtksxna: core: Better article link detection (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/146477 (https://phabricator.wikimedia.org/T70039) (owner: 10Se4598) [09:13:31] 3MediaWiki-extensions-WikibaseRepository, Wikidata: API function wbsetqualifier blocks frontend - https://phabricator.wikimedia.org/T89698#1043058 (10Balu) @thiemowmde: it means, that with sending the above string to api.php the frontend isn't usabele anymore. I can't say more. I am only observing this effect. W... [09:13:44] 3Phabricator: Phabricator project display names use awkward capitalization and hyphenation - https://phabricator.wikimedia.org/T911#1043059 (10Aklapper) >>! In T911#1042449, @Qgil wrote: > What do you think? Basically nothing has changed since the last evaluation, hence no reasons to change something. [09:14:31] 3Popups, Wikidata, MediaWiki-extensions-WikibaseRepository: make hover cards work on item links - https://phabricator.wikimedia.org/T69434#1043060 (10Prtksxna) [09:20:21] (03PS20) 10Aaron Schulz: Added WANObjectCache class and made redis/memcached subclasses [core] - 10https://gerrit.wikimedia.org/r/187074 [09:23:18] 3Phabricator: Missing info on T78424 - https://phabricator.wikimedia.org/T89690#1043066 (10Aklapper) 5Open>3stalled It has. It shows > Quiddity created this task.Via Web · Dec 12 2014, 8:21 PM here. If it does not show that for you, please provide a screenshot of the area at the end of the initial comment /... [09:25:57] 3MediaWiki-Interface: Section headings should have some clickable anchor for passing links - https://phabricator.wikimedia.org/T18691#1043070 (10Fomafix) For skin Cologne Blue (https://m4m.wmflabs.org/wiki/Slate?useskin=cologneblue) also the style for the § is missing. Should a inline `style="display:none"` be... [09:29:25] (03PS1) 10Prtksxna: mediawiki.ui: button: Use the correct background color for disabled buttons [core] - 10https://gerrit.wikimedia.org/r/190996 (https://phabricator.wikimedia.org/T88483) [09:30:48] 3GlobalUserPage: Redlink for my username in personal toolbar when using a GlobalUserPage - https://phabricator.wikimedia.org/T85550#1043077 (10Nemo_bis) If it's all or nothing, all blue is better than all red. > What about introducing a new link color meaning "shadow page" (that could also apply to local non-ex... [09:31:18] 3Phabricator: Missing info on T78424 - https://phabricator.wikimedia.org/T89690#1043079 (10Qgil) I don't see it either. {F42387} [09:32:12] 3Phabricator, Phabricator.org: Missing info on T78424 - https://phabricator.wikimedia.org/T89690#1043081 (10Qgil) [09:33:24] 3MediaWiki-extensions-SyntaxHighlight-(GeSHi): Performance issues with SyntaxHighlight under HHVM - https://phabricator.wikimedia.org/T87544#1043083 (10ori) @Jongfeli: Are you OK with using the version from April 2014 for now? I'll prioritize this accordingly. [09:38:05] (03PS1) 10Aaron Schulz: Made BloomFilterTitleHasLogs refresh odds linear to be smoother [core] - 10https://gerrit.wikimedia.org/r/190997 [09:38:35] 3MediaWiki-extensions-ConfirmAccount: ConfirmAccount error: Argument 1 passed to MailAddress::newFromUser() must be an instance of User, string given - https://phabricator.wikimedia.org/T89685#1043088 (10Aklapper) p:5Triage>3High [09:39:27] 3MediaWiki-Categories, Possible-Tech-Projects: Automatic category redirects - https://phabricator.wikimedia.org/T5311#1043091 (10Qgil) @Parent5446, this task is assigned to you. Do you want to work on it or propose it to the next GSoC/Outreachy round? [09:40:12] 3MediaWiki-API: list=alldeletedrevisions gives query (timeout?) error for adrfrom/adrto or adrprefix - https://phabricator.wikimedia.org/T89665#1043093 (10Aklapper) p:5Triage>3Normal [09:42:14] 3MediaWiki-extensions-Extensions-requests, Possible-Tech-Projects: An extension to edit a DocBook documentation on MediaWiki - https://phabricator.wikimedia.org/T63047#1043096 (10Qgil) @Spage, do you think this project fits in our current #documentation efforts? [09:44:54] 3Popups: Finalize on schema for the new instrumentation - https://phabricator.wikimedia.org/T88166#1043101 (10Prtksxna) WARNING: `$.jStorage` is using cookies. Popups has the expiry problem! @leila, thanks for pointing out this problem. I think `ResourceLoader` takes up all `localStorage`. [09:45:03] 3Possible-Tech-Projects, MediaWiki-extensions-ProofreadPage: Merge proofread text back into Djvu files - https://phabricator.wikimedia.org/T59807#1043102 (10Qgil) @Micru, @Aubrey, are you still interested in pursuing this task as a GSoC/Outreachy project? [09:46:25] 3MediaWiki-extensions-Extensions-requests, Possible-Tech-Projects: Automatic analysis of Commons images on accessibility for color-blind - https://phabricator.wikimedia.org/T59806#1043105 (10Qgil) @TheDJ, @hoo, do you think this is a good candidate to become a GSoC/Outreachy project? [09:48:08] 3MediaWiki-extensions-Extensions-requests, Possible-Tech-Projects: Allow smoother and easier Wikimedia Commons pictures discovery - https://phabricator.wikimedia.org/T59805#1043108 (10Qgil) >>! In T59805#633421, @Tgr wrote: > MultimediaViewer is very much a moving target currently, with major refactoring efforts... [09:48:25] 3MediaWiki-extensions-Extensions-requests, Possible-Tech-Projects, Multimedia: Allow smoother and easier Wikimedia Commons pictures discovery - https://phabricator.wikimedia.org/T59805#1043109 (10Qgil) [09:52:40] 3Phabricator, Phabricator.org: Missing info on T78424 - https://phabricator.wikimedia.org/T89690#1043111 (10Aklapper) 5stalled>3Open [09:52:58] 3Phabricator, Phabricator.org: Missing task creation info on T78424 (for non-admins?) - https://phabricator.wikimedia.org/T89690#1043112 (10Aklapper) p:5Triage>3Low [09:54:09] morning andre__ [09:54:16] back to regularly scheduled Prague weather I see [09:54:28] yeah, grey on a grey background [09:55:20] (03PS13) 10devunt: Special:WantedPages only lists page which having at least one red link pointing to it. [core] - 10https://gerrit.wikimedia.org/r/54120 (https://phabricator.wikimedia.org/T19665) [09:56:30] (03CR) 10devunt: "PS13: This is rebase only change. Moved release note to 1.25." [core] - 10https://gerrit.wikimedia.org/r/54120 (https://phabricator.wikimedia.org/T19665) (owner: 10devunt) [09:56:50] * werdna has given up on running MW-vagrant locally [09:57:16] 3Phabricator, Phabricator.org: Missing task creation info on T78424 (for non-admins?) - https://phabricator.wikimedia.org/T89690#1043118 (10Aklapper) p:5Low>3Normal Uhm, "Quiddity added a project: §Collaboration-Team." and everything done before that action (except for task description) is missing indeed whe... [09:57:47] 3MediaWiki-General-or-Unknown: MediaWiki returns Cache-Control: private for all HTTPS requests - https://phabricator.wikimedia.org/T89673#1043122 (10Aklapper) p:5Triage>3Normal [09:59:21] 3MediaWiki-extensions-SpamBlacklist: already used URLs on a page should not trigger spam blacklist - https://phabricator.wikimedia.org/T89699#1043123 (10Aklapper) [09:59:43] 3MediaWiki-extensions-SpamBlacklist: already used URLs on a page should not trigger spam blacklist - https://phabricator.wikimedia.org/T89699#1043034 (10Aklapper) [10:00:04] 3MediaWiki-extensions-WikibaseRepository, Wikidata: API function wbsetqualifier blocks frontend - https://phabricator.wikimedia.org/T89698#1043130 (10thiemowmde) https://github.com/wmde/WikibaseSerializationJavaScript/pull/15 https://github.com/wmde/DataValuesJavascript/pull/62 https://gerrit.wikimedia.org/r/#/c... [10:03:34] 3MediaWiki-API: Expose image thumbs, embedded video players via oEmbed (API + discovery ) - https://phabricator.wikimedia.org/T27854#1043132 (10Nemo_bis) [10:06:44] 3Phabricator: Remove the two-factor authentication code for Negative24 account - https://phabricator.wikimedia.org/T89605#1043133 (10Aklapper) In general we do not advertise using this functionality. Please paste your committed identity (SHA) on your user page. Afterwards, please follow the steps in T87495#1028... [10:06:45] 3Phabricator: Remove the two-factor authentication code for Negative24 account - https://phabricator.wikimedia.org/T89605#1043137 (10Aklapper) [10:06:47] 3Phabricator: Remove the two-factor authentication code for Negative24 account - https://phabricator.wikimedia.org/T89605#1040191 (10Aklapper) [10:06:57] 3Phabricator: Remove the two-factor authentication code for Negative24 account - https://phabricator.wikimedia.org/T89605#1040191 (10Aklapper) [made this task public as there is nothing secret] [10:07:07] 3Phabricator: Remove the two-factor authentication code for Negative24 account - https://phabricator.wikimedia.org/T89605#1043141 (10Aklapper) p:5Normal>3Low [10:07:44] 3MediaWiki-General-or-Unknown: Consider using https://github.com/lipis/flag-icon-css for flag icons - https://phabricator.wikimedia.org/T89669#1043142 (10Aklapper) p:5Triage>3Low [10:08:11] 3MediaWiki-Special-pages: Detects conflicts on delete and move with Special:MovePage - https://phabricator.wikimedia.org/T89671#1043147 (10Aklapper) p:5Triage>3Normal [10:08:46] 3MediaWiki-extensions-Extensions-requests, Possible-Tech-Projects, Multimedia: Allow smoother and easier Wikimedia Commons pictures discovery - https://phabricator.wikimedia.org/T59805#1043148 (10Nemo_bis) This task should probably be repurposed as a series of improvements to the [[https://commons.wikimedia.org/... [10:08:56] 3MediaWiki-Documentation, MediaWiki-API: Give action=query higher billing on api main help page - https://phabricator.wikimedia.org/T89659#1043150 (10Aklapper) p:5Triage>3Volunteer? [10:09:09] 3MediaWiki-Special-pages: Special:MovePage should have page toolbox instead of user toolbar (e.g. What links here) - https://phabricator.wikimedia.org/T89666#1043151 (10Aklapper) p:5Triage>3Low [10:10:13] 3Shop-Theme: [Ipad & Mobile] Lapel Pin page description overlaps footer - https://phabricator.wikimedia.org/T88607#1043152 (10Prtksxna) @Nirzar, I can't remember. Submit a pull request and I'll test if anything breaks. {icon smile-o} [10:10:18] (03CR) 10Aaron Schulz: [C: 032] Don't hardcode {$IP}/images/ as mwstore [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/188349 (https://phabricator.wikimedia.org/T45886) (owner: 10Nemo bis) [10:10:38] 3Possible-Tech-Projects: Multilingual SemanticMediaWiki - https://phabricator.wikimedia.org/T48522#1043153 (10Nemo_bis) Niklas is, Yaron I didn't ask yet. [10:11:40] (03Merged) 10jenkins-bot: Don't hardcode {$IP}/images/ as mwstore [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/188349 (https://phabricator.wikimedia.org/T45886) (owner: 10Nemo bis) [10:12:12] 3MediaWiki-extensions-ConfirmAccount: ConfirmAccount fails where wgUploadDirectory is set to any other path than the default - https://phabricator.wikimedia.org/T45886#1043155 (10Nemo_bis) 5Open>3Resolved Thanks Aaron. [10:13:09] (03PS1) 10Jhernandez: Add unit tests support [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191005 [10:15:03] 3Shop-Theme: [Ipad & desktop] Empty spaces in between products for both - https://phabricator.wikimedia.org/T88606#1043159 (10Prtksxna) @Nirzar Looks good {icon thumbs-o-up}. Submit a pull request? [10:16:36] 3MediaWiki-extensions-ContentTranslation: Suggest articles to translate when the user adds the interlanguage links to a new created article - https://phabricator.wikimedia.org/T89700#1043160 (10Pginer-WMF) 3NEW [10:20:27] If core changes/adds some HTML element, what happens to the skins? Do they all have to update themselves based on core, or does core (including core's css) have to ensure that it doesn't break older versions of skins? [10:21:36] polybuildr: depends where [10:22:13] An element that's styled in skinning/content.css (which some skins don't load, since they have their own). [10:22:19] polybuildr: here's a minimal skin to give you an idea: https://git.wikimedia.org/blob/mediawiki%2Fskins%2FLivingStyleGuide/e2013c80eabb432fe0d309e4b9a2b30dabe23019/templates%2FSkin.template [10:23:00] werdna: Specifically, in this case, I'm adding clickable anchors to section headers. https://phabricator.wikimedia.org/T18691 They're invisible unless the heading is hovered on. [10:23:14] But they show up in skins that have their own skinning/content.css [10:24:31] I would say your best bet is to implement what you want to implement in Vector or whichever skin [10:24:33] and test it in other skins [10:24:38] better than chasing ghosts [10:25:42] Vector loads the core skinning/content.css so it works fine there. [10:26:02] Monobook does too. Doesn't look too good, but works there too. [10:26:10] Modern and CologneBlue, for example, don't. [10:26:21] (03PS1) 10Spage: Add link to Special:ApiSandbox to api.php examples [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/191006 (https://phabricator.wikimedia.org/T89229) [10:26:28] So what's supposed to be hidden shows up there and looks quite broken. [10:26:37] (03CR) 10jenkins-bot: [V: 04-1] Add link to Special:ApiSandbox to api.php examples [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/191006 (https://phabricator.wikimedia.org/T89229) (owner: 10Spage) [10:31:49] 3MediaWiki-extensions-ContentTranslation: Ask users to try the beta feature - https://phabricator.wikimedia.org/T89701#1043171 (10Pginer-WMF) 3NEW [10:32:19] (03PS2) 10Spage: Add link to Special:ApiSandbox to api.php examples [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/191006 (https://phabricator.wikimedia.org/T89229) [10:33:23] 3Wikimedia-General-or-Unknown: Steward, global sysop and SWMT tasks bugs (tracking) - https://phabricator.wikimedia.org/T43492#1043183 (10Billinghurst) [10:33:24] 3MediaWiki-extensions-SpamBlacklist: regex expressions starting with caret (^) not functioning as per instructions say - https://phabricator.wikimedia.org/T66541#1043180 (10Billinghurst) 5Open>3declined a:3Billinghurst per seth's conversation, let it be and work on other things [10:37:36] (03CR) 10Spage: "Change Ib8f0f4a96 adds the links to api.php examples in JavaScript of extension ApiSandbox. It's more code but doesn't pollute core with k" [core] - 10https://gerrit.wikimedia.org/r/189921 (https://phabricator.wikimedia.org/T89229) (owner: 10Spage) [10:39:26] 3MediaWiki-extensions-SyntaxHighlight-(GeSHi): Performance issues with SyntaxHighlight under HHVM - https://phabricator.wikimedia.org/T87544#1043184 (10Jongfeli) @ori yes I am OK with that, no problem. The problem was that the latest version was in the tar download for MW 1.24.1 but that does not seem to be the... [10:47:51] 3Mobile-Apps: "Nearby" feature does not work in Android Wikipedia Beta when language is Armenian and some other languages - https://phabricator.wikimedia.org/T89703#1043195 (10Aschroet) 3NEW [10:51:15] (03PS1) 10Matthias Mullie: Pass title along to signature parser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/191011 (https://phabricator.wikimedia.org/T78424) [10:53:04] 3MediaWiki-extensions-ContentTranslation: Experiment ways to get more users to translate articles - https://phabricator.wikimedia.org/T87867#1043212 (10Pginer-WMF) [10:54:16] (03CR) 10jenkins-bot: [V: 04-1] Pass title along to signature parser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/191011 (https://phabricator.wikimedia.org/T78424) (owner: 10Matthias Mullie) [11:02:46] 3Social-Tools, MediaWiki-extensions-SocialProfile: Upload Avatars Issues - https://phabricator.wikimedia.org/T88913#1043232 (10Aklapper) >>! In T88913#1041317, @HypercaneTeen2 wrote: > anyways I fixed it. @HypercaneTeen2: If some code change happened and was committed, please link to it so others can find the c... [11:03:26] (03CR) 10Phuedx: [C: 032] Fix PHPUnit tests [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/190760 (owner: 10Mattflaschen) [11:04:07] (03CR) 10Phuedx: [C: 032] Update Gemfile.lock [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/190759 (https://phabricator.wikimedia.org/T89539) (owner: 10Mattflaschen) [11:05:08] (03Merged) 10jenkins-bot: Fix PHPUnit tests [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/190760 (owner: 10Mattflaschen) [11:07:02] (03PS6) 10Cenarium: [WIP] Patrolling of tagged changes [core] - 10https://gerrit.wikimedia.org/r/190656 (https://phabricator.wikimedia.org/T89553) [11:07:10] 3MediaWiki-extensions-ContentTranslation: Suggest to translate articles that became featured relevant to the user interests - https://phabricator.wikimedia.org/T89704#1043234 (10Pginer-WMF) 3NEW [11:07:18] (03Merged) 10jenkins-bot: Update Gemfile.lock [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/190759 (https://phabricator.wikimedia.org/T89539) (owner: 10Mattflaschen) [11:07:19] 3Phabricator: Decide on "Needs Volunteer" Priority field value in Phabricator - https://phabricator.wikimedia.org/T78617#1043240 (10Aklapper) Thanks everybody for the comments and input. It sounds like renaming "Needs Volunteer" to "Lowest" is the least controversial. Also at least two teams have expressed that... [11:07:23] 3Phabricator: Decide on "Needs Volunteer" Priority field value in Phabricator - https://phabricator.wikimedia.org/T78617#1043242 (10Aklapper) >>! In T78617#1039914, @jayvdb wrote: > I'd love a "Needs staff" priority That's not a //priority// value and there are already [[https://phabricator.wikimedia.org/projec... [11:07:37] 3MediaWiki-extensions-ContentTranslation: Suggest to translate articles that became featured (and relevant to the user interests) - https://phabricator.wikimedia.org/T89704#1043234 (10Pginer-WMF) [11:10:49] 3MediaWiki-extensions-ContentTranslation: Suggest articles to translate based on on new articles linked to those the user created - https://phabricator.wikimedia.org/T89705#1043245 (10Pginer-WMF) 3NEW [11:11:07] (03PS2) 10Matthias Mullie: Pass title along to signature parser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/191011 (https://phabricator.wikimedia.org/T78424) [11:12:04] (03CR) 10jenkins-bot: [V: 04-1] Pass title along to signature parser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/191011 (https://phabricator.wikimedia.org/T78424) (owner: 10Matthias Mullie) [11:12:52] 3Social-Tools, MediaWiki-extensions-SocialProfile: Upload Avatars Issues - https://phabricator.wikimedia.org/T88913#1043251 (10HypercaneTeen2) I don't have my wiki in github but I can tell you that in the images directory I added the avatars directory. [11:12:56] 3Quality-Assurance, MediaWiki-extensions-GettingStarted: GettingStarted browser tests are broken - https://phabricator.wikimedia.org/T89539#1043252 (10Mattflaschen) 5Open>3Resolved [11:16:24] (03PS3) 10Matthias Mullie: Pass title along to signature parser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/191011 (https://phabricator.wikimedia.org/T78424) [11:18:06]