[00:02:39] (03CR) 10Mattflaschen: [V: 032] Update PageTriage with easy JS fix [core] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/181761 (owner: 10Spage) [00:09:37] (03CR) 10Spage: [C: 032 V: 032] "deploy it to unbreak PageTriage" [core] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/181759 (owner: 10Spage) [00:24:11] Howto on connect to the db via ssh tunneling (say from R) - https://phabricator.wikimedia.org/T85294#943483 (10OrenBochman) 3NEW a:3yuvipanda [00:29:22] kaldari: https://gerrit.wikimedia.org/r/#/c/137168/ [00:31:44] spagewmf: am I correct in assuming that redeploying jquery.migrate would have fixed this problem? [00:32:53] the reason I'm asking is because I'd like to have some guidance for folks who might be stuck fixing a similar problem tomorrow or New Year's or some other grossly inconvenient time. [00:33:48] robla: I'm not sure. PageTriage was getting an input value with attr( 'val' ), which has been the wrong way to do it for several jQuery releases. I don't think jquery.migrate keeps that working, let me check... [00:39:59] robla: I think you're right, jquery.migrate.js kept attr('value') working. Where do migrateWarn() messages go? looks like it should have warned. [00:41:21] spagewmf: thanks for confirming! I'm not sure how the logging works, but with that confirmation, that makes me a little more confident in recommending a revert if we seem to be running into mroe of these. [00:44:03] robla: sure. grepping the extensions shows several calls for attr( 'value' ), but AIUI it's OK to use when building your UI, but not when trying to get the contents of an item. [00:44:24] s/contents/current value/ [00:44:33] robla: spagewmf: it's supposed to be in graphite [00:44:54] but that apparently broke a month ago or so and no one noticed, until timo fixed it recently (see engineering list) [00:47:47] that kinda implies that Timo didn't actually check the logs before removing jquery.migrate.... [00:51:02] (03CR) 10Ricordisamoa: "Is a backport needed?" [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/181414 (owner: 10Ricordisamoa) [00:53:21] robla: it was announced like half a year earlier when it would happen… [00:53:54] yes, but there's a lot of code without active maintainers [00:54:18] that code would break. life's tough [00:54:31] but we should be able to move forward at some point [00:55:31] we don't intentionally break functionality that editors rely on in the name of "moving forward" [00:55:49] MatmaRex: I'm on graphit.wikimedia.org, [Search] tab finds lots of JQMigrate bits, but I'm not sure which corresponds to migrateWarn("jQuery.fn.attr('value') no longer gets properties", "attr-prop"); [00:57:03] (i wasn't following, what broke? i'm not aware of any on-wiki tools that did) [00:57:27] robla: Collaboration team should have been on the ball, MatmaRex: but it helps to place the ball in front of someone with an orange note on it :) [00:57:42] MatmaRex: PageTriage broke [00:58:13] spagewmf: presumably something with 'attr-prop' in it? i'm trying (and failing) to log in to graphite right now [00:59:09] robla: didn't we deploy a fix for that on 6 pm on friday? [00:59:19] fix 1 of 2 [00:59:21] at 6 pm last friday* [00:59:51] spage just deployed fix 2 of 2 (hopefully just 2) [01:01:34] so....I don't want to lay this at Timo's feet. he's done a good job of warning everyone. I'd just like to make sure we keep improving our deprecation practices. [01:03:31] MatmaRex I'm on graphite.wikimedia.org, got a graph of mw.js.deprecate.jsqmigrate.attr_prop.count and .rate, and the count dropped to 0 around December 4. So maybe PageTriage's abuse of val() wasn't caught. [01:03:54] *attr( 'value' ) rather [01:05:05] spagewmf: yes, timo's email mentions this, and asks for help in figuring out why. no one replied [01:05:16] Christian replied, no? [01:05:25] not in my inbox [01:05:41] 3MediaWiki-extensions-WikibaseRepository: Bad dates (like September 31) in some entries - https://phabricator.wikimedia.org/T85296#943503 (10Smalyshev) 3NEW [01:06:16] oh, weird, he only replied on the Analytics list [01:06:45] https://lists.wikimedia.org/pipermail/analytics/2014-December/002974.html [01:07:01] also: https://lists.wikimedia.org/pipermail/analytics/2014-December/002985.html [01:15:34] 3LabsDB-Auditor, Scrum-of-Scrums, MediaWiki-Core-Team, Security-Reviews: Manually verify whitelisted.yaml / graylisted.yaml to ensure completeness - https://phabricator.wikimedia.org/T78730#943509 (10yuvipanda) So they are at: https://github.com/wikimedia/operations-software-labsdb-auditor/blob/master/whiteliste... [01:23:38] 3MediaWiki-API, pywikibot-core, MediaWiki-File-management: FileRepo::getInfo() information is very different depending on the subclass in use for each repo - https://phabricator.wikimedia.org/T85153#943512 (10XZise) Hmm okay from a bot standpoint it's pretty hard to determine the site a repo is actually using. A... [01:31:16] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Better error message if default MW main page already exists - https://phabricator.wikimedia.org/T44913#943514 (10m4tx) I wasn't able to reproduce the bug (Mediawiki 1.25alpha - 1913e2a, Wikibase Repository 0.5 alpha - e340af5). After installing Wikibase and set... [01:33:11] (03CR) 10RobLa: "I think we should consider temporarily reverting this change if there are more problems like T84996, which SPage just deployed a fix for t" [core] - 10https://gerrit.wikimedia.org/r/137168 (owner: 10Jforrester) [01:47:21] (03PS2) 10Hoo man: SpecialPage::execute doesn't return anything [core] - 10https://gerrit.wikimedia.org/r/179950 (owner: 10Thiemo Mättig (WMDE)) [01:47:40] (03CR) 10Hoo man: [C: 032] SpecialPage::execute doesn't return anything [core] - 10https://gerrit.wikimedia.org/r/179950 (owner: 10Thiemo Mättig (WMDE)) [01:53:45] (03Merged) 10jenkins-bot: SpecialPage::execute doesn't return anything [core] - 10https://gerrit.wikimedia.org/r/179950 (owner: 10Thiemo Mättig (WMDE)) [02:03:59] 3MediaWiki-extensions-WikimediaMessages: A missing condition in templates - https://phabricator.wikimedia.org/T75387#943526 (10m4tx) a:3m4tx [02:05:06] 3Mobile-Web: Sign in / Sign up or Log in / Create account - https://phabricator.wikimedia.org/T85190#943529 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson See [02:07:15] (03PS1) 10M4tx: Update CC BY conditions message [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/181776 [02:16:00] 3MediaWiki-Core-Team: Look into Maria 10 parallel-replication - https://phabricator.wikimedia.org/T85266#943535 (10Springle) We've been trialing this, along with multi-source replication, for a few months between sanitarium and labsdb as that's the only place we have MariaDB 10 master and slave, so far. The ide... [02:32:18] (03PS2) 10Gergő Tisza: [WIP] Add Vagrant role for Sentry (server + MW extension) [vagrant] - 10https://gerrit.wikimedia.org/r/181606 [02:32:57] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#943540 (10GOIII) > [[https://gerrit.wikimedia.org/r/151611]] > > [[https://gerrit.wikimedia.org/r/151616]] > > [[https://gerrit.wikimedia.org/r/151203]] > These 3 patches have been re-committed for we... [02:35:37] ori: I have a module for https://gerrit.wikimedia.org/r/#/c/181606/ which executes a script which returns an API key, and I need that key in the vagrant role to configure the extension [02:35:47] do you know of a good way to do that? [02:48:47] tgr: yes, by making a custom fact. there are a bunch of variables in global scope that are not explicitly assigned, but whose value is obtained from facter, which is a library that is bundled with puppet. one of the ways puppet modules can extend puppet is to provide custom "facts" -- basically a global variable that is assigned a value by executing some ruby code on the target node [02:48:57] i can point you to an example; just a sec.. [02:50:46] here's an example from operations/puppet: [02:51:25] by plopping that file in modules//lib/facter, you now magically have a global var, $::physicalcorecount [02:51:57] here's another example which actually calls out to an external api: [02:52:45] calling out to an external API in a fact implementation is a bit creepy, because it's not clear what ought to happen if that call fails [02:52:58] but it's probably the most straightforward way to do what you want [02:53:40] puppet labs has a full walkthrough help document for writing custom facts: [02:54:02] (03PS1) 10Arlolra: Tidy up tidy usage [core] - 10https://gerrit.wikimedia.org/r/181777 [02:56:01] (03CR) 10Arlolra: Tidy up tidy usage (031 comment) [core] - 10https://gerrit.wikimedia.org/r/181777 (owner: 10Arlolra) [02:57:01] ori: from what I understand, facts are read before the catalog is compiled, so a resource cannot create a fact for another resource to use [02:57:32] tgr: where is the script that generates the key? maybe if i took a look i'd understand the requirements better [02:57:56] sorry, I wasn't clear, the script is the 'create sentry project' resource [02:58:11] https://gerrit.wikimedia.org/r/#/c/181606/2/puppet/modules/sentry/manifests/init.pp [02:58:23] https://gerrit.wikimedia.org/r/#/c/181606/2/puppet/modules/sentry/templates/sentry_create_project.py.erb [02:58:57] oh, this could work as a custom function [02:59:24] mm, no, because functions are evaluated on the puppetmaster [02:59:39] actually, no, that's not true [02:59:46] this *would* work as a custom function [02:59:54] (03CR) 10jenkins-bot: [V: 04-1] Tidy up tidy usage [core] - 10https://gerrit.wikimedia.org/r/181777 (owner: 10Arlolra) [03:00:07] where do you need to use the variable? [03:00:11] well, this only makes sense for vagrant, so if it works with a local puppet setup that's good enough [03:00:49] for the proper puppet script that will be used for deployment, it makes no sense to autogenerate groups [03:01:03] the variable is needed in the extension's config file [03:01:17] https://gerrit.wikimedia.org/r/#/c/181606/2/puppet/modules/role/manifests/sentry.pp [03:01:57] tgr: well, that's even easier. you can just do: [03:03:03] mediawiki::extension { 'Sentry': settings => "$wgSentryDsn = file_get_contents('${dsn_file}');" } [03:03:28] that's what I ended up with, but blehh [03:03:43] why blehh? [03:04:13] reading a config file on every PHP initialization seems like a bad practice [03:05:27] but if there is no neat way to do it in puppet, I'll stick with that [03:11:47] tgr: well, it looks like the project key is just a simple hex-encoded UUID4 [03:11:50] see https://github.com/getsentry/sentry/blob/master/src/sentry/models/projectkey.py#L57-66 [03:12:00] it gets autogenerated when the project key is saved if it is not already set [03:12:12] but you can generate it in puppet and pass it as a parameter to your script [03:14:26] tgr: this should work: $dsn = inline_template('<%= require "SecureRandom"; SecureRandom.uuid.tr("-", "") %>') [03:15:54] (03PS1) 10Ricordisamoa: Use defined() instead of constant() [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/181778 [03:17:40] 3UI-Standardization: animating drawing of check mark in checkbox with simple SVG animation - https://phabricator.wikimedia.org/T78372#943547 (10Jaredzimmerman-WMF) @prtksxna this is the other library I was looking for http://snapsvg.io/ [03:17:48] that's a different key [03:18:13] I just set that one to a fixed value since it's stored in the config file [03:18:34] but the one needed for error reporting is compiled from various DB settings [03:19:17] also, if I use a random function in a template, won't that mean that the resource is assumed to have changed after every puppet run? [03:19:35] tgr: yes, you'd have to combine it with a check of some sort [03:19:52] i.e., use it as a parameter to an exec resource's command line, where that exec resource has an unless/onlyif/creates clause [03:20:03] you could also modify the python script to emit php code as output [03:20:06] that's not a bad idea [03:21:21] then you'd have exec { 'generate_sentry_php_settings': command => 'python /foo/sentry-create-project.py --out=php --foo=bar > /vagrant/settings.d/puppet-managed/sentry.php', creates => '/vagrant/settings.d/puppet-managed/sentry.php' } [03:21:24] or something like that [03:22:03] yeah, that would work [03:22:16] 3Wikidata, wikidata-query-service, MediaWiki-Core-Team: Figure out quantity representation - https://phabricator.wikimedia.org/T85298#943549 (10Smalyshev) 3NEW a:3Smalyshev [03:22:39] i'm not sure if being mentioned in a 'creates' clause is enough to make puppet not automatically purge it from puppet-managed, but if not you can create it in the parent directory (settings.d) instead. [03:26:41] (03CR) 10MaxSem: [C: 032] Use defined() instead of constant() [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/181778 (owner: 10Ricordisamoa) [03:31:04] (03Merged) 10jenkins-bot: Use defined() instead of constant() [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/181778 (owner: 10Ricordisamoa) [03:32:39] 3MediaWiki-extensions-Flow, MediaWiki-extensions-PageCuration, MediaWiki-extensions-WikiLove, MediaWiki-extensions-Thanks, MediaWiki-extensions-MoodBar, MediaWiki-extensions-Echo, Collaboration-Team: Audit deployed Collaboration team extensions for jQuery 1.11 upgrade issues - https://phabricator.wikimedia.org/T85... [03:44:36] 3MediaWiki-extensions-Flow, Collaboration-Team: Flow fatal error in feedcontribtuions "Accessing non-existent parameter: page_namespace" - https://phabricator.wikimedia.org/T85299#943559 (10Spage) 3NEW [03:52:28] 3Wikidata, wikidata-query-service, MediaWiki-Core-Team: Figure out quantity representation - https://phabricator.wikimedia.org/T85298#943566 (10Smalyshev) From [[ https://bitbucket.org/magnusmanske/wikidataquery/src/f1667a81c3c693606c519587d6588c7bde8af455/wd_inmem.cpp?at=master#cl-103 | WDQ source ]], WDQ treat... [04:16:52] (03PS3) 10Gergő Tisza: [WIP] Add Vagrant role for Sentry (server + MW extension) [vagrant] - 10https://gerrit.wikimedia.org/r/181606 [04:19:18] (03PS1) 10Gergő Tisza: Rename $wgSentryEndpoint to $wgSentryDsn to better match the docs [extensions/Sentry] - 10https://gerrit.wikimedia.org/r/181779 [04:20:16] (03PS4) 10Gergő Tisza: Add Vagrant role for Sentry (server + MW extension) [vagrant] - 10https://gerrit.wikimedia.org/r/181606 [04:21:09] (03PS2) 10Gergő Tisza: Rename $wgSentryEndpoint to $wgSentryDsn to better match the docs [extensions/Sentry] - 10https://gerrit.wikimedia.org/r/181779 [04:22:08] 3Multimedia, MediaWiki-extensions-MultimediaViewer: MediaViewer should ignore generated captions on special pages - https://phabricator.wikimedia.org/T85234#943575 (10Tgr) 5Open>3Resolved [04:32:41] 3MediaWiki-extensions-MoodBar, Collaboration-Team: Don't use jQuery's live method in MoodBar - https://phabricator.wikimedia.org/T85300#943576 (10Mattflaschen) 3NEW [04:33:19] 3UI-Standardization: Add mediawiki.ui dialogs - https://phabricator.wikimedia.org/T57534#943582 (10Spage) Matt originally wrote: > The new dialogs in GettingStarted can be used as a starting point, but more work is needed Flow has implemented a general-purpose `mw.Modal` in [[ https://github.com/wikimedia/media... [04:35:49] 3Collaboration-Team, MediaWiki-extensions-PageCuration: Buttons requiring a rationale on Curation toolbar appear to be broken - https://phabricator.wikimedia.org/T84996#943583 (10Spage) ori told us to "Just do it", so we backported on Christmas eve. [05:16:06] (03PS1) 1020after4: Use tokenizer in the rule editor ui. Cleanup code slightly. [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/181780 [05:16:33] (03CR) 10Hoo man: [C: 031] "As we now have an index that fits" [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/176366 (owner: 1001tonythomas) [05:16:46] (03Abandoned) 1020after4: Use tokenizer in the rule editor ui. Cleanup code slightly. [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/181780 (owner: 1020after4) [05:18:51] (03PS13) 1020after4: Huge refactor of security policy enforcer stuff. [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/179405 [05:20:03] (03CR) 10tosfos: [C: 04-1] "It seems this was already accomplished by Change-Id: I4b0bfbf02f997971927452114ec5d4ed5a629f90" [extensions/PageNotice] - 10https://gerrit.wikimedia.org/r/178067 (owner: 10Mlawnik) [05:21:01] (03CR) 1020after4: "The problem rush had in testing was that the event listener wasn't configured. This needs the events.listeners setting to be set to "Secur" [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/179405 (owner: 1020after4) [05:23:09] (03CR) 10tosfos: Replace deprecated wfMsg() and friends (031 comment) [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/178066 (owner: 10Mlawnik) [05:34:38] (03PS1) 10tosfos: add to Special Page Group, minor cleanup [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/181781 [05:47:55] (03CR) 10Hoo man: [C: 032] Remove meaningless default action name [core] - 10https://gerrit.wikimedia.org/r/168962 (owner: 10Thiemo Mättig (WMDE)) [05:49:51] 3WikiEditor: EditTool characters slightly outside their boxes in WikiEditor booklet on Wikimedia Commons - https://phabricator.wikimedia.org/T78354#943598 (10GOIII) I'll be damned if I can't figure out how to get it to take - can anyone take it from here? ``` lang=css diff --git a/modules/jquery.wikiEditor.toolb... [05:53:49] (03Merged) 10jenkins-bot: Remove meaningless default action name [core] - 10https://gerrit.wikimedia.org/r/168962 (owner: 10Thiemo Mättig (WMDE)) [05:55:58] (03CR) 10tosfos: [C: 032 V: 032] initial commit [extensions/PaginateText] - 10https://gerrit.wikimedia.org/r/181034 (owner: 10tosfos) [05:57:36] Generators can be iterated over multiple times - https://phabricator.wikimedia.org/T85204#943599 (10jayvdb) [06:21:18] 3MediaWiki-API, pywikibot-core, MediaWiki-File-management: FileRepo::getInfo() information is very different depending on the subclass in use for each repo - https://phabricator.wikimedia.org/T85153#943601 (10Tgr) So to rephrase the task in positive terms, you want to be able to retrieve an API endpoint for the... [06:22:19] now yes, good night everybody, time for get some sleep, merry xmas n_n [06:30:56] (03CR) 10Christopher Johnson (WMDE): [C: 032 V: 032] fixes SprintBoardTaskEditController [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/181729 (owner: 10Christopher Johnson (WMDE)) [07:20:41] 3MediaWiki-extensions-Gadgets: Twinkle stop working on ne.wikipedia.org - https://phabricator.wikimedia.org/T85301#943611 (10biplabanand) 3NEW a:3Krenair [07:41:20] I left a comment on https://phabricator.wikimedia.org/T36952, can somebody please help me out with it? [07:49:09] Hi polybuildr, looking [07:49:32] marktraceur: thanks! Please do let me know if you find something. [07:52:47] polybuildr: Well, the LocalFile implementation uses the field "bits" [07:53:00] So maybe it's that in other File incarnations too [07:53:14] I did take a look at that. [07:54:33] The trouble is in the $this->load [07:54:59] The method involves loading from the db, or from cache [07:55:23] But in the case of an `UnregisteredLocalFile`, I don't think such a field exists. [07:55:49] LocalFile calls load which also sets the `bits` field. [07:55:49] Right [07:59:09] polybuildr: I think LocalFile gets it from the file itself... [08:02:01] polybuildr: You might be able to use ImageHandler::getImageSize's 'img_bits' return value, but you're cutting out a lot of abstraction [08:02:14] Might be better to move some of the calculation code into the base File class. [08:03:10] Well, `File` is abstract, and has only stubs. A recommendation on the bug was that LocalFile and UploadStashFile (child of UnregisteredLocalFile) inherit it from a common parent. [08:04:14] Also, it looked to me like LocalFile was getting it from the db. Where did you see it accessing the file? [08:04:55] polybuildr: All the way in includes/media/ImageHandler.php [08:04:58] It took a while to trace [08:05:26] I looked at ImageHandler too, yesterday, and yeah, it was accessing the file. [08:05:39] But if I jump through all those levels of abstraction and access the file itself.. [08:07:06] From LocalFile to LocalFireleRepo to FSFileRepo to ImageHandler [08:08:22] Might not be a good idea for a bug that was considered easy. Or do I skip the middle layers anyway? [08:10:35] And all that getImageSize is doing is to call PHP's getimagesize. Which basically means that if I use it, it'll be destroying any attempt at abstraction. Seems like a simple enough solution, though. [08:14:00] Yeah... [08:14:16] polybuildr: I'm not sure if you're supposed to heavy-refactor or just ignore the whole middle part and do another getImageSize call [08:14:43] Then I suppose I should comment on phab? [08:15:20] Or should I do a getImageSize call for now and push to gerrit, wait for people to notice and attack? :P [08:17:19] marktraceur ^ [08:17:38] polybuildr: I'd say any or all of those are good plans. [08:18:53] Alright, then. Proceeding. Thanks, again! [08:22:13] marktraceur, would it be alright if I mentioned you in the comment as @marktraceur? [08:22:24] polybuildr: Of course, fine with me [08:22:31] I don't get emails from phabricator anyway [08:24:01] Ha. Okay. :P [08:24:17] 3Multimedia, MediaWiki-File-management: bitdepth of UploadStashFile is wrong - https://phabricator.wikimedia.org/T36952#943619 (10polybuildr) After speaking to @marktraceur on IRC, it seems like the only way to do this directly at the moment is to make a call to `ImageHandler::getFile()` which doesn't seem very... [08:31:11] marktraceur, okay, either I misunderstood you or we both missed something. There's an 'UnregisteredLocalFile::getImageSize` too. [08:31:24] Which has the bits field. [08:40:30] (03CR) 10Nemo bis: [C: 04-1] "* Commit message doesn't explain what the changeset does, among the many possibilities discussed in the task." [core] - 10https://gerrit.wikimedia.org/r/176853 (owner: 10Krinkle) [08:53:25] Rethink #Blocked-on-MediaWiki-Core - https://phabricator.wikimedia.org/T85302#943621 (10Nemo_bis) 3NEW [08:56:12] polybuildr: Well, let's talk in the morning, I'm tired [08:56:17] polybuildr: Good luck though [08:56:29] Submitting a patch now. Will see how things go. Thanks! :) [08:57:06] (03PS1) 10Polybuildr: UnregisteredLocalFile.php: Override File::getBitDepth() stub [core] - 10https://gerrit.wikimedia.org/r/181782 [09:00:27] 3Multimedia, MediaWiki-File-management: bitdepth of UploadStashFile is wrong - https://phabricator.wikimedia.org/T36952#943629 (10polybuildr) a:3polybuildr I seem to have not noticed `UnregisteredLocalFile::getImageSize()` earlier. Returned the `bits` field of that method in the patch. Also, `UnregisteredLoc... [09:05:57] (03PS2) 10Polybuildr: UnregisteredLocalFile.php: Override File::getBitDepth() stub [core] - 10https://gerrit.wikimedia.org/r/181782 [09:09:25] 3Wikimedia-General-or-Unknown: Migrate non-CSS/JS content stored in CSS/JS pages - https://phabricator.wikimedia.org/T85304#943638 (10Nemo_bis) 3NEW a:3Krinkle [09:09:56] 3Wikimedia-General-or-Unknown: Migrate non-CSS/JS content stored in CSS/JS pages - https://phabricator.wikimedia.org/T85304#943638 (10Nemo_bis) [09:12:59] 3Wikimedia-General-or-Unknown: Migrate non-CSS/JS content stored in CSS/JS pages - https://phabricator.wikimedia.org/T85304#943654 (10TTO) We could at least start by doing something about #REDIRECTs. Either make redirect syntax count as "valid JS" for MediaWiki purposes (although obviously `#REDIRECT [[bla]]` sh... [09:30:42] 3MediaWiki-ContentHandler, MediaWiki-JavaScript: Handle existing #REDIRECT CSS/JS pages - https://phabricator.wikimedia.org/T85306#943666 (10Nemo_bis) 3NEW a:3Krinkle [09:47:03] (03PS1) 10Pastakhov: update for PhpTags version 4.0.0 Hook release 6 (v 3.4.0) [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/181783 [09:47:07] (03CR) 10jenkins-bot: [V: 04-1] update for PhpTags version 4.0.0 Hook release 6 (v 3.4.0) [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/181783 (owner: 10Pastakhov) [10:00:58] 3MediaWiki-API, pywikibot-core, MediaWiki-File-management: FileRepo::getInfo() information is very different depending on the subclass in use for each repo - https://phabricator.wikimedia.org/T85153#943676 (10jayvdb) @Tgr, yes, that is about it. pywikibot currently has two main site concepts: 'BaseSite' and sub... [10:43:18] 3MediaWiki-Database: SQL: NULL in an IN-list should be written as OR - https://phabricator.wikimedia.org/T50853#943678 (10blackops0057) I had already started fixing this bug but i guess it has been fixed by someone else :/ [10:47:39] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#943679 (10Paladox) Hi so should I abandon them and then re upload them. [11:07:59] (03CR) 10Nemo bis: [C: 031] Make "account exists" message more user-friendly [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/181751 (owner: 10M4tx) [11:17:32] 3MediaWiki-Interface: Interface messages needing rewording or documentation and other issues with existing messages (tracking) - https://phabricator.wikimedia.org/T40638#943682 (10Nemo_bis) [11:17:35] 3MediaWiki-extensions-WikimediaMessages: A missing condition in templates - https://phabricator.wikimedia.org/T75387#943680 (10Nemo_bis) 5Open>3stalled The scope of this report is not clear, and adequacy of the suggested rewording can't therefore be assessed, because the documentation doesn't state where thi... [11:18:26] (03CR) 10Nemo bis: [C: 04-1] "The change itself may be fine, but we're currently unable to assess: https://phabricator.wikimedia.org/T75387#943680" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/181776 (owner: 10M4tx) [11:22:08] Sigh https://www.mediawiki.org/wiki/User_talk:Dominic [11:24:41] (03PS2) 10Nemo bis: State the format of previews/thumbnails linked from file description [core] - 10https://gerrit.wikimedia.org/r/181749 (owner: 10M4tx) [11:32:36] (03CR) 10Alex Monk: [C: 04-1] State the format of previews/thumbnails linked from file description (032 comments) [core] - 10https://gerrit.wikimedia.org/r/181749 (owner: 10M4tx) [11:36:41] (03CR) 10Nemo bis: "L10n ok; the rest I didn't review in depth, some comments." (035 comments) [core] - 10https://gerrit.wikimedia.org/r/181749 (owner: 10M4tx) [11:52:51] (03PS1) 10Christopher Johnson (WMDE): fix subtask creation problem [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/181784 [11:52:53] (03PS1) 10Christopher Johnson (WMDE): adds SprintUIEventListener [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/181785 [11:54:20] (03CR) 10Christopher Johnson (WMDE): [C: 032 V: 032] fix subtask creation problem [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/181784 (owner: 10Christopher Johnson (WMDE)) [12:01:54] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#943694 (10GOIII) basically yes -- although I suspect you would do better by taking the existing three and separating the changes even further into even more specific patches. Again, this is just from an... [12:02:52] 3MediaWiki-API, pywikibot-core, MediaWiki-File-management: FileRepo::getInfo() information is very different depending on the subclass in use for each repo - https://phabricator.wikimedia.org/T85153#943695 (10XZise) >>! In T85153#943676, @jayvdb wrote: > [...]As an absolute minimum, we need to be able to: > 1.... [12:05:30] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#943696 (10GOIII) On second thought - maybe css to less conversion should be the last patch merged after all the other pieces are in place rather than the first patch. [12:07:39] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#943700 (10Paladox) Hi the reason I created three patches is because someone asked me to create separate patches and then someone asked me to put the patch into one. so I created three patches. should I c... [12:08:28] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#943701 (10Paladox) So I should do the svg images first. and then css to less last. [12:14:45] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#943702 (10Paladox) Hi I will create the first patch with the new svg images excluding the arrow image. and second will include css to less arrow svg images and the new svg images from first reason becaus... [12:16:29] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#943703 (10GOIII) Patch No. # add the svg variants and and any additional png files to the ...images/toolbar directory * nothing should change the current rendering here # edit the current css to use... [12:17:47] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#943711 (10Paladox) Ok. [12:19:58] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#943714 (10Paladox) So I should add svg images and if I have any png files I should add them and I should not edit the css files on first patch but add the svg image to css on the second patch and then la... [12:25:04] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#943719 (10Paladox) I will abandon them patches in a min. I will upload the new patches to make sure they are what your saying to do. thanks for helping. [12:33:11] (03PS1) 10Paladox: Re add svg images. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 [12:33:23] (03PS2) 10Paladox: Re add svg images. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 [12:33:30] (03PS3) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 [12:34:07] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#943727 (10Paladox) Hi this is the first patch https://gerrit.wikimedia.org/r/#/c/181786/ is this what you ment for first patch. [12:35:39] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#943728 (10GOIII) Always abandon AFTER you have replacements up no? >>! In T37342#943714, @Paladox wrote: > So I should add svg images and if I have any png files I should add them and I should not edit... [12:37:14] 3MediaWiki-extensions-LiquidThreads: Thread history shows ghost edit entry: no diff, no contribution, no log entry - https://phabricator.wikimedia.org/T85309#943729 (10Nemo_bis) 3NEW [12:38:14] 3MediaWiki-extensions-LiquidThreads: Thread history shows ghost edit entry: no diff, no contribution, no log entry - https://phabricator.wikimedia.org/T85309#943729 (10Nemo_bis) p:5Volunteer?>3Normal [12:39:05] (03PS4) 10GOIII: Add svg images as a precursor to actively utilizing them [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [12:41:39] (03CR) 10GOIII: "Are the arrow png files any different from the ones currently hosted?" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [12:44:34] (03PS1) 10Paladox: Adds svg to css file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181788 [12:44:50] (03PS2) 10Paladox: Adds svg to css file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181788 [12:45:17] (03PS5) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 [12:46:13] (03CR) 10Paladox: "I got them from vector skin. because that was where svg was and I looked between the one here and the new uploaded one and doesent seem to" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [12:46:44] (03CR) 10GOIII: "and where are all the insert-xxxx svg files?" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [12:46:46] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#943776 (10Paladox) Css file containing svg. https://gerrit.wikimedia.org/r/#/c/181788/ [12:47:56] (03CR) 10Paladox: "Oh sorry I will find them thought they were in them but they are not." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [12:53:33] (03CR) 10GOIII: "I'd remove those arrow-xxx png from this patch. There is difference as far as I can tell and keeping them just goes towards more possible " [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [12:54:37] (03CR) 10GOIII: "I meant ' no difference ' above re: arrow-xxx png files" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [12:56:12] (03PS6) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 [12:56:59] (03CR) 10Paladox: "Hi the arrow.xxx.png is the same as svg. I got them both from vector skin." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [12:58:06] (03CR) 10Paladox: "Hi if you look between https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FWikiEditor/a619f8a09e47ba35ab80720332baed196affd37e/modules" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [13:00:50] (03PS3) 10M4tx: State the format of previews/thumbnails linked from file description [core] - 10https://gerrit.wikimedia.org/r/181749 [13:01:03] (03CR) 10M4tx: State the format of previews/thumbnails linked from file description (034 comments) [core] - 10https://gerrit.wikimedia.org/r/181749 (owner: 10M4tx) [13:01:30] (03CR) 10jenkins-bot: [V: 04-1] State the format of previews/thumbnails linked from file description [core] - 10https://gerrit.wikimedia.org/r/181749 (owner: 10M4tx) [13:01:47] (03PS2) 10Christopher Johnson (WMDE): adds SprintUIEventListener [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/181785 [13:03:18] (03CR) 10Christopher Johnson (WMDE): [C: 032 V: 032] adds SprintUIEventListener [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/181785 (owner: 10Christopher Johnson (WMDE)) [13:05:17] (03PS4) 10M4tx: State the format of previews/thumbnails linked from file description [core] - 10https://gerrit.wikimedia.org/r/181749 [13:07:29] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#943802 (10GOIII) shouldn't `format-italic-i.svg` be `format-italic-I.svg` ? (capital i =I [eye] ) the existing png I think its suppose to replace is `format-italic-I.png` [13:07:32] (03Abandoned) 10Paladox: WikiEditor: Re add SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (owner: 10Paladox) [13:07:49] (03PS7) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 [13:07:59] (03PS3) 10Paladox: Adds svg to css file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181788 [13:10:23] (03CR) 10M4tx: "About JPG vs. JPEG - I added an if condition that checks if the extension is JPG, and if so, it changes the format displayed to JPEG. Whil" [core] - 10https://gerrit.wikimedia.org/r/181749 (owner: 10M4tx) [13:10:27] (03PS8) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 [13:14:51] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#943806 (10Paladox) Please could I have some help to rename it because I try it but it stays at lower case I instead of being uppercase i. [13:20:34] (03PS9) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 [13:20:45] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#943809 (10Paladox) Hi I have managed to do it. [13:25:55] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#943810 (10GOIII) See, this is partly why the previous patches were so hard to follow. With the revised 1st patch just being the addition of the svg variants, the following .png files have no correspondin... [13:27:49] (03PS1) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181790 [13:28:01] (03PS2) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181790 [13:28:39] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#943813 (10Paladox) Hi I have this patch now https://gerrit.wikimedia.org/r/#/c/181790/ that converts .css to .less [13:29:53] (03Abandoned) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (owner: 10Paladox) [13:30:23] (03Abandoned) 10Paladox: WikiEditor: Convert .css to .less and add Arrow SVG images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151616 (owner: 10Paladox) [13:32:28] Use pagegenerators consistently in scripts - https://phabricator.wikimedia.org/T78452#943820 (10jayvdb) [13:32:58] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#943821 (10Paladox) Hi they doint currently have svg images but can be added later. [13:41:11] 3MediaWiki-extensions-Gadgets: Twinkle stop working on ne.wikipedia.org - https://phabricator.wikimedia.org/T85301#943822 (10Krenair) 5Open>3Invalid So you edited some MediaWiki: page on your wiki and stuff broke, and this is a problem with the Gadgets extension somehow? Maybe try asking the gadget's develop... [13:42:58] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#943824 (10GOIII) r151203 had at least `format-olist.svg` listed in it ...but if the svg file variants for all the existing png files are missing some, I doubt anybody would want to merge that so there's... [13:51:01] 3WikiEditor: If Chrome browser zoom set to 90% or less, icon positions too high/low in toolbar - https://phabricator.wikimedia.org/T72679#943828 (10Paladox) The problem could be caused by the size because the svg size is much larger then the png. [13:57:40] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#943830 (10GOIII) >>! In T37342#943824, @GOIII wrote: > ...but if the svg file variants for all the existing png files are missing some, I doubt anybody would want to merge that so there's the first roadb... [14:11:15] Add unit tests for SearchPageGenerator, YahooSearchPageGenerator and GoogleSearchPageGenerator - https://phabricator.wikimedia.org/T85310#943838 (10jayvdb) 3NEW [14:16:07] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#943844 (10Paladox) Do you have the link for svg version of format-olist.svg [14:16:44] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#943845 (10Paladox) There is also a bug with having svg images because if your on chrome and 90% zoomed in the icons go everywhere. [14:18:21] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#943846 (10GOIII) >>! In T37342#943844, @Paladox wrote: > Do you have the link for svg version of format-olist.svg It was part of one your patchsets - https://gerrit.wikimedia.org/r/151203 [14:21:03] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#943847 (10Paladox) Hi the problem started when someone created the images earlier this year. The problem was the reported. [14:30:16] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#943860 (10GOIII) >>! In T37342#943845, @Paladox wrote: > There is also a bug with having svg images because if your on chrome and 90% zoomed in the icons go everywhere. Every example screenshot that I'v... [14:38:11] Add unit tests for YearPageGenerator and DayPageGenerator - https://phabricator.wikimedia.org/T85313#943861 (10jayvdb) 3NEW [14:40:56] Add unit tests for YearPageGenerator and DayPageGenerator - https://phabricator.wikimedia.org/T85313#943867 (10jayvdb) http://www.google-melange.com/gci/task/view/google/gci2014/5876800144015360 [14:43:34] 3MediaWiki-extensions-Gadgets: Twinkle stop working on ne.wikipedia.org - https://phabricator.wikimedia.org/T85301#943869 (10Aklapper) Please ask on-wiki, contact gadget developers, and/or revert your changes for the time being. In any case you will have to provide clear steps when asking for help - "I edited s... [14:46:54] Obnoxious "screen dirt" (alleged unicode art?) in "real name" fields - https://phabricator.wikimedia.org/T85308#943870 (10Aklapper) [14:55:21] Add unit tests for SearchPageGenerator, YahooSearchPageGenerator and GoogleSearchPageGenerator - https://phabricator.wikimedia.org/T85310#943875 (10jayvdb) http://www.google-melange.com/gci/task/view/google/gci2014/5848819103170560 [14:55:24] Good Day :) [14:56:49] Use pagegenerators consistently in scripts - https://phabricator.wikimedia.org/T78452#943877 (10jayvdb) http://www.google-melange.com/gci/task/view/google/gci2014/5868557699121152 [14:57:19] Use pagegenerators consistently in scripts - https://phabricator.wikimedia.org/T78452#943879 (10jayvdb) [14:58:09] Rethink #Blocked-on-MediaWiki-Core - https://phabricator.wikimedia.org/T85302#943881 (10Aklapper) 5Open>3declined a:3Aklapper > I don't know when this tag was created See T78822 > Workboards should be used for this purpose. Please feel free to elaborate in T78822 why you think that the approach proposed b... [15:01:45] (03CR) 10Bartosz Dziewoński: [C: 032] Make "account exists" message more user-friendly [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/181751 (owner: 10M4tx) [15:02:27] 3MediaWiki-Interface: Interface messages needing rewording or documentation and other issues with existing messages (tracking) - https://phabricator.wikimedia.org/T40638#943896 (10matmarex) [15:02:29] 3MediaWiki-extensions-CentralAuth: Replace usage of centralauth-account-exists with userexists - https://phabricator.wikimedia.org/T75123#943892 (10matmarex) 5Open>3Resolved [15:02:43] (03Merged) 10jenkins-bot: Make "account exists" message more user-friendly [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/181751 (owner: 10M4tx) [15:06:43] 3MediaWiki-Change-tagging, MediaWiki-API: Add a way for user scripts and gadgets like Twinkle, AWB, wikEd, OneClickArchiver, etc to add tags to edits made with those tools. - https://phabricator.wikimedia.org/T85314#943899 (10Technical13) 3NEW [15:11:33] 3MediaWiki-Change-tagging, MediaWiki-API: Add a way for user scripts and gadgets like Twinkle, AWB, wikEd, OneClickArchiver, etc to add tags to edits made with those tools. - https://phabricator.wikimedia.org/T85314#943905 (10Se4598) same or related: {T20670} [15:14:39] 3Language-Engineering: Language Engineering team page at mediawiki.org is outdated - https://phabricator.wikimedia.org/T85315#943910 (10santhosh) 3NEW a:3Arrbee [15:16:51] (03CR) 10Bartosz Dziewoński: [C: 032] Add and use Title::getOtherPage() [core] - 10https://gerrit.wikimedia.org/r/177729 (owner: 10Legoktm) [15:22:39] (03Merged) 10jenkins-bot: Add and use Title::getOtherPage() [core] - 10https://gerrit.wikimedia.org/r/177729 (owner: 10Legoktm) [15:23:51] 3Wikimedia-Site-requests: Permanently enabled unregistered users editing on it.m.wikipedia.org - https://phabricator.wikimedia.org/T85317#943923 (10Nemo_bis) 3NEW [15:54:32] Obnoxious "screen dirt" (alleged unicode art?) in "real name" fields - https://phabricator.wikimedia.org/T85308#943946 (10Krenair) 5Open>3Invalid Send a private email for stuff like this. [15:56:21] 3Language-Engineering: Language Engineering team page at mediawiki.org is outdated - https://phabricator.wikimedia.org/T85315#943948 (10KartikMistry) Fixed some via: https://www.mediawiki.org/w/index.php?title=Wikimedia_Language_engineering&oldid=1329908 [16:12:36] 3VisualEditor, MediaWiki-extensions-BetaFeatures: VisualEditor incompatible with "Fixed header" beta feature - https://phabricator.wikimedia.org/T85247#943959 (10matmarex) [17:02:32] (03Abandoned) 10QChris: Allow to get JsonContent data as associative array [core] - 10https://gerrit.wikimedia.org/r/180771 (owner: 10QChris) [17:04:44] (03Abandoned) 10QChris: Remove caching of JsonContent's getData object [core] - 10https://gerrit.wikimedia.org/r/181052 (owner: 10QChris) [17:08:31] (03Abandoned) 10QChris: Follow MediaWiki's move from getJsonData to getData [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/180778 (owner: 10QChris) [17:12:22] 3MediaWiki-extensions-AbuseFilter: Allow filtering by local and global hits on Special:AbuseLog - https://phabricator.wikimedia.org/T85323#943981 (10Glaisher) 3NEW [17:17:20] 3MediaWiki-extensions-AbuseFilter: Allow filtering by local and global hits on Special:AbuseLog - https://phabricator.wikimedia.org/T85323#943987 (10Glaisher) Also while we're at it, can we have the filtering by local & global filters option available on centralwiki's Special:AbuseFilter? It's [[ https://meta.wi... [17:19:37] 3DataValues: DataValue Time recognizes the ISO date value not very well in Korean language. - https://phabricator.wikimedia.org/T85324#943989 (10Kwj2772) 3NEW [17:20:10] 3MediaWiki-extensions-AbuseFilter: Allow filtering by local and global hits on Special:AbuseLog - https://phabricator.wikimedia.org/T85323#943995 (10Se4598) IIRC from a recently discussion the wiki-field in the log-table is NULL for local hits (on the central wiki), thus inserting any value for the central wiki... [17:21:09] 3MediaWiki-extensions-AbuseFilter: Allow filtering by local and global hits on Special:AbuseLog - https://phabricator.wikimedia.org/T85323#943998 (10Se4598) >>! In T85323#943987, @Glaisher wrote: > Also while we're at it, can we have the filtering by local & global filters option available on centralwiki's Speci... [17:25:50] 3MediaWiki-extensions-AbuseFilter: Allow filtering by local and global hits on Special:AbuseLog - https://phabricator.wikimedia.org/T85323#944001 (10Glaisher) >>! In T85323#943995, @Se4598 wrote: > IIRC from a recently discussion the wiki-field in the log-table is NULL for local hits (on the central wiki), thus... [17:47:48] 3Wikimedia-Site-requests: Permanently enabled unregistered users editing on it.m.wikipedia.org - https://phabricator.wikimedia.org/T85317#944005 (10Nemo_bis) [17:48:02] 3Wikimedia-Site-requests: Permanently enable unregistered users editing on it.m.wikipedia.org - https://phabricator.wikimedia.org/T85317#944007 (10Nemo_bis) [17:50:34] Obnoxious "screen dirt" (alleged unicode art?) in "real name" fields - https://phabricator.wikimedia.org/T85308#944008 (10Nemo_bis) 5Invalid>3Open This is a perfectly valid task, similar to T1180. Intervention by admins may be needed. [17:58:18] 3Wikimedia-General-or-Unknown: MediaWiki pages edited by non-sysop registered users in Commons via TranslatePostInitGroups - https://phabricator.wikimedia.org/T85325#944013 (10Nemo_bis) 3NEW [18:06:44] 3MediaWiki-Patrolling, MediaWiki-Watchlist: Remove show/hide patrolled edits from watchlists if patrolling is disabled - https://phabricator.wikimedia.org/T76054#944019 (10Cenarium) Actually, it doesn't work for new pages : edits creating a new page that is not yet patrolled are shown even if patrolled edits are... [18:21:52] (03PS1) 10Se4598: add missing title-param to abusefilter-log form [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/181793 [18:22:06] Obnoxious "screen dirt" (alleged unicode art?) in "real name" fields - https://phabricator.wikimedia.org/T85308#944024 (10Jorm) It's Zalgo text, high-unicode. I'm not going to change it. This is ridiculous. [18:22:29] Obnoxious "screen dirt" (alleged unicode art?) in "real name" fields - https://phabricator.wikimedia.org/T85308#944025 (10Jorm) 5Open>3declined [18:23:30] (03PS2) 10Se4598: add missing title-param to abusefilter-log form [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/181793 [18:24:52] (03PS1) 10Sn1per: Replace deprecated wfMsg* [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/181794 [18:30:20] (03CR) 10Hoo man: [C: 04-1] add missing title-param to abusefilter-log form (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/181793 (owner: 10Se4598) [18:35:00] (03CR) 10Se4598: add missing title-param to abusefilter-log form (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/181793 (owner: 10Se4598) [18:35:39] (03CR) 10Florianschmidtwelzow: [C: 031] "Just a little thing to get rid of the use of parser :)" (031 comment) [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/181794 (owner: 10Sn1per) [18:35:59] (03PS1) 10Se4598: Allow searching for local hits on central wiki [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/181795 [18:36:37] (03CR) 10Hoo man: add missing title-param to abusefilter-log form (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/181793 (owner: 10Se4598) [18:38:07] 3MediaWiki-extensions-AbuseFilter: Allow filtering by local and global hits on Special:AbuseLog - https://phabricator.wikimedia.org/T85323#944029 (10Se4598) >>! In T85323#944027, @gerritbot wrote: > Change 181795 had a related patch set uploaded (by Se4598): this does the easy approach as accepting the value th... [18:38:45] (03CR) 10Florianschmidtwelzow: "seems so" [extensions/PageNotice] - 10https://gerrit.wikimedia.org/r/178067 (owner: 10Mlawnik) [18:40:56] (03CR) 10Florianschmidtwelzow: [C: 04-1] Replace deprecated wfMsg() and friends (032 comments) [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/178066 (owner: 10Mlawnik) [18:50:25] 3MediaWiki-User-login-and-signup, MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension): Captcha positioning is inconsistent between JavaScript and non-JavaScript users - https://phabricator.wikimedia.org/T85192#944032 (10Sumit) The js styles the fancy captcha and then moves it down. I think we can retain the sty... [18:52:08] hoo: getPrefixedText() or getPrefixedDBkey() ? [18:53:00] db key [18:53:37] ok [18:53:46] und: Fröhliche Weihnachten, hoo :) [18:53:55] Danke, dir auch :) [18:55:27] (03CR) 10tosfos: Replace deprecated wfMsg* (032 comments) [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/181794 (owner: 10Sn1per) [18:55:59] (03PS3) 10Se4598: add missing title-param to abusefilter-log form [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/181793 [18:57:43] Ask a question,I install a mediawiki,but the page has some problems,for example,the login page,the text should show login but show " ",has some one the problem [18:57:59] (03PS4) 10Se4598: add missing title-param to abusefilter-log form [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/181793 [18:59:44] (03CR) 10Se4598: "should be fixed now" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/181793 (owner: 10Se4598) [19:00:55] hi FlorianSW [19:02:55] by html list do you mean like a bulleted list? [19:03:05] im not sure exactly what duplicator outputs, lemme try that [19:03:37] 3MediaWiki-User-login-and-signup, MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension): Captcha positioning is inconsistent between JavaScript and non-JavaScript users - https://phabricator.wikimedia.org/T85192#944038 (10Sumit) or else we can display the captcha just before submit,as it appears when js enabled,... [19:07:32] (03PS2) 10Ori.livneh: [WIP] Add client API [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/181769 [19:17:00] hi GEOFBOT [19:17:35] yes, that is what i mean :) wikisyntax "*" will be a bullet list :) [19:21:44] 3MediaWiki-extensions-AbuseFilter: article_recent_contributors leaks revdeleted user names - https://phabricator.wikimedia.org/T71367#732423 (10Krenair) [19:43:29] (03PS2) 10Sumit: Added a parenthetical to fileextensions description in api help at meta=siteinfo&siprop=fileextensions [core] - 10https://gerrit.wikimedia.org/r/181364 [19:46:38] 3MediaWiki-API: Tweak MediaWiki API siteinfo siprop fileextensions description text - https://phabricator.wikimedia.org/T62121#944055 (10Sumit) Changed the description text here: https://gerrit.wikimedia.org/r/#/c/181364/ [19:58:19] FlorianSW: OK, thanks [20:00:41] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Add "copy to clipboard" button to share/embed fields - https://phabricator.wikimedia.org/T77295#944058 (10Tgr) Needs an icon. Could use [[ https://github.com/mojombo/clippy/tree/master/assets | the one from clippy ]] - doesn't really match the Wikimedia design... [20:01:18] FlorianSW: also, when switching from wfMessage() to $this->msg(), do I need to keep the additional arguments? [20:02:54] GEOFBOT: yep, that are arguments used to parse the message :) E.g. the message "Hello $1" with wfMessage( 'key', 'Florian' )-text(); will result in "Hello Florian" :) [20:03:14] ok, thanks :D [20:03:26] SpecialPage::msg() ist just a wrapper for wfMessage with the advantage, that the actual ContextSource object is used :) [20:06:24] 3VisualEditor-MediaWiki, VisualEditor, MediaWiki-extensions-EducationProgram: Links to existing pages in the Education Program namespaces are marked as red links - https://phabricator.wikimedia.org/T72123#944063 (10Krenair) [20:10:29] 3MediaWiki-extensions-EducationProgram: Remove EducationProgram rights from sysop - https://phabricator.wikimedia.org/T75416#944064 (10Krenair) Could we also pull sysops' MediaWiki namespace edit rights while we're at it? They shouldn't have that either. [20:14:06] (03PS2) 10Sn1per: Replace deprecated wfMsg* [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/181794 [20:14:09] (03CR) 10jenkins-bot: [V: 04-1] Replace deprecated wfMsg* [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/181794 (owner: 10Sn1per) [20:14:11] FlorianSW: ^^ [20:14:32] honestly I haven't written an ounce of like actual PHP so I probably screwed up somewhere [20:14:58] GEOFBOT: let me write some comments :) [20:15:09] thankd :D [20:17:15] 20:14:09 PHP Parse error: syntax error, unexpected T_OBJECT_OPERATOR in Duplicator.page.php on line 127 [20:17:16] GEOFBOT, ^ [20:17:46] you wrote this->msg instead of $this->msg [20:18:24] woops [20:19:12] :) [20:19:46] thanks :P [20:19:52] GEOFBOT, you know how to pick those error messages out of the test failures right? [20:20:01] i think so [20:20:03] Jenkins-bot is (usually) useful [20:20:13] (03PS3) 10Sn1per: Replace deprecated wfMsg* [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/181794 [20:20:31] when it fails, click the link on the failed test. Sometimes you'll need an extra 'full console' link or something like that. [20:20:49] ok [20:21:03] the relevant lines here are between the php -l call, which starts the php syntax check, and when it says php exited [20:21:28] 3MediaWiki-Uploading: Insufficient protection against overwriting files - https://phabricator.wikimedia.org/T85098#944066 (10Tgr) Or maybe the tutorials and instructions should be less showy :) [20:21:35] hooray no failure this time [20:21:39] :) [20:22:05] (03CR) 10Florianschmidtwelzow: Replace deprecated wfMsg* (034 comments) [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/181794 (owner: 10Sn1per) [20:22:09] Since we're in the context of a SpecialPage, could we not use $this->msg here? [20:22:31] GEOFBOT: i have added my comments to patchset 2 :) [20:22:32] for the calls in buildForm, I mean [20:22:39] (03CR) 10tosfos: [C: 04-1] "This is a terrific and timely improvement. Comments are mainly nitpicks. Thank you!" (038 comments) [extensions/googleAnalytics] - 10https://gerrit.wikimedia.org/r/175309 (owner: 10DavisNT) [20:32:08] (03PS4) 10Sn1per: Replace deprecated wfMsg* and inelegant HTML [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/181794 [20:36:24] (03CR) 10Florianschmidtwelzow: [C: 04-1] Replace deprecated wfMsg* and inelegant HTML (034 comments) [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/181794 (owner: 10Sn1per) [20:46:35] (03CR) 10Krinkle: "Why did arrow-down.png, arrow-ltr.png and arrow-rtl.png change? If this is intentional, please document the change in the commit message. " [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [20:51:05] (03PS5) 10Sn1per: Replace deprecated wfMsg* and inelegant HTML [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/181794 [20:53:36] 3MediaWiki-Uploading, Multimedia: Uppercase picture extensions like .PNG are not allowed - https://phabricator.wikimedia.org/T68667#944073 (10Tgr) [20:54:19] (03CR) 10Florianschmidtwelzow: [C: 04-1] Replace deprecated wfMsg* and inelegant HTML (033 comments) [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/181794 (owner: 10Sn1per) [20:57:13] 3MediaWiki-extensions-MultimediaViewer, Multimedia: "monthname, year" dates are not recognized - https://phabricator.wikimedia.org/T59307#944074 (10Tgr) 5Open>3declined a:3Tgr Per T68635, date parsing should happen in the API, not in the client. [20:57:21] 3MediaWiki-General-or-Unknown: Link to anti-spam measures from the default mainpage - https://phabricator.wikimedia.org/T85327#944079 (10Ciencia_Al_Poder) 3NEW [21:00:33] (03PS6) 10Sn1per: Replace deprecated wfMsg* and inelegant HTML [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/181794 [21:03:03] 3Multimedia, MediaWiki-File-management: Uppercase picture extensions like .PNG are not allowed - https://phabricator.wikimedia.org/T68667#944085 (10Ciencia_Al_Poder) [21:31:04] (03CR) 10Florianschmidtwelzow: [C: 04-1] Replace deprecated wfMsg* and inelegant HTML (032 comments) [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/181794 (owner: 10Sn1per) [21:33:18] (03PS1) 10Se4598: add filter option for local rules only on central wiki [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/181805 [21:37:09] hoo: like to start a AbuseFilter review marathon? :D https://gerrit.wikimedia.org/r/#/q/owner:se4598+status:open+project:mediawiki/extensions/AbuseFilter,n,z [21:37:41] I will probably later on :) [21:37:53] Do you plan to attend the 31C3, btw? [21:37:56] ho ho ho [21:38:38] (03CR) 10Se4598: "I'm not sure if "Both" is the best choice of word. "All" would also kind of match." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/181805 (owner: 10Se4598) [21:38:57] no [21:40:40] (03PS7) 10Sn1per: Replace deprecated wfMsg* and inelegant HTML [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/181794 [21:40:51] (03PS2) 10Se4598: Allow searching for local hits on central wiki [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/181795 [21:55:12] (03CR) 10Paladox: "I just added them from vector skin since there were svg images there and just in case there were any difference I added the png from there" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (owner: 10Paladox) [21:55:45] 3MediaWiki-extensions-Gadgets: Add a functionality to gray out gadgets on gadgets preference tab that are dependent on other gadgets. - https://phabricator.wikimedia.org/T55584#944104 (10Technical13) >>! In T55584#581617, @matmarex wrote: > The BetaFeatures extension implements something similar, maybe it could... [21:59:04] 3MediaWiki-User-preferences: Broken custom signatures should return "Invalid raw signature. Check HTML tags." error and use default. - https://phabricator.wikimedia.org/T51695#944105 (10Technical13) p:5Low>3Normal It wouldn't hurt if this validated as HTML5 as well. [22:02:40] (03PS1) 10Aaron Schulz: Added MapCacheLRU::getAllKeys() method [core] - 10https://gerrit.wikimedia.org/r/181806 [22:02:59] 3MediaWiki-Change-tagging, MediaWiki-API: Add a way for user scripts and gadgets like Twinkle, AWB, wikEd, OneClickArchiver, etc to add tags to edits made with those tools. - https://phabricator.wikimedia.org/T85314#944107 (10Technical13) p:5Volunteer?>3Normal [22:08:46] 3MediaWiki-extensions-CommonsMetadata, Multimedia: CommonsMetadata should parse EXIF dates - https://phabricator.wikimedia.org/T66014#944110 (10Tgr) GCI task at https://www.google-melange.com/gci/task/edit/google/gci2014/5803886094843904 [22:34:52] urgh [22:35:20] Extension:Collection uses action=ajax [22:37:01] no sajax though [22:41:48] (03PS3) 10Ori.livneh: Add a simple client API [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/181769 [22:43:21] (03PS4) 10Ori.livneh: Add a simple client API [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/181769 [22:44:00] (03PS5) 10Ori.livneh: Cleanup DatabaseBase::query implicit transaction code [core] - 10https://gerrit.wikimedia.org/r/180702 (owner: 10Aaron Schulz) [22:44:06] (03CR) 10Ori.livneh: [C: 032] Cleanup DatabaseBase::query implicit transaction code [core] - 10https://gerrit.wikimedia.org/r/180702 (owner: 10Aaron Schulz) [22:44:21] (03CR) 10Ori.livneh: [C: 032] Add a simple client API [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/181769 (owner: 10Ori.livneh) [22:50:02] (03Merged) 10jenkins-bot: Cleanup DatabaseBase::query implicit transaction code [core] - 10https://gerrit.wikimedia.org/r/180702 (owner: 10Aaron Schulz) [22:50:07] (03Merged) 10jenkins-bot: Add a simple client API [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/181769 (owner: 10Ori.livneh) [23:44:01] 3MediaWiki-skins-Vector: Search box is too small - https://phabricator.wikimedia.org/T85329#944128 (10Whatamidoing-WMF) 3NEW [23:44:46] 3MediaWiki-Change-tagging, MediaWiki-API: Add a way for user scripts and gadgets like Twinkle, AWB, wikEd, OneClickArchiver, etc to add tags to edits made with those tools. - https://phabricator.wikimedia.org/T85314#944134 (10Legoktm) [23:44:48] 3MediaWiki-Change-tagging: Create ability to add / remove tags from edits / actions - https://phabricator.wikimedia.org/T20670#944135 (10Legoktm) [23:53:18] 3MediaWiki-extensions-CommonsMetadata, Multimedia: Parse