[00:02:40] 3MediaWiki-extensions-Sentry, Multimedia: Implement module wrapping for Sentry - https://phabricator.wikimedia.org/T78809#942620 (10Tgr) [00:11:09] 3UI-Standardization: Create primary button with indeterminate loader - https://phabricator.wikimedia.org/T72417#942621 (10Jaredzimmerman-WMF) I like these (especially the text change, to explain to the user whats happening, I do worry about the translations, if the strings get really long, Initially I was thinki... [00:15:03] 3UI-Standardization: Create primary button with indeterminate loader - https://phabricator.wikimedia.org/T72417#942623 (10Nirzar) @Jaredzimmerman-WMF the last one (refresh) uses the loading animation that's being used for media viewer, I believe that's the one @Pginer-WMF made [00:15:15] 3MediaWiki-extensions-Flow: Could not create UserTuple for workflow_user_ - https://phabricator.wikimedia.org/T73858#942624 (10Spage) p:5High>3Normal This is still happening in my local DB when I visit the Flow board Talk:Main_Page or the problem topic Topic:Rm0bhqmo6cweo5m8 The $row passed to Flow\Model\Po... [00:20:25] 3UI-Standardization: Create primary button with indeterminate loader - https://phabricator.wikimedia.org/T72417#942630 (10Jaredzimmerman-WMF) @nirzar this is the one I think we're trying to synchronize on {T75972} [00:26:47] (03PS1) 10Alex Monk: Make a VirtualRESTService class for Parsoid [core] - 10https://gerrit.wikimedia.org/r/181706 [00:27:00] 3UI-Standardization: Create primary button with indeterminate loader - https://phabricator.wikimedia.org/T72417#942637 (10violetto) @Jaredzimmerman-WMF In English, noun to verb is often as easy as adding -ing. Other languages might not be so convenient and the text can grow from one word to five. I generally l... [00:27:53] Krenair: \o/ [00:27:58] 3MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-WikibaseRepository: Properties linking to Commons pages are not updated automatically when the page is moved - https://phabricator.wikimedia.org/T85257#942638 (10SJu) 3NEW [00:30:10] 3UI-Standardization: Create primary button with indeterminate loader - https://phabricator.wikimedia.org/T72417#942646 (10Jaredzimmerman-WMF) @violetto yeah thats what I was thinking, we could keep the button bounds and either switch to the neutral/disabled state with the animation centered where the text was, o... [00:30:21] 3Mobile-Web: Drawers are not fixed to the bottom of the page anymore - https://phabricator.wikimedia.org/T85258#942647 (10bmansurov) 3NEW [00:31:33] 3MediaWiki-extensions-VectorBeta: Echo flyout does not openon some pages when Compact Personal Bar is enabled - https://phabricator.wikimedia.org/T66862#942663 (10Jaredzimmerman-WMF) [00:34:31] 3Mobile-Web: Drawers are not fixed to the bottom of the page anymore - https://phabricator.wikimedia.org/T85258#942667 (10bmansurov) [00:35:22] 3MediaWiki-extensions-WikibaseRepository: Reciprocal Wikidata properties don't work really as reciprocal - https://phabricator.wikimedia.org/T85259#942669 (10SJu) 3NEW [00:36:17] 3Mobile-Web: Drawers are not fixed to the bottom of the page anymore - https://phabricator.wikimedia.org/T85258#942675 (10Jdlrobson) So in summary this only effects font changer and WikiGrokDialogC so not as big a concern as I thought straight away [00:37:16] (03PS1) 10Kaldari: Adding PHP mustache parser (lightncandy) [vendor] - 10https://gerrit.wikimedia.org/r/181708 [00:37:18] (03CR) 10jenkins-bot: [V: 04-1] Adding PHP mustache parser (lightncandy) [vendor] - 10https://gerrit.wikimedia.org/r/181708 (owner: 10Kaldari) [00:40:56] 3UI-Standardization: Create primary button with indeterminate loader - https://phabricator.wikimedia.org/T72417#942678 (10Nirzar) My only concern with 3-dot indicator is, it cannot adapt for determinate loading. in case of tiny progress bar in button or striped animation, there is a obvious adaptation for determ... [00:42:42] 3MediaWiki-ContentHandler, MediaWiki-JavaScript: Run a basic JavaScript syntax check when user/site JavaScript pages are saved - https://phabricator.wikimedia.org/T76204#942679 (10Jdforrester-WMF) Ping. What is there left to do here? Is a warning in Tech/News sufficient? [00:43:22] gwicke, ori: I realised that I didn't test the proxy stuff and that it won't actually do anything [00:43:42] (03CR) 10Jforrester: [C: 031] "+1 from Product perspective; however, we may wish to hold off on merging this before merging and do an announcement in the next Tech/News " [core] - 10https://gerrit.wikimedia.org/r/176853 (owner: 10Krinkle) [00:44:44] (03CR) 10Legoktm: [C: 04-1] "Needs rebase? Was this not created against master?" [vendor] - 10https://gerrit.wikimedia.org/r/181708 (owner: 10Kaldari) [00:45:03] (03CR) 10Legoktm: "Blah. T75440" [vendor] - 10https://gerrit.wikimedia.org/r/181708 (owner: 10Kaldari) [00:47:03] (03PS2) 10Kaldari: Adding PHP mustache parser (lightncandy) [vendor] - 10https://gerrit.wikimedia.org/r/181708 [00:47:16] (03CR) 10jenkins-bot: [V: 04-1] Adding PHP mustache parser (lightncandy) [vendor] - 10https://gerrit.wikimedia.org/r/181708 (owner: 10Kaldari) [00:47:32] (03PS3) 10Kaldari: Adding PHP mustache parser (lightncandy) [vendor] - 10https://gerrit.wikimedia.org/r/181708 [00:47:50] (03CR) 10jenkins-bot: [V: 04-1] Adding PHP mustache parser (lightncandy) [vendor] - 10https://gerrit.wikimedia.org/r/181708 (owner: 10Kaldari) [00:48:21] 3MediaWiki-Parser: Provide a parser function to create links to the wiki which don't look external - https://phabricator.wikimedia.org/T68746#942681 (10Jdlrobson) Another way we might look at this bug is think about updating the parser so that [http://currenthost/Special:Userlogin?type=signup signup] actually ge... [00:49:27] (03PS4) 10Kaldari: Adding PHP mustache parser (lightncandy) [vendor] - 10https://gerrit.wikimedia.org/r/181708 [00:49:34] (03CR) 10jenkins-bot: [V: 04-1] Adding PHP mustache parser (lightncandy) [vendor] - 10https://gerrit.wikimedia.org/r/181708 (owner: 10Kaldari) [00:50:06] 3UI-Standardization: Create primary button with indeterminate loader - https://phabricator.wikimedia.org/T72417#942682 (10violetto) @nirzar, what we can do is: For indeterminate loading, it uses an animation similar to 3-dot indicator. For determinate loading, we use a numbered percentage indication. The goa... [00:50:12] (03CR) 10Jforrester: [C: 031] Omit frontend and browsertest development files from release [tools/release] - 10https://gerrit.wikimedia.org/r/180118 (owner: 10Krinkle) [00:56:54] (03CR) 10Springle: "If double precision is enough here for our purposes, then ok. But if in doubt, use DECIMAL." [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/180704 (owner: 10MaxSem) [01:03:11] (03CR) 10Alex Monk: [C: 04-2] "Very much a work in progress still" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/181706 (owner: 10Alex Monk) [01:05:38] (03PS5) 10Kaldari: Adding PHP mustache parser (lightncandy) [vendor] - 10https://gerrit.wikimedia.org/r/181708 [01:09:46] (03PS6) 10Kaldari: Adding PHP mustache parser (lightncandy) [vendor] - 10https://gerrit.wikimedia.org/r/181708 [01:13:07] 3MediaWiki-extensions-Flow: Flow rendering can drop text in a header edit - https://phabricator.wikimedia.org/T66692#942691 (10Spage) 5Open>3Resolved a:3Spage This bug has long been fixed by changes to the Flow front-end. [01:15:52] 3Mobile-Web: No footer border in alpha on special pages - https://phabricator.wikimedia.org/T85251#942694 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson [01:22:55] 3Mobile-Web: Delay when rendering main menu - https://phabricator.wikimedia.org/T85253#942698 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson [01:25:46] (03CR) 10Legoktm: "lightncandy uses the file autoloader instead of classmap which means it gets loaded on every request. I submitted https://github.com/zordi" [vendor] - 10https://gerrit.wikimedia.org/r/181708 (owner: 10Kaldari) [01:29:17] (03CR) 10Legoktm: [C: 04-1] "Also there needs to be either a commit to core or a WMF-deployed extension adding this as a dependency, see the process at https://www.med" [vendor] - 10https://gerrit.wikimedia.org/r/181708 (owner: 10Kaldari) [01:42:27] (03PS1) 10GWicke: Update cassandra-driver once more [services/restbase/deploy] - 10https://gerrit.wikimedia.org/r/181711 [01:42:37] (03CR) 10GWicke: [C: 032 V: 032] Update cassandra-driver once more [services/restbase/deploy] - 10https://gerrit.wikimedia.org/r/181711 (owner: 10GWicke) [02:09:44] 3Collaboration-Team, MediaWiki-extensions-Flow: Flow boards and topics have no footer-info area, thus lack copyright msg - https://phabricator.wikimedia.org/T66619#942700 (10Spage) p:5Triage>3Normal [02:13:22] 3MediaWiki-extensions-Flow: Flow pages are dissimilar from regular pages (tracking) - https://phabricator.wikimedia.org/T85260#942705 (10Spage) 3NEW [02:18:14] 3Collaboration-Team, MediaWiki-extensions-Flow: Flow boards and topics have no footer-info area, thus lack copyright msg - https://phabricator.wikimedia.org/T66619#942711 (10Spage) I'm not sure what generates the footer-info or its content such as copyright. FWIW other content models/types have a footer-info di... [02:34:16] 3Collaboration-Team, MediaWiki-extensions-Flow: Flow: no "Redirected from" on Flow pages. - https://phabricator.wikimedia.org/T60763#942720 (10Spage) >>! In T60763#645199, @matthiasmullie wrote: > I stay on the page that should redirect, but get the flow board of the page it should redirect to. MediaWiki #REDIR... [02:36:24] 3MediaWiki-extensions-Flow: Flow pages are dissimilar from regular pages (tracking) - https://phabricator.wikimedia.org/T85260#942721 (10Spage) [02:39:31] 3MediaWiki-extensions-Sentry, Multimedia, MediaWiki-ResourceLoader: Create ResourceLoader hook to add new startup modules - https://phabricator.wikimedia.org/T85262#942722 (10Tgr) 3NEW a:3Tgr [02:42:42] 3MediaWiki-extensions-Sentry, Multimedia, MediaWiki-ResourceLoader: Create ResourceLoader hook to add new startup modules - https://phabricator.wikimedia.org/T85262#942730 (10Tgr) [02:49:23] 3MediaWiki-extensions-Sentry, Multimedia, MediaWiki-ResourceLoader: Create ResourceLoader hook to wrap module code - https://phabricator.wikimedia.org/T85263#942732 (10Tgr) 3NEW a:3Tgr [02:49:37] 3MediaWiki-extensions-Sentry, Multimedia, MediaWiki-ResourceLoader: Create ResourceLoader hook to add new startup modules - https://phabricator.wikimedia.org/T85262#942740 (10Tgr) [02:52:15] Krinkle|detached: RoanKattouw_away: can you look at the two tasks here ^^ and tell me if they are sane? I would start working on them if you think they make sense. [03:00:57] 3Multimedia: Create basic puppet role for Sentry - https://phabricator.wikimedia.org/T84956#942743 (10Tgr) [03:06:04] (03CR) 10Parent5446: [C: 04-1] "Unless it's being used in core, it shouldn't be in core." [core] - 10https://gerrit.wikimedia.org/r/181706 (owner: 10Alex Monk) [03:07:23] (03CR) 10Parent5446: [C: 031] Add and use Title::getOtherPage() [core] - 10https://gerrit.wikimedia.org/r/177729 (owner: 10Legoktm) [03:07:45] (03PS1) 10Christopher Johnson (WMDE): Fixes breaking upstream change 'Maniphest - introduce needProjectPHIDs' [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/181716 [03:27:24] 3Multimedia: Create basic puppet role for Sentry - https://phabricator.wikimedia.org/T84956#942750 (10Tgr) Missing packages (from comparing Sentry's [[ https://github.com/getsentry/sentry/blob/master/setup.py | setup.py ]] with the results of `aptitude search˙on an MW-Vagrant box): * [[ https://pypi.python.org/p... [03:31:03] 3§ Phabricator-Sprint-Extension: Sprint Extension Raise Error with the newest Phabricator - https://phabricator.wikimedia.org/T85060#942751 (10Christopher) FYI: This is also an unresolved upstream problem. Check it here https://secure.phabricator.com/maniphest/report/project/ Warning: https://secure.phabricat... [03:33:13] 3§ Phabricator-Sprint-Extension: Sprint Extension Raise Error with the newest Phabricator - https://phabricator.wikimedia.org/T85060#942755 (10Christopher) p:5Triage>3High [04:26:00] 3MediaWiki-User-login-and-signup: Landing page for password reset should link to the login screen - https://phabricator.wikimedia.org/T85063#942760 (10Glaisher) Looks like returnto link is used by some extensions for various stuff. Perhaps it would be best if we add a link to the message above it. [04:35:44] 3ContentTranslation-Deployments, Language-Engineering, MediaWiki-extensions-ContentTranslation: Setup Varnish on Beta (and Production) for cxserver - https://phabricator.wikimedia.org/T76200#942765 (10KartikMistry) [05:15:09] 3MediaWiki-extensions-Collection: Unable to save collection after changing its content (the save button is disabled) - https://phabricator.wikimedia.org/T62574#942768 (10Phoenix303) Hi Everyone! I could not find "Collection" link in Special Pages but there is "Book" link. Does Collection has been replaced by Boo... [05:19:22] (03CR) 10Arlolra: "@Jackmcbarn: can you suggest an approach to tackling this?" [core] - 10https://gerrit.wikimedia.org/r/181519 (owner: 10Arlolra) [05:26:19] (03CR) 10Jackmcbarn: "What do you want the output from {{urlencode:
two
}} to be?" [core] - 10https://gerrit.wikimedia.org/r/181519 (owner: 10Arlolra) [05:26:23] (03CR) 10Legoktm: [C: 04-1] "Also wondering about the use case." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/181558 (owner: 10Daniel Kinzler) [05:45:10] (03CR) 10Arlolra: "The output of," [core] - 10https://gerrit.wikimedia.org/r/181519 (owner: 10Arlolra) [05:56:38] (03CR) 10Jackmcbarn: "That's tricky. Urlencode would have to expand its input with PPFrame::NO_TAGS to make that feasible, but that solution wouldn't work for {" [core] - 10https://gerrit.wikimedia.org/r/181519 (owner: 10Arlolra) [06:07:23] (03CR) 10Arlolra: "I would think the expected behaviour is that all the nested expansions would happen, and then you'd urlencode the output." [core] - 10https://gerrit.wikimedia.org/r/181519 (owner: 10Arlolra) [06:12:08] (03CR) 10Jackmcbarn: "The problem with that is the output of {{Special:AllPages}} is a general strip marker, which we can't unstrip for security reasons. (And w" [core] - 10https://gerrit.wikimedia.org/r/181519 (owner: 10Arlolra) [06:15:13] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Re-implement uniqueness constraint in a consistent and efficient way - https://phabricator.wikimedia.org/T74430#942772 (10JeroenDeDauw) Calling this fingerprint is confusing, since we already use that word for a different concept. (Do point out how evil this is... [06:25:09] (03CR) 10Arlolra: "Ok, sounds like I need to go understand that exploit before commenting further." [core] - 10https://gerrit.wikimedia.org/r/181519 (owner: 10Arlolra) [06:44:24] 3MediaWiki-extensions-ContentTranslation: Translation dashboard does not display pages recently published - https://phabricator.wikimedia.org/T85264#942774 (10Arrbee) 3NEW [07:14:34] (03CR) 10Jackmcbarn: "Dropping the content would be fine, and is probably the "best" thing to do (other than what we do now). It's not really feasible to do the" [core] - 10https://gerrit.wikimedia.org/r/181519 (owner: 10Arlolra) [08:42:53] (03CR) 10Mr. Stradivarius: "Thank you! Will do. By the way, what are the other tests that you need to do?" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/181408 (owner: 10Mr. Stradivarius) [09:07:10] (03CR) 10Hashar: [C: 04-1] "Some annoying typo :-D" (033 comments) [tools/release] - 10https://gerrit.wikimedia.org/r/180118 (owner: 10Krinkle) [09:16:55] 3operations: Puppetize ircyall & set up instance appropriately - https://phabricator.wikimedia.org/T1357#942788 (10fgiunchedi) what's left on this? [09:24:48] 3Multimedia, Wikimedia-Media-storage: Apply Transfer-encoding: gzip to SVG files from upload.wikimedia.org - https://phabricator.wikimedia.org/T56291#942793 (10fgiunchedi) from Krinkle, see also https://gerrit.wikimedia.org/r/#/c/113687/ [09:26:22] 3Multimedia, Wikimedia-Media-storage: Apply Transfer-encoding: gzip to SVG files from upload.wikimedia.org - https://phabricator.wikimedia.org/T56291#942796 (10fgiunchedi) [09:35:47] 3operations: Puppetize ircyall & set up instance appropriately - https://phabricator.wikimedia.org/T1357#942805 (10yuvipanda) No logrotate, but I guess that's something I should add to the package. [09:49:26] (03CR) 1001tonythomas: "Might be good to go now after https://gerrit.wikimedia.org/r/#/c/181626/ ?" [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/176366 (owner: 1001tonythomas) [09:50:13] 3operations, Wikimedia-General-or-Unknown: HTTP/1.1 compliance of bits.wikimedia.org/.../load.php - https://phabricator.wikimedia.org/T30345#942808 (10fgiunchedi) +BBlack still reproducible, is it varnish though? also the refresh: header in this case is wrong ``` $ nc bits.wikimedia.org 80 << EOF > GET http://... [09:52:51] 3MediaWiki-extensions-Popups, Language-Engineering, MediaWiki-extensions-ContentTranslation: Gray bar on top of Special:CX - https://phabricator.wikimedia.org/T76718#942810 (10Pginer-WMF) It seems that #hovercards (a.k.a Hovercards) is adding a div with id=mwe-popups-svg which pushes content down, and affects Co... [09:55:33] 3operations, Wikimedia-General-or-Unknown: Run EventLogging test to determine best DC for each country - https://phabricator.wikimedia.org/T55497#942813 (10fgiunchedi) might be less of an issue with the ripe atlas work and geodns, does it still make sense? [09:57:13] 3operations, Wikimedia-General-or-Unknown: thumbs from Special:VipsTest sometimes fail - https://phabricator.wikimedia.org/T56751#942815 (10fgiunchedi) is still still an issue? [10:03:12] 3Wikimedia-General-or-Unknown, operations: Update Malayalam fonts packages - https://phabricator.wikimedia.org/T33950#942817 (10fgiunchedi) version in trusty is 2.5.3, appservers are upgraded to trusty because of hhvm now so we could do it if still needed ``` mw1018:~$ apt-cache policy fonts-lohit-mlym fonts-lo... [10:10:49] 3Wikimedia-General-or-Unknown, operations: [OPS] Puppet script for LaTeXML - https://phabricator.wikimedia.org/T56034#942826 (10fgiunchedi) latexml is in trusty, anything else that operations could do here? ``` $ apt-cache policy latexml latexml: Installed: (none) Candidate: 0.7.0-1 Version table: 0.... [10:12:08] 3operations, Wikimedia-Language-setup: Rename "be-x-old" to "be-tarask" - https://phabricator.wikimedia.org/T11823#942828 (10fgiunchedi) anything for operations to do here? [10:20:26] 3Wikimedia-General-or-Unknown, operations: Package texvc and distribute that way - https://phabricator.wikimedia.org/T47076#942830 (10fgiunchedi) 5Open>3Resolved a:3fgiunchedi so this is fixed in our apt repo for mediawiki-math-texvc, e.g. ``` mw1040:~$ apt-cache policy mediawiki-math-texvc mediawiki-math... [10:22:19] 3Mobile-Web: Create a browser module and split browser.js into smaller files - https://phabricator.wikimedia.org/T85213#942833 (10Jhernandez) Yeah I think right now it is not very big and it seems a premature optimization to me. I've voted too. Could we remove the uploads code and remove it from the code base?... [10:22:59] 3operations, Wikimedia-Language-setup: Rename "be-x-old" to "be-tarask" - https://phabricator.wikimedia.org/T11823#942834 (10Reedy) >>! In T11823#942828, @fgiunchedi wrote: > anything for operations to do here? Not really atm... Part of this is working out how to "rename" the database. Or more likely, hack arou... [10:23:28] 3Wikimedia-General-or-Unknown, operations: mobile users can be redirected to a non-existent www.m.project.org domain - https://phabricator.wikimedia.org/T59132#942836 (10fgiunchedi) 5Open>3Resolved a:3fgiunchedi I think we've fixed this: ``` $ curl -vsL -A ANDROID https://wikipedia.org/wiki/foo 2>&1 >/dev... [10:27:29] 3Wikimedia-General-or-Unknown, operations: security@mediawiki.org : Create a public key and publish it on the public key servers - https://phabricator.wikimedia.org/T40860#942839 (10fgiunchedi) a:3csteipp Chris, I've tentatively assigned this to you, let operations know if you need support [10:36:40] 3UI-Standardization: Create primary button with indeterminate loader - https://phabricator.wikimedia.org/T72417#942842 (10Pginer-WMF) Regarding the use of text, it is true that [[ https://translatewiki.net/w/i.php?title=Special:Translations&message=Wikimedia%3AWikipedia-android-strings-edit+done%2Fen | "save" ]]... [10:50:31] 3ContentTranslation-Deployments, Language-Engineering: Review request for a cookie usage in ContentTranslation - https://phabricator.wikimedia.org/T85130#942843 (10santhosh) Thanks. I think we can use a cookie name pattern as cx_Title_FromLang_TargetLang that will never have sufix as Session or Token [10:55:54] (03PS18) 1001tonythomas: Prune old bounce records [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/176366 [11:03:15] Hello, everyone. I'm looking to contribute to MediaWiki and though I've worked on several personal projects before, this will be my first open source contribution. [11:03:36] I've found a bug that I know how to fix. [11:04:33] https://phabricator.wikimedia.org/T35192 [11:05:01] I have fixed this locally, but I need some help figuring out how to submit this. [11:05:25] polybuildr: yay :) [11:05:57] Well, the simplest way is for you to attach a patch to the bug [11:06:11] But if you're gonna be making more changes, getting setup for gerrit would be preferable [11:06:15] What are you stuck with? [11:06:30] I've already registered and cloned from Gerrit. [11:06:58] That's half the battle [11:07:09] Oh, I see. :P [11:07:23] Yes, I do plan to make further contributions, assuming everything goes well. [11:07:48] So how far have you actually got? What are you stuck on? [11:08:34] This particular bug could be fixed in two ways. One is a suggestion on the bug's thread to simply trim out all leading and trailing whitespace. The other, which is the one I've chosen, is to only strip trailing newlines. [11:08:45] Based on the assumption that a more specific solution is probably safer. [11:09:42] And I've looked at Phabricator and Gerrit but at the moment, I am completely lost with respect to how I should actually submit this. [11:10:22] You can use git review if you want [11:10:49] Or, if you're more familiar with vanilla git [11:10:49] (03PS2) 10Christopher Johnson (WMDE): Fixes breaking upstream change 'Maniphest - introduce needProjectPHIDs' [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/181716 [11:10:49] git push origin HEAD:refs/for/master [11:11:09] So, just push? [11:11:28] you need the special bit at the end [11:11:46] Oh, there's a further issue. MediaWiki itself is cloned from gerrit, but the bug is in VisualEditor's JS. [11:12:14] Well, you need to clone the VE repo then [11:12:41] wait, the bug is in mediawiki.feedback.js right? [11:12:47] Yes, it is. [11:12:49] that's in core [11:12:58] it just happens to be used by VE [11:13:07] Oh, I see. My bad. [11:13:46] So then first commit my change in core's repo and then push. Is that right? [11:14:15] yup, pretty much [11:14:29] Make sure you reference the task in the commit summary so the bot links it for you [11:14:33] (03PS3) 10Christopher Johnson (WMDE): Fixes breaking upstream change 'Maniphest - introduce needProjectPHIDs' [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/181716 [11:14:51] 3Wikimedia-Etherpad, operations: Enable tags on Etherpad - https://phabricator.wikimedia.org/T32240#942846 (10fgiunchedi) do we still want this? my vote is "no" on the basis that we shouldn't provide incentives for more etherpad usage other than a scratchpad [11:16:56] So, I've done a git pull. 31 files were changed. Reading commit message guidelines before committing. [11:17:51] 3operations, Datasets-General-or-Unknown: dumps.wikimedia.org seems super-slow right now - https://phabricator.wikimedia.org/T45647#942848 (10fgiunchedi) 5Open>3Resolved dataset1001 network is fine, unlikely this is still an issue http://ganglia.wikimedia.org/latest/?r=month&cs=&ce=&m=cpu_report&c=Miscellan... [11:19:21] (03PS4) 10Christopher Johnson (WMDE): Fixes breaking upstream change 'Maniphest - introduce needProjectPHIDs' [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/181716 [11:22:35] (03CR) 10Bartosz Dziewoński: [C: 032] "Let's fiddle with the lurking dudes later." [core] - 10https://gerrit.wikimedia.org/r/181529 (owner: 10Jdlrobson) [11:22:50] (03PS5) 10Christopher Johnson (WMDE): Fixes breaking upstream change 'Maniphest - introduce needProjectPHIDs' [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/181716 [11:23:15] 3Wikimedia-General-or-Unknown, operations: texvc failure due to missing MW cgroup - https://phabricator.wikimedia.org/T57709#942852 (10fgiunchedi) looks like this might be resolved? repeating the google search shows 30 results, I spot-checked some and they look like real edits talking about the issue [11:23:44] 3Mobile-Web, MediaWiki-User-login-and-signup: Login form password reset and account creation form inconsistent between desktop and mobile - https://phabricator.wikimedia.org/T85189#942854 (10matmarex) 5Open>3Resolved p:5Triage>3Normal a:3Jdlrobson [11:23:45] 3Mobile-Web: [Tracking] Getting rid of own login page - https://phabricator.wikimedia.org/T74910#942858 (10matmarex) [11:25:46] 3Wikimedia-General-or-Unknown, operations: Updating Whois records, still show Leslie Carr - https://phabricator.wikimedia.org/T63433#942859 (10fgiunchedi) 5Open>3Resolved a:3fgiunchedi old/fixed ``` $ whois 2620:0:860::/46 | grep -i carr $ ``` [11:27:10] (03PS1) 10Polybuildr: mediawiki.feedback.js: Remove trailing newlines from message [core] - 10https://gerrit.wikimedia.org/r/181723 [11:27:28] polybuildr: whee :D [11:28:13] 3Wikimedia-General-or-Unknown, operations: COPYING is served as application/octet-stream - https://phabricator.wikimedia.org/T63903#942865 (10fgiunchedi) [11:28:22] Okay, had an issue with a missing Change-Id. Fixed that. Successfully pushed. :D [11:28:23] (03Merged) 10jenkins-bot: Consolidate mobile and desktop designs for login form [core] - 10https://gerrit.wikimedia.org/r/181529 (owner: 10Jdlrobson) [11:28:39] 3Wikimedia-General-or-Unknown, operations: COPYING is served as application/octet-stream - https://phabricator.wikimedia.org/T63903#942868 (10fgiunchedi) 5Open>3Resolved a:3fgiunchedi old/fixed ``` $ curl -sI https://en.wikipedia.org/w/COPYING | grep -i content-type Content-Type: text/html; charset=utf-8 ``` [11:28:43] Reedy, thanks! [11:28:59] MatmaRex, what happens next? [11:29:17] 3§ Phabricator-Sprint-Extension: Sprint Extension Raise Error with the newest Phabricator - https://phabricator.wikimedia.org/T85060#942872 (10Christopher) The SprintProjectProfileController and the route overrides from SprintApplication have been removed in favor of leaving the button for Workboard (even on Spr... [11:29:42] (03CR) 10Bartosz Dziewoński: mediawiki.feedback.js: Remove trailing newlines from message (032 comments) [core] - 10https://gerrit.wikimedia.org/r/181723 (owner: 10Polybuildr) [11:30:06] polybuildr: i commented on the patch ^ [11:31:44] (03CR) 10Christopher Johnson (WMDE): [C: 032 V: 032] Fixes breaking upstream change 'Maniphest - introduce needProjectPHIDs' [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/181716 (owner: 10Christopher Johnson (WMDE)) [11:31:46] 3Wikimedia-General-or-Unknown: Mobile Main Page outdated before logging in - https://phabricator.wikimedia.org/T50062#942873 (10fgiunchedi) [11:32:53] MatmaRex, sorry, but where exactly do I see your comment on https://gerrit.wikimedia.org/r/#/c/181723/ ? [11:33:32] oh duh, i forgot how awful the UI is [11:33:44] click on the "resources/src/mediawiki/mediawiki.feedback.js" file name [11:33:50] Okay, I've received an e-mail with the comment. Still can't seem to locate it in the web interface. [11:33:57] Oh. [11:34:17] Oh, wonderful. [11:34:21] Right, found it. [11:34:59] Yes, fair enough. I'll fix the coding style. Also will do it in both places. [11:35:15] MatmaRex: Stripping only the trailing newlines seems fair, or should I just trim()? [11:35:20] 3MediaWiki-Core-Team: Look into Maria 10 parallel-replication - https://phabricator.wikimedia.org/T85266#942877 (10aaron) 3NEW [11:35:29] stripping trailing sounds reasonable to me [11:35:32] 3MediaWiki-Core-Team: Look into Maria 10 parallel-replication - https://phabricator.wikimedia.org/T85266#942877 (10aaron) [11:36:14] Alright. Also, now do I amend my previous commit and push again, or do I make a new commit and push? [11:37:22] (03CR) 10TTO: "It'd be nicer to trim the start of the string as well. See https://test.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#Graham" [core] - 10https://gerrit.wikimedia.org/r/181723 (owner: 10Polybuildr) [11:37:26] amend and push [11:39:04] (03CR) 10Polybuildr: "What if someone wanted to start their message with a space, though?" [core] - 10https://gerrit.wikimedia.org/r/181723 (owner: 10Polybuildr) [11:39:48] (03CR) 10TTO: "Why would you? I can't think of a reason why. The dialog doesn't even tell you the message is treated as wikitext..." [core] - 10https://gerrit.wikimedia.org/r/181723 (owner: 10Polybuildr) [11:40:48] 3Wikimedia-General-or-Unknown, operations: [gdash] "(cdn) HTTP Error Rate" would use log scale for 5xx errors - https://phabricator.wikimedia.org/T43754#942887 (10fgiunchedi) looks like this is much better now? https://gdash.wikimedia.org/dashboards/reqerror/ [11:41:59] (03CR) 10Polybuildr: "Well, not saying it's interpreted as wikitext looks like a shortcoming to me, to be honest. Also, so we basically disallow preformatted te" [core] - 10https://gerrit.wikimedia.org/r/181723 (owner: 10Polybuildr) [11:43:39] (03CR) 10TTO: "If you want preformatted text on the first line for some weird reason, use 
. There's no point supporting use cases that no one is eve" [core] - 10https://gerrit.wikimedia.org/r/181723 (owner: 10Polybuildr)
[11:45:38] 	 (03CR) 10Polybuildr: "Hmm. If you're confident about it being a very rare use case, I'll just trim." [core] - 10https://gerrit.wikimedia.org/r/181723 (owner: 10Polybuildr)
[11:48:48] 	 (03PS2) 10Polybuildr: mediawiki.feedback.js: Trim whitespace from message and subject [core] - 10https://gerrit.wikimedia.org/r/181723 
[11:49:54] 	 polybuildr: The code change in PS2 is the same as PS1
[11:49:55] 	 3CirrusSearch: metrics for search latency disappeared from search dashboard - https://phabricator.wikimedia.org/T85267#942891 (10fgiunchedi) 3NEW
[11:50:01] 	 Perhaps you forgot to `git add`
[11:50:12] 	 or if using gui, Stage Changed
[11:50:21] 	 Uh oh. Yeah, forgot to git add.
[11:50:52] 	 3Wikimedia-General-or-Unknown, operations: wikimedia [[Special:Search]] randomly slow - https://phabricator.wikimedia.org/T44425#942897 (10fgiunchedi) I think we can safely close this with lsearchd out of the way and cirrussearch running 100% of the traffic (see T85267 though as search latency metrics disappeared)
[11:50:59] 	 (03PS3) 10Polybuildr: mediawiki.feedback.js: Trim whitespace from message and subject [core] - 10https://gerrit.wikimedia.org/r/181723 
[11:51:02] 	 3Wikimedia-General-or-Unknown, operations: wikimedia [[Special:Search]] randomly slow - https://phabricator.wikimedia.org/T44425#942901 (10fgiunchedi) 5Open>3Resolved a:3fgiunchedi
[11:52:16] 	 3UI-Standardization: Create primary button with indeterminate loader - https://phabricator.wikimedia.org/T72417#942903 (10Pginer-WMF) >>! In T72417#942678, @Nirzar wrote: > My only concern with 3-dot indicator is, it cannot adapt for determinate loading.   In many cases the indeterminate version is adapted to fi...
[11:53:10] 	 (03CR) 10TTO: [C: 04-1] "We still support IE8 which doesn't support the trim() function. Not sure if the mediawiki libraries or jQuery have a trim function somewh" [core] - 10https://gerrit.wikimedia.org/r/181723 (owner: 10Polybuildr)
[11:53:19] 	 MatmaRex: ^^
[11:53:24] 	 do we have a trim functon in a library somewhere?
[11:53:34] 	 or do we just roll our own regex every time?
[11:53:53] 	 jQuery.trim does exist.
[11:54:35] 	 ah, that would be the one to use then
[11:55:12] 	 just FYI, the page https://www.mediawiki.org/wiki/Compatibility shows which browsers MediaWiki supports
[11:55:15] 	 On it.
[11:55:47] 	 3Wikimedia-Etherpad, operations: Enable tags on Etherpad - https://phabricator.wikimedia.org/T32240#942904 (10akosiaris) My vote is also "no", but more on the basis that no software/plugin exists that does what is described in this ticket. Please correct me if I am wrong though.
[11:58:16] 	 (03PS4) 10Polybuildr: mediawiki.feedback.js: Trim whitespace from message and subject [core] - 10https://gerrit.wikimedia.org/r/181723 
[11:58:56] 	 (03CR) 10TTO: [C: 031] mediawiki.feedback.js: Trim whitespace from message and subject [core] - 10https://gerrit.wikimedia.org/r/181723 (owner: 10Polybuildr)
[12:02:02] 	 tto: Anything else that I should do?
[12:02:21] 	 polybuildr: Looks fine to me, good work :)
[12:03:15] 	 tto: A couple of questions. Firstly, I didn't make a new branch for these edits. Should I have?
[12:03:26] 	 No, best to amend on the same branch
[12:03:49] 	 You mean, when you first did it? It's good practice, otherwise you need to reset head
[12:03:57] 	 but you can change/set the branch via the gerrit interface too
[12:05:25] 	 So now for any other patches that I submit for core, I'll have to reset head. But if it had been a branch, then I could have made a different branch from master for a different patch. Right?
[12:06:11] 	 Yup
[12:07:01] 	 Alright. Thanks! So now I wait to see if this patch gets accepted, and meanwhile move on to something else?
[12:07:07] 	 Yeah
[12:07:28] 	 go forth and spam gerrit!
[12:07:30] 	 Where do I find out if it gets accepted?
[12:07:36] 	 (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.feedback.js: Trim whitespace from message and subject [core] - 10https://gerrit.wikimedia.org/r/181723 (owner: 10Polybuildr)
[12:07:37] 	 You'll get an email
[12:07:58] 	 it just got accepted. ;)
[12:07:59] 	 polybuildr: ^ it just did :P
[12:08:46] 	 Oh. Awesome. :P
[12:08:52] 	 3MediaWiki-Interface: [mediawiki.feedback.js] Signature is sometimes displayed as preformatted text - https://phabricator.wikimedia.org/T35192#942911 (10matmarex) 5Open>3Resolved a:3blackops0057
[12:09:06] 	 Anything that needs to be updated at https://phabricator.wikimedia.org/T35192 ?
[12:09:09] 	 Oh. That's done too.
[12:09:12] 	 Cool.
[12:09:49] 	 MatmaRex: I think you just assigned the task to blackops0057.
[12:09:58] 	 lol.
[12:10:27] 	 Who is not me. :P
[12:10:27] 	 polybuildr: um, i assumed that's you. i guess that's not you? :D sorry
[12:10:41] 	 3MediaWiki-Interface: [mediawiki.feedback.js] Signature is sometimes displayed as preformatted text - https://phabricator.wikimedia.org/T35192#380478 (10matmarex) a:5blackops0057>3polybuildr
[12:11:21] 	 Fixed. Thanks. :)
[12:13:18] 	 (03Merged) 10jenkins-bot: mediawiki.feedback.js: Trim whitespace from message and subject [core] - 10https://gerrit.wikimedia.org/r/181723 (owner: 10Polybuildr)
[12:14:01] 	 First merge. :')
[12:14:22] 	 Someone should've probably added you to patch contributors ;)
[12:15:41] 	 (03PS1) 10Christopher Johnson (WMDE): fixes SprintBoardTaskEditController [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/181729 
[12:15:45] 	 Reedy, where, exactly? Gerrit, Phabricator? :P
[12:16:15] 	 Gerrit
[12:16:34] 	 I see.
[12:16:43] 	 there's the CREDITS file
[12:16:44] 	 look at the CREDITS file :)
[12:16:50] 	 but it's not really maintained, heh
[12:17:05] 	 MatmaRex: RfC!
[12:20:53] 	 3MediaWiki-Interface: Interface messages needing rewording or documentation and other issues with existing messages (tracking) - https://phabricator.wikimedia.org/T40638#942921 (10m4tx)
[12:20:54] 	 3MediaWiki-extensions-Flow: "Add Message" must be replaced by direct quotation of relevant button - https://phabricator.wikimedia.org/T69972#942918 (10m4tx) 5Open>3Invalid a:3m4tx It looks like the message was removed in Ibb77ba1321ddaf4269bffa1f5881f679f7ebd9e3.
[12:21:07] 	 Reedy, a few more noob questions. There are credentials for Phabricator, Gerrit, a shell username for Gerrit, a login for MediaWiki... how many different ways is someone identified by? o.O
[12:21:19] 	 heh
[12:21:39] 	 So, for phabricator you can use your gerrit or your mediawiki.org credentials
[12:27:07] 	 Reedy, okay. afaik, I'm using mediawiki.org credentials. Which LDAP creds is phabricator talking about?
[12:27:18] 	 ldap is gerrit/wikitech
[12:28:16] 	 (03PS1) 10Reedy: Add use statement for type used in MWLoggerMonologSamplingHandler::setFormatter() [core] - 10https://gerrit.wikimedia.org/r/181730 
[12:28:24] 	 Whoa. Okay, so if I'm on gerrit, I can use the "shell username" to log in to phabricator? Or the normal username and password from gerrit?
[12:29:11] 	 you almost never use the shell username
[12:29:19] 	 unless you're using labs
[12:29:24] 	 it's used, uh
[12:29:24] 	 if you've already got an account, you need to link it
[12:29:34] 	 when configuring git-review, i think
[12:29:38] 	 Ah, okay. Or cloning from gerrit?
[12:29:43] 	 yep
[12:29:48] 	 in the ssh urls
[12:29:56] 	 Okay, this is starting to make a bit more sense.
[12:30:21] 	 (it is kind of messed up that we have this much stuff, now when i think about it)
[12:30:26] 	 So if I have two different gerrit and mediawiki+phabricator accounts, how do I link them together?
[12:30:39] 	 (but we used to have one more for Bugzilla before we moved to Phab, so, progress i guess?)
[12:30:41] 	 (I was thinking the same thing, tbh)
[12:30:46] 	 3Wiki-Release-Team, Cite: "SpecialCite" no longer bundled with tarball release of MediaWiki 1.25+ - https://phabricator.wikimedia.org/T85126#942922 (10Kghbln) 5Open>3Resolved a:3Kghbln Great, that was an easy-going on. Just documented this [[ https://www.mediawiki.org/w/index.php?title=MediaWiki_1.25&diff=...
[12:30:54] 	 (Oh. Then certainly progress.)
[12:31:13] 	 (03PS1) 10Reedy: Change to unix eol style [skins/Vector] - 10https://gerrit.wikimedia.org/r/181731 
[12:31:18] 	 polybuildr: not sure what you mean, but perhaps this? https://phabricator.wikimedia.org/settings/panel/external/
[12:31:23] 	 3UI-Standardization: Create primary button with indeterminate loader - https://phabricator.wikimedia.org/T72417#942926 (10Nirzar) I think that's a good idea! I was doing similar thing earlier - [[ http://nirzar.github.io/prototypes/ui/primary-button-loading.html | have a look ]] - this is with Pau's indicator...
[12:32:24] 	 (03CR) 10Bartosz Dziewoński: [C: 032] Change to unix eol style [skins/Vector] - 10https://gerrit.wikimedia.org/r/181731 (owner: 10Reedy)
[12:32:26] 	 (03Merged) 10jenkins-bot: Change to unix eol style [skins/Vector] - 10https://gerrit.wikimedia.org/r/181731 (owner: 10Reedy)
[12:32:55] 	 MatmaRex: My mediawiki account is already linked there. But I have another, basically unrelated gerrit account. 
[12:33:37] 	 (03PS1) 10Reedy: Change to unix eol style [core] - 10https://gerrit.wikimedia.org/r/181733 
[12:34:01] 	 And why does phabricator have an option to give it my public ssh key?
[12:34:19] 	 polybuildr: i don't think that'll cause any problems, but you can link up all these accounts under the link i gave you
[12:34:52] 	 polybuildr: we will probably be switching from Gerrit to Phabricator as code review tool at some point in the future
[12:35:22] 	 In the link you gave me, my mediawiki user is added as an external reference. How do I add in gerrit? LDAP username and password should be the same as gerrit's?
[12:35:25] 	 I see. 
[12:35:27] 	 and it'll probably need the SSH key then for you to be able to push patches for review to Phabricator
[12:35:28] 	 yes
[12:35:33] 	 but that's future
[12:36:02] 	 right now we have some of the repositories imported, but in read-only mode? not sure
[12:36:19] 	 Fair enough. As of now, any point in linking gerrit with mediawiki+phabricator?
[12:36:30] 	 not really
[12:36:36] 	 polybuildr: one thing you probably want to set up, is to add the email address you use for gerrit contributions here: https://phabricator.wikimedia.org/settings/panel/email/
[12:36:50] 	 That's added in too.
[12:36:53] 	 so the read-only imported commits are linked up with your account on phabricator
[12:36:54] 	 yay
[12:37:23] 	 (03CR) 10Bartosz Dziewoński: [C: 032] Change to unix eol style [core] - 10https://gerrit.wikimedia.org/r/181733 (owner: 10Reedy)
[12:37:32] 	 Hmm. Alright. That seems it for now. Thanks, MatmaRex, Reedy and tto. :)
[12:41:04] 	 3Cite: New project CiteThisPage required - https://phabricator.wikimedia.org/T85269#942927 (10Kghbln) 3NEW
[12:42:42] 	 (03PS1) 10Jhernandez: Implement in View a declarative event map for DOM events [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/181734 
[12:43:00] 	 (03Merged) 10jenkins-bot: Change to unix eol style [core] - 10https://gerrit.wikimedia.org/r/181733 (owner: 10Reedy)
[12:47:48] 	 3Cite, Wiki-Release-Team: "SpecialCite" no longer bundled with tarball release of MediaWiki 1.25+ - https://phabricator.wikimedia.org/T85126#942933 (10Kghbln) 5Resolved>3Open Ouch, thought this one was merged already.
[12:53:50] 	 Reedy, now that the change has been merged, I no longer need to do any resetting, do I?
[12:55:29] 	 polybuildr: yes, `git pull --rebase` should suffice
[12:55:39] 	 Awesome. Thanks.
[12:56:13] 	 (note the --rebase, Gerrit gets very finicky when your local repository is in any way different from the "canonical" one)
[12:56:29] 	 (as in, produces very unhelpful error messages)
[12:56:39] 	 Hmm. Alright.
[12:59:29] 	 3UI-Standardization: Create primary button with indeterminate loader - https://phabricator.wikimedia.org/T72417#942935 (10Pginer-WMF) > I made two versions since i thought background blue to light grey transition might look bit abrupt.  Makes sense, but keeping the loading stage as "active blue" while the button...
[13:03:23] 	 3Project-Creators: Create project for CiteThisPage extension - https://phabricator.wikimedia.org/T85162#942937 (10Se4598)
[13:03:24] 	 3Cite: New project CiteThisPage required - https://phabricator.wikimedia.org/T85269#942936 (10Se4598)
[13:15:32] 	 3MediaWiki-Installer: Improve messages output by the database updaters - https://phabricator.wikimedia.org/T34020#942947 (10polybuildr) What's the status of this bug?
[13:21:19] 	 (03PS3) 10Niharika29: Update countries database to reflect global north/south [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/181578 
[13:22:56] 	 (03PS2) 10Jhernandez: Implement in View a declarative event map for DOM events [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/181734 
[13:28:05] 	 (03PS4) 10Niharika29: Update countries database to reflect global north/south [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/181578 
[13:35:12] 	 (03PS5) 10Niharika29: Update countries database to reflect global north/south [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/181578 
[13:49:44] 	 (03PS1) 10Reedy: Add lots of @throws [core] - 10https://gerrit.wikimedia.org/r/181736 
[13:59:57] 	 Creating a new project - https://phabricator.wikimedia.org/T85273#942967 (10Jaspark1027) 3NEW a:3Jaspark1027
[14:06:54] 	 3MediaWiki-extensions-MultimediaViewer, Multimedia: MediaViewer should ignore generated captions on special pages - https://phabricator.wikimedia.org/T85234#942974 (10Namit) a:3Namit
[14:07:17] 	 3MediaWiki-Installer: Improve messages output by the database updaters - https://phabricator.wikimedia.org/T34020#942975 (10Aklapper) >>! In T34020#942947, @polybuildr wrote: > What's the status of this bug?  See the comments and information above. What's specifically unclear?  There's a patch and somebody needs...
[14:12:05] 	 3Project-Creators: Create project for CiteThisPage extension - https://phabricator.wikimedia.org/T85162#942976 (10Aklapper) 5Open>3Resolved a:3Aklapper Requested project has been created. If for some reason you want to rename a project, please check [[ https://www.mediawiki.org/wiki/Phabricator/Creating_an...
[14:13:56] 	 3CirrusSearch: metrics for search latency disappeared from search dashboard - https://phabricator.wikimedia.org/T85267#942979 (10Aklapper)
[14:15:50] 	 3MediaWiki-Installer: Improve messages output by the database updaters - https://phabricator.wikimedia.org/T34020#942981 (10polybuildr) >>! In T34020#942975, @Aklapper wrote: >>>! In T34020#942947, @polybuildr wrote: >> What's the status of this bug? >  > See the comments and information above. What's specifical...
[14:18:54] 	 3MediaWiki-extensions-WikibaseRepository, Wikidata: Edit buttons are getting cached, although their visibility depends on user rights - https://phabricator.wikimedia.org/T85252#942506 (10Aklapper) [offtopic]  @JohnLewis: ➔ T76732
[14:20:35] 	 (03PS1) 10Anomie: Remove bogus entry in $wgAutoloadClasses [extensions/ApiFeatureUsage] - 10https://gerrit.wikimedia.org/r/181738 
[14:20:51] 	 (03CR) 10jenkins-bot: [V: 04-1] Remove bogus entry in $wgAutoloadClasses [extensions/ApiFeatureUsage] - 10https://gerrit.wikimedia.org/r/181738 (owner: 10Anomie)
[14:21:50] 	 3MediaWiki-Maintenance-scripts: moveBatch.php contains old USAGE - https://phabricator.wikimedia.org/T85246#942990 (10Aklapper) p:5Low>3Volunteer?
[14:26:29] 	 3ops-requests, operations: Upgrade poppler-utils to at least 0.20 - https://phabricator.wikimedia.org/T83123#942997 (10fgiunchedi) 5stalled>3Resolved a:3fgiunchedi hhvm/trusty migration has happened, thus  ``` mw1040:~$ dpkg -l poppler-utils Desired=Unknown/Install/Remove/Purge/Hold | Status=Not/Inst/Conf-...
[14:26:32] 	 3ops-requests, operations: Upgrade poppler-utils to at least 0.20 - https://phabricator.wikimedia.org/T83123#943000 (10fgiunchedi)
[14:26:38] 	 (03PS2) 10Anomie: Update $wgAutoloadClasses [extensions/ApiFeatureUsage] - 10https://gerrit.wikimedia.org/r/181738 
[14:26:57] 	 (03CR) 10Anomie: "If9abef55138062f11fcc1ed8e16f90d3c6bb1c91 should fix it." [extensions/ApiFeatureUsage] - 10https://gerrit.wikimedia.org/r/181705 (owner: 10TTO)
[14:27:20] 	 3Wikimedia-Media-storage, Multimedia, operations: Upgrade poppler-utils to at least 1.20 - https://phabricator.wikimedia.org/T57624#621269 (10fgiunchedi)
[14:27:21] 	 3ops-requests, operations: Upgrade poppler-utils to at least 0.20 - https://phabricator.wikimedia.org/T83123#909434 (10fgiunchedi)
[14:27:36] 	 feedback box doesn't show on firefox, chrome with mediawiki 1.24.1 - https://phabricator.wikimedia.org/T85146#943007 (10Aklapper) >>! In T85146#941842, @Pcawiki wrote: > Just let me know if need more information.  See my questions in T85146#939987
[14:27:50] 	 (03PS3) 10Anomie: Update $wgAutoloadClasses [extensions/ApiFeatureUsage] - 10https://gerrit.wikimedia.org/r/181738 
[14:27:50] 	 3Wikimedia-Media-storage, Multimedia, operations: Upgrade poppler-utils to at least 1.20 - https://phabricator.wikimedia.org/T57624#943008 (10fgiunchedi) 5Open>3Resolved a:3fgiunchedi see related, migration to trusty is complete on appservers
[14:29:18] 	 3ops-codfw: install cable covers in enclosure's sidewalls - https://phabricator.wikimedia.org/T84072#943011 (10RobH) The cover's dont fit?  They'll be tight, but should fit.  (I recall installing a few, but I am no longer certain.)  Please advise, as we may have to chat with RackSolutions.
[14:30:56] 	 3ops-codfw: reclaim graphite2001 allocation back to spare - remove ssds - new system required. - https://phabricator.wikimedia.org/T84786#943012 (10RobH) 5Open>3Resolved added back to spares, resolving task.
[14:32:27] 	 3operations, Wikimedia-SSL-related: Wikibooks SSL certificate fails to validate (due to "Certificate Subject Alt Name"s?) - https://phabricator.wikimedia.org/T56457#943014 (10fgiunchedi) 5Open>3Resolved a:3fgiunchedi resolving this for now as there's no activity and no clear action, feel free to reopen of...
[14:41:01] 	 3ops-codfw: rename stat1 => stat2001 - update labels/racktables/drac - https://phabricator.wikimedia.org/T85275#943017 (10RobH) 3NEW a:3Papaul
[14:49:40] 	 (03PS65) 10Paladox: WikiEditor: Re add SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 
[14:51:24] 	 (03PS35) 10Paladox: WikiEditor: Convert .css to .less and add Arrow SVG images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151616 
[14:52:12] 	 (03PS70) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 
[15:02:56] 	 3MediaWiki-extensions-CiteThisPage, Cite, Wiki-Release-Team: "SpecialCite" no longer bundled with tarball release of MediaWiki 1.25+ - https://phabricator.wikimedia.org/T85126#943031 (10Kghbln)
[15:04:12] 	 3ops-requests, operations: Package for mobile jobs (androidsdk, libdclass) missing in Trusty - https://phabricator.wikimedia.org/T84164#943032 (10fgiunchedi) I think we have trusty labs slaves happily running, thus this can be resolved, I'll let @hashar comment tho
[15:04:14] 	 3ops-requests, operations: Package for mobile jobs (androidsdk, libdclass) missing in Trusty - https://phabricator.wikimedia.org/T84164#943034 (10fgiunchedi)
[15:06:25] 	 (03CR) 10Anomie: Terminate free external link on   (and numeric versions of <>) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/180982 (owner: 10Cscott)
[15:07:24] 	 (03CR) 10Anomie: "Just poking at it manually to see if I can think of any edge cases." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/181408 (owner: 10Mr. Stradivarius)
[15:09:02] 	 (03PS8) 10Niharika29: Create new "Primary language community on wiki" question [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/180802 
[15:12:05] 	 (03PS9) 10Niharika29: Create new "Primary language community on wiki" question [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/180802 
[15:14:21] 	 (03CR) 10Anomie: [C: 032] Add mw.site.interwikiMap [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/181408 (owner: 10Mr. Stradivarius)
[15:14:35] 	 (03CR) 10Niharika29: "Fixed!" [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/180802 (owner: 10Niharika29)
[15:16:27] 	 (03Merged) 10jenkins-bot: Add mw.site.interwikiMap [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/181408 (owner: 10Mr. Stradivarius)
[15:17:47] 	 3operations: No DNS record for stat1001.wikimedia.org - https://phabricator.wikimedia.org/T85249#943038 (10akosiaris) 5Open>3declined a:3akosiaris Hello,  Yes this is to be expected. It has been moved into the analytics vlan and hence changed IP (public => private) and name. It now is:  stat1001.eqiad.wmne...
[15:21:01] 	 Please create a task - https://phabricator.wikimedia.org/T85276#943044 (10Mr.Shoval) 3NEW
[15:22:20] 	 3Wikimedia-General-or-Unknown, operations: COPYING is served as application/octet-stream - https://phabricator.wikimedia.org/T63903#943049 (10MaxSem) Well, that's because it's a 404 now ;)
[15:25:23] 	 3operations: Add a "datasets" database to analytics-store.eqiad.wmnet - https://phabricator.wikimedia.org/T85277#943051 (10Ironholds) 3NEW
[15:30:33] 	 3ops-core, operations: Setup an Offsite backup infrastructure - https://phabricator.wikimedia.org/T85278#943057 (10akosiaris) 3NEW a:3akosiaris
[15:58:34] 	 legoktm: do you know when is one supposed to release tags? they don't have any descriptions: https://phabricator.wikimedia.org/project/view/327/
[15:59:09] 	 3MediaWiki-Installer: Unable to install MediaWiki via web installer if mysql user has empty password - https://phabricator.wikimedia.org/T85281#943083 (10Nikerabbit) 3NEW
[15:59:18] 	 3ops-codfw: install cable covers in enclosure's sidewalls - https://phabricator.wikimedia.org/T84072#943089 (10Papaul) yes you right "there are very tight"  I started to install some yesterday and it is taking me 3 mins to install 1. the reason is it is too tight and with the equipments in the rack it is also ma...
[15:59:44] 	 3MediaWiki-Installer: Unable to install MediaWiki via web installer if mysql user has empty password - https://phabricator.wikimedia.org/T85281#943083 (10Nikerabbit) This was observed on latest master.
[16:09:00] 	 3Wikimedia-Site-requests: Please upload last of the CGPGrey files to Wikimedia Commons - https://phabricator.wikimedia.org/T85282#943094 (101Veertje) 3NEW
[16:13:13] 	 3MediaWiki-extensions-Flow, Collaboration-Team: Title edit field overlaps with action menu - https://phabricator.wikimedia.org/T85283#943100 (10Pginer-WMF) 3NEW
[16:13:14] 	 Nikerabbit: release tags are supposed to be used when the bug should be fixed for that release. 
[16:15:21] 	 (03PS3) 10MarkTraceur: Add tests for mw.fileApi [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181169 
[16:15:45] 	 (03CR) 10MarkTraceur: Add tests for mw.fileApi (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181169 (owner: 10MarkTraceur)
[16:16:11] 	 (03CR) 10jenkins-bot: [V: 04-1] Add tests for mw.fileApi [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181169 (owner: 10MarkTraceur)
[16:16:44] 	 (03CR) 10MarkTraceur: "I guess that part of the code is still using some old method of getting the description text...on it" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181425 (owner: 10MarkTraceur)
[16:22:34] 	 3Multimedia, Wikimedia-General-or-Unknown, operations: PDF containing jpx/jp2 encoded images from Archive.org uploaded to Commons won't thumbnail - https://phabricator.wikimedia.org/T61975#943107 (10fgiunchedi) looks like thumbs for that pdf are still failing to generate, however IIRC jobrunners aren't HHVM (and...
[16:22:49] 	 3Multimedia, Wikimedia-General-or-Unknown: PDF containing jpx/jp2 encoded images from Archive.org uploaded to Commons won't thumbnail - https://phabricator.wikimedia.org/T61975#943110 (10fgiunchedi)
[16:26:56] 	 3Wikimedia-General-or-Unknown, operations: Icinga has httpauth on (not accessible for public) - https://phabricator.wikimedia.org/T62112#943112 (10fgiunchedi) this could get fixed also during the debian migration, I believe icinga jessie packages would do
[16:28:36] 	 3Collaboration-Team, WMF-Design, MediaWiki-extensions-Flow, UI-Standardization: Input field padding is unbalanced affecting vertical alignment of text - https://phabricator.wikimedia.org/T85284#943113 (10Pginer-WMF) 3NEW
[16:28:55] 	 (03PS2) 10MarkTraceur: Sanitize | characters in descriptions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181425 
[16:31:40] 	 3Collaboration-Team, WMF-Design, MediaWiki-extensions-Flow, UI-Standardization: Input field padding is unbalanced affecting vertical alignment of text - https://phabricator.wikimedia.org/T85284#943122 (10Pginer-WMF)
[16:32:30] 	 3MediaWiki-extensions-EducationProgram: Education Program article log should be an event for EP page not article - https://phabricator.wikimedia.org/T76384#943124 (10Cenarium) p:5Volunteer?>3Low
[16:35:18] 	 3Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice: Use contentlanguage for CentralNotice banners - https://phabricator.wikimedia.org/T53475#943127 (10awight)
[16:39:02] 	 (03PS3) 10MarkTraceur: Add tests for upload step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/180541 
[16:39:05] 	 (03CR) 10jenkins-bot: [V: 04-1] Add tests for upload step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/180541 (owner: 10MarkTraceur)
[16:39:53] 	 3Wikimedia-General-or-Unknown, operations: ishmael shows blank graphs - https://phabricator.wikimedia.org/T66581#943132 (10fgiunchedi) are we still interested in the tool or it has been superceded in the meantime?
[16:40:31] 	 3Wikimedia-Site-requests: Text layer of DjVu files doesn't appear in Page namespace due to higher memory consumption after upgrade to Ubuntu 12.04 - https://phabricator.wikimedia.org/T44466#943134 (10fgiunchedi)
[16:40:35] 	 3MediaWiki-extensions-CiteThisPage: "Cite this page" sidebar link should always be next to "Printable version", e.g. under "Print/export" where available - https://phabricator.wikimedia.org/T66314#943136 (10Legoktm)
[16:40:36] 	 3MediaWiki-extensions-CiteThisPage: Cite Extension: the Revision date and the Permanent link do not match - https://phabricator.wikimedia.org/T44678#943138 (10Legoktm)
[16:40:37] 	 3MediaWiki-extensions-CiteThisPage: Suggested Bibliographic Citations in Bulgarian - https://phabricator.wikimedia.org/T31192#943137 (10Legoktm)
[16:45:51] 	 3Wikimedia-General-or-Unknown, operations: COPYING is served as application/octet-stream - https://phabricator.wikimedia.org/T63903#943141 (10fgiunchedi) 5Resolved>3Open whoops! I jumped the gun there, apologies. is the file to be found somewhere else now?
[16:46:17] 	 3MediaWiki-User-login-and-signup, MediaWiki-Special-pages: Remove includes/templates/Userlogin.php, use HTMLForm class in includes/SpecialUserlogin.php instead - https://phabricator.wikimedia.org/T12317#943143 (10matmarex)
[16:47:12] 	 (03CR) 10Rush: "Ok I made sure everything was in /srv/phab/phabricator/src/extensions and I created a few new tasks using the drop down etc and I don't se" [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/179405 (owner: 1020after4)
[16:47:32] 	 (03PS4) 10MarkTraceur: Add tests for upload step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/180541 
[16:48:27] 	 (03PS4) 10Gergő Tisza: Add tests for mw.fileApi [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181169 (owner: 10MarkTraceur)
[16:48:44] 	 (03PS5) 10MarkTraceur: Add tests for mw.fileApi [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181169 
[16:49:44] 	 (03CR) 10Gergő Tisza: [C: 032] Add tests for upload step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/180541 (owner: 10MarkTraceur)
[16:50:08] 	 (03CR) 10Gergő Tisza: [C: 032] Add tests for mw.fileApi [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181169 (owner: 10MarkTraceur)
[16:50:25] 	 (03Merged) 10jenkins-bot: Add tests for upload step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/180541 (owner: 10MarkTraceur)
[16:50:59] 	 (03Merged) 10jenkins-bot: Add tests for mw.fileApi [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181169 (owner: 10MarkTraceur)
[16:51:01] 	 3MediaWiki-extensions-EducationProgram: Education Program article log should be an event for EP page not article - https://phabricator.wikimedia.org/T76384#943147 (10Cenarium) Raising priority in light of watchlist spam issues. Here's an example :  https://en.wikipedia.org/w/index.php?title=Wikipedia:Education_n...
[16:53:02] * legoktm throws Reedy
[16:53:09] 	 Hiya. I'm looking in to making PostEdit extensible so extensions can show their own messages, any body have any thoughts on the best way to implement this? (https://phabricator.wikimedia.org/T65740)
[16:53:27] 	 legoktm: merge it
[16:53:28] 	 legoktm: merge it
[16:53:29] 	 legoktm: merge it
[16:53:29] 	 legoktm: merge it
[16:53:36] 	 UltrasonicNXT: hooks, usually
[16:53:45] 	 Or config
[16:53:49] 	 UltrasonicNXT: VisualEditor hooks into it somehow, might want to look into what they do
[16:54:54] 	 3MediaWiki-User-login-and-signup, UI-Standardization: Convert MW core login/create/reset password pages to OOUI - https://phabricator.wikimedia.org/T74715#943150 (10matmarex) This would be a lot less unpleasant if somebody did T19312, or maybe even T12317, first.
[16:55:06] 	 legoktm!
[16:55:22] 	 legoktm: what are the chances of someone doing https://phabricator.wikimedia.org/T19312 soon?
[16:56:08] 	 3MediaWiki-Core-Team, Librarization: Create RFC for library extraction (PHP & javascript) practices - https://phabricator.wikimedia.org/T1017#943155 (10bd808) Draft on wiki now!   I will announce on...
[16:56:10] 	 hahahaha
[16:56:11] 	 3Wikimedia-Logstash: Add Hadoop mapreduce logfiles to logstash - https://phabricator.wikimedia.org/T63790#943156 (10Gage) 5Open>3Resolved Yes, this project is considered complete. However because there are so many log sources, please do create tasks if you identify any event streams which are absent from Log...
[16:56:21] 	 i'm serious
[16:56:27] 	 MatmaRex: I guess it might get done with the upcoming SOA auth project
[16:56:37] 	 i don't want to do it myself since i know nothing about the login code
[16:56:41] 	 So at the mo PostEdit is called when you get the ?action=submit parameter, so I can't just use hooks can I?
[16:56:57] 	 3MediaWiki-extensions-ContentTranslation: Short infographic to introduce CX - https://phabricator.wikimedia.org/T84878#943158 (10Pginer-WMF) I created the following infographic:  {F25087}  {F25088}  It needs to be updated with the exact sites we'll be deploying to, and we may want to create translations once we...
[16:56:59] 	 but i want to kill the templates
[16:57:09] 	 https://www.mediawiki.org/wiki/Wikimedia_Engineering/2014-15_Goals/Q3#Proposed_top_priorities "
[16:57:09] 	     SOA Auth: This work will likely begin, but we are not ready to declare it a top priority as we cannot give it sufficient dedicated leadership and support to push for very ambitious goals in Q3.
[16:57:09] 	 "
[16:57:13] 	 and if i were to do that, the form code would have to be tacked on to the special page
[16:57:24] 	 and i really don't want to add to these 1600 lines of code
[16:59:27] 	 Regarding, https://phabricator.wikimedia.org/T36952, can someone please explain when an upload is "stashed"?
[16:59:51] 	 MatmaRex: I've very interested in revamping the authn/authz stack to split things up into manageable pieces and make adding new functionality easier.
[17:00:08] 	 polybuildr: When you're doing big/huge uploads mainly
[17:00:33] 	 s/I've/I'm/
[17:00:46] 	 Reedy: I see. Okay, attempting to duplicate.
[17:01:47] 	 s/duplicate/reproduce
[17:01:50] 	 bd808: that sounds ambitious and far away :(
[17:02:03] 	 MatmaRex: I'd like to start in January
[17:02:09] 	 bd808: what would make me happy is what anomie outlined on https://gerrit.wikimedia.org/r/#/c/27022/ : "I'd say you should actually do what bug 17312 says: split LoginForm into a "LoginController" class[1] to handle the actual login logic and a SpecialUserlogin class that handles the UI. And maybe even split "CreateAccountController"[2] from "LoginController". Then change callers (e.g. the API) to use the new non-UI classes. And
[17:02:09] 	 then UI changes can be looked at."
[17:02:15] 	 (03CR) 10Legoktm: [C: 032] Update $wgAutoloadClasses [extensions/ApiFeatureUsage] - 10https://gerrit.wikimedia.org/r/181738 (owner: 10Anomie)
[17:02:26] 	 (03Merged) 10jenkins-bot: Update $wgAutoloadClasses [extensions/ApiFeatureUsage] - 10https://gerrit.wikimedia.org/r/181738 (owner: 10Anomie)
[17:03:42] 	 bd808: Hangout?
[17:03:52] 	 Niharika___: oops yeah
[17:04:14] 	 (03PS2) 10Anomie: Fix case of "API" in title of special page [extensions/ApiFeatureUsage] - 10https://gerrit.wikimedia.org/r/181705 (owner: 10TTO)
[17:04:21] 	 3Wikimedia-General-or-Unknown, operations: HTTP/1.1 compliance of bits.wikimedia.org/.../load.php - https://phabricator.wikimedia.org/T30345#943165 (10BBlack) I don't think it's a varnish bug at this point (tim filed a bug a couple years ago and it was fixed: https://www.varnish-cache.org/trac/ticket/1255 , and...
[17:06:05] 	 3Multimedia, MediaWiki-extensions-Sentry, MediaWiki-ResourceLoader: Create ResourceLoader hook to add new startup modules - https://phabricator.wikimedia.org/T85262#943166 (10Legoktm) Some historical context: https://gerrit.wikimedia.org/r/#/c/127581/ and https://gerrit.wikimedia.org/r/#/c/145680/  Is there a re...
[17:06:10] 	 (03PS4) 10MarkTraceur: Add tests for tutorial step object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/180521 
[17:06:13] 	 (03CR) 10jenkins-bot: [V: 04-1] Add tests for tutorial step object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/180521 (owner: 10MarkTraceur)
[17:06:21] 	 (03CR) 10Anomie: [C: 032] Fix case of "API" in title of special page [extensions/ApiFeatureUsage] - 10https://gerrit.wikimedia.org/r/181705 (owner: 10TTO)
[17:06:31] 	 (03Merged) 10jenkins-bot: Fix case of "API" in title of special page [extensions/ApiFeatureUsage] - 10https://gerrit.wikimedia.org/r/181705 (owner: 10TTO)
[17:07:08] 	 (03PS5) 10MarkTraceur: Add tests for tutorial step object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/180521 
[17:07:36] 	 (03CR) 10Legoktm: [C: 032] "____" [core] - 10https://gerrit.wikimedia.org/r/181736 (owner: 10Reedy)
[17:08:03] 	 bah, still didn't work
[17:08:26] 	 legoktm: lolwat
[17:09:01] 	 legoktm: Gerrit helpfully trims whitespace.
[17:10:40] 	 3MediaWiki-Watchlist, MediaWiki-Patrolling: Remove show/hide patrolled edits from watchlists if patrolling is disabled - https://phabricator.wikimedia.org/T76054#943174 (10Glaisher) Looks like it appears because new page patrolling is enabled. It only disappears when both $wgUseNPPatrol and $wgUseRCPatrol are se...
[17:12:49] 	 legoktm: Maybe if you prefix each line with > it will stop meddling
[17:13:20] 	 (03CR) 10Legoktm: "Thanks, I was looking for this earlier :)" [core] - 10https://gerrit.wikimedia.org/r/181551 (owner: 10Nikerabbit)
[17:13:32] 	 (03Merged) 10jenkins-bot: Add lots of @throws [core] - 10https://gerrit.wikimedia.org/r/181736 (owner: 10Reedy)
[17:14:28] 	 at the mo PostEdit is called when you get the ?action=submit parameter, so I can't just use hooks can I? I either have to provide a new url parameter or some dynamic js?
[17:15:34] 	 (03PS10) 10Legoktm: content: Recognise .json as JsonContent in User and MediaWiki namespace [core] - 10https://gerrit.wikimedia.org/r/177172 (owner: 10Krinkle)
[17:16:21] 	 3MediaWiki-HTMLForm, UI-Standardization: Disentangle VForms from HTMLForm code in core - https://phabricator.wikimedia.org/T85285#943180 (10matmarex) 3NEW
[17:17:10] 	 (03CR) 10Gergő Tisza: [C: 032] Add tests for tutorial step object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/180521 (owner: 10MarkTraceur)
[17:17:49] 	 (03Merged) 10jenkins-bot: Add tests for tutorial step object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/180521 (owner: 10MarkTraceur)
[17:21:08] 	 (03CR) 10Gergő Tisza: [C: 04-1] "I still see a normal pipe in the "To use the file in a wiki, copy this text into a page:" field." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181425 (owner: 10MarkTraceur)
[17:21:22] 	 (03PS2) 10BryanDavis: Add use statement for type used in MWLoggerMonologSamplingHandler::setFormatter() [core] - 10https://gerrit.wikimedia.org/r/181730 (owner: 10Reedy)
[17:21:29] 	 (03CR) 10BryanDavis: [C: 032] Add use statement for type used in MWLoggerMonologSamplingHandler::setFormatter() [core] - 10https://gerrit.wikimedia.org/r/181730 (owner: 10Reedy)
[17:22:41] 	 (03PS11) 10Legoktm: content: Recognise .json as JsonContent in User and MediaWiki namespace [core] - 10https://gerrit.wikimedia.org/r/177172 (owner: 10Krinkle)
[17:23:41] 	 (03CR) 10Legoktm: "PS11: Added tests." [core] - 10https://gerrit.wikimedia.org/r/177172 (owner: 10Krinkle)
[17:24:30] 	 3MediaWiki-Core-Team: Authn and authz as a service - https://phabricator.wikimedia.org/T84962#943201 (10bd808) I think we should consider issues like {T19312} to be in scope for this project. It seems reasonable to me that we will need to refactor/rethink the authn/authz stack inside MediaWiki in order to make i...
[17:26:10] 	 (03CR) 10Legoktm: [C: 04-1] "I think this is (or at least should be) blocked on I45200f4651d7200cfad541cdd21cc625c711e81f being merged." [core] - 10https://gerrit.wikimedia.org/r/176853 (owner: 10Krinkle)
[17:27:37] 	 (03Merged) 10jenkins-bot: Add use statement for type used in MWLoggerMonologSamplingHandler::setFormatter() [core] - 10https://gerrit.wikimedia.org/r/181730 (owner: 10Reedy)
[17:27:44] 	 3MediaWiki-extensions-Renameuser: Suppress redirects when moving *.js and *.css pages during a user rename - https://phabricator.wikimedia.org/T36930#943206 (10Legoktm) 5Open>3Resolved a:3Legoktm This was fixed when ContentHandler was introduced.
[17:27:53] 	 3ops-codfw: rename stat1 => stat2001 - update labels/racktables/drac - https://phabricator.wikimedia.org/T85275#943209 (10Papaul) 5Open>3Resolved Rack-Table updated visible label update mgmt set-up complete and tested  stat2001 mgmt ip = 10.193.2.13= ge-1/0/0
[17:28:09] 	 3MediaWiki-extensions-WikiForum: [WikiForum] Added capability to recognize single line breaks - https://phabricator.wikimedia.org/T53190#943211 (10UltrasonicNXT) a:3UltrasonicNXT I'm about to do this. I'm not going to add a config variable though, as I can't see this as a feature anyone would want to turn off.
[17:28:26] 	 3MediaWiki-User-login-and-signup, MediaWiki-Special-pages: Remove includes/templates/Userlogin.php, use HTMLForm class in includes/SpecialUserlogin.php instead - https://phabricator.wikimedia.org/T12317#943213 (10matmarex)
[17:28:36] 	 (03PS1) 10UltrasonicNXT: Parse single linebreaks into proper breaks [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/181745 
[17:29:44] 	 (03PS2) 10UltrasonicNXT: Parse single linebreaks into proper breaks [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/181745 
[17:30:21] 	 (03CR) 10UltrasonicNXT: [C: 032 V: 032] Parse single linebreaks into proper breaks [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/181745 (owner: 10UltrasonicNXT)
[17:31:21] 	 (03Abandoned) 10Jdlrobson: Begin deprecation of mediawiki.ui style module [core] - 10https://gerrit.wikimedia.org/r/151791 (owner: 10Jdlrobson)
[17:31:28] 	 3MediaWiki-extensions-WikiForum: [WikiForum] Added capability to recognize single line breaks - https://phabricator.wikimedia.org/T53190#943218 (10UltrasonicNXT) 5Open>3Resolved Done.
[17:33:01] 	 3MediaWiki-ContentHandler: Ensure JsonContent pages have valid syntax when saved - https://phabricator.wikimedia.org/T76553#943220 (10Legoktm) 5Open>3Resolved I think this is fixed now?
[17:33:03] 	 3MediaWiki-Page-editing: Restrict editing of .json pages in the user namespace (like .js and .css) - https://phabricator.wikimedia.org/T76554#943223 (10Legoktm)
[17:33:38] 	 (03CR) 10Legoktm: "Are User:Foo.json pages supposed to be user-protected?" [core] - 10https://gerrit.wikimedia.org/r/177172 (owner: 10Krinkle)
[17:35:32] 	 3MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension): ConfirmEdit's reCAPTCHA string mentions two words for Google Captcha but should be one - https://phabricator.wikimedia.org/T78129#943229 (10Glaisher) This is about reCAPTCHA, not a 're' language..  I don't think this is actually needed as Google's new No CAP...
[17:36:31] 	 (03CR) 10BryanDavis: "Besides the pull-request to fix the classmap, it looks like the upstream has several small bug fixes that aren't included in 0.17. We coul" [vendor] - 10https://gerrit.wikimedia.org/r/181708 (owner: 10Kaldari)
[17:37:54] 	 3operations, Project-Creators, ops-core, ops-requests: Project Proposal:  Label style projects for common operations tools - https://phabricator.wikimedia.org/T1147#943234 (10chasemp) On this:  > Debian packaging was raised on the list, with "Debian-packaging" or "Debs" (I prefer the latter but there's a couple...
[17:38:14] 	 3operations, Project-Creators, ops-core, ops-requests: Project Proposal:  Label style projects for common operations tools - https://phabricator.wikimedia.org/T1147#943236 (10chasemp)
[17:38:47] 	 3ops-codfw: mw2098 non-responsive to mgmt - https://phabricator.wikimedia.org/T85286#943237 (10RobH) 3NEW a:3Papaul
[17:39:16] 	 3Wikimedia-Wikimania-Scholarships: Update "Most active Wiki" question - https://phabricator.wikimedia.org/T85287#943245 (10Shouston_WMF) 3NEW
[17:41:11] 	 Regarding https://phabricator.wikimedia.org/T36952, I've installed UploadWizard and uploaded a few large files. I also have an entry in my uploadstash table. Can anyone tell me where I can find a filekey to supply to the API?
[17:42:06] 	 3Wikimedia-Wikimania-Scholarships: Create new "Primary language community on wiki" question - https://phabricator.wikimedia.org/T78606#943252 (10Shouston_WMF) Add a note to this question with the following text: If in the previous question, you selected Commons, Species, Data or Incubator as your most active Wik...
[17:43:06] 	 Reedy ^^ help please?
[17:43:30] 	 polybuildr: You shouldn't need to *find* the key, if you're using UploadWizard.
[17:44:05] 	 polybuildr: Oh, wait, you uploaded them, then closed the session, and now you want to finish the upload?
[17:44:08] 	 (03PS23) 10Legoktm: Show Captcha after click on edit over buttons on EditPage [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/136323 (https://bugzilla.wikimedia.org/19648) (owner: 10Florianschmidtwelzow)
[17:44:47] 	 3ops-core, operations: install/deploy codfw appservers - https://phabricator.wikimedia.org/T85227#943254 (10RobH) All mac info (except mw2098) is now in the install server module.  netboot.cfg already had a regex catchall for ALL mw* servers partitioning.  The network ports still need labeling, and vlan assignment.
[17:45:07] 	 marktraceur: I've uploaded 4 large image files. The uploads are complete. In order to query the API  as /api.php?action=query&prop=stashimageinfo&sliprop=bitdepth&filekey= I'm wondering where to find the filekey param.
[17:45:27] 	 In order to fix https://phabricator.wikimedia.org/T36952, I'm trying to reproduce the bug.
[17:46:30] 	 Create repository link for huggle - https://phabricator.wikimedia.org/T75870#943256 (10chasemp) @chad what do you think on this?
[17:47:02] 	 Is is not possible to add an email address to phab's cc field?
[17:47:59] 	 directly? no it's not possible
[17:49:33] 	 shouldn't that be allowed?
[17:49:38] 	 polybuildr: You can get them from Special:UploadStash but I'm not sure about the API
[17:49:42] 	 I think it was possible in bugzilla?
[17:49:57] 	 bugzilla emails were accounts so you were really adding an account I believe
[17:50:04] 	 taht happened to be the email
[17:50:20] 	 you can't cc someone (subscribe someone) who doesn't exist in Phab terms
[17:51:08] 	 that sounds right, otherwise that person wouldn't be able to un-cc him/herself if s/he doesn't have an account
[17:51:21] 	 marktraceur, I can see 4 filenames there. I still don't seem to be able to find the "filekey".
[17:51:23] 	 does that mean users who reported bugs at bugzilla but do not have an account on phab yet do not receive notifs?
[17:51:41] 	 polybuildr: I think the filekey *is* the filename
[17:51:46] 	 polybuildr: Or at least, part of it is
[17:52:21] 	 user's who never came over to Phab or don't check wikibugs don't get any notices that I'm aware of
[17:52:41] 	 hm
[17:53:43] 	 marktraceur: Hmm. Well, I'm trying to access them via the API, since that's the only way I know of to reproduce the bug. /api.php?action=query&prop=stashimageinfo&sliprop=bitdepth&filekey= gives me an error saying "One of filekey or sessionkey must be supplied"
[17:54:32] 	 Also, please take a look at https://phabricator.wikimedia.org/T36952. There is an API request there, but it is rather old, so I'm not sure it's still valid.
[17:55:19] 	 marktraceur: Am I getting the query right or is something wrong in the parameter itself?
[17:55:19] 	 polybuildr: change it to siiprop and siifilekey
[17:56:22] 	 marktraceur: Unrecognized parameters: 'siiprop', 'siifilekey' :/
[17:57:11] 	 ...wat.
[17:57:36] 	 it won't be sifilekey
[17:57:36] 	 marktraceur: Okay, no. My bad. The query works now.
[17:57:47] 	 polybuildr: Sweet.
[17:57:54] 	 Now I just have to get the right key. :P
[17:58:06] 	 MatmaRex: you around to help me with some oojs ui? I'm really struggling to get https://gerrit.wikimedia.org/r/#/c/181225/4/javascripts/modules/infobox/WikiDataItemLookupInputWidget.js working
[17:58:08] 	 And done. :D
[17:58:12] 	 marktraceur: Thanks!
[17:58:21] 	 My pleasure
[18:00:32] 	 (03CR) 10Legoktm: [C: 031] "Tested, looks good! I'm a bit unsure whether it'll be a weird UX to have the initial captcha at the bottom (near the save button) but all " [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/136323 (https://bugzilla.wikimedia.org/19648) (owner: 10Florianschmidtwelzow)
[18:03:24] 	 jdlrobson: i'm disappearing in ten minutes. what's supposed to work and not working?
[18:03:44] 	 i spent today wrangling VForms
[18:03:52] 	 MatmaRex: i'm just trying to get an OO.ui.LookupInputWidget working
[18:03:59] 	 i reached out to Trevor and James and there's no documentation
[18:04:07] 	 (03PS1) 10Bartosz Dziewoński: HTMLForm: Separate VForm code to a subclass [core] - 10https://gerrit.wikimedia.org/r/181748 
[18:04:22] 	 if you can point me at a simple example that should be enough for me to work off of
[18:04:49] 	 trevor and kirsten are working on docs, i think; but yeah, no tutorials now
[18:04:52] 	 basically it's doing something but not rendering the list of results
[18:04:59] 	 it's hitting api
[18:05:04] 	 but the results do not render anywhere
[18:05:06] 	 there should be some uses in VE, probably.
[18:05:08] * MatmaRex digs
[18:05:19] 	 the VE examples seemed pretty complicated (at least for categories)
[18:05:20] 	 LookupInputWidget is a bit wonky, iirc :/
[18:06:34] 	 jdlrobson: looks like it's supposed to be used as a mixin, not as a superclass?
[18:06:57] 	 hmm
[18:08:04] 	 3Librarization: Security update planning re Composer managed libraries for use on WMF cluster - https://phabricator.wikimedia.org/T349#943272 (10bd808)
[18:08:08] 	 jdlrobson: LookupInputWidget is definitely very wonky
[18:08:18] 	 MatmaRex: :-(
[18:08:44] 	 3Librarization: Have a check for reported security issues in dependencies - https://phabricator.wikimedia.org/T74193#943273 (10bd808) p:5Normal>3High
[18:09:27] 	 jdlrobson: ve.ui.MWTitleInputWidget looks like a reasonably simple use
[18:09:36] 	 3Librarization: Security update planning re Composer managed libraries for use on WMF cluster - https://phabricator.wikimedia.org/T349#943277 (10bd808) p:5Normal>3High
[18:09:50] 	 thanks MatmaRex i'll take a look
[18:09:50] 	 jdlrobson: basically the gist is that the 'widget' parameter to the mixin constructor should usually be just 'this'
[18:10:00] 	 and if it isn't, you're gonna have bad time
[18:10:06] 	 MatmaRex: seems like a bug?
[18:10:09] 	 we probably have a bug for that
[18:10:15] 	 sigh ok
[18:10:20] 	 thanks MatmaRex i really appreciate your guidance
[18:10:26] 	 i'll have another go today
[18:10:46] 	 (if we don't have a bug, we shou;d have)
[18:16:02] 	 3ops-core, operations: install/deploy codfw appservers - https://phabricator.wikimedia.org/T85227#943287 (10RobH) mw2001-mw2079 network config done (vlans set, ports enabled, port descriptions set with hostnames)  I've not trigged these to install, since they are an unattended install and ready to go.  Once we a...
[18:16:29] 	 Reedy, needed some help. I can't seem to find where the bitdepth is being stored for UnregisteredLocalFile. https://phabricator.wikimedia.org/T36952
[18:18:33] 	 bd808: is there a scrum of scrums today?
[18:18:48] 	 (03PS3) 10MarkTraceur: Sanitize | characters in descriptions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181425 
[18:19:05] 	 jdlrobson: Good question. I was going to join the hangout and find out.
[18:19:14] 	 bd808: same :-)
[18:19:22] 	 (i'm subbing for kaldari)
[18:19:25] * bd808 got tricked into being the mw-core delegate this week
[18:20:25] 	 I'm not sure the bit depth for an UnregisteredLocalFile is stored at all. Can somebody help, please? https://phabricator.wikimedia.org/T36952
[18:21:18] 	 (03PS1) 10M4tx: Display preview file format [core] - 10https://gerrit.wikimedia.org/r/181749 
[18:22:05] 	 3Multimedia, MediaWiki-File-management: Display file format of preview if different format from original file - https://phabricator.wikimedia.org/T58546#943303 (10m4tx) a:3m4tx
[18:23:16] 	 3Multimedia, MediaWiki-File-management: bitdepth of UploadStashFile is wrong - https://phabricator.wikimedia.org/T36952#943304 (10polybuildr) I can't seem to find where the bit depth is being stored for an `UnregisteredLocalFile`. I don't seem to be able to find it in the database, which is what the implementati...
[18:28:27] 	 (03PS1) 10Mr. Stradivarius: Use protocol-relative URLs in mw.site.interwikiMap [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/181750 
[18:38:01] 	 3LabsDB-Auditor, Scrum-of-Scrums, MediaWiki-Core-Team, Security-Reviews: Manually verify whitelisted.yaml / graylisted.yaml to ensure completeness - https://phabricator.wikimedia.org/T78730#943314 (10bd808) Is there a gerrit review for this that needs attention?
[18:38:34] 	 3MediaWiki-extensions-CentralAuth: Replace usage of centralauth-account-exists with userexists - https://phabricator.wikimedia.org/T75123#943316 (10m4tx) a:3m4tx
[18:39:55] 	 hi poxip
[18:39:57] 	 3ops-core, operations: install/deploy codfw appservers - https://phabricator.wikimedia.org/T85227#943319 (10Papaul)
[18:39:59] 	 3ops-codfw: mw2098 non-responsive to mgmt - https://phabricator.wikimedia.org/T85286#943317 (10Papaul) 5Open>3Resolved The set-up informations for the mgmt were correct the issue was that the DRAC card was just not responding any more.  what I did was to unplug all the data cables and power cords for 5 minut...
[18:40:01] 	 howdy
[18:40:02] 	 poxip
[18:40:06] 	 y0
[18:40:28] 	 i got rpi :D
[18:40:32] 	 meh :D
[18:40:54] 	 I want one, too xD
[18:41:06] 	 lol
[18:41:23] 	 3MediaWiki-extensions-CentralAuth: Replace usage of centralauth-account-exists with userexists - https://phabricator.wikimedia.org/T75123#943320 (10m4tx) p:5Normal>3Low
[18:41:24] 	 'xD'
[18:41:39] 	 3MediaWiki-extensions-CentralAuth: Replace usage of centralauth-account-exists with userexists - https://phabricator.wikimedia.org/T75123#769123 (10m4tx)
[18:42:13] 	 poxip, I sent you an interesting photo via G+ :P
[18:43:11] 	 lol
[18:44:37] 	 m4tx: mariusz
[18:46:08] 	 (03CR) 10Jdlrobson: [C: 031] "i'm willing to give this a try. @kaldari ?" [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/181734 (owner: 10Jhernandez)
[18:50:54] 	 mariusz.
[18:53:26] 	 (03PS4) 10MarkTraceur: Sanitize | characters in descriptions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181425 
[18:53:50] 	 (03PS5) 10MarkTraceur: Sanitize | characters in descriptions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181425 
[18:53:53] 	 3Bot-Requests: Create "readonlybot" account - https://phabricator.wikimedia.org/T85289#943324 (10RobLa-WMF) 3NEW
[18:54:03] 	 Create repository link for huggle - https://phabricator.wikimedia.org/T75870#943331 (10Chad) rHUG and rHUGGLE don't conform to the [[ https://www.mediawiki.org/wiki/Phabricator/Callsign_naming_conventions | naming conventions ]]; it'll probably be rGHUG.  Also, we're kind of on hold until T85047
[18:54:51] 	 (03PS1) 10M4tx: Make "account exists" message more user-friendly [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/181751 
[18:59:26] 	 3Wikimedia-General-or-Unknown: Don't use deprecated features removed in jQuery 1.9 (tracking) - https://phabricator.wikimedia.org/T67399#943338 (10Mattflaschen)
[18:59:28] 	 3Collaboration-Team, MediaWiki-extensions-PageCuration: Buttons requiring a rationale on Curation toolbar appear to be broken - https://phabricator.wikimedia.org/T84996#943337 (10Mattflaschen) 5Open>3Resolved
[19:01:24] 	 (03PS2) 10M4tx: Make "account exists" message more user-friendly [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/181751 
[19:01:49] 	 3Mobile-Web: VisualEditor JavaScript and tests should only be added if VisualEditor is installed - https://phabricator.wikimedia.org/T85007#943339 (10Florian) 5Open>3Resolved
[19:02:33] 	 3ops-codfw: mw2098 non-responsive to mgmt - https://phabricator.wikimedia.org/T85286#943340 (10Papaul) {F25101}
[19:04:05] 	 3Bot-Requests: Create "readonlybot" account - https://phabricator.wikimedia.org/T85289#943341 (10chasemp) A few people had proposed writing a "proxy" in labs that essentially housed a Phab identity and took anonymous calls and returned their Phab output.  Maybe related or similar, but just a thought as this acco...
[19:05:50] 	 3Bot-Requests: Create "readonlybot" account - https://phabricator.wikimedia.org/T85289#943344 (10chasemp) I am going to wait on creating it as changing the username could leave dangling references but in general seems like an idea worth pursuing to me.
[19:09:28] 	 3MediaWiki-extensions-Echo: EchoTitleLocalCacheTest::testGet fails under HHVM - https://phabricator.wikimedia.org/T78592#943345 (10Mattflaschen) a:3Spage
[19:10:29] 	 last greg-g 
[19:15:37] 	 (03PS1) 10Spage: Fix PageTriage JS dialog parameter [extensions/PageTriage] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/181752 
[19:16:03] 	 (03PS1) 10Spage: Fix PageTriage JS dialog parameter [extensions/PageTriage] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/181753 
[19:29:59] 	 3Multimedia, MediaWiki-extensions-UploadWizard: Titles with percent signs don't get sanitized and are not understood for some reason - https://phabricator.wikimedia.org/T85290#943354 (10MarkTraceur) 3NEW a:3MarkTraceur
[19:32:08] 	 (03CR) 10Spage: [C: 032] "we want to backport this to enwiki as soon as practical" [extensions/PageTriage] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/181753 (owner: 10Spage)
[19:32:22] 	 (03Merged) 10jenkins-bot: Fix PageTriage JS dialog parameter [extensions/PageTriage] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/181753 (owner: 10Spage)
[19:32:53] 	 (03CR) 10Spage: [C: 032] "Want to backport this." [extensions/PageTriage] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/181752 (owner: 10Spage)
[19:33:09] 	 (03Merged) 10jenkins-bot: Fix PageTriage JS dialog parameter [extensions/PageTriage] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/181752 (owner: 10Spage)
[19:34:47] 	 3Collaboration-Team, MediaWiki-extensions-PageCuration: Buttons requiring a rationale on Curation toolbar appear to be broken - https://phabricator.wikimedia.org/T84996#943366 (10Spage)
[19:34:48] 	 3MediaWiki-extensions-PageCuration: JavaScript errors from PageTriage if $wgLegacyJavaScriptGlobals is false - https://phabricator.wikimedia.org/T85184#943369 (10Spage) 5Open>3Resolved Closed by commit rEPTRf379c1eef361.
[19:34:50] 	 3Collaboration-Team, MediaWiki-extensions-PageCuration: Buttons requiring a rationale on Curation toolbar appear to be broken - https://phabricator.wikimedia.org/T84996#936236 (10Spage)
[19:34:52] 	 3MediaWiki-extensions-PageCuration: JavaScript errors from PageTriage if $wgLegacyJavaScriptGlobals is false - https://phabricator.wikimedia.org/T85184#943372 (10Spage) 5Open>3Resolved Closed by commit rEPTR6e3aa2ae32f3.
[19:38:39] 	 (03PS1) 10Legoktm: Fix JSON syntax errors [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/181755 
[19:43:27] 	 (03PS1) 10Legoktm: Remove empty file [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/181756 
[19:44:47] 	 (03CR) 10jenkins-bot: [V: 04-1] Fix JSON syntax errors [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/181755 (owner: 10Legoktm)
[19:47:42] 	 3WMF-Design, Mobile-Web: Polish : Remove active border on search dismiss control for consistency on mobile - https://phabricator.wikimedia.org/T1162#943387 (10Jdlrobson) This should be beta in the alpha mode of the site. I'm still not sure which elements are showing an active border that shouldn't - is it simply...
[19:48:01] 	 (03PS2) 10Legoktm: Fix JSON syntax errors [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/181755 
[19:48:03] 	 (03PS1) 10Legoktm: Remove unused variable declaration [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/181757 
[19:48:11] 	 (03CR) 10jenkins-bot: [V: 04-1] Remove unused variable declaration [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/181757 (owner: 10Legoktm)
[19:48:52] 	 sigh.
[19:52:16] 	 (03PS2) 10Legoktm: Fix jshint and JSON syntax errors [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/181757 
[19:52:31] 	 3Mobile-Web: If Javascript is disabled and an article doesn't have a talk page, we shouldn't show the talk page icon - https://phabricator.wikimedia.org/T69819#943391 (10Jdlrobson) I forget the details of this but I say we just hide the button until JS is enabled. The non-JS experience of Flow doesn't work too w...
[19:52:43] 	 (03Abandoned) 10Legoktm: Fix JSON syntax errors [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/181755 (owner: 10Legoktm)
[19:52:49] 	 (03PS1) 10Spage: Update PageTriage with easy JS fix [core] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/181759 
[19:58:47] 	 (03CR) 10jenkins-bot: [V: 04-1] Update PageTriage with easy JS fix [core] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/181759 (owner: 10Spage)
[20:04:22] 	 [13composer-merge-plugin] 15bd808 opened pull request #1: Add irc integration for Travis CI (06master...06travis) 02https://github.com/wikimedia/composer-merge-plugin/pull/1
[20:05:53] 	 (03PS1) 10MarkTraceur: Move title sanitization into new method [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181760 
[20:06:20] 	 (03PS2) 10MarkTraceur: Move title sanitization into new method [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181760 
[20:07:05] 	 (03CR) 10jenkins-bot: [V: 04-1] Move title sanitization into new method [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181760 (owner: 10MarkTraceur)
[20:13:19] 	 (03PS1) 10Spage: Update PageTriage with easy JS fix [core] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/181761 
[20:13:46] 	 3MediaWiki-Installer, MediaWiki-Core-Team, Librarization: composer.json should be useable by WMF, core and extensions - https://phabricator.wikimedia.org/T67188#943399 (10bd808) The plugin is on packagist now () so it should be a bit easier to test....
[20:19:11] 	 (03CR) 10jenkins-bot: [V: 04-1] Update PageTriage with easy JS fix [core] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/181761 (owner: 10Spage)
[20:32:08] 	 3MediaWiki-User-login-and-signup: mw-createaccount-cta needs to be one line - https://phabricator.wikimedia.org/T62700#943402 (10matmarex) 5Open>3Invalid This has been invalidated by the recent design changes per T85189. The form now looks like this: {F24496}
[20:34:01] 	 3Multimedia, MediaWiki-extensions-Sentry, MediaWiki-ResourceLoader: Create ResourceLoader hook to add new startup modules - https://phabricator.wikimedia.org/T85262#943407 (10Tgr) >>! In T85262#943166, @Legoktm wrote: > Is there a reason this is being implemented as an extension instead of a core feature?  There...
[20:35:59] 	 3UI-Standardization: checkboxes don't show Agora focus highlight - https://phabricator.wikimedia.org/T49902#943409 (10matmarex)
[20:36:18] 	 3UI-Standardization: checkboxes don't show Agora focus highlight - https://phabricator.wikimedia.org/T49902#943412 (10matmarex) 5stalled>3Invalid a:3matmarex Checkboxes have been redone from scratch at least two times since this bug was filed.
[20:38:41] 	 3MediaWiki-HTMLForm, UI-Standardization: Disentangle VForms from HTMLForm code in core - https://phabricator.wikimedia.org/T85285#943415 (10matmarex) a:3matmarex
[20:39:25] 	 (03PS3) 10MarkTraceur: Move title sanitization into new method [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181760 
[20:39:52] 	 3MediaWiki-HTMLForm, UI-Standardization: Implement OOUI "display format" in MediaWiki's HTMLForm - https://phabricator.wikimedia.org/T85291#943417 (10matmarex) 3NEW
[20:40:40] 	 seems like mediawiki-phphunit-hhvm is failing on branch builds in HtmlFormatterTest::testTransform tests, e.g. https://integration.wikimedia.org/ci/job/mediawiki-phpunit-hhvm/523/   Was there a fix or change to MWTidy on the master branch?
[20:41:10] 	 3MediaWiki-User-login-and-signup, UI-Standardization: Convert MW core login/create/reset password pages to OOUI - https://phabricator.wikimedia.org/T74715#943424 (10matmarex)
[20:44:43] 	 MatmaRex: great to see you going into the thicket of VForms / HTMLForm / Agora.  Where is OOUI PHP documented?
[20:45:34] 	 spagewmf: ha-ha
[20:46:01] * marktraceur shudders at every part of that message
[20:46:03] 	 spagewmf: there should be doxygen docs, but they're apparently not being published anywhere
[20:46:15] 	 (you can generate them locally, i guess)
[20:46:22] 	 Obviously you need to edit the jenkins job for doc generation
[20:46:37] 	 there is the JS documentation at https://doc.wikimedia.org/oojs-ui/master/ , PHP is a strict subset of this
[20:47:16] 	 OOUI comes with a neat small demo, that should mostly explain how to write PHP code that uses OOUI
[20:47:47] 	 I'm happy to amuse.  I'm seriously interested and supportive
[20:48:11] 	 spagewmf: real docs (tutorial-like) are being written and reviewed right now, though. there will probably be something to read after christmas :)
[21:08:58] 	 (03CR) 10MarkTraceur: Add tests for tutorial step object (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/180521 (owner: 10MarkTraceur)
[21:24:53] 	 (03PS1) 10GWicke: Update dependencies, especially cassandra-driver [services/restbase/deploy] - 10https://gerrit.wikimedia.org/r/181763 
[21:25:42] 	 (03CR) 10GWicke: [C: 032 V: 032] Update dependencies, especially cassandra-driver [services/restbase/deploy] - 10https://gerrit.wikimedia.org/r/181763 (owner: 10GWicke)
[21:27:48] 	 3Wikidata, wikidata-query-service, MediaWiki-Core-Team: Evaluate Titan as graph storage/query engine for Wikidata Query service - https://phabricator.wikimedia.org/T76373#943426 (10Smalyshev) Proposed storage format for dates:    # Dates are stored as long signed integers, representing number of seconds since 19...
[21:39:43] 	 (03CR) 10Paladox: [C: 032 V: 032] Fix jshint and JSON syntax errors [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/181757 (owner: 10Legoktm)
[21:39:55] 	 (03PS1) 10Paladox: Fix jshint and JSON syntax errors [extensions/CollapsibleVector] (REL1_24) - 10https://gerrit.wikimedia.org/r/181764 
[21:40:07] 	 (03CR) 10Paladox: [C: 032 V: 032] Fix jshint and JSON syntax errors [extensions/CollapsibleVector] (REL1_24) - 10https://gerrit.wikimedia.org/r/181764 (owner: 10Paladox)
[21:41:28] 	 Notification overlay back button behaviour broken - https://phabricator.wikimedia.org/T85292#943427 (10Jdlrobson) 3NEW
[21:43:43] 	 Notification overlay back button behaviour broken - https://phabricator.wikimedia.org/T85292#943433 (10Jdlrobson) (above happens on mobile device) On tablet I get this: {F25120}
[21:52:26] 	 3Wikimedia-Wikimania-Scholarships: Replace application text string for question on contribution to  free knowledge and free software - https://phabricator.wikimedia.org/T78609#943434 (10Shouston_WMF) p:5Low>3Normal No feedback was given on the text, so this task is ready to be implemented.
[21:53:05] 	 3Wikimedia-Wikimania-Scholarships: Replace text string associated with this "impact" question in the review system - https://phabricator.wikimedia.org/T78623#943436 (10Shouston_WMF) p:5Low>3Normal
[21:54:52] 	 3Wikimedia-Wikimania-Scholarships: Replace application text string for question on activity within the Wikimedia movement - https://phabricator.wikimedia.org/T78608#943437 (10Shouston_WMF) p:5Low>3Normal No feedback was given on the text, so this task is ready to be implemented.
[21:55:04] 	 3Wikimedia-Wikimania-Scholarships: Replace text string associated with this "contribution" question in the review system - https://phabricator.wikimedia.org/T78622#943439 (10Shouston_WMF) p:5Low>3Normal No feedback was given on the text, so this task is ready to be implemented.
[21:55:30] 	 3Wikimedia-Wikimania-Scholarships: Create new application question on "Collaborations" - https://phabricator.wikimedia.org/T78611#943441 (10Shouston_WMF) p:5Low>3Normal No feedback was given on the text, so this task is ready to be implemented.
[21:57:44] 	 3Wikimedia-Wikimania-Scholarships: Create new application question on "Sharing of experiences and learnings" - https://phabricator.wikimedia.org/T78613#943443 (10Shouston_WMF) p:5Low>3Normal No feedback was given on the text, so this task is ready to be implemented.
[22:09:57] 	 3MediaWiki-Installer: Unable to install MediaWiki via web installer if mysql user has empty password - https://phabricator.wikimedia.org/T85281#943446 (10Nemo_bis) Introduced in 0cf4e92d for T45528 / T61663.
[22:21:21] 	 (03PS1) 10GWicke: Update dependencies again [services/restbase/deploy] - 10https://gerrit.wikimedia.org/r/181766 
[22:21:32] 	 (03CR) 10GWicke: [C: 032 V: 032] Update dependencies again [services/restbase/deploy] - 10https://gerrit.wikimedia.org/r/181766 (owner: 10GWicke)
[22:22:46] 	 [13composer-merge-plugin] 15legoktm closed pull request #1: Add irc integration for Travis CI (06master...06travis) 02https://github.com/wikimedia/composer-merge-plugin/pull/1
[22:23:27] 	 omg
[22:23:30] 	 stalker!
[22:25:11] 	 do we run that bot?
[22:26:22] 	 wikimedia/composer-merge-plugin#2 (master - c435aa5 Kunal Mehta): The build passed. - http://travis-ci.org/wikimedia/composer-merge-plugin/builds/45059983
[22:27:10] 	 yeah
[22:33:24] 	 (03PS71) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 
[22:34:57] 	 (03CR) 10Paladox: "I added array to fix the issue in mwext-WikiEditor-phpcs-HEAD saying long line causing the test to come out with an error." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (owner: 10Paladox)
[22:37:58] 	 (03PS36) 10Paladox: WikiEditor: Convert .css to .less and add Arrow SVG images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151616 
[22:39:09] 	 (03CR) 10Paladox: "I added array to fix the issue in mwext-WikiEditor-phpcs-HEAD saying long line causing the test to come out with an error." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151616 (owner: 10Paladox)
[22:53:41] 	 (03PS1) 10Paladox: Localisation updates from https://translatewiki.net. [skins/Metrolook] (REL1_23) - 10https://gerrit.wikimedia.org/r/181767 
[22:54:02] 	 (03CR) 10Paladox: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [skins/Metrolook] (REL1_23) - 10https://gerrit.wikimedia.org/r/181767 (owner: 10Paladox)
[22:54:04] 	 (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/Metrolook] (REL1_23) - 10https://gerrit.wikimedia.org/r/181767 (owner: 10Paladox)
[22:54:39] 	 (03PS1) 10Paladox: Localisation updates from https://translatewiki.net. [skins/Metrolook] (REL1_24) - 10https://gerrit.wikimedia.org/r/181768 
[22:54:52] 	 (03CR) 10Paladox: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [skins/Metrolook] (REL1_24) - 10https://gerrit.wikimedia.org/r/181768 (owner: 10Paladox)
[22:56:30] 	 3Wikidata, wikidata-query-service, MediaWiki-Core-Team: Evaluate Titan as graph storage/query engine for Wikidata Query service - https://phabricator.wikimedia.org/T76373#943453 (10GWicke) >>! In T76373#943426, @Smalyshev wrote: > Proposed storage format for dates: >  >   # Dates are stored as long signed intege...
[23:02:40] 	 3Wikidata, wikidata-query-service, MediaWiki-Core-Team: Evaluate Titan as graph storage/query engine for Wikidata Query service - https://phabricator.wikimedia.org/T76373#943454 (10Smalyshev) @GWicke Do we really need per-second precision transitioning between year 292M and 292M+1? I'm not sure it is ever requir...
[23:05:35] 	 3MediaWiki-extensions-ProofreadPage: Mobile-view for Wikisource needs the basic linkage for transcluded works to facilitate Proofreading in Page: namespace - https://phabricator.wikimedia.org/T85118#943457 (10GOIII) I understand under normal Desktop mode, the side-bar portlet //Display options// hosts some forma...
[23:08:30] 	 3Wikidata, wikidata-query-service, MediaWiki-Core-Team: Evaluate Titan as graph storage/query engine for Wikidata Query service - https://phabricator.wikimedia.org/T76373#943458 (10GWicke) >>! In T76373#943454, @Smalyshev wrote: > seconds(292M-12-31T23:59:59) < seconds(292M+1)  It's pretty likely that there were...
[23:10:36] 	 (03PS1) 10Ori.livneh: [WIP] Add client API [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/181769 
[23:11:23] 	 3Wikidata, wikidata-query-service, MediaWiki-Core-Team: Evaluate Titan as graph storage/query engine for Wikidata Query service - https://phabricator.wikimedia.org/T76373#943459 (10Smalyshev) For dates beyond real Gregorian calendar, the values more precise than years have little meaning anyway, so I don't think...
[23:27:14] 	 3Wikidata, wikidata-query-service, MediaWiki-Core-Team: Evaluate Titan as graph storage/query engine for Wikidata Query service - https://phabricator.wikimedia.org/T76373#943462 (10GWicke) >>! In T76373#943459, @Smalyshev wrote: > For dates beyond real Gregorian calendar, the values more precise than years have...
[23:57:57] 	 3Wikidata, wikidata-query-service, operations, MediaWiki-General-or-Unknown, Services: Reliable publish / subscribe event bus - https://phabricator.wikimedia.org/T84923#943464 (10JanZerebecki) >>! In T84923#942248, @GWicke wrote: >>>! In T84923#940155, @JanZerebecki wrote: >> The actual data can be pulled by the...
[23:59:17] 	 (03CR) 10Spage: [C: 032] "deploy it to unbreak PageTriage" [core] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/181761 (owner: 10Spage)