[00:00:06] (03PS3) 10Krinkle: exception: Implement error-json log [core] - 10https://gerrit.wikimedia.org/r/177095 [00:00:14] (03PS4) 10Krinkle: exception: Hide suppressed errors in 'error' log, flag in 'error-json' [core] - 10https://gerrit.wikimedia.org/r/177096 [00:00:36] 3Wikimedia-General-or-Unknown: Empty respond for fawikinews recentchanges (works when using debug=true) - https://phabricator.wikimedia.org/T78776#934427 (10greg) @Mjbmr are you still seeing this issue on any pages? [00:00:51] 3Performance-Metrics-Dashboard: Familiarize yourself with edit-reportcard.wmflabs.org - https://phabricator.wikimedia.org/T84949#934428 (10Krinkle) [00:01:33] (03PS1) 10Legoktm: make-release: Fetch composer dependencies for core 1.25+ [tools/release] - 10https://gerrit.wikimedia.org/r/181004 [00:03:16] (03PS2) 10Legoktm: make-release: Fetch composer dependencies for core 1.25+ [tools/release] - 10https://gerrit.wikimedia.org/r/181004 [00:03:47] (03PS2) 10Jforrester: OOjs UI: Pull in I959ade244 from v0.5.0 for cherry-pick [core] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/180860 [00:05:51] (03CR) 10jenkins-bot: [V: 04-1] Update test.wikidata, fix Special:NewItem/Property and SetSiteLink [core] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/181003 (owner: 10Aude) [00:06:05] oh :/ [00:06:31] 00:04:19 MWException: MWTidy::clean: error text return from HHVM tidy is not supported [00:06:33] what? [00:06:37] aude: ^ [00:06:42] We can override, though [00:06:50] not specific to us [00:07:09] i saw something about MWTidy but don't really know exactly waht is going on [00:07:12] hhvm issue? [00:07:40] possibly [00:07:51] aude: hoo https://gerrit.wikimedia.org/r/#/c/180913/ [00:07:54] 3Continuous-Integration, MediaWiki-General-or-Unknown, Mobile-Web: QUnit job unable to collect logs, test still has active http requests writing to them - https://phabricator.wikimedia.org/T78590#934443 (10Jdlrobson) @Krinkle this is not the same bug. What does a log file running out of space have to do with te... [00:08:24] ERROR! It seems this job introduced a regression although it might be caused by a previous commit. in 8m 00s [00:08:28] did you see that? [00:08:28] 3Continuous-Integration, MediaWiki-General-or-Unknown, Mobile-Web: QUnit job unable to collect logs, test still has active http requests writing to them - https://phabricator.wikimedia.org/T78590#934444 (10Jdlrobson) (you'll see the tests pass but it is Archiving artifacts that fails) [00:08:38] (03PS2) 10Tim Starling: API: Avoid MySQL filesort with list=allpages&apfilterlanglinks=withlanglinks [core] - 10https://gerrit.wikimedia.org/r/179146 (owner: 10Anomie) [00:08:43] looks like just a time out [00:08:50] might be ok [00:09:01] (03CR) 10Tim Starling: [C: 032] "Fixing it for the servers we use at the moment is a good start." [core] - 10https://gerrit.wikimedia.org/r/179146 (owner: 10Anomie) [00:09:11] aude: That is post merge, no one cares for that :/ [00:09:19] sadly [00:09:21] greg-g: Is that planned to be backported [00:09:34] (03PS1) 10Jforrester: Update VE and MF for T78710 [core] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/181005 [00:09:48] (03CR) 10jenkins-bot: [V: 04-1] Update VE and MF for T78710 [core] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/181005 (owner: 10Jforrester) [00:10:14] 3Wikimedia-General-or-Unknown: Convert Oversight revisions to (revision deleted) suppressed on Wikimedia wikis - https://phabricator.wikimedia.org/T62373#934446 (10Reedy) @Krenair I guess it's worth testing it locally again to make sure it's doing what was expected... Also, looking at more entries would be bene... [00:10:15] hoo: hmm, right, probably should [00:10:20] hoo: comment on the change, please [00:10:39] 3Continuous-Integration, MediaWiki-General-or-Unknown, Mobile-Web: QUnit job unable to collect logs, test still has active http requests writing to them - https://phabricator.wikimedia.org/T78590#934447 (10Jdlrobson) (Running locally I'm seeing no ajax requests. I just verified that again.) [00:10:55] (03CR) 10Hoo man: "@Ori: I'm pretty sure this should be backported to wmf13..." [core] - 10https://gerrit.wikimedia.org/r/180913 (owner: 10Ori.livneh) [00:10:59] ori: ^ [00:11:07] wmf12 is also broken [00:11:08] 3Continuous-Integration, MediaWiki-General-or-Unknown, Mobile-Web: QUnit job unable to collect logs, test still has active http requests writing to them - https://phabricator.wikimedia.org/T78590#934449 (10Krinkle) >>! In T78590#934443, @Jdlrobson wrote: > @Krinkle this is not the same bug. > What does a log fi... [00:11:13] oh really? [00:11:17] yes [00:11:37] https://gerrit.wikimedia.org/r/#/c/181000/ [00:11:56] (03CR) 10Hoo man: "and wmf12 as well, apparently" [core] - 10https://gerrit.wikimedia.org/r/180913 (owner: 10Ori.livneh) [00:12:10] greg-g: how can that happen? Was the original change cherry-picked? [00:12:25] Or did the tests "improve" [00:12:36] I'm not sure, I wasn't totally aware of it, o.ri is your best person to ask [00:12:44] 3Shop-Theme: Add "create account" and "log in" - https://phabricator.wikimedia.org/T84935#934452 (10Prtksxna) I don't think I'll need mockups. We could iterate over them once I've implemented it incase of any changes. [00:12:49] could also be an issue with the hhvm test setup [00:12:56] i really don't know [00:13:01] possible [00:13:05] 3Shop-Theme: Add "create account" and "log in" - https://phabricator.wikimedia.org/T84935#934453 (10Prtksxna) a:5violetto>3Prtksxna [00:13:19] we should just ignore it for our submodule updates for now [00:13:25] sure [00:13:27] (03CR) 10jenkins-bot: [V: 04-1] OOjs UI: Pull in I959ade244 from v0.5.0 for cherry-pick [core] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/180860 (owner: 10Jforrester) [00:13:28] but certainly needs to be acted upon [00:13:31] safe to say it is unrelated [00:13:36] 3Multimedia, MediaWiki-File-management, Beta-Cluster: Thumbnail generation should happen via the same setup in the beta cluster and in production - https://phabricator.wikimedia.org/T84950#934455 (10Tgr) 3NEW [00:13:40] but overruling jenkins is nasty [00:13:45] so should be sorted out asap [00:13:46] James_F: Welcome to the unrelated-test-failures-party ;) [00:13:54] hoo: Yeah. :-( [00:14:30] 3Shop-Theme: Add instagram feed on homepage - https://phabricator.wikimedia.org/T76858#934462 (10Prtksxna) I am now pulling some images on the [[ https://wmf-test-shop.myshopify.com/ | test shop ]]. I'll make a setting to change the hashtag and to remove the instagram section completely. I also still need to pos... [00:15:13] (03PS2) 10Jforrester: Update VE and MF for T78710 [core] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/181005 [00:16:55] (03CR) 10Tim Starling: [C: 04-1] "The thing with array_keys($pairs) was cute in Parser::preSaveTransform(), which is called once per request, but less endearing here, in a " [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/180022 (owner: 10Anomie) [00:17:06] (03Merged) 10jenkins-bot: API: Avoid MySQL filesort with list=allpages&apfilterlanglinks=withlanglinks [core] - 10https://gerrit.wikimedia.org/r/179146 (owner: 10Anomie) [00:18:25] 3Continuous-Integration, MediaWiki-General-or-Unknown, Mobile-Web: QUnit job unable to collect logs, test still has active http requests writing to them - https://phabricator.wikimedia.org/T78590#934465 (10Jdlrobson) @krinkle I'm not seeing anything obvious so if you can find the time to take a look at our tests... [00:19:05] 3Multimedia, MediaWiki-File-management, Beta-Cluster: Thumbnail generation should happen via the same setup in the beta cluster and in production (tracking) - https://phabricator.wikimedia.org/T84950#934466 (10greg) p:5Triage>3Normal [00:20:07] 3Multimedia, MediaWiki-File-management, Beta-Cluster: Thumbnail generation should happen via the same setup in the beta cluster and in production (tracking) - https://phabricator.wikimedia.org/T84950#934455 (10greg) [00:20:28] (03CR) 10MaxSem: [C: 032 V: 032] OOjs UI: Pull in I959ade244 from v0.5.0 for cherry-pick [core] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/180860 (owner: 10Jforrester) [00:20:30] 3Multimedia, MediaWiki-File-management, Beta-Cluster: Thumbnail generation should happen via the same setup in the beta cluster and in production (tracking) - https://phabricator.wikimedia.org/T84950#934455 (10greg) [00:21:01] (03CR) 10jenkins-bot: [V: 04-1] Update VE and MF for T78710 [core] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/181005 (owner: 10Jforrester) [00:21:28] Yes, Jenkins, I love you too. [00:22:08] :D [00:22:12] (03CR) 10Tim Starling: [C: 032] Don't break autolinks by stripping the final semicolon from an entity. [core] - 10https://gerrit.wikimedia.org/r/179185 (owner: 10Cscott) [00:23:29] 3Multimedia, MediaWiki-File-management, Beta-Cluster: Thumbnail generation should happen via the same setup in the beta cluster and in production (tracking) - https://phabricator.wikimedia.org/T84950#934481 (10greg) [00:23:42] 3Project-Creators, Community-Engagement: Community Engagement Project page - https://phabricator.wikimedia.org/T420#934482 (10Quiddity) I had locked it, because we were planning on putting all our tasks on here, including details about work that wasn't public yet. I was under the impression that Herald was going... [00:23:54] 3Multimedia, MediaWiki-File-management, Beta-Cluster: Thumbnail generation should happen via the same setup in the beta cluster and in production (tracking) - https://phabricator.wikimedia.org/T84950#934455 (10greg) [00:25:47] (03CR) 10MaxSem: [C: 032 V: 032] Update Wikidata, fix for Special:SetSiteLink [core] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/181000 (owner: 10Aude) [00:26:07] (03CR) 10MaxSem: [C: 032 V: 032] Update test.wikidata, fix Special:NewItem/Property and SetSiteLink [core] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/181003 (owner: 10Aude) [00:27:53] (03PS1) 10Ori.livneh: Refactor [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/181006 [00:29:29] (03PS2) 10Ori.livneh: Refactor [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/181006 [00:29:30] 3Mobile-Web, WMF-Design: Polish : rules in mobile sidebar do not extend to screen edge - https://phabricator.wikimedia.org/T1161#934486 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson [00:30:34] (03CR) 10Tim Starling: "There's still no customised convolution matrix, right? Jcupitt said on the bug that he would add an option for it. I guess we can merge th" [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/62233 (https://bugzilla.wikimedia.org/47311) (owner: 10btongminh) [00:34:07] 3MediaWiki-Recent-changes: Hide specific user in recent changes - https://phabricator.wikimedia.org/T63173#934494 (10XXN) p:5Low>3Normal [00:34:27] 3MediaWiki-Recent-changes: Hide specific user in recent changes - https://phabricator.wikimedia.org/T63173#662579 (10XXN) Update: This thing can be very usefull to monitor recent edits by bots If a bot made several thousands of edits in last 2-3 hours, in recent changes you will see almost only his edits &limit=... [00:35:20] 3MediaWiki-Core-Team, Librarization: Librarization wishlist cleanup - https://phabricator.wikimedia.org/T1118#934497 (10aaron) [00:35:53] (03CR) 10jenkins-bot: [V: 04-1] Refactor [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/181006 (owner: 10Ori.livneh) [00:37:52] ori: In what way would EL break if it uses objects instead of arrays? Or would it just be a few character replacements for property access? [00:38:07] ori: I converted core to objects for objects so that it will rountrip them properly. [00:38:12] because assoc makes it blind. [00:38:42] 3MediaWiki-extensions-Flow: API result for submodule=new-topic: no easy way to get info about the just-posted topic - https://phabricator.wikimedia.org/T78746#934518 (10Spage) As [[ https://www.mediawiki.org/wiki/Flow/Architecture/API#Block_requests | Architecture/Flow/API]] now says, add ntmetadataonly=true to... [00:42:01] (03Merged) 10jenkins-bot: Don't break autolinks by stripping the final semicolon from an entity. [core] - 10https://gerrit.wikimedia.org/r/179185 (owner: 10Cscott) [00:47:06] 3Wikidata, MediaWiki-Interface, MediaWiki-skins-Vector: Wikidata shouldn't print two headings - https://phabricator.wikimedia.org/T78560#934534 (10Jdlrobson) ViewEntityAction does seem to be getting called... It seems FingerprintView::getHtmlForLabel is where the title gets added to the page. Ideally this shoul... [00:47:14] 3Collaboration-Team, MediaWiki-extensions-Flow: Flow new-header API result different from commit message - https://phabricator.wikimedia.org/T84954#934535 (10Spage) 3NEW a:3EBernhardson [00:47:20] (03CR) 10Krinkle: "The old method is still there so there's no immediate need to migrate. But given we don't want to use deprecated methods in EventLogging, " [core] - 10https://gerrit.wikimedia.org/r/180771 (owner: 10QChris) [00:48:15] 3Wikimedia-General-or-Unknown: RT tickets hide status information from volunteers and staff alike - https://phabricator.wikimedia.org/T32413#934543 (10MZMcBride) 5declined>3Resolved [00:51:18] 3Wikimedia-Wikimania-Scholarships: Update countries database to reflect Global North/South - https://phabricator.wikimedia.org/T84869#934548 (10MZMcBride) This ticket has no description. What is this about? Is this task related to some other task? Broadly, please refrain from using "Global North" or "Global Sou... [00:52:19] (03CR) 10Gergő Tisza: [C: 031] Refactor [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/181006 (owner: 10Ori.livneh) [00:54:19] (03PS1) 10Legoktm: Don't create Language objects during ResourceLoader tests [core] - 10https://gerrit.wikimedia.org/r/181009 [00:56:30] 3Multimedia, Project-Creators: Create MediaWiki-extensions-Sentry project - https://phabricator.wikimedia.org/T84955#934554 (10Tgr) 3NEW a:3Tgr [00:57:14] 3Multimedia: Puppetize Sentry - https://phabricator.wikimedia.org/T84956#934562 (10Tgr) 3NEW a:3Tgr [00:57:22] 3Wikimedia-Wikimania-Scholarships: Update countries database to reflect Global North/South - https://phabricator.wikimedia.org/T84869#934570 (10bd808) >>! In T84869#934548, @MZMcBride wrote: > This ticket has no description. What is this about? Is this task related to some other task? This is a task for the Wik... [00:57:32] (03CR) 10MaxSem: [C: 032 V: 032] Update VE and MF for T78710 [core] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/181005 (owner: 10Jforrester) [00:57:58] 3Multimedia: Vagrantize Sentry - https://phabricator.wikimedia.org/T84957#934575 (10Tgr) 3NEW a:3Tgr [00:58:30] 3Wikimedia-Wikimania-Scholarships: Update countries database to reflect Global North/South - https://phabricator.wikimedia.org/T84869#934583 (10MZMcBride) >>! In T84869#934570, @bd808 wrote: > This is a task for the Wikimania Scholarships application as is clearly marked in the **Projects** this task is associat... [01:00:11] 3Wikimedia-Site-requests, Wikidata: Enable 'other projects' from Wikidata on itwikipedia - https://phabricator.wikimedia.org/T77012#934584 (10Dereckson) 5Open>3Resolved Merged. [01:00:51] 3Wikimedia-Site-requests, Wikidata: Enable 'other projects' from Wikidata on itwikipedia - https://phabricator.wikimedia.org/T77012#934587 (10Dereckson) [01:00:54] 3Collaboration-Team, MediaWiki-extensions-Flow: Flow: should not override global h1 and h2 style - https://phabricator.wikimedia.org/T61636#934588 (10Quiddity) [01:01:07] 3Wikimedia-Logstash, operations, ops-core: Production hardware for Logstash service - https://phabricator.wikimedia.org/T84958#934590 (10Gage) 3NEW [01:01:49] 3Wikimedia-Wikimania-Scholarships: Update countries database to reflect Global North/South - https://phabricator.wikimedia.org/T84869#934601 (10bd808) >>! In T84869#934583, @MZMcBride wrote: >>>! In T84869#934570, @bd808 wrote: >> This is a task for the Wikimania Scholarships application as is clearly marked in... [01:04:27] 3Wikimedia-Logstash, operations, ops-core: Production hardware for Logstash service - https://phabricator.wikimedia.org/T84958#934603 (10Gage) [01:04:29] 3Engineering-Community: Announce January 6th Tech Talk - https://phabricator.wikimedia.org/T78353#934606 (10Rfarrand) This tech talk has been announced on wikitech-l, engineering@, facebook & twitter [01:04:35] 3MediaWiki-Core-Team, Wikimedia-Logstash, operations: Improve logstash - https://phabricator.wikimedia.org/T84895#934609 (10Gage) I've created a separate task for {T84958} [01:04:39] 3Engineering-Community: Announce January 6th Tech Talk - https://phabricator.wikimedia.org/T78353#934611 (10Rfarrand) 5Open>3Resolved [01:14:14] 3Wikimedia-Logstash: Add Hadoop mapreduce logfiles to logstash - https://phabricator.wikimedia.org/T63790#934625 (10bd808) a:3Gage I think this is done now (w00t!) by assigning to @gage for verification and proper attribution. [01:16:55] (03PS1) 10MaxSem: Bump MF [core] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/181013 [01:17:18] (03CR) 10MaxSem: [C: 032 V: 032] Bump MF [core] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/181013 (owner: 10MaxSem) [01:17:29] 3Wikimedia-Site-requests, Wikidata: Enable 'other projects' from Wikidata on itwikipedia - https://phabricator.wikimedia.org/T77012#934630 (10aude) deployed! https://it.wikipedia.org/wiki/MediaWiki:InterProject.js probably not needed now [01:18:19] AaronSchulz: Krenair is trying to write a virtualrest backend, his wip code is at https://gerrit.wikimedia.org/r/#/c/181011/1/ParsoidVirtualRESTService.php [01:18:47] his onResponses method is never called for some reason [01:19:21] do you see anything obviously wrong in there? [01:23:24] 3Wikimedia-Logstash, operations, ops-core: Production hardware for Logstash service - https://phabricator.wikimedia.org/T84958#934643 (10bd808) - several system log candidates are listed on T63779 - {T62689} - {T64177} - {T63782} - {T63780} - {T6} would be low volume but useful. - {T64505} From past... [01:25:46] Krenair: do you still see the error you saw earlier? [01:26:31] The one about 'response' being undefined when I undo my hack to core? [01:26:42] yes [01:26:53] was that from onResponses? [01:28:48] (03PS1) 10Aaron Schulz: Fix comment typo [core] - 10https://gerrit.wikimedia.org/r/181014 [01:30:32] Krenair: I'm heading out now, but will try to take a closer look later in case you haven't figured it out by then [01:30:43] ok, thanks [01:30:55] 3MediaWiki-Vagrant: Execution of config_version command `/vagrant/puppet/extra/config-version` failed - https://phabricator.wikimedia.org/T84961#934759 (10Tgr) 3NEW [01:31:07] that was from VirtualRESTServiceClient::run [01:31:16] I would be setting up a 'response' key in onResponses [01:31:25] which should fix it? [01:31:26] but onResponses does not get called [01:31:28] (03CR) 10Legoktm: [C: 032] Fix comment typo [core] - 10https://gerrit.wikimedia.org/r/181014 (owner: 10Aaron Schulz) [01:32:50] Krenair: I would instrument VirtualRESTServiceClient.php to see how far it gets [01:33:19] I did [01:33:30] I found $replaceReqsByService was empty [01:34:24] $replaceReqsByService is supposed to have stuff in it set when we're dealing with a virtual HTTP URL, not absolute [01:35:02] so your request is for /parsoid/something, right? [01:35:08] yes [01:36:11] (03PS2) 10Aaron Schulz: Fixed comment typo and other docs tweaks [core] - 10https://gerrit.wikimedia.org/r/181014 [01:37:44] Krenair: I got to run now, will have a look tomorrow if I don't get to it tonight [01:38:21] array( 'headers' => $params ) should be 'headers' => $params btw [01:38:46] thanks [01:39:29] (03CR) 10MaxSem: [C: 032] Fixed comment typo and other docs tweaks [core] - 10https://gerrit.wikimedia.org/r/181014 (owner: 10Aaron Schulz) [01:40:27] (03PS1) 10Yurik: Updated ZeroPortal to master [core] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/181015 [01:40:43] What is the index.php &autoclick=wpSave suppose to do? [01:41:18] (03CR) 10Yurik: [C: 032] Updated ZeroPortal to master [core] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/181015 (owner: 10Yurik) [01:41:24] other parameters? [01:42:12] we do hit isset( $servReqs[$index] ) || isset( $origPending[$index] ) [01:42:43] which explains why the entry doesn't make it into newReplaceReqsByService [01:42:53] ebernhardson, you around? [01:44:06] /index.php?action=edit&oldid=200476215&autoclick=wpSave&autosummary=foo&title=User:Example [01:44:25] 3Collaboration-Team, MediaWiki-extensions-Flow: Flow new-header API result different from commit message - https://phabricator.wikimedia.org/T84954#935340 (10Spage) [01:45:29] (03Merged) 10jenkins-bot: Fixed comment typo and other docs tweaks [core] - 10https://gerrit.wikimedia.org/r/181014 (owner: 10Aaron Schulz) [01:46:00] T13|mobile: I think that's from a gadget. Popups or lupin's AVT [01:46:40] (03CR) 10jenkins-bot: [V: 04-1] Updated ZeroPortal to master [core] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/181015 (owner: 10Yurik) [01:46:42] 3MediaWiki-Core-Team: Authn and authz as a service - https://phabricator.wikimedia.org/T84962#935456 (10Chad) 3NEW [01:46:43] 3MediaWiki-Core-Team: Authn and authz as a service - https://phabricator.wikimedia.org/T84962#935456 (10Chad) [01:47:04] Thanks legoktm [01:47:45] (03CR) 10Yurik: "recheck" [core] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/181015 (owner: 10Yurik) [01:47:58] grr, jenkins, be nice! [01:49:05] any ideas AaronSchulz? [01:51:56] MaxSem, any reasons why i shouldn't force it^ [01:52:08] Krenair: try using 'url' => ..., 'method' => ... instead of indexes 0 and 1? [01:52:41] (03CR) 10Yurik: [V: 032] Updated ZeroPortal to master [core] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/181015 (owner: 10Yurik) [01:52:59] Krenair: no, that can't be it [01:53:04] onResponsess till didn't get called [01:53:06] I'm doing that with swift and it works [01:54:47] what does the caller look like? [01:55:35] caller of what? [01:56:05] run() or runMulti() [01:56:22] that's just ApiVisualEditor::requestParsoid [01:56:35] in the same commit [01:56:51] I wasn't sure if you were testing this more directly [01:57:00] nope [01:59:29] [13cssjanus] 15Krinkle pushed 1 new commit to 06master: 02https://github.com/cssjanus/cssjanus/commit/efed0a45304f3a62e757e60bb8aa729495da0dfc [01:59:29] 13cssjanus/06master 14efed0a4 15Timo Tijhof: readme: Update badges... [02:00:16] Krenair: when does $replaceReqsByService become empty? [02:00:40] $replaceReqsByService = $newReplaceReqsByService; [02:00:52] [13php-cssjanus] 15Krinkle pushed 1 new commit to 06master: 02https://github.com/cssjanus/php-cssjanus/commit/784d395b8862a79d9e07f2bdf61ed4869ff87219 [02:00:52] 13php-cssjanus/06master 14784d395 15Timo Tijhof: readme: Update badges... [02:00:54] cssjanus/cssjanus#65 (master - efed0a4 Timo Tijhof): The build passed. - http://travis-ci.org/cssjanus/cssjanus/builds/44534275 [02:01:24] so basically once it's gone through onRequests and done some... strange processing of the result that I admittedly don't fully understand [02:01:32] we hit if ( isset( $servReqs[$index] ) || isset( $origPending[$index] ) ) [02:01:42] and both of those possible conditions are true [02:02:48] cssjanus/php-cssjanus#38 (master - 784d395 Timo Tijhof): The build passed. - http://travis-ci.org/cssjanus/php-cssjanus/builds/44534358 [02:04:08] (03PS3) 10Ori.livneh: Refactor [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/181006 [02:04:20] (03CR) 10jenkins-bot: [V: 04-1] Refactor [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/181006 (owner: 10Ori.livneh) [02:05:34] Krenair: there are two lines like that, I assume it's the first one...what is $doneReqs then? [02:06:40] Krinkle: the deprecation notice for getJsonData are causing EL unit tests to fail [02:06:49] AaronSchulz, yes, the first [02:07:12] AaronSchulz, $doneReqs is just a list of requests that have been completed [02:07:46] requests are considered completed from within onRequests if they get a 'response' key set [02:09:00] I mean what was the actual value [02:09:12] 3MediaWiki-Vagrant: Execution of config_version command `/vagrant/puppet/extra/config-version` failed - https://phabricator.wikimedia.org/T84961#935513 (10Tgr) It seems that the NFS mount for `/vagrant` is not set up, the errors are only a consequence of that. Upon subsequent attempts (`vagrant destroy`, `rm -r... [02:11:25] Krenair: ^ [02:12:04] (03PS1) 10Ori.livneh: Temporarily re-add JsonSchemaContent::getJsonData [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/181019 [02:12:32] 3MediaWiki-extensions-OAuth: Allow hiding OAuth edits in Recent Changes - https://phabricator.wikimedia.org/T66829#935514 (10Closeapple) If there is an edit speed/amount which is still safe for non-bots, but annoying to watchlist users: Couldn't we just request that interface tools allow the user to mark their e... [02:13:22] AaronSchulz, empty before first replaceReqsByService loop, empty afterwards too [02:14:19] Krenair: what about $executeReqs before http->runMulti() ? [02:14:31] 3MediaWiki-General-or-Unknown: HHVM: segfault when serializing/unserializing large preprocessor cache items - https://phabricator.wikimedia.org/T73486#935517 (10ori) [02:14:32] 3MediaWiki-Core-Team, operations: HHVM is segfaulting 1/hour/server in production - https://phabricator.wikimedia.org/T78771#935516 (10ori) [02:14:51] 3Collaboration-Team, MediaWiki-extensions-Flow: Editing Flow board header doesn't set keyboard focus and textarea is compressed - https://phabricator.wikimedia.org/T84963#935520 (10Spage) 3NEW [02:15:09] AaronSchulz, that has the entry [02:15:39] we already knew it was getting executed [02:16:57] does MultiHttpClient actually have a valid return value? [02:18:42] 3Performance-Metrics-Dashboard: Familiarize yourself with edit-reportcard.wmflabs.org - https://phabricator.wikimedia.org/T84949#935530 (10Memeht) Great, I'm on it. [02:19:32] AaronSchulz, $this->http->runMulti( $executeReqs ) returns the result I expect, yes [02:19:42] but onResponses is not run [02:20:13] 3Performance-Metrics-Dashboard: Familiarize yourself with edit-reportcard.wmflabs.org - https://phabricator.wikimedia.org/T84949#935531 (10Jdforrester-WMF) https://wikitech.wikimedia.org/wiki/Analytics/Dashboards is the documentation specifically about dasboards. [02:20:40] If I comment out that first if ( isset( $servReqs[$index] ) || isset( $origPending[$index] ) ) { and just leave the contents of the else, it works [02:20:45] and onResponses is called [02:20:47] I think I see the problem [02:20:58] onResponses is only called on replacement requests (e.g. with new IDs) [02:21:45] You are mangling original ones, not replacing them. I'm trying to figure out if there was a reason it was that way or if that's an oversight. [02:23:00] Krenair: why do you want to mangle responses (or do something else)? [02:23:15] there is no code in there yet, so I don't know what the goal will be [02:23:30] ori: Let me guess, you were looking to change deprecation warnings in localsettings earlier to not affect the current release? [02:24:05] Krinkle: no, my question then had nothing to do with the EventLogging getData deprecation warning [02:24:09] k [02:24:26] ori: ok, so aside from deprecation warning and access syntax, does EL need it to be an array for anything? [02:24:49] AaronSchulz, I need to set up a 'response' key at the end [02:24:53] on each request [02:25:24] VirtualRESTServiceClient::run requires it [02:25:38] return $req[0]['response']; [02:27:13] Krinkle: I don't remember all the places off the top of my head, but I think there are a number of places that expect it to be an array. The JSON Schema validation library, for one. [02:29:48] Krenair: anyway, seems like there should be a $execReqsByService for the second loop to over so onReponse is called for non-replaced requests too [02:30:00] * AaronSchulz can add that to his todo list [02:31:14] (03PS1) 10Yurik: Updated ZeroPortal to master [core] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/181023 [02:31:27] (03CR) 10Yurik: [C: 032 V: 032] Updated ZeroPortal to master [core] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/181023 (owner: 10Yurik) [02:35:18] 3RESTBase, VisualEditor-MediaWiki, VisualEditor, Scrum-of-Scrums, MediaWiki-General-or-Unknown, Parsoid, MediaWiki-extensions-Flow: Use PHP Virtual REST Service to access Parsoid - https://phabricator.wikimedia.org/T1218#935534 (10Krenair) I ran into issues with the way I was trying to use VirtualRESTService. My... [02:37:04] (03PS1) 10Yurik: Updated ZeroPortal to master [core] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/181025 [02:37:18] (03CR) 10Yurik: [C: 032 V: 032] Updated ZeroPortal to master [core] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/181025 (owner: 10Yurik) [02:40:28] 3MediaWiki-General-or-Unknown: HHVM: segfault when serializing/unserializing large preprocessor cache items - https://phabricator.wikimedia.org/T73486#935535 (10swtaarrs) Someone's already doing option (b) internally, which will at least turn segfaults into fatal errors. I'll let you know when the fix makes it o... [02:58:38] I will let you know when I see Tparis around here [02:58:38] @notify Tparis [03:00:05] @seen Tparis [03:00:05] T13|mobile: Last time I saw Tparis they were quitting the network with reason: no reason was given N/A at 12/1/2014 8:01:53 AM (17d18h58m11s ago) [03:00:14] :/ [03:02:39] (03CR) 10Tim Starling: [C: 04-1] "Looks good, just -1 for a minor inline comment." (031 comment) [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/178903 (owner: 10Manybubbles) [03:04:42] 3Wikimedia-General-or-Unknown: Empty respond for fawikinews recentchanges (works when using debug=true) - https://phabricator.wikimedia.org/T78776#935543 (10Mjbmr) The issue was resolved right after my last comment but it was odd. so please make sure it won't happen again 'cause people mostly won't append anythi... [03:12:34] (03CR) 10Tim Starling: "Should this be abandoned? Both Krinkle and Brad seemed to be against it on the bug." [core] - 10https://gerrit.wikimedia.org/r/105103 (https://bugzilla.wikimedia.org/38365) (owner: 10Jackmcbarn) [03:20:08] betacommand how do we install diff into our path to get mw-config to find GnuWin32/bin/file.exe and patch gnu diff3 can't be found error? [03:20:32] jehovahsays: what are you trying to do? [03:21:33] (03PS2) 10Tim Starling: Use a metatable when os.date("*t") is called [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/143627 (owner: 10Jackmcbarn) [03:21:40] (03CR) 10Tim Starling: [C: 032] Use a metatable when os.date("*t") is called [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/143627 (owner: 10Jackmcbarn) [03:21:50] resolve the error gnu diff3 could not be found error during installation. We installed everything. mediawiki installion stall can't find gnju diff3? [03:22:16] gnu diff3 sorry typo [03:22:44] We are reading this To activate the use of diffutils within MediaWiki, you have to ignore the fact that they won't be found during installation (they may actually be found if you install diff into your path) and open up LocalSettings.php to make the following changes: [03:23:18] We made the changes and it still does not find the gnu diff3 [03:23:39] (03CR) 10jenkins-bot: [V: 04-1] Use a metatable when os.date("*t") is called [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/143627 (owner: 10Jackmcbarn) [03:28:57] are we supposed to rename file.exe to file.exe -bi? We are on windows. [03:29:06] (03CR) 10Tim Starling: "The {{#invoke:}} counts as a child frame, so it's not possible for Lua code to be running in the root frame. Or is the idea to make it wor" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/141048 (owner: 10Jackmcbarn) [03:29:56] (03CR) 10Jackmcbarn: "The idea is to make it work with frame:getParent():preprocess when the #invoke frame is the direct child of the root." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/141048 (owner: 10Jackmcbarn) [03:32:00] (03Abandoned) 10Jackmcbarn: Allow moving pages with edit-protection [core] - 10https://gerrit.wikimedia.org/r/105103 (https://bugzilla.wikimedia.org/38365) (owner: 10Jackmcbarn) [03:33:57] how do check if diff3 is working on windows? [03:34:49] (03PS1) 10Jackmcbarn: DO NOT MERGE - testing Jenkins [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/181027 [03:35:42] why not merge? [03:36:16] 3MediaWiki-extensions-Echo, Collaboration-Team: Echo: Flyout's Alerts · Messages tab-links should have active tab as "black text, non-linked" - https://phabricator.wikimedia.org/T71929#935546 (10Spage) [03:36:17] 3Collaboration-Team, MediaWiki-extensions-Flow: Flow: after Summarize, action should change to 'Edit summary' - https://phabricator.wikimedia.org/T72749#935547 (10Spage) [03:36:22] 3Collaboration-Team, MediaWiki-extensions-Flow: Co-op: If bot creates a topic or board header on an empty page, turn it into a Flow board. - https://phabricator.wikimedia.org/T76793#935552 (10Spage) [03:36:24] 3Collaboration-Team, MediaWiki-extensions-Flow: Flow TOC occasionally doesn't pop up showing the current topic's title at the top. - https://phabricator.wikimedia.org/T78572#935550 (10Spage) [03:36:27] 3Collaboration-Team, MediaWiki-extensions-Flow: TABLE OF CONTENTS (J2d): Clicking on a topic title (current set of available topics, and beyond) (8) - https://phabricator.wikimedia.org/T76581#935554 (10Spage) [03:36:28] 3Collaboration-Team, MediaWiki-extensions-Flow: TOC does not affix to top of page after changing the sorting order. - https://phabricator.wikimedia.org/T78839#935553 (10Spage) [03:36:33] 3Collaboration-Team, MediaWiki-extensions-Flow: Flow TOC Minimum Viable Product - https://phabricator.wikimedia.org/T78566#935558 (10Spage) [03:36:34] 3Collaboration-Team, MediaWiki-extensions-Flow: Make ES configuration management maintenance script - https://phabricator.wikimedia.org/T78787#935559 (10Spage) [03:36:35] 3Collaboration-Team, MediaWiki-extensions-Flow: Timestamp: Make rollover state a link to topic history - https://phabricator.wikimedia.org/T77900#935562 (10Spage) [03:36:37] 3Collaboration-Team, MediaWiki-extensions-Flow: JS-generated timestamps have no hover, only displays readable time - https://phabricator.wikimedia.org/T84858#935563 (10Spage) [03:36:49] (03CR) 10jenkins-bot: [V: 04-1] DO NOT MERGE - testing Jenkins [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/181027 (owner: 10Jackmcbarn) [03:37:10] we must have asked a hard question [03:37:54] I have a (couple) custom WikiLove scripts, I'm wondering if I can have edits made with those scripts add a custom "tag". [03:38:01] jehovahsays: Probably better to ask on #mediawiki [03:38:10] That channel has more people [03:38:11] (03PS3) 10Tim Starling: Handle PTD_FOR_INCLUSION properly [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/141048 (owner: 10Jackmcbarn) [03:38:41] do you have 1.25 installed? [03:38:57] (03PS4) 10Tim Starling: Handle PTD_FOR_INCLUSION properly [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/141048 (owner: 10Jackmcbarn) [03:39:04] (03CR) 10Tim Starling: [C: 032] Handle PTD_FOR_INCLUSION properly [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/141048 (owner: 10Jackmcbarn) [03:40:56] (03CR) 10jenkins-bot: [V: 04-1] Handle PTD_FOR_INCLUSION properly [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/141048 (owner: 10Jackmcbarn) [03:41:00] (03PS1) 10Jackmcbarn: Make Jenkins tests pass [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/181029 [03:41:54] (03CR) 10Tim Starling: [C: 032] Make Jenkins tests pass [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/181029 (owner: 10Jackmcbarn) [03:43:20] (03Abandoned) 10Jackmcbarn: DO NOT MERGE - testing Jenkins [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/181027 (owner: 10Jackmcbarn) [03:44:05] 3Collaboration-Team, MediaWiki-extensions-Flow: Flow TOC Minimum Viable Product - https://phabricator.wikimedia.org/T78566#848433 (10Spage) [03:46:10] (03Merged) 10jenkins-bot: Make Jenkins tests pass [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/181029 (owner: 10Jackmcbarn) [03:46:26] (03PS3) 10Jackmcbarn: Use a metatable when os.date("*t") is called [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/143627 [03:46:27] (03PS5) 10Jackmcbarn: Handle PTD_FOR_INCLUSION properly [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/141048 [03:48:45] Can't keep up with the scrollback on my mobile. I'll take my question to #mediawiki where the bots are a little less chatty. :) [03:49:13] (03CR) 10Jackmcbarn: [C: 032] "Already +2'd by Tim. Forcing gate-and-submit to rerun" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/143627 (owner: 10Jackmcbarn) [03:49:26] (03CR) 10Jackmcbarn: [C: 032] "Already +2'd by Tim. Forcing gate-and-submit to rerun" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/141048 (owner: 10Jackmcbarn) [03:52:32] (03Merged) 10jenkins-bot: Use a metatable when os.date("*t") is called [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/143627 (owner: 10Jackmcbarn) [03:55:48] (03Merged) 10jenkins-bot: Handle PTD_FOR_INCLUSION properly [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/141048 (owner: 10Jackmcbarn) [03:56:08] (03PS3) 10Tim Starling: Re-emit unknown tags from #tag [core] - 10https://gerrit.wikimedia.org/r/138013 (owner: 10Jackmcbarn) [03:56:48] (03CR) 10Tim Starling: [C: 032] Re-emit unknown tags from #tag [core] - 10https://gerrit.wikimedia.org/r/138013 (owner: 10Jackmcbarn) [04:00:01] 3Shop-Theme: Add "create account" and "log in" - https://phabricator.wikimedia.org/T84935#935575 (10violetto) Perfect [04:01:00] how do we get the mw-config to find the diff3.exe [04:02:13] (03CR) 10jenkins-bot: [V: 04-1] Re-emit unknown tags from #tag [core] - 10https://gerrit.wikimedia.org/r/138013 (owner: 10Jackmcbarn) [04:03:40] 3Wikimedia-General-or-Unknown, ops-core: RT password reset function broken (sends mail w/ blank passwd) - https://phabricator.wikimedia.org/T32412#935576 (10jeremyb) [04:07:27] (03PS4) 10Jackmcbarn: Re-emit unknown tags from #tag [core] - 10https://gerrit.wikimedia.org/r/138013 [04:13:47] (03CR) 10Tim Starling: [C: 032] Re-emit unknown tags from #tag [core] - 10https://gerrit.wikimedia.org/r/138013 (owner: 10Jackmcbarn) [04:19:26] (03Merged) 10jenkins-bot: Re-emit unknown tags from #tag [core] - 10https://gerrit.wikimedia.org/r/138013 (owner: 10Jackmcbarn) [04:36:40] (03Abandoned) 10Jackmcbarn: Increase changed text background contrast [core] - 10https://gerrit.wikimedia.org/r/106763 (https://bugzilla.wikimedia.org/59093) (owner: 10Jackmcbarn) [04:36:44] (03Abandoned) 10Jackmcbarn: Allow finding the shortest name of a special page [core] - 10https://gerrit.wikimedia.org/r/115696 (owner: 10Jackmcbarn) [04:37:48] (03Abandoned) 10Jackmcbarn: Don't count #ifexist as expensive anymore [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/127160 (owner: 10Jackmcbarn) [04:39:51] (03PS1) 10Krinkle: EditPage: Optimise loading of mediawiki.toolbar module [core] - 10https://gerrit.wikimedia.org/r/181030 [04:40:13] (03Abandoned) 10Krinkle: Do not load the toolbar code if "showtoolbar" is disabled [core] - 10https://gerrit.wikimedia.org/r/156229 (owner: 10Helder.wiki) [04:40:28] 3Multimedia, MediaWiki-extensions-MultimediaViewer: MediaViewer should have special handling for images which link to other images - https://phabricator.wikimedia.org/T75902#935579 (10Tgr) [04:40:45] (03Abandoned) 10Krinkle: EditPage: Prettify inline scripts for mw.toolbar in debug mode [core] - 10https://gerrit.wikimedia.org/r/161768 (owner: 10Krinkle) [04:42:34] 3MediaWiki-History-or-Diffs: Colors used to mark added/deleted spaces in diffs should have higher contrast - https://phabricator.wikimedia.org/T61093#935580 (10TTO) [04:42:42] 3Multimedia, MediaWiki-extensions-MultimediaViewer: MediaViewer should have special handling for images which link to other images - https://phabricator.wikimedia.org/T75902#935582 (10Tgr) [04:53:57] 3Shop-Theme: Test a complete transaction - https://phabricator.wikimedia.org/T84966#935599 (10Prtksxna) 3NEW [05:19:05] 3MediaWiki-Page-editing: Allow "suppressredirect" and "move-subpages" within userspace on en.wikipedia - https://phabricator.wikimedia.org/T71162#935629 (10Dereckson) [05:19:49] 3Shop-Theme: Clean up theme files - https://phabricator.wikimedia.org/T78735#935634 (10Prtksxna) p:5Normal>3Low [05:24:25] 3ContentTranslation-Deployments, MediaWiki-extensions-ContentTranslation: Review of Content Translation Database for Production - https://phabricator.wikimedia.org/T84969#935635 (10KartikMistry) 3NEW a:3Springle [05:24:52] (03CR) 10Aaron Schulz: "The "no timeout" changes are for non-blocking mode, not infinite timeouts." [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/178903 (owner: 10Manybubbles) [05:25:19] 3Wikimedia-General-or-Unknown: Schema changes for Wikimedia wikis (tracking) - https://phabricator.wikimedia.org/T51188#935643 (10KartikMistry) [05:25:42] (03CR) 10Aaron Schulz: "Ugh, lettering is off. I mean:" [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/178903 (owner: 10Manybubbles) [05:26:10] 3ContentTranslation-Deployments, MediaWiki-extensions-ContentTranslation: Review of Content Translation Database for Production - https://phabricator.wikimedia.org/T84969#935635 (10KartikMistry) [05:26:44] 3ContentTranslation-Deployments, MediaWiki-extensions-ContentTranslation: Create Database config for Content Translation in Production - https://phabricator.wikimedia.org/T78775#935645 (10KartikMistry) [05:27:37] (03CR) 10Tim Starling: "Why are the keys put in the keys of the return value array? I think it would be faster and more consistent with similar APIs to make it wo" [core] - 10https://gerrit.wikimedia.org/r/165103 (owner: 10Jackmcbarn) [05:32:18] 3Shop-Theme: Selection menu control - https://phabricator.wikimedia.org/T78446#935646 (10Prtksxna) Initial: `October Sticker Packs / d - Rs. 5.00` First change: `October Stic... - Rs. 5.00` Now: `October...cks / d - Rs. 5.00` [05:37:02] (03CR) 10Jackmcbarn: "To remove the need for nasty hacky stuff like https://en.wikipedia.org/w/index.php?diff=637412928&oldid=625027646" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/178760 (owner: 10Jackmcbarn) [05:51:15] (03PS8) 10Umherirrender: Use new log system when create log entry for revision delete [core] - 10https://gerrit.wikimedia.org/r/152161 [05:51:39] (03PS7) 10Umherirrender: Migrate protect log to new log system [core] - 10https://gerrit.wikimedia.org/r/152156 [05:52:01] (03PS8) 10Umherirrender: Migrate block log to new log system [core] - 10https://gerrit.wikimedia.org/r/152003 [05:52:20] (03PS9) 10Umherirrender: Migrate import log to new log system [core] - 10https://gerrit.wikimedia.org/r/151701 [05:55:06] (03PS3) 10Jackmcbarn: Allow all users to view Special:UserRights [core] - 10https://gerrit.wikimedia.org/r/107009 [05:56:39] (03CR) 10Krinkle: "This introduced T84970. It's leaving behind tons of json files in /tmp. Please clean up after yourself in a tearDown() function. Unit test" [core] - 10https://gerrit.wikimedia.org/r/174874 (https://bugzilla.wikimedia.org/56602) (owner: 10Aude) [05:57:22] (03CR) 10Ori.livneh: "I think you should move this code to a shouldStartTransaction method" [core] - 10https://gerrit.wikimedia.org/r/180702 (owner: 10Aaron Schulz) [05:58:46] 3Continuous-Integration, MediaWiki-Unit-tests: /tmp/sites-******.json files are left behind on Jenkins slaves - https://phabricator.wikimedia.org/T84970#935659 (10Krinkle) p:5Triage>3Normal a:3aude [06:02:36] (03PS2) 10Krinkle: autoloader: Remove incorrect documentation comment [core] - 10https://gerrit.wikimedia.org/r/174117 [06:06:17] (03PS4) 10Krinkle: mediawiki.skinning: Use mw-body-content instead of mw-body where appropriate [core] - 10https://gerrit.wikimedia.org/r/158854 [06:07:13] (03CR) 10Legoktm: [C: 031] Omit frontent and browsertest development files from release [tools/release] - 10https://gerrit.wikimedia.org/r/180118 (owner: 10Krinkle) [06:07:22] (03CR) 10Krinkle: [C: 04-1] "Arlolra: That's an interesting case. I'll look into that. Possibly the content class should be applied to that separately. There can be mo" [core] - 10https://gerrit.wikimedia.org/r/158854 (owner: 10Krinkle) [06:12:04] (03PS2) 10Krinkle: Omit frontend and browsertest development files from release [tools/release] - 10https://gerrit.wikimedia.org/r/180118 [06:16:02] (03PS1) 10tosfos: initial commit [extensions/PaginateText] - 10https://gerrit.wikimedia.org/r/181034 [06:18:16] Who has access to the WMFlabs.org databases (specifically the one for the Wikidata-game, which I think is: 'merge_candidates' , 'p:tools-db' )? I'm trying to look into the broken stats page in the Wikidata-game, and I think it's probably a missing row in one of the tables... [06:20:41] 3Shop-Theme: Add instagram feed on homepage - https://phabricator.wikimedia.org/T76858#935673 (10Prtksxna) I have added the following settings under the //Homepage// sub-section: # Show Instagram? //(requirement for legal to be able to quickly switch off Instagram)// # Client ID //(this can be copied from the [... [06:20:55] (03PS2) 10tosfos: initial commit [extensions/PaginateText] - 10https://gerrit.wikimedia.org/r/181034 [06:29:16] 3Shop-Theme: Clean up the setting of the theme - https://phabricator.wikimedia.org/T84849#935676 (10Prtksxna) a:3Prtksxna [06:30:56] 3ops-codfw: label/setup/update servers haedus & capella - https://phabricator.wikimedia.org/T84901#935678 (10Joe) p:5Triage>3High [06:37:22] (03PS1) 10Legoktm: make-release: Fix --no-previous [tools/release] - 10https://gerrit.wikimedia.org/r/181035 [06:37:24] (03PS1) 10Legoktm: make-release: Rename and document some functions and add a test [tools/release] - 10https://gerrit.wikimedia.org/r/181036 [06:37:26] (03PS1) 10Legoktm: make-release: Use three double quotes for docstrings [tools/release] - 10https://gerrit.wikimedia.org/r/181037 [06:37:28] (03PS1) 10Legoktm: make-release: Explicitly close the opened config file, validate yaml [tools/release] - 10https://gerrit.wikimedia.org/r/181038 [06:37:30] (03PS1) 10Legoktm: make-release: Actually use the logging module [tools/release] - 10https://gerrit.wikimedia.org/r/181039 [06:37:32] (03PS1) 10Legoktm: make-release: Use print_function from the __future__ [tools/release] - 10https://gerrit.wikimedia.org/r/181040 [06:37:34] (03PS1) 10Legoktm: make-release: Use "as" when catching exceptions [tools/release] - 10https://gerrit.wikimedia.org/r/181041 [06:37:36] (03PS1) 10Legoktm: git-logs: Make log_updates python3 compatible [tools/release] - 10https://gerrit.wikimedia.org/r/181042 [06:37:38] (03PS1) 10Legoktm: git-logs: Port log_updates.py to python3 [tools/release] - 10https://gerrit.wikimedia.org/r/181043 [06:37:40] (03PS1) 10Legoktm: [tox] Add environment for flake8 under python3 [tools/release] - 10https://gerrit.wikimedia.org/r/181044 [06:57:52] 3MediaWiki-Categories: Hierarchical category system is urgently needed - https://phabricator.wikimedia.org/T3497#935683 (10Qgil) 5Open>3declined Agreed. Be bold. Go Wikidata! [07:01:51] (03PS1) 10Robert Vogel: UEModulePDF: Fixed some I18N [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/181045 [07:03:25] 3MediaWiki-Email, MediaWiki-General-or-Unknown, Project-Creators: ENotif/EConfirm & further enhancements (tracking) - https://phabricator.wikimedia.org/T3932#935685 (10Qgil) [07:05:50] 3ContentTranslation-Deployments, MediaWiki-extensions-ContentTranslation: Review of Content Translation Database for Production - https://phabricator.wikimedia.org/T84969#935635 (10Arrbee) [07:08:14] (03PS1) 10Jackmcbarn: Allow running code during unstrip [core] - 10https://gerrit.wikimedia.org/r/181046 [07:09:18] 3MediaWiki-extensions-Echo: Show "You have new messages on your user or user_talk page" -- i.e. both pages are notified - https://phabricator.wikimedia.org/T3876#935691 (10Qgil) [07:10:23] 3MediaWiki-extensions-Echo: Show "You have new messages on your user or user_talk page" -- i.e. both pages are notified - https://phabricator.wikimedia.org/T3876#62106 (10Qgil) Hasn't this old task been fixed with the orange bar, a long time ago? [07:13:05] (03CR) 10Qgil: "Meh. In any case, thank you for trying!" [core] - 10https://gerrit.wikimedia.org/r/106763 (https://bugzilla.wikimedia.org/59093) (owner: 10Jackmcbarn) [07:17:29] (03CR) 10Jackmcbarn: Allow running code during unstrip (032 comments) [core] - 10https://gerrit.wikimedia.org/r/181046 (owner: 10Jackmcbarn) [07:20:25] (03PS2) 10Jackmcbarn: Allow running code during unstrip [core] - 10https://gerrit.wikimedia.org/r/181046 [07:29:10] 3Project-Creators: Create a project for MediaWiki Language Extension Bundle - https://phabricator.wikimedia.org/T84880#935696 (10Arrbee) This is for tracking the release cycles every month. The individual components have their own projects (inherited from the bugzilla components) under which the actual tasks may... [07:33:55] 3Engineering-Community: Organize Wikimedia stand in FOSDEM - https://phabricator.wikimedia.org/T84971#935699 (10Qgil) 3NEW [07:37:23] 3Shop-Theme: Add instagram feed on homepage - https://phabricator.wikimedia.org/T76858#935706 (10Prtksxna) Positioned the images according to the grid now. [07:44:27] 3Engineering-Community: FOSDEM 2015 coordination - https://phabricator.wikimedia.org/T84972#935708 (10Qgil) 3NEW [07:44:39] 3Engineering-Community: FOSDEM 2015 coordination - https://phabricator.wikimedia.org/T84972#935708 (10Qgil) [07:50:31] (03CR) 10Aaron Schulz: [C: 032] autoloader: Remove incorrect documentation comment [core] - 10https://gerrit.wikimedia.org/r/174117 (owner: 10Krinkle) [07:52:53] 3Engineering-Community: FOSDEM 2015 coordination - https://phabricator.wikimedia.org/T84972#935728 (10Qgil) [07:54:23] (03CR) 10Aaron Schulz: "I have no strong feelings on that" [core] - 10https://gerrit.wikimedia.org/r/180702 (owner: 10Aaron Schulz) [07:55:34] 3MediaWiki-Core-Team: Retest geo indexes in Orient - https://phabricator.wikimedia.org/T84975#935736 (10aaron) 3NEW a:3aaron [07:56:01] (03Merged) 10jenkins-bot: autoloader: Remove incorrect documentation comment [core] - 10https://gerrit.wikimedia.org/r/174117 (owner: 10Krinkle) [08:06:16] 3Wikimedia-Site-requests, Wikidata: Enable 'other projects' from Wikidata on itwikipedia - https://phabricator.wikimedia.org/T77012#935754 (10Andyrom75) Thanks to all. Aude: that script is needed to integrate the projects not yet in wikidata (managed by template:interprogetto) with those managed by wikidata. How... [08:08:10] 3Wikimedia-Site-requests, Wikidata: Enable 'other projects' from Wikidata on itwikipedia - https://phabricator.wikimedia.org/T77012#935755 (10Andyrom75) Thanks to all. Aude: that script is needed to integrate the projects not yet in wikidata (managed by template:interprogetto) with those managed by wikidata. How... [08:12:38] 3Engineering-Community, WMF-Legal: Implement the Volunteer NDA process in Phabricator - https://phabricator.wikimedia.org/T655#935759 (10Qgil) p:5Normal>3High [08:13:56] Document the new puppet and hiera role function - https://phabricator.wikimedia.org/T84976#935760 (10Joe) 3NEW a:3Joe [08:16:21] 3MediaWiki-API: API: Purpose of "batchcomplete" property and implementation - https://phabricator.wikimedia.org/T84977#935768 (10Krinkle) 3NEW a:3Anomie [08:16:30] (03CR) 10Yuvipanda: make-release: Fix --no-previous (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/181035 (owner: 10Legoktm) [08:17:00] (03CR) 10Krinkle: "I'm not sure that answered the question. Filed https://phabricator.wikimedia.org/T84977." [core] - 10https://gerrit.wikimedia.org/r/152359 (owner: 10Anomie) [08:17:12] (03CR) 10Yuvipanda: [C: 032] make-release: Rename and document some functions and add a test [tools/release] - 10https://gerrit.wikimedia.org/r/181036 (owner: 10Legoktm) [08:17:41] 3operations: Document the new puppet and hiera role function - https://phabricator.wikimedia.org/T84976#935776 (10Joe) [08:17:55] 3operations: Document the new puppet and hiera role function - https://phabricator.wikimedia.org/T84976#935777 (10Joe) p:5Triage>3Normal [08:19:04] (03CR) 10Legoktm: make-release: Fix --no-previous (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/181035 (owner: 10Legoktm) [08:20:45] (03CR) 10Yuvipanda: [C: 032] make-release: Fix --no-previous [tools/release] - 10https://gerrit.wikimedia.org/r/181035 (owner: 10Legoktm) [08:21:10] (03CR) 10Yuvipanda: [C: 032] make-release: Use three double quotes for docstrings [tools/release] - 10https://gerrit.wikimedia.org/r/181037 (owner: 10Legoktm) [08:21:17] (03Merged) 10jenkins-bot: make-release: Use three double quotes for docstrings [tools/release] - 10https://gerrit.wikimedia.org/r/181037 (owner: 10Legoktm) [08:21:35] 3Engineering-Community, Project-Creators: Convert mw:Mentorship_programs/Possible_projects in two Phabricator projects - https://phabricator.wikimedia.org/T76341#935781 (10Qgil) p:5Low>3Normal [08:21:52] 3Engineering-Community: Establish minimum criteria to evaluate interns in outreach programs - https://phabricator.wikimedia.org/T1253#935783 (10Qgil) p:5Low>3Normal [08:21:54] (03CR) 10Yuvipanda: [C: 032] make-release: Explicitly close the opened config file, validate yaml [tools/release] - 10https://gerrit.wikimedia.org/r/181038 (owner: 10Legoktm) [08:22:01] (03Merged) 10jenkins-bot: make-release: Explicitly close the opened config file, validate yaml [tools/release] - 10https://gerrit.wikimedia.org/r/181038 (owner: 10Legoktm) [08:23:02] (03CR) 10Krinkle: "Looks like the code directly below the newly added !in_array check also intends to exclude 'SHOW'. Did that not work and is that now unuse" [core] - 10https://gerrit.wikimedia.org/r/180702 (owner: 10Aaron Schulz) [08:24:06] (03CR) 10Yuvipanda: [C: 04-1] make-release: Actually use the logging module (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/181039 (owner: 10Legoktm) [08:29:36] 3Shop-Theme: Decide and fix the links on the toolbar menu - https://phabricator.wikimedia.org/T78757#935786 (10Prtksxna) a:5Prtksxna>3violetto Added a setting called //Menu Links// under the //Header// section.{F22551} [08:31:30] 3Shop-Theme: Test on browsers - https://phabricator.wikimedia.org/T78759#935789 (10Prtksxna) a:3Prtksxna [08:31:45] 3Shop-Theme: Clean up theme files - https://phabricator.wikimedia.org/T78735#935790 (10Prtksxna) a:3Prtksxna [08:32:11] 3Shop-Theme: Test a complete transaction - https://phabricator.wikimedia.org/T84966#935791 (10Prtksxna) a:3violetto I am not sure how we'll do this. @violetto do you have any ideas? [08:32:22] 3MediaWiki-extensions-ContentTranslation: Section alignments do not break due to different actions - https://phabricator.wikimedia.org/T84978#935794 (10Arrbee) 3NEW a:3Arrbee [08:34:15] 3Shop-Theme: Test a complete transaction - https://phabricator.wikimedia.org/T84966#935802 (10violetto) a:5violetto>3vshchepakina [08:34:38] 3Shop-Theme: Test a complete transaction - https://phabricator.wikimedia.org/T84966#935599 (10violetto) I'll defer this to Victoria. Vic—let us know how we can test a full transaction. [08:35:45] (03PS9) 10Qgil: Huge refactor of security policy enforcer stuff. [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/179405 (owner: 1020after4) [08:36:16] 3Multimedia, MediaWiki-extensions-MultimediaViewer, Analytics: Create MediaViewer image varnish hit/miss ratio dashboard - https://phabricator.wikimedia.org/T78205#935804 (10Gilles) The theory doesn't seem to hold true, the vast majority of varnish misses with a very small "Age" value have a very old Last-Modifi... [08:38:31] 3Shop-Theme: Decide and fix the links on the toolbar menu - https://phabricator.wikimedia.org/T78757#935805 (10violetto) Thanks @Prtksxna, @vshchepakina let me know when you've created Women, Men, and Accessories collections. [08:40:00] How do I get popup messages in my script like the one I see when I click the star to watch a page? [08:40:46] I tried searching form mw.util.msg but got no results. [08:41:20] (03PS2) 10Legoktm: make-release: Actually use the logging module [tools/release] - 10https://gerrit.wikimedia.org/r/181039 [08:42:10] T13|mobile: mw.notify, need to depend upon mediawiki.notification [08:43:04] T13|mobile: https://www.mediawiki.org/wiki/ResourceLoader/Default_modules#mediawiki.notify [08:43:33] mediawiki.notify*, sorry [08:44:27] Thanks legoktm- found it. :) [08:44:42] (03CR) 10Yuvipanda: [C: 032] make-release: Actually use the logging module [tools/release] - 10https://gerrit.wikimedia.org/r/181039 (owner: 10Legoktm) [08:44:49] (03Merged) 10jenkins-bot: make-release: Actually use the logging module [tools/release] - 10https://gerrit.wikimedia.org/r/181039 (owner: 10Legoktm) [08:45:12] (03PS2) 10Yuvipanda: make-release: Use print_function from the __future__ [tools/release] - 10https://gerrit.wikimedia.org/r/181040 (owner: 10Legoktm) [08:47:05] Is there any way to detect if users are loading my script with importScript or if they're using mw.loader? [08:48:30] I think it would make it much easier to get them all updated to mw.loader.load() if I can detect and notify. [08:52:38] What does the tag do with mw.notify exactly? [08:55:52] 3Shop-Theme: On Safari, the font doesn't look legible - https://phabricator.wikimedia.org/T84933#935816 (10Prtksxna) Changing the weight of the sub-heading from `100` to `200` makes is visible on Safari. @violetto, are we fine with [[ https://wmf-test-shop.myshopify.com/ | this ]]? [08:56:08] T13|mobile: if you send a second notification with the same tag, it'll make the first one go away if it's still visible [08:57:52] Ahh. I see. :) [08:58:20] I was thinking had something to do with edit filter tags. [08:58:42] it's more like a unique id kind of thing [08:59:08] mw.Feedback() returns an "is not a constructor". [09:00:02] Is the example suppose to be a working one? Looking at the source, it would need to be updated anyways because bugzilla isn't used anymore. [09:00:53] dunno [09:01:49] (03CR) 10Yuvipanda: [C: 032] make-release: Use print_function from the __future__ [tools/release] - 10https://gerrit.wikimedia.org/r/181040 (owner: 10Legoktm) [09:01:56] (03Merged) 10jenkins-bot: make-release: Use print_function from the __future__ [tools/release] - 10https://gerrit.wikimedia.org/r/181040 (owner: 10Legoktm) [09:01:58] (03PS2) 10Yuvipanda: make-release: Use "as" when catching exceptions [tools/release] - 10https://gerrit.wikimedia.org/r/181041 (owner: 10Legoktm) [09:02:47] Wow. jQuery.client.profile() is sweet! [09:03:16] (03CR) 10Yuvipanda: [C: 032] make-release: Use "as" when catching exceptions [tools/release] - 10https://gerrit.wikimedia.org/r/181041 (owner: 10Legoktm) [09:03:20] 3MediaWiki-Core-Team: Convert old 1.23wmf* and 1.24wmf* deployment branches to tags - https://phabricator.wikimedia.org/T1288#935821 (10fgiunchedi) if there's no harm in keeping the tags around it sounds like a good idea to have them [09:03:22] (03Merged) 10jenkins-bot: make-release: Use "as" when catching exceptions [tools/release] - 10https://gerrit.wikimedia.org/r/181041 (owner: 10Legoktm) [09:04:30] legoktm: Why do I think my Bouquet config patchset still isn't what it should be? [09:04:48] uhmmmmm [09:04:58] :P [09:04:59] * legoktm looks [09:08:09] (03CR) 10Legoktm: [C: 04-1] Use Config for a few globals. (034 comments) [skins/Bouquet] - 10https://gerrit.wikimedia.org/r/168913 (owner: 10Lewis Cawte) [09:08:49] 4 comments :S [09:09:55] here's a good trick when you're testing this [09:09:57] $wgConfigRegistry['bouquet'] = function() { return new HashConfig( array( 'FooBar' => 'baz' ) ); }; [09:10:05] set that instead of the 'GlobalVarConfig' [09:10:23] and instead of 'FooBar', put in all of Bouquet's config settings (no 'wg' prefix) in that array [09:10:51] and now it'll throw ConfigException's if you try accessing something that belongs to a different config instance [09:10:56] 3MediaWiki-Parser: Add tracking category for pages that contain errors flagged by HTMLTidy - https://phabricator.wikimedia.org/T42607#935845 (10Schnark) There is an easy trick to test the output without HTML tidy applied: Use Special:ExpandTemplates. I did so with https://de.wikipedia.org/wiki/Spezial:Vorlagen_e... [09:11:41] Lcawte: ^ [09:11:51] 3Project-Creators: Create a project for MediaWiki Language Extension Bundle - https://phabricator.wikimedia.org/T84880#935846 (10Qgil) "Language-Extension-Bundle" is clear enough. You can always have an additional #mleb hashtag to save you some typing. However... If this is about organizing releases, maybe you... [09:12:00] 3Project-Creators: Create a project for MediaWiki Language Extension Bundle - https://phabricator.wikimedia.org/T84880#935848 (10Qgil) p:5Triage>3Normal [09:14:06] 3Project-Creators: WikidataQuality - https://phabricator.wikimedia.org/T84854#935856 (10Qgil) Wikidata-Quality might be better for searches. Is there a wiki page to link to from your description? [09:14:18] legoktm: Thanks. For the first comment, do I want to return new $classname( $this->oneconfig, $this->twoconfig ) or something? (Apparently I don't quite get all the OO stuff quite yet?) [09:15:31] (I /may/ go offline shortly because lesson ends in ten/fifteen minutes and my laptop is on about 4%) [09:16:11] Lcawte: yeah. And then create a custom constructor in your template that takes two config objects and sets them to member variables that you use later on [09:16:39] Ah, the custom constructor must of been what I was missing when I tried that :) [09:21:18] (03PS1) 10Aude: Cleanup SiteListFileCache test files in tearDown [core] - 10https://gerrit.wikimedia.org/r/181047 [09:26:11] (03PS2) 10Aude: Cleanup SiteListFileCache test files in tearDown [core] - 10https://gerrit.wikimedia.org/r/181047 [09:27:39] 3Shop-Theme: Give specification on photo sizes - https://phabricator.wikimedia.org/T78753#935866 (10Prtksxna) The largest image that Shopify accepts is `2048px` height and width. I think we should use this for the carousel and all other header images. The product images on the other hand are never shown in a siz... [09:29:17] (03CR) 10Legoktm: [C: 04-1] "I think I meant to squash this into its parent." [tools/release] - 10https://gerrit.wikimedia.org/r/181043 (owner: 10Legoktm) [09:32:21] 3Shop-Theme: On Safari, the font doesn't look legible - https://phabricator.wikimedia.org/T84933#935870 (10Prtksxna) Changed to `300` and moved the shadow a little closer. [09:34:07] 3operations: Varnish: the lower the Age value, the slower the request - https://phabricator.wikimedia.org/T84980#935873 (10Gilles) 3NEW [09:35:53] 3ops-core: identify physical disks for cisco machines - https://phabricator.wikimedia.org/T84981#935881 (10fgiunchedi) 3NEW [09:41:31] 3Wikimedia-Fundraising: fundraiser banner too big and makes it hard for users to get to link to log in - https://phabricator.wikimedia.org/T78023#935891 (10Nemo_bis) [09:43:04] 3MediaWiki-extensions-MultimediaViewer, Analytics, Multimedia: Investigate if pre-rendering images is having an impact on performance - https://phabricator.wikimedia.org/T76035#935895 (10Gilles) Now that I have more data I can confirm that only varnish hits are affected by the phenomenon where images uploaded re... [09:43:32] 3Shop-Theme: Add search to the top menubar - https://phabricator.wikimedia.org/T78379#935897 (10Prtksxna) Can you add the search icon's SVG here? [09:45:11] 3Shop-Theme: Add search to the top menubar - https://phabricator.wikimedia.org/T78379#935899 (10violetto) {F22563} [09:50:21] werdna: We decided not to have today's meeting, right? [09:52:43] 3Community-Engagement, Project-Creators: Community Engagement Project page - https://phabricator.wikimedia.org/T420#935905 (10Qgil) As weird as this might sound, [[ https://www.mediawiki.org/wiki/Phabricator/Creating_and_renaming_projects#Policy | project policies do not condition task policies ]]. Public tasks... [09:53:24] 3Wikimedia-Wikimania-Scholarships: Update countries database to reflect Global North/South - https://phabricator.wikimedia.org/T84869#935906 (10KTC) Also see [09:57:54] 3MediaWiki-extensions-MultimediaViewer, Analytics, Multimedia: Create MediaViewer image varnish hit/miss ratio dashboard - https://phabricator.wikimedia.org/T78205#935925 (10Gilles) What's interesting in those findings, though, is that 99.34% of varnish misses are swift pulls, regardless of upload time. Which wo... [10:07:59] 3MediaWiki-History-or-Diffs: Colors used to mark added/deleted spaces in diffs should have higher contrast - https://phabricator.wikimedia.org/T61093#935948 (10Qgil) Meh. Changed abandoned. Did we fall in one of those situations where the better solution was dismissed in pursue of the perfect solution? Meanwhi... [10:08:50] 3MediaWiki-General-or-Unknown, Continuous-Integration, Mobile-Web: QUnit job unable to collect logs, test still has active http requests writing to them - https://phabricator.wikimedia.org/T78590#935949 (10Florian) I tried to figure out, what @Krinkle said. What i did: I added a QUnit.done() callback on top of... [10:09:36] 3MediaWiki-History-or-Diffs: Colors used to mark added/deleted spaces in diffs should have higher contrast - https://phabricator.wikimedia.org/T61093#935951 (10Qgil) [10:09:39] 3operations: Varnish: the lower the Age value, the slower the request - https://phabricator.wikimedia.org/T84980#935952 (10fgiunchedi) +Brandon, perhaps this rings a bell [10:11:21] 3MediaWiki-extensions-Collection: Collection npm tests leak test files - https://phabricator.wikimedia.org/T60216#935959 (10hashar) [10:11:25] 3Wikimedia-Shop: Decide and fix the links on the toolbar menu - https://phabricator.wikimedia.org/T78757#935960 (10violetto) [10:12:15] 3Wikimedia-Shop: Decide on what photos appear on the top header - https://phabricator.wikimedia.org/T84932#935961 (10violetto) [10:12:50] 3Wikimedia-Shop: Decide on what photos appear on the top header - https://phabricator.wikimedia.org/T84932#934096 (10Prtksxna) [10:20:33] 3Community-Engagement, Project-Creators, Engineering-Community: XXXX-Radar projects for Wikimedia family projects and languages + MediaWiki Stakeholders - https://phabricator.wikimedia.org/T78482#935968 (10Darkdadaah) There are 2 levels of tasks for a project: - tasks about the project as a whole, all languages... [10:31:00] (03PS10) 1020after4: Huge refactor of security policy enforcer stuff. [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/179405 [10:31:22] 3operations: MediaWiki Jobrunner lacks init.d script - https://phabricator.wikimedia.org/T78126#936005 (10Joe) why do we need this? Upstart start(1) and stop(1) and, more importantly, the service(1) wrapper already know how to treat this. [10:31:40] 3operations: MediaWiki Jobrunner lacks init.d script - https://phabricator.wikimedia.org/T78126#936007 (10Joe) 5Open>3declined p:5Triage>3Low [10:32:17] 3Wikidata, Community-Engagement, Project-Creators: Phabricator projects for Wikimedia sister projects - https://phabricator.wikimedia.org/T802#936010 (10Qgil) If we are talking here about tracking software bugs, the big majority of them are not tied to a single language. Also, while we have a dozen project famil... [10:33:22] 3Community-Engagement, Project-Creators, Engineering-Community: XXXX-Radar projects for Wikimedia family projects and languages + MediaWiki Stakeholders - https://phabricator.wikimedia.org/T78482#936012 (10Qgil) @Darkdadaah, I just replied at https://phabricator.wikimedia.org/T802#936010 And I'm going to merge... [10:33:37] 3Community-Engagement, Project-Creators, Engineering-Community: XXXX-Radar projects for Wikimedia family projects and languages + MediaWiki Stakeholders - https://phabricator.wikimedia.org/T78482#936013 (10Qgil) [10:33:40] 3Wikidata, Community-Engagement, Project-Creators: Phabricator projects for Wikimedia sister projects - https://phabricator.wikimedia.org/T802#936014 (10Qgil) [10:36:45] (03PS2) 10Aaron Schulz: Avoiding starting transactions for SHOW MASTER/SLAVE STATUS [core] - 10https://gerrit.wikimedia.org/r/180702 [10:39:08] 3ops-core: Setting up a mirror serv{er,ice} - https://phabricator.wikimedia.org/T84817#936024 (10akosiaris) I +1 both ideas, namely splitting the install-server from the mirror and setting up a debian mirror. [10:39:33] (03PS11) 1020after4: Huge refactor of security policy enforcer stuff. [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/179405 [10:40:23] 3Shop-Theme: Test on browsers - https://phabricator.wikimedia.org/T78759#936032 (10Prtksxna) a:5Prtksxna>3violetto [10:47:14] 3Shop-Theme: Add search to the top menubar - https://phabricator.wikimedia.org/T78379#936036 (10violetto) the icon just needs to be bigger 48x48 instead of 24x24 and starts with #777, becomes #333 when active. Can we make it so half of the entire bar is clickable to start searching not just where the placeholder... [11:03:21] (03PS3) 10Aude: Cleanup SiteListFileCache test files in tearDown [core] - 10https://gerrit.wikimedia.org/r/181047 [11:05:30] 3Shop-Theme: Create pages for order workflow - https://phabricator.wikimedia.org/T84987#936048 (10violetto) 3NEW a:3Prtksxna [11:10:25] 3Shop-Theme: Create pages for order workflow - https://phabricator.wikimedia.org/T84987#936057 (10Prtksxna) p:5Triage>3High [11:11:10] (03PS2) 10Aude: Add documentation for SiteListFileCache [core] - 10https://gerrit.wikimedia.org/r/177098 [11:11:12] 3operations: Varnish: the lower the Age value, the slower the request - https://phabricator.wikimedia.org/T84980#936060 (10faidon) p:5Triage>3Normal a:3BBlack [11:21:02] Python 2.7.9 - https://phabricator.wikimedia.org/T78764#936072 (10jayvdb) 5Open>3Resolved a:3jayvdb [11:22:51] (03CR) 10Aude: [C: 04-1] "would like to unify the interface a bit more with the SiteStore interface and have SiteSQLStore implement both." [core] - 10https://gerrit.wikimedia.org/r/179448 (owner: 10Aude) [11:28:21] (03PS3) 10Aude: Add documentation for SiteListFileCache [core] - 10https://gerrit.wikimedia.org/r/177098 [11:32:21] (03PS8) 10Aude: Add SiteLookup interface [core] - 10https://gerrit.wikimedia.org/r/179448 [11:34:10] (03CR) 10jenkins-bot: [V: 04-1] Add documentation for SiteListFileCache [core] - 10https://gerrit.wikimedia.org/r/177098 (owner: 10Aude) [11:37:59] (03CR) 10jenkins-bot: [V: 04-1] Add SiteLookup interface [core] - 10https://gerrit.wikimedia.org/r/179448 (owner: 10Aude) [11:42:05] (03CR) 10QChris: [C: 032] Temporarily re-add JsonSchemaContent::getJsonData [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/181019 (owner: 10Ori.livneh) [11:43:57] (03Merged) 10jenkins-bot: Temporarily re-add JsonSchemaContent::getJsonData [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/181019 (owner: 10Ori.livneh) [11:54:02] 3operations: create pxe-bootable rescue image - https://phabricator.wikimedia.org/T76135#936145 (10fgiunchedi) a:3fgiunchedi [11:55:32] 3operations: Add updating labs/private with $::puppetmaster_autoupdate feature flag - https://phabricator.wikimedia.org/T75904#936146 (10fgiunchedi) ran into a similar issue today, I'm not even sure why we are cloning labs/private over ssh while it is freely clonable over https [11:55:50] 3§ Phabricator-Sprint-Extension: Use SprintFactDaemon to record and aggregate Maniphest Transactions related to points and status changes. - https://phabricator.wikimedia.org/T78127#936148 (10mmodell) @christopher:Thank you for thoroughly addressing the issues I raised. This does help ease my concerns quite a bi... [11:56:44] 3operations: Add updating labs/private with $::puppetmaster_autoupdate feature flag - https://phabricator.wikimedia.org/T75904#936154 (10fgiunchedi) a:3yuvipanda [11:57:08] (03CR) 10QChris: "recheck" [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/181006 (owner: 10Ori.livneh) [11:57:52] 3Project-Creators: Create a project for MediaWiki Language Extension Bundle - https://phabricator.wikimedia.org/T84880#936157 (10Arrbee) Using a release tag may actually be a good idea. Thank you for that suggestion @Qgil. I think we will go with that if there are no further concerns. [11:58:03] 3operations: provide a pxe-bootable rescue image - https://phabricator.wikimedia.org/T78135#936158 (10fgiunchedi) p:5Triage>3Low [12:12:24] 3MediaWiki-General-or-Unknown: Support inline styles for images - https://phabricator.wikimedia.org/T84991#936161 (10MC8) 3NEW [12:12:39] 3MediaWiki-General-or-Unknown: Support inline styles for images - https://phabricator.wikimedia.org/T84991#936161 (10MC8) [12:15:12] (03PS3) 10Florianschmidtwelzow: Getting rid of some globals [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/179838 [12:15:38] (03PS2) 10QChris: Allow to get JsonContent data as associative array [core] - 10https://gerrit.wikimedia.org/r/180771 [12:15:40] (03PS1) 10QChris: Remove caching of JsonContent's getData object [core] - 10https://gerrit.wikimedia.org/r/181052 [12:21:33] 3MediaWiki-extensions-ContentTranslation: Section alignments do not break due to different actions - https://phabricator.wikimedia.org/T84978#936174 (10Arrbee) [12:25:32] 3Wikidata, Project-Creators, Community-Engagement: Phabricator projects for Wikimedia sister projects - https://phabricator.wikimedia.org/T802#936176 (10Aklapper) Had drafted some comments for T78482, now pasting them here: I'd be willing to give this a try if wanted by some communities as it's an idea to impro... [12:36:22] (03PS2) 10QChris: Remove caching of JsonContent's getData object [core] - 10https://gerrit.wikimedia.org/r/181052 [12:36:24] (03PS3) 10QChris: Allow to get JsonContent data as associative array [core] - 10https://gerrit.wikimedia.org/r/180771 [12:40:03] (03PS1) 10Pwirth: Blog: Small css fix [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/181055 [12:52:14] (03CR) 10QChris: "Ori> [ Let's remove the caching again ]" [core] - 10https://gerrit.wikimedia.org/r/180771 (owner: 10QChris) [12:53:45] 3Team-Practices, Community-Engagement, Engineering-Community: How to address the long tail of low priority tasks - https://phabricator.wikimedia.org/T78639#936184 (10Aklapper) "If you don't work on it, don't expect anybody else to work on it." That's my cruel understanding of FOSS projects where anybody can pro... [12:58:36] 3Team-Practices, Community-Engagement, Engineering-Community: How to address the long tail of low priority tasks - https://phabricator.wikimedia.org/T78639#936186 (10Aklapper) > promoting easy tasks That's related to review speed (T78768), and to awareness of established developers to judge the complexity of a t... [13:02:01] (03CR) 10Daniel Kinzler: "recheck" [core] - 10https://gerrit.wikimedia.org/r/179448 (owner: 10Aude) [13:02:43] 3Wikidata, MediaWiki-extensions-WikibaseRepository: property datatype does not link - https://phabricator.wikimedia.org/T84992#936189 (10Lydia_Pintscher) 3NEW [13:08:39] (03PS1) 10Luis Felipe Schenone: Minor bugfix [extensions/MsCatSelect] - 10https://gerrit.wikimedia.org/r/181057 [13:08:52] 3Wikidata, MediaWiki-extensions-WikibaseRepository: fix the issue of people not seeing the suggestion in the main search box - https://phabricator.wikimedia.org/T55476#936197 (10thiemowmde) The feature is live on wikidata.org but it seems there is a bug. The spinner is not shown initially. I investigated and fou... [13:09:32] (03CR) 10Luis Felipe Schenone: [C: 032 V: 032] Minor bugfix [extensions/MsCatSelect] - 10https://gerrit.wikimedia.org/r/181057 (owner: 10Luis Felipe Schenone) [13:13:32] (03PS9) 10Aude: Add SiteLookup interface [core] - 10https://gerrit.wikimedia.org/r/179448 [13:19:27] (03CR) 10jenkins-bot: [V: 04-1] Add SiteLookup interface [core] - 10https://gerrit.wikimedia.org/r/179448 (owner: 10Aude) [13:19:50] 3MediaWiki-extensions-WikibaseRepository: Add i18n messages for property data type - https://phabricator.wikimedia.org/T84993#936202 (10aude) 3NEW [13:26:33] (03CR) 10Aude: [C: 04-1] "work in progress, not sure i like the interface like this and to merge them like this..." [core] - 10https://gerrit.wikimedia.org/r/179448 (owner: 10Aude) [13:37:29] 3MediaWiki-extensions-PageCuration: Page Curation tool lists "No Citations" issue on disambiguation pages - https://phabricator.wikimedia.org/T78601#936219 (10Swpb) [13:37:30] 3MediaWiki-extensions-PageCuration, MediaWiki-extensions-Disambiguator: Disambiguation pages should not be marked as "No citations" - https://phabricator.wikimedia.org/T76198#936220 (10Swpb) [13:42:04] 3MediaWiki-extensions-ApiSandbox: Examples surrounded by visible p tags - https://phabricator.wikimedia.org/T84995#936223 (10Lokal_Profil) 3NEW [13:42:18] 3Wikidata, MediaWiki-extensions-WikibaseRepository: property datatype does not link - https://phabricator.wikimedia.org/T84992#936230 (10daniel) In WikibaseValueFormatterBuilders, there is this list of formatters for HTML output: ``` SnakFormatter::FORMAT_HTML => array( 'PT:url' => 'Wikibase\Lib\HtmlUrlFo... [13:43:35] 3Wikidata, MediaWiki-extensions-WikibaseRepository: property datatype does not link - https://phabricator.wikimedia.org/T84992#936231 (10aude) [13:43:40] 3MediaWiki-Core-Team, operations, Services: Set warning thresholds for average cluster utilization - https://phabricator.wikimedia.org/T76306#936232 (10fgiunchedi) for capacity planning purposes I think we should also get an idea of how many requests a box can handle within a threshold latency, look at requests/... [13:44:23] 3MediaWiki-extensions-WikibaseRepository: Add i18n messages for property data type - https://phabricator.wikimedia.org/T84993#936234 (10aude) [13:44:32] 3MediaWiki-extensions-ApiSandbox: Examples surrounded by visible p tags - https://phabricator.wikimedia.org/T84995#936235 (10Lokal_Profil) [13:46:44] 3MediaWiki-extensions-PageCuration: "Tag" and "mark as reviewed" buttons on Curation toolbar appear to be broken. - https://phabricator.wikimedia.org/T84996#936236 (10Swpb) 3NEW [13:49:52] 3operations: Make ircecho run as its own user - https://phabricator.wikimedia.org/T76203#936243 (10fgiunchedi) a:3yuvipanda [13:50:02] 3operations: Make ircecho run as its own user - https://phabricator.wikimedia.org/T76203#792998 (10fgiunchedi) p:5Triage>3Low [13:50:49] 3Mobile-Apps: Mobile app edit inserting JSON blob - https://phabricator.wikimedia.org/T84997#936246 (10Ironholds) 3NEW [13:52:20] 3MediaWiki-extensions-ContentTranslation: Manual Testing Scenarios for January 2015 deployment - https://phabricator.wikimedia.org/T78377#936253 (10Arrbee) Currently, when trying to view a draft by using the URL the following happens: # user can see a broken translation view with emptiness in the source and t... [13:58:09] 3operations: Prepend timestamp in /var/log/puppet.log - https://phabricator.wikimedia.org/T75989#936259 (10fgiunchedi) a:3hashar note that ATM puppet is logging to syslog in trusty in labs and prod [13:58:20] 3operations: Prepend timestamp in /var/log/puppet.log - https://phabricator.wikimedia.org/T75989#936261 (10fgiunchedi) p:5Triage>3Low [13:59:07] 3operations: Shinken hostname column is not large enough - https://phabricator.wikimedia.org/T1362#936262 (10fgiunchedi) a:3yuvipanda [14:04:52] 3Legalpad: Recreate Trusted User Tool in phab-01.wmflabs.org - https://phabricator.wikimedia.org/T880#936270 (10Qgil) [14:06:51] 3WMF-Legal, Engineering-Community: Implement the Volunteer NDA process in Phabricator - https://phabricator.wikimedia.org/T655#936274 (10Qgil) [14:09:32] (03CR) 10Manybubbles: "Pretty much what Aaron said. I'll a bunch of that to the commit message." (031 comment) [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/178903 (owner: 10Manybubbles) [14:11:33] 3WMF-Legal, Engineering-Community: Implement the Volunteer NDA process in Phabricator - https://phabricator.wikimedia.org/T655#936287 (10Qgil) [14:13:31] 3ops-requests, operations, Engineering-Community: Define the RT process for volunteer NDAs - https://phabricator.wikimedia.org/T84400#936289 (10Qgil) [14:14:19] (03PS2) 10NikiWiki: Make table-width variable [core] - 10https://gerrit.wikimedia.org/r/178068 [14:14:28] 3ops-requests, operations, Engineering-Community: Define the RT process for volunteer NDAs - https://phabricator.wikimedia.org/T84400#926843 (10Qgil) [14:14:29] 3WMF-Legal, Engineering-Community: Implement the Volunteer NDA process in Phabricator - https://phabricator.wikimedia.org/T655#936294 (10Qgil) [14:20:56] 3operations: something (reqstats?) puts many different metrics into graphite, allocating a lot of disk space - https://phabricator.wikimedia.org/T1075#936296 (10fgiunchedi) p:5Triage>3High [14:21:24] 3Education-Program-Design-Research: Getting familiar with php - https://phabricator.wikimedia.org/T78683#936297 (10Aklapper) a:3Sputniza (Assigning to your as this looks like a personal task; as a side effect you get such tasks listed on https://phabricator.wikimedia.org/maniphest/ if "Assigned" is your top qu... [14:22:28] 3operations: Puppetize ircyall & set up instance appropriately - https://phabricator.wikimedia.org/T1357#936302 (10fgiunchedi) p:5Triage>3Normal [14:23:04] 3operations: Allow defining hiera data for all of labs - https://phabricator.wikimedia.org/T1291#936303 (10fgiunchedi) a:3yuvipanda [14:23:07] 3Education-Program-Design-Research: Setting up Vagrant - https://phabricator.wikimedia.org/T78682#936305 (10Aklapper) a:3Sputniza >>! In T78682#852593, @Sputniza wrote: > I indeed put it here more like a personal task for myself, or to remind me and my others, what else I'm busy with. Is that ok? That's okay... [14:23:22] 3operations: Allow defining hiera data for all of labs - https://phabricator.wikimedia.org/T1291#22575 (10fgiunchedi) p:5Triage>3Normal [14:24:19] 3MediaWiki-Core-Team, operations: Review Graphite scaling options - https://phabricator.wikimedia.org/T1018#936310 (10fgiunchedi) a:3fgiunchedi assigning to myself, though not sure what this is about [14:24:58] (03PS7) 10Manybubbles: Adds support for taking multiple locks [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/178903 [14:25:14] 3WMF-Legal, operations, Engineering-Community: Implement the Volunteer NDA process in Phabricator - https://phabricator.wikimedia.org/T655#936312 (10Qgil) [14:26:22] 3operations: require_package behaves herratically with other puppet contructs - https://phabricator.wikimedia.org/T1245#936314 (10fgiunchedi) a:3ori I //think// this is no longer an issue, but @ori might have more context on what's really going on [14:26:32] 3operations: require_package behaves herratically with other puppet contructs - https://phabricator.wikimedia.org/T1245#936316 (10fgiunchedi) p:5Triage>3Low [14:26:58] (03CR) 10Manybubbles: "PS7 handles Tim's comment about returning NULL and not handling it. We now explicitly handle it by complaining and exit(ERROR)-ing." [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/178903 (owner: 10Manybubbles) [14:27:13] 3WMF-Legal, operations, Engineering-Community: Implement the Volunteer NDA process in Phabricator - https://phabricator.wikimedia.org/T655#11021 (10Qgil) [14:28:08] 3operations: Disable cron.standard checking for lost+found directories - https://phabricator.wikimedia.org/T1249#936318 (10fgiunchedi) p:5Triage>3Low what's cron.standard? where can it be found? [14:28:18] 3operations: Disable cron.standard checking for lost+found directories - https://phabricator.wikimedia.org/T1249#936321 (10fgiunchedi) a:3yuvipanda [14:28:40] 3Monitoring, operations: icinga "max concurrent checks" limits reached - https://phabricator.wikimedia.org/T1242#936322 (10fgiunchedi) [14:28:57] 3Monitoring, operations: icinga "max concurrent checks" limits reached - https://phabricator.wikimedia.org/T1242#936323 (10fgiunchedi) p:5Triage>3Normal [14:31:16] 3operations: Disable cron.standard checking for lost+found directories - https://phabricator.wikimedia.org/T1249#936326 (10yuvipanda) It's `/etc/cron.daily/standard` present on all precise machines that basically seems to do nothing but this Lost and Found checking. [14:36:49] 3MediaWiki-extensions-ConfirmAccount: Error in confirmaccount.sql - https://phabricator.wikimedia.org/T84999#936327 (10Paladox) 3NEW [14:42:59] 3MediaWiki-extensions-ConfirmAccount: Error in confirmaccount.sql - https://phabricator.wikimedia.org/T84999#936334 (10Paladox) [14:43:10] 3MediaWiki-extensions-ConfirmAccount: Error in confirmaccount.sql - https://phabricator.wikimedia.org/T84999#936335 (10Paladox) p:5Unbreak!>3High [14:44:18] 3WMF-Legal, operations, Engineering-Community: Implement the Volunteer NDA process in Phabricator - https://phabricator.wikimedia.org/T655#936336 (10Qgil) @LuisV_WMF, @Dzahn), @RobLa-WMF, you should be able to access {L2}, which is just a copy of https://wikitech.wikimedia.org/wiki/File:Volunteer_Non-disclosure_... [14:45:40] 3operations: Disable cron.standard checking for lost+found directories - https://phabricator.wikimedia.org/T1249#936337 (10fgiunchedi) ah! it seems only on precise and not trusty/jessie though? if so I think we can just let it die off unless it is causing problems, and quick and easy and lame way would be to dis... [14:46:09] 3WMF-Legal, operations, Engineering-Community: Implement the Volunteer NDA process in Phabricator - https://phabricator.wikimedia.org/T655#936338 (10Qgil) [14:46:52] (03CR) 10Manybubbles: [C: 031] "Looks good. I'll test it locally soon." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/180995 (owner: 10Chad) [14:53:20] 3MediaWiki-API: API: Purpose of "batchcomplete" property and implementation - https://phabricator.wikimedia.org/T84977#936343 (10Anomie) The purpose of the property is to let clients know when a batch of pages is complete. It's mainly useful along with generators, but for consistency it works the same way any ti... [14:54:39] 3operations: Disable cron.standard checking for lost+found directories - https://phabricator.wikimedia.org/T1249#936348 (10yuvipanda) Yup, only on precise. quick and easy and lame way would probably to ensure absent :D [14:55:54] (03PS10) 10Aude: Add SiteLookup interface [core] - 10https://gerrit.wikimedia.org/r/179448 [15:00:07] 3operations: Fix /a vs /srv rsync module discrepency mess on stat* boxes - https://phabricator.wikimedia.org/T77029#936349 (10Ottomata) 5Open>3Resolved This is kinda sorta fixed. stat1003 does not have /a, and previously this was confusing to users, as much of the structure they are used to lives in /a on s... [15:02:23] 3MediaWiki-Database: Investigate query planning in MariaDB 10 - https://phabricator.wikimedia.org/T85000#936352 (10Anomie) 3NEW [15:04:17] 3MediaWiki-User-blocking, Analytics: Make a SpecialPage to show stats on blocked IP (ranges) that attempt to edit - https://phabricator.wikimedia.org/T78840#936359 (10Aklapper) p:5Triage>3Volunteer? [15:04:31] 3MediaWiki-extensions-CodeEditor, MediaWiki-JavaScript: LivePreview: no changes reflected on preview/diff when using CodeEditor - https://phabricator.wikimedia.org/T78838#936360 (10Aklapper) p:5Triage>3Volunteer? [15:04:40] 3MediaWiki-JavaScript: LivePreview: duplicate 'templates used on this page' list - https://phabricator.wikimedia.org/T78834#936361 (10Aklapper) p:5Triage>3Volunteer? [15:04:48] 3MediaWiki-extensions-PageCuration: "Tag" and "mark as reviewed" buttons on Curation toolbar appear to be broken. - https://phabricator.wikimedia.org/T84996#936362 (10Swpb) p:5Unbreak!>3High [15:05:20] 3MediaWiki-extensions-PageCuration: "Tag" and "mark as reviewed" buttons on Curation toolbar appear to be broken. - https://phabricator.wikimedia.org/T84996#936236 (10Swpb) p:5High>3Unbreak! [15:06:21] 3Wikimedia-General-or-Unknown: Empty respond for fawikinews recentchanges (works when using debug=true) - https://phabricator.wikimedia.org/T78776#936365 (10Aklapper) 5Open>3Resolved a:3Aklapper Closing as per last comment. Thanks everybody! [15:07:20] 3MediaWiki-General-or-Unknown: Support inline styles for images - https://phabricator.wikimedia.org/T84991#936368 (10Aklapper) p:5Triage>3Volunteer? [15:08:46] 3Wiki-Release-Team: Mentor Google Code-in 2014 Student(s): Help Compile a List of MediaWiki Third Party Customers - https://phabricator.wikimedia.org/T76893#936370 (10Palexis) Pranavmk98 is working fast and furious to get through these recurring tasks. :) [15:09:27] 3MediaWiki-extensions-RelatedArticles: #related use wrong CSS classes on Monobook & Modern - https://phabricator.wikimedia.org/T84840#936371 (10Aklapper) p:5Normal>3Volunteer? [15:09:57] 3MediaWiki-Page-editing: Edits that were created using StashEdit API show wrong timestamp - https://phabricator.wikimedia.org/T84843#936372 (10Aklapper) p:5Triage>3Normal [15:12:01] cloning mediawiki's repo.. this will take a while [15:13:09] (03CR) 10Daniel Kinzler: "Is there any code that uses the value returned from getData as an object? If there isn't, FORCE_ASSOC should be the default, or even alway" [core] - 10https://gerrit.wikimedia.org/r/180771 (owner: 10QChris) [15:14:23] (03CR) 10Daniel Kinzler: "Caching is important. One way would be to simply convert the object to an assoc array on demand. But I still prefer to just always use an " [core] - 10https://gerrit.wikimedia.org/r/181052 (owner: 10QChris) [15:15:27] (03CR) 10Daniel Kinzler: [C: 032] Add documentation for SiteListFileCache [core] - 10https://gerrit.wikimedia.org/r/177098 (owner: 10Aude) [15:15:30] 3MediaWiki-Database: Investigate query planning in MariaDB 10 - https://phabricator.wikimedia.org/T85000#936374 (10Anomie) The idea is to select by, group by, and sort by the "name_title" index on the page table so no filesorting is necessary. Variations that may accomplish this include: Remove the MySQL workar... [15:16:24] (03CR) 10Anomie: "I filed T85000 for the potential MariaDB 10 issue." [core] - 10https://gerrit.wikimedia.org/r/179146 (owner: 10Anomie) [15:17:55] 3MediaWiki-API, MediaWiki-Core-Team: allpages filterlanglinks DBQueryError - https://phabricator.wikimedia.org/T78276#936384 (10Anomie) 5Open>3Resolved The fix should be deployed to WMF wikis with 1.25wmf14, see https://www.mediawiki.org/wiki/MediaWiki_1.25/Roadmap for the schedule. [15:19:55] (03PS4) 10Florianschmidtwelzow: Add new reCaptcha (no captcha) to ConfirmEdit [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/179793 [15:21:21] (03Merged) 10jenkins-bot: Add documentation for SiteListFileCache [core] - 10https://gerrit.wikimedia.org/r/177098 (owner: 10Aude) [15:23:02] (03PS1) 10Manybubbles: Fix jenkins setup [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/181074 [15:25:38] (03CR) 10Florianschmidtwelzow: [C: 04-1] Use the modernized reCaptcha API, which hopefully allows for intervention-free verification (033 comments) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/180076 (owner: 10Gerrit Patch Uploader) [15:27:11] (03PS5) 10Florianschmidtwelzow: Add new reCaptcha (no captcha) to ConfirmEdit [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/179793 [15:29:20] (03PS2) 10Umherirrender: tables.sql: Improve description of old_flags [core] - 10https://gerrit.wikimedia.org/r/179873 (owner: 10PleaseStand) [15:29:26] (03CR) 10Umherirrender: [C: 032] tables.sql: Improve description of old_flags [core] - 10https://gerrit.wikimedia.org/r/179873 (owner: 10PleaseStand) [15:30:31] (03CR) 10Daniel Kinzler: [C: 04-1] "Makes sense, some issues." (0313 comments) [core] - 10https://gerrit.wikimedia.org/r/179448 (owner: 10Aude) [15:33:45] 3Wikimedia-Git-or-Gerrit: Gerrit bug search not (naively) working with Phabricator tasks - https://phabricator.wikimedia.org/T85002#936393 (10Anomie) 3NEW [15:33:46] (03PS3) 10Umherirrender: Make HTMLForm::formatErrors non-static to can parse message in context [core] - 10https://gerrit.wikimedia.org/r/179597 [15:34:14] (03CR) 10Umherirrender: "Patch Set 3: Changed to non-static function" [core] - 10https://gerrit.wikimedia.org/r/179597 (owner: 10Umherirrender) [15:35:24] (03CR) 10jenkins-bot: [V: 04-1] tables.sql: Improve description of old_flags [core] - 10https://gerrit.wikimedia.org/r/179873 (owner: 10PleaseStand) [15:35:42] 3operations: Gentlemans Box and Boozestones - https://phabricator.wikimedia.org/T85003#936403 (10emailbot) [15:37:11] 3MediaWiki-Redirects: Strip rdfrom parameter in canonical urls - https://phabricator.wikimedia.org/T84837#936405 (10Aklapper) p:5Triage>3Low [15:37:29] 3operations: Gentlemans Box and Boozestones - https://phabricator.wikimedia.org/T85003#936406 (10Chad) 5Open>3Invalid a:3Chad Bogus task. [15:37:43] (03CR) 10Aude: [C: 04-2] "i don't think this makes sense to use SiteList in the site lookup interface. would like to avoid that." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/179448 (owner: 10Aude) [15:40:08] (03CR) 10Zfilipin: [C: 031] Fix jenkins setup [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/181074 (owner: 10Manybubbles) [15:40:49] (03CR) 10Chad: [C: 032] Fix jenkins setup [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/181074 (owner: 10Manybubbles) [15:40:59] 3MediaWiki-Search: Searching for "File:" shows no results, yet a result count is shown - https://phabricator.wikimedia.org/T84856#936409 (10Aklapper) p:5Triage>3Low [15:41:06] (03Merged) 10jenkins-bot: Fix jenkins setup [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/181074 (owner: 10Manybubbles) [15:41:32] (03CR) 10Zfilipin: "On a second look, mwext-CirrusSearch-bundle-rubocop is failing, and looks like the change did not fix mwext-browsertests-CirrusSearch-phan" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/181074 (owner: 10Manybubbles) [15:42:29] (03CR) 10Zfilipin: "Oops, replied too late, after this was merged. :)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/181074 (owner: 10Manybubbles) [15:42:55] 3MediaWiki-JavaScript: LivePreview: Since 1.25wmf12 in 'section=new' mode the section header is not shown - https://phabricator.wikimedia.org/T84877#936410 (10Aklapper) p:5Triage>3Normal [15:43:34] 3MediaWiki-extensions-PageCuration: "Tag" and "mark as reviewed" buttons on Curation toolbar appear to be broken. - https://phabricator.wikimedia.org/T84996#936411 (10Swpb) Automatic messaging of the page creator is also broken. [15:47:14] (03PS1) 10MarkTraceur: Add unit tests for details step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181075 [15:47:18] (03CR) 10jenkins-bot: [V: 04-1] Add unit tests for details step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181075 (owner: 10MarkTraceur) [15:48:19] (03PS2) 10MarkTraceur: Add unit tests for details step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181075 [15:49:04] (03PS2) 10MarkTraceur: Add tests for upload step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/180541 [15:49:19] (03CR) 10jenkins-bot: [V: 04-1] Add unit tests for details step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181075 (owner: 10MarkTraceur) [15:51:08] (03PS3) 10MarkTraceur: Add unit tests for details step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181075 [15:51:42] (03CR) 10jenkins-bot: [V: 04-1] Add unit tests for details step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181075 (owner: 10MarkTraceur) [15:51:50] (03PS3) 10MarkTraceur: Add tests for tutorial step object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/180521 [15:52:24] (03CR) 10jenkins-bot: [V: 04-1] Add tests for tutorial step object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/180521 (owner: 10MarkTraceur) [15:52:28] (03CR) 10MarkTraceur: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181075 (owner: 10MarkTraceur) [15:59:12] 3ops-codfw: label/setup/update servers haedus & capella - https://phabricator.wikimedia.org/T84901#936419 (10Papaul) 5Open>3Resolved Racktable updated Visible label updated mgmt updated and tested old name: solr2 new name: haedus asset tag: WMF5834 mgmt ip: 10.193.2.1 port #: ge-5/0/20 old name: solr3 new... [15:59:13] 3ops-core: deploy haedus and capella with os for orientdb testing - https://phabricator.wikimedia.org/T84902#936421 (10Papaul) [16:00:30] !wg ContentHandlerUseDB [16:00:30] https://www.mediawiki.org/wiki/Manual:%24wgContentHandlerUseDB [16:01:28] (03PS3) 10Umherirrender: Change case of class names to match declarations [core] - 10https://gerrit.wikimedia.org/r/180856 (owner: 10PleaseStand) [16:01:35] (03CR) 10Umherirrender: [C: 032] Change case of class names to match declarations [core] - 10https://gerrit.wikimedia.org/r/180856 (owner: 10PleaseStand) [16:02:55] 3MediaWiki-Parser:   should terminate a free external link - https://phabricator.wikimedia.org/T84937#936423 (10Aklapper) p:5Triage>3Normal [16:03:34] 3operations, ops-core: Build a new HHVM package - https://phabricator.wikimedia.org/T84853#936425 (10Joe) trying to build a new hhvm package, but had met some roadbumps until now. Patchset is https://gerrit.wikimedia.org/r/#/c/180752/ [16:06:47] (03PS2) 10Anomie: Normalize newlines before calling preprocessor [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/180022 [16:07:35] (03CR) 10jenkins-bot: [V: 04-1] Change case of class names to match declarations [core] - 10https://gerrit.wikimedia.org/r/180856 (owner: 10PleaseStand) [16:07:49] (03Merged) 10jenkins-bot: Change case of class names to match declarations [core] - 10https://gerrit.wikimedia.org/r/180856 (owner: 10PleaseStand) [16:09:20] 3Wikidata, MediaWiki-extensions-WikibaseRepository: property datatype does not link - https://phabricator.wikimedia.org/T84992#936430 (10Unicodesnowman) 5Open>3Resolved a:3Unicodesnowman [16:11:20] 3MediaWiki-Recent-changes: Simple RecentChanges search can repeatably result in db timeout - https://phabricator.wikimedia.org/T84896#936434 (10Aklapper) p:5Triage>3Normal [16:11:26] (03PS2) 10Anomie: Format multiple autocomments in edit summaries [core] - 10https://gerrit.wikimedia.org/r/159326 (https://bugzilla.wikimedia.org/16530) [16:11:38] (03PS3) 10Umherirrender: Make the autoload generator use forward slashes on all OSs [core] - 10https://gerrit.wikimedia.org/r/178376 (owner: 10TTO) [16:11:44] (03CR) 10Anomie: [C: 04-1] "PS2: Rebase" [core] - 10https://gerrit.wikimedia.org/r/159326 (https://bugzilla.wikimedia.org/16530) (owner: 10Anomie) [16:11:46] (03CR) 10Umherirrender: [C: 032] Make the autoload generator use forward slashes on all OSs [core] - 10https://gerrit.wikimedia.org/r/178376 (owner: 10TTO) [16:12:03] 3MediaWiki-Unit-tests: Using wfSuppressWarnings() / wfRestoreWarnings() in a test cause other tests to fail - https://phabricator.wikimedia.org/T84885#936435 (10Aklapper) p:5Triage>3Low [16:12:41] 3MediaWiki-extensions-WikibaseRepository: Use CSS instead of jQuery for wb-claim-name position animation - https://phabricator.wikimedia.org/T85004#936437 (10Krinkle) 3NEW [16:13:58] Showing how to subscribe to a single task for a screencast - https://phabricator.wikimedia.org/T78655#936445 (10Aklapper) 5Open>3Resolved a:3Aklapper The underlying Code-in task was resolved, hence I'm closing this ticket [16:18:00] (03CR) 10jenkins-bot: [V: 04-1] Make the autoload generator use forward slashes on all OSs [core] - 10https://gerrit.wikimedia.org/r/178376 (owner: 10TTO) [16:22:13] 3MediaWiki-Maintenance-scripts: generateLocalAutoload.php outputs backslashes on Windows machines - https://phabricator.wikimedia.org/T77004#936451 (10Umherirrender) 5Open>3Resolved [16:29:05] (03PS1) 10Umherirrender: Use also $wgAutoloadClasses in tests for module names [core] - 10https://gerrit.wikimedia.org/r/181086 [16:29:47] (03CR) 10Umherirrender: "Follow-Up: Ic2024605d7d59890c527cc0580a49da73f8516c8" [core] - 10https://gerrit.wikimedia.org/r/173874 (owner: 10Umherirrender) [16:30:56] (03CR) 10Aude: Add SiteLookup interface (035 comments) [core] - 10https://gerrit.wikimedia.org/r/179448 (owner: 10Aude) [16:31:07] (03PS11) 10Aude: Add SiteLookup interface [core] - 10https://gerrit.wikimedia.org/r/179448 [16:32:47] (03CR) 10Aude: "after trying to have SiteSQLStore implement SiteLookup AND SiteStore, i think it is a bad idea." [core] - 10https://gerrit.wikimedia.org/r/179448 (owner: 10Aude) [16:33:55] (03CR) 10Legoktm: [C: 032] Make HTMLForm::formatErrors non-static to can parse message in context [core] - 10https://gerrit.wikimedia.org/r/179597 (owner: 10Umherirrender) [16:34:10] (03PS2) 10Umherirrender: Use also $wgAutoloadClasses in tests for module names [core] - 10https://gerrit.wikimedia.org/r/181086 [16:34:26] (03CR) 10Krinkle: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181075 (owner: 10MarkTraceur) [16:34:48] (03CR) 10jenkins-bot: [V: 04-1] Add unit tests for details step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181075 (owner: 10MarkTraceur) [16:38:45] (03PS12) 10Aude: Add SiteLookup interface [core] - 10https://gerrit.wikimedia.org/r/179448 [16:42:16] (03CR) 10jenkins-bot: [V: 04-1] Make HTMLForm::formatErrors non-static to can parse message in context [core] - 10https://gerrit.wikimedia.org/r/179597 (owner: 10Umherirrender) [16:43:33] (03CR) 10Krinkle: "debug#l14" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181075 (owner: 10MarkTraceur) [16:43:38] (03CR) 10Krinkle: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181075 (owner: 10MarkTraceur) [16:44:36] (03CR) 10jenkins-bot: [V: 04-1] Add SiteLookup interface [core] - 10https://gerrit.wikimedia.org/r/179448 (owner: 10Aude) [16:48:01] (03CR) 10Krinkle: "recheck" [core] - 10https://gerrit.wikimedia.org/r/179448 (owner: 10Aude) [16:48:06] (03PS4) 10Niharika29: [WIP] Create new "Primary language community on wiki" question [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/180802 [16:49:37] (03CR) 10Legoktm: "recheck" [core] - 10https://gerrit.wikimedia.org/r/179597 (owner: 10Umherirrender) [16:50:15] 3MediaWiki-Core-Team, Scrum-of-Scrums, LabsDB-Auditor: Manually verify whitelisted.yaml / graylisted.yaml to ensure completeness - https://phabricator.wikimedia.org/T78730#936485 (10mark) [16:50:45] 3OpenBadges, MediaWiki-extensions-Extensions-requests: Integration of Mozilla OpenBadges and MediaWiki users - https://phabricator.wikimedia.org/T62064#936486 (10Lokal_Profil) >>! In T62064#655408, @Qgil wrote: > A project developed by a team of students is starting to work on this, in the context of the Faceboo... [16:54:34] (03PS1) 10QChris: Turn validation fixture into valid Json [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/181088 [16:55:05] (03PS5) 10Niharika29: [WIP] Create new "Primary language community on wiki" question [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/180802 [16:56:34] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Store the badges of sitelinks in a queryable format - https://phabricator.wikimedia.org/T72229#936489 (10Superyetkin) p:5Normal>3High I agree that badges should be stored in another table. By the way, I was told that the current way of accessing the badges... [17:00:07] (03PS1) 10Umherirrender: Use more pretty output in ResourceLoader debug mode for arrays [core] - 10https://gerrit.wikimedia.org/r/181089 [17:03:16] 3Mobile-Web: VisualEditor JavaScript and tests should only be added if VisualEditor is installed - https://phabricator.wikimedia.org/T85007#936494 (10Jdlrobson) 3NEW [17:04:00] (03CR) 10Krinkle: [C: 032] "Thanks!" [core] - 10https://gerrit.wikimedia.org/r/181089 (owner: 10Umherirrender) [17:05:16] (03PS2) 10Krinkle: Revert "Simplify MWTidy" [core] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180830 (owner: 10Catrope) [17:05:57] (03CR) 10Krinkle: "recheck" [core] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/180831 (owner: 10Catrope) [17:06:11] 3MediaWiki-Unit-tests: Make Travis CI pass hhvm/MySQL tests - https://phabricator.wikimedia.org/T75175#936504 (10hashar) [17:06:52] 3operations, ops-core: Build a new HHVM package - https://phabricator.wikimedia.org/T84853#936507 (10hashar) Note {T75531} is now resolved, spa new HHVM package is no more a blocker for CI (the job is even voting now). [17:11:09] (03CR) 10jenkins-bot: [V: 04-1] Revert "Simplify MWTidy" [core] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180830 (owner: 10Catrope) [17:12:49] (03PS1) 10Umherirrender: Set mw.config wgFileExtensions only on Upload instead of site-wide [core] - 10https://gerrit.wikimedia.org/r/181090 [17:14:17] (03Merged) 10jenkins-bot: Use more pretty output in ResourceLoader debug mode for arrays [core] - 10https://gerrit.wikimedia.org/r/181089 (owner: 10Umherirrender) [17:17:07] (03CR) 10QChris: "> Is there any code that uses the value returned from getData as an object?" [core] - 10https://gerrit.wikimedia.org/r/180771 (owner: 10QChris) [17:17:19] 3ops-core: deploy haedus and capella with os for orientdb testing - https://phabricator.wikimedia.org/T84902#936514 (10RobH) old name: solr2 new name: haedus asset tag: WMF5834 mgmt ip: 10.193.2.1 port #: ge-5/0/20 old name: solr3 new name: capella asset tag: WMF5835 mgmt ip: 10.193.2.2 port #: ge-5/0/21 pulli... [17:18:31] 3MediaWiki-extensions-Translate: Page display title should be allowed to use a non-existent fake namespace after move - https://phabricator.wikimedia.org/T41041#936516 (10Glaisher) Hmm.. this does not only happen after page moves. reported at [[ https://meta.wikimedia.org/w/index.php?title=Wikimedia_Forum&oldid=... [17:21:17] Trebuchet/git-deploy maintenance - https://phabricator.wikimedia.org/T85008#936522 (10cscott) 3NEW [17:21:24] 3MediaWiki-extensions-Translate: Page display title should be allowed to use a non-existent fake namespace after move - https://phabricator.wikimedia.org/T41041#936525 (10Nemo_bis) [17:26:11] (03CR) 10Legoktm: "I see a few extensions that are using it since it's global...:" [core] - 10https://gerrit.wikimedia.org/r/181090 (owner: 10Umherirrender) [17:26:31] (03PS2) 10Krinkle: Revert "Simplify MWTidy" [core] - 10https://gerrit.wikimedia.org/r/180829 (owner: 10Catrope) [17:27:38] (03PS2) 10Umherirrender: SpecialImport: Don't access $this->getConfig() in the constructor [core] - 10https://gerrit.wikimedia.org/r/179959 (owner: 10Legoktm) [17:27:46] (03CR) 10Umherirrender: [C: 032] SpecialImport: Don't access $this->getConfig() in the constructor [core] - 10https://gerrit.wikimedia.org/r/179959 (owner: 10Legoktm) [17:28:51] 3MediaWiki-Export-or-Import: Import sources should be maintained by stewards - https://phabricator.wikimedia.org/T16264#936533 (10Dereckson) a:5Dereckson>3None [17:29:02] (03CR) 10Krinkle: Follow MediaWikis move from getJsonData to getData (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/180778 (owner: 10QChris) [17:32:06] (03CR) 10Krinkle: [C: 04-1] "There should be no need for associative arrays. I'd prefer we try to migrate use first. The assoc mode causes subtle problems and makes th" [core] - 10https://gerrit.wikimedia.org/r/180771 (owner: 10QChris) [17:33:41] (03Merged) 10jenkins-bot: SpecialImport: Don't access $this->getConfig() in the constructor [core] - 10https://gerrit.wikimedia.org/r/179959 (owner: 10Legoktm) [17:34:26] (03CR) 10Krinkle: [C: 04-1] "I don't think we should have getData vary its parsing mode. As for caching, I added that because ContentHandler and the rest of MediaWiki " [core] - 10https://gerrit.wikimedia.org/r/181052 (owner: 10QChris) [17:34:39] 3operations: Decomission lsearchd - https://phabricator.wikimedia.org/T85009#936539 (10Chad) 3NEW [17:34:40] (03PS2) 10Krinkle: Follow MediaWikis move from getJsonData to getData [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/180778 (owner: 10QChris) [17:35:04] 3MediaWiki-Special-pages: SpecialImport accesses $this->getConfig() in constructor, before context is set - https://phabricator.wikimedia.org/T73376#936546 (10Umherirrender) 5Open>3Resolved a:3Umherirrender [17:35:57] 3operations: Decomission lsearchd - https://phabricator.wikimedia.org/T85009#936539 (10Chad) [17:36:14] (03CR) 10jenkins-bot: [V: 04-1] Follow MediaWikis move from getJsonData to getData [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/180778 (owner: 10QChris) [17:36:37] Trebuchet/git-deploy maintenance - https://phabricator.wikimedia.org/T85008#936552 (10Ciencia_Al_Poder) [17:36:58] 3operations: Decomission lsearchd - https://phabricator.wikimedia.org/T85009#936555 (10Chad) [[ https://gerrit.wikimedia.org/r/#/c/180838/ | Pools 2, 4 and 5 are unused ]] and can be removed. [17:37:23] (03CR) 10Legoktm: [C: 04-1] "Nice! Since this is an example extension, I don't think it should contain any deprecated functions. If you could remove those functions, I" [extensions/examples] - 10https://gerrit.wikimedia.org/r/180885 (owner: 10Unicornisaurous) [17:37:40] 3MediaWiki-extensions-WikibaseRepository: Add i18n messages for property data type - https://phabricator.wikimedia.org/T84993#936556 (10Aklapper) Solved already by https://gerrit.wikimedia.org/r/#/c/181059 ? [17:37:58] (03PS1) 10Manybubbles: Add build status badge [search/extra] - 10https://gerrit.wikimedia.org/r/181096 [17:39:37] 3MediaWiki-extensions-WikibaseRepository: Add i18n messages for property data type - https://phabricator.wikimedia.org/T84993#936560 (10Aklapper) [17:40:12] (03PS1) 10Manybubbles: Fix build status icon [search/highlighter] - 10https://gerrit.wikimedia.org/r/181097 [17:40:39] (03CR) 10Aaron Schulz: "One gotcha is that it's easy to accidentally wrap some method in a pool counter call in a way that accidentally violates the rule. It's pr" [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/178903 (owner: 10Manybubbles) [17:41:07] (03PS2) 10Manybubbles: Add build status badge [search/extra] - 10https://gerrit.wikimedia.org/r/181096 [17:41:37] (03CR) 10Manybubbles: [C: 032] Fix build status icon [search/highlighter] - 10https://gerrit.wikimedia.org/r/181097 (owner: 10Manybubbles) [17:41:51] (03CR) 10Manybubbles: [C: 032] Add build status badge [search/extra] - 10https://gerrit.wikimedia.org/r/181096 (owner: 10Manybubbles) [17:42:45] 3Wikimedia-Git-or-Gerrit: Gerrit bug search not (naively) working with Phabricator tasks - https://phabricator.wikimedia.org/T85002#936561 (10Krinkle) Gerrit's configuration for Phabricator references matches the number only and adds the T in the url. The `commentlink` match group should instead include the T in... [17:42:55] (03Merged) 10jenkins-bot: Add build status badge [search/extra] - 10https://gerrit.wikimedia.org/r/181096 (owner: 10Manybubbles) [17:43:26] (03Merged) 10jenkins-bot: Fix build status icon [search/highlighter] - 10https://gerrit.wikimedia.org/r/181097 (owner: 10Manybubbles) [17:46:20] 3operations: IndieGoGo - Gentleman's Box - https://phabricator.wikimedia.org/T85011#936572 (10emailbot) [17:46:29] 3MediaWiki-Interface: Section headings should have some clickable anchor for passing links - https://phabricator.wikimedia.org/T18691#936575 (10blackops0057) Hi. I'm a beginner here and i was wondering if this bug was still open to take, Thanks [17:49:19] (03PS4) 10Niharika29: Create new application question on engagement and roles in Wikimedia Movement [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/180391 [17:50:36] 3MediaWiki-extensions-Flow: Flow: Hidden topic summary - https://phabricator.wikimedia.org/T72070#936579 (10blackops0057) HI I'd like to work on this bug. I'm a beginner and i have built the source code on my PC. How do i begin fixing this bug? [17:50:52] I'm using mw.notify to give notices on a user script of mine, and I'm wondering if there is a way to append to or pull the information back to modify it? Maybe using the tag? [17:51:01] Also, if I want to use both title and tag, are they grouped together in the curly brackets like an object or are they chained? [17:51:35] 3MediaWiki-extensions-WikibaseRepository: Add i18n messages for property data type - https://phabricator.wikimedia.org/T84993#936584 (10Ricordisamoa) a:3Ricordisamoa >>! In T84993#936556, @Aklapper wrote: > Solved already by https://gerrit.wikimedia.org/r/#/c/181059 ? Yes, thanks. Comments in the SpecialListD... [17:51:44] 3MediaWiki-extensions-WikibaseRepository: Add i18n messages for property data type - https://phabricator.wikimedia.org/T84993#936588 (10Ricordisamoa) 5Open>3Resolved [17:55:10] 3Wikimedia-Wikimania-Scholarships: Create new application question on engagement and roles within the movement - https://phabricator.wikimedia.org/T78615#936594 (10NiharikaKohli) @Shouston_WMF http://i.imgur.com/APZCV9I.png Done! [17:55:55] Chaining them like a json string {tag!: 'value', tag2: 'value'} doesn't seem to work. :( [17:58:12] 3Services, MediaWiki-Core-Team, operations: Set warning thresholds for average cluster utilization - https://phabricator.wikimedia.org/T76306#936595 (10GWicke) Lets not allow the perfect to get in the way of the good though. For some services it will make sense to do a deep investigation of latency vs. load, but... [18:00:43] (03CR) 10Manybubbles: ">One gotcha is that it's easy to accidentally wrap some method in a pool counter call in a way that accidentally violates the rule." [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/178903 (owner: 10Manybubbles) [18:00:45] (03PS2) 10Unicornisaurous: Convert API module to use i18n help/documentation. [extensions/examples] - 10https://gerrit.wikimedia.org/r/180885 [18:01:38] 3MediaWiki-Interface: Section headings should have some clickable anchor for passing links - https://phabricator.wikimedia.org/T18691#936596 (10Nemo_bis) > Hi. I'm a beginner here and i was wondering if this bug was still open to take, Thanks It is. https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacke... [18:02:07] (03PS3) 10Krinkle: Follow MediaWiki's move from getJsonData to getData [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/180778 (owner: 10QChris) [18:02:30] (03CR) 10Krinkle: "Added a few minor clean ups relating to the same refactor." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/180778 (owner: 10QChris) [18:03:24] (03CR) 10jenkins-bot: [V: 04-1] Follow MediaWiki's move from getJsonData to getData [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/180778 (owner: 10QChris) [18:03:26] rmoen: I'm using mw.notify to give notices on a user script of mine, and I'm wondering if there is a way to append to or pull the information back to modify it? Maybe using the tag? [18:04:03] Or do I pass it in as a classed DOM object and then just modify that object? [18:04:04] 3MediaWiki-extensions-PageCuration: "Tag" and "mark as reviewed" buttons on Curation toolbar appear to be broken. - https://phabricator.wikimedia.org/T84996#936597 (10Quiddity) Further notes onwiki at https://en.wikipedia.org/wiki/Wikipedia_talk:Page_Curation#Curation_Toolbar [18:04:19] (03CR) 10Bartosz Dziewoński: [C: 04-1] Eventify TemplateDataGenerator and use oojs-ui (032 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo) [18:06:04] (03CR) 10Aaron Schulz: "It could be called 'nowait', doesn't matter." [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/178903 (owner: 10Manybubbles) [18:06:24] 3MediaWiki-extensions-Flow: Flow: Hidden topic summary - https://phabricator.wikimedia.org/T72070#936601 (10blackops0057) What are the steps to reproduce this? [18:09:29] 3MediaWiki-extensions-Flow: Flow: the external link CAPTCHA for a reply appears in wrong place, doesn't work - https://phabricator.wikimedia.org/T71928#936602 (10blackops0057) HI I'd like to work on this bug. How do i begin fixing it? I have the source code ready [18:11:50] (03CR) 10Manybubbles: "> It could be called 'nowait', doesn't matter." [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/178903 (owner: 10Manybubbles) [18:14:51] (03CR) 10Bartosz Dziewoński: Eventify TemplateDataGenerator and use oojs-ui (032 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo) [18:17:48] (03PS1) 10Umherirrender: Add js config var 'wgFileExtensions' when loading module [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/181107 [18:17:50] 3Mobile-Web: Title covers the pencil icon - https://phabricator.wikimedia.org/T78707#936615 (10bmansurov) This happens in mobile view alpha. Any URL. Happens in latest Chrome and not in Firefox on a Mac. Possibly in other browsers too. Also happens when the screen size matches tablet size. Yes, MobileFrontend. [18:18:34] (03CR) 10Umherirrender: "The extensions/MultiUpload/resources/upload.js.patched are patches for the core upload.js, so no problem." [core] - 10https://gerrit.wikimedia.org/r/181090 (owner: 10Umherirrender) [18:18:59] (03CR) 10Krinkle: [C: 032] "Thanks!" [core] - 10https://gerrit.wikimedia.org/r/181009 (owner: 10Legoktm) [18:19:35] (03CR) 10Bartosz Dziewoński: Eventify TemplateDataGenerator and use oojs-ui (032 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo) [18:19:37] (03PS8) 10Krinkle: maintenance: Don't copy the Apex styles when importing OOjs UI [core] - 10https://gerrit.wikimedia.org/r/177901 (owner: 10Jforrester) [18:21:07] 3MediaWiki-Vagrant, MediaWiki-ResourceLoader: Local vagrant super slow due to minifier - https://phabricator.wikimedia.org/T78733#936625 (10Jdlrobson) I'm rarely changing the css. I'm seeing lots of rl-minify-css-cache-misses in the redis trace though. Is it possible my caching isn't setup correctly? Will take l... [18:23:13] (03CR) 10Gergő Tisza: [C: 031] Refactor [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/181006 (owner: 10Ori.livneh) [18:23:56] (03CR) 10Krinkle: [C: 032] "Works and results in a clean commit." [core] - 10https://gerrit.wikimedia.org/r/177901 (owner: 10Jforrester) [18:24:02] (03PS4) 10Krinkle: maintenance: Have update-oojs-ui.sh update composer.json too [core] - 10https://gerrit.wikimedia.org/r/180379 (owner: 10Jforrester) [18:25:07] (03Merged) 10jenkins-bot: Don't create Language objects during ResourceLoader tests [core] - 10https://gerrit.wikimedia.org/r/181009 (owner: 10Legoktm) [18:27:28] 3operations: Puppetize ircyall & set up instance appropriately - https://phabricator.wikimedia.org/T1357#936634 (10Gage) [18:28:59] 3Wikimedia-General-or-Unknown, Monitoring, operations: Easy way to define alerts for ganglia data - https://phabricator.wikimedia.org/T59882#936635 (10Gage) [18:29:32] (03PS2) 10Cscott: Terminate free external link on   (and numeric versions of <>) [core] - 10https://gerrit.wikimedia.org/r/180982 [18:29:41] (03Merged) 10jenkins-bot: maintenance: Don't copy the Apex styles when importing OOjs UI [core] - 10https://gerrit.wikimedia.org/r/177901 (owner: 10Jforrester) [18:30:09] (03PS1) 10Manybubbles: Fix rubocop errors [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/181109 [18:30:55] 3Wikimedia-Logstash: Monitor size of "logstash" redis list - https://phabricator.wikimedia.org/T85013#936636 (10bd808) 3NEW [18:31:55] 3Wikimedia-Logstash: Monitor size of "logstash" redis list - https://phabricator.wikimedia.org/T85013#936636 (10bd808) [18:33:04] 3MediaWiki-Page-editing: Allow creation of revisionless page entries - https://phabricator.wikimedia.org/T43473#936646 (10Trijnstel) >>! In T43473#825038, @Aklapper wrote: >>>! In T43473#823769, @Nemo_bis wrote: >> James, please manually notify Platonides of your priority change (as he's not in phabricator yet).... [18:35:11] 3WMF-Design, Mobile-Web: Polish : in mobile sidebar, last item is missing bottom line - https://phabricator.wikimedia.org/T1160#936647 (10bmansurov) Yes, it was Kaity. We didn't talk about this specifically, but it was part of our conversation when we worked on 50 shades of grey. [18:36:34] 3MediaWiki-Page-editing: Allow creation of revisionless page entries - https://phabricator.wikimedia.org/T43473#936648 (10Jdforrester-WMF) >>! In T43473#936646, @Trijnstel wrote: >>>! In T43473#825038, @Aklapper wrote: >> Mail has been more than once to users, asking them to create an account in Phabricator. >>... [18:36:44] 3MediaWiki-Logging: log_params isn't always serialized - https://phabricator.wikimedia.org/T72999#764371 (10Krinkle) [18:37:21] ^d, would you mind telling me where our github replication config is? [18:37:26] 3MediaWiki-extensions-CheckUser: Outdated checkuser-toollinks (spam, pay services, ad domains) - https://phabricator.wikimedia.org/T40195#936654 (10Trijnstel) >>! In T40195#833723, @MarcoAurelio wrote: > This should be easy to fix IMHO, but I think CUs should discuss which links would like to replace the outdate... [18:37:43] <^d> Krenair: puppet. gerrit.pp role [18:37:53] (03Draft2) 10Jackmcbarn: Allow running code during unstrip [core] - 10https://gerrit.wikimedia.org/r/181046 [18:39:34] 3WMF-Design, Mobile-Web: Polish : in mobile sidebar, last item is missing bottom line - https://phabricator.wikimedia.org/T1160#936655 (10KHammerstein) Oh yes I see. I wanted to remove the double dark gray + medium gray lines to leave just a light gray line between each item. I guess that there was only a dark g... [18:39:46] T13|mobile: sorry for delay. Are you trying to modify the message of the notification? [18:40:17] Yes, I want to append information as it becomes available. [18:40:44] (03CR) 10Cscott: "hm, http://php.net/manual/en/regexp.reference.onlyonce.php seems to indicate that `(?>` should work to avoid that problem, but in my testi" [core] - 10https://gerrit.wikimedia.org/r/133651 (owner: 10Cscott) [18:41:25] (03CR) 10Anomie: "> What is the reason for moving $post outside the ? It was introduced in r109086" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/159326 (https://bugzilla.wikimedia.org/16530) (owner: 10Anomie) [18:41:45] (03PS1) 10Jackmcbarn: Do all of Cite's real work during unstrip [extensions/Cite] - 10https://gerrit.wikimedia.org/r/181112 [18:41:59] T13|mobile: I'm thinking use the tag as it will have a classname of 'mw-notification-tag-' + tag [18:42:00] {title: 'foo', tag: 'bar', autohide: false} doesn't seem to work to set multiple parameters either. [18:42:02] 3WMF-Design, Mobile-Web: Polish : in mobile sidebar, last item is missing bottom line - https://phabricator.wikimedia.org/T1160#936657 (10KHammerstein) We should add a light gray line after the bottom item - log in/profile. (But soon we will make this menu much better!) [18:42:15] 3WMF-Design, Mobile-Web: Polish : in mobile sidebar, last item is missing bottom line - https://phabricator.wikimedia.org/T1160#936658 (10Jaredzimmerman-WMF) OK it feels a bit weird, @KHammerstein can you take a closer look and add an asset to this task with the way you'd like to see this menu (not a redesign fo... [18:42:34] 3Mobile-Web: Polish : in mobile sidebar, last item is missing bottom line - https://phabricator.wikimedia.org/T1160#936660 (10Jaredzimmerman-WMF) a:3KHammerstein [18:42:58] 3Mobile-Web: In mobile sidebar, last item border styling is inconsistent - https://phabricator.wikimedia.org/T1160#936664 (10Jaredzimmerman-WMF) [18:42:59] T13|mobile: you're doing new mw.notification( msg, options ) ? [18:43:07] Yes [18:43:13] ^d, thanks! [18:43:22] 3MediaWiki-extensions-Flow: Flow: Hidden topic summary - https://phabricator.wikimedia.org/T72070#936665 (10Spage) 5Open>3declined a:3Spage It's working as designed, now once you reload the hidden comment is gone from the page entirely. [18:43:59] (03PS6) 10Krinkle: ChangeTags: Hide tags whose description messages are disabled [core] - 10https://gerrit.wikimedia.org/r/172098 (owner: 10Ori.livneh) [18:44:02] T13|mobile: 'autoHide' ? [18:44:05] <^d> Krenair: yw [18:44:05] (03Abandoned) 10Jackmcbarn: Use transparent tags [extensions/Cite] - 10https://gerrit.wikimedia.org/r/137824 (owner: 10Jackmcbarn) [18:45:03] mw.notify('hello world', {title: 'foo', autohide: false, tag: 'bar'}); [18:45:14] T13|mobile: make sure you use "autoHide" [18:45:28] To be generally exact. [18:45:32] Ohh.. [18:45:39] (03CR) 10Krinkle: "Rebased to resolve merge conflict. Minor change:" [core] - 10https://gerrit.wikimedia.org/r/172098 (owner: 10Ori.livneh) [18:45:43] 3Collaboration-Team, MediaWiki-extensions-Flow: Editing Flow board header doesn't set keyboard focus and textarea is compressed - https://phabricator.wikimedia.org/T84963#936669 (10Spage) p:5Triage>3Normal [18:45:52] 3MediaWiki-Page-editing: Allow creation of revisionless page entries - https://phabricator.wikimedia.org/T43473#936670 (10Trijnstel) >>! In T43473#936648, @Jdforrester-WMF wrote: >>>! In T43473#936646, @Trijnstel wrote: >>>>! In T43473#825038, @Aklapper wrote: >>> Mail has been more than once to users, asking th... [18:45:59] ori: +1 https://gerrit.wikimedia.org/r/172098 to merge? [18:46:07] (03PS3) 10Anomie: Format multiple autocomments in edit summaries [core] - 10https://gerrit.wikimedia.org/r/159326 [18:46:11] (03CR) 10jenkins-bot: [V: 04-1] Do all of Cite's real work during unstrip [extensions/Cite] - 10https://gerrit.wikimedia.org/r/181112 (owner: 10Jackmcbarn) [18:46:45] (03CR) 10Jackmcbarn: "V-1 is due to missing core change. All tests pass when it's present." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/181112 (owner: 10Jackmcbarn) [18:47:10] Should I be able to: mw.notify(foo + 'new line', {tag: 'foo' ...}); ? [18:48:05] https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.notification-method-notify [18:48:06] https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.notification-property-defaults [18:48:12] T13|mobile: See also those :) [18:49:31] 3Collaboration-Team, MediaWiki-extensions-Flow: Co-op: If bot creates a topic or board header on an empty page, turn it into a Flow board. - https://phabricator.wikimedia.org/T76793#936674 (10Spage) p:5Triage>3High Should be working, need confirmation when Co-op team gets the bot right. [18:50:27] (03PS1) 10Krinkle: mediawiki.notification: Use link syntax for URL in documentation [core] - 10https://gerrit.wikimedia.org/r/181113 [18:51:58] Krinkle: bookmarked. [18:52:59] I'm guessing the best way for me to get the end result I want is to send in a table with an id and then modify that. :) [18:56:29] (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.notification: Use link syntax for URL in documentation [core] - 10https://gerrit.wikimedia.org/r/181113 (owner: 10Krinkle) [18:57:00] Position event not emitted after slug close - https://phabricator.wikimedia.org/T85014#936686 (10Esanders) 3NEW a:3dchan [18:57:01] T13|mobile: There's no need to do that. [18:57:35] T13|mobile: You should almost never select elements in javascript with a css selector or search. Since you created the element, or table or whatever, you own it, you have a reference to it. [18:57:45] There's no need to lose the reference and then try and get it back again [18:58:01] T13|mobile: Are you passing this table as html or as an element or jQuery object? [18:58:11] (03CR) 10Cscott: "Ah!" [core] - 10https://gerrit.wikimedia.org/r/133651 (owner: 10Cscott) [18:58:15] If as html, parse it yourself using $() and pass that to mw.notify instead. [18:58:31] If not as html, then you're good already and just keep that parameter around and modify it whenever you like. [18:59:05] I was planning on doing it with html. [19:00:10] And then just changing the values with $('#cell-foo').text('new value'); is there an easier way? [19:01:49] Krinkle: ^ [19:02:02] (03CR) 10Cscott: "As it turns out, only one (?> is needed:" [core] - 10https://gerrit.wikimedia.org/r/133651 (owner: 10Cscott) [19:02:05] (03Merged) 10jenkins-bot: mediawiki.notification: Use link syntax for URL in documentation [core] - 10https://gerrit.wikimedia.org/r/181113 (owner: 10Krinkle) [19:02:49] T13|mobile: var html = ''; $table = $(html); mw.notify( .. $table .. ); $cell.text( 'new value' ); [19:03:05] T13|mobile: Since you have the html right there in your hands, there's no need to re-gain access, you already have it. [19:03:27] mw.notify is simply given a reference to your object to display it somewhere, it doesn't hijack it or copy it. [19:04:48] Convert Hadoop-Logstash logging to use Redis to address failures - https://phabricator.wikimedia.org/T85015#936707 (10Gage) 3NEW [19:05:38] 3MediaWiki-extensions-Echo: Show "You have new messages on your user or user_talk page" -- i.e. both pages are notified - https://phabricator.wikimedia.org/T3876#936713 (10Mattflaschen) p:5Normal>3Volunteer? >>! In T3876#935691, @Qgil wrote: > Hasn't this old task been fixed with the orange bar, a long time... [19:06:08] 3MediaWiki-extensions-Echo: Show "You have new messages on your user or user_talk page" -- i.e. both pages are notified - https://phabricator.wikimedia.org/T3876#936716 (10Mattflaschen) [19:06:56] (03PS8) 10Manybubbles: Adds support for taking multiple locks [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/178903 [19:07:44] (03CR) 10Manybubbles: "PS8 enforces keys with -nowait suffix must have a 0 (immediate) timeout." [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/178903 (owner: 10Manybubbles) [19:08:49] (03CR) 10Aaron Schulz: "I was thinking of enforcing in the PoolCounter client classes in PHP. It makes sense to let the daemon be looser." [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/178903 (owner: 10Manybubbles) [19:09:59] 3MediaWiki-extensions-Echo: Show "You have new messages on your user or user_talk page" -- i.e. both pages are notified - https://phabricator.wikimedia.org/T3876#936725 (10Mattflaschen) This is an enhancement request, so we would also have to discuss if we want to do this. [19:12:10] 3MediaWiki-Page-editing: Edits that were created using StashEdit API show wrong timestamp - https://phabricator.wikimedia.org/T84843#936732 (10Umherirrender) edit stashing must/should ignore wikitext with time-depending things getting substituted, like all the time variables (LOCAL*/CURRENT*), parser function #t... [19:12:25] Krinkle: I'm back. Did I miss a comment? [19:13:04] 3ops-core: deploy haedus and capella with os for orientdb testing - https://phabricator.wikimedia.org/T84902#936735 (10RobH) capella online post OS install, puppet/salt keys NOT signed. [19:13:06] T13|mobile: Nope, https://gist.githubusercontent.com/Krinkle/c0a32a6862b3fad7a5d8/raw [19:13:07] (03CR) 10Jackmcbarn: [C: 04-1] "Per Anomie" [core] - 10https://gerrit.wikimedia.org/r/177969 (owner: 10Nikerabbit) [19:14:18] 3MediaWiki-extensions-Flow: Flow: the external link CAPTCHA for a reply appears in wrong place, doesn't work - https://phabricator.wikimedia.org/T71928#936737 (10Quiddity) 5Open>3Resolved a:3Quiddity This seems to have been fixed at some point, but without an attached patch (/me grumbles). I just tested at... [19:14:32] 3MediaWiki-extensions-Flow: Flow: the external link CAPTCHA for a reply appears in wrong place, doesn't work - https://phabricator.wikimedia.org/T71928#936740 (10Quiddity) a:5Quiddity>3None [19:14:42] Oh, then will my plan work using html and $('#id').text('foo'); ? [19:14:58] Or is there a better way? [19:15:25] T13|mobile: I just told you [19:15:34] No need to leave an ID behind or select it again [19:15:43] you already have the html before you give it to mw.notify [19:15:47] 3MediaWiki-extensions-CheckUser: Outdated checkuser-toollinks (spam, pay services, ad domains) - https://phabricator.wikimedia.org/T40195#936746 (10Ajraddatz) I think links to global contributions for the IP and global block would be very useful for stewards. The former would be good for anyone to check other ab... [19:15:49] T13|mobile: Can you show the code you have? [19:18:22] 3MediaWiki-extensions-Flow: Flow: the external link CAPTCHA for a reply appears in wrong place, doesn't work - https://phabricator.wikimedia.org/T71928#936748 (10Mattflaschen) p:5Triage>3High >>! In T71928#936602, @blackops0057 wrote: > HI I'd like to work on this bug. I'm a beginner. How do i begin fixing i... [19:18:42] It's just a text comment at the moment [[En:w:User:Technical 13/SandBox/OneClickArchiver.js]] I want to popup a table that shows what it got for counter, archive page, header level, max archive size, current archive size, etc... [19:18:45] @link [19:18:45] https://www.mediawiki.org/wiki/En:w:User:Technical_13/SandBox/OneClickArchiver.js [19:19:04] It's on enwp. :/ [19:19:53] 3MediaWiki-extensions-ConfirmAccount: Error in confirmaccount.sql - https://phabricator.wikimedia.org/T84999#936751 (10Aklapper) [19:20:30] That's my test usage. Later, I might put the status div in there. [19:21:49] 3MediaWiki-extensions-ConfirmAccount: Error in confirmaccount.sql - https://phabricator.wikimedia.org/T84999#936327 (10Aklapper) Please provide a summary of the actual error in a task summary, instead of just writing "error". Thanks. > upload confirmaccount.sql manualy There is no file with such a name. It loo... [19:22:15] 3MediaWiki-extensions-ConfirmAccount: confirmaccount.sql error: column 'acr_email' used in key specification without a key length - https://phabricator.wikimedia.org/T84999#936756 (10Aklapper) p:5High>3Normal [19:23:54] fhocutt, I'd like to set you up with a test bot on testwiki or test2wiki (whichever you prefer) for the Co-Op work. [19:23:54] (03CR) 10Manybubbles: ">I was thinking of enforcing in the PoolCounter client classes in PHP. It makes sense to let the daemon be looser." [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/178903 (owner: 10Manybubbles) [19:24:19] fhocutt, if you'd like to join us in #wikimedia-collaboration (where the Collaboration team working on Flow hangs out) that would be good. [19:25:56] (03PS6) 10Jackmcbarn: Add more comments and type hints [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/165989 (owner: 10Thiemo Mättig (WMDE)) [19:26:07] (03CR) 10Jackmcbarn: [C: 032] Add more comments and type hints [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/165989 (owner: 10Thiemo Mättig (WMDE)) [19:26:31] 3MediaWiki-extensions-ApiSandbox: Examples surrounded by visible p tags - https://phabricator.wikimedia.org/T84995#936760 (10Aklapper) p:5Triage>3Low [19:27:00] (03PS1) 10MarkTraceur: Add unit tests for Thanks step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181116 [19:27:16] (03CR) 10Jackmcbarn: [C: 04-1] "Needs rebase" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/168282 (owner: 10Ricordisamoa) [19:27:53] (03CR) 10jenkins-bot: [V: 04-1] Add unit tests for Thanks step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181116 (owner: 10MarkTraceur) [19:28:17] (03Merged) 10jenkins-bot: Add more comments and type hints [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/165989 (owner: 10Thiemo Mättig (WMDE)) [19:33:03] 3Engineering-Community: Update MWDS Attendees Page - It is out of date - https://phabricator.wikimedia.org/T78614#936769 (10Rfarrand) This page is now up to date! https://www.mediawiki.org/wiki/MediaWiki_Developer_Summit_2015/Attendees [19:33:32] 3Engineering-Community: Update MWDS Attendees Page - It is out of date - https://phabricator.wikimedia.org/T78614#936770 (10Rfarrand) 5Open>3Resolved [19:36:21] (03CR) 10Nuria: [C: 032] Turn validation fixture into valid Json [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/181088 (owner: 10QChris) [19:38:35] (03CR) 10Jackmcbarn: "I note that our links tables are insufficient for what this does (i.e., we have no way to make creating a new subpage under a title result" [core] - 10https://gerrit.wikimedia.org/r/66003 (https://bugzilla.wikimedia.org/48745) (owner: 10Parent5446) [19:39:48] (03PS2) 10MarkTraceur: Add unit tests for Thanks step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181116 [19:41:18] 3MediaWiki-extensions-ConfirmAccount: confirmaccount.sql error: column 'acr_email' used in key specification without a key length - https://phabricator.wikimedia.org/T84999#936778 (10Paladox) Ok. [19:41:37] 3Project-Creators: convert the RTL blocking bug into a tag - https://phabricator.wikimedia.org/T78670#850675 (10Aklapper) I like the idea but converting looks rather cumbersome, see my general comment in T75703#936775. Any naming proposal? "RTL-bidirectional" or such? Tag project description text could link to... [19:46:01] (03CR) 10Jackmcbarn: [C: 04-1] Normalize newlines before calling preprocessor (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/180022 (owner: 10Anomie) [19:46:46] 3ops-core: deploy haedus and capella with os for orientdb testing - https://phabricator.wikimedia.org/T84902#936783 (10RobH) a:5RobH>3Joe haedus online post OS install, puppet/salt keys NOT signed. As OS is online, but I don't see a related ticket for the testing of this (I am likely missing it), I'm just g... [19:47:15] (03PS3) 10Aaron Schulz: Cleanup DatabaseBase::query implicit transaction code [core] - 10https://gerrit.wikimedia.org/r/180702 [19:49:00] (03PS1) 10Aaron Schulz: Trigger onResponses on non-replacement request too in VirtualRESTServiceClient [core] - 10https://gerrit.wikimedia.org/r/181119 [19:49:36] 3MediaWiki-Core-Team: Fix onResponses in VirtualRESTServiceClient - https://phabricator.wikimedia.org/T85016#936796 (10aaron) 3NEW a:3aaron [19:50:09] 3Wikimedia-Wikimania-Scholarships: Create new report: "By groups of language community" - https://phabricator.wikimedia.org/T85017#936806 (10Shouston_WMF) 3NEW [19:50:45] 3Wikimedia-Wikimania-Scholarships: Create new report: "By groups of language community" - https://phabricator.wikimedia.org/T85017#936806 (10Shouston_WMF) Photo of report mock-up. {F22621} [19:53:57] 3MediaWiki-Vagrant, MediaWiki-ResourceLoader: Local vagrant super slow due to minifier - https://phabricator.wikimedia.org/T78733#936816 (10Jdlrobson) Okay so I debugged this and the source of slowdown seems to be $result = $compiler->compileFile( $fileName ); in compileLessFile Did something change to do with... [19:54:34] (03PS6) 10Cscott: Don't allow embedded newlines in magic links, but do allow   [core] - 10https://gerrit.wikimedia.org/r/133651 [19:56:42] 3Wikimedia-Wikimania-Scholarships: Remove "login.wikimedia.org" from Wiki list - https://phabricator.wikimedia.org/T85018#936817 (10Shouston_WMF) 3NEW [19:57:27] 3MediaWiki-Vagrant, MediaWiki-ResourceLoader: Local vagrant super slow due to minifier - https://phabricator.wikimedia.org/T78733#936824 (10Krinkle) The cache misses may be due to T84960. [19:58:34] 3MediaWiki-Vagrant, MediaWiki-ResourceLoader: Local vagrant super slow due to minifier - https://phabricator.wikimedia.org/T78733#936828 (10matmarex) Depending on how recently you mean. The result of some `compileFile` calls used to be cached separately some time ago, now it isn't (only the final CSS is). Perha... [19:58:56] (03CR) 10Cscott: "Turns out that I was misled a bit by the use of preg_match in Tim's example, which contains an extra implicit search iteration. The posse" [core] - 10https://gerrit.wikimedia.org/r/133651 (owner: 10Cscott) [19:59:12] (03CR) 10Jackmcbarn: Remove unneeded fields from query in Special:ListUsers (031 comment) [core] - 10https://gerrit.wikimedia.org/r/171848 (owner: 10Umherirrender) [19:59:39] (03CR) 10Cscott: "(and you can delete one of the + characters in the definition of $spaces and rerun the test to see the seg fault which tim originally foun" [core] - 10https://gerrit.wikimedia.org/r/133651 (owner: 10Cscott) [20:03:47] 3operations: Test task to see email behavior - https://phabricator.wikimedia.org/T85019#936833 (10yuvipanda) 3NEW [20:04:09] 3operations: Test task to see email behavior - https://phabricator.wikimedia.org/T85019#936833 (10yuvipanda) if I comment, will I get an email to myself? [20:05:09] 3operations: Test task to see email behavior - https://phabricator.wikimedia.org/T85019#936841 (10valhallasw) o hai [20:06:23] 3operations: Test task to see email behavior - https://phabricator.wikimedia.org/T85019#936844 (10yuvipanda) Testing cc behavior [20:07:53] 3operations: Test task to see email behavior - https://phabricator.wikimedia.org/T85019#936846 (10yuvipanda) 5Open>3Invalid [20:10:11] (03PS1) 10Alex Monk: Fix VirtualRESTServiceClient::run [core] - 10https://gerrit.wikimedia.org/r/181121 [20:11:20] (03CR) 10Alex Monk: "Thanks Aaron. Upon further review I believe I1d57ff24 fixes the issue I was running into." [core] - 10https://gerrit.wikimedia.org/r/181119 (owner: 10Aaron Schulz) [20:11:55] (03CR) 10Aaron Schulz: [C: 032] Fix VirtualRESTServiceClient::run [core] - 10https://gerrit.wikimedia.org/r/181121 (owner: 10Alex Monk) [20:12:28] (03CR) 10Alex Monk: "(Although this may well still be valid anyway.)" [core] - 10https://gerrit.wikimedia.org/r/181119 (owner: 10Aaron Schulz) [20:12:38] I'm going to trigger about 100 wikibugs notifications soon, in case anybody wants to silent it for a while. personally I don't have a problem with that. [20:12:53] 3Mobile-Web: Title covers the pencil icon - https://phabricator.wikimedia.org/T78707#936847 (10rmoen) a:3rmoen [20:13:55] (03CR) 10Aaron Schulz: "The code you had kept the original request keys, so it seems like this would be needed for that cases." [core] - 10https://gerrit.wikimedia.org/r/181119 (owner: 10Aaron Schulz) [20:17:53] 3MediaWiki-extensions-AbuseFilter: afl_log_id index on abuse_filter_log table should be unique - https://phabricator.wikimedia.org/T45507#936849 (10Aklapper) [20:17:55] 3MediaWiki-extensions-UploadWizard, Multimedia: IE7/test2wiki: "Syntax error" upon clicking UW link - https://phabricator.wikimedia.org/T44922#936851 (10Aklapper) [20:17:56] 3MediaWiki-extensions-LiquidThreads: LQT 2.0 - Cannot read property 'token' of undefined - https://phabricator.wikimedia.org/T57694#936850 (10Aklapper) [20:17:58] [Fatal error] Attempt to get the latitude of an invalid location - https://phabricator.wikimedia.org/T40632#936855 (10Aklapper) [20:17:59] 3MediaWiki-extensions-WikibaseRepository: Claim guid case difference in ChangeOpClaim means duplicate claims are created when editing - https://phabricator.wikimedia.org/T57514#936854 (10Aklapper) [20:18:00] 3MediaWiki-extensions-ParserFunctions: {{#switch}} should not cast values to integers or floats - https://phabricator.wikimedia.org/T48095#936853 (10Aklapper) [20:18:01] 3MediaWiki-extensions-CentralAuth: CentralAuth Session Fixation - https://phabricator.wikimedia.org/T42962#936857 (10Aklapper) [20:18:02] 3MediaWiki-extensions-LiquidThreads: "You cannot post a blank message" error on every summary edit and more - https://phabricator.wikimedia.org/T41773#936856 (10Aklapper) [20:18:05] 3MediaWiki-extensions-Other: Deploy and review SearchExtraNs extension - https://phabricator.wikimedia.org/T45848#936859 (10Aklapper) [20:18:06] 3MediaWiki-extensions-ApiSandbox: [regression?] Results show escaped HTML on Wikidata - https://phabricator.wikimedia.org/T47986#936860 (10Aklapper) [20:18:08] 3MediaWiki-extensions-LiquidThreads: LQT: Call to a member function getPrefixedText() on a non-object - https://phabricator.wikimedia.org/T43185#936862 (10Aklapper) [20:18:10] 3MediaWiki-extensions-MaintenanceShell: Server response on POST request empty - https://phabricator.wikimedia.org/T47338#936864 (10Aklapper) [20:18:11] 3MediaWiki-extensions-LiquidThreads: All LiquidTreads actions done twice - https://phabricator.wikimedia.org/T45693#936865 (10Aklapper) [20:18:13] 3MediaWiki-extensions-CentralAuth: Special:GlobalUsers subpage parameter mistaken for &username= - https://phabricator.wikimedia.org/T36016#936867 (10Aklapper) [20:18:14] 3MediaWiki-extensions-MapSources: special:mapsources on Wikivoyage fails with "Map sources mechanism not working yet" - https://phabricator.wikimedia.org/T46047#936866 (10Aklapper) [20:18:15] 3MediaWiki-extensions-SiteMatrix: Special:SiteMatrix gives incorrect interwiki link prefix for Wikivoyage - https://phabricator.wikimedia.org/T44147#936869 (10Aklapper) [20:18:16] 3MediaWiki-extensions-CentralAuth: SpecialBlockList throwing exception on 1.21wmf5 - https://phabricator.wikimedia.org/T44662#936868 (10Aklapper) [20:18:17] 3MediaWiki-extensions-Echo: "My notifications" opens overlapping unreadable text - https://phabricator.wikimedia.org/T43814#936870 (10Aklapper) [20:18:23] (03CR) 10Mattflaschen: "I understand no matter when this got merged, it would break some stuff (hopefully, limited to user scripts)." [core] - 10https://gerrit.wikimedia.org/r/137168 (owner: 10Jforrester) [20:19:34] 3MediaWiki-extensions-CheckUser: Outdated checkuser-toollinks (spam, pay services, ad domains) - https://phabricator.wikimedia.org/T40195#936871 (10Aklapper) [20:19:37] 3WikiEditor: Advanced edit toolbar doesn't allow changing the width of the editor textbox on Wikisource projects. - https://phabricator.wikimedia.org/T38230#936872 (10Aklapper) [20:19:39] 3WikiEditor: [Regression] ext.wikiEditor.toolbar.hideSig.js stopped working - https://phabricator.wikimedia.org/T42972#936873 (10Aklapper) [20:19:40] 3MediaWiki-extensions-UploadWizard, Multimedia: Uploading stuck about 1-2 minutes on "Finished!" - https://phabricator.wikimedia.org/T36997#936874 (10Aklapper) [20:19:41] 3MediaWiki-extensions-ParserFunctions: Add support for non-Arabic number systems - https://phabricator.wikimedia.org/T36193#936876 (10Aklapper) [20:19:43] 3Multimedia, MediaWiki-extensions-TimedMediaHandler: WebM playback on Commons halts after about 100 seconds - https://phabricator.wikimedia.org/T45447#936875 (10Aklapper) [20:19:44] 3MediaWiki-extensions-Babel: Babel autocreate edit summary in user language instead of content language - https://phabricator.wikimedia.org/T46623#936877 (10Aklapper) [20:19:45] 3MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension): The version of ConfirmEdit bundled with 1.20.0 is not compatible with 1.20.0 - https://phabricator.wikimedia.org/T44391#936879 (10Aklapper) [20:19:46] 3MediaWiki-extensions-CentralAuth: Prevent creation of new (unattached?) SUL accounts with already unified names - https://phabricator.wikimedia.org/T31234#936878 (10Aklapper) [20:19:49] 3MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension): ConfirmEdit fatal error when using MathCaptcha and current Math extension - https://phabricator.wikimedia.org/T48132#936882 (10Aklapper) [20:19:50] 3MediaWiki-extensions-RSS: RSS feed items (HTML) are not rendered as HTML but htmlescaped - https://phabricator.wikimedia.org/T36763#936883 (10Aklapper) [20:19:51] 3MediaWiki-extensions-DumpHTML: [Regression] HTML dump is missing all images due to new FileBackend code - https://phabricator.wikimedia.org/T35878#936880 (10Aklapper) [20:19:53] 3MediaWiki-extensions-TitleKey: Merge TitleKey into core - https://phabricator.wikimedia.org/T38203#936881 (10Aklapper) [20:19:54] 3MediaWiki-extensions-UniversalLanguageSelector: [BC] Preferences page: Fatal exception of type MWException: Undefined index: api in includes/HTMLForm.php line 288 - https://phabricator.wikimedia.org/T47204#936884 (10Aklapper) [20:19:55] 3MediaWiki-extensions-UserMerge: Unable to merge/delete blocked user - https://phabricator.wikimedia.org/T35414#936886 (10Aklapper) [20:19:56] 3MediaWiki-extensions-CustomUserSignup: Url query manipulation should not assume presence of query string (causes broken url/404 error) - https://phabricator.wikimedia.org/T39918#936885 (10Aklapper) [20:19:58] 3MediaWiki-extensions-ProofreadPage: Some pages are not transcluded while using tag - https://phabricator.wikimedia.org/T42444#936890 (10Aklapper) [20:19:59] 3MediaWiki-extensions-UserMerge: Fatal error if to be merged users are blocked - https://phabricator.wikimedia.org/T37239#936887 (10Aklapper) [20:20:00] 3WikiEditor: EditWarning should use $.fn.bind instead of window.onbeforeunload directly - https://phabricator.wikimedia.org/T35566#936888 (10Aklapper) [20:20:01] 3MediaWiki-extensions-ProofreadPage: Image width no longer limited to a sane value in edit mode - https://phabricator.wikimedia.org/T41015#936889 (10Aklapper) [20:20:01] (03CR) 10Mattflaschen: "We also should have been more on top of this when the announcements were going out, but I wasn't on the team maintaining PageTriage back w" [core] - 10https://gerrit.wikimedia.org/r/137168 (owner: 10Jforrester) [20:20:03] 3MediaWiki-extensions-Collection: Export and PDF generator returns "file not found" error on completion - https://phabricator.wikimedia.org/T38950#936893 (10Aklapper) [20:20:04] 3MediaWiki-extensions-TitleKey: Suggestion to set "$wgEnableMWSuggest = true;" inside the extension - https://phabricator.wikimedia.org/T38202#936892 (10Aklapper) [20:20:05] 3MediaWiki-extensions-Drafts: Drafts needs ResourceLoader-ifying - https://phabricator.wikimedia.org/T39999#936891 (10Aklapper) [20:20:06] 3WikiEditor: Keyboard accessible buttons - https://phabricator.wikimedia.org/T36847#936897 (10Aklapper) [20:20:07] 3WikiEditor: Insert file-embed button in WikiEditor should also help with size, thumb, alignment and caption - https://phabricator.wikimedia.org/T26172#936896 (10Aklapper) [20:20:08] 3WikiEditor: WikiEditor/modules/images/toolbar/example-image.png is missing - https://phabricator.wikimedia.org/T41029#936894 (10Aklapper) [20:20:10] 3WikiEditor: jquery.wikiEditor.dialogs: 'missing' and 'invalid' properties should check against undefined instead of truthy - https://phabricator.wikimedia.org/T41091#936895 (10Aklapper) [20:20:12] Edit tools and Narayam not working in gujarati wikis (IE7) - https://phabricator.wikimedia.org/T38275#936900 (10Aklapper) [20:20:12] 3MediaWiki-extensions-ExtensionDistributor: Add support for Git in ExtensionDistributor - https://phabricator.wikimedia.org/T37574#936898 (10Aklapper) [20:20:13] 3MediaWiki-extensions-CentralNotice: Language::factory(NULL) exception on SpecialBannerLoader - https://phabricator.wikimedia.org/T39170#936899 (10Aklapper) [20:20:14] 3WikiEditor: Resizing WikiEditor dialogs works wrong when using an RTL language - https://phabricator.wikimedia.org/T31002#936902 (10Aklapper) [20:20:16] Trailing comma in object literal in ext.webfonts.fontlist.js - https://phabricator.wikimedia.org/T39152#936901 (10Aklapper) [20:20:17] 3MediaWiki-extensions-ProofreadPage: Break of the fromsection and tosection parameters of the "pages" tag in 1.20-wmf1 release - https://phabricator.wikimedia.org/T38093#936905 (10Aklapper) [20:20:18] 3WikiEditor: Loading ext.wikieditor.toolbar module should not load it if user has preference "Enable enhanced editing toolbar" off - https://phabricator.wikimedia.org/T36594#936903 (10Aklapper) [20:20:20] 3WikiEditor: "Enable enhanced editing toolbar" remove both old and enhanced toolbars - https://phabricator.wikimedia.org/T36595#936908 (10Aklapper) [20:20:22] 3MediaWiki-extensions-ProofreadPage: The scan does not appear when editing pages after update to MW 1.19 on Opera - https://phabricator.wikimedia.org/T36732#936906 (10Aklapper) [20:20:22] 3MediaWiki-extensions-SyntaxHighlight-(GeSHi): 
 tags generated by extensions should not be collapsed into 
 (content) 
 by Tidy - https://phabricator.wikimedia.org/T37875#936907 (10Aklapper)
[20:20:23] 	 3MediaWiki-extensions-CodeReview: Whitespace changes should be identifiable in CR diffs - https://phabricator.wikimedia.org/T29375#936910 (10Aklapper)
[20:20:24] 	 3MediaWiki-extensions-SyntaxHighlight-(GeSHi): Geshi outputs invalid html which further gets borked by tidy causing ugly boxes. - https://phabricator.wikimedia.org/T37896#936909 (10Aklapper)
[20:20:26] 	 3MediaWiki-extensions-WikiLove: [Regression] WikiLove's preview button only works on second click - https://phabricator.wikimedia.org/T37057#936912 (10Aklapper)
[20:20:27] 	 3MediaWiki-extensions-ProofreadPage: Purging index page blanks bar graph in Special:IndexPages - https://phabricator.wikimedia.org/T36821#936911 (10Aklapper)
[20:20:28] 	 Add ability to customize Narayam on-wiki - https://phabricator.wikimedia.org/T36693#936913 (10Aklapper)
[20:20:30] 	 3MediaWiki-extensions-FlaggedRevs: Don't flag pages automatically when moved - https://phabricator.wikimedia.org/T36890#936914 (10Aklapper)
[20:20:31] 	 3MediaWiki-extensions-UploadWizard, Multimedia: Upload wizard: doesn't support descriptions in languages of non-Latin alphabet - https://phabricator.wikimedia.org/T34453#936915 (10Aklapper)
[20:20:33] 	 3MediaWiki-extensions-Nuke: [[Special:Nuke/USERNAME]] no longer works, chucks user back to main entry point - https://phabricator.wikimedia.org/T34652#936917 (10Aklapper)
[20:20:34] 	 3MediaWiki-extensions-UploadWizard, Multimedia: "Drop media file to donate here" sometimes silently fails - https://phabricator.wikimedia.org/T36601#936919 (10Aklapper)
[20:20:36] 	 3MediaWiki-extensions-LdapAuthentication: AutoAuthSetup providing empty userID - https://phabricator.wikimedia.org/T73703#936921 (10Aklapper)
[20:20:37] 	 3MediaWiki-extensions-Gadgets: Preload popular ResourceLoader modules (mediawiki.util) as stop-gap for scripts missing dependencies - https://phabricator.wikimedia.org/T35746#936920 (10Aklapper)
[20:20:38] 	 3MediaWiki-extensions-Collection: RuntimeError: command failed with returncode 256 - https://phabricator.wikimedia.org/T40187#936923 (10Aklapper)
[20:20:39] 	 3MediaWiki-extensions-SemanticDrilldown: Drilldown has issues with strings using plus signs and numbers - https://phabricator.wikimedia.org/T56455#936922 (10Aklapper)
[20:20:40] 	 Invisible properties on Special:WantedProperties—which surprisingly show up on top of Special:Properties - https://phabricator.wikimedia.org/T56488#936924 (10Aklapper)
[20:20:42] 	 3MediaWiki-extensions-SyntaxHighlight-(GeSHi): GeSHi-generated blocks should use 
 style for the container - https://phabricator.wikimedia.org/T21416#936926 (10Aklapper)
[20:20:43] 	 3MediaWiki-extensions-Nuke: Nuke extension w/PostgreSQL: column "recentchanges.rc_timestamp" should be in GROUP BY - https://phabricator.wikimedia.org/T25600#936927 (10Aklapper)
[20:20:44] 	 SMW messages aren't displaying any links - https://phabricator.wikimedia.org/T44560#936925 (10Aklapper)
[20:20:46] 	 3MediaWiki-extensions-CentralAuth: Oversighting an account globally does not remove it from public lists ! - https://phabricator.wikimedia.org/T36539#936930 (10Aklapper)
[20:20:47] 	 3MediaWiki-extensions-CentralAuth: [Regression] IRC action text should never contain HTML for title - https://phabricator.wikimedia.org/T36980#936929 (10Aklapper)
[20:20:48] 	 3MediaWiki-extensions-CentralAuth: Special:GlobalUsers pagination broken (incorrectly links to Special:ListUsers) - https://phabricator.wikimedia.org/T33638#936928 (10Aklapper)
[20:20:49] 	 Special:Ask shows a blank page (SMW 1.8 beta 2) - https://phabricator.wikimedia.org/T43080#936931 (10Aklapper)
[20:20:51] 	 3MediaWiki-extensions-CategoryTree: Crashes with 'loading...' message when click '+' (MW 1.18) - https://phabricator.wikimedia.org/T34961#936933 (10Aklapper)
[20:20:52] 	 3WikiEditor: [Regression] RTL with IE-7 (or IE 8/9 in "compatability mode") does not show any toolbar - https://phabricator.wikimedia.org/T36885#936932 (10Aklapper)
[20:20:53] 	 3MediaWiki-extensions-ParserFunctions: carriage return (CR) with #ifexpr: - https://phabricator.wikimedia.org/T37129#936934 (10Aklapper)
[20:20:54] 	 3MediaWiki-extensions-FlaggedRevs: "accept" button isn't greyed out if the rev is already accepted - https://phabricator.wikimedia.org/T36698#936937 (10Aklapper)
[20:20:55] 	 3MediaWiki-extensions-CentralAuth: JavaScript error in < IE8 on Special:CentralAuth - https://phabricator.wikimedia.org/T36823#936935 (10Aklapper)
[20:20:56] 	 3MediaWiki-extensions-ProofreadPage: Proofread extension JS loading fully broken on 1.19 - https://phabricator.wikimedia.org/T35873#936936 (10Aklapper)
[20:20:58] 	 3MediaWiki-extensions-CategoryTree: Trunk CategoryTree doesn't list pages of sub categories - https://phabricator.wikimedia.org/T35989#936938 (10Aklapper)
[20:20:59] 	 3WikiEditor: In some Help sections of WikiEditor, the ‘What you get’ column shows raw HTML instead of rendered text - https://phabricator.wikimedia.org/T36708#936940 (10Aklapper)
[20:21:00] 	 3MediaWiki-extensions-CentralNotice: Missing dependency to mw.user - https://phabricator.wikimedia.org/T35931#936939 (10Aklapper)
[20:21:01] 	 3MediaWiki-extensions-Gadgets: New gadget does not show up in Special:Gadgets and Special:Preferences - https://phabricator.wikimedia.org/T35829#936941 (10Aklapper)
[20:21:02] 	 3MediaWiki-extensions-Nuke: Special:Nuke allows deletions even when blocked - https://phabricator.wikimedia.org/T37214#936942 (10Aklapper)
[20:21:04] 	 3MediaWiki-extensions-DoubleWiki: DoubleWiki not working in 1.19 (see frwikisource) - https://phabricator.wikimedia.org/T36674#936944 (10Aklapper)
[20:21:05] 	 3MediaWiki-extensions-CentralAuth: Uncaught ReferenceError: showMethodHint is not defined - https://phabricator.wikimedia.org/T36915#936943 (10Aklapper)
[20:21:06] 	 3MediaWiki-extensions-CentralAuth: Special:MergeAccount&action=submit generates error - https://phabricator.wikimedia.org/T36478#936945 (10Aklapper)
[20:21:07] 	 Error: invalid magic word 'contributiontotal' - https://phabricator.wikimedia.org/T36424#936948 (10Aklapper)
[20:21:08] 	 3MediaWiki-extensions-FlaggedRevs: [Regression] Special:NewPages should show correct page status - https://phabricator.wikimedia.org/T36775#936947 (10Aklapper)
[20:21:10] 	 3MediaWiki-extensions-LiquidThreads: "More" menu is almost invisible on MW 1.19 in Chrome - https://phabricator.wikimedia.org/T36741#936946 (10Aklapper)
[20:21:11] 	 3MediaWiki-extensions-SyntaxHighlight-(GeSHi): [REGRESSION] SH Geshi's code boxes should look like pre's by default - https://phabricator.wikimedia.org/T37029#936952 (10Aklapper)
[20:21:12] 	 3MediaWiki-extensions-CentralAuth: Unable to login via SUL-account - https://phabricator.wikimedia.org/T19618#936950 (10Aklapper)
[20:21:13] 	 3MediaWiki-extensions-ProofreadPage: Side-by-side functionality broken in Chrome and possibly some Internet Explorer - https://phabricator.wikimedia.org/T36706#936949 (10Aklapper)
[20:21:14] 	 3MediaWiki-extensions-NewUserMessage: [Regression] Don't prepend 2 empty lines before the Welcome template - https://phabricator.wikimedia.org/T37058#936951 (10Aklapper)
[20:21:15] 	 3MediaWiki-extensions-CentralAuth: "Ignore spoofing checks" displayed twice - https://phabricator.wikimedia.org/T36842#936954 (10Aklapper)
[20:21:16] 	 o.O
[20:21:17] 	 3MediaWiki-extensions-ApiSandbox: UI cleanup for ApiSandbox - https://phabricator.wikimedia.org/T35801#936955 (10Aklapper)
[20:21:18] 	 3MediaWiki-extensions-CentralAuth: Port CentralAuth to use ResourceLoader (for real) - https://phabricator.wikimedia.org/T36916#936953 (10Aklapper)
[20:23:36] 	 3Wikimedia-Wikimania-Scholarships: Create new application question on engagement and roles within the movement - https://phabricator.wikimedia.org/T78615#936959 (10Shouston_WMF) Perfect! Thank you!
[20:24:41] 	 (03Merged) 10jenkins-bot: Fix VirtualRESTServiceClient::run [core] - 10https://gerrit.wikimedia.org/r/181121 (owner: 10Alex Monk)
[20:25:34] 	 3Project-Creators: Rename MediaWiki release tags - https://phabricator.wikimedia.org/T75916#936962 (10Aklapper) : We now have [[ https://phabricator.wikimedia.org/project/query/active/?after=1 | four active "Target Milestone" release projects ]] in Phabricator left, regarding the MW core (and to some exte...
[20:25:38] 	 3MediaWiki-extensions-ZeroBanner: "Don't ask me again" works on Android, but not on iOS 7 - https://phabricator.wikimedia.org/T62773#936965 (10jhobs)
[20:27:22] 	 3Project-Creators: Rename MediaWiki release tags - https://phabricator.wikimedia.org/T75916#936968 (10Aklapper) Left here: Drop the .x or .0 prefixes?
[20:29:44] 	 (03PS1) 10Cscott: Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/181124 
[20:30:53] 	 3Engineering-Community: Find new Tech Talks and get them scheduled for Dec, Jan & Feb. - https://phabricator.wikimedia.org/T1046#936973 (10Rfarrand) Followed up with all 4 groups
[20:33:07] 	 3Wikimedia-Wikimania-Scholarships: Update countries database to reflect Global North/South - https://phabricator.wikimedia.org/T84869#936975 (10Shouston_WMF) This attribute of "Global North/South" is to enable the creation of {T85017}, which is a report that will group applicants by using the "Global North/South...
[20:36:41] 	 3Project-Creators: Rename MediaWiki release tags - https://phabricator.wikimedia.org/T75916#936982 (10Krinkle) I'd drop the suffixes indeed. And also rename to mention "MW" or "MediaWiki" (with old name as additional hash-tag for back-compat and redirect). This to be less generic, and also because Phabricator do...
[20:38:19] 	 Blue hover highlights of focusable nodes inside a table are not updated immediately after a table cell is "focused", making it possible to do things to them - https://phabricator.wikimedia.org/T85020#936985 (10matmarex) 3NEW
[20:41:37] 	 MatmaRex: add a project for this task, because I have no idea what's that about ^
[20:43:19] 	 VE maybe?
[20:43:48] 	 3RESTBase, Parsoid, VisualEditor, MediaWiki-General-or-Unknown, VisualEditor-MediaWiki, Scrum-of-Scrums, MediaWiki-extensions-Flow: Use PHP Virtual REST Service to access Parsoid - https://phabricator.wikimedia.org/T1218#936998 (10Krenair) >>! In T1218#935534, @Krenair wrote: > I ran into issues with the way I w...
[20:43:52] 	 i did
[20:43:55] 	 strange, maybe it was a cache problem. wikibugs did't mention any project, and indeed there was none when I viewed the task
[20:43:56] 	 3Engineering-Community: Shuttles for MWDS - https://phabricator.wikimedia.org/T76499#936999 (10Rfarrand) Looking into public transportation options (Sarah will be riding the Mission Bay shuttle as a test on Monday) - also found a cheaper shuttle option. Making progress!
[20:43:56] 	 last comment was "changed Security from none to none"
[20:44:58] 	 3Engineering-Community: Finalize Logistics with Mission Bay Center - meeting specs & set-up - https://phabricator.wikimedia.org/T76501#937002 (10Rfarrand) Exact participant count given to MBC + room configuration & AV needs.  Catering already confirmed, added fruit to be available all day.
[20:45:00] 	 3Project-Creators: convert the RTL blocking bug into a tag - https://phabricator.wikimedia.org/T78670#937003 (10Qgil) >>! In T78670#936776, @Aklapper wrote: > I like the idea but converting looks rather cumbersome, see my general comment in T75703#936775.  https://phabricator.wikimedia.org/maniphest/query/stlzyr...
[20:45:31] 	 (03CR) 10Arlolra: [C: 032] Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/181124 (owner: 10Cscott)
[20:45:44] 	 (03CR) 10Subramanya Sastry: [C: 032] Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/181124 (owner: 10Cscott)
[20:47:38] 	 3Wikimedia-General-or-Unknown: Don't use deprecated features removed in jQuery 1.9 (tracking) - https://phabricator.wikimedia.org/T67399#937006 (10Mattflaschen)
[20:48:04] 	 3MediaWiki-extensions-ConfirmAccount: confirmaccount.sql error: column 'acr_email' used in key specification without a key length - https://phabricator.wikimedia.org/T84999#937008 (10Aklapper) I'm not sure what is "Ok." here. You might want to elaborate and avoid extremely short comments.
[20:48:16] 	 (03CR) 10Aaron Schulz: [C: 032] "I agree with Aude, but that should be a TODO task in phab" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/106126 (owner: 10Anomie)
[20:51:18] 	 (03Merged) 10jenkins-bot: Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/181124 (owner: 10Cscott)
[20:51:20] 	 (03Merged) 10jenkins-bot: Revert "Revert "Use WikiPage::prepareContentForEdit in SpamBlacklistHooks::filterMergedContent"" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/106126 (owner: 10Anomie)
[20:51:49] 	 3OCG-PDF-renderer: enwiki "Book:Che Guevara" fails to render: Status: Rendering process died with non zero code: 1 - https://phabricator.wikimedia.org/T85021#937012 (10Krenair) 3NEW
[20:52:00] 	 3RESTBase, Parsoid, VisualEditor, MediaWiki-General-or-Unknown, VisualEditor-MediaWiki, Scrum-of-Scrums, MediaWiki-extensions-Flow: Use PHP Virtual REST Service to access Parsoid - https://phabricator.wikimedia.org/T1218#937019 (10GWicke) @krenair: Ahh, great news! @aaron: Thank you!
[20:52:26] 	 3MediaWiki-Vagrant, MediaWiki-ResourceLoader: Local vagrant super slow due to minifier - https://phabricator.wikimedia.org/T78733#937020 (10Jdlrobson) I can't view T84960 :( Okay now I'm getting somewhere. If I checkout commit Id0221e9f68786758e10b2f222f5e9170898e320d it only takes 1 second. Going to keep invest...
[20:52:55] 	 3Project-Creators: Rename MediaWiki release tags - https://phabricator.wikimedia.org/T75916#937021 (10fbstj) I also support dropping and also prefixing with MW as there's more than just mediawiki that might require versions at some point
[20:52:59] 	 3MediaWiki-JavaScript: Upgrade jQuery from 1.8.x to 1.11.x - https://phabricator.wikimedia.org/T46740#937022 (10Mattflaschen) Note, the patch removing jQuery Migrate (and thus fully finalizing the upgrade) was c393f8747.
[20:53:52] 	 3MediaWiki-extensions-ConfirmAccount: confirmaccount.sql error: column 'acr_email' used in key specification without a key length - https://phabricator.wikimedia.org/T84999#937025 (10Paladox) I have written ok to tell that I have read your comment/change.
[20:54:10] 	 (03CR) 10Krinkle: "Since Patch Set 4 the parser test was changed to "expect" two spaces (the latter which I presume is  ). This is the exact thing the b" [core] - 10https://gerrit.wikimedia.org/r/142042 (https://bugzilla.wikimedia.org/3158) (owner: 10Krinkle)
[20:54:19] 	 (03CR) 10Krinkle: [C: 04-1] [WIP] Parser: Don't insert   inside style attributes [core] - 10https://gerrit.wikimedia.org/r/142042 (https://bugzilla.wikimedia.org/3158) (owner: 10Krinkle)
[20:54:28] 	 3FINCH: Rename WikimediaEvents extension to FINCH to aggregate tracking information from non-feature specific sources. - https://phabricator.wikimedia.org/T76809#937026 (10Tnegrin) Hey @kevinator, can you please estimate with the team. Please call out what we would need research's help with as well as what we ca...
[20:54:48] 	 3MediaWiki-Parser: Parser inserts invalid   in the middle of style attribute - https://phabricator.wikimedia.org/T5158#937028 (10Krinkle)
[20:55:46] 	 3Wikimedia-General-or-Unknown: Don't use deprecated features removed in jQuery 1.9 (tracking) - https://phabricator.wikimedia.org/T67399#937032 (10Mattflaschen) Note, the patch removing jQuery Migrate was c393f8747, merged on December 4.  Anything open and blocking this bug is broken on production Wikipedia wikis.
[20:57:41] 	 3MediaWiki-Core-Team, operations: Come up with key performance indicators (KPIs) - https://phabricator.wikimedia.org/T784#937037 (10Gage)
[20:59:13] 	 (03PS9) 10Manybubbles: Adds support for taking multiple locks [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/178903 
[20:59:54] 	 3MediaWiki-Vagrant, MediaWiki-ResourceLoader: Local vagrant super slow due to minifier - https://phabricator.wikimedia.org/T78733#937043 (10Jdlrobson) This is the commit where it all went wrong for me https://gerrit.wikimedia.org/r/#/c/175485/
[21:00:28] 	 3MediaWiki-Vagrant, MediaWiki-ResourceLoader: Local vagrant super slow due to minifier - https://phabricator.wikimedia.org/T78733#937044 (10Jdlrobson) @legoktm any idea why this has had just a negative effect on performance for me?
[21:02:13] 	 (03CR) 10Manybubbles: "PS9 implements Aaron's suggestions in the php client and drops the -nowait checking from the daemon." [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/178903 (owner: 10Manybubbles)
[21:02:26] 	 3Wikimedia-Wikimania-Scholarships: Create new report: "By groups of language community" - https://phabricator.wikimedia.org/T85017#937046 (10bd808)
[21:03:12] 	 3MediaWiki-extensions-PageCuration, MediaWiki-extensions-MoodBar, MediaWiki-extensions-Echo, MediaWiki-extensions-Thanks, MediaWiki-extensions-WikiLove: Audit deployed Collaboration team extensions for jQuery 1.11 upgrade issues - https://phabricator.wikimedia.org/T85022#937049 (10Mattflaschen) 3NEW
[21:03:22] 	 3MediaWiki-Vagrant, MediaWiki-ResourceLoader: Local vagrant super slow due to minifier - https://phabricator.wikimedia.org/T78733#937057 (10matmarex) It upgraded the lessphp library from 0.4.0 to 0.5.0, so I guess they had a performance regression.
[21:03:41] 	 3MediaWiki-extensions-PageCuration, MediaWiki-extensions-MoodBar, MediaWiki-extensions-Echo, MediaWiki-extensions-Thanks, MediaWiki-extensions-WikiLove: Audit deployed Collaboration team extensions for jQuery 1.11 upgrade issues - https://phabricator.wikimedia.org/T85022#937049 (10Mattflaschen)
[21:03:58] 	 3MediaWiki-extensions-PageCuration, MediaWiki-extensions-MoodBar, MediaWiki-extensions-Echo, MediaWiki-extensions-WikiLove, MediaWiki-extensions-Thanks, Collaboration-Team: Audit deployed Collaboration team extensions for jQuery 1.11 upgrade issues - https://phabricator.wikimedia.org/T85022#937049 (10Mattflaschen)
[21:04:15] 	 3MediaWiki-extensions-PageCuration, MediaWiki-extensions-MoodBar, MediaWiki-extensions-Echo, MediaWiki-extensions-WikiLove, MediaWiki-extensions-Thanks, Collaboration-Team: Audit deployed Collaboration team extensions for jQuery 1.11 upgrade issues - https://phabricator.wikimedia.org/T85022#937049 (10Mattflaschen...
[21:04:45] 	 3MediaWiki-extensions-PageCuration, MediaWiki-extensions-MoodBar, MediaWiki-extensions-Echo, MediaWiki-extensions-WikiLove, MediaWiki-extensions-Flow, MediaWiki-extensions-Thanks, Collaboration-Team: Audit deployed Collaboration team extensions for jQuery 1.11 upgrade issues - https://phabricator.wikimedia.org/T85...
[21:05:16] 	 MatmaRex: maybe another reason to change the less library :)
[21:05:41] 	 3MediaWiki-JavaScript, Project-Creators: Merge projects javascript and MediaWiki-JavaScript - https://phabricator.wikimedia.org/T76269#937071 (10matmarex) I'm going to be bold then and do it tomorrow.
[21:06:08] 	 jdlrobson: there's a rfc somewhere, right?
[21:06:14] 	 MatmaRex: yup
[21:06:20] 	 i can verify it's the change to 4
[21:06:20] 	 3MediaWiki-Vagrant, MediaWiki-ResourceLoader: Local vagrant super slow due to minifier - https://phabricator.wikimedia.org/T78733#937072 (10Legoktm) >>! In T78733#937057, @matmarex wrote: > It upgraded the lessphp library from 0.4.0 to 0.5.0, so I guess they had a performance regression.  Actually https://gerrit...
[21:06:28] 	 is there any reason we upgraded to 0.5.0?
[21:07:10] 	 legoktm: um, the removed PHP file says 0.4, the composer thingy says 0.5?
[21:07:12] 	 anyway i've reverted it locally so i can at least do some work now
[21:07:21] 	 MatmaRex: yeah, because Krinkle created a new tag
[21:07:26] 	 did they do a release after we upgraded?
[21:07:31] 	 yes
[21:07:38] 	 our upgrade commit pulled directly from master
[21:07:39] 	 jdlrobson: We updated to 0.5.0 in source code before 0.4.0
[21:07:44] 	 separate from composer
[21:07:48] 	 then Krinkle created a tag for it so we could pull it in via composer
[21:07:59] 	 https://github.com/leafo/lessphp/commit/0f5a7f5545d2bcf4e9fad9a228c8ad89cc9aa283
[21:08:00] 	 bah.
[21:08:05] 	 The version we had was an unreleased alpha version of 0.4.x
[21:08:08] 	 well
[21:08:14] 	 I created a tag at the version we were already using before that
[21:08:15] 	 jdlrobson: another reason to murder composer, then. :>
[21:08:19] 	 so trace it back further in git :)
[21:09:27] 	 3MediaWiki-Vagrant, MediaWiki-ResourceLoader: Possible performance degradation in lessc - Local vagrant super slow - https://phabricator.wikimedia.org/T78733#937075 (10Jdlrobson)
[21:09:53] 	 MatmaRex: jdlrobson: The removed PHP file was a copy from the 'master' branch which was last released as 0.4 but was several commits ahead (call it 0.5.0-alpha if you will). I created a tag at that exact version we were using and that's what composer switched to
[21:10:14] 	 jdlrobson: I'd be more interested in knowing why you have so many cache misses. You shouldn't be hitting lessc on normal page loads.
[21:10:17] 	 The performance regression must've happened before that. 0.5.0 has nothing to do with, nor composer.
[21:10:39] 	 legoktm: i looked closer with MaxSem and I'm actually get mostly cache hits
[21:10:54] 	 jdlrobson: If you're tracking it, please track it between the changes to the copy before composer. You'll find that the last copy before composer and the first after are exactly the same and have no performance difference.
[21:11:02] 	 Krinkle: all i know is if I revert that commit my vagrant is fast again for whatever reason
[21:11:06] 	 ok, so then any issue with lessc shouldn't matter if it's being cached.
[21:11:37] 	 (ridiculously faster)
[21:11:43] 	 jdlrobson: can you run `composer update` in /vagrant/mediawiki ?
[21:11:44] 	 actually jdlrobson was eferring to minifier cache
[21:11:59] 	 3MediaWiki-extensions-Renameuser: Wikimedia global user rights log entry did not get updated in global rename - https://phabricator.wikimedia.org/T85023#937077 (10Krenair) 3NEW a:3Legoktm
[21:12:09] 	 jdlrobson: Then I suspect you may be doing something wrong.
[21:12:14] 	 Faulty data.
[21:12:52] 	 3MediaWiki-extensions-Renameuser: Wikimedia global user rights log entry did not get updated in global rename - https://phabricator.wikimedia.org/T85023#937086 (10Legoktm) a:5Legoktm>3None
[21:13:53] 	 jdlrobson: the branch position you're at locally (after reverting the composer change), says v0.4.0@011afcca8e in the source code. Feel free to fetch 0.5.0 over curl on to of that and you'll see there's no difference
[21:13:55] 	 https://github.com/leafo/lessphp/compare/011afcca8e...v0.5.0
[21:15:15] 	 Only difference I can think of is the composer autoloader being slower than MW, but I doubt that could make such a significant difference.
[21:15:22] 	 Indeed
[21:15:38] 	 And https://gerrit.wikimedia.org/r/#/c/174448/14/includes/libs/lessc.inc.php isn't significant either
[21:16:03] 	 Maybe the install is broken after reverting that and you're getting a quick error response. Not actually produced css
[21:17:02] 	 Krinkle: verified. I changed it to v5 and it's the same speed so it's composer that is causing the slowdown
[21:17:15] 	 jdlrobson: did you run composer update like I suggested?
[21:17:27] 	 i did that earlier but i can try again
[21:17:39] 	 jdlrobson: Are you clearing cache in between (server-side), as long as the RL module doesn't change, re-requesting it will fetch it from cache.
[21:17:50] 	 (03PS1) 10Paladox: Upgrade jQuery to 1.11.2 [core] - 10https://gerrit.wikimedia.org/r/181134 
[21:18:03] 	 (03PS2) 10Paladox: Upgrade jQuery to 1.11.2 [core] - 10https://gerrit.wikimedia.org/r/181134 
[21:18:36] 	 (03PS10) 10Aaron Schulz: Adds support for taking multiple locks [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/178903 (owner: 10Manybubbles)
[21:19:14] 	 I highly doubt that the composer autoloader is *that* slow.
[21:20:41] 	 ok ran composer update than vagrant reload on latest master and it seems to be normal speed again
[21:20:49] 	 does vagrant git-update also run composer update ?
[21:21:02] 	 yes, it does
[21:21:25] 	 mm so if it's working now and composer update was the reason why would composer update not have been run?
[21:21:50] 	 (03PS3) 10Paladox: Upgrade jQuery from 1.11.1 to 1.11.2 [core] - 10https://gerrit.wikimedia.org/r/181134 
[21:22:18] 	 oh wait that hasn't fixed it
[21:22:26] 	 css is slow again
[21:22:30] 	 3MediaWiki-extensions-Renameuser: Wikimedia global user rights log entry did not get updated in global rename - https://phabricator.wikimedia.org/T85023#937090 (10Jalexander) So I think this is actually a larger question with global renames. We had the same issue with a globally locked account being renamed. The...
[21:23:38] * jdlrobson will come back to debugging this monday it's frying my brain and i need to do some work
[21:23:49] 	 jdlrobson: Have you tried profiling yet to see what's taking time?
[21:23:57] 	 (03CR) 10Anomie: Normalize newlines before calling preprocessor (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/180022 (owner: 10Anomie)
[21:23:59] 	 (03PS3) 10Anomie: Normalize newlines before calling preprocessor [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/180022 
[21:24:25] 	 bd808: was the less compiler compiling the less files
[21:31:25] 	 (03PS1) 10Legoktm: Reorganize directory structure [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/181168 
[21:32:28] 	 is there any way to get the api help text back on one page?
[21:35:10] 	 (03PS4) 10Krinkle: Update jQuery from v1.11.1 to v1.11.2 [core] - 10https://gerrit.wikimedia.org/r/181134 (owner: 10Paladox)
[21:35:44] 	 (03CR) 10Aaron Schulz: "I might make a follow up patch to support the order-basted strategy." [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/178903 (owner: 10Manybubbles)
[21:41:15] 	 (03CR) 10Aaron Schulz: Adds support for taking multiple locks (032 comments) [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/178903 (owner: 10Manybubbles)
[21:42:33] 	 (03PS1) 10MarkTraceur: Add tests for mw.fileApi [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181169 
[21:44:21] 	 FoxT: yes
[21:44:30] 	 there should be a link to do it on the main api.php page
[21:46:21] 	 MatmaRex: You are right. Pretty far down. Thanks!
[21:47:48] 	 3Wikidata, MediaWiki-extensions-WikibaseClient: Full support for wikibase edits in enhanced changes format ("Group changes by page in recent changes and watchlist" [usenewrc]) - https://phabricator.wikimedia.org/T46874#937116 (10Lydia_Pintscher)
[21:50:00] 	 3MediaWiki-Core-Team: Support strategy #1 in PoolCounter classes - https://phabricator.wikimedia.org/T85026#937122 (10aaron) 3NEW a:3aaron
[21:52:20] 	 3MediaWiki-extensions-Echo, Mobile-Web, Collaboration-Team: Echo should generate canonical diff links - https://phabricator.wikimedia.org/T72318#937137 (10MaxSem) @Mattflaschen, do you think it would be a sane thing to do to send diff links à-la https://en.wikipedia.org/wiki/Article?diff=123 ?
[21:56:50] 	 (03PS1) 10Alex Monk: Fix error in docs of VirtualRESTServiceClient and MultiHttpClient [core] - 10https://gerrit.wikimedia.org/r/181170 
[21:57:03] 	 gwicke, why do I get 'error' '' and 'code' 0 from MultiHttpClient when Parsoid is down?
[21:58:13] 	 (03PS1) 10Rillke: Add re-upload parameter to uploadtext message [core] - 10https://gerrit.wikimedia.org/r/181171 
[21:58:49] 	 3operations: Allow defining hiera data for all of labs - https://phabricator.wikimedia.org/T1291#937159 (10Gage)
[21:58:50] 	 (03CR) 10Rillke: "https://commons.wikimedia.org/wiki/Commons:Village_pump#Upload_a_new_version_of_this_file_notice" [core] - 10https://gerrit.wikimedia.org/r/181171 (owner: 10Rillke)
[21:59:43] 	 (03PS11) 10Manybubbles: Adds support for taking multiple locks [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/178903 
[21:59:50] 	 (03CR) 10Aaron Schulz: Add batch lookup for user groups on Special:ListUsers (032 comments) [core] - 10https://gerrit.wikimedia.org/r/171846 (owner: 10Umherirrender)
[22:00:22] 	 3MediaWiki-Core-Team: Support strategy #1 in PoolCounter classes - https://phabricator.wikimedia.org/T85026#937162 (10aaron) Per https://gerrit.wikimedia.org/r/#/c/178903/
[22:00:32] 	 3MediaWiki-extensions-Echo, Mobile-Web, Collaboration-Team: Echo should generate canonical diff links - https://phabricator.wikimedia.org/T72318#937163 (10Mattflaschen) Yeah, I think that's fine for a single-edit diff.  For diffs that span multiple revisions (e.g. diff between "Article a month ago" and "Article...
[22:00:55] 	 (03CR) 10Manybubbles: "PS11 handles Aaron's last set of comments." [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/178903 (owner: 10Manybubbles)
[22:01:06] 	 3Project-Creators: Rename MediaWiki release tags - https://phabricator.wikimedia.org/T75916#937165 (10Legoktm) +1 to dropping the point release suffixes.
[22:02:59] 	 (03CR) 10Rillke: "What happened to Jenkins? Do I have to invite them for code review?" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/181171 (owner: 10Rillke)
[22:04:18] 	 ori, see my question to gwicke above
[22:04:46] 	 3MediaWiki-User-blocking: blocking for 100000 years doesn't create a block but fills block log - https://phabricator.wikimedia.org/T51580#937168 (10Anomie) >>! In T51580#549868, @matmarex wrote: > and "a potato" (don't ask me why).  "a" is an alias for UTC+1, from [[https://en.wikipedia.org/wiki/Nautical_time|na...
[22:06:03] 	 (03CR) 10Aaron Schulz: Adds support for taking multiple locks (031 comment) [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/178903 (owner: 10Manybubbles)
[22:10:05] 	 (03PS12) 10Manybubbles: Adds support for taking multiple locks [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/178903 
[22:10:34] 	 (03CR) 10Manybubbles: "Agreed with Aaron's last comment and implemented change." [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/178903 (owner: 10Manybubbles)
[22:12:07] 	 (03PS1) 10Anomie: Reject out-of-range output when converting to TS_MW [core] - 10https://gerrit.wikimedia.org/r/181175 
[22:15:01] 	 (03CR) 1020after4: "I'd like to expedite landing this patch due to the fact that our" [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/179405 (owner: 1020after4)
[22:19:24] 	 (03CR) 10Aaron Schulz: [C: 032] "Thanks, that should avoid any value collisions." [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/178903 (owner: 10Manybubbles)
[22:19:37] 	 3MediaWiki-extensions-PageCuration, Collaboration-Team: pagetriage-mark-as-reviewed-error requires a parameter, but it's not always given - https://phabricator.wikimedia.org/T85029#937183 (10Mattflaschen) 3NEW
[22:20:28] 	 (03PS12) 1020after4: Huge refactor of security policy enforcer stuff. [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/179405 
[22:21:58] 	 3MediaWiki-extensions-PageCuration, MediaWiki-extensions-Flow: PageTriage does not support Flow - https://phabricator.wikimedia.org/T85030#937190 (10Mattflaschen) 3NEW
[22:24:09] 	 3MediaWiki-Vagrant: Execution of config_version command `/vagrant/puppet/extra/config-version` failed - https://phabricator.wikimedia.org/T84961#937199 (10Tgr) Can be worked around by `vagrant config nfs_shares no` (although at the cost of some performance hit I suppose).  This only affects new vagrant boxes, I...
[22:29:03] 	 (03CR) 10Subramanya Sastry: "Timo, it is just 2 spaces, not a space and a  " [core] - 10https://gerrit.wikimedia.org/r/142042 (https://bugzilla.wikimedia.org/3158) (owner: 10Krinkle)
[22:29:08] 	 3MediaWiki-Core-Team: Generalize nowait logic in PoolCounterClient_body - https://phabricator.wikimedia.org/T85031#937201 (10aaron) 3NEW a:3aaron
[22:30:32] 	 (03PS1) 10Mattflaschen: Replace .live function calls with .on [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/181191 
[22:31:18] 	 3MediaWiki-extensions-PageCuration, Collaboration-Team: "Tag" and "mark as reviewed" buttons on Curation toolbar appear to be broken. - https://phabricator.wikimedia.org/T84996#937212 (10Mattflaschen)
[22:32:19] 	 3MediaWiki-extensions-PageCuration, Collaboration-Team: "Tag" and "mark as reviewed" buttons on Curation toolbar appear to be broken. - https://phabricator.wikimedia.org/T84996#937215 (10Mattflaschen) a:3Mattflaschen
[22:32:27] 	 3MediaWiki-Core-Team: Generalize nowait logic in PoolCounterClient_body - https://phabricator.wikimedia.org/T85031#937216 (10aaron) Move some code to the base class
[22:32:47] 	 (03PS2) 10Mattflaschen: Replace .live function calls with .on [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/181191 
[22:33:30] 	 (03CR) 10Aaron Schulz: [C: 032] Reject out-of-range output when converting to TS_MW [core] - 10https://gerrit.wikimedia.org/r/181175 (owner: 10Anomie)
[22:38:31] 	 3MediaWiki-Special-pages, Librarization: Show version of jQuery libraries in Special:Version - https://phabricator.wikimedia.org/T40730#937222 (10matmarex)
[22:45:16] 	 (03PS2) 10Bartosz Dziewoński: EditPage: Optimise loading of mediawiki.toolbar module [core] - 10https://gerrit.wikimedia.org/r/181030 (owner: 10Krinkle)
[22:45:34] 	 (03CR) 10Bartosz Dziewoński: "Rebased to fix conflict with 9e02d7d12ac063996b79f7332c83e06dbc86d5ca." [core] - 10https://gerrit.wikimedia.org/r/181030 (owner: 10Krinkle)
[22:49:31] 	 3Ops-Access-Requests: Give mukunda access to gallium - https://phabricator.wikimedia.org/T85033#937240 (10greg) 3NEW
[22:49:49] 	 3Ops-Access-Requests: Give mukunda access to gallium - https://phabricator.wikimedia.org/T85033#937240 (10greg) (We need him to help @hashar :) )
[22:51:22] 	 (03Merged) 10jenkins-bot: Adds support for taking multiple locks [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/178903 (owner: 10Manybubbles)
[22:53:47] 	 3Ops-Access-Requests: Give mukunda access to gallium - https://phabricator.wikimedia.org/T85033#937249 (10JohnLewis) Identification of rights/group is the thing now. Gallium has three groups which are on it, contint-users, -admins and -roots. I'd assume -admins would be the group you're looking at here?  https:/...
[22:53:50] 	 (03PS3) 10Bartosz Dziewoński: EditPage: Optimise loading of mediawiki.toolbar module [core] - 10https://gerrit.wikimedia.org/r/181030 (owner: 10Krinkle)
[22:54:54] 	 3LabsDB-Auditor, MediaWiki-Core-Team, Scrum-of-Scrums: Manually verify whitelisted.yaml / graylisted.yaml to ensure completeness - https://phabricator.wikimedia.org/T78730#937252 (10Legoktm) Where are whitelisted.yaml and greylisted.yaml?
[22:58:14] 	 3SUL-Finalization, MediaWiki-extensions-CentralAuth, MediaWiki-Core-Team: Re-enable $wgCentralAuthAutoMigrate = true - https://phabricator.wikimedia.org/T78727#937255 (10Legoktm) >>! In T78727#931822, @Nemo_bis wrote: > Do we know how many users were merged thanks to $wgCentralAuthAutoMigrate?  legoktm@fluorine:...
[22:59:22] 	 (03Merged) 10jenkins-bot: Reject out-of-range output when converting to TS_MW [core] - 10https://gerrit.wikimedia.org/r/181175 (owner: 10Anomie)
[23:00:14] 	 3MediaWiki-extensions-GeoData, Mobile-Apps: MySQL rounds coordinates improperly - https://phabricator.wikimedia.org/T78715#937258 (10KLans_WMF)
[23:00:49] 	 (03PS1) 10Manybubbles: Fix spacing issues that have been annoying me [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/181205 
[23:00:54] 	 3Services, Mobile-Web, MediaWiki-API: Expose page properties as an API - https://phabricator.wikimedia.org/T78737#937259 (10MaxSem) Note that getting properties on expandtemplates is unlikely because it just preprocesses wikitext while properties are usually (or rather universally?) added later, at the parse step.
[23:01:09] 	 (03CR) 10jenkins-bot: [V: 04-1] Replace .live function calls with .on [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/181191 (owner: 10Mattflaschen)
[23:02:00] 	 3MediaWiki-extensions-PageCuration, Collaboration-Team: "Tag" and "mark as reviewed" buttons on Curation toolbar appear to be broken. - https://phabricator.wikimedia.org/T84996#937260 (10tommorris) Quiddity said on-wiki that there is a code freeze until January 7. This is currently preventing anyone doing new pa...
[23:04:11] 	 (03PS1) 10Legoktm: Split $wgCentralAuthAutoMigrate into two settings [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/181206 
[23:05:39] 	 (03CR) 10Jackmcbarn: "I notice that there's still ways a \r could sneak in, such as frame:extensionTag('ref', 'something with a \r in it')" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/180022 (owner: 10Anomie)
[23:06:22] 	 (03PS2) 10Manybubbles: Fix spacing issues that have been annoying me [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/181205 
[23:11:28] 	 3Wikimedia-Mailing-lists: Add Wikimedia-US-MN mailing list for Minnesota - https://phabricator.wikimedia.org/T76655#937264 (10JohnLewis) 5Open>3Resolved a:3JohnLewis Done.
[23:13:56] 	 3MediaWiki-extensions-Flow: Flow: use PHP Virtual REST Service to access Parsoid on private wikis (e.g. officewiki) - https://phabricator.wikimedia.org/T74988#937267 (10Krenair)
[23:14:18] 	 3MediaWiki-extensions-Flow: Flow: Use PHP Virtual REST Service to access Parsoid - https://phabricator.wikimedia.org/T74988#937268 (10Krenair)
[23:15:57] 	 3Wikimedia-Mailing-lists: Add Wikimedia-US-MN mailing list for Minnesota - https://phabricator.wikimedia.org/T76655#937273 (10MarkTraceur) Thanks so much!
[23:17:09] 	 3Ops-Access-Requests: Give mukunda access to gallium - https://phabricator.wikimedia.org/T85033#937274 (10greg) >>! In T85033#937249, @JohnLewis wrote: > Identification of rights/group is the thing now. Gallium has three groups which are on it, contint-users, -admins and -roots. I'd assume -admins would be the g...
[23:20:40] 	 (03PS3) 10Manybubbles: Fix spacing issues that have been annoying me [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/181205 
[23:21:20] 	 3Collaboration-Team, MediaWiki-extensions-Flow: Fatal errors such as "Class 'Edit-headerAction' not found" from action=edit-header on regular or non-existent page. - https://phabricator.wikimedia.org/T85035#937284 (10Spage) 3NEW
[23:22:56] 	 (03PS4) 10Manybubbles: Fix spacing issues that have been annoying me [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/181205 
[23:24:16] 	 3Ops-Access-Requests: Give mukunda access to gallium - https://phabricator.wikimedia.org/T85033#937291 (10greg) And for the record, I approve my own request as his manager :)
[23:27:43] 	 (03PS1) 10Aaron Schulz: Moved "nowait:" key code to PoolCounter in core [core] - 10https://gerrit.wikimedia.org/r/181209 
[23:28:24] 	 (03PS1) 10Aaron Schulz: Move to using the core "nowait:" key code [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/181210 
[23:28:59] 	 3MediaWiki-API, Mobile-Web, Wikipedia-App-Android-App: "description page there" (commons images) links to [[commons:file:API]] - https://phabricator.wikimedia.org/T78003#937295 (10KLans_WMF) p:5Triage>3Normal
[23:31:12] 	 (03CR) 10Aaron Schulz: [C: 032] Fix spacing issues that have been annoying me [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/181205 (owner: 10Manybubbles)
[23:31:16] 	 (03Merged) 10jenkins-bot: Fix spacing issues that have been annoying me [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/181205 (owner: 10Manybubbles)
[23:31:23] 	 AaronS: thanks
[23:33:52] 	 (03CR) 10Aaron Schulz: "Can you update MultiHttpClient too?" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/181170 (owner: 10Alex Monk)
[23:34:02] 	 (03CR) 10Manybubbles: [C: 031] "Makes sense to me. Can test Monday morning and +2 if you can't someone else to do it first." [core] - 10https://gerrit.wikimedia.org/r/181209 (owner: 10Aaron Schulz)
[23:35:06] 	 (03CR) 10Manybubbles: [C: 031] "Happy to test and +2 on Monday morning after I test it." [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/181210 (owner: 10Aaron Schulz)
[23:35:10] 	 3Wikimedia-Mailing-lists: Opening new mailing list for WikimediaIL - https://phabricator.wikimedia.org/T76440#937296 (10JohnLewis) 5Open>3Resolved a:3JohnLewis Done.
[23:38:31] 	 3Multimedia: Puppetize Sentry - https://phabricator.wikimedia.org/T84956#937306 (10Tgr)
[23:38:48] 	 3Multimedia, MediaWiki-Vagrant: Vagrantize Sentry - https://phabricator.wikimedia.org/T84957#937309 (10Tgr)
[23:39:37] 	 3Wikimedia-Mailing-lists: Create mailing list specifically for Afrikaans speaking contributors - Wikimedia ZA - https://phabricator.wikimedia.org/T75066#937310 (10JohnLewis) 5Open>3Resolved a:3JohnLewis Really really sorry for this delay in processing this request.
[23:42:00] 	 3Multimedia: Puppetize Sentry - https://phabricator.wikimedia.org/T84956#937313 (10Tgr)
[23:43:06] 	 3Multimedia, MediaWiki-Vagrant: Vagrantize Sentry - https://phabricator.wikimedia.org/T84957#937314 (10Tgr)
[23:43:55] 	 3Wikimedia-Mailing-lists: Close Fundraising-DE - https://phabricator.wikimedia.org/T76121#937317 (10JohnLewis) Hi,  The way you should close the mailing list is by doing the following: (only listadmins can do)  First, remove the list from the listinfo page display by going to https://lists.wikimedia.org/mailman/...
[23:48:19] 	 (03PS1) 10Spage: Correct MWPageTriageMissingRevisionException name [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/181214 
[23:50:45] 	 (03CR) 10jenkins-bot: [V: 04-1] Moved "nowait:" key code to PoolCounter in core [core] - 10https://gerrit.wikimedia.org/r/181209 (owner: 10Aaron Schulz)
[23:53:12] 	 (03PS2) 10Aaron Schulz: Moved "nowait:" key code to PoolCounter in core [core] - 10https://gerrit.wikimedia.org/r/181209 
[23:58:27] 	 3MediaWiki-JavaScript: [jquery.tipsy] Uses deprecated $.fn.live when using live option - https://phabricator.wikimedia.org/T69989#937345 (10matmarex) a:3matmarex