[00:00:16] 3MediaWiki-extensions-Gadgets: Require all gadgets to load via ResourceLoader - https://phabricator.wikimedia.org/T75810#783026 (10He7d3r) [00:01:32] superm401: do you know if we still have an account with browserstack, and if so, where the credentials for it are? [00:03:04] 3Beta-Cluster: hhvm apache fills /var/log/apache2 with access logs - https://phabricator.wikimedia.org/T75262#783082 (10greg) [00:03:08] superm401: nevermind; found the relevant page on officewiki [00:03:20] 3MediaWiki-extensions-Gadgets: Require all gadgets to load via ResourceLoader - https://phabricator.wikimedia.org/T75810#783083 (10Legoktm) https://gerrit.wikimedia.org/r/#/c/166363/ needs work. [00:03:36] 3Beta-Cluster: hhvm apache fills /var/log/apache2 with access logs - https://phabricator.wikimedia.org/T75262#755023 (10greg) [00:04:04] 3Fundraising: Donation banner showing up for logged-in users - https://phabricator.wikimedia.org/T75812 (10MZMcBride) 3NEW p:3High [00:04:13] Map from bugzilla aliases to phabricator tasks - https://phabricator.wikimedia.org/T240#783096 (10Aklapper) Uhm, looks like we did not put the Alias into the initial description... I'm sorry for that. I think we forgot while discussing all the other stuff to drop in the description in T694 and while discussion foc... [00:04:33] (03PS4) 10Kaldari: Fixing confusing function description [core] - 10https://gerrit.wikimedia.org/r/175570 [00:05:41] 3Fundraising: Donation banner showing up for logged-in users - https://phabricator.wikimedia.org/T75812#783088 (10MZMcBride) Lego points out that donation banners also shouldn't be appearing on non-articles. This seems like a pretty major bug. [00:06:03] 3MediaWiki-Core-Team: Investigate OrientDB for WDQ - https://phabricator.wikimedia.org/T75813 (10aaron) 3NEW p:3Normal a:3aaron [00:06:27] 3Beta-Cluster: Setup puppet exported resources to collect ssh host keys for beta - https://phabricator.wikimedia.org/T72792#783117 (10greg) p:5Triage>3Normal [00:06:58] (03CR) 10Ori.livneh: Shut down writer once input is exhausted (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/175338 (owner: 10QChris) [00:08:42] 3MediaWiki-extensions-GettingStarted, Beta-Cluster: GettingStarted extension broken at beta.wmflabs.org - https://phabricator.wikimedia.org/T53362#783128 (10greg) [00:08:49] 3MediaWiki-extensions-GettingStarted, Beta-Cluster: GettingStarted extension broken at beta.wmflabs.org - https://phabricator.wikimedia.org/T53362#563334 (10greg) [00:10:33] (03PS1) 10EBernhardson: Bug: Typo in property name [extensions/Flow] - 10https://gerrit.wikimedia.org/r/175609 [00:11:25] (03CR) 10Divec: "Overall, looks like a good split and is much cleaner." (033 comments) [services/cxserver] - 10https://gerrit.wikimedia.org/r/175398 (owner: 10Santhosh) [00:13:08] 3Team-Practices: create non-engineering specific health check survey - https://phabricator.wikimedia.org/T1344#783141 (10Awjrichards) a:3ggellerman [00:13:18] 3Team-Practices: schedule q2 health-check - flow - https://phabricator.wikimedia.org/T1304#783149 (10Awjrichards) [00:13:29] 3Team-Practices: schedule q2 health-check - analytics research - https://phabricator.wikimedia.org/T1303#783151 (10Awjrichards) a:3ggellerman [00:13:36] 3Team-Practices: schedule q2 health-check - analytics engineering - https://phabricator.wikimedia.org/T1302#783152 (10Awjrichards) a:3ggellerman [00:14:49] (03CR) 10Legoktm: [C: 032] Support joins via EchoBatchRowIterator [extensions/Echo] - 10https://gerrit.wikimedia.org/r/174236 (owner: 10EBernhardson) [00:15:07] (03PS9) 10Legoktm: Rename ConvertLqt to ConvertLqtPage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174353 (owner: 10EBernhardson) [00:15:10] (03CR) 10QChris: [C: 04-1] Make sql_writer accept a 'replace' parameter (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/175339 (owner: 10QChris) [00:15:12] (03CR) 10Legoktm: [C: 032] Rename ConvertLqt to ConvertLqtPage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174353 (owner: 10EBernhardson) [00:15:21] (03PS10) 10Legoktm: Create a CONTENT_MODEL_FLOW_BOARD define [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174838 (owner: 10EBernhardson) [00:15:29] (03Merged) 10jenkins-bot: Support joins via EchoBatchRowIterator [extensions/Echo] - 10https://gerrit.wikimedia.org/r/174236 (owner: 10EBernhardson) [00:15:55] (03PS3) 10Ori.livneh: Shut down writer once input is exhausted [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/175338 (owner: 10QChris) [00:16:05] (03Merged) 10jenkins-bot: Rename ConvertLqt to ConvertLqtPage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174353 (owner: 10EBernhardson) [00:16:08] (03CR) 10Legoktm: [C: 032] Create a CONTENT_MODEL_FLOW_BOARD define [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174838 (owner: 10EBernhardson) [00:16:26] (03PS1) 10MaxSem: MF: https://gerrit.wikimedia.org/r/#/c/175552/ [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/175611 [00:16:56] (03Merged) 10jenkins-bot: Create a CONTENT_MODEL_FLOW_BOARD define [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174838 (owner: 10EBernhardson) [00:17:09] (03CR) 10Ori.livneh: "I did a --reset-author but Gerrit doesn't care, evidently. Anyhow, if any credit is due here, it's to you for spotting the original issue " [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/175338 (owner: 10QChris) [00:17:36] 3MediaWiki-extensions-CentralAuth: Create special page to manage global rename request queue - https://phabricator.wikimedia.org/T70924#783154 (10DerHexer) [00:17:42] (03CR) 10Legoktm: [C: 032] Bug: LQT import wrong date on topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174033 (owner: 10EBernhardson) [00:18:37] (03PS1) 10MaxSem: MF: https://gerrit.wikimedia.org/r/#q,175126,n,z https://gerrit.wikimedia.org/r/#q,175554,n,z [core] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/175613 [00:18:58] (03CR) 10MaxSem: [C: 032 V: 032] MF: https://gerrit.wikimedia.org/r/#/c/175552/ [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/175611 (owner: 10MaxSem) [00:19:14] (03CR) 10MaxSem: [C: 032 V: 032] MF: https://gerrit.wikimedia.org/r/#q,175126,n,z https://gerrit.wikimedia.org/r/#q,175554,n,z [core] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/175613 (owner: 10MaxSem) [00:19:19] (03Merged) 10jenkins-bot: Bug: LQT import wrong date on topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174033 (owner: 10EBernhardson) [00:22:54] (03CR) 10Bartosz Dziewoński: "Let's revert, the backwards-compatibility breakage is unintended (didn't even have a release note). I'll revert tomorrow unless someone do" [core] - 10https://gerrit.wikimedia.org/r/166872 (https://bugzilla.wikimedia.org/72094) (owner: 10Gerrit Patch Uploader) [00:23:50] ori, we also have Sauce Labs access, if you prefer that or want to try it. Similar concept, different provider. I've mostly used Sauce. [00:28:17] Investigate float test failures - https://phabricator.wikimedia.org/T75815#783160 (10GWicke) [00:28:42] Investigate float test failures - https://phabricator.wikimedia.org/T75815#783160 (10GWicke) [00:29:27] (03PS10) 10EBernhardson: LQT import Postprocessing. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174460 (owner: 10Werdna) [00:29:36] (03CR) 10jenkins-bot: [V: 04-1] LQT import Postprocessing. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174460 (owner: 10Werdna) [00:31:35] (03PS11) 10EBernhardson: LQT import Postprocessing. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174460 (owner: 10Werdna) [00:34:06] (03PS12) 10EBernhardson: LQT import Postprocessing. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174460 (owner: 10Werdna) [00:35:37] (03CR) 10EBernhardson: [C: 032] "Cleaned up one wrong comment and adjusted namespacing for 1 class per file." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174460 (owner: 10Werdna) [00:36:26] (03Merged) 10jenkins-bot: LQT import Postprocessing. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174460 (owner: 10Werdna) [00:39:21] 3Fundraising: Donation banner showing up for logged-in users - https://phabricator.wikimedia.org/T75812#783167 (10Pcoombe) Thanks for finding the banner name, that's helpful! So far as I can tell [[ https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/B14_1030_enUS_dsk_gwy_wp | that banner ]] has al... [00:42:06] 3Services, Scrum-of-Scrums: Restbase deployment - https://phabricator.wikimedia.org/T1228#783172 (10GWicke) [00:45:39] (03PS1) 10Yurik: fix broken xml in .idea/codeStyleSettings.xml [vagrant] - 10https://gerrit.wikimedia.org/r/175617 [00:46:18] Need a new Project created for WikiGrok extension - https://phabricator.wikimedia.org/T75816 (10kaldari) 3NEW p:3Triage [00:46:53] (03CR) 10Trevor Parscal: [C: 031] "I'm no bash expert, but it seems sane to me." [core] - 10https://gerrit.wikimedia.org/r/175185 (owner: 10Jforrester) [00:48:17] (03CR) 10Yurik: [C: 032] "self-commiting, minor IDE fix" [vagrant] - 10https://gerrit.wikimedia.org/r/175617 (owner: 10Yurik) [00:48:24] (03Merged) 10jenkins-bot: fix broken xml in .idea/codeStyleSettings.xml [vagrant] - 10https://gerrit.wikimedia.org/r/175617 (owner: 10Yurik) [00:50:58] 3VisualEditor, VisualEditor-EditingTools, MediaWiki-extensions-UniversalLanguageSelector: IME selector shows up at the bottom-right corner of the table while selecting a cell on a table or placing a cursor into it - https://phabricator.wikimedia.org/T74824#783182 (10Ryasmeen) [00:51:44] 3VisualEditor, VisualEditor-EditingTools, MediaWiki-extensions-UniversalLanguageSelector: IME selector shows up at the bottom-right corner of the table while selecting a cell on a table or placing a cursor into it - https://phabricator.wikimedia.org/T74824#783183 (10Ryasmeen) [00:52:06] 3WMF-Design, Fundraising: Polish : Credit card input form should reflect organization of credit card - https://phabricator.wikimedia.org/T1189#783184 (10Jaredzimmerman-WMF) [00:52:11] (03PS3) 10Krinkle: Maintainance: Update OOjs UI pull-through script to use release versions [core] - 10https://gerrit.wikimedia.org/r/175185 (owner: 10Jforrester) [00:52:47] 3Mobile-Web, WMF-Design: Polish : Search placeholder text is shifted ~2 px when field gains focus. - https://phabricator.wikimedia.org/T1159#783186 (10Jaredzimmerman-WMF) [00:54:32] 3WMF-Design, Editing: Polish : VisualEditor Loading indicator should feel more integrated into the interface - https://phabricator.wikimedia.org/T1181#783194 (10Jaredzimmerman-WMF) [00:55:32] 3WMF-Design, Editing: Polish : Date entry in citations should be automatically reformatted to community norms - https://phabricator.wikimedia.org/T1186#783196 (10Jaredzimmerman-WMF) [00:56:18] (03CR) 10Krinkle: [C: 04-1] "Commit creation failed. Throws error in rsync locally:" [core] - 10https://gerrit.wikimedia.org/r/175185 (owner: 10Jforrester) [00:56:23] James_F: TrevorParscal: ^ [00:56:34] Not sure what's going on. Please verify and let me know if you want me to investigate. [00:56:55] Krinkle: Its your scrupt… [00:56:59] Err. Script. [00:57:03] (03PS1) 10Awight: update CentralNotice submodule [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/175623 [00:57:05] The other version works :P [00:57:10] Krinkle: So, why is it failing to create the temporary directory? [00:57:19] Is it? [00:57:39] (03PS1) 10Awight: update CentralNotice submodule [core] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/175624 [00:58:02] James_F: I checked $ ls -l /private/var/folders/5g/w6rp8_3d56s7jmxjz8p6fznw0000gn/T/update-oojs-ui.akaGV4HC/node_modules/oojs-ui/ [00:58:05] the issue is dist/ not existing [00:58:19] I guess build was not run before npm publish [00:58:33] Or rather, unliek oojs-core, we don't ahve grunt build set up in oojs-ui package.json prepublish auto-hook [00:58:35] James_F: [00:58:38] Krinkle: Hmm. It was. Does OOjs-UI's grunt… yeah. [00:58:45] i.e. the package is broken :-( [00:58:46] * James_F looks. [00:58:50] Well, let's fix it. [00:58:54] cool [00:59:00] I'm assuming that's the only issue [00:59:08] * James_F crosses fingers. [00:59:09] I'll review/merge swiftly. [00:59:15] Thanks. [00:59:16] Or want me to add the hook and publish? [00:59:36] "prepublish": "grunt build" [00:59:40] it's there... Hm.. [00:59:58] Yeah. [01:00:11] (03CR) 10Awight: [C: 032] update CentralNotice submodule [core] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/175624 (owner: 10Awight) [01:00:16] (03CR) 10Awight: [C: 032] update CentralNotice submodule [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/175623 (owner: 10Awight) [01:00:21] Nothing looks obviously different. [01:01:24] James_F: OK, I'll debug. [01:01:29] Krinkle: Should it be `grunt git-build` instead? [01:01:41] That would still produce some kind of dist/ directory. [01:01:45] Right now it's not there at all [01:01:52] Yeah. [01:02:03] Did your local execution of the script fail for some reason. [01:02:05] cd /tmp, npm install oojs-ui, ls -l /tmp/node_modules/oojs-ui [01:02:10] Nope [01:02:23] James_F: I suspect npmignore [01:02:30] We're probably excluding it from the build [01:02:42] Oooh. [01:03:07] Krinkle: OOjs vs. OOjs UI .gitignore files are essentially identical. [01:03:13] 3MediaWiki-extensions-GettingStarted, Beta-Cluster: GettingStarted extension broken at beta.wmflabs.org - https://phabricator.wikimedia.org/T53362#783205 (10faidon) [01:03:17] James_F: But absence of npmignore is key [01:03:21] npmigure falls back to gitignore [01:03:29] Aha. [01:03:32] oojs coe npmignore is gitingore sans dist/ [01:03:52] Krinkle: Adding. [01:06:01] (03Merged) 10jenkins-bot: update CentralNotice submodule [core] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/175624 (owner: 10Awight) [01:06:12] (03Merged) 10jenkins-bot: update CentralNotice submodule [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/175623 (owner: 10Awight) [01:10:13] 3MediaWiki-extensions-Popups, MediaWiki-extensions-TextExtracts: Hovercards: TextExtract has anchor link?! - https://phabricator.wikimedia.org/T69180#783207 (10Quiddity) [01:14:39] 3MediaWiki-extensions-Flow: CSS is broken in IE 8 (tracking) - https://phabricator.wikimedia.org/T75817#783215 (10Mattflaschen) [01:16:07] 3MediaWiki-extensions-Flow: CSS is broken in IE 8 (tracking) - https://phabricator.wikimedia.org/T75817#783215 (10Mattflaschen) [01:18:03] 3WMF-Design, Core-Features: Polish : Include echo notification count as a favicon badge - https://phabricator.wikimedia.org/T1188#783240 (10Jaredzimmerman-WMF) [01:19:38] 3MediaWiki-extensions-Flow: Don't use psuedo-selectors that are not supported in IE 8. - https://phabricator.wikimedia.org/T75819#783241 (10Mattflaschen) [01:20:09] 3MediaWiki-extensions-Flow: Don't use psuedo-selectors that are not supported in IE 8. - https://phabricator.wikimedia.org/T75819#783241 (10Mattflaschen) [01:23:23] 3MediaWiki-extensions-Flow: Don't use psuedo-selectors that are not supported in IE 8. - https://phabricator.wikimedia.org/T75819#783249 (10Mattflaschen) [01:23:43] (03PS1) 10Krinkle: Update OOjs UI to v0.2.2 [core] - 10https://gerrit.wikimedia.org/r/175631 [01:24:33] 3Wikimedia-Fundraising: Payment processor website uses RC4 for https encryption - https://phabricator.wikimedia.org/T75644#783253 (10Chmarkine) While you may say "it presents very little risk in this context", the real issue here is that the existence of RC4-only servers prevents the clients from disabling RC4 c... [01:25:22] (03CR) 10Krinkle: [C: 032] "Caused by oojs-ui's npmignore (in absence thereof, npm defaults to gitignore) excluding dist/ from the published package. Fixed in https:/" [core] - 10https://gerrit.wikimedia.org/r/175185 (owner: 10Jforrester) [01:26:01] 3MediaWiki-extensions-Popups, MediaWiki-extensions-TextExtracts: Extract too short due to initials - https://phabricator.wikimedia.org/T75820 (10Quiddity) 3NEW p:3Triage [01:26:27] (03CR) 10Jforrester: [C: 032] Update OOjs UI to v0.2.2 [core] - 10https://gerrit.wikimedia.org/r/175631 (owner: 10Krinkle) [01:30:25] 3MediaWiki-extensions-Flow: Don't use psuedo-selectors that are not supported in IE 8. - https://phabricator.wikimedia.org/T75819#783261 (10Mattflaschen) [01:30:53] (03Merged) 10jenkins-bot: Maintainance: Update OOjs UI pull-through script to use release versions [core] - 10https://gerrit.wikimedia.org/r/175185 (owner: 10Jforrester) [01:31:59] (03CR) 10Mattflaschen: [C: 04-1] "A couple issues. One of them is pretty straightforward to fix (can't use :not in LESS, so I'll add inactive). For the other one, I'm goi" (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169531 (owner: 10SG) [01:32:14] (03Merged) 10jenkins-bot: Update OOjs UI to v0.2.2 [core] - 10https://gerrit.wikimedia.org/r/175631 (owner: 10Krinkle) [01:52:05] (03PS1) 10GWicke: Pull restbase from wikimedia repo [services/restbase/deploy] - 10https://gerrit.wikimedia.org/r/175635 [01:52:07] (03PS1) 10GWicke: Update to restbase v0.2.5 [services/restbase/deploy] - 10https://gerrit.wikimedia.org/r/175636 [01:52:29] (03CR) 10GWicke: [C: 032 V: 032] Pull restbase from wikimedia repo [services/restbase/deploy] - 10https://gerrit.wikimedia.org/r/175635 (owner: 10GWicke) [01:52:43] (03CR) 10GWicke: [C: 032 V: 032] Update to restbase v0.2.5 [services/restbase/deploy] - 10https://gerrit.wikimedia.org/r/175636 (owner: 10GWicke) [01:58:08] (03PS11) 10Mattflaschen: J-2a.II Current topic title in affixed board nav [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169531 (owner: 10SG) [01:58:34] (03CR) 10Mattflaschen: [C: 04-1] "Finished the active thing (went with a slightly different approach)." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169531 (owner: 10SG) [01:58:46] (03PS6) 10Mattflaschen: Add component to api callback info object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170997 (owner: 10SG) [02:00:22] (03PS6) 10Mattflaschen: Introduce include-offset option to pager [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170998 (owner: 10SG) [02:01:13] (03CR) 10jenkins-bot: [V: 04-1] Introduce include-offset option to pager [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170998 (owner: 10SG) [02:03:50] (03PS7) 10Mattflaschen: J-2d.III Load more revamp and jumpTo support [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170999 (owner: 10SG) [02:04:38] (03CR) 10jenkins-bot: [V: 04-1] J-2d.III Load more revamp and jumpTo support [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170999 (owner: 10SG) [02:06:05] 3Services, Scrum-of-Scrums: Restbase deployment - https://phabricator.wikimedia.org/T1228#783262 (10GWicke) [02:12:14] (03CR) 10Mattflaschen: [C: 032] "Works." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/175609 (owner: 10EBernhardson) [02:13:00] (03Merged) 10jenkins-bot: Bug: Typo in property name [extensions/Flow] - 10https://gerrit.wikimedia.org/r/175609 (owner: 10EBernhardson) [02:22:17] Krenair: thedj: It seems addOnloadHook made a significant increase in usage past week. Anything come to mind as to what that might be? [02:22:30] 3Wikimedia-Site-requests: Restore missing CheckUser logs - https://phabricator.wikimedia.org/T29807#783266 (10Rschen7754) [02:22:47] http://s.codepen.io/Krinkle/fullpage/zyodJ#h-legacy.wikibits [02:24:11] 3Wikimedia-Site-requests: Turn mediawiki.org into a Wikidata client - https://phabricator.wikimedia.org/T73685#783276 (10Rschen7754) [02:25:26] This query will give me an edit count for user "foobar" [02:25:28] http://en.wikipedia.org/w/api.php?action=query&list=users&usprop=editcount&ususers=foobar [02:25:40] However this query doesn't work for an ip address [02:26:15] Is there a way to get the API to return a edit count for an ip address? [02:28:48] 3Fundraising: Donation banner showing up for logged-in users - https://phabricator.wikimedia.org/T75812#783287 (10awight) We filter out the Special: namespace, but the others are currently fair game. I'd be interested in any arguments for filtering down to only the article space, though... [02:29:33] FutureTense: No, there is not (short of counting revisions from the contributions query, I think) [02:29:47] thats poo poo :( [02:29:54] FutureTense: Mostly since IPs are not considered a single usr [02:30:02] multiple users : 1 IP [02:30:06] yah [02:30:07] 1 user: multiple IPs [02:30:25] t [02:30:26] ty [02:30:39] 3Mobile-Web: editing header missing in beta in mobile editor after scrolling down - https://phabricator.wikimedia.org/T75821 (10kaldari) 3NEW p:3Triage [02:30:46] FutureTense: however there is an extension for research currently enabled you may be able to use [02:30:49] FutureTense: http://www.mediawiki.org/w/api.php?action=help&modules=userdailycontribs [02:31:03] userdialycontribs is a custom extension that provides some stats. It might have it for anons. Check it out. [02:31:10] Let me know if that works out so I know as well :) [02:33:36] (03CR) 10Krinkle: [C: 032] "Cool. The value was already a boolean it seems (attributes take string values)." [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/175600 (https://bugzilla.wikimedia.org/69349) (owner: 10Kaldari) [02:33:54] (03Merged) 10jenkins-bot: Migrating from attr() to prop() [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/175600 (https://bugzilla.wikimedia.org/69349) (owner: 10Kaldari) [02:35:45] (03PS1) 10Krinkle: Maintenance: Simplify reading of package.json by using require() [core] - 10https://gerrit.wikimedia.org/r/175650 [02:38:42] (03CR) 10Jforrester: Maintenance: Simplify reading of package.json by using require() (032 comments) [core] - 10https://gerrit.wikimedia.org/r/175650 (owner: 10Krinkle) [02:38:48] (03PS2) 10Krinkle: Maintenance: Simplify reading of package.json by using require() [core] - 10https://gerrit.wikimedia.org/r/175650 [02:39:10] :-D [02:39:15] (03CR) 10Jforrester: [C: 032] Maintenance: Simplify reading of package.json by using require() [core] - 10https://gerrit.wikimedia.org/r/175650 (owner: 10Krinkle) [02:39:23] (03CR) 10Krinkle: "Indeed. Caught that in testing. I thought I copied it from your ve-core commit though. Will double check." [core] - 10https://gerrit.wikimedia.org/r/175650 (owner: 10Krinkle) [02:39:58] (03PS25) 10Mattflaschen: J-2b & J-2d.IV Implement TOC on front-end [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171000 (owner: 10SG) [02:40:51] (03CR) 10jenkins-bot: [V: 04-1] J-2b & J-2d.IV Implement TOC on front-end [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171000 (owner: 10SG) [02:44:46] (03Merged) 10jenkins-bot: Maintenance: Simplify reading of package.json by using require() [core] - 10https://gerrit.wikimedia.org/r/175650 (owner: 10Krinkle) [02:44:56] (03PS1) 10Dbrant: Added config parameter for search logging sample rate. [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/175651 [02:45:26] (03CR) 10jenkins-bot: [V: 04-1] Added config parameter for search logging sample rate. [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/175651 (owner: 10Dbrant) [02:46:51] (03CR) 10EBernhardson: [C: 031] J-2e Remove all collapsing functionality [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166727 (owner: 10SG) [02:49:39] Krinkle: RoanKattouw: yt? [02:50:17] I'm here [02:50:43] RoanKattouw: hi! Have a sec for a quick check into a possible problem with RL and caching? [02:51:03] Sure [02:52:03] RoanKattouw: thanks! https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FCentralNotice/7721b32b1df7cc141fc6e5ac01fcf773b35d57f5/includes%2FCNBannerChoiceDataResourceLoaderModule.php [02:52:15] ^ that's our current version of our custom RL module [02:52:31] Our possible issue is caching & line 37 [02:52:39] Ahm [02:52:42] Yeah, that looks fishy [02:52:54] Why does it matter whether the user is logged in or not? [02:52:55] We're worried that we're not distinguishing logged-ins vs. anons... [02:53:06] You almost certainly aren;t [02:53:22] Would it be feasible to do the anon/logged-in distinction on the client instead? [02:53:28] And serve data for both in this module? [02:53:53] RoanKattouw: OK, important to hear that, yes it's feasable but it's desirable not to [02:54:16] Is it not possible to disitnguish logged in status in a RL module? [02:56:04] AndyRussG: I think there may be a way to do it, but I don't think there's a nice way to do it [02:56:05] RoanKattouw: awight: I can say mw.config.get('wgUserId') in JS... [02:56:42] Yeah [02:56:52] There are various wgUser* variables you can look at [02:58:52] AndyRussG: yeah I agree that we have to move this check to the client side [02:59:04] AndyRussG: meanwhile, I'm flipping the client choice switch back off... :( [02:59:26] awight: wait -- RoanKattouw isn't there a reliable way we could get anon vs logged in in RL? [02:59:55] We have production code doing undesirable things but if there's a simple fix we could roll that out instead of turning off the feature... [02:59:57] AndyRussG: the problem is that the URL doesn't distinguish between anon and logged-out [03:00:22] Then how oes mw.config do it? [03:00:33] AndyRussG: I think in the startup module. [03:01:02] So... the startup module has more info than the rest¡ [03:01:03] ? [03:01:10] AndyRussG: There's no good way to do it server side, especially not if you're in a rush [03:01:15] AndyRussG: did u see that horrific URL I pasted? That doesn't seem to distinguish between logged-in and logged-out [03:01:27] No, the startup module is not where that comes from [03:01:32] wgUserId is in the HTML of the view page itself [03:01:53] AndyRussG: http://paste2.org/pO6mek9F [03:01:57] RoanKattouw: ah [03:02:37] I looked at some of the code I apparently wrote many years ago, and it looks like possibly there's a way to do server-side user stuff maybe (involves passing a &user= parameter) [03:02:54] (03PS4) 10EBernhardson: OccupationController should consider Title::getContentType [extensions/Flow] - 10https://gerrit.wikimedia.org/r/175574 [03:03:01] But I don't know if the client-side loader supports it, and I don't think you want to go into poorly-understood territory if it's urgent [03:03:07] (03PS12) 10EBernhardson: Implement full wiki lqt conversion [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174354 [03:03:26] RoanKattouw: yeah I did see there was a user param expected in places but that wasn't sent [03:03:36] Whereas at least if you do client-side variance using wgUserId or whatever, everyone will perfectly understand what's going on [03:05:33] (03PS10) 10EBernhardson: Archive and takeover namespaces with Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174861 [03:05:35] RoanKattouw: awight: OK, I see that URL doesn't send in user data... So RL sets the user info by checking the client-side HTML? [03:06:19] The client-side HTML includes a blurb that looks like [03:06:48] That blurb is mostly used for wgPageName, and it's more sensible that page-specific stuff would go there [03:07:00] But a quirk of our caching setup is that only anon reads are cached, logged-in reads are not [03:07:11] And so putting user stuff in there is safe as long as it's the same for all anons [03:10:29] (03PS4) 10Krinkle: Better article link detection [extensions/Popups] - 10https://gerrit.wikimedia.org/r/146477 (https://bugzilla.wikimedia.org/68039) (owner: 10Se4598) [03:11:09] (03CR) 10jenkins-bot: [V: 04-1] Better article link detection [extensions/Popups] - 10https://gerrit.wikimedia.org/r/146477 (https://bugzilla.wikimedia.org/68039) (owner: 10Se4598) [03:12:09] (03CR) 10Krinkle: [C: 04-1] Better article link detection (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/146477 (https://bugzilla.wikimedia.org/68039) (owner: 10Se4598) [03:13:20] RoanKattouw: awight: right, hurmmm, so to be more specific about that quirk, only the page html for logged-ins is not cached, but RL modules for logged-ins _are_ cached. OK... [03:13:47] interesting to learn about this fancy footwork, albeit late in the game 8p [03:14:48] Yeah... [03:15:06] RL module requests deliberately do not have user information so they're easier to cache [03:15:31] The less they know, the fewer different outputs they can produce, the easier caching is [03:15:36] Yeah... [03:15:58] RoanKattouw: K, so as awight correctly said a little while ago, the feature that depended on this is getting turned off, and we'll see how we fix it... [03:19:18] JeroenDeDauw: The Maps extension has coding the long-deprecated andSelf() function (https://gerrit.wikimedia.org/r/#/c/9529/ introduced a plugin jquery.miniColors which uses that). That plugin has been updated a lot since 2011, but it's still using the old verison. Might wanna hot-patch or see if it can be updated to a newer upstream version as in 1.25, jQuery will be upgraded finally. [03:19:30] RoanKattouw: thanks for taking a look! :) [03:42:01] (03PS12) 10Mattflaschen: J-2a.II Current topic title in affixed board nav [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169531 (owner: 10SG) [03:43:29] (03CR) 10Mattflaschen: [C: 031] "Backported orderedTopicIds from Shahyar's main patch ("Implement TOC on front-end") to solve that. This is good to merge." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169531 (owner: 10SG) [03:50:11] 3Fundraising: Donation banner showing up for logged-in users - https://phabricator.wikimedia.org/T75812#783339 (10MZMcBride) I looked at https://meta.wikimedia.org/wiki/Special:CentralNoticeLogs and ... yeah, I don't know why the donation banner was showing to me and others. It seemed to go off a few minutes aft... [03:52:19] (03PS7) 10Mattflaschen: Add component to api callback info object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170997 (owner: 10SG) [03:53:10] (03CR) 10jenkins-bot: [V: 04-1] Add component to api callback info object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170997 (owner: 10SG) [03:57:10] (03PS7) 10Jforrester: [wip] Eventify the TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/157174 (owner: 10Mooeypoo) [03:57:18] (03CR) 10Jforrester: "ping" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/157174 (owner: 10Mooeypoo) [03:57:20] 3Fundraising: Donation banner showing up for logged-in users - https://phabricator.wikimedia.org/T75812#783340 (10MZMcBride) >>! In T75812#783287, @awight wrote: > We filter out the Special: namespace, but the others are currently fair game. I'd be interested in any arguments for filtering down to only the arti... [03:59:48] 3Wikimedia-SSL-related: replace SHA1 certificates with SHA256 - https://phabricator.wikimedia.org/T73156#783341 (10Chmarkine) [04:03:27] 3Wikimedia-SSL-related: replace SHA1 certificates with SHA256 - https://phabricator.wikimedia.org/T73156#783342 (10Chmarkine) [04:04:57] /join #wikimedia-operations [04:05:12] err [04:14:09] 3MediaWiki-Parser: {{fullurl:}} does not resolve to commons.m.wikimedia.org but to commons.wikimedia.org - https://phabricator.wikimedia.org/T52399#783343 (10Mattflaschen) >>! In T52399#548203, @kaldari wrote: > Expected result: > You get the mobile editing interface. > > Actual result: > You get the desktop ed... [04:17:37] 3Fundraising: Donation banner showing up for logged-in users - https://phabricator.wikimedia.org/T75812#783347 (10AndyRussG) Confirmed that banners were being shown to logged-in users due to a bug in the new system for choosing banners on the client. The new system was switched off by Adam's patch (above), so th... [04:17:53] 3MediaWiki-Parser: {{fullurl:}} does not resolve to commons.m.wikimedia.org but to commons.wikimedia.org - https://phabricator.wikimedia.org/T52399#783348 (10Mattflaschen) [04:18:22] 3MediaWiki-Parser: {{fullurl:}} does not resolve to commons.m.wikimedia.org but to commons.wikimedia.org - https://phabricator.wikimedia.org/T52399#548138 (10Mattflaschen) [04:31:19] Understand performance & monitor to current capacity- set up tests to identify performance bottleneck (alarm for no writes) - https://phabricator.wikimedia.org/T75825 (10ggellerman) 3NEW p:3Triage [04:31:33] (03PS17) 10Mooeypoo: Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 [04:36:15] (03CR) 10jenkins-bot: [V: 04-1] Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo) [04:37:33] 3MediaWiki-extensions-UniversalLanguageSelector: Middle click with - https://phabricator.wikimedia.org/T43988#783386 (10santhosh) a:5santhosh>3None [04:38:19] 3MediaWiki-User-login-and-signup: Cannot create a username containing a Zero width joiner on languages where a ZWJ makes a visible difference and is required - https://phabricator.wikimedia.org/T26999#783395 (10santhosh) a:5santhosh>3None [04:38:23] (03CR) 10MZMcBride: ""The composer.json file has been renamed to composer.json.sample after Jamie Thingelstad reported that his composer.json was overwritten b" [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/175453 (owner: 10MarkAHershberger) [04:42:49] 3Language-Engineering, Scrum-of-Scrums: Common Database for Content Translation in Beta - https://phabricator.wikimedia.org/T1254#783411 (10Springle) [04:49:02] 3MediaWiki-Core-Team: SHA-1 file name support - https://phabricator.wikimedia.org/T1210#783413 (10Revi) [05:02:00] (03CR) 10EBernhardson: "it looks like the test failure in api view topic list test starts here. Basically defaulted parameters end up in the api output so the tes" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170998 (owner: 10SG) [05:06:54] Redirect Bugzilla enter_bug.cgi to https://phabricator.wikimedia.org/home/create/ - https://phabricator.wikimedia.org/T75832 (10Mattflaschen) 3NEW p:3Triage [05:08:15] 3MediaWiki-extensions-GWToolset, Multimedia: Updating broken 'request' link at GWToolset - https://phabricator.wikimedia.org/T75732#778115 (10Mattflaschen) [05:13:03] (03CR) 10Mattflaschen: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170997 (owner: 10SG) [05:18:13] 3MediaWiki-extensions-Flow: Flow: Off-by-one timestamp failures in tests - https://phabricator.wikimedia.org/T75833#783427 (10Mattflaschen) [05:18:55] 3MediaWiki-extensions-Flow: Flow: Off-by-one timestamp failures in tests - https://phabricator.wikimedia.org/T75833#783427 (10Mattflaschen) [05:20:46] (03PS4) 10Santhosh: WIP MT: Subsequence extraction and mapping algorithm implementation [services/cxserver] - 10https://gerrit.wikimedia.org/r/175420 [05:29:00] (03CR) 10Mattflaschen: Bug: UID generator counter overflow (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174830 (https://bugzilla.wikimedia.org/73638) (owner: 10EBernhardson) [05:32:20] (03PS1) 10Mooeypoo: Correct placement of tags [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/175661 [05:35:45] 3ArchCom, MW-RFCs: RFC: Extensions continuous integration - https://phabricator.wikimedia.org/T1350#783436 (10tstarling) The meeting is on Wednesday November 26, 21:00 UTC [05:38:57] 3MediaWiki-API, MediaWiki-Core-Team: API: adrprefix gives invalid title error for valid titles - https://phabricator.wikimedia.org/T75711#783440 (10Mattflaschen) [05:40:49] 3Wikimedia-Bugzilla: "Fixes-Bug" keyword in Git commit message that will cause a bug report to automatically be marked FIXED in Bugzilla - https://phabricator.wikimedia.org/T55387#783443 (10Mattflaschen) 5declined>3Open In my opinion, it is still valid. As of now, the Gerrit bot basically works the same. I... [05:41:18] 3Wikimedia-Bugzilla: "Fixes-Bug" keyword in Git commit message that will cause a bug report to automatically be marked Resolved in Maniphest - https://phabricator.wikimedia.org/T55387#783445 (10Mattflaschen) [06:03:55] 3Wikimedia-Bugzilla: Find a way to mark a report as "needinfo" - https://phabricator.wikimedia.org/T38064#783458 (10scfc) >>! In T38064#777589, @Qgil wrote: > You can explain that in the task description and/or the last comment. What is Phabricator's syntax for that? Also, if someone adds another comment, will... [06:06:59] (03PS18) 10Mooeypoo: Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 [06:08:10] (03CR) 10jenkins-bot: [V: 04-1] Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo) [06:47:58] (03PS1) 10EBernhardson: Match workflow last updated to the created revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/175664 [06:49:07] (03CR) 10jenkins-bot: [V: 04-1] Match workflow last updated to the created revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/175664 (owner: 10EBernhardson) [06:52:09] (03PS2) 10EBernhardson: Match workflow last updated to the created revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/175664 [06:53:27] (03PS1) 10EBernhardson: Use revision timestamp instead of wfTimestampNow() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/175665 [06:55:51] 3MediaWiki-extensions-Flow: Flow: Off-by-one timestamp failures in tests - https://phabricator.wikimedia.org/T75833#783480 (10EBernhardson) [06:57:29] (03PS19) 10Mooeypoo: Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 [06:58:12] (03CR) 10jenkins-bot: [V: 04-1] Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo) [06:58:22] 3Wikimedia-Bugzilla: Find a way to mark a report as "needinfo" - https://phabricator.wikimedia.org/T38064#783481 (10Qgil) 5declined>3stalled No syntax, human language. A task is staled; the description (or at least the last comment) should explain why. If the problem is that a user needs to provide informat... [06:58:30] 3Wikimedia-Bugzilla: Find a way to mark a report as "needinfo" - https://phabricator.wikimedia.org/T38064#783483 (10Qgil) [06:59:08] 3Wikimedia-Bugzilla: Find a way to mark a report as "needinfo" - https://phabricator.wikimedia.org/T38064#783484 (10Qgil) 5stalled>3declined Yep, it works. [07:04:20] Setup per-instance configurability for labs in hiera - https://phabricator.wikimedia.org/T1356#783491 (10yuvipanda) so.. Hiera:/hosts.yaml, perhaps? Contains things in the format of: ```: key1: value1 key2: value2 : key1: value1 key2: valu... [07:05:54] Setup per-instance configurability for labs in hiera - https://phabricator.wikimedia.org/T1356#783492 (10yuvipanda) [07:16:40] (03CR) 10Nikerabbit: [C: 04-1] "On quick look I don't see inheritance as the best way to reuse code here. This is very clear in the case of Yandex where it does not need " [services/cxserver] - 10https://gerrit.wikimedia.org/r/175398 (owner: 10Santhosh) [07:18:30] (03CR) 10Santhosh: "Niklas, in the follow up patch, I will see how I am going to use this pattern for achieving the annotation mapping algorithm. Working on i" [services/cxserver] - 10https://gerrit.wikimedia.org/r/175398 (owner: 10Santhosh) [07:18:52] (03CR) 10Santhosh: "I will see -> I will show" [services/cxserver] - 10https://gerrit.wikimedia.org/r/175398 (owner: 10Santhosh) [07:20:13] (03PS1) 10Nemo bis: Revert "mediawiki.api: Use action=query&meta=tokens instead of action=tokens" [core] - 10https://gerrit.wikimedia.org/r/175667 [07:22:34] (03PS2) 10Nemo bis: Revert "mediawiki.api: Use action=query&meta=tokens instead of action=tokens" [core] - 10https://gerrit.wikimedia.org/r/175667 [07:43:48] 3MediaWiki-extensions-GlobalUserPage: userpage tab is red, when seen at usertalkpage - https://phabricator.wikimedia.org/T75840 (10Quiddity) 3NEW p:3Triage [07:45:58] Epic: Create pipeline EL -> DW -> Pentaho - https://phabricator.wikimedia.org/T75841 (10kevinator) 3NEW p:3Triage [07:51:49] "Reference" should state that additional information may be available on old-bugzilla - https://phabricator.wikimedia.org/T75843 (10Nemo_bis) 3NEW p:3Triage [07:59:18] Search should state (approximate) number of results for a query - https://phabricator.wikimedia.org/T75845#783570 (10Nemo_bis) [08:07:23] 3MediaWiki-General-or-Unknown: Redirect=no post-edit url - https://phabricator.wikimedia.org/T75719#783592 (10fbstj) Since I've set all relevant (?) `$wgActionPath`s the bug is * submitting an edit to a redirect sends me to `/w/index.php?title=$1&redirect=no` where it should send to `/wiki/$1?redirect=no` I al... [08:13:56] (03CR) 10Robert Vogel: [C: 031 V: 031] Added a margin to author pictures [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/174947 (owner: 10Smuggli) [08:13:56] 3Wikimedia-Site-requests: Wikis waiting for creation (tracking) - https://phabricator.wikimedia.org/T18976#783602 (10Glaisher) [08:14:54] (03CR) 10Robert Vogel: [C: 032 V: 032] BsFileSystemHelper: Fixed Fatal [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/174956 (owner: 10Pwirth) [08:17:58] (03PS2) 10Robert Vogel: SPECIAL CODE REVIEW BRANCH/COMMIT [extensions/Teahouse] - 10https://gerrit.wikimedia.org/r/170702 [08:22:28] (03PS3) 10Ori.livneh: Make sql_writer accept a 'replace' parameter [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/175339 (owner: 10QChris) [08:23:37] 3MediaWiki-extensions-TimedMediaHandler, Multimedia: TimedMediaHandler should pass jshint - https://phabricator.wikimedia.org/T63638#783621 (10Gilles) @thedj made that happen in https://gerrit.wikimedia.org/r/#/c/173513/ and previous commits [08:28:15] (03PS7) 10Robert Vogel: [WIP] Implementing CR and community feedback [extensions/Teahouse] - 10https://gerrit.wikimedia.org/r/173014 [08:28:16] Weird redirect on fr.wiktionary - https://phabricator.wikimedia.org/T75849 (10JAnD) 3NEW p:3Triage [08:35:28] 3Wikimedia-General-or-Unknown: Weird redirect on fr.wiktionary - https://phabricator.wikimedia.org/T75849#783639 (10Glaisher) [08:35:35] Phabricator does not recognize wiki markup - https://phabricator.wikimedia.org/T75850#783641 (10JAnD) [08:35:41] 3Wikimedia-General-or-Unknown: Weird redirect on fr.wiktionary - https://phabricator.wikimedia.org/T75849#783647 (10Koavf) Confirmed. It also briefly loads https://fr.wiktionary.org/wiki/Fichier:Wiki.png and *then* redirects to https://fr.wiktionary.org/wiki/undefined for some reason (note that I have HTTPS by d... [08:38:22] 3MediaWiki-extensions-GWToolset, Multimedia: GWToolset should add a change tag to upload log entries, and dummy history edits - https://phabricator.wikimedia.org/T64910#783650 (10Steinsplitter) I see no need to add a tag to GWT uploads, It is possible to use https://commons.wikimedia.org/wiki/Template:Uploaded_w... [08:41:28] (03PS3) 10Robert Vogel: SPECIAL CODE REVIEW BRANCH/COMMIT [extensions/Teahouse] - 10https://gerrit.wikimedia.org/r/170702 [08:44:39] 3MediaWiki-extensions-PdfHandler: Linker::makeImageLink: File: .... .pdf does not allow inline display - https://phabricator.wikimedia.org/T74044#783661 (10FLX90) I thought that too, but I've no errors in my debug.log I also have no error when I type the wfShellExec-Commands on cmd. pdfinfo, pdftotext, convert,.... [09:01:31] (03CR) 10Smuggli: [C: 032 V: 032] Added a margin to author pictures [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/174947 (owner: 10Smuggli) [09:02:33] (03CR) 10Smuggli: [C: 032 V: 032] CSS Fix for ExtJS [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/175403 (owner: 10Robert Vogel) [09:09:04] 3MediaWiki-extensions-Cite: Cite: when using "group=" attribute within "ref" element the space can cause line-break - https://phabricator.wikimedia.org/T21303#783704 (10Bub_s) 5Open>3Resolved a:3Bub_s Hi, It no longer is a problem, at least on french Wikipedia displayed with skin Vector. I just tested an... [09:16:15] 3MediaWiki-extensions-TimedMediaHandler, Multimedia: TimedMediaHandler should pass jshint - https://phabricator.wikimedia.org/T63638#783717 (10TheDJ) [09:19:23] 3Wikimedia-General-or-Unknown: Create an arbcom-cz wiki - https://phabricator.wikimedia.org/T62764#783718 (10Glaisher) Is this still needed? What's the state of this? [09:19:59] 3MediaWiki-extensions-TimedMediaHandler, Multimedia: TimedMediaHandler should pass jshint - https://phabricator.wikimedia.org/T63638#783720 (10Gilles) [09:29:37] 3MediaWiki-Interface: Hide "(Redirected from …)" notice when printing articles - https://phabricator.wikimedia.org/T18296#783727 (10Glaisher) [09:34:58] 3Quality-Assurance: use rspec-expectations expect syntax instead of should syntax - https://phabricator.wikimedia.org/T68369#783756 (10Jagori79) Zeljko:I see the changes already implemented for Visual editor code,should I abandon the part which I was working on :https://gerrit.wikimedia.org/r/#/c/146712/ I had... [09:54:42] 3Wikimedia-Bugzilla: Searching old-bugzilla partially broken due to character encoding - https://phabricator.wikimedia.org/T75848#783792 (10Qgil) [09:54:51] (03PS1) 10Smuggli: Removed installer i18n backward compatibility [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/175669 [09:55:19] 3Wikimedia-Bugzilla: Searching old-bugzilla partially broken due to character encoding - https://phabricator.wikimedia.org/T75848#783613 (10Qgil) [10:00:43] 3MediaWiki-extensions-WikidataClient: Usage Tracking: changes should trigger an appropriate update of pages that use the corresponding aspect of the change item - https://phabricator.wikimedia.org/T73352#783798 (10daniel) [10:06:24] 3MediaWiki-extensions-Gadgets: Require all gadgets to load via ResourceLoader - https://phabricator.wikimedia.org/T75810#783807 (10TheDJ) I'm in favor, but what about disallowing it first for gadgets that are disabled by default ? A ton of gadgets stuff is only used by very few users, in those cases it probably... [10:08:28] 3Multimedia, MediaWiki-File-management: Impossible to move dwg files - https://phabricator.wikimedia.org/T27523#783815 (10Kghbln) >>! In T27523#305340, @Aklapper wrote: > I'm curious if this is still a problem? I just tested moving a .eml file on MW 1.23.6, PHP 5.4 and it is still a problem. The message basical... [10:10:32] 3ArchCom, MW-RFCs: RFC: Extensions continuous integration - https://phabricator.wikimedia.org/T1350#783819 (10Liuxinyu970226) [10:11:11] 3Wikimedia-Bugzilla: Provide phabricator link for current task in old-bugzilla banner - https://phabricator.wikimedia.org/T75839#783825 (10Qgil) [10:12:41] Pywikibot mailing list notification test bug - please ignore; sorry. - https://phabricator.wikimedia.org/T1391#783830 (10Liuxinyu970226) Umm from this task, T1392~T1999 have jumped. [10:14:32] 3MediaWiki-extensions-SyntaxHighlight-(GeSHi): SQL format does not colorize for "ELSEIF" - https://phabricator.wikimedia.org/T74232#783842 (10TheDJ) The upstream pullrequest, still unmerged: https://github.com/GeSHi/geshi-1.0/pull/26 [10:14:57] 3MediaWiki-extensions-ProofreadPage: The WikiEditor dialogs do not work in Page namespace - https://phabricator.wikimedia.org/T74960#783843 (10Xelgen) [10:16:31] 3MediaWiki-extensions-TimedMediaHandler, Multimedia: TimedMediaHandler should pass jshint - https://phabricator.wikimedia.org/T63638#783846 (10hashar) [10:17:34] 3Multimedia, MediaWiki-extensions-MultiUpload: MultiUpload should pass jshint - https://phabricator.wikimedia.org/T73106#783849 (10hashar) [10:17:52] 3Multimedia, MediaWiki-extensions-MultiUpload: MultiUpload should pass jshint - https://phabricator.wikimedia.org/T73106#746575 (10hashar) [10:18:21] 3MediaWiki-extensions-TimedMediaHandler, Multimedia: TimedMediaHandler should pass jshint - https://phabricator.wikimedia.org/T63638#652930 (10hashar) [10:18:33] 3MediaWiki-extensions-ProofreadPage: The WikiEditor dialogs do not work in Page namespace - https://phabricator.wikimedia.org/T74960#783854 (10Xelgen) [10:18:47] 3MediaWiki-extensions-SyntaxHighlight-(GeSHi): SQL format does not colorize for "ELSEIF" - https://phabricator.wikimedia.org/T74232#783857 (10TheDJ) @reedy, should we consider creating a wikimedia/geshi repo with composer support for geshi and pull our version from there ? Stuff still seems to take a bit too lo... [10:19:05] 3Continuous-Integration: All repositories should pass jshint test (tracking) - https://phabricator.wikimedia.org/T62619#783860 (10hashar) [10:19:07] 3MediaWiki-extensions-TimedMediaHandler, Multimedia: TimedMediaHandler should pass jshint - https://phabricator.wikimedia.org/T63638#783858 (10hashar) 5Open>3Resolved TimedMediaHandler now pass jshint and @gilles kindly updated the Zuul configuration to prevent regression (job is voting). Nothing left to be... [10:22:28] 3MediaWiki-extensions-EasyTimeline: Document more clearly the procedure to setup a font for EasyTimeline - https://phabricator.wikimedia.org/T75809#783864 (10Kghbln) To me this extension appears to need some love in general but that's another story. However, I believe to have recently adjusted the installation i... [10:35:06] Shinken on labs send dupe notification for beta cluster - https://phabricator.wikimedia.org/T75859#783883 (10hashar) [10:35:59] (03PS1) 10Christopher Johnson (WMDE): Adds autosum of points for columns in Sprint Board [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/175670 [10:36:04] Shinken on labs send dupe notification for beta cluster - https://phabricator.wikimedia.org/T75859#783890 (10yuvipanda) a:3yuvipanda Yup, shinken-server-01 is just test server. I'll figure out a way to route all email from there to... just me. [10:38:04] 3MediaWiki-extensions-ContactPage: Retag the ContactPage extension for REL1_23 - https://phabricator.wikimedia.org/T1359#783898 (10Reedy) Not a simple cherry pick due to the i18n changes [10:40:16] (03PS2) 10Christopher Johnson (WMDE): Adds autosum of points for columns in Sprint Board [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/175670 [10:42:18] (03PS3) 10Christopher Johnson (WMDE): Adds autosum of points for columns in Sprint Board [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/175670 [10:42:56] 3MediaWiki-extensions-WikidataRepo: Can't use tab while adding sitelinks - https://phabricator.wikimedia.org/T75642#783904 (10Tobi_WMDE_SW) Needs a release of ValueView. [10:43:05] (03CR) 10Christopher Johnson (WMDE): [C: 032 V: 032] Adds autosum of points for columns in Sprint Board [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/175670 (owner: 10Christopher Johnson (WMDE)) [10:44:02] 3MediaWiki-extensions-ContactPage: Retag the ContactPage extension for REL1_23 - https://phabricator.wikimedia.org/T1359#783905 (10Kghbln) Ah, ok. Perhaps this [[ https://git.wikimedia.org/commit/mediawiki%2Fextensions%2FContactPage/ae75785aaa77d9e702ac082af8ac5505b19548f7 | this one is better ]] since it contai... [10:45:02] 3MediaWiki-extensions-WikidataClient: allow accessing data from an item not connected to the current page - arbitrary access (tracking) - https://phabricator.wikimedia.org/T49930#783906 (10Liuxinyu970226) [10:50:25] (03PS1) 10Mglaser: Make allowing site-wide styles on restricted special pages a config option [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/175671 (https://bugzilla.wikimedia.org/71621) [10:50:56] 3MediaWiki-extensions-GWToolset, Multimedia: Creating directory with special characters - https://phabricator.wikimedia.org/T75725#783912 (10JeanFred) [10:52:11] 3MediaWiki-extensions-ContactPage: Retag the ContactPage extension for REL1_23 - https://phabricator.wikimedia.org/T1359#783915 (10Reedy) I was trying to be lazy and just use the cherry pick button in gerrit, which won't work due to the changes. It's doable manually, just a little more work. We could just rebra... [10:56:05] (03CR) 10Mglaser: [C: 032 V: 032] Make allowing site-wide styles on restricted special pages a config option [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/174014 (https://bugzilla.wikimedia.org/71621) (owner: 10Legoktm) [10:59:51] 3MediaWiki-extensions-ContactPage: Retag the ContactPage extension for REL1_23 - https://phabricator.wikimedia.org/T1359#783921 (10Kghbln) Whatever is easier ... Besides, great profile picture. Waffles-picking I believe ;) [11:00:26] Shinken hostname column is not large enough - https://phabricator.wikimedia.org/T1362#783922 (10hashar) Maybe they have some support to inject a CSS or create a custom skin? [11:01:01] (03CR) 10Mglaser: [C: 032 V: 032] Make allowing site-wide styles on restricted special pages a config option [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/174018 (https://bugzilla.wikimedia.org/71621) (owner: 10Legoktm) [11:03:37] 3Release-Engineering, MediaWiki-Core-Team: Make sure scap rsync proxies aren't in jobrunner pool - https://phabricator.wikimedia.org/T1342#783927 (10Reedy) It's something that @bd808 has mentioned a few times, based on the logs, stuff using the job runners take longer IIRC. This can be then exacerbated by many... [11:04:13] 3Wikimedia-General-or-Unknown: Update Solr for Translate to 3.6.2 - https://phabricator.wikimedia.org/T51245#783929 (10faidon) [11:04:54] 3Wikimedia-OTRS: OTRS password request abuse (implement CAPTCHA?) - https://phabricator.wikimedia.org/T23579#783934 (10Rjd0060) [11:05:20] 3MediaWiki-extensions-UploadWizard, Multimedia: Campaigns API call is very, very slow - https://phabricator.wikimedia.org/T56465#783936 (10yuvipanda) a:5yuvipanda>3None Nope, not anymore, sorry. Cluster didn't melt, ops didn't scream, so I presumed it was ok. [11:09:08] 3MediaWiki-File-management: disable SVG rasterizing - https://phabricator.wikimedia.org/T43771#783938 (10fbstj) [11:19:44] (03PS1) 10Robert Vogel: Added compatibility with non-BsBaseTemplate skins [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/175674 [11:21:08] (03CR) 10Werdna: [C: 031] "Two minor points, otherwise good to go." (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174354 (owner: 10EBernhardson) [11:24:21] 3Language-Engineering, Scrum-of-Scrums: Common Database for Content Translation in Beta - https://phabricator.wikimedia.org/T1254#783948 (10Reedy) wikishared was created for BounceHandler (primarily) in https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/CommonSettings.php#L2206-L2215... [11:24:22] (03PS1) 10Robert Vogel: Removed some BsBaseTemplate switches [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/175675 [11:25:18] Shinken on labs send dupe notification for beta cluster - https://phabricator.wikimedia.org/T75859#783949 (10yuvipanda) 5Open>3Resolved !log shinken made /usr/bin/mail a small script that just logs to /data/project/shinken-server-01.email on shinken-server-01 So I can still easily inspect it, without having t... [11:26:39] (03CR) 10Werdna: [C: 032] Bug: Import is not updating lastEditId [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174580 (owner: 10EBernhardson) [11:27:31] (03Merged) 10jenkins-bot: Bug: Import is not updating lastEditId [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174580 (owner: 10EBernhardson) [11:28:37] (03CR) 10Werdna: [C: 032] OccupationController should consider Title::getContentType [extensions/Flow] - 10https://gerrit.wikimedia.org/r/175574 (owner: 10EBernhardson) [11:29:31] (03Merged) 10jenkins-bot: OccupationController should consider Title::getContentType [extensions/Flow] - 10https://gerrit.wikimedia.org/r/175574 (owner: 10EBernhardson) [11:30:29] Setup per-instance configurability for labs in hiera - https://phabricator.wikimedia.org/T1356#783952 (10yuvipanda) [11:31:00] 3MediaWiki-extensions-WikiEditor: Convert ext.wikiEditor.tests.toolbar to QUnit - https://phabricator.wikimedia.org/T39485#783953 (10happy5214) [11:32:54] (03PS1) 10Christopher Johnson (WMDE): new SprintBoardTaskEdit Controller [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/175677 [11:34:35] (03CR) 10Christopher Johnson (WMDE): [C: 032 V: 032] new SprintBoardTaskEdit Controller [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/175677 (owner: 10Christopher Johnson (WMDE)) [11:39:54] (03CR) 10Werdna: Implement full wiki lqt conversion (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174354 (owner: 10EBernhardson) [11:40:15] (03PS13) 10Werdna: Implement full wiki lqt conversion [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174354 (owner: 10EBernhardson) [11:40:21] (03PS5) 10Thiemo Mättig (WMDE): Better article link detection [extensions/Popups] - 10https://gerrit.wikimedia.org/r/146477 (https://bugzilla.wikimedia.org/68039) (owner: 10Se4598) [11:40:27] (03PS11) 10Werdna: Archive and takeover namespaces with Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174861 (owner: 10EBernhardson) [11:40:40] (03CR) 10jenkins-bot: [V: 04-1] Archive and takeover namespaces with Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174861 (owner: 10EBernhardson) [11:41:50] (03CR) 10Werdna: [C: 031] "I made changes so needs approval from someone else." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174354 (owner: 10EBernhardson) [11:42:15] (03CR) 10Thiemo Mättig (WMDE): "Turns out I had an unsubmitted fix for this patch in my stash. Here it is. Please note that I did NOT tested this extensively." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/146477 (https://bugzilla.wikimedia.org/68039) (owner: 10Se4598) [11:43:53] (03PS5) 10Santhosh: WIP MT: Subsequence extraction and mapping algorithm implementation [services/cxserver] - 10https://gerrit.wikimedia.org/r/175420 [11:46:07] legoktm: Nice work on SkinDistributor :) [11:49:35] (03CR) 10Thiemo Mättig (WMDE): mediawiki.action.view.dblClickEdit: Do not call click on undefined (032 comments) [core] - 10https://gerrit.wikimedia.org/r/174679 (https://bugzilla.wikimedia.org/57713) (owner: 10Thiemo Mättig (WMDE)) [11:51:17] (03PS12) 10Werdna: Archive and takeover namespaces with Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174861 (owner: 10EBernhardson) [11:51:20] (03PS14) 10Werdna: Implement full wiki lqt conversion [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174354 (owner: 10EBernhardson) [11:53:56] 3MediaWiki-MediaWiki-UI: LiquidThreads' fork of getNavigationBar should not use obsolete HTML attributes (align, cellpadding and valign) - https://phabricator.wikimedia.org/T75860#783959 (10He7d3r) [11:55:26] 3MediaWiki-extensions-LiquidThreads, MediaWiki-MediaWiki-UI: LiquidThreads' fork of getNavigationBar should not use obsolete HTML attributes (align, cellpadding and valign) - https://phabricator.wikimedia.org/T75860#783959 (10He7d3r) [11:56:48] 3MediaWiki-extensions-WikidataRepo: cannot save badges on Q183 (Germany) - https://phabricator.wikimedia.org/T72716#783975 (10JanZerebecki) [12:00:26] 3Wikimedia-General-or-Unknown: Add Wikispecies to the Parsoid cluster - https://phabricator.wikimedia.org/T62052#783978 (10Kelson) Here a new request about this: https://sourceforge.net/p/kiwix/feature-requests/858/ Would be really nice if someone might take a few minutes to configure the Parsoid cluster for this. [12:05:34] 3MediaWiki-JavaScript: Implement a front-end for interacting with resourceLoaderDebug cookie - https://phabricator.wikimedia.org/T37063#783979 (10He7d3r) See also: https://github.com/he7d3r/mw-gadget-DebugModeToggle [12:05:51] Identify features Scrumbugz users would miss in Phabricator - https://phabricator.wikimedia.org/T132#783981 (10Wikidata-bugs) [12:08:04] 3MediaWiki-Search: Search "טריפלקס" in the Hebrew Wikipedia doesn't find an article with the word "וטריפלקס" - https://phabricator.wikimedia.org/T75862 (10Amire80) 3NEW p:3Triage [12:14:10]