[00:01:15] (03PS7) 10Gerrit Patch Uploader: Implement namespace inversion on WhatLinksHere [core] - 10https://gerrit.wikimedia.org/r/129933 (https://bugzilla.wikimedia.org/16848) [00:01:17] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/129933 (https://bugzilla.wikimedia.org/16848) (owner: 10Gerrit Patch Uploader) [00:01:22] 3Wikimedia / 3Extension setup: Review and deploy GlobalUserPage extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/70576#c12 (10MZMcBride) (In reply to James Forrester from comment #11) > I'm sorry, I missed the part where you are the responsible party for making > sure community leaders like ar... [00:01:36] (03CR) 10Mattflaschen: "Okay, this patch shouldn't be merged unless you can identify somewhere less.js is used (AFAICT it is not used)." [core] - 10https://gerrit.wikimedia.org/r/173845 (owner: 10Paladox) [00:05:51] 3MediaWiki / 3File management: Download this file link on description page (particularly relevant to svg) - 10https://bugzilla.wikimedia.org/25148#c3 (10Tisza Gergő) bug 25695 added a download URL, so the only thing needed is to expose that URL in a link. Marking as easy. [00:06:35] 3Wikimedia / 3Extension setup: Review and deploy GlobalUserPage extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/70576#c13 (10Krinkle) (In reply to Kunal Mehta (Legoktm) from comment #0) > If a local user page does not exist, and the user has a global account > attached on the local wiki and t... [00:10:36] 3MediaWiki / 3File management: File description page thumbnail click versus EXIF rotation, mustRender() - 10https://bugzilla.wikimedia.org/31366#c9 (10Tisza Gergő) 5PATC>3NEW This could be solved by linking to a full-size thumbnail instead of the original file if mustRender() is true. See bug 65383 for a... [00:10:36] 3MediaWiki / 3File management: Serve thumbnails even for the original size of a jpeg or png - 10https://bugzilla.wikimedia.org/65383 (10Tisza Gergő) [00:11:09] (03PS1) 10Krinkle: Omit 'window.' when accessing browsing location [core] - 10https://gerrit.wikimedia.org/r/174321 [00:13:53] (03PS2) 10Krinkle: Omit 'window.' when accessing browsing location [core] - 10https://gerrit.wikimedia.org/r/174321 [00:16:08] 3dev.wikimedia.org: Possibility to pair API documentation with user comments - https://phabricator.wikimedia.org/T322#23301 (10Wmat) >>! In T322#3826, @flimport wrote: > **qgil** wrote on `2014-07-31 21:45:25 (UTC)` > > At T491#11 I'm proposing to find a way to publish API docs in MediaWiki pages, which would a... [00:22:09] (03PS1) 10TheDJ: Support WebM Vorbis files in the player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/174325 (https://bugzilla.wikimedia.org/72996) [00:24:08] Krinkle: https://gerrit.wikimedia.org/r/#/c/129933/7/includes/specials/SpecialWhatlinkshere.php [00:25:31] huh: looks good at first glance [00:28:31] (03PS1) 10QChris: Revert "Fix for multi-row INSERT capability test" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/174328 [00:28:33] (03PS1) 10QChris: Revert "Batch event insertion" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/174329 [00:34:20] (03PS2) 10TheDJ: Make sure jquery.ui.dialog is loaded if there are pop up videos [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108472 (https://bugzilla.wikimedia.org/72437) (owner: 10Brian Wolff) [00:34:23] (03CR) 10jenkins-bot: [V: 04-1] Make sure jquery.ui.dialog is loaded if there are pop up videos [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108472 (https://bugzilla.wikimedia.org/72437) (owner: 10Brian Wolff) [00:35:32] 3dev.wikimedia.org: Future of the current Developer Hub at mediawiki.org - https://phabricator.wikimedia.org/T313#23311 (10Wmat) What's in a name, right? Clear, concise, relevant and up to date documentation will make or break this hub regardless of its name. In particular, I'd like to see the examples of inte... [00:37:39] 3MediaWiki / 3MediaWiki UI: Active neutral buttons are ugly - yellow text on grey background - 10https://bugzilla.wikimedia.org/73587 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None Created attachment 17167 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17167&action=edit screenshot See the... [00:41:26] (03PS1) 10Ori.livneh: Avoid file glob in SyntaxHighlight_GeSHi::getSupportedLanguages() [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/174332 [00:43:14] (03Abandoned) 10QChris: Revert "Fix for multi-row INSERT capability test" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/174328 (owner: 10QChris) [00:43:23] (03Abandoned) 10QChris: Revert "Batch event insertion" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/174329 (owner: 10QChris) [00:46:39] (03PS2) 10Ori.livneh: Avoid file glob in SyntaxHighlight_GeSHi::getSupportedLanguages() [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/174332 [00:50:07] 3MediaWiki extensions / 3SecurePoll: Secure Poll Error - 10https://bugzilla.wikimedia.org/73588 (10Mike V) 3UNCO p:3Unprio s:3normal a:3None When trying to vote through the poll listed below, clicking on the "Go to voting server" gives the following error: "Error fetching your account information fro... [00:51:00] (03CR) 10Legoktm: [C: 04-1] Avoid file glob in SyntaxHighlight_GeSHi::getSupportedLanguages() (032 comments) [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/174332 (owner: 10Ori.livneh) [00:51:15] (03PS3) 10Legoktm: Avoid file glob in SyntaxHighlight_GeSHi::getSupportedLanguages() [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/174332 (owner: 10Ori.livneh) [00:51:32] (03PS1) 10TheDJ: Add audio/webm to Special:TimedMediaHandler [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/174333 [00:52:38] legoktm: thanks! [00:52:52] (03CR) 10Ori.livneh: [C: 031] Avoid file glob in SyntaxHighlight_GeSHi::getSupportedLanguages() [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/174332 (owner: 10Ori.livneh) [00:53:08] (03CR) 10Legoktm: [C: 032] Avoid file glob in SyntaxHighlight_GeSHi::getSupportedLanguages() [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/174332 (owner: 10Ori.livneh) [00:53:11] (03Merged) 10jenkins-bot: Avoid file glob in SyntaxHighlight_GeSHi::getSupportedLanguages() [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/174332 (owner: 10Ori.livneh) [00:53:36] 3MediaWiki extensions / 3SecurePoll: Secure Poll Error - 10https://bugzilla.wikimedia.org/73588#c1 (10James Alexander) 5UNCO>3NEW verified both on that election and on enWiki 392 (a newly set up election to ensure this wasn't just a bug from the issue last night that was already patch). Copying in Dan a... [00:56:56] (03PS1) 10Ori.livneh: Avoid file glob in SyntaxHighlight_GeSHi::getSupportedLanguages() [extensions/SyntaxHighlight_GeSHi] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174334 [01:01:16] (03CR) 10Ori.livneh: [C: 032] Avoid file glob in SyntaxHighlight_GeSHi::getSupportedLanguages() [extensions/SyntaxHighlight_GeSHi] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174334 (owner: 10Ori.livneh) [01:01:19] (03Merged) 10jenkins-bot: Avoid file glob in SyntaxHighlight_GeSHi::getSupportedLanguages() [extensions/SyntaxHighlight_GeSHi] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174334 (owner: 10Ori.livneh) [01:04:44] (03PS1) 10Ori.livneh: Avoid file glob in SyntaxHighlight_GeSHi::getSupportedLanguages() [extensions/SyntaxHighlight_GeSHi] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/174336 [01:05:02] (03CR) 10Ori.livneh: [C: 032] Avoid file glob in SyntaxHighlight_GeSHi::getSupportedLanguages() [extensions/SyntaxHighlight_GeSHi] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/174336 (owner: 10Ori.livneh) [01:05:05] (03Merged) 10jenkins-bot: Avoid file glob in SyntaxHighlight_GeSHi::getSupportedLanguages() [extensions/SyntaxHighlight_GeSHi] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/174336 (owner: 10Ori.livneh) [01:06:24] (03PS1) 10Ori.livneh: Update SyntaxHighlight_GeSHi for cherry-picks [core] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/174337 [01:06:37] (03PS1) 10Ori.livneh: Update SyntaxHighlight_GeSHi for cherry-picks [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174338 [01:06:55] (03CR) 10Ori.livneh: [C: 032] Update SyntaxHighlight_GeSHi for cherry-picks [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174338 (owner: 10Ori.livneh) [01:07:32] (03PS1) 10Spage: Fix jenkins CI complaining of comments in Gemfile [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174339 [01:09:04] (03CR) 10Ori.livneh: [C: 032] Update SyntaxHighlight_GeSHi for cherry-picks [core] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/174337 (owner: 10Ori.livneh) [01:12:54] (03Merged) 10jenkins-bot: Update SyntaxHighlight_GeSHi for cherry-picks [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174338 (owner: 10Ori.livneh) [01:14:32] (03Merged) 10jenkins-bot: Update SyntaxHighlight_GeSHi for cherry-picks [core] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/174337 (owner: 10Ori.livneh) [01:22:33] (03CR) 10PleaseStand: "See bug 51576." [core] - 10https://gerrit.wikimedia.org/r/174298 (owner: 10Chad) [01:37:01] (03CR) 10Nuria: "Right, actually we do not need to revert cause this code was not intended for prod. It was intended for beta-labs." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/174329 (owner: 10QChris) [01:37:06] 3MediaWiki / 3General/Unknown: ApiFormatWddxTest::testValidSyntax fails in mediawiki-core-regression-hhvm-master test - 10https://bugzilla.wikimedia.org/73531#c2 (10Tim Landscheidt) This is an error in hhvm's WDDX serialization. A test script: | (03CR) 10Mattflaschen: [C: 032] Fix jenkins CI complaining of comments in Gemfile [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174339 (owner: 10Spage) [01:38:13] (03Merged) 10jenkins-bot: Fix jenkins CI complaining of comments in Gemfile [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174339 (owner: 10Spage) [01:52:43] (03Abandoned) 10Krinkle: [WIP] Clean up samples [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163962 (owner: 10Krinkle) [01:54:02] (03PS1) 10Nuria: Removing override of run method of thread class [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/174347 [01:54:22] Krinkle: shahyar picked up all your fixes in a code refactor. That's in the midst of a stack of patches, but we'll get there. [01:54:39] spagewmf: Sure, hence I'm closing this one. [01:54:56] spagewmf: Though from what I could see it only took 1 or 2 of the dozens of things I pointed out. [01:55:27] (03CR) 10jenkins-bot: [V: 04-1] Removing override of run method of thread class [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/174347 (owner: 10Nuria) [01:55:32] Krinkle: thx. Hmm, I checked and a revised patch picked up more. [01:55:55] ok :) [01:56:06] Krinkle: re: this stuff, do you still not want us to have a Gruntfile until npm test passes? I'd like to unpack that patch from the refactor [01:56:32] s/npm test/grunt test/, I think 8-) [01:57:01] Add it in steps if you must. Merge commits that add passing tests. [01:57:42] starting small with most stuff disabled, and you could have pending commits in gerrit that re-enable more and you can amend those until it passes. [01:57:59] There's only a small number of violations, should be trivial to do in a single commit that adds the test and fixes the issues [01:58:10] or fix the issues in a commmit first and then add the test if you prefer. [02:00:19] (03CR) 10Gergő Tisza: [C: 032] Don't re-apply EXIF rotation to chained thumbnails [core] - 10https://gerrit.wikimedia.org/r/172969 (https://bugzilla.wikimedia.org/67525) (owner: 10Gilles) [02:02:22] (03PS19) 10Spage: build: Implement Grunt workflow (via npm test) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163908 [02:02:32] (03PS2) 10Nuria: Removing override of run method on PeriodicThread [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/174347 [02:06:02] (03Merged) 10jenkins-bot: Don't re-apply EXIF rotation to chained thumbnails [core] - 10https://gerrit.wikimedia.org/r/172969 (https://bugzilla.wikimedia.org/67525) (owner: 10Gilles) [02:10:14] (03CR) 10Nuria: "Code (ahem) "deployed" on beta labs and working fine thus far." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/174347 (owner: 10Nuria) [02:17:35] 3MediaWiki / 3Export/Import: Special:Import increases NUMBEROFARTICLES for each Revision instead of each Article - 10https://bugzilla.wikimedia.org/40009#c38 (10This, that and the other (TTO)) The problem seems to be around here [1]: the database is being queried for page links, to determine whether the page... [02:34:40] (03PS1) 10Spage: build: Implement Grunt workflow (via npm test) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174352 [02:38:52] (03CR) 10Spage: "This is gerrit 163908 (change I2400db1319) pulled out of the TOC stack of patches, with jscs not run by default." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174352 (owner: 10Spage) [02:43:35] 3MediaWiki extensions / 3SecurePoll: Secure Poll Error - 10https://bugzilla.wikimedia.org/73588#c2 (10James Alexander) Just a note that I tried this on a testWiki poll too (where I know polls worked earlier) with just basic voter requirements (to ensure that it wasn't because of the voter list) and got the s... [02:44:49] (03CR) 10Spage: "`npm test` passes for me." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163908 (owner: 10Spage) [02:45:56] (03PS1) 10EBernhardson: Rename ConvertLqt to ConvertLqtPage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174353 [02:45:59] (03PS1) 10EBernhardson: Implement full wiki lqt conversion [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174354 [02:57:41] 3MediaWiki / 3General/Unknown: Tracking bug (tracking) - 10https://bugzilla.wikimedia.org/2007 (10James Forrester) [03:01:18] (03PS3) 10Krinkle: exception: Prefix error type in front of error message [core] - 10https://gerrit.wikimedia.org/r/173660 [03:03:24] (03CR) 10Krinkle: build: Implement Grunt workflow (via npm test) (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174352 (owner: 10Spage) [03:08:02] ori: https://gerrit.wikimedia.org/r/#/c/171497/ [03:08:20] ori: And the VE change is https://gerrit.wikimedia.org/r/#/c/171499/ [03:08:42] (03CR) 10Ori.livneh: [C: 032] Fix JS error when no data is passed to an event [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/171437 (owner: 10Catrope) [03:09:01] (03Merged) 10jenkins-bot: Fix JS error when no data is passed to an event [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/171437 (owner: 10Catrope) [03:09:30] (03PS2) 10Ori.livneh: Add schema.Edit [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/171497 (owner: 10Catrope) [03:09:35] (03CR) 10Ori.livneh: [C: 032] Add schema.Edit [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/171497 (owner: 10Catrope) [03:09:46] (03Merged) 10jenkins-bot: Add schema.Edit [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/171497 (owner: 10Catrope) [03:11:53] 3Wikimedia / 3General/Unknown: Trying to log in slows the site, eventually stops loading - 10https://bugzilla.wikimedia.org/73594 (10Ian.thomson) 3UNCO p:3Unprio s:3normal a:3None For some reason, I cannot log into Wikipedia through AT&T, and any system that I attempt to log into starts loading Wikip... [03:25:21] 3Wikimedia / 3General/Unknown: Trying to log in slows the site, eventually stops loading - 10https://bugzilla.wikimedia.org/73594 (10Ian.thomson) s:5normal>3major [03:25:36] (03PS4) 10Gerrit Patch Uploader: Make logging of IPs for account creations optional, default disabled [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/138745 (https://bugzilla.wikimedia.org/21206) [03:25:38] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/138745 (https://bugzilla.wikimedia.org/21206) (owner: 10Gerrit Patch Uploader) [03:28:09] (03PS2) 10Krinkle: mediawiki.skinning: Use mw-body-content instead of mw-body where appropriate [core] - 10https://gerrit.wikimedia.org/r/158854 [03:32:37] (03PS1) 10Tim Starling: Fix vim folding [core] - 10https://gerrit.wikimedia.org/r/174361 [03:36:54] 3MediaWiki / 3MediaWiki UI: Active neutral buttons are ugly - yellow text on grey background - 10https://bugzilla.wikimedia.org/73587#c1 (10Matthew Flaschen) Note, this is inheriting from a general a:active rule, so that will have to be overridden. [03:37:37] 3MediaWiki / 3MediaWiki UI: Active neutral element buttons are ugly - yellow text on grey background - 10https://bugzilla.wikimedia.org/73587 (10Matthew Flaschen) [03:44:53] (03Abandoned) 10Krinkle: Improve OCR layer filtering [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/135546 (owner: 10Krinkle) [03:46:54] (03CR) 10Jackmcbarn: [C: 04-1] Make logging of IPs for account creations optional, default disabled (032 comments) [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/138745 (https://bugzilla.wikimedia.org/21206) (owner: 10Gerrit Patch Uploader) [03:48:04] (03CR) 10Jforrester: [C: 032] Implement new "maps" property in Root [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167389 (owner: 10Mvolz) [03:48:45] (03Merged) 10jenkins-bot: Implement new "maps" property in Root [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167389 (owner: 10Mvolz) [03:50:16] (03CR) 10PiRSquared17: Make logging of IPs for account creations optional, default disabled (032 comments) [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/138745 (https://bugzilla.wikimedia.org/21206) (owner: 10Gerrit Patch Uploader) [03:50:23] (03CR) 10Aaron Schulz: [C: 032] Follow-up to I05aacd30b: normalize case in User::idFromName [core] - 10https://gerrit.wikimedia.org/r/174304 (owner: 10Ori.livneh) [03:50:25] (03CR) 10Jforrester: [C: 031] doc: Clean up Doxyfile for doxygen 1.8.6 [core] - 10https://gerrit.wikimedia.org/r/173502 (owner: 10Krinkle) [03:50:28] jackmcbarn: [03:50:34] huh: ? [03:50:43] replied [03:51:07] (03CR) 10Jforrester: [C: 032] Expose ID of relevant page in JS variables [core] - 10https://gerrit.wikimedia.org/r/169639 (https://bugzilla.wikimedia.org/53774) (owner: 10Alex Monk) [03:51:37] 3MediaWiki / 3JavaScript: mw.config doesn't expose page existence information about the target of a special page - 10https://bugzilla.wikimedia.org/53774 (10James Forrester) 5PATC>3RESO/FIX [03:53:14] (03CR) 10Jackmcbarn: Make logging of IPs for account creations optional, default disabled (032 comments) [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/138745 (https://bugzilla.wikimedia.org/21206) (owner: 10Gerrit Patch Uploader) [03:53:42] (03CR) 10Jforrester: [C: 032] Omit 'window.' when accessing browsing location [core] - 10https://gerrit.wikimedia.org/r/174321 (owner: 10Krinkle) [03:54:05] 3MediaWiki / 3Documentation: Doxygen: Duplicate anchor LICENSE found - 10https://bugzilla.wikimedia.org/70328#c2 (10Bill Traynor) (In reply to Antoine "hashar" Musso (WMF) from comment #1) > Several files define: > > * @section LICENSE > > That causes dupes indeed. The @section should probably be removed... [03:54:19] jackmcbarn: any suggestions for logging without username? [03:54:44] huh: not really; doing so is unprecedented afaik [03:54:50] maybe another reviewer would know [03:55:17] (03CR) 10Aaron Schulz: [C: 04-2] "One tweak" [core] - 10https://gerrit.wikimedia.org/r/174304 (owner: 10Ori.livneh) [03:59:13] (03PS3) 10BryanDavis: Add PHPUnit integration [cdb] - 10https://gerrit.wikimedia.org/r/174080 (https://bugzilla.wikimedia.org/73541) (owner: 10Hashar) [03:59:35] 3MediaWiki extensions / 3OAuth: Provide "authenticate" endpoint for regular users - 10https://bugzilla.wikimedia.org/69232#c3 (10Mukunda Modell) p:5Unprio>3Normal (In reply to Chris Steipp from comment #2) > I forgot to comment on this one, but I'm solidly maybe on this. Silent > redirects make me a lit... [04:01:53] (03Merged) 10jenkins-bot: Expose ID of relevant page in JS variables [core] - 10https://gerrit.wikimedia.org/r/169639 (https://bugzilla.wikimedia.org/53774) (owner: 10Alex Monk) [04:02:00] (03Merged) 10jenkins-bot: Omit 'window.' when accessing browsing location [core] - 10https://gerrit.wikimedia.org/r/174321 (owner: 10Krinkle) [04:02:21] jackmcbarn: would it be possible to somehow integrate it with CU? [04:02:50] huh: yes, with enough code [04:03:42] (03PS2) 10Spage: build: Implement Grunt workflow (via npm test) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174352 [04:04:28] (03CR) 10Spage: "PS2 improves commit message." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174352 (owner: 10Spage) [04:05:48] (03PS2) 10Aaron Schulz: Follow-up to I05aacd30b: normalize case in User::idFromName [core] - 10https://gerrit.wikimedia.org/r/174304 (owner: 10Ori.livneh) [04:06:08] 3Wikimedia / 3Site requests: luri lrc creation - 10https://bugzilla.wikimedia.org/73596 (10mike) 3UNCO p:3Unprio s:3normal a:3None hello luri lrc has been active for 1.5 ago but this wikitest isn't created so far and farsi wikivoyage that has less activity time was created please help us to create th... [04:06:20] (03CR) 10Aaron Schulz: [C: 032] Follow-up to I05aacd30b: normalize case in User::idFromName [core] - 10https://gerrit.wikimedia.org/r/174304 (owner: 10Ori.livneh) [04:12:16] (03Merged) 10jenkins-bot: Follow-up to I05aacd30b: normalize case in User::idFromName [core] - 10https://gerrit.wikimedia.org/r/174304 (owner: 10Ori.livneh) [04:13:09] AaronSchulz: good call! [04:13:29] it wasn't where it should be before, either, but I should have spotted that regardless [04:22:00] (03CR) 10Spage: [C: 032] "I0ec83cd3 removes the tests along with the feature but won't be merged until the TOC replacement is ready. So +2ing this to make tests mor" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164720 (https://bugzilla.wikimedia.org/73451) (owner: 10Spage) [04:22:51] (03Merged) 10jenkins-bot: QA: remove moderated notion from collape tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164720 (https://bugzilla.wikimedia.org/73451) (owner: 10Spage) [04:41:51] 3MediaWiki-Core-Team: Fix PCRE cache - https://phabricator.wikimedia.org/T757#23320 (10tstarling) [04:42:00] 3MediaWiki-Core-Team: Isolate throughput issue on HHVM API action=parse - https://phabricator.wikimedia.org/T758#23321 (10tstarling) [05:01:35] (03CR) 10Parent5446: "I'm going to continue discussion in the security bug, since this bug is only worthwhile in its context." [core] - 10https://gerrit.wikimedia.org/r/65418 (https://bugzilla.wikimedia.org/38417) (owner: 10Parent5446) [05:07:23] (03PS4) 10BryanDavis: Add PHPUnit integration [cdb] - 10https://gerrit.wikimedia.org/r/174080 (https://bugzilla.wikimedia.org/73541) (owner: 10Hashar) [05:10:28] (03PS1) 10Mattflaschen: LQT import: Handle 'revisions' key being absent without Notice [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174368 [05:10:32] (03PS5) 10BryanDavis: Add PHPUnit integration [cdb] - 10https://gerrit.wikimedia.org/r/174080 (https://bugzilla.wikimedia.org/73541) (owner: 10Hashar) [05:12:04] (03Restored) 10Parent5446: Send a cookie with autoblocks to prevent vandalism. [core] - 10https://gerrit.wikimedia.org/r/48029 (https://bugzilla.wikimedia.org/3233) (owner: 10Parent5446) [05:27:52] 3MediaWiki-Core-Team: Remove ProfilerStandard dependency from SectionProfiler - https://phabricator.wikimedia.org/T1326#23322 (10aaron) [05:28:27] 3MediaWiki-Core-Team: Isolate throughput issue on HHVM API action=parse - https://phabricator.wikimedia.org/T758#23324 (10tstarling) [05:29:03] 3MediaWiki-Core-Team: Isolate throughput issue on HHVM API action=parse - https://phabricator.wikimedia.org/T758#12610 (10tstarling) Hacked up a temporary xhprof collector, removed blocker. [05:34:51] (03PS1) 10Physikerwelt: LaTeXML: prevent automatic rerendering of SVG [extensions/Math] (debug) - 10https://gerrit.wikimedia.org/r/174369 [05:35:06] (03CR) 10Physikerwelt: [C: 032] LaTeXML: prevent automatic rerendering of SVG [extensions/Math] (debug) - 10https://gerrit.wikimedia.org/r/174369 (owner: 10Physikerwelt) [05:37:18] (03Merged) 10jenkins-bot: LaTeXML: prevent automatic rerendering of SVG [extensions/Math] (debug) - 10https://gerrit.wikimedia.org/r/174369 (owner: 10Physikerwelt) [05:40:52] (03PS1) 10Physikerwelt: Fix: Treat --hooks parameter in UpdateMath.php correctly [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/174370 [05:40:54] (03CR) 10jenkins-bot: [V: 04-1] Fix: Treat --hooks parameter in UpdateMath.php correctly [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/174370 (owner: 10Physikerwelt) [05:41:26] (03PS2) 10Physikerwelt: Fix: Treat --hooks parameter in UpdateMath.php correctly [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/174370 [05:42:14] (03CR) 10Physikerwelt: [C: 032] Fix: Treat --hooks parameter in UpdateMath.php correctly [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/174370 (owner: 10Physikerwelt) [05:42:23] (03Merged) 10jenkins-bot: Fix: Treat --hooks parameter in UpdateMath.php correctly [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/174370 (owner: 10Physikerwelt) [05:48:31] (03PS1) 10Prtksxna: Make ':after' triangle larger so that the border of div is covered [extensions/Popups] - 10https://gerrit.wikimedia.org/r/174371 (https://bugzilla.wikimedia.org/73550) [05:49:21] 3MediaWiki-Core-Team: Isolate throughput issue on HHVM API action=parse - https://phabricator.wikimedia.org/T758#23327 (10tstarling) * 34% of wall clock time goes to Wikidata's SidebarHookHandlers, which does expensive things (mostly loading the site list) despite there being no sidebar. * 28% goes to MWTidy::ex... [05:51:43] "34% of wall clock time goes to Wikidata's SidebarHookHandlers, which does expensive things (mostly loading the site list) despite there being no sidebar." [05:51:58] TimStarling: I literally laughed out loud on that one [05:54:55] (03PS2) 10Tim Starling: Fix vim folding [core] - 10https://gerrit.wikimedia.org/r/174361 [05:58:13] (03CR) 10Legoktm: [C: 032] Fix vim folding [core] - 10https://gerrit.wikimedia.org/r/174361 (owner: 10Tim Starling) [06:03:51] (03Merged) 10jenkins-bot: Fix vim folding [core] - 10https://gerrit.wikimedia.org/r/174361 (owner: 10Tim Starling) [06:06:41] thanks legoktm [06:06:50] np :) [06:12:01] (03CR) 10Aaron Schulz: Show patrol marks on Special:Contributions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151381 (https://bugzilla.wikimedia.org/69061) (owner: 10Brian Wolff) [06:20:46] (03PS1) 10EBernhardson: Hygiene: Use the core AutoloadGenerator [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174373 [06:21:06] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use the core AutoloadGenerator [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174373 (owner: 10EBernhardson) [06:30:49] (03PS1) 10EBernhardson: Bug: Append to wgAutoloadClasses [core] - 10https://gerrit.wikimedia.org/r/174374 [06:32:05] (03CR) 10EBernhardson: [C: 04-1] "requires I7d42ee5d in core to be merged first." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174373 (owner: 10EBernhardson) [06:32:21] 3MediaWiki-Core-Team: Isolate throughput issue on HHVM API action=parse - https://phabricator.wikimedia.org/T758#23328 (10tstarling) When I ran the same test another few times, MessageCache disappeared from the list, but SidebarHookHandlers and MWTidy::execExternalTidy were still very expensive: ~110ms and ~200m... [06:33:53] (03PS2) 10EBernhardson: Bug: Append to wgAutoloadClasses [core] - 10https://gerrit.wikimedia.org/r/174374 [06:44:55] 3MediaWiki / 3Parser: indicator can't add class - 10https://bugzilla.wikimedia.org/73599 (10shi zhao) 3NEW p:3Unprio s:3normal a:3None can't add new class. e.g.
.....
[06:53:12] (03PS2) 10EBernhardson: Only prevent caching API requests on IE8 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174023 [06:53:24] (03CR) 10jenkins-bot: [V: 04-1] Only prevent caching API requests on IE8 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174023 (owner: 10EBernhardson) [06:54:56] (03PS3) 10EBernhardson: Only prevent caching API requests on IE8 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174023 [06:58:10] (03CR) 10EBernhardson: "patch now does as suggested: if IE8 then cache:false" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174023 (owner: 10EBernhardson) [07:02:08] (03CR) 10Aaron Schulz: [C: 032] Bug: Append to wgAutoloadClasses [core] - 10https://gerrit.wikimedia.org/r/174374 (owner: 10EBernhardson) [07:07:41] (03CR) 10jenkins-bot: [V: 04-1] Bug: Append to wgAutoloadClasses [core] - 10https://gerrit.wikimedia.org/r/174374 (owner: 10EBernhardson) [07:08:32] (03PS4) 10EBernhardson: Bug: Fails signature detection with extra long signature [extensions/Echo] - 10https://gerrit.wikimedia.org/r/173455 (https://bugzilla.wikimedia.org/73426) [07:09:51] (03CR) 10EBernhardson: "recheck" [core] - 10https://gerrit.wikimedia.org/r/174374 (owner: 10EBernhardson) [07:21:35] (03CR) 10Nemo bis: "> We don't know that for sure, though" [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/138745 (https://bugzilla.wikimedia.org/21206) (owner: 10Gerrit Patch Uploader) [07:23:51] 3MediaWiki extensions / 3TitleBlacklist: Log of title blacklist hits - 10https://bugzilla.wikimedia.org/21206#c24 (10Nemo) Jackmcbarn said on "Make logging of IPs for account creations optional, default disabled" : > I doubt that many non-WMF wikis would want this... [07:26:09] (03CR) 10Legoktm: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174373 (owner: 10EBernhardson) [07:30:06] 3Scrum-of-Scrums, MediaWiki-Core-Team: disks for logstash - https://phabricator.wikimedia.org/T1328#23329 (10Spage) [07:45:04] 3Scrum-of-Scrums, Multimedia, Release-Engineering: Files disappear and give 404's for the full resolution - https://phabricator.wikimedia.org/T1226#23337 (10Spage) 5Open>3Resolved [07:48:07] 3MediaWiki extensions / 3Semantic MediaWiki: SMW Ask query offset has a hardcoded limit - 10https://bugzilla.wikimedia.org/49203 (10Nemo) 5UNCO>3NEW [07:54:37] 3Wikimedia / 3Site requests: Run sendConfirmAndMigrateEmail.php for all unconfirmed emails on all wikis - 10https://bugzilla.wikimedia.org/71241#c5 (10Nemo) 08.52 < Nemo_bis> legoktm: is https://bugzilla.wikimedia.org/show_bug.cgi?id=71241 blocked on anything I can help with? 08.52 < legoktm> I just finished... [07:58:36] 3MediaWiki / 3Export/Import: Special:Import increases NUMBEROFARTICLES for each Revision instead of each Article - 10https://bugzilla.wikimedia.org/40009#c39 (10Andyrom75) I haven't reviewed the scripts but your idea seems to be reasobale. [07:59:29] 3Scrum-of-Scrums, Core-Features, MediaWiki-Core-Team: Enable $wgContentHandlerUseDB everywhere (bug 49193) - https://phabricator.wikimedia.org/T1217#23338 (10Spage) [08:12:24] Reporters of imported reports should be added to subscribers - https://phabricator.wikimedia.org/T896#23341 (10Nemo_bis) > These users will be added as reporters or subscribers when they create their accounts. What happens to the notifications till that point? We're not going to have tens of thousands orphaned re... [08:14:12] 3Scrum-of-Scrums, MediaWiki-Core-Team: disks for logstash - https://phabricator.wikimedia.org/T1328#23329 (10Spage) [08:15:45] Reporters of imported reports should be added to subscribers - https://phabricator.wikimedia.org/T896#23344 (10Nemo_bis) 5declined>3Open Reopen as documentation task until last comment is answered on https://www.mediawiki.org/wiki/Phabricator/versus_Bugzilla , which just says reporter and subscribers are impor... [08:21:18] (03PS5) 10EBernhardson: [WIP] End occupation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160923 [08:22:08] (03CR) 10jenkins-bot: [V: 04-1] [WIP] End occupation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160923 (owner: 10EBernhardson) [08:22:57] (03PS1) 10Robert Vogel: ShoutBox: Fixed statebar link [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/174379 [08:23:28] Don't duplicate the list of lists - https://phabricator.wikimedia.org/T636#23349 (10Nemo_bis) 5Invalid>3Open > It's definitely not a duplicate of https://meta.wikimedia.org/wiki/Mailing_lists/Overview But it must be prevented that it will ever be. What guarantees do we have that people won't start adding more... [08:25:35] 3Wikimedia / 3Site requests: Run sendConfirmAndMigrateEmail.php for all unconfirmed emails on all wikis - 10https://bugzilla.wikimedia.org/71241#c6 (10Kunal Mehta (Legoktm)) Generated the lists of users to be notified, there is a file for each wiki in /home/legoktm/spam/ on terbium. Total of 1,831,168. Emai... [08:38:51] 3Wikimedia / 3SSL related: replace SHA1 certificates with SHA256 - 10https://bugzilla.wikimedia.org/71156#c11 (10Antoine "hashar" Musso (WMF)) (In reply to chmarkine from comment #10) > Chrome 39 was released today. When will the certificates be replaced then? Thanks for the update. I have poked the interna... [08:44:51] 3MediaWiki / 3General/Unknown: ApiFormatWddxTest::testValidSyntax fails in mediawiki-core-regression-hhvm-master test - 10https://bugzilla.wikimedia.org/73531#c3 (10Antoine "hashar" Musso (WMF)) CCing Tim Starling since he did some commit to wddx ( https://github.com/facebook/hhvm/commit/46f5476b0c52b8b7564b... [08:46:06] (03CR) 10Gilles: [C: 032] Dependency fix [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/174300 (owner: 10TheDJ) [08:46:20] Actions shouldn't be attributed to bzimport - https://phabricator.wikimedia.org/T847#23354 (10Nemo_bis) [08:46:21] (03Merged) 10jenkins-bot: Dependency fix [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/174300 (owner: 10TheDJ) [08:53:46] 3Human-Resources, Engineering-Community: Wrap-up GSoC 2014 and FOSS OPW round 8 - https://phabricator.wikimedia.org/T717#23361 (10Nemo_bis) Either this is closed, or it's not blocking T561... Comment 0 is very depressing. :( [08:54:10] (03CR) 10Hashar: "The job template -phpunit is rather lame since it just runs whatever phpunit is provided by integration/phpunit.git" [cdb] - 10https://gerrit.wikimedia.org/r/174080 (https://bugzilla.wikimedia.org/73541) (owner: 10Hashar) [08:55:15] 3Engineering-Community: Prepare Wikimedia's participation in Google Code-In - https://phabricator.wikimedia.org/T561#23362 (10Qgil) [08:57:56] 3Human-Resources, Engineering-Community: Wrap-up GSoC 2014 and FOSS OPW round 8 - https://phabricator.wikimedia.org/T717#23363 (10Qgil) [09:01:22] Severity information is not being migrated - https://phabricator.wikimedia.org/T695#23365 (10Nemo_bis) [09:05:51] Severity information is not being migrated - https://phabricator.wikimedia.org/T695#23368 (10Nemo_bis) 5Resolved>3Open Reopen because [[Phabricator/Help]] is silent on severity and [[Phabricator/versus Bugzilla]] only says «Also note that Severity, Version, URL, Whiteboard, and other fields will not be availab... [09:09:22] Can't search for orphan tasks in "projects: none" - https://phabricator.wikimedia.org/T1329 (10Nemo_bis) 3NEW p:3Triage [09:09:46] Can't search for orphan tasks in "projects: none" - https://phabricator.wikimedia.org/T1329#23371 (10Nemo_bis) [09:11:53] "ext_ref" should be "Reference" - https://phabricator.wikimedia.org/T861 (10Nemo_bis) [09:13:21] (03PS1) 10Hoo man: Update Wikidata [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174382 [09:14:29] Print URL, Version, etc only when they contain data - https://phabricator.wikimedia.org/T694#23379 (10Nemo_bis) > I compared data of tickets https://bugzillapreview.wmflabs.org/T204 https://bugzillapreview.wmflabs.org/T716 https://bugzillapreview.wmflabs.org/T828 https://bugzillapreview.wmflabs.org/T939 https://bu... [09:14:37] Print URL, Version, etc only when they contain data - https://phabricator.wikimedia.org/T694 (10Nemo_bis) [09:15:04] (03PS2) 10Hoo man: Update Wikidata [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174382 [09:17:56] (03PS1) 10Prtksxna: mediawiki.ui: button: Add specific hover and active rule for color [core] - 10https://gerrit.wikimedia.org/r/174383 (https://bugzilla.wikimedia.org/73587) [09:19:05] 3MediaWiki / 3MediaWiki UI: Active neutral element buttons are ugly - yellow text on grey background - 10https://bugzilla.wikimedia.org/73587#c3 (10Prateek Saxena) Would it be better if the the element used