[00:00:11] (03CR) 10Ori.livneh: [C: 032] Add rsyslog module [vagrant] - 10https://gerrit.wikimedia.org/r/173932 (owner: 10BryanDavis) [00:00:16] (03Merged) 10jenkins-bot: Add rsyslog module [vagrant] - 10https://gerrit.wikimedia.org/r/173932 (owner: 10BryanDavis) [00:00:19] (03PS13) 10Trevor Parscal: Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo) [00:00:28] (03PS1) 10Catrope: Update VisualEditor for cherry-picks [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174017 [00:01:13] (03CR) 10Ori.livneh: [C: 032] apache: Handle error logs with rsyslog [vagrant] - 10https://gerrit.wikimedia.org/r/173933 (https://bugzilla.wikimedia.org/57426) (owner: 10BryanDavis) [00:01:19] (03Merged) 10jenkins-bot: apache: Handle error logs with rsyslog [vagrant] - 10https://gerrit.wikimedia.org/r/173933 (https://bugzilla.wikimedia.org/57426) (owner: 10BryanDavis) [00:01:38] (03CR) 10Ori.livneh: [C: 032] hhvm: log via syslog [vagrant] - 10https://gerrit.wikimedia.org/r/173934 (owner: 10BryanDavis) [00:01:44] (03Merged) 10jenkins-bot: hhvm: log via syslog [vagrant] - 10https://gerrit.wikimedia.org/r/173934 (owner: 10BryanDavis) [00:01:48] (03PS1) 10Legoktm: Make allowing site-wide styles on restricted special pages a config option [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/174018 (https://bugzilla.wikimedia.org/71621) [00:02:05] bd808: > I didn't pass undef to priority as I think that would actually cause logstash::conf to fail to apply if not overridden. [00:02:07] are you sure? [00:02:23] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (f1abca8e82) [core] - 10https://gerrit.wikimedia.org/r/174011 (owner: 10Catrope) [00:02:27] bd808: is your thinking that an explicit undef counts as a value and would clobber the default? [00:02:41] bd808: we know that's not true, because we do it all the time with resources that wrap file resources [00:02:50] (03CR) 10jenkins-bot: [V: 04-1] Make allowing site-wide styles on restricted special pages a config option [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/174018 (https://bugzilla.wikimedia.org/71621) (owner: 10Legoktm) [00:02:59] That was my thinking, but if untrue then... untrue. [00:03:19] I can totally change those then [00:04:31] (03PS2) 10Legoktm: Make allowing site-wide styles on restricted special pages a config option [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/174018 (https://bugzilla.wikimedia.org/71621) [00:04:38] (03PS1) 10Catrope: Update VisualEditor for cherry-picks [core] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/174020 [00:05:21] (03CR) 10MaxSem: [C: 032] Fix JS timestamp; shows up as 45 years ago (epoch) [extensions/Flow] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173462 (owner: 10EBernhardson) [00:05:43] (03CR) 10MaxSem: [C: 032] Update VisualEditor for cherry-picks [core] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/174020 (owner: 10Catrope) [00:06:21] (03CR) 10jenkins-bot: [V: 04-1] Fix JS timestamp; shows up as 45 years ago (epoch) [extensions/Flow] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173462 (owner: 10EBernhardson) [00:06:47] (03PS3) 10BryanDavis: ELK role [vagrant] - 10https://gerrit.wikimedia.org/r/173935 [00:07:25] (03PS16) 10Paladox: Adding message documentation [extensions/MaintenanceShell] - 10https://gerrit.wikimedia.org/r/170902 [00:07:27] (03CR) 10EBernhardson: [C: 032 V: 032] Fix JS timestamp; shows up as 45 years ago (epoch) [extensions/Flow] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173462 (owner: 10EBernhardson) [00:07:30] (03CR) 10BryanDavis: "Ori pointed out on irc tha undef is special in Puppet and doesn't override a default." [vagrant] - 10https://gerrit.wikimedia.org/r/173935 (owner: 10BryanDavis) [00:07:36] (03PS17) 10Paladox: Adding message documentation [extensions/MaintenanceShell] - 10https://gerrit.wikimedia.org/r/170902 [00:09:05] 3MediaWiki / 3User login and signup: Not loading site CSS on Special:UserLogin/Preferences breaks wikis which use it to create a skin/theme - 10https://bugzilla.wikimedia.org/71621#c20 (10Kunal Mehta (Legoktm)) I uploaded patches for REL1_24, REL1_23, and REL1_22. I started on REL1_19 and then it got all sca... [00:09:23] I am trying to setup the vagrant box for mediawiki on Fedora 20 [00:09:27] (03CR) 10EBernhardson: [C: 032] Use core's postWithToken for watching, which handles badtoken [extensions/Flow] - 10https://gerrit.wikimedia.org/r/172668 (https://bugzilla.wikimedia.org/72500) (owner: 10Mattflaschen) [00:10:02] (03CR) 10MaxSem: [V: 032] Update VisualEditor for cherry-picks [core] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/174020 (owner: 10Catrope) [00:10:03] The setup is stuck at "Redirecting to /bin/systemctl start nfs-server.service ==> default: Mounting NFS shared folders..." for 10 minutes now [00:10:19] any idea how to resolve this issue? [00:10:24] (03CR) 10MaxSem: [C: 032 V: 032] Update VisualEditor for cherry-picks [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174017 (owner: 10Catrope) [00:10:36] 3Wikimedia / 3Site requests: Enable VisualEditor in ca.wikiquote.org - 10https://bugzilla.wikimedia.org/73483 (10Dereckson) [00:11:23] 3Wikimedia / 3Git/Gerrit: Remove port 29418 from cloning process - 10https://bugzilla.wikimedia.org/35611#c18 (10Daniel Zahn) unfortunately more to do before we can. next we would need this or similar to make gerrit nodes setup a SSHD to listen only on the non-Gerrit IP: https://gerrit.wikimedia.org/r/#/c/1... [00:11:23] 3Wikimedia / 3Site requests: Enable VisualEditor in ca.wikiquote.org - 10https://bugzilla.wikimedia.org/73483 (10Dereckson) [00:12:20] (03PS1) 10EBernhardson: Only prevent caching of POST requests via API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174023 [00:12:34] (03CR) 10jenkins-bot: [V: 04-1] Fix JS timestamp; shows up as 45 years ago (epoch) [extensions/Flow] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173462 (owner: 10EBernhardson) [00:12:49] Followup with analytics research team post-retro - https://phabricator.wikimedia.org/T1310#22995 (10KLans_WMF) [00:12:59] (03CR) 10EBernhardson: [C: 032 V: 032] Fix JS timestamp; shows up as 45 years ago (epoch) [extensions/Flow] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173462 (owner: 10EBernhardson) [00:13:02] (03PS1) 10MaxSem: Bump MF and WikiGrok [core] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/174024 [00:13:22] (03Merged) 10jenkins-bot: Use core's postWithToken for watching, which handles badtoken [extensions/Flow] - 10https://gerrit.wikimedia.org/r/172668 (https://bugzilla.wikimedia.org/72500) (owner: 10Mattflaschen) [00:13:29] (03CR) 10Mwjames: "Starting with this change the drop-down looks a bit [0] out of place." [skins/chameleon] - 10https://gerrit.wikimedia.org/r/173928 (https://bugzilla.wikimedia.org/73509) (owner: 10Foxtrott) [00:14:06] 3MediaWiki / 3API: rollback token system is randomly broken - 10https://bugzilla.wikimedia.org/73207#c9 (10Peter Bena) 5RESO/WOR>3REOP ok it started happening again, even for old huggle but only in PEAK hours where we had around 15 reverts per minute and after half an hour where traffic went down it star... [00:14:52] 3MediaWiki / 3API: rollback token system is randomly broken - 10https://bugzilla.wikimedia.org/73207#c10 (10Peter Bena) I believe this is caused by some caches like memcache or sql lags [00:14:55] rtnpro: Do you know what version of Vagrant you have installed? This sounds like a possible bug in the Vagrant NFS setup for Fedora. [00:15:32] bd808, I am running vagrant 1.5.1 [00:15:47] (03PS1) 10MaxSem: Bump MF, WG and Flow [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174025 [00:15:57] rtnpro: Google found this for me too -- https://github.com/coreos/coreos-vagrant/issues/162 [00:16:04] (03CR) 10MaxSem: [C: 032 V: 032] Bump MF and WikiGrok [core] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/174024 (owner: 10MaxSem) [00:16:06] possible firewall conflict [00:16:18] bd808, I was looking at https://github.com/wunki/vagrant-freebsd/issues/4 :\ [00:16:19] (03CR) 10MaxSem: [C: 032 V: 032] Bump MF, WG and Flow [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174025 (owner: 10MaxSem) [00:16:21] (03PS4) 10Chad: Drop ss_total_views and page_counter fields from MediaWiki [core] - 10https://gerrit.wikimedia.org/r/167655 [00:17:06] bd808, hmm, makes sense [00:17:42] rtnpro: If you don't want to piddle with it right now, you can disable use of NFS with `vagrant config nfs_shares no` [00:17:54] bd808, ok [00:18:20] The NFS shares are faster but they have been a pain for some people [00:18:36] bd808, hmm [00:19:07] One example, nfs sharing doesn't work if you have MediaWiki-Vagrant installed on an encrypted partition. [00:19:28] Do you have to upgrade to Ubuntu 14 for MW-Vagrant? [00:19:47] I had it working back in May, but now it says it has to be version 14... [00:20:03] bd808, I will try to resolve the NFS share issue in Fedora :) [00:20:07] huh: The VM needs to be running 14.04. Your host OS does not. [00:20:26] bd808: should I run do-release-upgrade? [00:20:31] It'd be great to add the resolution in the docs: https://www.mediawiki.org/wiki/MediaWiki-Vagrant [00:20:43] I don't want to lose anything [00:20:46] bd808, thanks :) [00:21:02] huh: If you have a VM you haven't used since may, I would recommend starting over with the VM. `vagrant destroy -f; vagrant up` [00:21:05] rtnpro: yw [00:21:23] bd808, could you tell me where I can speak with folks working on https://github.com/wikimedia/analytics-wikimetrics/? [00:21:45] huh: Are you worried about losing content you put in the wiki on the VM? [00:22:24] bd808: no, stashed changes [00:22:30] for MW [00:22:40] the wiki content itself is useless [00:22:55] rtnpro: #wikimedia-analytics would be a good place to ask questions [00:23:17] bd808, thanks, again, +1 [00:24:18] huh: Ok. Your vagrant/mediawiki clone won't be effected by rebuiliding the vm from scratch so you should be safe. If you are really paranoid (who here isn't?) backup your mediawiki directory first. [00:24:50] (03CR) 10Esanders: [C: 04-1] Eventify TemplateDataGenerator and use oojs-ui (034 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo) [00:25:32] bd808: what about wiki content, not that it matters much? [00:26:16] huh: That would be lost if you destroy the VM. You can use any of the normal wiki backup techniques to preserve it if you'd like. [00:26:51] (03PS6) 10Aaron Schulz: Refactor profiling output from profiling [core] - 10https://gerrit.wikimedia.org/r/173348 (owner: 10Chad) [00:27:16] bd808: lots o changes [00:27:32] sweet [00:27:59] bd808: I've got more patch ideas too, so it would be nice to get that merged soon [00:28:46] AaronSchulz: You don't want to live in my world of having a long patch chain go unmerged for a year? ;) [00:30:41] aude: I left a comment on https://bugzilla.wikimedia.org/show_bug.cgi?id=56602 [00:32:30] (03PS1) 10Catrope: Update OOjs UI to v0.1.0-pre (d0af1e5b65) [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174029 [00:34:40] ProfilerOutput refactoring - https://phabricator.wikimedia.org/T1311#22996 (10aaron) [00:34:48] ProfilerOutput refactoring - https://phabricator.wikimedia.org/T1311#22997 (10aaron) [00:34:55] ProfilerOutput refactoring - https://phabricator.wikimedia.org/T1311#22884 (10aaron) p:5High>3Normal [00:36:29] (03PS11) 10Mattflaschen: EventLog Flow topic and post actions (FlowReplies) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171791 (owner: 10Matthias Mullie) [00:37:22] (03CR) 10jenkins-bot: [V: 04-1] EventLog Flow topic and post actions (FlowReplies) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171791 (owner: 10Matthias Mullie) [00:37:59] bd808: will it affect SQL in any way? [00:38:04] or is that backed up? [00:39:11] huh: The mysql instance is not backed up automatically. You would need to do that manually if you had something special in the mysql inside the VM that you need to keep. [00:40:02] Nothing is backed up, but content that lives on your host computer (git clones, MW config files) will not be deleted [00:41:12] (03PS1) 10EBernhardson: Fix allowunknownusernames cli option, and add a little debug logging [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174032 [00:41:15] (03PS1) 10EBernhardson: Bug: LQT import wrong date on topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174033 [00:41:18] the git is stored on the host computer FS? [00:41:20] (03CR) 10jenkins-bot: [V: 04-1] Fix allowunknownusernames cli option, and add a little debug logging [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174032 (owner: 10EBernhardson) [00:41:23] (03PS2) 10EBernhardson: Fix allowunknownusernames cli option, and add a little debug logging [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174032 [00:41:25] even if I disabled NFS? [00:41:26] (03CR) 10jenkins-bot: [V: 04-1] Bug: LQT import wrong date on topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174033 (owner: 10EBernhardson) [00:41:34] huh: Yes. [00:41:36] (03PS2) 10EBernhardson: Bug: LQT import wrong date on topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174033 [00:42:32] When NFS is disabled Vagrant falls back to Virtualbox native file sharing [00:43:26] Everything you see in the /vagrant directory inside the VM is actually on your host computer in the directory where you cloned MediaWiki-Vagrant [00:44:19] (03CR) 10TheDJ: [C: 04-1] "Did some more reading, my memory was failing me a bit:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174023 (owner: 10EBernhardson) [00:44:45] quick, how do I check what version of ubuntu I'm running? [00:44:50] it is uname -something? [00:45:04] (03CR) 10Mwjames: "Mischief of input fields with standard buttons [0]." [skins/chameleon] - 10https://gerrit.wikimedia.org/r/173928 (https://bugzilla.wikimedia.org/73509) (owner: 10Foxtrott) [00:45:21] 3Wikimedia / 3Site requests: Enable VisualEditor by default for all users on the Tagalog Wikipedia (currently a Beta Feature there) - 10https://bugzilla.wikimedia.org/73365#c6 (10James Forrester) 5PATC>3RESO/FIX Now done. [00:46:34] huh: lsb_release -a [00:46:40] thanks [00:48:57] (03CR) 10MaxSem: [C: 032] Update OOjs UI to v0.1.0-pre (d0af1e5b65) [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174029 (owner: 10Catrope) [00:50:33] (03CR) 10TheDJ: "It seems there is also something we might be able to do about this on the server side:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174023 (owner: 10EBernhardson) [00:52:47] (03CR) 10EBernhardson: Bug: Fails signature detection with extra long signature (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/173455 (https://bugzilla.wikimedia.org/73426) (owner: 10EBernhardson) [00:52:56] (03PS3) 10EBernhardson: Bug: Fails signature detection with extra long signature [extensions/Echo] - 10https://gerrit.wikimedia.org/r/173455 (https://bugzilla.wikimedia.org/73426) [00:53:33] (03CR) 10jenkins-bot: [V: 04-1] Bug: Fails signature detection with extra long signature [extensions/Echo] - 10https://gerrit.wikimedia.org/r/173455 (https://bugzilla.wikimedia.org/73426) (owner: 10EBernhardson) [00:54:34] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (d0af1e5b65) [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174029 (owner: 10Catrope) [00:57:30] (03PS1) 10Paladox: Localisation updates [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/174038 [00:57:42] (03PS2) 10Paladox: Localisation updates [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/174038 [00:57:48] (03CR) 10Paladox: [C: 032 V: 032] Localisation updates [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/174038 (owner: 10Paladox) [00:59:01] (03PS1) 10Paladox: Localisation updates [extensions/CollapsibleVector] (REL1_24) - 10https://gerrit.wikimedia.org/r/174039 [00:59:12] (03CR) 10Paladox: [C: 032 V: 032] Localisation updates [extensions/CollapsibleVector] (REL1_24) - 10https://gerrit.wikimedia.org/r/174039 (owner: 10Paladox) [00:59:22] 3MediaWiki / 3Watchlist: Watchlist doesn't show earlier normal edits when hiding bot edits or minor edits - 10https://bugzilla.wikimedia.org/9790#c25 (10Eric) Throwing my voice into the din, in case anyone is listening 7+ years on... Someone please make it so that when bot edits are hidden, the most recent n... [01:05:33] (03PS1) 10Paladox: Localisation updates [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/174040 [01:06:48] (03CR) 10Paladox: [C: 032 V: 032] Localisation updates [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/174040 (owner: 10Paladox) [01:07:02] (03PS1) 10Paladox: Localisation updates [extensions/CollapsibleVector] (REL1_24) - 10https://gerrit.wikimedia.org/r/174041 [01:07:13] (03CR) 10Paladox: [C: 032 V: 032] Localisation updates [extensions/CollapsibleVector] (REL1_24) - 10https://gerrit.wikimedia.org/r/174041 (owner: 10Paladox) [01:15:18] (03PS1) 10Paladox: Localisation updates [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/174043 [01:15:34] (03CR) 10Paladox: [C: 032 V: 032] Localisation updates [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/174043 (owner: 10Paladox) [01:15:42] (03PS1) 10Paladox: Localisation updates [extensions/CollapsibleVector] (REL1_24) - 10https://gerrit.wikimedia.org/r/174044 [01:15:53] (03CR) 10Paladox: [C: 032 V: 032] Localisation updates [extensions/CollapsibleVector] (REL1_24) - 10https://gerrit.wikimedia.org/r/174044 (owner: 10Paladox) [01:33:16] (03PS7) 10BryanDavis: Refactor profiling output from profiling [core] - 10https://gerrit.wikimedia.org/r/173348 (owner: 10Chad) [01:35:38] 3MediaWiki extensions / 3AbuseFilter: Whether or not the user recently hit the spam blacklist - 10https://bugzilla.wikimedia.org/73417#c2 (10Cenarium) Ok, that wasn't clear. I mean that it should be an abusefilter variable like article_recent_contributors. Let's call this variable users_having_recently_hit_t... [01:38:33] (03PS1) 10Paladox: Localisation updates [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/174049 [01:38:43] (03PS2) 10Paladox: Localisation updates [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/174049 [01:38:52] (03CR) 10Paladox: [C: 032 V: 032] Localisation updates [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/174049 (owner: 10Paladox) [01:38:58] (03PS1) 10Paladox: Localisation updates [extensions/CollapsibleVector] (REL1_24) - 10https://gerrit.wikimedia.org/r/174050 [01:39:24] (03CR) 10Paladox: [C: 032 V: 032] Localisation updates [extensions/CollapsibleVector] (REL1_24) - 10https://gerrit.wikimedia.org/r/174050 (owner: 10Paladox) [01:40:15] what does it mean if http://127.0.0.1:8080/ gives a directory listing including info.php etc. ? [01:40:19] how to fix ? [01:41:51] huh, vagrant? [01:41:56] yes [01:42:36] cd vagrant && git pull && vagrant reload && vagrant provision [01:42:54] on host? [01:43:34] <^d> MaxSem: `vagrant reload --provision` :) [01:44:05] huh: yes, on your host computer [01:44:33] * bd808 tries to think of how the apache config would output a directory listing [01:45:23] it's the listing of / btw [01:45:39] or that's what it says, but it's not really [01:45:59] (03CR) 10Chad: [C: 032 V: 032] Link to docs on mediawiki.org in README [cdb] - 10https://gerrit.wikimedia.org/r/173988 (owner: 10Legoktm) [01:46:16] It's the root of the vhost, not the OS. [01:46:38] ^d, I keep forgetting where --provision applies and where not. easier just to type a tad more [01:53:49] (03PS1) 10Ori.livneh: Avoid calling Title::makeTitleSafe in User::idFromName [core] - 10https://gerrit.wikimedia.org/r/174051 (https://bugzilla.wikimedia.org/54193) [01:54:02] (03PS18) 10Paladox: Adding message documentation [extensions/MaintenanceShell] - 10https://gerrit.wikimedia.org/r/170902 [01:54:08] ^ AaronSchulz [01:55:26] (03PS53) 10Paladox: WikiEditor: Re add SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) [01:58:04] (03CR) 10Legoktm: Avoid calling Title::makeTitleSafe in User::idFromName (031 comment) [core] - 10https://gerrit.wikimedia.org/r/174051 (https://bugzilla.wikimedia.org/54193) (owner: 10Ori.livneh) [01:58:38] can someone with security bug access add me to https://bugzilla.wikimedia.org/show_bug.cgi?id=73490 ? [01:58:47] (or pm me a summary of it?) [01:58:59] (03PS2) 10Ori.livneh: Avoid calling Title::makeTitleSafe in User::idFromName [core] - 10https://gerrit.wikimedia.org/r/174051 (https://bugzilla.wikimedia.org/54193) [01:59:48] jackmcbarn: CC'd [02:00:47] ori: thanks [02:00:57] (03CR) 10Aaron Schulz: [C: 032] Avoid calling Title::makeTitleSafe in User::idFromName [core] - 10https://gerrit.wikimedia.org/r/174051 (https://bugzilla.wikimedia.org/54193) (owner: 10Ori.livneh) [02:06:28] (03Merged) 10jenkins-bot: Avoid calling Title::makeTitleSafe in User::idFromName [core] - 10https://gerrit.wikimedia.org/r/174051 (https://bugzilla.wikimedia.org/54193) (owner: 10Ori.livneh) [02:08:34] (03PS1) 10Anomie: Fix SecurePollContent handling [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/174056 [02:10:35] (03CR) 10Legoktm: [C: 032] Fix SecurePollContent handling [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/174056 (owner: 10Anomie) [02:10:42] (03Merged) 10jenkins-bot: Fix SecurePollContent handling [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/174056 (owner: 10Anomie) [02:13:36] 3MediaWiki / 3Parser: indicators with template parameters can't work - 10https://bugzilla.wikimedia.org/73450#c6 (10Jackmcbarn) As was previously mentioned, just use #tag if you need this. I see no reason to make this tag special. [02:14:40] 3MediaWiki skins / 3Vector: Mediawiki diff formatting is broken in printer ready display - 10https://bugzilla.wikimedia.org/73544 (10Chris Davies) 3UNCO p:3Unprio s:3normal a:3None Printable diffs now contain a hideous combination of the old and new diff styles. Compare: http://en.wikipedia.org/w/... [02:17:29] (03CR) 10CSteipp: [C: 032] Initial WMF extension commit [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/173303 (owner: 10CSteipp) [02:20:24] is there a way to check if puppet is working (vagrant)? [02:21:02] huh: You can run it in debug mode -- PUPPET_DEBUG=1 vagrant provision [02:21:24] That will spew a lot of info about the progress of the puppet run [02:21:40] "Shared folders that Puppet requires are missing on the virtual machine." ??? [02:22:09] That's an "epic fail" basically. [02:22:11] The fix is to run a `vagrant reload` but I've done that several times already :/ [02:24:01] huh: You said previously you had disabled NFS mounts correct? [02:24:19] yes, months ago, but in debugging I've re-enabled them [02:25:07] I'm pretty sure the puppet file shares are done with the Virtualbox built-in file sharing anyway [02:25:23] * bd808 tries to think of how to debug this [02:25:41] (03PS1) 10Ori.livneh: Avoid calling Title::makeTitleSafe in User::idFromName [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174057 (https://bugzilla.wikimedia.org/54193) [02:26:22] (03PS8) 10BryanDavis: Refactor profiling output from profiling [core] - 10https://gerrit.wikimedia.org/r/173348 (owner: 10Chad) [02:26:31] maybe it has something to do with not having the right version of vbox guest additions? [02:28:38] (03CR) 10BryanDavis: [C: 031] "I fixed up some of the docs for ProfilerXhprof to match the new system. Seems to work in my local testing. We should have a config patch r" [core] - 10https://gerrit.wikimedia.org/r/173348 (owner: 10Chad) [02:29:19] which is why I get mount/vbox.fs errors [02:31:13] (03CR) 10Anomie: "I'd have -1ed this, you broke stuff. For example, http://localhost/w/api.php?action=query&list=logevents&leuser=anomie now fails to return" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/174051 (https://bugzilla.wikimedia.org/54193) (owner: 10Ori.livneh) [02:31:17] this is all so confusing :/ [02:31:34] (03CR) 10Anomie: [C: 04-1] "See original patch, this breaks stuff." [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174057 (https://bugzilla.wikimedia.org/54193) (owner: 10Ori.livneh) [02:32:01] anomie: good catch; i'll follow up [02:33:41] huh: It probably is a guest additions problem. Did you just download the 14.04 base image or do you maybe have an old one? [02:33:58] bd808: it's apparently Ubuntu 14 [02:34:52] so I guess the new version was installed correctly, I backed up the wiki [02:36:36] bd808: https://tools.wmflabs.org/paste/view/1823b441 [02:37:08] and installing the vagrant plugin gives some error about ffi [02:37:24] bah. Stupid ruby ffi [02:37:29] (earlier someone suggested that I just disable installing plugins, but that causes this issue) [02:37:50] yeah. :( [02:37:56] ok. let's figure this out [02:38:29] want the error from trying to install the vbox stuff? [02:39:05] well, there are 2 ways we can go [02:39:37] one is to try and get the vbox updater working (probably the best idea long term) [02:40:06] the other would be to try forcing the latest base image to be downloaded [02:40:20] meh. let's fix it right [02:40:22] what would you recommend? [02:40:24] ok [02:40:48] I think getting the updater plugin working is the best bet long term [02:41:12] So that puts us back to where you were when you had problems getting that installed [02:42:18] * bd808 looks in scrollback for old error pastes and finds -- https://tools.wmflabs.org/paste/view/aa258d42 [02:42:45] I'll try to get the error message [02:43:40] huh: Did you ever upgrade Vagrant or are you still on a 1.5.x version? [02:43:50] I upgraded it [02:44:21] ok cool. so you have 1.6.5 now or whatever the latest is? [02:44:37] Did you happen to upgrade Virtualbox too? [02:45:18] it's up-to-date [02:45:32] (I just did the "Check for updates" thing) [02:45:33] cool. [02:45:51] 3MediaWiki / 3Parser: indicators with template parameters can't work - 10https://bugzilla.wikimedia.org/73450#c7 (10ssastry) (In reply to Bartosz Dziewoński from comment #5) > as far as I know no other tags support > arbitrary wikitext in attributes and I wouldn't want to make this one > different. Ah, int... [02:46:01] (03PS1) 10Aaron Schulz: [WIP] Make eval.php try to handle newlines in code [core] - 10https://gerrit.wikimedia.org/r/174059 [02:46:01] bd808: https://tools.wmflabs.org/paste/view/ae61f2f1 [02:46:05] So we are down to "just" fighting with ruby and Bundler [02:46:47] *nod* [02:47:02] * bd808 rummages through old bugs in bugzilla [02:47:10] I've seen something like this before... [02:48:08] any idea what's wrong? [02:48:11] I'm no expert in ruby [02:48:22] In fact, I don't know much about Ruby at all. [02:48:39] i don't understand what would be requiring ffi [02:48:46] We've had problems with the nokogiri gem before, but not ffi [02:49:14] marxarelli: It's crazy stuff that happens when you install nay plugin [02:49:16] I'm not sure any gem will work [02:49:33] Since they are managed with Bundler it tries to update everything [02:49:36] the actual gem command succeeds, but the vagrant one doesn't [02:49:42] and sometimes **boom** [02:49:47] huh: what does `vagrant plugin list` say? [02:50:13] huh: We need to run it using a different ruby. Vagrant has one that is not the system ruby [02:50:25] marxarelli: mediawiki-vagrant (0.2.1)\n - Version Constraint: 0.2.1\nvagrant-login (1.0.1, system)\nvagrant-share (1.1.1, system) [02:50:48] huh: Take a look at https://bugzilla.wikimedia.org/show_bug.cgi?id=69052#c18 [02:51:09] This was a slightly differnt problem but I think things there apply [02:51:52] damn OSX incompatibility [02:52:14] try: /Applications/Vagrant/embedded/bin/gem install --install-dir ~/.vagrant.d/gems ffi -v '1.9.6' --no-ri --no-rdoc [02:52:59] it gives the same error as in the paste [02:53:12] with "/Applications/Vagrant/embedded/lib/ruby/2.0.0/mkmf.rb:292:in `initialize_copy': Bad file descriptor (Errno::EBADF)" etc [02:54:16] that line says: @orgerr = $stderr.dup [02:55:26] no idea, what the .dup thing means, I don't know ruby [02:56:10] Looks like this bug report -- https://github.com/mitchellh/vagrant/issues/2770 [02:57:02] huh: What version of OSX are you running? [02:57:09] same as the bug [02:58:10] yuck. Do you see the fix there? Build ruby 2.0 and splat it into the Vagrant app bundle. [02:58:40] ??? [02:59:08] I tried removing the .dup mentioned here https://github.com/mitchellh/vagrant/issues/2770#issuecomment-31788447 and it worked :/ [02:59:24] sweet! [02:59:29] I hope it actually works though! :) [02:59:54] hmm [03:00:15] huh: My dinner's getting cold. Poke marxarelli if you keep having problems. I'll be back online later. [03:00:34] bye bd808 and thanks for all the help! :D [03:17:58] 3MediaWiki / 3History/Diffs: Diffs for meta-data changes (Protect/Move/ContentHandler type) should show something useful, not "No difference". - 10https://bugzilla.wikimedia.org/73546 (10James Forrester) 3NEW p:3Unprio s:3enhanc a:3None "No difference" is not useful to show to users; the diff page fo... [03:21:36] 3MediaWiki / 3History/Diffs: Diffs for meta-data changes (Protect/Move/ContentHandler type) should show something useful, not "No difference". - 10https://bugzilla.wikimedia.org/73546 (10James Forrester) p:5Unprio>3High [03:25:40] 3Librarization: Bring in Flow's dependencies via composer - https://phabricator.wikimedia.org/T1283#23005 (10bd808) p:5Triage>3Normal [03:26:02] 3Librarization, Architecture-RfCs: RfC: Better PHP profiling - https://phabricator.wikimedia.org/T1251#23006 (10bd808) p:5Triage>3Normal [03:27:40] Large file upload to Commons please - https://phabricator.wikimedia.org/T1312#23007 (10bd808) [03:30:24] Decide on repository callsign naming conventions, and the callsigns to use for existing repos - https://phabricator.wikimedia.org/T1314 (10Jdforrester-WMF) 3NEW p:3Normal a:3Chad [03:30:57] Decide on repository callsign naming conventions, and the callsigns to use for existing repos - https://phabricator.wikimedia.org/T1314#23009 (10Jdforrester-WMF) [03:32:53] Release 2.0 - https://phabricator.wikimedia.org/T1315 (10jayvdb) 3NEW p:3Triage a:3valhallasw [03:46:45] (03CR) 10Aaron Schulz: [C: 032] filebackend: Log more details about backend-fail-internal errors [core] - 10https://gerrit.wikimedia.org/r/173864 (https://bugzilla.wikimedia.org/73094) (owner: 10Gilles) [03:52:15] (03Merged) 10jenkins-bot: filebackend: Log more details about backend-fail-internal errors [core] - 10https://gerrit.wikimedia.org/r/173864 (https://bugzilla.wikimedia.org/73094) (owner: 10Gilles) [04:18:08] (03CR) 10PiRSquared17: [C: 031] "Looks OK." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/173856 (owner: 10Glaisher) [05:35:22] (03PS2) 10BryanDavis: parsoid: Copy logs to logstash [vagrant] - 10https://gerrit.wikimedia.org/r/173936 [06:08:51] 3MediaWiki extensions / 3SemanticForms: Error when using Special:RunQuery - "Parser state cleared while parsing" - 10https://bugzilla.wikimedia.org/66202#c8 (10Yaron Koren) Masin - thanks for looking into this, and sorry about the delay. In your code, you seem to have hit on the main reason for using parse()... [06:13:28] ori: Could I have a look at the Bug40009 logs? [06:15:56] (03CR) 10Mattflaschen: [C: 04-1] "> This has been tested and does not break anything. version 2 does." [core] - 10https://gerrit.wikimedia.org/r/173845 (owner: 10Paladox) [06:41:10] (03CR) 10BryanDavis: "Tested on instances with and without role::elk enabled:" (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/173936 (owner: 10BryanDavis) [06:44:21] 3MediaWiki / 3Export/Import: Special:Import increases NUMBEROFARTICLES for each Revision instead of each Article - 10https://bugzilla.wikimedia.org/40009 (10This, that and the other (TTO)) 5PATC>3NEW [06:45:26] Use Wikimedia favicon - https://phabricator.wikimedia.org/T273#23031 (10Mattflaschen) 5declined>3Open >>! In T273#20411, @Qgil wrote: > Right, the Wikimedia favicon is used in https://wikimediafoundation.org/ and... ? > > The stock Phabricator icon will be unique for the 99.99% of users here (just a few of us... [06:47:15] (03PS3) 10BryanDavis: parsoid: Copy logs to logstash [vagrant] - 10https://gerrit.wikimedia.org/r/173936 [06:57:39] (03PS2) 10Robert Vogel: ShoutBox: Fixed some issues [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/173780 [07:04:35] 3MediaWiki / 3General/Unknown: Warning: Recursion detected in RequestContext::getLanguage in /includes/context/RequestContext.php on line 284 - 10https://bugzilla.wikimedia.org/54193 (10Nemo) 5PATC>3NEW [07:07:27] (03CR) 10Robert Vogel: [C: 032 V: 032] More word query returned no results [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/173004 (owner: 10Smuggli) [07:14:32] (03CR) 10Mattflaschen: [C: 04-1] "This is an interesting approach. I wasn't originally envisioning it being data-driven. I just suggested the data attributes as a memory " (0325 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171791 (owner: 10Matthias Mullie) [07:20:50] 3MediaWiki / 3Parser: Provide a parser function to create links to the wiki which don't look external - 10https://bugzilla.wikimedia.org/66746#c13 (10Niklas Laxström) You will need a solution even with templating. The general problem of avoiding lego-messages by taking something in the translation string and... [07:28:30] (03PS2) 10Robert Vogel: Added missing i18n for responsible editor log [extensions/BlueSpiceExtensions] (REL1_22) - 10https://gerrit.wikimedia.org/r/172672 (owner: 10Tweichart) [07:37:07] 3MediaWiki / 3Parser: indicators with template parameters can't work - 10https://bugzilla.wikimedia.org/73450 (10Bartosz Dziewoński) 5NEW>3RESO/WON [07:47:52] 3MediaWiki extensions / 3SemanticForms: Input form autocompletion does not work when data is Korean. (case of 'property=PROPERTY_NAME') - 10https://bugzilla.wikimedia.org/73548 (10boomindera) 3UNCO p:3Unprio s:3normal a:3Yaron Koren Input form autocompletion does not work when data is Korean (2-bytes... [07:49:20] 3MediaWiki extensions / 3SemanticForms: Input form autocompletion does not work when data is Korean. (case of 'property=PROPERTY_NAME') - 10https://bugzilla.wikimedia.org/73548 (10boomindera) [08:14:11] (03CR) 10Raimond Spekking: [C: 032] Updating and debugging the extension [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/166986 (owner: 10Luis Felipe Schenone) [08:15:24] (03CR) 10Raimond Spekking: [C: 032] Fix tracking for version [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/172581 (owner: 10Paladox) [08:18:05] Hovercards: Create access point for user survey in hovercards - https://phabricator.wikimedia.org/T1005#23035 (10Prtksxna) >>! In T1005#21814, @aripstra wrote: > It is active now. The Greek translation is completed, but Catalan and Chinese are not ready yet. Cool. I saw that its just one link and the language can... [08:19:09] (03Merged) 10jenkins-bot: Updating and debugging the extension [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/166986 (owner: 10Luis Felipe Schenone) [08:19:11] (03Merged) 10jenkins-bot: Fix tracking for version [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/172581 (owner: 10Paladox) [08:19:51] thedj: Do you think you could take a look at https://bugzilla.wikimedia.org/62952#c9 [08:28:32] Actually, goes for anyone with access: Could I have a look at the wfDebugLog output for the Bug40009 log group? [08:30:00] Large file upload to Commons please - https://phabricator.wikimedia.org/T1312#23036 (10hashar) [08:33:53] 3Wikimedia / 3Site requests: Please upload large file to Commons - 10https://bugzilla.wikimedia.org/73549 (10Vera de Kok) 3UNCO p:3Unprio s:3enhanc a:3None Please upload these videos https://docs.google.com/uc?export=download&id=0B0QItG8OyBLrdUstazVMQ2xIVWc [08:35:28] (03PS1) 10Paladox: Updating and debugging the extension [extensions/MsUpload] (REL1_24) - 10https://gerrit.wikimedia.org/r/174069 [08:35:33] prtksxna: can u remind me again in 12 hours ? [08:35:42] thedj: Will do [08:36:04] (03CR) 10Paladox: "@Raimond Spekking" [extensions/MsUpload] (REL1_24) - 10https://gerrit.wikimedia.org/r/174069 (owner: 10Paladox) [08:36:07] thedj: 14-15 actually, I'll be sleeping then… [08:36:23] that's fine, anything that skips my workday :) [08:36:36] and 14 15 would do that. [08:36:46] thedj: Cool. Thanks! [08:39:29] (03CR) 10Raimond Spekking: [C: 032] Updating and debugging the extension [extensions/MsUpload] (REL1_24) - 10https://gerrit.wikimedia.org/r/174069 (owner: 10Paladox) [08:41:49] (03Merged) 10jenkins-bot: Updating and debugging the extension [extensions/MsUpload] (REL1_24) - 10https://gerrit.wikimedia.org/r/174069 (owner: 10Paladox) [08:48:50] (03PS1) 10Paladox: Fix path to i18n [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/174071 [08:49:00] (03PS2) 10Paladox: Fix path to i18n [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/174071 [08:49:20] 3MediaWiki / 3General/Unknown: ApiFormatWddxTest::testValidSyntax fails in mediawiki-core-regression-hhvm-master test - 10https://bugzilla.wikimedia.org/73531#c1 (10Antoine "hashar" Musso (WMF)) The console log shows: Entity: line 1: parser error : xmlParseEntityRef: no name ring>/^([a-z]+)(.*)$/sD (03CR) 10Paladox: "change it from /extensions/msupload/i18n/$csCode.json to /i18n/$csCode.json" [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/174071 (owner: 10Paladox) [08:52:29] (03PS1) 10Paladox: Fix path to i18n [extensions/MsUpload] (REL1_24) - 10https://gerrit.wikimedia.org/r/174072 [08:57:06] (03CR) 10Paladox: "Ok" [core] - 10https://gerrit.wikimedia.org/r/173845 (owner: 10Paladox) [08:58:35] (03CR) 10Paladox: "It may not show the change but the change is there." [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/174071 (owner: 10Paladox) [09:01:39] (03PS8) 10Physikerwelt: Increase size of the math_mathml in the mathlatexml table [extensions/Math] - 10https://gerrit.wikimedia.org/r/171627 (https://bugzilla.wikimedia.org/73090) [09:01:52] 3Wikimedia / 3Site requests: Please upload large file to Commons - 10https://bugzilla.wikimedia.org/73549#c1 (10Glaisher) 5UNCO>3NEW Which username should be used? [09:03:54] (03PS3) 10Paladox: Fix path to i18n [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/174071 [09:04:23] (03PS4) 10Paladox: Fix path to i18n [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/174071 [09:05:02] (03PS5) 10Paladox: Fix path to i18n [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/174071 [09:05:11] (03PS6) 10Paladox: Fix path to i18n [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/174071 [09:05:36] (03PS3) 10Smuggli: ShoutBox: Fixed some issues [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/173780 (owner: 10Robert Vogel) [09:06:24] Use Wikimedia favicon - https://phabricator.wikimedia.org/T273#23039 (10Glaisher) [09:07:07] (03Abandoned) 10Smuggli: Added contributor [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/172981 (owner: 10Smuggli) [09:11:10] (03PS1) 10Physikerwelt: LaTeXML: prevent automatic rerendering of SVG [extensions/Math] - 10https://gerrit.wikimedia.org/r/174074 [09:12:50] (03PS1) 10Physikerwelt: Add logging table [extensions/Math] - 10https://gerrit.wikimedia.org/r/174075 [09:13:10] (03PS7) 10Paladox: Fix path to i18n [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/174071 [09:13:28] (03PS8) 10Paladox: Fix path to i18n [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/174071 [09:17:31] (03CR) 10Raimond Spekking: [C: 031] "i18n review" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/173780 (owner: 10Robert Vogel) [09:19:45] (03PS9) 10Paladox: Fix path to i18n [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/174071 [09:20:04] (03PS10) 10Paladox: Fix path to i18n [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/174071 [09:21:29] (03PS11) 10Paladox: Fix path to i18n [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/174071 [09:21:31] (03CR) 10Smuggli: [C: 032 V: 032] ShoutBox: Fixed some issues [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/173780 (owner: 10Robert Vogel) [09:21:42] (03PS12) 10Paladox: Fix path to i18n [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/174071 [09:22:37] (03PS1) 10Physikerwelt: Create debugging table onLoadExtensionSchemaUpdates [extensions/Math] - 10https://gerrit.wikimedia.org/r/174076 [09:22:52] (03CR) 10Smuggli: [C: 032 V: 032] Added missing i18n for responsible editor log [extensions/BlueSpiceExtensions] (REL1_22) - 10https://gerrit.wikimedia.org/r/172672 (owner: 10Tweichart) [09:24:47] (03CR) 10Paladox: "@Raimond Spekking please could I have some help it seems that my changes aren't showing here I have renamed msupload.php to MsUpload.php a" [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/174071 (owner: 10Paladox) [09:25:25] (03Abandoned) 10Paladox: Fix path to i18n [extensions/MsUpload] (REL1_24) - 10https://gerrit.wikimedia.org/r/174072 (owner: 10Paladox) [09:32:55] hello everyone,i want to work on this bug https://bugzilla.wikimedia.org/show_bug.cgi?id=73253 but not able to understand from where to start [09:32:59] (03PS13) 10Paladox: Fix path to i18n [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/174071 [09:33:13] (03PS14) 10Paladox: Fix path to i18n [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/174071 [09:33:52] (03CR) 10Paladox: "@Raimond Spekking I have managed to fix it and is now showing what I changed." [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/174071 (owner: 10Paladox) [09:35:35] Use Wikimedia favicon - https://phabricator.wikimedia.org/T273#23040 (10Qgil) [09:35:46] alok_pandey: submit a patch to gerrit? [09:36:22] (03CR) 10Foxtrott: "Guess I'll have to finally rework form elements completely so they have a somewhat consistent style throughout the wiki. :/" [skins/chameleon] - 10https://gerrit.wikimedia.org/r/173928 (https://bugzilla.wikimedia.org/73509) (owner: 10Foxtrott) [09:37:49] (03PS15) 10Paladox: Fix path to i18n [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/174071 [09:38:53] (03PS1) 10Paladox: Fix path to i18n [extensions/MsUpload] (REL1_24) - 10https://gerrit.wikimedia.org/r/174079 [09:38:55] (03CR) 10jenkins-bot: [V: 04-1] Fix path to i18n [extensions/MsUpload] (REL1_24) - 10https://gerrit.wikimedia.org/r/174079 (owner: 10Paladox) [09:38:59] (03PS1) 10Hashar: Add 'composer test' to run PHPUnit [cdb] - 10https://gerrit.wikimedia.org/r/174080 (https://bugzilla.wikimedia.org/73541) [09:39:03] (03CR) 10jenkins-bot: [V: 04-1] Add 'composer test' to run PHPUnit [cdb] - 10https://gerrit.wikimedia.org/r/174080 (https://bugzilla.wikimedia.org/73541) (owner: 10Hashar) [09:43:07] (03PS2) 10Paladox: Fix path to i18n [extensions/MsUpload] (REL1_24) - 10https://gerrit.wikimedia.org/r/174079 [09:43:22] (03PS3) 10Paladox: Fix path to i18n [extensions/MsUpload] (REL1_24) - 10https://gerrit.wikimedia.org/r/174079 [09:43:57] (03PS2) 10Hashar: PHPUnit integration [cdb] - 10https://gerrit.wikimedia.org/r/174080 (https://bugzilla.wikimedia.org/73541) [09:43:59] (03CR) 10jenkins-bot: [V: 04-1] PHPUnit integration [cdb] - 10https://gerrit.wikimedia.org/r/174080 (https://bugzilla.wikimedia.org/73541) (owner: 10Hashar) [09:45:08] (03PS1) 10Foxtrott: Limit fix of padding of mw-ui-input and -button to Special:Search [skins/chameleon] - 10https://gerrit.wikimedia.org/r/174083 (https://bugzilla.wikimedia.org/73509) [09:46:11] (03CR) 10Hashar: "PS2 adds phpunit.xml.dist which let the current Jenkins job actually run phpunit instead of throwing help." [cdb] - 10https://gerrit.wikimedia.org/r/174080 (https://bugzilla.wikimedia.org/73541) (owner: 10Hashar) [09:46:28] (03PS2) 10Foxtrott: Limit fix of padding of mw-ui-input and -button to Special:Search [skins/chameleon] - 10https://gerrit.wikimedia.org/r/174083 (https://bugzilla.wikimedia.org/73509) [09:48:02] Use Wikimedia favicon - https://phabricator.wikimedia.org/T273#23044 (10Qgil) In fact, I have just realized that upstream's favicon is blue, while our favicon is black. Problem solved? [09:48:23] i am a newbie and not able to find the codebase for this bug https://bugzilla.wikimedia.org/show_bug.cgi?id=73253 for making changes.please help me out [09:48:27] (03CR) 10Foxtrott: [C: 032 V: 032] Limit fix of padding of mw-ui-input and -button to Special:Search [skins/chameleon] - 10https://gerrit.wikimedia.org/r/174083 (https://bugzilla.wikimedia.org/73509) (owner: 10Foxtrott) [09:48:53] (03PS2) 10Physikerwelt: Add logging table [extensions/Math] - 10https://gerrit.wikimedia.org/r/174075 [09:51:39] (03PS19) 10Paladox: Update jquery.ui Vector theme to 1.9.2 [skins/Vector] - 10https://gerrit.wikimedia.org/r/154024 [09:57:52] 3MediaWiki / 3Page editing: Auto-save to increase chances of lost edits recovery - 10https://bugzilla.wikimedia.org/73241#c5 (10Nemo) Merged in ContentTranslation: 00ebcc6e3e31b278092abde755cbd9009ef65cf4 No idea how much of its code/idea is reusable. [09:59:09] (03CR) 10Paladox: "Could someone abandon this patch because https://gerrit.wikimedia.org/r/#/c/166986/ was merged into the extension." [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/102023 (owner: 10Wikinaut) [10:00:56] Top bar of Phabricator should signify to users they are interacting with a Wikimedia project space - https://phabricator.wikimedia.org/T69#23047 (10Qgil) >>! In T69#15051, @Nemo_bis wrote: > Green is much better, thanks https://bugzillapreview.wmflabs.org/ Should we have a green header here as well, then? I have... [10:07:08] how to get codebase for any particular bugs.please help i am a newbie [10:07:36] checkout: I find the easiest is to look up the repository at https://github.com/wikimedia [10:08:16] checkout: https://www.mediawiki.org/wiki/Gerrit has some more info on how to contribute, and there are project-specific guidelines [10:08:20] Top bar of Phabricator should signify to users they are interacting with a Wikimedia project space - https://phabricator.wikimedia.org/T69#23048 (10Qgil) I took a screenshot of the same header in blue, just in case you want something else to compare. I have tried the other colors available, but at least in my eyes... [10:08:35] (03PS16) 10Paladox: Fix path to i18n [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/174071 [10:09:05] (03PS17) 10Paladox: Fix path to i18n [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/174071 [10:10:25] @valhallasw i have read gerrit tutorial but not able to find anywhere how to find codebase for any bugs like this one:https://bugzilla.wikimedia.org/show_bug.cgi?id=36055 [10:11:08] checkout: that would be in the mediawiki-core repository. [10:11:17] (03PS4) 10Paladox: Fix path to i18n [extensions/MsUpload] (REL1_24) - 10https://gerrit.wikimedia.org/r/174079 [10:11:33] (03PS5) 10Paladox: Fix path to i18n [extensions/MsUpload] (REL1_24) - 10https://gerrit.wikimedia.org/r/174079 [10:11:48] checkout: also, if you can make sense of that bug, please add your interpretation there. [10:12:06] because the link in that bug looks completely OK to me [10:14:20] valhallasw: still i want to know how did you know in which respository would it lie.If it fine then what should i do.can you tell me about this bug:https://bugzilla.wikimedia.org/show_bug.cgi?id=73253 [10:14:23] 3MediaWiki skins / 3Chameleon: Chameleon / mw-ui-button are utterly large - 10https://bugzilla.wikimedia.org/73509 (10s7eph4n) 5PATC>3RESO/FIX [10:14:35] checkout: it's in the 'mediawiki' project [10:14:44] again, that bug is in the 'mediawiki' project [10:16:14] checkout: specifically, the code for Special:Contributions are at includes/specials/SpecialContributions.php [10:16:44] so how exactly i am supposed to clone this using gerrit [10:16:52] git clone [10:16:58] but from gerrit [10:17:11] checkout: https://www.mediawiki.org/wiki/Gerrit/Tutorial [10:17:41] thanks for helping me [10:17:45] you can also just clone from github -- git-review will set everything up for you when you want to push stuff to gerrit [10:24:22] 3MediaWiki extensions / 3Popups: Pin has an outline and looks like its behind the card - 10https://bugzilla.wikimedia.org/73550 (10Prateek Saxena) 3NEW p:3Unprio s:3normal a:3None Created attachment 17157 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17157&action=edit border over triangle T... [10:27:07] 3MediaWiki extensions / 3Popups: 2 pixels of the text of the last line is visible. - 10https://bugzilla.wikimedia.org/73551 (10Prateek Saxena) 3NEW p:3Unprio s:3normal a:3None Created attachment 17158 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17158&action=edit half cut text visible This... [10:49:00] Use Wikimedia favicon - https://phabricator.wikimedia.org/T273#23057 (10Qgil) I'm not sure about mixing the shape of a brand with the colors of another brand. I have tried with a simplified {F895} but I'm not convinced either. Maybe we just just wait for T96 and use the Phabricator icon with one of the Wikime... [11:11:56] Anyone willing to fetch me the wfDebugLog output for the "Bug40009" log group? [11:12:56] Keen to have this data at least before the next wmf branch tomorrow [11:17:22] 3MediaWiki / 3API: rollback token system is randomly broken - 10https://bugzilla.wikimedia.org/73207 (10Andre Klapper) [11:19:20] 3MediaWiki extensions / 3SemanticForms: Input form autocompletion does not work when data is Korean. (case of 'property=PROPERTY_NAME') - 10https://bugzilla.wikimedia.org/73548 (10Andre Klapper) [11:22:20] 3Code-Review, MediaWiki-Core-Team: Wikimedia code repository browser in Phabricator - https://phabricator.wikimedia.org/T752#23095 (10Qgil) [11:27:35] 3Wikimedia / 3Site requests: Please upload large file to Commons - 10https://bugzilla.wikimedia.org/73549#c2 (10Vera de Kok) 1Veertje [11:30:31] (03PS2) 10Physikerwelt: Create debugging table onLoadExtensionSchemaUpdates [extensions/Math] - 10https://gerrit.wikimedia.org/r/174076 [11:33:29] 3Engineering-Community: Engineering Community team goals for October 2014 - https://phabricator.wikimedia.org/T553#23099 (10Qgil) p:5Normal>3High [11:46:23] Shinken Email notifications should be formatted properly - https://phabricator.wikimedia.org/T1098#23104 (10yuvipanda) 5Open>3Resolved a:3yuvipanda Is better formatted now! [11:47:01] (03Abandoned) 10Physikerwelt: Create debugging table onLoadExtensionSchemaUpdates [extensions/Math] - 10https://gerrit.wikimedia.org/r/174076 (owner: 10Physikerwelt) [11:47:19] (03PS3) 10Physikerwelt: Add logging table [extensions/Math] - 10https://gerrit.wikimedia.org/r/174075 [11:47:21] (03PS9) 10Physikerwelt: Increase size of the math_mathml in the mathlatexml table [extensions/Math] - 10https://gerrit.wikimedia.org/r/171627 (https://bugzilla.wikimedia.org/73090) [11:48:34] (03CR) 10jenkins-bot: [V: 04-1] Add logging table [extensions/Math] - 10https://gerrit.wikimedia.org/r/174075 (owner: 10Physikerwelt) [11:51:20] 3Architecture-RfCs: RfC: Text extraction - https://phabricator.wikimedia.org/T1319#23107 (10Qgil) [11:58:00] Large file upload to Commons please - https://phabricator.wikimedia.org/T1312#23115 (101Veertje) see https://bugzilla.wikimedia.org/show_bug.cgi?id=73549 [11:59:02] (03PS4) 10Physikerwelt: Add logging table [extensions/Math] - 10https://gerrit.wikimedia.org/r/174075 [12:05:33] (03PS1) 10Hashar: Conf for doxygen [cdb] - 10https://gerrit.wikimedia.org/r/174092 (https://bugzilla.wikimedia.org/73530) [12:05:35] (03CR) 10jenkins-bot: [V: 04-1] Conf for doxygen [cdb] - 10https://gerrit.wikimedia.org/r/174092 (https://bugzilla.wikimedia.org/73530) (owner: 10Hashar) [12:05:41] (03PS1) 10Hashar: Use README.md as doxygen main page [cdb] - 10https://gerrit.wikimedia.org/r/174093 (https://bugzilla.wikimedia.org/73530) [12:05:43] (03CR) 10jenkins-bot: [V: 04-1] Use README.md as doxygen main page [cdb] - 10https://gerrit.wikimedia.org/r/174093 (https://bugzilla.wikimedia.org/73530) (owner: 10Hashar) [12:06:39] 3MediaWiki / 3Interface: Mediawiki diff formatting is broken in printer ready display - 10https://bugzilla.wikimedia.org/73544#c1 (10Bartosz Dziewoński) 5UNCO>3NEW (In reply to Chris Davies from comment #0) > Additionally, while it might not be classified as a bug, the new styling for > diffs is just aw... [12:20:40] (03PS1) 10TheDJ: Repair error handling for transcode reset [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/174095 [12:22:37] 3MediaWiki extensions / 3CentralNotice: Can't see or click login button due to fundraising banner - 10https://bugzilla.wikimedia.org/72013#c5 (10Peter Coombe) 5NEW>3RESO/WON That part of the banner only appears when a user's cursor is over the banner. It is the most unobtrusive way we've found to present... [12:24:07] 3MediaWiki / 3Interface: Search bar icon/button slightly lower when html5 mode is enabled - 10https://bugzilla.wikimedia.org/30525#c7 (10Martijn Hoekstra) Is this fixed? It looks fixed for me. [12:24:20] (03PS1) 10Paladox: Updating and debugging the extension [extensions/MsUpload] (REL1_23) - 10https://gerrit.wikimedia.org/r/174096 [12:26:49] (03PS2) 10Paladox: Updating and debugging the extension [extensions/MsUpload] (REL1_23) - 10https://gerrit.wikimedia.org/r/174096 [12:27:19] (03PS1) 10TheDJ: Remove superfluous parseInt() [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/174097 [12:27:58] (03PS1) 10Paladox: Updating and debugging the extension [extensions/MsUpload] (REL1_23) - 10https://gerrit.wikimedia.org/r/174098 [12:28:12] (03Abandoned) 10Paladox: Updating and debugging the extension [extensions/MsUpload] (REL1_23) - 10https://gerrit.wikimedia.org/r/174098 (owner: 10Paladox) [12:28:43] (03CR) 10TheDJ: Make the private modules of TMH pass jshint (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/173513 (owner: 10TheDJ) [12:29:52] (03CR) 10TheDJ: [C: 04-1] "Untested" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/174097 (owner: 10TheDJ) [12:33:53] 3Wikimedia / 3Site requests: Please upload large file to Commons - 10https://bugzilla.wikimedia.org/73553 (10Sandra Fauconnier) 3UNCO p:3Unprio s:3enhanc a:3None I would like to request an upload of a ~150 MB .djvu file to Commons. * The .djvu file can be publicly accessed here: https://googledrive... [12:34:56] (03CR) 10TheDJ: "@nemo http://caniuse.com/#feat=indexeddb" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/159626 (https://bugzilla.wikimedia.org/73241) (owner: 10TheDJ) [12:35:40] (03PS1) 10Paladox: Updating and debugging the extension [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/174099 [12:35:42] (03CR) 10jenkins-bot: [V: 04-1] Updating and debugging the extension [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/174099 (owner: 10Paladox) [12:36:04] (03Abandoned) 10Paladox: Updating and debugging the extension [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/174099 (owner: 10Paladox) [12:36:26] (03PS1) 10Paladox: Updating and debugging the extension [extensions/MsUpload] (REL1_23) - 10https://gerrit.wikimedia.org/r/174100 [12:37:06] 3MediaWiki extensions / 3CentralNotice: Can't see or click login button due to fundraising banner - 10https://bugzilla.wikimedia.org/72013#c6 (10Nemo) 5RESO/WON>3REOP (In reply to Peter Coombe from comment #5) > suggestions for a better > way to do it are always welcome. * Not using the full width, so t... [12:38:07] (03Abandoned) 10Paladox: Updating and debugging the extension [extensions/MsUpload] (REL1_23) - 10https://gerrit.wikimedia.org/r/174096 (owner: 10Paladox) [12:41:44] (03PS1) 10Bartosz Dziewoński: mediawiki.action.history.diff: Rework print styles [core] - 10https://gerrit.wikimedia.org/r/174101 (https://bugzilla.wikimedia.org/73544) [12:42:01] (03PS1) 10Paladox: Update msupload.i18n.php and fix issue with .gitreview [extensions/MsUpload] (REL1_23) - 10https://gerrit.wikimedia.org/r/174102 [12:42:03] (03CR) 10jenkins-bot: [V: 04-1] Update msupload.i18n.php and fix issue with .gitreview [extensions/MsUpload] (REL1_23) - 10https://gerrit.wikimedia.org/r/174102 (owner: 10Paladox) [12:44:53] (03PS2) 10Paladox: Update msupload.i18n.php and fix issue with .gitreview [extensions/MsUpload] (REL1_23) - 10https://gerrit.wikimedia.org/r/174102 [12:44:55] (03CR) 10jenkins-bot: [V: 04-1] Update msupload.i18n.php and fix issue with .gitreview [extensions/MsUpload] (REL1_23) - 10https://gerrit.wikimedia.org/r/174102 (owner: 10Paladox) [12:45:07] (03PS3) 10Paladox: Update msupload.i18n.php and fix issue with .gitreview [extensions/MsUpload] (REL1_23) - 10https://gerrit.wikimedia.org/r/174102 [12:57:31] (03PS1) 10Paladox: Updating and debugging the extension [extensions/MsUpload] (REL1_23) - 10https://gerrit.wikimedia.org/r/174104 [12:57:49] (03PS2) 10Paladox: Updating and debugging the extension [extensions/MsUpload] (REL1_23) - 10https://gerrit.wikimedia.org/r/174104 [13:00:06] (03PS1) 10Lubaochuan: WIP added the simplest test for view history link [core] - 10https://gerrit.wikimedia.org/r/174105 [13:04:59] (03CR) 10TheDJ: mediawiki.action.history.diff: Rework print styles (031 comment) [core] - 10https://gerrit.wikimedia.org/r/174101 (https://bugzilla.wikimedia.org/73544) (owner: 10Bartosz Dziewoński) [13:06:59] (03CR) 10Bartosz Dziewoński: mediawiki.action.history.diff: Rework print styles (031 comment) [core] - 10https://gerrit.wikimedia.org/r/174101 (https://bugzilla.wikimedia.org/73544) (owner: 10Bartosz Dziewoński) [13:08:03] (03PS3) 10Paladox: Updating and debugging the extension [extensions/MsUpload] (REL1_23) - 10https://gerrit.wikimedia.org/r/174104 [13:08:12] (03CR) 10Krinkle: mediawiki.api: Use action=query&meta=tokens instead of action=tokens (034 comments) [core] - 10https://gerrit.wikimedia.org/r/166872 (https://bugzilla.wikimedia.org/72094) (owner: 10Gerrit Patch Uploader) [13:08:18] (03CR) 10Krinkle: [C: 04-1] mediawiki.api: Use action=query&meta=tokens instead of action=tokens [core] - 10https://gerrit.wikimedia.org/r/166872 (https://bugzilla.wikimedia.org/72094) (owner: 10Gerrit Patch Uploader) [13:08:25] Incorrect status for imported Bugzilla ticket in Preview Instance - https://phabricator.wikimedia.org/T686#23122 (10Aklapper) [13:08:28] (03PS4) 10Paladox: Updating and debugging the extension [extensions/MsUpload] (REL1_23) - 10https://gerrit.wikimedia.org/r/174104 [13:09:50] (03Abandoned) 10Paladox: Updating and debugging the extension [extensions/MsUpload] (REL1_23) - 10https://gerrit.wikimedia.org/r/174100 (owner: 10Paladox) [13:10:12] (03PS2) 10Lubaochuan: WIP added the simplest test for view history link [core] - 10https://gerrit.wikimedia.org/r/174105 [13:17:28] (03PS18) 10Paladox: Fix path to i18n [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/174071 [13:17:58] (03PS19) 10Paladox: Fix path to i18n [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/174071 [13:18:10] (03PS20) 10Paladox: Fix path to i18n [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/174071 [13:19:58] (03CR) 10Krinkle: API: Overhaul token handling (033 comments) [core] - 10https://gerrit.wikimedia.org/r/153110 (owner: 10Anomie) [13:20:12] (03PS6) 10Paladox: Fix path to i18n [extensions/MsUpload] (REL1_24) - 10https://gerrit.wikimedia.org/r/174079 [13:20:27] (03PS7) 10Paladox: Fix path to i18n [extensions/MsUpload] (REL1_24) - 10https://gerrit.wikimedia.org/r/174079 [13:20:47] (03PS8) 10Paladox: Fix path to i18n [extensions/MsUpload] (REL1_24) - 10https://gerrit.wikimedia.org/r/174079 [13:24:35] (03CR) 10Krinkle: "FIXME: This is adding a strange 'batchcomplete' property to requests like api.php?action=watch." [core] - 10https://gerrit.wikimedia.org/r/152359 (owner: 10Anomie) [13:26:16] (03PS1) 10Paladox: Update .gitreview [extensions/MsUpload] (REL1_22) - 10https://gerrit.wikimedia.org/r/174111 [13:26:18] (03CR) 10jenkins-bot: [V: 04-1] Update .gitreview [extensions/MsUpload] (REL1_22) - 10https://gerrit.wikimedia.org/r/174111 (owner: 10Paladox) [13:26:40] (03CR) 10Gilles: [C: 032] Repair error handling for transcode reset [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/174095 (owner: 10TheDJ) [13:26:53] (03Merged) 10jenkins-bot: Repair error handling for transcode reset [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/174095 (owner: 10TheDJ) [13:27:35] (03PS2) 10Paladox: Update .gitreview [extensions/MsUpload] (REL1_22) - 10https://gerrit.wikimedia.org/r/174111 [13:27:50] (03PS3) 10Paladox: Update .gitreview [extensions/MsUpload] (REL1_22) - 10https://gerrit.wikimedia.org/r/174111 [13:38:15] (03Abandoned) 10Krinkle: Send a cookie with autoblocks to prevent vandalism. [core] - 10https://gerrit.wikimedia.org/r/48029 (https://bugzilla.wikimedia.org/3233) (owner: 10Parent5446) [13:39:37] (03CR) 10Krinkle: "Story here? Is there a use case pending and/or satisfied by other solutions?" [core] - 10https://gerrit.wikimedia.org/r/53189 (owner: 10Platonides) [13:43:07] (03PS5) 10Robert Vogel: [WIP] Implementing CR and community feedback [extensions/Teahouse] - 10https://gerrit.wikimedia.org/r/173014 [13:44:18] (03CR) 10Krinkle: [C: 04-1] "Hm.. I'm not convinced this would provide a net benefit. It won't enforce any new security rules. Our other measures should be good enough" [core] - 10https://gerrit.wikimedia.org/r/65418 (https://bugzilla.wikimedia.org/38417) (owner: 10Parent5446) [13:50:38] (03PS1) 10Paladox: Updating MsUpload to 9.5.1 [extensions/MsUpload] (REL1_22) - 10https://gerrit.wikimedia.org/r/174115 [13:50:50] 3MediaWiki / 3JavaScript: mw.api.getToken should not use deprecated api.php?action=tokens - 10https://bugzilla.wikimedia.org/72094 (10Krinkle) [13:50:53] (03PS2) 10Paladox: Updating MsUpload to 9.5.1 [extensions/MsUpload] (REL1_22) - 10https://gerrit.wikimedia.org/r/174115 [13:53:47] (03CR) 10Raimond Spekking: "Removing myself from release branches. I am not familiar with merging rules for release branches" [extensions/MsUpload] (REL1_22) - 10https://gerrit.wikimedia.org/r/174115 (owner: 10Paladox) [13:54:40] (03CR) 10Krinkle: "Yes, and these are not dependencies for MediaWiki core, but rather for a subset of vey specific tests most developers do not run locally. " [core] - 10https://gerrit.wikimedia.org/r/167794 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [13:54:50] 3Wikimedia / 3Site requests: Please upload large file to Commons - 10https://bugzilla.wikimedia.org/73549#c3 (10Dereckson) We need for each video a text file containing the Wikimedia Commons page initial content, with the {{Information}} or other relevant template, categories, etc. The script will then add... [13:57:36] (03PS1) 10Krinkle: autoloader: Remove incorrect documentation comment [core] - 10https://gerrit.wikimedia.org/r/174117 [13:57:52] 3Wikimedia / 3Site requests: Please upload large file to Commons - 10https://bugzilla.wikimedia.org/73549#c4 (10Dereckson) Oh, and we also need an URL we can wget from the server. Google Docs doesn't satisfy this condition. [13:58:25] (03CR) 10Krinkle: Generate $wgAutoloadLocalClasses with a maint script (031 comment) [core] - 10https://gerrit.wikimedia.org/r/163304 (owner: 10EBernhardson) [13:58:32] (03PS3) 10Krinkle: ResourceLoader: Stop passing around errors as /**/-comments [core] - 10https://gerrit.wikimedia.org/r/172591 (owner: 10Bartosz Dziewoński) [13:58:36] (03PS1) 10Gilles: Backport Media Viewer bugfixes [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174118 [14:00:17] (03PS3) 10Paladox: Updating MsUpload to 9.5.1 [extensions/MsUpload] (REL1_22) - 10https://gerrit.wikimedia.org/r/174115 [14:00:52] (03PS4) 10Paladox: Updating MsUpload to 9.5.1 [extensions/MsUpload] (REL1_22) - 10https://gerrit.wikimedia.org/r/174115 [14:01:52] 3MediaWiki extensions / 3SemanticForms: SF Incorrect page name "Some very long page name that will hopefully never get created ABCDEF123" appearing - 10https://bugzilla.wikimedia.org/51479#c23 (10Tiago Ferreira) Hi, I'm new to SMW and MW development but, apart from the deprecation of $wgTitle how dirty is t... [14:02:21] 3Wikimedia / 3Site requests: Please upload large file to Commons - 10https://bugzilla.wikimedia.org/73549#c5 (10Dereckson) Comment 2 issue is addressed, the text files are provided in the archive. [14:02:45] (03CR) 10Krinkle: "Reverted in c6181662499ab8f44ae760dc4dcda651d8afd3c5." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/97454 (https://bugzilla.wikimedia.org/35342) (owner: 10M4tx) [14:04:10] (03PS5) 10Paladox: Updating MsUpload to 9.5.1 [extensions/MsUpload] (REL1_22) - 10https://gerrit.wikimedia.org/r/174115 [14:04:25] (03PS6) 10Paladox: Updating MsUpload to 9.5.1 [extensions/MsUpload] (REL1_22) - 10https://gerrit.wikimedia.org/r/174115 [14:04:58] (03PS6) 10Krinkle: split up internalAttemptSave [core] - 10https://gerrit.wikimedia.org/r/141113 (owner: 10Awight) [14:13:36] 3MediaWiki extensions / 3SemanticForms: SF Incorrect page name "Some very long page name that will hopefully never get created ABCDEF123" appearing - 10https://bugzilla.wikimedia.org/51479#c24 (10s7eph4n) I would expect this to result in the Title of the page containing the redlink being used as the title of... [14:24:14] (03CR) 10Paladox: "@Raimond Spekking this is just fixes for .gitreview and msupload.i18n.php that should have been updated before 1.23 released." [extensions/MsUpload] (REL1_23) - 10https://gerrit.wikimedia.org/r/174102 (owner: 10Paladox) [14:25:14] (03PS5) 10Paladox: Updating and debugging the extension [extensions/MsUpload] (REL1_23) - 10https://gerrit.wikimedia.org/r/174104 [14:27:29] (03CR) 10Raimond Spekking: "Please stop adding me as reviewer for release branches. Thanks." [extensions/MsUpload] (REL1_23) - 10https://gerrit.wikimedia.org/r/174104 (owner: 10Paladox) [14:28:37] (03PS7) 10Paladox: Updating MsUpload to 9.5.1 [extensions/MsUpload] (REL1_22) - 10https://gerrit.wikimedia.org/r/174115 [14:30:03] (03CR) 10Paladox: "Oh ok." [extensions/MsUpload] (REL1_23) - 10https://gerrit.wikimedia.org/r/174104 (owner: 10Paladox) [14:32:11] Create projects for Pywikibot's compat and core versions, and assign the corresponding tasks to each - https://phabricator.wikimedia.org/T1282#23133 (10Aklapper) [14:34:43] (03CR) 10Paladox: "@Raimond Spekking please merge this because it uses twitters old api that they switched off and now has the new link to there api." [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/151640 (owner: 10Paladox) [14:38:30] (03CR) 10Hashar: "Timo, if that file confuses you feel free to add a comment at the top of it explaining its purpose and pointing to https://www.mediawiki.o" [core] - 10https://gerrit.wikimedia.org/r/167794 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [14:38:41] (03PS1) 10Anomie: Fix SecurePollContent handling [extensions/SecurePoll] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174125 [14:38:54] (03CR) 10Anomie: [C: 032] "Backport" [extensions/SecurePoll] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174125 (owner: 10Anomie) [14:39:04] (03Merged) 10jenkins-bot: Fix SecurePollContent handling [extensions/SecurePoll] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174125 (owner: 10Anomie) [14:39:30] (03CR) 10Raimond Spekking: "@Paladox: This patch set changes more than an URL. I feel not comfortable to merge it without testing it (for which I do not have time)." [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/151640 (owner: 10Paladox) [14:41:06] 3Wikimedia / 3Site requests: Please upload large file to Commons - 10https://bugzilla.wikimedia.org/73553#c1 (10Andre Klapper) Hi Sandra, you could try to use https://commons.wikimedia.org/wiki/Commons:Chunked_uploads which allows file sizes up to 1GB and upload yourself. :) [14:43:36] 3MediaWiki / 3General/Unknown: ApiFormatWddxTest::testValidSyntax fails in mediawiki-core-regression-hhvm-master test - 10https://bugzilla.wikimedia.org/73531 (10Andre Klapper) p:5Unprio>3Normal [14:43:51] 3MediaWiki / 3User login and signup: Equal sign (=) is not considered a prohibited character when creating an account - 10https://bugzilla.wikimedia.org/73518 (10Andre Klapper) 5UNCO>3NEW p:5Unprio>3Low s:5minor>3enhanc [14:44:23] 3Wikimedia / 3Git/Gerrit: Gerrit web interface is down - 10https://bugzilla.wikimedia.org/73555 (10Antoine "hashar" Musso (WMF)) 3NEW p:3Unprio s:3normal a:3None Guice provision errors: 1) Cannot open ReviewDb at com.google.gerrit.server.util.ThreadLocalRequestContext$1.provideReviewDb(ThreadLocal... [14:48:51] 3Wikimedia / 3Git/Gerrit: [OPS] db1020.eqiad.wmnet is down (impacts Gerrit, OTRS, EventLogging) - 10https://bugzilla.wikimedia.org/73555#c1 (10Antoine "hashar" Musso (WMF)) According to puppet, Gerrit uses the DB 'm2-master.eqiad.wmnet' From site.pp: ## m2 shard node /^db10(20)\.eqiad\.wmnet/ { Mysqld... [14:50:37] 3Wikimedia / 3Git/Gerrit: [OPS] db1020.eqiad.wmnet is down (impacts Gerrit, OTRS, EventLogging) - 10https://bugzilla.wikimedia.org/73555 (10Glaisher) p:5Unprio>3High s:5normal>3blocke [14:50:55] 3MediaWiki / 3JavaScript: PHP Notice: Uninitialized string offset: includes/libs/JavaScriptMinifier.php on line 571 - 10https://bugzilla.wikimedia.org/73556 (10Nemo) 3NEW p:3Unprio s:3normal a:3None -rakkaus:#mediawiki-i18n- [18-Nov-2014 14:18:47 UTC] PHP Notice: Uninitialized string offset: 710 in... [14:50:55] 3MediaWiki / 3General/Unknown: Bugs affecting translatewiki.net (errors from MediaWiki master) (tracking) - 10https://bugzilla.wikimedia.org/39480 (10Nemo) [14:52:53] 3MediaWiki extensions / 3SemanticForms: SF Incorrect page name "Some very long page name that will hopefully never get created ABCDEF123" appearing - 10https://bugzilla.wikimedia.org/51479#c25 (10s7eph4n) No, you are right. However, try the following: 1. Have a property that creates pages (e.g. call it some... [14:54:48] (03PS1) 10Anomie: Update SecurePoll with [[gerrit:174125]] [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174126 [14:56:21] 3Wikimedia / 3Git/Gerrit: [OPS] db1020.eqiad.wmnet is down (impacts Gerrit, OTRS, EventLogging) - 10https://bugzilla.wikimedia.org/73555#c2 (10Antoine "hashar" Musso (WMF)) !log fail over m2 to m2-slave (db1046); investigating db1020 [14:57:06] 3Wikimedia / 3Git/Gerrit: [OPS] db1020.eqiad.wmnet is down (impacts Gerrit, OTRS, EventLogging) - 10https://bugzilla.wikimedia.org/73555#c3 (10Antoine "hashar" Musso (WMF)) 5NEW>3RESO/FIX Gerrit is back, using the other mysql server now. Sean Pringle is investigating db1020 failure. Not much help to do... [14:59:41] 3Engineering-Community: Prepare Wikimedia's participation in Google Code-In - https://phabricator.wikimedia.org/T561#23135 (10Palexis) @Aklapper, I did not receive the instructions to register and cannot find the link. Mark hasn't registered yet so we need to get moving quickly. Thanks. [15:01:46] (03CR) 10Anomie: API: Overhaul token handling (033 comments) [core] - 10https://gerrit.wikimedia.org/r/153110 (owner: 10Anomie) [15:01:53] (03CR) 10Paladox: "Ok" [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/151640 (owner: 10Paladox) [15:05:38] 3MediaWiki / 3JavaScript: PHP Notice: Uninitialized string offset: includes/libs/JavaScriptMinifier.php on line 571 - 10https://bugzilla.wikimedia.org/73556#c1 (10Krinkle) Excerpt: class JavaScriptMinifier { public static function minify( $s, $statementsOnOwnLine = false, $maxLineLength = 1000 ) { /... [15:07:59] (03PS1) 10Gilles: filebackend: Log more details about backend-fail-internal errors [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174128 (https://bugzilla.wikimedia.org/73094) [15:08:18] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/92621 (owner: 10Hashar) [15:08:32] (03PS2) 10Seb35: Style tweaks [extensions/HSTS] - 10https://gerrit.wikimedia.org/r/170642 (owner: 10Reedy) [15:08:45] (03CR) 10GOIII: [C: 031] "Thanks Anomie. Lets get this merged already." [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/173104 (https://bugzilla.wikimedia.org/73281) (owner: 10TheDJ) [15:15:26] (03CR) 10Seb35: [C: 032 V: 032] "Thanks Reedy for this!" [extensions/HSTS] - 10https://gerrit.wikimedia.org/r/170642 (owner: 10Reedy) [15:15:33] (03CR) 10Brent Garber: "IIRC This bug was the end result result of the "Bad Images List should be renamed" drama from last year." [core] - 10https://gerrit.wikimedia.org/r/53189 (owner: 10Platonides) [15:16:21] 3MediaWiki / 3ResourceLoader: PHP Notice: Uninitialized string offset: includes/libs/JavaScriptMinifier.php on line 571 - 10https://bugzilla.wikimedia.org/73556 (10Bartosz Dziewoński) [15:17:39] (03PS2) 10Umherirrender: Add batch lookup for user groups on Special:ListUsers [core] - 10https://gerrit.wikimedia.org/r/171846 [15:18:05] (03PS2) 10Umherirrender: Remove unneeded fields from query in Special:ListUsers [core] - 10https://gerrit.wikimedia.org/r/171848 [15:29:08] 3Wikimedia / 3Bugzilla: Component for new extension ApiFeatureUsage - 10https://bugzilla.wikimedia.org/73557 (10Brad Jorsch) 3NEW p:3Unprio s:3normal a:3None Gerrit repo requested at https://www.mediawiki.org/w/index.php?title=Git/New_repositories/Requests/Entries&diff=prev&oldid=1268800 Product: Me... [15:37:10] (03CR) 10Stephenliang: "Hey there, I'm reusing a variable that already exists in SpecialUserLogin.php, if you see on line 185 the variable 'fromhttp' is the one t" [core] - 10https://gerrit.wikimedia.org/r/165080 (https://bugzilla.wikimedia.org/71716) (owner: 10Stephenliang) [15:41:29] (03CR) 10Stephenliang: "Also, fromhttp is used in a variety of places during login as a get parameter (such as when you're going from http to https when trying to" [core] - 10https://gerrit.wikimedia.org/r/165080 (https://bugzilla.wikimedia.org/71716) (owner: 10Stephenliang) [15:47:33] 3Engineering-Community: Prepare Wikimedia's participation in Google Code-In - https://phabricator.wikimedia.org/T561#23142 (10Aklapper) @Palexis: Please see https://www.mediawiki.org/wiki/Google_Code-in_2014#Mentors.27_corner and send me a private email to aklapper@wm.o if you need any help. Thank you! [15:54:07] (03CR) 10Manybubbles: [C: 032] Don't wait for completion. It can take a long time for big indexes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/173309 (owner: 10Chad) [15:54:39] (03Merged) 10jenkins-bot: Don't wait for completion. It can take a long time for big indexes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/173309 (owner: 10Chad) [15:56:21] 3Wikimedia / 3Bugzilla: Component for new extension ApiFeatureUsage - 10https://bugzilla.wikimedia.org/73557#c1 (10Andre Klapper) 5NEW>3RESO/FIX a:3Andre Klapper Created [16:03:22] 3Release-Engineering: browser tests for mediawiki core should be running after every commit - https://phabricator.wikimedia.org/T1320 (10zeljkofilipin) 3NEW p:3Low [16:03:44] (03CR) 10Krinkle: "I found a difference on https://ur.wikipedia.org/wiki/%D8%B5%D8%A7%D8%B1%D9%81:%D8%A7%D9%85%DB%8C%D9%86_%D8%A7%DA%A9%D8%A8%D8%B1/vector.cs" [core] - 10https://gerrit.wikimedia.org/r/164735 (owner: 10Amire80) [16:03:51] (03CR) 10Anomie: [C: 032] "SWAT" [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174128 (https://bugzilla.wikimedia.org/73094) (owner: 10Gilles) [16:05:39] (03CR) 10Anomie: [C: 032] "Yes, let's." [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/173104 (https://bugzilla.wikimedia.org/73281) (owner: 10TheDJ) [16:06:50] 3Wikimedia / 3Site requests: Enable VisualEditor in ca.wikiquote.org - 10https://bugzilla.wikimedia.org/73483#c5 (10James Forrester) 5PATC>3RESO/FIX Now done: https://ca.wikiquote.org/w/index.php?title=Especial:Canvis_recents&tagfilter=visualeditor [16:09:37] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: some words are getting jammed together - 10https://bugzilla.wikimedia.org/73558 (10Nik Everett) 3NEW p:3Unprio s:3normal a:3None This search for 11st: https://en.wikipedia.org/w/index.php?title=Special%3ASearch&profile=advanced&search=%2211st%22+-%... [16:13:50] 3MediaWiki / 3History/Diffs: Diffs for meta-data changes (Protect/Move/ContentHandler type) should show something useful, not "No difference". - 10https://bugzilla.wikimedia.org/73546#c1 (10Umherirrender) "No difference" is correct because a move or protect produce a null revision which points to the same te... [16:17:39] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Prefix search should normalize dashes to spaces and ’ to ' - 10https://bugzilla.wikimedia.org/73560 (10Nik Everett) 3NEW p:3Unprio s:3normal a:3None Prefix search should normalize dashes to spaces and ’ to '. Note: the direction of the normalizati... [16:17:52] 3Release-Engineering: browsertests-VisualEditor-language-screenshot jenkins job failing - https://phabricator.wikimedia.org/T1321 (10zeljkofilipin) 3NEW p:3Normal a:3zeljkofilipin [16:18:15] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Prefix search should normalize dashes to spaces and ’ to ' - 10https://bugzilla.wikimedia.org/73560#c1 (10Nik Everett) Rather, I mean that when searching for one of them you should find the other. [16:18:21] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Prefix search should normalize dashes to spaces and ’ to ' - 10https://bugzilla.wikimedia.org/73560 (10Nik Everett) p:5Unprio>3High [16:20:06] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: some words are getting jammed together - 10https://bugzilla.wikimedia.org/73558#c1 (10Nik Everett) p:5Unprio>3High Prioritizing high because I think this is effecting lots of places. Also fixing it'll be interesting because some HTML should constitute... [16:40:20] Reedy: can you give rtnpro autoconfirmed on mw.org? [16:40:24] new dev, wants to play with quarry :) [16:40:29] legoktm: ^ [16:40:32] other mw.org admins too? [16:51:35] YuviPanda: you'll need a crat for this [16:51:43] MatmaRex: oh? [16:51:50] apparently [16:52:02] who are the crats? [16:52:04] i'm a sysop and can't do it [16:52:18] https://www.mediawiki.org/wiki/Special:ListUsers/bureaucrat [16:52:22] tons of 'em [16:52:26] MatmaRex: can you do confirmed? [16:52:38] no, that's what i meant. i'm sure no one can do autoconfirmed at all :) [16:53:13] (i can do autoreview and ipblock-exempt only) [16:53:17] ^d: can you make User:rtnpro confirmed on mw.org? [16:53:23] 3Code-Review, MediaWiki-Core-Team: Wikimedia code repository browser in Phabricator - https://phabricator.wikimedia.org/T752#23167 (10Chad) [16:53:54] ^d: is helping with writing code for quarry [16:54:22] <^d> We don't have confirmed as an explicit group on mw.org [16:54:37] <^d> bleh, "groups you cannot change" [16:54:42] YuviPanda, it says: You do not have permission to propose new OAuth consumers, for the following reason: The action you have requested is limited to users in one of the groups: Autoconfirmed users, Confirmed users. [16:54:52] so that's what he got when trying to get an oauth app in [16:55:09] ONly stewards can change that [16:55:47] >> $user->addGroup('confirmed'); [16:55:48] MatmaRex: SyntaxError: Unexpected token > [16:55:51] :> [16:55:55] hahahahahaha [16:56:33] lol [16:57:24] let's hook up ecmabot-wm to eval.php on terbium [16:57:51] 3Wikimedia / 3Site requests: Enable VisualEditor in ca.wikiquote.org - 10https://bugzilla.wikimedia.org/73483#c6 (10Quim Gil) 5RESO/FIX>3REOP PLEASE REVERT THIS CHANGE ASAP Something very weird is happening. In all pages "}}}}}}" appears instead of quotes. I mean all pages, not the ones edited with VE.... [16:58:20] 3MediaWiki extensions / 3SyntaxHighlight (GeSHi): Lua syntax highlighting doesn't recognize comments properly - 10https://bugzilla.wikimedia.org/73281#c7 (10Brad Jorsch) 5PATC>3RESO/FIX This should be deployed to WMF wikis with 1.25wmf9, see https://www.mediawiki.org/wiki/MediaWiki_1.25/Roadmap for the s... [17:00:22] (03CR) 10GWicke: [C: 032] Increase size of the math_mathml in the mathlatexml table [extensions/Math] - 10https://gerrit.wikimedia.org/r/171627 (https://bugzilla.wikimedia.org/73090) (owner: 10Physikerwelt) [17:00:30] (03Merged) 10jenkins-bot: Increase size of the math_mathml in the mathlatexml table [extensions/Math] - 10https://gerrit.wikimedia.org/r/171627 (https://bugzilla.wikimedia.org/73090) (owner: 10Physikerwelt) [17:02:35] 3Wikimedia / 3Site requests: Enable VisualEditor in ca.wikiquote.org - 10https://bugzilla.wikimedia.org/73483#c7 (10Glaisher) This was due to an edit to the {{Cita}} template. I've reverted it. https://ca.wikiquote.org/w/index.php?title=Plantilla:Cita&diff=50689 [17:03:15] (03CR) 10CSteipp: "Yeah, I'd actually like to specifically keep fromhttp (the GET param) and the POST param separate, even though they both should set mFromH" [core] - 10https://gerrit.wikimedia.org/r/165080 (https://bugzilla.wikimedia.org/71716) (owner: 10Stephenliang) [17:03:20] 3Wikimedia / 3Site requests: Enable VisualEditor in ca.wikiquote.org - 10https://bugzilla.wikimedia.org/73483 (10Brad Jorsch) 5REOP>3RESO/FIX [17:05:20] 3Wikimedia / 3Site requests: Enable VisualEditor in ca.wikiquote.org - 10https://bugzilla.wikimedia.org/73483#c8 (10Quim Gil) Indeed. Sorry for the mistake and thank you for fixing it so quick. [17:09:04] 3Team-Practices: Schedule time for Kristen/Grace to chat - https://phabricator.wikimedia.org/T1306#23171 (10KLans_WMF) [17:14:58] (03PS1) 10Krinkle: diff: Fill background of transparent cells with white [core] - 10https://gerrit.wikimedia.org/r/174145 [17:16:09] (03CR) 10Krinkle: "Screenshot of bug on mediawiki.org: http://i.imgur.com/d4EUoqO.png" [core] - 10https://gerrit.wikimedia.org/r/174145 (owner: 10Krinkle) [17:19:21] 3Librarization: Test monolog logging provider in beta - https://phabricator.wikimedia.org/T845#23181 (10bd808) a:3bd808 [17:19:32] 3Librarization: Test monolog logging provider in beta - https://phabricator.wikimedia.org/T845#14269 (10bd808) [17:20:53] So.... why *is* the Manual namespace light purple on mediawiki.org? [17:21:08] (03CR) 10Bartosz Dziewoński: "White background was recently removed in 42583e9558920067040b1ce9014766a222e9a31b." [core] - 10https://gerrit.wikimedia.org/r/174145 (owner: 10Krinkle) [17:22:18] cscott: re: that SSH key for Travis integration, would it work with a passphrase on the key? [17:23:35] 3MediaWiki extensions / 3WikimediaMessages: A missing condition in templates - 10https://bugzilla.wikimedia.org/73387#c1 (10Glaisher) +CC Luis Villa from WMF Legal [17:23:48] Hi. I am getting the following error on my mediawiki-vagrant install: [17:23:50] Notice: Constant GESHI_VERSION already defined in /vagrant/mediawiki/extensions/SyntaxHighlight_GeSHi/geshi/geshi.php on line 44 [17:24:05] Anybody else having this problem? [17:25:39] (03CR) 10BearND: "How is this batchcomplete property supposed to be used by the client? To me it seem that it's always set to empty string. In our Android c" [core] - 10https://gerrit.wikimedia.org/r/152359 (owner: 10Anomie) [17:37:52] 3Wikimedia / 3Site requests: Please upload large file to Commons - 10https://bugzilla.wikimedia.org/73549#c6 (10Vera de Kok) Direct link: veradekok.nl/analyzer.zip [17:38:52] YuviPanda: sure, what's the username? [17:39:03] oh [17:39:04] nvm [17:39:21] (03PS5) 10Physikerwelt: Disable overwriting of the fallback image [extensions/Math] - 10https://gerrit.wikimedia.org/r/170643 (https://bugzilla.wikimedia.org/72626) [17:40:36] 3Wikimedia / 3Site requests: Complete unification of all accounts to SUL - 10https://bugzilla.wikimedia.org/35707 (10Keegan Peterzell) a:5Keegan Peterzell>3Kunal Mehta (Legoktm) [17:40:58] (03CR) 10Paladox: "@Raimond Spekking could you merged. This is changing branch from master to REL1_22" [extensions/MsUpload] (REL1_22) - 10https://gerrit.wikimedia.org/r/174111 (owner: 10Paladox) [17:41:37] (03PS3) 10Physikerwelt: LaTeXML: prevent automatic rerendering of SVG [extensions/Math] - 10https://gerrit.wikimedia.org/r/174074 [17:42:36] mutante: i don't think so. i think ssh is smart enough not to allow piped input when it is asking for a passphrase. [17:42:49] (03CR) 10Isarra: [C: 04-1] "Specifying a white background assumes that the overall theme (skin) uses a white background. This is not a valid assumption." [core] - 10https://gerrit.wikimedia.org/r/174145 (owner: 10Krinkle) [17:42:59] mutante: so there would be no way to use the key from within jenkins or any other automation. [17:43:24] 3Multimedia: Review existing JS error logging solutions - https://phabricator.wikimedia.org/T525#23184 (10Gilles) I think that raven uses TraceKit. But beyond the very low-level tools, since the entire Sentry stack is open source, I think the easiest first step is to set up Sentry on labs, use it to track errors... [17:43:36] mutante: and anyway it's not clear that having 'echo PASSPHRASE | git push foo bar' in the public jenkins repo would add any security over just having no passphrase. [17:43:46] (03CR) 10Krinkle: "Specifying a light shade border color around the text assumes as much as well. How is that any different? Look at the screenshot. Got a be" [core] - 10https://gerrit.wikimedia.org/r/174145 (owner: 10Krinkle) [17:44:05] cscott: i see.. yea [17:44:52] (03CR) 10Krinkle: "If you find it acceptable that dark skins will override that behaviour, then they can override that background, too; Right?" [core] - 10https://gerrit.wikimedia.org/r/174145 (owner: 10Krinkle) [17:45:25] gi11es: I believe we already have a sentry instance set up in beta labs. [17:45:37] (03CR) 10Isarra: "Cool. Got a big red thing in the html one, though." [core] - 10https://gerrit.wikimedia.org/r/174101 (https://bugzilla.wikimedia.org/73544) (owner: 10Bartosz Dziewoński) [17:45:46] legoktm_: ah, excellent. what has it been used for? [17:46:35] I think we tried using it to aggregate hhvm error logs, but I don't know if it was actually used by anyone. [17:48:15] 3Release-Engineering: browsertests-VisualEditor-language-screenshot jenkins job failing - https://phabricator.wikimedia.org/T1321#23186 (10hashar) [17:48:27] (03PS2) 10Bartosz Dziewoński: mediawiki.action.history.diff: Rework print styles [core] - 10https://gerrit.wikimedia.org/r/174101 (https://bugzilla.wikimedia.org/73544) [17:48:39] (03PS1) 10Physikerwelt: Add logging table [extensions/Math] (debug) - 10https://gerrit.wikimedia.org/r/174155 [17:49:30] (03PS1) 10Physikerwelt: Add debuging functionality [extensions/Math] (debug) - 10https://gerrit.wikimedia.org/r/174156 [17:50:38] (03CR) 10Krinkle: "Removing reviews. None of us have anything to do with this third-party extension not used by us." [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/174071 (owner: 10Paladox) [17:50:58] (03CR) 10Isarra: "A border around the text does not affect the legibility of the text itself; a background does." [core] - 10https://gerrit.wikimedia.org/r/174145 (owner: 10Krinkle) [17:51:12] (03CR) 10Physikerwelt: [C: 032] Add logging table [extensions/Math] (debug) - 10https://gerrit.wikimedia.org/r/174155 (owner: 10Physikerwelt) [17:52:02] (03CR) 10Krinkle: "I know. How does adding the background color make it less legible? Should this module specify the text color being black as well (or #2525" [core] - 10https://gerrit.wikimedia.org/r/174145 (owner: 10Krinkle) [17:52:28] (03Merged) 10jenkins-bot: Add logging table [extensions/Math] (debug) - 10https://gerrit.wikimedia.org/r/174155 (owner: 10Physikerwelt) [17:54:15] (03CR) 10Physikerwelt: [C: 04-2] "gwicke suggested to track problems server side." [extensions/Math] - 10https://gerrit.wikimedia.org/r/174075 (owner: 10Physikerwelt) [17:54:33] (03CR) 10Krinkle: Use event binding from a module instead of inline javascript (031 comment) [extensions/CharInsert] - 10https://gerrit.wikimedia.org/r/152076 (https://bugzilla.wikimedia.org/9424) (owner: 10Helder.wiki) [17:54:56] (03PS2) 10Physikerwelt: Add debuging functionality [extensions/Math] (debug) - 10https://gerrit.wikimedia.org/r/174156 [17:55:30] (03CR) 10Isarra: "For an extreme example, white text on white background is not legible. I'm not sure how to explain that any better." [core] - 10https://gerrit.wikimedia.org/r/174145 (owner: 10Krinkle) [17:55:40] (03CR) 10Physikerwelt: [C: 04-2] "see https://gerrit.wikimedia.org/r/#/c/174075/" [extensions/Math] - 10https://gerrit.wikimedia.org/r/174141 (owner: 10Physikerwelt) [17:56:11] (03PS5) 10Physikerwelt: Add support for display and ID attributes to VisualEditor [extensions/Math] - 10https://gerrit.wikimedia.org/r/172751 (owner: 10Esanders) [17:56:39] (03PS1) 10Umherirrender: Use Parser::OT_HTML class const [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/174158 [17:56:41] (03CR) 10Physikerwelt: [C: 032] Add debuging functionality [extensions/Math] (debug) - 10https://gerrit.wikimedia.org/r/174156 (owner: 10Physikerwelt) [17:57:37] (03Merged) 10jenkins-bot: Add debuging functionality [extensions/Math] (debug) - 10https://gerrit.wikimedia.org/r/174156 (owner: 10Physikerwelt) [17:58:24] (03PS2) 10Physikerwelt: Use local Mathoid renderer [vagrant] - 10https://gerrit.wikimedia.org/r/173791 [17:59:36] (03PS1) 10Umherirrender: Use Parser::OT_HTML class const [extensions/News] - 10https://gerrit.wikimedia.org/r/174159 [17:59:42] (03CR) 10Jsahleen: "This commit has created an issue where the version constant is defined twice. It is throwing the following notice:" [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/172581 (owner: 10Paladox) [18:00:23] (03CR) 10Krinkle: "I know what illegible text is. The point was when that would happen. Sounds like you say it only happens in cases where they already have " [core] - 10https://gerrit.wikimedia.org/r/174145 (owner: 10Krinkle) [18:00:32] (03Abandoned) 10Krinkle: diff: Fill background of transparent cells with white [core] - 10https://gerrit.wikimedia.org/r/174145 (owner: 10Krinkle) [18:01:06] (03CR) 10Krinkle: ".. because the black text on purple background on a mediawiki.org Manual-namespace diff, that is the case for the content area as well. So" [core] - 10https://gerrit.wikimedia.org/r/174145 (owner: 10Krinkle) [18:02:33] (03PS1) 10Umherirrender: Use Parser::OT_WIKI class const [extensions/GoogleMaps] - 10https://gerrit.wikimedia.org/r/174160 [18:04:21] 3MediaWiki extensions / 3Math: Font size problems in MathML with SVG or PNG fallback mode - 10https://bugzilla.wikimedia.org/72553 (10Gabriel Wicke) p:5Unprio>3High [18:05:17] cscott: i made a new keypair. i put the private key in the private puppet repo. i made a change in public that shows how to install it from there. https://gerrit.wikimedia.org/r/#/c/174161/1/manifests/role/ci.pp sounds good? [18:06:08] cscott: the public key, i could just paste it, or do we install it via puppet too [18:07:05] 3MediaWiki extensions / 3ProofreadPage: Add Index and Page namespaces to $wgContentNamespaces - 10https://bugzilla.wikimedia.org/52709#c1 (10Glaisher) This needs more discussion on Wikisource wikis? [18:07:23] (03CR) 10Umherirrender: "Untested" [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/174158 (owner: 10Umherirrender) [18:07:27] (03CR) 10Umherirrender: "Untested" [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/174158 (owner: 10Umherirrender) [18:07:31] (03CR) 10Umherirrender: "Untested" [extensions/GoogleMaps] - 10https://gerrit.wikimedia.org/r/174160 (owner: 10Umherirrender) [18:10:29] (03CR) 10Krinkle: [C: 032] Update .gitreview [extensions/MsUpload] (REL1_22) - 10https://gerrit.wikimedia.org/r/174111 (owner: 10Paladox) [18:10:38] (03Merged) 10jenkins-bot: Update .gitreview [extensions/MsUpload] (REL1_22) - 10https://gerrit.wikimedia.org/r/174111 (owner: 10Paladox) [18:11:03] (03CR) 10Legoktm: "Can we run "composer install" before the tests are executed?" [cdb] - 10https://gerrit.wikimedia.org/r/174080 (https://bugzilla.wikimedia.org/73541) (owner: 10Hashar) [18:12:07] (03PS1) 10Umherirrender: Use Parser::SFH_NO_HASH class const [extensions/BookManager] - 10https://gerrit.wikimedia.org/r/174165 [18:12:43] (03CR) 10Umherirrender: "Untested" [extensions/BookManager] - 10https://gerrit.wikimedia.org/r/174165 (owner: 10Umherirrender) [18:13:35] (03CR) 10Legoktm: "We can't, because that would pull in additional dependencies :/" [cdb] - 10https://gerrit.wikimedia.org/r/174080 (https://bugzilla.wikimedia.org/73541) (owner: 10Hashar) [18:13:44] mutante: email the public side to me for now; it might end up in puppet eventually, but at the moment it needs to end up in gerrit/labs authorized keys/ldap. [18:14:02] i can do that via the web settings interface, dunno how to do that in puppet. [18:14:28] (03PS1) 10Umherirrender: Use Parser::SFH_NO_HASH class const [extensions/SubpageFun] - 10https://gerrit.wikimedia.org/r/174167 [18:14:46] cscott: https://phabricator.wikimedia.org/P81 [18:15:02] (03CR) 10Umherirrender: "Untested" [extensions/SubpageFun] - 10https://gerrit.wikimedia.org/r/174167 (owner: 10Umherirrender) [18:15:08] (03CR) 10Isarra: "Aye, what we need is some higher-up way for a skin to specify its colour scheme. That way this could just use the relevant colours and alw" [core] - 10https://gerrit.wikimedia.org/r/174145 (owner: 10Krinkle) [18:15:11] cscott: i updated that RT just now [18:16:34] (03PS1) 10Umherirrender: Use Parser::SFH_NO_HASH class const [extensions/PageLanguage] - 10https://gerrit.wikimedia.org/r/174168 [18:17:00] MatmaRex: Did you say skins/common is done or you have patches for me to review? [18:17:14] (03CR) 10Umherirrender: "Untested" [extensions/PageLanguage] - 10https://gerrit.wikimedia.org/r/174168 (owner: 10Umherirrender) [18:18:08] 3MediaWiki extensions / 3SyntaxHighlight (GeSHi): GeSHi version constant defined twice - 10https://bugzilla.wikimedia.org/73567 (10Joel Sahleen) 3NEW p:3Unprio s:3normal a:3None The following commit has created a situation where the GeSHi version constant is defined twice, resulting in a notice. htt... [18:18:15] * cscott makes the sign of the cross against phab [18:18:21] 3MediaWiki extensions / 3ProofreadPage: Add Index and Page namespaces to $wgContentNamespaces - 10https://bugzilla.wikimedia.org/52709#c2 (10Nemo) (In reply to Glaisher from comment #1) > This needs more discussion on Wikisource wikis? No: this is not a site request. Most/all wikisources already do so, but... [18:18:28] Krinkle: all done and gone, feel free to rejoice [18:18:56] i'm sure it will pop up in some form of another at least one more time :) [18:19:05] mutante: i'm "at lunch" right now (or should be, according to my stomach), i'll take a look at the puppet patch & try to make this all work in, say, 30min or so. [18:19:27] (03CR) 10Krinkle: "FIXME: GPLv2 is not a valid license value in Composer." [cdb] - 10https://gerrit.wikimedia.org/r/172312 (owner: 10Chad) [18:19:42] (03PS1) 10MaxSem: Bump MobileFrontend and WikiGrok [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174170 [18:19:52] cscott: no rush, it can all happen via ticket anytime..also going to get some food soon [18:20:10] i also added a couple reviewers [18:20:30] legoktm_: Yes. We'd simply have "composer validate/install/test" as a generic job that works independent and fliexibly on both jenkins and locally for developers. [18:20:36] just like npm is already [18:21:03] (03PS1) 10Umherirrender: Use Parser::SFH_NO_HASH class const [extensions/Interlanguage] - 10https://gerrit.wikimedia.org/r/174171 [18:21:16] Krinkle: the path to get varnish change merged is probably asking Faidon or Brandon [18:21:33] Krinkle: ah, that would be fantastic. [18:21:37] (03PS1) 10MaxSem: Bump MobileFrontend and WikiGrok [core] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/174172 [18:21:52] 3MediaWiki-Core-Team: Option to ignore storing bot edits in the recent changes table - https://phabricator.wikimedia.org/T1290#23189 (10Subfader) I added it here because on MW it reads that Phabricator will replace Bugzilla. It reads how to login and how to use Phabricator. It nowhere reads we shall not use Pha... [18:21:59] (03CR) 10MaxSem: [C: 032 V: 032] Bump MobileFrontend and WikiGrok [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174170 (owner: 10MaxSem) [18:22:07] (03CR) 10Umherirrender: "Untested" [extensions/Interlanguage] - 10https://gerrit.wikimedia.org/r/174171 (owner: 10Umherirrender) [18:22:12] (03CR) 10MaxSem: [C: 032 V: 032] Bump MobileFrontend and WikiGrok [core] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/174172 (owner: 10MaxSem) [18:22:41] DELETE - https://phabricator.wikimedia.org/T1290#23190 (10Subfader) [18:22:43] ^d: ^ so we could add a jenkins job that runs "composer test" instead of phpunit [18:23:48] (03PS1) 10Legoktm: Use valid spdx license identifier [cdb] - 10https://gerrit.wikimedia.org/r/174173 [18:23:50] (03CR) 10jenkins-bot: [V: 04-1] Use valid spdx license identifier [cdb] - 10https://gerrit.wikimedia.org/r/174173 (owner: 10Legoktm) [18:23:55] (03PS1) 10Umherirrender: Use Parser::SFH_NO_HASH class const [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/174174 [18:24:12] (03CR) 10Legoktm: "https://gerrit.wikimedia.org/r/#/c/174173/" [cdb] - 10https://gerrit.wikimedia.org/r/172312 (owner: 10Chad) [18:24:23] (03CR) 10Umherirrender: "Untested" [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/174174 (owner: 10Umherirrender) [18:26:07] (03PS1) 10Umherirrender: Use Parser::SFH_NO_HASH/SFH_OBJECT_ARGS class const [extensions/ParserFun] - 10https://gerrit.wikimedia.org/r/174175 [18:26:38] (03CR) 10Umherirrender: "Untested" [extensions/ParserFun] - 10https://gerrit.wikimedia.org/r/174175 (owner: 10Umherirrender) [18:27:32] (03CR) 10Chad: Use valid spdx license identifier (031 comment) [cdb] - 10https://gerrit.wikimedia.org/r/174173 (owner: 10Legoktm) [18:28:05] (03PS1) 10Umherirrender: Use Parser::SFH_NO_HASH class const [extensions/ExtraLanguageLink] - 10https://gerrit.wikimedia.org/r/174176 [18:28:23] (03PS2) 10Legoktm: Use valid spdx license identifier [cdb] - 10https://gerrit.wikimedia.org/r/174173 [18:28:25] (03CR) 10jenkins-bot: [V: 04-1] Use valid spdx license identifier [cdb] - 10https://gerrit.wikimedia.org/r/174173 (owner: 10Legoktm) [18:28:36] (03CR) 10Umherirrender: "Untested" [extensions/ExtraLanguageLink] - 10https://gerrit.wikimedia.org/r/174176 (owner: 10Umherirrender) [18:28:39] (03CR) 10Legoktm: Use valid spdx license identifier (031 comment) [cdb] - 10https://gerrit.wikimedia.org/r/174173 (owner: 10Legoktm) [18:29:17] (03CR) 10TheDJ: mediawiki.action.history.diff: Rework print styles (031 comment) [core] - 10https://gerrit.wikimedia.org/r/174101 (https://bugzilla.wikimedia.org/73544) (owner: 10Bartosz Dziewoński) [18:29:33] (03CR) 10TheDJ: [C: 032] mediawiki.action.history.diff: Rework print styles [core] - 10https://gerrit.wikimedia.org/r/174101 (https://bugzilla.wikimedia.org/73544) (owner: 10Bartosz Dziewoński) [18:29:58] MatmaRex: can't believe it was that broken... :) [18:30:24] thedj: neither could i, first thing i checked is whether there are messed up styles on en.wp :P [18:30:30] (03PS1) 10Umherirrender: Use Parser::SFH_NO_HASH class const [extensions/Comments] - 10https://gerrit.wikimedia.org/r/174178 [18:30:44] i guess printing diffs isn't the most common action people take. [18:31:06] (03CR) 10Umherirrender: "Untested" [extensions/Comments] - 10https://gerrit.wikimedia.org/r/174178 (owner: 10Umherirrender) [18:32:25] (03PS1) 10Umherirrender: Use Parser::SFH_NO_HASH class const [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/174180 [18:32:52] (03CR) 10Umherirrender: "Untested" [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/174180 (owner: 10Umherirrender) [18:39:21] (03Merged) 10jenkins-bot: mediawiki.action.history.diff: Rework print styles [core] - 10https://gerrit.wikimedia.org/r/174101 (https://bugzilla.wikimedia.org/73544) (owner: 10Bartosz Dziewoński) [18:40:49] (03CR) 10BryanDavis: "Related config change by Aaron in If28876d10407a5bd8567b7b282c754fea484367a" [core] - 10https://gerrit.wikimedia.org/r/173348 (owner: 10Chad) [18:45:30] (03PS1) 10Umherirrender: Use Parser::SFH_NO_HASH class const [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/174184 [18:45:52] (03CR) 10Umherirrender: "Untested" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/174184 (owner: 10Umherirrender) [18:47:23] 3Team-Practices: Publish Q2 blog post - https://phabricator.wikimedia.org/T1215#23195 (10KLans_WMF) [18:47:32] (03CR) 10Legoktm: "Minor nitpick, looks good otherwise" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/173348 (owner: 10Chad) [18:47:34] (03PS1) 10Umherirrender: Use Parser::SFH_OBJECT_ARGS class const [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/174186 [18:48:02] (03CR) 10Umherirrender: "Untested" [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/174186 (owner: 10Umherirrender) [18:49:22] (03CR) 10Chad: Refactor profiling output from profiling (031 comment) [core] - 10https://gerrit.wikimedia.org/r/173348 (owner: 10Chad) [18:49:54] (03CR) 10Anomie: "When "batchcomplete" is present, then it means the next continuation is going to start on another batch of pages from the generator." [core] - 10https://gerrit.wikimedia.org/r/152359 (owner: 10Anomie) [18:51:34] (03CR) 10Legoktm: Refactor profiling output from profiling (031 comment) [core] - 10https://gerrit.wikimedia.org/r/173348 (owner: 10Chad) [18:52:04] (03PS1) 10Umherirrender: Use Parser::SFH_OBJECT_ARGS class const [extensions/UserFunctions] - 10https://gerrit.wikimedia.org/r/174187 [18:52:44] (03CR) 10Umherirrender: "Untested" [extensions/UserFunctions] - 10https://gerrit.wikimedia.org/r/174187 (owner: 10Umherirrender) [18:54:10] 3MediaWiki / 3Database: column "mwuser.user_name" must appear in the GROUP BY clause or be used in an aggregate function - 10https://bugzilla.wikimedia.org/73568 (10Igor Pashev) 3UNCO p:3Unprio s:3normal a:3None Special:ActiveUsers page produces DB error with Postgresql backend: A database query err... [18:54:26] (03PS1) 10Umherirrender: Use Parser::SFH_OBJECT_ARGS class const [extensions/ReplaceSet] - 10https://gerrit.wikimedia.org/r/174188 [18:55:06] (03CR) 10Umherirrender: "Untested" [extensions/ReplaceSet] - 10https://gerrit.wikimedia.org/r/174188 (owner: 10Umherirrender) [18:55:24] (03CR) 10Legoktm: [C: 031] Refactor profiling output from profiling [core] - 10https://gerrit.wikimedia.org/r/173348 (owner: 10Chad) [18:55:51] (03CR) 10BryanDavis: [C: 032] Refactor profiling output from profiling [core] - 10https://gerrit.wikimedia.org/r/173348 (owner: 10Chad) [18:56:35] (03PS1) 10Umherirrender: Use Parser::SFH_OBJECT_ARGS class const [extensions/LoopFunctions] - 10https://gerrit.wikimedia.org/r/174189 [18:56:58] (03PS7) 10Ragesoss: Add more course info to API output [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/173452 [18:57:19] (03CR) 10Umherirrender: "Untested" [extensions/LoopFunctions] - 10https://gerrit.wikimedia.org/r/174189 (owner: 10Umherirrender) [18:58:35] 3Wikimedia / 3General/Unknown: Translation memory (solr) is failing - 10https://bugzilla.wikimedia.org/69613#c21 (10Niklas Laxström) 5ASSI>3RESO/FIX We have switched to ES now. ES cluster is so much faster that with same logic a query which was previously timing out now takes less than 4 seconds. [18:59:02] (03PS1) 10Umherirrender: Use Parser::SFH_OBJECT_ARGS class const [extensions/ParserHooks] - 10https://gerrit.wikimedia.org/r/174190 [19:01:36] (03CR) 10BryanDavis: "I think the job needs a `composer install --no-dev` to generate the autoloader files before running phpunit. That's what a typical .travis" [cdb] - 10https://gerrit.wikimedia.org/r/174080 (https://bugzilla.wikimedia.org/73541) (owner: 10Hashar) [19:01:44] (03Merged) 10jenkins-bot: Refactor profiling output from profiling [core] - 10https://gerrit.wikimedia.org/r/173348 (owner: 10Chad) [19:02:04] (03CR) 10Umherirrender: "Untested" [extensions/ParserHooks] - 10https://gerrit.wikimedia.org/r/174190 (owner: 10Umherirrender) [19:02:37] 3MediaWiki / 3Page editing: of editing page doesn't respect DISPLAYTITLE - 10https://bugzilla.wikimedia.org/49667 (10James Forrester) a:3Alex Monk [19:07:26] <phawkes> 3MediaWiki-Core-Team: Fix jobrunner coordinator OOMs - https://phabricator.wikimedia.org/T1140#23220 (10aaron) [19:13:12] <grrrit-wm> (03PS1) 10Legoktm: Profiler: Explicitly convert output type to class name [core] - 10https://gerrit.wikimedia.org/r/174191 [19:15:57] <grrrit-wm> (03CR) 10BryanDavis: [C: 032] Profiler: Explicitly convert output type to class name [core] - 10https://gerrit.wikimedia.org/r/174191 (owner: 10Legoktm) [19:17:21] <^d> RoanKattouw: https://phabricator.wikimedia.org/T836#23219 [19:20:32] <RoanKattouw> ^d: Thanks [19:21:42] <grrrit-wm> (03Merged) 10jenkins-bot: Profiler: Explicitly convert output type to class name [core] - 10https://gerrit.wikimedia.org/r/174191 (owner: 10Legoktm) [19:22:52] <wikibugs> 3MediaWiki / 3History/Diffs: Diffs for meta-data changes (Protect/Move/ContentHandler type) should show something useful, not "No difference". - 10https://bugzilla.wikimedia.org/73546#c2 (10James Forrester) (In reply to Umherirrender from comment #1) > "No difference" is correct because a move or protect pro... [19:25:24] <phawkes> 3Librarization, MediaWiki-Core-Team: Bring in elastica library through composer - https://phabricator.wikimedia.org/T1281#23223 (10bd808) [19:25:34] <phawkes> 3Librarization: [Bug 72572] Create a general UDP transport class instead of abusing wfErrorLog - https://phabricator.wikimedia.org/T938#23224 (10bd808) [19:25:53] <phawkes> 3Librarization, MediaWiki-Core-Team: Template profiling rewrite - https://phabricator.wikimedia.org/T1258#23225 (10bd808) [19:25:57] <phawkes> 3Librarization, MediaWiki-Core-Team: Clean up @ profile entry handling in xhprof - https://phabricator.wikimedia.org/T1274#23226 (10bd808) [19:29:36] <wikibugs> 3Wikimedia / 3Site requests: Set $wgUploadNavigationUrl on it.wikivoyage - 10https://bugzilla.wikimedia.org/73439#c6 (10Dereckson) 5PATC>3RESO/FIX Yes we figured it were well about it.wikivoyage, per comment 1. Change merged by Reedy. [19:34:39] <phawkes> enable diffusion for people w/ admin rights for some to setup to repos - https://phabricator.wikimedia.org/T786#23232 (10Chad) [19:36:49] <grrrit-wm> (03CR) 10Chad: [C: 032] Use valid spdx license identifier [cdb] - 10https://gerrit.wikimedia.org/r/174173 (owner: 10Legoktm) [19:36:56] <grrrit-wm> (03PS12) 10BryanDavis: Add logging context to database logs [core] - 10https://gerrit.wikimedia.org/r/141599 [19:37:52] <wikibugs> 3MediaWiki / 3API: API output containing <cross-domain-policy> is corrupted in non-XML formats - 10https://bugzilla.wikimedia.org/66776#c3 (10Brad Jorsch) Created attachment 17162 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17162&action=edit Patch to work around wfMangleFlashPolicy, if we're not g... [19:38:20] <wikibugs> 3Wikimedia / 3Site requests: Set $wgUploadNavigationUrl on it.wikivoyage - 10https://bugzilla.wikimedia.org/73439#c7 (10Dereckson) alt + shift + u shorcut works, but link is hidden by the $("#t-upload").css("display","none"); instruction, pending the elimination planned in comment 1. [19:38:54] <grrrit-wm> (03CR) 10BryanDavis: "Patch set #12 was mostly a manual rebase. I fixed a few small style issues as well." [core] - 10https://gerrit.wikimedia.org/r/141599 (owner: 10BryanDavis) [19:39:31] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Use valid spdx license identifier [cdb] - 10https://gerrit.wikimedia.org/r/174173 (owner: 10Legoktm) [19:39:35] <wikibugs> 3MediaWiki / 3General/Unknown: Send a cookie with each block? - 10https://bugzilla.wikimedia.org/3233 (10James Forrester) 5PATC>3NEW [19:41:24] <grrrit-wm> (03CR) 10BryanDavis: "I think that moving the Database classes to direct use of MWLogger would be nice but really isn't fully necessary at this point. Let's exp" [core] - 10https://gerrit.wikimedia.org/r/141599 (owner: 10BryanDavis) [19:42:48] <grrrit-wm> (03PS1) 10Anomie: API: Recognize an "Api-User-Agent" header [core] - 10https://gerrit.wikimedia.org/r/174200 [19:43:31] <grrrit-wm> (03PS1) 10Umherirrender: Use Parser::SFH_OBJECT_ARGS class const [extensions/Carp] - 10https://gerrit.wikimedia.org/r/174201 [19:44:40] <grrrit-wm> (03PS1) 10Umherirrender: Use Parser::SFH_OBJECT_ARGS class const [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/174202 [19:44:49] <grrrit-wm> (03CR) 10Umherirrender: "Untested" [extensions/Carp] - 10https://gerrit.wikimedia.org/r/174201 (owner: 10Umherirrender) [19:44:58] <grrrit-wm> (03CR) 10Umherirrender: "Untested" [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/174202 (owner: 10Umherirrender) [19:45:43] <grrrit-wm> (03PS1) 10Umherirrender: Use Parser::SFH_OBJECT_ARGS class const [extensions/ContributionsList] - 10https://gerrit.wikimedia.org/r/174203 [19:46:19] <grrrit-wm> (03PS1) 10Umherirrender: Use Parser::SFH_OBJECT_ARGS class const [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/174204 [19:46:21] <grrrit-wm> (03CR) 10Umherirrender: "Untested" [extensions/ContributionsList] - 10https://gerrit.wikimedia.org/r/174203 (owner: 10Umherirrender) [19:46:55] <grrrit-wm> (03CR) 10Umherirrender: "Untested" [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/174204 (owner: 10Umherirrender) [19:47:12] <grrrit-wm> (03PS1) 10Umherirrender: Use Parser::SFH_OBJECT_ARGS class const [extensions/CreatePage] - 10https://gerrit.wikimedia.org/r/174206 [19:47:45] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Use Parser::SFH_OBJECT_ARGS class const [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/174202 (owner: 10Umherirrender) [19:48:12] <grrrit-wm> (03CR) 10Umherirrender: "Untested" [extensions/CreatePage] - 10https://gerrit.wikimedia.org/r/174206 (owner: 10Umherirrender) [19:48:19] <grrrit-wm> (03PS1) 10Umherirrender: Use Parser::SFH_OBJECT_ARGS class const [extensions/ExtTab] - 10https://gerrit.wikimedia.org/r/174207 [19:49:02] <grrrit-wm> (03CR) 10Umherirrender: "Untested" [extensions/ExtTab] - 10https://gerrit.wikimedia.org/r/174207 (owner: 10Umherirrender) [19:49:17] <grrrit-wm> (03PS1) 10Umherirrender: Use Parser::SFH_OBJECT_ARGS class const [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/174208 [19:49:51] <grrrit-wm> (03CR) 10Umherirrender: "Untested" [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/174208 (owner: 10Umherirrender) [19:49:59] <grrrit-wm> (03PS1) 10Umherirrender: Use Parser::SFH_OBJECT_ARGS class const [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/174209 [19:51:18] <grrrit-wm> (03CR) 10Umherirrender: "Untested" [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/174209 (owner: 10Umherirrender) [19:51:25] <grrrit-wm> (03PS1) 10Umherirrender: Use Parser::SFH_OBJECT_ARGS class const [extensions/HashTables] - 10https://gerrit.wikimedia.org/r/174210 [19:51:59] <grrrit-wm> (03CR) 10Umherirrender: "Untested" [extensions/HashTables] - 10https://gerrit.wikimedia.org/r/174210 (owner: 10Umherirrender) [19:52:06] <grrrit-wm> (03PS1) 10Umherirrender: Use Parser::SFH_OBJECT_ARGS class const [extensions/IfTemplates] - 10https://gerrit.wikimedia.org/r/174211 [19:52:46] <grrrit-wm> (03CR) 10Umherirrender: "Untested" [extensions/IfTemplates] - 10https://gerrit.wikimedia.org/r/174211 (owner: 10Umherirrender) [19:52:51] <grrrit-wm> (03PS1) 10Chad: ProfilerOutput: Remove logStandardData() and make log() abstract [core] - 10https://gerrit.wikimedia.org/r/174212 [19:52:53] <grrrit-wm> (03PS1) 10Umherirrender: Use Parser::SFH_OBJECT_ARGS class const [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/174213 [19:52:55] <grrrit-wm> (03PS1) 10Aaron Schulz: Batch executeReadyPeriodicTasks() updates to avoid OOMs [services/jobrunner] - 10https://gerrit.wikimedia.org/r/174214 [19:53:39] <phawkes> 3MediaWiki-Core-Team: Fix jobrunner coordinator OOMs - https://phabricator.wikimedia.org/T1140#23235 (10aaron) https://gerrit.wikimedia.org/r/#/c/174214/ [19:53:42] <grrrit-wm> (03PS1) 10Umherirrender: Use Parser::SFH_OBJECT_ARGS class const [extensions/Loops] - 10https://gerrit.wikimedia.org/r/174216 [19:53:51] <phawkes> 3MediaWiki-Core-Team: Fix jobrunner coordinator OOMs - https://phabricator.wikimedia.org/T1140#23236 (10aaron) [19:53:53] <phawkes> 3MediaWiki-Core-Team: ProfilerOutput refactoring - https://phabricator.wikimedia.org/T1311#23237 (10aaron) [19:54:24] <grrrit-wm> (03CR) 10Umherirrender: "Untested" [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/174213 (owner: 10Umherirrender) [19:54:31] <grrrit-wm> (03PS1) 10Umherirrender: Use Parser::SFH_OBJECT_ARGS class const [extensions/NaturalLanguageList] - 10https://gerrit.wikimedia.org/r/174217 [19:54:46] <grrrit-wm> (03CR) 10Merlijn van Deen: [C: 032] Use Parser::SFH_OBJECT_ARGS class const [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/174213 (owner: 10Umherirrender) [19:54:51] <grrrit-wm> (03CR) 10Umherirrender: "Untested" [extensions/NaturalLanguageList] - 10https://gerrit.wikimedia.org/r/174217 (owner: 10Umherirrender) [19:55:00] <grrrit-wm> (03Merged) 10jenkins-bot: Use Parser::SFH_OBJECT_ARGS class const [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/174213 (owner: 10Umherirrender) [19:55:23] <grrrit-wm> (03PS1) 10Umherirrender: Use Parser::SFH_OBJECT_ARGS class const [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/174219 [19:55:35] <grrrit-wm> (03CR) 10Umherirrender: "Untested" [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/174219 (owner: 10Umherirrender) [19:55:53] <grrrit-wm> (03CR) 10Aaron Schulz: [C: 032] ProfilerOutput: Remove logStandardData() and make log() abstract [core] - 10https://gerrit.wikimedia.org/r/174212 (owner: 10Chad) [19:56:19] <grrrit-wm> (03PS1) 10Umherirrender: Use Parser::SFH_OBJECT_ARGS class const [extensions/RegexFun] - 10https://gerrit.wikimedia.org/r/174220 [19:56:53] <grrrit-wm> (03CR) 10Umherirrender: "Untested" [extensions/RegexFun] - 10https://gerrit.wikimedia.org/r/174220 (owner: 10Umherirrender) [19:57:04] <grrrit-wm> (03PS1) 10Umherirrender: Use Parser::SFH_OBJECT_ARGS class const [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/174221 [19:57:57] <grrrit-wm> (03CR) 10Umherirrender: "Untested" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/174221 (owner: 10Umherirrender) [19:58:59] <grrrit-wm> (03PS1) 10Legoktm: Add script to populate log_search for global rename entries [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/174224 [20:00:19] <grrrit-wm> (03PS1) 10Umherirrender: Use Parser::SFH_OBJECT_ARGS class const [extensions/Variables] - 10https://gerrit.wikimedia.org/r/174226 [20:00:52] <grrrit-wm> (03CR) 10Umherirrender: "Untested" [extensions/Variables] - 10https://gerrit.wikimedia.org/r/174226 (owner: 10Umherirrender) [20:01:04] <grrrit-wm> (03PS1) 10Umherirrender: Use Parser::SFH_OBJECT_ARGS class const [extensions/WikiLovesMonuments] - 10https://gerrit.wikimedia.org/r/174227 [20:01:21] <grrrit-wm> (03CR) 10Umherirrender: "Untested" [extensions/WikiLovesMonuments] - 10https://gerrit.wikimedia.org/r/174227 (owner: 10Umherirrender) [20:02:09] <grrrit-wm> (03Merged) 10jenkins-bot: ProfilerOutput: Remove logStandardData() and make log() abstract [core] - 10https://gerrit.wikimedia.org/r/174212 (owner: 10Chad) [20:02:59] <grrrit-wm> (03PS2) 10Legoktm: Add script to populate log_search for global rename entries [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/174224 [20:03:18] <grrrit-wm> (03CR) 10Legoktm: [C: 031] "Already run in production" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/174224 (owner: 10Legoktm) [20:03:38] <grrrit-wm> (03CR) 10Umherirrender: "Untested" [extensions/Loops] - 10https://gerrit.wikimedia.org/r/174216 (owner: 10Umherirrender) [20:03:45] <grrrit-wm> (03CR) 10Umherirrender: "Untested" [extensions/News] - 10https://gerrit.wikimedia.org/r/174159 (owner: 10Umherirrender) [20:03:59] <grrrit-wm> (03CR) 10Legoktm: "Back-populate script is I230707116f468c6cca3fa20b16c65c471e5bf5e5" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/169542 (https://bugzilla.wikimedia.org/70850) (owner: 10Legoktm) [20:04:51] <wikibugs> 3MediaWiki extensions / 3CentralAuth: Not possible to filter Special:Log/gblrename by old CentralAuth account name - 10https://bugzilla.wikimedia.org/70850#c7 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX Deployed, and ran the back-populate script on metawiki. [20:05:31] <grrrit-wm> (03PS2) 10Umherirrender: Use Parser::SFH_OBJECT_ARGS class const [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/174202 [20:05:43] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Use Parser::SFH_OBJECT_ARGS class const [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/174202 (owner: 10Umherirrender) [20:06:23] <grrrit-wm> (03CR) 10Umherirrender: "Patch Set 2: Found another occurence" [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/174202 (owner: 10Umherirrender) [20:06:53] <wikibugs> 3MediaWiki extensions / 3CentralAuth: Improve GlobalRename's AntiSpoof checking feature - 10https://bugzilla.wikimedia.org/73573 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None * Check that the conflicting name isn't the name we're renaming away from * Display the conflicting name(s) as lo... [20:07:32] <grrrit-wm> (03PS1) 10Aaron Schulz: Use upsert() in ProfilerOutputDb [core] - 10https://gerrit.wikimedia.org/r/174230 [20:07:41] <grrrit-wm> (03CR) 10Umherirrender: "Changes to extensions can be found under: https://gerrit.wikimedia.org/r/#/q/status:open+branch:master+topic:consts,n,z" [core] - 10https://gerrit.wikimedia.org/r/172588 (owner: 10Umherirrender) [20:07:54] <grrrit-wm> (03Abandoned) 10Aaron Schulz: Replace insert() and update call() with upsert() call [core] - 10https://gerrit.wikimedia.org/r/91405 (https://bugzilla.wikimedia.org/32217) (owner: 10Reedy) [20:20:36] <grrrit-wm> (03PS1) 10EBernhardson: Support joins via EchoBatchRowIterator [extensions/Echo] - 10https://gerrit.wikimedia.org/r/174236 [20:27:00] <legoktm> hoo: what's the difference between CentralAuthUser::isHidden() and isOversighted()? [20:27:27] <hoo> is oversighted is more private [20:27:31] <hoo> but can't tell the details [20:27:33] <hoo> offhand [20:27:36] <legoktm> hmm [20:27:36] <hoo> but there's a difference [20:27:41] <legoktm> const HIDDEN_LISTS = 'lists'; [20:27:42] <legoktm> const HIDDEN_OVERSIGHT = 'suppressed'; [20:27:51] <hoo> I think that also suppresses local accounts or so [20:27:58] <grrrit-wm> (03PS3) 10Umherirrender: Use Parser::SFH_NO_HASH/SFH_OBJECT_ARGS class const [core] - 10https://gerrit.wikimedia.org/r/172588 [20:28:05] <grrrit-wm> (03CR) 10Anomie: [C: 032] Use Parser::SFH_OBJECT_ARGS class const [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/174221 (owner: 10Umherirrender) [20:28:07] <legoktm> in global rename, before displaying the username of antispoof conflicts, should I check isHidden or isOversighted? [20:28:23] <grrrit-wm> (03CR) 10Umherirrender: "Patch Set 3: Added hint to defines" [core] - 10https://gerrit.wikimedia.org/r/172588 (owner: 10Umherirrender) [20:30:08] <grrrit-wm> (03Merged) 10jenkins-bot: Use Parser::SFH_OBJECT_ARGS class const [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/174221 (owner: 10Umherirrender) [20:31:27] <grrrit-wm> (03PS1) 10Umherirrender: Add hint to OT_* defines [core] - 10https://gerrit.wikimedia.org/r/174237 [20:39:18] <grrrit-wm> (03PS1) 10Aaron Schulz: Fixed some incorrect Profiler comments [core] - 10https://gerrit.wikimedia.org/r/174266 [20:41:44] <grrrit-wm> (03CR) 10Chad: [C: 032] Use upsert() in ProfilerOutputDb [core] - 10https://gerrit.wikimedia.org/r/174230 (owner: 10Aaron Schulz) [20:42:29] <grrrit-wm> (03CR) 10Chad: [C: 032] Fixed some incorrect Profiler comments [core] - 10https://gerrit.wikimedia.org/r/174266 (owner: 10Aaron Schulz) [20:42:41] <grrrit-wm> (03PS1) 10Chad: Remove obvious function-level profiling [core] - 10https://gerrit.wikimedia.org/r/174267 [20:45:11] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Remove obvious function-level profiling [core] - 10https://gerrit.wikimedia.org/r/174267 (owner: 10Chad) [20:46:47] <grrrit-wm> (03PS1) 10Krinkle: profiler: Simplify code for class name mapping [core] - 10https://gerrit.wikimedia.org/r/174269 [20:47:36] <grrrit-wm> (03Merged) 10jenkins-bot: Use upsert() in ProfilerOutputDb [core] - 10https://gerrit.wikimedia.org/r/174230 (owner: 10Aaron Schulz) [20:48:22] <grrrit-wm> (03Merged) 10jenkins-bot: Fixed some incorrect Profiler comments [core] - 10https://gerrit.wikimedia.org/r/174266 (owner: 10Aaron Schulz) [20:49:40] <grrrit-wm> (03PS2) 10Chad: Remove obvious function-level profiling [core] - 10https://gerrit.wikimedia.org/r/174267 [20:50:11] <grrrit-wm> (03CR) 10Chad: [C: 032] profiler: Simplify code for class name mapping [core] - 10https://gerrit.wikimedia.org/r/174269 (owner: 10Krinkle) [20:52:25] <grrrit-wm> (03CR) 10Paladox: "@Raimond Spekking please merge." [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/174071 (owner: 10Paladox) [20:54:07] <Krinkle> ^d: Can you give me a quick pointer about xhprof? [20:54:12] <Krinkle> What/where/how [20:54:58] <^d> Bundled in HHVM by default. Output formats are shared with the standard MW profiler so you can still send them to UDP or DB or w/e. [20:55:09] <^d> New config style is documented in StartProfiler.sample [20:55:15] <grrrit-wm> (03CR) 10EBernhardson: WIP: Import: Cleanup header by removing LQT magic word and adding template (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/172925 (owner: 10Mattflaschen) [20:56:13] <grrrit-wm> (03Merged) 10jenkins-bot: profiler: Simplify code for class name mapping [core] - 10https://gerrit.wikimedia.org/r/174269 (owner: 10Krinkle) [20:56:24] <Krinkle> ^d: and it works with regular php5 as well? [20:56:25] <phawkes> 3Community-Engagement: Create Product Roadmap Survey text - https://phabricator.wikimedia.org/T1324 (10Rdicerb) 3NEW p:3High a:3Rdicerb [20:56:37] <^d> Krinkle: Pecl package. Should be in most distros too [20:56:44] <^d> php5-xhprof in debian/ubuntu. [20:56:47] <Krinkle> k [20:58:23] <^d> Krinkle: We also decoupled profiling from profiling output a bit as you see. That means it's now possible to write your profiling data to multiple locations [20:58:35] <^d> (So you can log it in DB/UDP & output to the page at the same time) [21:03:52] <wikibugs> 3MediaWiki / 3JavaScript: mediawiki.Uri: Default URI not updated after pushState - 10https://bugzilla.wikimedia.org/72334 (10Krinkle) p:5Normal>3High [21:05:42] <Krinkle> ^d: cool. that makes sense [21:16:51] <phawkes> 3Librarization: Get support for xhprof_frame_begin & xhprof_frame_end functions added to XHProf PECL package - https://phabricator.wikimedia.org/T1325 (10bd808) 3NEW p:3Triage [21:18:05] <phawkes> 3Architecture-RfCs, Librarization: RfC: Better PHP profiling - https://phabricator.wikimedia.org/T1251#23257 (10bd808) [21:18:43] <Krinkle> ^d: [21:18:45] <Krinkle> - $difftext = $wgContLang->unsegmentForDiff( $formatter->format( $diffs ) ) . [21:18:45] <Krinkle> - wfProfileOut( __METHOD__ ); [21:18:48] <Krinkle> That one was weird [21:19:54] <grrrit-wm> (03CR) 10Krinkle: [C: 032] Remove obvious function-level profiling [core] - 10https://gerrit.wikimedia.org/r/174267 (owner: 10Chad) [21:20:47] <^d> Krinkle|detached: Yeahhhh :) [21:23:12] <grrrit-wm> (03CR) 10TheDJ: "corrected coding style in the upstream patch, just because that is the right thing to do :)" [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/173104 (https://bugzilla.wikimedia.org/73281) (owner: 10TheDJ) [21:23:26] <phawkes> 3Librarization: Get support for xhprof_frame_begin & xhprof_frame_end functions added to XHProf PECL package - https://phabricator.wikimedia.org/T1325#23259 (10bd808) During the [[http://tools.wmflabs.org/meetbot/wikimedia-office/2014/wikimedia-office.2014-11-12-22.04.log.html#l-86 | most recent discussion of th... [21:23:48] <phawkes> 3Librarization: Get support for xhprof_frame_begin & xhprof_frame_end functions added to XHProf PECL package - https://phabricator.wikimedia.org/T1325#23260 (10bd808) p:5Triage>3Normal [21:24:09] <grrrit-wm> (03CR) 10Chad: [C: 04-2] "I'm not sure I want this to land in the new wmf branch on thursday." [core] - 10https://gerrit.wikimedia.org/r/174267 (owner: 10Chad) [21:32:47] <grrrit-wm> (03CR) 10BryanDavis: [C: 04-1] "This should probably be considered blocked by T1325 and the upstream https://github.com/phacility/xhprof/issues/51 or some hybrid xhprof +" [core] - 10https://gerrit.wikimedia.org/r/174267 (owner: 10Chad) [21:33:55] <grrrit-wm> (03CR) 10TheDJ: [C: 04-1] "Please correct the indentation of the block." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/98249 (owner: 10Dev-zero) [21:37:48] <grrrit-wm> (03PS1) 10Hoo man: Update Wikidata [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174287 [21:39:37] <Helder> In december 2006, Tim Starling said a few things related to demoting inactive admins: [21:39:38] <Helder> https://en.wikipedia.org/w/index.php?diff=95076360 [21:39:39] <Helder> I would like to know if any/all of them are still true 8 years later: [21:39:39] <Helder> 1. Is it a disaster if a sysop or bureaucrat account gets compromised? [21:39:39] <Helder> 2. Can the developers still respond rapidly to disable a compromised account with any level of access? [21:39:39] <Helder> 3. How many times has this been necessary? [21:39:41] <Helder> 4. Are active accounts still more likely to be compromised than inactive accounts? [21:40:39] <^d> (1) No, it's not a disaster, but can be very annoying. [21:40:49] <^d> (2) Yes. [21:41:00] <^d> (3) basically never? I can't think of any offhand. [21:42:04] <hoo> slow jenkins is slow [21:42:12] <^d> obvious hoo is obvious. [21:42:21] <^d> :) [21:43:20] <hoo> :D [21:43:48] <grrrit-wm> (03CR) 10Hoo man: [C: 032] Update Wikidata [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174287 (owner: 10Hoo man) [21:45:14] <grrrit-wm> (03PS1) 10CSteipp: Make calling wfMangleFlashPolicy configurable [core] - 10https://gerrit.wikimedia.org/r/174289 (https://bugzilla.wikimedia.org/66776) [21:46:06] <Helder> ^d: what about (4)? [21:46:18] <^d> Probably? I dunno really. [21:46:41] <^d> I'm guessing Tim meant "people are more likely to notice an inactive account suddenly being active & compromised" [21:46:52] <^d> As opposed to "highly active user who's lost control of their account" [21:47:05] <^d> Which strikes me as true. [21:48:34] <phawkes> DELETE - https://phabricator.wikimedia.org/T1290#23265 (10Aklapper) 5Open>3Invalid a:3Aklapper @Subfader: I am sorry for the confusion (and potentially confusing documentation). Phabricator will be the totally correct place to file such tickets from next week on, but currently we do not have projects set up... [21:49:31] <grrrit-wm> (03Merged) 10jenkins-bot: Update Wikidata [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174287 (owner: 10Hoo man) [21:49:40] <Helder> thanks [21:49:52] <^d> You're welcome [21:49:59] <RoanKattouw> Also, there's both value and risk in an active admin account, but arguably zero value and non-zero risk in an inactive one [21:50:46] <RoanKattouw> In other words: every admin account is another one that could potentially be compromised, but at least the active ones are useful, outweighing the risk, whereas the inactive ones are arguably not useful but still add risk [21:51:43] <^d> RoanKattouw: Did you see my last comment on TT836? :) [21:51:54] <ejegg> springle: can I ask for some advise on avoiding database locks during a huge select...into ? [21:51:54] <RoanKattouw> I say "arguably" because I don't take a position on this issue, but some people feel that way [21:52:10] <ejegg> s/advise/advice [21:52:29] <RoanKattouw> ^d: I had not, thanks [21:52:41] <^d> yw. Look closely at the last link ;-) [21:52:47] <RoanKattouw> I did :) [21:52:53] <Helder> thank you too, RoanKattouw [21:55:10] <grrrit-wm> (03Abandoned) 10Jeroen De Dauw: Add ComposerPackageModifierTest integration test [core] - 10https://gerrit.wikimedia.org/r/119476 (owner: 10Jeroen De Dauw) [21:55:15] <grrrit-wm> (03Restored) 10Jeroen De Dauw: Add ComposerPackageModifierTest integration test [core] - 10https://gerrit.wikimedia.org/r/119476 (owner: 10Jeroen De Dauw) [21:56:07] <wikibugs> 3Wikimedia / 3SSL related: replace SHA1 certificates with SHA256 - 10https://bugzilla.wikimedia.org/71156#c10 (10chmarkine) Chrome 39 was released today. When will the certificates be replaced then? [21:59:51] <wikibugs> 3MediaWiki-Vagrant: Postgres: command-line installer fails every time: "Class 'PostgresqlInstaller' not found" - 10https://bugzilla.wikimedia.org/61350#c3 (10Marcin Cieślak) can somebody using vagrant confirm this? [22:03:36] <grrrit-wm> (03PS1) 10Chad: MW_NO_OUTPUT_BUFFER is never defined [core] - 10https://gerrit.wikimedia.org/r/174298 [22:05:04] <grrrit-wm> (03CR) 10Aaron Schulz: [C: 032] MW_NO_OUTPUT_BUFFER is never defined [core] - 10https://gerrit.wikimedia.org/r/174298 (owner: 10Chad) [22:10:37] <grrrit-wm> (03Merged) 10jenkins-bot: MW_NO_OUTPUT_BUFFER is never defined [core] - 10https://gerrit.wikimedia.org/r/174298 (owner: 10Chad) [22:10:50] <wikibugs> 3MediaWiki extensions / 3Semantic MediaWiki: datatype URL / breaking URL special character transformation (1.8.0) - 10https://bugzilla.wikimedia.org/35452#c2 (10[[kgh]]) Now recorded on GitHub with issue 633 [1] [1] https://github.com/SemanticMediaWiki/SemanticMediaWiki/issues/633 [22:16:02] <welterkj> I'm getting an error from git review: Problems encountered installing commit-msg hook [22:16:39] <welterkj> The following command failed with exit code 104 "GET https://gerrit.wikimedia.org/tools/hooks/commit-msg" [22:16:42] <welterkj> Known issue? [22:17:09] <ejegg> welterkj: if you have another repo with git-review working, you can copy the hook from there [22:18:02] <ejegg> it's in .git/hooks/commit-msg [22:18:13] <grrrit-wm> (03PS1) 10TheDJ: Dependency fix [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/174300 [22:18:51] <grrrit-wm> (03CR) 10Gergő Tisza: [C: 04-1] "Some minor documentation/phrasing issues." (035 comments) [core] - 10https://gerrit.wikimedia.org/r/142046 (owner: 10Umherirrender) [22:20:14] <welterkj> Thanks ejegg, I'm only using the one repo though. [22:21:10] <ejegg> drat, i'm not sure what the real fix for that would be then [22:21:56] <welterkj> Is it a transient kind of thing? [22:27:52] <wikibugs> 3MediaWiki / 3Interface: Mediawiki diff formatting is broken in printer ready display - 10https://bugzilla.wikimedia.org/73544#c4 (10Bartosz Dziewoński) 5PATC>3RESO/FIX p:5Unprio>3Normal a:3Bartosz Dziewoński Fixed! The change will be deployed on Wikimedia wikis according to the schedule at [[mw:... [22:30:54] <phawkes> 3MediaWiki-Core-Team: Remove ProfilerStandard dependency from SectionProfiler - https://phabricator.wikimedia.org/T1326 (10aaron) 3NEW p:3Normal a:3aaron [22:44:21] <grrrit-wm> (03PS1) 10Ori.livneh: Follow-up to I05aacd30b: normalize case in User::idFromName [core] - 10https://gerrit.wikimedia.org/r/174304 [22:45:16] <ori> AaronSchulz: ^ [22:47:15] <grrrit-wm> (03CR) 10BryanDavis: "recheck" [cdb] - 10https://gerrit.wikimedia.org/r/174080 (https://bugzilla.wikimedia.org/73541) (owner: 10Hashar) [22:47:33] <grrrit-wm> (03PS2) 10Gerrit Patch Uploader: Show the globally blocked range in block message [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/134043 (https://bugzilla.wikimedia.org/38367) [22:47:35] <grrrit-wm> (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/134043 (https://bugzilla.wikimedia.org/38367) (owner: 10Gerrit Patch Uploader) [22:48:43] <grrrit-wm> (03PS6) 10Mattflaschen: Use an actual registration to test GettingStarted returnto behavior. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/160193 [22:48:54] <grrrit-wm> (03CR) 10Mattflaschen: "Done, thanks." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/160193 (owner: 10Mattflaschen) [22:49:57] <phawkes> 3WMF-Product-Strategy: Add developer personæ - https://phabricator.wikimedia.org/T665#23281 (10Jdforrester-WMF) a:5Jdforrester-WMF>3None [22:54:50] <grrrit-wm> (03PS1) 10Aaron Schulz: Placed ProfilerStandard logic directly into SectionProfiler [core] - 10https://gerrit.wikimedia.org/r/174307 [22:55:13] <grrrit-wm> (03CR) 10Legoktm: [C: 032] Use valid spdx license identifier [cdb] - 10https://gerrit.wikimedia.org/r/174173 (owner: 10Legoktm) [22:56:38] <grrrit-wm> (03CR) 10Legoktm: "recheck" [cdb] - 10https://gerrit.wikimedia.org/r/174092 (https://bugzilla.wikimedia.org/73530) (owner: 10Hashar) [22:56:42] <grrrit-wm> (03CR) 10Legoktm: "recheck" [cdb] - 10https://gerrit.wikimedia.org/r/174093 (https://bugzilla.wikimedia.org/73530) (owner: 10Hashar) [22:56:59] <grrrit-wm> (03CR) 10Chad: [C: 032] Conf for doxygen [cdb] - 10https://gerrit.wikimedia.org/r/174092 (https://bugzilla.wikimedia.org/73530) (owner: 10Hashar) [22:57:48] <grrrit-wm> (03CR) 10Chad: [C: 032] Use README.md as doxygen main page [cdb] - 10https://gerrit.wikimedia.org/r/174093 (https://bugzilla.wikimedia.org/73530) (owner: 10Hashar) [22:57:50] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Use README.md as doxygen main page [cdb] - 10https://gerrit.wikimedia.org/r/174093 (https://bugzilla.wikimedia.org/73530) (owner: 10Hashar) [22:58:34] <grrrit-wm> (03PS1) 10Aaron Schulz: Cleaned up template profile report tabbing [core] - 10https://gerrit.wikimedia.org/r/174309 [22:59:07] <wikibugs> 3Wikimedia / 3Site requests: Set $wgUploadNavigationUrl on it.wikivoyage - 10https://bugzilla.wikimedia.org/73439#c8 (10Andyrom75) Just done. Thanks a lot! [22:59:27] <grrrit-wm> (03CR) 10Chad: "recheck" [cdb] - 10https://gerrit.wikimedia.org/r/174093 (https://bugzilla.wikimedia.org/73530) (owner: 10Hashar) [22:59:37] <grrrit-wm> (03CR) 10Legoktm: "recheck" [cdb] - 10https://gerrit.wikimedia.org/r/174093 (https://bugzilla.wikimedia.org/73530) (owner: 10Hashar) [22:59:50] <grrrit-wm> (03CR) 10Legoktm: [C: 032] Use README.md as doxygen main page [cdb] - 10https://gerrit.wikimedia.org/r/174093 (https://bugzilla.wikimedia.org/73530) (owner: 10Hashar) [22:59:52] <grrrit-wm> (03Merged) 10jenkins-bot: Use README.md as doxygen main page [cdb] - 10https://gerrit.wikimedia.org/r/174093 (https://bugzilla.wikimedia.org/73530) (owner: 10Hashar) [23:02:33] <grrrit-wm> (03PS6) 10Gerrit Patch Uploader: Show lock notice on contribs for locked users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/133997 (https://bugzilla.wikimedia.org/52674) [23:02:35] <grrrit-wm> (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/133997 (https://bugzilla.wikimedia.org/52674) (owner: 10Gerrit Patch Uploader) [23:16:47] <grrrit-wm> (03CR) 10Krinkle: [C: 04-1] "Don't merge until either Wikimedia installs php5-xhprof or has migrated to hhvm everywhere." [core] - 10https://gerrit.wikimedia.org/r/174267 (owner: 10Chad) [23:19:24] <huh> What do I need to do to get https://gerrit.wikimedia.org/r/#/c/129933/ merged? (This is from April) [23:24:00] <grrrit-wm> (03PS1) 10Chad: Don't branch AntiBot anymore, undeployed [tools/release] - 10https://gerrit.wikimedia.org/r/174316 [23:24:18] <grrrit-wm> (03PS5) 10Krinkle: Implement namespace inversion on SpecialWhatlinkshere [core] - 10https://gerrit.wikimedia.org/r/129933 (https://bugzilla.wikimedia.org/16848) (owner: 10Gerrit Patch Uploader) [23:24:37] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Implement namespace inversion on SpecialWhatlinkshere [core] - 10https://gerrit.wikimedia.org/r/129933 (https://bugzilla.wikimedia.org/16848) (owner: 10Gerrit Patch Uploader) [23:24:44] <grrrit-wm> (03PS6) 10Krinkle: Implement namespace inversion on SpecialWhatlinkshere [core] - 10https://gerrit.wikimedia.org/r/129933 (https://bugzilla.wikimedia.org/16848) (owner: 10Gerrit Patch Uploader) [23:25:02] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Implement namespace inversion on SpecialWhatlinkshere [core] - 10https://gerrit.wikimedia.org/r/129933 (https://bugzilla.wikimedia.org/16848) (owner: 10Gerrit Patch Uploader) [23:25:06] <grrrit-wm> (03CR) 10Krinkle: "Patch no longer merges due to path conflict." [core] - 10https://gerrit.wikimedia.org/r/129933 (https://bugzilla.wikimedia.org/16848) (owner: 10Gerrit Patch Uploader) [23:25:38] <huh> Krinkle: should I rebase? [23:25:47] <huh> or manually merge it [23:25:54] <huh> and resubmit? [23:25:57] <grrrit-wm> (03CR) 10Krinkle: "Confirm that this kind of query is optimised in our database schema. These data sets are too large to allow a slow query." [core] - 10https://gerrit.wikimedia.org/r/129933 (https://bugzilla.wikimedia.org/16848) (owner: 10Gerrit Patch Uploader) [23:26:29] <Krinkle> huh: check it out locally, fetch origin master, rebase origin/master, resolve conflict, send back to gerrit for git review [23:26:50] <grrrit-wm> (03PS1) 10Legoktm: Remove AntiBot from make-wmf-branch [tools/release] - 10https://gerrit.wikimedia.org/r/174317 [23:27:00] <legoktm> oh [23:27:02] <legoktm> I'm slow >.< [23:27:07] <grrrit-wm> (03Abandoned) 10Legoktm: Remove AntiBot from make-wmf-branch [tools/release] - 10https://gerrit.wikimedia.org/r/174317 (owner: 10Legoktm) [23:27:15] <grrrit-wm> (03CR) 10Legoktm: [C: 032] Don't branch AntiBot anymore, undeployed [tools/release] - 10https://gerrit.wikimedia.org/r/174316 (owner: 10Chad) [23:27:23] <grrrit-wm> (03Merged) 10jenkins-bot: Don't branch AntiBot anymore, undeployed [tools/release] - 10https://gerrit.wikimedia.org/r/174316 (owner: 10Chad) [23:31:07] <huh> Krinkle: should I try to be as succinct as possible, or are repetitive if/else blocks OK? [23:31:53] <Krinkle> huh: in which code? [23:31:56] <Krinkle> I don't see that there [23:32:10] <huh> in the new version of the file [23:32:24] <Krinkle> I don't know. Try to keep the logic together. [23:32:46] <huh> https://github.com/wikimedia/mediawiki/blob/master/includes/specials/SpecialWhatlinkshere.php#L129 [23:32:54] <huh> + add another if for invert or not... [23:36:48] <grrrit-wm> (03CR) 10Chad: [C: 032] Cleaned up template profile report tabbing [core] - 10https://gerrit.wikimedia.org/r/174309 (owner: 10Aaron Schulz) [23:38:06] <wikibugs> 3Wikimedia / 3Extension setup: Review and deploy GlobalUserPage extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/70576#c7 (10James Forrester) Semi-+1 from a Product perspective; I'd recommend that LCA get flagged (at the very least) first before considering it a +2. [23:39:37] <wikibugs> 3MediaWiki-Vagrant: EventLogging cannot find schemas on MW-Vagrant - 10https://bugzilla.wikimedia.org/70979#c7 (10Tisza Gergő) *** Bug 70183 has been marked as a duplicate of this bug. *** [23:39:37] <wikibugs> 3MediaWiki-Vagrant: Validation error against schema <schema>: Unknown schema: <schema> - 10https://bugzilla.wikimedia.org/70183#c3 (10Tisza Gergő) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 70979 *** [23:42:24] <grrrit-wm> (03Merged) 10jenkins-bot: Cleaned up template profile report tabbing [core] - 10https://gerrit.wikimedia.org/r/174309 (owner: 10Aaron Schulz) [23:48:07] <wikibugs> 3Wikimedia / 3Extension setup: Review and deploy GlobalUserPage extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/70576#c8 (10MZMcBride) (In reply to James Forrester from comment #7) > Semi-+1 from a Product perspective; I'd recommend that LCA get flagged (at > the very least) first before cons... [23:49:44] <grrrit-wm> (03CR) 10Mattflaschen: "Thanks, TheDJ. For the server side, I filed https://bugzilla.wikimedia.org/show_bug.cgi?id=73583 ." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/174023 (owner: 10EBernhardson) [23:50:07] <wikibugs> 3Wikimedia / 3Extension setup: Review and deploy GlobalUserPage extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/70576#c9 (10James Forrester) (In reply to MZMcBride from comment #8) > (In reply to James Forrester from comment #7) > > Semi-+1 from a Product perspective; I'd recommend that LCA g... [23:57:07] <wikibugs> 3Wikimedia / 3Extension setup: Review and deploy GlobalUserPage extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/70576#c10 (10MZMcBride) (In reply to James Forrester from comment #9) > It's the C, not the L, part of LCA that will mostly care, as it trivially > impacts community audit requireme... [23:58:36] <wikibugs> 3Wikimedia / 3Extension setup: Review and deploy GlobalUserPage extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/70576#c11 (10James Forrester) (In reply to MZMcBride from comment #10) > (In reply to James Forrester from comment #9) > > It's the C, not the L, part of LCA that will mostly care,... [23:59:51] <wikibugs> 3MediaWiki-Vagrant: Postgres: command-line installer fails every time: "Class 'PostgresqlInstaller' not found" - 10https://bugzilla.wikimedia.org/61350#c4 (10Bryan Davis) I'm inclined to close this as RESOLVED>INVALID. MediaWiki-Vagrant doesn't have any puppet configuration to install Postgres and the default...