[00:00:56] (03PS1) 10Chad: Updating Echo to pick up I7304046c [core] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/173202 [00:02:29] (03PS1) 10Chad: Updating Echo to pick up I7304046c [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173203 [00:02:50] (03CR) 10Chad: [C: 032 V: 032] Updating Echo to pick up I7304046c [core] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/173202 (owner: 10Chad) [00:02:55] (03CR) 10Chad: [C: 032 V: 032] Updating Echo to pick up I7304046c [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173203 (owner: 10Chad) [00:03:08] (03CR) 10Jaredzimmerman: "basically any case there a target is not clearly tied to the target, in the case of this control there is more target area that is white s" [core] - 10https://gerrit.wikimedia.org/r/165256 (owner: 10Jdlrobson) [00:05:23] (03Merged) 10jenkins-bot: Update MobileFrontend [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173201 (owner: 10Kaldari) [00:08:02] Set up wiki pages and wikitables for health check survey results - https://phabricator.wikimedia.org/T1212#22144 (10KLans_WMF) [00:08:48] Publish Q1 health check data - https://phabricator.wikimedia.org/T1023#22145 (10KLans_WMF) [00:08:56] Publish Q1 health check data - https://phabricator.wikimedia.org/T1023#17730 (10KLans_WMF) [00:09:45] (03CR) 10Malvineous: "The problem with $wgConfirmAccountFSRepos is that it's a huge variable to set and as you point out it's very involved to configure it prop" [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/170275 (owner: 10Malvineous) [00:11:59] (03PS1) 10Catrope: Update VisualEditor for cherry-pick [core] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/173206 [00:12:30] 3MediaWiki / 3Redirects: Interwiki redirects via URL and other 301s are indexed by Google search - 10https://bugzilla.wikimedia.org/26115#c24 (10Nemo) (In reply to Matthew Flaschen from comment #23) > It may or may not still be happening. But I don't see any examples at > https://archive.today/ysbIZ . Don'... [00:13:10] (03PS1) 10Catrope: Update VE for cherry-pick [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173208 [00:13:49] (03CR) 10Chad: [C: 032 V: 032] Update VisualEditor for cherry-pick [core] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/173206 (owner: 10Catrope) [00:13:55] (03CR) 10Chad: [C: 032 V: 032] Update VE for cherry-pick [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173208 (owner: 10Catrope) [00:15:31] hah, apparently my commit messages are terribly inconsistent [00:15:57] <^d> I gave up on trying to get people to write nice commit summaries ages ago :) [00:21:30] 3Logstash: doc_values setting in mapping causes fields >32K to reject indexing document - https://phabricator.wikimedia.org/T1269#22148 (10bd808) 5Open>3Resolved Default index mapping updated in beta and prod. New mapping can be seen in . This should take effect st... [00:22:57] 3Logstash: doc_values setting in mapping causes fields >32K to reject indexing document - https://phabricator.wikimedia.org/T1269#22151 (10bd808) [00:23:01] Create team projects for all teams participating in scrum of scrums - https://phabricator.wikimedia.org/T1211#22152 (10bd808) [00:28:28] (03PS2) 10Mattflaschen: Doc: Document problem sorting inserted data [core] - 10https://gerrit.wikimedia.org/r/171999 (https://bugzilla.wikimedia.org/72367) (owner: 10EBernhardson) [00:31:18] (03CR) 10Mattflaschen: [C: 032] Doc: Document problem sorting inserted data [core] - 10https://gerrit.wikimedia.org/r/171999 (https://bugzilla.wikimedia.org/72367) (owner: 10EBernhardson) [00:33:22] (03PS1) 10Kaldari: Update WikiGrok and MobileFrontend [core] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/173217 [00:35:07] (03CR) 10EBernhardson: [C: 04-1] "LQT records title changes but we are only importing the top revision" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [00:36:47] (03Merged) 10jenkins-bot: Doc: Document problem sorting inserted data [core] - 10https://gerrit.wikimedia.org/r/171999 (https://bugzilla.wikimedia.org/72367) (owner: 10EBernhardson) [00:37:22] (03PS50) 10EBernhardson: Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [00:38:09] (03CR) 10jenkins-bot: [V: 04-1] Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [00:52:36] (03CR) 10Kaldari: [C: 032] Update WikiGrok and MobileFrontend [core] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/173217 (owner: 10Kaldari) [00:57:51] (03CR) 10EBernhardson: "i can't seem to figure out how to get previous topic subject's out of the LQT api ... will try more later" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [00:58:12] (03Merged) 10jenkins-bot: Update WikiGrok and MobileFrontend [core] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/173217 (owner: 10Kaldari) [00:58:33] (03PS1) 10saper: ImportTest should not depend on allow_url_fopen=1 [core] - 10https://gerrit.wikimedia.org/r/173221 [00:58:35] (03PS1) 10saper: Use ImportStringSource for simple import sources [core] - 10https://gerrit.wikimedia.org/r/173222 (https://bugzilla.wikimedia.org/73283) [00:59:41] (03Abandoned) 10saper: ImportTest should not depend on allow_url_fopen=1 [core] - 10https://gerrit.wikimedia.org/r/173221 (owner: 10saper) [00:59:58] (03Abandoned) 10saper: Use ImportStringSource for simple import sources [core] - 10https://gerrit.wikimedia.org/r/173222 (https://bugzilla.wikimedia.org/73283) (owner: 10saper) [01:01:29] (03PS1) 10saper: Use ImportStringSource for simple import sources [core] - 10https://gerrit.wikimedia.org/r/173223 (https://bugzilla.wikimedia.org/73283) [01:03:22] (03CR) 10saper: "Early code to fix this properly is submitted in change I61c94202467ae6729ae52684a6477f7cbd8e00b7" [core] - 10https://gerrit.wikimedia.org/r/172657 (https://bugzilla.wikimedia.org/73283) (owner: 10saper) [01:03:42] (03CR) 10saper: "Not tested via special page, API or scripts." [core] - 10https://gerrit.wikimedia.org/r/173223 (https://bugzilla.wikimedia.org/73283) (owner: 10saper) [01:07:04] (03CR) 10jenkins-bot: [V: 04-1] Use ImportStringSource for simple import sources [core] - 10https://gerrit.wikimedia.org/r/173223 (https://bugzilla.wikimedia.org/73283) (owner: 10saper) [01:09:18] 3Wikimedia / 3Site requests: Set $wgCheckUserForceSummary to true on Wikimedia wikis - 10https://bugzilla.wikimedia.org/71457 (10Dereckson) a:3Glaisher [01:11:15] 3Wikimedia / 3Site requests: install Extension:Translate on cawikimedia - 10https://bugzilla.wikimedia.org/73394 (10Dereckson) p:5Unprio>3Normal s:5normal>3enhanc [01:13:28] Document user migration process - https://phabricator.wikimedia.org/T1156#22155 (10Mattflaschen) I [clarified how to signup](https://www.mediawiki.org/w/index.php?title=Phabricator/Help&diff=1260536&oldid=1254123) a little on MediaWiki.org. I agree it would be nice to have a little more visibility on the user mig... [01:17:50] Document user migration process - https://phabricator.wikimedia.org/T1156#22156 (10Mattflaschen) [01:18:36] (03PS2) 10saper: Use ImportStringSource for simple import sources [core] - 10https://gerrit.wikimedia.org/r/173223 (https://bugzilla.wikimedia.org/73283) [01:25:01] 3Wikimedia / 3Site requests: install Extension:Translate on cawikimedia - 10https://bugzilla.wikimedia.org/73394 (10Dereckson) 5NEW>3ASSI a:3Dereckson [01:35:40] (03CR) 10Mattflaschen: "Removing myself" [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/144780 (https://bugzilla.wikimedia.org/60432) (owner: 10TheDJ) [01:38:45] Replace default avatar icon - https://phabricator.wikimedia.org/T256#22166 (10Mattflaschen) [01:44:30] 3MediaWiki / 3JavaScript: Core modules should use mediawiki.cookie instead of jquery.cookie - 10https://bugzilla.wikimedia.org/65384#c3 (10Matthew Flaschen) Unsubscribing, but feel free to add me to code review on this. [01:45:16] 3Wikimedia / 3Site requests: Install Translate extension on be.wikimedia.org - 10https://bugzilla.wikimedia.org/37391 (10Dereckson) a:3Robin Pepermans (SPQRobin) [01:53:48] 3Wikimedia / 3DNS: Redirect mul.wikisource.org to wikisource.org - 10https://bugzilla.wikimedia.org/73407 (10This, that and the other (TTO)) 3NEW p:3Unprio s:3minor a:3None From [[phabricator:T1257]]: [[s:fr:]] goes to fr.wikisource.org, but [[s:mul:]] goes to wikisource.org. Users may then expect... [01:54:00] mul.wikisource.org should redirect to the multi-lingual portal wikisource.org - https://phabricator.wikimedia.org/T1257#22179 (10TTO) Would actually be Wikimedia > DNS, if we are going to be fussy. I filed [[bugzilla:73407]]. [01:54:15] 3Wikimedia / 3Site requests: install Extension:Translate on cawikimedia - 10https://bugzilla.wikimedia.org/73394#c3 (10Dereckson) I let some messages to Amqui on IRC about the different possibilities of configuation of the extension. The patch uses sensible settings for a small team wiki. [01:54:28] mul.wikisource.org should redirect to the multi-lingual portal wikisource.org - https://phabricator.wikimedia.org/T1257#22182 (10TTO) What, wikilink syntax doesn't work here? That needs to be fixed... [01:58:15] 3Wikimedia / 3Site requests: Enable VisualEditor by default for all users on the Tagalog Wikipedia (currently a Beta Feature there) - 10https://bugzilla.wikimedia.org/73365 (10Dereckson) [02:03:00] 3Wikimedia / 3Site requests: Set $wgCheckUserForceSummary to true on Wikimedia wikis - 10https://bugzilla.wikimedia.org/71457#c18 (10billinghurst) (In reply to Glaisher from comment #17) > It might also be useful to send another mail to checkusers-l informing that > this has now been done (and not to use vag... [02:12:46] 3MediaWiki extensions / 3ZeroBanner: Fatal error: Class undefined: ResourceLoaderTemplateModule in /srv/mediawiki/php-master/includes/resourceloader/ResourceLoader.php on line 506 - 10https://bugzilla.wikimedia.org/73377#c19 (10Jon) I'm not sure why OCG broke or what that is but this would have been noticed... [02:14:45] 3MediaWiki / 3Page editing: Changes lost when submitting an edit after the session has expired - 10https://bugzilla.wikimedia.org/9749#c4 (10Matthew Flaschen) 5NEW>3RESO/FIX I think this is fixed (a long time ago). I did the following (locally): 1. Log in. 2. Go to an edit page. 3. Make some changes 4.... [02:16:00] 3MediaWiki / 3History/Diffs: Correcting edit summaries (if own, last, & recent) - 10https://bugzilla.wikimedia.org/13937#c21 (10John Mark Vandenberg) Note that https://www.mediawiki.org/wiki/Extension:RevisionCommentSupplement provides similar functionality without the dependency on bug 10105 [02:18:01] 3MediaWiki / 3History/Diffs: Allow editing of edit summaries after the fact - 10https://bugzilla.wikimedia.org/10105#c6 (10John Mark Vandenberg) Unrelated to changing the original summary in the database, worth noting that https://www.mediawiki.org/wiki/Extension:RevisionCommentSupplement may be sufficient f... [02:20:16] (03CR) 10Aaron Schulz: [C: 032] Generate $wgAutoloadLocalClasses with a maint script [core] - 10https://gerrit.wikimedia.org/r/163304 (owner: 10EBernhardson) [02:25:48] (03Merged) 10jenkins-bot: Generate $wgAutoloadLocalClasses with a maint script [core] - 10https://gerrit.wikimedia.org/r/163304 (owner: 10EBernhardson) [02:33:16] (03PS5) 10Lubaochuan: Fixed Style/LeadingCommentSpace RuboCop offense Change-Id: I7edaf2d65bbaace3715eee3b6497a8d468595e7d [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/171508 [02:39:45] 3Utilities / 3WM-Bot: Don't use WDDX (set to die in May 2015) - 10https://bugzilla.wikimedia.org/71543 (10Andre Klapper) [02:44:15] 3Utilities / 3WM-Bot: wm-bot should not use WDDX MediaWiki API format (format going away May 2015) - 10https://bugzilla.wikimedia.org/71543 (10MZMcBride) [02:45:32] (03PS6) 10Lubaochuan: Fixed Style/LeadingCommentSpace RuboCop offense Removed Style/LeadingCommentSpace RuboCop offense from .rubocop_todo.yml file [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/171508 [02:49:19] Need review of CSSJanus "support for four-value rules" - https://phabricator.wikimedia.org/T1220#21083 (10Mattflaschen) [02:49:50] (03PS7) 10Lubaochuan: Fixed Style/LeadingCommentSpace RuboCop offense Removed Style/LeadingCommentSpace RuboCop offense from .rubocop_todo.yml file [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/171508 [02:50:00] 3MediaWiki / 3Patrolling: Rollback shouldn't patrol without log entry - 10https://bugzilla.wikimedia.org/40624#c2 (10Dalba) I was going to get all unpatrolled edits of an article using api. To do so I first got all needed revisions ('action=query&prop=revisions&titles=...') and then compared the results with... [02:53:11] (03PS18) 10Mattflaschen: build: Implement Grunt workflow (via npm test) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163908 (owner: 10Spage) [02:54:07] (03CR) 10jenkins-bot: [V: 04-1] build: Implement Grunt workflow (via npm test) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163908 (owner: 10Spage) [02:57:01] (03PS8) 10Lubaochuan: Fixed Style/LeadingCommentSpace RuboCop offense in the two files Removed Style/LeadingCommentSpace RuboCop offense from .rubocop_todo.yml file [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/171508 [02:58:21] (03PS9) 10Lubaochuan: Fixed Style/LeadingCommentSpace RuboCop offense in the two files Removed Style/LeadingCommentSpace RuboCop offense from .rubocop_todo.yml file [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/171508 [03:17:46] (03CR) 10EBernhardson: "afaict liquidthreads doesn't expose the thread history" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [03:18:15] (03CR) 10EBernhardson: "afaict liquidthreads doesn't expose the thread history over api, to import historical topic titles would have to adjust the lqt api" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [03:21:54] (03CR) 10Alex Monk: [wip] Adding paramOrder widget to TemplateData editor (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/170655 (owner: 10Mooeypoo) [03:31:17] Publish names of attendees and topics they are interested in discussing for MediaWiki Developers Summit - https://phabricator.wikimedia.org/T1219#22198 (10Rfarrand) p:5Triage>3Normal [03:57:30] (03PS51) 10EBernhardson: Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [03:58:19] (03CR) 10EBernhardson: "PS51: Now only imports top revision of header. Lets ship this, its completely localized and we can't keep updating this patch" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [04:22:45] 3Utilities / 3WM-Bot: wm-bot should not use WDDX MediaWiki API format (format going away May 2015) - 10https://bugzilla.wikimedia.org/71543#c2 (10MZMcBride) While auto-assigning in Bugzilla is convenient, I do wonder if it leads to cookie-licking. [04:26:46] 3Wikimedia / 3Media storage: Files disappear and give 404's for the full resolution - 10https://bugzilla.wikimedia.org/69362#c6 (10This, that and the other (TTO)) *** Bug 73002 has been marked as a duplicate of this bug. *** [04:26:46] 3Wikimedia / 3General/Unknown: 404 file on Commons: "File:Encyclia diurna (=Epidendrum diurnum)- Icones v. 3 pl. 603.jpg" - 10https://bugzilla.wikimedia.org/73002#c1 (10This, that and the other (TTO)) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 69362 *** [04:27:30] 3Wikimedia / 3Media storage: Files disappear and give 404's for the full resolution - 10https://bugzilla.wikimedia.org/69362#c7 (10This, that and the other (TTO)) This is pretty serious, isn't it? Files just disappearing, and inaccessible? [04:34:45] 3Wikimedia / 3DNS: Redirect mul.wikisource.org to wikisource.org - 10https://bugzilla.wikimedia.org/73407#c1 (10Justin Anthony Knapp) Originally posted here: https://phabricator.wikimedia.org/T1257 [04:36:25] (03PS1) 10EBernhardson: Stop indentation at .flow-post-max-depth [extensions/Flow] - 10https://gerrit.wikimedia.org/r/173232 [04:46:32] 3MediaWiki / 3API: The API list=recentchanges and prop=revisions should return the rev_sha1 field - 10https://bugzilla.wikimedia.org/73411 (10Nathan Larson) 3NEW p:3Unprio s:3minor a:3None It's unclear why the API in general converts from the internally-stored base-36 representation to base-16, excep... [04:46:46] 3MediaWiki / 3API: The API list=recentchanges and prop=revisions should return the rev_sha1 field - 10https://bugzilla.wikimedia.org/73411#c1 (10Nathan Larson) h/t Brad Jorsch [04:54:17] 3MediaWiki extensions / 3Other: GraphViz and MscGen Graphics produce errors and do not render properly when page saved - 10https://bugzilla.wikimedia.org/73073#c7 (10Keith Welter) The StripState.php: Invalid marker exception is caused by a recursive call to Parser::parse. The documentation for Parser::parse... [05:05:15] 3MediaWiki extensions / 3Other: GraphViz and MscGen Graphics produce errors and do not render properly when page saved - 10https://bugzilla.wikimedia.org/73073#c8 (10Keith Welter) The key points from the prior back trace are: 1) The GraphViz extension uploaded a file (a graph image) from the context of a Par... [05:11:00] 3MediaWiki extensions / 3Math: MathML: Using en dash as minus takes a parser error - 10https://bugzilla.wikimedia.org/73367#c1 (10physikerwelt) 5NEW>3RESO/INV I don't understand your poblem. In $\TeX$ you are supposed to use a normal - (https://en.wikipedia.org/wiki/Plus_and_minus_signs#Minus_sign) char.... [05:12:00] 3MediaWiki extensions / 3Math: Undesired spaces added after math expressions - 10https://bugzilla.wikimedia.org/72806#c6 (10physikerwelt) 5PATC>3RESO/FIX Change got merged. [05:14:30] 3MediaWiki extensions / 3Math: support regular action=purge - 10https://bugzilla.wikimedia.org/72537 (10physikerwelt) [05:21:16] 3MediaWiki extensions / 3Popups: Hovercards wastes API call and "TypeError re.query is undefined" on external links and other links with no title - 10https://bugzilla.wikimedia.org/65929 (10Prateek Saxena) 5PATC>3RESO/FIX [05:53:07] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (fe4076af75) [core] - 10https://gerrit.wikimedia.org/r/173179 (owner: 10Jforrester) [05:58:35] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (fe4076af75) [core] - 10https://gerrit.wikimedia.org/r/173179 (owner: 10Jforrester) [06:00:18] (03CR) 10Physikerwelt: [V: 032] "tested on vagrant... update works" [extensions/Math] - 10https://gerrit.wikimedia.org/r/171627 (https://bugzilla.wikimedia.org/73090) (owner: 10Physikerwelt) [06:20:03] 3MediaWiki-Vagrant: mysql port forwarding - 10https://bugzilla.wikimedia.org/73413 (10physikerwelt) 3NEW p:3Unprio s:3normal a:3None After enabeling the port fowarding for mysql/mariadb according to the template in support/Vagrant-extrafile a connection to the database server is not possible from the r... [06:33:16] 3Wikimedia / 3Site requests: Enable VisualEditor by default for all users on the Tagalog Wikipedia (currently a Beta Feature there) - 10https://bugzilla.wikimedia.org/73365#c3 (10Roan Kattouw) (In reply to Gerrit Notification Bot from comment #2) > Change 172993 had a related patch set uploaded by Jforrester... [06:53:00] 3MediaWiki-Vagrant: PHP errors swallowed. - 10https://bugzilla.wikimedia.org/73037#c11 (10Jon) 5PATC>3RESO/FIX I see errors now. This is good. [06:55:36] (03PS1) 10Aaron Schulz: Improved MIME detection in FileBackend [core] - 10https://gerrit.wikimedia.org/r/173241 [07:07:16] 3MediaWiki / 3Patrolling: Rollback shouldn't patrol without log entry - 10https://bugzilla.wikimedia.org/40624#c3 (10Nemo) (In reply to Dalba from comment #2) > Do you know a better way to do this? Patrolled edits are RC properties, ask the RC: [[mw:API:Recentchanges]]. [07:43:50] Requesting a Wikimedia stand at FOSDEM - https://phabricator.wikimedia.org/T1073#22210 (10Qgil) Dimitar replied, and he is going to request the stand. Phew! [07:55:21] Replace default avatar icon - https://phabricator.wikimedia.org/T256#22211 (10mmodell) @qgil there isn't really a clean way to maintain this outside of the upstream. @valhallasw: proposing a config option upstream would be ideal, for sure. Anyone wanna submit a patch to https://secure.phabricator.org? [07:58:02] 3MediaWiki / 3Page editing: Changes lost when submitting an edit after the session has expired - 10https://bugzilla.wikimedia.org/9749#c5 (10Nemo) 5RESO/FIX>3REOP (In reply to Matthew Flaschen from comment #4) > I think this is fixed (a long time ago). As far as I remember the "Sorry! We could not proce... [08:15:36] (03PS2) 10Nemo bis: Added updated version history from 1.19.2 to 1.22.13 [core] - 10https://gerrit.wikimedia.org/r/173093 (https://bugzilla.wikimedia.org/42723) (owner: 10Ckoerner) [08:16:03] (03CR) 10Nemo bis: "Looks ok at first glance" [core] - 10https://gerrit.wikimedia.org/r/173093 (https://bugzilla.wikimedia.org/42723) (owner: 10Ckoerner) [08:29:04] (03CR) 10Zfilipin: [C: 04-1] "Excellent work! :)" (033 comments) [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/171508 (owner: 10Lubaochuan) [08:51:49] Desperate times... I naively thought that formatting test fixture data as .json would make it accessible from MediaWiki QUnit tests, somehow... [08:53:41] Is this a thing people do? Do I have to write a subclass of ResourceLoaderModule or something? and... If we have to specify the number of assertions, how would I be able to test using a data provider, which could be of any length... [08:55:30] 3Wikimedia / 3Mailing lists: Create mailing list specifically for Afrikaans speaking contributors - Wikimedia ZA - 10https://bugzilla.wikimedia.org/73066#c5 (10Theresa Hume) Can you please advise on the status of this? Many thanks [08:56:31] 3MediaWiki extensions / 3Translate: Translation page does not contain the latest translations/last translation - 10https://bugzilla.wikimedia.org/46716#c30 (10Niklas Laxström) I'm sorry but responding to your questions which are spread out like been shot with shotgun requires me to explain you how Translate... [08:57:00] awight: I don't understand what's the problem [08:57:20] you can set the number of assertions to whatever you want [08:57:45] 3Wikimedia / 3Mailing lists: Create mailing list specifically for Afrikaans speaking contributors - Wikimedia ZA - 10https://bugzilla.wikimedia.org/73066#c6 (10Glaisher) It might also be useful to post the email addresses of the initial listadmins here. [08:59:33] Nikerabbit: well, I'm trying to test some ResourceLoaded javascript... it will be the client side port of the PHP code I'm testing here: https://gerrit.wikimedia.org/r/#/c/173225/3/tests/BannerAllocationCalculatorTest.php,unified [09:00:07] as you see, I'm using phpunit's @dataProvider statement to load an arbitrary number of fixtures [09:01:04] Yeah I'm not too worried about the exact number of assertions, it could be fixtures.length if need be [09:01:14] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I checked each and I'm sure. Please recheck or ask and I will recheck." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/172691 (owner: 10Thiemo Mättig (WMDE)) [09:01:30] Loading the fixtures, however, is looking nasty. [09:01:51] yeah, I haven't done that myself [09:03:31] Nikerabbit: it's a nice technique, where appropriate... [09:03:42] Thanks for taking a look! [09:07:48] Krinkle: I'm trying to load json into qunit tests, can you point me to any prior art? [09:08:12] awight: What kind of data? Test cases? [09:08:16] or would I have to encapsulate as jsonp or write a custom RL module subclass for something like that... [09:08:28] Krinkle: yeah, like @dataProvider in PHPUnit [09:08:31] No, shouldn't be needed, but depends. [09:08:36] awight: Why is it in a separate file? [09:08:46] Krinkle: cos it is also used by PHPUnit tests [09:08:56] that's why wrapping as jsonp would be sort of a PITA [09:09:08] well, certainly not jsonp [09:09:15] no need for a callback on the same domain [09:09:44] You could use $.ajax to load it from the test data directly, like we do in core. [09:09:51] Here's the preliminary work... https://gerrit.wikimedia.org/r/#/c/173225 [09:09:53] it'll be async, but that's the fastest approach [09:10:10] I can just ajax a random filesystem path within the mw root? [09:10:11] $.ajax wgExtensionAssetsPath [09:10:14] aha [09:10:17] No, not just any path [09:10:17] ok thx that's great [09:10:24] only if it's explicitly exposed as web-readable [09:10:30] excellent [09:10:35] (03PS2) 10Thiemo Mättig (WMDE): Add missing visibility keywords everywhere [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/172691 [09:10:42] '/tests/data', 'uploads', 'extensions', 'resources' and 'skins' are web-readable. [09:11:18] 3Wikimedia / 3General/Unknown: Remove proxyunbannable from sysop - 10https://bugzilla.wikimedia.org/73414 (10Cenarium) 3NEW p:3Unprio s:3normal a:3None Proxyunbannable is a userright granted to sysops by [[mw:Extension:AutoProxyBlock]]. But this extension is not used on WMF wikis, which instead use [... [09:12:50] (03CR) 10Thiemo Mättig (WMDE): "I rechecked and made two getTestModules protected." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/172691 (owner: 10Thiemo Mättig (WMDE)) [09:13:00] 3MediaWiki-Vagrant: mysql port forwarding - 10https://bugzilla.wikimedia.org/73413#c1 (10physikerwelt) p:5Unprio>3Low I found a workaround: 1. uncomment the binding to 127.0.0.1 in /etc/mysql/my.cnf 2. execute the mysql command GRANT ALL PRIVILEGES ON *.* TO 'root'@'%'; [09:15:35] Krinkle: looks like that will work! [09:16:09] awight: Something similar for CSSJanus, https://github.com/cssjanus/php-cssjanus/blob/master/test/suites/CSSJanusTest.php [09:16:34] (ignore that it's fetching it from a remote url) [09:18:20] Very nice to have. I need fixture support in the browser tests I just wrote for CentralNotice, too... not sure how I'm going to tackle that. [09:19:16] I could implement a writable API, but for CN, that's more of a liability than benefit. [09:28:46] 3Wikimedia / 3General/Unknown: Wikisource related bugs and enhancements (tracking) - 10https://bugzilla.wikimedia.org/35925 (10Glaisher) [09:28:47] 3Wikimedia / 3DNS: Redirect mul.wikisource.org to wikisource.org - 10https://bugzilla.wikimedia.org/73407 (10Glaisher) 5NEW>3ASSI p:5Unprio>3Normal s:5minor>3enhanc a:3Glaisher [09:33:30] 3MediaWiki / 3API: rollback token system is randomly broken - 10https://bugzilla.wikimedia.org/73207#c8 (10Peter Bena) 5UNCO>3RESO/WOR I can no longer reproduce it, this bug will need to be resolved by x-files department of FBI. Just as with UFO, there are people who have seen it. Have evidence. But nob... [09:40:15] 3MediaWiki extensions / 3WikimediaMessages: A missing condition in templates - 10https://bugzilla.wikimedia.org/73387 (10Nemo) [09:40:32] 3MediaWiki / 3Interface: Interface messages needing rewording or documentation and other issues with existing messages (tracking) - 10https://bugzilla.wikimedia.org/38638 (10Nemo) [09:40:32] 3MediaWiki extensions / 3WikimediaMessages: A missing condition in templates - 10https://bugzilla.wikimedia.org/73387 (10Nemo) [09:45:18] 3MediaWiki extensions / 3EducationProgram: Remove EducationProgram rights from sysop - 10https://bugzilla.wikimedia.org/73416 (10Cenarium) 3NEW p:3Unprio s:3normal a:3None The sysop usergroup shouldn't have any education program userrights, since those are very specialized and already possessed by co... [09:50:37] Krinkle: you might enjoy how easy that was... https://gerrit.wikimedia.org/r/#/c/173249/2/tests/qunit/ext.centralNotice.bannerController.lib/bannerController.lib.tests.js,unified -- thanks again :) [09:52:02] awight: Be careful of defining tests asynchronously though. They may not run at all in Jenkins. [09:52:18] Tests can be asynchronous, but the tests themselves should be defined up front. [09:52:46] As soon as the test file is exhausted and no tests are pending, the test suite is closed. [09:53:15] ok, glad to be warned [09:53:44] When things appear to be simple ... ;) [09:54:26] Krinkle: u think QUnit.start()/stop will work here, or is that only possible from within already-defined tests? [09:54:41] only within a test. [09:55:03] It's hairy indeed. [09:55:29] blaargh! [09:55:53] I'll sleep on it, in that case [09:55:55] You might be able to define other tests within a test. [09:56:03] So you'd wrap it in a noop test [09:56:05] that is async [09:56:15] meh, I'd be happy to just include the test case title in assertions [09:56:34] but... then I'm back to not knowing how many assertions there are. [09:56:50] * awight wonders why we have this somewhat pedantic counting of assertions arrangement [09:57:55] You don't need to use that [09:58:05] and no that's not true [09:58:07] you would know it [09:58:11] 0 probably [09:58:12] or maybe 1 [09:58:15] they don't nest [09:58:17] wat. [09:58:33] You'd just define another test while the other test is running. [09:58:41] thedj / Krinkle : #wmhack [09:58:41] yeah that's something I'll try. [09:59:15] multichill: #glamdata2014 #wmhack [09:59:22] multichill: can we tweet the slideshow ? [09:59:34] I'll tweet it [10:04:31] [13cssjanus] 15Krinkle pushed 1 new commit to 06master: 02https://github.com/cssjanus/cssjanus/commit/c7ca88d7aa4eab5433c38ce35cb31582b2ff268c [10:04:31] 13cssjanus/06master 14c7ca88d 15Matthew Flaschen: Support !important in four-value declarations... [10:05:05] [13cssjanus] 15Krinkle closed pull request #27: Add !important support for four-value rules, with tests (06master...06fixImportant) 02https://github.com/cssjanus/cssjanus/pull/27 [10:05:27] cssjanus/cssjanus#60 (master - c7ca88d : Matthew Flaschen): The build passed. [10:05:27] Change view : https://github.com/cssjanus/cssjanus/compare/cf978839045c...c7ca88d7aa4e [10:05:27] Build details : http://travis-ci.org/cssjanus/cssjanus/builds/40980705 [10:07:32] Phabricator search does not search substrings - https://phabricator.wikimedia.org/T679#22218 (10Qgil) Someone else is complaining about this problem upstream: https://secure.phabricator.com/T6552 [10:09:15] 3Wikimedia / 3Site requests: Remove proxyunbannable from sysop - 10https://bugzilla.wikimedia.org/73414 (10Glaisher) [10:09:59] (03PS10) 10Lubaochuan: Fixed Style/LeadingCommentSpace RuboCop offense [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/171508 (https://bugzilla.wikimedia.org/63307) [10:14:50] Krinkle: I won't fix the async issue tonight, but if you're curious whether it works: https://gerrit.wikimedia.org/r/173253 [10:15:09] Nothing I did caused the inner tests to appear in the suite...a [10:19:02] 3Wikimedia / 3Site requests: Remove proxyunbannable from sysop - 10https://bugzilla.wikimedia.org/73414#c1 (10Glaisher) I just checked wmf-config but I don't see anything about 'proxyunbannable' in there except for mlwikis and wikidata. I'm not sure but I think this is done by the TorBlock extension as all... [10:29:29] Document user migration process - https://phabricator.wikimedia.org/T1156#22224 (10Qgil) Maybe this is a misunderstanding. There is no "process" or "stub accounts". Users will get their Bugzilla activity assigned as soon as they add the email address(es) they used in Bugzilla. Before or after the migration, it is... [10:36:15] 3Wikimedia / 3Mailing lists: Create mailing list specifically for Afrikaans speaking contributors - Wikimedia ZA - 10https://bugzilla.wikimedia.org/73066#c7 (10Theresa Hume) (In reply to Glaisher from comment #6) > It might also be useful to post the email addresses of the initial > listadmins here. Thanks,... [11:06:00] 3Wikimedia / 3Site requests: Remove proxyunbannable from sysop - 10https://bugzilla.wikimedia.org/73414 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc [11:06:16] 3MediaWiki extensions / 3SecurePoll: Add arbcom/mainspace list script to SecurePoll and backport - 10https://bugzilla.wikimedia.org/73325 (10Andre Klapper) p:5Unprio>3Normal [11:06:30] 3MediaWiki / 3Parser: External link ending in {{subst:Magic}} does not substitute - 10https://bugzilla.wikimedia.org/73338 (10Andre Klapper) p:5Unprio>3Low [11:06:45] 3MediaWiki / 3General/Unknown: When using MS SQL Server, article links remain red after creation. - 10https://bugzilla.wikimedia.org/73390 (10Andre Klapper) p:5Unprio>3Normal [11:07:00] 3MediaWiki / 3Database: Microsoft SQL Server/MSSQL support (tracking) - 10https://bugzilla.wikimedia.org/9767 (10Andre Klapper) [11:15:04] (03CR) 10Nik: [C: 031] Use ImportStringSource for simple import sources [core] - 10https://gerrit.wikimedia.org/r/173223 (https://bugzilla.wikimedia.org/73283) (owner: 10saper) [11:19:15] 3Wikimedia / 3General/Unknown: 404 file on Commons: "File:Encyclia diurna (=Epidendrum diurnum)- Icones v. 3 pl. 603.jpg" - 10https://bugzilla.wikimedia.org/73002#c2 (10Andre Klapper) 5RESO/DUP>3REOP Not a duplicate. [11:19:30] 3Wikimedia / 3General/Unknown: 404 file on Commons: "File:Encyclia diurna (=Epidendrum diurnum)- Icones v. 3 pl. 603.jpg" - 10https://bugzilla.wikimedia.org/73002 (10Andre Klapper) 5REOP>3NEW [11:22:31] 3MediaWiki / 3API: The API list=recentchanges and prop=revisions should return the rev_sha1 field - 10https://bugzilla.wikimedia.org/73411 (10Andre Klapper) p:5Unprio>3Low s:5minor>3enhanc [11:22:45] 3MediaWiki extensions / 3WikimediaMessages: A missing condition in templates - 10https://bugzilla.wikimedia.org/73387 (10Andre Klapper) p:5Unprio>3Low [11:24:19] mul.wikisource.org should redirect to the multi-lingual portal wikisource.org - https://phabricator.wikimedia.org/T1257#22225 (10Aklapper) @TTO: T53, T99. [12:09:19] (03CR) 10Siebrand: "I'm okay with your proposal. I'd recommend against using a class on "var" (and possibly other tags), because it complicates the strings, a" (038 comments) [core] - 10https://gerrit.wikimedia.org/r/169534 (owner: 10Siebrand) [12:21:03] something (reqstats?) puts many different metrics into graphite, allocating a lot of disk space - https://phabricator.wikimedia.org/T1075#22237 (10fgiunchedi) [12:26:23] (03PS2) 10Siebrand: Update and enrich API documentation [core] - 10https://gerrit.wikimedia.org/r/169534 [12:29:36] something (reqstats?) puts many different metrics into graphite, allocating a lot of disk space - https://phabricator.wikimedia.org/T1075#22240 (10hashar) [12:31:48] Remove statsd plugin from Jenkins - https://phabricator.wikimedia.org/T1278 (10hashar) 3NEW p:3Triage a:3hashar [12:32:08] Remove statsd plugin from Jenkins - https://phabricator.wikimedia.org/T1278#22241 (10hashar) [12:32:21] Remove statsd plugin from Jenkins - https://phabricator.wikimedia.org/T1278#22241 (10hashar) p:5Triage>3Normal [12:33:03] something (reqstats?) puts many different metrics into graphite, allocating a lot of disk space - https://phabricator.wikimedia.org/T1075#18643 (10hashar) We can most probably remove the Statsd plugin from Jenkins. I have created the sub task {T1278} [12:37:54] (03PS1) 10Siebrand: Update "apihelp-upload-param-stash" [core] - 10https://gerrit.wikimedia.org/r/173264 [12:38:22] something (reqstats?) puts many different metrics into graphite, allocating a lot of disk space - https://phabricator.wikimedia.org/T1075#22258 (10fgiunchedi) [12:39:19] (03PS1) 10Siebrand: Fix typo [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/173265 [12:41:49] (03CR) 10Raimond Spekking: [C: 032] Fix typo [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/173265 (owner: 10Siebrand) [12:42:06] (03Merged) 10jenkins-bot: Fix typo [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/173265 (owner: 10Siebrand) [12:48:49] (03PS3) 10Robert Vogel: [WIP] Implementing CR and community feedback [extensions/Teahouse] - 10https://gerrit.wikimedia.org/r/173014 [12:54:45] (03PS2) 10Siebrand: Move $preloadedMessages to LocalisationCache.php [core] - 10https://gerrit.wikimedia.org/r/167891 [13:01:34] 3MediaWiki extensions / 3AbuseFilter: Whether or not the user recently hit the spam blacklist - 10https://bugzilla.wikimedia.org/73417 (10Cenarium) 3NEW p:3Unprio s:3normal a:3None It would be helpful to know if the user recently hit the spam blacklist. For example, to detect spammers trying to get a... [13:01:46] 3MediaWiki extensions / 3AbuseFilter: Whether or not the user recently hit the spam blacklist - 10https://bugzilla.wikimedia.org/73417 (10Cenarium) s:5normal>3enhanc [13:14:11] (03PS2) 10Umherirrender: Use Parser::SFH_NO_HASH/SFH_OBJECT_ARGS class const [core] - 10https://gerrit.wikimedia.org/r/172588 [13:26:45] 3MediaWiki extensions / 3UniversalLanguageSelector: Replace wgULSLanguages with mw.language.getData(code, 'languageNames') - 10https://bugzilla.wikimedia.org/64706 (10Amir E. Aharoni) p:5Unprio>3Normal [13:29:41] 3MediaWiki extensions / 3WikibaseQuery: Don't invoke code that is bound to the DBAL schema classes - 10https://bugzilla.wikimedia.org/73268 (10Jeroen De Dauw) [13:30:56] 3MediaWiki extensions / 3UniversalLanguageSelector: [Compact links]: Middle click in language box impossible - 10https://bugzilla.wikimedia.org/64806 (10Amir E. Aharoni) 5NEW>3RESO/FIX p:5Unprio>3High [13:37:46] 3MediaWiki / 3Logging: Patrolled edits do not appear in patrol log - 10https://bugzilla.wikimedia.org/73362 (10Andre Klapper) p:5Unprio>3High [13:38:45] 3MediaWiki / 3Configuration: Extend User rights through $wgGroupPermissions - 10https://bugzilla.wikimedia.org/73400#c1 (10Andre Klapper) Hi Ian, what is the problem that you would like to solve? :) [13:57:36] (03PS2) 10Krinkle: Delete skins/common/{ajax.js, wikibits.js, images/{magnify-clip-rtl.png, redirectltr.png, redirectrtl.png}} [core] - 10https://gerrit.wikimedia.org/r/172256 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [13:59:14] (03PS3) 10Krinkle: Delete skins/common/{ajax.js, wikibits.js, images/{magnify-clip-rtl.png, redirectltr.png, redirectrtl.png}} [core] - 10https://gerrit.wikimedia.org/r/172256 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [13:59:25] (03CR) 10Krinkle: [C: 031] Delete skins/common/{ajax.js, wikibits.js, images/{magnify-clip-rtl.png, redirectltr.png, redirectrtl.png}} [core] - 10https://gerrit.wikimedia.org/r/172256 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [13:59:35] (03PS4) 10Krinkle: mediawiki.skinning: Provide SVG version of the "magnify clip" icon [core] - 10https://gerrit.wikimedia.org/r/172214 (https://bugzilla.wikimedia.org/69705) (owner: 10Jforrester) [14:01:25] (03CR) 10Krinkle: [C: 04-1] mediawiki.skinning: Provide SVG version of the "magnify clip" icon (031 comment) [core] - 10https://gerrit.wikimedia.org/r/172214 (https://bugzilla.wikimedia.org/69705) (owner: 10Jforrester) [14:11:02] (03PS4) 10Robert Vogel: [WIP] Implementing CR and community feedback [extensions/Teahouse] - 10https://gerrit.wikimedia.org/r/173014 [14:19:44] (03CR) 10Umherirrender: "Works. Thanks." [core] - 10https://gerrit.wikimedia.org/r/173085 (owner: 10BryanDavis) [14:23:01] 3MediaWiki / 3Logging: Patrolled edits do not appear in patrol log - 10https://bugzilla.wikimedia.org/73362#c2 (10Krinkle) On nl.wikipedia.org: 3 edits made in a row * https://nl.wikipedia.org/w/index.php?title=Dru%C3%AFde&diff=42481374&oldid=42361145 * https://nl.wikipedia.org/w/index.php?title=Dru%C3%AFde... [14:26:57] (03CR) 10Krinkle: [C: 04-1] make-wmf-branch: forge Zuul cloner parameters (032 comments) [tools/release] - 10https://gerrit.wikimedia.org/r/161225 (owner: 10Hashar) [14:27:27] (03CR) 10Krinkle: [C: 04-1] make-wmf-branch: factor out php sapi == cli check (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/161224 (owner: 10Hashar) [14:29:52] (03CR) 10Krinkle: ResourceLoader: Stop passing around errors as /**/-comments (031 comment) [core] - 10https://gerrit.wikimedia.org/r/172591 (owner: 10Bartosz Dziewoński) [14:33:40] (03PS2) 10Umherirrender: Set wgMetaNamespace on TitleTest.php [core] - 10https://gerrit.wikimedia.org/r/173060 (https://bugzilla.wikimedia.org/65879) [14:34:12] (03CR) 10Umherirrender: "Patch Set 2: Fixed a issue with cached language objects" [core] - 10https://gerrit.wikimedia.org/r/173060 (https://bugzilla.wikimedia.org/65879) (owner: 10Umherirrender) [14:37:33] (03PS1) 10Manybubbles: Fix pool counter usage [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/173279 [14:44:09] (03CR) 10Raimond Spekking: [C: 032] Update "apihelp-upload-param-stash" [core] - 10https://gerrit.wikimedia.org/r/173264 (owner: 10Siebrand) [14:49:40] (03PS2) 10Southparkfan: Use __DIR__ instead of dirname( __FILE__ ) [core] - 10https://gerrit.wikimedia.org/r/173068 [14:58:32] 3MediaWiki / 3User blocking: Remove $wgBlockOpenProxies (or move to an extension) - 10https://bugzilla.wikimedia.org/54597#c9 (10Cenarium) 5RESO/FIX>3REOP Change was not complete. It did not remove the proxyunbannable userright from sysop which granted immunity to $wgBlockOpenProxies. [14:59:15] (03CR) 10Chad: "Couple of inline nits, but functionally ok." (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/173279 (owner: 10Manybubbles) [15:05:46] 3Wikimedia / 3Site requests: Remove proxyunbannable from sysop - 10https://bugzilla.wikimedia.org/73414#c2 (10Cenarium) 5NEW>3RESO/DUP The AutoProxyBlock extension seems to be an offshoot of the deprecated $wgBlockOpenProxies. Proxyunbannable was missed. *** This bug has been marked as a duplicate of bu... [15:05:46] 3MediaWiki / 3User blocking: Remove $wgBlockOpenProxies (or move to an extension) - 10https://bugzilla.wikimedia.org/54597#c10 (10Cenarium) *** Bug 73414 has been marked as a duplicate of this bug. *** [15:12:03] (03CR) 10Umherirrender: "Should have a test to ensure the alphabetically order of the array to avoid manual entrys in wrong order to be merged and producing a bad " (031 comment) [core] - 10https://gerrit.wikimedia.org/r/163304 (owner: 10EBernhardson) [15:13:52] (03CR) 10Umherirrender: "Used windows directory style on windows machine (/ vs. \\)" [core] - 10https://gerrit.wikimedia.org/r/163304 (owner: 10EBernhardson) [15:13:56] (03CR) 10Jforrester: mediawiki.skinning: Provide SVG version of the "magnify clip" icon (031 comment) [core] - 10https://gerrit.wikimedia.org/r/172214 (https://bugzilla.wikimedia.org/69705) (owner: 10Jforrester) [15:14:30] 3MediaWiki / 3API: The API list=recentchanges and prop=revisions should return the rev_sha1 field - 10https://bugzilla.wikimedia.org/73411#c2 (10Brad Jorsch) The title, as stated, makes this a WORKSFORME because it already returns the field. Comment 0 makes it clear that it's just not encoded in the specifi... [15:14:36] (03PS5) 10Jforrester: mediawiki.skinning: Provide SVG version of the "magnify clip" icon [core] - 10https://gerrit.wikimedia.org/r/172214 (https://bugzilla.wikimedia.org/69705) [15:15:00] 3MediaWiki / 3API: The API list=recentchanges and prop=revisions should return the rev_sha1 field in the internal base-36 format rather than base-16 - 10https://bugzilla.wikimedia.org/73411 (10Brad Jorsch) [15:21:27] (03CR) 10Anomie: Update "apihelp-upload-param-stash" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/173264 (owner: 10Siebrand) [15:25:01] 3MediaWiki extensions / 3Collection: Collection extension needs some way to credit original authors of a work - 10https://bugzilla.wikimedia.org/28064 (10Helder) [15:25:01] 3MediaWiki extensions / 3Extensions requests: Customizable summary of page editors/authors - 10https://bugzilla.wikimedia.org/27629 (10Helder) [15:29:38] thedj: Moet meteen aan http://xkcd.com/927/ denken [15:31:23] (03CR) 10Southparkfan: "Commit message (title) updated." [core] - 10https://gerrit.wikimedia.org/r/173068 (owner: 10Southparkfan) [15:50:16] (03CR) 10Umherirrender: "jenkins seems to lost the job for this merge, so needs resubmit. But I will not doing that, because it is unclear to me, if the text shoul" [core] - 10https://gerrit.wikimedia.org/r/173264 (owner: 10Siebrand) [16:08:32] 3MediaWiki / 3User blocking: Remove $wgBlockOpenProxies (or move to an extension) - 10https://bugzilla.wikimedia.org/54597#c11 (10Kevin Israel (PleaseStand)) 5REOP>3RESO/FIX (In reply to Cenarium from comment #9) > Change was not complete. It did not remove the proxyunbannable userright > from sysop whic... [16:10:15] 3Wikimedia / 3Site requests: Remove proxyunbannable from sysop - 10https://bugzilla.wikimedia.org/73414#c3 (10Kevin Israel (PleaseStand)) 5RESO/DUP>3REOP Not a duplicate; commented there. [16:12:21] (03CR) 10PleaseStand: "> @Legoktm: would that mean this patch can't be merged yet until support for 1.19 ends?" [core] - 10https://gerrit.wikimedia.org/r/173068 (owner: 10Southparkfan) [16:13:55] (03CR) 10Zfilipin: WIP: Use an actual registration to test GettingStarted returnto behavior. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/160193 (owner: 10Mattflaschen) [16:14:16] 3Wikimedia / 3Extension setup: Review and deploy BounceHandler extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/69019#c9 (10Greg Grossmeier) (In reply to Greg Grossmeier from comment #5) > Scheduled for Wed Nov 5th. How about we try this again... ;) Wed Nov 19th at 10am Pacific [16:20:05] (03CR) 10Umherirrender: Move request-only template profiling to an always-on parser report (031 comment) [core] - 10https://gerrit.wikimedia.org/r/172813 (owner: 10Aaron Schulz) [16:21:06] (03PS1) 10Phuedx: WIP Allow limiting morelike to pages with WikiGrok claims [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/173289 [16:24:43] (03CR) 10Anomie: Update and enrich API documentation (0323 comments) [core] - 10https://gerrit.wikimedia.org/r/169534 (owner: 10Siebrand) [16:26:31] (03PS2) 10Manybubbles: Fix pool counter usage [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/173279 [16:31:27] (03CR) 10Chad: [C: 032] Fix pool counter usage [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/173279 (owner: 10Manybubbles) [16:31:43] (03Merged) 10jenkins-bot: Fix pool counter usage [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/173279 (owner: 10Manybubbles) [16:33:13] disks for logstash - https://phabricator.wikimedia.org/T1225#22268 (10bd808) [16:33:18] (03PS1) 10Physikerwelt: Select rendering engine for batch update script [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/173292 [16:35:48] disks for logstash - https://phabricator.wikimedia.org/T1225#22269 (10bd808) Two 3T drives were added to each logstash host as a raid0 volume. We now have 5.5T per server exclusively for elasticsearch instead of 433G shared with the OS. \o/ See also https://rt.wikimedia.org/Ticket/Display.html?id=8805 [16:36:06] Performance review BounceHandler extension for Deployment - https://phabricator.wikimedia.org/T1227#22272 (10bd808) [16:36:10] disks for logstash - https://phabricator.wikimedia.org/T1225#22273 (10bd808) [16:36:12] Need a more reliable Beta Labs for QA - https://phabricator.wikimedia.org/T1222#22274 (10bd808) [16:36:14] Create team projects for all teams participating in scrum of scrums - https://phabricator.wikimedia.org/T1211#22275 (10bd808) [16:36:17] Opportunity to add a Phabricator tag "continuous integration" - https://phabricator.wikimedia.org/T952#22276 (10bd808) [16:36:20] [Zuul] Don't run the vendor tests unless composer.json is touched. - https://phabricator.wikimedia.org/T797#22277 (10bd808) [16:36:22] Reuse build test results when no code changes have happened - https://phabricator.wikimedia.org/T796#22278 (10bd808) [16:36:26] [Jenkins/Zuul] Make extension jobs run post mwcore merge - https://phabricator.wikimedia.org/T795#22279 (10bd808) [16:36:28] [Jenkins/Zuul] Make non-voting jobs run post-merge - https://phabricator.wikimedia.org/T794#22280 (10bd808) [16:36:30] create mailing list "betacluster-alerts" - https://phabricator.wikimedia.org/T790#22281 (10bd808) [16:36:52] disks for logstash - https://phabricator.wikimedia.org/T1225#21119 (10bd808) [16:40:53] (03PS1) 10Manybubbles: Fix pool counter usage [extensions/CirrusSearch] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173297 [16:41:03] (03PS1) 10Manybubbles: Fix pool counter usage [extensions/CirrusSearch] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/173298 [16:46:32] (03CR) 10Manybubbles: [C: 032] Fix pool counter usage [extensions/CirrusSearch] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/173298 (owner: 10Manybubbles) [16:46:34] (03CR) 10Manybubbles: [C: 032] Fix pool counter usage [extensions/CirrusSearch] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173297 (owner: 10Manybubbles) [16:46:50] (03Merged) 10jenkins-bot: Fix pool counter usage [extensions/CirrusSearch] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/173298 (owner: 10Manybubbles) [16:47:06] (03Merged) 10jenkins-bot: Fix pool counter usage [extensions/CirrusSearch] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173297 (owner: 10Manybubbles) [16:49:06] Krinkle: fwiw, I was able to run the CentralNotice cases under asyncTest--seems that nesting the creation of new tests does not work, however. [16:49:24] (03PS1) 10Manybubbles: SWAT update Cirrus [core] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173301 [16:51:20] (03PS1) 10CSteipp: Initial WMF extension commit [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/173303 [16:51:32] (03PS1) 10Manybubbles: SWAT update Cirrus [core] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/173304 [16:52:39] (03PS1) 10Martineznovo: Fix quotes in string literal of SQL query [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/173306 [16:57:47] Announce published health check data - https://phabricator.wikimedia.org/T1276#22284 (10Awjrichards) [17:03:57] (03PS1) 10Chad: Don't wait for completion. It can take a long time for big indexes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/173309 [17:18:15] 3Wikimedia / 3Site requests: Unblock IP ranges for Habib University - 10https://bugzilla.wikimedia.org/72893#c4 (10Matthew Bowker) 5NEW>3RESO/WON User is opting for the Account Creation userright. [17:19:46] (03CR) 10Krinkle: [C: 04-1] Add siteNotice div to the fallback skin [core] - 10https://gerrit.wikimedia.org/r/172870 (owner: 10Awight) [17:20:57] (03CR) 10Krinkle: [C: 04-1] "Needs more information for the limit to remain useful and justifiable. In that case is RL slower than 10 seconds? How did you run into thi" [core] - 10https://gerrit.wikimedia.org/r/173182 (owner: 10EBernhardson) [17:23:28] (03Abandoned) 10Awight: Add siteNotice div to the fallback skin [core] - 10https://gerrit.wikimedia.org/r/172870 (owner: 10Awight) [17:28:32] 3Wikimedia / 3General/Unknown: The Hebrew Wikipedia logo needs consistent naming - 10https://bugzilla.wikimedia.org/73424 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None For a short time in 2010 the Hebrew Wikipedia had a logo with a font that the community didn't like. That logo is currently st... [17:30:31] 3MediaWiki / 3API: The API list=recentchanges and prop=revisions should return the rev_sha1 field in the internal base-36 format rather than base-16 - 10https://bugzilla.wikimedia.org/73411#c3 (10Umherirrender) the file sha1 (in imageinfo or allimages) is also converted before outputting, when than should al... [17:56:02] (03PS1) 10Dbrant: Correctly display MathML fallback images. [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/173315 [17:56:16] Wiki Release Team November 2014 Goals - https://phabricator.wikimedia.org/T782#22290 (10Palexis) [17:56:17] Publish 1.24.0-RC.Final - https://phabricator.wikimedia.org/T1130#22293 (10Palexis) [17:56:18] Publish 1.24.0-RC.1 - https://phabricator.wikimedia.org/T1128#22289 (10Palexis) [17:56:19] Publish 1.24.0-RC.2 - https://phabricator.wikimedia.org/T1129#22291 (10Palexis) [17:56:20] Publish Major Release 1.24.0 - https://phabricator.wikimedia.org/T1131#22292 (10Palexis) [18:01:19] 3MediaWiki / 3Templates: Format to exclude element from desktop view - 10https://bugzilla.wikimedia.org/73427 (10Ian Tresman) 3NEW p:3Unprio s:3normal a:3None It would be nice to have a class/ID that ensures that elements are not diplayed on desktop views, and consequently are displayed on mobile vie... [18:08:28] (03PS1) 10Cicalese: i18n update: gender [extensions/PluggableAuth] - 10https://gerrit.wikimedia.org/r/173320 [18:10:45] 3MediaWiki / 3File management: PNG thumbnail get smudgy and streaky (near garbled) - 10https://bugzilla.wikimedia.org/69155#c4 (10PRO) Another example, there are some slightly visible vertical stripes. The image is indexed with only 6 colors. [[File:Wappen_Samtgemeinde_Bevensen-Ebstorf.png]] [18:13:46] 3MediaWiki extensions / 3CentralNotice: Visiting non existent banners shouldn't result in an exception - 10https://bugzilla.wikimedia.org/54180#c6 (10Glaisher) 5NEW>3ASSI a:3Glaisher I'll try to take a look. [18:16:52] (03CR) 10Aaron Schulz: Move request-only template profiling to an always-on parser report (031 comment) [core] - 10https://gerrit.wikimedia.org/r/172813 (owner: 10Aaron Schulz) [18:19:00] 3MediaWiki / 3API: Allow diff of deleted revisions with api - 10https://bugzilla.wikimedia.org/28047#c3 (10Umherirrender) FYI: gerrit 168646 adds a drvdiffto param to the new deletedrevisions module, but that seems not to work for deleted revisions, so this bug is not affected. [18:19:28] (03PS2) 10Matthias Mullie: Make $.findWithParent work with a set of comma-separated selectors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/172935 [18:19:32] (03PS6) 10Matthias Mullie: [WIP] EventLog Flow topic and post actions (FlowReplies) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171791 [18:19:35] (03PS1) 10Matthias Mullie: Expand/compress textareas via CSS instead of swapping nodes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/173324 [18:19:38] (03PS1) 10Matthias Mullie: Make it possible to add interactiveHandlers to elements on focus [extensions/Flow] - 10https://gerrit.wikimedia.org/r/173325 [18:19:41] (03PS1) 10EBernhardson: Performance improvements for autoload generator [core] - 10https://gerrit.wikimedia.org/r/173326 [18:20:20] (03CR) 10jenkins-bot: [V: 04-1] Make $.findWithParent work with a set of comma-separated selectors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/172935 (owner: 10Matthias Mullie) [18:20:33] (03CR) 10jenkins-bot: [V: 04-1] Expand/compress textareas via CSS instead of swapping nodes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/173324 (owner: 10Matthias Mullie) [18:20:39] (03CR) 10jenkins-bot: [V: 04-1] [WIP] EventLog Flow topic and post actions (FlowReplies) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171791 (owner: 10Matthias Mullie) [18:21:04] (03CR) 10jenkins-bot: [V: 04-1] Make it possible to add interactiveHandlers to elements on focus [extensions/Flow] - 10https://gerrit.wikimedia.org/r/173325 (owner: 10Matthias Mullie) [18:21:30] (03CR) 10Cicalese: [C: 032 V: 032] i18n update: gender [extensions/PluggableAuth] - 10https://gerrit.wikimedia.org/r/173320 (owner: 10Cicalese) [18:25:40] (03CR) 10SG: [C: 031] Make $.findWithParent work with a set of comma-separated selectors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/172935 (owner: 10Matthias Mullie) [18:27:00] 3MediaWiki / 3API: action=parse does not expand character references in section titles - 10https://bugzilla.wikimedia.org/21935#c2 (10Umherirrender) The line attribute of the sections is wikitext and you can see that the wikitext still contains the character reference, by also requesting the wikitext: https... [18:27:45] 3MediaWiki / 3File management: PNG thumbnail get smudgy and streaky (near garbled) - 10https://bugzilla.wikimedia.org/69155#c5 (10Bawolff (Brian Wolff)) (In reply to Brion Vibber from comment #2) > Problem with VPSscaler? Yes I think so. It looks similar to artifacts observed with tiffs when using vips shri... [18:31:00] (03CR) 10Chad: [C: 032] Performance improvements for autoload generator [core] - 10https://gerrit.wikimedia.org/r/173326 (owner: 10EBernhardson) [18:31:11] <^d> ebernhardson: merged ^ [18:32:45] (03PS9) 10SG: [WIP] J-2b & J-2d.IV Implement TOC on front-end [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171000 [18:32:48] (03PS4) 10SG: Clean up flow-menus to use section delimiters [extensions/Flow] - 10https://gerrit.wikimedia.org/r/172308 [18:33:44] (03CR) 10jenkins-bot: [V: 04-1] [WIP] J-2b & J-2d.IV Implement TOC on front-end [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171000 (owner: 10SG) [18:33:50] (03CR) 10jenkins-bot: [V: 04-1] Clean up flow-menus to use section delimiters [extensions/Flow] - 10https://gerrit.wikimedia.org/r/172308 (owner: 10SG) [18:36:45] (03Merged) 10jenkins-bot: Performance improvements for autoload generator [core] - 10https://gerrit.wikimedia.org/r/173326 (owner: 10EBernhardson) [18:40:57] (03PS1) 10Kaldari: Keep buttons from changing size when they change state [core] - 10https://gerrit.wikimedia.org/r/173329 (https://bugzilla.wikimedia.org/73381) [18:41:32] 3MediaWiki / 3API: need an easy way to see if a filename is in use via the API (including InstantCommons) - 10https://bugzilla.wikimedia.org/29640#c8 (10Umherirrender) Is this alreay fixed? With prop=imageinfo you get back a "imagerepository" property, which contains the name of the repo or an empty string.... [18:44:31] (03CR) 10BearND: [C: 04-1] Correctly display MathML fallback images. (031 comment) [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/173315 (owner: 10Dbrant) [18:45:34] bearND: good eye [18:46:24] (03PS2) 10Dbrant: Correctly display MathML fallback images. [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/173315 [18:49:00] 3MediaWiki / 3File management: PNG thumbnail get smudgy and streaky (near garbled) - 10https://bugzilla.wikimedia.org/69155#c6 (10PRO) (In reply to Bawolff (Brian Wolff) from comment #5) > (In reply to Brion Vibber from comment #2) > > ... Based on comment 4, maybe only observable on indexed pngs? Yes I th... [18:54:01] (03PS2) 10Legoktm: Add scripts to cleanup LocalPageMoveJob breakage [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/173088 (https://bugzilla.wikimedia.org/72927) [18:54:17] (03Abandoned) 10Legoktm: Add scripts to cleanup LocalPageMoveJob breakage [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/173088 (https://bugzilla.wikimedia.org/72927) (owner: 10Legoktm) [18:55:01] 3Wikimedia / 3General/Unknown: Write a maint. script to queue failed page moves due to LocalPageMoveJob breakage - 10https://bugzilla.wikimedia.org/72927#c6 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX Written, and run on the cluster. [18:55:18] [Bug 72927] Write a maint. script to queue failed page moves due to LocalPageMoveJob breakage - https://phabricator.wikimedia.org/T1055#22299 (10Legoktm) [19:02:02] (03PS1) 10EBernhardson: Doc: Mention the php command in autoload.php to regenerate it [core] - 10https://gerrit.wikimedia.org/r/173330 [19:04:04] (03CR) 10EBernhardson: Generate $wgAutoloadLocalClasses with a maint script (031 comment) [core] - 10https://gerrit.wikimedia.org/r/163304 (owner: 10EBernhardson) [19:15:09] (03PS3) 10BryanDavis: Avoid sending spammy @X xhprof entries over UDP [core] - 10https://gerrit.wikimedia.org/r/173099 (owner: 10Aaron Schulz) [19:15:14] (03CR) 10BryanDavis: [C: 032] Avoid sending spammy @X xhprof entries over UDP [core] - 10https://gerrit.wikimedia.org/r/173099 (owner: 10Aaron Schulz) [19:20:00] 3Wikimedia / 3DNS: Redirect mul.wikisource.org to wikisource.org - 10https://bugzilla.wikimedia.org/73407#c5 (10Daniel Zahn) I merged the DNS change. Now: mul.wikisource.org has address 198.35.26.96 mul.wikisource.org has IPv6 address 2620:0:863:ed1a::1 http://mul.wikisource.org/ https://mul.wikisource.or... [19:20:54] (03Merged) 10jenkins-bot: Avoid sending spammy @X xhprof entries over UDP [core] - 10https://gerrit.wikimedia.org/r/173099 (owner: 10Aaron Schulz) [19:37:40] Fix non-CentralAuth https preference handling - https://phabricator.wikimedia.org/T1279#22305 (10csteipp) [19:40:30] Fix non-CentralAuth https preference handling - https://phabricator.wikimedia.org/T1279#22313 (10csteipp) p:5Triage>3Normal [19:40:42] Fix non-CentralAuth https preference handling - https://phabricator.wikimedia.org/T1279#22305 (10csteipp) [19:40:51] km-mpb:mediawiki km$ /usr/bin/php maintenance/generateLocalAutoload.php [19:40:51] Fatal error: Class 'MWException' not found in /Users/km/projects/mediawiki/vagrant/mediawiki/includes/utils/AutoloadGenerator.php on line 86 [19:40:53] ouch. [19:41:36] ebernhardson: ^ I guess it can't throw MWExceptions? [19:43:57] PHP Fatal error: Uncaught exception 'Exception' with message 'Path is not within basepath: /vagrant/mediawiki/LocalSettings.php' in /vagrant/mediawiki/includes/utils/AutoloadGenerator.php:90 [19:45:17] 3Wikimedia / 3DNS: Redirect mul.wikisource.org to wikisource.org - 10https://bugzilla.wikimedia.org/73407#c6 (10Justin Anthony Knapp) Works for me! [19:45:46] 3Logstash: Setup udp2log on logstash-mw for testing - https://phabricator.wikimedia.org/T1280 (10bd808) 3NEW p:3Low a:3bd808 [19:46:51] (03PS4) 10Legoktm: Use cdb library and provide a back-compat layer [core] - 10https://gerrit.wikimedia.org/r/172779 [19:48:21] (03PS1) 10Legoktm: AutoloadGenerator: Don't throw MWExceptions [core] - 10https://gerrit.wikimedia.org/r/173342 [19:48:28] ebernhardson: ^ [19:48:39] legoktm: ouch, i guess not. I didn't pull in the entirety of mediawiki. thanks [19:49:09] do you know why it doesn't like my LocalSettings.php file? [19:49:23] legoktm: i bet its a symlink outside the repo? [19:49:29] it is [19:49:35] legoktm: perhaps instead of bailing when something is outside the repo, we should just report but not fail? [19:49:57] sounds good to me [19:51:35] [13cssjanus] 15mattflaschen opened pull request #30: Release v1.1.1 (06master...06releasev1.1.1) 02https://github.com/cssjanus/cssjanus/pull/30 [19:51:39] (03CR) 10EBernhardson: [C: 032] AutoloadGenerator: Don't throw MWExceptions [core] - 10https://gerrit.wikimedia.org/r/173342 (owner: 10Legoktm) [19:52:23] (03PS7) 10Matthias Mullie: [WIP] EventLog Flow topic and post actions (FlowReplies) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171791 [19:52:46] 3MediaWiki / 3Templates: Format to exclude element from desktop view - 10https://bugzilla.wikimedia.org/73427#c1 (10Andre Klapper) s:5normal>3enhanc Thanks for taking the time to report this! What would be the usecase of this? Any examples? [19:52:47] 3Wikimedia / 3Site requests: install Extension:Translate on cawikimedia - 10https://bugzilla.wikimedia.org/73394#c4 (10Daniel Zahn) Thank you Dereckson for taking this. I mailed Benoit via the original RT ticket and pointed him to the Gerrit change and over here as well. Suggested we continue here and progre... [19:53:10] (03CR) 10jenkins-bot: [V: 04-1] [WIP] EventLog Flow topic and post actions (FlowReplies) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171791 (owner: 10Matthias Mullie) [19:53:42] Krinkle|detached, trivial change to release v1.1.1. That will allow updating the test in php-cssjanus once it is tagged in the node.js version: https://github.com/cssjanus/cssjanus/pull/30 [19:53:49] Please let me know what I can do to move that forward. [19:54:32] Once the commit is finalized, it can be tagged as part of the release. [19:57:23] (03Merged) 10jenkins-bot: AutoloadGenerator: Don't throw MWExceptions [core] - 10https://gerrit.wikimedia.org/r/173342 (owner: 10Legoktm) [20:00:07] 3MediaWiki extensions / 3SemanticForms: XSS via 'form_name' parameter on Semantic Forms's Special:CreateForm page - 10https://bugzilla.wikimedia.org/38150 (10Chris Steipp) [20:00:58] Document user migration process - https://phabricator.wikimedia.org/T1156#22328 (10greg) [20:01:18] 3MediaWiki extensions / 3CirrusSearch: RegEx-style Cirrus searches are ignored on en.wikipedia - 10https://bugzilla.wikimedia.org/72894#c15 (10Nik Everett) OK! I found the problem. Our pool counter work differently then how I thought it did. I've prepared a patch to deploy and we'll sync it out during the... [20:06:00] 3MediaWiki / 3ResourceLoader: CSSJanus fails to flip with !important - 10https://bugzilla.wikimedia.org/61440#c9 (10Matthew Flaschen) Step 1 is done. It's fixed in the CSSJanus upstream node.js repository. However, I realized we also need to do a node.js release and tag, since the PHP version imports the t... [20:08:34] Need review of CSSJanus "support for four-value rules" - https://phabricator.wikimedia.org/T1220#22329 (10Mattflaschen) See https://bugzilla.wikimedia.org/show_bug.cgi?id=61440#c9 for an update. The initial commit is merged, but there are two pull requests that still need to be merged. [20:13:42] (03PS1) 10Chad: Refactor profiling output from profiling [core] - 10https://gerrit.wikimedia.org/r/173348 [20:21:39] (03CR) 10BryanDavis: [C: 031] "The diff could be made smaller by adding "as" phrases to the use statements (eg `use Cdb\Reader as CdbReader;`). Not sure that it matters " [core] - 10https://gerrit.wikimedia.org/r/172779 (owner: 10Legoktm) [20:30:51] (03PS1) 10Gerrit Patch Uploader: mediawiki.special.changeslist.legend: Avoid legend as stairs [core] - 10https://gerrit.wikimedia.org/r/173354 [20:30:53] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/173354 (owner: 10Gerrit Patch Uploader) [20:36:05] (03CR) 10BearND: [C: 032] Correctly display MathML fallback images. [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/173315 (owner: 10Dbrant) [20:36:30] (03Merged) 10jenkins-bot: Correctly display MathML fallback images. [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/173315 (owner: 10Dbrant) [20:36:56] (03CR) 10Merl: [C: 031] mediawiki.special.changeslist.legend: Avoid legend as stairs [core] - 10https://gerrit.wikimedia.org/r/173354 (owner: 10Gerrit Patch Uploader) [20:38:00] (03CR) 10BryanDavis: "Looks like a good start. I could see extending the output param to allow outputting to say both udp and the page at the same time." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/173348 (owner: 10Chad) [20:47:38] (03PS5) 10Legoktm: Use cdb library and provide a back-compat layer [core] - 10https://gerrit.wikimedia.org/r/172779 [20:49:10] Find new Tech Talks and get them scheduled for Dec, Jan & Feb. - https://phabricator.wikimedia.org/T1046#22334 (10Rfarrand) Emailed @tfinc, @TrevorParscal, Carolynne, @Maryana & Frances to check on possible tech talks. [20:49:15] (03CR) 10Legoktm: "PS5: Used "as" for Writer and Reader" [core] - 10https://gerrit.wikimedia.org/r/172779 (owner: 10Legoktm) [20:49:30] 3MediaWiki / 3Templates: Format to exclude element from desktop view - 10https://bugzilla.wikimedia.org/73427#c2 (10Ian Tresman) Because my mobile is a different size and shape to my desktop, I want to put images on certain pages at different sizes for mobiles and desktops. eg.
[[file:... [20:51:09] hmpf ever-changing bot names [20:51:38] TechTalk: MediaWiki-Vagrant - https://phabricator.wikimedia.org/T1045#22336 (10Rfarrand) publicized on Nov. 13 [20:58:28] (03CR) 10Jjanes: [C: 031] "This gets rid of the Error. There is still a Failure associated with naming the site 'Foo'," [core] - 10https://gerrit.wikimedia.org/r/173060 (https://bugzilla.wikimedia.org/65879) (owner: 10Umherirrender) [20:58:40] (03CR) 10Manybubbles: [C: 04-1] "Ah! I see what you are looking for. Hmmm - if we can detect it we can certainly add it to the index. If you can point me to a page with" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/173289 (owner: 10Phuedx) [21:04:21] (03PS8) 10Bartosz Dziewoński: DiscussionParser: More tests for custom and localised namespaces [extensions/Echo] - 10https://gerrit.wikimedia.org/r/163844 [21:04:58] (03CR) 10jenkins-bot: [V: 04-1] DiscussionParser: More tests for custom and localised namespaces [extensions/Echo] - 10https://gerrit.wikimedia.org/r/163844 (owner: 10Bartosz Dziewoński) [21:05:23] (03CR) 10BryanDavis: [C: 031] "LGTM. I can +2 if nobody has an objection." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/172779 (owner: 10Legoktm) [21:05:58] (03PS2) 10Matthias Mullie: Expand/compress textareas via CSS instead of swapping nodes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/173324 [21:06:13] (03PS2) 10Matthias Mullie: Make it possible to add interactiveHandlers to elements on focus [extensions/Flow] - 10https://gerrit.wikimedia.org/r/173325 [21:06:21] (03PS8) 10Matthias Mullie: [WIP] EventLog Flow topic and post actions (FlowReplies) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171791 [21:06:45] (03CR) 10jenkins-bot: [V: 04-1] Expand/compress textareas via CSS instead of swapping nodes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/173324 (owner: 10Matthias Mullie) [21:07:09] (03CR) 10jenkins-bot: [V: 04-1] Make it possible to add interactiveHandlers to elements on focus [extensions/Flow] - 10https://gerrit.wikimedia.org/r/173325 (owner: 10Matthias Mullie) [21:07:14] (03CR) 10jenkins-bot: [V: 04-1] [WIP] EventLog Flow topic and post actions (FlowReplies) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171791 (owner: 10Matthias Mullie) [21:07:31] (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.special.changeslist.legend: Avoid legend as stairs [core] - 10https://gerrit.wikimedia.org/r/173354 (owner: 10Gerrit Patch Uploader) [21:09:05] (03CR) 10Bartosz Dziewoński: [C: 031] Delete skins/common/{ajax.js, wikibits.js, images/{magnify-clip-rtl.png, redirectltr.png, redirectrtl.png}} [core] - 10https://gerrit.wikimedia.org/r/172256 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [21:13:01] (03Merged) 10jenkins-bot: mediawiki.special.changeslist.legend: Avoid legend as stairs [core] - 10https://gerrit.wikimedia.org/r/173354 (owner: 10Gerrit Patch Uploader) [21:17:33] Announce published health check data - https://phabricator.wikimedia.org/T1276#22339 (10KLans_WMF) [21:17:49] First draft of blog post for Q2 - https://phabricator.wikimedia.org/T1213#22340 (10KLans_WMF) [21:25:24] Clean up @ profile entry handling in xhprof - https://phabricator.wikimedia.org/T1274#22343 (10aaron) [21:27:57] (03PS1) 10Bartosz Dziewoński: Delete skins/common/images/magnify-clip.png [core] - 10https://gerrit.wikimedia.org/r/173417 (https://bugzilla.wikimedia.org/69277) [21:34:23] (03PS2) 10Chad: Refactor profiling output from profiling [core] - 10https://gerrit.wikimedia.org/r/173348 [21:34:31] test Wed, 03 Sep 2014 21:27:40 +0000 - https://phabricator.wikimedia.org/T1262#22346 (10chasemp) **Wiki.Melancholie** wrote: New Favicon for Wiktionaries Favicon.ico, per [[wikt:de:Wiktionary:Teestube#Vorschau]]. Should be also used by OpenSearch description, not just meta tag itself. **Attached**: {F5949} [21:34:56] (03CR) 10jenkins-bot: [V: 04-1] Refactor profiling output from profiling [core] - 10https://gerrit.wikimedia.org/r/173348 (owner: 10Chad) [21:35:00] (03CR) 10Chad: Refactor profiling output from profiling (033 comments) [core] - 10https://gerrit.wikimedia.org/r/173348 (owner: 10Chad) [21:35:23] (03PS1) 10Legoktm: Bring in elastica library via composer [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/173429 [21:35:41] (03PS3) 10Chad: Refactor profiling output from profiling [core] - 10https://gerrit.wikimedia.org/r/173348 [21:35:47] 3MediaWiki / 3Database: Postgres Error - 10https://bugzilla.wikimedia.org/73434 (10thomas) 3UNCO p:3Unprio s:3normal a:3None during installation I encounter an error in the postgres /maintenance/update-keys.sql file. Postgres does not use the syntax INSERT IGNORE INTO ... I am on CentOS 7, postgres... [21:35:53] (03PS5) 10Paladox: Migrate to JSON i18n [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/172645 [21:36:43] (03PS7) 10Paladox: Fix tracking for version [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/172581 [21:36:59] (03PS15) 10Paladox: Adding message documentation [extensions/MaintenanceShell] - 10https://gerrit.wikimedia.org/r/170902 [21:37:11] All WMF Engineers should be registered for the MediaWiki Developers Summit 2015 - https://phabricator.wikimedia.org/T566#22347 (10Rfarrand) Just emailed 22 staff/contractors with reqs (or their managers) who have not registered (including a few new hires) [21:37:20] (03PS47) 10Paladox: WikiEditor: Fix issue with SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) [21:37:22] (03CR) 10BryanDavis: [C: 04-1] "Needs elastica in mediawiki/vendor" [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/173429 (owner: 10Legoktm) [21:37:56] (03CR) 10Spage: [C: 032] "Big code addition shouldn't make regular Flow explode..." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [21:38:52] (03CR) 10jenkins-bot: [V: 04-1] Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [21:39:09] (03CR) 10Paladox: "@Siebrand" [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/166986 (owner: 10Luis Felipe Schenone) [21:39:17] (03PS18) 10Paladox: Update jquery.ui Vector theme to 1.9.2 [skins/Vector] - 10https://gerrit.wikimedia.org/r/154024 [21:39:24] (03CR) 10Paladox: Update jquery.ui Vector theme to 1.9.2 [skins/Vector] - 10https://gerrit.wikimedia.org/r/154024 (owner: 10Paladox) [21:40:02] (03PS17) 10Paladox: TwitterLogin: Update auth link [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/151640 [21:40:21] (03PS1) 10Legoktm: Add ruflin/elastica 1.3.0.0 for Elastica extension [vendor] - 10https://gerrit.wikimedia.org/r/173430 [21:40:40] (03CR) 10SG: [C: 04-1] "Maybe call it flow-focus-handler?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/173325 (owner: 10Matthias Mullie) [21:40:45] (03PS1) 10Cscott: Consistently handle trailing slashes in subpage links. [core] - 10https://gerrit.wikimedia.org/r/173431 [21:41:08] (03PS2) 10Legoktm: Bring in elastica library via composer [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/173429 [21:41:22] (03CR) 10Legoktm: "Ie5a3560ddd756f45b90ea02a2eedf7f828aebda0 is the vendor change" [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/173429 (owner: 10Legoktm) [21:42:14] (03CR) 10Paladox: "or @Raimond Spekking" [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/166986 (owner: 10Luis Felipe Schenone) [21:42:42] (03CR) 10EBernhardson: [C: 032] "re-apply spage +2" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [21:43:24] (03CR) 10jenkins-bot: [V: 04-1] Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [21:46:30] (03CR) 10jenkins-bot: [V: 04-1] Consistently handle trailing slashes in subpage links. [core] - 10https://gerrit.wikimedia.org/r/173431 (owner: 10Cscott) [21:48:42] (03PS9) 10Matthias Mullie: EventLog Flow topic and post actions (FlowReplies) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171791 [21:49:13] (03CR) 10Legoktm: "I verified that this brings in the same exact code by running:" [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/173429 (owner: 10Legoktm) [21:49:29] (03CR) 10jenkins-bot: [V: 04-1] EventLog Flow topic and post actions (FlowReplies) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171791 (owner: 10Matthias Mullie) [21:50:05] 3Librarization: Bring in elastica library through composer - https://phabricator.wikimedia.org/T1281 (10Legoktm) 3NEW p:3Normal a:3Legoktm [21:50:44] 3Librarization: Bring in elastica library through composer - https://phabricator.wikimedia.org/T1281#22350 (10Legoktm) [21:51:04] (03CR) 10EBernhardson: "Links to intermittent failures in jenkins that appear to be due to timeouts. They seem to happen more during SF work day when jenkins is " [core] - 10https://gerrit.wikimedia.org/r/173182 (owner: 10EBernhardson) [21:53:19] Fix non-CentralAuth https preference handling - https://phabricator.wikimedia.org/T1279#22360 (10csteipp) And bug 70145 [21:56:31] 3Wikimedia / 3General/Unknown: Track down popular gadgets that refer to files in skins/common/ and fix them not to - 10https://bugzilla.wikimedia.org/69678#c12 (10Bartosz Dziewoński) 5NEW>3RESO/FIX Replaced bullet.gif on a couple dozen wikis today. There are still a few matches, but it seems like they ar... [21:57:12] (03PS1) 10Bartosz Dziewoński: Delete skins/common/images/bullet.gif [core] - 10https://gerrit.wikimedia.org/r/173434 (https://bugzilla.wikimedia.org/69277) [21:57:30] (03PS2) 10Cscott: Consistently handle trailing slashes in subpage links. [core] - 10https://gerrit.wikimedia.org/r/173431 [21:57:52] (03PS2) 10Bartosz Dziewoński: Delete skins/common/images/bullet.gif [core] - 10https://gerrit.wikimedia.org/r/173434 (https://bugzilla.wikimedia.org/69277) [21:59:41] Publish names of attendees and topics they are interested in discussing for MediaWiki Developers Summit - https://phabricator.wikimedia.org/T1219#22369 (10Rfarrand) https://www.mediawiki.org/wiki/MediaWiki_Developer_Summit_2015/Attendees [21:59:46] (03PS3) 10Cscott: Consistently handle trailing slashes in subpage links. [core] - 10https://gerrit.wikimedia.org/r/173431 [21:59:57] Publish names of attendees and topics they are interested in discussing for MediaWiki Developers Summit - https://phabricator.wikimedia.org/T1219#22370 (10Rfarrand) 5Open>3Resolved [22:03:08] (03CR) 10SG: [C: 04-1] "Don't use !important and don't use pixel height." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/173324 (owner: 10Matthias Mullie) [22:04:42] (03CR) 10Manybubbles: "Looks good to me. Do I just test by pulling in this version of the library and running composer?" [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/173429 (owner: 10Legoktm) [22:05:11] (03CR) 10jenkins-bot: [V: 04-1] Consistently handle trailing slashes in subpage links. [core] - 10https://gerrit.wikimedia.org/r/173431 (owner: 10Cscott) [22:05:13] (03CR) 10Matthias Mullie: "The !important is because the auto-expanding thingy sets a height & minheight on it and we need to make sure we overwrite that when compre" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/173324 (owner: 10Matthias Mullie) [22:05:16] (03CR) 10Krinkle: [C: 032] Delete skins/common/{ajax.js, wikibits.js, images/{magnify-clip-rtl.png, redirectltr.png, redirectrtl.png}} [core] - 10https://gerrit.wikimedia.org/r/172256 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [22:05:18] (03CR) 10Legoktm: "Yup!" [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/173429 (owner: 10Legoktm) [22:09:11] (03PS4) 10Cscott: Consistently handle trailing slashes in subpage links. [core] - 10https://gerrit.wikimedia.org/r/173431 [22:10:04] (03PS10) 10SG: [WIP] J-2b & J-2d.IV Implement TOC on front-end [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171000 [22:10:07] (03PS5) 10SG: Clean up flow-menus to use section delimiters [extensions/Flow] - 10https://gerrit.wikimedia.org/r/172308 [22:10:23] (03CR) 10Hashar: "I have retriggered the doxygen job to publish REL1_24 documentation at https://doc.wikimedia.org/mediawiki-core/REL1_24/php/html/" [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/172045 (owner: 10MarkAHershberger) [22:10:49] (03CR) 10jenkins-bot: [V: 04-1] [WIP] J-2b & J-2d.IV Implement TOC on front-end [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171000 (owner: 10SG) [22:10:52] (03PS1) 10Dbrant: Remove webkit color inversion for Math images. [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/173436 [22:11:01] (03Merged) 10jenkins-bot: Delete skins/common/{ajax.js, wikibits.js, images/{magnify-clip-rtl.png, redirectltr.png, redirectrtl.png}} [core] - 10https://gerrit.wikimedia.org/r/172256 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [22:11:10] (03CR) 10jenkins-bot: [V: 04-1] Clean up flow-menus to use section delimiters [extensions/Flow] - 10https://gerrit.wikimedia.org/r/172308 (owner: 10SG) [22:11:51] 3MediaWiki / 3Patrolling: Rollback shouldn't patrol without log entry - 10https://bugzilla.wikimedia.org/40624#c4 (10Robert Morley) (In reply to Nemo from comment #3) > (In reply to Dalba from comment #2) > > Do you know a better way to do this? > > Patrolled edits are RC properties, ask the RC: [[mw:API:Re... [22:15:18] (03PS11) 10SG: [WIP] J-2b & J-2d.IV Implement TOC on front-end [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171000 [22:15:21] (03PS6) 10SG: Clean up flow-menus to use section delimiters [extensions/Flow] - 10https://gerrit.wikimedia.org/r/172308 [22:16:06] (03CR) 10jenkins-bot: [V: 04-1] [WIP] J-2b & J-2d.IV Implement TOC on front-end [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171000 (owner: 10SG) [22:16:17] (03CR) 10jenkins-bot: [V: 04-1] Clean up flow-menus to use section delimiters [extensions/Flow] - 10https://gerrit.wikimedia.org/r/172308 (owner: 10SG) [22:17:00] (03CR) 10Legoktm: [C: 032] Delete skins/common/images/magnify-clip.png [core] - 10https://gerrit.wikimedia.org/r/173417 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [22:17:05] (03CR) 10Legoktm: [C: 032] Delete skins/common/images/bullet.gif [core] - 10https://gerrit.wikimedia.org/r/173434 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [22:18:28] (03CR) 10Hashar: "Retriggered to generate the doxygen documentation at https://doc.wikimedia.org/mediawiki-core/REL1_23/php/html/" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/169752 (owner: 10MarkAHershberger) [22:19:04] (03CR) 10Hashar: "Retriggered to generate the doxygen documentation at https://doc.wikimedia.org/mediawiki-core/REL1_22/php/html/" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/169754 (owner: 10MarkAHershberger) [22:22:53] (03Merged) 10jenkins-bot: Delete skins/common/images/magnify-clip.png [core] - 10https://gerrit.wikimedia.org/r/173417 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [22:23:02] (03Merged) 10jenkins-bot: Delete skins/common/images/bullet.gif [core] - 10https://gerrit.wikimedia.org/r/173434 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [22:24:36] 3MediaWiki / 3Interface: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277#c101 (10James Forrester) 5PATC>3RESO/FIX Done. Gosh. [22:24:51] 3Wikimedia / 3Site requests: Enable VisualEditor by default for all users on the Tagalog Wikipedia (currently a Beta Feature there) - 10https://bugzilla.wikimedia.org/73365#c4 (10Roan Kattouw) (In reply to Roan Kattouw from comment #3) > Once the schedule for next week is put on the wiki page, I'll schedule... [22:26:53] 3MediaWiki / 3Configuration: Sidebar upload image link to commons - 10https://bugzilla.wikimedia.org/73439 (10Andyrom75) 3NEW p:3Unprio s:3normal a:3None Please set $wgUploadNavigationUrl = '//commons.wikimedia.org/wiki/Special:UploadWizard'; in order to eliminate the following code: $(function(){... [22:27:21] 3MediaWiki / 3Configuration: Sidebar upload image link to commons - 10https://bugzilla.wikimedia.org/73439 (10Andyrom75) [22:32:06] 3MediaWiki / 3Interface: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277#c102 (10Bartosz Dziewoński) And the directory is gone from master too! At last! Thank you, everyone who helped wit this boring cleanup work :D (MW 1.24 wil... [22:32:53] (03PS6) 10Bartosz Dziewoński: mediawiki.skinning: Provide SVG version of the "magnify clip" icon [core] - 10https://gerrit.wikimedia.org/r/172214 (https://bugzilla.wikimedia.org/69705) (owner: 10Jforrester) [22:37:20] 3Librarization: Bring in Flow's dependencies via composer - https://phabricator.wikimedia.org/T1283 (10Legoktm) 3NEW p:3Triage [22:37:56] (03CR) 10Hashar: "I needed a test change to verify the doc publishing system works properly :-)" [tools/releng] - 10https://gerrit.wikimedia.org/r/116750 (owner: 10Greg Grossmeier) [22:40:28] Core dumps fill up /var on labs instances - https://phabricator.wikimedia.org/T1259#22386 (10yuvipanda) [22:42:42] Core dumps fill up /var on labs instances - https://phabricator.wikimedia.org/T1259#22387 (10ori) >>! In T1259#21753, @chasemp wrote: > ...I meant disabling core dumps for labs vm's by default. Sounds right to me. [22:45:58] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Looks good from the technical side, but the SVG image displays incorrectly for me. http://i.imgur.com/Ca5RaKm.png It has a 'viewBox' defin" [core] - 10https://gerrit.wikimedia.org/r/172214 (https://bugzilla.wikimedia.org/69705) (owner: 10Jforrester) [22:48:12] (03CR) 10Bartosz Dziewoński: "Ori, do you think the check should be added anyway? Can you propose a way to clean up responsibilities?" [core] - 10https://gerrit.wikimedia.org/r/171880 (owner: 10Bartosz Dziewoński) [22:48:22] (03PS2) 10Bartosz Dziewoński: CSSMin: Rewrite encodeImageAsDataURI() [core] - 10https://gerrit.wikimedia.org/r/171880 [22:51:51] (03CR) 10Bartosz Dziewoński: ResourceLoader: Stop passing around errors as /**/-comments (031 comment) [core] - 10https://gerrit.wikimedia.org/r/172591 (owner: 10Bartosz Dziewoński) [22:54:07] MatmaRex: with filesize() you don't need to read the file to get its size [22:54:17] MatmaRex: and then you can decide if it exceeds the limit or not [22:54:18] (03CR) 10BearND: [C: 032] Remove webkit color inversion for Math images. [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/173436 (owner: 10Dbrant) [22:54:22] 3MediaWiki extensions / 3SemanticForms: "Add another" feature for multiple-instance templates broken with MW >= 1.24 - 10https://bugzilla.wikimedia.org/72900#c17 (10Joel K. Pettersson) 5UNCO>3RESO/INV Quite unexpectedly, it can now be considered resolved. There's two copies of the wiki. Only the local c... [22:54:31] ori: it already uses filesize() as the first check, no? [22:54:44] yes, but in an imprecise way [22:54:57] (03Merged) 10jenkins-bot: Remove webkit color inversion for Math images. [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/173436 (owner: 10Dbrant) [22:54:57] it must be that way, i don't know if i'm going to base64-encode it until i read it [22:55:13] ohhh, I see what you're saying [22:55:17] unless we're willing to accept that we'll overshoot sometimes [22:56:01] MatmaRex: let me spend a minute looking at it again [22:56:23] Find new Tech Talks and get them scheduled for Dec, Jan & Feb. - https://phabricator.wikimedia.org/T1046#22396 (10Tfinc) @Maryana, how about doing one on WikiGrok? @Deskana, how about doing a dry run of what we plan on for the dev summit? [22:56:47] (03PS7) 10Jforrester: mediawiki.skinning: Provide SVG version of the "magnify clip" icon [core] - 10https://gerrit.wikimedia.org/r/172214 (https://bugzilla.wikimedia.org/69705) [22:57:36] (03CR) 10Jforrester: "Whoops, yes, we decided against width=100% before, and these should have been mastered off 17x15 (!) instead of the usual 24x24. Redone." [core] - 10https://gerrit.wikimedia.org/r/172214 (https://bugzilla.wikimedia.org/69705) (owner: 10Jforrester) [22:58:28] (03PS16) 10Bartosz Dziewoński: [WIP] ResourceLoaderImageModule for icons [core] - 10https://gerrit.wikimedia.org/r/165922 (owner: 10Trevor Parscal) [22:58:50] (03CR) 10Bartosz Dziewoński: "PS16: Only rebased." [core] - 10https://gerrit.wikimedia.org/r/165922 (owner: 10Trevor Parscal) [22:59:10] (03PS2) 10Bartosz Dziewoński: ResourceLoader: Stop passing around errors as /**/-comments [core] - 10https://gerrit.wikimedia.org/r/172591 [22:59:42] (03PS3) 10Legoktm: Bring in elastica library via composer [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/173429 [23:00:39] (03CR) 10Legoktm: "PS3: composer validate didn't like the lack of a description, so I added one." [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/173429 (owner: 10Legoktm) [23:03:16] James_F: why 17x15? [23:03:41] MatmaRex: Wasn't that what the original was? [23:03:51] isn't it 15x11? [23:04:46] * James_F is lost. [23:04:51] One moment. [23:08:04] (03PS1) 10Legoktm: Fix inconsistent spacing in composer.json [extensions/cldr] - 10https://gerrit.wikimedia.org/r/173448 [23:10:43] (03PS2) 10Legoktm: Fix inconsistent spacing in composer.json [extensions/cldr] - 10https://gerrit.wikimedia.org/r/173448 [23:11:07] (03PS8) 10Jforrester: mediawiki.skinning: Provide SVG version of the "magnify clip" icon [core] - 10https://gerrit.wikimedia.org/r/172214 (https://bugzilla.wikimedia.org/69705) [23:11:24] MatmaRex: Done, but… it's a horrible size. Oh well. [23:11:40] (03CR) 10BryanDavis: [C: 032] Add ruflin/elastica 1.3.0.0 for Elastica extension [vendor] - 10https://gerrit.wikimedia.org/r/173430 (owner: 10Legoktm) [23:15:26] (03CR) 10BryanDavis: "One small grammar error in README." (031 comment) [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/173429 (owner: 10Legoktm) [23:16:38] (03PS4) 10Legoktm: Bring in elastica library via composer [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/173429 [23:16:46] (03CR) 10Legoktm: Bring in elastica library via composer (031 comment) [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/173429 (owner: 10Legoktm) [23:16:56] (03Merged) 10jenkins-bot: Add ruflin/elastica 1.3.0.0 for Elastica extension [vendor] - 10https://gerrit.wikimedia.org/r/173430 (owner: 10Legoktm) [23:18:17] (03PS1) 10Ragesoss: Add assigned articles per student to API output [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/173452 [23:18:22] (03CR) 10jenkins-bot: [V: 04-1] Add assigned articles per student to API output [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/173452 (owner: 10Ragesoss) [23:18:39] (03PS1) 10PleaseStand: generateLocalAutoload.php: Abort for web requests [core] - 10https://gerrit.wikimedia.org/r/173453 [23:22:59] (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.skinning: Provide SVG version of the "magnify clip" icon [core] - 10https://gerrit.wikimedia.org/r/172214 (https://bugzilla.wikimedia.org/69705) (owner: 10Jforrester) [23:23:42] James_F: it could probably be resized without too much fuss, if you think it's worth the effort. the dimensions are only hardcoded in CSS in a few places. [23:24:07] MatmaRex: Eh. I don't care enough. It's meant to be removed from Vector by UX anyway… [23:24:10] 3MediaWiki / 3Interface: "Enlarge" icon (magnify-clip.png) missing a SVG version - 10https://bugzilla.wikimedia.org/69705 (10James Forrester) 5PATC>3RESO/FIX [23:24:48] (03PS1) 10EBernhardson: Bug: Fails signature detection with extra long signature [extensions/Echo] - 10https://gerrit.wikimedia.org/r/173455 (https://bugzilla.wikimedia.org/73426) [23:28:21] 3MediaWiki / 3Database: Postgres Error - 10https://bugzilla.wikimedia.org/73434#c1 (10Andre Klapper) 5UNCO>3RESO/DUP Hi thomas. Thanks for taking the time to report this! This particular problem has already been reported into our bug tracking system, but please feel free to report any further issues you... [23:28:22] 3MediaWiki / 3Database: PostgreSQL install fails on INSERT IGNORE INTO "mediawiki"."updatelog" in update_keys.sql - 10https://bugzilla.wikimedia.org/72834#c7 (10Andre Klapper) *** Bug 73434 has been marked as a duplicate of this bug. *** [23:28:33] (03Merged) 10jenkins-bot: mediawiki.skinning: Provide SVG version of the "magnify clip" icon [core] - 10https://gerrit.wikimedia.org/r/172214 (https://bugzilla.wikimedia.org/69705) (owner: 10Jforrester) [23:28:37] (03CR) 10EBernhardson: [C: 032] "re-apply spage +2" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [23:28:40] (03PS2) 10Ragesoss: Add assigned articles per student to API output [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/173452 [23:29:31] (03CR) 10jenkins-bot: [V: 04-1] Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [23:30:52] (03CR) 10EBernhardson: [C: 032] Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [23:31:34] (03CR) 10jenkins-bot: [V: 04-1] Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [23:31:50] 3MediaWiki / 3Configuration: Sidebar upload image link to commons - 10https://bugzilla.wikimedia.org/73439#c1 (10Andre Klapper) (In reply to Andyrom75 from comment #0) > Please set $wgUploadNavigationUrl = > '//commons.wikimedia.org/wiki/Special:UploadWizard'; Where and for what? In the MediaWiki codebase?... [23:31:52] (03CR) 10EBernhardson: [C: 032] Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [23:32:35] (03CR) 10jenkins-bot: [V: 04-1] Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [23:32:47] (03CR) 10EBernhardson: [C: 032 V: 032] Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [23:33:05] 3Wikimedia / 3Site requests: Sidebar upload image link to commons - 10https://bugzilla.wikimedia.org/73439#c2 (10Andre Klapper) s:5normal>3enhanc [Moving to "Wikimedia" product as I assume that this request is about settings / configuration of the website, not about the codebase of MediaWiki itself.] [23:33:37] (03Merged) 10jenkins-bot: Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [23:36:20] (03CR) 10EBernhardson: [C: 032] generateLocalAutoload.php: Abort for web requests [core] - 10https://gerrit.wikimedia.org/r/173453 (owner: 10PleaseStand) [23:36:30] (03PS1) 10PleaseStand: AutoloadGenerator: Add newline at end of output file [core] - 10https://gerrit.wikimedia.org/r/173458 [23:38:21] 3MediaWiki extensions / 3GlobalUserPage: Security review of GlobalUserPage extension - 10https://bugzilla.wikimedia.org/70584#c2 (10Chris Steipp) Sorry for the delay on this. Minor nitpick: The default central wiki is an http link, can you make that https, so we encourage that? That ties into the bigger is... [23:38:50] GlobalUserPage security review - https://phabricator.wikimedia.org/T1285 (10csteipp) 3NEW p:3Triage [23:39:02] GlobalUserPage security review - https://phabricator.wikimedia.org/T1285#22406 (10csteipp) [23:39:19] GlobalUserPage security review - https://phabricator.wikimedia.org/T1285#22406 (10csteipp) p:5Triage>3Normal a:3csteipp [23:39:36] GlobalUserPage security review - https://phabricator.wikimedia.org/T1285#22406 (10csteipp) [23:40:57] (03PS3) 10Matthias Mullie: Expand/compress textareas via CSS instead of swapping nodes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/173324 [23:41:09] (03PS3) 10Matthias Mullie: Make it possible to add interactiveHandlers to elements on focus [extensions/Flow] - 10https://gerrit.wikimedia.org/r/173325 [23:41:48] (03Merged) 10jenkins-bot: generateLocalAutoload.php: Abort for web requests [core] - 10https://gerrit.wikimedia.org/r/173453 (owner: 10PleaseStand) [23:41:51] (03CR) 10jenkins-bot: [V: 04-1] Expand/compress textareas via CSS instead of swapping nodes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/173324 (owner: 10Matthias Mullie) [23:41:54] (03CR) 10Mattflaschen: [C: 04-1] "mlitn, can you just remove the style attribute instead of using !important?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/173324 (owner: 10Matthias Mullie) [23:41:57] (03CR) 10jenkins-bot: [V: 04-1] Make it possible to add interactiveHandlers to elements on focus [extensions/Flow] - 10https://gerrit.wikimedia.org/r/173325 (owner: 10Matthias Mullie) [23:44:26] (03PS1) 10Legoktm: Make default settings generic [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/173461 [23:46:22] (03PS1) 10EBernhardson: Fix JS timestamp; shows up as 45 years ago (epoch) [extensions/Flow] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173462 [23:46:32] (03CR) 10Matthias Mullie: [C: 032] Stop indentation at .flow-post-max-depth [extensions/Flow] - 10https://gerrit.wikimedia.org/r/173232 (owner: 10EBernhardson) [23:47:15] (03CR) 10jenkins-bot: [V: 04-1] Fix JS timestamp; shows up as 45 years ago (epoch) [extensions/Flow] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173462 (owner: 10EBernhardson) [23:47:24] (03Merged) 10jenkins-bot: Stop indentation at .flow-post-max-depth [extensions/Flow] - 10https://gerrit.wikimedia.org/r/173232 (owner: 10EBernhardson) [23:47:27] (03PS1) 10Chad: Removing a ton of empty repositories [extensions] - 10https://gerrit.wikimedia.org/r/173463 [23:48:47] (03CR) 10EBernhardson: "recheck" [extensions/Flow] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173462 (owner: 10EBernhardson) [23:50:32] (03CR) 10BryanDavis: [C: 032] Fix inconsistent spacing in composer.json [extensions/cldr] - 10https://gerrit.wikimedia.org/r/173448 (owner: 10Legoktm) [23:50:51] 3MediaWiki extensions / 3AbuseFilter: Incorrect tagging of a certain edit at English Wikipedia – AbuseFilter's diff and the real diff are not the same - 10https://bugzilla.wikimedia.org/71947#c3 (10Helder) Here is another example on Portuguese Wikipedia: https://pt.wikipedia.org/wiki/Special:AbuseFilter/exam... [23:51:48] (03CR) 10Matthias Mullie: "I don't mind renaming it. Just didn't want to replace "interactive", as the focus handlers are also still "interactive" :p" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/173325 (owner: 10Matthias Mullie) [23:51:50] 3MediaWiki / 3Interface: "Enlarge" icon (magnify-clip.png) missing a SVG version - 10https://bugzilla.wikimedia.org/69705 (10Bartosz Dziewoński) [23:52:05] 3MediaWiki extensions / 3AbuseFilter: Incorrect tagging of edits on some Wikipedias – AbuseFilter's diff and the real diff are not the same - 10https://bugzilla.wikimedia.org/71947 (10Helder) [23:52:36] 3MediaWiki extensions / 3SemanticForms: "Add another" feature for multiple-instance templates broken with MW >= 1.24 - 10https://bugzilla.wikimedia.org/72900#c18 (10Yaron Koren) Aha! No problem, and that's great to hear. [23:53:24] (03Merged) 10jenkins-bot: Fix inconsistent spacing in composer.json [extensions/cldr] - 10https://gerrit.wikimedia.org/r/173448 (owner: 10Legoktm) [23:53:52] Aphlict security review - https://phabricator.wikimedia.org/T1286 (10csteipp) 3NEW p:3Normal a:3csteipp