[00:01:14] (03CR) 10Catrope: [C: 032] Update MobileFrontend [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170860 (owner: 10Kaldari) [00:01:18] (03CR) 10Catrope: [C: 032] Update VisualEditor for cherry-picks [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170795 (owner: 10Catrope) [00:01:22] (03CR) 10Catrope: [C: 032] Update VisualEditor for cherry-picks [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170793 (owner: 10Catrope) [00:01:38] (03CR) 10Catrope: [C: 032] Revert layout changes in Media viewer [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170816 (owner: 10Gilles) [00:02:38] (03CR) 10Legoktm: [C: 032] Add i18n for API module help [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/169816 (owner: 10Anomie) [00:03:18] (03CR) 10Legoktm: [C: 032] Add i18n for API module help [extensions/Echo] - 10https://gerrit.wikimedia.org/r/169813 (owner: 10Anomie) [00:06:57] (03Merged) 10jenkins-bot: Update MobileFrontend [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170860 (owner: 10Kaldari) [00:07:59] (03Merged) 10jenkins-bot: Update VisualEditor for cherry-picks [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170795 (owner: 10Catrope) [00:08:04] (03Merged) 10jenkins-bot: Update VisualEditor for cherry-picks [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170793 (owner: 10Catrope) [00:08:11] (03Merged) 10jenkins-bot: Revert layout changes in Media viewer [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170816 (owner: 10Gilles) [00:08:13] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/169816 (owner: 10Anomie) [00:08:15] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/Echo] - 10https://gerrit.wikimedia.org/r/169813 (owner: 10Anomie) [00:14:07] (03CR) 10Subramanya Sastry: "New extension .. but this feels like page metadata disguished as an extension tag which is why you are adding this to core parser tests." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/170599 (owner: 10Bartosz Dziewoński) [00:14:11] (03CR) 10Legoktm: [C: 032] Add i18n for API module help [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/169827 (owner: 10Anomie) [00:14:32] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/169827 (owner: 10Anomie) [00:14:42] (03CR) 10Ori.livneh: [C: 04-1] "I don't like the introduction of globals, a new configuration object, and the fact that sql_store_event no longer does what its name sugge" (034 comments) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/169977 (https://bugzilla.wikimedia.org/67450) (owner: 10Nuria) [00:14:51] (03CR) 10Legoktm: [C: 032] Add i18n for API module help [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/169825 (owner: 10Anomie) [00:15:08] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/169825 (owner: 10Anomie) [00:19:33] (03PS1) 10Krinkle: jquery.getAttrs: Remove compat code for IE6/IE7 [core] - 10https://gerrit.wikimedia.org/r/170865 [00:19:35] (03PS1) 10Krinkle: jquery.getAttrs: Replace deprecated nodeName/nodeValue with Attr.name/value [core] - 10https://gerrit.wikimedia.org/r/170866 [00:21:33] (03CR) 10Legoktm: [C: 032] "Should this module be marked as internal?" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/169815 (owner: 10Anomie) [00:21:59] (03PS1) 10Ori.livneh: Fix: "Undefined index: bandwidth" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/170867 [00:23:10] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/169815 (owner: 10Anomie) [00:23:23] (03CR) 10Legoktm: [C: 032] Add i18n for API module help [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/169817 (owner: 10Anomie) [00:23:36] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/169817 (owner: 10Anomie) [00:24:13] (03CR) 10BryanDavis: [C: 04-1] "I think that rather than pulling from this downstream that just happened to publish their fork on packagist.org we should pull directly fr" [vendor] - 10https://gerrit.wikimedia.org/r/170369 (https://bugzilla.wikimedia.org/72779) (owner: 1001tonythomas) [00:26:54] (03CR) 10Legoktm: "I believe Chris reviewed it given his comment in https://bugzilla.wikimedia.org/show_bug.cgi?id=69099#c3" [vendor] - 10https://gerrit.wikimedia.org/r/170369 (https://bugzilla.wikimedia.org/72779) (owner: 1001tonythomas) [00:28:33] (03PS4) 10Trevor Parscal: Index ResourceLoader dependency lists in startup [core] - 10https://gerrit.wikimedia.org/r/168732 [00:29:10] Hi! Does anyone know how caching and cache-purging works for http://bits.wikimedia.org/en.wikipedia.org/load.php?debug=true&lang=en&modules=startup&only=scripts&skin=vector&* ?? [00:29:26] (03CR) 10Krinkle: [C: 04-1] "(per previous comment)" [core] - 10https://gerrit.wikimedia.org/r/168732 (owner: 10Trevor Parscal) [00:29:36] (03CR) 10Legoktm: [C: 032] Add i18n for API module help [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/169821 (owner: 10Anomie) [00:29:45] awight: ejegg: whom should I ping? [00:29:49] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/169821 (owner: 10Anomie) [00:29:58] AndyRussG: As being an unversioned load.php url, it is cached for 5 minutes by the browser and for 5 minutes by the cache-proxy. [00:29:59] AndyRussG: I do [00:30:07] But Krinkle does too, I'll let him take it :) [00:30:17] woooo :) hi Krinkle and RoanKattouw [00:30:53] Krinkle: AndyRussG is working on a really crazy idea, which would make CentralNotice not suck. [00:31:40] k, sounds interesting. [00:31:43] Krinkle: the general idea is that we do a database query when setting the mw.config variables, which builds the current CN allocations table for the given language and project... and inlines that as a configuration array. [00:31:44] Any details to spill? [00:32:12] yeah... :) we need to have banners depend on more parameters than the cache can handle [00:32:39] AndyRussG: what kind of parameters? which cache? [00:32:45] the varnish cache [00:32:52] So we'd like to send to the client a list of CentralNotice campaigns and banners that are available for a given language and project [00:32:58] and have the client chooooose [00:33:10] err, the cache thing is just one of the benefits this scheme would give us, we would fragment the cache much less. [00:33:11] which campaign/banner [00:33:17] yes [00:33:39] (...but it was on the other hand a likely impediment to other options we looked at...) [00:33:58] AndyRussG: Right now the client sends the environment to the server via a Special page, which responds with a banner ID which is then fetched from a cached url, right? [00:33:58] I'm curious about whether we will be trout-slapped for doing a few ms of calculations and jamming a lot (1-8k) of json into the exported config [00:34:27] I recommend not getting bogged down in CentralNotice implementation details... [00:34:30] (03CR) 10jenkins-bot: [V: 04-1] Index ResourceLoader dependency lists in startup [core] - 10https://gerrit.wikimedia.org/r/168732 (owner: 10Trevor Parscal) [00:35:13] Krinkle: that's an accurate enough summary :) there are some more details here https://www.mediawiki.org/wiki/Extension:CentralNotice/Banner_loading [00:35:19] awight: Sounds like a bad idea if you phrase it that way [00:35:21] but I don't think they're relevant to the immediate question [00:35:26] hrm [00:35:39] Currently it's a bit more efficient, rather it sends to Special page the language, project, bucket, geo id, device, some other details including a rando slot, and the server decides what campaign/banner you get [00:35:48] So one background call and you have a banner [00:35:59] Right, not a separate request [00:36:05] at the cost of not caching it [00:36:21] The background call has to be deterministic and not explode the cache, which it's currently almost doing since there are so many parameters [00:36:48] What do you mean it has to be deterministic? [00:37:05] Doesn't it return a different one each time potentially based on the available pool of banners? [00:37:12] Mmm that's my understanding of caching, you have to be sure you'll get the same response with the same paraemters [00:37:19] It only pretends to [00:37:38] (03CR) 10Legoktm: [C: 032] Use Config instead of globals [skins/Truglass] - 10https://gerrit.wikimedia.org/r/168912 (owner: 10Lewis Cawte) [00:37:39] In fact one of the parameters is a randomized "slot", so all the indeterminism happens on the client [00:37:40] (03Merged) 10jenkins-bot: Use Config instead of globals [skins/Truglass] - 10https://gerrit.wikimedia.org/r/168912 (owner: 10Lewis Cawte) [00:37:58] well, it depends on which cache you're referring to. If you make the request cachable (not dependant on cookies and cache-control:public) then squid/varnish will cache it by url until it is purged. [00:38:00] The problem is that the server can't get from the outset everything it needs to decide what campaign/banner you get, that's why something has to happen on the client [00:38:39] AndyRussG: Does that mean if there are 4 central notices for registered users that are equal in weight, I only ever get one? [00:38:42] Well issue right now is just how to the extra data into the client without having to make yet another request [00:38:58] Krinkle: currently yes, only one per page visit [00:39:08] (03CR) 10Legoktm: [C: 032] Always return string on HTMLTagFilter::getInputHTML [core] - 10https://gerrit.wikimedia.org/r/170303 (owner: 10Umherirrender) [00:39:14] AndyRussG: That's not what I meant, obvously it only shows one at a time [00:39:21] Ah [00:39:33] Will the random "slot" will be different each request [00:39:34] sorry [00:39:38] I mean, if the slot is determined client side does that mean my session or browser has a persistent slot? [00:39:41] Ah, okay [00:39:49] Yeah the slot will change on each request [00:39:57] ok [00:40:04] That's nice [00:40:16] In the bannerController.js: slot: Math.floor( Math.random() * RAND_MAX ) + 1 [00:40:27] Where RAND_MAX= 30 [00:40:50] So that's the current strategy for being able to cache banner responses [00:41:01] Hm.. May wanna use Math.ceil instead of floor+1 [00:41:16] Well that hopefully will go out the door [00:41:28] anyhow, so what's the issue at hand or feature you're trying to implement [00:41:35] I get the current situation now [00:41:36] The problem now is that we want even more parameters... or ahem... analyitics, really, needs even more paremters [00:41:50] And that'll just splinter the cache even more [00:42:00] you mean parameters that influence which banner is shown? in addition to country/lang/project etc.? [00:42:04] Yes [00:42:10] (03PS1) 10EBernhardson: Support private wiki's [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170869 [00:42:16] Currently there's another parameter, "bucket", which is used for A/B testing [00:42:17] AndyRussG: Right [00:42:28] But it's global per project [00:42:40] And we're trying to make buckets campaign specific [00:42:59] (03CR) 10jenkins-bot: [V: 04-1] Support private wiki's [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170869 (owner: 10EBernhardson) [00:43:06] And also introduce another parameter, "phase", for serving first one kind of banner and then another [00:43:33] (03PS2) 10EBernhardson: Support private wiki's [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170869 [00:43:39] So we were talking about different ways to get more data to bannerController [00:43:55] On the server we know what the project is, what the logged in status is, and what the language is [00:43:55] AndyRussG: From what I understand, we have done in the past banners that incorporate user groups/rights/count and things like that (they're in mw.config) client-side [00:44:03] I guess those were implemented as an omni-banner [00:44:14] Yes, we'd prefer to supply the list of banners to the client, which will make a calculation and retrieve a specific banner (x language and country) [00:44:36] (03PS3) 10EBernhardson: Support private wiki's [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170869 [00:44:42] But we can't afford the additional round-trip to retrieve the list of banners, then fetch a specific banner. [00:44:48] (03Merged) 10jenkins-bot: Always return string on HTMLTagFilter::getInputHTML [core] - 10https://gerrit.wikimedia.org/r/170303 (owner: 10Umherirrender) [00:44:57] ^ this [00:45:04] Hence, brainstorming about ways to cheat and get the list of banners early in page load. [00:45:25] I was like, why don't we just stuff it in a resource loader config variable hehehehe [00:45:38] The banners can be quite large, and some are only very rarely shown. Dumping all seems like overkill. [00:45:49] Krinkle: right, it won't be dumping all [00:46:02] Krinkle: this is only the list of banners, not the contents [00:46:04] it'll be dumping only the ones that are active for a given language or project, usually no more than 2 or 3 [00:46:11] Ah yes also, not banner content [00:46:12] 3MediaWiki / 3General/Unknown: Write a secure group editor - 10https://bugzilla.wikimedia.org/27035 (10Alex Monk) 5PATC>3ASSI a:5Alex Monk>3None [00:46:15] computation is probably not an issue since it's cached globally and strongly and if set up properly, varnish will merge incoming requests on a cache miss. [00:46:27] 3MediaWiki / 3General/Unknown: Write a secure group editor - 10https://bugzilla.wikimedia.org/27035 (10Alex Monk) 5ASSI>3NEW [00:46:28] 3Wikimedia / 3Logstash: Update puppet managed copy of elasticsearch template - 10https://bugzilla.wikimedia.org/72930 (10Bryan Davis) 3NEW p:3Unprio s:3minor a:3None Update the default index template in modules/logstash/files/elasticsearch-template.json of operations/puppet.git to match the current r... [00:46:40] 3Wikimedia / 3Logstash: Update puppet managed copy of elasticsearch template - 10https://bugzilla.wikimedia.org/72930 (10Bryan Davis) p:5Unprio>3Normal [00:46:47] AndyRussG's two proposals so far are 1) skin change to load the list of banners from a script tag in the head, and 2) sneak into a config variable [00:46:49] so assuming it isn't slow for the waiting user, it certainly won't block the server. [00:47:09] Can you just put any arbitrary amount of data in a resource loader config vaariable? [00:47:33] e.g. resourceloader startup is not too slow for the user to generate, but too slow for the server to do lots of at once. That's why its' cached in two layers. Then a 5 minute exiy is more than enough. It means we only ever compute it once every 5 minutes for 1 user. [00:47:53] What about for anonymous users? [00:48:00] AndyRussG: anything you stuff into startup will be purged, re-generated, and (most importantly) re-downlaoded every 5 minutes. [00:48:17] It should most likely not be used for whatever you're doing, I think. [00:48:21] Krinkle: that's a more than acceptable lag [00:48:46] skin changes take like weeks [00:48:53] or decades [00:48:58] The lag isn't the issue. 5 minutes is soon enough indeed. [00:49:05] Krinkle: should not be used, because of the payload size? [00:49:24] awight: Yes. As far as readers/users are concerned, they're redownloading it every 5 minutes no matter whether something changed. [00:49:26] or because it's an evil idea... [00:49:42] It should be used to bootstrap the mediawiki and resourceloader environment. [00:49:52] 1k every 5 minutes would be a non-issue, I think [00:50:10] yeah I don't think it'd be very big... [00:50:14] awight: As far as request combination goes, whatever code you have can trivially go in a separate module that is loaded alongside other modules in a request. [00:50:22] Making it its own module doesn't mean it's a seprate request [00:50:33] that's only the case if the code is delivered through something weird like a special page :) [00:50:40] :) seriously. [00:51:02] modules are cheap and easier to reason about and invalidate. [00:51:12] Is there a precedent for RL modules containing dynamically generated json? [00:51:33] The module would be a ResourceLoaderModule subclass that returns the json/js from getScript() and implements a hash to determine whehter it has changed [00:51:36] banner controller is currently sent as a module in the BeforePageDisplay hook [00:51:42] then it can be loaded alongside the main resourceloader module request [00:51:49] and invalidated automatically within 5 minutes [00:51:53] when a change is detected. [00:52:15] AndyRussG: awight: Look at the ResourceLoaderLanguageData module for example [00:52:22] * awight hi-fives all around [00:52:23] That's essentially sending a json blob to mw.language module [00:52:26] (03CR) 10Legoktm: Add "tag-HHVM" message (031 comment) [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/158137 (owner: 10Legoktm) [00:52:34] wohoo sounds just right [00:52:37] Krinkle: thanks! [00:52:49] Let me know if you need anything else :) [00:53:00] (03PS1) 10Aaron Schulz: Support empty DB names in LoadBalancer more fully [core] - 10https://gerrit.wikimedia.org/r/170870 [00:53:13] Krinkle: sure: a nice reference when we bring the site down next week :D [00:53:17] (03PS5) 10Trevor Parscal: Index ResourceLoader dependency lists in startup [core] - 10https://gerrit.wikimedia.org/r/168732 [00:53:25] for my next job :'-( [00:53:28] Krinkle: thanks a ton, really appreciate it :) [00:53:43] 3MediaWiki / 3Database: Add el_timestamp to the externallinks table - 10https://bugzilla.wikimedia.org/72931 (10Betacommand) 3NEW p:3Unprio s:3normal a:3None Betacommand Ive got an interesting idea for the externallinks table. What about having a including the timestamp that a link was added? Like... [00:53:43] awight: np, I'll take the blame [00:53:50] you got it :p [00:54:08] AndyRussG: awight: To clarify, this works better because it'll be laoded as part of the load.php request generated by mw.loader (whih includes the max() of the startup version numbers and can be cached by the browser). [00:54:40] 3MediaWiki / 3Database: Add el_timestamp to the externallinks table - 10https://bugzilla.wikimedia.org/72931 (10Kunal Mehta (Legoktm)) p:5Unprio>3Normal s:5normal>3enhanc [00:54:43] one of the numbers in the startup module will be your new module's last modified timestamp [00:54:48] yes I like it being encapsulated, anyway [00:55:02] RoanKattouw: sanity check? [00:55:12] Reading backscroll [00:55:13] (last few minutes scrollback) [00:55:32] Ahm, from where exactly? [00:55:35] It goes on for pages [00:56:08] (03CR) 10Krinkle: Index ResourceLoader dependency lists in startup (031 comment) [core] - 10https://gerrit.wikimedia.org/r/168732 (owner: 10Trevor Parscal) [00:56:09] RoanKattouw: tl;dr: sending some jsony bloby info early into the client [00:56:18] for use by JS [00:56:30] Aha [00:56:38] Does the info depend on config or on the page? [00:56:42] à la ResourceLoaderLanguageData [00:56:48] RoanKattouw: yeah, punchline was, we're talking about listing CentralNotice banners and campaigns for a given (lang, project) in a ResourceLoader module, which generates dynamic json like ResourceLoaderLanguageData [00:56:58] OK [00:57:14] So that list is not dependent on which page you're looking at [00:57:14] But it might change at any time [00:57:21] RoanKattouw: exactly! [00:57:21] So it's not like a page property and very much like a config setting [00:57:24] Correct? [00:57:29] yes [00:57:44] It bifurcates only on project (i.e. wiki) and language [00:57:49] And, we're already accustomed to a 15-minute cache delay on the banners, so 5 minutes would actually be a big improvement, in the context of a 1-hour test. [00:57:54] OK cool [00:57:56] So, yes [00:58:00] There is a hook you can use [00:58:06] I always forget the name, looking it up now [00:58:17] ResourceLoaderGetConfigVars [00:58:41] RoanKattouw: well, Krinkle was suggesting we serve this data as its own RL module [00:58:48] Ooh [00:58:53] Ahm, yeah that would be possible [00:58:53] that lets us manage its caching independently... [00:58:55] Better, actually [00:58:56] so that it doesn't get redownloaded every 5 minutes [00:58:57] RoanKattouw: yeah that hook was my first thought [00:59:06] No that's an excellent suggestion [00:59:08] at no extra cost [00:59:11] Come to think of it it's probably relatively big [00:59:19] 1-8k, or so [00:59:24] Krinkle is the expert regarding data modules, he invented the infrastructure for it [00:59:30] :) hired. [00:59:39] ResourceLoaderLanguageData is exactly the model you want to follow [00:59:39] (03CR) 10jenkins-bot: [V: 04-1] Index ResourceLoader dependency lists in startup [core] - 10https://gerrit.wikimedia.org/r/168732 (owner: 10Trevor Parscal) [00:59:40] * AndyRussG blinks in admiration [00:59:44] hehehe [00:59:51] That is the module that all the bugs were found in (and therefore fixed in) :) [00:59:54] awight: Roan brings up a good point though, what's your fragmentation? [00:59:54] (03PS3) 10BryanDavis: Update autoloader-suffix to match repo name [vendor] - 10https://gerrit.wikimedia.org/r/170135 (owner: 10Umherirrender) [01:00:09] Krinkle: project x language is great for our purposes [01:00:19] ^ yes that's it for now [01:00:28] awight: you'll only have wikidb, skin and user language as variation (wiki hostname and resourceloader context paramters) [01:00:42] (03CR) 10BryanDavis: [C: 032] Update autoloader-suffix to match repo name [vendor] - 10https://gerrit.wikimedia.org/r/170135 (owner: 10Umherirrender) [01:00:56] yep, that's great. That narrows us down to only a few banners. [01:00:57] since load.php is fragmented by wiki hostname first, and then by skin/user/lang [01:01:10] sounds prefect [01:01:31] If one day we were able to get GeoID into PHP we might want to fragment further, but for today that's fantastic [01:01:43] you'll probably need to slice project-site/lang from the wiki id [01:02:09] since you won't have any custom url parameters [01:02:43] it's config->DBname and context->language [01:03:33] Krinkle: I'll look at how the RL subclasses are invoked, but ordinarily that's just available in PHP globals, right? [01:03:36] (03PS1) 10Aaron Schulz: Removed obsolete TODO comment [services/jobrunner] - 10https://gerrit.wikimedia.org/r/170871 [01:03:58] awight: Yep [01:04:24] awight: so you;ll need to extract project, site language and user language server-side from the environment. pretty straight forward though [01:04:25] yeah [01:04:37] Currently in bannerController.js it's uselang: mw.config.get( 'wgUserLanguage' ), [01:04:37] db: mw.config.get( 'wgDBname' ), [01:04:37] project: mw.config.get( 'wgNoticeProject' ), [01:05:52] (03Merged) 10jenkins-bot: Update autoloader-suffix to match repo name [vendor] - 10https://gerrit.wikimedia.org/r/170135 (owner: 10Umherirrender) [01:06:07] that RL LanguageData module is real pretty... [01:07:55] (03PS2) 10BryanDavis: Update monolog/monolog to 1.11.0 [vendor] - 10https://gerrit.wikimedia.org/r/170125 (owner: 10Reedy) [01:07:57] (03CR) 10jenkins-bot: [V: 04-1] Update monolog/monolog to 1.11.0 [vendor] - 10https://gerrit.wikimedia.org/r/170125 (owner: 10Reedy) [01:08:33] AndyRussG: this is great... we can even have the bannerlist module depend on the bannercontroller, so they're loaded in a predictable order... [01:09:44] awight: yeah, I think we're all set :) [01:10:06] (03PS3) 10BryanDavis: Update monolog/monolog to 1.11.0 [vendor] - 10https://gerrit.wikimedia.org/r/170125 (owner: 10Reedy) [01:10:08] (03CR) 10jenkins-bot: [V: 04-1] Update monolog/monolog to 1.11.0 [vendor] - 10https://gerrit.wikimedia.org/r/170125 (owner: 10Reedy) [01:10:24] Seems like this even avoids the 1-week cache expiry for skin changes! [01:11:11] Yeah! :) ready to rock and roll [01:11:27] (03CR) 10BryanDavis: "I'm not sure why jenkins-bot is confused after I manually rebased. :(" [vendor] - 10https://gerrit.wikimedia.org/r/170125 (owner: 10Reedy) [01:11:54] bd808: it's still showing a rebase button for me [01:11:56] Krinkle: RoanKattouw: thanks again :) [01:12:10] Reedy: Yeah, for me too. [01:12:12] bd808: you're missing a patch https://github.com/wikimedia/mediawiki-vendor/commits/master [01:12:23] https://github.com/wikimedia/mediawiki-vendor/commit/55a17685f2c3191ae98a922d6446e64308114815 [01:12:31] oh... I forgot to fetch :/ [01:13:23] * ebernhardson cant wait to stop json encoding metadata and just attaching it to the end of a log line :) [01:13:43] ebernhardson: It will be nice right? [01:13:50] bd808: will be glorious :) [01:14:40] ebernhardson: You could review and +2 https://gerrit.wikimedia.org/r/#/c/141599/ to make that future happen just a bit sooner. :) [01:15:50] (03PS4) 10BryanDavis: Update monolog/monolog to 1.11.0 [vendor] - 10https://gerrit.wikimedia.org/r/170125 (owner: 10Reedy) [01:16:00] RoanKattouw: both oo.Factory.create and oo.EventEmitter.emit are flagged by chrome's JS profiler w/ "Not optimized: inlining bailed out". Are you aware of this / have you guys investigated this? [01:16:18] What does "inlining bailed out" mean? [01:16:27] (03PS9) 10Mattflaschen: J2f - Add minimal topic list API for TOC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169310 [01:16:36] (no I was not aware of this) [01:16:49] bd808: sure i'll look it over, dunno about a +2 though :) is the plan for extensions to each get their own logger object through the SPI, or changing the global logging functions? [01:16:51] RoanKattouw: it means that v8 did not inline the function for some reason (using eval() would be one reason, not applicable here) [01:17:01] RoanKattouw: investigating is tricky, see: https://github.com/GoogleChrome/devtools-docs/issues/53 [01:17:14] (03CR) 10jenkins-bot: [V: 04-1] J2f - Add minimal topic list API for TOC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169310 (owner: 10Mattflaschen) [01:18:03] RoanKattouw: see too -- when loading Barack Obama oo.Factory.create calls amounted to 7% of the total load time [01:18:08] ebernhardson: Long term the plan (such as it is) is to have things grab an MWLogger instance and talk to it directly, but we are many many edits away from that day. [01:18:48] (03CR) 10Mattflaschen: "Done, except the templating and test ones." (035 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169310 (owner: 10Mattflaschen) [01:19:10] ebernhardson: Exposing the logger context via the global functions is a useful intermediate step I think. [01:20:12] (03CR) 10BryanDavis: [C: 031] "Rebase works better when you fetch all upstream changes first." [vendor] - 10https://gerrit.wikimedia.org/r/170125 (owner: 10Reedy) [01:21:51] ori: Thanks for the heads-up, I will investigate this soon [01:21:58] Right now I have restaurant to go to :) [01:22:03] sure [01:22:45] (03CR) 10Legoktm: [C: 032] hash_equals(): Avoid division by zero when $known_string is empty [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/168931 (owner: 10PleaseStand) [01:25:44] 3MediaWiki / 3Logging: PHP Fatal error: Interface 'Psr\Log\LoggerInterface' not found in Logger.php - 10https://bugzilla.wikimedia.org/72932 (10Ryan Kaldari) 3NEW p:3Unprio s:3major a:3None Ever since I last updated my MediaWiki repo to master I can't load /index.php or /mw-config/index.php (or run... [01:26:07] lol [01:26:57] 3MediaWiki / 3Logging: PHP Fatal error: Interface 'Psr\Log\LoggerInterface' not found in Logger.php - 10https://bugzilla.wikimedia.org/72932#c1 (10Sam Reed (reedy)) You need to clone our vendor repo, or run composer https://www.mediawiki.org/wiki/Composer#Installing_Composer [01:27:11] 3MediaWiki / 3Unit tests: Unit tests in FormatJsonTest fail - 10https://bugzilla.wikimedia.org/72778#c8 (10Bryan Davis) Ori pointed out that the CMake rules will use a shared libjson-c library if present and the WMF HHVM build is using that: $ ldd /usr/bin/hhvm |grep json libjson-c.so.2 => /lib/x86_... [01:29:01] (03Merged) 10jenkins-bot: hash_equals(): Avoid division by zero when $known_string is empty [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/168931 (owner: 10PleaseStand) [01:31:06] (03CR) 10EBernhardson: "filed db change as https://bugzilla.wikimedia.org/show_bug.cgi?id=72934" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165683 (https://bugzilla.wikimedia.org/60646) (owner: 10EBernhardson) [01:39:54] (03PS1) 10Jdlrobson: Apply margin right to mw ui checkbox [core] - 10https://gerrit.wikimedia.org/r/170876 (https://bugzilla.wikimedia.org/72727) [01:44:49] 3Wikimedia / 3General/Unknown: Add two new columns to flow_revision table - 10https://bugzilla.wikimedia.org/72934 (10Erik Bernhardson) 3NEW p:3Unprio s:3normal a:3None Short description: To support output requirements we are going to start explicitly tracking the number of bytes in a revision and t... [01:44:49] 3Wikimedia / 3General/Unknown: Add two new columns to flow_revision table - 10https://bugzilla.wikimedia.org/72934 (10Erik Bernhardson) p:5Unprio>3Normal a:3Sean Pringle [01:44:49] 3MediaWiki / 3Logging: PHP Fatal error: Interface 'Psr\Log\LoggerInterface' not found in Logger.php - 10https://bugzilla.wikimedia.org/72932#c4 (10Ryan Kaldari) Reedy: Thanks that fixed it. [01:44:49] 3MediaWiki / 3Logging: PHP Fatal error: Interface 'Psr\Log\LoggerInterface' not found in Logger.php - 10https://bugzilla.wikimedia.org/72932#c3 (10Kunal Mehta (Legoktm)) https://lists.wikimedia.org/pipermail/wikitech-l/2014-October/079232.html [01:44:50] 3MediaWiki / 3Logging: PHP Fatal error: Interface 'Psr\Log\LoggerInterface' not found in Logger.php - 10https://bugzilla.wikimedia.org/72932#c2 (10Sam Reed (reedy)) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 72777 *** [01:44:51] 3Wikimedia / 3Bugzilla: New component of MediaWiki for mediawiki/vendor git repository - 10https://bugzilla.wikimedia.org/72935 (10Bryan Davis) 3NEW p:3Unprio s:3normal a:3None Name: Vendor Type: Component Category: MediaWiki Default CC: bdavis@wikimedia.org Description: External libraries required... [01:44:52] 3MediaWiki / 3General/Unknown: [Regression] MediaWiki should detect absent or outdated vendor - 10https://bugzilla.wikimedia.org/72777#c4 (10Sam Reed (reedy)) *** Bug 72932 has been marked as a duplicate of this bug. *** [01:45:50] 3Wikimedia / 3Bugzilla: New component of MediaWiki for mediawiki/vendor git repository - 10https://bugzilla.wikimedia.org/72935#c1 (10Kunal Mehta (Legoktm)) (In reply to Bryan Davis from comment #0) > Default CC: bdavis@wikimedia.org Me too please! :) [01:48:58] YuviPanda|zzz: dogpile.cache claims to be py3 compatible [01:49:24] 3MediaWiki / 3General/Unknown: [Regression] MediaWiki should detect absent or outdated vendor - 10https://bugzilla.wikimedia.org/72777#c5 (10Ryan Kaldari) I ran into the same problem. This should definitely generate some kind of meaningful error message. Also someone should update the documentation on mediaw... [01:52:59] 3MediaWiki / 3General/Unknown: [Regression] MediaWiki should detect absent or outdated vendor - 10https://bugzilla.wikimedia.org/72777#c6 (10Kunal Mehta (Legoktm)) (In reply to Ryan Kaldari from comment #5) > I ran into the same problem. This should definitely generate some kind of > meaningful error message... [01:55:44] 3MediaWiki / 3General/Unknown: [Regression] MediaWiki should detect absent or outdated vendor - 10https://bugzilla.wikimedia.org/72777#c7 (10Ryan Kaldari) Legoktm: It seems to be required to me. If I don't install it, I just get a 500 server error (as Krinkle did). [01:56:42] 3MediaWiki / 3General/Unknown: [Regression] MediaWiki should detect absent or outdated vendor - 10https://bugzilla.wikimedia.org/72777#c8 (10Sam Reed (reedy)) You can just clone https://github.com/wikimedia/mediawiki-vendor instead. you don't have to use composer [01:57:12] 3MediaWiki / 3General/Unknown: [Regression] MediaWiki should detect absent or outdated vendor - 10https://bugzilla.wikimedia.org/72777#c9 (10Ryan Kaldari) Ah, nevermind, I see now. You can install the vendor components manually if you want to. That should be better explained in the prerequisites section. [01:57:21] !bug 1 [01:57:22] https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=1 [01:58:41] 3MediaWiki / 3General/Unknown: [Regression] MediaWiki should detect absent or outdated vendor - 10https://bugzilla.wikimedia.org/72777#c10 (10Ryan Kaldari) Guess I should read the entire instructions and not just the first part :) [01:59:24] kaldari: :P [01:59:32] :) [01:59:41] 3MediaWiki / 3Database: Add el_timestamp to the externallinks table - 10https://bugzilla.wikimedia.org/72931#c1 (10Marc A. Pelletier) Sounds sane; the actual cost of adding a timestamp should be essentially nil, and I can think of a couple use cases when patrolling for spam links that make it easier than tra... [02:00:26] kaldari: if you have some time, testing https://gerrit.wikimedia.org/r/#/c/170274/ would be appreciated [02:01:09] legoktm: sure [02:08:28] legoktm: That works great. [02:08:36] (03CR) 10Kaldari: [C: 032] die() with explanation when \Psr\Log\LoggerInterface is missing [core] - 10https://gerrit.wikimedia.org/r/170274 (https://bugzilla.wikimedia.org/72777) (owner: 10BryanDavis) [02:08:42] woot :D [02:10:26] 3MediaWiki / 3General/Unknown: [Regression] MediaWiki should detect absent or outdated vendor - 10https://bugzilla.wikimedia.org/72777 (10Ryan Kaldari) 5PATC>3RESO/FIX [02:11:28] 3MediaWiki / 3General/Unknown: [Regression] MediaWiki should detect absent or outdated vendor - 10https://bugzilla.wikimedia.org/72777#c11 (10Ryan Kaldari) Fixed in https://gerrit.wikimedia.org/r/#/c/170274/ [02:14:13] (03Merged) 10jenkins-bot: die() with explanation when \Psr\Log\LoggerInterface is missing [core] - 10https://gerrit.wikimedia.org/r/170274 (https://bugzilla.wikimedia.org/72777) (owner: 10BryanDavis) [02:14:25] (03CR) 10MaxSem: die() with explanation when \Psr\Log\LoggerInterface is missing (031 comment) [core] - 10https://gerrit.wikimedia.org/r/170274 (https://bugzilla.wikimedia.org/72777) (owner: 10BryanDavis) [02:15:34] (03CR) 10Kaldari: "Shows up for me both on-screen and in the error logs (with default error settings)." [core] - 10https://gerrit.wikimedia.org/r/170274 (https://bugzilla.wikimedia.org/72777) (owner: 10BryanDavis) [02:39:24] (03CR) 10Technical 13: "Looks mostly fine except I'm not sure why "padding-right: 1em;" is being changed to "padding: 0 1em 0 0;" as the previous is the preferred" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/170296 (https://bugzilla.wikimedia.org/72458) (owner: 10Prtksxna) [02:40:55] 3MediaWiki / 3MediaWiki UI: [[Special:Search]] should not use obsolete "cellpadding" attribute (use CSS instead) - 10https://bugzilla.wikimedia.org/72458#c3 (10Technical 13) Patch mostly looks fine except for one little thing I commented on in Gerrit... *sigh* wish I had known about this before it was merged... [02:47:34] (03CR) 10Prtksxna: "Technical13, it is to remove the default padding that the browser might add on the td." [core] - 10https://gerrit.wikimedia.org/r/170296 (https://bugzilla.wikimedia.org/72458) (owner: 10Prtksxna) [02:50:59] (03CR) 10Technical 13: "Then it shouldn't be ambiguous." [core] - 10https://gerrit.wikimedia.org/r/170296 (https://bugzilla.wikimedia.org/72458) (owner: 10Prtksxna) [02:51:57] 3Wikimedia / 3General/Unknown: Add two new columns to flow_revision table - 10https://bugzilla.wikimedia.org/72934#c1 (10Sean Pringle) 5NEW>3RESO/FIX Both done. [02:56:23] (03CR) 10Prtksxna: "Technical 13, I am not sure what you mean. Is your suggestion that we add the em unit to the zero value?" [core] - 10https://gerrit.wikimedia.org/r/170296 (https://bugzilla.wikimedia.org/72458) (owner: 10Prtksxna) [02:56:58] (03PS10) 10Mattflaschen: J2f - Add minimal topic list API for TOC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169310 [02:58:44] (03PS11) 10Mattflaschen: J2f - Add minimal topic list API for TOC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169310 [03:14:50] (03PS12) 10Mattflaschen: J2f - Add minimal topic list API for TOC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169310 [03:28:35] (03CR) 10Technical 13: "It's just a matter of shorthand vs. longhand and I would rather see the longhand... Also, having the 0s in there does nothing towards my " [core] - 10https://gerrit.wikimedia.org/r/170296 (https://bugzilla.wikimedia.org/72458) (owner: 10Prtksxna) [03:36:42] (03CR) 10Legoktm: [C: 032] Add i18n for API module help [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/169822 (owner: 10Anomie) [03:37:02] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/169822 (owner: 10Anomie) [03:44:10] 3MediaWiki extensions / 3SemanticForms: "Add another" feature for multiple-instance templates broken with MW >= 1.24 - 10https://bugzilla.wikimedia.org/72900#c10 (10Yaron Koren) I can't reproduce that problem, unfortunately. I assume this is not a public wiki? If not, what I would try doing is to cut down th... [03:46:56] (03CR) 10Tim Starling: [C: 031] "Please break comment lines at 80 rather than 100." [core] - 10https://gerrit.wikimedia.org/r/170593 (https://bugzilla.wikimedia.org/72887) (owner: 10Bartosz Dziewoński) [04:15:42] (03PS1) 10Christopher Johnson (WMDE): removed global scope for stat functions [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/170880 [04:19:23] (03CR) 10Christopher Johnson (WMDE): [C: 032 V: 032] removed global scope for stat functions [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/170880 (owner: 10Christopher Johnson (WMDE)) [04:21:01] (03CR) 10Christopher Johnson (WMDE): [C: 032 V: 032] Adds Celerity map and resources [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/170018 (owner: 10Christopher Johnson (WMDE)) [05:13:02] (03CR) 10CSteipp: [C: 032] Split doc for $wgHKDFSecret/$wgHKDFAlgorithm in DefaultSettings.php [core] - 10https://gerrit.wikimedia.org/r/170302 (owner: 10Umherirrender) [05:16:41] 3MediaWiki extensions / 3GlobalUserPage: Security review of GlobalUserPage extension - 10https://bugzilla.wikimedia.org/70584#c1 (10MZMcBride) I'm a bit confused about the status of this bug. Should it be marked assigned? Does Chris have time to do this? [05:16:59] csteipp: Oh, perhaps you're around? Has Lego talked to you about that one? [05:17:13] (03CR) 10Pastakhov: "Yes, I agree with both points." [extensions/PhpTagsWiki] - 10https://gerrit.wikimedia.org/r/170651 (owner: 10Pastakhov) [05:18:46] (03Merged) 10jenkins-bot: Split doc for $wgHKDFSecret/$wgHKDFAlgorithm in DefaultSettings.php [core] - 10https://gerrit.wikimedia.org/r/170302 (owner: 10Umherirrender) [05:26:40] Carmela: yeah, it's in his queue [05:26:42] Carmela: https://www.mediawiki.org/wiki/Security_auditing_and_response#Review_queue [05:36:43] 3MediaWiki / 3History/Diffs: Problems with Diffs - 10https://bugzilla.wikimedia.org/72936 (10Nick Gibson) 3UNCO p:3Unprio s:3normal a:3None See [https://en.wikipedia.org/w/index.php?title=Wikipedia:In_the_news/Candidates&diff=prev&oldid=632380777 this diff]. Also see [[Commons:File:Diff problem.png]]... [05:39:58] (03PS2) 10Pastakhov: add NS_* constants (v 1.5.0) [extensions/PhpTagsWiki] - 10https://gerrit.wikimedia.org/r/170651 [05:40:43] 3MediaWiki / 3Watchlist: New idea for watchlist - 10https://bugzilla.wikimedia.org/72937 (10Nick Gibson) 3UNCO p:3Unprio s:3normal a:3None I propose that on the watchlist, under the line for selecting a namespace, their is a box that can be ticked so that only unveiwed changes appear. [05:41:25] 3MediaWiki / 3Watchlist: New idea for watchlist - 10https://bugzilla.wikimedia.org/72937 (10Nick Gibson) s:5normal>3enhanc [05:46:44] (03CR) 10Pastakhov: [C: 032] add NS_* constants (v 1.5.0) [extensions/PhpTagsWiki] - 10https://gerrit.wikimedia.org/r/170651 (owner: 10Pastakhov) [05:46:54] (03Merged) 10jenkins-bot: add NS_* constants (v 1.5.0) [extensions/PhpTagsWiki] - 10https://gerrit.wikimedia.org/r/170651 (owner: 10Pastakhov) [06:03:12] (03CR) 10TTO: "Brad/Kunal: Any chance of a look at this?" [core] - 10https://gerrit.wikimedia.org/r/148585 (https://bugzilla.wikimedia.org/64333) (owner: 10TTO) [06:04:07] (03CR) 10Nikerabbit: [C: 04-1] "Can you add test case for skins in tests/FinderTest.php?" [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/168274 (https://bugzilla.wikimedia.org/67154) (owner: 10Reedy) [06:04:46] (03PS1) 10Pastakhov: add NS_* constants (v 1.5.0) [extensions/PhpTagsWiki] (REL1_24) - 10https://gerrit.wikimedia.org/r/170881 [06:05:34] (03CR) 10Legoktm: [C: 031] Update article count when pages are moved (031 comment) [core] - 10https://gerrit.wikimedia.org/r/148585 (https://bugzilla.wikimedia.org/64333) (owner: 10TTO) [06:05:37] (03CR) 10Pastakhov: [C: 032] add NS_* constants (v 1.5.0) [extensions/PhpTagsWiki] (REL1_24) - 10https://gerrit.wikimedia.org/r/170881 (owner: 10Pastakhov) [06:05:48] (03Merged) 10jenkins-bot: add NS_* constants (v 1.5.0) [extensions/PhpTagsWiki] (REL1_24) - 10https://gerrit.wikimedia.org/r/170881 (owner: 10Pastakhov) [06:13:39] (03PS4) 10TTO: Update article count when pages are moved [core] - 10https://gerrit.wikimedia.org/r/148585 (https://bugzilla.wikimedia.org/64333) [06:19:25] (03CR) 10Legoktm: [C: 032] Update article count when pages are moved [core] - 10https://gerrit.wikimedia.org/r/148585 (https://bugzilla.wikimedia.org/64333) (owner: 10TTO) [06:25:10] (03Merged) 10jenkins-bot: Update article count when pages are moved [core] - 10https://gerrit.wikimedia.org/r/148585 (https://bugzilla.wikimedia.org/64333) (owner: 10TTO) [06:44:42] (03PS1) 10TTO: Fix fatal error in I0349cfe0e322 [core] - 10https://gerrit.wikimedia.org/r/170882 [06:45:49] (03CR) 10TTO: "This patch gives fatal errors. Sorry :/" [core] - 10https://gerrit.wikimedia.org/r/148585 (https://bugzilla.wikimedia.org/64333) (owner: 10TTO) [06:47:47] (03CR) 10Legoktm: [C: 032] "We need tests covering page moves... :/" [core] - 10https://gerrit.wikimedia.org/r/170882 (owner: 10TTO) [06:53:33] (03Merged) 10jenkins-bot: Fix fatal error in I0349cfe0e322 [core] - 10https://gerrit.wikimedia.org/r/170882 (owner: 10TTO) [06:57:31] (03CR) 10Nikerabbit: Improve mt error handling and reporting (031 comment) [services/cxserver] - 10https://gerrit.wikimedia.org/r/170044 (owner: 10Nikerabbit) [06:57:56] (03PS2) 10Nikerabbit: Improve mt error handling and reporting [services/cxserver] - 10https://gerrit.wikimedia.org/r/170044 [07:21:20] (03CR) 10Nikerabbit: [C: 031] jquery.getAttrs: Replace deprecated nodeName/nodeValue with Attr.name/value [core] - 10https://gerrit.wikimedia.org/r/170866 (owner: 10Krinkle) [07:38:45] (03CR) 10Legoktm: [C: 032] Add hiera config link to project special page [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/170699 (owner: 10Yuvipanda) [07:38:51] (03Merged) 10jenkins-bot: Add hiera config link to project special page [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/170699 (owner: 10Yuvipanda) [07:53:36] (03CR) 10Robert Vogel: "Thank you four the review! I've added some answers." (035 comments) [extensions/Teahouse] - 10https://gerrit.wikimedia.org/r/170702 (owner: 10Robert Vogel) [08:05:58] 3MediaWiki / 3Internationalization: Use 'de-CH' instead of 'de-ch' for attribute lang in HTML - 10https://bugzilla.wikimedia.org/72939 (10Fomafix) 3NEW p:3Unprio s:3minor a:3None * With [[Special:PageLanguage]] it is possible to set the page content language per page. In the MediaWiki namespace there... [08:19:31] (03PS1) 1001tonythomas: Add API parameter handling details for the bounehandler API [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170889 (https://bugzilla.wikimedia.org/72685) [08:19:43] (03CR) 10jenkins-bot: [V: 04-1] Add API parameter handling details for the bounehandler API [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170889 (https://bugzilla.wikimedia.org/72685) (owner: 1001tonythomas) [08:19:51] (03PS1) 10Nikerabbit: Apply wfBCP47 to language attribute on edit page [core] - 10https://gerrit.wikimedia.org/r/170890 (https://bugzilla.wikimedia.org/72939) [08:24:52] (03PS2) 1001tonythomas: Add API parameter handling details for the bounehandler API [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170889 (https://bugzilla.wikimedia.org/72685) [08:28:13] 3MediaWiki / 3Internationalization: Special:PageLanguage does not tag page html output correctly - 10https://bugzilla.wikimedia.org/72940 (10Niklas Laxström) 3NEW p:3Unprio s:3normal a:3None https://dev.translatewiki.net/w/i.php?title=Blag is set to be de-ch, yet the source code says:

(03CR) 10MaxSem: Added wgBounceHandlerCluster setting (032 comments) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170835 (owner: 10Aaron Schulz) [08:32:27] (03CR) 10Seb35: [C: 04-1] "Thanks a lot for improving this extension. Aside the small issue, I will approve this change." (031 comment) [extensions/HSTS] - 10https://gerrit.wikimedia.org/r/170642 (owner: 10Reedy) [08:32:56] 3MediaWiki / 3Internationalization: Special:PageLanguage does not tag page html output correctly - 10https://bugzilla.wikimedia.org/72940 (10Nemo) [08:32:56] 3MediaWiki / 3Internationalization: Specify default language on a per-page basis - 10https://bugzilla.wikimedia.org/9360 (10Nemo) [08:33:35] (03CR) 10Nikerabbit: [C: 032] Clear DeferredUpdates state via setUp() [core] - 10https://gerrit.wikimedia.org/r/170819 (https://bugzilla.wikimedia.org/72922) (owner: 10EBernhardson) [08:34:16] (03PS2) 1001tonythomas: Added wgBounceHandlerCluster setting [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170835 (owner: 10Aaron Schulz) [08:35:58] 3Wikimedia / 3Extension setup: Install Extension:PageLanguage and enabled it on wikidatawiki (maybe on other multilingual wikis too) - 10https://bugzilla.wikimedia.org/53756#c5 (10Nemo) 5NEW>3RESO/DUP Better focus on bug 9360, the deploy of which is essentially tracked at bug 67223. *** This bug has bee... [08:35:58] 3MediaWiki / 3Internationalization: Specify default language on a per-page basis - 10https://bugzilla.wikimedia.org/9360#c25 (10Nemo) *** Bug 53756 has been marked as a duplicate of this bug. *** [08:38:36] (03CR) 10Nemo bis: [C: 031] Apply wfBCP47 to language attribute on edit page [core] - 10https://gerrit.wikimedia.org/r/170890 (https://bugzilla.wikimedia.org/72939) (owner: 10Nikerabbit) [08:38:38] (03CR) 1001tonythomas: [C: 031] Added wgBounceHandlerCluster setting [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170835 (owner: 10Aaron Schulz) [08:39:14] (03Merged) 10jenkins-bot: Clear DeferredUpdates state via setUp() [core] - 10https://gerrit.wikimedia.org/r/170819 (https://bugzilla.wikimedia.org/72922) (owner: 10EBernhardson) [08:40:49] (03PS1) 10Prtksxna: mw.ui:checkbox: Fix indentation and add zero before decimal [core] - 10https://gerrit.wikimedia.org/r/170891 [08:41:35] (03CR) 10Tpt: [C: 031] Apply wfBCP47 to language attribute on edit page [core] - 10https://gerrit.wikimedia.org/r/170890 (https://bugzilla.wikimedia.org/72939) (owner: 10Nikerabbit) [08:43:44] (03CR) 10Fomafix: [C: 031] Apply wfBCP47 to language attribute on edit page [core] - 10https://gerrit.wikimedia.org/r/170890 (https://bugzilla.wikimedia.org/72939) (owner: 10Nikerabbit) [08:47:11] 3MediaWiki / 3Internationalization: Special:PageLanguage does not tag page html output correctly - 10https://bugzilla.wikimedia.org/72940 (10Nemo) [08:48:48] (03CR) 10Fomafix: [C: 04-1] "Use getHtmlCode()." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/170890 (https://bugzilla.wikimedia.org/72939) (owner: 10Nikerabbit) [08:55:07] (03PS3) 1001tonythomas: Add API parameter handling details for the bounehandler API [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170889 (https://bugzilla.wikimedia.org/72685) [09:15:28] (03CR) 10Fomafix: "The same code is in" [core] - 10https://gerrit.wikimedia.org/r/170890 (https://bugzilla.wikimedia.org/72939) (owner: 10Nikerabbit) [09:19:55] 3MediaWiki / 3Interface: [collapsibleTabs] Tabs (Read / View Source / Search) wrap to next line and cover content if screen width < ~700px - 10https://bugzilla.wikimedia.org/54919#c18 (10Michael M.) From bug 72876: On "normal" pages the "Read" tab will not be collapsed, but when the FlaggedRevs extension is... [09:23:11] 3MediaWiki / 3General/Unknown: Updating Page count doesn't work reliably when a page is moved - 10https://bugzilla.wikimedia.org/64333#c15 (10This, that and the other (TTO)) 5PATC>3RESO/FIX Now fixed on the beta cluster. Expect to see it on Wikivoyages on 11 November. [09:33:13] (03PS3) 10Esanders: Add selection restriction to command [extensions/Math] - 10https://gerrit.wikimedia.org/r/170710 [09:33:33] (03PS3) 10Esanders: Add selection restriction to command [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/170709 [09:43:02] (03CR) 10Bartosz Dziewoński: [C: 032] mw.ui:checkbox: Fix indentation and add zero before decimal [core] - 10https://gerrit.wikimedia.org/r/170891 (owner: 10Prtksxna) [09:45:00] (03CR) 10Bartosz Dziewoński: [C: 032] jquery.getAttrs: Remove compat code for IE6/IE7 [core] - 10https://gerrit.wikimedia.org/r/170865 (owner: 10Krinkle) [09:47:27] (03CR) 10Bartosz Dziewoński: [C: 032] jquery.getAttrs: Replace deprecated nodeName/nodeValue with Attr.name/value [core] - 10https://gerrit.wikimedia.org/r/170866 (owner: 10Krinkle) [09:49:00] (03Merged) 10jenkins-bot: mw.ui:checkbox: Fix indentation and add zero before decimal [core] - 10https://gerrit.wikimedia.org/r/170891 (owner: 10Prtksxna) [09:50:47] (03Merged) 10jenkins-bot: jquery.getAttrs: Remove compat code for IE6/IE7 [core] - 10https://gerrit.wikimedia.org/r/170865 (owner: 10Krinkle) [09:53:12] (03Merged) 10jenkins-bot: jquery.getAttrs: Replace deprecated nodeName/nodeValue with Attr.name/value [core] - 10https://gerrit.wikimedia.org/r/170866 (owner: 10Krinkle) [09:54:08] (03PS1) 10Thiemo Mättig (WMDE): Revert uselang=... default to the wikis $wgLanguageCode [core] - 10https://gerrit.wikimedia.org/r/170895 [09:58:07] (03CR) 10Bartosz Dziewoński: "Needs rebase." [core] - 10https://gerrit.wikimedia.org/r/170876 (https://bugzilla.wikimedia.org/72727) (owner: 10Jdlrobson) [09:58:46] (03PS2) 10Bartosz Dziewoński: Apply margin right to mw ui checkbox [core] - 10https://gerrit.wikimedia.org/r/170876 (https://bugzilla.wikimedia.org/72727) (owner: 10Jdlrobson) [09:59:49] (03PS2) 10Adrian Lang: Revert uselang=... default to the wikis $wgLanguageCode [core] - 10https://gerrit.wikimedia.org/r/170895 (owner: 10Thiemo Mättig (WMDE)) [10:01:11] 3MediaWiki extensions / 3SemanticForms: Error when using Special:RunQuery - "Parser state cleared while parsing" - 10https://bugzilla.wikimedia.org/66202#c7 (10Masin Al-Dujaili) Meanwhile, I have been told extensions shouldn't use Parser::parse() at all but rather Parser::recursiveTagParse(). So I changed th... [10:05:27] (03CR) 10Bartosz Dziewoński: [C: 04-1] "This change doesn't match the commit message at all and in general makes no sense to me. Why do we want 1.6em of margin to the right when " [core] - 10https://gerrit.wikimedia.org/r/170876 (https://bugzilla.wikimedia.org/72727) (owner: 10Jdlrobson) [10:14:17] (03PS1) 10Bartosz Dziewoński: mediawiki.ui: Remove dead code from checkbox [core] - 10https://gerrit.wikimedia.org/r/170897 [10:16:27] (03PS1) 10Christopher Johnson (WMDE): Call getAuxFields with Sprint Query in BurndownListController [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/170899 [10:19:09] (03PS5) 10Bartosz Dziewoński: Correctly parse contents, Parser rejiggering [core] - 10https://gerrit.wikimedia.org/r/170593 (https://bugzilla.wikimedia.org/72887) [10:20:38] (03CR) 10Smuggli: [C: 032 V: 032] small css fix, right action buttons now on one line [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/170670 (owner: 10Tweichart) [10:22:47] (03CR) 10Bartosz Dziewoński: "Re-wrapped comments. I expect that this functionality will be used on a small percentage of pages (featured and good articles, little more" [core] - 10https://gerrit.wikimedia.org/r/170593 (https://bugzilla.wikimedia.org/72887) (owner: 10Bartosz Dziewoński) [10:25:14] (03CR) 10jenkins-bot: [V: 04-1] Correctly parse contents, Parser rejiggering [core] - 10https://gerrit.wikimedia.org/r/170593 (https://bugzilla.wikimedia.org/72887) (owner: 10Bartosz Dziewoński) [10:25:59] (03PS6) 10Bartosz Dziewoński: Correctly parse contents, Parser rejiggering [core] - 10https://gerrit.wikimedia.org/r/170593 (https://bugzilla.wikimedia.org/72887) [10:26:28] 3MediaWiki / 3Page editing: Enter in edit summary does nothing when preview is forced - 10https://bugzilla.wikimedia.org/72945 (10Nemo) [10:26:31] 3Wikimedia / 3General/Unknown: Enter in edit summary line doesn't save on ja.wiki - 10https://bugzilla.wikimedia.org/72944 (10Nemo) 3NEW p:3Unprio s:3normal a:3None 1) Visit a random page on ja.wiki 2) Reach action=edit 3) Press tab or otherwise move the cursor in edit summary text area 4) Press ente... [10:26:31] 3Wikimedia / 3General/Unknown: Enter in edit summary line doesn't save on ja.wiki - 10https://bugzilla.wikimedia.org/72944 (10Nemo) [10:26:34] 3MediaWiki / 3Page editing: Enter in edit summary does nothing when preview is forced - 10https://bugzilla.wikimedia.org/72945 (10Nemo) 3NEW p:3Unprio s:3normal a:3None 1) Visit a random page on zh.wiki as non.autoconfirmed user 2) Reach action=edit 3) Press tab or otherwise move the cursor in edit s... [10:27:00] 3Wikimedia / 3General/Unknown: Enter in edit summary line doesn't save on ja.wiki - 10https://bugzilla.wikimedia.org/72944#c1 (10Yusuke Matsubara) If I recall it correctly, this is a behavior added by [[:ja:MediaWiki:Common.js]], not MediaWiki. It can be toggled with the variable summaryEnterRejectDisable.... [10:33:40] (03CR) 10Gilles: [C: 04-1] "Still happens: https://www.dropbox.com/s/vx5iq6qa6jrxcok/Screenshot%202014-11-04%2011.32.49.png?dl=0" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 (owner: 10MarkTraceur) [10:34:36] (03CR) 10TTO: "Bump. Chris, could you have a look at my previous comment?" [core] - 10https://gerrit.wikimedia.org/r/149507 (https://bugzilla.wikimedia.org/56439) (owner: 10TTO) [10:34:44] (03CR) 10Gilles: [C: 032] Fix: "Undefined index: bandwidth" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/170867 (owner: 10Ori.livneh) [10:35:07] (03Merged) 10jenkins-bot: Fix: "Undefined index: bandwidth" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/170867 (owner: 10Ori.livneh) [10:37:10] (03Abandoned) 10Zfilipin: WIP Feature: Cache [core] - 10https://gerrit.wikimedia.org/r/144976 (owner: 10Zfilipin) [10:46:46] 3MediaWiki / 3Watchlist: Option to list only unviewed changes on watchlist - 10https://bugzilla.wikimedia.org/72937#c1 (10Andre Klapper) p:5Unprio>3Lowest What are "unviewed changes"? [10:49:19] (03CR) 10Zfilipin: [C: 04-2] "Chris, it has been a few weeks since last activity on the bug. Should this commit be merged, changed, abandoned...?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163993 (owner: 10Cmcmahon) [10:50:26] (03CR) 10Zfilipin: "What is preventing this commit from being merged into master?" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/160193 (owner: 10Mattflaschen) [10:53:05] (03CR) 10Zfilipin: [C: 04-1] "Should this commit be abandoned?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169943 (owner: 10Cmcmahon) [10:58:07] (03CR) 10Phuedx: [C: 032] Name and shame modules that still use ResourceLoaderTemplateModule [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/170813 (owner: 10Jdlrobson) [10:58:51] (03Merged) 10jenkins-bot: Name and shame modules that still use ResourceLoaderTemplateModule [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/170813 (owner: 10Jdlrobson) [11:17:44] (03PS3) 10Santhosh: Improve mt error handling and reporting [services/cxserver] - 10https://gerrit.wikimedia.org/r/170044 (owner: 10Nikerabbit) [11:17:46] (03CR) 10jenkins-bot: [V: 04-1] Improve mt error handling and reporting [services/cxserver] - 10https://gerrit.wikimedia.org/r/170044 (owner: 10Nikerabbit) [11:19:20] (03PS4) 10Santhosh: Improve mt error handling and reporting [services/cxserver] - 10https://gerrit.wikimedia.org/r/170044 (owner: 10Nikerabbit) [11:20:04] (03CR) 10Santhosh: [C: 032] Improve mt error handling and reporting [services/cxserver] - 10https://gerrit.wikimedia.org/r/170044 (owner: 10Nikerabbit) [11:20:35] (03Merged) 10jenkins-bot: Improve mt error handling and reporting [services/cxserver] - 10https://gerrit.wikimedia.org/r/170044 (owner: 10Nikerabbit) [11:24:52] (03PS2) 10Christopher Johnson (WMDE): Refactor stats functions to SprintTransaction class [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/170899 [11:26:34] (03PS1) 10Paladox: Adding message documentation [extensions/MaintenanceShell] - 10https://gerrit.wikimedia.org/r/170902 [11:26:45] (03PS2) 10Paladox: Adding message documentation [extensions/MaintenanceShell] - 10https://gerrit.wikimedia.org/r/170902 [11:28:22] (03CR) 10Christopher Johnson (WMDE): [C: 032 V: 032] Refactor stats functions to SprintTransaction class [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/170899 (owner: 10Christopher Johnson (WMDE)) [11:28:55] 3MediaWiki / 3History/Diffs: Problems with Diffs - 10https://bugzilla.wikimedia.org/72936#c1 (10Andre Klapper) (In reply to Nick Gibson from comment #0) > See > [https://en.wikipedia.org/w/index.php?title=Wikipedia:In_the_news/ > Candidates&diff=prev&oldid=632380777 this diff]. Please explain what to "see"... [11:33:16] (03CR) 10Paladox: "This is so that it can be added to translatewiki." [extensions/MaintenanceShell] - 10https://gerrit.wikimedia.org/r/170902 (owner: 10Paladox) [11:37:45] (03PS1) 10Paladox: Adding message documentation [extensions/MaintenanceShell] (REL1_24) - 10https://gerrit.wikimedia.org/r/170903 [11:38:15] (03PS1) 10Paladox: Adding message documentation [extensions/MaintenanceShell] (REL1_23) - 10https://gerrit.wikimedia.org/r/170904 [11:48:42] 3Wikimedia / 3General/Unknown: Enter in edit summary line doesn't save on ja.wiki - 10https://bugzilla.wikimedia.org/72944#c2 (10Andre Klapper) 5NEW>3RESO/INV Closing as INVALID as per comment 1 [11:48:56] 3MediaWiki / 3Page editing: Enter in edit summary does nothing when preview is forced - 10https://bugzilla.wikimedia.org/72945 (10Andre Klapper) p:5Unprio>3Normal [11:49:11] 3Wikimedia / 3General/Unknown: Write a maint. script to queue failed page moves due to LocalPageMoveJob breakage - 10https://bugzilla.wikimedia.org/72927 (10Andre Klapper) p:5Unprio>3Normal [11:57:56] 3Wikimedia / 3General/Unknown: Enter in edit summary line doesn't save on ja.wiki - 10https://bugzilla.wikimedia.org/72944#c3 (10Nemo) 5RESO/INV>3REOP (In reply to Yusuke Matsubara from comment #1) > I believe the reason behind this behavior was to prevent unintended saving, > which happens rather freque... [12:02:59] 3MediaWiki extensions / 3TitleBlacklist: User should be warned if moving a page to a blacklisted title - 10https://bugzilla.wikimedia.org/72926 (10Andre Klapper) p:5Unprio>3Low [12:02:59] 3MediaWiki / 3Parser: {{!}} always treated as literal instead of separator when the template is transcluded - 10https://bugzilla.wikimedia.org/72920 (10Andre Klapper) 5UNCO>3NEW p:5Unprio>3Low [12:06:39] (03CR) 10Henning Snater: "In general, thumbs up for the code. It is structured very well and readable (although it would benefit from additional documentation)." (0319 comments) [extensions/Teahouse] - 10https://gerrit.wikimedia.org/r/170702 (owner: 10Robert Vogel) [12:10:40] (03CR) 10Prtksxna: [C: 032] mediawiki.ui: Remove dead code from checkbox [core] - 10https://gerrit.wikimedia.org/r/170897 (owner: 10Bartosz Dziewoński) [12:10:58] 3MediaWiki / 3Configuration: wikigender.org is no longer blacklisted but is still blocked. - 10https://bugzilla.wikimedia.org/72921#c1 (10Andre Klapper) (In reply to richshup from comment #0) > 1. I verified that wikigender.org is no longer blacklisted, in the Wikimedia > blacklist (or whatever the correct n... [12:11:41] 3MediaWiki extensions / 3ParserFunctions: #expr error doesn't show non-ascii glyphs - 10https://bugzilla.wikimedia.org/72913 (10Andre Klapper) p:5Unprio>3Normal [12:22:11] 3MediaWiki extensions / 3ApiSandbox: Unparsed wikitext on [[Special:ApiSandbox]] - 10https://bugzilla.wikimedia.org/72928 (10Andre Klapper) p:5Unprio>3Normal [12:30:42] 3Wikimedia / 3Bugzilla: New component of MediaWiki for mediawiki/vendor git repository - 10https://bugzilla.wikimedia.org/72935#c2 (10Andre Klapper) 5NEW>3RESO/FIX a:3Andre Klapper Done [12:42:12] 3Wikimedia / 3General/Unknown: bits.wikimedia.org discourages indexing, resulting in goofy archive.org snapshots - 10https://bugzilla.wikimedia.org/65464#c9 (10Nemo) 5REOP>3RESO/FIX And now it looks (mostly) good again. Go figure. http://web.archive.org/web/20141104122645/http://it.wikipedia.org/wiki/Pa... [12:54:33] (03PS1) 10Christopher Johnson (WMDE): fix minor duplication issues [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/170910 [12:55:39] (03CR) 10Christopher Johnson (WMDE): [C: 032 V: 032] fix minor duplication issues [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/170910 (owner: 10Christopher Johnson (WMDE)) [13:01:33] (03PS1) 10Zfilipin: Fixed Style/SpaceAfterComma RuboCop offense [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/170911 (https://bugzilla.wikimedia.org/63307) [13:07:41] 3MediaWiki extensions / 3CirrusSearch: RegEx-style Cirrus searches are ignored on en.wikipedia - 10https://bugzilla.wikimedia.org/72894#c5 (10Nik Everett) Quick update: Step 1 is moving along pretty quickly. I'm communicating closely with a Lucene committer on getting a patch merged for this. It feels like... [13:17:48] (03PS1) 10Christopher Johnson (WMDE): removed dead $event_type from SprintQuery [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/170913 [13:18:39] (03CR) 10Christopher Johnson (WMDE): [C: 032 V: 032] removed dead $event_type from SprintQuery [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/170913 (owner: 10Christopher Johnson (WMDE)) [13:30:12] 3MediaWiki / 3General/Unknown: Record links to special pages in the data base - 10https://bugzilla.wikimedia.org/17597#c1 (10Andre Klapper) ...and quoting Brion from bug 16162: For now the special links are not being recorded. It could be useful to start recording them, but we'd want to do a few things: * N... [13:30:28] 3MediaWiki / 3Special pages: Enable "What links here" link in toolbox of special pages - 10https://bugzilla.wikimedia.org/17596 (10Andre Klapper) [13:30:28] 3MediaWiki / 3Special pages: Special pages associated with a wiki page should have "What links here" in the Tools section - 10https://bugzilla.wikimedia.org/14787 (10Andre Klapper) [13:36:56] 3MediaWiki / 3Interface: showLogExtract can produce a self link - 10https://bugzilla.wikimedia.org/19015#c1 (10Andre Klapper) (In reply to Umherirrender from comment #0) > Any logevent has a actionlink. It is unnecessary to show a actionlink to the > page itself. Please remove these actionlink. Thanks. > >... [13:38:57] 3MediaWiki extensions / 3Extensions requests: feature request - faceted browsing - 10https://bugzilla.wikimedia.org/19407#c1 (10Andre Klapper) p:5Low>3Lowest Does that refer to tables on pages? Or does that refer to page categories? [13:54:29] (03PS1) 10Christopher Johnson (WMDE): add composer.json [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/170915 [13:56:00] (03CR) 10Christopher Johnson (WMDE): [C: 032 V: 032] add composer.json [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/170915 (owner: 10Christopher Johnson (WMDE)) [14:21:26] 3Wikimedia / 3General/Unknown: Enter in edit summary line doesn't save on ja.wiki - 10https://bugzilla.wikimedia.org/72944#c4 (10Yusuke Matsubara) (In reply to Nemo from comment #3) > (In reply to Yusuke Matsubara from comment #1) > > I believe the reason behind this behavior was to prevent unintended saving... [14:26:46] (03CR) 10Reedy: Style tweaks (031 comment) [extensions/HSTS] - 10https://gerrit.wikimedia.org/r/170642 (owner: 10Reedy) [14:29:17] (03CR) 10Reedy: "Are we sticking one table in the centralauth db then?" [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170835 (owner: 10Aaron Schulz) [14:29:56] 3Wikimedia / 3Site requests: Enable automatic AbuseFilter blocking on eswikivoyage - 10https://bugzilla.wikimedia.org/62321 (10Glaisher) 5PATC>3RESO/FIX [14:32:44] (03CR) 10Reedy: "So, the API was recently i18nified, so we should really take advantage of that, rather than adding essentially old code." [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170889 (https://bugzilla.wikimedia.org/72685) (owner: 1001tonythomas) [14:36:32] (03CR) 10Reedy: [C: 04-1] "I guess this should be marked as write mode, and probably posted too?" (033 comments) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170889 (https://bugzilla.wikimedia.org/72685) (owner: 1001tonythomas) [14:37:15] (03PS1) 10Christopher Johnson (WMDE): Change composer.json [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/170920 [14:37:56] 3Wikimedia / 3General/Unknown: Enter in edit summary line doesn't save on ja.wiki - 10https://bugzilla.wikimedia.org/72944#c5 (10Andre Klapper) If anybody wants to turn this into an IME bug, please adjust the summary and component. I still consider the current summary INVALID as it's on-wiki code [14:39:34] (03PS2) 10Christopher Johnson (WMDE): Change composer.json [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/170920 [14:40:05] (03CR) 10Christopher Johnson (WMDE): [C: 032 V: 032] Change composer.json [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/170920 (owner: 10Christopher Johnson (WMDE)) [14:41:40] (03CR) 10Anomie: [C: 04-1] "I'm not terribly convinced with "Wikibase was making an assumption with respect to uselang" meaning "We can never change that!" instead of" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/170895 (owner: 10Thiemo Mättig (WMDE)) [14:43:27] (03CR) 10Bartosz Dziewoński: [WIP] ResourceLoaderImageModule for icons (035 comments) [core] - 10https://gerrit.wikimedia.org/r/165922 (owner: 10Trevor Parscal) [14:43:29] (03PS2) 10Bartosz Dziewoński: [WIP] ResourceLoaderImageModule for icons [core] - 10https://gerrit.wikimedia.org/r/165922 (owner: 10Trevor Parscal) [14:44:05] (03PS1) 10Bartosz Dziewoński: [WIP] Allow passing stdin via wfShellExec() [core] - 10https://gerrit.wikimedia.org/r/170921 [14:44:20] (03PS3) 10Bartosz Dziewoński: [WIP] ResourceLoaderImageModule for icons [core] - 10https://gerrit.wikimedia.org/r/165922 (owner: 10Trevor Parscal) [14:50:02] (03CR) 10Cmcmahon: [C: 032] Prepare repository for running RuboCop after every push to Gerrit [core] - 10https://gerrit.wikimedia.org/r/167794 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [14:52:14] (03PS3) 10Reedy: Added wgBounceHandlerCluster setting [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170835 (owner: 10Aaron Schulz) [14:53:10] (03CR) 10Anomie: Add i18n for API module help (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/169844 (owner: 10Anomie) [14:55:57] (03Merged) 10jenkins-bot: Prepare repository for running RuboCop after every push to Gerrit [core] - 10https://gerrit.wikimedia.org/r/167794 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [15:00:31] 3Wikimedia / 3General/Unknown: WMF logo in wikimedia.org should be moved to the footer - 10https://bugzilla.wikimedia.org/39842#c2 (10Glaisher) wikimedia.org's (and other [[m:project portals]]') design is managed on Meta. You can find the HTML for www.wikimedia.org at (03PS1) 10Smuggli: Added missing PLURAL distinction in message [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/170926 [15:05:12] 3MediaWiki / 3Configuration: wikigender.org is no longer blacklisted but is still blocked. - 10https://bugzilla.wikimedia.org/72921#c2 (10Sam Reed (reedy)) (In reply to Andre Klapper from comment #1) > (In reply to richshup from comment #0) > > 1. I verified that wikigender.org is no longer blacklisted, in t... [15:10:11] 3Wikimedia / 3General/Unknown: wikigender.org is no longer blacklisted but is still blocked. - 10https://bugzilla.wikimedia.org/72921#c3 (10Sam Reed (reedy)) I don't see anything in those history pages though. My quick guess is some cache wasn't invalidated when the page was saved. [15:13:49] (03CR) 10Zfilipin: "check experimental" [vagrant] - 10https://gerrit.wikimedia.org/r/168264 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [15:15:40] (03CR) 10Zfilipin: "Is there anything preventing this commit from being merged into master branch?" [vagrant] - 10https://gerrit.wikimedia.org/r/168264 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [15:16:11] 3MediaWiki / 3Database: Add el_timestamp to the externallinks table - 10https://bugzilla.wikimedia.org/72931#c2 (10Sam Reed (reedy)) (In reply to Marc A. Pelletier from comment #1) > Sounds sane; the actual cost of adding a timestamp should be essentially > nil, and I can think of a couple use cases when pat... [15:28:01] (03PS4) 1001tonythomas: Add API parameter handling details for the bounehandler API [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170889 (https://bugzilla.wikimedia.org/72685) [15:34:46] (03PS1) 10Cmcmahon: QA: date created is now a required field [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170932 [15:34:56] (03CR) 10Reedy: [C: 04-1] Add API parameter handling details for the bounehandler API (033 comments) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170889 (https://bugzilla.wikimedia.org/72685) (owner: 1001tonythomas) [15:35:20] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170932 (owner: 10Cmcmahon) [15:35:42] (03CR) 10MarkTraceur: QA: date created is now a required field (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170932 (owner: 10Cmcmahon) [15:36:02] (03Merged) 10jenkins-bot: QA: date created is now a required field [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170932 (owner: 10Cmcmahon) [15:37:21] (03CR) 10Anomie: [C: 031] "Seems to work. Not +2ing yet in case others want to review." [core] - 10https://gerrit.wikimedia.org/r/170743 (https://bugzilla.wikimedia.org/72652) (owner: 10Gilles) [15:42:05] (03CR) 10Thiemo Mättig (WMDE): "I'm not exactly sure what you are talking about. This is clearly a regression as far as I can see. The "assumption" you are talking about " [core] - 10https://gerrit.wikimedia.org/r/170895 (owner: 10Thiemo Mättig (WMDE)) [15:47:26] 3MediaWiki / 3API: list=tags output can depending on language - 10https://bugzilla.wikimedia.org/45965#c1 (10Umherirrender) 5NEW>3RESO/FIX gerrit 160798 adds a uselang parameter to the main module [15:48:55] (03CR) 10Umherirrender: "You can set the default to "user", than it should acts like a missing "uselang"." [core] - 10https://gerrit.wikimedia.org/r/170895 (owner: 10Thiemo Mättig (WMDE)) [15:50:06] (03PS5) 1001tonythomas: Add API parameter handling details for the bounehandler API [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170889 (https://bugzilla.wikimedia.org/72685) [15:50:50] Reedy: ^ Time for one more quick look at https://gerrit.wikimedia.org/r/#/c/170889/ ? [15:50:58] 3MediaWiki / 3API: uselang=user on api breaks in ULS - 10https://bugzilla.wikimedia.org/72951 (10Umherirrender) 3NEW p:3Unprio s:3normal a:3None https://en.wikipedia.org/w/api.php?uselang=user gives a error page instead of api help in the user lang. I am not sure, if this bug is in ULS or API. If y... [15:51:18] (03CR) 10Krinkle: "fixme: Did you see Hashar's comment? It wasn't replied to before merging. Also, this moves the Gemfile to the root of the repository which" [core] - 10https://gerrit.wikimedia.org/r/167794 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [15:52:38] (03CR) 10Reedy: [C: 04-1] Add API parameter handling details for the bounehandler API (032 comments) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170889 (https://bugzilla.wikimedia.org/72685) (owner: 1001tonythomas) [15:52:50] anomie: Any chance you could once over https://gerrit.wikimedia.org/r/#/c/170889/ please? [15:53:08] Reedy: I was just reviewing it now [15:53:12] :) [15:54:05] (03Abandoned) 10Krinkle: Adding message documentation [extensions/MaintenanceShell] (REL1_23) - 10https://gerrit.wikimedia.org/r/170904 (owner: 10Paladox) [15:54:10] (03Abandoned) 10Krinkle: Adding message documentation [extensions/MaintenanceShell] (REL1_24) - 10https://gerrit.wikimedia.org/r/170903 (owner: 10Paladox) [15:54:26] Reedy: once I remove getDescription(), I can remove the message key too right ? [15:54:31] (03CR) 10Krinkle: [C: 04-1] Adding message documentation (031 comment) [extensions/MaintenanceShell] - 10https://gerrit.wikimedia.org/r/170902 (owner: 10Paladox) [15:54:35] No [15:54:40] oh. ok [15:54:52] (03PS3) 10Umherirrender: Use html helpformat for paraminfo [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/168761 (https://bugzilla.wikimedia.org/72928) [15:54:55] AFAIK the api rewrite anomie did sets the description for you if the right message key exists [15:55:04] (03PS4) 10Umherirrender: Use html helpformat for paraminfo [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/168761 (https://bugzilla.wikimedia.org/72928) [15:55:09] (03PS3) 10Paladox: Adding message documentation [extensions/MaintenanceShell] - 10https://gerrit.wikimedia.org/r/170902 [15:55:51] anomie: should I wait for your review, or push in the new changeset correcting Reedy's comments ? [15:57:37] (03CR) 10Anomie: [C: 04-1] Add API parameter handling details for the bounehandler API (037 comments) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170889 (https://bugzilla.wikimedia.org/72685) (owner: 1001tonythomas) [15:57:53] tonythomas: I just submitted my review [15:58:13] (03PS4) 10Paladox: Adding message documentation [extensions/MaintenanceShell] - 10https://gerrit.wikimedia.org/r/170902 [15:58:23] (03PS5) 10Paladox: Adding message documentation [extensions/MaintenanceShell] - 10https://gerrit.wikimedia.org/r/170902 [15:58:31] anomie: thanks. checking [16:06:26] 3MediaWiki / 3Interface: showLogExtract can produce a self link - 10https://bugzilla.wikimedia.org/19015#c2 (10Umherirrender) The showLogExtract function is not used on Special:Log/delete. You have to go to https://test2.wikipedia.org/wiki/Special:Undelete/MediaWiki:Gadget-Stockphoto.css and than clicking v... [16:06:40] (03CR) 10Krinkle: "https://bugzilla.wikimedia.org/show_bug.cgi?id=72952" [vendor] - 10https://gerrit.wikimedia.org/r/170106 (owner: 10Legoktm) [16:08:40] (03CR) 10Krinkle: "The main intent of this change (don't load if disabled) is still useful, but the rest has already been done in other commits. Needs rebase" [core] - 10https://gerrit.wikimedia.org/r/156229 (owner: 10Helder.wiki) [16:09:12] 3Wikimedia / 3Site requests: Add *.wikiportret.nl to wgCopyUploadsDomains - 10https://bugzilla.wikimedia.org/72953 (10Steinsplitter) s:5normal>3enhanc [16:09:13] 3Wikimedia / 3Site requests: Add domains to $wgCopyUploadsDomains (tracking) - 10https://bugzilla.wikimedia.org/58224 (10Steinsplitter) [16:09:14] 3Wikimedia / 3Site requests: Add *.wikiportret.nl to wgCopyUploadsDomains - 10https://bugzilla.wikimedia.org/72953 (10Steinsplitter) 3NEW p:3Unprio s:3normal a:3None please add the following domain(s) to the wgCopyUploadsDomains whitelist: *.wikiportret.nl [16:11:57] hey anomie , is there an example usage in a i18n file for the {{doc-apihelp-example|bouncehandler}} type you mentioned in the review ? [16:13:09] tonythomas: mediawiki/core includes/api/i18n/qqq.json [16:13:32] oh should I have messages of the type : apihelp-query+bouncehandler-example-1 ? [16:14:14] tonythomas: Only if it's a query submodule, which it doesn't look like since it subclasses ApiBase rather than ApiQueryBase [16:14:33] true. let me check the includes/api/i18n/qqq.json [16:15:13] Also, it's not a query submodule since it's being added to $wgAPIModules rather than $wgAPIPropModules, $wgAPIListModules, or $wgAPIMetaModules. [16:16:14] (03CR) 10Chad: [C: 032] Cirrus updates for 1.23 [extensions/CirrusSearch] (REL1_23) - 10https://gerrit.wikimedia.org/r/170730 (owner: 10Manybubbles) [16:16:25] (03CR) 10Chad: [C: 032] Cirrus updates for 1.24 [extensions/CirrusSearch] (REL1_24) - 10https://gerrit.wikimedia.org/r/170754 (owner: 10Manybubbles) [16:16:40] (03Merged) 10jenkins-bot: Cirrus updates for 1.23 [extensions/CirrusSearch] (REL1_23) - 10https://gerrit.wikimedia.org/r/170730 (owner: 10Manybubbles) [16:16:55] (03Merged) 10jenkins-bot: Cirrus updates for 1.24 [extensions/CirrusSearch] (REL1_24) - 10https://gerrit.wikimedia.org/r/170754 (owner: 10Manybubbles) [16:17:18] (03PS2) 10Umherirrender: Use correct case of function ImageGallery::toHTML [core] - 10https://gerrit.wikimedia.org/r/170722 [16:17:43] (03PS2) 10Umherirrender: phpcs: The final declaration must precede the visibility declaration [core] - 10https://gerrit.wikimedia.org/r/170081 [16:18:05] anomie: and also on Lose "api.php?". The usage is wrong over there ? [16:19:05] tonythomas: The old getExamples() needed "api.php?" before the query string; the new getExamplesMessages() does not. If you see somewhere where getExamplesMessages() is having "api.php?", let me know or submit a change and add me as a reviewer. [16:19:27] (03CR) 10Krinkle: "Progress on this? I'd recommend copying bits from https://gerrit.wikimedia.org/r/#/c/162544/ into this change ID as a start (extend fronte" [core] - 10https://gerrit.wikimedia.org/r/161998 (https://bugzilla.wikimedia.org/58620) (owner: 10Prtksxna) [16:20:21] anomie: oh. true. I missed that one from Reedys CR earleir [16:20:42] (03CR) 10Umherirrender: "Should be skipped, if in debug mode to allow easier reading of the startup module in the browsers debugger." [core] - 10https://gerrit.wikimedia.org/r/168732 (owner: 10Trevor Parscal) [16:21:08] (03CR) 10Krinkle: "Migrated code looks good. Untested. FlaggedRevs maintainers: Feel free to test and merge." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/138890 (owner: 10Gerrit Patch Uploader) [16:21:31] (03PS6) 1001tonythomas: Add API parameter handling details for the bounehandler API [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170889 (https://bugzilla.wikimedia.org/72685) [16:23:01] (03CR) 10Reedy: SPECIAL CODE REVIEW BRANCH/COMMIT (031 comment) [extensions/Teahouse] - 10https://gerrit.wikimedia.org/r/170702 (owner: 10Robert Vogel) [16:24:41] anomie: Reedy ^ https://gerrit.wikimedia.org/r/#/c/170889/ :) [16:25:16] 3Wikimedia / 3Site requests: http://tools.wikimedia.pl/~odder add to whitelist - 10https://bugzilla.wikimedia.org/72897 (10Steinsplitter) 5PATC>3RESO/FIX [16:25:16] 3MediaWiki / 3API: uselang=user on api breaks in ULS - 10https://bugzilla.wikimedia.org/72951#c1 (10Brad Jorsch) It depends on whether the $context parameter to 'UserGetLanguageObject' is really supposed to be a RequestContext, or if any IContextSource implementation should be accepted. If the former, API; i... [16:25:18] 3MediaWiki / 3File management: Duplicate-archive files not detected (previously deleted files when uploading identical [SHA1] files) when file extension is upper case - 10https://bugzilla.wikimedia.org/72070#c1 (10Umherirrender) see also bug 41858 [16:25:18] (03CR) 10Reedy: SPECIAL CODE REVIEW BRANCH/COMMIT (031 comment) [extensions/Teahouse] - 10https://gerrit.wikimedia.org/r/170702 (owner: 10Robert Vogel) [16:27:26] (03PS2) 10Rush: Phab: Remove non-existing Bugzilla status from list [phabricator/tools] - 10https://gerrit.wikimedia.org/r/170705 (owner: 10Aklapper) [16:27:34] (03CR) 10Rush: [C: 032 V: 032] Phab: Remove non-existing Bugzilla status from list [phabricator/tools] - 10https://gerrit.wikimedia.org/r/170705 (owner: 10Aklapper) [16:27:56] (03CR) 10jenkins-bot: [V: 04-1] Add API parameter handling details for the bounehandler API [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170889 (https://bugzilla.wikimedia.org/72685) (owner: 1001tonythomas) [16:28:07] (03PS1) 10Smuggli: Fixed issue that a link without a label has one after roundtrip [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/170939 [16:28:13] (03PS1) 10Anomie: UserGetLanguageObject hook should accept any IContextSource [core] - 10https://gerrit.wikimedia.org/r/170940 (https://bugzilla.wikimedia.org/72951) [16:30:26] 3Wikimedia / 3Site requests: Add *.wikiportret.nl to wgCopyUploadsDomains - 10https://bugzilla.wikimedia.org/72953 (10Glaisher) p:5Unprio>3Normal [16:32:14] (03CR) 10Anomie: [C: 04-1] Add API parameter handling details for the bounehandler API (033 comments) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170889 (https://bugzilla.wikimedia.org/72685) (owner: 1001tonythomas) [16:35:01] (03PS20) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [16:37:03] (03PS7) 1001tonythomas: Add API parameter handling details for the bounehandler API [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170889 (https://bugzilla.wikimedia.org/72685) [16:38:26] 3MediaWiki / 3API: uselang=user on api breaks in ULS - 10https://bugzilla.wikimedia.org/72951 (10Nemo) [16:38:33] (03PS1) 10Christopher Johnson (WMDE): add composer.lock [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/170946 [16:39:17] (03CR) 10Christopher Johnson (WMDE): [C: 032 V: 032] add composer.lock [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/170946 (owner: 10Christopher Johnson (WMDE)) [16:40:06] (03CR) 10jenkins-bot: [V: 04-1] Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 (owner: 10MarkTraceur) [16:40:37] (03PS1) 10Anomie: Update UniversalLanguageSelector for bugfix [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170947 [16:40:44] 3MediaWiki / 3Vendor: Security review of Plancake e-mail parser library - 10https://bugzilla.wikimedia.org/72956 (10Bryan Davis) 3NEW p:3Unprio s:3normal a:3Chris Steipp Gerrit change I5cc3d2eda7188628fd016950a16ffe63c2ae6f6f proposes adding the Plancake e-mail parser library to the mediawiki/vendor... [16:41:08] (03PS21) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [16:41:13] err. tab issue [16:41:25] 3MediaWiki / 3Vendor: Security review of Plancake e-mail parser library - 10https://bugzilla.wikimedia.org/72956#c1 (10Bryan Davis) The library was already approved in https://bugzilla.wikimedia.org/show_bug.cgi?id=69099#c3 so I think this just needs to be acknowledged here for bookkeeping purposes. [16:41:28] (03PS8) 1001tonythomas: Add API parameter handling details for the bounehandler API [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170889 (https://bugzilla.wikimedia.org/72685) [16:42:03] (03PS1) 10Anomie: Update UniversalLanguageSelector for bugfix [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170948 [16:42:07] (03CR) 10Manybubbles: [C: 032 V: 032] Update UniversalLanguageSelector for bugfix [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170947 (owner: 10Anomie) [16:42:08] anomie: Reedy ^ finally ! https://gerrit.wikimedia.org/r/#/c/170889 [16:42:11] 3MediaWiki / 3Vendor: Security review of Plancake e-mail parser library - 10https://bugzilla.wikimedia.org/72956 (10Bryan Davis) p:5Unprio>3Normal [16:43:21] (03CR) 10Krinkle: [C: 04-1] [WIP] ResourceLoaderImageModule for icons (033 comments) [core] - 10https://gerrit.wikimedia.org/r/165922 (owner: 10Trevor Parscal) [16:43:26] (03CR) 10Gilles: [C: 032] Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 (owner: 10MarkTraceur) [16:44:20] (03CR) 10Manybubbles: [C: 032 V: 032] Update UniversalLanguageSelector for bugfix [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170948 (owner: 10Anomie) [16:45:44] 3Wikimedia / 3General/Unknown: WMF logo in wikimedia.org should be moved to the footer - 10https://bugzilla.wikimedia.org/39842#c3 (10Waldir) Thanks, Glaisher, I've added a comment there (and linked back to this bug for reference). [16:47:06] (03CR) 10Umherirrender: UserGetLanguageObject hook should accept any IContextSource (031 comment) [core] - 10https://gerrit.wikimedia.org/r/170940 (https://bugzilla.wikimedia.org/72951) (owner: 10Anomie) [16:48:13] 3MediaWiki extensions / 3UniversalLanguageSelector: uselang=user on api breaks in ULS - 10https://bugzilla.wikimedia.org/72951#c9 (10Brad Jorsch) 5PATC>3RESO/FIX a:3Brad Jorsch The bug itself is fixed, and was backported during the SWAT window that was conveniently still open. The doc fix for hooks.txt... [16:49:33] (03Merged) 10jenkins-bot: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 (owner: 10MarkTraceur) [16:50:00] (03PS8) 10Gilles: Move stupid DOM-bound events to OO EE syntax [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170131 (owner: 10MarkTraceur) [16:51:00] (03CR) 10Anomie: [C: 031] "Looks good. Haven't tested beyond making sure the API help looks right." [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170889 (https://bugzilla.wikimedia.org/72685) (owner: 1001tonythomas) [16:52:05] (03PS1) 10Bartosz Dziewoński: Make load.php parse in PHP 4 again [core] - 10https://gerrit.wikimedia.org/r/170949 [16:52:19] (03PS2) 10Anomie: UserGetLanguageObject hook should accept any IContextSource [core] - 10https://gerrit.wikimedia.org/r/170940 (https://bugzilla.wikimedia.org/72951) [16:53:16] (03CR) 1001tonythomas: [C: 031] "Tested in my local install. The API works as expected !" [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170889 (https://bugzilla.wikimedia.org/72685) (owner: 1001tonythomas) [16:53:18] (03CR) 10Ottomata: "Oriiii this would be so cool! We could use this to add page_id to the header. Come ooon!" [extensions/XAnalytics] - 10https://gerrit.wikimedia.org/r/157841 (owner: 10Ori.livneh) [17:00:03] is Jared about? [17:03:21] <^d|voted> werdna: I don't see him hanging out in here usually I think. [17:09:28] 3Wikimedia / 3Bugzilla: Find a way to mark a report as "needinfo" - 10https://bugzilla.wikimedia.org/36064#c26 (10Andre Klapper) p:5Normal>3Low a:5Andre Klapper>3None Unassigning - we're moving from Bugzilla to Phabricator and we will have a corresponding "Needs info" status there, see https://www.me... [17:09:35] * ebernhardson still feels weird seeing werdna now :) [17:11:29] (03CR) 10Umherirrender: [C: 032] UserGetLanguageObject hook should accept any IContextSource [core] - 10https://gerrit.wikimedia.org/r/170940 (https://bugzilla.wikimedia.org/72951) (owner: 10Anomie) [17:14:21] (03CR) 10Matthias Mullie: [C: 032] Fixed Style/SpaceAfterComma RuboCop offense [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/170911 (https://bugzilla.wikimedia.org/63307) (owner: 10Zfilipin) [17:17:11] (03CR) 10Parent5446: "Why does it "need" to parse?" [core] - 10https://gerrit.wikimedia.org/r/170949 (owner: 10Bartosz Dziewoński) [17:17:29] (03Merged) 10jenkins-bot: UserGetLanguageObject hook should accept any IContextSource [core] - 10https://gerrit.wikimedia.org/r/170940 (https://bugzilla.wikimedia.org/72951) (owner: 10Anomie) [17:17:34] (03Merged) 10jenkins-bot: Fixed Style/SpaceAfterComma RuboCop offense [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/170911 (https://bugzilla.wikimedia.org/63307) (owner: 10Zfilipin) [17:22:26] (03CR) 10Bartosz Dziewoński: "No idea. The purpose is to show a nice error message rather than fatalling out, but I can't tell why/whether we *need* to do that these da" [core] - 10https://gerrit.wikimedia.org/r/170949 (owner: 10Bartosz Dziewoński) [17:26:15] Krinkle, https://gerrit.wikimedia.org/r/#/c/138890/3/frontend/FlaggedRevsUI.setup.php looks a bit odd to me [17:27:14] Krenair: The mw.util method is deprecated, it uses accesKeyLabel directly now. And, both the old and the new method, have built-in logic for preserving or adding the " [...]" suffix to the tooltip [17:27:30] so we don't need to re-add that, it's already there, since it's not a new link but an existing button [17:27:32] Krinkle, yes, but why is it removing references to accesskey-save and adding a .updateTooltipAccessKeys() call in ext.flaggedRevs.advanced, but then in the RL modules changing messages/dependencies for ext.flaggedRevs.review instead? [17:27:50] the acceskey attribtue is already present in the DOM [17:27:57] so it doesn't need to be set again on the client-side [17:28:00] so it no longer needs accesks-save [17:28:40] I guess a better question would be why 'accesskey-save' was used by ext.flaggedRevs.advanced but in the RL module for ext.flaggedRevs.review [17:28:53] Hm.. [17:28:59] Right [17:29:02] I have no answer [17:29:25] Looks liek it's on the wrong module yeah [17:29:39] Krenair: Can you check out wha hte relation is between those two modules? Which is which loaded [17:29:40] (03CR) 10Matthias Mullie: [C: 032] "This should improve things until we have a better solutions." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170785 (https://bugzilla.wikimedia.org/72490) (owner: 10Mattflaschen) [17:29:45] we're not adding a 'jquery.accessKeyLabel' dependency to ext.flaggedRevs.review... and only using it in ext.flaggedRevs.advanced [17:29:49] (03PS9) 10EBernhardson: Bug: [DB]Mis-reporting content length [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165683 (https://bugzilla.wikimedia.org/60646) [17:29:52] (03Abandoned) 10Matthias Mullie: Anchor's toArray should produce full url [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166419 (owner: 10Matthias Mullie) [17:29:54] now adding* [17:30:31] (03Merged) 10jenkins-bot: Expand anchors to full URL on server rendering [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170785 (https://bugzilla.wikimedia.org/72490) (owner: 10Mattflaschen) [17:30:40] (03CR) 10jenkins-bot: [V: 04-1] Bug: [DB]Mis-reporting content length [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165683 (https://bugzilla.wikimedia.org/60646) (owner: 10EBernhardson) [17:32:12] (03PS1) 10Chad: Fix undefined offset in updateOneSearchIndexConfig [extensions/CirrusSearch] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170956 (https://bugzilla.wikimedia.org/72888) [17:32:35] (03PS1) 10Chad: Fix undefined offset in updateOneSearchIndexConfig [extensions/CirrusSearch] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170957 (https://bugzilla.wikimedia.org/72888) [17:32:44] Krinkle, according to frontend/FlaggedRevsUI.hooks.php, injectStyleAndJS function, ext.flaggedRevs.review is loaded only for users with the 'review' permission [17:32:51] Krinkle, ext.flaggedRevs.advanced is loaded for all users [17:32:51] (03CR) 10Chad: [C: 032] Fix undefined offset in updateOneSearchIndexConfig [extensions/CirrusSearch] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170956 (https://bugzilla.wikimedia.org/72888) (owner: 10Chad) [17:33:04] (03PS2) 10Umherirrender: Make load.php parse in PHP 4 again [core] - 10https://gerrit.wikimedia.org/r/170949 (owner: 10Bartosz Dziewoński) [17:33:08] (03Merged) 10jenkins-bot: Fix undefined offset in updateOneSearchIndexConfig [extensions/CirrusSearch] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170956 (https://bugzilla.wikimedia.org/72888) (owner: 10Chad) [17:33:30] (03CR) 10Umherirrender: [C: 032] "When this file not parsed, than the PhpVersionError cannot be shown." [core] - 10https://gerrit.wikimedia.org/r/170949 (owner: 10Bartosz Dziewoński) [17:34:28] (03CR) 10Reedy: [C: 032] Add API parameter handling details for the bounehandler API [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170889 (https://bugzilla.wikimedia.org/72685) (owner: 1001tonythomas) [17:35:26] (03CR) 10Paladox: "I have added the author now." [extensions/MaintenanceShell] - 10https://gerrit.wikimedia.org/r/170902 (owner: 10Paladox) [17:35:53] (03CR) 10Matthias Mullie: [C: 031] "Good to go after code freeze" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165426 (owner: 10EBernhardson) [17:36:04] (03CR) 10Matthias Mullie: [C: 031] "Good to go after code freeze" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165427 (owner: 10EBernhardson) [17:39:56] (03Merged) 10jenkins-bot: Make load.php parse in PHP 4 again [core] - 10https://gerrit.wikimedia.org/r/170949 (owner: 10Bartosz Dziewoński) [17:39:58] (03Merged) 10jenkins-bot: Add API parameter handling details for the bounehandler API [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170889 (https://bugzilla.wikimedia.org/72685) (owner: 1001tonythomas) [17:42:48] (03PS1) 10Chad: Profiler: Call getContentType() only once in logData() [core] - 10https://gerrit.wikimedia.org/r/170962 [17:43:57] (03CR) 10Alex Monk: [C: 04-1] "Looks like you're adding the dependency to the wrong module." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/138890 (owner: 10Gerrit Patch Uploader) [17:43:59] (03CR) 10Matthias Mullie: [C: 031] "Good to go after code freeze" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170503 (owner: 10EBernhardson) [17:48:42] 3MediaWiki extensions / 3BounceHandler: ApiBounceHandler improvements - 10https://bugzilla.wikimedia.org/72685#c5 (10Sam Reed (reedy)) 5PATC>3RESO/FIX Think this is done now... [17:49:01] (03CR) 10Reedy: Add API parameter handling details for the bounehandler API (031 comment) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170889 (https://bugzilla.wikimedia.org/72685) (owner: 1001tonythomas) [17:50:12] 3MediaWiki / 3Internationalization: Specify default language on a per-page basis - 10https://bugzilla.wikimedia.org/9360 (10Umherirrender) [17:50:19] 3MediaWiki / 3API: Add api action for Special:PageLanguage - 10https://bugzilla.wikimedia.org/72958 (10Umherirrender) 3NEW p:3Unprio s:3normal a:3None Setting $wgPageLanguageUseDB = true; $wgGroupPermissions['sysop']['pagelang'] = true; in the LocalSettings.php allows to specify another page language... [17:53:39] (03CR) 10Aaron Schulz: "I was thinking extension-1" [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170835 (owner: 10Aaron Schulz) [17:55:07] (03PS9) 10MarkTraceur: Move stupid DOM-bound events to OO EE syntax [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170131 [17:56:53] (03CR) 10Aaron Schulz: "Though instead of per-wiki tables on extension1 it really only needs to be one table. That would require more code changes." [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170835 (owner: 10Aaron Schulz) [17:57:37] (03PS1) 10Umherirrender: Select column page_lang in prop=info [core] - 10https://gerrit.wikimedia.org/r/170964 [17:58:31] (03CR) 10Reedy: "Is there any real benefit from pushing all this into extension1? The table isn't going to get that large.. is it? (In comparison to AFT et" [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170835 (owner: 10Aaron Schulz) [18:03:11] (03PS4) 10MarkTraceur: Remove reservedIndex [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170170 [18:03:56] 3MediaWiki extensions / 3Translate: Microsoft Translator not working with new authorisation model - 10https://bugzilla.wikimedia.org/44679#c4 (10Sam Reed (reedy)) (In reply to sen from comment #2) > i use chinese so the other just not work for me.i see translate.net is work > fine with bing api,but the sourc... [18:04:08] (03CR) 10Aaron Schulz: "It will be smaller if the tables are just one, without duplicates. Also there is the matter of some extra I/O. I'd rather we not just keep" [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170835 (owner: 10Aaron Schulz) [18:04:40] 3MediaWiki extensions / 3Translate: Microsoft Translator translation service errors - 10https://bugzilla.wikimedia.org/41435#c6 (10Nemo) 14.15 -rakkaus:#mediawiki-i18n- (1 lines skipped) 2014-11-04 13:15:21 translatewiki.net translatewiki_net-bw_: Translation service Microsoft problem: Http::get fa... [18:05:47] http://www.theregister.co.uk/2014/11/04/remoteie_for_osx_ios_android [18:06:54] (03PS1) 10Cmcmahon: QA: delete header test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170965 [18:07:11] 3MediaWiki / 3Interface: showLogExtract can produce a self link - 10https://bugzilla.wikimedia.org/19015#c3 (10Andre Klapper) Argh, I am sorry. Thanks, I see! [18:08:19] (03CR) 10CSteipp: [C: 032] "It might be nice if the error message said which username it was too similar to, but the basic functionality works and is useful." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/169006 (https://bugzilla.wikimedia.org/70380) (owner: 10Legoktm) [18:09:15] (03Merged) 10jenkins-bot: GlobalRenameUser: Warn if there are AntiSpoof conflicts [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/169006 (https://bugzilla.wikimedia.org/70380) (owner: 10Legoktm) [18:11:45] (03CR) 10BryanDavis: [C: 032] Profiler: Call getContentType() only once in logData() [core] - 10https://gerrit.wikimedia.org/r/170962 (owner: 10Chad) [18:11:46] 3MediaWiki extensions / 3CentralAuth: GlobalRename: check with global AntiSpoof and warn about possible collisions - 10https://bugzilla.wikimedia.org/70380 (10Chris Steipp) 5PATC>3RESO/FIX [18:14:53] (03PS1) 10Anomie: Add role for SecurePoll [vagrant] - 10https://gerrit.wikimedia.org/r/170966 [18:16:40] (03CR) 10Aaron Schulz: "In any case, separate tables on extension1 is tolerable IMO." [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170835 (owner: 10Aaron Schulz) [18:17:38] (03Merged) 10jenkins-bot: Profiler: Call getContentType() only once in logData() [core] - 10https://gerrit.wikimedia.org/r/170962 (owner: 10Chad) [18:18:44] (03PS1) 10Cscott: Update CHANGELOG. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/170968 [18:18:46] (03PS1) 10Cscott: Release 1.2.0. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/170969 [18:18:48] (03PS1) 10Cscott: Bump version after release. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/170970 [18:19:09] anomie: Are the API module help patches still WIP or just waiting for review? [18:20:29] marktraceur: For extensions? Just waiting for review. [18:21:29] (03CR) 10jenkins-bot: [V: 04-1] Update CHANGELOG. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/170968 (owner: 10Cscott) [18:21:31] (03CR) 10jenkins-bot: [V: 04-1] Bump version after release. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/170970 (owner: 10Cscott) [18:22:12] OK [18:22:14] * marktraceur reviews [18:23:32] (03CR) 10Anomie: [C: 04-1] "I'm failing to see the point of this patch. If the Title object needs the field, it should be returned by Title::getSelectFields()." [core] - 10https://gerrit.wikimedia.org/r/170964 (owner: 10Umherirrender) [18:24:11] (03CR) 10Cmcmahon: [C: 032] "merged after discussion with Erik" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170965 (owner: 10Cmcmahon) [18:25:00] (03Merged) 10jenkins-bot: QA: delete header test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170965 (owner: 10Cmcmahon) [18:28:16] (03CR) 10Anomie: "Well, ApiQueryInfo probably should be using Title::getSelectFields() if it comes down to that, instead of duplicating the logic." [core] - 10https://gerrit.wikimedia.org/r/170964 (owner: 10Umherirrender) [18:34:04] (03PS1) 10Manybubbles: Limit complexity explosion during determinization [search/extra] - 10https://gerrit.wikimedia.org/r/170973 [18:34:34] (03PS1) 10Cmcmahon: QA: forgot to change a "should" statement [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170975 [18:35:00] (03PS1) 10UltrasonicNXT: Fix bug with deleting threads [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/170976 [18:35:04] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170975 (owner: 10Cmcmahon) [18:35:11] (03CR) 10Gilles: [C: 032] Move stupid DOM-bound events to OO EE syntax [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170131 (owner: 10MarkTraceur) [18:35:18] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Fix bug with deleting threads [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/170976 (owner: 10UltrasonicNXT) [18:35:49] (03Merged) 10jenkins-bot: QA: forgot to change a "should" statement [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170975 (owner: 10Cmcmahon) [18:35:52] (03Merged) 10jenkins-bot: Move stupid DOM-bound events to OO EE syntax [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170131 (owner: 10MarkTraceur) [18:36:28] (03PS2) 10MarkTraceur: Add i18n for API module help [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/169844 (owner: 10Anomie) [18:36:59] (03CR) 10MarkTraceur: [C: 032] "Minor changes, given I pretty much directly fixed the issues I'm +2ing the rest. Thanks anomie!" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/169844 (owner: 10Anomie) [18:38:39] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/169844 (owner: 10Anomie) [18:41:22] (03PS1) 10Chad: Profiler code cleanup [core] - 10https://gerrit.wikimedia.org/r/170977 [18:42:02] (03CR) 10Legoktm: [C: 032] mw.Title: Add new static methods `newFromFileName`, `newFromUserInput` [core] - 10https://gerrit.wikimedia.org/r/131971 (https://bugzilla.wikimedia.org/64912) (owner: 10Rillke) [18:42:26] (03PS4) 10Bartosz Dziewoński: [WIP] ResourceLoaderImageModule for icons [core] - 10https://gerrit.wikimedia.org/r/165922 (owner: 10Trevor Parscal) [18:43:07] <^d|voted> lolol. [18:43:14] (03CR) 10jenkins-bot: [V: 04-1] [WIP] ResourceLoaderImageModule for icons [core] - 10https://gerrit.wikimedia.org/r/165922 (owner: 10Trevor Parscal) [18:43:16] <^d|voted> "When we upgrade to mysql 4.1, the insert+update" [18:44:04] (03CR) 10Bartosz Dziewoński: [WIP] ResourceLoaderImageModule for icons (031 comment) [core] - 10https://gerrit.wikimedia.org/r/165922 (owner: 10Trevor Parscal) [18:46:02] (03PS1) 10Cmcmahon: QA: update user strings, remove unnecessary expect clause [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170978 [18:46:29] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170978 (owner: 10Cmcmahon) [18:46:45] (03Abandoned) 10Cmcmahon: QA: update user message on delete [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169971 (owner: 10Cmcmahon) [18:47:45] 3MediaWiki extensions / 3ProofreadPage: The WikiEditor dialogs do not work in Page namespace - 10https://bugzilla.wikimedia.org/72960 (10Tpt) 3NEW p:3Unprio s:3normal a:3None WikiEditor dialogs do not work in Page namespace. Sample: https://fr.wikisource.org/w/index.php?title=Page:Champollion_-_Lett... [18:48:16] (03Merged) 10jenkins-bot: mw.Title: Add new static methods `newFromFileName`, `newFromUserInput` [core] - 10https://gerrit.wikimedia.org/r/131971 (https://bugzilla.wikimedia.org/64912) (owner: 10Rillke) [18:48:23] (03Merged) 10jenkins-bot: QA: update user strings, remove unnecessary expect clause [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170978 (owner: 10Cmcmahon) [18:49:18] (03PS1) 10Cscott: Create CHANGELOG. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/170979 [18:49:20] (03PS1) 10Cscott: Release 0.3.0. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/170980 [18:49:22] (03PS1) 10Cscott: Bump version after release. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/170981 [18:49:24] (03CR) 10MarkTraceur: [C: 04-1] "Needs a serious rebase." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/47837 (https://bugzilla.wikimedia.org/43408) (owner: 10Nischayn22) [18:49:44] (03CR) 10Umherirrender: "Title::getSelectFields is protected at the moment and not called here. It only needs return page_lang when that is really needed. In case " [core] - 10https://gerrit.wikimedia.org/r/170964 (owner: 10Umherirrender) [18:50:09] (03Abandoned) 10MarkTraceur: Use only one pad per page [extensions/EtherEditor] - 10https://gerrit.wikimedia.org/r/43100 (https://bugzilla.wikimedia.org/39424) (owner: 10SuchetaG) [18:50:15] RIP EtherEditor. [18:53:12] (03PS6) 10Paladox: Adding message documentation [extensions/MaintenanceShell] - 10https://gerrit.wikimedia.org/r/170902 [18:53:33] (03PS1) 10Cscott: Create CHANGELOG.md. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/170982 [18:53:35] (03PS1) 10Cscott: Release 0.3.0. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/170983 [18:53:37] (03PS1) 10Cscott: Bump version after release. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/170984 [18:54:56] (03PS1) 10Cscott: Create CHANGELOG.md [extensions/Collection/OfflineContentGenerator/zim_renderer] - 10https://gerrit.wikimedia.org/r/170986 [18:55:15] (03CR) 10jenkins-bot: [V: 04-1] Create CHANGELOG.md [extensions/Collection/OfflineContentGenerator/zim_renderer] - 10https://gerrit.wikimedia.org/r/170986 (owner: 10Cscott) [18:55:48] (03PS2) 10Chad: Profiler code cleanup [core] - 10https://gerrit.wikimedia.org/r/170977 [18:56:43] (03CR) 10jenkins-bot: [V: 04-1] Profiler code cleanup [core] - 10https://gerrit.wikimedia.org/r/170977 (owner: 10Chad) [18:58:36] (03PS1) 10Cscott: Release 1.0.0. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/170989 [18:58:38] (03PS1) 10Cscott: Bump version after release. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/170990 [18:59:46] (03CR) 10Cscott: "recheck" [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/170968 (owner: 10Cscott) [19:00:20] (03CR) 10Cscott: "recheck" [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/170970 (owner: 10Cscott) [19:01:56] (03CR) 10Cscott: [C: 032 V: 032] Create CHANGELOG.md [extensions/Collection/OfflineContentGenerator/zim_renderer] - 10https://gerrit.wikimedia.org/r/170986 (owner: 10Cscott) [19:02:38] (03CR) 10Gilles: [C: 032] "If it breaks someone's workflow, I'm sure we'll hear about it." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170170 (owner: 10MarkTraceur) [19:02:47] (03CR) 10jenkins-bot: [V: 04-1] Create CHANGELOG.md [extensions/Collection/OfflineContentGenerator/zim_renderer] - 10https://gerrit.wikimedia.org/r/170986 (owner: 10Cscott) [19:03:07] (03PS3) 10Chad: Profiler code cleanup [core] - 10https://gerrit.wikimedia.org/r/170977 [19:03:14] (03Merged) 10jenkins-bot: Remove reservedIndex [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170170 (owner: 10MarkTraceur) [19:04:40] 3MediaWiki / 3Internationalization: Special:PageLanguage does not tag page html output correctly - 10https://bugzilla.wikimedia.org/72940#c1 (10Umherirrender) getViewPageLanguage vs. getPageLanguage For the lang in the header it is using getViewPageLanguage which does not use the page_lang field. The textar... [19:04:52] (03CR) 10Legoktm: [C: 032] Add i18n for API module help [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/169814 (owner: 10Anomie) [19:05:13] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/169814 (owner: 10Anomie) [19:05:47] (03CR) 10Legoktm: [C: 032] Add i18n for API module help [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/169806 (owner: 10Anomie) [19:08:39] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/169806 (owner: 10Anomie) [19:08:59] ori: How the hell do I install d8? [19:09:05] (03CR) 10Kji: [C: 032 V: 032] Initial commit for the HierarchyBuilder extension. [extensions/HierarchyBuilder] - 10https://gerrit.wikimedia.org/r/168192 (owner: 10Kji) [19:09:13] The lazyweb suggests that there is no good way to do it other than building v8 from source [19:11:30] building v8 from source isn't so bad [19:11:37] much easier than building chromium from source [19:12:04] I haven't even found good instructions to download the source yet [19:12:19] Something about git-svn that looks like mid-migration crap [19:13:11] RoanKattouw: https://github.com/preillyme/v8js#compile-latest-v8 i wrote that [19:13:42] of course, it was a little while ago, it might have rotted slightly. but that should be basically right still. [19:13:57] (03CR) 10Legoktm: [C: 032] Add i18n for API module help [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/169831 (owner: 10Anomie) [19:14:13] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/169831 (owner: 10Anomie) [19:14:15] (03CR) 10Legoktm: [C: 032] Add i18n for API module help [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/169836 (owner: 10Anomie) [19:14:29] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/169836 (owner: 10Anomie) [19:15:12] (03PS12) 10SG: JS sanity per Krinkle's patch [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166951 [19:15:15] (03PS7) 10SG: J-2a Affix board navigation to viewport top on scroll [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167059 [19:15:18] (03PS13) 10SG: J2f - Add minimal topic list API for TOC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169310 (owner: 10Mattflaschen) [19:15:21] (03PS3) 10SG: J-2a.II Current topic title in affixed board nav [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169531 [19:15:24] (03PS16) 10SG: J-2e Remove all collapsing functionality [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166727 [19:15:27] (03PS1) 10SG: Add component to api callback info object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170997 [19:15:30] (03PS1) 10SG: Introduce include-offset option to pager [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170998 [19:15:33] (03PS1) 10SG: J-2d.III Load more revamp and jumpTo support [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170999 [19:15:36] (03PS1) 10SG: [WIP] J-2b & J-2d.IV Implement TOC on front-end [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171000 [19:15:42] ... wut... [19:16:15] (03CR) 10jenkins-bot: [V: 04-1] JS sanity per Krinkle's patch [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166951 (owner: 10SG) [19:16:18] (03PS1) 10Umherirrender: Simplify Special:Undelete link from navigation [core] - 10https://gerrit.wikimedia.org/r/171001 [19:16:29] (03PS3) 10Daniel Kinzler: Revert uselang=... default to the wikis $wgLanguageCode [core] - 10https://gerrit.wikimedia.org/r/170895 (owner: 10Thiemo Mättig (WMDE)) [19:16:31] (03CR) 10jenkins-bot: [V: 04-1] J2f - Add minimal topic list API for TOC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169310 (owner: 10Mattflaschen) [19:16:47] (03CR) 10jenkins-bot: [V: 04-1] J-2e Remove all collapsing functionality [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166727 (owner: 10SG) [19:16:51] (03CR) 10jenkins-bot: [V: 04-1] J-2a.II Current topic title in affixed board nav [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169531 (owner: 10SG) [19:17:06] (03CR) 10jenkins-bot: [V: 04-1] Add component to api callback info object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170997 (owner: 10SG) [19:17:31] (03CR) 10jenkins-bot: [V: 04-1] J-2d.III Load more revamp and jumpTo support [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170999 (owner: 10SG) [19:17:39] (03CR) 10jenkins-bot: [V: 04-1] [WIP] J-2b & J-2d.IV Implement TOC on front-end [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171000 (owner: 10SG) [19:18:51] (03CR) 10Daniel Kinzler: "@Umherirrender: yes, but ALL client code has to do that now. This is a pretty massive breaking change. And inconsistent to the behavior of" [core] - 10https://gerrit.wikimedia.org/r/170895 (owner: 10Thiemo Mättig (WMDE)) [19:20:20] (03PS1) 10Legoktm: ApiAddStudents: Use ApiBase::PARAM_ISMULTI [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/171003 [19:20:41] (03CR) 10Legoktm: Add i18n for API module help (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/169814 (owner: 10Anomie) [19:22:05] (03CR) 10Jforrester: [C: 031] "Per Tim; Chris, do you want to +2?" [core] - 10https://gerrit.wikimedia.org/r/170593 (https://bugzilla.wikimedia.org/72887) (owner: 10Bartosz Dziewoński) [19:22:26] 3OCG / 3General/Unknown: More specific logging - 10https://bugzilla.wikimedia.org/71242#c1 (10C. Scott Ananian) 5NEW>3RESO/FIX Fixed with latest deploy. [19:22:58] (03CR) 10Daniel Kinzler: "@anomie: Wikibase made no assumptions wrt uselang. Wikibase makes assumptions about $wgLang resp. IContextSource::getLanguage." [core] - 10https://gerrit.wikimedia.org/r/170895 (owner: 10Thiemo Mättig (WMDE)) [19:26:05] (03CR) 10Anomie: "Parameter docs should be updated to remove "separated by a \"|\".", since adding PARAM_ISMULTI will cause the API to add text to that effe" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/171003 (owner: 10Legoktm) [19:26:26] (03CR) 10Daniel Kinzler: [C: 031] "didn't test this, but looks good now" [core] - 10https://gerrit.wikimedia.org/r/166143 (https://bugzilla.wikimedia.org/71916) (owner: 10Cacycle) [19:26:51] (03PS2) 10Legoktm: ApiAddStudents: Use ApiBase::PARAM_ISMULTI [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/171003 [19:28:29] 3MediaWiki / 3Internationalization: Special:PageLanguage permission checks: Allow pagelang changes when edit protected? - 10https://bugzilla.wikimedia.org/72965 (10Umherirrender) 3NEW p:3Unprio s:3normal a:3None When a page is edit protected it is not possible to delete the page without the necessary... [19:30:05] (03PS1) 10EBernhardson: K4: add links so new topic notifications are linked from Special:Notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171005 [19:30:08] (03CR) 10Anomie: [C: 031] "Looks good. Haven't tested beyond checking the help output." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/171003 (owner: 10Legoktm) [19:30:19] (03PS2) 10SG: J-2d.III Load more revamp and jumpTo support [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170999 [19:30:23] (03PS2) 10SG: Introduce include-offset option to pager [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170998 [19:30:25] (03PS2) 10SG: Add component to api callback info object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170997 [19:30:28] (03PS13) 10SG: JS sanity per Krinkle's patch [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166951 [19:30:31] (03PS8) 10SG: J-2a Affix board navigation to viewport top on scroll [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167059 [19:30:35] (03PS14) 10SG: J2f - Add minimal topic list API for TOC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169310 (owner: 10Mattflaschen) [19:30:38] (03PS2) 10SG: [WIP] J-2b & J-2d.IV Implement TOC on front-end [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171000 [19:30:41] (03PS4) 10SG: J-2a.II Current topic title in affixed board nav [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169531 [19:30:44] (03PS17) 10SG: J-2e Remove all collapsing functionality [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166727 [19:31:09] (03CR) 10jenkins-bot: [V: 04-1] J-2d.III Load more revamp and jumpTo support [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170999 (owner: 10SG) [19:31:29] (03CR) 10jenkins-bot: [V: 04-1] Introduce include-offset option to pager [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170998 (owner: 10SG) [19:32:11] 3MediaWiki / 3Internationalization: Specify default language on a per-page basis - 10https://bugzilla.wikimedia.org/9360 (10Umherirrender) [19:32:11] 3MediaWiki / 3Internationalization: Special:PageLanguage permission checks: Allow pagelang changes when edit protected? - 10https://bugzilla.wikimedia.org/72965 (10Umherirrender) [19:32:12] (03CR) 10jenkins-bot: [V: 04-1] J2f - Add minimal topic list API for TOC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169310 (owner: 10Mattflaschen) [19:32:33] (03CR) 10jenkins-bot: [V: 04-1] J-2e Remove all collapsing functionality [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166727 (owner: 10SG) [19:32:57] (03CR) 10SG: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170998 (owner: 10SG) [19:33:05] (03CR) 10jenkins-bot: [V: 04-1] [WIP] J-2b & J-2d.IV Implement TOC on front-end [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171000 (owner: 10SG) [19:35:14] (03CR) 10CSteipp: [C: 032] Correctly parse contents, Parser rejiggering [core] - 10https://gerrit.wikimedia.org/r/170593 (https://bugzilla.wikimedia.org/72887) (owner: 10Bartosz Dziewoński) [19:35:42] 3MediaWiki / 3Internationalization: Specify default language on a per-page basis - 10https://bugzilla.wikimedia.org/9360 (10Umherirrender) [19:35:44] 3MediaWiki / 3Internationalization: Use better default values on Special:PageLanguage - 10https://bugzilla.wikimedia.org/72966 (10Umherirrender) 3NEW p:3Unprio s:3normal a:3None When Special:PageLanguage gets opened for a page which already has a page lang set, than "Select language" should be select... [19:35:53] (03CR) 10Aaron Schulz: [C: 032] API: Split list=deletedrevs into prop=deletedrevisions and list=alldeletedrevisions [core] - 10https://gerrit.wikimedia.org/r/168646 (https://bugzilla.wikimedia.org/23489) (owner: 10Anomie) [19:36:07] (03CR) 10Aaron Schulz: [C: 032] Removed obsolete TODO comment [services/jobrunner] - 10https://gerrit.wikimedia.org/r/170871 (owner: 10Aaron Schulz) [19:36:11] (03Merged) 10jenkins-bot: Removed obsolete TODO comment [services/jobrunner] - 10https://gerrit.wikimedia.org/r/170871 (owner: 10Aaron Schulz) [19:37:48] (03PS1) 10Jforrester: Correctly parse contents, Parser rejiggering [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/171010 (https://bugzilla.wikimedia.org/72887) [19:38:11] (03PS1) 10Jforrester: Correctly parse contents, Parser rejiggering [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/171011 (https://bugzilla.wikimedia.org/72887) [19:38:51] (03CR) 10Mattflaschen: "Yes, I believe so." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169943 (owner: 10Cmcmahon) [19:41:29] (03Merged) 10jenkins-bot: Correctly parse contents, Parser rejiggering [core] - 10https://gerrit.wikimedia.org/r/170593 (https://bugzilla.wikimedia.org/72887) (owner: 10Bartosz Dziewoński) [19:41:33] (03CR) 10jenkins-bot: [V: 04-1] API: Split list=deletedrevs into prop=deletedrevisions and list=alldeletedrevisions [core] - 10https://gerrit.wikimedia.org/r/168646 (https://bugzilla.wikimedia.org/23489) (owner: 10Anomie) [19:42:26] i really hope that doesn't break anything else. [19:42:41] MatmaRex: Indeed. :-) [19:42:48] Do the tests pass? [19:42:55] ;D [19:43:00] Reedy: They do, and it adds new tests, but… :-) [19:43:05] lolol [19:45:09] (03PS1) 10PleaseStand: WikiPage::selectFields(): Do not include page_counter [core] - 10https://gerrit.wikimedia.org/r/171013 [19:47:17] (03PS1) 10Chad: DumpHTML: Minor code fixes [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/171014 [19:47:57] (03PS2) 10Reedy: Fixup missing parameters and undefined variables [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/144149 [19:47:59] (03CR) 10Mattflaschen: "This is probably testable via ViewTopicListTest (maybe chained on top of the TOC API patch), right?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170998 (owner: 10SG) [19:48:50] YuviPanda: Wanna review/merge https://gerrit.wikimedia.org/r/144149 ? [19:51:17] 3Wikimedia / 3Language setup: Localization of word invoke in urwiki - 10https://bugzilla.wikimedia.org/72967 (10Muhammad Shuaib) 3UNCO p:3Unprio s:3normal a:3None Hi, plz localize the magic word #invoke which is used in module templates for urdu wikipedia as #استدعا [19:52:40] 3MediaWiki / 3Internationalization: Localization of word invoke in urwiki - 10https://bugzilla.wikimedia.org/72967#c1 (10Sam Reed (reedy)) p:5Unprio>3Normal s:5normal>3enhanc You can do this at https://translatewiki.net/w/i.php?language=ur&module=words&title=Special%3AAdvancedTranslate [19:54:11] 3MediaWiki / 3Internationalization: Localization of word invoke in urwiki - 10https://bugzilla.wikimedia.org/72967#c2 (10Sam Reed (reedy)) Can you confirm this diff is correct? https://translatewiki.net/w/i.php?title=MediaWiki:Sp-translate-data-MagicWords/ur&diff=prev&oldid=5848042 [19:56:41] 3MediaWiki / 3Internationalization: Use better default values on Special:PageLanguage - 10https://bugzilla.wikimedia.org/72966 (10Sam Reed (reedy)) s:5normal>3enhanc [19:56:45] 3MediaWiki / 3API: Add api action for Special:PageLanguage - 10https://bugzilla.wikimedia.org/72958 (10Sam Reed (reedy)) s:5normal>3enhanc [19:59:11] (03PS4) 10Anomie: API: Split list=deletedrevs into prop=deletedrevisions and list=alldeletedrevisions [core] - 10https://gerrit.wikimedia.org/r/168646 (https://bugzilla.wikimedia.org/23489) [20:02:10] (03PS5) 10Anomie: API: Split list=deletedrevs into prop=deletedrevisions and list=alldeletedrevisions [core] - 10https://gerrit.wikimedia.org/r/168646 (https://bugzilla.wikimedia.org/23489) [20:08:23] In a fight between wgNamespaceRobotPolicies and wgContentNamespaces, which wins? [20:08:29] (03CR) 10BryanDavis: "Erik said something to me on irc that has me rethinking this approach a bit. Rather than adding to the signature of the wf*Log functions I" [core] - 10https://gerrit.wikimedia.org/r/141599 (owner: 10BryanDavis) [20:08:31] Yes. [20:09:44] Reedy: Helpful. :-P [20:12:24] (03CR) 10Andrew Bogott: [C: 031] Fixup missing parameters and undefined variables [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/144149 (owner: 10Reedy) [20:13:02] (03CR) 10Aaron Schulz: [C: 032] WikiPage::selectFields(): Do not include page_counter [core] - 10https://gerrit.wikimedia.org/r/171013 (owner: 10PleaseStand) [20:16:17] (03CR) 10Aaron Schulz: [C: 032] API: Split list=deletedrevs into prop=deletedrevisions and list=alldeletedrevisions [core] - 10https://gerrit.wikimedia.org/r/168646 (https://bugzilla.wikimedia.org/23489) (owner: 10Anomie) [20:16:29] (03PS1) 10Cmcmahon: QA: fix typo that made step pending by accident [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171025 [20:16:52] Reedy: Well, https://gerrit.wikimedia.org/r/#/c/171024/ is one way to find out… [20:17:00] (03CR) 10Cmcmahon: [C: 032] "fix typo" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171025 (owner: 10Cmcmahon) [20:17:28] (03CR) 10jenkins-bot: [V: 04-1] QA: fix typo that made step pending by accident [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171025 (owner: 10Cmcmahon) [20:19:04] (03Merged) 10jenkins-bot: WikiPage::selectFields(): Do not include page_counter [core] - 10https://gerrit.wikimedia.org/r/171013 (owner: 10PleaseStand) [20:19:25] (03CR) 10Cmcmahon: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171025 (owner: 10Cmcmahon) [20:19:38] (03CR) 10Cmcmahon: [V: 032] "force" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171025 (owner: 10Cmcmahon) [20:22:06] (03Merged) 10jenkins-bot: API: Split list=deletedrevs into prop=deletedrevisions and list=alldeletedrevisions [core] - 10https://gerrit.wikimedia.org/r/168646 (https://bugzilla.wikimedia.org/23489) (owner: 10Anomie) [20:23:27] 3MediaWiki / 3API: Allow namespace filter for list=deletedrevs&druser - 10https://bugzilla.wikimedia.org/27193 (10Brad Jorsch) 5PATC>3RESO/FIX [20:23:31] 3MediaWiki / 3Page deletion: Implement ability to get page title of a deleted revision by its rev_id (and use it!) - 10https://bugzilla.wikimedia.org/23489 (10Brad Jorsch) 5PATC>3RESO/FIX [20:23:40] 3MediaWiki / 3API: Add format and model to list=deletedrevs - 10https://bugzilla.wikimedia.org/44190 (10Brad Jorsch) 5PATC>3RESO/FIX [20:23:42] 3MediaWiki / 3API: Add revid handling (revids=, drstartid= and drendid=) to list=deletedrevs - 10https://bugzilla.wikimedia.org/71396 (10Brad Jorsch) 5PATC>3RESO/FIX [20:23:57] 3MediaWiki / 3API: action=query&list=deletedrevs with a new-style continuation fails - 10https://bugzilla.wikimedia.org/71389 (10Brad Jorsch) 5PATC>3RESO/FIX [20:24:43] (03PS15) 10EBernhardson: J2f - Add minimal topic list API for TOC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169310 (owner: 10Mattflaschen) [20:24:57] (03CR) 10EBernhardson: [C: 032] J2f - Add minimal topic list API for TOC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169310 (owner: 10Mattflaschen) [20:25:41] (03PS3) 10EBernhardson: [WIP] J-2b & J-2d.IV Implement TOC on front-end [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171000 (owner: 10SG) [20:25:46] (03Merged) 10jenkins-bot: J2f - Add minimal topic list API for TOC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169310 (owner: 10Mattflaschen) [20:26:36] (03CR) 10jenkins-bot: [V: 04-1] [WIP] J-2b & J-2d.IV Implement TOC on front-end [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171000 (owner: 10SG) [20:27:05] (03PS1) 10Foxtrott: Enable coverage reporting for Scrutinizer [skins/chameleon] - 10https://gerrit.wikimedia.org/r/171031 [20:28:32] (03CR) 10Anomie: [C: 032] "Ugh. I hate the duplication of field-lists between the two methods, but fine." [core] - 10https://gerrit.wikimedia.org/r/170964 (owner: 10Umherirrender) [20:28:34] (03PS5) 10Bartosz Dziewoński: [WIP] ResourceLoaderImageModule for icons [core] - 10https://gerrit.wikimedia.org/r/165922 (owner: 10Trevor Parscal) [20:29:07] (03CR) 10Foxtrott: [C: 032 V: 032] Enable coverage reporting for Scrutinizer [skins/chameleon] - 10https://gerrit.wikimedia.org/r/171031 (owner: 10Foxtrott) [20:29:09] (03CR) 10jenkins-bot: [V: 04-1] [WIP] ResourceLoaderImageModule for icons [core] - 10https://gerrit.wikimedia.org/r/165922 (owner: 10Trevor Parscal) [20:33:02] (03PS6) 10Bartosz Dziewoński: [WIP] ResourceLoaderImageModule for icons [core] - 10https://gerrit.wikimedia.org/r/165922 (owner: 10Trevor Parscal) [20:33:19] (03PS1) 10Ssmith: update form settings to allow for WorldPay tests [core] (fundraising/REL1_23) - 10https://gerrit.wikimedia.org/r/171032 [20:35:06] (03Merged) 10jenkins-bot: Select column page_lang in prop=info [core] - 10https://gerrit.wikimedia.org/r/170964 (owner: 10Umherirrender) [20:35:08] (03CR) 10SG: "force" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170999 (owner: 10SG) [20:35:50] (03CR) 10SG: [C: 04-1] "Yeah, I'll update this to add the tests, and in turn modify your patch to support this in testing." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170998 (owner: 10SG) [20:37:29] (03CR) 10Ejegg: [C: 04-1] "Want to put them in the if (enableWorldPay) block like they were in this other patch? https://gerrit.wikimedia.org/r/#/c/169539/2/Donation" [core] (fundraising/REL1_23) - 10https://gerrit.wikimedia.org/r/171032 (owner: 10Ssmith) [20:40:02] (03CR) 10Chad: [C: 032] Fix undefined offset in updateOneSearchIndexConfig [extensions/CirrusSearch] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170957 (https://bugzilla.wikimedia.org/72888) (owner: 10Chad) [20:40:22] (03PS1) 10Chad: Updating CirrusSearch to pull in I1d8c13cb [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/171034 [20:40:26] (03Merged) 10jenkins-bot: Fix undefined offset in updateOneSearchIndexConfig [extensions/CirrusSearch] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170957 (https://bugzilla.wikimedia.org/72888) (owner: 10Chad) [20:42:04] (03PS1) 10Chad: Updating CirrusSearch to pull in I1d8c13cb [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/171035 [20:42:51] (03CR) 10Manybubbles: [C: 031] "thanks!" [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/171035 (owner: 10Chad) [20:43:04] (03CR) 10Manybubbles: [C: 031] "thanks!" [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/171034 (owner: 10Chad) [20:50:31] (03CR) 10UltrasonicNXT: [C: 032 V: 032] "Cheers :)" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/168009 (owner: 10Jack Phoenix) [20:50:58] 3Wikimedia / 3Extension setup: Deploy WikiGrok extension to test, test2, and en.wiki - 10https://bugzilla.wikimedia.org/72465 (10Ryan Kaldari) 5PATC>3RESO/FIX [20:53:30] (03PS4) 10BryanDavis: Profiler code cleanup [core] - 10https://gerrit.wikimedia.org/r/170977 (owner: 10Chad) [21:00:44] (03PS1) 10Foxtrott: Fix travis setup to avoid pcre 8.34 incompatibility [skins/chameleon] - 10https://gerrit.wikimedia.org/r/171036 [21:01:07] (03CR) 10Foxtrott: [C: 032 V: 032] Fix travis setup to avoid pcre 8.34 incompatibility [skins/chameleon] - 10https://gerrit.wikimedia.org/r/171036 (owner: 10Foxtrott) [21:06:22] (03PS1) 10Chad: wfDebugLog(): remove unused global [core] - 10https://gerrit.wikimedia.org/r/171037 [21:09:57] (03CR) 10Bartosz Dziewoński: "The use case is the same." [core] - 10https://gerrit.wikimedia.org/r/154227 (https://bugzilla.wikimedia.org/40322) (owner: 10Helder.wiki) [21:10:59] (03CR) 10Chad: [C: 032] Use MWLogger logging for wfLogProfilingData [core] - 10https://gerrit.wikimedia.org/r/119942 (owner: 10BryanDavis) [21:11:06] (03CR) 10Legoktm: [C: 032] wfDebugLog(): remove unused global [core] - 10https://gerrit.wikimedia.org/r/171037 (owner: 10Chad) [21:12:03] (03CR) 10BryanDavis: [C: 031] "The code changes look sane to me, but I'm not sure about the change in behavior. The old code had a lot of cruft, but it did selectively e" [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/171014 (owner: 10Chad) [21:13:36] (03Abandoned) 10SG: [WIP] J-2b & J-2d.IV Implement TOC on front-end [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171000 (owner: 10SG) [21:14:30] (03CR) 10Reedy: "We haven't used DumpHTML on the cluster in quite a while..." [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/171014 (owner: 10Chad) [21:14:53] (03PS5) 10BryanDavis: Profiler code cleanup [core] - 10https://gerrit.wikimedia.org/r/170977 (owner: 10Chad) [21:15:04] (03CR) 10BryanDavis: [C: 032] Profiler code cleanup [core] - 10https://gerrit.wikimedia.org/r/170977 (owner: 10Chad) [21:16:23] (03PS2) 10Ori.livneh: Initial commit [extensions/XAnalytics] - 10https://gerrit.wikimedia.org/r/157841 [21:17:20] (03CR) 10Chad: "Based on current config, it would remove profiling--but per Reedy, we've not been running this so it's probably no big deal." [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/171014 (owner: 10Chad) [21:17:22] (03Merged) 10jenkins-bot: Use MWLogger logging for wfLogProfilingData [core] - 10https://gerrit.wikimedia.org/r/119942 (owner: 10BryanDavis) [21:17:27] qchris: sorry for the (huge) delay. Addressed your comments in . [21:17:32] (03Merged) 10jenkins-bot: wfDebugLog(): remove unused global [core] - 10https://gerrit.wikimedia.org/r/171037 (owner: 10Chad) [21:17:41] ori awesome. [21:17:44] thanks. [21:18:16] qchris: my idea is that we'd change mobilefrontend to use the hook that is introduced by the extension ("XAnalyticsSetHeader"), and then set $wmgMFEnableXAnalyticsLogging to false. [21:19:20] sounds good. [21:21:35] (03PS1) 10Chad: Deprecate Profiler::setInstance() [core] - 10https://gerrit.wikimedia.org/r/171044 [21:21:41] (03Merged) 10jenkins-bot: Profiler code cleanup [core] - 10https://gerrit.wikimedia.org/r/170977 (owner: 10Chad) [21:22:08] (03PS1) 10Foxtrott: Fix travis build script [skins/chameleon] - 10https://gerrit.wikimedia.org/r/171045 [21:22:41] (03CR) 10Foxtrott: [C: 032 V: 032] Fix travis build script [skins/chameleon] - 10https://gerrit.wikimedia.org/r/171045 (owner: 10Foxtrott) [21:23:29] (03CR) 10Chad: [C: 032] Add i18n for API module help [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/169807 (owner: 10Anomie) [21:23:49] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/169807 (owner: 10Anomie) [21:24:58] Reedy, ^d|voted: It doesn't work anyway with current trunk :/ -- Fatal error: Cannot access protected property LocalRepo::$thumbScriptUrl in /vagrant/mediawiki/extensions/DumpHTML/dumpHTML.inc on line 1163 [21:25:32] <^d|voted> Well yeah, that's known it's pretty busted. [21:25:37] bd808: Is your code out of date? [21:25:48] Oh, wait [21:25:49] https://gerrit.wikimedia.org/r/#/c/157504/ [21:25:51] It's just not merged [21:26:01] I fixed this a while ago [21:26:26] Reedy: Ah. neat [21:26:35] Please feel free to +2 it ;) [21:26:39] I just noticed this though [21:26:40] lmao, I just saw qgil's reply to that sugar labs email. hilarious. [21:26:40] 628 628 » » $this->copyDirectory( "$IP/skins/vector", "{$this->dest}/skins/vector" ); [21:26:40] 629 629 » » $this->copyDirectory( "$IP/skins/monobook", "{$this->dest}/skins/monobook" ); [21:26:40] 630 630 » » $this->copyDirectory( "$IP/skins/common", "{$this->dest}/skins/common" ); [21:26:40] 631 631 » » $this->copyDirectory( "{$this->extdir}/skin", "{$this->dest}/skins/offline" ); [21:26:43] So more broken stuff [21:27:07] yeah. It needs to check for skins now instead of assuming [21:27:38] But that's a different issue :) [21:28:17] (03CR) 10BryanDavis: [C: 032] "Per Chad and Sam the change in behavior shouldn't be a problem. The command can be run with --profile=text or the user can configure a pro" [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/171014 (owner: 10Chad) [21:28:19] (03Merged) 10jenkins-bot: DumpHTML: Minor code fixes [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/171014 (owner: 10Chad) [21:28:43] (03PS4) 10BryanDavis: Fix access to protected properties [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/157504 (owner: 10Physikerwelt) [21:29:42] (03CR) 10Chad: [C: 032] Support empty DB names in LoadBalancer more fully [core] - 10https://gerrit.wikimedia.org/r/170870 (owner: 10Aaron Schulz) [21:29:43] 3MediaWiki extensions / 3DumpHTML: Skins have moved... May not exist in core folder - 10https://bugzilla.wikimedia.org/72981 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3normal a:3None https://github.com/wikimedia/mediawiki-extensions-DumpHTML/blob/master/dumpHTML.inc#L628-L631 Skins are explicitly copie... [21:33:18] (03PS1) 10Foxtrott: Fix travis build script [skins/chameleon] - 10https://gerrit.wikimedia.org/r/171048 [21:33:38] (03CR) 10Foxtrott: [C: 032 V: 032] Fix travis build script [skins/chameleon] - 10https://gerrit.wikimedia.org/r/171048 (owner: 10Foxtrott) [21:35:39] (03Merged) 10jenkins-bot: Support empty DB names in LoadBalancer more fully [core] - 10https://gerrit.wikimedia.org/r/170870 (owner: 10Aaron Schulz) [21:35:41] (03CR) 10Chad: "Actually, since dumpHTML was the only caller ever, core or anywhere else, I'm inclined to just remove this." [core] - 10https://gerrit.wikimedia.org/r/171044 (owner: 10Chad) [21:44:08] (03PS1) 10Anomie: API: Make uselang=user the default [core] - 10https://gerrit.wikimedia.org/r/171050 [21:44:14] (03PS1) 10Foxtrott: Fix travis build script [skins/chameleon] - 10https://gerrit.wikimedia.org/r/171051 [21:44:24] (03CR) 10Foxtrott: [C: 032 V: 032] Fix travis build script [skins/chameleon] - 10https://gerrit.wikimedia.org/r/171051 (owner: 10Foxtrott) [21:44:53] Reedy: DumpHTML is whack-a-mole with problems. No ProcessCacheLRU() in the proxy RepoGroup first. Now Cannot access protected property ThumbnailImage::$file/ [21:45:13] Does anybody use this with master? I'm guessing not [21:45:15] bd808: it's just broken. [21:45:22] no one uses it [21:45:29] legoktm: I was tricked into looking at it [21:45:39] * bd808 shakes fist at ^d|voted [21:45:47] bd808: https://www.mediawiki.org/wiki/Extension:DumpHTML#Beware.2C_cowboy.21 [21:45:56] lol [21:46:08] I think physikerwelt_ was trying to get it working.. [21:46:32] gwicke: These are the wacky drawings I made, which caused me to rethink what the use cases for branching might be... http://www.mediawiki.org/wiki/Requests_for_comment/Branching#UI_changes [21:46:38] "Very brave PHP developers willing to fix dumpHTML should probably plan some weeks of work on it" lolol [21:47:00] DumpHTML... That POS. I tricked myself into working on it, at one point... [21:47:30] I think it was being used by Kiwix, but they migrated to Parsoid output. [21:47:35] (03CR) 10Kaldari: "I agree this should probably be reverted at least until the breakage can be fixed. The mobile web interface also has breakage due to the c" [core] - 10https://gerrit.wikimedia.org/r/170895 (owner: 10Thiemo Mättig (WMDE)) [21:48:27] awight: thanks for the link! [21:49:30] bd808: I have an interest in resurrecting HTML dumps, but also prefer to base them on Parsoid output [21:49:31] gwicke: Pau Giner did some much more in-depth mockups for the Drafts feature, hopefully he puts those online! [21:50:24] bd808: there's https://github.com/gwicke/htmldumper, which does a full dump against the current Parsoid API; takes ~7 hours on the first run, and about two in subsequent runs (it reuses downloaded articles that haven't changed) [21:50:35] (numbers for enwiki) [21:50:51] should get faster with restbase [21:50:55] (03CR) 10BryanDavis: [C: 032] "This is slightly less broken. The next problems I found in the whack-a-mole list:" [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/157504 (owner: 10Physikerwelt) [21:50:57] (03Merged) 10jenkins-bot: Fix access to protected properties [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/157504 (owner: 10Physikerwelt) [21:51:42] * bd808 wipes mud off of his face and looks for something more productive to work on [21:52:35] (03PS4) 10Spage: Support Parsoid on private wikis [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170869 (owner: 10EBernhardson) [21:53:43] (03PS2) 10Ssmith: update form settings to allow for WorldPay tests [core] (fundraising/REL1_23) - 10https://gerrit.wikimedia.org/r/171032 [21:56:10] (03PS2) 10Chad: Remove Profiler::setInstance() [core] - 10https://gerrit.wikimedia.org/r/171044 [21:56:33] awight: some of the wireframes look more like annotations on steroids [21:58:01] (03PS5) 10MarkTraceur: Move showTooManyFilesWarning to the wizard object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170343 [21:58:04] maybe the stable ID stuff the parsoid folks are working on could come in handy for that: https://www.mediawiki.org/wiki/Parsoid/MediaWiki_DOM_spec/Element_IDs [21:58:12] (03PS1) 10BryanDavis: Call RepoGroup constructor for subclass [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/171053 [21:58:13] gwicke: yeah... having diverging articles sounded terrible... Probably best to keep differences inline until there's some kind of agreement that they should be split out. At that point, it seems to make sense that they are associated with something in the mother article :) [21:58:14] (03PS6) 10MarkTraceur: Move a global starting handler out of uwu [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170349 [21:58:21] (03PS6) 10MarkTraceur: Move global remove handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170350 [21:58:24] (03PS1) 10Foxtrott: Documentation fixes [skins/chameleon] - 10https://gerrit.wikimedia.org/r/171054 [21:58:35] (03CR) 10Foxtrott: [C: 032 V: 032] Documentation fixes [skins/chameleon] - 10https://gerrit.wikimedia.org/r/171054 (owner: 10Foxtrott) [21:58:42] gwicke: oh definitely, thanks for adding those anchors! [21:59:06] it's not fully implemented yet afaik [21:59:12] but underway [21:59:46] well that's still much further along than branching... [22:01:05] yeah; we need it for more pedestrian things first, so it's going to happen [22:01:13] (03PS3) 10BryanDavis: Remove Profiler::setInstance() [core] - 10https://gerrit.wikimedia.org/r/171044 (owner: 10Chad) [22:01:26] (03CR) 10BryanDavis: [C: 032] Remove Profiler::setInstance() [core] - 10https://gerrit.wikimedia.org/r/171044 (owner: 10Chad) [22:05:51] (03PS7) 10Awight: Componentize Title permissions logic [core] - 10https://gerrit.wikimedia.org/r/166357 [22:06:15] OuKB: merged your fatalmonitor patch! [22:06:43] (03CR) 10jenkins-bot: [V: 04-1] Componentize Title permissions logic [core] - 10https://gerrit.wikimedia.org/r/166357 (owner: 10Awight) [22:07:51] (03Merged) 10jenkins-bot: Remove Profiler::setInstance() [core] - 10https://gerrit.wikimedia.org/r/171044 (owner: 10Chad) [22:09:08] (03PS10) 10BryanDavis: Enable profiling via xhprof [core] - 10https://gerrit.wikimedia.org/r/168930 [22:10:15] kaldari: could you possibly review https://gerrit.wikimedia.org/r/171055 ? [22:11:42] YuviPanda, thanks! :) [22:12:29] (03CR) 10Jforrester: [C: 032] "Per I88f3d049." [extensions/Math] - 10https://gerrit.wikimedia.org/r/170710 (owner: 10Esanders) [22:12:43] (03PS4) 10Jforrester: VisualEditor: Add selection restriction to command [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/170709 (owner: 10Esanders) [22:12:49] (03CR) 10Jforrester: [C: 032] "Per I88f3d049." [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/170709 (owner: 10Esanders) [22:13:00] (03PS4) 10Jforrester: VisualEditor: Add selection restriction to command [extensions/Math] - 10https://gerrit.wikimedia.org/r/170710 (owner: 10Esanders) [22:13:53] (03Merged) 10jenkins-bot: VisualEditor: Add selection restriction to command [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/170709 (owner: 10Esanders) [22:14:56] 3MediaWiki / 3Patrolling: Moved paged cannot be verified - 10https://bugzilla.wikimedia.org/64254#c6 (10Andyrom75) Another case on this page: https://it.wikivoyage.org/wiki/Baghdad No one can take this bug in charge after 6 months? [22:17:04] (03PS3) 10Ori.livneh: Initial commit [extensions/XAnalytics] - 10https://gerrit.wikimedia.org/r/157841 [22:18:45] (03CR) 10Ori.livneh: "MobileFrontend will respect an existing header value as of Id22eaf5dc" [extensions/XAnalytics] - 10https://gerrit.wikimedia.org/r/157841 (owner: 10Ori.livneh) [22:21:07] (03PS2) 10Jforrester: Revert "Add SVG versions of toolbar icons" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/168821 (https://bugzilla.wikimedia.org/35342) (owner: 10TheDJ) [22:21:28] (03CR) 10Jforrester: [C: 032] "Let's land this for now for damage avoidance, and then we'll fix up the icons and try again in the follow-ups." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/168821 (https://bugzilla.wikimedia.org/35342) (owner: 10TheDJ) [22:21:32] (03Merged) 10jenkins-bot: Revert "Add SVG versions of toolbar icons" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/168821 (https://bugzilla.wikimedia.org/35342) (owner: 10TheDJ) [22:22:32] (03CR) 10Jforrester: [C: 032] "Dear jenkins…" [extensions/Math] - 10https://gerrit.wikimedia.org/r/170710 (owner: 10Esanders) [22:23:23] (03PS8) 10Awight: Componentize Title permissions logic [core] - 10https://gerrit.wikimedia.org/r/166357 [22:23:38] (03CR) 10Awight: "PS8: trixy rebase" [core] - 10https://gerrit.wikimedia.org/r/166357 (owner: 10Awight) [22:23:51] (03Merged) 10jenkins-bot: VisualEditor: Add selection restriction to command [extensions/Math] - 10https://gerrit.wikimedia.org/r/170710 (owner: 10Esanders) [22:24:18] (03CR) 10Awight: Componentize Title permissions logic (036 comments) [core] - 10https://gerrit.wikimedia.org/r/166357 (owner: 10Awight) [22:24:32] (03CR) 10jenkins-bot: [V: 04-1] Componentize Title permissions logic [core] - 10https://gerrit.wikimedia.org/r/166357 (owner: 10Awight) [22:24:51] (03CR) 10Kaldari: [C: 04-1] "I'd like to get a designer to sign off on this before it is merged." [core] - 10https://gerrit.wikimedia.org/r/165256 (owner: 10Jdlrobson) [22:26:26] (03PS3) 10Jdlrobson: Cleanup mw ui checkbox margins [core] - 10https://gerrit.wikimedia.org/r/170876 (https://bugzilla.wikimedia.org/72727) [22:31:46] (03CR) 10Kaldari: "Discussed this with Jared and he thinks this is a bad idea. He also thinks we should remove the existing mw-ui-block class on the links in" [core] - 10https://gerrit.wikimedia.org/r/165256 (owner: 10Jdlrobson) [22:33:30] (03CR) 10Ejegg: [C: 032] update form settings to allow for WorldPay tests [core] (fundraising/REL1_23) - 10https://gerrit.wikimedia.org/r/171032 (owner: 10Ssmith) [22:36:33] (03PS1) 10Matthias Mullie: Remove unused autoExpand animationtime [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171140 [22:36:36] (03PS1) 10Matthias Mullie: Get rid of .offset() undefined error [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171141 [22:43:42] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (b38d485723) [core] - 10https://gerrit.wikimedia.org/r/171144 [22:43:49] can someone with a checkout of all the wmf extensions grep them all for recursiveTagParse and tell me which ones use it? [22:44:07] I've got every extension in our repo checked out... [22:44:34] jackmcbarn: you can also use github search... [22:44:54] it's running [22:44:58] YuviPanda: is that reliable? i've always been wary of indexed searches screwing things up [22:45:06] (03CR) 10Alex Monk: [C: 032] Update OOjs UI to v0.1.0-pre (b38d485723) [core] - 10https://gerrit.wikimedia.org/r/171144 (owner: 10Jforrester) [22:45:11] hmm, that's true, I don't know how reliable it is [22:46:52] jackmcbarn: http://p.defau.lt/?EOKecsxFUHOE6WYREDh0yQ [22:47:46] Not that many are WMF deployed [22:47:49] SF is probably the worst [22:48:01] oh, duh [22:48:06] i have a checkout of just wmf extensions [22:48:06] ffs [22:49:45] jackmcbarn: http://p.defau.lt/?CoyV3e3RiJDja5bRxuoBRQ [22:50:34] Reedy: thanks! [22:50:49] (03PS1) 10Matthias Mullie: Fix undoing topic moderation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171146 [22:51:13] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (b38d485723) [core] - 10https://gerrit.wikimedia.org/r/171144 (owner: 10Jforrester) [23:01:10] * qgil never loses a chance (ref Sugar Labs) [23:01:20] shahyar, ^^^ [23:01:48] (03Abandoned) 10Aklapper: Add initial version of Phabricator Greasemonkey triage script [phabricator/tools] - 10https://gerrit.wikimedia.org/r/157021 (owner: 10Aklapper) [23:05:32] OuKB: mind if I cherry-pick the X-Analytics change to the prod branches? [23:06:24] is it so urgent even though XAnalytics isn't even merget yet alone deployed? :P [23:06:45] OuKB: do you want to merge it? :) [23:06:59] waaah [23:07:12] (03PS4) 10Bartosz Dziewoński: Cleanup mw ui checkbox margins [core] - 10https://gerrit.wikimedia.org/r/170876 (https://bugzilla.wikimedia.org/72727) (owner: 10Jdlrobson) [23:08:52] (03CR) 10Bartosz Dziewoński: [C: 031] "I actually removed that weird 18px margin in a separate changeset today, so the commit message here got out-of-date. If the issue is still" [core] - 10https://gerrit.wikimedia.org/r/170876 (https://bugzilla.wikimedia.org/72727) (owner: 10Jdlrobson) [23:09:09] (03PS2) 10Ori.livneh: API: Make uselang=user the default [core] - 10https://gerrit.wikimedia.org/r/171050 (owner: 10Anomie) [23:09:24] (03CR) 10Ori.livneh: [C: 032] API: Make uselang=user the default [core] - 10https://gerrit.wikimedia.org/r/171050 (owner: 10Anomie) [23:14:30] (03CR) 10Spage: "I tried the stack of patches with this top-most on http://flow-tests.wmflabs.org/wiki/Talk:Sandbox I noticed some issues mostly with the " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170999 (owner: 10SG) [23:15:49] (03Merged) 10jenkins-bot: API: Make uselang=user the default [core] - 10https://gerrit.wikimedia.org/r/171050 (owner: 10Anomie) [23:16:20] (03CR) 10EBernhardson: [C: 032] "WFM" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171146 (owner: 10Matthias Mullie) [23:17:13] (03Merged) 10jenkins-bot: Fix undoing topic moderation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171146 (owner: 10Matthias Mullie) [23:20:51] (03CR) 10EBernhardson: [C: 032] Remove unused autoExpand animationtime [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171140 (owner: 10Matthias Mullie) [23:21:47] (03Merged) 10jenkins-bot: Remove unused autoExpand animationtime [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171140 (owner: 10Matthias Mullie) [23:27:27] (03PS9) 10Awight: Componentize Title permissions logic [core] - 10https://gerrit.wikimedia.org/r/166357 [23:39:37] (03CR) 10EBernhardson: [C: 032] "WFM" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171141 (owner: 10Matthias Mullie) [23:40:24] (03Merged) 10jenkins-bot: Get rid of .offset() undefined error [extensions/Flow] - 10https://gerrit.wikimedia.org/r/171141 (owner: 10Matthias Mullie) [23:43:12] 3MediaWiki extensions / 3DataTransfer: First {{ and last }} escaped when editing a field with Special:ImportCSV - 10https://bugzilla.wikimedia.org/72992 (10Nemo) 3NEW p:3Unprio s:3minor a:3Yaron Koren These two edits are generated by perfectly equivalent CSV rows: http://wikipapers.referata.com/w/ind... [23:50:08] (03PS2) 10EBernhardson: Bug: prevent floats from breaking out of topic summary [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168492 [23:50:58] superm401: Anything else on https://gerrit.wikimedia.org/r/#/c/162194/ ? [23:51:21] (03CR) 10EBernhardson: [C: 032] Throw correct exception when failing to contact Parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169710 (owner: 10Matthias Mullie) [23:53:27] (03CR) 10EBernhardson: "i think we could instead just do reference updates from DeferredUpdates?" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169711 (https://bugzilla.wikimedia.org/70148) (owner: 10Matthias Mullie) [23:53:52] (03PS6) 10Jdlrobson: Drop ResourceLoaderTemplateModule and mw.mantle.template [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/168233 [23:53:56] (03CR) 10jenkins-bot: [V: 04-1] Drop ResourceLoaderTemplateModule and mw.mantle.template [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/168233 (owner: 10Jdlrobson) [23:54:02] prtksxna, no. It looks good, but I haven't tested yet. I would probably test while I'm writing the WikimediaEvents part. [23:54:11] (03PS3) 10EBernhardson: QA: reuse "When I have created a Flow topic" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166946 (owner: 10Spage) [23:54:28] superm401: Cool [23:54:31] (03CR) 10EBernhardson: [C: 032] "re-apply cmcmahon +2" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166946 (owner: 10Spage) [23:58:07] (03CR) 10EBernhardson: [C: 04-1] "needs rebase" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164245 (owner: 10Spage) [23:59:41] 3MediaWiki / 3Internationalization: Localization of word invoke in urwiki - 10https://bugzilla.wikimedia.org/72967#c3 (10Muhammad Shuaib) Ohh thanks, yes this is correct :-) [23:59:41] (03CR) 10Chad: [C: 032] Updating CirrusSearch to pull in I1d8c13cb [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/171034 (owner: 10Chad) [23:59:47] (03CR) 10Chad: [C: 032] Updating CirrusSearch to pull in I1d8c13cb [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/171035 (owner: 10Chad)