[00:00:43] 3MediaWiki extensions / 3Math: Don't cache render errors & support regular action=purge - 10https://bugzilla.wikimedia.org/72537#c6 (10physikerwelt) See MathRenderer.php l 520 ff // TODO: Figure out if ?action=purge // $action = $request->getText('action'); //always returns '' // unti... [00:05:12] 3MediaWiki extensions / 3Math: Math support in Flow seems to be broken - 10https://bugzilla.wikimedia.org/70516#c1 (10physikerwelt) Can you give an URL? [00:11:16] (03PS1) 10Physikerwelt: Remove Undesired spaces after math expressions [extensions/Math] - 10https://gerrit.wikimedia.org/r/170644 (https://bugzilla.wikimedia.org/72806) [00:19:11] 3Wikimedia / 3General/Unknown: Remove null constraints on workflow_user_* fields of flow_workflow table in preparation for removal - 10https://bugzilla.wikimedia.org/72842#c1 (10Sean Pringle) 5NEW>3RESO/FIX Done. [00:39:52] (03PS1) 10Anomie: Add periods to some move-related error messages [core] - 10https://gerrit.wikimedia.org/r/170645 [00:45:44] 3Wikimedia / 3Site requests: Unblock IP ranges for Habib University - 10https://bugzilla.wikimedia.org/72893 (10Matthew Bowker) 3NEW p:3Unprio s:3normal a:3None In reference to [[ticket:2014110310000241]], Habib University requests the removal of the Account Creation limits for the following IP range... [00:53:27] 3Wikimedia / 3Site requests: Unblock IP ranges for Habib University - 10https://bugzilla.wikimedia.org/72893#c1 (10Sam Reed (reedy)) That's quite a few IP addresses. What projects? Having read the ticket, it would seem they should be ok to specify a rough deadline for this exemption. Presumably at most a c... [00:54:59] 3MediaWiki extensions / 3CirrusSearch: RegEx-style Cirrus searches are ignored on en.wikipedia - 10https://bugzilla.wikimedia.org/72894 (10SpontaneousGrumbler) 3UNCO p:3Unprio s:3normal a:3None A search for "wyoming"insource:/wyoming/ should find only lower-case examples, but over 45,000 articles, mo... [00:57:57] 3MediaWiki / 3Unit tests: Unit tests in FormatJsonTest fail - 10https://bugzilla.wikimedia.org/72778#c7 (10Bryan Davis) (In reply to Tim Landscheidt from comment #6) > Interestingly, while this has silenced the Jenkins tests, the change has > introduced failures in the same spots with Travis CI's HHVM: The c... [00:58:42] 3Wikimedia / 3Site requests: Unblock IP ranges for Habib University - 10https://bugzilla.wikimedia.org/72893 (10Sam Reed (reedy)) p:5Unprio>3Normal s:5normal>3enhanc [01:03:27] 3Wikimedia / 3Site requests: Unblock IP ranges for Habib University - 10https://bugzilla.wikimedia.org/72893#c2 (10jeremyb) not a crazy number of IPa but it is a lot of blocks. (its essentially a /26 + a /29) I think we've done a /24 before? I haven't read the ticket yet. [01:05:29] 3MediaWiki / 3Unit tests: Unit tests in FormatJsonTest fail - 10https://bugzilla.wikimedia.org/72778 (10Bryan Davis) 5RESO/FIX>3REOP a:3Bryan Davis [01:34:12] 3MediaWiki extensions / 3Scribunto: Lua error in mw.html.lua - 10https://bugzilla.wikimedia.org/72880#c5 (10Jackmcbarn) A lot of templates from enwiki require you to use the latest version of MediaWiki (and extensions) to work properly. Note that the latest stable version is always several months behind this... [01:42:55] (03CR) 10Springle: [C: 031] "Bug done." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170503 (owner: 10EBernhardson) [02:03:13] (03PS1) 10Jackmcbarn: Set the correct error source from mw.html [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/170648 [02:30:56] (03CR) 10Jackmcbarn: [C: 031] "If nobody objects for a few days, I'll merge." [core] - 10https://gerrit.wikimedia.org/r/143220 (owner: 10Reedy) [03:12:17] (03CR) 10Mr. Stradivarius: [C: 031] "Looks fine to me. Note that this is pretty much what Gerrit 145547 does as well." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/170648 (owner: 10Jackmcbarn) [03:14:21] (03CR) 10Jackmcbarn: "Ah, I forgot about that one. If you want to rebase it, I'll take another look at it and probably merge it." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/170648 (owner: 10Jackmcbarn) [03:20:49] (03CR) 10Mr. Stradivarius: "(That's change If9cf9a52bd4b1bb42cc7f9f1f1096828710cbc52.)" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/170648 (owner: 10Jackmcbarn) [03:21:46] (03CR) 10Jackmcbarn: "I meant I forgot about it until you said that. Anyway, can you rebase it? (You'll need to do it manually since there's conflicts.)" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/170648 (owner: 10Jackmcbarn) [03:22:17] (03CR) 10Mr. Stradivarius: "I hosed my vagrant installation, which is why I never got round to doing it, but I'll try and get that done today or tomorrow." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/170648 (owner: 10Jackmcbarn) [03:29:56] 3MediaWiki extensions / 3CirrusSearch: RegEx-style Cirrus searches are ignored on en.wikipedia - 10https://bugzilla.wikimedia.org/72894#c1 (10Chad H.) Yes, they're disabled for the time being as they were causing downtime. [03:34:07] (03CR) 10Pastakhov: "This is the right place for definitions NS_* constants, but there is a comment and a proposal to make it easier for all NS_ * constants." (031 comment) [extensions/PhpTagsWiki] - 10https://gerrit.wikimedia.org/r/170571 (owner: 10JoelKP) [03:44:11] 3Wikimedia / 3Site requests: Unblock IP ranges for Habib University - 10https://bugzilla.wikimedia.org/72893#c3 (10Matthew Bowker) Response from the user: Currently, the university has 113 students. They would ask for the window to be re-opened at the beginning of each academic year to allow their new stude... [03:50:11] 3MediaWiki / 3File management: .htaccess causing problems! - 10https://bugzilla.wikimedia.org/72868#c4 (10Bawolff (Brian Wolff)) (In reply to Andre Klapper from comment #1) > Thanks for taking the time to report this! > > https://releases.wikimedia.org/mediawiki/1.23/mediawiki-1.23.6.tar.gz does > not inclu... [03:52:11] 3MediaWiki / 3JavaScript: Edit on double click: Try to target background (not inputs, etc) - 10https://bugzilla.wikimedia.org/72891#c1 (10This, that and the other (TTO)) Probably get rid of FORM and put some other form field elements, such as BUTTON, TEXTAREA, SELECT.... If you wish to contribute a patch, i... [04:11:27] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own commit" [xowa] - 10https://gerrit.wikimedia.org/r/164891 (owner: 10Gnosygnu) [04:42:24] (03CR) 10Csersoft: [C: 04-1] "$wp = new WikiPage( $this->title );" [core] - 10https://gerrit.wikimedia.org/r/144411 (https://bugzilla.wikimedia.org/17212) (owner: 10Florianschmidtwelzow) [04:48:10] (03PS1) 10Pastakhov: add NS_* constants (v 1.5.0) [extensions/PhpTagsWiki] - 10https://gerrit.wikimedia.org/r/170651 [04:48:36] (03CR) 10Jackmcbarn: "Huh?" [core] - 10https://gerrit.wikimedia.org/r/144411 (https://bugzilla.wikimedia.org/17212) (owner: 10Florianschmidtwelzow) [04:49:35] (03CR) 10Pastakhov: "please see Change-Id: 0fc30fa07baaef5f320f535b0425400e50e0df6b" [extensions/PhpTagsWiki] - 10https://gerrit.wikimedia.org/r/170571 (owner: 10JoelKP) [04:51:09] (03CR) 10Pastakhov: "* Change-Id: I0fc30fa07baaef5f320f535b0425400e50e0df6b" [extensions/PhpTagsWiki] - 10https://gerrit.wikimedia.org/r/170571 (owner: 10JoelKP) [05:15:15] (03CR) 10BryanDavis: "> Doesn't seem to work. Still gets a blank HTTP 200 with apache/php error log. This time for MWLogger not being found." [core] - 10https://gerrit.wikimedia.org/r/170274 (https://bugzilla.wikimedia.org/72777) (owner: 10BryanDavis) [05:17:02] (03CR) 10Florianschmidtwelzow: [C: 04-1] Add new Magic Word USEDISPLAYTITLE (031 comment) [core] - 10https://gerrit.wikimedia.org/r/144411 (https://bugzilla.wikimedia.org/17212) (owner: 10Florianschmidtwelzow) [05:32:20] (03PS1) 10Mooeypoo: [wip] Adding paramOrder widget to TemplateData editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/170655 [05:32:56] (03CR) 10jenkins-bot: [V: 04-1] [wip] Adding paramOrder widget to TemplateData editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/170655 (owner: 10Mooeypoo) [05:43:39] (03CR) 10Mattflaschen: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169310 (owner: 10Mattflaschen) [05:50:12] 3MediaWiki extensions / 3CirrusSearch: RegEx-style Cirrus searches are ignored on en.wikipedia - 10https://bugzilla.wikimedia.org/72894#c2 (10SpontaneousGrumbler) And how were the users of WP notified that the feature was turned off? How long is "the time being"? [06:00:13] 3MediaWiki / 3Parser: tag hook contents are not parsed correctly (symptoms: links replaced with comments, list syntax not parsed, strip markers) - 10https://bugzilla.wikimedia.org/72887#c6 (10Andre Klapper) Is that something to backport to 1.25wmf6 before group1 is deployed on Tuesday? Was the... [06:00:13] 3Wikimedia / 3General/Unknown: Next wmf deployment (tracking) - 10https://bugzilla.wikimedia.org/38865 (10Andre Klapper) [06:00:58] 3MediaWiki / 3Parser: tag hook contents are not parsed correctly (symptoms: links replaced with comments, list syntax not parsed, strip markers) - 10https://bugzilla.wikimedia.org/72887 (10Andre Klapper) [06:00:58] 3Wikimedia / 3General/Unknown: Next wmf deployment (tracking) - 10https://bugzilla.wikimedia.org/38865 (10Andre Klapper) [06:20:26] 3Wikimedia / 3General/Unknown: php5-common-5.3.10-1ubuntu3 .15+wmf1 is incompatible with Ubuntu Trusty's php5-common - 10https://bugzilla.wikimedia.org/72793#c1 (10Andre Klapper) Where is this problem exposed / how to reproduce? Where would you use php5-common-5.3.10-1ubuntu3.15+wmf1 instead of the default p... [06:20:28] (03PS1) 10Nemo bis: Revert translations by Paladox [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/170658 [06:20:43] (03PS1) 10Nemo bis: Revert translations by Paladox [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/170659 [06:27:26] 3MediaWiki / 3Database: SQL syntax errors with PostgreSQL installation - 10https://bugzilla.wikimedia.org/72834 (10Andre Klapper) p:5Unprio>3Normal [06:30:27] 3MediaWiki / 3User login and signup: "Reset your password" link should come after the password box - 10https://bugzilla.wikimedia.org/53929 (10Andre Klapper) [06:31:27] 3MediaWiki / 3General/Unknown: wmfLoadInitialiseSettings - 10https://bugzilla.wikimedia.org/50473#c10 (10Andre Klapper) (This ticket was already closed on June 30 hence no need to add such comments.) [06:31:41] 3MediaWiki / 3JavaScript: Edit on double click: Try to target background (not inputs, etc) - 10https://bugzilla.wikimedia.org/72891 (10Andre Klapper) p:5Unprio>3Low [06:35:11] 3MediaWiki / 3General/Unknown: .htaccess in tarball causing problems - 10https://bugzilla.wikimedia.org/72868#c5 (10Andre Klapper) 5RESO/INV>3REOP p:5Unprio>3Low bawolff: Ah, thanks for correcting me! Was only looking for top-level. [06:35:25] 3MediaWiki / 3General/Unknown: .htaccess in tarball causing problems - 10https://bugzilla.wikimedia.org/72868 (10Andre Klapper) 5REOP>3UNCO [06:44:42] 3MediaWiki / 3General/Unknown: TitleMoveComplete hook is broken after (ac53e4503) - 10https://bugzilla.wikimedia.org/72870#c1 (10Andre Klapper) Ic5026384b92a0d68d628397ffe1de6e5b6183f02 [06:44:56] Does anyone know if Jenkins runs PHPUnit tests in parallel (i.e. two different tests hitting the database at the same time)? [06:45:25] 3MediaWiki / 3General/Unknown: TitleMoveComplete hook is broken after (ac53e4503) - 10https://bugzilla.wikimedia.org/72870 (10Andre Klapper) [06:47:41] 3MediaWiki / 3Parser: RTL/bidirectional issues (tracking) - 10https://bugzilla.wikimedia.org/745 (10Andre Klapper) [06:47:41] 3MediaWiki / 3Parser: Table of contents doesn't account for HTML tags - 10https://bugzilla.wikimedia.org/72884 (10Andre Klapper) p:5Unprio>3Normal [06:50:57] 3MediaWiki / 3Interface: Extra scrollbars on custom skin in 1.25wmf branches - 10https://bugzilla.wikimedia.org/72821#c8 (10Andre Klapper) p:5Low>3Lowest See comment 4 for which info is needed here. [06:53:26] 3MediaWiki extensions / 3CirrusSearch: RegEx-style Cirrus searches are ignored on en.wikipedia - 10https://bugzilla.wikimedia.org/72894#c3 (10Andre Klapper) https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_%28technical%29&oldid=632239801#Search_for_special_chars mentions it. [06:56:55] superm401: they shouldn't be hitting the same database. [06:57:41] legoktm, thanks. I realized I didn't clarify. I meant different tests for the same Gerrit change. [06:58:09] legoktm, do you know if it runs multiple tests for the same change/Gerrit number in parallel? [07:00:18] no, it shouldn't be [07:00:41] legoktm, thanks, just a possibility I was considering for why a change is failing on Jenkins, but passing locally. [07:00:55] 3MediaWiki / 3Watchlist: Watchlist should show individual uploads to watched files on the Commons - 10https://bugzilla.wikimedia.org/72811 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc [07:00:55] and if you upload a new PS and then +2 it right away, it'll be doing both the +2 jobs and the gate-and-submit jobs, but they should have their own workspaces and different sqlite dbs [07:04:06] (03CR) 10Santhosh: [C: 032] Add hi-ur and ur-hi language pairs to config [services/cxserver] - 10https://gerrit.wikimedia.org/r/170292 (owner: 10KartikMistry) [07:04:11] 3MediaWiki / 3Templates: mr-wikibooks requests support for Template:Random Subpage - 10https://bugzilla.wikimedia.org/72878#c1 (10Andre Klapper) 5NEW>3RESO/INV Sorry but this is out of scope for Bugzilla as it's about on-wiki templates. Furthermore, if it's not working on mr.wikibooks.org, please provid... [07:04:36] (03Merged) 10jenkins-bot: Add hi-ur and ur-hi language pairs to config [services/cxserver] - 10https://gerrit.wikimedia.org/r/170292 (owner: 10KartikMistry) [07:08:37] (03CR) 10Santhosh: Improve mt error handling and reporting (031 comment) [services/cxserver] - 10https://gerrit.wikimedia.org/r/170044 (owner: 10Nikerabbit) [07:52:53] (03CR) 10Santhosh: [C: 04-1] Improve mt error handling and reporting (031 comment) [services/cxserver] - 10https://gerrit.wikimedia.org/r/170044 (owner: 10Nikerabbit) [07:58:57] 3MediaWiki / 3Special pages: Add option to exclude included/templated pages from Special:Lonelypages - 10https://bugzilla.wikimedia.org/11271#c1 (10Andre Klapper) Is there a specific example for a template inclusion on some Wikimedia site that this request could be (re)tested with? [08:05:40] 3MediaWiki / 3Special pages: enable namespace inversion (&invert=1) for other special: pages - 10https://bugzilla.wikimedia.org/14485#c8 (10Andre Klapper) (In reply to Charlotte Webb from comment #0) > Contributions > Watchlist > Whatlinkshere Those three are already covered in specific bug reports, see the... [08:06:41] 3MediaWiki / 3Interface: Special:UserContributions styling problems on mobile due to inline styles - 10https://bugzilla.wikimedia.org/48544#c3 (10Andre Klapper) (In reply to Jon from comment #0) > The Special:Contributions page has some styling issues > > https://en.m.wikipedia.org/wiki/Special:Contribution... [08:07:25] 3MediaWiki / 3Special pages: Add talk/no talk namespace filters to Special:Contributions - 10https://bugzilla.wikimedia.org/11499 (10Andre Klapper) [08:07:27] 3MediaWiki / 3Special pages: multiple-namespace filtering on Special:Contributions (instead of a dropdown) - 10https://bugzilla.wikimedia.org/11265 (10Andre Klapper) [08:07:27] 3MediaWiki / 3Special pages: enable namespace inversion (&invert=1) for other special: pages - 10https://bugzilla.wikimedia.org/14485 (10Andre Klapper) [08:08:56] 3MediaWiki extensions / 3Popups: Hovercards: disable NavigationPopups (Gadget) if Hovercards Beta Feature is enabled - 10https://bugzilla.wikimedia.org/62952#c9 (10Prateek Saxena) I need help resolving this bug. I am unable to understand the order in which things are executing, though the order should not be... [08:21:47] (03CR) 10Frédéric Wang: [C: 032] Remove Undesired spaces after math expressions [extensions/Math] - 10https://gerrit.wikimedia.org/r/170644 (https://bugzilla.wikimedia.org/72806) (owner: 10Physikerwelt) [08:22:53] (03Merged) 10jenkins-bot: Remove Undesired spaces after math expressions [extensions/Math] - 10https://gerrit.wikimedia.org/r/170644 (https://bugzilla.wikimedia.org/72806) (owner: 10Physikerwelt) [08:27:53] (03CR) 10Raimond Spekking: [C: 032] Revert translations by Paladox [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/170658 (owner: 10Nemo bis) [08:27:58] (03Merged) 10jenkins-bot: Revert translations by Paladox [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/170658 (owner: 10Nemo bis) [08:28:00] (03CR) 10Raimond Spekking: [C: 032] Revert translations by Paladox [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/170659 (owner: 10Nemo bis) [08:28:08] (03Merged) 10jenkins-bot: Revert translations by Paladox [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/170659 (owner: 10Nemo bis) [08:29:33] thanks Raymond_ ; please warn me before you do today's export, I still need to rollback him on the wiki [08:37:04] Nemo_bis: ok [08:37:26] 3MediaWiki / 3File management: Ability to give a reason when deleting old image revision - 10https://bugzilla.wikimedia.org/7535#c6 (10Andre Klapper) 5PATC>3RESO/FIX Closing again per comment 3 - comment 5 was a mistake. [08:41:40] 3MediaWiki / 3General/Unknown: Option to require comment for non-editing actions - 10https://bugzilla.wikimedia.org/18995#c1 (10Andre Klapper) If anybody wants to work on this, the existing logic in Core is around here: ./includes/EditPage.php: $status->fatal( 'missingcommenttext' ); [08:45:12] 3MediaWiki / 3Revision deletion: Specific log_action for revision deletions - 10https://bugzilla.wikimedia.org/17806#c25 (10Andre Klapper) 5REOP>3NEW (In reply to Rd232 from comment #24) > 18 months with no progress. Is there anything in particular blocking this? Not that I knew. Patches in Gerrit are w... [08:45:23] (03PS1) 10Tweichart: small css fix, right action buttons now on one line [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/170670 [08:50:40] 3MediaWiki / 3Watchlist: Watchlist should report when the log entry for an action affecting a watched page is changed (ie log suppression) - 10https://bugzilla.wikimedia.org/18866 (10Andre Klapper) s:5normal>3enhanc [08:51:40] 3MediaWiki extensions / 3Scribunto: Lua error in mw.html.lua - 10https://bugzilla.wikimedia.org/72880#c6 (10Rob Kam) BTW the templates were all exported from Wikipedia yesterday. The wiki is using the latest stable version 1.23.6. Just in case it might help, extensions Scribunto and Parser were replaced yest... [10:12:38] (03CR) 10Gilles: [C: 032] Cast UploadWizardErrorFlowEvent.message to string [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/169919 (owner: 10Gergő Tisza) [10:13:18] (03Merged) 10jenkins-bot: Cast UploadWizardErrorFlowEvent.message to string [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/169919 (owner: 10Gergő Tisza) [10:14:09] (03CR) 10Gilles: "Did you miss my inline comments from my previous review pass?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 (owner: 10MarkTraceur) [10:16:16] (03PS5) 10Lewis Cawte: Use Config instead of globals [skins/Truglass] - 10https://gerrit.wikimedia.org/r/168912 [10:16:48] (03CR) 10Lewis Cawte: Use Config instead of globals (031 comment) [skins/Truglass] - 10https://gerrit.wikimedia.org/r/168912 (owner: 10Lewis Cawte) [10:21:59] legoktm: If you're happy with that config patch then +2 it, Jack said you'd need to approve any config stuff and I'm not a fan of self +2ing :) [10:23:43] 3MediaWiki / 3Parser: Missing whitespaces between words in article's last line on hy.wp - 10https://bugzilla.wikimedia.org/63918#c9 (10Xelgen) I've made English only text, to check if this has something to do with page content language. This doesn't reproduce on en:WP (https://en.wikipedia.org/wiki/User:Xel... [10:23:59] 3MediaWiki / 3Sites: http://tools.wikimedia.pl/~odder add to whitelist - 10https://bugzilla.wikimedia.org/72897 (10Russavia) 3NEW p:3Unprio s:3normal a:3None Please add http://tools.wikimedia.pl/~odder for https://commons.wikimedia.org/wiki/Commons:Upload_tools/wgCopyUploadsDomains so that we can upl... [10:25:11] 3Wikimedia / 3Site requests: http://tools.wikimedia.pl/~odder add to whitelist - 10https://bugzilla.wikimedia.org/72897 (10Marius Hoch) [10:25:27] 3Wikimedia / 3Site requests: http://tools.wikimedia.pl/~odder add to whitelist - 10https://bugzilla.wikimedia.org/72897 (10Marius Hoch) [10:25:27] 3Wikimedia / 3Site requests: Add domains to $wgCopyUploadsDomains (tracking) - 10https://bugzilla.wikimedia.org/58224 (10Marius Hoch) [10:36:41] 3MediaWiki extensions / 3SemanticForms: Error when using Special:RunQuery - "Parser state cleared while parsing" - 10https://bugzilla.wikimedia.org/66202#c5 (10Silke Meyer (WMDE)) Hi Yaron, can you please comment on Masin's comment? Is it a solution? I can't tell myself... Thanks! Best, Silke [11:12:55] 3MediaWiki skins / 3Vector: Read/edit/view history tabs obscure title when browser window is half-size - 10https://bugzilla.wikimedia.org/72876#c2 (10Michael M.) 5UNCO>3NEW When there is a draft, the "Read" tab is collapsed to the "More" dropdown, but not on other pages. That's why the tabs fit your very... [11:15:40] 3Wikimedia / 3Site requests: http://tools.wikimedia.pl/~odder add to whitelist - 10https://bugzilla.wikimedia.org/72897#c1 (10Nemo) For simplicity I suggest to add the whole http://tools.wikimedia.pl/ instead. [11:21:54] (03Abandoned) 10JoelKP: Add configurable support for namespace constants; by default, all standard MediaWiki namespace constants are supported. [extensions/PhpTagsWiki] - 10https://gerrit.wikimedia.org/r/170571 (owner: 10JoelKP) [11:32:50] (03PS1) 10Aklapper: Phab: Print URL, Version, etc only when they contain data [phabricator/tools] - 10https://gerrit.wikimedia.org/r/170679 [11:33:44] (03PS2) 10Aklapper: Phab: Print URL, Version, etc only when they contain data [phabricator/tools] - 10https://gerrit.wikimedia.org/r/170679 [11:34:02] (03PS3) 10Aklapper: Phab: Print URL, Version, etc only when they contain data [phabricator/tools] - 10https://gerrit.wikimedia.org/r/170679 [11:34:51] (03CR) 10Aklapper: "Note that this is untested & I'm not a python coder but a cargo cult "programmer". The related bug is real though. :)" [phabricator/tools] - 10https://gerrit.wikimedia.org/r/170679 (owner: 10Aklapper) [11:37:46] (03PS4) 10Aklapper: Phab: Print URL, Version, etc only when they contain data [phabricator/tools] - 10https://gerrit.wikimedia.org/r/170679 [11:42:10] (03CR) 10JoelKP: Add configurable support for namespace constants; by default, all standard MediaWiki namespace constants are supported. (031 comment) [extensions/PhpTagsWiki] - 10https://gerrit.wikimedia.org/r/170571 (owner: 10JoelKP) [11:50:25] 3MediaWiki / 3Templates: mr-wikibooks requests support for Template:Random Subpage - 10https://bugzilla.wikimedia.org/72878#c2 (10Mahitgar) (In reply to Andre Klapper from comment #1) What scope and what to reproduce sirji,? Forget the currently available template on mr-wikibooks. I would be quite ok with a... [12:00:05] (03PS1) 10Paladox: Localisation updates from https://translatewiki.net. [extensions/CollapsibleVector] (REL1_24) - 10https://gerrit.wikimedia.org/r/170682 [12:00:21] (03CR) 10Paladox: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/CollapsibleVector] (REL1_24) - 10https://gerrit.wikimedia.org/r/170682 (owner: 10Paladox) [12:02:52] (03CR) 10Daniel Kinzler: Add an "ArticleDeleteAfterSuccess" hook (031 comment) [core] - 10https://gerrit.wikimedia.org/r/170530 (owner: 10Hoo man) [12:08:36] (03CR) 10Daniel Kinzler: [C: 04-1] Add a hook for custom diff engines (WikEdDiff) (032 comments) [core] - 10https://gerrit.wikimedia.org/r/166143 (https://bugzilla.wikimedia.org/71916) (owner: 10Cacycle) [12:11:35] (03PS4) 10Daniel Kinzler: Re-caclulate SHA1 after applying exportTransform [core] - 10https://gerrit.wikimedia.org/r/168587 (https://bugzilla.wikimedia.org/72478) [12:12:16] (03CR) 10jenkins-bot: [V: 04-1] Re-caclulate SHA1 after applying exportTransform [core] - 10https://gerrit.wikimedia.org/r/168587 (https://bugzilla.wikimedia.org/72478) (owner: 10Daniel Kinzler) [12:14:46] (03PS12) 10Daniel Kinzler: Apply exportTransform in backupTextPass.inc [core] - 10https://gerrit.wikimedia.org/r/168126 (https://bugzilla.wikimedia.org/72361) [12:15:12] (03PS5) 10Daniel Kinzler: Re-caclulate SHA1 after applying exportTransform [core] - 10https://gerrit.wikimedia.org/r/168587 (https://bugzilla.wikimedia.org/72478) [12:30:26] 3Wikimedia / 3Site requests: Set $wgLegacyJavaScriptGlobals = false on ptwiki and ptwikibooks - 10https://bugzilla.wikimedia.org/70366#c2 (10Helder) Who is supposed to CONFIRM a site request if not the community itself? [12:35:12] (03PS1) 10Florianschmidtwelzow: Load style mosule only when needed [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/170685 [12:35:37] (03PS2) 10Florianschmidtwelzow: Load style module only when needed [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/170685 [12:53:26] 3MediaWiki extensions / 3Scribunto: Lua error in mw.html.lua - 10https://bugzilla.wikimedia.org/72880#c7 (10Jackmcbarn) 1.23 isn't the latest version. It's just the latest stable version. Wikimedia servers run a development release of 1.25. [12:54:41] 3MediaWiki / 3Templates: mr-wikibooks requests support for Template:Random Subpage - 10https://bugzilla.wikimedia.org/72878#c3 (10Andre Klapper) I understand that you look for support but unfortunately Bugzilla is not a support forum for on-wiki code. I am not sure if there is a general place on a wiki where... [12:54:56] 3Wikimedia / 3Extension setup: Install Page Curation on ur.wp - 10https://bugzilla.wikimedia.org/72899 (10Sam Reed (reedy)) p:5Unprio>3Normal s:5normal>3enhanc [12:59:40] 3MediaWiki / 3General/Unknown: .htaccess in tarball causing problems - 10https://bugzilla.wikimedia.org/72868#c6 (10Isai Castro) The .htaccess file was in the root directory of MediaWiki, I have a copy of it... [13:01:16] 3MediaWiki / 3General/Unknown: .htaccess in tarball causing problems - 10https://bugzilla.wikimedia.org/72868#c7 (10Isai Castro) Created attachment 16999 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16999&action=edit That problem file.. [13:01:56] 3Wikimedia / 3Extension setup: Install Page Curation on ur.wp - 10https://bugzilla.wikimedia.org/72899#c1 (10Andre Klapper) 5UNCO>3NEW p:5Normal>3Lowest Hi Obaid. This is unlikely to happen - see https://bugzilla.wikimedia.org/show_bug.cgi?id=38512#c5 and bug 48552. Furthermore, for any configurat... [13:19:40] 3Wikimedia / 3Extension setup: Install Page Curation on ur.wp - 10https://bugzilla.wikimedia.org/72899#c2 (10Obaid Raza) Community consensus: https://ur.wikipedia.org/w/index.php?title=%D9%88%DB%8C%DA%A9%DB%8C%D9%BE%DB%8C%DA%88%DB%8C%D8%A7:%D8%AF%DB%8C%D9%88%D8%A7%D9%86_%D8%B9%D8%A7%D9%85/%D8%B7%D8%B1%D8%B2%... [13:20:26] 3Wikimedia / 3Extension setup: Install Page Curation on ur.wp - 10https://bugzilla.wikimedia.org/72899#c3 (10Andre Klapper) Thanks! However as I wrote this will reuqire fixing bug 48552 first and I am not aware of anybody working on that. :-/ [13:21:26] 3MediaWiki / 3General/Unknown: .htaccess in tarball causing problems - 10https://bugzilla.wikimedia.org/72868 (10Andre Klapper) [13:34:26] 3MediaWiki / 3Export/Import: Put the and tags before the tag in the XML dumps. - 10https://bugzilla.wikimedia.org/72417 (10Lydia Pintscher) 5PATC>3RESO/FIX [13:36:18] (03CR) 10Reedy: "Guess we should really merge this before Wednesdays deploy..." [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/168274 (https://bugzilla.wikimedia.org/67154) (owner: 10Reedy) [13:38:12] 3MediaWiki extensions / 3CirrusSearch: RegEx-style Cirrus searches are ignored on en.wikipedia - 10https://bugzilla.wikimedia.org/72894#c4 (10Nik Everett) 5UNCO>3ASSI a:3Nik Everett Hi Grumbler! I sent an email to wikitech-ambassadors@lists.wikimedia.org on October 31st at 11:30 US Eastern time. Its... [13:41:13] 3MediaWiki extensions / 3SemanticForms: "Add another" feature for multiple-instance templates broken with MW >= 1.24 - 10https://bugzilla.wikimedia.org/72900 (10Joel K. Pettersson) 3UNCO p:3Unprio s:3normal a:3Yaron Koren At some point in MW 1.24 development - my guess is it may have been the jQuery... [13:43:31] !logs [13:43:31] channel logs: http://bots.wmflabs.org/~wm-bot/logs/%23mediawiki/ html version: http://tools.wmflabs.org/wm-bot/logs/index.php?display=%23mediawiki [13:46:28] Ah, they're in the topic. [13:47:41] 3MediaWiki extensions / 3Scribunto: Lua error in mw.html.lua - 10https://bugzilla.wikimedia.org/72880#c8 (10Rob Kam) Then Wikipedia templates are incompatible with 1.23 [13:55:40] 3MediaWiki extensions / 3Math: \frac in exponents is shown too big - 10https://bugzilla.wikimedia.org/72618#c2 (10Juetho) Created attachment 17000 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17000&action=edit bug representation [13:57:10] 3MediaWiki extensions / 3Math: \frac in exponents is shown too big - 10https://bugzilla.wikimedia.org/72618#c3 (10Juetho) Screenshot from the following page: https://de.wikibooks.org/wiki/Komplexe_Zahlen/_Weitere_Rechenverfahren#Wurzeln [14:14:53] (03PS5) 10Aklapper: Phab: Print URL, Version, etc only when they contain data [phabricator/tools] - 10https://gerrit.wikimedia.org/r/170679 [14:17:56] 3MediaWiki extensions / 3Scribunto: Lua error in mw.html.lua for {{infobox}} template from Wikipedia - 10https://bugzilla.wikimedia.org/72880#c9 (10Andre Klapper) {{infobox}} from which Wikipedia? Link welcome. There are some languages... :) [14:29:12] 3MediaWiki extensions / 3CirrusSearch: Notice: Undefined offset: 1 in updateOneSearchIndexConfig.php on line 585 - 10https://bugzilla.wikimedia.org/72888 (10Aude) 5PATC>3RESO/FIX [14:32:08] (03PS6) 10Aklapper: Phab: Fix wrong variable [phabricator/tools] - 10https://gerrit.wikimedia.org/r/170679 [14:32:10] (03CR) 10jenkins-bot: [V: 04-1] Phab: Fix wrong variable [phabricator/tools] - 10https://gerrit.wikimedia.org/r/170679 (owner: 10Aklapper) [14:32:14] 3MediaWiki / 3General/Unknown: .htaccess in tarball causing problems - 10https://bugzilla.wikimedia.org/72868#c8 (10Tisza Gergő) This file should be in the images/ directory, not the root. Maybe it got copied accidentally? Re: the spurious 403, that's probably a duplicate of bug 62289. [14:35:06] (03CR) 10Robert Vogel: [C: 032 V: 032] Bugfix: Popup position and links [extensions/Teahouse] - 10https://gerrit.wikimedia.org/r/169669 (owner: 10Robert Vogel) [14:35:26] (03CR) 10Robert Vogel: [C: 032 V: 032] Fixed typo in I18N text [extensions/Teahouse] - 10https://gerrit.wikimedia.org/r/169670 (owner: 10Robert Vogel) [14:35:29] (03PS1) 10Yuvipanda: Add hiera config link to project special page [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/170699 [14:36:46] (03PS1) 10Aklapper: Phab: Fix incorrect variable name [phabricator/tools] - 10https://gerrit.wikimedia.org/r/170701 [14:37:18] (03Abandoned) 10Aklapper: Phab: Fix wrong variable [phabricator/tools] - 10https://gerrit.wikimedia.org/r/170679 (owner: 10Aklapper) [14:39:49] (03PS1) 10Robert Vogel: SPECIAL CODE REVIEW BRANCH/COMMIT [extensions/Teahouse] - 10https://gerrit.wikimedia.org/r/170702 [14:40:43] 3MediaWiki extensions / 3CirrusSearch: insource:"A, B et C (Le Prisonnier)" should match interwiki links such as [[fr:A, B et C (Le Prisonnier)]] - 10https://bugzilla.wikimedia.org/72902 (10Yusuke Matsubara) 3NEW p:3Unprio s:3normal a:3None Plain-text insource search should match interwiki links, but... [14:40:52] (03CR) 10Rush: [C: 04-1] "close!" (031 comment) [phabricator/tools] - 10https://gerrit.wikimedia.org/r/170701 (owner: 10Aklapper) [14:42:02] (03PS2) 10Yuvipanda: Add hiera config link to project special page [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/170699 [14:42:26] 3MediaWiki extensions / 3CirrusSearch: insource:"A, B et C (Le Prisonnier)" should match interwiki links such as [[fr:A, B et C (Le Prisonnier)]] - 10https://bugzilla.wikimedia.org/72902#c1 (10Yusuke Matsubara) Sorry intended links are: https://en.wikipedia.org/w/index.php?title=Special%3ASearch&profile=def... [14:43:52] (03CR) 10Manybubbles: "If we want this in today's SWAT I believe we should get this merged pretty soon. I'm not comfortable merging things into core's master br" [core] - 10https://gerrit.wikimedia.org/r/170593 (https://bugzilla.wikimedia.org/72887) (owner: 10Bartosz Dziewoński) [14:46:32] (03PS2) 10Aklapper: Phab: Fix incorrect variable name [phabricator/tools] - 10https://gerrit.wikimedia.org/r/170701 [14:47:57] 3MediaWiki extensions / 3CirrusSearch: insource:"A, B et C (Le Prisonnier)" should match interwiki links such as [[fr:A, B et C (Le Prisonnier)]] - 10https://bugzilla.wikimedia.org/72902#c2 (10Nik Everett) p:5Unprio>3Normal Confirmed. It should indeed. [14:48:26] 3MediaWiki extensions / 3Scribunto: Lua error in mw.html.lua for {{infobox}} template from Wikipedia - 10https://bugzilla.wikimedia.org/72880#c10 (10Rob Kam) https://en.wikipedia.org/wiki/Template:Infobox_synthesizer [14:48:26] (03CR) 10Rush: [C: 032 V: 032] Phab: Fix incorrect variable name [phabricator/tools] - 10https://gerrit.wikimedia.org/r/170701 (owner: 10Aklapper) [14:52:57] 3MediaWiki / 3Email: E-Mail over SMTP throws strict errors everytime an e-mail is sent - 10https://bugzilla.wikimedia.org/47463#c2 (10Kevin Israel (PleaseStand)) (In reply to Kevin Israel (PleaseStand) from comment #1) > Upstream bug reports were already filed about two years ago. I have no clue > if > (or w... [14:54:26] 3MediaWiki / 3API: Undefined property: stdClass::$page_touched in ApiPageSet.php on line 712 - 10https://bugzilla.wikimedia.org/72764#c9 (10Brad Jorsch) 5PATC>3RESO/FIX Should be fixed with 1.25wmf7. [14:55:46] (03CR) 10JoelKP: [C: 031] "This seems a better way to do it - no configuration needed." [extensions/PhpTagsWiki] - 10https://gerrit.wikimedia.org/r/170651 (owner: 10Pastakhov) [15:00:42] (03PS1) 10Aklapper: Phab: Remove non-existing Bugzilla status from list [phabricator/tools] - 10https://gerrit.wikimedia.org/r/170705 [15:07:42] 3MediaWiki extensions / 3Scribunto: Lua error in mw.html.lua for {{infobox}} template from Wikipedia - 10https://bugzilla.wikimedia.org/72880#c11 (10Jackmcbarn) 5UNCO>3RESO/INV (In reply to Rob Kam from comment #8) > Then Wikipedia templates are incompatible with 1.23 Yes, some of them are. I've looked... [15:08:43] 3MediaWiki extensions / 3TitleBlacklist: [[Special:Log/titleblacklist]] is empty - 10https://bugzilla.wikimedia.org/72905 (10Helder) 3NEW p:3Unprio s:3normal a:3None Even after trying to create few blacklisted titles, the logs a re still empty on https://pt.wikipedia.org/wiki/Special:Log/titleblacklist [15:18:02] anomie: re https://en.wikipedia.org/wiki/Module_talk:Arguments#Implement_i18n , i don't really see how that would be a problem [15:18:55] you say it's like special page names being different, but (ignoring the wtf example of the de watchlist) those don't really pose a problem either, do they? [15:19:22] since in practice, content is almost always copied from an english wiki to somewhere else [15:25:18] (03PS1) 10Esanders: Add selection restriction to command [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/170709 [15:25:21] (03PS1) 10Esanders: Add selection restriction to command [extensions/Math] - 10https://gerrit.wikimedia.org/r/170710 [15:25:56] 3MediaWiki extensions / 3SemanticForms: "Add another" feature for multiple-instance templates broken with MW >= 1.24 - 10https://bugzilla.wikimedia.org/72900#c1 (10Yaron Koren) Hi Joel, I'm guessing that there's a Javascript error somewhere. Can you open the Javascript console in your browser (if you're usi... [15:27:55] 3MediaWiki extensions / 3SemanticForms: Error when using Special:RunQuery - "Parser state cleared while parsing" - 10https://bugzilla.wikimedia.org/66202#c6 (10Yaron Koren) Oh, I didn't realize that the previous post was a proposed solution. It's great that this may fix the issue. I'm adding Stephan to this... [15:33:13] (03CR) 10MarkTraceur: "Sorry about that! Incoming." (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 (owner: 10MarkTraceur) [15:33:23] (03PS11) 10MarkTraceur: Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 [15:41:46] (03PS3) 10Krinkle: die() with explanation when \Psr\Log\LoggerInterface is missing [core] - 10https://gerrit.wikimedia.org/r/170274 (https://bugzilla.wikimedia.org/72777) (owner: 10BryanDavis) [15:42:26] 3MediaWiki extensions / 3TitleBlacklist: [[Special:Log/titleblacklist]] is empty - 10https://bugzilla.wikimedia.org/72905#c1 (10Umherirrender) 5NEW>3RESO/DUP $wgTitleBlacklistLogHits is still false on wmf wikis (default in the extension) *** This bug has been marked as a duplicate of bug 66450 *** [15:42:27] 3Wikimedia / 3Site requests: Set $wgTitleBlacklistLogHits = true on WMF wikis - 10https://bugzilla.wikimedia.org/66450#c35 (10Umherirrender) *** Bug 72905 has been marked as a duplicate of this bug. *** [15:44:26] 3MediaWiki extensions / 3SemanticForms: "Add another" feature for multiple-instance templates broken with MW >= 1.24 - 10https://bugzilla.wikimedia.org/72900#c2 (10Andre Klapper) Joel: For error console instructions please see: * Firefox ≥24: https://developer.mozilla.org/en-US/docs/Tools/Web_Console * Inter... [15:46:16] (03CR) 10Anomie: "IMO it's too late to merge in time for the 08:00 PST SWAT window today." [core] - 10https://gerrit.wikimedia.org/r/170593 (https://bugzilla.wikimedia.org/72887) (owner: 10Bartosz Dziewoński) [15:47:36] (03PS4) 10Krinkle: die() with explanation when \Psr\Log\LoggerInterface is missing [core] - 10https://gerrit.wikimedia.org/r/170274 (https://bugzilla.wikimedia.org/72777) (owner: 10BryanDavis) [15:47:59] (03CR) 10Krinkle: "Removed quotes and added die( 1 ), to match existing code." [core] - 10https://gerrit.wikimedia.org/r/170274 (https://bugzilla.wikimedia.org/72777) (owner: 10BryanDavis) [15:50:25] (03CR) 10Krinkle: [C: 04-1] "I'm not sure what or how, but all I can say is, I get a blank HTTP 200 and a stacktrace in the error log for "Class 'MWLogger' not found"." [core] - 10https://gerrit.wikimedia.org/r/170274 (https://bugzilla.wikimedia.org/72777) (owner: 10BryanDavis) [15:50:56] 3MediaWiki extensions / 3TitleBlacklist: [[Special:Log/titleblacklist]] is empty - 10https://bugzilla.wikimedia.org/72905#c2 (10Helder) @Umherirrender: Shouldn't the the option be removed from the dropdown menu then? [15:52:50] (03CR) 10Krinkle: [C: 031] MediaTransformOutput: Allow alt value to be "0" [core] - 10https://gerrit.wikimedia.org/r/116483 (https://bugzilla.wikimedia.org/38910) (owner: 10Lekshmi) [15:53:41] 3MediaWiki extensions / 3TitleBlacklist: [[Special:Log/titleblacklist]] is empty - 10https://bugzilla.wikimedia.org/72905#c3 (10Umherirrender) That is possible, maybe change this bug to a feature request for that. [15:56:25] (03PS6) 10Kji: Initial commit for the HierarchyBuilder extension. [extensions/HierarchyBuilder] - 10https://gerrit.wikimedia.org/r/168192 [15:57:48] (03PS1) 10Cacycle: Add a hook for custom difference engine (WikEdDiff) [core] - 10https://gerrit.wikimedia.org/r/170716 (https://bugzilla.wikimedia.org/71916) [16:01:12] 3MediaWiki extensions / 3TitleBlacklist: Hide "titleblacklist" from [[Special:Log]] if $wgTitleBlacklistLogHits is false - 10https://bugzilla.wikimedia.org/72905 (10Helder) 5RESO/DUP>3REOP [16:01:26] 3MediaWiki extensions / 3TitleBlacklist: Hide "titleblacklist" from [[Special:Log]] if $wgTitleBlacklistLogHits is false - 10https://bugzilla.wikimedia.org/72905 (10Helder) 5REOP>3NEW [16:01:33] (03Abandoned) 10Cacycle: Add a hook for custom difference engine (WikEdDiff) [core] - 10https://gerrit.wikimedia.org/r/170716 (https://bugzilla.wikimedia.org/71916) (owner: 10Cacycle) [16:01:43] 3MediaWiki extensions / 3TitleBlacklist: Hide "titleblacklist" from [[Special:Log]] if $wgTitleBlacklistLogHits is false - 10https://bugzilla.wikimedia.org/72905 (10Helder) [16:01:43] 3Wikimedia / 3Site requests: Set $wgTitleBlacklistLogHits = true on WMF wikis - 10https://bugzilla.wikimedia.org/66450 (10Helder) [16:02:43] bd808: hey ! time for a composer patch review ? https://gerrit.wikimedia.org/r/#/c/170369/ [16:05:57] tonythomas: It's "on the list". Today is a write docs and do code review sort of day. [16:06:19] bd808: yay ! nice day [16:10:55] (03CR) 10JanZerebecki: "Is the sha1 used anywhere as input in the api? Is there any way to get the original revision content instead of the transformed one?" [core] - 10https://gerrit.wikimedia.org/r/168587 (https://bugzilla.wikimedia.org/72478) (owner: 10Daniel Kinzler) [16:13:12] 3MediaWiki / 3General/Unknown: Tracking bug (tracking) - 10https://bugzilla.wikimedia.org/2007 (10James Forrester) [16:13:27] 3MediaWiki extensions / 3Translate: and do not work with Parsoid because they are not normal parser tags - 10https://bugzilla.wikimedia.org/48891 (10Nemo) [16:15:41] 3MediaWiki extensions / 3SemanticForms: "Add another" feature for multiple-instance templates broken with MW >= 1.24 - 10https://bugzilla.wikimedia.org/72900#c3 (10Joel K. Pettersson) Okay - the following appears, and it seems my initial guess regarding the cause was wrong: "Exception thrown by user callbac... [16:15:48] (03CR) 10Daniel Kinzler: "@Jan: as far as I know, there is no way to get the original content via the API. The API operates on Content objects - they get re-seriali" [core] - 10https://gerrit.wikimedia.org/r/168587 (https://bugzilla.wikimedia.org/72478) (owner: 10Daniel Kinzler) [16:16:01] jzerebecki: --^ [16:16:54] (03PS5) 10BryanDavis: die() with explanation when \Psr\Log\LoggerInterface is missing [core] - 10https://gerrit.wikimedia.org/r/170274 (https://bugzilla.wikimedia.org/72777) [16:16:58] 3MediaWiki extensions / 3Translate: tags visible when transcluded - 10https://bugzilla.wikimedia.org/56451 (10James Forrester) [16:16:58] 3MediaWiki extensions / 3Translate: and do not work with Parsoid because they are not normal parser tags - 10https://bugzilla.wikimedia.org/48891 (10James Forrester) [16:18:46] (03CR) 10BryanDavis: "Added a call to trigger_error() which should at least get something useful into the server's error logs. Under MediaWiki-Vagrant's HHVM th" [core] - 10https://gerrit.wikimedia.org/r/170274 (https://bugzilla.wikimedia.org/72777) (owner: 10BryanDavis) [16:20:12] 3MediaWiki / 3Page editing: "Templates used on this page" on section edit should show templates used in the section at initial edit as well as preview - 10https://bugzilla.wikimedia.org/878 (10James Forrester) [16:20:30] (03CR) 10Phuedx: "Recheck." [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/170457 (https://bugzilla.wikimedia.org/72711) (owner: 10Jdlrobson) [16:22:13] 3MediaWiki extensions / 3GoogleLogin: Login link redirect to default login (not GoogleLogin) - 10https://bugzilla.wikimedia.org/72909 (10tim.schenk) 3UNCO p:3Unprio s:3normal a:3None The link supplied by the mobile page redirects to : http://wiki.firstconsulting.nl/Speciaal:Aanmelden <-- dutch This... [16:23:57] 3MediaWiki extensions / 3GoogleLogin: Login link redirect to default login (not GoogleLogin) - 10https://bugzilla.wikimedia.org/72909 (10tim.schenk) [16:23:57] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "As with every code review this may look like I don't like the code just because I'm focusing on possible problems and nitpicks. But I like" (0310 comments) [extensions/Teahouse] - 10https://gerrit.wikimedia.org/r/170702 (owner: 10Robert Vogel) [16:24:18] (03PS12) 10MarkTraceur: Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 [16:26:31] (03CR) 10Umherirrender: "For sha1 as input to the api: bug 49136" [core] - 10https://gerrit.wikimedia.org/r/168587 (https://bugzilla.wikimedia.org/72478) (owner: 10Daniel Kinzler) [16:29:56] 3MediaWiki / 3Parser: Pre-save transform skips extensions using wikitext (gallery, references, footnotes, Cite, status indicators, pipe trick, subst, signatures) - 10https://bugzilla.wikimedia.org/2700 (10James Forrester) [16:30:04] (03CR) 1001tonythomas: [C: 031] "@Hoo:" [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170523 (https://bugzilla.wikimedia.org/72685) (owner: 1001tonythomas) [16:32:55] 3MediaWiki / 3General/Unknown: .htaccess in tarball causing problems - 10https://bugzilla.wikimedia.org/72868#c9 (10Bawolff (Brian Wolff)) 5UNCO>3RESO/INV (In reply to Tisza Gergő from comment #8) > This file should be in the images/ directory, not the root. Maybe it got > copied accidentally? > > Re: t... [16:33:12] (03CR) 10Phuedx: [C: 032] Deprecate one in favour of once [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/170457 (https://bugzilla.wikimedia.org/72711) (owner: 10Jdlrobson) [16:33:45] (03Merged) 10jenkins-bot: Deprecate one in favour of once [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/170457 (https://bugzilla.wikimedia.org/72711) (owner: 10Jdlrobson) [16:34:21] (03PS13) 10MarkTraceur: Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 [16:34:48] (03PS14) 10MarkTraceur: Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 [16:39:10] 3Wikimedia / 3Bugzilla: Close or move Cortado / mwEmbed products - 10https://bugzilla.wikimedia.org/54063#c5 (10Andre Klapper) p:5Normal>3Lowest Problem might "solve" itself by moving from Bugzilla to Phabricator with its flat namespace for projects. [16:39:19] (03CR) 10Gilles: [C: 032] Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 (owner: 10MarkTraceur) [16:39:53] (03Merged) 10jenkins-bot: Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 (owner: 10MarkTraceur) [16:40:03] (03PS15) 10Gilles: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 (owner: 10MarkTraceur) [16:40:29] (03PS1) 10Umherirrender: Correct case of ImageGallery::toHTML [core] - 10https://gerrit.wikimedia.org/r/170722 [16:44:46] (03PS1) 10Cacycle: Add a hook for custom difference engine (WikEdDiff) [core] - 10https://gerrit.wikimedia.org/r/170723 (https://bugzilla.wikimedia.org/71916) [16:48:42] (03CR) 10Daniel Kinzler: "A cheap way out would be not simply drop the sha1 when the output was transformed. Can be done during export." [core] - 10https://gerrit.wikimedia.org/r/168587 (https://bugzilla.wikimedia.org/72478) (owner: 10Daniel Kinzler) [16:50:53] (03PS16) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [16:51:51] (03CR) 10Gilles: Move updateFileCounts to the upload controller (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 (owner: 10MarkTraceur) [16:52:46] (03Abandoned) 10Cacycle: Add a hook for custom difference engine (WikEdDiff) [core] - 10https://gerrit.wikimedia.org/r/170723 (https://bugzilla.wikimedia.org/71916) (owner: 10Cacycle) [16:54:48] (03PS17) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [16:58:02] (03CR) 10Anomie: Correctly parse contents, Parser rejiggering (035 comments) [core] - 10https://gerrit.wikimedia.org/r/170593 (https://bugzilla.wikimedia.org/72887) (owner: 10Bartosz Dziewoński) [16:59:41] (03CR) 10Gilles: [C: 04-1] "Uploaded 2 flickr imports + one regular file, went through the whole process, then clicked on the button to upload new files, got this:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 (owner: 10MarkTraceur) [17:00:09] I need a babysitter for uploading a patchset into https://gerrit.wikimedia.org/r/#/c/166143/ without creating a new change &@%$ :-) [17:00:16] Have followed https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change [17:00:42] Cacycle: is the original change-id at the bottom of your commit message? [17:00:48] change-ids are how gerrit tells changes apart [17:03:41] Thanks! Nope, I had removed the long change-Id... Will try again without changing the number. [17:04:17] Don't remove it!!!!!!!!!!!!!!!!!1 [17:04:44] :P [17:05:12] Cacycle: there's a script that will add a random one if it doesn't see one, so make sure that it matches the one in gerrit from your original patch before pushing the change out [17:05:22] You can make completely different changesets, and give it the same change-id. It'll overwrite the existing one [17:17:25] (03PS3) 10Florianschmidtwelzow: Load style mosule only when needed [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/170685 [17:18:12] (03PS1) 10Florianschmidtwelzow: Fix: undefined var [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/170726 [17:19:40] (03PS9) 10Cacycle: Add hook for custom difference engine (WikEdDiff) [core] - 10https://gerrit.wikimedia.org/r/166143 (https://bugzilla.wikimedia.org/71916) [17:20:30] (03PS2) 10Physikerwelt: Disable overwriting of the fallback image [extensions/Math] - 10https://gerrit.wikimedia.org/r/170643 (https://bugzilla.wikimedia.org/72626) [17:20:38] (03PS2) 1001tonythomas: Marked the BounceHandler API as internal [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170523 (https://bugzilla.wikimedia.org/72685) [17:21:22] (03CR) 10Physikerwelt: [C: 031] Add selection restriction to command [extensions/Math] - 10https://gerrit.wikimedia.org/r/170710 (owner: 10Esanders) [17:22:27] (03CR) 10Physikerwelt: "Frédér" (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/167019 (owner: 10Frédéric Wang) [17:23:27] 3MediaWiki extensions / 3Scribunto: Lua error in mw.html.lua for {{infobox}} template from Wikipedia - 10https://bugzilla.wikimedia.org/72880#c12 (10Rob Kam) Thanks! Changing to 1.24 Scribunto has fixed it. [17:28:55] (03CR) 10Cacycle: "Daniel:" [core] - 10https://gerrit.wikimedia.org/r/166143 (https://bugzilla.wikimedia.org/71916) (owner: 10Cacycle) [17:31:56] (03PS1) 10Manybubbles: Cirrus updates for 1.23 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/170729 [17:32:04] (03CR) 10jenkins-bot: [V: 04-1] Cirrus updates for 1.23 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/170729 (owner: 10Manybubbles) [17:32:18] (03Abandoned) 10Manybubbles: Cirrus updates for 1.23 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/170729 (owner: 10Manybubbles) [17:32:56] 3Wikimedia / 3Site requests: http://tools.wikimedia.pl/~odder add to whitelist - 10https://bugzilla.wikimedia.org/72897 (10Dereckson) 5NEW>3ASSI a:3Dereckson [17:33:54] (03PS1) 10Manybubbles: Cirrus updates for 1.23 [extensions/CirrusSearch] (REL1_23) - 10https://gerrit.wikimedia.org/r/170730 [17:35:42] 3MediaWiki extensions / 3GoogleLogin: Login link redirect to default login (not GoogleLogin) - 10https://bugzilla.wikimedia.org/72909#c1 (10Florian) 5UNCO>3ASSI p:5Unprio>3Normal a:3Florian Actually it depends on MobileFrontend in a special way :) Both Extensions, MobileFrontend and GoogleLogin, wi... [17:36:56] 3MediaWiki / 3General/Unknown: Tracking bug (tracking) - 10https://bugzilla.wikimedia.org/2007 (10Florian) [17:37:29] (03PS18) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [17:38:49] (03PS7) 10Umherirrender: Add el_from_namespace column to support namespace filter [core] - 10https://gerrit.wikimedia.org/r/163470 (https://bugzilla.wikimedia.org/10593) [17:38:59] (03PS4) 10Florianschmidtwelzow: Load style module only when needed [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/170685 [17:39:36] (03CR) 10jenkins-bot: [V: 04-1] Add el_from_namespace column to support namespace filter [core] - 10https://gerrit.wikimedia.org/r/163470 (https://bugzilla.wikimedia.org/10593) (owner: 10Umherirrender) [17:39:54] (03CR) 10Umherirrender: "Patch Set 7: Removed the changes to the api modules to allow fixing of bug 57176 first." [core] - 10https://gerrit.wikimedia.org/r/163470 (https://bugzilla.wikimedia.org/10593) (owner: 10Umherirrender) [17:40:10] (03PS2) 10Florianschmidtwelzow: Fix: undefined var [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/170726 [17:40:51] (03PS5) 10Florianschmidtwelzow: Load style module only when needed [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/170685 [17:41:06] (03CR) 10Florianschmidtwelzow: [C: 032] Fix: undefined var [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/170726 (owner: 10Florianschmidtwelzow) [17:41:15] (03Merged) 10jenkins-bot: Fix: undefined var [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/170726 (owner: 10Florianschmidtwelzow) [17:41:46] (03PS8) 10Umherirrender: Add el_from_namespace column to support namespace filter [core] - 10https://gerrit.wikimedia.org/r/163470 (https://bugzilla.wikimedia.org/10593) [17:41:56] (03PS1) 10Florianschmidtwelzow: Fix: undefined var [extensions/GoogleLogin] (v0_2_0) - 10https://gerrit.wikimedia.org/r/170733 [17:41:58] (03CR) 10Anomie: [C: 04-1] Set the correct error source from mw.html (033 comments) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/170648 (owner: 10Jackmcbarn) [17:42:08] (03CR) 10Umherirrender: "Patch Set 8: Rebased" [core] - 10https://gerrit.wikimedia.org/r/163470 (https://bugzilla.wikimedia.org/10593) (owner: 10Umherirrender) [17:42:28] 3MediaWiki extensions / 3GlobalUserPage: Performance review of GlobalUserPage extension - 10https://bugzilla.wikimedia.org/70585#c8 (10Aaron Schulz) 5PATC>3RESO/FIX LGTM. --- Comment #9 from Aaron Schulz --- LGTM. [17:42:28] 3MediaWiki extensions / 3GlobalUserPage: Performance review of GlobalUserPage extension - 10https://bugzilla.wikimedia.org/70585#c8 (10Aaron Schulz) 5PATC>3RESO/FIX LGTM. --- Comment #9 from Aaron Schulz --- LGTM. [17:43:10] o.O [17:43:18] (03CR) 10Florianschmidtwelzow: [C: 032] Fix: undefined var [extensions/GoogleLogin] (v0_2_0) - 10https://gerrit.wikimedia.org/r/170733 (owner: 10Florianschmidtwelzow) [17:43:28] (03Merged) 10jenkins-bot: Fix: undefined var [extensions/GoogleLogin] (v0_2_0) - 10https://gerrit.wikimedia.org/r/170733 (owner: 10Florianschmidtwelzow) [17:44:11] (03PS1) 10Rahdev: This directory (.config) and file (git-review.conf) do not exist in the MacOSX Yosimite installation, so added defaultremote = origin to .gitreview [extensions/examples] - 10https://gerrit.wikimedia.org/r/170734 [17:45:37] (03PS1) 10Aaron Schulz: Mention that IDatabase is allowed for RL module getDB() method [core] - 10https://gerrit.wikimedia.org/r/170735 [17:46:59] (03PS1) 10Aaron Schulz: Use getConnectionRef() so that reuseConnection() gets called [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/170737 [17:50:00] (03CR) 10Bartosz Dziewoński: Correctly parse contents, Parser rejiggering (031 comment) [core] - 10https://gerrit.wikimedia.org/r/170593 (https://bugzilla.wikimedia.org/72887) (owner: 10Bartosz Dziewoński) [17:51:07] (03CR) 10Jdlrobson: [C: 031] "Any objections to me merging...?" [core] - 10https://gerrit.wikimedia.org/r/170520 (https://bugzilla.wikimedia.org/71769) (owner: 10Florianschmidtwelzow) [17:53:31] (03PS3) 1001tonythomas: Marked the BounceHandler API as internal [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170523 (https://bugzilla.wikimedia.org/72685) [17:54:08] (03PS6) 10Jdlrobson: Remove Handlebars Mantle dependency [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/170099 [17:54:50] (03CR) 10Legoktm: UserLogin: Allow extensions to add valid error messages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/170520 (https://bugzilla.wikimedia.org/71769) (owner: 10Florianschmidtwelzow) [17:55:51] (03CR) 10Aaron Schulz: [C: 032] Marked the BounceHandler API as internal [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170523 (https://bugzilla.wikimedia.org/72685) (owner: 1001tonythomas) [17:55:54] (03CR) 10Bartosz Dziewoński: Correctly parse contents, Parser rejiggering (034 comments) [core] - 10https://gerrit.wikimedia.org/r/170593 (https://bugzilla.wikimedia.org/72887) (owner: 10Bartosz Dziewoński) [17:55:59] (03Merged) 10jenkins-bot: Marked the BounceHandler API as internal [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170523 (https://bugzilla.wikimedia.org/72685) (owner: 1001tonythomas) [17:56:26] 3MediaWiki / 3General/Unknown: Updating Page count doesn't work reliably when a page is moved - 10https://bugzilla.wikimedia.org/64333#c12 (10Andyrom75) I've just made a test moving https://it.wikivoyage.org/wiki/Utente:Andyrom75/Test into https://it.wikivoyage.org/wiki/Test (and back), and unfortunately the... [17:57:15] (03CR) 10Hoo man: Marked the BounceHandler API as internal (032 comments) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170523 (https://bugzilla.wikimedia.org/72685) (owner: 1001tonythomas) [17:57:24] (03PS3) 10Bartosz Dziewoński: Correctly parse contents, Parser rejiggering [core] - 10https://gerrit.wikimedia.org/r/170593 (https://bugzilla.wikimedia.org/72887) [17:57:43] anomie: i'm around now if you want to discuss that mess ^ [17:58:47] MatmaRex: Should be supported in that, for one thing? [17:59:12] (03CR) 10Jdlrobson: "Bueller! (I mean Matt ;-))" [core] - 10https://gerrit.wikimedia.org/r/165256 (owner: 10Jdlrobson) [17:59:16] (03PS6) 10Jdlrobson: Allow mw-ui-block modifier on anchors [core] - 10https://gerrit.wikimedia.org/r/165256 [17:59:52] anomie: why not? we still need to support all kinds of other stuff, like correctly doing link table things [18:00:10] the fact that works is a nice side-effect [18:00:39] MatmaRex: Yeah, link table not being affected is a bad side effect of messages. [18:01:12] The problem is that you can't tell the difference between something that needs the after-parse hooks called for the snippet and something that [18:01:19] 'll break if the hooks are called. [18:01:32] Unless you add more hooks. [18:03:08] (03PS1) 10Gilles: Remove wrapper arrays coming from EXIF [core] - 10https://gerrit.wikimedia.org/r/170743 (https://bugzilla.wikimedia.org/72652) [18:03:11] anomie: i could special-case this more, i guess. keep indicators in primary page content until the very last instant, when we extract it [18:03:26] (03CR) 10jenkins-bot: [V: 04-1] Correctly parse contents, Parser rejiggering [core] - 10https://gerrit.wikimedia.org/r/170593 (https://bugzilla.wikimedia.org/72887) (owner: 10Bartosz Dziewoński) [18:03:27] anomie: that might also be how transparent tag hooks work, but they apparently have some other issues [18:04:07] I think transparent tag hooks just allow the parser to preprocess over the tags instead of treating their contents as opaque. [18:04:28] (03CR) 10Florianschmidtwelzow: [C: 04-1] UserLogin: Allow extensions to add valid error messages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/170520 (https://bugzilla.wikimedia.org/71769) (owner: 10Florianschmidtwelzow) [18:05:00] anomie: bah [18:05:10] anomie: i changed one of the things you asked me for and now tests fail [18:06:54] (03PS4) 10Bartosz Dziewoński: Correctly parse contents, Parser rejiggering [core] - 10https://gerrit.wikimedia.org/r/170593 (https://bugzilla.wikimedia.org/72887) [18:06:59] (03PS3) 10Florianschmidtwelzow: UserLogin: Allow extensions to add valid error messages [core] - 10https://gerrit.wikimedia.org/r/170520 (https://bugzilla.wikimedia.org/71769) [18:07:40] (03CR) 10Gilles: [C: 04-1] "More of the same:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 (owner: 10MarkTraceur) [18:08:27] (03CR) 10Bartosz Dziewoński: Correctly parse contents, Parser rejiggering (031 comment) [core] - 10https://gerrit.wikimedia.org/r/170593 (https://bugzilla.wikimedia.org/72887) (owner: 10Bartosz Dziewoński) [18:08:29] (03PS4) 10Florianschmidtwelzow: UserLogin: Allow extensions to add valid error messages [core] - 10https://gerrit.wikimedia.org/r/170520 (https://bugzilla.wikimedia.org/71769) [18:08:51] (03CR) 10EBernhardson: [C: 032] Remove Handlebars Mantle dependency [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/170099 (owner: 10Jdlrobson) [18:09:17] (03CR) 10Hoo man: Add an "ArticleDeleteAfterSuccess" hook (031 comment) [core] - 10https://gerrit.wikimedia.org/r/170530 (owner: 10Hoo man) [18:09:39] (03Merged) 10jenkins-bot: Remove Handlebars Mantle dependency [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/170099 (owner: 10Jdlrobson) [18:12:26] 3MediaWiki extensions / 3BounceHandler: Performance review BounceHandler extension for Deployment - 10https://bugzilla.wikimedia.org/69100#c8 (10Aaron Schulz) I'd second having an index as above. [18:12:49] (03CR) 10Jjanes: [C: 031] "I've verified that this does not break the installation or the upgrade of simple PostgreSQL installs. I haven't tested any of the interwi" [core] - 10https://gerrit.wikimedia.org/r/161034 (https://bugzilla.wikimedia.org/46992) (owner: 10Alex Monk) [18:13:57] (03PS2) 10Krinkle: resourceloader: Document that WikiModule::getDB() may return IDatabase [core] - 10https://gerrit.wikimedia.org/r/170735 (owner: 10Aaron Schulz) [18:14:08] (03CR) 10Krinkle: [C: 031] resourceloader: Document that WikiModule::getDB() may return IDatabase [core] - 10https://gerrit.wikimedia.org/r/170735 (owner: 10Aaron Schulz) [18:14:33] (03CR) 10Legoktm: [C: 04-1] Add hiera config link to project special page (031 comment) [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/170699 (owner: 10Yuvipanda) [18:15:29] (03CR) 10Krinkle: "CSSJanusTest should be removed as well." [core] - 10https://gerrit.wikimedia.org/r/170107 (owner: 10Legoktm) [18:16:19] (03CR) 10Jjanes: "I've verified that this does not break the installation or the upgrade of simple PostgreSQL installs." [core] - 10https://gerrit.wikimedia.org/r/167655 (owner: 10Chad) [18:17:13] 3MediaWiki / 3Internationalization: Interlanguage list should be rendered according to context language (user interface language) - 10https://bugzilla.wikimedia.org/37703#c12 (10Lydia Pintscher) *** Bug 72423 has been marked as a duplicate of this bug. *** [18:17:19] (03PS1) 10Umherirrender: Add el_from_namespace support to api modules [core] - 10https://gerrit.wikimedia.org/r/170746 [18:18:15] (03CR) 10Umherirrender: "The api part is now in I57bfa8f2570446e3978cc9bf647428ae50b8318e (with the necessary changes to the l10n changes in the api code)" [core] - 10https://gerrit.wikimedia.org/r/163470 (https://bugzilla.wikimedia.org/10593) (owner: 10Umherirrender) [18:19:20] (03PS16) 10EBernhardson: build: Implement Grunt workflow (via npm test) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163908 (owner: 10Spage) [18:19:30] (03CR) 10jenkins-bot: [V: 04-1] build: Implement Grunt workflow (via npm test) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163908 (owner: 10Spage) [18:19:57] 3Wikimedia / 3Extension setup: Architecture review for BounceHandler extension - 10https://bugzilla.wikimedia.org/69101 (10Sam Reed (reedy)) [18:19:57] 3MediaWiki extensions / 3BounceHandler: Performance review BounceHandler extension for Deployment - 10https://bugzilla.wikimedia.org/69100 (10Sam Reed (reedy)) [18:19:57] 3Wikimedia / 3Extension setup: Review and deploy BounceHandler extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/69019 (10Sam Reed (reedy)) [18:21:40] 3MediaWiki extensions / 3BounceHandler: Performance review BounceHandler extension for Deployment - 10https://bugzilla.wikimedia.org/69100#c9 (10Sam Reed (reedy)) 5PATC>3NEW (In reply to Sam Reed (reedy) from comment #7) > CREATE INDEX /*i*/br_mail_timestamp ON /*_*/user (br_user_email(50), > br_timestam... [18:22:44] (03CR) 10EBernhardson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169499 (owner: 10Matthias Mullie) [18:22:54] (03PS3) 10Yuvipanda: Add hiera config link to project special page [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/170699 [18:23:05] legoktm: ^ [18:25:04] (03CR) 10Legoktm: [C: 031] "LGTM, added Siebrand for i18n." [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/170699 (owner: 10Yuvipanda) [18:25:29] (03PS1) 10MaxSem: Add WikiGrok [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170749 [18:26:39] (03PS1) 10MaxSem: Add WikiGrok [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170750 [18:26:53] MaxSem: behave [18:29:02] behave? i'm behaving to the best standards imaginable [18:30:34] (03CR) 10EBernhardson: [C: 032] Show more descriptive error message for insufficient permissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166575 (https://bugzilla.wikimedia.org/70497) (owner: 10Matthias Mullie) [18:31:22] (03Merged) 10jenkins-bot: Show more descriptive error message for insufficient permissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166575 (https://bugzilla.wikimedia.org/70497) (owner: 10Matthias Mullie) [18:36:07] (03PS1) 10Manybubbles: Cirrus updates for 1.24 [extensions/CirrusSearch] (REL1_24) - 10https://gerrit.wikimedia.org/r/170754 [18:45:41] 3MediaWiki extensions / 3SemanticForms: "Add another" feature for multiple-instance templates broken with MW >= 1.24 - 10https://bugzilla.wikimedia.org/72900#c4 (10Yaron Koren) If you add "&debug=true" (or "?debug=true") to the URL, it will probably give a more helpful message about the exact line number in... [18:54:56] 3MediaWiki extensions / 3BounceHandler: ApiBounceHandler improvements - 10https://bugzilla.wikimedia.org/72685 (10Sam Reed (reedy)) 5PATC>3NEW [18:55:31] (03PS1) 1001tonythomas: Create table index for 'bounce_records' table [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170759 (https://bugzilla.wikimedia.org/69100) [18:55:39] (03CR) 10jenkins-bot: [V: 04-1] Create table index for 'bounce_records' table [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170759 (https://bugzilla.wikimedia.org/69100) (owner: 1001tonythomas) [18:56:39] (03CR) 10Reedy: [C: 04-1] Create table index for 'bounce_records' table (031 comment) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170759 (https://bugzilla.wikimedia.org/69100) (owner: 1001tonythomas) [18:57:40] 3Wikimedia / 3Site requests: http://tools.wikimedia.pl/~odder add to whitelist - 10https://bugzilla.wikimedia.org/72897 (10Sam Reed (reedy)) p:5Unprio>3Normal s:5normal>3enhanc [18:58:15] (03CR) 10MaxSem: [C: 032 V: 032] Add WikiGrok [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170749 (owner: 10MaxSem) [18:58:33] (03CR) 10MaxSem: [C: 032 V: 032] Add WikiGrok [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170750 (owner: 10MaxSem) [18:58:49] herewegoherewegoagain [19:00:05] anomie: do you see any more obvious way to solve the indicator issue? [19:00:24] (03CR) 10MaxSem: [C: 032] Add WikiGrok [tools/release] - 10https://gerrit.wikimedia.org/r/170454 (owner: 10MaxSem) [19:00:35] (03Merged) 10jenkins-bot: Add WikiGrok [tools/release] - 10https://gerrit.wikimedia.org/r/170454 (owner: 10MaxSem) [19:01:37] MatmaRex: Not really. [19:02:26] (03CR) 10Legoktm: [C: 04-1] UserLogin: Allow extensions to add valid error messages (034 comments) [core] - 10https://gerrit.wikimedia.org/r/170520 (https://bugzilla.wikimedia.org/71769) (owner: 10Florianschmidtwelzow) [19:02:36] (03PS2) 1001tonythomas: Create table index for 'bounce_records' table [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170759 (https://bugzilla.wikimedia.org/69100) [19:03:28] Reedy: ^ [19:03:30] (03CR) 10Legoktm: [C: 032] Use getConnectionRef() so that reuseConnection() gets called [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/170737 (owner: 10Aaron Schulz) [19:04:03] (03CR) 10Reedy: [C: 04-1] "You should add the index to the bounce_records.sql file too. Makes life easier for us when adding to WMF wikis, so we just have to process" [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170759 (https://bugzilla.wikimedia.org/69100) (owner: 1001tonythomas) [19:04:37] (03CR) 10Legoktm: [C: 032] resourceloader: Document that WikiModule::getDB() may return IDatabase [core] - 10https://gerrit.wikimedia.org/r/170735 (owner: 10Aaron Schulz) [19:07:24] (03PS1) 10Legoktm: Use LoadBalancer::getConnectionRef() so that reuseConnection() gets called [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/170763 [19:07:34] AaronSchulz: ^ [19:07:49] (03PS3) 1001tonythomas: Create table index for 'bounce_records' table [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170759 (https://bugzilla.wikimedia.org/69100) [19:09:57] Reedy: ^ I pasted the CREATE index in the other file too. looks good ? [19:11:51] (03Merged) 10jenkins-bot: Use getConnectionRef() so that reuseConnection() gets called [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/170737 (owner: 10Aaron Schulz) [19:15:40] 3MediaWiki / 3Templates: mr-wikibooks requests support for Template:Random Subpage - 10https://bugzilla.wikimedia.org/72878#c4 (10Bawolff (Brian Wolff)) I fixed the template. (On wikis which use non arabic-hindu digits (or whatever the proper name is for 1,2,3,4,5,6,7,8,9,0 is), you can't use {{#time:U}} dir... [19:16:19] jackmcbarn: you around? have you looked at the latest indicator thing? :/ [19:16:35] (03Merged) 10jenkins-bot: resourceloader: Document that WikiModule::getDB() may return IDatabase [core] - 10https://gerrit.wikimedia.org/r/170735 (owner: 10Aaron Schulz) [19:16:53] (03PS1) 10Jforrester: VisualEditor: Provide the tool in the toolbar [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/170765 [19:17:12] (03CR) 10JanZerebecki: [C: 04-1] "Aproach of this patch seems ok. Small things that need fixing inline." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/168587 (https://bugzilla.wikimedia.org/72478) (owner: 10Daniel Kinzler) [19:17:39] (03CR) 10Catrope: [C: 032] VisualEditor: Provide the tool in the toolbar [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/170765 (owner: 10Jforrester) [19:17:55] (03Merged) 10jenkins-bot: VisualEditor: Provide the tool in the toolbar [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/170765 (owner: 10Jforrester) [19:18:47] (03CR) 10Reedy: [C: 032] "WFM" [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170759 (https://bugzilla.wikimedia.org/69100) (owner: 1001tonythomas) [19:19:01] (03Merged) 10jenkins-bot: Create table index for 'bounce_records' table [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170759 (https://bugzilla.wikimedia.org/69100) (owner: 1001tonythomas) [19:19:55] 3MediaWiki extensions / 3BounceHandler: Performance review BounceHandler extension for Deployment - 10https://bugzilla.wikimedia.org/69100 (10Sam Reed (reedy)) 5PATC>3NEW [19:20:28] Reedy: yay ! [19:22:14] (03CR) 10Legoktm: [C: 031] "Looks fine to me" [core] - 10https://gerrit.wikimedia.org/r/170530 (owner: 10Hoo man) [19:22:25] tonythomas: You should fixup your api module parameter handling [19:22:59] 3MediaWiki extensions / 3ParserFunctions: #expr error doesn't show non-ascii glyphs - 10https://bugzilla.wikimedia.org/72913 (10Bawolff (Brian Wolff)) 3NEW p:3Unprio s:3normal a:3None Do the wikitext: {{#expr:ģ}} Expected behaviour: Expression error: Unrecognized punctuation character "ģ". Actual... [19:23:01] Reedy: yeah. working on getAllowedParams [19:23:15] (03CR) 10JanZerebecki: [C: 04-1] "Missing a test that fails if the transformation does not happen." [core] - 10https://gerrit.wikimedia.org/r/168126 (https://bugzilla.wikimedia.org/72361) (owner: 10Daniel Kinzler) [19:32:00] (03CR) 10EBernhardson: [C: 032] Add automatic edit summaries for new topic & edit post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169499 (owner: 10Matthias Mullie) [19:36:42] 3Wikimedia / 3Bugzilla: Include "MediaWiki skins" in default bugzilla search - 10https://bugzilla.wikimedia.org/72915 (10Umherirrender) 3NEW p:3Unprio s:3normal a:3None With bug 66441 a new product in bugzilla was added, with the name "MediaWiki skins". This should also be default in the "Advanced se... [19:38:25] (03PS1) 10Foxtrott: Fix Travis for MW 1.25 Psr/Logger issue [skins/chameleon] - 10https://gerrit.wikimedia.org/r/170772 [19:39:19] (03PS2) 10Foxtrott: Fix Travis for MW 1.25 Psr/Logger issue [skins/chameleon] - 10https://gerrit.wikimedia.org/r/170772 [19:39:35] (03CR) 10Foxtrott: [C: 032 V: 032] Fix Travis for MW 1.25 Psr/Logger issue [skins/chameleon] - 10https://gerrit.wikimedia.org/r/170772 (owner: 10Foxtrott) [19:43:29] (03CR) 10Legoktm: [C: 031] "I think it depends on the level of error reporting setup. If I set error_reporting(0), then I only see one error message. If I have it set" [core] - 10https://gerrit.wikimedia.org/r/170274 (https://bugzilla.wikimedia.org/72777) (owner: 10BryanDavis) [19:46:12] (03CR) 10Manybubbles: Enable profiling via xhprof (032 comments) [core] - 10https://gerrit.wikimedia.org/r/168930 (owner: 10BryanDavis) [19:49:59] (03PS5) 10Florianschmidtwelzow: UserLogin: Allow extensions to add valid error messages [core] - 10https://gerrit.wikimedia.org/r/170520 (https://bugzilla.wikimedia.org/71769) [19:50:14] (03PS1) 10Jdlrobson: Use mw.template.compile for compiling [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/170776 [19:50:54] (03CR) 10Florianschmidtwelzow: UserLogin: Allow extensions to add valid error messages (034 comments) [core] - 10https://gerrit.wikimedia.org/r/170520 (https://bugzilla.wikimedia.org/71769) (owner: 10Florianschmidtwelzow) [19:53:10] chrismcmalunch, can you run your tests against testwiki to make sure nothing's broken, please? [20:01:06] (03PS19) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [20:01:40] 3MediaWiki extensions / 3SemanticForms: "Add another" feature for multiple-instance templates broken with MW >= 1.24 - 10https://bugzilla.wikimedia.org/72900#c5 (10Joel K. Pettersson) Just tried it. The first line is load.php:10344 - which simply leads to a console.log() call in jQuery. The rest points to lo... [20:02:39] dr0ptp4kt: Can u point me to some discussion of Varnish's ESI shortcomings? [20:03:26] i'll be over there after a bit, okay? sitting in "batcave". i think that's what "they" call it these days [20:04:12] hehe no rush [20:04:21] I've been wondering about this for... over a year now. [20:09:30] (03CR) 10Legoktm: UserLogin: Allow extensions to add valid error messages (032 comments) [core] - 10https://gerrit.wikimedia.org/r/170520 (https://bugzilla.wikimedia.org/71769) (owner: 10Florianschmidtwelzow) [20:15:25] 3MediaWiki / 3Internationalization: Superfluous -{R| }- appears on https://zh.wikipedia.org/w/api.php around links - 10https://bugzilla.wikimedia.org/72875#c2 (10Brad Jorsch) 5RESO/DUP>3REOP This doesn't look like a duplicate of that bug to me. Bug 52661 is about the parser interpreting bits of the varia... [20:16:44] 3MediaWiki extensions / 3SemanticForms: "Add another" feature for multiple-instance templates broken with MW >= 1.24 - 10https://bugzilla.wikimedia.org/72900#c6 (10Yaron Koren) Oh, okay. Are you using "show on select" within the form? If not, my guess is that the second error is just a result of the first er... [20:16:45] 3Wikimedia / 3Bugzilla: Include "MediaWiki skins" in default bugzilla search - 10https://bugzilla.wikimedia.org/72915#c1 (10Andre Klapper) 5NEW>3RESO/FIX a:3Andre Klapper Makes sense. Done. [20:17:15] (03PS6) 10Florianschmidtwelzow: UserLogin: Allow extensions to add valid error messages [core] - 10https://gerrit.wikimedia.org/r/170520 (https://bugzilla.wikimedia.org/71769) [20:19:56] 3Wikimedia / 3Site requests: Purge cache for all it.m.wikipedia.org pages - 10https://bugzilla.wikimedia.org/72856#c6 (10Brandon Black) 5NEW>3ASSI a:3Brandon Black I've purged it.m.wikipedia.org on the mobile caches, can someone confirm it had the intended effect? [20:21:15] Nemo_bis: ^^ [20:23:11] 3Wikimedia / 3Site requests: Purge cache for all it.m.wikipedia.org pages - 10https://bugzilla.wikimedia.org/72856#c7 (10Florian) Confirmed with some random articles :) Thanks! (RESO/FIXED?) [20:24:39] (03CR) 10Anomie: Componentize Title permissions logic (036 comments) [core] - 10https://gerrit.wikimedia.org/r/166357 (owner: 10Awight) [20:26:27] FlorianSW: https://gerrit.wikimedia.org/r/#/c/170520/6/includes/specials/SpecialUserlogin.php,cm isn't it still string[] ? [20:26:46] anomie: great comments, thanks! [20:26:56] (03PS2) 10Mooeypoo: [wip] Adding paramOrder widget to TemplateData editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/170655 [20:26:59] legoktm: sure, it's still string, sorry :( [20:27:12] MaxSem: i ran the core browser tests and there are two failures [20:27:14] FlorianSW: fix that and I'll +2 :) [20:27:25] molliug, why are there RT links in the monthly engineering report? [20:27:29] legoktm: give me 30 seconds :P [20:27:31] (03CR) 10jenkins-bot: [V: 04-1] [wip] Adding paramOrder widget to TemplateData editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/170655 (owner: 10Mooeypoo) [20:28:03] (03PS1) 10Mattflaschen: Expand anchors to full URL on server rendering [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170785 (https://bugzilla.wikimedia.org/72490) [20:28:27] (03PS7) 10Florianschmidtwelzow: UserLogin: Allow extensions to add valid error messages [core] - 10https://gerrit.wikimedia.org/r/170520 (https://bugzilla.wikimedia.org/71769) [20:29:01] (03CR) 10Legoktm: [C: 032] UserLogin: Allow extensions to add valid error messages [core] - 10https://gerrit.wikimedia.org/r/170520 (https://bugzilla.wikimedia.org/71769) (owner: 10Florianschmidtwelzow) [20:29:06] legoktm: ^ [20:29:11] :P [20:29:44] thanks legoktm [20:29:51] :) [20:32:30] (03CR) 10Mattflaschen: "Jon, this is so we don't have a broken user experience pending the #link discussions. Let me know if this breaks the mobile UX somehow." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170785 (https://bugzilla.wikimedia.org/72490) (owner: 10Mattflaschen) [20:33:26] (03PS41) 10Werdna: Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) [20:34:13] (03CR) 10jenkins-bot: [V: 04-1] Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [20:34:18] (03CR) 10Legoktm: "I don't see a CSSJanusTest?" [core] - 10https://gerrit.wikimedia.org/r/170107 (owner: 10Legoktm) [20:34:50] (03Merged) 10jenkins-bot: UserLogin: Allow extensions to add valid error messages [core] - 10https://gerrit.wikimedia.org/r/170520 (https://bugzilla.wikimedia.org/71769) (owner: 10Florianschmidtwelzow) [20:36:41] 3MediaWiki extensions / 3GoogleLogin: Login link redirect to default login (not GoogleLogin) - 10https://bugzilla.wikimedia.org/72909#c2 (10tim.schenk) Florian, thanks for your help. Changing the order in which the extensions load solves my problem. Thanks again for the fast reply! [20:37:35] (03PS1) 10Cscott: Updating to latest masters [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/170788 [20:37:42] 3MediaWiki / 3Special pages: Unable to add new custom messages to validErrorMessages - 10https://bugzilla.wikimedia.org/71769 (10Florian) 5PATC>3RESO/FIX [20:38:53] (03CR) 10Legoktm: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/169839 (owner: 10Anomie) [20:39:48] (03CR) 10Bartosz Dziewoński: "Was already removed in 282847e6d3c4328138f4d6a056b759d38af68e9a." [core] - 10https://gerrit.wikimedia.org/r/170107 (owner: 10Legoktm) [20:40:04] James_F: https://gerrit.wikimedia.org/r/#/c/169803/1 what does "Sort of i18n files" mean? [20:40:21] (03CR) 10Cscott: [C: 032 V: 032] Updating to latest masters [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/170788 (owner: 10Cscott) [20:40:34] (03PS1) 10Cscott: Merge branch 'master' into wmf-deploy [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/170791 [20:41:01] (03CR) 10Cscott: [C: 032 V: 032] Merge branch 'master' into wmf-deploy [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/170791 (owner: 10Cscott) [20:41:14] (03CR) 10Legoktm: [C: 031] Add i18n for API module help [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/169803 (owner: 10Anomie) [20:42:38] legoktm: The i18n files need to be sorted. [20:42:46] legoktm: Alphabetic sort. [20:42:54] but it's not currently sorted. [20:43:05] (03CR) 10Spage: [C: 04-1] "The qunit failure is" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170150 (https://bugzilla.wikimedia.org/72780) (owner: 10EBernhardson) [20:43:15] legoktm: Even more reason to fix it. ;-) [20:43:23] that's not a reason to block the patch though. [20:43:33] (IMO) [20:43:49] legoktm: I fixed it, just didn't push it seems. [20:43:50] Whoops. [20:44:05] * James_F re-fixes. [20:44:11] I told Brad I'd fix and merge. [20:44:31] (03CR) 10Legoktm: [C: 032] Add i18n for API module help [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/169829 (owner: 10Anomie) [20:44:44] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/169829 (owner: 10Anomie) [20:45:10] (03CR) 10Legoktm: [C: 032] Add i18n for API module help [extensions/MarkAsHelpful] - 10https://gerrit.wikimedia.org/r/169826 (owner: 10Anomie) [20:45:22] (03PS2) 10Jforrester: Add i18n for API module help [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/169803 (owner: 10Anomie) [20:45:35] (03CR) 10Jforrester: [C: 032] Add i18n for API module help [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/169803 (owner: 10Anomie) [20:47:07] (03CR) 10Legoktm: [C: 032] Add i18n for API module help [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/169823 (owner: 10Anomie) [20:47:19] (03PS1) 10Catrope: Update VisualEditor for cherry-picks [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170793 [20:47:30] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/MarkAsHelpful] - 10https://gerrit.wikimedia.org/r/169826 (owner: 10Anomie) [20:48:22] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/169803 (owner: 10Anomie) [20:48:24] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/169823 (owner: 10Anomie) [20:56:05] MatmaRex: yeah, i see it [20:56:37] (03PS1) 10Catrope: Update VisualEditor for cherry-picks [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170795 [20:58:23] (03CR) 10Legoktm: [C: 032] "Adding Raymond since the new directory will need to be added to TWN" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/169818 (owner: 10Anomie) [20:59:20] (03CR) 10Legoktm: [C: 032] Add i18n for API module help [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/169809 (owner: 10Anomie) [21:00:52] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/169818 (owner: 10Anomie) [21:00:54] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/169809 (owner: 10Anomie) [21:03:45] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (571f26d0ab) [core] - 10https://gerrit.wikimedia.org/r/170802 [21:04:21] 3MediaWiki extensions / 3GoogleLogin: Login link redirect to default login (not GoogleLogin) - 10https://bugzilla.wikimedia.org/72909#c3 (10Florian) Thanks for confirm this :) Added the info to the Extension page: [[Extension:GoogleLogin#MobileFrontend_.3C-.3E_GoogleLogin_conflict_.28only_with_.24wgGLReplac... [21:04:22] 3MediaWiki / 3Configuration: wikigender.org is no longer blacklisted but is still blocked. - 10https://bugzilla.wikimedia.org/72921 (10richshup) 3UNCO p:3Unprio s:3normal a:3None 1. I verified that wikigender.org is no longer blacklisted, in the Wikimedia blacklist (or whatever the correct name is).... [21:04:23] 3MediaWiki extensions / 3SemanticForms: "Add another" feature for multiple-instance templates broken with MW >= 1.24 - 10https://bugzilla.wikimedia.org/72900#c8 (10Yaron Koren) Could you include your form definition here? (Assuming this only happens to you with one form.) [21:05:09] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (571f26d0ab) [core] - 10https://gerrit.wikimedia.org/r/170802 (owner: 10Jforrester) [21:05:38] (03PS2) 10Legoktm: Add i18n for API module help [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/169804 (owner: 10Anomie) [21:05:54] (03PS1) 10Cscott: Rebuilding dependencies [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/170803 [21:08:02] (03CR) 10Legoktm: [C: 032] "PS2 was a rebase in the 18n files" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/169804 (owner: 10Anomie) [21:08:40] 3MediaWiki extensions / 3GoogleLogin: Login link redirect to default login (not GoogleLogin) - 10https://bugzilla.wikimedia.org/72909#c4 (10Florian) :/ MediaWiki.org links seems not to work: https://www.mediawiki.org/wiki/Extension:GoogleLogin#MobileFrontend_.3C-.3E_GoogleLogin_conflict_.28only_with_.24wgGLR... [21:08:58] 3MediaWiki / 3Parser: {{!}} always treated as literal instead of separator when the template is transcluded - 10https://bugzilla.wikimedia.org/72920 (10Diego Queiroz) 3UNCO p:3Unprio s:3normal a:3None It is hard for me to describe this problem, so I made a simple (and useless) example to describe thi... [21:09:08] (03CR) 10Legoktm: [C: 032] Add i18n for API module help [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/169833 (owner: 10Anomie) [21:09:11] 3MediaWiki extensions / 3SemanticForms: "Add another" feature for multiple-instance templates broken with MW >= 1.24 - 10https://bugzilla.wikimedia.org/72900#c7 (10Joel K. Pettersson) It's not being used within the form, but I tried disabling WikiEditor anyway, and the "Add another" button problem persisted... [21:10:20] (03PS2) 10Legoktm: Add i18n for API module help and mark ApiScribuntoConsole as internal [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/169834 (owner: 10Anomie) [21:10:25] (03CR) 10Legoktm: [C: 032] Add i18n for API module help and mark ApiScribuntoConsole as internal [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/169834 (owner: 10Anomie) [21:10:59] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (571f26d0ab) [core] - 10https://gerrit.wikimedia.org/r/170802 (owner: 10Jforrester) [21:11:01] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/169804 (owner: 10Anomie) [21:11:03] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/169833 (owner: 10Anomie) [21:11:12] (03CR) 10Legoktm: [C: 032] Add i18n for API module help [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/169835 (owner: 10Anomie) [21:12:46] (03Merged) 10jenkins-bot: Add i18n for API module help and mark ApiScribuntoConsole as internal [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/169834 (owner: 10Anomie) [21:12:48] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/169835 (owner: 10Anomie) [21:13:34] (03CR) 10EBernhardson: "best guess is deferred updates is being added to in another test, but not executed untill this test. Looking into a fix." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/169839 (owner: 10Anomie) [21:21:31] Hmm, I'm missing the Psr\Log thing... do I just need to clone mw/vendor to fix that? [21:22:00] (03CR) 10Legoktm: [C: 032] Add i18n for API module help [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/169838 (owner: 10Anomie) [21:22:11] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/169838 (owner: 10Anomie) [21:22:12] Lcawte: yes, or install Composer and run `composer install` [21:22:36] Lcawte: https://lists.wikimedia.org/pipermail/wikitech-l/2014-October/079232.html [21:22:41] or ^ [21:22:46] (03PS2) 10Cscott: Rebuilding dependencies [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/170803 [21:23:00] we're working on having a better error message [21:23:33] That's error logging and not... "mediawiki logging" for lack of a better phrase right? [21:23:39] (03PS2) 10EBernhardson: Add i18n for API module help [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/169839 (owner: 10Anomie) [21:26:28] (03CR) 10Legoktm: [C: 032] Add i18n for API module help [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/169840 (owner: 10Anomie) [21:26:31] (03CR) 10jenkins-bot: [V: 04-1] Add i18n for API module help [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/169839 (owner: 10Anomie) [21:27:09] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/169840 (owner: 10Anomie) [21:27:57] debug logging vs Special:log logging? :P [21:28:43] (03CR) 10Legoktm: [C: 032] Add i18n for API module help [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/169841 (owner: 10Anomie) [21:28:58] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/169841 (owner: 10Anomie) [21:29:37] legoktm: Yus. [21:31:58] (03CR) 10Aaron Schulz: [C: 032] Use LoadBalancer::getConnectionRef() so that reuseConnection() gets called [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/170763 (owner: 10Legoktm) [21:32:12] (03Merged) 10jenkins-bot: Use LoadBalancer::getConnectionRef() so that reuseConnection() gets called [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/170763 (owner: 10Legoktm) [21:32:32] (03PS3) 10EBernhardson: Add i18n for API module help [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/169839 (owner: 10Anomie) [21:33:02] gwicke: https://gerrit.wikimedia.org/r/#/c/170761/ [21:33:11] oh, wait, interview, heh :) [21:36:12] (03PS3) 10Spage: Bug: Finish removing post_moderation_state msg [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170150 (https://bugzilla.wikimedia.org/72780) (owner: 10EBernhardson) [21:36:16] (03PS1) 10Jdlrobson: Name and shame modules that still use ResourceLoaderTemplateModule [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/170813 [21:36:52] (03CR) 10EBernhardson: [C: 031] "I wasn't able to reproduce, so i'm not sure which tests are inserting to deferred updates and then not clearing them." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/169839 (owner: 10Anomie) [21:38:21] (03CR) 10Spage: [C: 031] "I think my Resources.php change made qunit pass..." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170150 (https://bugzilla.wikimedia.org/72780) (owner: 10EBernhardson) [21:38:57] (03PS1) 10Gilles: Revert layout changes in Media viewer [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170816 [21:40:19] legoktm: For the Bouquet thing, how would I pass the Theme config option in? Does the setupTemplate override the default config item? (Since the $this->config->get() seems to be fine for getting stuff from the Truglass config object?) https://gerrit.wikimedia.org/r/#/c/168913/1/Bouquet.skin.php,cm [21:41:15] (03CR) 10Cmcmahon: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169971 (owner: 10Cmcmahon) [21:42:43] 3MediaWiki extensions / 3TitleBlacklist: User should be warned if moving a page to a blacklisted title - 10https://bugzilla.wikimedia.org/72926 (10od_mishehu) 3NEW p:3Unprio s:3enhanc a:3None Currently, on English Wikipedia, if I (an admin) try to move a page to a blacklisted title, I get no notifica... [21:42:58] (03PS1) 10EBernhardson: Clear DeferredUpdates state via setUp() [core] - 10https://gerrit.wikimedia.org/r/170819 (https://bugzilla.wikimedia.org/72922) [21:43:58] (03PS1) 10Cscott: Configure bunyan logging to syslog. [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/170826 [21:44:01] (03PS2) 10EBernhardson: Clear DeferredUpdates state via setUp() [core] - 10https://gerrit.wikimedia.org/r/170819 (https://bugzilla.wikimedia.org/72922) [21:44:17] (03PS2) 10Ori.livneh: Made LogEventsList use the log bloom filter, not just the Article class [core] - 10https://gerrit.wikimedia.org/r/170441 (owner: 10Aaron Schulz) [21:44:18] (03CR) 10Cscott: [C: 032 V: 032] Rebuilding dependencies [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/170803 (owner: 10Cscott) [21:44:24] (03CR) 10Ori.livneh: [C: 032] Made LogEventsList use the log bloom filter, not just the Article class [core] - 10https://gerrit.wikimedia.org/r/170441 (owner: 10Aaron Schulz) [21:44:31] (03CR) 10Cscott: [C: 032 V: 032] Configure bunyan logging to syslog. [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/170826 (owner: 10Cscott) [21:46:11] 3MediaWiki extensions / 3SemanticForms: "Add another" feature for multiple-instance templates broken with MW >= 1.24 - 10https://bugzilla.wikimedia.org/72900#c9 (10Joel K. Pettersson) I only had one form using multiple instance templates, but I just made a greatly cut down test form. It still shows the probl... [21:46:28] (03CR) 10EBernhardson: [C: 032] Bug: Finish removing post_moderation_state msg [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170150 (https://bugzilla.wikimedia.org/72780) (owner: 10EBernhardson) [21:49:41] (03CR) 10BryanDavis: "Responses inline to Nik's comments." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/168930 (owner: 10BryanDavis) [21:51:05] (03Merged) 10jenkins-bot: Made LogEventsList use the log bloom filter, not just the Article class [core] - 10https://gerrit.wikimedia.org/r/170441 (owner: 10Aaron Schulz) [21:51:12] (03Merged) 10jenkins-bot: Bug: Finish removing post_moderation_state msg [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170150 (https://bugzilla.wikimedia.org/72780) (owner: 10EBernhardson) [21:52:34] (03PS3) 10Spage: Bug: Wrong i18n message for some moderation actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170154 (https://bugzilla.wikimedia.org/72780) (owner: 10EBernhardson) [21:53:54] (03PS1) 10Foxtrott: New layout "clean"; new modifications HideFor, ShowOnlyFor [skins/chameleon] - 10https://gerrit.wikimedia.org/r/170834 [21:54:11] (03PS2) 10Foxtrott: New layout "clean"; new modifications HideFor, ShowOnlyFor [skins/chameleon] - 10https://gerrit.wikimedia.org/r/170834 [21:55:14] (03CR) 10Legoktm: [C: 032] Add i18n for API module help [extensions/UserDailyContribs] - 10https://gerrit.wikimedia.org/r/169845 (owner: 10Anomie) [21:55:26] (03PS1) 10Aaron Schulz: Added wgBounceHandlerCluster setting [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170835 [21:55:28] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/UserDailyContribs] - 10https://gerrit.wikimedia.org/r/169845 (owner: 10Anomie) [21:56:50] (03CR) 10Jdlrobson: "The only problem with this is on mobile clicking this link will trigger a redirect so 2 http requests to get to the destination and if you" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170785 (https://bugzilla.wikimedia.org/72490) (owner: 10Mattflaschen) [21:56:55] (03CR) 10Legoktm: [C: 032] Add i18n for API module help [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/169802 (owner: 10Anomie) [21:57:29] (03CR) 10Jdlrobson: [C: 032] SpecialSearch: Use CSS instead of cellpadding and cellspacing [core] - 10https://gerrit.wikimedia.org/r/170296 (https://bugzilla.wikimedia.org/72458) (owner: 10Prtksxna) [21:59:06] legoktm: wat, why is config on a wiki page?! [21:59:07] legoktm: NOOOOO [21:59:55] what? [22:01:19] Krenair: wikibugs2 [22:01:43] legoktm: also dogpile isn't py3 compliant [22:02:10] (03CR) 10Foxtrott: [C: 032 V: 032] New layout "clean"; new modifications HideFor, ShowOnlyFor [skins/chameleon] - 10https://gerrit.wikimedia.org/r/170834 (owner: 10Foxtrott) [22:02:18] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/169802 (owner: 10Anomie) [22:02:20] (03PS1) 10Cscott: Brown paper bag bug fix for If9e1c690831001f79e8119267fdaaad13ab244d5. [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/170836 [22:02:22] (03CR) 10EBernhardson: [C: 031] "this should work for now until we can get better support in core" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170785 (https://bugzilla.wikimedia.org/72490) (owner: 10Mattflaschen) [22:02:48] (03CR) 10Cscott: [C: 032 V: 032] Brown paper bag bug fix for If9e1c690831001f79e8119267fdaaad13ab244d5. [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/170836 (owner: 10Cscott) [22:02:55] (03PS4) 10Spage: Bug: Wrong i18n message for some moderation actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170154 (https://bugzilla.wikimedia.org/72780) (owner: 10EBernhardson) [22:03:19] YuviPanda: because wikipages are awesome, and I don't like having to deploy stuff manually, it should just be automatic. [22:03:32] legoktm: well, no review!!1!11 [22:03:34] (03Merged) 10jenkins-bot: SpecialSearch: Use CSS instead of cellpadding and cellspacing [core] - 10https://gerrit.wikimedia.org/r/170296 (https://bugzilla.wikimedia.org/72458) (owner: 10Prtksxna) [22:03:46] YuviPanda: do you know of another caching library besides dogpile? [22:03:49] that was the first one in google [22:03:55] legoktm: why do you need a caching library? [22:03:57] just use redis... [22:04:27] but fancy decorators!!!111 [22:04:38] (03CR) 10Spage: [C: 032] "PS4 was just template recompile, updating flow_block_board-history.handlebars.php. Carrying forward +2." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170154 (https://bugzilla.wikimedia.org/72780) (owner: 10EBernhardson) [22:04:45] legoktm: nooooooo [22:04:47] :P [22:04:57] legoktm: we can make decorators simply enough, but I think not using them in this case is clearer [22:05:01] okay [22:05:11] I'm also not sure if redis is even needed [22:05:24] (03Merged) 10jenkins-bot: Bug: Wrong i18n message for some moderation actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170154 (https://bugzilla.wikimedia.org/72780) (owner: 10EBernhardson) [22:05:30] just a dictionary should be fine [22:08:29] 3MediaWiki extensions / 3SecurePoll: Securepoll-htmlform-daterange-relative-layout needs PLURAL support - 10https://bugzilla.wikimedia.org/68267#c1 (10Brad Jorsch) 5NEW>3RESO/INV There is no specific number. The value of $2 is an HTML or