[00:06:08] (03PS1) 10MarkAHershberger: 1.24.0-rc.0 [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/170259 [00:06:29] 3MediaWiki / 3API: link in API help for uselang "list of codes" doesn't show list of codes - 10https://bugzilla.wikimedia.org/72798#c1 (10spage) p:5Unprio>3Low It's actually in includes/api/i18n/en.json: apihelp-main-param-uselang": "Language to use for message translations. A list of codes may be fetch... [00:11:28] (03PS2) 10MarkAHershberger: 1.24.0-rc.0 [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/170259 [00:12:42] (03PS1) 10Jdlrobson: Define interface for hide/show on all Views [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/170261 [00:14:12] (03CR) 10MarkAHershberger: "See I2255ac2999ad207203fa6514f2e1b23f5d7965d7" [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/170058 (owner: 10MarkAHershberger) [00:16:09] (03CR) 10MarkAHershberger: "Added a bit here to make one line shorter and stop (non-voting) test failures." [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/170259 (owner: 10MarkAHershberger) [00:18:52] (03PS11) 10Mattflaschen: JS sanity per Krinkle's patch [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166951 (owner: 10SG) [00:19:00] (03CR) 10jenkins-bot: [V: 04-1] JS sanity per Krinkle's patch [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166951 (owner: 10SG) [00:24:42] 3MediaWiki-Vagrant: Audit base install to see if resource footprint can be reduced - 10https://bugzilla.wikimedia.org/70421#c8 (10Bryan Davis) 5PATC>3RESO/FIX There is probably more that can be done on this front, but short of changing the jobrunner to use php5 instead of hhvm I don't see any easy wins. [00:25:41] (03PS3) 10Legoktm: 1.24.0-rc.0 [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/170259 (owner: 10MarkAHershberger) [00:34:45] (03PS1) 10EBernhardson: Prevent fatal error while running unit tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170266 [00:50:26] 3MediaWiki / 3JobQueue: Retry counts not working - 10https://bugzilla.wikimedia.org/71853#c5 (10Gabriel Wicke) @Aaron: Should we just clear the old jobs by temporarily merging https://gerrit.wikimedia.org/r/#/c/165635/ ? If it's still a problem with new jobs then we'll find new ones to investigate soon. If i... [01:14:39] grrrit-wm? [01:49:12] 3Wikimedia / 3Bugzilla: Can't register to phabricator.wikimedia.org - 10https://bugzilla.wikimedia.org/72776#c2 (10teo8976) > There is also a link in the banner on top of Bugzilla which links to > https://www.mediawiki.org/wiki/Phabricator/Help#Creating_your_account Oh, that comes after the link to https:... [02:20:27] 3Wikimedia / 3Bugzilla: Can't register to phabricator.wikimedia.org - 10https://bugzilla.wikimedia.org/72776#c3 (10MZMcBride) https://phabricator.wikimedia.org/T862 may be relevant here. :-) [02:37:17] https://www.mediawiki.org/w/index.php?title=User:Allen2/common.css&oldid=1246745 wtf? [04:26:14] 3Wikimedia / 3Deployment systems: [scap] "UnicodeDecodeError: 'ascii' codec can't decode byte" when announcing sync result to irc - 10https://bugzilla.wikimedia.org/68780 (10Bryan Davis) a:3Bryan Davis [05:53:26] 3Wikimedia / 3Extension setup: Plancake composer dependancy - 10https://bugzilla.wikimedia.org/72779#c3 (10Tony Thomas) Should I prepare a patch adding plancake to https://github.com/wikimedia/mediawiki-vendor/blob/master/composer.json and committing the downloaded dependencies into the same repo ? [07:51:27] 3Wikimedia / 3Site requests: Please upload large file to Commons - 10https://bugzilla.wikimedia.org/71911#c15 (10Vishnu) (In reply to Vishnu from comment #14) > (In reply to jeremyb from comment #13) > > Hi, sorry we (or at least I) forgot about this bug. > > > > Do you mind if I try uploading with chunked... [08:08:29] 3MediaWiki extensions / 3WikibaseQueryEngine: Update QueryEngine to use WB DB again - 10https://bugzilla.wikimedia.org/71501#c1 (10tobias.gritschacher) 5NEW>3ASSI Switch QueryEngine over from executing queries via DBAL to use WikibaseDatabase [08:08:42] 3MediaWiki extensions / 3WikibaseDatabase: DBAL adapter for QueryInterface in WB DB - 10https://bugzilla.wikimedia.org/71500 (10tobias.gritschacher) 5NEW>3ASSI [08:08:57] 3MediaWiki extensions / 3WikibaseQueryEngine: Investigate how to prevent schema definition code from not breaking - 10https://bugzilla.wikimedia.org/71503 (10tobias.gritschacher) 5NEW>3ASSI [08:47:48] (03PS1) 10KartikMistry: Add hi-ur and ur-hi language pairs to config [services/cxserver] - 10https://gerrit.wikimedia.org/r/170292 [08:48:43] Tobi_WMDE_SW_NA: "Investigate how to prevent schema definition code from not breaking" unintentionally funny [08:48:59] presumably you mean preventing it from breaking, not preventing it from not breaking :) [08:49:22] ori: ha, you're right [08:49:27] :D [08:50:03] (03CR) 10Mwjames: "Just yesterday I had to fix our Travis run due to the Psr install issue but this morning I had again to find our tests on MW 1.25 failing " [core] - 10https://gerrit.wikimedia.org/r/155872 (owner: 10Legoktm) [08:50:27] 3MediaWiki extensions / 3WikibaseQueryEngine: Investigate how to prevent schema definition code from breaking - 10https://bugzilla.wikimedia.org/71503 (10tobias.gritschacher) [09:04:21] (03PS2) 1001tonythomas: Fixed DB timestamp range query in BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170290 (https://bugzilla.wikimedia.org/72686) [09:04:30] (03CR) 10jenkins-bot: [V: 04-1] Fixed DB timestamp range query in BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170290 (https://bugzilla.wikimedia.org/72686) (owner: 1001tonythomas) [09:05:51] (03PS3) 1001tonythomas: Fixed DB timestamp range query in BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170290 (https://bugzilla.wikimedia.org/72686) [09:12:48] (03CR) 1001tonythomas: [C: 031] "Works as expected!" [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170290 (https://bugzilla.wikimedia.org/72686) (owner: 1001tonythomas) [09:18:44] 3MediaWiki extensions / 3Math: Undesired spaces added after math expressions - 10https://bugzilla.wikimedia.org/72806 (10Frédéric Wang) 3NEW p:3Unprio s:3normal a:3None If you type "\omega," then the MathML mode generates (03CR) 10Gilles: "My point was that you can try to call the function and then resort to something like what you're doing now if the function still returns s" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/169919 (owner: 10Gergő Tisza) [09:34:08] (03PS1) 10Umherirrender: Allow /-/ in MediaWikiVersionFetcher::fetchVersion [core] - 10https://gerrit.wikimedia.org/r/170295 [09:41:57] (03PS1) 10Prtksxna: SpecialSearch: Use CSS instead of cellpadding and cellspacing [core] - 10https://gerrit.wikimedia.org/r/170296 (https://bugzilla.wikimedia.org/72458) [09:48:54] (03CR) 10Gilles: [C: 032] Make tutorial step a controller and UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 (owner: 10MarkTraceur) [09:49:29] (03Merged) 10jenkins-bot: Make tutorial step a controller and UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 (owner: 10MarkTraceur) [09:54:03] (03CR) 10Hashar: "> Or we can wait about a month and then bump the minimum php version to 5.4 and call it all good." [core/vendor] - 10https://gerrit.wikimedia.org/r/147658 (owner: 10BryanDavis) [09:55:55] (03CR) 10Gilles: Move setSkipTutorialPreference to Tutorial class (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153413 (owner: 10MarkTraceur) [10:01:52] (03PS8) 10Gilles: Move setSkipTutorialPreference to Tutorial class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153413 (owner: 10MarkTraceur) [10:02:47] (03CR) 10Gilles: [C: 032] Move setSkipTutorialPreference to Tutorial class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153413 (owner: 10MarkTraceur) [10:03:20] (03Merged) 10jenkins-bot: Move setSkipTutorialPreference to Tutorial class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153413 (owner: 10MarkTraceur) [10:03:36] (03PS8) 10Gilles: Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 (owner: 10MarkTraceur) [10:13:01] (03CR) 10He7d3r: SpecialSearch: Use CSS instead of cellpadding and cellspacing (031 comment) [core] - 10https://gerrit.wikimedia.org/r/170296 (https://bugzilla.wikimedia.org/72458) (owner: 10Prtksxna) [10:16:51] (03PS2) 10Prtksxna: SpecialSearch: Use CSS instead of cellpadding and cellspacing [core] - 10https://gerrit.wikimedia.org/r/170296 (https://bugzilla.wikimedia.org/72458) [10:18:21] (03PS1) 10Raimond Spekking: Convert i18n to JSON [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/170297 [10:19:42] (03CR) 10Poke: "Considering that all new versions are now supposed to use semantic versioning, and also considering that this test is supposed to check wh" [core] - 10https://gerrit.wikimedia.org/r/170295 (owner: 10Umherirrender) [10:21:43] (03CR) 10Poke: [C: 031] Remove double semicolon [core] - 10https://gerrit.wikimedia.org/r/170083 (owner: 10Umherirrender) [10:23:48] (03CR) 10Raimond Spekking: "@Paladox: Conversion to JSON prepared with https://gerrit.wikimedia.org/r/#/c/170297/" [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/169787 (owner: 10Paladox) [10:25:19] (03CR) 10Poke: [C: 031] SpecialSearch: Use CSS instead of cellpadding and cellspacing [core] - 10https://gerrit.wikimedia.org/r/170296 (https://bugzilla.wikimedia.org/72458) (owner: 10Prtksxna) [10:33:42] (03CR) 10Gilles: [C: 04-1] "I get a JS error when I attempt to go from deeds to details:" (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 (owner: 10MarkTraceur) [10:43:48] 3OCG / 3PDF renderer: Bidirectional text sometimes in wrong order in PDF - 10https://bugzilla.wikimedia.org/71869#c5 (10Michael M.) Actually, I don't think the lang attribute should *ever* have any influence on the direction of the text. It can be used to select an appropriate font, but only the dir attribut... [10:44:43] (03PS1) 10Umherirrender: Fix doc of WikiPageTest::newPage [core] - 10https://gerrit.wikimedia.org/r/170301 [10:55:15] (03PS1) 10Umherirrender: Split doc for $wgHKDFSecret/$wgHKDFAlgorithm in DefaultSettings.php [core] - 10https://gerrit.wikimedia.org/r/170302 [10:59:23] (03PS1) 10Umherirrender: Always return string on HTMLTagFilter::getInputHTML [core] - 10https://gerrit.wikimedia.org/r/170303 [11:06:50] (03PS1) 10Umherirrender: Always return a value on SpecialRandomInCategory::onSubmit [core] - 10https://gerrit.wikimedia.org/r/170304 [11:15:43] (03CR) 10Umherirrender: "If you have a good regex for checking that, feel free to upload a own patch set, maybe that will be accepted. The regex has also to work f" [core] - 10https://gerrit.wikimedia.org/r/170295 (owner: 10Umherirrender) [11:18:03] (03CR) 10Florianschmidtwelzow: [C: 031] Always return string on HTMLTagFilter::getInputHTML [core] - 10https://gerrit.wikimedia.org/r/170303 (owner: 10Umherirrender) [11:23:29] (03CR) 10Aude: [C: 032] Fix doc of WikiPageTest::newPage [core] - 10https://gerrit.wikimedia.org/r/170301 (owner: 10Umherirrender) [11:24:12] (03CR) 10Aude: [C: 032] Remove double semicolon [core] - 10https://gerrit.wikimedia.org/r/170083 (owner: 10Umherirrender) [11:29:40] (03Merged) 10jenkins-bot: Fix doc of WikiPageTest::newPage [core] - 10https://gerrit.wikimedia.org/r/170301 (owner: 10Umherirrender) [11:30:02] (03Merged) 10jenkins-bot: Remove double semicolon [core] - 10https://gerrit.wikimedia.org/r/170083 (owner: 10Umherirrender) [11:31:57] 3MediaWiki extensions / 3CirrusSearch: Bold sidebar and search results when searching on is.wikipedia.org - 10https://bugzilla.wikimedia.org/61348#c13 (10Andre Klapper) 5NEW>3RESO/INV Nik: Thanks so much for tracking this down! Snævar: I'm closing this ticket as INVALID as this needs to be handled and f... [11:43:12] 3MediaWiki / 3Database: "ChangeTags::addTags" Database returned error "1205 Lock wait timeout exceeded; try restarting transaction" - 10https://bugzilla.wikimedia.org/72636 (10Andre Klapper) p:5Unprio>3Low [11:44:46] 3MediaWiki / 3Interface: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277#c88 (10Andre Klapper) (In reply to Dan Andreescu from comment #86) > Well, you can query the logs with SQL on our hadoop cluster if you'd like > more info (... [11:47:41] 3MediaWiki / 3Redirects: Redirects using relative links do not redirect - 10https://bugzilla.wikimedia.org/72682 (10Andre Klapper) p:5Unprio>3Low [11:58:56] 3MediaWiki / 3File management: Upload new file version: Auto convert image file format - Add info afterwards - 10https://bugzilla.wikimedia.org/72555#c4 (10Andre Klapper) p:5Unprio>3Low Exact and specific steps to reproduce still welcome. (There are several ways to upload files etc.) Or posting on https:... [11:59:02] (03CR) 10Raimond Spekking: "Before adding this extension to translatewiki.net the message prefixes have to be changed to "collapsiblevector-..." to avoid key conflict" [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/170297 (owner: 10Raimond Spekking) [11:59:11] 3Wikimedia / 3General/Unknown: Raw '#coordinates:' shown on articles due to Elastic/CirrusSearch disabling - 10https://bugzilla.wikimedia.org/72559#c10 (10Andyrom75) 5RESO/FIX>3REOP I've reopened because I've the problem has come back again. Just noticed in Wikivoyage (e.g. https://it.wikivoyage.org/wiki... [11:59:41] 3MediaWiki / 3Interface: Provide the OOUI PHP module inside MW core - 10https://bugzilla.wikimedia.org/72714 (10Andre Klapper) p:5Unprio>3High [11:59:43] 3MediaWiki / 3General/Unknown: Tarballs should include mediawiki/vendor repository - 10https://bugzilla.wikimedia.org/72726 (10Andre Klapper) p:5Unprio>3Normal [11:59:43] 3MediaWiki / 3User login and signup: Convert MW core login/logout/signup pages to OOUI - 10https://bugzilla.wikimedia.org/72715 (10Andre Klapper) p:5Unprio>3High [12:02:41] 3MediaWiki / 3Categories: sorting in category: B before A - 10https://bugzilla.wikimedia.org/72661#c4 (10Andre Klapper) p:5High>3Normal (In reply to Bartosz Dziewoński from comment #3) > The underlying software bug has been fixed a while ago So does that mean that this ticket should be moved to the Wiki... [12:03:43] 3MediaWiki / 3Parser: Support {{void}} as a magic word (currently {{void}} template to include empty strings into pages) - 10https://bugzilla.wikimedia.org/72775 (10Andre Klapper) 5UNCO>3NEW p:5Unprio>3Low s:5normal>3enhanc [12:06:12] 3Wikimedia / 3Bugzilla: Can't register to phabricator.wikimedia.org - 10https://bugzilla.wikimedia.org/72776#c4 (10Andre Klapper) 5UNCO>3RESO/FIX Yeah, good point. Thanks for reporting this again! I've changed the top banner on Bugzilla to state: ''Phabricator will replace Bugzilla soon''. For a smooth... [12:06:28] 3Wikimedia / 3Bugzilla: Can't register to phabricator.wikimedia.org - 10https://bugzilla.wikimedia.org/72776 (10Andre Klapper) a:3Andre Klapper [12:06:35] (03PS1) 10Florianschmidtwelzow: Use HTMLForm for Special:FileDuplicateSearch [core] - 10https://gerrit.wikimedia.org/r/170309 (https://bugzilla.wikimedia.org/71436) [12:06:42] 3MediaWiki / 3Uploading: Add chunked upload support to standard Special:Upload for files larger than POST limit - 10https://bugzilla.wikimedia.org/72768 (10Andre Klapper) p:5Unprio>3Normal [12:08:14] 3MediaWiki / 3MediaWiki UI: Fix Special:FileDuplicateSearch - 10https://bugzilla.wikimedia.org/71436 (10Florian) a:3Florian [12:12:26] 3MediaWiki / 3Special pages: Database query error on [[Special:UnconnectedPages]] - 10https://bugzilla.wikimedia.org/72696#c1 (10Andre Klapper) 5NEW>3UNCO URL above works for me right now; cannot reproduce. [12:13:27] I'm sorry if I'm wrong here, but I try to understand the purpose of a parameter of Parser::parse(), $clearState [12:14:42] I have an extension here (SemanticForms), that causes an exception in lock() when embedded in a page [12:15:01] But if I call parse() with $clearState = false it works [12:15:36] But I'm not sure if that's the usage $clearState is supposed to [12:16:02] are there any side effects to setting $clearState = false when calling parse()? [12:44:26] 3MediaWiki / 3Special pages: Database query error on [[Special:UnconnectedPages]] - 10https://bugzilla.wikimedia.org/72696#c2 (10Helder) I was able to reproduce it right now: A database query error has occurred. This may indicate a bug in the software. Function: Wikibase\Client\Specials\SpecialUnconnect... [12:56:29] (03CR) 10SPQRobin: [C: 032] Adjust 'wikidata-staff' group page i18n [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/169678 (owner: 10Vogone) [12:56:45] (03Merged) 10jenkins-bot: Adjust 'wikidata-staff' group page i18n [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/169678 (owner: 10Vogone) [12:58:56] 3MediaWiki extensions / 3SemanticForms: Error when using Special:RunQuery - "Parser state cleared while parsing" - 10https://bugzilla.wikimedia.org/66202#c4 (10Masin Al-Dujaili) If I change line 428 in extensions/SemanticForms/includes/SF_FormUtils.php: $output = $parser->parse( $form_def, $title, $parser->g... [13:01:00] 3MediaWiki / 3Watchlist: Watchlist does not show individual uploads to watched files on the Commons - 10https://bugzilla.wikimedia.org/72811 (10Timeshifter) 3NEW p:3Unprio s:3normal a:3None Watchlist does not show individual uploads to watched files on the Commons. What it does is this: 09:31 (U... [13:16:16] (03PS1) 10KartikMistry: Fixed typo and spacing in mt/index.html [services/cxserver] - 10https://gerrit.wikimedia.org/r/170315 [13:17:50] (03CR) 10Santhosh: [C: 032] Fixed typo and spacing in mt/index.html [services/cxserver] - 10https://gerrit.wikimedia.org/r/170315 (owner: 10KartikMistry) [13:18:38] (03Merged) 10jenkins-bot: Fixed typo and spacing in mt/index.html [services/cxserver] - 10https://gerrit.wikimedia.org/r/170315 (owner: 10KartikMistry) [13:25:57] 3Wikimedia / 3General/Unknown: Raw '#coordinates:' shown on articles due to Elastic/CirrusSearch disabling - 10https://bugzilla.wikimedia.org/72559#c11 (10Elitre) Gone again? I can't see it on the Wikivoyage article you linked (after purging). [13:39:42] 3Wikimedia / 3General/Unknown: Fix broken category data caused by bug 69740 in production Wikimedia wikis - 10https://bugzilla.wikimedia.org/72661#c5 (10Bartosz Dziewoński) I believe so, yes. [13:39:42] 3MediaWiki / 3Categories: Categories don't react well to their members moving between special-cased namespaces (Category ↔ File ↔ (other)) - 10https://bugzilla.wikimedia.org/69740 (10Bartosz Dziewoński) [13:41:00] Reedy: time for some quick review ? https://gerrit.wikimedia.org/r/#/c/170290/ [13:41:06] yesterdays failing test [13:41:51] You could've amended Aarons patch you know ;) [13:42:28] 3Wikimedia / 3General/Unknown: Keep GeoData living when disabling CirrusSearch - 10https://bugzilla.wikimedia.org/72814 (10Raimond Spekking) 3NEW p:3Unprio s:3normal a:3None Every time CirrusSearch is disabled (this week a few times) the GeoData extension is disabled too and therefor all pages with t... [13:42:42] Reedy: I almost got killed rebasing it :( [13:42:44] 3Wikimedia / 3General/Unknown: Keep GeoData living when disabling CirrusSearch - 10https://bugzilla.wikimedia.org/72814 (10Raimond Spekking) [13:42:44] 3Wikimedia / 3General/Unknown: Raw '#coordinates:' shown on articles due to Elastic/CirrusSearch disabling - 10https://bugzilla.wikimedia.org/72559 (10Raimond Spekking) [13:42:49] got killed? [13:43:08] dont know what specifically got wrong ( https://gerrit.wikimedia.org/r/#/c/169760/ ) [13:43:13] what a mess [13:46:51] Reedy: due to some issues, I couldn't fix the re-base issues - can you take a look ( or are we sticking with the new one ? ) [13:47:14] What did you do? [13:47:54] ah. I made the change, did the git review -R and I had the entire changes of earlier change too getting commited [13:48:14] usually, that gets corrected with the rebase change button there in gerrit, but this one didnt [13:48:55] did you use git review -d 12345 first? [13:49:17] Reedy: yeah. I was on the branch Aaron created [13:51:09] I tried almost 7 times resending after adding / removing / trying to merge with master - but it didnt seem to work [13:51:11] 3Wikimedia / 3General/Unknown: Raw '#coordinates:' shown on articles due to Elastic/CirrusSearch disabling - 10https://bugzilla.wikimedia.org/72559#c12 (10Andre Klapper) Yes, same problem as four days ago - it broke and now it works again. Operations is/was investigating. [13:51:21] and later, ended up creating the new one [13:51:26] 3Wikimedia / 3General/Unknown: Keep GeoData living when disabling CirrusSearch - 10https://bugzilla.wikimedia.org/72814 (10Andre Klapper) p:5Unprio>3Normal s:5normal>3enhanc [13:55:44] tonythomas: line 58 of ProcessBounceEmail.php - $bouncedUserId is unused anywhere [13:56:01] * tonythomas checks [13:56:42] oh right. we are not storing the user id anyway! [13:56:56] Guess you can remove the isset above too [13:57:07] true. should I include that one too with my new patch ? [13:57:53] You can do it as a seperate patch [13:58:07] okey. you can merge the other one then ? [13:58:21] I'm just looking at the timestamp code :) [13:59:29] Date: Thu, 30 Oct 2014 13:35:30 +0000 [13:59:33] Where does it get transformed? [13:59:49] okey. I printed the query when the test ran and found out that $dbr->timestamp was printing in the format like 20141028212834 [13:59:58] Certainly it would seem in the regex version at least, it's just pushed as is to the db [14:00:04] not sure if/where it is getting handled [14:00:39] I see the header extraction test only tests Plancake [14:00:44] Reedy: it got pushed in earlier as - the query always had the timestamp part as TRUE [14:01:27] That was for the select [14:01:39] For insert, you don't do any transform [14:02:15] Reedy: header extraction here ? ProcessBounceWithRegexTest::testExtractHeaders() ? [14:02:32] Right [14:02:33] if ( !class_exists( 'PlancakeEmailParser' ) ) { [14:02:33] $this->markTestSkipped( "This test requires the Plancake Email Parser library" ); [14:02:33] } [14:02:54] The change you're proposing makes sense [14:02:54] it checks if plancake is installed in the first case, and if not - it should continue with the regex part ? [14:03:10] It skips the test if no Plancake [14:03:25] Meaning it doesn't test the regex code [14:03:31] oh. true that. [14:03:58] err. The test is comparing the output of the plancake extraction and the regex extraction [14:04:20] Ah [14:04:23] makes sense - if plancake is not installed, there is no point in running it [14:04:36] True [14:04:41] But jenkins won't be testing it I guess [14:04:48] and I don't think I've run the unit tests locally [14:05:47] (03PS2) 10Manybubbles: WIP: Query boosting nearby matches [search/extra] - 10https://gerrit.wikimedia.org/r/164632 [14:06:01] ok. I tested it in my local settings, with plancake installed - was a success [14:06:13] tonythomas: Like I say, the patch seems sane, just the inserting seems a little vague [14:06:23] inserting ? [14:06:25] * tonythomas checks [14:06:33] (03CR) 10jenkins-bot: [V: 04-1] WIP: Query boosting nearby matches [search/extra] - 10https://gerrit.wikimedia.org/r/164632 (owner: 10Manybubbles) [14:06:46] The inserting/formatting [14:06:52] Let me get a copy of the plancake code checked out [14:06:54] moment :) [14:06:58] okey :) [14:07:01] oh, bah [14:07:06] ? [14:07:12] my dev vm is still updating a looaaad of repos :) [14:08:11] oh. thats sad. so - the insertion/formatting - you meant the way we are storing the timestamp :? [14:08:52] actually - we are not extracting the timestamp from the Date header from the email. [14:09:01] oh? [14:09:13] yeah. we are extracting it from the VERP address we are generating [14:09:27] we have the timestamp encrypted in the address itself :) [14:09:43] ah [14:09:52] that's probably why it's not so obvious [14:09:57] Reedy: wikiId-base36( $UserID )-base36( $Timestamp )-hash( $algorithm, $key, $prefix )@$email_domain [14:10:04] yeah. [14:10:32] I don't see any date checking in VERPEncodeDecodeTest [14:10:43] oh [14:12:21] let me check the functions [14:13:02] https://github.com/wikimedia/mediawiki-extensions-BounceHandler/blob/master/includes/ProcessBounceEmails.php#L86 returns the $failedUser [14:13:26] which have 'rawEmail' and 'bounceTime' in it [14:13:59] Reedy: and we are extracting the email address from the $failedUser [14:14:12] so - do we need one more explicit time check ? [14:17:20] I dunno [14:17:30] It sorta makes sense to check the data ends up as what it started [14:21:13] hmm. anyway, ProcessBounceEmails::getUserDetails() makes sure that the hash matches, and make sure that the bounce have occured in the timeperiod before it returns the $failedUser [14:21:18] (03PS1) 10Chad: Provide sledgehammer to disable regular expression searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/170325 [14:22:03] (03CR) 10Manybubbles: [C: 032] Provide sledgehammer to disable regular expression searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/170325 (owner: 10Chad) [14:22:07] (03PS2) 10Chad: Provide sledgehammer to disable regular expression searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/170325 [14:22:27] <^d> We want to merge PS2. [14:22:33] <^d> I had true/false backwards from testing [14:23:37] (03CR) 10Chad: [C: 032] Provide sledgehammer to disable regular expression searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/170325 (owner: 10Chad) [14:27:18] Reedy: anyway, once https://gerrit.wikimedia.org/r/#/c/170290/ gets merged, I will prepare the patch removing $bouncedUserId [14:27:51] and about the mediawiki/vendor -> we need a patch adding plancake to mediawiki/vendor right ? [14:28:05] (03CR) 10Paladox: "Ok thanks for doing this." [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/170297 (owner: 10Raimond Spekking) [14:29:33] (03CR) 10Paladox: [C: 032 V: 032] Convert i18n to JSON [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/170297 (owner: 10Raimond Spekking) [14:30:38] tonythomas: Yeah [14:30:49] I *think* that will mean jenkins can/will test with pancake too [14:31:13] (03Merged) 10jenkins-bot: Provide sledgehammer to disable regular expression searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/170325 (owner: 10Chad) [14:34:53] (03PS1) 10Chad: Provide sledgehammer to disable regular expression searches [extensions/CirrusSearch] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170326 [14:35:15] (03PS1) 10Chad: Provide sledgehammer to disable regular expression searches [extensions/CirrusSearch] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170327 [14:35:31] (03CR) 10Chad: [C: 032] Provide sledgehammer to disable regular expression searches [extensions/CirrusSearch] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170326 (owner: 10Chad) [14:35:48] (03Merged) 10jenkins-bot: Provide sledgehammer to disable regular expression searches [extensions/CirrusSearch] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170326 (owner: 10Chad) [14:35:51] (03CR) 10Chad: [C: 032] Provide sledgehammer to disable regular expression searches [extensions/CirrusSearch] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170327 (owner: 10Chad) [14:36:08] (03Merged) 10jenkins-bot: Provide sledgehammer to disable regular expression searches [extensions/CirrusSearch] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170327 (owner: 10Chad) [14:37:25] (03PS1) 10Chad: Updating Cirrus to disable regular expressions [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170328 [14:37:27] (03PS1) 10Cscott: Prevent 100% CPU hang on certain input text. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/170329 [14:37:56] (03CR) 10Reedy: [C: 032] Fixed DB timestamp range query in BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170290 (https://bugzilla.wikimedia.org/72686) (owner: 1001tonythomas) [14:38:10] (03Merged) 10jenkins-bot: Fixed DB timestamp range query in BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170290 (https://bugzilla.wikimedia.org/72686) (owner: 1001tonythomas) [14:38:49] (03CR) 10Paladox: "Ok thanks what do you do it with do you do it with command prompt or some other program." [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/169787 (owner: 10Paladox) [14:39:30] (03PS1) 10Chad: Updating Cirrus to disable regular expressions [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170330 [14:39:46] (03CR) 10Paladox: "What do you mean by path to php.exe" [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/169787 (owner: 10Paladox) [14:41:09] (03PS2) 10Cscott: Prevent 100% CPU hang on certain input text. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/170329 [14:43:14] (03CR) 10Raimond Spekking: "I am using http://msysgit.github.io/ Git Bash. It provides a Linux like shell." [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/169787 (owner: 10Paladox) [14:45:24] (03CR) 10Paladox: "Oh ok thanks for telling I use that git too I was just unsure if you could use that but thanks." [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/169787 (owner: 10Paladox) [14:45:59] (03PS1) 10Reedy: Add .gitignore from core [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170331 [14:46:04] tonythomas: ^^ [14:46:32] (03CR) 10Paladox: "I doint know where php.ex is. I haven't downloaded that either. Do you mean in the git program or do you have to download." [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/169787 (owner: 10Paladox) [14:49:59] (03CR) 10Chad: [C: 032] Updating Cirrus to disable regular expressions [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170330 (owner: 10Chad) [14:50:06] (03CR) 10Chad: [C: 032] Updating Cirrus to disable regular expressions [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170328 (owner: 10Chad) [14:50:16] (03PS2) 10Reedy: Add .gitignore from core [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170331 [14:56:08] (03Merged) 10jenkins-bot: Updating Cirrus to disable regular expressions [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170330 (owner: 10Chad) [14:56:30] (03Merged) 10jenkins-bot: Updating Cirrus to disable regular expressions [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170328 (owner: 10Chad) [14:57:06] (03CR) 10MarkAHershberger: [C: 032] "Thanks, Umherirrender." [core] - 10https://gerrit.wikimedia.org/r/170295 (owner: 10Umherirrender) [15:03:00] (03Merged) 10jenkins-bot: Allow /-/ in MediaWikiVersionFetcher::fetchVersion [core] - 10https://gerrit.wikimedia.org/r/170295 (owner: 10Umherirrender) [15:15:20] Reedy: yay! one down. now will remove the $bouncedUserId [15:19:48] (03CR) 10Gergő Tisza: "It doesn't return anything and does DOM manipulation. I'm not sure that function is the one that actually gets passed, but in general I wo" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/169919 (owner: 10Gergő Tisza) [15:24:16] (03CR) 10BryanDavis: "> Do we have plan to bump to Zend 5.4?" [core/vendor] - 10https://gerrit.wikimedia.org/r/147658 (owner: 10BryanDavis) [15:25:15] (03CR) 10Reedy: "the PHP patch just stops the segfault... Doesn't make traits work" [core/vendor] - 10https://gerrit.wikimedia.org/r/147658 (owner: 10BryanDavis) [15:27:59] 3Wikimedia / 3General/Unknown: Raw '#coordinates:' shown on articles due to Elastic/CirrusSearch disabling - 10https://bugzilla.wikimedia.org/72559#c13 (10Andyrom75) Now we have modified in it:voy our main template to avoid layout issues. However, when GeoData is disable the special mobile page Nearby doesn'... [15:28:01] anyone want to review https://gerrit.wikimedia.org/r/#/c/163898/ in tools/codesniffer? its been up a month with no feedback and i'd really like to get it through and out of my open patch list [15:35:57] 3MediaWiki / 3Interface: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277#c89 (10Dan Andreescu) Sorry to not update the bug - RT ticket has been filed to get Sam access: https://rt.wikimedia.org/Ticket/Display.html?id=8773 I don'... [15:36:23] (03PS1) 1001tonythomas: Remove unused variable $bouncedUserId [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170337 [15:38:25] (03CR) 10BryanDavis: "The original problem that I was working around with this was that scap called lint.php and lint.php used the parsekit PECL module. That c" [core/vendor] - 10https://gerrit.wikimedia.org/r/147658 (owner: 10BryanDavis) [15:38:26] Reedy: ^^ https://gerrit.wikimedia.org/r/#/c/170337/ [15:38:46] (03CR) 10Reedy: [C: 032] Remove unused variable $bouncedUserId [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170337 (owner: 1001tonythomas) [15:38:55] (03Merged) 10jenkins-bot: Remove unused variable $bouncedUserId [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170337 (owner: 1001tonythomas) [15:39:16] yay. and time to sign off https://gerrit.wikimedia.org/r/#/c/170331/ ? [15:39:17] I should check how to run phpunit again ;) [15:39:27] (03PS3) 10Reedy: Add .gitignore from core [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170331 [15:39:30] okey [15:39:31] (03CR) 10Reedy: [C: 032] Add .gitignore from core [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170331 (owner: 10Reedy) [15:39:41] (03Merged) 10jenkins-bot: Add .gitignore from core [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170331 (owner: 10Reedy) [15:39:51] I will add the changes to mediawiki/vendor then [15:41:59] tonythomas: Tests seem to pass with phpunit and plancake [15:42:13] yeah. looks good [15:42:55] as discussed I will be adding the plancake dependency to https://github.com/wikimedia/mediawiki-vendor/blob/master/composer.json right ? [15:43:17] and commit the generated dependency too ? [15:43:34] * tonythomas tries to find the composer RFC [15:48:28] tonythomas: right [15:48:33] (03PS1) 10Reedy: Stylistic tweaks [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170338 [15:48:38] tonythomas: ^^ [15:49:48] tonythomas: You should probably make sure all files have proper headers too [15:51:45] (03CR) 10Legoktm: "The Psr\Log change was announced over a week ago[1] with the words "breaking change" in the subject line. I'm not sure what the issue with" [core] - 10https://gerrit.wikimedia.org/r/155872 (owner: 10Legoktm) [16:07:41] 3MediaWiki / 3File management: Upload new file version: Auto convert image file format - Add info afterwards - 10https://bugzilla.wikimedia.org/72555#c5 (10Subfader) 5UNCO>3RESO/WON Closing. As said, I found out the non-working MIME detection caused this. [16:14:29] (03CR) 10Arlolra: [C: 032] Rename COLLECTOID -> OCG_SERVICE. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/170278 (owner: 10Cscott) [16:19:58] (03CR) 10Paladox: "I have tryed the above but it says does not esist and is not a script" [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/169787 (owner: 10Paladox) [16:20:06] (03PS1) 10MarkTraceur: Move showTooManyFilesWarning to the wizard object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170343 [16:21:32] (03CR) 1001tonythomas: "Great. I will add the file headers too." [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170338 (owner: 10Reedy) [16:24:31] (03CR) 10Reedy: "php.exe is the php executable" [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/169787 (owner: 10Paladox) [16:24:45] (03CR) 10Paladox: "i have collapsiblevector in user file. i have wamp installed with php but that is in another directory." [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/169787 (owner: 10Paladox) [16:25:08] (03CR) 10Paladox: "I have found php.exe inside wamp." [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/169787 (owner: 10Paladox) [16:25:15] gj [16:25:57] 3Wikimedia / 3Media storage: [Regression] Error creating thumbnail: convert: Too many IDAT's found - 10https://bugzilla.wikimedia.org/41374#c7 (10Mark A. Hershberger) Filed upstream: http://www.imagemagick.org/discourse-server/viewtopic.php?f=3&t=26471 [16:32:53] (03PS2) 10Daniel Kinzler: Re-caclulate SHA1 after applying exportTransform [core] - 10https://gerrit.wikimedia.org/r/168587 (https://bugzilla.wikimedia.org/72478) [16:33:27] 3MediaWiki extensions / 3OAuth: Users cannot log in via OAuth unless they have global accounts - 10https://bugzilla.wikimedia.org/72791#c4 (10Brion Vibber) So that sounds like a serious regression in CentralAuth to me. [16:35:57] 3OCG / 3PDF renderer: Bidirectional text sometimes in wrong order in PDF - 10https://bugzilla.wikimedia.org/71869#c6 (10C. Scott Ananian) Hm. You're probably right. The lang->dir implication is left over from before we had proper unicode bidi algorithm support. That can probably be removed now (but I shou... [16:35:57] 3MediaWiki extensions / 3OAuth: Users cannot log in via OAuth unless they have global accounts - 10https://bugzilla.wikimedia.org/72791 (10Sage Ross) p:5Unprio>3High s:5normal>3major [16:36:57] 3MediaWiki extensions / 3CentralAuth: Users cannot log in via OAuth unless they have global accounts - 10https://bugzilla.wikimedia.org/72791 (10Sage Ross) [16:37:57] 3MediaWiki extensions / 3CentralAuth: Newly created accounts are not global (at least, according to OAuth) - 10https://bugzilla.wikimedia.org/72791 (10Sage Ross) [16:39:50] (03PS4) 10Daniel Kinzler: Change position of and tags in XML dumps. [core] - 10https://gerrit.wikimedia.org/r/168583 (https://bugzilla.wikimedia.org/72417) [16:40:40] brion: hey! ready for an early morning merge? ---^ [16:40:48] nobody seemd to object on the mailing list [16:40:59] and wikidata dumps are stuck on this [16:41:48] (03CR) 10Jdlrobson: [C: 04-1] "Minor fix then I can +2. Someone should feel free to +2 if that's done and I haven't." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/170296 (https://bugzilla.wikimedia.org/72458) (owner: 10Prtksxna) [16:41:54] (03CR) 10Arlolra: "Sure enough: https://gerrit.wikimedia.org/r/#/c/170329/" [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/168541 (owner: 10Arlolra) [16:42:04] *yawn* [16:42:05] whee [16:42:17] :) [16:42:19] DanielK_WMDE: oh yah that should be safe [16:42:22] lemme poke the patch [16:43:16] bah why does the order even matter to the schema? silly XSD [16:43:48] brion: because JAX based processors it's very convenient to be able to rely on the order of the elements [16:43:55] in fact, that'S why i'm changing the order [16:44:02] fair nuff :D [16:44:23] * brion is used to unordered JSON crap these days ;) [16:44:33] DanielK_WMDE: Want me to do the mediawiki-config side? [16:44:53] Reedy: oh, the xsd rewrite? that would be awesome, thanks! [16:44:59] (03CR) 10Brion VIBBER: [C: 032] "Push zee button! Should help for streaming parsers and *should* not break other stuff." [core] - 10https://gerrit.wikimedia.org/r/168583 (https://bugzilla.wikimedia.org/72417) (owner: 10Daniel Kinzler) [16:45:24] (03CR) 10Arlolra: [C: 032] Prevent 100% CPU hang on certain input text. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/170329 (owner: 10Cscott) [16:45:37] brion: I'll be in awe if the release notes merge ;) [16:45:43] :D [16:45:45] hehe [16:45:48] yay! [16:46:07] (03PS1) 10MarkTraceur: Move a global starting handler out of uwu [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170349 [16:46:39] (03CR) 10Paladox: "It says you have to have localsettings.php" [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/169787 (owner: 10Paladox) [16:47:01] (03CR) 10Jdlrobson: [C: 04-1] "Submit button jumps underneath the form both for beta feature and normal mode. It should be inline with the input." [core] - 10https://gerrit.wikimedia.org/r/170309 (https://bugzilla.wikimedia.org/71436) (owner: 10Florianschmidtwelzow) [16:47:34] (03PS1) 10MarkTraceur: Move global remove handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170350 [16:49:27] DanielK_WMDE: https://gerrit.wikimedia.org/r/170351 [16:49:51] brion: Oh, zuul is backed up [16:49:52] lol [16:50:01] (03PS5) 10Reedy: Change position of and tags in XML dumps. [core] - 10https://gerrit.wikimedia.org/r/168583 (https://bugzilla.wikimedia.org/72417) (owner: 10Daniel Kinzler) [16:50:03] feck [16:50:04] it did rebase [16:50:24] Guess we better wait for zuul/jenkins to work first [16:50:55] heh [16:51:07] (03CR) 10Daniel Kinzler: "> It's not RequestContext's responsibility to log that some" [core] - 10https://gerrit.wikimedia.org/r/168923 (owner: 10Hoo man) [16:55:51] (03CR) 10Paladox: "Hi i used this but get the following error." [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/169787 (owner: 10Paladox) [17:00:14] 3MediaWiki / 3Interface: Bug in MediaWiki 1.25 - 10https://bugzilla.wikimedia.org/72821 (10paladox2015) 3UNCO p:3Unprio s:3normal a:3None Hi i have a custom skin and one of the users reported a problem with mediawiki 1.25 he is using mediawiki 1.25 wmf 1 for now because of the problem. the prolem is... [17:02:22] (03CR) 10MarkTraceur: "Maybe you should provide a jsondir argument." [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/169787 (owner: 10Paladox) [17:07:12] (03Abandoned) 10Umherirrender: Always escape 'word-separator' and 'parentheses' messages [core] - 10https://gerrit.wikimedia.org/r/136161 (owner: 10Umherirrender) [17:11:53] (03CR) 1001tonythomas: [C: 032] "Thanks Reedy !" [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170338 (owner: 10Reedy) [17:14:43] (03CR) 10jenkins-bot: [V: 04-1] Move showTooManyFilesWarning to the wizard object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170343 (owner: 10MarkTraceur) [17:14:50] ....well then [17:16:00] (03CR) 10jenkins-bot: [V: 04-1] Move a global starting handler out of uwu [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170349 (owner: 10MarkTraceur) [17:16:04] (03CR) 10jenkins-bot: [V: 04-1] Move global remove handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170350 (owner: 10MarkTraceur) [17:16:46] (03Merged) 10jenkins-bot: Rename COLLECTOID -> OCG_SERVICE. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/170278 (owner: 10Cscott) [17:17:08] brace yourself, jenkins just got unstuck [17:17:11] (03CR) 10Reedy: [C: 032] "Zuul/Jenkins are playing ball now.." [core] - 10https://gerrit.wikimedia.org/r/168583 (https://bugzilla.wikimedia.org/72417) (owner: 10Daniel Kinzler) [17:17:30] (03Merged) 10jenkins-bot: Prevent 100% CPU hang on certain input text. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/170329 (owner: 10Cscott) [17:18:50] cscott: Are these likely to be false -1s? I swear that string of patches is rebased properly [17:19:17] (03PS12) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [17:19:17] marktraceur: i don't think so, it was just a problem where jenkins wasn't picking up jobs [17:19:20] (03CR) 10Paladox: "Hi managed to do it thanks for help." [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/169787 (owner: 10Paladox) [17:19:21] Oh, OK [17:19:31] (03PS6) 10MarkTraceur: Move stupid DOM-bound events to OO EE syntax [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170131 [17:19:36] marktraceur: but feel free to believe that jenkins hates you personally. he has his moods. [17:19:38] (03PS2) 10MarkTraceur: Remove reservedIndex [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170170 [17:19:43] (03PS2) 10MarkTraceur: Move showTooManyFilesWarning to the wizard object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170343 [17:19:52] Petty, jealous bastard [17:19:58] marktraceur: (and if you find a false -1, let me know -- i'm a contint-admin now, i feel so empowered) [17:20:04] Nice [17:20:14] (03CR) 10Mwjames: "> The Psr\Log change was announced over a week ago[1] with the words "breaking change" in the subject line." [core] - 10https://gerrit.wikimedia.org/r/155872 (owner: 10Legoktm) [17:21:07] (03CR) 10Arlolra: Switch from winston to bunyan (033 comments) [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/167703 (owner: 10Cscott) [17:22:57] (03CR) 1001tonythomas: "recheck" [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170338 (owner: 10Reedy) [17:23:31] (03CR) 10jenkins-bot: [V: 04-1] Move showTooManyFilesWarning to the wizard object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170343 (owner: 10MarkTraceur) [17:23:57] (03CR) 10Jdlrobson: [C: 032] Disable CodeEditor on mobile [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/141385 (owner: 10TheDJ) [17:24:42] (03PS2) 10MarkTraceur: Move a global starting handler out of uwu [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170349 [17:24:57] (03PS2) 10MarkTraceur: Move global remove handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170350 [17:25:16] (03CR) 10jenkins-bot: [V: 04-1] Move a global starting handler out of uwu [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170349 (owner: 10MarkTraceur) [17:25:30] (03CR) 10jenkins-bot: [V: 04-1] Move global remove handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170350 (owner: 10MarkTraceur) [17:25:41] (03CR) 10Arlolra: [C: 032] Use standard bunyan serializer for Error objects. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/170279 (owner: 10Cscott) [17:25:54] (03PS2) 10BryanDavis: hhvm: fix FormatJsonTest::testParseTryFixing for lenient json parser [core] - 10https://gerrit.wikimedia.org/r/170251 (https://bugzilla.wikimedia.org/72778) [17:26:06] (03PS3) 10MarkTraceur: Move showTooManyFilesWarning to the wizard object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170343 [17:26:18] (03PS3) 10MarkTraceur: Move a global starting handler out of uwu [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170349 [17:26:22] (03PS3) 10MarkTraceur: Move global remove handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170350 [17:27:15] (03CR) 10jenkins-bot: [V: 04-1] Move a global starting handler out of uwu [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170349 (owner: 10MarkTraceur) [17:27:19] (03CR) 10jenkins-bot: [V: 04-1] Move global remove handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170350 (owner: 10MarkTraceur) [17:27:34] marktraceur: I think it's weekend time [17:27:44] (03CR) 10BryanDavis: hhvm: fix FormatJsonTest::testParseTryFixing for lenient json parser (031 comment) [core] - 10https://gerrit.wikimedia.org/r/170251 (https://bugzilla.wikimedia.org/72778) (owner: 10BryanDavis) [17:27:58] (03CR) 10Cscott: Switch from winston to bunyan (033 comments) [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/167703 (owner: 10Cscott) [17:28:31] (03PS4) 10MarkTraceur: Move a global starting handler out of uwu [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170349 [17:28:36] (03Merged) 10jenkins-bot: Stylistic tweaks [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170338 (owner: 10Reedy) [17:28:38] (03Merged) 10jenkins-bot: Change position of and tags in XML dumps. [core] - 10https://gerrit.wikimedia.org/r/168583 (https://bugzilla.wikimedia.org/72417) (owner: 10Daniel Kinzler) [17:28:40] (03Merged) 10jenkins-bot: Disable CodeEditor on mobile [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/141385 (owner: 10TheDJ) [17:28:44] (03PS4) 10MarkTraceur: Move global remove handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170350 [17:29:10] (03PS11) 10Reedy: Apply exportTransform in backupTextPass.inc [core] - 10https://gerrit.wikimedia.org/r/168126 (https://bugzilla.wikimedia.org/72361) (owner: 10Daniel Kinzler) [17:29:45] (03PS5) 10Cscott: Switch from winston to bunyan [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/167703 [17:29:47] (03PS3) 10Cscott: Use standard bunyan serializer for Error objects. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/170279 [17:30:57] 3MediaWiki / 3File management: Upload new file version: Auto convert image file format - Add info afterwards - 10https://bugzilla.wikimedia.org/72555 (10Andre Klapper) 5RESO/WON>3RESO/INV [17:31:12] 3Wikimedia / 3Media storage: [Regression] Error creating thumbnail: convert: Too many IDAT's found - 10https://bugzilla.wikimedia.org/41374 (10Andre Klapper) [17:32:41] 3MediaWiki / 3Interface: Bug in MediaWiki 1.25 - 10https://bugzilla.wikimedia.org/72821#c1 (10Andre Klapper) Hi paladox2015, unfortunately this report is not very useful because it does not describe the problem well. If you have time and can still reproduce the problem, please read https://www.mediawiki.org... [17:32:56] 3MediaWiki / 3Interface: Bug in MediaWiki 1.25 - 10https://bugzilla.wikimedia.org/72821 (10Andre Klapper) p:5Unprio>3Low [17:33:05] (03PS3) 10Reedy: Re-caclulate SHA1 after applying exportTransform [core] - 10https://gerrit.wikimedia.org/r/168587 (https://bugzilla.wikimedia.org/72478) (owner: 10Daniel Kinzler) [17:33:31] (03PS1) 10EBernhardson: Fix intermittent test failures on 12.04 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170356 (https://bugzilla.wikimedia.org/73267) [17:36:46] (03CR) 10Reedy: "Fixed the dependency" [core] - 10https://gerrit.wikimedia.org/r/168587 (https://bugzilla.wikimedia.org/72478) (owner: 10Daniel Kinzler) [17:38:38] (03PS1) 10Paladox: Update CollapsibleVector [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/170357 [17:39:55] (03PS2) 10Paladox: Update CollapsibleVector [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/170357 [17:41:07] (03CR) 10Paladox: [C: 032 V: 032] Update CollapsibleVector [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/170357 (owner: 10Paladox) [17:42:11] (03CR) 10Paladox: "Hi please see https://gerrit.wikimedia.org/r/#/c/170357/ which added the prefix collapsiblevector to the messages." [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/170297 (owner: 10Raimond Spekking) [17:45:06] (03PS1) 10Paladox: Update CollapsibleVector [extensions/CollapsibleVector] (REL1_24) - 10https://gerrit.wikimedia.org/r/170361 [17:45:36] (03CR) 10Paladox: [C: 032 V: 032] Update CollapsibleVector [extensions/CollapsibleVector] (REL1_24) - 10https://gerrit.wikimedia.org/r/170361 (owner: 10Paladox) [17:47:36] (03PS2) 10BryanDavis: die() with explanation when \Psr\Log\LoggerInterface is missing [core] - 10https://gerrit.wikimedia.org/r/170274 (https://bugzilla.wikimedia.org/72777) [17:48:08] (03CR) 10Yurik: [C: 032] "awesome job! Now i wish hhvm smart parsing could be disabled just for the consistency sake (if the dev does not use "fix mode", they expec" [core] - 10https://gerrit.wikimedia.org/r/170251 (https://bugzilla.wikimedia.org/72778) (owner: 10BryanDavis) [17:49:27] 3MediaWiki / 3Interface: Bug in MediaWiki 1.25 - 10https://bugzilla.wikimedia.org/72821#c2 (10paladox2015) Yes the user has tryed wmf1 and seems to work so it may be somewere in wmf 2, 3, 4, 5 or 6. [17:51:56] (03CR) 10BryanDavis: "> Are we only going to do this for the log interfaces?" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/170274 (https://bugzilla.wikimedia.org/72777) (owner: 10BryanDavis) [17:54:03] (03Merged) 10jenkins-bot: hhvm: fix FormatJsonTest::testParseTryFixing for lenient json parser [core] - 10https://gerrit.wikimedia.org/r/170251 (https://bugzilla.wikimedia.org/72778) (owner: 10BryanDavis) [17:57:28] (03PS2) 10EBernhardson: Fix intermittent test failures on 12.04 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170356 (https://bugzilla.wikimedia.org/72367) [17:59:56] (03PS1) 10Legoktm: Further optimize displayGlobalPage() [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/170363 (https://bugzilla.wikimedia.org/70585) [18:07:27] 3Wikimedia / 3General/Unknown: Raw '#coordinates:' shown on articles due to Elastic/CirrusSearch disabling - 10https://bugzilla.wikimedia.org/72559#c16 (10Max Semenik) 5PATC>3RESO/FIX GeoData should now remain enabled no matter what's going on with CS. [18:10:27] 3Wikimedia / 3General/Unknown: Raw '#coordinates:' shown on articles due to Elastic/CirrusSearch disabling - 10https://bugzilla.wikimedia.org/72559#c17 (10Raimond Spekking) *** Bug 72814 has been marked as a duplicate of this bug. *** [18:10:27] 3Wikimedia / 3General/Unknown: Keep GeoData living when disabling CirrusSearch - 10https://bugzilla.wikimedia.org/72814#c1 (10Raimond Spekking) 5NEW>3RESO/DUP Was fixed with a patch set in bug 72559. Thank you *** This bug has been marked as a duplicate of bug 72559 *** [18:12:27] 3MediaWiki / 3Unit tests: Unit tests in FormatJsonTest fail - 10https://bugzilla.wikimedia.org/72778#c5 (10Bryan Davis) 5PATC>3RESO/FIX Passing now. 00:05:49.197 OK, but incomplete or skipped tests! 00:05:49.20... [18:14:19] (03CR) 10Arlolra: [C: 032] Switch from winston to bunyan [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/167703 (owner: 10Cscott) [18:15:03] (03Merged) 10jenkins-bot: Switch from winston to bunyan [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/167703 (owner: 10Cscott) [18:15:49] (03Merged) 10jenkins-bot: Use standard bunyan serializer for Error objects. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/170279 (owner: 10Cscott) [18:23:34] (03PS1) 1001tonythomas: Added the Plancake e-mail parser library to MediaWiki using Composer [vendor] - 10https://gerrit.wikimedia.org/r/170369 (https://bugzilla.wikimedia.org/69019) [18:24:27] (03CR) 10Bmansurov: [C: 032] Deprecate `one` function [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/168724 (owner: 10Jdlrobson) [18:25:02] (03Merged) 10jenkins-bot: Deprecate `one` function [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/168724 (owner: 10Jdlrobson) [18:25:37] (03CR) 10Spage: [C: 04-1] "do {" (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170356 (https://bugzilla.wikimedia.org/72367) (owner: 10EBernhardson) [18:26:17] (03PS2) 1001tonythomas: Added the Plancake e-mail parser library to MediaWiki using Composer [vendor] - 10https://gerrit.wikimedia.org/r/170369 (https://bugzilla.wikimedia.org/72779) [18:29:00] (03CR) 1001tonythomas: "The library gets auto-loaded and tests/phpunit/phpunit.php extensions/BounceHandler/tests/VERPEncodeDecodeTest.php passes through." [vendor] - 10https://gerrit.wikimedia.org/r/170369 (https://bugzilla.wikimedia.org/72779) (owner: 1001tonythomas) [18:30:48] (03CR) 10BryanDavis: [C: 04-1] "Importing a dev-master reference is really bad. We have no way to know what actual upstream hash we are getting and it may cause a dirty d" (031 comment) [vendor] - 10https://gerrit.wikimedia.org/r/170369 (https://bugzilla.wikimedia.org/72779) (owner: 1001tonythomas) [18:33:53] (03CR) 1001tonythomas: "The issue is upstream :(. Their latest release tag, v1 dates back to May 15, 2011 and the master branch seems to be more updated and have " [vendor] - 10https://gerrit.wikimedia.org/r/170369 (https://bugzilla.wikimedia.org/72779) (owner: 1001tonythomas) [18:34:57] 3MediaWiki / 3Interface: Bug in MediaWiki 1.25 - 10https://bugzilla.wikimedia.org/72821#c3 (10Andre Klapper) Unfortunately this report is not very useful because it does not describe the problem well. If you have time and can still reproduce the problem, please read https://www.mediawiki.org/wiki/How_to_repo... [18:35:28] tonythomas: Why are you pulling in a fork too? Is https://github.com/plancake/official-library-php-email-parser not in packagist? [18:36:06] apparently it isn't. [18:36:15] bd808: https://packagist.org/packages/floriansemm/official-library-php-email-parser [18:36:42] yeah which is a fork of the upstream that only changes the package name [18:37:01] awesome... [18:37:03] https://github.com/floriansemm/official-library-php-email-parser/compare/plancake:master...master [18:37:03] true. and have only the dev-master there [18:37:12] use a vcl? [18:37:13] 3MediaWiki extensions / 3CentralAuth: Newly created accounts are not global (at least, according to OAuth) - 10https://bugzilla.wikimedia.org/72791#c5 (10Kunal Mehta (Legoktm)) 5NEW>3RESO/DUP I looked in the logs and this appears to be the same issue as bug 72469. mw1183 enwiki: CentralAuthHooks::onOAut... [18:37:14] 3MediaWiki extensions / 3OAuth: OAuth: Authorisation should not fail because you don't have an account on central wiki - 10https://bugzilla.wikimedia.org/72469#c4 (10Kunal Mehta (Legoktm)) *** Bug 72791 has been marked as a duplicate of this bug. *** [18:37:26] * vcs [18:37:38] hoo: yeah that might be better [18:37:52] hoo: they have only the dev-master branch well and good. the v1 tag ( latest ) dates to 2011 [18:38:01] I certainly am not excited about tracking dev-master on a random fork [18:38:17] yeah, tracking it for the official package is less bad [18:38:21] but still, that's awry [18:38:32] maybe use a less unstable lib? [18:38:59] My first vote would be to work with the upstream to get them to tag and to list on packagist [18:39:11] This is part of starting to be a good php community player [18:39:11] 3MediaWiki extensions / 3CentralAuth: Newly created accounts are not global (at least, according to OAuth) - 10https://bugzilla.wikimedia.org/72791#c6 (10Chris Steipp) (In reply to Brion Vibber from comment #4) > So that sounds like a serious regression in CentralAuth to me. The issue is how we're doing the... [18:39:25] hoo: we went through a few, and found this lightweight and good for our job - we can switch anytime though [18:39:37] https://github.com/plancake/official-library-php-email-parser/issues/20 :D [18:40:21] tonythomas: Ok... is it active, still [18:40:22] ? [18:40:26] Lat commit more than a year ago [18:41:31] hoo: thats true [18:42:02] Blocking on that issue might not be a good idea [18:42:03] just saying [18:42:37] Year of contributions: 0 total [18:42:44] for the whole org [18:43:21] Sep 5, 2013 was the last update for any of their original repos [18:43:54] Can we point composer to a git repo and use a specific hash? [18:44:04] legoktm: with vcs I think so [18:44:14] we could also for it into wikimedia or so [18:44:17] * fork [18:44:19] and make a tag [18:44:49] reminds me of mediawiki/core/vendor/swiftmailer/ [18:47:05] I'm not seeing use of a hash as a version documented at getcomposer.org [18:47:18] https://getcomposer.org/doc/01-basic-usage.md#package-versions [18:47:53] Found it -- "dev-master#2eb0c0978d290a1c45346a1955188929cb4e5db7" [18:48:30] So I'd be willing to see that hack used to pin to a given hash [18:48:47] bd808: that looks great - adding that change now [18:50:01] That usage is documented at https://getcomposer.org/doc/04-schema.md#package-links : require and require-dev additionally support explicit references (i.e. commit) for dev versions to make sure they are locked to a given state, even when you run update. These only work if you explicitly require a dev version and append the reference with #. [18:51:25] tonythomas: But if we find that upstream is really abandonware somebody should take over maintainership via a fork [18:51:42] 3MediaWiki / 3Interface: Bug in MediaWiki 1.25 - 10https://bugzilla.wikimedia.org/72821#c4 (10Bawolff (Brian Wolff)) (In reply to paladox2015 from comment #0) > Hi i have a custom skin and one of the users reported a problem with > mediawiki 1.25 he is using mediawiki 1.25 wmf 1 for now because of the > prob... [18:51:43] 3Wikimedia / 3Mailing lists: New mailing lists for Chairpersons - 10https://bugzilla.wikimedia.org/72615#c3 (10John F. Lewis) 5NEW>3ASSI a:3John F. Lewis Alright. [18:51:58] or use another lib [18:52:07] bd808: true that. lets see what happens with the issue reported. [18:52:13] * bd808 nods to both [18:52:26] 3MediaWiki / 3Interface: Extra scrollbars on custom skin in 1.25wmf branches - 10https://bugzilla.wikimedia.org/72821 (10Bawolff (Brian Wolff)) [18:52:42] hoo: the alternative that came across us next was the Zend library, but was lot more bulky - having loads of stuff we never use [18:53:00] but would be our option in the worst case [18:53:03] we are not likely to pull in a zend lib [18:53:23] true taht [18:53:35] yeah. legoktm and I discussed on that earlier - and agreed with the plancake one. [18:53:39] unless it can come without a ton of zend2 baggage [18:53:51] yeah. that was the issue [18:54:11] http://stackoverflow.com/questions/4721410/best-way-to-handle-email-parsing-decoding-in-php [18:54:15] * bd808|LUNCH needs food badly [18:55:33] bd808|LUNCH: one more thing before you go - the hash is "reference": "e7453ead1f3a74810d8050a30afb96feed74477a", under https://gerrit.wikimedia.org/r/#/c/170369/2/composer.lock right ? [18:57:29] 3Wikimedia / 3Mailing lists: New mailing lists for Chairpersons - 10https://bugzilla.wikimedia.org/72615 (10John F. Lewis) 5ASSI>3RESO/FIX [18:58:11] (03PS3) 1001tonythomas: Added the Plancake e-mail parser library to MediaWiki using Composer [vendor] - 10https://gerrit.wikimedia.org/r/170369 (https://bugzilla.wikimedia.org/72779) [18:58:53] done. we are now cloning a specific version of the library ! [19:15:27] 3Wikimedia / 3Mailing lists: disable the defunct mk-edu list - 10https://bugzilla.wikimedia.org/72289#c1 (10Andrew Otto) Asaf, as you are a list admin for this list, you should be able to do all you want to with the list itself. Can you still log in as an admin? [19:21:14] (03CR) 10Umherirrender: "In my opinion the sha1 should be the same as in rev_sha1 and which is also outputted by the api. Maybe add a new hash as explicit checksum" [core] - 10https://gerrit.wikimedia.org/r/168587 (https://bugzilla.wikimedia.org/72478) (owner: 10Daniel Kinzler) [19:24:29] (03CR) 10Ori.livneh: [C: 032] Don't encode() non-unicode strings [tools/scap] - 10https://gerrit.wikimedia.org/r/170282 (https://bugzilla.wikimedia.org/68780) (owner: 10BryanDavis) [19:24:48] (03Merged) 10jenkins-bot: Don't encode() non-unicode strings [tools/scap] - 10https://gerrit.wikimedia.org/r/170282 (https://bugzilla.wikimedia.org/68780) (owner: 10BryanDavis) [19:26:59] (03PS2) 10Ori.livneh: Map JSON Schema 'integer' type to MySQL BIGINTs rather than INTs [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/168003 [19:27:04] (03CR) 10Ori.livneh: [C: 032] Map JSON Schema 'integer' type to MySQL BIGINTs rather than INTs [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/168003 (owner: 10Ori.livneh) [19:28:17] (03CR) 10Phuedx: Register Hogan with mw.template (031 comment) [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/169931 (owner: 10Jdlrobson) [19:28:30] (03Merged) 10jenkins-bot: Map JSON Schema 'integer' type to MySQL BIGINTs rather than INTs [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/168003 (owner: 10Ori.livneh) [19:29:07] ori: Thanks. I think that one is a good candidate for my personal highest lines of commit message to lines of code changed benchmark. :) [19:29:27] heh [19:33:33] (03CR) 10Phuedx: [C: 032] "Tested with MobileFrontend master and watched the large number of deprecation notices fly by!" [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/169931 (owner: 10Jdlrobson) [19:34:24] (03CR) 10Catrope: [C: 032] Add Special:CiteThisPage to the 'pagetools' group of Special:SpecialPages [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/169555 (owner: 10Jforrester) [19:37:57] 3MediaWiki / 3Database: PostgreSQL: undefined method Status::clearFlag() - 10https://bugzilla.wikimedia.org/70030#c10 (10Jeff Janes) Is there anyone who can merge https://gerrit.wikimedia.org/r/156349 ? PostgreSQL support is slowly rotting away, as the persistence of this problem makes it hard to test for o... [19:38:03] (03PS1) 10MarkTraceur: Move makePreviewsFlag out of UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170385 [19:38:45] (03CR) 10jenkins-bot: [V: 04-1] Move makePreviewsFlag out of UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170385 (owner: 10MarkTraceur) [19:39:02] (03Merged) 10jenkins-bot: Add Special:CiteThisPage to the 'pagetools' group of Special:SpecialPages [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/169555 (owner: 10Jforrester) [19:48:11] (03CR) 10Phuedx: [C: 032] "Jdlrobson put me at ease about reviewing this. Tested with MobileFrontent with and without debug mode enabled and it didn't explode." [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/169926 (owner: 10Jdlrobson) [19:48:47] (03Merged) 10jenkins-bot: Split out ResourceLoaderTemplateParserModule from ResourceLoaderTemplateModule [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/169926 (owner: 10Jdlrobson) [19:48:52] (03Merged) 10jenkins-bot: Register Hogan with mw.template [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/169931 (owner: 10Jdlrobson) [19:54:26] 3Wikimedia / 3Deployment systems: [scap] "UnicodeDecodeError: 'ascii' codec can't decode byte" when announcing sync result to irc - 10https://bugzilla.wikimedia.org/68780#c5 (10Bryan Davis) 5PATC>3RESO/FIX $ /usr/local/bin/wmf-beta-scap 'Testing with unicode ☃' Starting ssh-agent Agent pid 6624 Identity... [19:55:28] legoktm: I'm going to take a wild guess at https://gerrit.wikimedia.org/r/#/c/168912/3/Truglass.skin.php,cm being wrong? What was I supposed to be doing with that/what else needs to be done to fix it? [19:56:27] (03CR) 10Legoktm: Use Config instead of globals (031 comment) [skins/Truglass] - 10https://gerrit.wikimedia.org/r/168912 (owner: 10Lewis Cawte) [19:58:47] Lcawte: Also, you need to construct your TruglassTemplate with the proper config object. [19:59:18] legoktm: Can I just git rm * instead? ;) [19:59:41] (03PS2) 10MarkTraceur: Move makePreviewsFlag out of UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170385 [19:59:47] just override setupTemplate like Vector does [19:59:47] lol [20:00:12] But Vector isn't ancient code :P [20:00:17] legoktm: Just because Vector does it doesn't mean it's a good idea [20:00:42] If Vector jumped off a cliff, it would be dead. And you wouldn't follow it, because now it's dead and life can go on. :P [20:05:24] legoktm: So hang on, does that __construct even need to be in SkinTruglass? [20:05:56] yes.... [20:06:14] (03PS1) 10MarkTraceur: Move extra-file handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170389 [20:11:50] (03PS4) 10Lewis Cawte: Use Config instead of globals [skins/Truglass] - 10https://gerrit.wikimedia.org/r/168912 [20:12:28] (03CR) 10MarkTraceur: "Hm, I swear I fixed that. Like seven times. Let me try one more time." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 (owner: 10MarkTraceur) [20:14:52] (03PS9) 10MarkTraceur: Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 [20:15:02] (03PS13) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [20:15:25] (03PS10) 10MarkTraceur: Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 [20:15:33] (03PS14) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [20:15:47] (03PS7) 10MarkTraceur: Move stupid DOM-bound events to OO EE syntax [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170131 [20:15:53] (03PS3) 10MarkTraceur: Remove reservedIndex [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170170 [20:15:56] (03PS4) 10MarkTraceur: Move showTooManyFilesWarning to the wizard object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170343 [20:15:59] I don't pretend to have any idea what I'm doing here lol [20:16:01] (03PS5) 10MarkTraceur: Move a global starting handler out of uwu [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170349 [20:16:04] (03PS5) 10MarkTraceur: Move global remove handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170350 [20:16:08] (03PS3) 10MarkTraceur: Move makePreviewsFlag out of UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170385 [20:16:13] (03PS2) 10MarkTraceur: Move extra-file handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170389 [20:20:42] 3Wikimedia / 3Mailing lists: disable the defunct mk-edu list - 10https://bugzilla.wikimedia.org/72289#c2 (10John F. Lewis) Adding on to what Andrew said; disabling the list in a some-what multi-step operation here. First, remove the list from the listinfo page display by going to 3MediaWiki / 3Database: SQL syntax errors with PostgreSQL installation - 10https://bugzilla.wikimedia.org/72834 (10Jeff Janes) 3UNCO p:3Unprio s:3normal a:3None This the PostgreSQL equivalent to bug 71040 for Oracle. [20:28:35] (03PS1) 10Jjanes: PostgreSQL: Port update-keys.sql to PostgreSQL [core] - 10https://gerrit.wikimedia.org/r/170395 (https://bugzilla.wikimedia.org/72834) [20:28:43] (03CR) 10Aaron Schulz: [C: 032] Fixed possible db error log spam when cluster=* in wfWaitForSlaves() [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/169972 (owner: 10Aaron Schulz) [20:29:27] 3Wikimedia / 3SSL related: links.email.donate.wikimedia.org should offer HTTPS - 10https://bugzilla.wikimedia.org/72514 (10chmarkine) [20:29:28] 3Wikimedia / 3Fundraising: Opting out of the annual fundraising e-mail is a terrible user experience; links.email.donate.wikimedia.org has invalid certificate - 10https://bugzilla.wikimedia.org/58373 (10chmarkine) [20:31:01] Hmm, why am I no longer getting gerrit mail? [20:31:44] <^d> Since when? [20:32:43] 3MediaWiki extensions / 3Gadgets: Allow specifying what pages a gadget should run on in the definition - 10https://bugzilla.wikimedia.org/61007#c1 (10Helder) See also: https://en.wikipedia.org/wiki/MediaWiki_talk:Common.js/Archive_19#Execute_custom_scripts_per_page [20:35:07] (03Merged) 10jenkins-bot: Fixed possible db error log spam when cluster=* in wfWaitForSlaves() [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/169972 (owner: 10Aaron Schulz) [20:38:20] (03PS3) 10EBernhardson: Fix intermittent test failures on 12.04 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170356 (https://bugzilla.wikimedia.org/72367) [20:38:23] (03PS1) 10EBernhardson: Always decode Blob objects from Database::decodeBlob [core] - 10https://gerrit.wikimedia.org/r/170396 (https://bugzilla.wikimedia.org/72367) [20:38:51] (03PS1) 10Aaron Schulz: Fixed possible db error log spam when cluster=* in wfWaitForSlaves() [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170397 [20:38:55] (03CR) 10Aaron Schulz: [C: 032] Fixed possible db error log spam when cluster=* in wfWaitForSlaves() [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170397 (owner: 10Aaron Schulz) [20:39:10] (03CR) 10jenkins-bot: [V: 04-1] Fix intermittent test failures on 12.04 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170356 (https://bugzilla.wikimedia.org/72367) (owner: 10EBernhardson) [20:40:13] ^d: I haven't gotten one since like 27th (I don't submit patches or do things that often...) [20:40:23] <^d> I had one like an hour ago. [20:40:31] <^d> So I don't think it's gerrit, hmm [20:45:20] (03Merged) 10jenkins-bot: Fixed possible db error log spam when cluster=* in wfWaitForSlaves() [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170397 (owner: 10Aaron Schulz) [20:48:48] (03PS4) 10Jdlrobson: Remove Handlebars Mantle dependency [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/170099 [20:49:21] (03PS5) 10Jdlrobson: Remove Handlebars Mantle dependency [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/170099 [20:50:13] Do all skins repos have tests running by default or does each new repo have to be enabled manually? I'm thinking basic tests like phplint... https://gerrit.wikimedia.org/r/#/c/168913/ ... before I 'recheck' and nothing happens ;) [20:50:45] (03Abandoned) 10Aaron Schulz: Fixed DB timestamp range query [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/169760 (https://bugzilla.wikimedia.org/72686) (owner: 10Aaron Schulz) [20:53:25] (03CR) 10Florianschmidtwelzow: "HTMLForm doesn't support inline forms so far i know. Maybe we can extend HTMLForm as HTMLInlineForm and do the work there (inline input an" [core] - 10https://gerrit.wikimedia.org/r/170309 (https://bugzilla.wikimedia.org/71436) (owner: 10Florianschmidtwelzow) [20:56:28] (03CR) 10Spage: "Couple of comment comments." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/170396 (https://bugzilla.wikimedia.org/72367) (owner: 10EBernhardson) [20:56:57] 3MediaWiki / 3Database: SQL syntax errors with PostgreSQL installation - 10https://bugzilla.wikimedia.org/72834 (10Andre Klapper) [20:56:57] 3MediaWiki / 3Database: PostgreSQL/pgsql support (tracking) - 10https://bugzilla.wikimedia.org/384 (10Andre Klapper) [21:00:50] (03CR) 10EBernhardson: [C: 04-2] "Do not merge until core patch is merged. This will appear to work on sqlite in jenkins, but then fail on mysql without the core patch." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170356 (https://bugzilla.wikimedia.org/72367) (owner: 10EBernhardson) [21:12:04] (03CR) 10MarkTraceur: [C: 031] "gi11es: If you can test this, I trust you to, I still don't have a testing setup for Flickr uploads, but the code looks fine and seems lik" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/168556 (https://bugzilla.wikimedia.org/65423) (owner: 10Gilles) [21:16:40] (03PS1) 10Aaron Schulz: Made LogEventsList use the log bloom filter, not just the Article class [core] - 10https://gerrit.wikimedia.org/r/170441 [21:41:39] Lcawte: The tests need to be setup for each skin, but it's pretty simple -- https://github.com/wikimedia/integration-config/blob/master/jjb/mediawiki-skins.yaml [21:42:27] bd808: That simple? :O [21:44:00] Just copy pasta any of the project blocks and change the name to 'mw-skins-Bouquet' [21:52:02] (03Abandoned) 10Jdlrobson: Define interface for hide/show on all Views [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/170261 (owner: 10Jdlrobson) [21:58:26] 3MediaWiki / 3File management: Error generating thumbnail - OOM on progressive jpeg - 10https://bugzilla.wikimedia.org/69377#c3 (10Vera de Kok) Flickr2Commons didn't transfer a lot of the images from this photographer. Is this caused by the same problem + something that can be fixed? [22:00:29] 3MediaWiki extensions / 3Math: Don't cache render errors & support regular action=purge - 10https://bugzilla.wikimedia.org/72537#c4 (10Andre Klapper) I saw the same issue again on https://de.wikipedia.org/wiki/Potenzmengenkonstruktion#Automat_zum_regul.C3.A4ren_Ausdruck_.0A.0A_.0A_.28.0A_a.0A_.0A_.7C.0A_.0A_... [22:13:25] (03CR) 10Aaron Schulz: [C: 04-1] Further optimize displayGlobalPage() (031 comment) [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/170363 (https://bugzilla.wikimedia.org/70585) (owner: 10Legoktm) [22:13:50] ...I hate PHP [22:14:47] * Lcawte votes to rewrite MediaWiki in C [22:15:50] (03PS2) 10Legoktm: Further optimize displayGlobalPage() [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/170363 (https://bugzilla.wikimedia.org/70585) [22:16:02] (03CR) 10Legoktm: Further optimize displayGlobalPage() (031 comment) [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/170363 (https://bugzilla.wikimedia.org/70585) (owner: 10Legoktm) [22:23:11] (03CR) 10Aaron Schulz: [C: 032] Further optimize displayGlobalPage() [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/170363 (https://bugzilla.wikimedia.org/70585) (owner: 10Legoktm) [22:23:21] (03Merged) 10jenkins-bot: Further optimize displayGlobalPage() [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/170363 (https://bugzilla.wikimedia.org/70585) (owner: 10Legoktm) [22:44:57] (03PS1) 10MaxSem: Add WikiGrok [tools/release] - 10https://gerrit.wikimedia.org/r/170454 [22:45:11] (03CR) 10MaxSem: [C: 04-2] Add WikiGrok [tools/release] - 10https://gerrit.wikimedia.org/r/170454 (owner: 10MaxSem) [22:54:50] (03PS1) 10Jdlrobson: Remove use of one in favour of once [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/170457 (https://bugzilla.wikimedia.org/72711) [22:57:26] (03PS2) 10Jdlrobson: Deprecate one in favour of once [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/170457 (https://bugzilla.wikimedia.org/72711) [22:58:05] (03CR) 10jenkins-bot: [V: 04-1] Deprecate one in favour of once [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/170457 (https://bugzilla.wikimedia.org/72711) (owner: 10Jdlrobson) [23:24:31] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (eee616d664) [core] - 10https://gerrit.wikimedia.org/r/170468 [23:28:09] (03PS4) 10EBernhardson: Fix intermittent test failures on 12.04 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170356 (https://bugzilla.wikimedia.org/72367) [23:28:12] (03PS1) 10EBernhardson: Create UUIDBlob objects directly [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170470 [23:28:25] (03PS2) 10EBernhardson: Always decode Blob objects from Database::decodeBlob [core] - 10https://gerrit.wikimedia.org/r/170396 (https://bugzilla.wikimedia.org/72367) [23:28:49] (03CR) 10EBernhardson: "dependency on core patch has been moved into followup, this should be safe to merge as is" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170356 (https://bugzilla.wikimedia.org/72367) (owner: 10EBernhardson) [23:28:57] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (eee616d664) [core] - 10https://gerrit.wikimedia.org/r/170468 (owner: 10Jforrester) [23:29:00] (03CR) 10jenkins-bot: [V: 04-1] Fix intermittent test failures on 12.04 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170356 (https://bugzilla.wikimedia.org/72367) (owner: 10EBernhardson) [23:32:52] (03PS2) 10EBernhardson: Create UUIDBlob objects directly [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170470 [23:32:55] (03PS5) 10EBernhardson: Fix intermittent test failures on 12.04 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170356 (https://bugzilla.wikimedia.org/72367) [23:35:09] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (eee616d664) [core] - 10https://gerrit.wikimedia.org/r/170468 (owner: 10Jforrester) [23:37:57] (03PS3) 10EBernhardson: Always decode Blob objects from Database::decodeBlob [core] - 10https://gerrit.wikimedia.org/r/170396 (https://bugzilla.wikimedia.org/72367) [23:42:03] (03PS4) 10EBernhardson: Always decode Blob objects from Database::decodeBlob [core] - 10https://gerrit.wikimedia.org/r/170396 (https://bugzilla.wikimedia.org/72367) [23:45:59] (03PS5) 10EBernhardson: Always decode Blob objects from Database::addQuotes [core] - 10https://gerrit.wikimedia.org/r/170396 (https://bugzilla.wikimedia.org/72367) [23:57:58] 3MediaWiki / 3JobQueue: Retry counts not working - 10https://bugzilla.wikimedia.org/71853#c6 (10Aaron Schulz) It doesn't seem to be the redis job queue retry system. Maybe it's the partitioning code in the Parsoid extension? aaron@fluorine:~/mw-log$ head -n 10000000 runJobs.log | grep -Po '\w+: ParsoidCache...