[00:01:14] (03PS14) 10Paladox: Update jquery.ui Vector theme to 1.9.2 [skins/Vector] - 10https://gerrit.wikimedia.org/r/154024 [00:03:13] 3Wikimedia / 3Media storage: Swift outage caused a bunch of moved files to be "inconsistent" and "missing" - 10https://bugzilla.wikimedia.org/69311#c20 (10Tisza Gergő) Created attachment 16952 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16952&action=edit List of files/thumbnails which are referenc... [00:03:56] That's a lot of whitespace [00:10:46] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (da4b0d5c14) [core] - 10https://gerrit.wikimedia.org/r/169970 [00:11:05] (03CR) 10CSteipp: [C: 032] Fix creating non-parameterized hashes in ParameterizedPassword [core] - 10https://gerrit.wikimedia.org/r/167523 (owner: 10Hoo man) [00:11:47] csteipp: :) [00:12:01] Thanks! [00:12:04] Do we want to backport it? Now that 1.24 is not yet out it's rather painless [00:12:15] Yeah, I think we should [00:13:00] "Could not create a merge commit during the cherry pick" [00:13:08] Ah, I know why [00:13:16] Will manually do it [00:17:10] (03Merged) 10jenkins-bot: Fix creating non-parameterized hashes in ParameterizedPassword [core] - 10https://gerrit.wikimedia.org/r/167523 (owner: 10Hoo man) [00:18:01] (03PS1) 10Cmcmahon: QA: update user message on delete [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169971 [00:19:00] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169971 (owner: 10Cmcmahon) [00:19:46] (03CR) 10jenkins-bot: [V: 04-1] QA: update user message on delete [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169971 (owner: 10Cmcmahon) [00:22:39] (03PS4) 10EBernhardson: Make watchlist topic title link to topic with with unread posts highlighted [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167218 (owner: 10Matthias Mullie) [00:24:43] (03PS2) 10EBernhardson: Make sure isRecordHidden doesn't return true is run more than once [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168953 (owner: 10Matthias Mullie) [00:25:43] (03PS1) 10Aaron Schulz: Fixed possible db error log spam when cluster=* in wfWaitForSlaves() [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/169972 [00:27:27] 3MediaWiki extensions / 3BounceHandler: BounceHandlerActions::handleFailingRecipient() SQL query - 10https://bugzilla.wikimedia.org/72686#c1 (10Chris Steipp) (In reply to Sam Reed (reedy) from comment #0) > array( > 'br_user'=> $originalEmail, > 'br_timestamp' >= $bounceValidPeriod > ), > > 'br_t... [00:28:28] 3MediaWiki extensions / 3BounceHandler: BounceHandlerActions::handleFailingRecipient() SQL query - 10https://bugzilla.wikimedia.org/72686#c2 (10Sam Reed (reedy)) (In reply to Chris Steipp from comment #1) > (In reply to Sam Reed (reedy) from comment #0) > > array( > > 'br_user'=> $originalEmail, > >... [00:34:57] (03PS1) 10Hoo man: Fix creating non-parameterized hashes in ParameterizedPassword [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/169975 [00:35:02] csteipp: ^ [00:57:13] TimStarling: i notice in your Scribunto design doc, you said "To protect the consistency of the empty-frame expansion cache (Parser::$mTplExpandCache), I propose that we do not provide access to grandparent frames." [00:57:13] but a while ago, we changed that cache to be per-frame, so now it would be safe to expose grandparent frames. are there any other reasons to not do that, or would it be okay now? [00:58:10] I guess [00:58:59] great! users have been wanting that for a long time [00:59:07] * jackmcbarn starts coding [01:20:44] (03PS1) 10Nuria: [WIP] Batching event insertion [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/169977 (https://bugzilla.wikimedia.org/67450) [01:51:17] (03PS10) 10Mooeypoo: Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 [01:51:49] (03CR) 10jenkins-bot: [V: 04-1] Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo) [01:51:58] (03PS11) 10Mooeypoo: Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 [01:57:49] (03CR) 10EBernhardson: Make watchlist topic title link to topic with with unread posts highlighted (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167218 (owner: 10Matthias Mullie) [01:58:54] (03PS2) 10Luis Felipe Schenone: Updated, debugged and enhanced the extension [extensions/MsCatSelect] - 10https://gerrit.wikimedia.org/r/169946 [02:01:04] (03CR) 10Luis Felipe Schenone: [C: 032 V: 032] Updated, debugged and enhanced the extension [extensions/MsCatSelect] - 10https://gerrit.wikimedia.org/r/169946 (owner: 10Luis Felipe Schenone) [02:05:38] (03PS1) 10Jackmcbarn: Expose all ancestor frames [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/169983 [02:08:18] (03CR) 10Legoktm: [C: 032] Fix creating non-parameterized hashes in ParameterizedPassword [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/169975 (owner: 10Hoo man) [02:10:34] (03PS1) 10Luis Felipe Schenone: Normalizing filenames [extensions/MsCatSelect] - 10https://gerrit.wikimedia.org/r/169984 [02:11:00] (03CR) 10Luis Felipe Schenone: [C: 032 V: 032] Normalizing filenames [extensions/MsCatSelect] - 10https://gerrit.wikimedia.org/r/169984 (owner: 10Luis Felipe Schenone) [02:14:35] (03Merged) 10jenkins-bot: Fix creating non-parameterized hashes in ParameterizedPassword [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/169975 (owner: 10Hoo man) [02:20:24] springle: ping [02:22:58] jackmcbarn: pong [02:23:15] (03PS3) 10EBernhardson: Make sure isRecordHidden doesn't return true is run more than once [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168953 (owner: 10Matthias Mullie) [02:23:20] springle: someone in #mediawiki had https://gist.github.com/anonymous/fdc1db9c8443f5a63557 . any idea about it? [02:24:23] looking [02:29:24] jackmcbarn: check their available /tmp space. check mysqld error log for more info, os log for anything related to disk or filesystem. [02:29:56] told him that, thanks [02:39:19] (03PS5) 10EBernhardson: Make watchlist topic title link to topic with with unread posts highlighted [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167218 (owner: 10Matthias Mullie) [02:39:22] (03PS4) 10EBernhardson: Make sure isRecordHidden doesn't return true is run more than once [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168953 (owner: 10Matthias Mullie) [02:39:43] (03CR) 10EBernhardson: [C: 032] Make watchlist topic title link to topic with with unread posts highlighted [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167218 (owner: 10Matthias Mullie) [02:39:50] (03CR) 10EBernhardson: [C: 032] Make sure isRecordHidden doesn't return true is run more than once [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168953 (owner: 10Matthias Mullie) [02:40:30] (03Merged) 10jenkins-bot: Make watchlist topic title link to topic with with unread posts highlighted [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167218 (owner: 10Matthias Mullie) [02:40:33] (03Merged) 10jenkins-bot: Make sure isRecordHidden doesn't return true is run more than once [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168953 (owner: 10Matthias Mullie) [02:48:13] 3MediaWiki / 3Documentation: Documentation is out of date, incomplete (tracking) - 10https://bugzilla.wikimedia.org/1 (10Sam Reed (reedy)) [02:50:39] (03PS6) 10EBernhardson: (bug 71584) Fetch title content from API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166559 (https://bugzilla.wikimedia.org/71584) (owner: 10Matthias Mullie) [02:50:53] (03CR) 10EBernhardson: "PS6: manual rebase" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166559 (https://bugzilla.wikimedia.org/71584) (owner: 10Matthias Mullie) [03:05:38] (03CR) 10EBernhardson: (bug 71584) Fetch title content from API (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166559 (https://bugzilla.wikimedia.org/71584) (owner: 10Matthias Mullie) [03:07:42] (03PS7) 10EBernhardson: (bug 71584) Fetch title content from API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166559 (https://bugzilla.wikimedia.org/71584) (owner: 10Matthias Mullie) [03:08:06] (03CR) 10EBernhardson: [C: 032] "ps7: fix typo in comment" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166559 (https://bugzilla.wikimedia.org/71584) (owner: 10Matthias Mullie) [03:08:38] (03CR) 10Mattflaschen: [C: 04-1] "Looks good. I would like the name not to include 'beacon' (suggestions provided inline), and there are a few other small items." (037 comments) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/162194 (https://bugzilla.wikimedia.org/42815) (owner: 10Prtksxna) [03:08:50] (03Merged) 10jenkins-bot: (bug 71584) Fetch title content from API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166559 (https://bugzilla.wikimedia.org/71584) (owner: 10Matthias Mullie) [03:12:18] (03PS14) 10Mattflaschen: J-2e Remove all collapsing functionality [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166727 (owner: 10SG) [03:47:01] (03PS6) 10BryanDavis: [WIP] Enable profiling via xhprof [core] - 10https://gerrit.wikimedia.org/r/168930 [04:09:43] 3MediaWiki / 3Categories: sorting in category: B before A - 10https://bugzilla.wikimedia.org/72661#c2 (10Bawolff (Brian Wolff)) Page was moved on 2014-06-09T23:24:29‎ which is prior to e0ff770adee0 which was done in september. Category was added on 2013-12-01T13:33:20Z, prior to the page move. Thus its fro... [04:11:30] 3MediaWiki / 3API: Unicode characters in API output - 10https://bugzilla.wikimedia.org/72734 (10nejuje6tpztluvolq) 3UNCO p:3Unprio s:3normal a:3None Not sure if this is a bug but for example: wget -q -O- "http://en.wikipedia.org/w/api.php?action=parse&page=abbé_Prévost&prop=links&format=json" produ... [04:32:06] (03CR) 10Mattflaschen: [C: 04-1] "Looks solid. In addition to the one item inine:" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166727 (owner: 10SG) [04:46:57] (03PS15) 10Mattflaschen: J-2e Remove all collapsing functionality [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166727 (owner: 10SG) [04:47:43] (03CR) 10jenkins-bot: [V: 04-1] J-2e Remove all collapsing functionality [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166727 (owner: 10SG) [04:48:24] (03CR) 10Mattflaschen: [C: 031] "15 should address the items from 14. If I understand right "when you view the Permalink of a collapsed post, the post still has collapse " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166727 (owner: 10SG) [04:48:56] (03CR) 10Mattflaschen: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166727 (owner: 10SG) [04:52:29] 3Wikimedia / 3Site requests: Enable ULS webfonts by default at dv wikis - 10https://bugzilla.wikimedia.org/69860#c7 (10Runa Bhattacharjee) Created attachment 16953 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16953&action=edit Default font on Divehi Wikipedia [04:53:43] 3Wikimedia / 3Site requests: Enable ULS webfonts by default at dv wikis - 10https://bugzilla.wikimedia.org/69860#c8 (10Runa Bhattacharjee) (In reply to Glaisher from comment #5) > This does not actually do what I expected. I expected that FreeFontThana be > enabled on by default instead of the default font.... [04:57:43] 3Wikimedia / 3Site requests: Enable ULS webfonts by default at dv wikis - 10https://bugzilla.wikimedia.org/69860#c9 (10Glaisher) I've tested this both logged in and logged out: same result. Perhaps the font needs to be defined for the body in Common.css for it to take effect? [06:02:58] (03PS1) 10Pastakhov: add MakeGlobalVariablesScript hook (v 3.6.0) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/169988 [06:04:19] (03CR) 10Pastakhov: [C: 032] add MakeGlobalVariablesScript hook (v 3.6.0) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/169988 (owner: 10Pastakhov) [06:04:32] (03Merged) 10jenkins-bot: add MakeGlobalVariablesScript hook (v 3.6.0) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/169988 (owner: 10Pastakhov) [06:11:53] (03PS3) 10Umherirrender: Add LinkBatch to Special:LinkSearch [core] - 10https://gerrit.wikimedia.org/r/163219 [06:36:26] 3Wikimedia / 3Language setup: Create Wikipedia Maithili - 10https://bugzilla.wikimedia.org/72346#c20 (10बिप्लब आनन्द) (In reply to Glaisher from comment #19) > Asia/Nepal is not a valid format so I used Asia/Kathmandu (both UTC+5:45). > > There is an issue with DNS but that is currently being investigated.... [07:41:55] (03CR) 10Legoktm: LocalPageMoveJob: Use MovePage (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/169602 (owner: 10Legoktm) [07:42:01] (03PS2) 10Legoktm: LocalPageMoveJob: Use MovePage [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/169602 [07:44:03] (03CR) 10Legoktm: Updates after performance review (031 comment) [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/169653 (https://bugzilla.wikimedia.org/70585) (owner: 10Legoktm) [07:44:06] (03PS5) 10Legoktm: Updates after performance review [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/169653 (https://bugzilla.wikimedia.org/70585) [07:53:51] (03PS7) 10Qgil: Sanitize herald effects on maniphest tasks [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/168907 (owner: 1020after4) [07:54:22] (03CR) 10Nikerabbit: "Please add @since notes when changing a public API." [core] - 10https://gerrit.wikimedia.org/r/75511 (owner: 10Helder.wiki) [07:56:33] (03PS1) 10Nikerabbit: Fig compatibility with MW 1.22: mw.loader.using does not return promise [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/169995 [07:59:45] (03PS2) 10Nemo bis: Fix compatibility with MW 1.22: mw.loader.using does not return promise [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/169995 (owner: 10Nikerabbit) [08:00:16] (03PS1) 10Nikerabbit: Add a note when the return value was added to mediawiki.loader.using [core] - 10https://gerrit.wikimedia.org/r/169996 [08:01:41] Interesting: https://www.openhub.net/orgs/wikimedia?view=outside_projects [08:02:02] But only 12 committers declared an affiliation to Wikimedia [08:07:44] 3OCG / 3General/Unknown: Crash with HTTPS only Mediawiki instances - 10https://bugzilla.wikimedia.org/71797#c1 (10Nemo) What's the https domain in question? Are you sure the certificates for it are correct? [08:09:14] 3OCG / 3PDF renderer: [[Grants:APG/Proposals/Community/Review]] fails rendering - 10https://bugzilla.wikimedia.org/72748 (10Nemo) 3NEW p:3Unprio s:3normal a:3None From the URL: La generazione del file del documento non è riuscita. Stato: Rendering process died with non zero code: 1 It doesn't have... [08:20:54] (03PS5) 10Prtksxna: Add an experimental function to log events using the sendBeacon API. [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/162194 (https://bugzilla.wikimedia.org/42815) [08:22:05] (03CR) 10Prtksxna: "Matt, made the changes you requested." (037 comments) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/162194 (https://bugzilla.wikimedia.org/42815) (owner: 10Prtksxna) [08:22:20] (03CR) 10jenkins-bot: [V: 04-1] Add an experimental function to log events using the sendBeacon API. [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/162194 (https://bugzilla.wikimedia.org/42815) (owner: 10Prtksxna) [08:25:42] (03PS6) 10Prtksxna: Add an experimental function to log events using the sendBeacon API. [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/162194 (https://bugzilla.wikimedia.org/42815) [08:36:38] (03CR) 10Smuggli: [C: 032 V: 032] Multi select list: Small css fix [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/169793 (owner: 10Pwirth) [08:37:28] (03CR) 10Gilles: [C: 032] Support for message function in confirmCloseWindow [core] - 10https://gerrit.wikimedia.org/r/169772 (owner: 10MarkTraceur) [08:43:17] (03Merged) 10jenkins-bot: Support for message function in confirmCloseWindow [core] - 10https://gerrit.wikimedia.org/r/169772 (owner: 10MarkTraceur) [08:47:02] (03CR) 10Gilles: [C: 032] Use confirmCloseWindow from mediawiki-core [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151127 (owner: 10MarkTraceur) [08:47:41] (03Merged) 10jenkins-bot: Use confirmCloseWindow from mediawiki-core [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151127 (owner: 10MarkTraceur) [08:49:04] (03CR) 10Gilles: [C: 04-1] "Why not call the function when it is one and use its return? That's what those functions passed as message parameters are normally for, ri" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/169919 (owner: 10Gergő Tisza) [08:55:59] (03CR) 10KartikMistry: [C: 032] Fix compatibility with MW 1.22: mw.loader.using does not return promise [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/169995 (owner: 10Nikerabbit) [08:56:07] (03Merged) 10jenkins-bot: Fix compatibility with MW 1.22: mw.loader.using does not return promise [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/169995 (owner: 10Nikerabbit) [08:59:54] (03CR) 10Bartosz Dziewoński: [C: 032] Add a note when the return value was added to mediawiki.loader.using [core] - 10https://gerrit.wikimedia.org/r/169996 (owner: 10Nikerabbit) [09:00:01] (03CR) 10Bartosz Dziewoński: "https://gerrit.wikimedia.org/r/#/c/169996/" [core] - 10https://gerrit.wikimedia.org/r/75511 (owner: 10Helder.wiki) [09:05:53] (03Merged) 10jenkins-bot: Add a note when the return value was added to mediawiki.loader.using [core] - 10https://gerrit.wikimedia.org/r/169996 (owner: 10Nikerabbit) [09:10:47] (03CR) 10Zfilipin: [C: 031] QA: remove Scenario for "old permalink" checking [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169943 (owner: 10Cmcmahon) [09:11:43] 3MediaWiki / 3Categories: sorting in category: B before A - 10https://bugzilla.wikimedia.org/72661#c3 (10Bartosz Dziewoński) The underlying software bug has been fixed a while ago, so given the low number of affected pages this could be fixed on-wiki, for example by deleting and recreating the subcategories.... [09:30:24] (03CR) 10Smuggli: [C: 032 V: 032] Fixed MaximizablePanel in Chrome [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/169349 (owner: 10Robert Vogel) [09:30:43] (03CR) 10Smuggli: [C: 032 V: 032] Fixed MaximizablePanel in Chrome [extensions/BlueSpiceExtensions] (REL1_22) - 10https://gerrit.wikimedia.org/r/169338 (owner: 10Robert Vogel) [09:34:13] (03PS1) 10Pastakhov: Init and add Slick widget (v 1.0.0) [extensions/PhpTagsWidgets] - 10https://gerrit.wikimedia.org/r/169999 [09:37:40] (03CR) 10Gilles: [C: 032] Remove default date population with "now" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/169858 (https://bugzilla.wikimedia.org/53605) (owner: 10MarkTraceur) [09:38:14] (03Merged) 10jenkins-bot: Remove default date population with "now" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/169858 (https://bugzilla.wikimedia.org/53605) (owner: 10MarkTraceur) [09:40:26] (03PS1) 10Santhosh: Revert "Derive MT subsentence map from uppercasing" [services/cxserver] - 10https://gerrit.wikimedia.org/r/170000 [09:40:44] (03PS2) 10Smuggli: Added boost query for namespace evaluation [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/169666 [09:43:19] (03PS3) 10Smuggli: Added boost query for namespace evaluation [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/169666 [09:46:48] 3Wikimedia / 3General/Unknown: cs.wikiversity drop down menu doesn't display all pages - 10https://bugzilla.wikimedia.org/42041#c7 (10Glaisher) 5NEW>3RESO/WOR This works now. [10:06:57] 3Wikimedia / 3Apache configuration: tr.wikiMedia.org redirects to tr.m.wikiPedia.org - 10https://bugzilla.wikimedia.org/52837#c7 (10Glaisher) Looks like mobile sites are not set up for the chapter wikis. [10:48:14] (03CR) 10He7d3r: "Thanks!" [core] - 10https://gerrit.wikimedia.org/r/169996 (owner: 10Nikerabbit) [11:04:12] 3Wikimedia / 3Media storage: Swift outage caused a bunch of moved files to be "inconsistent" and "missing" - 10https://bugzilla.wikimedia.org/69311#c21 (10Tisza Gergő) On a closer look, almost all of these seem to be about old versions of files. The files for which the current version is missing (filtered vi... [12:47:47] (03PS1) 10Nikerabbit: Yandex backend [services/cxserver] - 10https://gerrit.wikimedia.org/r/170015 [12:48:12] (03CR) 10jenkins-bot: [V: 04-1] Yandex backend [services/cxserver] - 10https://gerrit.wikimedia.org/r/170015 (owner: 10Nikerabbit) [12:50:58] (03CR) 10Gergő Tisza: "Normally :) I think the function in question is the one returned by UploadWizardUpload.duplicateErrorInfo." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/169919 (owner: 10Gergő Tisza) [12:52:59] (03PS1) 10Pwirth: BsValidator: Fixed warning [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/170016 [12:55:22] (03PS2) 10Nikerabbit: Yandex backend [services/cxserver] - 10https://gerrit.wikimedia.org/r/170015 [12:55:52] (03CR) 10jenkins-bot: [V: 04-1] Yandex backend [services/cxserver] - 10https://gerrit.wikimedia.org/r/170015 (owner: 10Nikerabbit) [12:57:03] (03PS3) 10Nikerabbit: Yandex backend [services/cxserver] - 10https://gerrit.wikimedia.org/r/170015 [12:58:28] (03CR) 10jenkins-bot: [V: 04-1] Yandex backend [services/cxserver] - 10https://gerrit.wikimedia.org/r/170015 (owner: 10Nikerabbit) [12:58:59] (03PS4) 10Nikerabbit: Yandex backend [services/cxserver] - 10https://gerrit.wikimedia.org/r/170015 [12:59:24] (03CR) 10jenkins-bot: [V: 04-1] Yandex backend [services/cxserver] - 10https://gerrit.wikimedia.org/r/170015 (owner: 10Nikerabbit) [13:00:43] (03PS1) 10Christopher Johnson (WMDE): Adds Celerity map and resources [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/170018 [13:01:18] (03PS5) 10Nikerabbit: Yandex backend [services/cxserver] - 10https://gerrit.wikimedia.org/r/170015 [13:04:07] (03PS1) 10Pwirth: Blog: Thumb float direction [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/170019 [13:15:01] (03CR) 10Smuggli: [C: 032 V: 032] BsValidator: Fixed warning [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/170016 (owner: 10Pwirth) [13:16:17] (03CR) 10Smuggli: [C: 031 V: 032] Blog: Thumb float direction [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/170019 (owner: 10Pwirth) [13:18:11] 3Wikimedia / 3Mailing lists: Beta should not send Newprojects announcements to the "real" mailing list - 10https://bugzilla.wikimedia.org/48786#c26 (10Antoine "hashar" Musso (WMF)) 5RESO/?>3VERI I don't think we need to send any announcement for the creation of wikis on the beta cluster, but if we ever w... [13:29:56] 3OCG / 3General/Unknown: Crash with HTTPS only Mediawiki instances - 10https://bugzilla.wikimedia.org/71797#c2 (10C. Scott Ananian) Yeah, this sonuds like your HTTPS certificates are invalid. That's not a Parsoid/OCG problem. [13:38:12] 3MediaWiki / 3API: Unicode characters in API output - 10https://bugzilla.wikimedia.org/72734#c1 (10Brad Jorsch) 5UNCO>3RESO/WOR "\u00e9" is also produced by JavaScript and other ECMAScript implementations. Your JSON decoder should be handling it for you; if you're writing your own JSON decoder, it will n... [13:48:48] (03Draft1) 10Aude: Track branch for special extensions [tools/release] - 10https://gerrit.wikimedia.org/r/170025 (https://bugzilla.wikimedia.org/72759) [13:49:34] (03CR) 10Aude: "i was only able to partially test and verify this, but seems to work" [tools/release] - 10https://gerrit.wikimedia.org/r/170025 (https://bugzilla.wikimedia.org/72759) (owner: 10Aude) [13:50:07] (03CR) 10Hoo man: [C: 04-1] Don't let users merge themselves (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/169601 (owner: 10Legoktm) [13:53:37] (03CR) 10Steinsplitter: [C: 031] Parse 'upload_source_url' message on SpecialUpload [core] - 10https://gerrit.wikimedia.org/r/169572 (owner: 10Hoo man) [13:56:41] (03CR) 10Anomie: Expose all ancestor frames (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/169983 (owner: 10Jackmcbarn) [13:58:11] 3MediaWiki / 3API: Unicode characters in API output - 10https://bugzilla.wikimedia.org/72734#c2 (10Kevin Israel (PleaseStand)) (In reply to Brad Jorsch from comment #1) > "\u00e9" is also produced by JavaScript and other ECMAScript > implementations. Brad, I think you meant "correctly parsed" instead of "pr... [13:59:00] (03CR) 10Hashar: "People would most probably run rubocop locally before sending their patch to Gerrit. Since they have extensions cloned under /extensions/ " [core] - 10https://gerrit.wikimedia.org/r/167794 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [14:00:11] (03CR) 10Hoo man: "Looks ok in general... I have two nitpicks. though" (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/169542 (https://bugzilla.wikimedia.org/70850) (owner: 10Legoktm) [14:02:45] (03PS2) 10Cscott: Be quiet when unzipping; don't create pipes in `P.spawn`. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/169941 [14:03:09] (03CR) 10Smuggli: [C: 032 V: 032] Added boost query for namespace evaluation [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/169666 (owner: 10Smuggli) [14:03:24] (03CR) 10Smuggli: [C: 032 V: 032] Added support for opensearch [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/169509 (owner: 10Smuggli) [14:03:38] (03CR) 10Smuggli: [C: 032 V: 032] Renamed autocomplete file [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/169733 (owner: 10Smuggli) [14:12:41] (03CR) 10Hoo man: [C: 031] "Untested... and the code in LogEventsList looks a little scary (also the old one, so nothing new here)." [core] - 10https://gerrit.wikimedia.org/r/169540 (https://bugzilla.wikimedia.org/70850) (owner: 10Legoktm) [14:12:57] (03PS1) 10Cscott: Move this package to the WMF repository. [extensions/Collection/OfflineContentGenerator/zim_renderer] - 10https://gerrit.wikimedia.org/r/170029 [14:16:13] 3MediaWiki / 3API: Undefined property: stdClass::$page_touched in ApiPageSet.php on line 712 - 10https://bugzilla.wikimedia.org/72764 (10Aude) 3NEW p:3Unprio s:3normal a:3None a lot of such notices in the hhvm.log though this is probably not hhvm-specific. Undefined property: stdClass::$page_touched... [14:19:58] (03CR) 10SG: [C: 04-1] "May need to have post code put back." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166727 (owner: 10SG) [14:22:42] 3MediaWiki / 3API: Unicode characters in API output - 10https://bugzilla.wikimedia.org/72734#c3 (10nejuje6tpztluvolq) I'm using a language (awk) with no native UTF or JSON support so found it needs to pipe through the unix utility iconv eg. > echo '\u00E9' | iconv -f java > é However &utf8=1 is awesome. Th... [14:26:29] (03PS1) 10Cscott: Update dependencies. [extensions/Collection/OfflineContentGenerator/zim_renderer] - 10https://gerrit.wikimedia.org/r/170032 [14:26:32] (03PS1) 10Cscott: Be quiet when unzipping; don't create pipes in `P.spawn`. [extensions/Collection/OfflineContentGenerator/zim_renderer] - 10https://gerrit.wikimedia.org/r/170033 [14:26:37] (03CR) 10Jackmcbarn: Expose all ancestor frames (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/169983 (owner: 10Jackmcbarn) [14:27:36] cscott: nice commit message! ^ [14:31:38] (03CR) 10Cscott: [C: 032 V: 032] Move this package to the WMF repository. [extensions/Collection/OfflineContentGenerator/zim_renderer] - 10https://gerrit.wikimedia.org/r/170029 (owner: 10Cscott) [14:31:57] (03CR) 10Cscott: [C: 032 V: 032] Update dependencies. [extensions/Collection/OfflineContentGenerator/zim_renderer] - 10https://gerrit.wikimedia.org/r/170032 (owner: 10Cscott) [14:32:17] (03CR) 10Cscott: [C: 032 V: 032] Be quiet when unzipping; don't create pipes in `P.spawn`. [extensions/Collection/OfflineContentGenerator/zim_renderer] - 10https://gerrit.wikimedia.org/r/170033 (owner: 10Cscott) [14:39:54] (03CR) 10Cscott: [C: 032] Update dependencies. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/169796 (owner: 10Cscott) [14:42:02] (03CR) 10Cscott: [C: 032] Update dependencies. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/169940 (owner: 10Cscott) [14:42:10] (03CR) 10Cscott: [C: 032] Be quiet when unzipping; don't create pipes in `P.spawn`. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/169941 (owner: 10Cscott) [14:42:24] (03Merged) 10jenkins-bot: Update dependencies. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/169940 (owner: 10Cscott) [14:42:26] (03Merged) 10jenkins-bot: Be quiet when unzipping; don't create pipes in `P.spawn`. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/169941 (owner: 10Cscott) [14:43:06] (03CR) 10Santhosh: "Niklas, could you please split the generic improvements on MT backend to another patch? Yandex backend can not be merged to master since i" [services/cxserver] - 10https://gerrit.wikimedia.org/r/170015 (owner: 10Nikerabbit) [14:43:49] (03PS1) 10Aude: Update Wikidata, fix aliases "edit" link [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170042 [14:46:37] (03CR) 10Nikerabbit: "Sure but as far as I can see there is nothing that prevents merging. Aside from removing it from default configs." [services/cxserver] - 10https://gerrit.wikimedia.org/r/170015 (owner: 10Nikerabbit) [14:47:09] (03CR) 10MarkAHershberger: "noting for myself for later: This doesn't require release notes since it fixes a problem introduced since 1.23." [core] - 10https://gerrit.wikimedia.org/r/167523 (owner: 10Hoo man) [14:48:00] (03CR) 10Matthias Mullie: [C: 04-1] "Looks good, just some minor cleanups" (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168259 (owner: 10EBernhardson) [14:49:15] (03CR) 10Matthias Mullie: [C: 032] Remove initStorer callback [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168100 (owner: 10Mattflaschen) [14:50:07] (03Merged) 10jenkins-bot: Remove initStorer callback [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168100 (owner: 10Mattflaschen) [14:52:46] (03CR) 10Matthias Mullie: [C: 032] Restore workflow query parameter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168184 (https://bugzilla.wikimedia.org/72336) (owner: 10EBernhardson) [14:53:31] (03Merged) 10jenkins-bot: Restore workflow query parameter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168184 (https://bugzilla.wikimedia.org/72336) (owner: 10EBernhardson) [14:53:42] 3OCG / 3General/Unknown: Crash with HTTPS only Mediawiki instances - 10https://bugzilla.wikimedia.org/71797#c3 (10Kelson [Emmanuel Engelhart]) I know only two people who have tried to installed OCG and both were puzzled by this problem. We need: 1 - A correct error handling 2 - The solution should be clearl... [14:55:56] (03PS6) 10Nikerabbit: Yandex backend [services/cxserver] - 10https://gerrit.wikimedia.org/r/170015 [14:55:58] (03PS1) 10Nikerabbit: Improve mt error handling and reporting [services/cxserver] - 10https://gerrit.wikimedia.org/r/170044 [14:58:41] (03CR) 10MarkTraceur: [C: 032] Update Wikidata, fix aliases "edit" link [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170042 (owner: 10Aude) [14:59:23] (03CR) 10MarkAHershberger: "Release notes state: "Older versions of MediaWiki core will barf at this usage."" [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/168207 (https://bugzilla.wikimedia.org/70630) (owner: 10Awight) [15:04:19] (03Merged) 10jenkins-bot: Update Wikidata, fix aliases "edit" link [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170042 (owner: 10Aude) [15:04:37] (03CR) 10Matthias Mullie: [C: 032] "This patch hurt my head" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168743 (owner: 10EBernhardson) [15:04:55] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make ObjectManager instantiation readable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168743 (owner: 10EBernhardson) [15:06:07] (03CR) 10Matthias Mullie: [C: 032] Hygeine: Remove stub/unused links from API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169317 (owner: 10Mattflaschen) [15:06:30] (03CR) 10Nikerabbit: Improve mt error handling and reporting (031 comment) [services/cxserver] - 10https://gerrit.wikimedia.org/r/170044 (owner: 10Nikerabbit) [15:06:55] (03Merged) 10jenkins-bot: Hygeine: Remove stub/unused links from API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169317 (owner: 10Mattflaschen) [15:08:03] (03CR) 10Matthias Mullie: [C: 032] Hygiene: kill fake post_moderation_state i18n message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169595 (owner: 10EBernhardson) [15:08:11] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: kill fake post_moderation_state i18n message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169595 (owner: 10EBernhardson) [15:08:20] (03CR) 10MarkAHershberger: "Fixes code introduced in 4f0b2f42419c283e8c94a5be6147d54ae7731a6b" [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/162908 (owner: 10Aude) [15:08:55] (03CR) 10Legoktm: Don't let users merge themselves (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/169601 (owner: 10Legoktm) [15:12:47] (03CR) 10Legoktm: "If you have an extension which is using this feature with a version of core that doesn't have this feature (<1.24), it'll barf." [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/168207 (https://bugzilla.wikimedia.org/70630) (owner: 10Awight) [15:14:59] (03PS1) 10Manybubbles: Skip loading skins if no SkinFactory [vagrant] - 10https://gerrit.wikimedia.org/r/170046 [15:25:43] (03PS1) 10Matthias Mullie: Restore used namespaces in Action.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170049 [15:26:09] (03CR) 10Matthias Mullie: Restore workflow query parameter (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168184 (https://bugzilla.wikimedia.org/72336) (owner: 10EBernhardson) [15:40:41] 3MediaWiki / 3User login and signup: Not loading site CSS on Special:UserLogin/Preferences breaks wikis which use it to create a skin/theme - 10https://bugzilla.wikimedia.org/71621#c14 (10Mark A. Hershberger) Kunal's fix here makes sense to me. Perhaps the ideal would be that everyone who sets up a wiki has... [15:43:49] (03CR) 10Matthias Mullie: [C: 04-1] "-1 for the small issue." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169596 (owner: 10EBernhardson) [15:51:16] (03CR) 10Matthias Mullie: "A quick glance at https://gerrit.wikimedia.org/r/#/c/169597/4/handlebars/flow_post_meta_actions.handlebars leads me to believe that we sti" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169596 (owner: 10EBernhardson) [15:51:42] (03CR) 10Matthias Mullie: [C: 04-1] "See comment on parent patch" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169597 (owner: 10EBernhardson) [15:53:14] (03CR) 10Matthias Mullie: [C: 032] Hygiene: Standardize spelling of API classes and methods. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169634 (owner: 10Mattflaschen) [15:53:21] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Standardize spelling of API classes and methods. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169634 (owner: 10Mattflaschen) [15:57:27] (03PS1) 10MarkAHershberger: 1.24.0-rc.0 [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/170058 [15:59:27] (03CR) 10Legoktm: Allow for searching the global rename log by previous username (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/169542 (https://bugzilla.wikimedia.org/70850) (owner: 10Legoktm) [15:59:35] (03PS3) 10Legoktm: Allow for searching the global rename log by previous username [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/169542 (https://bugzilla.wikimedia.org/70850) [16:00:20] hoo: I responded on https://gerrit.wikimedia.org/r/#/c/169601/ [16:01:22] I see [16:01:36] (03CR) 10Hoo man: [C: 032] Don't let users merge themselves [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/169601 (owner: 10Legoktm) [16:01:38] (03PS2) 10Matthias Mullie: Hygiene: Make ObjectManager instantiation readable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168743 (owner: 10EBernhardson) [16:01:49] (03CR) 10Matthias Mullie: [C: 032] Hygiene: Make ObjectManager instantiation readable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168743 (owner: 10EBernhardson) [16:01:56] thanks [16:02:34] (03Merged) 10jenkins-bot: Don't let users merge themselves [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/169601 (owner: 10Legoktm) [16:02:38] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make ObjectManager instantiation readable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168743 (owner: 10EBernhardson) [16:02:41] (03Merged) 10jenkins-bot: Hygiene: Make ObjectManager instantiation readable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168743 (owner: 10EBernhardson) [16:03:28] (03PS3) 10Matthias Mullie: Hygiene: kill fake post_moderation_state i18n message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169595 (owner: 10EBernhardson) [16:03:55] (03CR) 10Matthias Mullie: [C: 032] Hygiene: kill fake post_moderation_state i18n message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169595 (owner: 10EBernhardson) [16:07:08] (03CR) 10Hashar: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169595 (owner: 10EBernhardson) [16:07:31] (03Abandoned) 10Reedy: De-globali[sz]e Special:ActiveUsers [core] - 10https://gerrit.wikimedia.org/r/139868 (owner: 10Reedy) [16:11:23] (03PS4) 10MarkTraceur: Parse 'upload_source_url' message on SpecialUpload [core] - 10https://gerrit.wikimedia.org/r/169572 (owner: 10Hoo man) [16:11:29] (03CR) 10MarkTraceur: [C: 032] Parse 'upload_source_url' message on SpecialUpload [core] - 10https://gerrit.wikimedia.org/r/169572 (owner: 10Hoo man) [16:12:21] (03PS1) 10MarkTraceur: Parse 'upload_source_url' message on SpecialUpload [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170062 [16:12:48] (03PS1) 10MarkTraceur: Parse 'upload_source_url' message on SpecialUpload [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170063 [16:14:36] (03PS1) 10Awight: update CentralNotice submodule [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170065 [16:14:48] (03CR) 10Awight: [C: 032] update CentralNotice submodule [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170065 (owner: 10Awight) [16:14:50] (03PS2) 10MarkAHershberger: 1.24.0-rc.0 [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/170058 [16:15:48] (03PS1) 10Awight: update CentralNotice submodule [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170066 [16:16:01] (03CR) 10Awight: [C: 032] update CentralNotice submodule [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170066 (owner: 10Awight) [16:16:11] (03CR) 10EBernhardson: [C: 032] Restore used namespaces in Action.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170049 (owner: 10Matthias Mullie) [16:16:30] (03CR) 10Mglaser: [C: 032 V: 032] 1.24.0-rc.0 [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/170058 (owner: 10MarkAHershberger) [16:17:33] marktraceur: hey... you deploying? [16:18:10] marktraceur: I'm happy to push those SpecialUpload patches along with the CentralNotice upgrade we're doing... [16:18:40] (03Merged) 10jenkins-bot: Parse 'upload_source_url' message on SpecialUpload [core] - 10https://gerrit.wikimedia.org/r/169572 (owner: 10Hoo man) [16:19:12] 3Wikimedia / 3General/Unknown: HHVM looks for config in /usr/etc/hhvm rather than /etc/hhvm - 10https://bugzilla.wikimedia.org/71343#c2 (10Bryan Davis) 5NEW>3RESO/FIX Retested with hhvm build 3.3.0+dfsg1-1+wm1: $ strace php hello.php 2>&1 | grep '/etc/hhvm' access("/etc/hhvm/php.ini", R_OK) = 0 ac... [16:20:27] 3Wikimedia / 3SSL related: Put all zirconium vhosts behind misc varnish cluster - 10https://bugzilla.wikimedia.org/58048 (10Bryan Davis) [16:21:44] 3Wikimedia / 3Site requests: request for GlamWikiToolset upload for europeanafashion - 10https://bugzilla.wikimedia.org/72765 (10tobias.hendrickx) 3UNCO p:3Unprio s:3normal a:3None please add the following domain(s) to the wgCopyUploadsDomains whitelist: http://repos.europeanafashion.eu/momu/images/ [16:22:26] (03Merged) 10jenkins-bot: update CentralNotice submodule [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170065 (owner: 10Awight) [16:23:41] (03CR) 10TheDJ: [C: 032] Remove whitespace at the end of lines [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/169751 (owner: 10Florianschmidtwelzow) [16:23:45] (03Merged) 10jenkins-bot: update CentralNotice submodule [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170066 (owner: 10Awight) [16:23:47] (03CR) 10jenkins-bot: [V: 04-1] Restore used namespaces in Action.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170049 (owner: 10Matthias Mullie) [16:25:41] 3Wikimedia / 3Site requests: Add domains to $wgCopyUploadsDomains (tracking) - 10https://bugzilla.wikimedia.org/58224 (10Glaisher) [16:25:42] 3Wikimedia / 3Site requests: request for GlamWikiToolset upload for europeanafashion - 10https://bugzilla.wikimedia.org/72765 (10Glaisher) 5UNCO>3NEW p:5Unprio>3Normal s:5normal>3enhanc [16:31:18] (03Merged) 10jenkins-bot: Remove whitespace at the end of lines [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/169751 (owner: 10Florianschmidtwelzow) [16:42:19] vagrant boo: Error: Could not set 'file' on ensure: No such file or directory - /usr/lib/php5/sessionclean20141030-2327-ds0hj6.lock at 26:/tmp/vagrant-puppet-1/modules-0/php/manifests/sessionclean.pp [16:43:22] (03CR) 10EBernhardson: [C: 032] Restore used namespaces in Action.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170049 (owner: 10Matthias Mullie) [16:44:11] (03Merged) 10jenkins-bot: Restore used namespaces in Action.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170049 (owner: 10Matthias Mullie) [16:44:32] (03PS1) 10Umherirrender: Remove unused globals [core] - 10https://gerrit.wikimedia.org/r/170074 [16:45:22] (03CR) 10MaxSem: [C: 032] Skip loading skins if no SkinFactory [vagrant] - 10https://gerrit.wikimedia.org/r/170046 (owner: 10Manybubbles) [16:45:29] (03Merged) 10jenkins-bot: Skip loading skins if no SkinFactory [vagrant] - 10https://gerrit.wikimedia.org/r/170046 (owner: 10Manybubbles) [16:45:38] MaxSem: thanks [16:46:12] ori: Thank you for the patch, but please refrain from self-merging! re: https://gerrit.wikimedia.org/r/157484 [16:46:21] manybubbles, do you have to test against older versions? [16:46:30] awight: What, right now? I don't think so [16:46:36] Oh, sure [16:46:42] MaxSem: I've got someone that'd like a backport of cirrus against the lts release, yeah [16:46:44] awight: If I'm not too late that would be awesome [16:46:48] ori: Sorry for the two-month delay, I definitely understand. [16:47:06] and one of the goals of the project is to get it more widely used outside of wmf - basically to not be mwsearch [16:47:07] marktraceur: ah. We just deployed, but things looks good for us. YEah I'm happy to push yr changes. [16:47:13] K thanks :) [16:47:22] (03PS1) 10Legoktm: Remove Asirra integration [extensions/ConfirmEdit] (REL1_24) - 10https://gerrit.wikimedia.org/r/170076 (https://bugzilla.wikimedia.org/71712) [16:47:23] I can take them off the SWAT calendar when you're done [16:47:27] marktraceur: u mind linking again? [16:47:38] (03CR) 10Legoktm: [C: 032] Remove Asirra integration [extensions/ConfirmEdit] (REL1_24) - 10https://gerrit.wikimedia.org/r/170076 (https://bugzilla.wikimedia.org/71712) (owner: 10Legoktm) [16:47:44] (03Merged) 10jenkins-bot: Remove Asirra integration [extensions/ConfirmEdit] (REL1_24) - 10https://gerrit.wikimedia.org/r/170076 (https://bugzilla.wikimedia.org/71712) (owner: 10Legoktm) [16:48:10] marktraceur: ok nvm, I found them in the SWAT [16:48:16] Sweet [16:48:50] (03CR) 10Awight: [C: 032] Parse 'upload_source_url' message on SpecialUpload [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170062 (owner: 10MarkTraceur) [16:49:07] (03CR) 10Awight: [C: 032] Parse 'upload_source_url' message on SpecialUpload [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170063 (owner: 10MarkTraceur) [16:49:34] marktraceur: considering the time... you mind if I skip the unit tests? [16:49:52] awight: Is there another deploy after you? I don't think so, it should be OK to run over [16:50:09] marktraceur: ok, lemme alert greg-g [16:50:14] greg-g: You mind a slight overrun so awight can finish pushing my patches? [16:50:42] hehe just pinged him in -ops [16:51:04] (03PS1) 10Umherirrender: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/170078 [16:55:09] (03Merged) 10jenkins-bot: Parse 'upload_source_url' message on SpecialUpload [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170062 (owner: 10MarkTraceur) [16:55:14] (03PS1) 10Manybubbles: Support specifying replica count per index type [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/170079 [16:55:16] (03PS7) 10EBernhardson: Hygiene: Use real objects instead of mocks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168259 [16:55:35] (03Merged) 10jenkins-bot: Parse 'upload_source_url' message on SpecialUpload [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170063 (owner: 10MarkTraceur) [16:55:37] (03PS1) 10Legoktm: Create a generic UDP transport class [core] - 10https://gerrit.wikimedia.org/r/170080 (https://bugzilla.wikimedia.org/72572) [16:55:39] (03PS1) 10Umherirrender: The final declaration must precede the visibility declaration [core] - 10https://gerrit.wikimedia.org/r/170081 [16:55:52] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use real objects instead of mocks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168259 (owner: 10EBernhardson) [16:55:55] (03CR) 10EBernhardson: Hygiene: Use real objects instead of mocks (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168259 (owner: 10EBernhardson) [16:57:48] (03CR) 10EBernhardson: Validate UserTuple constructor input (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168258 (owner: 10EBernhardson) [16:58:49] (03PS7) 10EBernhardson: Validate UserTuple constructor input [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168258 [16:59:36] (03PS40) 10EBernhardson: Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [17:00:13] (03PS1) 10Umherirrender: Remove double semicolon [core] - 10https://gerrit.wikimedia.org/r/170083 [17:00:21] (03CR) 10jenkins-bot: [V: 04-1] Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [17:01:00] (03CR) 10Matthias Mullie: [C: 031] Hygiene: Use real objects instead of mocks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168259 (owner: 10EBernhardson) [17:01:41] 3MediaWiki extensions / 3ConfirmEdit (CAPTCHA extension): Remove Asirra integration - 10https://bugzilla.wikimedia.org/71712#c11 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX I backported the removal to the 1.24 branch as well. [17:03:36] (03CR) 10Matthias Mullie: [C: 032] Validate UserTuple constructor input [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168258 (owner: 10EBernhardson) [17:04:26] (03Merged) 10jenkins-bot: Validate UserTuple constructor input [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168258 (owner: 10EBernhardson) [17:06:59] 3MediaWiki / 3API: Undefined property: stdClass::$page_touched in ApiPageSet.php on line 712 - 10https://bugzilla.wikimedia.org/72764#c1 (10Brad Jorsch) a:3Brad Jorsch I found three things that could cause this bug (although as far as I can tell only the third actually is). Patches coming. [17:09:01] (03PS1) 10Reedy: Fix .gitreview [extensions/ConfirmEdit] (REL1_23) - 10https://gerrit.wikimedia.org/r/170085 [17:09:03] (03PS1) 10Reedy: Remove Asirra integration [extensions/ConfirmEdit] (REL1_23) - 10https://gerrit.wikimedia.org/r/170086 (https://bugzilla.wikimedia.org/71712) [17:09:45] (03PS2) 10Paladox: Adding files [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/169787 [17:09:52] (03CR) 10Paladox: [C: 031] Adding files [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/169787 (owner: 10Paladox) [17:10:01] (03CR) 10Phuedx: [C: 04-1] Split out ResourceLoaderTemplateParserModule from ResourceLoaderTemplateModule (031 comment) [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/169926 (owner: 10Jdlrobson) [17:10:49] (03CR) 10Chad: [C: 031] Use MWLogger logging for wfLogProfilingData [core] - 10https://gerrit.wikimedia.org/r/119942 (owner: 10BryanDavis) [17:12:01] (03PS1) 10Reedy: Fix .gitreview [extensions/ConfirmEdit] (REL1_22) - 10https://gerrit.wikimedia.org/r/170087 [17:12:03] (03PS1) 10Reedy: Remove Asirra integration [extensions/ConfirmEdit] (REL1_22) - 10https://gerrit.wikimedia.org/r/170088 (https://bugzilla.wikimedia.org/71712) [17:13:18] (03PS5) 10Legoktm: Require PHP >= 5.3.3 [core] - 10https://gerrit.wikimedia.org/r/168535 [17:15:35] (03PS1) 10Reedy: Add .gitreview [extensions/ConfirmEdit] (REL1_19) - 10https://gerrit.wikimedia.org/r/170090 [17:15:37] (03PS1) 10Reedy: Remove Asirra integration [extensions/ConfirmEdit] (REL1_19) - 10https://gerrit.wikimedia.org/r/170091 (https://bugzilla.wikimedia.org/71712) [17:16:25] (03CR) 10Legoktm: [C: 032] Fix .gitreview [extensions/ConfirmEdit] (REL1_23) - 10https://gerrit.wikimedia.org/r/170085 (owner: 10Reedy) [17:16:31] (03Merged) 10jenkins-bot: Fix .gitreview [extensions/ConfirmEdit] (REL1_23) - 10https://gerrit.wikimedia.org/r/170085 (owner: 10Reedy) [17:16:46] (03CR) 10Legoktm: [C: 032] Remove Asirra integration [extensions/ConfirmEdit] (REL1_23) - 10https://gerrit.wikimedia.org/r/170086 (https://bugzilla.wikimedia.org/71712) (owner: 10Reedy) [17:16:52] (03CR) 10Legoktm: [C: 032] Remove Asirra integration [extensions/ConfirmEdit] (REL1_22) - 10https://gerrit.wikimedia.org/r/170088 (https://bugzilla.wikimedia.org/71712) (owner: 10Reedy) [17:16:54] (03Merged) 10jenkins-bot: Remove Asirra integration [extensions/ConfirmEdit] (REL1_23) - 10https://gerrit.wikimedia.org/r/170086 (https://bugzilla.wikimedia.org/71712) (owner: 10Reedy) [17:16:57] (03CR) 10Legoktm: [C: 032] Fix .gitreview [extensions/ConfirmEdit] (REL1_22) - 10https://gerrit.wikimedia.org/r/170087 (owner: 10Reedy) [17:17:07] (03Merged) 10jenkins-bot: Fix .gitreview [extensions/ConfirmEdit] (REL1_22) - 10https://gerrit.wikimedia.org/r/170087 (owner: 10Reedy) [17:17:09] (03Merged) 10jenkins-bot: Remove Asirra integration [extensions/ConfirmEdit] (REL1_22) - 10https://gerrit.wikimedia.org/r/170088 (https://bugzilla.wikimedia.org/71712) (owner: 10Reedy) [17:17:23] (03CR) 10Legoktm: [C: 032] Add .gitreview [extensions/ConfirmEdit] (REL1_19) - 10https://gerrit.wikimedia.org/r/170090 (owner: 10Reedy) [17:17:25] (03CR) 10Legoktm: [C: 032] Remove Asirra integration [extensions/ConfirmEdit] (REL1_19) - 10https://gerrit.wikimedia.org/r/170091 (https://bugzilla.wikimedia.org/71712) (owner: 10Reedy) [17:17:31] (03Merged) 10jenkins-bot: Add .gitreview [extensions/ConfirmEdit] (REL1_19) - 10https://gerrit.wikimedia.org/r/170090 (owner: 10Reedy) [17:17:33] (03Merged) 10jenkins-bot: Remove Asirra integration [extensions/ConfirmEdit] (REL1_19) - 10https://gerrit.wikimedia.org/r/170091 (https://bugzilla.wikimedia.org/71712) (owner: 10Reedy) [17:18:41] 3MediaWiki extensions / 3ConfirmEdit (CAPTCHA extension): Remove Asirra integration - 10https://bugzilla.wikimedia.org/71712#c18 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX Gone from all supported versions now. [17:21:15] (03PS9) 10EBernhardson: Hygiene: Move RecentChangeListener to Listener namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165427 [17:21:18] (03PS14) 10EBernhardson: Hygiene: Simplify listener for inserting RecentChange [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165426 [17:23:45] (03CR) 10Reedy: [C: 032] "Let's do this..." [core] - 10https://gerrit.wikimedia.org/r/168535 (owner: 10Legoktm) [17:25:28] (03PS15) 10EBernhardson: Hygiene: Simplify listener for inserting RecentChange [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165426 [17:25:37] (03PS10) 10EBernhardson: Hygiene: Move RecentChangeListener to Listener namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165427 [17:26:16] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Simplify listener for inserting RecentChange [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165426 (owner: 10EBernhardson) [17:31:29] (03PS8) 10EBernhardson: Hygiene: Use real objects instead of mocks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168259 [17:32:37] (03CR) 10Arlolra: [C: 032] Don't create pipes for `P.spawn` by default. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/169937 (owner: 10Cscott) [17:32:41] (03CR) 10EBernhardson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165426 (owner: 10EBernhardson) [17:33:12] (03PS1) 10Anomie: Correctly populate pageset in ApiQueryGeoSearchElastic [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/170093 (https://bugzilla.wikimedia.org/72764) [17:33:26] (03CR) 10Arlolra: [C: 032] Update dependencies. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/169938 (owner: 10Cscott) [17:33:43] (03PS1) 10Anomie: API: Add doc warning to ApiPageSet::populateFromQueryResult [core] - 10https://gerrit.wikimedia.org/r/170094 (https://bugzilla.wikimedia.org/72764) [17:33:54] (03PS1) 10Anomie: API: Fix simplified continuation module skipping [core] - 10https://gerrit.wikimedia.org/r/170095 (https://bugzilla.wikimedia.org/72764) [17:34:41] 3MediaWiki / 3API: Undefined property: stdClass::$page_touched in ApiPageSet.php on line 712 - 10https://bugzilla.wikimedia.org/72764#c5 (10Brad Jorsch) (In reply to Brad Jorsch from comment #1) > I found three things that could cause this bug (although as far as I can > tell only the third actually is). Pat... [17:35:40] (03CR) 10Arlolra: [C: 032] Don't create pipes for `P.spawn` by default. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/169795 (owner: 10Cscott) [17:36:32] (03Merged) 10jenkins-bot: Don't create pipes for `P.spawn` by default. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/169937 (owner: 10Cscott) [17:36:34] (03Merged) 10jenkins-bot: Update dependencies. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/169938 (owner: 10Cscott) [17:36:42] (03CR) 10Arlolra: [C: 032] Update dependencies. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/169797 (owner: 10Cscott) [17:37:49] (03Merged) 10jenkins-bot: Don't create pipes for `P.spawn` by default. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/169795 (owner: 10Cscott) [17:37:51] (03Merged) 10jenkins-bot: Update dependencies. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/169796 (owner: 10Cscott) [17:38:01] (03Merged) 10jenkins-bot: Update dependencies. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/169797 (owner: 10Cscott) [17:38:14] (03CR) 10Arlolra: [C: 032] Add `/_version` API endpoint for verifying the running version of the service. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/169798 (owner: 10Cscott) [17:38:57] (03Merged) 10jenkins-bot: Add `/_version` API endpoint for verifying the running version of the service. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/169798 (owner: 10Cscott) [17:40:32] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (da4b0d5c14) [core] - 10https://gerrit.wikimedia.org/r/169970 (owner: 10Jforrester) [17:40:43] 3MediaWiki extensions / 3BounceHandler: Rename br_user column - 10https://bugzilla.wikimedia.org/72683 (10Tony Thomas) a:3Tony Thomas [17:44:29] (03CR) 10Legoktm: "recheck" [core] - 10https://gerrit.wikimedia.org/r/168535 (owner: 10Legoktm) [17:46:33] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (da4b0d5c14) [core] - 10https://gerrit.wikimedia.org/r/169970 (owner: 10Jforrester) [17:49:11] (03PS5) 10Jdlrobson: Split out ResourceLoaderTemplateParserModule from ResourceLoaderTemplateModule [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/169926 [17:50:44] (03CR) 10Theaitetos: [C: 032 V: 031] DynamicPageList: Use more standard LIMIT syntax [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/151265 (https://bugzilla.wikimedia.org/68994) (owner: 10Jjanes) [17:51:07] (03Merged) 10jenkins-bot: DynamicPageList: Use more standard LIMIT syntax [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/151265 (https://bugzilla.wikimedia.org/68994) (owner: 10Jjanes) [17:52:51] (03PS7) 10Jdlrobson: Register Handlebars with core [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/168434 [17:52:53] (03PS1) 10Jdlrobson: Remove Handlebars Mantle dependency [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/170099 [17:53:15] (03PS2) 10Jdlrobson: Remove Handlebars Mantle dependency [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/170099 [17:53:49] (03CR) 10jenkins-bot: [V: 04-1] Remove Handlebars Mantle dependency [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/170099 (owner: 10Jdlrobson) [17:55:56] (03CR) 10BryanDavis: Create a generic UDP transport class (031 comment) [core] - 10https://gerrit.wikimedia.org/r/170080 (https://bugzilla.wikimedia.org/72572) (owner: 10Legoktm) [17:56:28] (03PS5) 10Jdlrobson: Register Hogan with mw.template [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/169931 [17:56:40] (03PS2) 10MarkTraceur: WIP move most of the upload step stuff into controller.Upload [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/154341 [17:56:47] (03CR) 10jenkins-bot: [V: 04-1] WIP move most of the upload step stuff into controller.Upload [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/154341 (owner: 10MarkTraceur) [17:58:26] (03PS3) 10MarkTraceur: WIP move most of the upload step stuff into controller.Upload [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/154341 [17:58:29] (03CR) 10jenkins-bot: [V: 04-1] WIP move most of the upload step stuff into controller.Upload [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/154341 (owner: 10MarkTraceur) [17:58:41] (03PS6) 10Jdlrobson: Register Hogan with mw.template [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/169931 [17:59:37] (03CR) 10Mattflaschen: [C: 04-1] "Chris and I talked about this yesterday." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169943 (owner: 10Cmcmahon) [18:00:53] (03CR) 10MaxSem: [C: 032] Correctly populate pageset in ApiQueryGeoSearchElastic [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/170093 (https://bugzilla.wikimedia.org/72764) (owner: 10Anomie) [18:01:03] (03Merged) 10jenkins-bot: Correctly populate pageset in ApiQueryGeoSearchElastic [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/170093 (https://bugzilla.wikimedia.org/72764) (owner: 10Anomie) [18:01:54] (03PS1) 1001tonythomas: Rename br_user column to br_user_email and update comments [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170101 (https://bugzilla.wikimedia.org/72683) [18:03:19] (03CR) 10Mattflaschen: "Actually, that patch was merged this morning (I thought it was still open): https://gerrit.wikimedia.org/r/#/c/168184/1" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169943 (owner: 10Cmcmahon) [18:04:39] (03CR) 10Paladox: [C: 032 V: 032] "I have +2 so that the files are ready but could i have some help to do the i18n please." [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/169787 (owner: 10Paladox) [18:06:14] 3MediaWiki / 3Uploading: Add chunked upload support to standard Special:Upload for files larger than POST limit - 10https://bugzilla.wikimedia.org/72768 (10Brion Vibber) 3NEW p:3Unprio s:3enhanc a:3None While batch-fixing broken Ogg videos in https://commons.wikimedia.org/wiki/Category:Wikimania_2009... [18:06:52] (03PS2) 10Umherirrender: API: Actually use api-help-param-no-description [core] - 10https://gerrit.wikimedia.org/r/169718 (owner: 10Anomie) [18:07:00] (03CR) 10Umherirrender: [C: 032] API: Actually use api-help-param-no-description [core] - 10https://gerrit.wikimedia.org/r/169718 (owner: 10Anomie) [18:10:51] (03CR) 10Mattflaschen: [C: 04-1] "Okay, Danny said this should not be merged until the TOC is done anyway (since both aspects are user-visible, we don't want to remove this" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166727 (owner: 10SG) [18:13:43] (03Merged) 10jenkins-bot: API: Actually use api-help-param-no-description [core] - 10https://gerrit.wikimedia.org/r/169718 (owner: 10Anomie) [18:14:08] (03CR) 10Phuedx: "Update the DocBlock for ResourceLoaderTemplateModule and I reckon this is mergeable." (031 comment) [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/169926 (owner: 10Jdlrobson) [18:14:54] ori: how do we handle adding a new dependency to requirements.txt of EventLogging? Is the deployment of code + puppet run going to install that new dependency? [18:15:03] ori: or is that something we do by hand? [18:16:27] 3MediaWiki extensions / 3BounceHandler: Inconsistent returns in BounceHandler - 10https://bugzilla.wikimedia.org/72684 (10Tony Thomas) a:3Tony Thomas [18:17:09] (03PS6) 10Jdlrobson: Split out ResourceLoaderTemplateParserModule from ResourceLoaderTemplateModule [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/169926 [18:20:58] (03PS1) 10Legoktm: Add cssjanus/cssjanus 1.1.0 [vendor] - 10https://gerrit.wikimedia.org/r/170106 [18:22:28] (03PS1) 10Legoktm: Use CSSJanus via composer [core] - 10https://gerrit.wikimedia.org/r/170107 [18:22:50] (03CR) 10Catrope: (Bug 2700) Pre-save transform inside extension hooks (031 comment) [core] - 10https://gerrit.wikimedia.org/r/8784 (owner: 10Dan Collins) [18:23:04] (03PS2) 10Legoktm: Use CSSJanus via composer [core] - 10https://gerrit.wikimedia.org/r/170107 [18:25:18] (03PS2) 10Umherirrender: chmod 755 bash & Perl files, chmod 644 .css file [core] - 10https://gerrit.wikimedia.org/r/168627 (https://bugzilla.wikimedia.org/71972) (owner: 10Southparkfan) [18:25:26] (03CR) 10Umherirrender: [C: 032] chmod 755 bash & Perl files, chmod 644 .css file [core] - 10https://gerrit.wikimedia.org/r/168627 (https://bugzilla.wikimedia.org/71972) (owner: 10Southparkfan) [18:28:27] (03CR) 10jenkins-bot: [V: 04-1] Use CSSJanus via composer [core] - 10https://gerrit.wikimedia.org/r/170107 (owner: 10Legoktm) [18:29:11] (03PS2) 10Umherirrender: Add editors and other things to .gitignore [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/168758 [18:29:29] (03PS1) 10Umherirrender: Add editors and other things to .gitignore [vendor] - 10https://gerrit.wikimedia.org/r/170108 [18:30:37] (03CR) 10EBernhardson: "i don't have any" (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169500 (owner: 10Matthias Mullie) [18:30:51] (03CR) 10EBernhardson: "i dont have any particularly good suggestions, will have to think on it" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169500 (owner: 10Matthias Mullie) [18:32:01] (03Merged) 10jenkins-bot: chmod 755 bash & Perl files, chmod 644 .css file [core] - 10https://gerrit.wikimedia.org/r/168627 (https://bugzilla.wikimedia.org/71972) (owner: 10Southparkfan) [18:33:00] (03PS1) 10Alex Monk: Tidy up JS [extensions/LastModified] - 10https://gerrit.wikimedia.org/r/170110 [18:34:20] (03CR) 10Reedy: [C: 031] "Is it worth doing a patch to do the rename too? Are there going to be people that get annoyed by the rename? :)" [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170101 (https://bugzilla.wikimedia.org/72683) (owner: 1001tonythomas) [18:34:43] 3MediaWiki / 3General/Unknown: file permissions cause lintian warnings - 10https://bugzilla.wikimedia.org/71972#c4 (10Umherirrender) 5PATC>3RESO/FIX Some files also done with I6def7588b970a15c4e6bd49dc4f7a7138687a99e [18:41:57] (03CR) 10Umherirrender: "Was also backported to REL1_23 (Icf34bca58c792225d735d576213d6887015459ca) so in my opinion REL1_24 does not need a release note." [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/169965 (https://bugzilla.wikimedia.org/72274) (owner: 10Poke) [18:43:24] (03PS1) 1001tonythomas: Fix inconsistent returns in BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170112 (https://bugzilla.wikimedia.org/72684) [18:46:24] (03PS2) 10BryanDavis: GlobalRenameQueue: Allow users to add a comment for the public log [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/168996 (https://bugzilla.wikimedia.org/72545) (owner: 10Legoktm) [18:46:36] (03CR) 10BryanDavis: [C: 032] GlobalRenameQueue: Allow users to add a comment for the public log [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/168996 (https://bugzilla.wikimedia.org/72545) (owner: 10Legoktm) [18:46:41] (03PS1) 10Alex Monk: More misc JS fixes [extensions/LastModified] - 10https://gerrit.wikimedia.org/r/170114 [18:46:53] (03PS2) 10Umherirrender: API: Add doc warning to ApiPageSet::populateFromQueryResult [core] - 10https://gerrit.wikimedia.org/r/170094 (https://bugzilla.wikimedia.org/72764) (owner: 10Anomie) [18:47:02] (03CR) 10Umherirrender: [C: 032] API: Add doc warning to ApiPageSet::populateFromQueryResult [core] - 10https://gerrit.wikimedia.org/r/170094 (https://bugzilla.wikimedia.org/72764) (owner: 10Anomie) [18:47:28] (03Merged) 10jenkins-bot: GlobalRenameQueue: Allow users to add a comment for the public log [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/168996 (https://bugzilla.wikimedia.org/72545) (owner: 10Legoktm) [18:48:53] (03CR) 10Reedy: [C: 04-1] "Modify patch is really needed due to extension being installed on on all of beta" [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170101 (https://bugzilla.wikimedia.org/72683) (owner: 1001tonythomas) [18:49:00] (03CR) 1001tonythomas: "ok. I will prepare the alter table patch - since the extension is installed everywhere over labs." [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170101 (https://bugzilla.wikimedia.org/72683) (owner: 1001tonythomas) [18:50:14] 3MediaWiki extensions / 3CentralAuth: GlobalRenameQueue: When approving a request, add a field to add a reason for the public log - 10https://bugzilla.wikimedia.org/72545 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3Kunal Mehta (Legoktm) [18:53:29] (03Merged) 10jenkins-bot: API: Add doc warning to ApiPageSet::populateFromQueryResult [core] - 10https://gerrit.wikimedia.org/r/170094 (https://bugzilla.wikimedia.org/72764) (owner: 10Anomie) [18:57:27] (03PS1) 10Chad: Remove ProfileMwprof [core] - 10https://gerrit.wikimedia.org/r/170118 [18:58:26] (03CR) 10Jdlrobson: [C: 04-1] Work in progress: ogv.js media player for Safari/IE (3 of 3) (035 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165479 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER) [19:00:56] (03PS2) 10EBernhardson: Add automatic edit summaries for new topic & edit post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169499 (owner: 10Matthias Mullie) [19:01:18] (03CR) 10EBernhardson: [C: 031] "PS2: manual rebase" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169499 (owner: 10Matthias Mullie) [19:01:45] (03CR) 10jenkins-bot: [V: 04-1] Add automatic edit summaries for new topic & edit post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169499 (owner: 10Matthias Mullie) [19:02:10] (03CR) 10Brion VIBBER: "(some inline notes \o/)" (033 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165479 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER) [19:03:20] (03CR) 10EBernhardson: [C: 032] "re-apply mlitn +2" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169634 (owner: 10Mattflaschen) [19:03:27] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Standardize spelling of API classes and methods. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169634 (owner: 10Mattflaschen) [19:05:03] (03PS1) 10Southparkfan: Add executable rights for executable (bash) files [core] - 10https://gerrit.wikimedia.org/r/170120 [19:05:44] (03PS2) 10Southparkfan: Add executable rights for executable (bash) files [core] - 10https://gerrit.wikimedia.org/r/170120 [19:06:28] 3MediaWiki / 3API: meta=siteinfo should allow client to identify RTL languages - 10https://bugzilla.wikimedia.org/72153#c6 (10Umherirrender) He is asking for rtl="" for all supported languages, not for the content language (where the flag exists). https://he.wikipedia.org/w/api.php?action=query&meta=siteinf... [19:07:36] (03PS2) 10EBernhardson: Hygiene: Standardize spelling of API classes and methods. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169634 (owner: 10Mattflaschen) [19:08:10] (03CR) 10EBernhardson: [C: 032] "PS2: manual rebase" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169634 (owner: 10Mattflaschen) [19:08:55] (03CR) 10EBernhardson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169695 (owner: 10Matthias Mullie) [19:09:00] (03Merged) 10jenkins-bot: Hygiene: Standardize spelling of API classes and methods. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169634 (owner: 10Mattflaschen) [19:11:56] (03CR) 10EBernhardson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169695 (owner: 10Matthias Mullie) [19:13:28] (03CR) 10Umherirrender: [C: 032] Add executable rights for executable (bash) files [core] - 10https://gerrit.wikimedia.org/r/170120 (owner: 10Southparkfan) [19:16:56] 3Wikimedia / 3SSL related: Disable SSL 3.0 on Wikimedia sites to mitigate POODLE attack (CVE-2014-3566) - 10https://bugzilla.wikimedia.org/72072#c7 (10Daniel Zahn) (In reply to Daniel Zahn from comment #4) > it did NOT fix Tool Labs fixed toollabs by https://gerrit.wikimedia.org/r/#/c/169949/2 and restar... [19:19:26] (03Merged) 10jenkins-bot: Add executable rights for executable (bash) files [core] - 10https://gerrit.wikimedia.org/r/170120 (owner: 10Southparkfan) [19:19:42] 3MediaWiki extensions / 3BounceHandler: Performance review BounceHandler extension for Deployment - 10https://bugzilla.wikimedia.org/69100#c7 (10Sam Reed (reedy)) (In reply to Aaron Schulz from comment #3) > * The query in handleFailingRecipient() is unindexed, how large is the table > expected to get? I wa... [19:23:40] (03PS2) 1001tonythomas: Rename br_user column to br_user_email and update comments [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170101 (https://bugzilla.wikimedia.org/72683) [19:27:04] (03PS1) 10Reedy: Update monolog/monolog to 1.11.0 [vendor] - 10https://gerrit.wikimedia.org/r/170125 [19:27:25] * Reedy waits to see what Jenkins thinks of that [19:28:07] (03CR) 10Reedy: [C: 032] Add editors and other things to .gitignore [vendor] - 10https://gerrit.wikimedia.org/r/170108 (owner: 10Umherirrender) [19:28:44] 3Wikimedia / 3SSL related: Disable SSL 3.0 on Wikimedia sites to mitigate POODLE attack (CVE-2014-3566) - 10https://bugzilla.wikimedia.org/72072#c8 (10Daniel Zahn) Chmarkine, you had that nice table, what does your data say now, anything left? [19:28:56] (03PS1) 10Reedy: Require PHP >= 5.3.3 as per core [vendor] - 10https://gerrit.wikimedia.org/r/170128 [19:28:58] (03CR) 10EBernhardson: [C: 032] Add test for wikitext-html-wikitext roundtrip [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169695 (owner: 10Matthias Mullie) [19:30:59] (03CR) 1001tonythomas: [C: 04-1] Rename br_user column to br_user_email and update comments [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170101 (https://bugzilla.wikimedia.org/72683) (owner: 1001tonythomas) [19:33:28] 3MediaWiki / 3API: Allow registration of API modules and special pages as a factory function. - 10https://bugzilla.wikimedia.org/66870#c2 (10Umherirrender) Already fixed? - api part maybe gerrit 149183 - special page part maybe gerrit 152755 [19:33:31] 3MediaWiki / 3General/Unknown: Can't use underscore in page titles - 10https://bugzilla.wikimedia.org/72774 (10teo8976) 3UNCO p:3Unprio s:3major a:3None There's no way to create a page with an underscore in its title. Underscores are treated incorrectly because 1) Spaces in titles are encoded as unde... [19:33:54] (03Merged) 10jenkins-bot: Add editors and other things to .gitignore [vendor] - 10https://gerrit.wikimedia.org/r/170108 (owner: 10Umherirrender) [19:33:56] (03Merged) 10jenkins-bot: Add test for wikitext-html-wikitext roundtrip [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169695 (owner: 10Matthias Mullie) [19:37:17] (03PS2) 10Umherirrender: Require PHP >= 5.3.3 as per core [vendor] - 10https://gerrit.wikimedia.org/r/170128 (owner: 10Reedy) [19:37:32] (03CR) 10Umherirrender: [C: 032] "Iac827ef8505ff0653a40e45d759b0f79619351ee is the mediawiki/core change" [vendor] - 10https://gerrit.wikimedia.org/r/170128 (owner: 10Reedy) [19:39:16] (03CR) 10Krinkle: "Is there a straight forward way to verify the committed vendor contents match what composer does? (e.g. to avoid mistakes or malice) Right" [vendor] - 10https://gerrit.wikimedia.org/r/170106 (owner: 10Legoktm) [19:40:41] 3MediaWiki / 3General/Unknown: Can't use underscore in page titles - 10https://bugzilla.wikimedia.org/72774#c1 (10Bartosz Dziewoński) 5UNCO>3RESO/WON This is the expected behavior. You can use the DISPLAYTITLE: parser function to override the displayed page title, for example to display it with undersco... [19:41:27] (03CR) 10Poke: "Oh sure, I didn’t know how this is usually handled, so I just included it to be safe. But if that’s how it’s done, I’ll remove that part f" [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/169965 (https://bugzilla.wikimedia.org/72274) (owner: 10Poke) [19:41:28] 3MediaWiki / 3Parser: Support {{void}} as a magic word - 10https://bugzilla.wikimedia.org/72775 (10Diego Queiroz) 3UNCO p:3Unprio s:3normal a:3None Currently, some wikis use {{void}} as a Template to include empty strings into pages. This template has several uses (some of them described at [[:pt:Te... [19:42:28] 3Wikimedia / 3Bugzilla: Can't register to phabricator.wikimedia.org - 10https://bugzilla.wikimedia.org/72776 (10teo8976) 3UNCO p:3Unprio s:3critic a:3None I reported a bug here at bugzilla. Then I saw this warning: Phabricator will replace Bugzilla soon. For a smooth migration of your data, create y... [19:42:30] (03PS3) 1001tonythomas: Rename br_user column to br_user_email and update comments [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170101 (https://bugzilla.wikimedia.org/72683) [19:42:55] (03Merged) 10jenkins-bot: Require PHP >= 5.3.3 as per core [vendor] - 10https://gerrit.wikimedia.org/r/170128 (owner: 10Reedy) [19:43:10] (03PS1) 10MarkTraceur: Move stupid DOM-bound events to OO EE syntax [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170131 [19:43:55] (03CR) 10Phuedx: [C: 031] "This LGTM. Kaldari, MaxSem? I'm not super-familiar with RL so I'm a little uneasy about +2ing." [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/169926 (owner: 10Jdlrobson) [19:44:44] 3MediaWiki / 3General/Unknown: U+200B ZERO WIDTH SPACE allowed in page titles - 10https://bugzilla.wikimedia.org/27446 (10Bartosz Dziewoński) [19:44:44] 3MediaWiki / 3Parser: Question: Bidi overrides and Unicode spaces removal from titles: why not zero-width space and horizontal tab? - 10https://bugzilla.wikimedia.org/32717 (10Bartosz Dziewoński) [19:45:06] Anyone know if the tools used for the bugzilla -> phabricator migration are publicly available? [19:45:39] Lcawte: I'd presume they are, or will be eventually. Ask in #wikimedia-devtools for a better answer [19:45:46] 3MediaWiki / 3General/Unknown: [Regression] MediaWiki should detect absent or outdated vendor - 10https://bugzilla.wikimedia.org/72777 (10Krinkle) 3NEW p:3Unprio s:3blocke a:3None Right now doing git-pull gives me an blank HTTP 500 response with no information at all. This is useless and unacceptabl... [19:45:48] (03PS1) 10Cicalese: first commit [extensions/PluggableAuth] - 10https://gerrit.wikimedia.org/r/170132 [19:45:57] 3MediaWiki / 3General/Unknown: [Regression] MediaWiki should detect absent or outdated vendor - 10https://bugzilla.wikimedia.org/72777 (10Krinkle) [19:46:00] So many WMF channels :| [19:46:57] 3MediaWiki / 3General/Unknown: [Regression] MediaWiki should detect absent or outdated vendor - 10https://bugzilla.wikimedia.org/72777#c1 (10Sam Reed (reedy)) (In reply to Krinkle from comment #0) > Right now doing git-pull gives me an blank HTTP 500 response with no > information at all. git pull where of... [19:49:29] (03CR) 10Krinkle: "In fact, doing it on current master gives me a bad feeling already that something has gone wrong." [vendor] - 10https://gerrit.wikimedia.org/r/170106 (owner: 10Legoktm) [19:49:50] (03CR) 10Aaron Schulz: [C: 032] Add LinkBatch to Special:LinkSearch [core] - 10https://gerrit.wikimedia.org/r/163219 (owner: 10Umherirrender) [19:50:05] (03PS8) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [19:50:17] (03PS2) 10MarkTraceur: Move stupid DOM-bound events to OO EE syntax [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170131 [19:50:20] (03PS1) 10Cicalese: first commit [extensions/OpenIDConnect] - 10https://gerrit.wikimedia.org/r/170133 [19:50:55] (03CR) 10Aaron Schulz: [C: 032] LocalPageMoveJob: Use MovePage [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/169602 (owner: 10Legoktm) [19:51:26] (03CR) 10Reedy: "php composer.phar update --optimize-autoloader ??" [vendor] - 10https://gerrit.wikimedia.org/r/170106 (owner: 10Legoktm) [19:51:28] (03CR) 10Aaron Schulz: [C: 032] Use MovePageCheckPermissions hook if possible [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/169012 (owner: 10Legoktm) [19:51:30] (03CR) 1001tonythomas: [C: 031 V: 031] "Tested in local setup. Works as expected" [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170101 (https://bugzilla.wikimedia.org/72683) (owner: 1001tonythomas) [19:51:38] (03PS1) 10Cicalese: first commit [extensions/SimpleSAMLphp] - 10https://gerrit.wikimedia.org/r/170134 [19:52:17] (03PS1) 10Umherirrender: Update autoloader-suffix to match repro name [vendor] - 10https://gerrit.wikimedia.org/r/170135 [19:53:51] (03PS7) 10Phuedx: Register Hogan with mw.template [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/169931 (owner: 10Jdlrobson) [19:54:36] (03CR) 1001tonythomas: Rename br_user column to br_user_email and update comments [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170101 (https://bugzilla.wikimedia.org/72683) (owner: 1001tonythomas) [19:55:37] (03CR) 10Reedy: [C: 032] "WFM too" [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170101 (https://bugzilla.wikimedia.org/72683) (owner: 1001tonythomas) [19:56:05] (03Merged) 10jenkins-bot: Add LinkBatch to Special:LinkSearch [core] - 10https://gerrit.wikimedia.org/r/163219 (owner: 10Umherirrender) [19:56:07] (03Merged) 10jenkins-bot: LocalPageMoveJob: Use MovePage [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/169602 (owner: 10Legoktm) [19:56:10] (03Merged) 10jenkins-bot: Use MovePageCheckPermissions hook if possible [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/169012 (owner: 10Legoktm) [19:56:13] (03Merged) 10jenkins-bot: Rename br_user column to br_user_email and update comments [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170101 (https://bugzilla.wikimedia.org/72683) (owner: 1001tonythomas) [19:57:02] (03PS2) 10Reedy: Fix inconsistent returns in BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170112 (https://bugzilla.wikimedia.org/72684) (owner: 1001tonythomas) [19:57:27] 3MediaWiki extensions / 3BounceHandler: Rename br_user column - 10https://bugzilla.wikimedia.org/72683 (10Tony Thomas) 5PATC>3RESO/FIX [19:57:39] (03CR) 10Reedy: [C: 032] Fix inconsistent returns in BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170112 (https://bugzilla.wikimedia.org/72684) (owner: 1001tonythomas) [19:57:49] (03Merged) 10jenkins-bot: Fix inconsistent returns in BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/170112 (https://bugzilla.wikimedia.org/72684) (owner: 1001tonythomas) [20:00:16] 3MediaWiki extensions / 3BounceHandler: Inconsistent returns in BounceHandler - 10https://bugzilla.wikimedia.org/72684#c5 (10Tony Thomas) 5PATC>3RESO/FIX Thanks Reedy for reporting those! [20:00:24] (03CR) 10Aaron Schulz: [C: 032] Fully replace Title::moveTo() with MovePage (031 comment) [core] - 10https://gerrit.wikimedia.org/r/166175 (owner: 10Legoktm) [20:00:27] 3MediaWiki / 3API: API Login session time limit - 10https://bugzilla.wikimedia.org/26538#c2 (10Umherirrender) (In reply to Sam Reed (reedy) from comment #1) > Unless I'm missing something, there doesn't seem to be core functionality > for this yet... time limited token support was added with gerrit 156336 M... [20:01:32] (03PS3) 10Umherirrender: Remove LinkSearchPage::doQuery override [core] - 10https://gerrit.wikimedia.org/r/163206 [20:02:03] (03PS3) 10Reedy: Fixed DB timestamp range query [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/169760 (https://bugzilla.wikimedia.org/72686) (owner: 10Aaron Schulz) [20:02:07] (03CR) 10jenkins-bot: [V: 04-1] Fixed DB timestamp range query [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/169760 (https://bugzilla.wikimedia.org/72686) (owner: 10Aaron Schulz) [20:04:21] (03CR) 10Aaron Schulz: [C: 032] Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/170078 (owner: 10Umherirrender) [20:05:14] 3MediaWiki / 3General/Unknown: Unit tests in FormatJsonTest fail - 10https://bugzilla.wikimedia.org/72778 (10Tim Landscheidt) 3NEW p:3Unprio s:3normal a:3None The unit tests in mediawiki-core-regression-hhvm-master fail (cf. https://integration.wikimedia.org/ci/job/mediawiki-core-regression-hhvm-mast... [20:05:57] 3MediaWiki / 3API: API Login session time limit - 10https://bugzilla.wikimedia.org/26538#c3 (10Brad Jorsch) (In reply to Umherirrender from comment #2) > time limited token support was added with Gerrit change #156336 > Maybe with that feature it is possible to time limit the login token (or > allow time lim... [20:06:29] (03Merged) 10jenkins-bot: Fully replace Title::moveTo() with MovePage [core] - 10https://gerrit.wikimedia.org/r/166175 (owner: 10Legoktm) [20:07:03] (03Abandoned) 10Arlolra: This is probably not the fix but ... [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/168541 (owner: 10Arlolra) [20:07:42] (03CR) 10Legoktm: "Uhh, did you run composer update on this? The lock file should have been updated I think." [vendor] - 10https://gerrit.wikimedia.org/r/170128 (owner: 10Reedy) [20:08:40] legoktm: ba [20:08:40] h [20:09:15] (03PS1) 10Reedy: Followup bump to php 5.3.3 [vendor] - 10https://gerrit.wikimedia.org/r/170137 [20:09:34] (03CR) 10Legoktm: [C: 032] Followup bump to php 5.3.3 [vendor] - 10https://gerrit.wikimedia.org/r/170137 (owner: 10Reedy) [20:09:56] (03Merged) 10jenkins-bot: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/170078 (owner: 10Umherirrender) [20:11:22] (03CR) 10Phuedx: Register Hogan with mw.template (031 comment) [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/169931 (owner: 10Jdlrobson) [20:15:15] (03Merged) 10jenkins-bot: Followup bump to php 5.3.3 [vendor] - 10https://gerrit.wikimedia.org/r/170137 (owner: 10Reedy) [20:15:18] (03CR) 10Chad: [C: 032] Support specifying replica count per index type [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/170079 (owner: 10Manybubbles) [20:15:48] (03Merged) 10jenkins-bot: Support specifying replica count per index type [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/170079 (owner: 10Manybubbles) [20:15:57] 3Wikimedia / 3Extension setup: Review and deploy BounceHandler extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/69019 (10Sam Reed (reedy)) [20:15:59] 3Wikimedia / 3Extension setup: Plancake composer dependancy - 10https://bugzilla.wikimedia.org/72779 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3enhanc a:3None We don't "need" to use the Plancake dependency, but the fact it's not just regex probably suggests it might be better in the long run. We don't h... [20:16:33] (03PS2) 10Umherirrender: Update autoloader-suffix to match repro name [vendor] - 10https://gerrit.wikimedia.org/r/170135 [20:16:41] 3Wikimedia / 3Extension setup: Review and deploy BounceHandler extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/69019#c6 (10Sam Reed (reedy)) 72779 doesn't have to be a blocker to deployment... [20:16:55] (03PS1) 10Chad: Support specifying replica count per index type [extensions/CirrusSearch] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170142 [20:17:12] (03PS1) 10Chad: Support specifying replica count per index type [extensions/CirrusSearch] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170143 [20:17:30] (03CR) 10Chad: [C: 032] Support specifying replica count per index type [extensions/CirrusSearch] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170142 (owner: 10Chad) [20:17:35] (03CR) 10Chad: [C: 032] Support specifying replica count per index type [extensions/CirrusSearch] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170143 (owner: 10Chad) [20:17:41] (03PS1) 10Manybubbles: Cirrus updates for 1.23 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/170144 [20:17:43] Reedy: Or we could have a mediawiki/extensions/BounceHandler/vendor [20:17:46] (03Merged) 10jenkins-bot: Support specifying replica count per index type [extensions/CirrusSearch] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170142 (owner: 10Chad) [20:17:50] (03Merged) 10jenkins-bot: Support specifying replica count per index type [extensions/CirrusSearch] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170143 (owner: 10Chad) [20:19:04] (03CR) 10EBernhardson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168259 (owner: 10EBernhardson) [20:19:20] (03Abandoned) 10Manybubbles: Cirrus updates for 1.23 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/170144 (owner: 10Manybubbles) [20:19:42] 3MediaWiki / 3General/Unknown: Can't use underscore in page titles - 10https://bugzilla.wikimedia.org/72774#c2 (10teo8976) Good to know there's a workaround, but it's still a wrong approach. Also note that if you still want to maintain this approach (i.e. considering "_" and " " as the same character in ti... [20:20:21] (03PS1) 10Chad: Updating CirrusSearch to pull in I65193ae6 [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170146 [20:21:20] (03PS1) 10Manybubbles: Cirrus updates for 1.23 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/170147 [20:21:31] (03CR) 10Aaron Schulz: [C: 032] Updates after performance review [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/169653 (https://bugzilla.wikimedia.org/70585) (owner: 10Legoktm) [20:21:44] (03Merged) 10jenkins-bot: Updates after performance review [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/169653 (https://bugzilla.wikimedia.org/70585) (owner: 10Legoktm) [20:22:45] (03CR) 10Krinkle: "OK. That reduces the dirty diff to:" [vendor] - 10https://gerrit.wikimedia.org/r/170106 (owner: 10Legoktm) [20:22:47] (03Abandoned) 10Manybubbles: Cirrus updates for 1.23 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/170147 (owner: 10Manybubbles) [20:25:32] (03PS1) 10Chad: Updating CirrusSearch to pull in I65193ae6 [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170148 [20:26:08] (03CR) 10Reedy: "Mine shows no changes..." [vendor] - 10https://gerrit.wikimedia.org/r/170106 (owner: 10Legoktm) [20:27:41] 3Wikimedia / 3Extension setup: Plancake composer dependancy - 10https://bugzilla.wikimedia.org/72779#c1 (10Sam Reed (reedy)) It could go in mediawiki/vendor I guess... Considering vendor is primarly for WMF usage (but others can use it for ease) [20:28:16] (03PS2) 10Poke: Add Content-Length header for job queue requests [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/169965 (https://bugzilla.wikimedia.org/72274) [20:28:48] (03CR) 10Reedy: "https://github.com/wikimedia/mediawiki-vendor/blob/master/psr/log/Psr/Log/LoggerAwareTrait.php doesn't seeminly exist in master..." [vendor] - 10https://gerrit.wikimedia.org/r/170106 (owner: 10Legoktm) [20:33:43] 3MediaWiki extensions / 3Gadgets: Allow specifying what pages a gadget should run on in the definition - 10https://bugzilla.wikimedia.org/61007 (10Helder) 5UNCO>3NEW [20:34:42] 3MediaWiki / 3Uploading: Add chunked upload support to standard Special:Upload for files larger than POST limit - 10https://bugzilla.wikimedia.org/72768#c1 (10Bawolff (Brian Wolff)) I agree this would be nice. Many people using a user script currently to get around this limitation: https://commons.wikimedia... [20:34:56] (03CR) 10Reedy: "But if I use install, I get the same thing..." [vendor] - 10https://gerrit.wikimedia.org/r/170106 (owner: 10Legoktm) [20:36:00] (03PS1) 10Reedy: Update psr per issues Timo is having [vendor] - 10https://gerrit.wikimedia.org/r/170149 [20:36:20] (03CR) 10Reedy: "The obvious option is to commit them: https://gerrit.wikimedia.org/r/170149" [vendor] - 10https://gerrit.wikimedia.org/r/170106 (owner: 10Legoktm) [20:36:46] Krinkle: OH [20:36:47] I know [20:36:50] Reedy: that has a trait [20:37:00] legoktm: yup [20:37:06] hence my OH above ;) [20:37:14] ;P [20:37:26] I just googled PHP traits [20:37:27] "As of PHP 5.4.0, PHP implements a method of code reuse called Traits." [20:37:49] (03Abandoned) 10Reedy: Update psr per issues Timo is having [vendor] - 10https://gerrit.wikimedia.org/r/170149 (owner: 10Reedy) [20:38:44] (03CR) 10Reedy: "Except the traits being there for WMF usage isn't going to work due to PHP 5.3" [vendor] - 10https://gerrit.wikimedia.org/r/170106 (owner: 10Legoktm) [20:38:56] (03CR) 10Aude: Update psr per issues Timo is having (032 comments) [vendor] - 10https://gerrit.wikimedia.org/r/170149 (owner: 10Reedy) [20:39:23] Reedy: Hm.. did we exclude those files manually? [20:39:29] Not sure [20:39:31] How was vendor.git set up. [20:39:45] if we start manually removing files, that's a mess. [20:39:57] When are the details for the 2015 hackathon normally announced? [20:39:59] Well, presumably composer update should've fixed that? [20:40:06] Lcawte: European one? [20:40:21] https://github.com/wikimedia/mediawiki-vendor/commits/master [20:40:30] Krinkle: https://github.com/wikimedia/mediawiki-vendor/commit/bc9adb23dee28056cdc518b9f59d6742ca312303 [20:40:31] (03PS1) 10EBernhardson: Bug: Finish removing post_moderation_state [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170150 (https://bugzilla.wikimedia.org/72780) [20:40:33] https://gerrit.wikimedia.org/r/#/c/147658/ [20:40:34] Explictly removed [20:40:41] Which makes sense [20:40:43] Reedy: Let's assume yet since I'm not aware of what other ones there normally are (except the SF one which in January) [20:40:51] As it fucks up production [20:41:02] Lcawte: last i heard, wikimedia fr wants to host the hackathon [20:41:07] ^ [20:41:09] dates, no idea, but sometime in the spring [20:41:19] (03CR) 10jenkins-bot: [V: 04-1] Bug: Finish removing post_moderation_state [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170150 (https://bugzilla.wikimedia.org/72780) (owner: 10EBernhardson) [20:41:37] Announcement in Spring? :( [20:41:38] Krinkle: I guess part of it is, you should either just use the vendor repo. Or you run composer yourself [20:41:44] (03CR) 10Krinkle: "fixme: This is a hotpatch that makes the vendor no longer match composer's install. So whenever someone updates the composer install, thes" [core/vendor] - 10https://gerrit.wikimedia.org/r/147658 (owner: 10BryanDavis) [20:41:55] Lcawte: rfarrand knows details [20:42:00] Reedy: Well, yes, but the vendor repo needs maintaining and someone to review the commits with confidence [20:42:02] psr/log should have a minimum PHP version requirement. [20:42:04] and not have random files missing [20:42:10] anyway, so far it's only these two, so that's good. [20:42:14] rfarrand: Planned date of the European hackathon [20:42:16] at least it's known now [20:42:33] Lcawte: no, hackathon in spring [20:42:59] we have not signed a contract so we do not have confirmed dates [20:43:13] we will announce on wikitech-l as soon as we know [20:43:13] what rfarrand says [20:43:36] and if wikimedia fr is budgeting for it then maybe they want to know the results of the FDC (funding) application [20:44:00] (03CR) 10Reedy: "I guess the fixme is docs, as we can't have PHP 5.4 stuff in the repo." [core/vendor] - 10https://gerrit.wikimedia.org/r/147658 (owner: 10BryanDavis) [20:44:01] aude: It's funded by the WMF [20:44:11] ok :) [20:44:48] System was changed a bit to not get FDC madness for the big European hackathon, details somewhere on some wiki I guess ;-) [20:45:40] agree, that seems better [20:45:48] (03CR) 10Reedy: [C: 04-1] "Needs rebasing" [vendor] - 10https://gerrit.wikimedia.org/r/170106 (owner: 10Legoktm) [20:45:50] legoktm: trololol [20:46:59] https://github.com/php-fig/log/issues/25 [20:47:02] bah [20:47:03] (03PS1) 10Paladox: Updating file [extensions/CollapsibleVector] (REL1_24) - 10https://gerrit.wikimedia.org/r/170151 [20:47:36] (03CR) 10Paladox: [C: 032 V: 032] Updating file [extensions/CollapsibleVector] (REL1_24) - 10https://gerrit.wikimedia.org/r/170151 (owner: 10Paladox) [20:48:02] (03PS1) 10EBernhardson: Bug: Wrong i18n message for some moderation actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170154 (https://bugzilla.wikimedia.org/72780) [20:48:21] legoktm: He replied [20:48:34] that was fast :P [20:48:47] (03CR) 10jenkins-bot: [V: 04-1] Bug: Wrong i18n message for some moderation actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170154 (https://bugzilla.wikimedia.org/72780) (owner: 10EBernhardson) [20:48:49] don't use traits! [20:49:05] (03PS8) 10EBernhardson: Switch to using template mechanism provided by core. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168317 (owner: 10Jdlrobson) [20:49:52] (03CR) 10jenkins-bot: [V: 04-1] Switch to using template mechanism provided by core. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168317 (owner: 10Jdlrobson) [20:49:57] (03PS2) 10Legoktm: Add cssjanus/cssjanus 1.1.0 [vendor] - 10https://gerrit.wikimedia.org/r/170106 [20:50:23] (03PS2) 10Ori.livneh: Remove ProfileMwprof [core] - 10https://gerrit.wikimedia.org/r/170118 (owner: 10Chad) [20:50:49] (03CR) 10Ori.livneh: [C: 031] "Fine by me, if this gets in the way of refactoring things. I'd like to resurrect it eventually, but I'll know where to find it." [core] - 10https://gerrit.wikimedia.org/r/170118 (owner: 10Chad) [20:52:15] (03CR) 10Reedy: "legoktm just filed https://github.com/php-fig/log/issues/25 upstream..." [core/vendor] - 10https://gerrit.wikimedia.org/r/147658 (owner: 10BryanDavis) [20:52:30] legoktm: You'd sorta think the answer is just to make a 5.3 branch or something [20:52:43] maybe [20:52:49] why would lint.php segfault? [20:53:01] shouldn't it throw an error if it comes across invalid syntax? [20:53:10] https://bugs.php.net/bug.php?id=53748 [20:53:35] Ah [20:53:39] legoktm: We need PHP 5.3.17 [20:53:43] lol [20:54:39] (03CR) 10Reedy: "[20:52:30] legoktm: You'd sorta think the answer is just to make a 5.3 branch or something" [core/vendor] - 10https://gerrit.wikimedia.org/r/147658 (owner: 10BryanDavis) [20:55:16] Hmm, so my exams are at either end of June, Hackathon should just be dependant on cash this year :) [20:55:41] (03PS3) 10Umherirrender: Add Content-Length header for job queue requests [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/169965 (https://bugzilla.wikimedia.org/72274) (owner: 10Poke) [20:55:47] (03CR) 10Umherirrender: [C: 032] Add Content-Length header for job queue requests [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/169965 (https://bugzilla.wikimedia.org/72274) (owner: 10Poke) [20:56:10] Reedy: even if we had that patch, lint.php would still fail because traits are invalid syntax... [20:56:18] lol [20:56:23] but it wouldn't segfault at least [20:57:29] (03PS6) 10Krinkle: Remove jQuery Migrate and $wgIncludejQueryMigrate [core] - 10https://gerrit.wikimedia.org/r/137168 (owner: 10Jforrester) [20:58:23] (03CR) 10Krinkle: [C: 032] mediawiki.api: Transform arrays with join('|') in query parameters [core] - 10https://gerrit.wikimedia.org/r/164886 (https://bugzilla.wikimedia.org/64570) (owner: 10saper) [20:59:09] (03CR) 10jenkins-bot: [V: 04-1] Remove jQuery Migrate and $wgIncludejQueryMigrate [core] - 10https://gerrit.wikimedia.org/r/137168 (owner: 10Jforrester) [20:59:12] legoktm: Maybe we should just starting adding features like this to MW [20:59:24] And just claim people shouldn't use them if they don't have a new enough PHP version [20:59:29] haha [21:00:07] (03CR) 10Reedy: [C: 031] Add cssjanus/cssjanus 1.1.0 [vendor] - 10https://gerrit.wikimedia.org/r/170106 (owner: 10Legoktm) [21:00:25] (03CR) 10Umherirrender: [C: 031] API: Make `usernames` a local variable [core] - 10https://gerrit.wikimedia.org/r/168739 (owner: 10Poke) [21:02:41] (03CR) 10jenkins-bot: [V: 04-1] Add Content-Length header for job queue requests [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/169965 (https://bugzilla.wikimedia.org/72274) (owner: 10Poke) [21:03:57] Reedy: Hm.. when I check out that cssjanus commit and re-run install locally it puts cssjanus higher up in the file [21:04:15] haha [21:04:42] >.< [21:04:51] (03PS8) 10EBernhardson: Register Handlebars with core [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/168434 (owner: 10Jdlrobson) [21:05:13] (03PS3) 10Krinkle: Add cssjanus/cssjanus 1.1.0 [vendor] - 10https://gerrit.wikimedia.org/r/170106 (owner: 10Legoktm) [21:05:23] (03CR) 10EBernhardson: "minor whitespace inconsistency" (031 comment) [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/168434 (owner: 10Jdlrobson) [21:05:29] Seems composer is not deterministic across platforms in being a-z or order-as-specified [21:05:37] (03CR) 10EBernhardson: [C: 032] "PS8: added a couple tab characters" [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/168434 (owner: 10Jdlrobson) [21:06:17] (03PS1) 10Ori.livneh: Update NavigationTiming for SCID 10374055 [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/170158 [21:06:34] Isn't legoktm osx too? [21:06:38] I am [21:06:41] (03CR) 10Krinkle: [C: 031] "Re-running install got me a dirty diff in the order of the keys in the json file. Looks like it alphabetized it. Assuming you didn't manua" [vendor] - 10https://gerrit.wikimedia.org/r/170106 (owner: 10Legoktm) [21:06:43] Should I be worried when jenkins verifies -1 beacuse of a failing vendor-integration? [21:06:51] (03CR) 10Ori.livneh: [C: 032] "trivial" [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/170158 (owner: 10Ori.livneh) [21:07:09] poke`: yes.... [21:07:16] poke`: Yes, vendor-integration is the new name of our php unit test. [21:07:20] It should be renamed to phpunit [21:07:28] 21:03:08 1) MediaWikiVersionFetcherTest::testReturnsResult [21:07:28] 21:03:08 RuntimeException: Could not extract the MediaWiki version from DefaultSettings.php [21:07:41] (there is no longer a mediawiki-core-phpunit on the Jenkins pipeline) [21:07:56] https://gerrit.wikimedia.org/r/#/c/170058/ [21:07:57] nice [21:08:04] (03CR) 10Umherirrender: [C: 031] "Timeout in mediawiki-vendor-integration seems unrelated to this change set." [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/169965 (https://bugzilla.wikimedia.org/72274) (owner: 10Poke) [21:08:07] just bypassed jenkins [21:08:16] (03CR) 10Umherirrender: [C: 032] "Resubmit" [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/169965 (https://bugzilla.wikimedia.org/72274) (owner: 10Poke) [21:08:25] (03CR) 10Legoktm: "FIXME: This introduced a failing test, jenkins should not have been overriden." [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/170058 (owner: 10MarkAHershberger) [21:08:37] I guess Umherirrender just answered my concern xD [21:09:12] * legoktm grumbles [21:09:18] I wonder what that test is even for. [21:09:25] (03Merged) 10jenkins-bot: mediawiki.api: Transform arrays with join('|') in query parameters [core] - 10https://gerrit.wikimedia.org/r/164886 (https://bugzilla.wikimedia.org/64570) (owner: 10saper) [21:09:30] (03Merged) 10jenkins-bot: Register Handlebars with core [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/168434 (owner: 10Jdlrobson) [21:09:32] (03Merged) 10jenkins-bot: Update NavigationTiming for SCID 10374055 [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/170158 (owner: 10Ori.livneh) [21:10:27] 3MediaWiki extensions / 3GlobalUserPage: Performance review of GlobalUserPage extension - 10https://bugzilla.wikimedia.org/70585#c5 (10Aaron Schulz) Also displayGlobalPage() checks for name validity twice and MapCacheLRU overhead probably isn't worth the avoiding the first the checks of canBeGlobal() sometim... [21:10:37] (03CR) 10EBernhardson: "recheck" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168317 (owner: 10Jdlrobson) [21:14:16] preg_match( "/wgVersion = '([0-9a-zA-Z\.]+)';/", $defaultSettings, $matches ); [21:14:28] 3MediaWiki / 3JavaScript: mediawiki.api: Serialize { foo: [1,2] } as "foo=1|2" instead of "foo[]=1&foo[]=2" - 10https://bugzilla.wikimedia.org/64570 (10Bartosz Dziewoński) 5PATC>3RESO/FIX a:3Marcin Cieślak [21:15:04] What's the point of that? [21:15:04] (03CR) 10jenkins-bot: [V: 04-1] Add Content-Length header for job queue requests [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/169965 (https://bugzilla.wikimedia.org/72274) (owner: 10Poke) [21:15:08] (03PS1) 10Ori.livneh: Update NavigationTiming for SCID 10374055 [extensions/NavigationTiming] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170163 [21:15:10] I don't know. [21:15:13] (03CR) 10Ori.livneh: [C: 032] Update NavigationTiming for SCID 10374055 [extensions/NavigationTiming] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170163 (owner: 10Ori.livneh) [21:15:21] (03PS1) 10Ori.livneh: Update NavigationTiming for SCID 10374055 [extensions/NavigationTiming] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170164 [21:15:26] (03CR) 10Ori.livneh: [C: 032] Update NavigationTiming for SCID 10374055 [extensions/NavigationTiming] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170164 (owner: 10Ori.livneh) [21:15:30] (03Merged) 10jenkins-bot: Update NavigationTiming for SCID 10374055 [extensions/NavigationTiming] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170163 (owner: 10Ori.livneh) [21:15:35] (03PS7) 10Krinkle: Remove jQuery Migrate and $wgIncludejQueryMigrate [core] - 10https://gerrit.wikimedia.org/r/137168 (owner: 10Jforrester) [21:15:42] (03Merged) 10jenkins-bot: Update NavigationTiming for SCID 10374055 [extensions/NavigationTiming] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170164 (owner: 10Ori.livneh) [21:15:48] (03CR) 10Krinkle: "Fixed php syntax error" [core] - 10https://gerrit.wikimedia.org/r/137168 (owner: 10Jforrester) [21:16:14] (03PS1) 10Ori.livneh: Update NavigationTiming for cherry-picks [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170165 [21:16:24] (03PS1) 10Ori.livneh: Update NavigationTiming for cherry-picks [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170166 [21:16:37] (03CR) 10Ori.livneh: [C: 032] Update NavigationTiming for cherry-picks [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170165 (owner: 10Ori.livneh) [21:16:46] (03CR) 10Ori.livneh: [C: 032] Update NavigationTiming for cherry-picks [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170166 (owner: 10Ori.livneh) [21:16:58] (03CR) 10Umherirrender: "Maybe delete the script file jquery.migrate.js? Or there are problems with caches to keep it 30 days?" [core] - 10https://gerrit.wikimedia.org/r/137168 (owner: 10Jforrester) [21:17:25] (03CR) 10Krinkle: [C: 04-1] "Nope, that should be removed." [core] - 10https://gerrit.wikimedia.org/r/137168 (owner: 10Jforrester) [21:19:00] (03CR) 10Umherirrender: "Needs someone from the vendor team to explain the failing test:" [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/169965 (https://bugzilla.wikimedia.org/72274) (owner: 10Poke) [21:20:15] Is there a way to link to other changes in Gerrit comments? [21:20:19] (03CR) 10Legoktm: "The failing test is due to https://gerrit.wikimedia.org/r/#/c/170058/ which bypassed jenkins and didn't even wait for the results of the u" [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/169965 (https://bugzilla.wikimedia.org/72274) (owner: 10Poke) [21:20:36] (03CR) 10EBernhardson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168317 (owner: 10Jdlrobson) [21:20:44] poke`: either url or use copy the Change-Id value [21:20:53] I'm apparently to slow anyway.. xD Thanks ^^ [21:21:13] 3MediaWiki / 3Search: Wikimedia mobile view search not functional in stable Chrome (v38) - 10https://bugzilla.wikimedia.org/72788 (10scoppino.giuseppe) 3UNCO p:3Unprio s:3normal a:3None 1) Go to m.mediawiki.org or select "Mobile View" on mediawiki.org 2) Attempt to select the search bar to begin typi... [21:23:14] (03Merged) 10jenkins-bot: Update NavigationTiming for cherry-picks [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170165 (owner: 10Ori.livneh) [21:23:16] (03CR) 10Umherirrender: "Version number must match /([0-9a-zA-Z\.]+)/ in MediaWikiVersionFetcher. Adding a - seems the only way, because the used version number is" [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/170058 (owner: 10MarkAHershberger) [21:23:18] (03PS9) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [21:23:33] legoktm: So I guess I should wait now until 170058 is fixed, and then rebase my change on top of that to fix it? [21:23:36] (03PS3) 10MarkTraceur: Move stupid DOM-bound events to OO EE syntax [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170131 [21:23:38] yup. [21:23:42] Alright :) [21:23:43] (03Merged) 10jenkins-bot: Update NavigationTiming for cherry-picks [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170166 (owner: 10Ori.livneh) [21:23:57] 3MediaWiki / 3Search: Wikimedia mobile view search not functional in stable Chrome (v38) - 10https://bugzilla.wikimedia.org/72788#c1 (10scoppino.giuseppe) A recent change must have caused this because I used the mobile view for a search on Chrome within the past 2 weeks and it worked fine then. [21:24:58] (03PS7) 10MarkTraceur: Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 [21:25:03] (03PS10) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [21:25:08] (03PS4) 10MarkTraceur: Move stupid DOM-bound events to OO EE syntax [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170131 [21:27:53] (03PS11) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [21:27:58] (03PS5) 10MarkTraceur: Move stupid DOM-bound events to OO EE syntax [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170131 [21:34:00] (03PS1) 10MarkTraceur: Remove reservedIndex [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170170 [21:36:29] 3MediaWiki extensions / 3OAuth: Users cannot log in via OAuth unless they have global accounts - 10https://bugzilla.wikimedia.org/72791 (10Sage Ross) 3NEW p:3Unprio s:3normal a:3None If a user creates a new account and then attempts to use an OAuth app, they will get an error because they don't yet h... [21:40:42] (03CR) 10Hashar: "Can a bug be filled for it please? We might be able to apply the PHP patch in our Debian package and thus remove this hack :-]" [core/vendor] - 10https://gerrit.wikimedia.org/r/147658 (owner: 10BryanDavis) [21:40:45] (03CR) 10EBernhardson: [C: 032] Switch to using template mechanism provided by core. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168317 (owner: 10Jdlrobson) [21:41:30] (03Merged) 10jenkins-bot: Switch to using template mechanism provided by core. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168317 (owner: 10Jdlrobson) [21:42:01] (03CR) 10Spage: [C: 032] "Oversighter no longer sees in topic action menu with this patch." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170154 (https://bugzilla.wikimedia.org/72780) (owner: 10EBernhardson) [21:44:11] 3MediaWiki / 3General/Unknown: [Regression] MediaWiki should detect absent or outdated vendor - 10https://bugzilla.wikimedia.org/72777#c2 (10Bryan Davis) The place where we do the php version check is before the autoloader, so that won't work to fix the problem. Maybe we can put a check in the includes/debug... [21:44:34] >>1+1 [21:44:34] Helder: (number) 2 [21:47:01] (03PS7) 10BryanDavis: [WIP] Enable profiling via xhprof [core] - 10https://gerrit.wikimedia.org/r/168930 [21:47:03] (03CR) 10Poke: "Note that prior to 1.22, the usual way to denotate RC version numbers was without a dash, e.g. `1.22.0rc0`. This can be seen in 5a75904 an" [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/170058 (owner: 10MarkAHershberger) [21:47:25] >>0.1+0.2 [21:47:25] Krenair: (number) 0.30000000000000004 [21:48:05] of course it is [21:48:14] <^d> ecmabot-wm is the weirdest bot. [21:48:16] o.O [21:48:42] >>0.1+0.2-0000000000000004 [21:48:42] Reedy: (number) -3.7 [21:48:50] >>0.1+0.2-0.00000000000000004 [21:48:50] Reedy: (number) 0.3 [21:48:53] success [21:48:57] (03CR) 10BryanDavis: "Or we can wait about a month and then bump the minimum php version to 5.4 and call it all good." [core/vendor] - 10https://gerrit.wikimedia.org/r/147658 (owner: 10BryanDavis) [21:49:54] Reedy: Blame ieee floating point [21:51:00] 0.1 is an irrational number in ieee -- http://grouper.ieee.org/groups/754/faq.html#binary-decimal [21:51:14] 3Wikimedia / 3General/Unknown: php5-common-5.3.10-1ubuntu3.15+wmf1 is incompatible with Trusty's php5-common - 10https://bugzilla.wikimedia.org/72793 (10Tim Landscheidt) 3NEW p:3Unprio s:3blocke a:3None Trusty's php5-common provides the virtual package phpapi-20121212 which is required by many depend... [21:54:29] desktop calculators are more accurate that computers, it seems :P [21:57:33] (03PS3) 10EBernhardson: Remove Handlebars Mantle dependency [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/170099 (owner: 10Jdlrobson) [21:57:51] (03CR) 10Catrope: [C: 031] "Yay OO events! Suggestions for more fanciness you can optionally use inline." (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170131 (owner: 10MarkTraceur) [21:58:07] (03CR) 10jenkins-bot: [V: 04-1] Remove Handlebars Mantle dependency [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/170099 (owner: 10Jdlrobson) [22:01:10] (03CR) 10Spage: [C: 04-1] "I no longer see if I hide the first post." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170150 (https://bugzilla.wikimedia.org/72780) (owner: 10EBernhardson) [22:01:15] (03CR) 10EBernhardson: [C: 04-1] Remove Handlebars Mantle dependency (033 comments) [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/170099 (owner: 10Jdlrobson) [22:01:53] (03PS2) 10Spage: Bug: Finish removing post_moderation_state msg [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170150 (https://bugzilla.wikimedia.org/72780) (owner: 10EBernhardson) [22:02:08] (03CR) 10Spage: [C: 032] "Hope I got the commit msg right." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170150 (https://bugzilla.wikimedia.org/72780) (owner: 10EBernhardson) [22:02:42] (03CR) 10jenkins-bot: [V: 04-1] Bug: Finish removing post_moderation_state msg [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170150 (https://bugzilla.wikimedia.org/72780) (owner: 10EBernhardson) [22:13:51] (03PS1) 10Alex Monk: Expose getLastModifiedText function [extensions/LastModified] - 10https://gerrit.wikimedia.org/r/170184 (https://bugzilla.wikimedia.org/52403) [22:16:12] 3MediaWiki extensions / 3OAuth: Users cannot log in via OAuth unless they have global accounts - 10https://bugzilla.wikimedia.org/72791#c1 (10Brion Vibber) Er, shouldn't a new user creation automatically create a global account already? [22:18:18] (03PS1) 10Hashar: Revert "1.24.0-rc.0" [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/170185 [22:18:59] (03CR) 10Hashar: "Revert proposed with https://gerrit.wikimedia.org/r/#/c/170185/ . Please rebase your change on top of it and the tests should pass." [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/169965 (https://bugzilla.wikimedia.org/72274) (owner: 10Poke) [22:19:27] 3Wikimedia / 3Extension setup: Plancake composer dependancy - 10https://bugzilla.wikimedia.org/72779#c2 (10Bryan Davis) mediawiki/vendor is the right place to add composer managed dependencies that are going to be used in WMF production. I wrote an RFC for it and everything. :) (03PS1) 10Chad: Remove collateOnly() from ProfilerStandard and subclasses [core] - 10https://gerrit.wikimedia.org/r/170186 [22:20:21] (03CR) 10Hashar: "See comments on https://gerrit.wikimedia.org/r/#/c/170058/" [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/170185 (owner: 10Hashar) [22:20:47] (03PS3) 10BryanDavis: Remove ProfileMwprof [core] - 10https://gerrit.wikimedia.org/r/170118 (owner: 10Chad) [22:21:38] (03Abandoned) 10Alex Monk: Expose getLastModifiedText function [extensions/LastModified] - 10https://gerrit.wikimedia.org/r/170184 (https://bugzilla.wikimedia.org/52403) (owner: 10Alex Monk) [22:22:11] 3MediaWiki extensions / 3OAuth: Users cannot log in via OAuth unless they have global accounts - 10https://bugzilla.wikimedia.org/72791#c2 (10Sage Ross) I would have thought so, but as of the last time I tried a few weeks ago, I ran into the E008 error with the new testing account I'd just created, and someo... [22:23:03] (03CR) 10BryanDavis: [C: 032] "I've tried to incorporate ideas from this profiler in the data that I'm working on generating from xhprof (03PS4) 10Hashar: Add Content-Length header for job queue requests [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/169965 (https://bugzilla.wikimedia.org/72274) (owner: 10Poke) [22:23:59] (03CR) 10MarkAHershberger: "We switched to semantic versioning (http://semver.org/) during the RC period of 1.22 at the request of WikiApiary and that means using the" [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/170058 (owner: 10MarkAHershberger) [22:24:32] (03CR) 10Hashar: "Rebased on top of "Revert "1.24.0-rc.0"" https://gerrit.wikimedia.org/r/#/c/170185/" [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/169965 (https://bugzilla.wikimedia.org/72274) (owner: 10Poke) [22:25:18] "Please rebase your change on top of it..." - *starts looking up how to rebase on top of proposed changes* - (5 minutes later) "Uploaded patch set" - Meh :( [22:25:31] (03CR) 10Jdlrobson: "Note Flow no longer use this code so this falls to the mobile team to review :)" [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/169926 (owner: 10Jdlrobson) [22:26:29] poke`: Usually easiest to just cherry pick ontop and resubmit [22:26:49] (03CR) 10Legoktm: [C: 032] Revert "1.24.0-rc.0" [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/170185 (owner: 10Hashar) [22:27:36] Reedy: I know but I forgot how to fetch a change (that isn't mine) ^^ [22:27:51] git review -d #### [22:27:52] But apparently I'm too slow for anything anyway xD [22:27:55] :P [22:28:49] (03CR) 10Hashar: "I would self merge it because the original commit broke test and that is what we are usually doing. But I don't want to disrupt MarkAHers" [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/170185 (owner: 10Hashar) [22:29:08] (03CR) 10Hashar: "+1 legoktm thanks :-]" [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/170185 (owner: 10Hashar) [22:29:32] (03Merged) 10jenkins-bot: Remove ProfileMwprof [core] - 10https://gerrit.wikimedia.org/r/170118 (owner: 10Chad) [22:30:18] legoktm: thanks for the REL1_24 revert +2 :-} [22:30:20] (03CR) 10Chad: "Actually, now that I think about it we might just remove those code paths entirely since nothing is using them." [core] - 10https://gerrit.wikimedia.org/r/170186 (owner: 10Chad) [22:30:32] hexmode: mglaser: you will want to repurpose a new change that bumps REL1_24 version to rc0 [22:30:42] hashar: Thanks for asking me to rebase and then doing it yourself before I could possibly respond xD [22:31:00] * Reedy high fives hashar [22:31:23] hashar: np [22:31:32] hexmode: mglaser: https://gerrit.wikimedia.org/r/#/c/170058/2 "1.24.0-rc.0" broke some test :-D [22:31:48] poke`: yeah I thought it would be faster for me to just do it and then post the information on how to do it [22:31:56] poke`: the trick is using git cherry-pick [22:32:34] I appreciate posting the instructions though because I would probably done it differently (I'm not too used to git-review yet) [22:32:55] (I also keep doing dry-runs with it to make sure that I don't break stuff..) [22:33:22] poke`: well you can get rid of git-review entirely. Most just push to Gerrit using something like: git push HEAD:refs/for/master [22:33:34] Yeah, I know [22:33:40] (03Merged) 10jenkins-bot: Revert "1.24.0-rc.0" [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/170185 (owner: 10Hashar) [22:33:46] it's refs/production/master nowadays though [22:33:48] (03Merged) 10jenkins-bot: Add Content-Length header for job queue requests [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/169965 (https://bugzilla.wikimedia.org/72274) (owner: 10Poke) [22:33:54] ^ whoo! [22:34:35] (03PS2) 10Chad: Remove collateOnly() from ProfilerStandard and subclasses [core] - 10https://gerrit.wikimedia.org/r/170186 [22:34:41] would need to sync with hexmode and mglaser though since the rc0 would now contain your patch :D [22:34:58] 3Wikimedia / 3Bugzilla: Can't register to phabricator.wikimedia.org - 10https://bugzilla.wikimedia.org/72776#c1 (10Andre Klapper) There is also a link in the banner on top of Bugzilla which links to https://www.mediawiki.org/wiki/Phabricator/Help#Creating_your_account - did you follow those instructions by u... [22:35:26] (03CR) 10Chad: [C: 032] Import.php: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/155872 (owner: 10Legoktm) [22:35:41] btw. since we are apparently now using semantic versioning, I guess the version number test should be patched for that, right? Is anyone already working on that? [22:35:56] 3MediaWiki / 3Unit tests: Unit tests in FormatJsonTest fail - 10https://bugzilla.wikimedia.org/72778 (10Andre Klapper) p:5Unprio>3Normal [22:36:47] (03CR) 10Chad: [C: 031] "lgtm if i18n passes review." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/169807 (owner: 10Anomie) [22:36:58] 3MediaWiki / 3General/Unknown: [Regression] MediaWiki should detect absent or outdated vendor - 10https://bugzilla.wikimedia.org/72777 (10Bryan Davis) p:5Unprio>3High a:3Bryan Davis [22:42:03] (03Merged) 10jenkins-bot: Import.php: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/155872 (owner: 10Legoktm) [22:44:56] 3Wikimedia / 3General/Unknown: Create a proposal review system for IEG and other applications - 10https://bugzilla.wikimedia.org/62170#c6 (10Bryan Davis) 5NEW>3RESO/FIX Live in production for a couple of weeks. [22:46:29] (03PS1) 10Paladox: Update Metrolook [skins/Metrolook] (REL1_22) - 10https://gerrit.wikimedia.org/r/170238 [22:46:57] 3Wikimedia / 3General/Unknown: Create a proposal review system for IEG and other applications - 10https://bugzilla.wikimedia.org/62170#c7 (10Quim Gil) You Unsung Hero. [22:47:10] (03PS3) 10Chad: Remove collateOnly() from ProfilerStandard and subclasses [core] - 10https://gerrit.wikimedia.org/r/170186 [22:47:12] (03PS1) 10Chad: Remove per-template profiling [core] - 10https://gerrit.wikimedia.org/r/170239 [22:47:49] submitting patches is the best way to appear busy.. my phone doesn't stop blinking.. [22:49:26] 3MediaWiki / 3JobQueue: Job queue not running (HTTP 411) due to missing Content-Length: header - 10https://bugzilla.wikimedia.org/72274#c17 (10Patrick Westerhoff) 5PATC>3RESO/FIX Backported to 1.23 and 1.24. [22:49:50] (03CR) 10Paladox: [C: 032 V: 032] Update Metrolook [skins/Metrolook] (REL1_22) - 10https://gerrit.wikimedia.org/r/170238 (owner: 10Paladox) [22:50:50] (03CR) 10Greg Grossmeier: "Mark: then please update the other bits needed instead of breaking tests." [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/170058 (owner: 10MarkAHershberger) [22:51:01] (03PS1) 10Jack Phoenix: Version 1.4.0 -- converted to JSON i18n, PHP i18n dropped [extensions/WhosOnline] - 10https://gerrit.wikimedia.org/r/170241 [22:51:19] (03CR) 10BryanDavis: [C: 032] Remove collateOnly() from ProfilerStandard and subclasses [core] - 10https://gerrit.wikimedia.org/r/170186 (owner: 10Chad) [22:51:36] (03CR) 10Jack Phoenix: [C: 032 V: 032] Version 1.4.0 -- converted to JSON i18n, PHP i18n dropped [extensions/WhosOnline] - 10https://gerrit.wikimedia.org/r/170241 (owner: 10Jack Phoenix) [22:51:38] (03CR) 10BryanDavis: [C: 031] Remove per-template profiling [core] - 10https://gerrit.wikimedia.org/r/170239 (owner: 10Chad) [22:54:15] (03PS2) 10EBernhardson: Bug: Wrong i18n message for some moderation actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170154 (https://bugzilla.wikimedia.org/72780) [22:55:03] (03CR) 10jenkins-bot: [V: 04-1] Bug: Wrong i18n message for some moderation actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170154 (https://bugzilla.wikimedia.org/72780) (owner: 10EBernhardson) [22:55:27] (03PS1) 10Paladox: Update Metrolook [skins/Metrolook] (REL1_23) - 10https://gerrit.wikimedia.org/r/170242 [22:57:23] (03Merged) 10jenkins-bot: Remove collateOnly() from ProfilerStandard and subclasses [core] - 10https://gerrit.wikimedia.org/r/170186 (owner: 10Chad) [22:57:40] (03CR) 10Paladox: [C: 032 V: 032] Update Metrolook [skins/Metrolook] (REL1_23) - 10https://gerrit.wikimedia.org/r/170242 (owner: 10Paladox) [22:59:04] (03CR) 10EBernhardson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/170154 (https://bugzilla.wikimedia.org/72780) (owner: 10EBernhardson) [22:59:41] (03CR) 10Chad: [C: 032] Updating CirrusSearch to pull in I65193ae6 [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170146 (owner: 10Chad) [22:59:45] (03CR) 10Chad: [C: 032] Updating CirrusSearch to pull in I65193ae6 [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170148 (owner: 10Chad) [23:02:22] (03PS1) 10Paladox: Update Metrolook [skins/Metrolook] (REL1_24) - 10https://gerrit.wikimedia.org/r/170243 [23:04:11] (03CR) 10Paladox: [C: 032 V: 032] Update Metrolook [skins/Metrolook] (REL1_24) - 10https://gerrit.wikimedia.org/r/170243 (owner: 10Paladox) [23:06:08] (03Merged) 10jenkins-bot: Updating CirrusSearch to pull in I65193ae6 [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/170146 (owner: 10Chad) [23:06:24] (03Merged) 10jenkins-bot: Updating CirrusSearch to pull in I65193ae6 [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170148 (owner: 10Chad) [23:10:25] (03PS1) 10Paladox: Update Metrolook [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/170247 [23:11:36] (03PS2) 10Paladox: Update Metrolook [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/170247 [23:11:42] 3Wikimedia / 3General/Unknown: Create a proposal review system for IEG and other applications - 10https://bugzilla.wikimedia.org/62170#c8 (10Bryan Davis) (In reply to Quim Gil from comment #7) > You Unsung Hero. Don't tell anybody I did another one of these "could you just make something that ..." apps plea... [23:12:25] (03CR) 10Paladox: [C: 032 V: 032] Update Metrolook [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/170247 (owner: 10Paladox) [23:15:00] (03CR) 10Daniel Friesen: "These files do not need +x, they are not intended to be executed." [core] - 10https://gerrit.wikimedia.org/r/170120 (owner: 10Southparkfan) [23:15:41] 3Wikimedia / 3Language setup: Create Wikipedia Maithili - 10https://bugzilla.wikimedia.org/72346#c21 (10Daniel Zahn) the DNS entry mai.wikipedia.org exists now since today. wiki installation can go ahead. [23:15:56] 3MediaWiki extensions / 3OAuth: Users cannot log in via OAuth unless they have global accounts - 10https://bugzilla.wikimedia.org/72791#c3 (10Sage Ross) Just tried it again. You can replicate this error like so: 1. Open a private tab 2. Visit wizard.wikiedu.org and click "Login with Wikipedia" 3. You be sen... [23:17:52] (03CR) 10Aaron Schulz: [C: 032] API: Fix simplified continuation module skipping [core] - 10https://gerrit.wikimedia.org/r/170095 (https://bugzilla.wikimedia.org/72764) (owner: 10Anomie) [23:17:57] 3MediaWiki / 3Unit tests: Unit tests in FormatJsonTest fail - 10https://bugzilla.wikimedia.org/72778#c1 (10Bryan Davis) HHVM has a lenient json parser which allows trailing commas. The failing tests seem to be ones where the test expects json_decode() to fail with JSON_ERROR_SYNTAX and then need to have extr... [23:23:49] (03Merged) 10jenkins-bot: API: Fix simplified continuation module skipping [core] - 10https://gerrit.wikimedia.org/r/170095 (https://bugzilla.wikimedia.org/72764) (owner: 10Anomie) [23:40:26] 3MediaWiki / 3Unit tests: Unit tests in FormatJsonTest fail - 10https://bugzilla.wikimedia.org/72778#c2 (10Bryan Davis) Block that ignores trailing commas: $ /usr/bin/php5 -r 'var... [23:40:59] (03PS1) 10BryanDavis: hhvm: fix FormatJsonTest::testParseTryFixing for lenient json parser [core] - 10https://gerrit.wikimedia.org/r/170251 (https://bugzilla.wikimedia.org/72778) [23:42:12] 3Wikimedia / 3SSL related: Disable SSL 3.0 on Wikimedia sites to mitigate POODLE attack (CVE-2014-3566) - 10https://bugzilla.wikimedia.org/72072#c9 (10chmarkine) (In reply to Daniel Zahn from comment #8) > Chmarkine, you had that nice table, what does your data say now, anything > left? Thanks for fixing th... [23:44:41] 3Wikimedia / 3SSL related: Disable SSL 3.0 on Wikimedia sites to mitigate POODLE attack (CVE-2014-3566) - 10https://bugzilla.wikimedia.org/72072#c10 (10Daniel Zahn) ticket for upgrading sodium: RT #5420 ticket for deploying new dumps misc hosts RT #4570 ticket for enabling https on dumps: RT #7067 [23:49:14] 3MediaWiki / 3API: bad link in API help for uselang "list of codes" - 10https://bugzilla.wikimedia.org/72798 (10spage) 3NEW p:3Unprio s:3minor a:3None The new awesome HTML API output displays: uselang ... A list of codes may be fetched from action=query&meta=siteinfo&siprop=languages The displaye... [23:53:41] 3Wikimedia / 3General/Unknown: Unable to login and reset password: "Invalid hash given" in all cases - 10https://bugzilla.wikimedia.org/70098#c12 (10Chris Steipp) 5NEW>3RESO/FIX I think we fixed the general issue, and the specific user is in, so I'm going to close this. Reopen if anything else is needed.