[00:02:36] jackmcbarn, what MIME type would you like there? we don't care which one to use [00:03:35] yurikR: text/x-wiki like action=raw uses [00:04:23] jackmcbarn, i'm ok with it, although it won't be entirely accurate - most of the time it will be json. Do you have any objections to json? [00:05:07] i don't know all the details of which mime types are safe and which aren't; i just remember that text/plain isn't [00:06:12] easy enough to change. I am not very happy with x-wiki simply because it is not accurate. As far as i read somewhere, only IE treats text/plain as something magical, but the problem is that it also does that with many other, if not all, mime types [00:07:39] 3MediaWiki / 3API: API and OAuth malfunction - 10https://bugzilla.wikimedia.org/72384#c14 (10Brad Jorsch) 5REOP>3RESO/FIX Since this issue was about the "Internal Server Error" rather than an API error response, let's keep this closed unless that's recurring. If you want to open a new bug about OAuth no... [00:08:07] 3MediaWiki extensions / 3CentralAuth: Global renames should leave local log entries on affected wikis - 10https://bugzilla.wikimedia.org/70851#c4 (10Ajraddatz) Legoktm's idea sounds good to me. [00:21:37] (03PS1) 10Chad: Remove back-compat profiling configuration [core] - 10https://gerrit.wikimedia.org/r/169631 [00:23:07] (03CR) 10BryanDavis: [C: 032] "Less cruft == more awesome" [core] - 10https://gerrit.wikimedia.org/r/169631 (owner: 10Chad) [00:28:57] (03Merged) 10jenkins-bot: Remove back-compat profiling configuration [core] - 10https://gerrit.wikimedia.org/r/169631 (owner: 10Chad) [00:47:07] (03PS1) 10Mattflaschen: Hygiene: Standardize spelling of API classes and methods. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169634 [00:53:55] (03PS1) 10Mattflaschen: Include workflow title in TopicList API response [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169636 (https://bugzilla.wikimedia.org/72655) [01:00:45] RoanKattouw: $wgMFDeviceWidthTablet = 768; $wgMFDeviceWidthMobileSmall = 280; [01:02:45] RoanKattouw: For userAgent sniffing (which we actually don't use currently, check out includes/DeviceDetection.php in MF_ [01:03:19] RoanKattouw: It's PHP code, but the regexes might be useful [01:07:30] (03CR) 10EBernhardson: [C: 04-1] Include workflow title in TopicList API response (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169636 (https://bugzilla.wikimedia.org/72655) (owner: 10Mattflaschen) [01:14:23] 3MediaWiki extensions / 3MassMessage: Add support to MassMessage to allow using the sender's username for deliveries - 10https://bugzilla.wikimedia.org/69954 (10wctaiwan) 5PATC>3NEW [01:15:24] 3MediaWiki extensions / 3MassMessage: CreateMassMessageList source text input field accepts non-existent categories - 10https://bugzilla.wikimedia.org/70522 (10wctaiwan) 5PATC>3RESO/FIX [01:18:52] (03PS1) 10Alex Monk: Expose ID of relevant page in JS variables [core] - 10https://gerrit.wikimedia.org/r/169639 (https://bugzilla.wikimedia.org/53774) [01:21:38] 3MediaWiki extensions / 3MassMessage: CreateMassMessageList source text input field should not suggest invalid options (non-lists and non-categories) - 10https://bugzilla.wikimedia.org/70524 (10wctaiwan) 5UNCO>3NEW s:5normal>3enhanc [01:22:20] (03PS3) 10Jforrester: Remove jQuery Migrate and $wgIncludejQueryMigrate [core] - 10https://gerrit.wikimedia.org/r/137168 [01:22:52] (03CR) 10Jforrester: "Now nominally OK to merge, though some further announcements are due as a last-minute alert." [core] - 10https://gerrit.wikimedia.org/r/137168 (owner: 10Jforrester) [01:23:24] 3MediaWiki extensions / 3MassMessage: Update documentation to incorporate mm-ch - 10https://bugzilla.wikimedia.org/70633#c1 (10wctaiwan) 5NEW>3RESO/FIX Documentation has been added for both the UI and the API. [01:24:03] (03CR) 10jenkins-bot: [V: 04-1] Remove jQuery Migrate and $wgIncludejQueryMigrate [core] - 10https://gerrit.wikimedia.org/r/137168 (owner: 10Jforrester) [01:24:54] (03CR) 10jenkins-bot: [V: 04-1] Expose ID of relevant page in JS variables [core] - 10https://gerrit.wikimedia.org/r/169639 (https://bugzilla.wikimedia.org/53774) (owner: 10Alex Monk) [01:25:03] (03PS4) 10Jforrester: Remove jQuery Migrate and $wgIncludejQueryMigrate [core] - 10https://gerrit.wikimedia.org/r/137168 [01:26:05] (03CR) 10Alex Monk: "recheck" [core] - 10https://gerrit.wikimedia.org/r/169639 (https://bugzilla.wikimedia.org/53774) (owner: 10Alex Monk) [01:26:50] (03CR) 10jenkins-bot: [V: 04-1] Remove jQuery Migrate and $wgIncludejQueryMigrate [core] - 10https://gerrit.wikimedia.org/r/137168 (owner: 10Jforrester) [01:29:44] (03PS5) 10Jforrester: Remove jQuery Migrate and $wgIncludejQueryMigrate [core] - 10https://gerrit.wikimedia.org/r/137168 [01:31:20] (03CR) 10jenkins-bot: [V: 04-1] Remove jQuery Migrate and $wgIncludejQueryMigrate [core] - 10https://gerrit.wikimedia.org/r/137168 (owner: 10Jforrester) [01:33:32] Krenair: Did you want to do https://bugzilla.wikimedia.org/show_bug.cgi?id=72156 for today? :-) [01:34:09] had forgotten about that [01:34:19] Sorry. :-) [01:36:35] wait, what? we are still using this in ve-mw? [01:36:45] We are? [01:36:49] Where? [01:37:34] MWTemplateDialog, MWImageNode, MWTransclusionModel, MWImageModel, Target, ViewPageTarget [01:37:56] Huh. [01:38:00] I thought those got removed? [01:38:09] Did I mess up? [01:38:17] er, without Target [01:38:19] I thought they did as well [01:38:24] Anyway, first step, let's remove those. :-) [01:40:44] almost all of them were gone when the commit to ve-mw to remove those callers got merged (except one in MWMediaDialog which somehow got missed) [01:40:56] But they came back? [01:41:00] Rebase issues? [01:41:39] 3MediaWiki extensions / 3MassMessage: Only mark MassMessage edits as a bot in User talk namespace - 10https://bugzilla.wikimedia.org/65180 (10Kunal Mehta (Legoktm)) [01:41:52] 3MediaWiki extensions / 3MassMessage: CreateMassMessageList title input should use AJAX to warn about preëxisting titles - 10https://bugzilla.wikimedia.org/70471 (10Kunal Mehta (Legoktm)) [01:42:07] 3MediaWiki extensions / 3MassMessage: CreateMassMessageList source field should be hidden until needed - 10https://bugzilla.wikimedia.org/70520 (10Kunal Mehta (Legoktm)) [01:42:38] James_F, possibly [01:42:39] 3MediaWiki extensions / 3MassMessage: CreateMassMessageList source text input should use AJAX to warn about an invalid entry - 10https://bugzilla.wikimedia.org/70523 (10Kunal Mehta (Legoktm)) [01:42:49] probably some new ones introduced separately as well [01:55:52] 3MediaWiki extensions / 3Popups: Hovercards not active on Live preview or wikEd preview: add mw.hook( 'wikipage.content' ) - 10https://bugzilla.wikimedia.org/72628#c1 (10Quiddity) Created attachment 16938 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16938&action=edit screenshot Hovercards are actu... [01:58:11] (03CR) 10Alex Monk: "recheck" [core] - 10https://gerrit.wikimedia.org/r/169639 (https://bugzilla.wikimedia.org/53774) (owner: 10Alex Monk) [01:59:26] (03CR) 10Jforrester: [C: 032] "Per Ori." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/167326 (https://bugzilla.wikimedia.org/72197) (owner: 10Catrope) [02:01:15] (03Merged) 10jenkins-bot: Fix off-by-one error in mw.track subscriber [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/167326 (https://bugzilla.wikimedia.org/72197) (owner: 10Catrope) [02:06:58] James_F, ugh, PhantomJS timeouts [02:07:37] on three tests of the same change [02:08:24] Did the Phabricator e-mail address change... [02:08:32] It's shitting all over my inbox again. [02:08:58] I saw something about a noreply email change [02:09:00] T69+public+f5bf750f01f50098@phabricator.wikimedia.org [02:09:03] Cute. [02:09:33] Krenair: Lovely. [02:10:01] Carmela, [15:24:09] why'd the email change from noreply@ to no-reply@? :) (it broke my filters) [02:10:21] see http://bots.wmflabs.org/~wm-bot/logs/%23wikimedia-devtools/20141028.txt [02:16:28] Carmela: ISTR mail.wikimedia.org was killed yesterday; maybe related to that clean-up? [02:18:13] Carmela: *@phabricator.wikimedia.org? [02:18:15] wasn't it mail.wikipedia.org? [02:19:18] both, it seems [02:20:30] Both got killed. [02:20:37] werdna: Yeah, I did an ends with. :-) [02:23:17] (03PS39) 10Werdna: Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) [02:24:03] (03CR) 10jenkins-bot: [V: 04-1] Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [02:27:55] (03CR) 10Alex Monk: "recheck" [core] - 10https://gerrit.wikimedia.org/r/169639 (https://bugzilla.wikimedia.org/53774) (owner: 10Alex Monk) [02:46:33] Hi. [02:46:52] I wanted to know if it would be okay to add a large JSON file for transliterating a specific language. [02:47:22] It has complex rules, but the JSON contains a "dictionary" of common words/combinations [02:52:21] PiRSquared17: we already do that for different variants of Chinese [02:52:26] do you know about that? [02:52:44] werdna: This is for a variety of Chinese too, but it's more complex [02:53:02] because it is for Romanization, not simplification [02:53:43] Hakka Wikipedia is mostly written in Latin script but they want a hans/hant->latn transliterator [02:56:08] I already have a working version, but it requires thousands of lines of transliterations and words. I'm not sure that's allowed. [03:37:51] (03PS2) 10Mattflaschen: Include workflow title in TopicList API response [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169636 (https://bugzilla.wikimedia.org/72655) [03:40:15] Krinkle|detached, can you re-review the CSSJanus patch when you have a chance? It should be pretty straightforward. I addressed both of your notes at https://github.com/mattflaschen/node-cssjanus/commit/fce8b9220791243b36abcf2fe847f45c35c3f935#commitcomment-8096434 [03:40:41] New patch is https://github.com/mattflaschen/node-cssjanus/commit/69007a515c60d0869ba96c3e56bac06cc4ed7a18 [04:07:10] (03CR) 10Mattflaschen: [C: 04-1] "I don't understand yet why flow-component is being moved out of Handlebars and into PHP. But I gather it's due to discussion at https://g" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169494 (owner: 10SG) [04:24:11] (03PS1) 10Legoktm: Updates after performance review [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/169653 [04:28:07] (03PS2) 10Legoktm: Updates after performance review [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/169653 [04:30:41] (03CR) 10EBernhardson: "i was thinking like this, but a smidgen different :) First a prelude for matt, your opinion is likely valuable i'm not so familiar with fr" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169494 (owner: 10SG) [04:31:37] 3MediaWiki extensions / 3GlobalUserPage: Performance review of GlobalUserPage extension - 10https://bugzilla.wikimedia.org/70585#c2 (10Kunal Mehta (Legoktm)) 5ASSI>3PATC (In reply to Aaron Schulz from comment #1) > * I don't like the unbounded cache in displayGlobalPage() I set it to 100, is that too hi... [04:36:52] (03PS3) 10Legoktm: Updates after performance review [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/169653 [04:37:02] (03CR) 10EBernhardson: "One other thing, in this case since flow_component was only a single html element i don't have a strong opinion either way, but in general" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169494 (owner: 10SG) [04:43:16] (03CR) 10Jack Phoenix: [C: 031] Updates after performance review [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/169653 (owner: 10Legoktm) [04:49:24] (03CR) 10MZMcBride: "It may make sense to cross-reference bug 70585 in the commit message." [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/169653 (owner: 10Legoktm) [04:49:56] (03PS4) 10Legoktm: Updates after performance review [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/169653 (https://bugzilla.wikimedia.org/70585) [05:33:24] (03PS5) 10BryanDavis: [WIP] Enable profiling via xhprof [core] - 10https://gerrit.wikimedia.org/r/168930 [05:39:24] 3MediaWiki extensions / 3BounceHandler: Performance review BounceHandler extension for Deployment - 10https://bugzilla.wikimedia.org/69100#c4 (10Tony Thomas) (In reply to Aaron Schulz from comment #3) > Where is the code for the broker that takes in the bounces and does a POST > to the API? Here is the cod... [06:17:46] (03PS1) 1001tonythomas: Handle the return value of getOriginalEmail efficiently [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/169654 (https://bugzilla.wikimedia.org/69100) [06:25:59] (03PS2) 1001tonythomas: Various performance fixed for the BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/169654 (https://bugzilla.wikimedia.org/69100) [06:48:03] (03PS5) 10Mooeypoo: [Extremely WIP] Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 [06:48:06] (03CR) 10jenkins-bot: [V: 04-1] [Extremely WIP] Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo) [06:59:53] (03PS2) 10Springle: Switch to LOCK IN SHARE MODE in recordUpload2() [core] - 10https://gerrit.wikimedia.org/r/167424 (owner: 10Aaron Schulz) [07:05:24] (03CR) 10Robert Vogel: [C: 032 V: 032] Added QQQ [extensions/Teahouse] - 10https://gerrit.wikimedia.org/r/169322 (owner: 10Robert Vogel) [07:05:54] (03CR) 10Robert Vogel: [C: 032 V: 032] Added missing I18N [extensions/BlueSpiceExtensions] (REL1_22) - 10https://gerrit.wikimedia.org/r/169332 (owner: 10Robert Vogel) [07:09:11] (03CR) 10Springle: [C: 032] Switch to LOCK IN SHARE MODE in recordUpload2() [core] - 10https://gerrit.wikimedia.org/r/167424 (owner: 10Aaron Schulz) [07:14:10] 3MediaWiki / 3Categories: sorting in category: B before A - 10https://bugzilla.wikimedia.org/72661 (10Romaine) 3NEW p:3Unprio s:3normal a:3None Category: https://commons.wikimedia.org/wiki/Category:Wikipedia_logo_variants_by_language This category on Commons categorizes the categories starting with... [07:19:13] superm401: Around? [07:19:30] prtksxna, yeah, what's up? [07:26:16] superm401: Going through https://etherpad.wikimedia.org/p/sendBeacon-2014-10-03 now. For how much longer are you online? [07:26:51] prtksxna, I can talk for a few minutes, not too long. [07:27:36] prtksxna, so as that says, we decided to do an initial experiment with just two calls (logEventThatCallsSendBeacon (whatever that is called) and logEvent). sendBeacon would be the only backend for the first one, at least initially. [07:28:09] superm401: And where do we actually start using this? [07:28:24] prtksxna, nowhere initially, except an experiment. [07:28:31] The experiment will be in WikimediaEvents. [07:28:33] The point is to get an idea of sendBeacon real-world availability and reliability by comparing to logEvent (considered a reliable base-line, since this logging will not be on link-click). [07:28:49] superm401: I see, so all there is to do is to rename the method? [07:28:59] superm401: Do we still need it to return a promise? [07:29:40] prtksxna, yeah, basically. I am doing the experiment (given at the bottom of the etherpad) [07:30:16] I favor having it return a promise. Whether that is useful depends on whether it ever uses an backend that uses async calls. [07:30:18] See https://gerrit.wikimedia.org/r/#/c/162194/3/modules/ext.eventLogging.core.js [07:30:43] BTW, nuria__ does not favor adding another backend for now, but we haven't ruled it out 100% for later. [07:30:59] superm401: Yeah saw that. So I'll make it return a promise that has resolved based on whatever sendBeacon returned [07:31:51] Right, if you go with the promise, it can resolve/reject immediately based on the boolean. [07:32:08] Cool. Thanks! [07:32:14] Night superm401 o/ [07:32:29] prtksxna, thanks, TZAG. :) [08:16:53] 3MediaWiki / 3API: Using a generator together with a non-query module always uses new continue format - 10https://bugzilla.wikimedia.org/72471#c6 (10Michael M.) (In reply to Brad Jorsch from comment #5) > If you're referring to the documentation on > mediawiki.org, feel free to update that. I added [[mw:API... [08:17:17] (03PS1) 10Christopher Johnson (WMDE): Fix infinite ApplicationField in proxy custom field object [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/169656 [08:20:41] (03PS2) 10Christopher Johnson (WMDE): Fix infinite ApplicationField in proxy custom field object [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/169656 [08:21:54] (03CR) 10Christopher Johnson (WMDE): [C: 032 V: 032] Fix infinite ApplicationField in proxy custom field object [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/169656 (owner: 10Christopher Johnson (WMDE)) [08:58:53] 3MediaWiki / 3Export/Import: Call ContentHandler::exportTransform in backupTextPass.inc and friends - 10https://bugzilla.wikimedia.org/72361 (10tobias.gritschacher) [09:05:28] (03CR) 10Zfilipin: "Why do we need Include/Exclude statements? The point of this commit is to make RuboCop run after every push to Gerrit. If somebody wants t" [core] - 10https://gerrit.wikimedia.org/r/167794 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [09:05:41] (03PS1) 10Smuggli: Fixed display of section results [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/169659 [09:12:51] (03CR) 10Robert Vogel: [C: 031 V: 031] "I see no problems." [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/169659 (owner: 10Smuggli) [09:13:10] (03CR) 10Smuggli: [C: 032 V: 032] Fixed display of section results [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/169659 (owner: 10Smuggli) [09:13:21] (03Merged) 10jenkins-bot: Fixed display of section results [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/169659 (owner: 10Smuggli) [09:33:04] (03CR) 10Hashar: "> This is already covered by banana-checker in the front-end tests, which are run by Jenkins (mediawiki-core-npm)." [core] - 10https://gerrit.wikimedia.org/r/169579 (https://bugzilla.wikimedia.org/35942) (owner: 10Umherirrender) [10:10:39] (03PS1) 10Smuggli: Added boost query for namespace evaluation [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/169666 [10:13:40] (03PS2) 10Smuggli: Added support for opensearch [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/169509 [10:35:06] (03PS1) 10Robert Vogel: Bugfix: Popup position and links [extensions/Teahouse] - 10https://gerrit.wikimedia.org/r/169669 [10:38:18] (03PS1) 10Robert Vogel: Fixed typo in I18N text [extensions/Teahouse] - 10https://gerrit.wikimedia.org/r/169670 [10:48:34] (03PS4) 10Prtksxna: Add an experimental function to log events using the sendBeacon API. [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/162194 (https://bugzilla.wikimedia.org/42815) [10:49:23] 3Wikimedia / 3Site requests: Temporary lift of IP cap for JNCF 2014 workshop - 10https://bugzilla.wikimedia.org/72518 (10Glaisher) 5PATC>3RESO/FIX [10:56:09] 3Wikimedia / 3Site requests: Enable mergehistory right of transwiki group on it.wiktionary.org - 10https://bugzilla.wikimedia.org/72422 (10Glaisher) 5PATC>3RESO/FIX a:3Glaisher [10:56:16] (03CR) 10Hashar: "Thanks! That will make it easier to review them and would most probably get them merged in faster :-]" [tools/release] - 10https://gerrit.wikimedia.org/r/169308 (owner: 10MarkAHershberger) [11:21:37] (03PS6) 10Cacycle: Add a hook for custom diff engines (WikEdDiff) [core] - 10https://gerrit.wikimedia.org/r/166143 (https://bugzilla.wikimedia.org/71916) [11:21:39] (03PS1) 10Cacycle: Add a hook for custom diff engines (WikEdDiff) [core] - 10https://gerrit.wikimedia.org/r/169677 (https://bugzilla.wikimedia.org/71916) [11:28:53] (03CR) 10Matthias Mullie: [C: 031] "Looks good, merge when the time is right" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167639 (owner: 10EBernhardson) [11:33:29] (03PS1) 10Vogone: Adjust 'wikidata-staff' group page i18n [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/169678 [11:37:15] (03CR) 10Matthias Mullie: [C: 032] Fix incorrect collapsed form state when topic sort changes. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169625 (https://bugzilla.wikimedia.org/72602) (owner: 10Mattflaschen) [11:38:10] (03Merged) 10jenkins-bot: Fix incorrect collapsed form state when topic sort changes. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169625 (https://bugzilla.wikimedia.org/72602) (owner: 10Mattflaschen) [11:53:29] (03CR) 10Cacycle: "Sorry, I have no idea why the new patch set landed under:" [core] - 10https://gerrit.wikimedia.org/r/166143 (https://bugzilla.wikimedia.org/71916) (owner: 10Cacycle) [12:01:01] (03CR) 10SG: "Getting rid of flow_component makes sense, because that template isn't used client-side, and resolves some hacky code in the PHP." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169494 (owner: 10SG) [12:02:52] (03CR) 10SG: Update lightncandy and remove flow_component (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169494 (owner: 10SG) [12:05:08] (03PS4) 10SG: Update lightncandy and remove flow_component [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169494 [12:05:37] (03CR) 10SG: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166728 (owner: 10SG) [12:05:53] (03CR) 10jenkins-bot: [V: 04-1] Update lightncandy and remove flow_component [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169494 (owner: 10SG) [12:06:15] (03PS25) 10SG: H-8. Implement boardHistory component features [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166728 [12:06:23] (03PS17) 10SG: J-1: Comment moderation updates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166778 (owner: 10EBernhardson) [12:10:37] 3MediaWiki extensions / 3Popups: Hovercards not active on Live preview or wikEd preview: add mw.hook( 'wikipage.content' ) - 10https://bugzilla.wikimedia.org/72628#c2 (10Cacycle) 5NEW>3RESO/FIX Thanks Quiddity, it now works fine after I have removed the elevated z-index in wikEd (no idea why it was there... [12:30:10] 3MediaWiki / 3Revision deletion: Wrong error message after deleting an article - 10https://bugzilla.wikimedia.org/72672 (10Fomafix) 3NEW p:3Unprio s:3minor a:3None I just saw on my watchlist a deletion request on an article: 13:13 Zellersee (Naturschutzgebiet)‎ (Unterschied | Versionen) . . (+... [12:30:39] (03CR) 10PleaseStand: "> Sorry, I have no idea why the new patch set landed under:" [core] - 10https://gerrit.wikimedia.org/r/166143 (https://bugzilla.wikimedia.org/71916) (owner: 10Cacycle) [12:32:01] (03PS58) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [12:35:49] (03PS7) 10PleaseStand: Add a hook for custom diff engines (WikEdDiff) [core] - 10https://gerrit.wikimedia.org/r/166143 (https://bugzilla.wikimedia.org/71916) (owner: 10Cacycle) [12:36:27] (03CR) 10Florianschmidtwelzow: "Legoktm: Can you take a look on this again please? :)" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/136323 (https://bugzilla.wikimedia.org/19648) (owner: 10Florianschmidtwelzow) [12:37:35] (03Abandoned) 10PleaseStand: Add a hook for custom diff engines (WikEdDiff) [core] - 10https://gerrit.wikimedia.org/r/169677 (https://bugzilla.wikimedia.org/71916) (owner: 10Cacycle) [12:41:09] 3MediaWiki / 3Revision deletion: Wrong error message after deleting an article - 10https://bugzilla.wikimedia.org/72672#c1 (10Vogone) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 29280 *** [12:41:09] 3MediaWiki / 3General/Unknown: More detailed badtitle errors - 10https://bugzilla.wikimedia.org/29280#c7 (10Vogone) *** Bug 72672 has been marked as a duplicate of this bug. *** [12:59:22] (03CR) 10Cacycle: "PleaseStand: Thanks a lot!" [core] - 10https://gerrit.wikimedia.org/r/166143 (https://bugzilla.wikimedia.org/71916) (owner: 10Cacycle) [13:07:42] Hi [13:09:05] manybubbles: Thanks for your help yesterday. I now see things are working atleast without any errors [13:09:26] vijay_: wonderful! [13:09:30] sorry for the confusion [13:11:08] manybubbles: I followed the instructions on https://github.com/wikimedia/mediawiki-extensions-CirrusSearch/blob/master/README for indexing but yesterday even I couldn't get the results from even console [13:12:12] vijay_: I don't understand. you ran the indexing script and it failed with an error? or it worked but you couldn't find any documents? [13:12:21] manybubbles: Then today, I tried to clear all the indexes and tried to follow the step1 on the topic upgrade from the same readme document and I now I see results from wiki [13:12:49] manybubbles: the index script ran completely but I dont see any results for any query [13:13:03] then I tried today again as mentioned above [13:13:07] hmmmm [13:13:13] I do wonder why it failed the first time [13:13:27] I'm tempted to believe that it was because of the elasticsearch setup being wonky [13:13:35] because it worked the second time around.... [13:15:33] manybubbles: yes,may be. Today I'm able to see the results from console and also from wiki [13:15:58] manybubbles: If i'm right, the indexes should be stored somewhere like /var/lib/elasticsearch/elasticsearch/nodes/0/indices/wikidb_general_first/0/index , am I right? [13:16:10] vijay_: yup [13:16:57] manybubbles: yesterda those folder were empty even after I ran the index for about 40K odd pages. I saw only segments_d and nothing else [13:17:32] vijay_: was this before or after killing the extra elasticsearch processes? [13:17:54] manybubbles: after killing extra processes [13:19:01] manybubbles: I have some doubts over the search from wiki, query like linksto:Main_Page is not returning any results while Main_Page exists and links also exists [13:21:07] vijay_: I *think* linksto is from a newer version of cirrus [13:21:24] manybubbles: I'm using 0.2 [13:21:27] you can check - open the file called Searcher.php and search for linksto [13:21:33] ok [13:21:55] ^d: I thank you too on the help you provided on Cirrus and elastic search [13:21:57] vijay_: because we release weekly the public version numbers don't mean much to me, unfortunately [13:22:08] manybubbles: ok :) [13:23:22] <^d> vijay_: You're welcome :) [13:24:47] manybubbles: I dont see that. I see boost-templates, hastemplate, incategory, intitle only [13:25:39] vijay_: then its not in that version :( - I'll have to make a new release compatible for 1.23 [13:25:51] manybubbles: ok [13:26:00] manybubbles: I have a requirement that my results should be order by recent documents along with relevance, is that possible? [13:26:00] let me add that to my list - I imagine I can get to it tomorrow [13:26:44] vijay_: yeah - look at $wgCirrusSearchPreferRecentDefaultDecayPortion and $wgCirrusSearchPreferRecentUnspecifiedDecayPortion and $wgCirrusSearchPreferRecentDefaultHalfLife [13:26:51] that should just work [13:27:23] <^d> We should maybe bump the version number more often too. [13:27:25] you can set those to configure how big the of a boost recency offers [13:27:42] ^d: we should release every couple weeks to all the "supported" versions of mw I think [13:27:50] like, with a release schedule and stuff [13:27:56] we do have external users [13:28:01] like vijay_ [13:28:46] (03CR) 10Anomie: "Code looks good to me, haven't tested. A few nitpicks." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/166143 (https://bugzilla.wikimedia.org/71916) (owner: 10Cacycle) [13:29:50] manybubbles: what value should wgCirrusSearchPreferRecentDefaultDecayPortion have? [13:30:42] vijay_: its the portion of the score scaled by the recent updates. [13:30:50] ok [13:31:08] vijay_: so if you think recency is super important set it to like .9 or 1. If its only a bit important then .2. [13:32:34] vijay_: the half life is how quickly the scores fall off with time [13:33:15] <^d> manybubbles: Yeah, let's talk about that later. [13:37:37] vijay_: https://phabricator.wikimedia.org/T964 tracks us cutting a new cirrus for 1.23 [13:38:30] (03PS1) 10Matthias Mullie: Add test for wikitext-html-wikitext roundtrip [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169695 [13:39:15] (03CR) 10jenkins-bot: [V: 04-1] Add test for wikitext-html-wikitext roundtrip [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169695 (owner: 10Matthias Mullie) [13:41:20] (03CR) 10Cacycle: "> Line 632: if ( wfRunHooks( 'GetDiffEngineClass', array( &$context, &$diffEngineClass ) ) ) {" [core] - 10https://gerrit.wikimedia.org/r/166143 (https://bugzilla.wikimedia.org/71916) (owner: 10Cacycle) [13:44:29] Can you even type those variable names in a commit message and make it conform to the guidelines? :P [13:47:09] manybubbles: Yes I tried with a value 1 for wgCirrusSearchPreferRecentDefaultDecayPortion and with a value of 0 and I see the results differ [13:47:42] 3MediaWiki / 3JavaScript: JavaScript caching within localStorage allows persisten XSS on all *.wikipedia.org domains. - 10https://bugzilla.wikimedia.org/72676 (10lekies-sebastian) 3UNCO p:3Unprio s:3normal a:3None The wikipedia main page caches a piece of JavaScript code within localStorage under the... [13:47:44] vijay_: yup - its a sliding scale [13:47:55] 3MediaWiki / 3JavaScript: JavaScript caching within localStorage allows persistent XSS on all *.wikipedia.org domains. - 10https://bugzilla.wikimedia.org/72676 (10lekies-sebastian) [13:53:02] manybubbles: but some times when the value is 1 and stil the results are coming not exactly in the order of last updted date, What I would have liked is like get all the document on relevance and then sort by recency and display [13:53:22] (03PS2) 10Matthias Mullie: Add test for wikitext-html-wikitext roundtrip [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169695 [13:53:45] manybubbles: I dont know whether this is available in cirrus now , and even its not possible I would be happy with the current settings [13:53:48] vijay_: that isn't supported as such - you can lower the half life and get closer to that behavior [13:54:05] (03CR) 10jenkins-bot: [V: 04-1] Add test for wikitext-html-wikitext roundtrip [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169695 (owner: 10Matthias Mullie) [13:54:15] manybubbles: ok. I understand the changes it may require ;) [13:57:27] superm401: yt? [14:05:34] (03CR) 10PleaseStand: "> No, it is not supposed to be be changed. It is passed by reference for saving resources by not duplicating this large object." [core] - 10https://gerrit.wikimedia.org/r/166143 (https://bugzilla.wikimedia.org/71916) (owner: 10Cacycle) [14:11:12] (03CR) 10Anomie: "> It is passed by reference for saving resources by not duplicating this large object." [core] - 10https://gerrit.wikimedia.org/r/166143 (https://bugzilla.wikimedia.org/71916) (owner: 10Cacycle) [14:12:41] (03PS5) 10Kji: Initial commit for the HierarchyBuilder extension. [extensions/HierarchyBuilder] - 10https://gerrit.wikimedia.org/r/168192 [14:14:45] (03CR) 10Anomie: [C: 031] "Looks good, haven't tested." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/169593 (https://bugzilla.wikimedia.org/72634) (owner: 10CSteipp) [14:17:37] (03PS1) 10Manybubbles: Doc fix [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/169701 [14:20:20] (03PS1) 10Aude: Update Wikidata branch [tools/release] - 10https://gerrit.wikimedia.org/r/169702 [14:22:24] 3Wikimedia / 3Site requests: Requesting temporary lift of the IP cap in ca.wiki - 10https://bugzilla.wikimedia.org/72611#c2 (10Glaisher) a:3Glaisher I'll try to get this done by the next SWAT window which will happen in about 30 minutes. [14:23:23] (03CR) 10Chad: [C: 032] Doc fix [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/169701 (owner: 10Manybubbles) [14:23:45] (03Merged) 10jenkins-bot: Doc fix [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/169701 (owner: 10Manybubbles) [14:24:56] (03PS1) 10Aude: Update Wikidata, fix js error in "add links" client widget [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169707 [14:28:08] 3Wikimedia / 3Bugzilla: Remove Alolita from default CCs - 10https://bugzilla.wikimedia.org/72617#c10 (10Alolita Sharma) Nemo - can you add my gmail back to default cc? Still waiting.... [14:35:41] (03PS1) 10Matthias Mullie: Throw correct exception when failing to contact Parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169710 [14:35:44] (03PS1) 10Matthias Mullie: (bug 70148) Fix new topic creation with wikitext storage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169711 (https://bugzilla.wikimedia.org/70148) [14:36:44] (03CR) 10jenkins-bot: [V: 04-1] (bug 70148) Fix new topic creation with wikitext storage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169711 (https://bugzilla.wikimedia.org/70148) (owner: 10Matthias Mullie) [14:37:50] since when do we put the bug number into the description line again? :O [14:38:45] old habbits die hard, I guess :p [14:40:20] (03PS3) 10Matthias Mullie: Add test for wikitext-html-wikitext roundtrip [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169695 [14:40:23] (03CR) 10Alex Monk: "recheck" [core] - 10https://gerrit.wikimedia.org/r/169639 (https://bugzilla.wikimedia.org/53774) (owner: 10Alex Monk) [14:41:04] (03CR) 10jenkins-bot: [V: 04-1] Add test for wikitext-html-wikitext roundtrip [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169695 (owner: 10Matthias Mullie) [14:47:12] (03CR) 10PleaseStand: [C: 04-1] "It's pointless to continue to post "recheck" comments when the tests are reliably failing because of a bug in your code." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/169639 (https://bugzilla.wikimedia.org/53774) (owner: 10Alex Monk) [14:49:07] (03CR) 10Kji: "Thank you for all your help Siebrand!" [extensions/HierarchyBuilder] - 10https://gerrit.wikimedia.org/r/168192 (owner: 10Kji) [14:49:53] 3MediaWiki / 3Interface: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277#c83 (10Dan Andreescu) Created attachment 16942 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16942&action=edit hits to */skins/common/** on October... [14:50:24] (03PS4) 10Matthias Mullie: Add test for wikitext-html-wikitext roundtrip [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169695 [14:51:09] (03CR) 10jenkins-bot: [V: 04-1] Add test for wikitext-html-wikitext roundtrip [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169695 (owner: 10Matthias Mullie) [14:52:52] 3MediaWiki / 3Interface: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277#c84 (10Sam Reed (reedy)) wtf /static-1.21wmf10/skins/common/images/magnify-clip.png 14926 /static-1.21wmf8/skins/common/images/magnify-clip.png 11160... [14:58:01] (03PS8) 10Cacycle: Add a hook for custom diff engines (WikEdDiff) [core] - 10https://gerrit.wikimedia.org/r/166143 (https://bugzilla.wikimedia.org/71916) [14:59:28] (03CR) 10MarkTraceur: [C: 04-1] Trim trailing dots in UploadWizard filename (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/169326 (https://bugzilla.wikimedia.org/71704) (owner: 1001tonythomas) [15:00:22] (03CR) 10Anomie: [C: 032] "SWAT" [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169707 (owner: 10Aude) [15:00:53] (03CR) 10Cacycle: "> File docs/hooks.txt:" [core] - 10https://gerrit.wikimedia.org/r/166143 (https://bugzilla.wikimedia.org/71916) (owner: 10Cacycle) [15:01:19] (03PS2) 10Alex Monk: Expose ID of relevant page in JS variables [core] - 10https://gerrit.wikimedia.org/r/169639 (https://bugzilla.wikimedia.org/53774) [15:02:17] (03CR) 10MarkTraceur: Points upload events to the right schema (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/168563 (https://bugzilla.wikimedia.org/72360) (owner: 10Gilles) [15:02:34] (03CR) 10Anomie: "The formatting doesn't look as bad as I had thought. Thanks for doing this, Siebrand." (038 comments) [core] - 10https://gerrit.wikimedia.org/r/169534 (owner: 10Siebrand) [15:03:03] (03PS2) 10MarkTraceur: Points upload events to the right schema [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/168563 (https://bugzilla.wikimedia.org/72360) (owner: 10Gilles) [15:03:55] 3MediaWiki / 3History/Diffs: Edit disappeared from history - 10https://bugzilla.wikimedia.org/72677 (10Helder) 3NEW p:3Unprio s:3major a:3None The he edit https://pt.wikipedia.org/w/index.php?diff=40404233&uselang=en (from 2014-10-29T12:46:27), is visible in the user contributions https://pt.wikipedi... [15:03:56] (03CR) 10MarkTraceur: [C: 031] "Leaving +2 to gi11es, should be quick, I just changed the docstrings" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/168563 (https://bugzilla.wikimedia.org/72360) (owner: 10Gilles) [15:04:25] (03CR) 10Gilles: [C: 032] Points upload events to the right schema [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/168563 (https://bugzilla.wikimedia.org/72360) (owner: 10Gilles) [15:06:49] (03Merged) 10jenkins-bot: Update Wikidata, fix js error in "add links" client widget [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169707 (owner: 10Aude) [15:06:51] (03Merged) 10jenkins-bot: Points upload events to the right schema [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/168563 (https://bugzilla.wikimedia.org/72360) (owner: 10Gilles) [15:12:38] 3Wikimedia / 3Site requests: Requesting temporary lift of the IP cap in ca.wiki - 10https://bugzilla.wikimedia.org/72611 (10Glaisher) 5PATC>3RESO/FIX [15:13:07] (03CR) 10Alex Monk: "Right, thanks for pointing that out PleaseStand. I had been assuming that the "PhantomJS timed out, possibly due to a missing QUnit start(" [core] - 10https://gerrit.wikimedia.org/r/169639 (https://bugzilla.wikimedia.org/53774) (owner: 10Alex Monk) [15:15:51] (03PS5) 10Matthias Mullie: Add test for wikitext-html-wikitext roundtrip [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169695 [15:16:24] (03PS1) 10Anomie: API: Fix access on getExamplesMessages [core] - 10https://gerrit.wikimedia.org/r/169717 [15:17:04] (03PS1) 10Anomie: API: Actually use api-help-param-no-description [core] - 10https://gerrit.wikimedia.org/r/169718 [15:18:09] (03CR) 10Reedy: [C: 032] API: Fix access on getExamplesMessages [core] - 10https://gerrit.wikimedia.org/r/169717 (owner: 10Anomie) [15:19:55] (03CR) 10jenkins-bot: [V: 04-1] Add test for wikitext-html-wikitext roundtrip [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169695 (owner: 10Matthias Mullie) [15:21:08] 3MediaWiki / 3History/Diffs: Edit disappeared from history - 10https://bugzilla.wikimedia.org/72677#c1 (10Helder) 5NEW>3RESO/INV Never mind. The edit was in another article with a similar title: https://pt.wikipedia.org/w/index.php?title=Droga_lícita&action=history&uselang=en [15:23:38] (03CR) 10KartikMistry: [C: 032] Update CXServer to 5ccdc0d [services/cxserver/deploy] - 10https://gerrit.wikimedia.org/r/167629 (owner: 10KartikMistry) [15:24:00] (03CR) 10KartikMistry: [V: 032] "Verified manually." [services/cxserver/deploy] - 10https://gerrit.wikimedia.org/r/167629 (owner: 10KartikMistry) [15:24:10] (03Merged) 10jenkins-bot: API: Fix access on getExamplesMessages [core] - 10https://gerrit.wikimedia.org/r/169717 (owner: 10Anomie) [15:27:23] (03PS6) 10Matthias Mullie: Add test for wikitext-html-wikitext roundtrip [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169695 [15:31:22] 3MediaWiki / 3Interface: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277#c85 (10Sam Reed (reedy)) (In reply to Dan Andreescu from comment #83) > Created attachment 16942 [details] > hits to */skins/common/** on October 27th Are... [15:36:22] 3MediaWiki / 3Categories: sorting in category: B before A - 10https://bugzilla.wikimedia.org/72661#c1 (10Bawolff (Brian Wolff)) Appears to be related to that page move doesnt change cl_type bug. Although not sure how that equals observed behaviour. Will have to look at code later when not on cell phone. For... [15:39:05] (03CR) 10Reedy: [C: 032] Update Wikidata branch [tools/release] - 10https://gerrit.wikimedia.org/r/169702 (owner: 10Aude) [15:39:11] (03Merged) 10jenkins-bot: Update Wikidata branch [tools/release] - 10https://gerrit.wikimedia.org/r/169702 (owner: 10Aude) [15:41:54] 3MediaWiki / 3Interface: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277#c86 (10Dan Andreescu) Well, you can query the logs with SQL on our hadoop cluster if you'd like more info (you have rights to stat1002.eqiad.wmnet right Sam... [15:47:54] 3MediaWiki / 3Interface: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277#c87 (10Sam Reed (reedy)) reedy@tin:/srv/mediawiki-staging$ ssh -A stat1002 Permission denied (publickey). reedy@tin:/srv/mediawiki-staging$ Nope :( [15:48:08] (03PS1) 10Pwirth: ExtendedStatistics: Small fixes [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/169726 [15:50:09] (03PS7) 10Matthias Mullie: Add test for wikitext-html-wikitext roundtrip [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169695 [15:50:53] (03CR) 10jenkins-bot: [V: 04-1] Add test for wikitext-html-wikitext roundtrip [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169695 (owner: 10Matthias Mullie) [15:56:35] (03CR) 10Smuggli: [C: 031] ExtendedStatistics: Small fixes [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/169726 (owner: 10Pwirth) [16:03:47] Thanks everyone . You guys are doing a great job [16:07:22] 3Wikimedia / 3Site requests: Set $wgCheckUserForceSummary to true on Wikimedia wikis - 10https://bugzilla.wikimedia.org/71457 (10Glaisher) p:5Low>3Normal [16:07:54] 3MediaWiki / 3Unit tests: Many LinksUpdateTest triggering MWException: LinkCache doesn't know latest revision ID of this title: Testing - 10https://bugzilla.wikimedia.org/44307 (10Kevin Israel (PleaseStand)) 5NEW>3RESO/FIX [16:12:23] 3Wikimedia / 3Site requests: Various site changes for voteWiki - 10https://bugzilla.wikimedia.org/72589 (10Glaisher) 5PATC>3RESO/FIX [16:14:15] DanielK_WMDE: meeting? [16:22:52] (03PS1) 10Smuggli: Renamed autocomplete file [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/169733 [16:24:29] manybubbles: sorry, i was in a training session all day, just got out now. [16:24:52] DanielK_WMDE: yikes. well, we can still do it if you have the willpower after an all day training. [16:25:21] manybubbles: i gotta run, sorry. but lydia is in SF, maybe you can get hold of her :) [16:25:38] 3MediaWiki extensions / 3Diff: [HHVM] Tests on Travis are failing (due to PHPUnit version used) - 10https://bugzilla.wikimedia.org/69524#c5 (10Jan Zerebecki) I think this was fixed? [16:25:49] cool [16:26:03] manybubbles: do you have any concrete questions / issues? my mind is quite blank... [16:26:11] yeah - nothing concrete [16:26:29] ok cool. ping lydia :) [16:26:35] i'm off! [16:26:39] 3MediaWiki extensions / 3Diff: [HHVM] Tests on Travis are failing (due to PHPUnit version used) - 10https://bugzilla.wikimedia.org/69524#c6 (10Jan Zerebecki) Sorry not true: https://travis-ci.org/wmde/Diff/jobs/38707716 [16:34:25] 3MediaWiki / 3Redirects: Redirects using relative links do not redirect - 10https://bugzilla.wikimedia.org/72682 (10djr013) 3UNCO p:3Unprio s:3normal a:3None Redirect pages which redirect from one subpage to another using a relative link do not create an automatic redirection to the target page. For... [16:35:48] (03PS1) 10MarkAHershberger: AuthorDate: 2014-10-20 23:40:20 +0200 [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/169734 (https://bugzilla.wikimedia.org/72274) [16:36:49] (03PS1) 10Jack Phoenix: Removed legacy i18n file + $dir var from setup file [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/169735 [16:37:09] (03CR) 10Jack Phoenix: [C: 032 V: 032] Removed legacy i18n file + $dir var from setup file [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/169735 (owner: 10Jack Phoenix) [16:37:53] (03PS2) 10MarkAHershberger: Add Content-Length header for job queue requests [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/169734 (https://bugzilla.wikimedia.org/72274) [16:39:37] (03CR) 10EBernhardson: "flow_block_loop is just a foreach loop, practically the implementation of flow_block_loop *is* the block helper, which is already implemen" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169494 (owner: 10SG) [16:42:22] 3MediaWiki extensions / 3Diff: [HHVM] Tests on Travis are failing (due to PHPUnit version used) - 10https://bugzilla.wikimedia.org/69524#c7 (10Jan Zerebecki) Probably needs a change like in https://github.com/wmde/WikibaseDataModel/commit/3dd5504a1a6568e6a8d237184ee578c3352cfc61 [16:48:24] 3Wikimedia / 3Bugzilla: Remove Alolita from default CCs - 10https://bugzilla.wikimedia.org/72617#c11 (10Andre Klapper) 5REOP>3RESO/INV I have now added the gmail account to * MediaWiki extensions > Babel * MediaWiki extensions > CLDR * MediaWiki extensions > ContentTranslation * MediaWiki extensions > T... [16:49:25] (03PS1) 10Jack Phoenix: Replaced deprecated $wgSpecialPageGroups definition with the correct, modern way of grouping a special page [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/169737 [16:50:55] (03CR) 10EBernhardson: [C: 032] Include workflow title in TopicList API response [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169636 (https://bugzilla.wikimedia.org/72655) (owner: 10Mattflaschen) [16:51:35] (03CR) 10Jack Phoenix: [C: 032 V: 032] Replaced deprecated $wgSpecialPageGroups definition with the correct, modern way of grouping a special page [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/169737 (owner: 10Jack Phoenix) [16:51:43] (03CR) 10jenkins-bot: [V: 04-1] Include workflow title in TopicList API response [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169636 (https://bugzilla.wikimedia.org/72655) (owner: 10Mattflaschen) [16:53:07] 3MediaWiki / 3Redirects: Redirects using relative links do not redirect - 10https://bugzilla.wikimedia.org/72682 (10Glaisher) 5UNCO>3NEW [16:55:36] (03PS1) 10Jack Phoenix: Removed $wgTitle instances from the ContentBlock module [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/169740 [16:55:53] 3MediaWiki / 3Internationalization: Full export of language files - 10https://bugzilla.wikimedia.org/71899#c1 (10Sam Reed (reedy)) Can we get someone to do these? :) [16:56:02] (03CR) 10Jack Phoenix: [C: 032 V: 032] Removed $wgTitle instances from the ContentBlock module [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/169740 (owner: 10Jack Phoenix) [16:57:21] (03PS3) 10MarkAHershberger: Add Content-Length header for job queue requests [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/169734 (https://bugzilla.wikimedia.org/72274) [16:57:54] 3MediaWiki extensions / 3Diff: [HHVM] Tests on Travis are failing (due to PHPUnit version used) - 10https://bugzilla.wikimedia.org/69524#c8 (10Jeroen De Dauw) Unless there are breaking changes we made for HHVM support, I suggest be backport the changes onto the 1.x branch and do a 1.1.0 release rather than a... [16:58:28] (03PS1) 10Jack Phoenix: Move clearPhalanxCache.php into the maintenance/ dir for it is a maintenance script [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/169741 [16:58:56] (03CR) 10Jack Phoenix: [C: 032 V: 032] Move clearPhalanxCache.php into the maintenance/ dir for it is a maintenance script [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/169741 (owner: 10Jack Phoenix) [16:59:15] (03CR) 10EBernhardson: [C: 032] Include workflow title in TopicList API response [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169636 (https://bugzilla.wikimedia.org/72655) (owner: 10Mattflaschen) [16:59:57] (03Merged) 10jenkins-bot: Include workflow title in TopicList API response [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169636 (https://bugzilla.wikimedia.org/72655) (owner: 10Mattflaschen) [17:00:08] (03CR) 10Aaron Schulz: [C: 032] Remove edit token from conflict detection [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/169593 (https://bugzilla.wikimedia.org/72634) (owner: 10CSteipp) [17:00:20] (03PS1) 10Jack Phoenix: ...and fix paths in the clearPhalanxCache.php maintenance script [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/169743 [17:00:26] (03Merged) 10jenkins-bot: Remove edit token from conflict detection [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/169593 (https://bugzilla.wikimedia.org/72634) (owner: 10CSteipp) [17:00:34] (03CR) 10Jack Phoenix: [C: 032 V: 032] ...and fix paths in the clearPhalanxCache.php maintenance script [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/169743 (owner: 10Jack Phoenix) [17:01:53] 3MediaWiki / 3Internationalization: Full export of language files - 10https://bugzilla.wikimedia.org/71899#c2 (10Nemo) (In reply to Sam Reed (reedy) from comment #1) > Can we get someone to do these? :) Raymond, interested? [17:02:19] (03PS1) 10Jack Phoenix: Remove include() calls from rebuildPhalanxCache.php and add a statement to indicate that everything has been done [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/169745 [17:02:35] (03CR) 10Jack Phoenix: [C: 032 V: 032] Remove include() calls from rebuildPhalanxCache.php and add a statement to indicate that everything has been done [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/169745 (owner: 10Jack Phoenix) [17:06:53] 3Wikimedia / 3Bugzilla: Remove Alolita from default CCs - 10https://bugzilla.wikimedia.org/72617#c12 (10Alolita Sharma) 5RESO/INV>3RESO/FIX Thanks so much Andre! I really appreciate it :) Will ping to be added to other components. [17:07:53] 3MediaWiki / 3Special pages: Special:MovePage disappeared from tet.wikipedia - 10https://bugzilla.wikimedia.org/70686#c35 (10Mark A. Hershberger) fix was was reverted [17:12:58] (03CR) 10MarkTraceur: "...wait, what happened to PS2" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/168659 (owner: 10MarkTraceur) [17:13:11] (03CR) 10MarkTraceur: "Oh, paranoia, the core patch changed." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/168659 (owner: 10MarkTraceur) [17:13:29] (03PS1) 10Southparkfan: Fix spelling mistake: s/databses/database [core] - 10https://gerrit.wikimedia.org/r/169747 [17:13:50] (03PS1) 10Reedy: Fix typo in sql comment [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/169748 [17:14:32] (03CR) 10Reedy: [C: 032] Fix spelling mistake: s/databses/database [core] - 10https://gerrit.wikimedia.org/r/169747 (owner: 10Southparkfan) [17:14:50] that was fast - thanks :) [17:15:42] (03PS1) 10Jack Phoenix: i18n is a thing and not taking it into account can lead into "fun" bugs [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/169749 [17:16:13] (03CR) 10Jack Phoenix: [C: 032 V: 032] i18n is a thing and not taking it into account can lead into "fun" bugs [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/169749 (owner: 10Jack Phoenix) [17:16:52] (03PS4) 10MarkAHershberger: Add Content-Length header for job queue requests [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/169734 (https://bugzilla.wikimedia.org/72274) [17:18:37] (03PS4) 10Cmcmahon: QA: make watch test maintainable and readable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168420 [17:19:17] (03CR) 10SG: "Per IRC" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169494 (owner: 10SG) [17:20:30] (03Merged) 10jenkins-bot: Fix spelling mistake: s/databses/database [core] - 10https://gerrit.wikimedia.org/r/169747 (owner: 10Southparkfan) [17:20:50] (03CR) 10Cmcmahon: "Zeljko, I think you missed that the "unless" uses the |page| two times in the two steps that look like" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168420 (owner: 10Cmcmahon) [17:23:02] (03PS1) 10Florianschmidtwelzow: Remove whitespace at the end of lines [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/169751 [17:23:09] (03PS1) 10MarkAHershberger: Bump version number [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/169752 [17:25:05] (03CR) 10Mglaser: [C: 032 V: 032] Add Content-Length header for job queue requests [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/169734 (https://bugzilla.wikimedia.org/72274) (owner: 10MarkAHershberger) [17:25:28] 3Wikimedia / 3Language setup: Create Wikipedia Maithili - 10https://bugzilla.wikimedia.org/72346#c17 (10Glaisher) 5PATC>3ASSI Siebrand imported the namespace names' translations to MW core earlier this week. I'll try to get a patch up for configurations today. [17:25:36] 3MediaWiki extensions / 3BounceHandler: Rename br_user column - 10https://bugzilla.wikimedia.org/72683 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3normal a:3None br_user VARCHAR(255) NOT NULL, -- Email Id of failing recipient This column name/text are a bit confusing. It should probably be rena... [17:25:37] 3MediaWiki extensions / 3BounceHandler: Inconsistent returns in BounceHandlerHooks::onVERPAddressGenerate() - 10https://bugzilla.wikimedia.org/72684 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3normal a:3None Only the else block returns anything. Should self::generateVerp be prepended with a return? (thou... [17:25:38] 3MediaWiki / 3Internationalization: Full export of language files - 10https://bugzilla.wikimedia.org/71899#c3 (10Niklas Laxström) 5NEW>3RESO/FIX This was done on Monday. [17:25:40] 3MediaWiki extensions / 3BounceHandler: ApiBounceHandler improvements - 10https://bugzilla.wikimedia.org/72685 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3normal a:3None The module should probably be marked internal. It should probably also use proper api parameter handling rather than: $email = $this->g... [17:25:49] (03CR) 10Mglaser: [C: 032 V: 032] Bump version number [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/169752 (owner: 10MarkAHershberger) [17:26:55] 3MediaWiki extensions / 3BounceHandler: BounceHandlerActions::handleFailingRecipient() SQL query - 10https://bugzilla.wikimedia.org/72686 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3normal a:3None array( 'br_user'=> $originalEmail, 'br_timestamp' >= $bounceValidPeriod... [17:28:12] (03PS1) 10Reedy: Fix return type/comment hint [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/169753 [17:28:47] (03CR) 10Gilles: [C: 032] Add more detailed upload stash error messages [core] - 10https://gerrit.wikimedia.org/r/168649 (owner: 10MarkTraceur) [17:29:07] (03CR) 10Gilles: [C: 032] Add more detailed stash error messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/168659 (owner: 10MarkTraceur) [17:29:38] (03PS1) 10MarkAHershberger: bump version number & update release notes [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/169754 [17:30:10] 3MediaWiki extensions / 3BounceHandler: Inconsistent returns in BounceHandler - 10https://bugzilla.wikimedia.org/72684#c1 (10Sam Reed (reedy)) (In reply to Sam Reed (reedy) from comment #0) > Only the else block returns anything. > > Should self::generateVerp be prepended with a return? (though, I note that... [17:31:08] 3MediaWiki extensions / 3BounceHandler: Inconsistent returns in BounceHandler - 10https://bugzilla.wikimedia.org/72684#c2 (10Sam Reed (reedy)) ProcessBounceEmails::getOriginalEmail() too [17:31:49] legoktm : I am about to merge your backport here: https://gerrit.wikimedia.org/r/#/c/162923/ [17:32:16] legoktm : but this has a revert history I do not understand: https://gerrit.wikimedia.org/r/#/c/163957/ [17:32:20] (03CR) 10Dduvall: [C: 04-1] QA: make watch test maintainable and readable (035 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168420 (owner: 10Cmcmahon) [17:32:24] so is it morged or reverted? [17:32:31] *merged [17:32:53] (03CR) 10Aaron Schulz: [C: 031] "Maybe the default timeout could be 10 sec?" (031 comment) [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/169653 (https://bugzilla.wikimedia.org/70585) (owner: 10Legoktm) [17:35:30] 3Wikimedia / 3Extension setup: Review and deploy BounceHandler extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/69019 (10Sam Reed (reedy)) [17:35:30] 3MediaWiki extensions / 3BounceHandler: Rename br_user column - 10https://bugzilla.wikimedia.org/72683 (10Sam Reed (reedy)) [17:35:30] 3MediaWiki extensions / 3BounceHandler: ApiBounceHandler improvements - 10https://bugzilla.wikimedia.org/72685 (10Sam Reed (reedy)) [17:35:30] 3MediaWiki extensions / 3BounceHandler: Inconsistent returns in BounceHandler - 10https://bugzilla.wikimedia.org/72684 (10Sam Reed (reedy)) [17:35:31] 3MediaWiki extensions / 3BounceHandler: BounceHandlerActions::handleFailingRecipient() SQL query - 10https://bugzilla.wikimedia.org/72686 (10Sam Reed (reedy)) [17:35:32] 3Wikimedia / 3Extension setup: Review and deploy BounceHandler extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/69019 (10Sam Reed (reedy)) [17:35:33] 3Wikimedia / 3Extension setup: Review and deploy BounceHandler extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/69019 (10Sam Reed (reedy)) [17:35:38] 3Wikimedia / 3Extension setup: Review and deploy BounceHandler extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/69019 (10Sam Reed (reedy)) [17:39:25] (03CR) 10Aaron Schulz: [C: 032] "Note: the LB method getConnectionRef() can be useful in cases like this." [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/169654 (https://bugzilla.wikimedia.org/69100) (owner: 1001tonythomas) [17:39:42] (03CR) 10Aaron Schulz: [C: 032] Fix typo in sql comment [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/169748 (owner: 10Reedy) [17:40:26] (03PS5) 10Cmcmahon: QA: make watch test maintainable and readable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168420 [17:40:55] (03Merged) 10jenkins-bot: Add more detailed upload stash error messages [core] - 10https://gerrit.wikimedia.org/r/168649 (owner: 10MarkTraceur) [17:40:57] (03Merged) 10jenkins-bot: Add more detailed stash error messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/168659 (owner: 10MarkTraceur) [17:41:00] (03Merged) 10jenkins-bot: Various performance fixed for the BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/169654 (https://bugzilla.wikimedia.org/69100) (owner: 1001tonythomas) [17:41:12] (03CR) 10Aaron Schulz: [C: 032] Fix return type/comment hint [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/169753 (owner: 10Reedy) [17:41:14] (03Merged) 10jenkins-bot: Fix typo in sql comment [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/169748 (owner: 10Reedy) [17:41:44] (03Merged) 10jenkins-bot: Fix return type/comment hint [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/169753 (owner: 10Reedy) [17:41:57] (03PS1) 10MarkAHershberger: bump version number for 1.19.21 & update release notes [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/169756 [17:42:08] (03CR) 10Cmcmahon: "that should do it" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168420 (owner: 10Cmcmahon) [17:45:43] (03CR) 10Dduvall: [C: 04-1] "Almost!" (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168420 (owner: 10Cmcmahon) [17:46:04] (03CR) 10Mglaser: [C: 032 V: 032] bump version number for 1.19.21 & update release notes [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/169756 (owner: 10MarkAHershberger) [17:46:41] 3Wikimedia / 3Bugzilla: Please add Reedy to default CC for Wikimedia -> Continuous Integration - 10https://bugzilla.wikimedia.org/72688 (10Greg Grossmeier) 3NEW p:3Unprio s:3normal a:3None :) [17:47:38] (03PS6) 10Cmcmahon: QA: make watch test maintainable and readable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168420 [17:48:04] (03CR) 10Cmcmahon: "heh. two spaces removed" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168420 (owner: 10Cmcmahon) [17:48:43] (03CR) 10Dduvall: [C: 032] QA: make watch test maintainable and readable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168420 (owner: 10Cmcmahon) [17:55:11] (03PS1) 10Jack Phoenix: Database::escapeLike() hasn't existed since MW 1.20... [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/169759 [17:55:23] (03CR) 10Mglaser: [C: 032 V: 032] bump version number & update release notes [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/169754 (owner: 10MarkAHershberger) [17:55:46] (03PS2) 10Reedy: Update GeSHi from upstream [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/150622 (https://bugzilla.wikimedia.org/52509) [17:56:03] (03CR) 10Jack Phoenix: [C: 032] Database::escapeLike() hasn't existed since MW 1.20... [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/169759 (owner: 10Jack Phoenix) [17:56:37] (03PS3) 10Reedy: Update GeSHi from upstream [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/150622 (https://bugzilla.wikimedia.org/52509) [18:00:27] (03Merged) 10jenkins-bot: Database::escapeLike() hasn't existed since MW 1.20... [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/169759 (owner: 10Jack Phoenix) [18:02:03] (03PS1) 10Aaron Schulz: Fixed DB timsestamp range query [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/169760 [18:02:18] (03CR) 10jenkins-bot: [V: 04-1] Fixed DB timsestamp range query [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/169760 (owner: 10Aaron Schulz) [18:03:24] (03PS2) 10Reedy: Fixed DB timsestamp range query [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/169760 (https://bugzilla.wikimedia.org/72686) (owner: 10Aaron Schulz) [18:03:33] (03CR) 10jenkins-bot: [V: 04-1] Fixed DB timsestamp range query [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/169760 (https://bugzilla.wikimedia.org/72686) (owner: 10Aaron Schulz) [18:03:51] heh [18:04:29] 3Wikimedia / 3Language setup: Create Wikipedia Maithili - 10https://bugzilla.wikimedia.org/72346#c19 (10Glaisher) a:3Sam Reed (reedy) Asia/Nepal is not a valid format so I used Asia/Kathmandu (both UTC+5:45). There is an issue with DNS but that is currently being investigated. Except that, there are no is... [18:04:39] 3Wikimedia / 3Bugzilla: Please add Reedy to default CC for Wikimedia -> Continuous Integration - 10https://bugzilla.wikimedia.org/72688#c1 (10Andre Klapper) 5NEW>3RESO/FIX Done [18:04:46] (03CR) 10Reedy: "18:02:17 1) UnSubscribeUserTest::testUnSubscribeUser" [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/169760 (https://bugzilla.wikimedia.org/72686) (owner: 10Aaron Schulz) [18:05:42] awight: Could you tell us what browser you were using, and which page you were editing? [18:05:47] (For both of the VE bugs you just filed) [18:06:38] 3Datasets / 3General/Unknown: mwxml2sql fails for `mediawiki' versions above 1.21; patch posted for review - 10https://bugzilla.wikimedia.org/66663#c8 (10Andre Klapper) That sounds like questions for https://lists.wikimedia.org/mailman/listinfo/wikitech-l instead of this bug report. [18:08:26] (03PS1) 10Jack Phoenix: Demonstratably secure code [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/169761 [18:08:53] 3Datasets / 3General/Unknown: mwxml2sql fails for `mediawiki' versions above 1.21; patch posted for review - 10https://bugzilla.wikimedia.org/66663#c7 (10wp mirror) Dear Sirs, 1) Database Schema Currently, MW 1.25 is being deployed. Can someone tell me if the database schema for MW 1.26+ is known at this t... [18:08:59] (03CR) 10Jack Phoenix: [C: 032] Demonstratably secure code [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/169761 (owner: 10Jack Phoenix) [18:09:06] (03Merged) 10jenkins-bot: Demonstratably secure code [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/169761 (owner: 10Jack Phoenix) [18:10:09] 3Datasets / 3General/Unknown: mwxml2sql fails for `mediawiki' versions above 1.21; patch posted for review - 10https://bugzilla.wikimedia.org/66663#c9 (10Sam Reed (reedy)) (In reply to wp mirror from comment #7) > Dear Sirs, > > 1) Database Schema > > Currently, MW 1.25 is being deployed. Can someone tell... [18:15:09] (03CR) 10Reedy: [C: 031] "Branched. Should be good to be merged now..." [core] - 10https://gerrit.wikimedia.org/r/119941 (owner: 10BryanDavis) [18:15:18] RoanKattouw: sure, I'll add to the bugs [18:15:27] Cool thanks [18:15:48] RoanKattouw: yeah, thanks for jumping on it. I was soo happy to be using VE... then, doc corruption. [18:15:55] awight: You should know better! ;) [18:16:04] (to file a bug report properly that is :P) [18:16:25] :p [18:17:43] RoanKattouw: if you're in SF I can show you. [18:18:02] awight: I am, can I come to your desk once I'm ready? [18:18:15] RoanKattouw: any time [18:18:53] (03CR) 10Aaron Schulz: LocalPageMoveJob: Use MovePage (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/169602 (owner: 10Legoktm) [18:23:21] RoanKattouw: aaargh I can no longer reproduce the bugs [18:25:16] RoanKattouw: I'll go ahead and edit, & will ping you if anything else fun happens [18:25:25] awight: I actually have time right now [18:25:33] Seems like, once the VE is in a corrupted state, all sorts of things fall apart. [18:25:37] If you want me to come over [18:25:39] Oh yes [18:31:20] (03PS1) 10MarkTraceur: Support for message function in confirmCloseWindow [core] - 10https://gerrit.wikimedia.org/r/169772 [18:31:59] (03CR) 10MarkTraceur: "See Iffe106cfc5430aaeb2c56b83316116b2c5dd5835" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151127 (owner: 10MarkTraceur) [18:34:08] (03PS23) 10Legoktm: Use MWLogger logging for legacy logging methods [core] - 10https://gerrit.wikimedia.org/r/119941 (owner: 10BryanDavis) [18:34:17] 3Wikimedia / 3Extension setup: Need security review for WikiGrok extension - 10https://bugzilla.wikimedia.org/72567#c2 (10Chris Steipp) 5NEW>3RESO/FIX I talked through the dataflow and interfaces for this with Kaldari and Max. The mobile team should continue to review each other's code for basic security... [18:46:55] brb -- getting george to bed [18:57:14] hello [18:57:28] (03PS24) 10Legoktm: Use MWLogger logging for legacy logging methods [core] - 10https://gerrit.wikimedia.org/r/119941 (owner: 10BryanDavis) [18:57:40] i submitted a patch some time back which needs reviewing [18:57:52] could someone review it please? [18:58:07] ankita_: You should link to it ;) [18:58:37] Reedy: oh sorry! :) [18:58:37] https://gerrit.wikimedia.org/r/#/c/167231/ [18:58:41] (03CR) 10Legoktm: [C: 032] "Added a @return for a few doc comments, and added release notes." [core] - 10https://gerrit.wikimedia.org/r/119941 (owner: 10BryanDavis) [18:59:16] ankita_: Brian Wolff already left you a comment... [18:59:16] Q170484ktm: \o/ [19:00:17] Reedy: I discussed about that with Brian here on irc and he wasnt sure of what should be done next [19:00:35] I guess having those comments on the revision would help [19:00:51] I'd be inclined to agree that the fancycaptcha css should be moved from core at least [19:03:19] csteipp: see if it worked? https://www.mediawiki.org/w/index.php?title=Special:OAuthListConsumers/view/d35363a3096559d3a7a6a1f6d9b8ddda&name=&publisher=Ragesoss&stage=0 [19:03:47] Reedy: I'll add the irc conversation in the comments there [19:03:57] please [19:04:17] As for your actual change, it might be worth looping in some of the WMF designers to look at it [19:04:35] (03PS25) 10Krinkle: resourceloader: Add support for delivering templates [core] - 10https://gerrit.wikimedia.org/r/167342 (owner: 10Jdlrobson) [19:04:50] (03Merged) 10jenkins-bot: Use MWLogger logging for legacy logging methods [core] - 10https://gerrit.wikimedia.org/r/119941 (owner: 10BryanDavis) [19:05:22] * bd808 does a happy dance for that merge message ^ [19:05:58] (03CR) 10Ankitashukla: " ankita_: On the bug report, I think Reedy said that it probably shouldn't be done the way you're currently doing it" [core] - 10https://gerrit.wikimedia.org/r/167231 (https://bugzilla.wikimedia.org/57821) (owner: 10Ankitashukla) [19:06:41] (03CR) 10Ankitashukla: "^The irc conversation regarding the patch" [core] - 10https://gerrit.wikimedia.org/r/167231 (https://bugzilla.wikimedia.org/57821) (owner: 10Ankitashukla) [19:13:30] Also, I have set up a proposal for OPW. Would it be a good idea to share the link here for community reviews? [19:19:57] (03CR) 10Mattflaschen: "> Basically jon, timo and trevor whom all likely know better than I do have expressed varying levels of displeasure regarding our use of h" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169494 (owner: 10SG) [19:20:18] Anyone able to temporarily my ratelimit for work-related use of Special:EmailUser on Metawiki? [19:20:30] Or have another solution? [19:20:43] A bulk email interface would be preferable... [19:25:22] Hello, I want to start contributing to wikimedia. I'll be glad if someone could guide me [19:25:23] (03PS13) 10MarkTraceur: Make tutorial step a controller and UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 [19:25:46] (03CR) 10MarkTraceur: "Simple rebase, because apparently I'm smarter than Gerrit." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 (owner: 10MarkTraceur) [19:26:32] (03PS4) 10EBernhardson: K2: Timestamps [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169597 [19:26:57] modestguy: Contributing to what exactly? :) [19:27:27] 3Wikimedia / 3General/Unknown: harmonize Wikisource namespaces used by the ProofreadPage extension - 10https://bugzilla.wikimedia.org/72525#c5 (10Sam Reed (reedy)) (In reply to Gerrit Notification Bot from comment #3) > Change 169779 had a related patch set uploaded by Reedy: > Set a default for wgProofreadP... [19:27:58] contributing to this organisation in terms of code [19:28:16] modestguy: To mediawiki? [19:28:40] https://www.mediawiki.org/wiki/Special:MyLanguage/How_to_contribute [19:28:42] 3Wikimedia / 3General/Unknown: harmonize Wikisource namespaces used by the ProofreadPage extension - 10https://bugzilla.wikimedia.org/72525#c6 (10Dereckson) 5PATC>3NEW In this consultation, I note: - the lack of strong support of Tpt, current current maintainer of Proofreadpage - the very weak support of... [19:28:57] 3Wikimedia / 3Extension setup: Deploy WikiGrok extension to test, test2, and en.wiki - 10https://bugzilla.wikimedia.org/72465#c11 (10Ryan Kaldari) Security review completed. Should be ready for deployment now. [19:31:14] bd808: sent a followup email to wikitech-l [19:32:11] (03CR) 10Krinkle: resourceloader: Add support for delivering templates (038 comments) [core] - 10https://gerrit.wikimedia.org/r/167342 (owner: 10Jdlrobson) [19:32:16] (03PS26) 10Krinkle: resourceloader: Add support for delivering templates [core] - 10https://gerrit.wikimedia.org/r/167342 (owner: 10Jdlrobson) [19:32:19] (03CR) 10Krinkle: [C: 031] "Addressed inline comments." [core] - 10https://gerrit.wikimedia.org/r/167342 (owner: 10Jdlrobson) [19:38:18] (03PS10) 10Cicalese: added CSS selector config variable, formatting [extensions/TitleIcon] - 10https://gerrit.wikimedia.org/r/168019 [19:44:37] Q170484ktm: Something is not right with my patch I think. I'm not seeing any logs from beta now at all. :/ [19:45:53] "#012Warning: timed out after 0.25 seconds when connecting to 10.68.16.146 [110]: Connection timed out" in hhvm error logs [19:48:04] (03PS7) 10MarkTraceur: Move setSkipTutorialPreference to Tutorial class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153413 [19:51:58] 3MediaWiki / 3JobQueue: Job queue not running (HTTP 411) due to missing Content-Length: header - 10https://bugzilla.wikimedia.org/72274#c13 (10Patrick Westerhoff) Now that this has been integrated into REL1_23, should I go ahead and backport it to REL1_24 too? [19:52:37] uhoh :/ [19:54:18] bd808: in logstash or in the filesystem? [19:54:53] Q170484ktm: both. logstash is fed by log2udp [19:55:07] hm. [19:55:10] But I'm not seeing errors on the hhvm hosts directly [19:56:07] (03CR) 10Umherirrender: "banana-checker seems not to work or need config maintenance when a new en.json/qqq.json is added, because there was no fail on Iba47043fb3" [core] - 10https://gerrit.wikimedia.org/r/169579 (https://bugzilla.wikimedia.org/35942) (owner: 10Umherirrender) [19:58:00] 3MediaWiki / 3Special pages: Database query error on [[Special:UnconnectedPages]] - 10https://bugzilla.wikimedia.org/72696 (10Helder) 3NEW p:3Unprio s:3normal a:3None In the URL above, I got this error instead of the list I was expecting: --------------------------------------------------------------... [19:59:06] (03PS1) 10Paladox: Adding files [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/169787 [20:00:01] debug toolbar works... [20:00:20] (03CR) 10Paladox: [C: 031] "@Siebrand Please could I have some help in converting to i18n please. because I doint know how to do and doint know how to do it on a wind" [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/169787 (owner: 10Paladox) [20:03:43] (03PS1) 10Smuggli: Improved Vector skin support [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/169790 [20:05:03] (03CR) 10Jforrester: "includes/api/i18n/* are not tested for in the test configuration. Are they new?" [core] - 10https://gerrit.wikimedia.org/r/169579 (https://bugzilla.wikimedia.org/35942) (owner: 10Umherirrender) [20:05:21] James_F: ~2 weeks old. [20:06:01] * Q170484ktm clicks [20:07:36] (03PS1) 10Jforrester: test: Check banana status for includes/api/i18n/* too [core] - 10https://gerrit.wikimedia.org/r/169791 [20:07:53] Q170484ktm: Well, that'd be the problem. Who merged untested code? :-( [20:08:10] Q170484ktm: +2 https://gerrit.wikimedia.org/r/169791 and it'll be covered. [20:08:14] why doesn't it just read from $wgMessageDirs? [20:08:31] Q170484ktm: You're asking why JavaScript doesn't read a PHP variable? [20:08:47] Well, I'd then ask why we're using JS to test PHP code. [20:08:53] We're not testing PHP code. [20:08:59] We're testing JSON files with JS code. [20:09:04] Which feels eminently sensible. [20:09:08] $wgMessageDirs is set in PHP :) [20:09:22] For one context, yes. [20:09:36] I think using a phpunit test is a better idea. [20:09:45] (03CR) 10Aaron Schulz: [C: 04-1] LocalPageMoveJob: Use MovePage [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/169602 (owner: 10Legoktm) [20:09:47] Well, forking efforts into PHP-land is sad. [20:09:59] Because a bunch of our code doesn't exist in PHP-land, and needs this tested. [20:11:27] (03CR) 10Jforrester: "Fixed in I9244130e." [core] - 10https://gerrit.wikimedia.org/r/169579 (https://bugzilla.wikimedia.org/35942) (owner: 10Umherirrender) [20:14:23] bd808: I set $wgDebugLogFile to a udp port, and it's working fine for me. [20:14:59] (03PS11) 10Cicalese: added CSS selector config variable, formatting [extensions/TitleIcon] - 10https://gerrit.wikimedia.org/r/168019 [20:16:22] (03CR) 10Legoktm: [C: 032] test: Check banana status for includes/api/i18n/* too [core] - 10https://gerrit.wikimedia.org/r/169791 (owner: 10Jforrester) [20:17:41] lestaty: Thanks. [20:17:48] Bah, sorry, mis-ping. [20:17:51] Q170484ktm: Thanks. [20:18:35] :P [20:18:39] (03PS5) 10MarkTraceur: Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 [20:19:03] (03CR) 10Legoktm: [C: 031] "This makes sense to me, especially since it'll work for extensions without too much additional setup. Having extra test coverage for somet" [core] - 10https://gerrit.wikimedia.org/r/169579 (https://bugzilla.wikimedia.org/35942) (owner: 10Umherirrender) [20:19:13] (03CR) 10jenkins-bot: [V: 04-1] Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 (owner: 10MarkTraceur) [20:19:57] Q170484ktm: It's worked in local testing for me too, but deployment-bastion:/data/project/logs is sadly empty [20:20:03] (03CR) 10Jforrester: [C: 04-2] "Regardless of the sanity of re-implementing established testing pipelines, we don't add failing tests to 300 repos and then expect people " [core] - 10https://gerrit.wikimedia.org/r/169579 (https://bugzilla.wikimedia.org/35942) (owner: 10Umherirrender) [20:20:54] James_F: Did you actually test against 300 repos, or just an estimate? [20:21:22] Q170484ktm: Estimation based on experience trying to roll this out to other repos. [20:21:34] Okay. [20:21:36] It's ~ 3 hours work per repo to roll it out, hence the slow process. [20:22:04] And new voting tests are assumed failing until proven otherwise, not the other way around, in CI. [20:22:21] The fact that it takes 3 hours to set this up for a repo sounds like an issue. [20:22:28] (03Merged) 10jenkins-bot: test: Check banana status for includes/api/i18n/* too [core] - 10https://gerrit.wikimedia.org/r/169791 (owner: 10Jforrester) [20:22:31] It takes 5 minutes to set up. [20:22:40] It takes 3 hours to fix the issues flagged. [20:22:52] Sadly, i18n quality is generally very low. [20:22:55] (03PS6) 10MarkTraceur: Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 [20:23:11] I had to sit with marktraceur just to work out qqqs for UploadWizard, for example. [20:23:16] is this about missing qqq only? [20:23:21] Yeah. [20:23:25] Missing or blank qqq. [20:23:34] yep, it's very hard to get devs pay attention to messages [20:23:46] (03PS1) 10Pwirth: Multi select list: Small css fix [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/169793 [20:23:46] Just missing, not blank. [20:23:47] Q170484ktm: Core had ~ 1000 missing qqqs before we started on it. [20:23:58] heck I myself often fail to add qqq [20:24:12] * James_F tsks Nikerabbit. :-) [20:24:17] but if you can get it enforced then it's likely to get done [20:24:21] * James_F nods. [20:24:34] I would make it start out as not failing, but only reporting [20:24:35] Definitely, adding it to all repos is a good piece of work to take up. [20:24:40] maybe php notice [20:24:46] Erhm... is there an acceptable way to unthrottle my Special:EmailUser usage temporarily? [20:25:07] awight: Sure, just give yourself noratelimit of some way [20:25:12] James_F: just wondering, could these be code-in tasks? [20:25:16] some way = some group [20:25:56] Nikerabbit: Hmm. Possibly. Adding an npm pipeline to a repo is easy once you know how, but… could be a bit hard? [20:26:14] 3MediaWiki / 3Special pages: Special:MovePage disappeared from tet.wikipedia - 10https://bugzilla.wikimedia.org/70686#c36 (10Kunal Mehta (Legoktm)) (In reply to Mark A. Hershberger from comment #35) > fix was was reverted Did you read the bug? It was reverted and then restored. [20:26:32] James_F: hard to add qqq? possible [20:26:43] 3MediaWiki / 3Special pages: Special:MovePage disappeared from tet.wikipedia - 10https://bugzilla.wikimedia.org/70686#c37 (10Kunal Mehta (Legoktm)) (In reply to Kunal Mehta (Legoktm) from comment #36) > (In reply to Mark A. Hershberger from comment #35) > > fix was was reverted > > Did you read the bug? It... [20:26:44] If it's not hard, Shirayuki has already done it ;) [20:26:51] (03CR) 10Umherirrender: "@Legoktm: It will also work for developer without additional setup" [core] - 10https://gerrit.wikimedia.org/r/169579 (https://bugzilla.wikimedia.org/35942) (owner: 10Umherirrender) [20:27:11] (03PS12) 10Cicalese: added CSS selector config variable, formatting [extensions/TitleIcon] - 10https://gerrit.wikimedia.org/r/168019 [20:27:20] Nikerabbit: It's easy to add qqqs if you know the code. [20:28:06] Nikerabbit: But understanding grunt and CI enough to add a Gruntfile.js and related items to a repo, let alone getting it passing, then adding it to jenkins to make it run, then once it passes making it voting, is not too easy. [20:28:27] but what task doesn't require understanding code? [20:28:31] So lets not require people to do that. [20:28:37] And just have a phpunit test for it. [20:29:29] <^d> +1 [20:29:31] Nikerabbit: Coding style fixes? [20:29:39] Q170484ktm: :-P [20:29:50] Just to be clear, the current interim conclusion is that nothing in this area is suitable for Google Code-In, correct? [20:30:19] Because I'm available to mentor stuff in GCI again but I didn't have any qqq task in my plans. [20:30:59] I'm running a script right now to figure out how many qqq we're missing. [20:31:00] (03CR) 10Umherirrender: "Along this discussion the status of bug 35942 seems wrong. Someone with know how should try to fix bug 64045, at least for wmf deployed re" [core] - 10https://gerrit.wikimedia.org/r/169579 (https://bugzilla.wikimedia.org/35942) (owner: 10Umherirrender) [20:31:51] Q170484ktm: you know that special:languagestats already says, right? [20:32:00] oh, really? [20:32:12] https://translatewiki.net/wiki/Special:LanguageStats/qqq [20:32:14] (03PS6) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [20:32:21] 1 213 missing [20:32:36] That's what Shirayuki uses, I think :) [20:32:55] (03CR) 10jenkins-bot: [V: 04-1] Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 (owner: 10MarkTraceur) [20:32:57] ooh, that's neat. [20:33:01] 94% aint bad [20:33:31] all core is done though? [20:33:34] There is some approximation in that number but not so important [20:33:43] Reedy: You're welcome. :-) [20:34:13] 3MediaWiki / 3JobQueue: Job queue not running (HTTP 411) due to missing Content-Length: header - 10https://bugzilla.wikimedia.org/72274#c14 (10Mark A. Hershberger) (In reply to Patrick Westerhoff from comment #13) > Now that this has been integrated into REL1_23, should I go ahead and > backport it to REL1_2... [20:35:51] ^d: can you help me with getting the right access to the mediawiki/selenium repo? i need to delete a remote branch that i created from the wrong ref yesterday [20:36:28] <^d> What's your gerrit name? [20:36:55] hoo|away: aha, thanks for the tip! [20:36:56] (03PS7) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [20:36:59] ^d: Dduvall [20:37:02] (03PS1) 10Cscott: Don't create pipes for `P.spawn` by default. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/169795 [20:37:04] (03PS1) 10Cscott: Update dependencies. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/169796 [20:37:11] <^d> marxarelli: {{done}} [20:37:12] (03PS1) 10Cscott: Update dependencies. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/169797 [20:37:14] (03PS1) 10Cscott: Add `/_version` API endpoint for verifying the running version of the service. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/169798 [20:37:55] ^d: gracias! [20:37:57] (03CR) 10Krinkle: [C: 031] resourceloader: Add support for delivering templates [core] - 10https://gerrit.wikimedia.org/r/167342 (owner: 10Jdlrobson) [20:38:32] <^d> marxarelli: you're welcome! [20:45:14] * anomie gets ready to make grrrit-wm flood the channel [20:45:35] what're you doing? [20:45:50] Submitting patches to add API help i18n to 49 extensions [20:46:00] ah [20:46:05] :>> [20:46:07] (03CR) 10Jdlrobson: [C: 031] resourceloader: Add support for delivering templates [core] - 10https://gerrit.wikimedia.org/r/167342 (owner: 10Jdlrobson) [20:46:13] (03PS1) 10Anomie: Add i18n for API module help [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/169801 [20:46:16] (03PS1) 10Anomie: Add i18n for API module help [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/169802 [20:46:27] 3MediaWiki / 3API: commonmetadata and extmetadata in imageinfo cannot handle deep arrays returned by File::getMetadata() - 10https://bugzilla.wikimedia.org/72652 (10Andre Klapper) p:5Unprio>3Normal [20:46:57] 3MediaWiki / 3Categories: sorting in category: B before A - 10https://bugzilla.wikimedia.org/72661 (10Andre Klapper) p:5Unprio>3High [20:47:31] (03PS1) 10Anomie: Add i18n for API module help [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/169803 [20:47:33] (03PS1) 10Anomie: Add i18n for API module help [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/169804 [20:47:35] anomie: do you have a script for converting them? [20:47:37] (03PS1) 10Anomie: Add i18n for API module help [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/169806 [20:47:39] (03PS1) 10Anomie: Add i18n for API module help [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/169807 [20:47:41] (03PS1) 10Anomie: Add i18n for API module help [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/169808 [20:47:43] (03PS1) 10Anomie: Add i18n for API module help [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/169809 [20:47:51] (03PS1) 10Anomie: Add i18n for API module help [extensions/Echo] - 10https://gerrit.wikimedia.org/r/169813 [20:47:54] (03PS1) 10Anomie: Add i18n for API module help [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/169814 [20:47:57] (03PS1) 10Anomie: Add i18n for API module help [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/169815 [20:47:59] (03PS1) 10Anomie: Add i18n for API module help [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/169816 [20:48:01] (03PS1) 10Anomie: Add i18n for API module help [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/169817 [20:48:03] (03PS1) 10Anomie: Add i18n for API module help [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/169818 [20:48:05] (03PS1) 10Anomie: Add i18n for API module help [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169819 [20:48:08] (03PS1) 10Anomie: Add i18n for API module help [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/169820 [20:48:10] (03PS1) 10Anomie: Add i18n for API module help [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/169821 [20:48:12] (03PS1) 10Anomie: Add i18n for API module help [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/169822 [20:48:14] (03PS1) 10Anomie: Add i18n for API module help [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/169823 [20:48:18] (03PS1) 10Anomie: Add i18n for API module help [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/169825 [20:48:20] (03PS1) 10Anomie: Add i18n for API module help [extensions/MarkAsHelpful] - 10https://gerrit.wikimedia.org/r/169826 [20:48:22] (03PS1) 10Anomie: Add i18n for API module help [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/169827 [20:48:26] (03PS1) 10Anomie: Add i18n for API module help [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/169829 [20:48:28] (03PS1) 10Anomie: Add i18n for API module help [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/169830 [20:48:30] (03PS1) 10Anomie: Add i18n for API module help [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/169831 [20:48:30] anomie: Wow. [20:48:32] (03PS1) 10Anomie: Add i18n for API module help [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/169832 [20:48:35] (03PS1) 10Anomie: Add i18n for API module help [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/169833 [20:48:37] (03PS1) 10Anomie: Add i18n for API module help [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/169834 [20:48:39] (03PS1) 10Anomie: Add i18n for API module help [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/169835 [20:48:41] (03PS1) 10Anomie: Add i18n for API module help [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/169836 [20:48:44] (03PS1) 10Anomie: Add i18n for API module help [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/169837 [20:48:45] Q170484ktm: I made a script that will extract the existing messages using action=paraminfo and dump a snipped for en.json and qqq.json. Then I had to find those files and put them in, and update the classes themselves slightly. [20:48:46] (03PS1) 10Anomie: Add i18n for API module help [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/169838 [20:48:48] (03PS1) 10Anomie: Add i18n for API module help [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/169839 [20:48:51] (03PS1) 10Anomie: Add i18n for API module help [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/169840 [20:48:54] (03PS1) 10Anomie: Add i18n for API module help [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/169841 [20:49:00] (03PS1) 10Anomie: Add i18n for API module help [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/169844 [20:49:03] (03PS1) 10Anomie: Add i18n for API module help [extensions/UserDailyContribs] - 10https://gerrit.wikimedia.org/r/169845 [20:49:07] (03PS1) 10Anomie: Add i18n for API module help [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/169847 [20:49:45] Q170484ktm: And then I ran a few bash one-liners over things to make sure I didn't get the en and qqq mismatched, and so on. [20:50:27] want to publish those somewhere for non-WMF extensions? or are you planning to do those as well? :) [20:50:47] Q170484ktm: I could, sure. [20:51:12] (03PS1) 10MarkTraceur: Remove default date population with "now" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/169858 (https://bugzilla.wikimedia.org/53605) [20:51:38] Q170484ktm: Well... except for the part where the interesting bit uses AnomieBOT. So I don't know how useful it'll really be. [20:52:13] anomie: Argh. i18n files are meant to be in alphabetical order, aren't they? [20:52:16] ha :P [20:52:23] (03CR) 10Krinkle: [C: 032] resourceloader: Add support for delivering templates [core] - 10https://gerrit.wikimedia.org/r/167342 (owner: 10Jdlrobson) [20:52:29] James_F: I've never heard that one. [20:52:30] (03PS2) 10Krinkle: Use HTML templates for captcha instead of string stitching [core] - 10https://gerrit.wikimedia.org/r/168123 (owner: 10Jdlrobson) [20:52:41] anomie: It's the cause of several -1s in the front-end universe. [20:53:03] James_F: Not really, I typically keep them grouped by how they're used in the code. [20:53:04] (Maybe we should write a test in banana-checker for it.) [20:53:05] James_F: Feel free to pipe it through sort and submit a new patchset ;) [20:53:07] (03CR) 10Krinkle: [C: 04-1] Use HTML templates for captcha instead of string stitching (031 comment) [core] - 10https://gerrit.wikimedia.org/r/168123 (owner: 10Jdlrobson) [20:53:18] anomie: Sure. [20:53:24] it's not widely adopted practise [20:53:29] Ah. [20:53:43] We do it mostly for i18n comparability. [20:53:48] 3Wikimedia / 3Deployment systems: sa translation not showing up in interface - 10https://bugzilla.wikimedia.org/65334 (10Nemo) [20:53:48] 3MediaWiki extensions / 3CentralAuth: GlobalRename: optionally create a dummy account at the old name after the rename - 10https://bugzilla.wikimedia.org/70379#c1 (10DerHexer) Very useful for stewards, indeed. [20:54:26] Krinkle: Woo. [20:55:04] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/169820 (owner: 10Anomie) [20:55:07] (03CR) 10jenkins-bot: [V: 04-1] Add i18n for API module help [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/169839 (owner: 10Anomie) [20:55:31] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/169832 (owner: 10Anomie) [20:55:51] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/169831 (owner: 10Anomie) [20:56:04] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/169817 (owner: 10Anomie) [20:56:10] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/169827 (owner: 10Anomie) [20:56:23] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/169808 (owner: 10Anomie) [20:56:29] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/169830 (owner: 10Anomie) [20:56:35] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/169825 (owner: 10Anomie) [20:56:41] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/169822 (owner: 10Anomie) [20:56:47] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/169821 (owner: 10Anomie) [20:56:53] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/169815 (owner: 10Anomie) [20:57:00] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/169806 (owner: 10Anomie) [20:57:04] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/169803 (owner: 10Anomie) [20:57:10] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169819 (owner: 10Anomie) [20:57:16] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/169816 (owner: 10Anomie) [20:57:22] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/169814 (owner: 10Anomie) [20:57:27] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/169813 (owner: 10Anomie) [20:57:44] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/169847 (owner: 10Anomie) [20:57:50] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/UserDailyContribs] - 10https://gerrit.wikimedia.org/r/169845 (owner: 10Anomie) [20:57:57] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/169844 (owner: 10Anomie) [20:58:14] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/169841 (owner: 10Anomie) [20:58:20] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/169840 (owner: 10Anomie) [20:58:25] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/169839 (owner: 10Anomie) [20:58:30] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/169838 (owner: 10Anomie) [20:58:37] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/169837 (owner: 10Anomie) [20:58:40] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/169835 (owner: 10Anomie) [20:58:46] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/169834 (owner: 10Anomie) [20:58:50] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/169833 (owner: 10Anomie) [20:59:00] (03Merged) 10jenkins-bot: resourceloader: Add support for delivering templates [core] - 10https://gerrit.wikimedia.org/r/167342 (owner: 10Jdlrobson) [20:59:07] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/169809 (owner: 10Anomie) [20:59:13] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/169807 (owner: 10Anomie) [20:59:19] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/169804 (owner: 10Anomie) [20:59:24] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/169829 (owner: 10Anomie) [20:59:29] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/MarkAsHelpful] - 10https://gerrit.wikimedia.org/r/169826 (owner: 10Anomie) [20:59:35] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/169823 (owner: 10Anomie) [20:59:40] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/169818 (owner: 10Anomie) [20:59:51] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/169802 (owner: 10Anomie) [20:59:57] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/169801 (owner: 10Anomie) [21:00:09] (03PS1) 10Chad: Remove repo to be deleted [extensions] - 10https://gerrit.wikimedia.org/r/169864 [21:00:20] (03CR) 10Chad: [C: 032 V: 032] Remove repo to be deleted [extensions] - 10https://gerrit.wikimedia.org/r/169864 (owner: 10Chad) [21:01:37] (03CR) 10Jforrester: [C: 04-1] Add i18n for API module help (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/169837 (owner: 10Anomie) [21:02:02] (03CR) 10Jdlrobson: "recheck" [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/168434 (owner: 10Jdlrobson) [21:02:05] (03PS3) 10Jdlrobson: Use core template compiler for Handlebars [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/168434 [21:02:12] (03CR) 10Jforrester: [C: 04-1] "Sort of i18n files, otherwise G2G." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/169803 (owner: 10Anomie) [21:02:25] (03CR) 10jenkins-bot: [V: 04-1] Use HTML templates for captcha instead of string stitching [core] - 10https://gerrit.wikimedia.org/r/168123 (owner: 10Jdlrobson) [21:02:31] (03PS5) 10Jdlrobson: Switch to templates in core. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168317 [21:02:49] (03CR) 10jenkins-bot: [V: 04-1] Use core template compiler for Handlebars [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/168434 (owner: 10Jdlrobson) [21:03:24] (03CR) 10jenkins-bot: [V: 04-1] Switch to templates in core. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168317 (owner: 10Jdlrobson) [21:04:44] hi [21:04:54] (03PS4) 10Jdlrobson: Use core template compiler for Handlebars [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/168434 [21:05:12] hi [21:05:32] if mike or anyone of the release team is around: i think the subject line of your latest release announecement is misleading in that it suggests security impact. [21:05:33] (03PS5) 10Jdlrobson: Use core template compiler for Handlebars [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/168434 [21:05:57] ... while the mail body doesn't [21:06:06] hexmode: ^ [21:06:18] (03PS6) 10Jdlrobson: Switch to using template mechanism provided by core. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168317 [21:07:00] (03CR) 10Anomie: "Note the Jenkins failure seems to be due to something in Flow rather than in this patch." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/169839 (owner: 10Anomie) [21:07:11] (03CR) 10jenkins-bot: [V: 04-1] Switch to using template mechanism provided by core. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168317 (owner: 10Jdlrobson) [21:07:19] Deskana: can you see if the OAuth fix worked? https://www.mediawiki.org/w/index.php?title=Special:OAuthListConsumers/view/d35363a3096559d3a7a6a1f6d9b8ddda&name=&publisher=Ragesoss&stage=-1 [21:08:12] (03Abandoned) 10Krinkle: Tests: Compare en.json and qqq.json message keys [core] - 10https://gerrit.wikimedia.org/r/169579 (https://bugzilla.wikimedia.org/35942) (owner: 10Umherirrender) [21:08:43] (03PS1) 10Cmcmahon: QA: update for newest Hide element [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169909 [21:09:31] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169909 (owner: 10Cmcmahon) [21:09:53] (03CR) 10Anomie: Add i18n for API module help (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/169837 (owner: 10Anomie) [21:10:23] (03Merged) 10jenkins-bot: QA: update for newest Hide element [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169909 (owner: 10Cmcmahon) [21:10:27] 3MediaWiki / 3Unit tests: Implement unit test to compare en and qqq localisation files - 10https://bugzilla.wikimedia.org/35942#c12 (10Umherirrender) 5PATC>3RESO/FIX banana-checker running since some weeks or month [21:10:47] (03PS6) 10Jdlrobson: Use core template compiler for Handlebars [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/168434 [21:12:04] (03PS7) 10Jdlrobson: Switch to using template mechanism provided by core. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168317 [21:12:49] (03CR) 10jenkins-bot: [V: 04-1] Switch to using template mechanism provided by core. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168317 (owner: 10Jdlrobson) [21:16:01] (03PS6) 10Mooeypoo: [Just WIP] Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 [21:16:04] (03CR) 10jenkins-bot: [V: 04-1] [Just WIP] Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo) [21:18:49] (03PS1) 10Gergő Tisza: Cast UploadWizardErrorFlowEvent.message to string [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/169919 [21:18:56] (03PS1) 10Cmcmahon: QA: use newest watch locators, simplify [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169920 [21:19:46] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169920 (owner: 10Cmcmahon) [21:19:58] 3MediaWiki extensions / 3OAuth: Attempting to approve some OAuth consumers results in error - 10https://bugzilla.wikimedia.org/72634#c4 (10Sage Ross) Now that the fix is merged and deployed, can someone approve my apps to see if it worked? :) [21:20:29] (03CR) 10jenkins-bot: [V: 04-1] QA: use newest watch locators, simplify [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169920 (owner: 10Cmcmahon) [21:20:46] (03PS1) 10Yurik: Updated ZeroPortal to master [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/169922 [21:20:57] ^d, ^ [21:21:32] yurikR: you realise wmf6 was branched barely a few hours ago? [21:21:34] (03PS1) 10Yurik: Updated ZeroPortal to master [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169923 [21:21:44] ^d, ^ [21:21:58] Reedy, yes, i have always patched last 2 branches [21:22:05] <^d> yurikR: Yeah, those are right. [21:22:12] <^d> Ignore my e-mail. Must've been a fluke. [21:22:42] Reedy, it shouldn't really matter if its a few hrs old - i wouldn't want the next rollout to have older ext ver than current [21:23:03] (03CR) 10Yurik: [C: 032] Updated ZeroPortal to master [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169923 (owner: 10Yurik) [21:23:16] (03CR) 10Yurik: [C: 032] Updated ZeroPortal to master [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/169922 (owner: 10Yurik) [21:23:51] (03CR) 10Cmcmahon: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169920 (owner: 10Cmcmahon) [21:24:41] (03CR) 10EBernhardson: "i'm not suggesting to kill the block concept at all, although certainly its something we can do. I just wanted to move the logic out of t" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169494 (owner: 10SG) [21:24:42] 3Wikimedia / 3Deployment systems: Have a check for reported security issues in dependencies - 10https://bugzilla.wikimedia.org/72193#c3 (10Chris Steipp) As a simple PoC, I setup https://integration.wikimedia.org/ci/job/test-csteipp-sensiolabs-securityadvisorieschecker/ Which checks against https://security... [21:26:24] (03CR) 10Cmcmahon: "c'mon Jenkins" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169920 (owner: 10Cmcmahon) [21:27:59] (03PS1) 10Jdlrobson: Split out ResourceLoaderTemplateParserModule from ResourceLoaderTemplateModule [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/169926 [21:28:41] (03CR) 10jenkins-bot: [V: 04-1] Split out ResourceLoaderTemplateParserModule from ResourceLoaderTemplateModule [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/169926 (owner: 10Jdlrobson) [21:29:21] (03Merged) 10jenkins-bot: Updated ZeroPortal to master [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169923 (owner: 10Yurik) [21:29:55] (03Merged) 10jenkins-bot: Updated ZeroPortal to master [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/169922 (owner: 10Yurik) [21:35:44] (03PS1) 10Yurik: Revert "Updated ZeroPortal to master" [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169928 [21:35:49] (03PS1) 10Yurik: Revert "Updated ZeroPortal to master" [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/169929 [21:36:14] (03CR) 10Yurik: [C: 032] Revert "Updated ZeroPortal to master" [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169928 (owner: 10Yurik) [21:36:14] (03CR) 10Yurik: [C: 032] Revert "Updated ZeroPortal to master" [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/169929 (owner: 10Yurik) [21:36:40] (03PS2) 10Jdlrobson: Split out ResourceLoaderTemplateParserModule from ResourceLoaderTemplateModule [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/169926 [21:37:07] Q170484ktm: grep tells that Shirayuki is credited in no less than 537 qqq files :) [21:37:15] wow [21:37:32] well, I added some qqq to CentralAuth. [21:37:43] gooooood [21:37:57] 3Wikimedia / 3Bugzilla: Write Quips extension for Phabricator - 10https://bugzilla.wikimedia.org/71245#c3 (10Daniel Kinzler) We need this! [21:38:32] (03CR) 10jenkins-bot: [V: 04-1] Split out ResourceLoaderTemplateParserModule from ResourceLoaderTemplateModule [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/169926 (owner: 10Jdlrobson) [21:39:42] 3Wikimedia / 3Bugzilla: Write Quips extension for Phabricator - 10https://bugzilla.wikimedia.org/71245#c4 (10Dereckson) (In reply to Peter Bena from comment #1) > in order to follow the phabricator extension naming it should be called > 'quiphs' :) I'm not sure. ph replaces the f, not the p. [21:39:57] 3Wikimedia / 3General/Unknown: harmonize Wikisource namespaces used by the ProofreadPage extension - 10https://bugzilla.wikimedia.org/72525#c7 (10Tpt) I support the project to move namespace ids for Page/Index namespaces to 250/252 that are the ones reserved by ProofreadPage extension. I'll be happy to help... [21:41:13] 3Wikimedia / 3Bugzilla: Write Quips extension for Phabricator - 10https://bugzilla.wikimedia.org/71245#c5 (10Chad H.) p:5Lowest>3Low Definitely needing this. It's a blocker for my day-to-day work. [21:43:09] (03Merged) 10jenkins-bot: Revert "Updated ZeroPortal to master" [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169928 (owner: 10Yurik) [21:43:30] (03Merged) 10jenkins-bot: Revert "Updated ZeroPortal to master" [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/169929 (owner: 10Yurik) [21:45:00] (03CR) 10Luis Felipe Schenone: "Siebrand, can you merge this, please?" [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/166986 (owner: 10Luis Felipe Schenone) [21:45:03] tomreyn: Q170484ktm: sending out email noting the problem in the previous email [21:46:01] (03PS3) 10Jdlrobson: Split out ResourceLoaderTemplateParserModule from ResourceLoaderTemplateModule [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/169926 [21:48:27] 3MediaWiki / 3User login and signup: Not loading site CSS on Special:UserLogin/Preferences breaks wikis which use it to create a skin/theme - 10https://bugzilla.wikimedia.org/71621#c13 (10Subfader) Is there no really easier way to suppress disasbling MediaWiki NS CSS when Special:Preferences is loaded? Only... [21:49:29] (03PS1) 10Jdlrobson: Register Hogan with mw.template [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/169931 [21:49:59] (03CR) 10jenkins-bot: [V: 04-1] Register Hogan with mw.template [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/169931 (owner: 10Jdlrobson) [21:51:54] (03PS6) 10Awight: Componentize Title permissions logic [core] - 10https://gerrit.wikimedia.org/r/166357 [21:52:29] (03Abandoned) 10Awight: Merge remote-tracking branch 'origin/fundraising/REL1_22' into HEAD [core] (fundraising/REL1_23) - 10https://gerrit.wikimedia.org/r/166890 (owner: 10Awight) [21:57:50] (03CR) 10Jforrester: Add i18n for API module help (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/169837 (owner: 10Anomie) [21:59:27] 3MediaWiki / 3File management: Upload new file version: Auto convert image file format - Add info afterwards - 10https://bugzilla.wikimedia.org/72555#c3 (10Subfader) Turns out the MIME detection is not properly working on the wiki. Then it does this: Upload a PNG > Replace file > Select a JPG > Wait... > Be... [21:59:36] (03PS2) 10Jforrester: Add i18n for API module help [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/169837 (owner: 10Anomie) [21:59:45] 3Wikimedia / 3Bugzilla: Wikimedia → IRC component description is outdated - 10https://bugzilla.wikimedia.org/72710 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None Wikimedia → IRC component description is outdated. > "Issues with Recent Changes feeds on irc.wikimedia.org. Bot issues should go... [22:00:06] (03CR) 10Jforrester: [C: 032] Add i18n for API module help [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/169837 (owner: 10Anomie) [22:00:38] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/169837 (owner: 10Anomie) [22:01:11] (03PS2) 10Jdlrobson: Register Hogan with mw.template [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/169931 [22:01:14] 3Wikimedia / 3Bugzilla: Wikimedia → IRC component description is outdated - 10https://bugzilla.wikimedia.org/72710 (10James Forrester) a:3James Forrester [22:02:19] (03Abandoned) 10Jdlrobson: Make Mantle use the template system in core. [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/167114 (owner: 10Jdlrobson) [22:02:54] (03CR) 10Jdlrobson: [C: 04-2] "Can't be done until Flow and MobileFrontend have moved off of this code." [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/168233 (owner: 10Jdlrobson) [22:04:08] (03PS4) 10Jdlrobson: Split out ResourceLoaderTemplateParserModule from ResourceLoaderTemplateModule [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/169926 [22:04:17] (03PS3) 10Jdlrobson: Register Hogan with mw.template [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/169931 [22:04:27] 3Wikimedia / 3Bugzilla: Wikimedia → IRC component description is outdated - 10https://bugzilla.wikimedia.org/72710#c1 (10James Forrester) 5NEW>3RESO/FIX Done. [22:04:52] !g a6a23ac1ec [22:04:52] https://gerrit.wikimedia.org/r/#q,a6a23ac1ec,n,z [22:05:12] 3MediaWiki extensions / 3CentralAuth: GlobalRename: optionally create a dummy account at the old name after the rename - 10https://bugzilla.wikimedia.org/70379 (10Andre Klapper) p:5Unprio>3Normal [22:06:00] ragesoss: https://www.mediawiki.org/wiki/Special:OAuthListConsumers/view/d35363a3096559d3a7a6a1f6d9b8ddda [22:06:07] Q170484ktm: ping :) [22:06:14] hi FlorianSW [22:06:18] csteipp: woohoo! [22:06:58] a stupid question about: https://lists.wikimedia.org/pipermail/wikitech-l/2014-October/079232.html :) Should vendor.git always be master branch? There are only some wmf branches: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/core/vendor,branches ?? [22:07:07] Q170484ktm ^ [22:07:55] FlorianSW: since it's only required now, REL1_25 will be the first stable branch for it [22:08:19] i mean, if there are some persons, who run wikis on wmf branches :) [22:08:29] 3Wikimedia / 3Bugzilla: wikibugs-l excluded from e-mail notification when creating a new bug with empty summary - 10https://bugzilla.wikimedia.org/64836#c5 (10Merlijn van Deen) *** Bug 72708 has been marked as a duplicate of this bug. *** [22:08:38] so they have to clone vendor, too, but which branch? [22:09:37] (03PS1) 10Cscott: Don't create pipes for `P.spawn` by default. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/169937 [22:09:39] (03PS1) 10Cscott: Update dependencies. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/169938 [22:10:13] 3MediaWiki extensions / 3OAuth: Attempting to approve some OAuth consumers results in error - 10https://bugzilla.wikimedia.org/72634 (10Chris Steipp) 5PATC>3RESO/FIX [22:12:14] FlorianSW: then they should use whatever version corresponds to their core version [22:12:27] (03PS1) 10Cscott: Update dependencies. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/169940 [22:12:29] (03PS1) 10Cscott: WIP: write this commit message. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/169941 [22:13:00] Q170484ktm: there is the problem. vendor doesn't have 1.25 branches :) (or you mean just the master if there is no correspending version branch?) [22:13:31] I see them: https://github.com/wikimedia/mediawiki-vendor/tree/wmf/1.25wmf6 [22:16:15] Q170484ktm: oops, my fault, i was looking in mediawiki/core/vendor instead of mediawiki/vendor :/ Sorry for confusion :( [22:16:25] /core/vendor is dead [22:16:43] Lets properly mark it as dead... [22:16:47] git submodule sync [22:18:56] (03PS1) 10Legoktm: Empty repository, point to new location [core/vendor] - 10https://gerrit.wikimedia.org/r/169942 [22:19:02] bd808: ^ [22:19:06] <^d> We could, you know, delete it. [22:19:52] ^d: will all the changes listed at https://gerrit.wikimedia.org/r/#/q/project:mediawiki/core/vendor,n,z still work? [22:19:58] (03CR) 10BryanDavis: [C: 032] Empty repository, point to new location [core/vendor] - 10https://gerrit.wikimedia.org/r/169942 (owner: 10Legoktm) [22:20:11] <^d> Q170484ktm: No those go byebye [22:20:17] :/ [22:20:22] (03PS1) 10Cmcmahon: QA: remove Scenario for "old permalink" checking [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169943 [22:20:27] <^d> Q170484ktm: gerrit sucks [22:20:54] (03CR) 10Legoktm: [V: 032] Empty repository, point to new location [core/vendor] - 10https://gerrit.wikimedia.org/r/169942 (owner: 10Legoktm) [22:21:10] ^d: probably not worth deleting then. [22:21:19] <^d> ya [22:21:28] https://gerrit.wikimedia.org/r/#/c/137538/ has useful discussion on it [22:21:56] (03PS2) 10Hoo man: Remove RequestContext::getMainAndWarn [core] - 10https://gerrit.wikimedia.org/r/168923 [22:23:02] (03CR) 10jenkins-bot: [V: 04-1] Remove RequestContext::getMainAndWarn [core] - 10https://gerrit.wikimedia.org/r/168923 (owner: 10Hoo man) [22:23:09] oh wtf [22:23:41] I only removed from that file [22:23:43] I mean wtf [22:23:46] * hoo rages [22:24:39] uhh [22:24:40] what [22:24:41] bd808: https://integration.wikimedia.org/ci/job/mediawiki-vendor-integration/3775/console [22:26:12] 3Wikimedia / 3Site requests: Rename "chapcomwiki" to "affcomwiki" - 10https://bugzilla.wikimedia.org/39482#c15 (10Sam Reed (reedy)) mediawiki config side of this for Mutliversion is at https://gerrit.wikimedia.org/r/#/c/169939/ [22:28:05] Q170484ktm: looking [22:30:06] Q170484ktm: it checked out the wrong repo ?! [22:30:23] gallium:/srv/ssd/jenkins-slave/workspace/mediawiki-vendor-integration/src/vendor/MOVED [22:31:16] >.< [22:31:29] 22:22:40 INFO:zuul.Cloner:Creating repo mediawiki/vendor from upstream https://gerrit.wikimedia.org/r/p/mediawiki/vendor [22:31:59] 3MediaWiki / 3Interface: Provide the OOUI PHP module inside MW core - 10https://bugzilla.wikimedia.org/72714 (10James Forrester) 3ASSI p:3Unprio s:3enhanc a:3Bartosz Dziewoński Part of "front-end standardisation" Q2 priority project. [22:32:13] 3MediaWiki / 3Interface: Provide the OOUI PHP module inside MW core - 10https://bugzilla.wikimedia.org/72714 (10James Forrester) [22:32:15] 3MediaWiki / 3User login and signup: Convert MW core login/logout/signup pages to OOUI - 10https://bugzilla.wikimedia.org/72715 (10James Forrester) 3NEW p:3Unprio s:3normal a:3None Part of "front-end standardisation" Q2 priority project. [22:32:16] Q170484ktm: I'm re-running to see if it was sunspots [22:32:27] And it was [22:32:32] https://integration.wikimedia.org/ci/job/mediawiki-vendor-integration/3776/console [22:32:42] weird. [22:33:02] (03CR) 10Legoktm: "recheck" [core] - 10https://gerrit.wikimedia.org/r/168923 (owner: 10Hoo man) [22:33:06] oh. passing job is running on lanthanum [22:33:16] gallium's workspace is still hosed [22:33:41] I wonder ... [22:35:31] 3MediaWiki / 3General/Unknown: Tracking bug (tracking) - 10https://bugzilla.wikimedia.org/2007 (10James Forrester) [22:37:53] (03PS1) 10Luis Felipe Schenone: Updated, debugged and enhanced the extension [extensions/MsCatSelect] - 10https://gerrit.wikimedia.org/r/169946 [22:39:09] Q170484ktm: I fixed it by deleting the back vendor checkout on gallium. Not exactly sure what put it there in the first place. [22:39:16] s/back/bad/ [22:41:28] (03PS4) 10Jdlrobson: Register Hogan with mw.template [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/169931 [22:41:33] ok [22:41:37] (03CR) 10BryanDavis: "There was a strange Jenkins job failure on gallium following this merge. The /srv/ssd/jenkins-slave/workspace/mediawiki-vendor-integration" [core/vendor] - 10https://gerrit.wikimedia.org/r/169942 (owner: 10Legoktm) [22:41:45] (03CR) 10Legoktm: "recheck" [core] - 10https://gerrit.wikimedia.org/r/168923 (owner: 10Hoo man) [22:45:15] (03PS5) 10EBernhardson: Update lightncandy and remove flow_component [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169494 (owner: 10SG) [22:47:17] (03CR) 10EBernhardson: [C: 032] "this will work for now, i will submit a followup where we can discuss the other parts" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169494 (owner: 10SG) [22:47:59] (03Merged) 10jenkins-bot: Update lightncandy and remove flow_component [extensions/Flow] - 10https://gerrit.wikimedia.org/r/169494 (owner: 10SG) [22:58:51] (03PS26) 10EBernhardson: H-8. Implement boardHistory component features [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166728 (owner: 10SG) [22:59:35] (03CR) 10jenkins-bot: [V: 04-1] H-8. Implement boardHistory component features [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166728 (owner: 10SG) [23:00:41] (03CR) 10EBernhardson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166728 (owner: 10SG) [23:02:31] Q170484ktm: The logging problem in beta ended up being unrelated and is fixed now. [23:02:40] sweet :D [23:03:25] thanks for the clarification, hexmode [23:03:45] np [23:04:10] (03PS15) 10BryanDavis: Use MWLogger logging for wfLogProfilingData [core] - 10https://gerrit.wikimedia.org/r/119942 [23:05:23] (03CR) 10BryanDavis: "Parent5446: any chance you'd be willing to remove your -1 now that the related bug is filed for the legacy behaviour you objected to?" [core] - 10https://gerrit.wikimedia.org/r/119942 (owner: 10BryanDavis) [23:05:35] (03PS11) 10BryanDavis: Add logging context to database logs [core] - 10https://gerrit.wikimedia.org/r/141599 [23:05:57] 3Wikimedia / 3General/Unknown: out of memory for some animated GIF images on Commons - 10https://bugzilla.wikimedia.org/61711#c14 (10Kelson [Emmanuel Engelhart]) New example of problematic image (although the image is really not so big!): https://commons.wikimedia.org/wiki/File:DNA_orbit_animated.gif Try to... [23:06:02] This is a really nice skin for mw: https://ddll.inf.tu-dresden.de/web/Dresden_Logic_Labs/en [23:06:16] (03CR) 10Parent5446: "Yep" [core] - 10https://gerrit.wikimedia.org/r/119942 (owner: 10BryanDavis) [23:07:13] 3Wikimedia / 3Apache configuration: create pk.wikimedia.org and redirect to wikimediapakistan.org - 10https://bugzilla.wikimedia.org/54780#c22 (10Saqib) ok. guys . sorry for too much troubling but things were not perfect at my side.. now the site is finally up.. and will be working on soon once i get some... [23:07:28] 3MediaWiki / 3File management: HTTP 500 errors with certain JPEG thumbnails: "Fractional sampling not implemented yet" - 10https://bugzilla.wikimedia.org/72511#c9 (10Kelson [Emmanuel Engelhart]) Sorry for my last comment, is not for this bug report. [23:09:44] 3Wikimedia / 3Apache configuration: create pk.wikimedia.org and redirect to wikimediapakistan.org - 10https://bugzilla.wikimedia.org/54780#c23 (10Saqib) and www.wikimediapakistan.org is expired already so no more wasting money to buy it again.. right now we have hosted our site on a temporary URL [23:10:24] (03PS7) 10Mooeypoo: Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 [23:10:27] (03CR) 10jenkins-bot: [V: 04-1] Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo) [23:11:57] (03PS1) 10Catrope: Update VisualEditor to wmf6 branch for cherry-pick [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/169951 [23:12:11] (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor to wmf6 branch for cherry-pick [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/169951 (owner: 10Catrope) [23:12:52] (03PS8) 10Mooeypoo: Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 [23:13:12] 3Wikimedia / 3SSL related: Disable SSL 3.0 on Wikimedia sites to mitigate POODLE attack (CVE-2014-3566) - 10https://bugzilla.wikimedia.org/72072#c4 (10Daniel Zahn) fixed misc-web-lb by restarting nginx on cp1043 and cp1044. they already had the right config but lacked that. this fixed all the services behin... [23:13:45] 3MediaWiki / 3General/Unknown: Tarballs should include mediawiki/vendor repository - 10https://bugzilla.wikimedia.org/72726 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3enhanc a:3None Starting with 1.25, tarballs need to include the mediawiki/vendor repository. [23:26:34] (03PS9) 10Mooeypoo: Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 [23:28:10] (03PS1) 10MaxSem: Bump MF for https://gerrit.wikimedia.org/r/#/c/169778/ [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/169960 [23:29:10] (03CR) 10EBernhardson: [C: 032] H-8. Implement boardHistory component features (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166728 (owner: 10SG) [23:29:59] (03CR) 10jenkins-bot: [V: 04-1] H-8. Implement boardHistory component features [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166728 (owner: 10SG) [23:30:43] (03CR) 10EBernhardson: [C: 032] H-8. Implement boardHistory component features [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166728 (owner: 10SG) [23:31:29] (03Merged) 10jenkins-bot: H-8. Implement boardHistory component features [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166728 (owner: 10SG) [23:32:23] (03CR) 10MaxSem: [C: 032 V: 032] Bump MF for https://gerrit.wikimedia.org/r/#/c/169778/ [core] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/169960 (owner: 10MaxSem) [23:32:38] (03PS1) 10MaxSem: Bump MF for https://gerrit.wikimedia.org/r/#/c/169778/ [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169961 [23:32:55] (03CR) 10MaxSem: [C: 032 V: 032] Bump MF for https://gerrit.wikimedia.org/r/#/c/169778/ [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169961 (owner: 10MaxSem) [23:33:44] (03PS18) 10EBernhardson: J-1: Comment moderation updates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166778 [23:34:16] (03CR) 10EBernhardson: [C: 032] "re-apply sg+2" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166778 (owner: 10EBernhardson) [23:34:52] (03PS10) 10EBernhardson: I-1: Finish topic moderation updates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167738 [23:37:14] (03PS1) 10Aaron Schulz: Fixed possible db error log spam when cluster=* in wfWaitForSlaves() [core] - 10https://gerrit.wikimedia.org/r/169964 [23:37:16] ori: ^ [23:37:49] (03CR) 10Ori.livneh: [C: 032] """." [core] - 10https://gerrit.wikimedia.org/r/169964 (owner: 10Aaron Schulz) [23:40:06] (03PS1) 10Poke: Add Content-Length header for job queue requests [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/169965 (https://bugzilla.wikimedia.org/72274) [23:45:42] (03Merged) 10jenkins-bot: J-1: Comment moderation updates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166778 (owner: 10EBernhardson) [23:50:53] (03Merged) 10jenkins-bot: Fixed possible db error log spam when cluster=* in wfWaitForSlaves() [core] - 10https://gerrit.wikimedia.org/r/169964 (owner: 10Aaron Schulz) [23:52:46] (03CR) 10EBernhardson: [C: 032] "re-apply sg+2" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167738 (owner: 10EBernhardson) [23:53:32] (03Merged) 10jenkins-bot: I-1: Finish topic moderation updates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167738 (owner: 10EBernhardson) [23:53:58] 3MediaWiki extensions / 3WikibaseQueryEngine: [HHVM] Tests on Travis are failing (due to HHVM's sqlsite driver) - 10https://bugzilla.wikimedia.org/69526#c9 (10Bill Schaller) HHVM PDO bug is supposedly fixed -- https://github.com/facebook/hhvm/issues/3467