[00:00:38] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/168196 (owner: 10Florianschmidtwelzow) [00:06:39] 3MediaWiki extensions / 3SemanticBundle: XSS in Semantic Search - 10https://bugzilla.wikimedia.org/46852 (10Chris Steipp) [00:16:54] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (0310 comments) [extensions/HierarchyBuilder] - 10https://gerrit.wikimedia.org/r/168192 (owner: 10Kji) [00:17:22] greg-g: To confirm, after tomorrow (23rd) the next deploy will be 29th not 30th, right? [00:17:27] s/deploy/train/ [00:19:04] James_F: right, I'm basically going with Message-ID: [00:19:17] Umm. OK. [00:21:01] greg-g: If you edit Deployments to mark it up I'll be your friend forever. ;-) [00:21:35] I'm not already?!?!?!?! [00:21:42] was it all a game?! [00:21:43] Clearly not. :-) [00:21:54] tease [00:21:57] That's me. [00:22:03] * greg-g goes to do that [00:22:46] Thanks! [00:25:35] (03CR) 10Siebrand: [C: 032] "i18n/L10n reviewed." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/168118 (https://bugzilla.wikimedia.org/72346) (owner: 10Glaisher) [00:26:43] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/158880 (owner: 10Umherirrender) [00:27:44] (03Merged) 10jenkins-bot: Add namespace translations for 'mai' [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/168118 (https://bugzilla.wikimedia.org/72346) (owner: 10Glaisher) [00:28:20] Why isn't api.php complete anymore? [00:28:43] I saw the link to the complete version, just wondering why it was changed [00:30:07] warpcore: information overload [00:32:01] I liked the plaintext too but I don't miss it much [00:32:25] Betacommand: was there are discussion/bug? [00:32:28] or rfc [00:32:41] warpcore: I know there was an announcement [00:33:05] <^d> There was an RfC as well. [00:33:15] <^d> https://www.mediawiki.org/w/api.php?action=help&recursivesubmodules=1 - for those who like information in large doses [00:33:21] Why does it say I am logged in, please reload? [00:33:39] warpcore: SUL [00:33:49] why does the API help load SUL? [00:33:55] with the annoying popup [00:34:13] and it appears every time I reload, it doesn't log me in [00:35:03] and I'm already logged in... is that a bug? [00:37:07] ^d: does it give the little SUL popup for you even when logged in, or is it just me? [00:37:37] <^d> I don't see anything about that. [00:38:40] warpcore: https://bugzilla.wikimedia.org/show_bug.cgi?id=72174 [00:38:56] Thanks [00:39:27] <^d> Ah, already fixed in master. [00:39:39] <^d> Guess it'll make tomorrow's branch and start rolling out [00:40:18] James_F: https://wikitech.wikimedia.org/wiki/Deployments#Week_of_October_27th [00:40:29] greg-g: It's a beaut. :-0 [00:41:00] (03PS1) 10Arlolra: Set TMPDIR for the renderer [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/168227 [00:41:25] greg-g: Are 04:00 SWATs going to happen the week after that? [00:42:01] James_F: oops, going to move the Tuesday deploy to 5am... [00:42:15] I'm going to skip the adding of new SWAT windows, I haven't lined up people yet [00:42:41] Oh, yeah. [00:42:42] * James_F nods. [00:43:34] James_F: while looking at https://bugzilla.wikimedia.org/show_bug.cgi?id=71789 , i notice that template parameters currently don't seem to subst correctly [00:44:06] <^d> greg-g: You know, weekly deployments + swat basically removed almost all of the one-off deploys. [00:44:14] <^d> The calendar is so...simple...these days [00:44:22] jackmcbarn: Bug 71157, already fixed in master. [00:44:32] jackmcbarn: And yeah, it was ugly. [00:45:25] James_F: i was going to ask about substing in the edit window next, but now i see https://gerrit.wikimedia.org/r/#/c/168205/ is already in progress [00:45:50] (03CR) 10Krinkle: Add support for delivering templates via ResourceLoader (031 comment) [core] - 10https://gerrit.wikimedia.org/r/167342 (owner: 10Jdlrobson) [00:46:02] jackmcbarn: Yeah, that's waiting on Parsoid support, I think. [00:46:44] James_F: is it? [00:46:58] jackmcbarn: Krenair is the expert, I'm just the product manager. :-) [00:47:17] ok [00:47:17] (03CR) 10Krinkle: "PS5 is a rebase with changes, avoid rebasing and making changes in the same patch set. Makes reviewing almost impossible without command-l" [core] - 10https://gerrit.wikimedia.org/r/167342 (owner: 10Jdlrobson) [00:49:30] (03CR) 10Cscott: [C: 04-1] Set TMPDIR for the renderer (033 comments) [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/168227 (owner: 10Arlolra) [00:53:24] James_F: email sent (it's now more official) [00:58:34] Not sure if this is the right place [00:58:50] But I added Wiktionary to my list of search engines in Firefox, but it doesn't have an icon (still works). [00:59:03] Does this happen for other people? [01:00:13] (03CR) 10Catrope: [C: 04-1] "A few minor things but looks good otherwise" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/167342 (owner: 10Jdlrobson) [01:09:39] (03CR) 10Krinkle: [C: 04-1] Add support for delivering templates via ResourceLoader (032 comments) [core] - 10https://gerrit.wikimedia.org/r/167342 (owner: 10Jdlrobson) [01:10:10] poxy: how did you add it? [01:10:45] firefox icony things can sometimes be fixed by removing and re-adding [01:11:12] warpcore: After accessing the site, I added it using the search engine drop-down menu [01:11:56] I just did that, no icon [01:12:16] but the icon is in the drop-down menu [01:12:21] ^ Yeah [01:12:28] but not after you add it. Weird [01:12:44] Mozilla bug probably [01:14:04] Do we know the file type of the icon (e.g., jpg, ...)? [01:14:23] It's working with other sites [01:15:14] https://bits.wikimedia.org/favicon/piece.ico [01:15:47] https://bits.wikimedia.org/favicon/wiktionary/en.ico [01:16:04] Awesome, thanks [01:16:32] Which one depends on which language version you use. Isn't .ico standard anyway? [01:17:37] I've got no idea. Just wanted to get sources before heading to the firefox forums [01:20:07] The add-on from the firefox addons site works just fine, though. Different icon, is all. [01:24:35] (03CR) 10Arlolra: Set TMPDIR for the renderer (033 comments) [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/168227 (owner: 10Arlolra) [01:26:11] (03PS7) 10Jdlrobson: Use templates in core. [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/167114 [01:26:13] (03PS1) 10Jdlrobson: Drop Hogan dependency on mantle templates [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/168233 [01:27:00] (03CR) 10jenkins-bot: [V: 04-1] Use templates in core. [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/167114 (owner: 10Jdlrobson) [01:27:16] (03CR) 10jenkins-bot: [V: 04-1] Drop Hogan dependency on mantle templates [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/168233 (owner: 10Jdlrobson) [01:28:39] (03PS2) 10Arlolra: Set TMPDIR for the renderer [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/168227 [01:30:51] (03CR) 10Krinkle: [C: 04-1] "They shouldn't use parse() because the return values of these are interpreted as wikitext, not html." [core] - 10https://gerrit.wikimedia.org/r/167975 (owner: 10Bartosz Dziewoński) [01:32:50] (03Abandoned) 10Krinkle: StripState: Minor coding style and optimisation [core] - 10https://gerrit.wikimedia.org/r/167567 (owner: 10Krinkle) [01:36:31] (03CR) 10Krinkle: [C: 04-1] "Did you mean to commit localsettings?" [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/168227 (owner: 10Arlolra) [01:48:36] (03PS1) 10Ori.livneh: Change link target of HHVM tag to [[mw:HHVM/About]] [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/168234 [01:48:48] quiddity: ^ [01:49:20] (03PS3) 10Arlolra: Set TMPDIR for the renderer [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/168227 [01:49:41] (03CR) 10Arlolra: "Krinkle: thanks for noticing that :(" [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/168227 (owner: 10Arlolra) [01:52:32] hmm, weird. No Change-id line came up when I tried to make a commit. I wonder what I possibly could have done to messed up git-review [01:52:50] oh but it came up after [01:53:03] maybe its always been like that and I just didn't notice [01:54:01] (03PS1) 10Brian Wolff: Respect $wgApiFrameOptions in formatted API output mode [core] - 10https://gerrit.wikimedia.org/r/168235 (https://bugzilla.wikimedia.org/72340) [02:05:52] (03CR) 10Krinkle: "It's because the vendor files moved from modules/new to modules/, but the pattern exception is still for modules/new." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163908 (owner: 10Spage) [02:08:38] 3MediaWiki / 3Parser: Parser::doBlockLevels performs poorly under HHVM - 10https://bugzilla.wikimedia.org/72205#c4 (10Krinkle) 5PATC>3NEW (In reply to Gerrit Notification Bot from comment #2) > Change 167411 merged by jenkins-bot: > Use a fixed regex for StripState > > https://gerrit.wikimedia.org/r/167... [02:08:59] ori: legoktm: https://gerrit.wikimedia.org/r/#/c/166411/ [02:09:44] (03PS3) 10Krinkle: special.js: Use then() instead of manually wrapping Deferred [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/145552 [02:10:07] prtksxna: https://gerrit.wikimedia.org/r/#/c/145552/ [02:11:27] (03CR) 10Krinkle: JS sanity per Krinkle's patch (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166951 (owner: 10SG) [02:11:50] (03CR) 10Krinkle: [C: 04-1] "TypeError: undefined is not a function (string.string)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166951 (owner: 10SG) [02:16:14] (03CR) 10Cscott: "lstat(./xelatex) failed ..." [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/168227 (owner: 10Arlolra) [02:20:09] (03CR) 10Ori.livneh: [C: 032] Declare dependency jquery.cookie for ext.navigationTiming [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/166411 (owner: 10Krinkle) [02:20:38] (03Merged) 10jenkins-bot: Declare dependency jquery.cookie for ext.navigationTiming [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/166411 (owner: 10Krinkle) [02:21:15] (03CR) 10Krinkle: [C: 04-1] Allow passing pages to ResourceLoaderWikiModule via constructor parameters (033 comments) [core] - 10https://gerrit.wikimedia.org/r/167834 (owner: 10Legoktm) [02:25:26] (03PS2) 10Krinkle: Drafts: Refactor with IndexedDB [core] - 10https://gerrit.wikimedia.org/r/159626 (owner: 10TheDJ) [02:26:02] (03PS4) 10Cscott: Set TMPDIR for the renderer [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/168227 (owner: 10Arlolra) [02:26:04] (03CR) 10jenkins-bot: [V: 04-1] Drafts: Refactor with IndexedDB [core] - 10https://gerrit.wikimedia.org/r/159626 (owner: 10TheDJ) [02:30:20] (03CR) 10Krinkle: "Please wontfix the bug and abandon the patch or provide a path forward. Removing myself from CC." [skins/Vector] - 10https://gerrit.wikimedia.org/r/154350 (https://bugzilla.wikimedia.org/54604) (owner: 10Bartosz Dziewoński) [02:30:22] (03CR) 10Arlolra: "LGTM but you should +2" [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/168227 (owner: 10Arlolra) [02:31:31] (03Abandoned) 10Krinkle: Set $wgUseTwoButtonsSearchForm false by default [core] - 10https://gerrit.wikimedia.org/r/145517 (https://bugzilla.wikimedia.org/40622) (owner: 10Rohan013) [02:33:43] (03CR) 10Krinkle: "Which references are those? These classes where virtually inexistant/unused until very very recently. Whatever misused them can be fixed i" [skins/Vector] - 10https://gerrit.wikimedia.org/r/158803 (owner: 10Arlolra) [02:35:22] 3MediaWiki / 3File management: given path of the specified thumbnail is incorrect - 10https://bugzilla.wikimedia.org/72389#c1 (10Bawolff (Brian Wolff)) Appears to be accientally caused by f7be7e6a (Abbreviation threshold for files with long names was set to 140 for commons as a foreign repo, but kept at 160... [02:35:54] MediaWiki core is now exactly 19000074 bytes [02:36:01] nice number [02:36:04] https://tools.wmflabs.org/snapshots/#!/mediawiki-core/master [02:38:53] ^d: Can we remove wmf 1.23 branches? [02:39:08] and 1.24 for that matter [02:39:39] Reedy: I forgot what the policy is for that again [02:42:37] 3MediaWiki / 3Special pages: Special:AllPages no longer has Next link (regression?) - 10https://bugzilla.wikimedia.org/69951#c3 (10Romaine) This problem still exists, can it please be solved. Special:AllPages is now almost useless or totally clumsy in use. [02:44:08] 3MediaWiki / 3File management: abbrvThreshold mismatch between commons as foreign repo and local commons breaking images with long names - 10https://bugzilla.wikimedia.org/72389#c3 (10Bawolff (Brian Wolff)) I wonder if it would be a good idea to also make expected name mismatches give a redirect instead of a... [02:50:22] 3MediaWiki / 3Special pages: Special:AllPages no longer has Next link (regression?) - 10https://bugzilla.wikimedia.org/69951#c4 (10MZMcBride) (In reply to Donald Lancon from comment #0) > (Note: I guess this technically constitutes a return to the very ancient bug > 1331. Maybe I was supposed to just reopen... [02:51:04] (03PS1) 10Cscott: Turn off redundant console logging. [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/168241 [02:53:12] (03PS8) 10Krinkle: jquery.textSelection: Add ability to register custom implementation [core] - 10https://gerrit.wikimedia.org/r/150032 (https://bugzilla.wikimedia.org/29328) (owner: 10TheDJ) [02:53:33] (03CR) 10Mattflaschen: [C: 04-1] "> Don't merge yet since we need to migrate uses first." [core] - 10https://gerrit.wikimedia.org/r/139686 (owner: 10Paladox) [02:58:10] (03CR) 10Arlolra: [C: 032 V: 032] Turn off redundant console logging. [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/168241 (owner: 10Cscott) [02:58:31] (03PS9) 10Krinkle: jquery.textSelection: Add ability to register custom implementation [core] - 10https://gerrit.wikimedia.org/r/150032 (https://bugzilla.wikimedia.org/29328) (owner: 10TheDJ) [02:58:37] (03CR) 10Krinkle: [C: 032] jquery.textSelection: Add ability to register custom implementation [core] - 10https://gerrit.wikimedia.org/r/150032 (https://bugzilla.wikimedia.org/29328) (owner: 10TheDJ) [02:58:45] (03CR) 10Krinkle: [C: 032] Split jquery.textSelection and WikiEditor api overrides [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/150037 (https://bugzilla.wikimedia.org/29328) (owner: 10TheDJ) [03:00:45] I'm looking at https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/includes%2Fspecials%2FSpecialAllPages.php [03:00:54] Trying to figure out why the next link doesn't appear at https://www.mediawiki.org/wiki/Special:AllPages [03:04:59] (03Merged) 10jenkins-bot: jquery.textSelection: Add ability to register custom implementation [core] - 10https://gerrit.wikimedia.org/r/150032 (https://bugzilla.wikimedia.org/29328) (owner: 10TheDJ) [03:05:04] (03Merged) 10jenkins-bot: Split jquery.textSelection and WikiEditor api overrides [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/150037 (https://bugzilla.wikimedia.org/29328) (owner: 10TheDJ) [03:05:12] Oh, I think I see it. [03:05:48] GitBlit really is only a hair better than command-line Git. [03:09:02] superm401: https://github.com/cssjanus/php-cssjanus/pull/4 [03:09:03] Nemo_bis: Should https://github.com/wikimedia say "Wikimedia Foundation"? [03:09:30] It does? [03:10:04] Carmela: I think you misspelled "GitBlit is significantly worse than command line git" [03:10:07] superm401: https://github.com/mattflaschen?tab=activity "The comment has since been removed." [03:10:15] bawolff: Command-line Git is pretty bad. [03:11:06] At least I know what to type to get a directory listing. with git blit I have to click through several pages, or memorize a url structure that's really frustrating to memorize [03:11:14] So now I need to convert a commit to Gerrit. [03:11:17] Which is even worse. [03:11:22] Krinkle, that's weird. I don't remember doing that. [03:11:54] Found it. [03:11:55] Soon we'll be able to say bad things about phabricator instead [03:12:11] Krinkle, alright, let me try to remember what I wrote. [03:12:31] Right-o. MatmaRex. [03:12:33] (03CR) 10Cscott: [C: 032] Set TMPDIR for the renderer [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/168227 (owner: 10Arlolra) [03:12:36] And Danny B! [03:12:49] superm401: Or tell me here, I'd like to close it now. [03:12:57] Krinkle, sure, just one sec. [03:13:16] (03Merged) 10jenkins-bot: Set TMPDIR for the renderer [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/168227 (owner: 10Arlolra) [03:15:21] Krinkle, okay, I think one was that it should explicitly mention pull requests should also be submitted to the nodejs version, and the other was that I thought node-cssjanus was a clearer name. [03:17:08] 3MediaWiki / 3Special pages: Special:AllPages no longer has Next link (regression?) - 10https://bugzilla.wikimedia.org/69951#c5 (10MZMcBride) Right, so https://gerrit.wikimedia.org/r/145761 did this (specifically ). It... [03:17:25] I guess that really is just a matter of re-adding $n++; somewhere in there. [03:17:39] Krinkle, is it possible you deleted the branch or something? I think something similar to that happened the last time this kind of GitHub comment deletion came up (totally different person and project, but also GitHub). [03:18:52] 3MediaWiki / 3Special pages: Special:AllPages no longer has Next link (regression?) - 10https://bugzilla.wikimedia.org/69951 (10MZMcBride) [03:20:53] 3MediaWiki / 3File management: abbrvThreshold mismatch between commons as foreign repo and local commons breaking images with long names - 10https://bugzilla.wikimedia.org/72389#c5 (10Bawolff (Brian Wolff)) 5PATC>3RESO/FIX CScott deployed fix, so it should be resolved now. (Some cached pages may need to... [03:22:19] Krinkle, BTW, I don't consider the repo name thing a blocker or anything, I just noticed that the redirect direction changed, and I thought it was clearer the other way.. [03:22:32] Yeah, I'm not changing the name now. [03:23:27] hi Krinkle [03:23:31] I heard you moved! :D [03:23:40] I dropped the prefix because it never had a prefix (it was added due to a name conflict Trevor ran into and hadnt yet fixed, most documetnation already referred to cssjanus because that's whre it was originally) and also to make more explicit that node- is no longer a port but the canonical implementation. [03:24:24] whcih makes fetching test data less awkward (e.g. php-cssjanus fetching node-cssjanus is odd) [03:29:17] (03PS1) 10BryanDavis: Make role::centralauth docs prettier [vagrant] - 10https://gerrit.wikimedia.org/r/168247 [03:29:30] (03PS31) 10Pastakhov: refactor and extend usability (v 3.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/163544 [03:31:16] (03CR) 10Legoktm: [C: 032] Change link target of HHVM tag to [[mw:HHVM/About]] [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/168234 (owner: 10Ori.livneh) [03:31:34] (03Merged) 10jenkins-bot: Change link target of HHVM tag to [[mw:HHVM/About]] [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/168234 (owner: 10Ori.livneh) [03:37:39] Krinkle, alright, that just leaves mentioning pull requests. [03:41:55] (03PS1) 10MZMcBride: Restore next link to Special:AllPages [core] - 10https://gerrit.wikimedia.org/r/168248 (https://bugzilla.wikimedia.org/69951) [03:44:17] (03CR) 10MZMcBride: "Untested." [core] - 10https://gerrit.wikimedia.org/r/168248 (https://bugzilla.wikimedia.org/69951) (owner: 10MZMcBride) [03:48:38] (03CR) 10Legoktm: [C: 032] Restore next link to Special:AllPages [core] - 10https://gerrit.wikimedia.org/r/168248 (https://bugzilla.wikimedia.org/69951) (owner: 10MZMcBride) [03:49:45] (03PS1) 10Legoktm: Restore next link to Special:AllPages [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/168249 (https://bugzilla.wikimedia.org/69951) [03:49:56] (03CR) 10Legoktm: [C: 032] Restore next link to Special:AllPages [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/168249 (https://bugzilla.wikimedia.org/69951) (owner: 10Legoktm) [03:54:37] (03Merged) 10jenkins-bot: Restore next link to Special:AllPages [core] - 10https://gerrit.wikimedia.org/r/168248 (https://bugzilla.wikimedia.org/69951) (owner: 10MZMcBride) [03:56:57] (03Merged) 10jenkins-bot: Restore next link to Special:AllPages [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/168249 (https://bugzilla.wikimedia.org/69951) (owner: 10Legoktm) [04:07:55] 3MediaWiki / 3Special pages: Special:AllPages no longer has Next link (regression?) - 10https://bugzilla.wikimedia.org/69951#c10 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3MZMcBride Merged and backported to the 1.24 branch. [04:19:41] (03PS2) 10Krinkle: Respect $wgApiFrameOptions in formatted API output mode [core] - 10https://gerrit.wikimedia.org/r/168235 (https://bugzilla.wikimedia.org/72340) (owner: 10Brian Wolff) [04:26:16] (03CR) 10Krinkle: [C: 04-1] "A few points, and there's also trailing whitespace (I'd recommend configuring your editor to either trim these or point them out to you wh" (032 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167389 (owner: 10Mvolz) [04:31:52] 3MediaWiki / 3Page deletion: Deletion log excerpt (mw-warning-with-logexcerpt ) not shown when only curid given and page has been deleted - 10https://bugzilla.wikimedia.org/71578#c3 (10Matthew Flaschen) I tried to rephase the summary; let me know if I'm mis-stating something. [04:32:36] (03CR) 10Krinkle: maps added as allowed value in TD JSON root (033 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167389 (owner: 10Mvolz) [04:37:25] (03CR) 10Krinkle: maps added as allowed value in TD JSON root (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167389 (owner: 10Mvolz) [04:43:22] 3MediaWiki / 3User preferences: Have watchlist email setting in "Notifications" tab in Special:Preferences - 10https://bugzilla.wikimedia.org/66965#c1 (10MZMcBride) This bug is probably a duplicate of bug 63577 and/or bug 63578. [04:45:42] (03PS27) 10EBernhardson: Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [04:45:45] (03PS1) 10EBernhardson: Bug: getUserLinks wrong output for anons [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168251 [04:45:48] (03PS1) 10EBernhardson: Hygiene: Dont reach out to $wgTitle [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168252 [04:46:37] (03CR) 10jenkins-bot: [V: 04-1] Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [04:47:34] (03PS20) 10BryanDavis: Use MWLogger logging for legacy logging methods [core] - 10https://gerrit.wikimedia.org/r/119941 [04:47:36] (03PS1) 10BryanDavis: Make $wgMWLoggerDefaultSpi more expressive [core] - 10https://gerrit.wikimedia.org/r/168253 [04:49:21] (03CR) 10BryanDavis: "Addressed Timo's comments, fixed @since tags and rebased on new ObjectFactory patch." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/119941 (owner: 10BryanDavis) [04:52:25] 3MediaWiki / 3MediaWiki UI: Update usage instructions for mw-ui-destructive - 10https://bugzilla.wikimedia.org/71856 (10Matthew Flaschen) a:3Matthew Flaschen [04:53:27] (03CR) 10jenkins-bot: [V: 04-1] Use MWLogger logging for legacy logging methods [core] - 10https://gerrit.wikimedia.org/r/119941 (owner: 10BryanDavis) [04:57:55] (03PS1) 10Mattflaschen: Tweak 'destructive' use case in style guide [core] - 10https://gerrit.wikimedia.org/r/168254 [04:58:23] (03PS2) 10Mattflaschen: Tweak 'destructive' use case in style guide [core] - 10https://gerrit.wikimedia.org/r/168254 (https://bugzilla.wikimedia.org/71856) [05:19:33] (03PS32) 10Pastakhov: refactor and extend usability (v 3.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/163544 [05:40:25] 3MediaWiki / 3API: "createaccount" action failure should return the name of the extension that caused it to fail. - 10https://bugzilla.wikimedia.org/72387 (10Dan Garry) [05:45:18] who runs quarry [05:46:42] (03CR) 10Florianschmidtwelzow: Change RC visibility to use a tag instead of string (031 comment) [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/168196 (owner: 10Florianschmidtwelzow) [05:46:51] (03PS33) 10Pastakhov: refactor and extend usability (v 3.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/163544 [05:48:04] Carmela: on? [05:49:05] (03PS2) 10Florianschmidtwelzow: Change RC visibility to use a tag instead of string [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/168196 [05:50:40] (03PS13) 10BryanDavis: Use MWLogger logging for wfLogProfilingData [core] - 10https://gerrit.wikimedia.org/r/119942 [05:50:42] (03PS8) 10BryanDavis: Add logging context to database logs [core] - 10https://gerrit.wikimedia.org/r/141599 [05:50:59] (03CR) 10BryanDavis: Add logging context to database logs (032 comments) [core] - 10https://gerrit.wikimedia.org/r/141599 (owner: 10BryanDavis) [05:55:37] Yuvi does [05:56:44] (03CR) 10jenkins-bot: [V: 04-1] Use MWLogger logging for wfLogProfilingData [core] - 10https://gerrit.wikimedia.org/r/119942 (owner: 10BryanDavis) [05:56:59] (03CR) 10jenkins-bot: [V: 04-1] Add logging context to database logs [core] - 10https://gerrit.wikimedia.org/r/141599 (owner: 10BryanDavis) [05:57:21] (03PS34) 10Pastakhov: refactor and extend usability (v 3.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/163544 [05:58:25] 3MediaWiki / 3API: "createaccount" action failure should return the name of the extension that caused it to fail. - 10https://bugzilla.wikimedia.org/72387#c1 (10Kunal Mehta (Legoktm)) I think AntiSpoof just needs to use the API specific hooks (like was done to ConfirmEdit in Id628defaeab2bf5979ca8f4284d14fc4... [06:53:20] (03CR) 10Bartosz Dziewoński: [C: 032] Tweak 'destructive' use case in style guide [core] - 10https://gerrit.wikimedia.org/r/168254 (https://bugzilla.wikimedia.org/71856) (owner: 10Mattflaschen) [06:53:53] 3MediaWiki / 3MediaWiki UI: Update usage instructions for mw-ui-destructive - 10https://bugzilla.wikimedia.org/71856 (10Bartosz Dziewoński) 5PATC>3RESO/FIX [06:54:18] (03CR) 10Pastakhov: [C: 032] refactor and extend usability (v 3.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/163544 (owner: 10Pastakhov) [06:55:45] (03PS2) 10Lilu: PermissionManager-Bugfixes [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/168053 [06:59:06] (03Merged) 10jenkins-bot: Tweak 'destructive' use case in style guide [core] - 10https://gerrit.wikimedia.org/r/168254 (https://bugzilla.wikimedia.org/71856) (owner: 10Mattflaschen) [06:59:11] (03Merged) 10jenkins-bot: refactor and extend usability (v 3.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/163544 (owner: 10Pastakhov) [07:10:39] 3MediaWiki / 3MediaWiki UI: Make use of an icon font like Font Awesome - 10https://bugzilla.wikimedia.org/71525#c5 (10Matthew Flaschen) 5NEW>3RESO/WON Clarifying that for now this is a WONTFIX for web. I.E. MediaWiki itself will not use an actual font file for now, for the reasons given in that wikitech... [07:21:17] (03PS1) 10Lilu: PermissionManager-ArticleRights [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/168256 [07:21:23] 3MediaWiki / 3Database: missing 'patch-add_interwiki.sql' for the includes/installer/PostgresqlUpdater.php - 10https://bugzilla.wikimedia.org/69360#c3 (10Andre Klapper) Anton: Can you please answer comment 2? [07:29:23] 3MediaWiki / 3File management: abbrvThreshold mismatch between commons as foreign repo and local commons breaking images with long names - 10https://bugzilla.wikimedia.org/72389#c6 (10Tisza Gergő) (In reply to Bawolff (Brian Wolff) from comment #1) > Appears to be accientally caused by f7be7e6a (Abbreviation... [07:47:10] 3MediaWiki / 3File management: thumb.php: If upscale: Return original image instead of error - 10https://bugzilla.wikimedia.org/72328 (10Andre Klapper) p:5Normal>3Lowest [07:53:20] (03CR) 10Gergő Tisza: "I think this will use $wgEditPageFrameOptions instead of $wgApiFrameOptions. Also, the api.php help page (which you get e.g. when sending " (032 comments) [core] - 10https://gerrit.wikimedia.org/r/168235 (https://bugzilla.wikimedia.org/72340) (owner: 10Brian Wolff) [07:53:40] (03CR) 10Gergő Tisza: [C: 04-1] Respect $wgApiFrameOptions in formatted API output mode [core] - 10https://gerrit.wikimedia.org/r/168235 (https://bugzilla.wikimedia.org/72340) (owner: 10Brian Wolff) [08:08:54] 3MediaWiki / 3JavaScript: jquery.textSelection in core hardcodes checks for WikiEditor's iframe - 10https://bugzilla.wikimedia.org/29328#c14 (10Bartosz Dziewoński) 5PATC>3RESO/FIX So… this is really fixed now, isn't it? [08:20:53] (03CR) 10Robert Vogel: [C: 032 V: 032] Improved expression (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/168083 (owner: 10Smuggli) [08:22:59] (03CR) 10Robert Vogel: [C: 032 V: 032] Show blog as only active item in TopMenu [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/168051 (owner: 10Mglaser) [08:28:54] 3MediaWiki / 3User login and signup: "Username taken" warning is too fast and alarming - 10https://bugzilla.wikimedia.org/71744#c1 (10Bartosz Dziewoński) (In reply to Nemo from comment #0) > * A simple improvement might be to "fire" the warning only some (fraction > of) seconds after the user has stopped typ... [08:30:09] (03PS2) 10EBernhardson: Bug: getUserLinks wrong output for anons [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168251 [08:30:12] (03PS4) 10EBernhardson: Hygiene: Move RecentChangeListener to Listener namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165427 [08:30:15] (03PS2) 10EBernhardson: Hygiene: Dont reach out to $wgTitle [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168252 [08:30:18] (03PS6) 10EBernhardson: Hygiene: Simplify listener for inserting RecentChange [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165426 [08:30:21] (03PS28) 10EBernhardson: Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [08:30:24] (03PS1) 10EBernhardson: Validate UserTuple constructor input [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168258 [08:30:27] (03PS1) 10EBernhardson: Hygiene: Use real objects instead of mocks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168259 [08:30:58] (03CR) 10jenkins-bot: [V: 04-1] Bug: getUserLinks wrong output for anons [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168251 (owner: 10EBernhardson) [08:31:04] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move RecentChangeListener to Listener namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165427 (owner: 10EBernhardson) [08:31:21] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Simplify listener for inserting RecentChange [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165426 (owner: 10EBernhardson) [08:31:24] (03CR) 10jenkins-bot: [V: 04-1] Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [08:31:38] (03CR) 10jenkins-bot: [V: 04-1] Validate UserTuple constructor input [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168258 (owner: 10EBernhardson) [08:31:49] (03PS3) 10Robert Vogel: PermissionManager-Bugfixes [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/168053 (owner: 10Lilu) [08:33:44] (03CR) 10Robert Vogel: [C: 032 V: 032] "Looks OK. I just implemented some comments from Stephan." [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/168053 (owner: 10Lilu) [08:34:08] 3MediaWiki / 3Export/Import: Call ContentHandler::exportTransform in backupTextPass.inc and friends - 10https://bugzilla.wikimedia.org/72361 (10Daniel Kinzler) 5NEW>3ASSI [08:34:34] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use real objects instead of mocks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168259 (owner: 10EBernhardson) [08:38:51] (03PS1) 10Robert Vogel: Merge branch 'master' into review/lilu/PermissionManager-ArticlePermissions [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/168260 [08:40:53] (03Abandoned) 10Robert Vogel: Merge branch 'master' into review/lilu/PermissionManager-ArticlePermissions [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/168260 (owner: 10Robert Vogel) [08:41:11] (03PS2) 10Robert Vogel: PermissionManager-ArticleRights [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/168256 (owner: 10Lilu) [08:41:36] (03CR) 10Robert Vogel: [C: 032 V: 032] PermissionManager-ArticleRights [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/168256 (owner: 10Lilu) [08:41:38] (03CR) 10Bartosz Dziewoński: "So what do we need here, just a test? Let's do that, I want to get this done." [core] - 10https://gerrit.wikimedia.org/r/164886 (https://bugzilla.wikimedia.org/64570) (owner: 10saper) [08:41:41] (03PS6) 10Bartosz Dziewoński: mediawiki.api: Transform arrays with join('|') in query parameters [core] - 10https://gerrit.wikimedia.org/r/164886 (https://bugzilla.wikimedia.org/64570) (owner: 10saper) [08:45:48] (03PS7) 10Bartosz Dziewoński: mediawiki.api: Transform arrays with join('|') in query parameters [core] - 10https://gerrit.wikimedia.org/r/164886 (https://bugzilla.wikimedia.org/64570) (owner: 10saper) [08:46:40] 3MediaWiki / 3API: Many false positive warnings about missing continuation parameter - 10https://bugzilla.wikimedia.org/72415 (10Michael M.) 3NEW p:3Unprio s:3minor a:3None The API shows the warning about missing continuation parameters even when it is inappropriate. Many false positive warnings will... [08:50:51] (03PS1) 10Bartosz Dziewoński: mediawiki.ui: Add 'background-color: inherit' to match 'color: inherit' [core] - 10https://gerrit.wikimedia.org/r/168261 (https://bugzilla.wikimedia.org/72192) [08:50:58] (03CR) 10Bartosz Dziewoński: "Added a test. Krinkle, recheck?" [core] - 10https://gerrit.wikimedia.org/r/164886 (https://bugzilla.wikimedia.org/64570) (owner: 10saper) [09:01:30] (03PS1) 10Foxtrott: Doc updates [skins/chameleon] - 10https://gerrit.wikimedia.org/r/168262 [09:02:56] 3MediaWiki / 3Export/Import: Put the and tags before the tag. - 10https://bugzilla.wikimedia.org/72417 (10Daniel Kinzler) 3NEW p:3Unprio s:3normal a:3None According to export-0.9.xsd, the and tags follow the tag. That is however quite annoying when proc... [09:03:38] 3MediaWiki / 3Export/Import: Call ContentHandler::exportTransform in backupTextPass.inc and friends - 10https://bugzilla.wikimedia.org/72361 (10Daniel Kinzler) [09:03:39] 3MediaWiki / 3Export/Import: Put the and tags before the tag. - 10https://bugzilla.wikimedia.org/72417 (10Daniel Kinzler) [09:03:53] 3MediaWiki / 3Export/Import: Put the and tags before the tag. - 10https://bugzilla.wikimedia.org/72417 (10Daniel Kinzler) [09:04:10] (03Abandoned) 10Foxtrott: Fix TOC layout [skins/chameleon] - 10https://gerrit.wikimedia.org/r/168176 (owner: 10Foxtrott) [09:04:23] 3MediaWiki / 3Export/Import: Put the and tags before the tag. - 10https://bugzilla.wikimedia.org/72417#c1 (10Daniel Kinzler) Point in case: bug 72361 would be a lot easier to fix if model and format would appear before text in the xml event stream. [09:06:08] (03PS2) 10Foxtrott: Doc updates [skins/chameleon] - 10https://gerrit.wikimedia.org/r/168262 [09:06:34] (03CR) 10Foxtrott: [C: 032 V: 032] Doc updates [skins/chameleon] - 10https://gerrit.wikimedia.org/r/168262 (owner: 10Foxtrott) [09:26:24] (03CR) 10Zfilipin: "check experimental" [core] - 10https://gerrit.wikimedia.org/r/167794 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [10:08:17] (03PS1) 10Zfilipin: Prepare repository for running RuboCop after every push to Gerrit [vagrant] - 10https://gerrit.wikimedia.org/r/168264 (https://bugzilla.wikimedia.org/69245) [10:43:20] (03PS1) 10Aude: Update Wikidata branch to wmf/1.25wmf5 [tools/release] - 10https://gerrit.wikimedia.org/r/168268 [10:48:59] (03PS1) 10Yuvipanda: [WIP] Add Hiera: namespace with YAML content model [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/168269 [10:54:36] (03PS2) 10Yuvipanda: [WIP] Add Hiera: namespace with YAML content model [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/168269 [10:57:58] (03PS3) 10Yuvipanda: [WIP] Add Hiera: namespace with YAML content model [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/168269 [11:00:16] (03CR) 10Smuggli: Improved expression (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/168083 (owner: 10Smuggli) [11:04:18] (03PS4) 10Yuvipanda: [WIP] Add Hiera: namespace with YAML content model [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/168269 [11:06:44] (03PS5) 10Yuvipanda: [WIP] Add Hiera: namespace with YAML content model [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/168269 [11:10:32] duh: do you know if / how I can create a custom protection level? [11:10:47] duh: specifically, I want pages in the Hiera namespace only be editable by project admins for that project [11:10:56] so Hiera:Tools should only be editable if you've projectadmin on tools, etc [11:11:20] phuedx: ^ if you know as well [11:13:22] YuviPanda: $wgNamespaceProtection, perhaps? [11:13:35] you'd probably need a specific user group too [11:13:36] Glaisher: nope, that only lets you restrict based on rights [11:13:39] and I need something more custom [11:13:45] yeah, I don't have a specific user group [11:13:49] and it's also different per page [11:14:09] I could just abort the edit from being saved, but that feels suboptimal [11:22:38] (03PS6) 10Yuvipanda: [WIP] Add Hiera: namespace with YAML content model [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/168269 [11:28:17] Glaisher: btw, found what I'm looking for - userCan and related hooks should do it [11:32:44] (03CR) 10Gergő Tisza: [C: 031] Make $wgMWLoggerDefaultSpi more expressive [core] - 10https://gerrit.wikimedia.org/r/168253 (owner: 10BryanDavis) [11:45:08] 3MediaWiki / 3Database: Option to restrict view counter per namespace - 10https://bugzilla.wikimedia.org/27576#c6 (10Subfader) Very bad decision imo. [11:45:42] (03PS7) 10Yuvipanda: [WIP] Add Hiera: namespace with YAML content model [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/168269 [11:47:27] (03CR) 10Gergő Tisza: [C: 04-1] Add logging context to database logs (032 comments) [core] - 10https://gerrit.wikimedia.org/r/141599 (owner: 10BryanDavis) [11:51:25] 3MediaWiki / 3General/Unknown: Bring back the view counter and make it optional - 10https://bugzilla.wikimedia.org/72420 (10Subfader) 3NEW p:3Unprio s:3major a:3None The view counter was removed in https://gerrit.wikimedia.org/r/#/c/150699/ But this is an essential to determine which pages are most... [11:52:09] 3MediaWiki / 3General/Unknown: Bring back the view counter and make it optional - 10https://bugzilla.wikimedia.org/72420 (10Subfader) p:5Unprio>3High [11:54:58] (03PS8) 10Yuvipanda: [WIP] Add Hiera: namespace with YAML content model [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/168269 [11:57:33] (03PS9) 10Yuvipanda: [WIP] Add Hiera: namespace with YAML content model [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/168269 [12:03:08] 3MediaWiki / 3File management: thumb.php: If upscale: Return original image instead of error - 10https://bugzilla.wikimedia.org/72328#c4 (10Subfader) Check if viewport has enough width to display the 500px image. Call thumb.php?f=Foo.jpg&w=500 > Displays a 500px thumb or a smaller original How does return... [12:05:32] (03PS10) 10Yuvipanda: Add Hiera: namespace with YAML content model [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/168269 [12:07:05] duh: I've mostly implemented what I wanted, CR at https://gerrit.wikimedia.org/r/#/c/168269/ would be helpful [12:08:10] 3MediaWiki / 3Patrolling: Add Extension:Patroller to core - 10https://bugzilla.wikimedia.org/71607#c3 (10Subfader) Since this exention I no more use Special:Recentchanges I also pimped it a bit to display the current page view at the bottom. [12:23:36] (03PS11) 10Krinkle: Add Hiera namespace with YAML content model [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/168269 (owner: 10Yuvipanda) [12:24:15] (03PS1) 10Reedy: [WIP] LocalisationUpdate needs to support updating skins as well as extensions [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/168274 (https://bugzilla.wikimedia.org/67154) [12:24:40] 3MediaWiki extensions / 3CentralNotice: Multiselects in Special:CentralNotice sometimes load incorrectly - 10https://bugzilla.wikimedia.org/72421 (10Peter Coombe) 3NEW p:3Unprio s:3normal a:3None Created attachment 16865 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16865&action=edit screens... [12:25:41] (03PS1) 10Florianschmidtwelzow: Prepare use of MediaWikiUIEverywhere [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/168275 [12:28:08] 3MediaWiki / 3User login and signup: "Username taken" warning is too fast and alarming - 10https://bugzilla.wikimedia.org/71744#c2 (10Nemo) (In reply to Bartosz Dziewoński from comment #1) > This delay was > mostly added to prevent unnecessary network requests rather than as user > experience improvement, pe... [12:50:41] 3Wikimedia / 3Site requests: add mergehistory - 10https://bugzilla.wikimedia.org/72422 (10Wim b) 3NEW p:3Unprio s:3normal a:3None Hi, Community of it.wikt approved by consensus ( https://it.wiktionary.org/w/index.php?title=Wikizionario:Bar&oldid=2204183#Funzione_per_gli_importatori ), enabling the m... [12:53:22] (03PS3) 10Daniel Kinzler: Apply exportTarnsform in backupTextPass.inc [core] - 10https://gerrit.wikimedia.org/r/168126 [12:53:49] (03PS4) 10Daniel Kinzler: Apply exportTarnsform in backupTextPass.inc [core] - 10https://gerrit.wikimedia.org/r/168126 (https://bugzilla.wikimedia.org/72361) [12:55:03] (03PS2) 10Reedy: [WIP] LocalisationUpdate needs to support updating skins as well as extensions [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/168274 (https://bugzilla.wikimedia.org/67154) [12:58:26] (03PS3) 10Reedy: [WIP] LocalisationUpdate needs to support updating skins as well as extensions [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/168274 (https://bugzilla.wikimedia.org/67154) [12:59:00] (03PS5) 10Daniel Kinzler: Apply exportTarnsform in backupTextPass.inc [core] - 10https://gerrit.wikimedia.org/r/168126 [13:01:37] (03CR) 10Zfilipin: [C: 04-1] "See inline comments." (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167448 (owner: 10Cmcmahon) [13:03:27] (03CR) 10Nikerabbit: "Does this apply to the search string as well, i.e. does search "ä" find article like "aasia"?" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/168071 (https://bugzilla.wikimedia.org/67521) (owner: 10Manybubbles) [13:05:31] (03CR) 10Zfilipin: "Antoine, what needs to happen so mediawiki-core-bundle-rubocop ignores extensions?" [core] - 10https://gerrit.wikimedia.org/r/167794 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [13:12:02] (03PS6) 10Daniel Kinzler: Apply exportTarnsform in backupTextPass.inc [core] - 10https://gerrit.wikimedia.org/r/168126 (https://bugzilla.wikimedia.org/72361) [13:13:24] 3Wikimedia / 3Site requests: Enable mergehistory right of transwiki group on it.wiktionary.org - 10https://bugzilla.wikimedia.org/72422 (10Andre Klapper) p:5Unprio>3Normal s:5normal>3enhanc [13:22:53] 3MediaWiki / 3General/Unknown: Bring back the view counter and make it optional - 10https://bugzilla.wikimedia.org/72420#c1 (10Andre Klapper) p:5High>3Lowest s:5major>3enhanc Setting priorities is left to developers, hence resetting. The commit message says "For proper metrics, it is suggested to us... [13:25:10] 3MediaWiki / 3API: "createaccount" action failure should return the name of the extension that caused it to fail. - 10https://bugzilla.wikimedia.org/72387 (10Andre Klapper) p:5Unprio>3Normal [13:25:12] 3MediaWiki / 3API: Many false positive warnings about missing continuation parameter - 10https://bugzilla.wikimedia.org/72415 (10Andre Klapper) p:5Unprio>3Low [13:25:12] 3MediaWiki extensions / 3CentralNotice: Multiselects in Special:CentralNotice sometimes load incorrectly - 10https://bugzilla.wikimedia.org/72421 (10Andre Klapper) p:5Unprio>3Normal [13:25:12] 3MediaWiki / 3API: API and OAuth malfunction - 10https://bugzilla.wikimedia.org/72384 (10Andre Klapper) p:5Unprio>3High [13:26:08] 3OCG / 3General/Unknown: Wikimedia Italia's cotton book (tracking) - 10https://bugzilla.wikimedia.org/72372 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc [13:30:54] 3OCG / 3General/Unknown: Wikimedia Italia's Cotton book (tracking) - 10https://bugzilla.wikimedia.org/72372 (10Ricordisamoa) [13:34:24] 3MediaWiki extensions / 3Scribunto: Provide a standard way to get the target of a redirect page - 10https://bugzilla.wikimedia.org/66974 (10Ricordisamoa) a:3Ricordisamoa [13:34:36] (03PS1) 10Ricordisamoa: Provide a standard way to get the target of a redirect page [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/168282 [13:41:20] (03CR) 10Ricordisamoa: "There is some duplicated code between redirectTarget() and getContent()." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/168282 (owner: 10Ricordisamoa) [13:43:02] (03CR) 10Ottomata: "(I don't know much about mediawiki so I don't know how this works...)" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/168269 (owner: 10Yuvipanda) [13:53:55] (03PS5) 10Umherirrender: Remove unneeded row seek in Special:Watchlist [core] - 10https://gerrit.wikimedia.org/r/161582 [13:54:38] (03CR) 10Hoo man: [C: 04-1] "I agree that we should fix this fast, but think that we should fix it properly (if possible) and not using such hacks that introduce redun" [core] - 10https://gerrit.wikimedia.org/r/168126 (https://bugzilla.wikimedia.org/72361) (owner: 10Daniel Kinzler) [14:02:08] 3MediaWiki / 3Export/Import: Put the and tags before the tag in the XML dumps. - 10https://bugzilla.wikimedia.org/72417 (10Daniel Kinzler) [14:02:23] 3MediaWiki / 3General/Unknown: Bring back the view counter and make it optional - 10https://bugzilla.wikimedia.org/72420#c2 (10Chad H.) It already was optional. If an identical implementation is desired for some reason, I'd suggest implementing it as an extension. [14:11:15] (03CR) 10Aude: [C: 04-1] "typo" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/168126 (https://bugzilla.wikimedia.org/72361) (owner: 10Daniel Kinzler) [14:12:34] (03PS7) 10Daniel Kinzler: Apply exportTransform in backupTextPass.inc [core] - 10https://gerrit.wikimedia.org/r/168126 (https://bugzilla.wikimedia.org/72361) [14:14:04] (03CR) 10Daniel Kinzler: "@hoo so you mean that you want bug 72417 fixed first?" [core] - 10https://gerrit.wikimedia.org/r/168126 (https://bugzilla.wikimedia.org/72361) (owner: 10Daniel Kinzler) [14:14:58] (03CR) 10Aude: Apply exportTransform in backupTextPass.inc (031 comment) [core] - 10https://gerrit.wikimedia.org/r/168126 (https://bugzilla.wikimedia.org/72361) (owner: 10Daniel Kinzler) [14:15:23] 3MediaWiki / 3Export/Import: Call ContentHandler::exportTransform in backupTextPass.inc and friends - 10https://bugzilla.wikimedia.org/72361#c3 (10Daniel Kinzler) Making this depend on bug 72417 following Hoo's comment on the patch. [14:15:27] (03CR) 10Aude: Apply exportTransform in backupTextPass.inc (031 comment) [core] - 10https://gerrit.wikimedia.org/r/168126 (https://bugzilla.wikimedia.org/72361) (owner: 10Daniel Kinzler) [14:15:37] 3MediaWiki / 3Export/Import: Put the and tags before the tag in the XML dumps. - 10https://bugzilla.wikimedia.org/72417 (10Daniel Kinzler) [14:16:20] <^d> Krinkle|detached: Yes, we can remove those branches. Just a matter of someone taking the time to turn them to tags [14:16:45] <^d> (and actually, that can happen as soon as we're no longer porting changes to a branch and it's closed) [14:19:45] (03CR) 10Aude: Apply exportTransform in backupTextPass.inc (032 comments) [core] - 10https://gerrit.wikimedia.org/r/168126 (https://bugzilla.wikimedia.org/72361) (owner: 10Daniel Kinzler) [14:29:50] (03PS8) 10Daniel Kinzler: Apply exportTransform in backupTextPass.inc [core] - 10https://gerrit.wikimedia.org/r/168126 (https://bugzilla.wikimedia.org/72361) [14:30:09] (03PS11) 10Robert Vogel: [WIP] Notifications [extensions/Teahouse] - 10https://gerrit.wikimedia.org/r/166749 [14:31:03] (03CR) 10Rush: [C: 032 V: 032] Policy Enforcer should not remove user-submitted projects [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/168141 (owner: 1020after4) [14:31:34] (03CR) 10Hoo man: "@Daniel: Yes, and then probably abandon this one." [core] - 10https://gerrit.wikimedia.org/r/168126 (https://bugzilla.wikimedia.org/72361) (owner: 10Daniel Kinzler) [14:34:49] (03PS12) 10Robert Vogel: [WIP] Notifications [extensions/Teahouse] - 10https://gerrit.wikimedia.org/r/166749 [14:36:40] 3MediaWiki / 3Export/Import: Put the and tags before the tag in the XML dumps. - 10https://bugzilla.wikimedia.org/72417#c2 (10Nemo) Do Special:Import and importDump.php care about the order of XML tags? I hope not, but they don't always behave logically. :) [14:39:51] (03PS2) 10Reedy: API: Include ApiMain construction in api.php try-catch block [core] - 10https://gerrit.wikimedia.org/r/168193 (https://bugzilla.wikimedia.org/72384) (owner: 10Anomie) [14:39:59] (03CR) 10Reedy: [C: 032] "LGTM" [core] - 10https://gerrit.wikimedia.org/r/168193 (https://bugzilla.wikimedia.org/72384) (owner: 10Anomie) [14:46:10] (03Merged) 10jenkins-bot: API: Include ApiMain construction in api.php try-catch block [core] - 10https://gerrit.wikimedia.org/r/168193 (https://bugzilla.wikimedia.org/72384) (owner: 10Anomie) [14:46:21] (03PS1) 10Anomie: API: Include ApiMain construction in api.php try-catch block [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168296 (https://bugzilla.wikimedia.org/72384) [14:48:07] 3MediaWiki / 3API: API and OAuth malfunction - 10https://bugzilla.wikimedia.org/72384#c8 (10Brad Jorsch) 5PATC>3UNCO (In reply to Magnus Manske from comment #5) > Try a browser where you haven't used my Widar OAuth "proxy tool" (if ever). > This URL > > http://tools.wmflabs.org/widar/index.php?action=ge... [14:53:01] hi andre__! [14:53:07] (03CR) 10Ricordisamoa: "What about implementing Content::getUltimateRedirectTarget() too?" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/168282 (owner: 10Ricordisamoa) [14:53:08] hi dbrant [14:54:05] andre__: I just realized that I don't seem to be on the default CC list for new Android bugs... are you the right person to ask about that? [14:54:11] dbrant, yes [14:54:16] which product? [14:54:22] 3Wikimedia / 3Bugzilla: Accessing bug 9444 via XML RPC API crashes due to invalid byte sequence: "not well-formed (invalid token)" - 10https://bugzilla.wikimedia.org/69747#c9 (10Andre Klapper) Note: As this workaround is applied to *any* output if also damages binary attachment data. See https://phabricator.... [14:54:34] https://bugzilla.wikimedia.org/describeproducts.cgi [14:54:47] argh. https://bugzilla.wikimedia.org/describecomponents.cgi I meant [14:55:03] andre__: Wikipedia App -> Android App [14:55:40] dbrant, yeah, you were not on default CC. I have added you now but that will only affect future bugs filed [14:55:56] andre__: awesome; thanks! [14:55:57] if you want to be CC'ed on existing open tickets you or I can mass-edit them to add you [14:56:29] that's ok, as long as I'm aware of new ones [14:57:42] (03CR) 10BryanDavis: "recheck" [core] - 10https://gerrit.wikimedia.org/r/119941 (owner: 10BryanDavis) [15:00:12] (03PS2) 10Anomie: API: Fix ApiFormatFeedWrapper [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168128 (https://bugzilla.wikimedia.org/72359) [15:00:20] (03CR) 10Anomie: [C: 032] "SWAT" [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168128 (https://bugzilla.wikimedia.org/72359) (owner: 10Anomie) [15:05:28] (03PS1) 10Smuggli: Rewrite of NamespaceNuker [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/168299 [15:06:53] 3MediaWiki / 3API: API and OAuth malfunction - 10https://bugzilla.wikimedia.org/72384#c9 (10Magnus Manske) I have tried quite a few times now, and never got the Internal Server Error, nor did I get an IP-as-a-name. Everything looks like it should! [15:07:17] (03Merged) 10jenkins-bot: API: Fix ApiFormatFeedWrapper [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168128 (https://bugzilla.wikimedia.org/72359) (owner: 10Anomie) [15:07:40] 3Wikimedia / 3General/Unknown: Videos invisible on commons - 10https://bugzilla.wikimedia.org/72429 (10Steinsplitter) 3NEW p:3Unprio s:3major a:3None All OVG videos are no longer visible in any browser (FF, other not tested). See also: https://commons.wikimedia.org/w/index.php?title=Commons:Village_... [15:08:33] 3Wikimedia / 3General/Unknown: Videos invisible on commons - 10https://bugzilla.wikimedia.org/72429 (10Steinsplitter) p:5Unprio>3High [15:11:08] 3Wikimedia / 3General/Unknown: Videos invisible on commons - 10https://bugzilla.wikimedia.org/72429#c1 (10Steinsplitter) Related to [[Bug 61823]]? [15:11:34] (03PS2) 10Anomie: API: Include ApiMain construction in api.php try-catch block [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168296 (https://bugzilla.wikimedia.org/72384) [15:11:45] (03CR) 10Anomie: [C: 032] "SWAT" [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168296 (https://bugzilla.wikimedia.org/72384) (owner: 10Anomie) [15:12:37] 3MediaWiki / 3API: feedrecentchanges returns zero bytes on 1.25wmf4 - 10https://bugzilla.wikimedia.org/72359#c8 (10Brad Jorsch) 5PATC>3RESO/FIX Backported, should be working now on all WMF wikis. [15:13:37] 3MediaWiki / 3API: API and OAuth malfunction - 10https://bugzilla.wikimedia.org/72384#c10 (10Brad Jorsch) (In reply to Magnus Manske from comment #9) > I have tried quite a few times now, and never got the Internal Server Error, > nor did I get an IP-as-a-name. Everything looks like it should! That's intere... [15:18:53] (03Merged) 10jenkins-bot: API: Include ApiMain construction in api.php try-catch block [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168296 (https://bugzilla.wikimedia.org/72384) (owner: 10Anomie) [15:20:40] (03CR) 10Legoktm: "Why not just use JSON?" (034 comments) [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/168269 (owner: 10Yuvipanda) [15:22:24] 3MediaWiki / 3API: API and OAuth malfunction - 10https://bugzilla.wikimedia.org/72384#c12 (10Brad Jorsch) Now it's merged, and the test link from comment 5 is reporting an API error rather than Internal Server Error. Feel free to close this as RESOLVED FIXED if you can't reproduce anymore. [15:26:41] (03CR) 10Anomie: [C: 032] "Let's do it. I agree the performance impact should be minimal, and something along these lines is necessary." (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/168074 (https://bugzilla.wikimedia.org/61556) (owner: 10Jackmcbarn) [15:26:51] (03Merged) 10jenkins-bot: Support protocol-relative URLs in the whitelist [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/168074 (https://bugzilla.wikimedia.org/61556) (owner: 10Jackmcbarn) [15:27:22] 3MediaWiki extensions / 3CentralNotice: Multiselects in Special:CentralNotice sometimes load incorrectly - 10https://bugzilla.wikimedia.org/72421#c1 (10Glaisher) Yes. I've also seen this happen on Chrome, not on any other browser though. [15:36:28] (03PS1) 10Smuggli: Adjusted boosts [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/168304 [15:43:54] (03CR) 10Hashar: "> Why not just use JSON?" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/168269 (owner: 10Yuvipanda) [15:46:03] does anyone here know how I can commit only the last n commits (in my case top 3) to gerrit review? [15:46:30] I was developing in github, then someone else pushed all those commits directly to the repo [15:46:57] but now they're showing up as ready to review in gerrit review, but they've all been merged except for the top 3 I'm trying to continue with [15:47:26] essentially I want to ignore/forget about the commits before my top 3, forever [15:47:43] (as far as review is concerned) [15:48:45] just read that wikitech-l thread about tech debt [15:48:50] looks like it would be based on https://insight.sensiolabs.com/projects/8b5d527f-f70c-4fc0-977f-de99743eae06/analyses/16 [15:48:53] (03PS31) 10Paladox: Update jQuery Cookie to v1.4.1 [core] - 10https://gerrit.wikimedia.org/r/139686 [15:49:03] anyone? [15:49:15] but specifically, the "Global variable or function should never be used" section - about 1 day to fix each item? [15:49:35] pizzzacat: Have you rebased your working branch on the current HEAD? [15:49:49] (03PS1) 10Cacycle: Version 1.2.4 (October 23, 2014) [extensions/WikEdDiff] - 10https://gerrit.wikimedia.org/r/168307 [15:50:02] and this only shows 1000 of the "issues" [15:50:09] pizzzacat: If you have, even if gerrit is telling you that it will push a bunch of things you don't want it is probably just confused [15:50:33] bd808, you mean rebase my last 3 commits onto gerrit master? [15:51:05] pizzzacat: Something like `git fetch; git rebase origin/master` usually works [15:51:07] pizzzacat, "git fetch gerrit" [15:51:08] oh you think it won't actually push the ones before those? I'm so nervous to try it because there are srsly like 25 [15:51:22] if it thinks it's submitting changes that have already been merged [15:51:31] pizzzacat: Meh. worst case is you abandon the junk that gets made in gerrit [15:51:40] yes bd808 I have [15:51:49] (03CR) 10Cacycle: [C: 032 V: 032] Version 1.2.4 (October 23, 2014) [extensions/WikEdDiff] - 10https://gerrit.wikimedia.org/r/168307 (owner: 10Cacycle) [15:51:53] yeah that's what I was thinking might have to happen. [15:51:56] But I've never had it actually make junk even when it gives the scary warning [15:52:17] the fun thing is that I have to add commit messages to like 8 commits though [15:52:20] pizzzacat, did you run the command? [15:52:35] Krenair yes I already did that [15:52:51] what does running 'git review' show now then? [15:53:00] (03CR) 10Raimond Spekking: [C: 031] "i18n review" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/168299 (owner: 10Smuggli) [15:53:19] the same thing, Krenair [15:53:29] ok, pastebin? [15:53:29] it's all up to date and everything [15:53:37] pastebin? [15:53:48] !paste [15:53:48] http://tools.wmflabs.org/paste [15:53:52] (03CR) 10Ricordisamoa: "Any updates?" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/67588 (https://bugzilla.wikimedia.org/41498) (owner: 10Brian Wolff) [15:54:23] Krenair: Heh. That sensiolabs report is cute. "All code must be in classes!" is so very java [15:54:31] (03CR) 10Anomie: [C: 04-1] "I'm *almost* inclined to -2 this, since I can't think of a situation where someone would want "SAMEORIGIN" over "DENY" for the human-forma" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/168235 (https://bugzilla.wikimedia.org/72340) (owner: 10Brian Wolff) [15:54:43] (03CR) 10Legoktm: "I don't enough about Hiera, but JSON is a valid subset of YAML, which is why I thought it might work." [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/168269 (owner: 10Yuvipanda) [15:55:19] I like the estimate that it will take 11.5 years to fix all the problems though. That sounds about right. [15:55:29] Krenair: http://gw.gd/wKRl [15:55:59] ok, no idea what your remotes are [15:56:11] it's complicated [15:56:14] because [15:56:32] I was developing in github, then someone else took those commits [15:56:43] do you have a 'gerrit' remote? [15:56:51] merged them, then put them into the actual wikimedia repo [15:56:55] no [15:56:59] it's origin for me [15:56:59] (03PS21) 10BryanDavis: Use MWLogger logging for legacy logging methods [core] - 10https://gerrit.wikimedia.org/r/119941 [15:57:07] in maintenance/eval.php, line 92 [15:57:11] var_dump() should only be used for debug, and not committed to the source code repository. [15:57:13] lol [15:57:24] pizzzacat, git remote -v [15:57:30] tell me what your origin is [15:58:05] gerrit [15:58:14] ssh://ssmith@gerrit.wikimedia.org:29418/wikimedia/fundraising/dash.git [15:58:34] so "git fetch origin"? [15:58:52] yes, I did that [15:59:05] and that's where we're at :-/ [15:59:43] I'm thinking I'm just going to have to push everything to review [15:59:57] and go in and abandon alllll those patches if they show up [16:00:13] but before I do that, I get to handle the fact that several of those patches don't have commit messages [16:00:20] since this was partially done in github. [16:00:38] so that's why I was hoping there was an easier way, to cut out everything I don't want [16:00:46] so I don't have to double back twice [16:00:55] over patches that I don't want to exist [16:00:59] oh well [16:01:08] do you have a 'gerrit' remote? [16:01:18] nope. just github and origin. [16:01:25] right [16:01:26] gerrit is origin. [16:01:53] why? [16:01:58] does it change something? [16:02:17] I know there is the https gerrit one and origin ssh one, [16:02:21] typically [16:02:28] that should make no difference [16:02:34] ok that's what I was thinking [16:02:43] but since you asked me a few times I was wondering why :) [16:03:50] do you have a .gitreview file? [16:03:54] yep [16:04:12] I'm just going to do the painful way. [16:04:28] sadly. [16:11:31] (03CR) 10Gergő Tisza: [C: 032] Add ImageMetrics submodule [core] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/167723 (https://bugzilla.wikimedia.org/70402) (owner: 10Gergő Tisza) [16:11:43] (03CR) 10Gergő Tisza: [C: 032] Add ImageMetrics submodule [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167724 (https://bugzilla.wikimedia.org/70402) (owner: 10Gergő Tisza) [16:17:56] (03Merged) 10jenkins-bot: Add ImageMetrics submodule [core] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/167723 (https://bugzilla.wikimedia.org/70402) (owner: 10Gergő Tisza) [16:18:24] (03Merged) 10jenkins-bot: Add ImageMetrics submodule [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167724 (https://bugzilla.wikimedia.org/70402) (owner: 10Gergő Tisza) [16:20:24] (03PS14) 10BryanDavis: Use MWLogger logging for wfLogProfilingData [core] - 10https://gerrit.wikimedia.org/r/119942 [16:21:28] (03CR) 10BryanDavis: Use MWLogger logging for legacy logging methods (031 comment) [core] - 10https://gerrit.wikimedia.org/r/119941 (owner: 10BryanDavis) [16:23:22] 3MediaWiki / 3API: "createaccount" action failure should return the name of the extension that caused it to fail. - 10https://bugzilla.wikimedia.org/72387#c2 (10Brad Jorsch) The API-specific hooks aren't actually necessary for this. AddNewAccountApiForm is really intended for mapping from parameters named in... [16:24:08] (03PS2) 10Siebrand: Rewrite of NamespaceNuker [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/168299 (owner: 10Smuggli) [16:25:34] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/168299 (owner: 10Smuggli) [16:26:29] (03CR) 10MarkAHershberger: "I didn't miss your earlier comment, "git review" just thought it needed to push again." [tools/release] - 10https://gerrit.wikimedia.org/r/164288 (owner: 10MarkAHershberger) [16:28:46] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." (031 comment) [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/168196 (owner: 10Florianschmidtwelzow) [16:30:32] (03CR) 10Legoktm: [C: 032] Extensions may add tests by directory [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/168207 (https://bugzilla.wikimedia.org/70630) (owner: 10Awight) [16:31:43] (03CR) 10Legoktm: [C: 032] Fix string callbacks for special page registration [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/162908 (owner: 10Aude) [16:32:02] (03CR) 10Siebrand: Change link target of HHVM tag to [[mw:HHVM/About]] (031 comment) [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/168234 (owner: 10Ori.livneh) [16:32:35] (03PS9) 10BryanDavis: Add logging context to database logs [core] - 10https://gerrit.wikimedia.org/r/141599 [16:32:37] (03PS2) 10Umherirrender: Avoid implicit Message::toString in InfoAction [core] - 10https://gerrit.wikimedia.org/r/163158 [16:33:43] (03PS1) 10Legoktm: Use Special:MyLanguage in tag-HHVM message [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/168315 [16:33:45] siebrand: ^ [16:33:57] (03PS8) 10Jdlrobson: Use templates in core. [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/167114 [16:34:09] * siebrand jumps up and slaps a thundering high5 with legoktm [16:34:17] (03CR) 10Legoktm: Change link target of HHVM tag to [[mw:HHVM/About]] (031 comment) [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/168234 (owner: 10Ori.livneh) [16:34:21] (03PS12) 10Yuvipanda: Add Hiera: namespace with YAML content model [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/168269 [16:34:31] (03CR) 10Siebrand: [C: 032] "i18n/L10n reviewed." [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/168315 (owner: 10Legoktm) [16:34:40] :) [16:34:47] (03CR) 10jenkins-bot: [V: 04-1] Use templates in core. [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/167114 (owner: 10Jdlrobson) [16:35:11] and it hasn't been branched yet, woot. [16:37:04] (03Merged) 10jenkins-bot: Extensions may add tests by directory [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/168207 (https://bugzilla.wikimedia.org/70630) (owner: 10Awight) [16:37:19] (03CR) 10Yuvipanda: "@otto: Yes, this would provide YAML files per project. You can probably still use it on a per instance basis by structuring the data appro" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/168269 (owner: 10Yuvipanda) [16:37:50] (03Merged) 10jenkins-bot: Fix string callbacks for special page registration [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/162908 (owner: 10Aude) [16:37:52] (03Merged) 10jenkins-bot: Use Special:MyLanguage in tag-HHVM message [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/168315 (owner: 10Legoktm) [16:38:29] (03PS1) 10Jdlrobson: Switch to templates in core. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168317 [16:39:19] (03CR) 10jenkins-bot: [V: 04-1] Switch to templates in core. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168317 (owner: 10Jdlrobson) [16:40:46] (03CR) 10Siebrand: "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/159626 (owner: 10TheDJ) [16:40:49] (03PS13) 10Yuvipanda: Add Hiera: namespace with YAML content model [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/168269 [16:43:57] (03CR) 10Gergő Tisza: Respect $wgApiFrameOptions in formatted API output mode (031 comment) [core] - 10https://gerrit.wikimedia.org/r/168235 (https://bugzilla.wikimedia.org/72340) (owner: 10Brian Wolff) [16:46:46] (03PS2) 10Jdlrobson: Switch to templates in core. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168317 [16:46:49] (03CR) 10BryanDavis: Add Hiera: namespace with YAML content model (035 comments) [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/168269 (owner: 10Yuvipanda) [16:46:58] (03PS9) 10Jdlrobson: Use templates in core. [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/167114 [16:47:30] (03CR) 10jenkins-bot: [V: 04-1] Switch to templates in core. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168317 (owner: 10Jdlrobson) [16:47:43] (03PS1) 10Legoktm: Register directory with UnitTestsList hook [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/168321 [16:47:46] (03CR) 10jenkins-bot: [V: 04-1] Use templates in core. [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/167114 (owner: 10Jdlrobson) [16:49:16] YuviPanda|zzz: make sure you update https://www.mediawiki.org/wiki/Extension_default_namespaces#ID_600-699 [16:50:05] (03CR) 10Anomie: [C: 04-1] "> There is some duplicated code between redirectTarget() and getContent()" (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/168282 (owner: 10Ricordisamoa) [16:50:51] (03PS2) 10Legoktm: Register directory with UnitTestsList hook [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/168321 [16:51:06] hey legoktm : there is a script to manually authenticate the email id of a user right ? hoo have once shared the documentation with me once - cant find it now. anyidea what it is ? [16:51:12] (03CR) 10jenkins-bot: [V: 04-1] Register directory with UnitTestsList hook [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/168321 (owner: 10Legoktm) [16:51:52] tonythomas: you just want to manually confirm their email? [16:51:57] yeah [16:53:06] you can use eval.php [16:53:27] ok. [16:53:52] User::newFromName('FOoBar'); [16:53:55] er [16:53:58] $user = User::newFromName('FOoBar'); [16:54:03] $user->confirmEmail(); [16:54:19] <^d> Two lines is extra copy+pasting! [16:54:19] $user->saveSettings(); [16:54:30] <^d> Oh bleh, have to call saveSettings() [16:55:45] okey :) Thanks. let me try that one. [16:56:01] ( all my fake accounts got un-subscribed :D ) [16:56:23] 3MediaWiki extensions / 3Collection: "Preview with PediaPress" defunct - 10https://bugzilla.wikimedia.org/71675#c34 (10Erik Moeller) <3 Thanks for fixing this so quickly! :) [16:57:28] (03CR) 10Chad: [C: 032] Lookup namespaces with Elasticsearch [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/168194 (owner: 10Manybubbles) [16:57:32] (03CR) 10Jdlrobson: Add support for delivering templates via ResourceLoader (035 comments) [core] - 10https://gerrit.wikimedia.org/r/167342 (owner: 10Jdlrobson) [16:57:36] (03PS12) 10Jdlrobson: Add support for delivering templates via ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/167342 [16:57:45] (03CR) 10Chad: [C: 032] Update to support new version of Cirrus [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/168198 (owner: 10Manybubbles) [16:57:49] (03PS13) 10Jdlrobson: Add support for delivering templates via ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/167342 [16:58:25] worked. I should paste that in my blog [16:59:36] (03Merged) 10jenkins-bot: Lookup namespaces with Elasticsearch [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/168194 (owner: 10Manybubbles) [16:59:38] (03Merged) 10jenkins-bot: Update to support new version of Cirrus [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/168198 (owner: 10Manybubbles) [17:09:28] (03PS10) 10BryanDavis: Add logging context to database logs [core] - 10https://gerrit.wikimedia.org/r/141599 [17:11:51] (03CR) 10BryanDavis: "Patch set 9 and patch set 10 addresses the issues that Gergő pointed out." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/141599 (owner: 10BryanDavis) [17:12:09] (03CR) 10Nikerabbit: [C: 032] "It looks like RawMessage would be messy here, and this is an improvement." [core] - 10https://gerrit.wikimedia.org/r/163158 (owner: 10Umherirrender) [17:17:56] (03Merged) 10jenkins-bot: Avoid implicit Message::toString in InfoAction [core] - 10https://gerrit.wikimedia.org/r/163158 (owner: 10Umherirrender) [17:27:30] (03CR) 10Nikerabbit: [WIP] LocalisationUpdate needs to support updating skins as well as extensions (031 comment) [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/168274 (https://bugzilla.wikimedia.org/67154) (owner: 10Reedy) [17:31:32] (03PS3) 10Brian Wolff: Respect $wgApiFrameOptions in formatted API output mode [core] - 10https://gerrit.wikimedia.org/r/168235 (https://bugzilla.wikimedia.org/72340) [17:32:16] (03CR) 10Manybubbles: "Hey ^d, you +2ed something that depends on this to work properly in Cirrus. Want to do the same here? If we're going to change how this " [core] - 10https://gerrit.wikimedia.org/r/168167 (https://bugzilla.wikimedia.org/62322) (owner: 10Manybubbles) [17:33:00] (03CR) 10Chad: [C: 032] "How did I miss this? I totally reviewed it too." [core] - 10https://gerrit.wikimedia.org/r/168167 (https://bugzilla.wikimedia.org/62322) (owner: 10Manybubbles) [17:33:10] <^d> manybubbles_: mea culpa. [17:33:21] ^d: thanks! [17:33:26] (03CR) 10Brian Wolff: "Another argument for this change, is that there should not be backwards-compatibility breaks with clients which do weird things to work ar" [core] - 10https://gerrit.wikimedia.org/r/168235 (https://bugzilla.wikimedia.org/72340) (owner: 10Brian Wolff) [17:33:27] how did I get an underscore...... [17:34:22] (03PS1) 10MarkAHershberger: Fix E_STRICT warnings in MWSearch::getTextSnippet() [extensions/MWSearch] (REL1_24) - 10https://gerrit.wikimedia.org/r/168335 [17:34:40] (03CR) 10MarkAHershberger: [C: 032] Fix E_STRICT warnings in MWSearch::getTextSnippet() [extensions/MWSearch] (REL1_24) - 10https://gerrit.wikimedia.org/r/168335 (owner: 10MarkAHershberger) [17:34:46] (03CR) 10Brian Wolff: "I'm not sure what the usecase of framing API help would be. If you want I could change that too for consistency, but I'm unsure of the nee" [core] - 10https://gerrit.wikimedia.org/r/168235 (https://bugzilla.wikimedia.org/72340) (owner: 10Brian Wolff) [17:35:11] (03PS2) 10Ricordisamoa: Provide a standard way to get the target of a redirect page [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/168282 [17:35:42] (03CR) 10Chad: "Not sure why an E_STRICT fix for an extension all of 3 people use needs a backport :)" [extensions/MWSearch] (REL1_24) - 10https://gerrit.wikimedia.org/r/168335 (owner: 10MarkAHershberger) [17:36:16] (03CR) 10Ricordisamoa: Provide a standard way to get the target of a redirect page (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/168282 (owner: 10Ricordisamoa) [17:37:53] (03PS1) 1001tonythomas: Improved the bounce limit comparison check from '>' to '>=' [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/168337 [17:39:16] (03Merged) 10jenkins-bot: Add hook to extract namespace in prefix search [core] - 10https://gerrit.wikimedia.org/r/168167 (https://bugzilla.wikimedia.org/62322) (owner: 10Manybubbles) [17:39:20] (03Merged) 10jenkins-bot: Fix E_STRICT warnings in MWSearch::getTextSnippet() [extensions/MWSearch] (REL1_24) - 10https://gerrit.wikimedia.org/r/168335 (owner: 10MarkAHershberger) [17:39:39] 3Wikimedia / 3General/Unknown: Videos invisible on commons - 10https://bugzilla.wikimedia.org/72429#c2 (10Bawolff (Brian Wolff)) (In reply to Steinsplitter from comment #1) > Related to [[Bug 61823]]? I don't believe anything related to that bug was deployed, so probably not. [17:40:35] (03PS3) 10Ricordisamoa: Provide a standard way to get the target of a redirect page [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/168282 [17:41:37] (03CR) 10Addshore: [C: 032] Use setMwGlobals in TitleTest::testGetPageViewLanguage [core] - 10https://gerrit.wikimedia.org/r/167029 (owner: 10Umherirrender) [17:41:49] (03CR) 10Addshore: [C: 032] Use setMwGlobals in UserTest::testPasswordExpire [core] - 10https://gerrit.wikimedia.org/r/167026 (owner: 10Umherirrender) [17:41:53] 3MediaWiki / 3Search: Namespaces with diacritics are ignored on search suggestions - 10https://bugzilla.wikimedia.org/62322#c7 (10Nik Everett) 5PATC>3RESO/FIX Resolved. It'll take some time for this to arrive on a wiki near you because it requires rebuilding the search index which has to come after the... [17:42:31] ZOMG SEXY API DOCS ON MEDIAWIKI.ORG [17:42:35] (03PS2) 10Addshore: Use mergeMwGlobalArrayValue in ApiOptionsTest [core] - 10https://gerrit.wikimedia.org/r/166758 (owner: 10Umherirrender) [17:42:37] (03PS2) 10Addshore: Use mergeMwGlobalArrayValue in LocalisationCacheTest [core] - 10https://gerrit.wikimedia.org/r/166756 (owner: 10Umherirrender) [17:42:46] marktraceur: ? [17:43:30] (03PS2) 1001tonythomas: Improved the bounce limit comparison check from '>' to '>=' [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/168337 [17:43:33] James_F: www.mediawiki.org/w/api.php [17:43:51] marktraceur: Oh, yeah, that merged last week. Yay anomie. [17:43:56] (03CR) 10Addshore: [C: 032] Use mergeMwGlobalArrayValue in ApiOptionsTest [core] - 10https://gerrit.wikimedia.org/r/166758 (owner: 10Umherirrender) [17:44:02] (03CR) 10Addshore: [C: 032] Use mergeMwGlobalArrayValue in LocalisationCacheTest [core] - 10https://gerrit.wikimedia.org/r/166756 (owner: 10Umherirrender) [17:44:05] * marktraceur hugs anomie so much [17:45:00] (03CR) 10Addshore: [C: 032] Use mergeMwGlobalArrayValue in AutoLoaderTest::setUp [core] - 10https://gerrit.wikimedia.org/r/166760 (owner: 10Umherirrender) [17:45:45] (03CR) 10Addshore: [C: 032] Fix setting hooks in ApiQueryTest [core] - 10https://gerrit.wikimedia.org/r/166759 (owner: 10Umherirrender) [17:46:12] (03CR) 10Addshore: [C: 032] Refactor hook handling in ResourceLoaderTest [core] - 10https://gerrit.wikimedia.org/r/166752 (owner: 10Umherirrender) [17:46:49] (03PS3) 10EBernhardson: Bug: getUserLinks wrong output for anons [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168251 [17:46:52] (03PS5) 10EBernhardson: Hygiene: Move RecentChangeListener to Listener namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165427 [17:46:55] (03PS3) 10EBernhardson: Hygiene: Dont reach out to $wgTitle [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168252 [17:46:58] (03PS7) 10EBernhardson: Hygiene: Simplify listener for inserting RecentChange [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165426 [17:47:01] (03PS29) 10EBernhardson: Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [17:47:04] (03PS2) 10EBernhardson: Hygiene: Use real objects instead of mocks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168259 [17:47:07] (03PS2) 10EBernhardson: Validate UserTuple constructor input [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168258 [17:47:10] (03PS2) 10Addshore: Fix bypassing hooks in TextContentTest [core] - 10https://gerrit.wikimedia.org/r/166754 (owner: 10Umherirrender) [17:47:12] (03CR) 10Addshore: [C: 032] Fix bypassing hooks in TextContentTest [core] - 10https://gerrit.wikimedia.org/r/166754 (owner: 10Umherirrender) [17:48:27] (03PS3) 10EBernhardson: Hygiene: Use real objects instead of mocks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168259 [17:48:44] (03CR) 10Jgreen: [C: 032 V: 031] Improved the bounce limit comparison check from '>' to '>=' [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/168337 (owner: 1001tonythomas) [17:50:33] (03CR) 10Addshore: [C: 032] Avoid running of hooks when running MWTimestampTest [core] - 10https://gerrit.wikimedia.org/r/166751 (https://bugzilla.wikimedia.org/55886) (owner: 10Umherirrender) [17:50:37] (03PS2) 10Addshore: Avoid running of hooks when running MWTimestampTest [core] - 10https://gerrit.wikimedia.org/r/166751 (https://bugzilla.wikimedia.org/55886) (owner: 10Umherirrender) [17:52:00] (03CR) 10Addshore: [C: 04-1] "would need a manual rebase" [core] - 10https://gerrit.wikimedia.org/r/167227 (owner: 10Umherirrender) [17:52:08] 3MediaWiki / 3API: Many false positive warnings about missing continuation parameter - 10https://bugzilla.wikimedia.org/72415#c1 (10Brad Jorsch) (In reply to Michael M. from comment #0) > Just don't show a warning for meta submodules (I think these are the only > that can't be continued). meta=allmessages m... [17:52:55] (03PS1) 10Legoktm: Properly mark UserGetImplicitGroups hook as deprecated [core] - 10https://gerrit.wikimedia.org/r/168341 [17:53:03] (03Merged) 10jenkins-bot: Use setMwGlobals in TitleTest::testGetPageViewLanguage [core] - 10https://gerrit.wikimedia.org/r/167029 (owner: 10Umherirrender) [17:53:15] (03PS4) 10Addshore: Add test for class names in SpecialPageFactory::$list [core] - 10https://gerrit.wikimedia.org/r/163336 (owner: 10Umherirrender) [17:54:17] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move RecentChangeListener to Listener namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165427 (owner: 10EBernhardson) [17:54:53] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Simplify listener for inserting RecentChange [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165426 (owner: 10EBernhardson) [17:55:22] (03Merged) 10jenkins-bot: Use setMwGlobals in UserTest::testPasswordExpire [core] - 10https://gerrit.wikimedia.org/r/167026 (owner: 10Umherirrender) [17:55:24] 3MediaWiki extensions / 3CirrusSearch: Cirrus finds no results but Lucene finds 500+ (when searching outside main namespace) - 10https://bugzilla.wikimedia.org/68920#c3 (10Chad H.) I'm getting 700 with lsearchd: https://en.wikipedia.org/w/index.php?title=Special:Search&search=%22mw.loader.load%22%20AND%20%22... [17:55:33] (03CR) 10jenkins-bot: [V: 04-1] Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [17:55:53] (03Merged) 10jenkins-bot: Use mergeMwGlobalArrayValue in ApiOptionsTest [core] - 10https://gerrit.wikimedia.org/r/166758 (owner: 10Umherirrender) [17:56:01] (03Merged) 10jenkins-bot: Use mergeMwGlobalArrayValue in LocalisationCacheTest [core] - 10https://gerrit.wikimedia.org/r/166756 (owner: 10Umherirrender) [17:56:04] (03Merged) 10jenkins-bot: Use mergeMwGlobalArrayValue in AutoLoaderTest::setUp [core] - 10https://gerrit.wikimedia.org/r/166760 (owner: 10Umherirrender) [17:56:06] (03CR) 10jenkins-bot: [V: 04-1] Validate UserTuple constructor input [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168258 (owner: 10EBernhardson) [17:56:46] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use real objects instead of mocks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168259 (owner: 10EBernhardson) [17:56:59] (03Merged) 10jenkins-bot: Fix setting hooks in ApiQueryTest [core] - 10https://gerrit.wikimedia.org/r/166759 (owner: 10Umherirrender) [17:57:10] (03CR) 10jenkins-bot: [V: 04-1] Refactor hook handling in ResourceLoaderTest [core] - 10https://gerrit.wikimedia.org/r/166752 (owner: 10Umherirrender) [17:58:08] (03CR) 10EBernhardson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168258 (owner: 10EBernhardson) [17:58:39] 3MediaWiki / 3General/Unknown: Multimedia:Video player has strange size and proportions - 10https://bugzilla.wikimedia.org/72437 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None Created attachment 16869 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16869&action=edit video popup Wi... [18:01:46] (03PS1) 10Chad: Comment fix [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/168345 [18:03:38] 3mwEmbed / 3Timed text: MediaWiki:Gadget-mwEmbed.js - 10https://bugzilla.wikimedia.org/24265 (10Jonatan Svensson Glad (Josve05a)) [18:03:54] (03CR) 10Manybubbles: [C: 032] Comment fix [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/168345 (owner: 10Chad) [18:04:48] ^d: https://phabricator.wikimedia.org/diffusion/ close to being readable by mere humans yet? :-) [18:05:00] <^d> almost. [18:05:04] (03Merged) 10jenkins-bot: Fix bypassing hooks in TextContentTest [core] - 10https://gerrit.wikimedia.org/r/166754 (owner: 10Umherirrender) [18:08:33] (03Merged) 10jenkins-bot: Comment fix [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/168345 (owner: 10Chad) [18:10:02] (03CR) 10Reedy: [C: 032] Preparation to deploy Imagmetrics extension [tools/release] - 10https://gerrit.wikimedia.org/r/167728 (https://bugzilla.wikimedia.org/70402) (owner: 10Gergő Tisza) [18:10:12] (03Merged) 10jenkins-bot: Preparation to deploy Imagmetrics extension [tools/release] - 10https://gerrit.wikimedia.org/r/167728 (https://bugzilla.wikimedia.org/70402) (owner: 10Gergő Tisza) [18:10:42] (03PS4) 10Reedy: Remove DonationInterface from automatic release branching [tools/release] - 10https://gerrit.wikimedia.org/r/166915 (owner: 10Awight) [18:10:47] (03CR) 10Reedy: [C: 032] Remove DonationInterface from automatic release branching [tools/release] - 10https://gerrit.wikimedia.org/r/166915 (owner: 10Awight) [18:10:56] (03Merged) 10jenkins-bot: Remove DonationInterface from automatic release branching [tools/release] - 10https://gerrit.wikimedia.org/r/166915 (owner: 10Awight) [18:11:11] (03PS2) 10Reedy: Update Wikidata branch to wmf/1.25wmf5 [tools/release] - 10https://gerrit.wikimedia.org/r/168268 (owner: 10Aude) [18:11:17] (03CR) 10Reedy: [C: 032] Update Wikidata branch to wmf/1.25wmf5 [tools/release] - 10https://gerrit.wikimedia.org/r/168268 (owner: 10Aude) [18:11:28] (03Merged) 10jenkins-bot: Update Wikidata branch to wmf/1.25wmf5 [tools/release] - 10https://gerrit.wikimedia.org/r/168268 (owner: 10Aude) [18:15:11] 3MediaWiki / 3API: Improve documentation of API's "dir" parameter - 10https://bugzilla.wikimedia.org/56860#c2 (10dkontotasiou) Created attachment 16870 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16870&action=edit The attached file improves documentation of API's "dir" parameter (which accept valu... [18:15:16] (03CR) 10Anomie: [C: 032] "I don't buy that argument at all; people screen-scraping shouldn't complain when their scraping gets broken." [core] - 10https://gerrit.wikimedia.org/r/168235 (https://bugzilla.wikimedia.org/72340) (owner: 10Brian Wolff) [18:18:09] (03PS1) 10Brian Wolff: Follow-up 9649253f6b: Unbreak videos [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/168352 (https://bugzilla.wikimedia.org/72429) [18:20:53] (03CR) 10Brian Wolff: "Please also remember to test videos when making changes to TMH (This change broke videos)" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165753 (https://bugzilla.wikimedia.org/71365) (owner: 10Phuedx) [18:22:11] (03CR) 10Gergő Tisza: [C: 032] Follow-up 9649253f6b: Unbreak videos [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/168352 (https://bugzilla.wikimedia.org/72429) (owner: 10Brian Wolff) [18:22:25] (03CR) 10Brian Wolff: "Its not screen scraping - It was using the iframe as IE6 doesn't support using FormData to send files via ajax, but does support submittin" [core] - 10https://gerrit.wikimedia.org/r/168235 (https://bugzilla.wikimedia.org/72340) (owner: 10Brian Wolff) [18:22:29] (03PS14) 10Yuvipanda: Add Hiera: namespace with YAML content model [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/168269 [18:22:35] (03CR) 10Bartosz Dziewoński: [C: 04-1] "(still reviewing)" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/167342 (owner: 10Jdlrobson) [18:23:02] (03PS1) 10Cmcmahon: QA: WIP refactor watch test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168357 [18:24:50] (03Merged) 10jenkins-bot: Respect $wgApiFrameOptions in formatted API output mode [core] - 10https://gerrit.wikimedia.org/r/168235 (https://bugzilla.wikimedia.org/72340) (owner: 10Brian Wolff) [18:24:52] bawolff: that should no longer be necessary now that IE6 doesn't get JS right? [18:25:06] UploadWizard does silly things [18:25:10] (03PS1) 10Awight: Merge remote-tracking branch 'origin/fundraising/REL1_22' into HEAD [core] (fundraising/REL1_23) - 10https://gerrit.wikimedia.org/r/168358 [18:25:15] (03Merged) 10jenkins-bot: Follow-up 9649253f6b: Unbreak videos [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/168352 (https://bugzilla.wikimedia.org/72429) (owner: 10Brian Wolff) [18:25:22] (03CR) 10Awight: [C: 032] Merge remote-tracking branch 'origin/fundraising/REL1_22' into HEAD [core] (fundraising/REL1_23) - 10https://gerrit.wikimedia.org/r/168358 (owner: 10Awight) [18:25:50] You're right its no longer needed. I was just trying to make the point its a backwards compat break, since doing that sort of thing was once legit [18:26:14] Unfortunately upload wizard apearently uses the iframe hack for all browsers or something [18:26:23] !change 167888 | bd808|LUNCH [18:26:23] bd808|LUNCH: https://gerrit.wikimedia.org/r/#q,167888,n,z [18:27:18] dr0ptp4kt: hey! Want to chat about CentralNotice this afternoon? Any time works for me. [18:30:21] (03PS15) 10Yuvipanda: Add Hiera: namespace with YAML content model [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/168269 [18:30:52] bawolff: All browsers? I thought it was just IE [18:30:53] Crap [18:31:03] I don't know, user didn't specify browser [18:31:37] https://commons.wikimedia.org/wiki/Commons:Village_pump#Upload_Wizard_problems [18:31:48] (03CR) 10Anomie: "The screen scraping part is that it is using format=jsonfm and then using $( doc.body ).find( 'pre' ).text() to scrape the text out of the" [core] - 10https://gerrit.wikimedia.org/r/168235 (https://bugzilla.wikimedia.org/72340) (owner: 10Brian Wolff) [18:32:09] At one point they said they had a "connection reset" error so might not even be on our end [18:32:26] (03CR) 10Brian Wolff: "ewww." [core] - 10https://gerrit.wikimedia.org/r/168235 (https://bugzilla.wikimedia.org/72340) (owner: 10Brian Wolff) [18:33:22] bawolff: "ewww" is right [18:33:53] I wonder if it does that, becaue the mime type of application/json could cause a "download this file" dialog [18:34:31] That's my suspicion, which is why I suggested a better workaround would have been to add a parameter to return a content type that doesn't break IE. [18:37:14] (03CR) 10Bartosz Dziewoński: "A thought: the template renderers are apparently supposed to return HTML strings now. Why not DOM nodes, or jQuery objects? All of the exa" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/167342 (owner: 10Jdlrobson) [18:38:52] (03PS6) 10EBernhardson: Hygiene: Move RecentChangeListener to Listener namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165427 [18:38:55] (03PS8) 10EBernhardson: Hygiene: Simplify listener for inserting RecentChange [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165426 [18:38:58] (03PS30) 10EBernhardson: Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [18:39:01] (03PS4) 10EBernhardson: Hygiene: Use real objects instead of mocks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168259 [18:39:51] <^d> James_F: Doing VE now for you. [18:39:58] ^d: I saw! [18:39:59] <^d> And I got rid of VE/VE since you hate it ;-) [18:40:26] ^d: Yay. [18:44:11] yo awight, tomorrow would probably be best. you gonna be onsite then? [18:44:20] (03PS1) 10Manybubbles: Only index namespaces when rebuiling general index [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/168367 [18:44:24] dr0ptp4kt: yep! Please grab any time in my calendar... [18:44:29] awight: will do [18:44:39] (03CR) 10Anomie: [C: 04-1] "Code looks good, but you have some broken unit tests." (033 comments) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/168282 (owner: 10Ricordisamoa) [18:45:50] (03PS4) 10EBernhardson: Bug: getUserLinks wrong output for anons [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168251 [18:45:53] (03PS7) 10EBernhardson: Hygiene: Move RecentChangeListener to Listener namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165427 [18:45:56] (03PS4) 10EBernhardson: Hygiene: Dont reach out to $wgTitle [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168252 [18:45:59] (03PS9) 10EBernhardson: Hygiene: Simplify listener for inserting RecentChange [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165426 [18:46:02] (03PS31) 10EBernhardson: Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [18:46:05] (03PS5) 10EBernhardson: Hygiene: Use real objects instead of mocks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168259 [18:46:08] (03PS3) 10EBernhardson: Validate UserTuple constructor input [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168258 [18:46:28] (03PS1) 10Legoktm: View userpages in the user's language instead of site language [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/168372 [18:46:44] (03CR) 10jenkins-bot: [V: 04-1] Bug: getUserLinks wrong output for anons [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168251 (owner: 10EBernhardson) [18:47:19] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Simplify listener for inserting RecentChange [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165426 (owner: 10EBernhardson) [18:51:06] (03CR) 10EBernhardson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168251 (owner: 10EBernhardson) [18:53:59] (03CR) 10EBernhardson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165426 (owner: 10EBernhardson) [18:57:32] (03CR) 10Bartosz Dziewoński: "I like this :D Most comments are nitpicks, more important issues/questions:" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/167342 (owner: 10Jdlrobson) [18:58:53] 3MediaWiki / 3Documentation: Clear documentation should be provided about the *my* permissions - 10https://bugzilla.wikimedia.org/67167#c1 (10dkontotasiou) [[mw:Manual:User rights]] contains clear instructions about editmyoptions. I committed a pull request in github and clear instructions will be added to D... [18:59:47] Jees [18:59:48] https://www.mediawiki.org/wiki/MediaWiki_1.25/wmf5/Changelog [18:59:51] Looks like this is a big deploy [19:00:15] Oh [19:00:17] donationinterface [19:02:20] (03CR) 10Gergő Tisza: [C: 031] Add logging context to database logs [core] - 10https://gerrit.wikimedia.org/r/141599 (owner: 10BryanDavis) [19:09:50] (03PS2) 10EBernhardson: Hygiene: autogenerate $wgAutoloadFiles lines [extensions/Echo] - 10https://gerrit.wikimedia.org/r/163288 [19:10:23] (03CR) 10BryanDavis: Use MWLogger logging for legacy logging methods (031 comment) [core] - 10https://gerrit.wikimedia.org/r/119941 (owner: 10BryanDavis) [19:12:01] (03CR) 10Umherirrender: [C: 032] "Resubmit, it seems that the rebase was done after Code-Review+2, so jenkins stops the merge" [core] - 10https://gerrit.wikimedia.org/r/166751 (https://bugzilla.wikimedia.org/55886) (owner: 10Umherirrender) [19:12:53] (03PS3) 10EBernhardson: Generate $wgAutoloadLocalClasses with a maint script [core] - 10https://gerrit.wikimedia.org/r/163304 [19:13:04] (03PS14) 10Jdlrobson: Add support for delivering templates via ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/167342 [19:15:41] (03PS1) 10Manybubbles: Allow limiting morelike to pages with wikidata [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/168385 [19:17:21] (03CR) 10Umherirrender: More test isolation (033 comments) [core] - 10https://gerrit.wikimedia.org/r/142703 (owner: 10MaxSem) [19:18:06] (03CR) 10Manybubbles: "Chad, this is something Sam asked for to implement a some experiments for mobile. It was no big deal to implement so I figured I'd just d" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/168385 (owner: 10Manybubbles) [19:18:23] (03Merged) 10jenkins-bot: Avoid running of hooks when running MWTimestampTest [core] - 10https://gerrit.wikimedia.org/r/166751 (https://bugzilla.wikimedia.org/55886) (owner: 10Umherirrender) [19:18:35] (03CR) 10Manybubbles: "The full from mediawiki reindex may not come soon though. Might want to just do it for the wikis he wants to target." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/168385 (owner: 10Manybubbles) [19:18:47] (03CR) 10Umherirrender: Improve isolation of a few tests (033 comments) [core] - 10https://gerrit.wikimedia.org/r/142635 (owner: 10MaxSem) [19:19:20] (03PS3) 10Umherirrender: Refactor hook handling in ResourceLoaderTest [core] - 10https://gerrit.wikimedia.org/r/166752 [19:19:51] (03CR) 10jenkins-bot: [V: 04-1] Add support for delivering templates via ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/167342 (owner: 10Jdlrobson) [19:21:24] 3MediaWiki / 3Unit tests: CLDR breaks core timestamp tests - 10https://bugzilla.wikimedia.org/55886 (10Umherirrender) 5PATC>3RESO/FIX [19:21:41] (03PS1) 10Gergő Tisza: Respect $wgApiFrameOptions in formatted API output mode [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168386 (https://bugzilla.wikimedia.org/72340) [19:22:55] 3MediaWiki extensions / 3[other]: Teahouse has bad title - 10https://bugzilla.wikimedia.org/72444 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3normal a:3Robert Vogel Ask your question If you hover over the "Ask your question" link you get shown "" [19:24:55] 3MediaWiki / 3Special pages: Special:Version produces warning when there's an open_basedir restriction, when checking for $wgGitBin - 10https://bugzilla.wikimedia.org/72445 (10Jesús Martínez Novo (Ciencia Al Poder)) 3NEW p:3Unprio s:3minor a:3None Special:Version is using is_file() to check if $wgGit... [19:25:09] (03PS1) 10Gergő Tisza: Follow-up 9649253f6b: Unbreak videos [extensions/TimedMediaHandler] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168387 (https://bugzilla.wikimedia.org/72429) [19:25:33] (03PS1) 10Gergő Tisza: Follow-up 9649253f6b: Unbreak videos [extensions/TimedMediaHandler] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/168388 (https://bugzilla.wikimedia.org/72429) [19:25:39] 3MediaWiki extensions / 3ConfirmEdit (CAPTCHA extension): captcha whitelist does not work for protocol-relative URLs - 10https://bugzilla.wikimedia.org/61556#c6 (10Jackmcbarn) 5PATC>3RESO/FIX a:3Jackmcbarn This will be deployed to all WMF wikis by October 30th. [19:25:52] (03PS3) 10Umherirrender: Do not use value '1' for boolean params in api.php examples [core] - 10https://gerrit.wikimedia.org/r/167227 [19:26:10] (03CR) 10Umherirrender: "Patch Set 3: Rebased" [core] - 10https://gerrit.wikimedia.org/r/167227 (owner: 10Umherirrender) [19:26:37] (03PS1) 10Dzahn: phabricator - change top bar color to WMF green [phabricator/phabricator] - 10https://gerrit.wikimedia.org/r/168389 [19:27:08] (03PS6) 10Legoktm: Add forceRenameUsers.php [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/161632 [19:27:10] (03CR) 10Umherirrender: [C: 032] "Needs resubmit due to fail of unrelated unit test" [core] - 10https://gerrit.wikimedia.org/r/166752 (owner: 10Umherirrender) [19:27:12] (03CR) 10Legoktm: Add forceRenameUsers.php (038 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/161632 (owner: 10Legoktm) [19:27:45] (03PS2) 10Dzahn: phabricator - change top bar color to WMF green [phabricator/phabricator] - 10https://gerrit.wikimedia.org/r/168389 [19:28:48] (03PS15) 10Umherirrender: Always escape 'word-separator' and 'parentheses' messages [core] - 10https://gerrit.wikimedia.org/r/136161 [19:29:02] (03PS16) 10Umherirrender: Always escape 'word-separator' and 'parentheses' messages [core] - 10https://gerrit.wikimedia.org/r/136161 [19:31:38] (03PS1) 10Legoktm: [WIP] Add MassMessageTarget class [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/168392 [19:31:55] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add MassMessageTarget class [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/168392 (owner: 10Legoktm) [19:32:25] (03CR) 10Rush: [C: 04-1] "This is not worth managing this merge conflict forever and ever." [phabricator/phabricator] - 10https://gerrit.wikimedia.org/r/168389 (owner: 10Dzahn) [19:33:15] (03Merged) 10jenkins-bot: Refactor hook handling in ResourceLoaderTest [core] - 10https://gerrit.wikimedia.org/r/166752 (owner: 10Umherirrender) [19:33:47] (03CR) 10Rush: "ui.header-color also exists" [phabricator/phabricator] - 10https://gerrit.wikimedia.org/r/168389 (owner: 10Dzahn) [19:34:51] (03PS8) 10Legoktm: Add maintenance script to send messages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/144256 (https://bugzilla.wikimedia.org/72123) [19:35:09] (03CR) 10Legoktm: Add maintenance script to send messages (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/144256 (https://bugzilla.wikimedia.org/72123) (owner: 10Legoktm) [19:35:11] (03CR) 10jenkins-bot: [V: 04-1] Add maintenance script to send messages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/144256 (https://bugzilla.wikimedia.org/72123) (owner: 10Legoktm) [19:35:29] eh [19:36:12] jenkins says no [19:36:51] https://www.mediawiki.org/w/api.php?action=query&list=mmsites&term=en [19:36:54] "*": "Formatting of continuation data will be changing soon. To continue using the current formatting, use the 'rawcontinue' parameter. To begin using the new format, pass an empty string for 'continue' in the initial query." [19:37:15] There's a bug open about that [19:37:33] Continue warnings where they're not really appropriate [19:37:48] https://github.com/wikimedia/mediawiki/commit/af11268d05d98d27d99cfee9264d649a62c2c816#diff-5d0b32eec32a62c1b4a33adaaed24920 [19:38:19] (03Abandoned) 10Dzahn: phabricator - change top bar color to WMF green [phabricator/phabricator] - 10https://gerrit.wikimedia.org/r/168389 (owner: 10Dzahn) [19:39:21] I'm not sure this is the best way to announce something either.... [19:39:27] (03CR) 10Gergő Tisza: [C: 032] Follow-up 9649253f6b: Unbreak videos [extensions/TimedMediaHandler] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168387 (https://bugzilla.wikimedia.org/72429) (owner: 10Gergő Tisza) [19:39:42] (03Merged) 10jenkins-bot: Follow-up 9649253f6b: Unbreak videos [extensions/TimedMediaHandler] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168387 (https://bugzilla.wikimedia.org/72429) (owner: 10Gergő Tisza) [19:39:44] anomie: no mediawiki-api-announce email ? [19:40:01] (03CR) 10Gergő Tisza: [C: 032] Follow-up 9649253f6b: Unbreak videos [extensions/TimedMediaHandler] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/168388 (https://bugzilla.wikimedia.org/72429) (owner: 10Gergő Tisza) [19:40:13] (03Merged) 10jenkins-bot: Follow-up 9649253f6b: Unbreak videos [extensions/TimedMediaHandler] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/168388 (https://bugzilla.wikimedia.org/72429) (owner: 10Gergő Tisza) [19:40:27] (03PS1) 10Legoktm: Work around API continuation warning in ApiQueryMMSitesTest [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/168396 [19:40:50] legoktm: https://lists.wikimedia.org/pipermail/mediawiki-api-announce/2014-September/000069.html [19:41:35] ok, I forgot about that [19:41:45] a reminder would be nice :P [19:42:36] Reedy: merge https://gerrit.wikimedia.org/r/#/c/168396/ ? [19:44:19] (03CR) 10Legoktm: "Test failure is unrelated and due to core API changes, workaround in Ia0e208a3ed887ab189b5692ba8d5539fd7bbd05f." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/144256 (https://bugzilla.wikimedia.org/72123) (owner: 10Legoktm) [19:44:57] (03CR) 10Umherirrender: "hooks.txt does not mention, that this hook is deprecated" [core] - 10https://gerrit.wikimedia.org/r/168341 (owner: 10Legoktm) [19:45:39] (03CR) 10Bartosz Dziewoński: Properly mark UserGetImplicitGroups hook as deprecated (031 comment) [core] - 10https://gerrit.wikimedia.org/r/168341 (owner: 10Legoktm) [19:53:29] 3MediaWiki / 3Unit tests: Reduce duplication for UnitTestList hook in extensions - 10https://bugzilla.wikimedia.org/70630 (10Umherirrender) 5PATC>3RESO/FIX a:3Adam Wight [19:53:33] Oooh, hashar's pulling MW into scrutiniser is fun. [19:53:37] https://scrutinizer-ci.com/g/wikimedia/mediawiki/issues/master?selectedLabels%5B0%5D=11&orderField=issueCount&order=desc for example. [19:54:23] 3MediaWiki / 3Unit tests: Reduce duplication for UnitTestList hook in extensions - 10https://bugzilla.wikimedia.org/70630#c6 (10Umherirrender) Was backported, so setting milestone 1.24 [19:54:39] Now we have numbers to know there are issues with ORM. :-) [19:55:10] doesn't look very smart [19:55:11] https://scrutinizer-ci.com/g/wikimedia/mediawiki/indices/366438/duplications/23078766 [19:55:33] https://scrutinizer-ci.com/g/wikimedia/mediawiki/issues/master/files/includes/Preferences.php?selectedLabels[0]=4&selectedLabels[1]=2&orderField=issueCount&order=desc [19:55:35] Oh, indeed. [19:55:41] It's a guide not a worklist. [19:56:38] <^d> The ORMRow bit just shows us that we're using our own deprecated code. [19:56:58] Indeed. [19:57:06] (03CR) 10Siebrand: [C: 032] Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/168397 (owner: 10L10n-bot) [19:58:09] Also https://insight.sensiolabs.com/projects/8b5d527f-f70c-4fc0-977f-de99743eae06/analyses/16 is more fun. [19:58:27] Apparently eval.php has a critical security vulnerability in that it uses eval(). [19:59:41] <^d> Well eval.php is one giant vulnerability if you let people access it ;-) [20:00:04] James_F: sounds about right. Also their parser doesn't understand multivariate return types (eg @return int|bool) and probably a zillion other boring wild goose chase errors. [20:00:20] bd808|LUNCH: Yeah, I noticed a few issues like that. [20:00:57] <^d> I'm fixing the and/or -> &&/|| [20:00:57] ^d: Most sysadmins probably shouldn't ever use it; maybe we should alter the installer so you don't have it by default? [20:00:58] (03PS1) 10Paladox: Update Metrolook add support for MediaWiki 1.22 [skins/Metrolook] (REL1_22) - 10https://gerrit.wikimedia.org/r/168402 [20:01:00] <^d> That irks me anyway [20:01:01] <^d> :) [20:01:55] (03CR) 10Paladox: [C: 032 V: 032] Update Metrolook add support for MediaWiki 1.22 [skins/Metrolook] (REL1_22) - 10https://gerrit.wikimedia.org/r/168402 (owner: 10Paladox) [20:01:58] Web applications should contain a favicon [MAJOR] seriously? [20:03:19] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/168397 (owner: 10L10n-bot) [20:03:49] (03PS1) 10Gergő Tisza: Update TimedMediaHandler submodule [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168403 [20:03:55] (03PS1) 10Chad: Swap and for && [core] - 10https://gerrit.wikimedia.org/r/168404 [20:03:56] <^d> ^ if anyone's feeling bold. [20:04:29] (03CR) 10Daniel Kinzler: [C: 04-1] "@i'd probably adapt this to just remember the model and format from the respective tags instead of accessing the attributes. a little more" [core] - 10https://gerrit.wikimedia.org/r/168126 (https://bugzilla.wikimedia.org/72361) (owner: 10Daniel Kinzler) [20:08:08] omg... https://scrutinizer-ci.com/g/wikimedia/mediawiki/issues/master?selectedLabels%5B0%5D=11&orderField=issueCount&order=desc ;) [20:08:28] (03PS1) 10Paladox: Update Metrolook [skins/Metrolook] (REL1_23) - 10https://gerrit.wikimedia.org/r/168407 [20:09:01] (03PS4) 10Jackmcbarn: Expose file page count, width, and height to Lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/136274 [20:09:03] (03CR) 10Chad: [C: 032] Only index namespaces when rebuiling general index [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/168367 (owner: 10Manybubbles) [20:09:16] (03CR) 10Paladox: [C: 032 V: 032] Update Metrolook [skins/Metrolook] (REL1_23) - 10https://gerrit.wikimedia.org/r/168407 (owner: 10Paladox) [20:09:25] (03CR) 10Jackmcbarn: "This should probably be redone as a dependency of I9c6b5024ae6b5af393ed7eb1448a297c5c4e5830" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/67588 (https://bugzilla.wikimedia.org/41498) (owner: 10Brian Wolff) [20:09:32] (03Merged) 10jenkins-bot: Only index namespaces when rebuiling general index [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/168367 (owner: 10Manybubbles) [20:12:09] 3MediaWiki extensions / 3SecurePoll: SecurePoll: [[Special:SecurePoll]] should include a link to the history for each poll - 10https://bugzilla.wikimedia.org/72449 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None What it says on the tin. Let's put a link in so the UI is easier to use. [20:12:23] 3MediaWiki extensions / 3SecurePoll: Issues blocking deployment of new SecurePoll interface (tracking) - 10https://bugzilla.wikimedia.org/68118 (10Dan Garry) [20:12:23] 3MediaWiki extensions / 3SecurePoll: SecurePoll: [[Special:SecurePoll]] should include a link to the history for each poll - 10https://bugzilla.wikimedia.org/72449 (10Dan Garry) [20:12:52] anomie: can i bug you to look at https://gerrit.wikimedia.org/r/#/c/136274/ ? it's rather old [20:13:06] (03PS1) 10Paladox: Update Metrolook [skins/Metrolook] (REL1_24) - 10https://gerrit.wikimedia.org/r/168409 [20:13:38] (03PS1) 10Welterkj: Add tag argument “preparse”. [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/168410 [20:13:52] (03CR) 10Paladox: [C: 032 V: 032] Update Metrolook [skins/Metrolook] (REL1_24) - 10https://gerrit.wikimedia.org/r/168409 (owner: 10Paladox) [20:18:10] 3MediaWiki extensions / 3SecurePoll: SecurePoll: History view should display actual values of questions, not just IDs - 10https://bugzilla.wikimedia.org/72450 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None Go here: https://test.wikipedia.org/w/index.php?title=SecurePoll:370&oldid=217686 The entry fo... [20:18:23] 3MediaWiki extensions / 3SecurePoll: SecurePoll: History view should display actual values of questions, not just IDs - 10https://bugzilla.wikimedia.org/72450 (10Dan Garry) [20:18:23] 3MediaWiki extensions / 3SecurePoll: Issues blocking deployment of new SecurePoll interface (tracking) - 10https://bugzilla.wikimedia.org/68118 (10Dan Garry) [20:18:31] (03PS1) 10Paladox: Update Metrolook [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/168413 [20:19:17] (03PS2) 10Paladox: Update Metrolook [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/168413 [20:19:34] (03PS2) 10Welterkj: Add tag argument “preparse”. [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/168410 [20:20:00] (03CR) 10Paladox: [C: 032 V: 032] Update Metrolook [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/168413 (owner: 10Paladox) [20:21:42] (03CR) 10Jackmcbarn: [C: 04-1] Provide a standard way to get the target of a redirect page (032 comments) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/168282 (owner: 10Ricordisamoa) [20:22:13] (03CR) 10Jack Phoenix: [C: 032] View userpages in the user's language instead of site language [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/168372 (owner: 10Legoktm) [20:22:25] (03Merged) 10jenkins-bot: View userpages in the user's language instead of site language [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/168372 (owner: 10Legoktm) [20:23:04] (03CR) 10Jackmcbarn: Provide a standard way to get the target of a redirect page (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/168282 (owner: 10Ricordisamoa) [20:23:26] (03PS1) 10Gergő Tisza: Update TimedMediaHandler submodule [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/168415 [20:23:27] anomie: https://test.wikipedia.org/w/api.php?action=query&meta=siteinfo&siprop=interwikimap probably shouldn't have the warning? [20:25:13] https://bugzilla.wikimedia.org/show_bug.cgi?id=72415 [20:25:32] legoktm: The problem is that determining what shouldn't have warnings basically requires adding "function neverContinues() { return false; }" to ApiQueryBase, then reimplementing it to return true for everything that never continues, and then checking the supplied modules in ApiQuery to see if any return false. And meta=siteinfo could theoretically continue anyway. [20:25:45] yeahhhh [20:25:46] ugh [20:26:16] legoktm: Or we could just wait 6 months for 1.26 and then the warning is removed. [20:26:26] :P [20:27:44] (03CR) 10Hashar: "We needed to stop processing git submodules in the bundle job template which should be the case with https://gerrit.wikimedia.org/r/#/c/16" [core] - 10https://gerrit.wikimedia.org/r/167794 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [20:27:56] (03CR) 10Hashar: "check experimental" [core] - 10https://gerrit.wikimedia.org/r/167794 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [20:28:12] * jackmcbarn does think it's kind of obnoxious to warn when an optional parameter is omitted, but then realizes he's guilty of it too in action=expandtemplates [20:29:09] 3MediaWiki extensions / 3CirrusSearch: Send ES stats to graphite - 10https://bugzilla.wikimedia.org/71055#c1 (10Chad H.) graphite.wmflabs.org is now getting elastic stats. [20:29:16] (03PS1) 10Bartosz Dziewoński: MessagesNds_nl.php: Remove lies [core] - 10https://gerrit.wikimedia.org/r/168418 [20:29:50] (03PS1) 10MarkTraceur: Upgrade FDT to use promises instead of old syntax [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/168419 (https://bugzilla.wikimedia.org/60821) [20:32:08] 3Wikimedia / 3General/Unknown: UploadWizard Freezes at Uploading Stage due to Firefogg (Firefox extension) - 10https://bugzilla.wikimedia.org/69374#c18 (10Mark Holmquist) *** Bug 65696 has been marked as a duplicate of this bug. *** [20:32:13] (03PS1) 10Cmcmahon: QA: make watch test maintainable and readable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168420 [20:34:08] 3MediaWiki extensions / 3SecurePoll: SecurePoll: History view should display actual values of questions, not just IDs - 10https://bugzilla.wikimedia.org/72450#c1 (10Brad Jorsch) See https://test.wikipedia.org/w/index.php?title=SecurePoll:370/msg/en The languages are split out so that people editing differen... [20:34:43] (03Abandoned) 10Cmcmahon: QA: WIP refactor watch test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168357 (owner: 10Cmcmahon) [20:34:53] 3MediaWiki extensions / 3SecurePoll: SecurePoll: [[Special:SecurePoll]] should include a link to the history for each poll - 10https://bugzilla.wikimedia.org/72449#c1 (10Brad Jorsch) You may want to check the reply on bug 72450 and refine your idea here. There's more than one "history page" to link, possibly... [20:37:52] (03CR) 10Gergő Tisza: [C: 032] Upgrade FDT to use promises instead of old syntax [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/168419 (https://bugzilla.wikimedia.org/60821) (owner: 10MarkTraceur) [20:37:57] (03PS3) 10Florianschmidtwelzow: Change RC visibility to use a tag instead of string [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/168196 [20:38:04] (03CR) 10Florianschmidtwelzow: Change RC visibility to use a tag instead of string (031 comment) [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/168196 (owner: 10Florianschmidtwelzow) [20:38:24] (03Merged) 10jenkins-bot: Upgrade FDT to use promises instead of old syntax [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/168419 (https://bugzilla.wikimedia.org/60821) (owner: 10MarkTraceur) [20:38:40] 3MediaWiki / 3JavaScript: Deprecation warnings may not be consistent for jQuery - 10https://bugzilla.wikimedia.org/72451 (10Mark Holmquist) 3NEW p:3Unprio s:3normal a:3None Exhibit A: https://gerrit.wikimedia.org/r/168419 Caused, I think, by deprecation of the { ok: ..., err: ... } way of setting ca... [20:40:44] (03PS1) 10MarkTraceur: Fix trivial error in Firefogg upload handling [extensions/UploadWizard] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168421 (https://bugzilla.wikimedia.org/69374) [20:40:58] (03PS1) 10MarkTraceur: Upgrade FDT to use promises instead of old syntax [extensions/UploadWizard] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/168422 (https://bugzilla.wikimedia.org/60821) [20:41:39] (03PS1) 10MarkTraceur: Upgrade FDT to use promises instead of old syntax [extensions/UploadWizard] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168423 (https://bugzilla.wikimedia.org/60821) [20:41:42] (03CR) 10Ori.livneh: [C: 032] Make role::centralauth docs prettier [vagrant] - 10https://gerrit.wikimedia.org/r/168247 (owner: 10BryanDavis) [20:41:55] (03CR) 10Hashar: "Now it is just failing because of:" [core] - 10https://gerrit.wikimedia.org/r/167794 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [20:42:01] (03Merged) 10jenkins-bot: Make role::centralauth docs prettier [vagrant] - 10https://gerrit.wikimedia.org/r/168247 (owner: 10BryanDavis) [20:42:55] 3MediaWiki extensions / 3Math: Font is changed to Serif in articles using MathJax viewed via Tor Browser - 10https://bugzilla.wikimedia.org/72452 (10Zell Faze) 3UNCO p:3Unprio s:3minor a:3None When viewing the article Random walk on English Wikipedia via the newest version of the Tor Browser Bundle (... [20:45:38] 3Wikimedia / 3Extension setup: Review and deploy ImageMetrics extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/70402 (10Tisza Gergő) 5PATC>3RESO/FIX [20:46:52] (03CR) 10Wctaiwan: [C: 032] Work around API continuation warning in ApiQueryMMSitesTest [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/168396 (owner: 10Legoktm) [20:47:10] (03Merged) 10jenkins-bot: Work around API continuation warning in ApiQueryMMSitesTest [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/168396 (owner: 10Legoktm) [20:47:57] (03PS9) 10Legoktm: Add maintenance script to send messages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/144256 (https://bugzilla.wikimedia.org/72123) [20:47:59] (03PS2) 10Legoktm: [WIP] Add MassMessageTarget class [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/168392 [20:48:20] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add MassMessageTarget class [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/168392 (owner: 10Legoktm) [20:50:10] (03PS15) 10Jdlrobson: Add support for delivering templates via ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/167342 [20:52:07] (03PS16) 10Jdlrobson: Add support for delivering templates via ResourceLoader t A base ResourceLoaderModule::getTemplates() exists for subclasses to override. An implementation is provided for ResourceLoaderFileModule. [core] - 10https://gerrit.wikimedia.org/r/167342 [20:56:11] (03CR) 10Aaron Schulz: [C: 032] Add maintenance script to send messages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/144256 (https://bugzilla.wikimedia.org/72123) (owner: 10Legoktm) [20:56:27] (03Merged) 10jenkins-bot: Add maintenance script to send messages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/144256 (https://bugzilla.wikimedia.org/72123) (owner: 10Legoktm) [20:57:04] (03PS32) 10EBernhardson: Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [20:57:49] (03CR) 10jenkins-bot: [V: 04-1] Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [20:58:03] (03CR) 10jenkins-bot: [V: 04-1] Add support for delivering templates via ResourceLoader t A base ResourceLoaderModule::getTemplates() exists for subclasses to override. An implementation is provided for ResourceLoaderFileModule. [core] - 10https://gerrit.wikimedia.org/r/167342 (owner: 10Jdlrobson) [20:59:52] 3MediaWiki extensions / 3Math: Font is changed to Serif in articles using MathJax viewed via Tor Browser - 10https://bugzilla.wikimedia.org/72452#c1 (10Peter Krautzberger) What does MathJax's About pop-up (right/cmd-click equations to open the MathJax menu => click on About) say on the top about fonts? Does... [21:03:42] (03PS17) 10Jdlrobson: Add support for delivering templates via ResourceLoader t A base ResourceLoaderModule::getTemplates() exists for subclasses to override. An implementation is provided for ResourceLoaderFileModule. [core] - 10https://gerrit.wikimedia.org/r/167342 [21:04:08] 3MediaWiki extensions / 3MassMessage: Add a maintenance script to send mass messages - 10https://bugzilla.wikimedia.org/72123 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX [21:05:43] (03CR) 10Bartosz Dziewoński: [C: 031] resourceloader: Add ResourceLoaderContext::getUserObj and replace use of $wgUser (031 comment) [core] - 10https://gerrit.wikimedia.org/r/164724 (owner: 10Legoktm) [21:06:09] (03PS1) 10Jdlrobson: Use core template compiler for Handlebars [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/168434 [21:06:25] (03PS3) 10Jdlrobson: Switch to templates in core. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168317 [21:06:45] (03CR) 10jenkins-bot: [V: 04-1] Use core template compiler for Handlebars [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/168434 (owner: 10Jdlrobson) [21:07:16] (03CR) 10jenkins-bot: [V: 04-1] Switch to templates in core. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168317 (owner: 10Jdlrobson) [21:07:18] siebrand: Hey, are you around the office still? [21:08:24] (03PS7) 10Cmcmahon: QA: create a test for sorting topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167448 [21:10:44] (03PS8) 10Cmcmahon: QA: create a test for sorting topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167448 [21:11:20] (03CR) 10Cmcmahon: "I didn't know about "when_not_visible" somehow :-)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167448 (owner: 10Cmcmahon) [21:12:15] (03PS5) 10Legoktm: resourceloader: Add ResourceLoaderContext::getUserObj and replace use of $wgUser [core] - 10https://gerrit.wikimedia.org/r/164724 [21:12:17] (03CR) 10Legoktm: resourceloader: Add ResourceLoaderContext::getUserObj and replace use of $wgUser (031 comment) [core] - 10https://gerrit.wikimedia.org/r/164724 (owner: 10Legoktm) [21:12:54] 3MediaWiki / 3API: API and OAuth malfunction - 10https://bugzilla.wikimedia.org/72384 (10Magnus Manske) 5UNCO>3RESO/FIX [21:19:24] (03CR) 10Bartosz Dziewoński: [C: 032] resourceloader: Add ResourceLoaderContext::getUserObj and replace use of $wgUser [core] - 10https://gerrit.wikimedia.org/r/164724 (owner: 10Legoktm) [21:22:50] (03CR) 10Gergő Tisza: [C: 032] Upgrade FDT to use promises instead of old syntax [extensions/UploadWizard] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168423 (https://bugzilla.wikimedia.org/60821) (owner: 10MarkTraceur) [21:22:53] (03CR) 10Gergő Tisza: [C: 032] Upgrade FDT to use promises instead of old syntax [extensions/UploadWizard] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/168422 (https://bugzilla.wikimedia.org/60821) (owner: 10MarkTraceur) [21:23:18] (03CR) 10Bartosz Dziewoński: [C: 032] "YOLO" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/163651 (https://bugzilla.wikimedia.org/71353) (owner: 10EBernhardson) [21:23:41] (03CR) 10Bartosz Dziewoński: "Erik, feel like looking into this?… :(" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/163844 (owner: 10Bartosz Dziewoński) [21:25:26] (03Merged) 10jenkins-bot: resourceloader: Add ResourceLoaderContext::getUserObj and replace use of $wgUser [core] - 10https://gerrit.wikimedia.org/r/164724 (owner: 10Legoktm) [21:25:28] (03Merged) 10jenkins-bot: Upgrade FDT to use promises instead of old syntax [extensions/UploadWizard] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168423 (https://bugzilla.wikimedia.org/60821) (owner: 10MarkTraceur) [21:25:31] (03Merged) 10jenkins-bot: Upgrade FDT to use promises instead of old syntax [extensions/UploadWizard] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/168422 (https://bugzilla.wikimedia.org/60821) (owner: 10MarkTraceur) [21:25:38] (03Merged) 10jenkins-bot: Detect signature using Title class [extensions/Echo] - 10https://gerrit.wikimedia.org/r/163651 (https://bugzilla.wikimedia.org/71353) (owner: 10EBernhardson) [21:26:43] (03CR) 10Gergő Tisza: [C: 032] Fix trivial error in Firefogg upload handling [extensions/UploadWizard] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168421 (https://bugzilla.wikimedia.org/69374) (owner: 10MarkTraceur) [21:27:19] (03Merged) 10jenkins-bot: Fix trivial error in Firefogg upload handling [extensions/UploadWizard] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168421 (https://bugzilla.wikimedia.org/69374) (owner: 10MarkTraceur) [21:27:56] (03PS6) 10EBernhardson: DiscussionParser: More tests for custom and localised namespaces [extensions/Echo] - 10https://gerrit.wikimedia.org/r/163844 (owner: 10Bartosz Dziewoński) [21:28:27] (03CR) 10jenkins-bot: [V: 04-1] DiscussionParser: More tests for custom and localised namespaces [extensions/Echo] - 10https://gerrit.wikimedia.org/r/163844 (owner: 10Bartosz Dziewoński) [21:32:02] (03PS1) 10Gergő Tisza: Update UploadWizard submodule [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168487 [21:38:24] 3MediaWiki extensions / 3SecurePoll: SecurePoll: [[Special:SecurePoll]] should include a link to the history for each poll - 10https://bugzilla.wikimedia.org/72449#c2 (10Dan Garry) (In reply to Brad Jorsch from comment #1) > You may want to check the reply on bug 72450 and refine your idea here. > There's mo... [21:39:00] (03CR) 10Bartosz Dziewoński: [C: 031] Add support for delivering templates via ResourceLoader t A base ResourceLoaderModule::getTemplates() exists for subclasses to override. An (032 comments) [core] - 10https://gerrit.wikimedia.org/r/167342 (owner: 10Jdlrobson) [21:43:24] (03PS1) 10EBernhardson: Bug: prevent floats from breaking out of topic summary [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168492 [21:50:23] 3MediaWiki extensions / 3CirrusSearch: Redirects should appear in Cirrus's results - 10https://bugzilla.wikimedia.org/71491#c5 (10Gryllida) I repeat: how can I re-enable LuceneSearch on this project? [21:50:37] 3MediaWiki extensions / 3RSS: RSS: - 10https://bugzilla.wikimedia.org/72453 (10Subfader) 5NEW>3RESO/WON [21:55:29] (03PS18) 10Jdlrobson: Add support for delivering templates via ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/167342 [21:55:56] 3MediaWiki / 3MediaWiki UI: [[Special:Search]] should not use obsolete "cellpadding" attribute (use CSS instead) - 10https://bugzilla.wikimedia.org/72458 (10Helder) 3NEW p:3Unprio s:3normal a:3None https://en.wikipedia.org/w/index.php?title=Special:Search&search=&fulltext=Search&profile=advanced htt... [21:58:46] (03CR) 10Aaron Schulz: Add forceRenameUsers.php (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/161632 (owner: 10Legoktm) [21:58:52] (03CR) 10Dduvall: [C: 04-1] "Chris, I think you might be mistaken here. AFAIK, the page-object instance is what's yielded to the block.[1]" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168197 (owner: 10Cmcmahon) [21:58:55] (03CR) 10Aaron Schulz: Add forceRenameUsers.php (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/161632 (owner: 10Legoktm) [22:00:51] (03PS7) 10Legoktm: Add forceRenameUsers.php [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/161632 [22:00:52] 3MediaWiki extensions / 3CirrusSearch: Redirects should appear in Cirrus's results - 10https://bugzilla.wikimedia.org/71491#c6 (10Chad H.) Enabling Lucene as the default wouldn't change anything that srbackend can't already do. [22:01:44] (03PS1) 10Gergő Tisza: Update UploadWizard submodule [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/168496 [22:03:00] (03CR) 10Cmcmahon: "Very interesting, I didn't know that." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168197 (owner: 10Cmcmahon) [22:09:26] (03CR) 10Fomafix: "Superseded by https://gerrit.wikimedia.org/r/168419" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/167410 (owner: 10Gerrit Patch Uploader) [22:11:08] 3MediaWiki / 3General/Unknown: Bring back the view counter and make it optional - 10https://bugzilla.wikimedia.org/72420#c3 (10Subfader) How do you come to the conclusion that it's useless and can be removed? If WP used the counter it wouldn't have flaws... [22:18:02] (03CR) 10Siebrand: [C: 032] MessagesNds_nl.php: Remove lies [core] - 10https://gerrit.wikimedia.org/r/168418 (owner: 10Bartosz Dziewoński) [22:18:25] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/168196 (owner: 10Florianschmidtwelzow) [22:19:05] moizsyed: Racebaiting aside, wanna see a design concept thing? [22:19:16] It needs a serious feedback cycle or ten. [22:19:22] 3Wikimedia / 3Site requests: Create "templateeditor" user group on fawiki - 10https://bugzilla.wikimedia.org/72146#c3 (10Calak) Now templateeditor user group can not edit cascade-protected pages. Please add this group to $wgRestrictionLevels to resolve this problem. [22:19:31] (03CR) 10Siebrand: [C: 032] Swap and for && [core] - 10https://gerrit.wikimedia.org/r/168404 (owner: 10Chad) [22:19:39] 3MediaWiki / 3General/Unknown: Bring back the view counter and make it optional - 10https://bugzilla.wikimedia.org/72420#c4 (10Subfader) And still, the counter may not read the exact number of "views", but in comparisson with other page view counts it's just perfect enough to get an idea of the propularity a... [22:21:07] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/168410 (owner: 10Welterkj) [22:21:22] 3MediaWiki extensions / 3CirrusSearch: Redirects should appear in Cirrus's results - 10https://bugzilla.wikimedia.org/71491#c7 (10Nik Everett) Two answers to two different questions: 1. If LuceneSearch is timing out or failing in another way we'll need to fix it. At lest for the next few months. The link... [22:22:23] 3MediaWiki / 3General/Unknown: Bring back the view counter and make it optional - 10https://bugzilla.wikimedia.org/72420#c5 (10Subfader) "Setting priorities is left to developers, hence resetting." Then the form shouldnt give me the option... [22:22:53] 3MediaWiki / 3General/Unknown: Bring back the view counter and make it optional - 10https://bugzilla.wikimedia.org/72420 (10Subfader) p:5Lowest>3High [22:24:11] (03Merged) 10jenkins-bot: MessagesNds_nl.php: Remove lies [core] - 10https://gerrit.wikimedia.org/r/168418 (owner: 10Bartosz Dziewoński) [22:25:25] (03Merged) 10jenkins-bot: Swap and for && [core] - 10https://gerrit.wikimedia.org/r/168404 (owner: 10Chad) [22:27:08] 3MediaWiki extensions / 3CirrusSearch: Redirects should appear in Cirrus's results - 10https://bugzilla.wikimedia.org/71491#c8 (10Nik Everett) A (maybe bad) idea! What if we piped the list of redirects that match the query back through the api. You'd still get the non-redirect page back but it'd come with... [22:30:37] (03CR) 10Trevor Parscal: [C: 032] Add support for delivering templates via ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/167342 (owner: 10Jdlrobson) [22:32:39] 3MediaWiki / 3General/Unknown: Bring back the view counter and make it optional - 10https://bugzilla.wikimedia.org/72420#c6 (10Bartosz Dziewoński) (In reply to Subfader from comment #5) > Then the form shouldnt give me the option... You can remove your own 'editbugs' permission at (03PS1) 10Foxtrott: Doc fix [skins/chameleon] - 10https://gerrit.wikimedia.org/r/168500 [22:33:32] (03CR) 10Foxtrott: [C: 032 V: 032] Doc fix [skins/chameleon] - 10https://gerrit.wikimedia.org/r/168500 (owner: 10Foxtrott) [22:35:08] (03PS4) 10EBernhardson: Switch to templates in core. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168317 (owner: 10Jdlrobson) [22:35:11] (03PS10) 10EBernhardson: Use templates in core. [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/167114 (owner: 10Jdlrobson) [22:35:54] (03PS1) 10Foxtrott: Doc fix [skins/chameleon] - 10https://gerrit.wikimedia.org/r/168501 [22:36:09] (03CR) 10Foxtrott: [C: 032 V: 032] Doc fix [skins/chameleon] - 10https://gerrit.wikimedia.org/r/168501 (owner: 10Foxtrott) [22:36:56] (03PS1) 10Bartosz Dziewoński: MessagesSv.php: Also remove lies [core] - 10https://gerrit.wikimedia.org/r/168502 [22:37:10] (03CR) 10Krinkle: Add support for delivering templates via ResourceLoader (031 comment) [core] - 10https://gerrit.wikimedia.org/r/167342 (owner: 10Jdlrobson) [22:37:25] 3Wikimedia / 3Site requests: New "WMDE staff" user group for Wikidata - 10https://bugzilla.wikimedia.org/72459 (10Robin Pepermans (SPQRobin)) 3NEW p:3Unprio s:3normal a:3None Per consensus on https://www.wikidata.org/wiki/Wikidata:Requests_for_comment/New_user_group_for_developers, a user group "WMDE... [22:38:52] 3Wikimedia / 3Site requests: New "WMDE staff" user group for Wikidata - 10https://bugzilla.wikimedia.org/72459 (10John F. Lewis) p:5Unprio>3Normal [22:39:23] (03CR) 10Aaron Schulz: Add forceRenameUsers.php (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/161632 (owner: 10Legoktm) [22:40:38] 3Wikimedia / 3Site requests: New "WMDE staff" user group for Wikidata - 10https://bugzilla.wikimedia.org/72459#c1 (10John F. Lewis) I CC'd Lydia as I feel we can invalidate this bug by accessing whether the staff really still need access on their WMDE accounts. [22:41:16] (03CR) 10jenkins-bot: [V: 04-1] Use templates in core. [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/167114 (owner: 10Jdlrobson) [22:41:38] (03CR) 10jenkins-bot: [V: 04-1] Switch to templates in core. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168317 (owner: 10Jdlrobson) [22:44:21] (03PS2) 10Jdlrobson: Drop ResourceLoaderTemplateModule [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/168233 [22:44:23] (03PS11) 10Jdlrobson: Use templates in core. [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/167114 [22:45:12] (03CR) 10jenkins-bot: [V: 04-1] Drop ResourceLoaderTemplateModule [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/168233 (owner: 10Jdlrobson) [22:45:14] (03CR) 10jenkins-bot: [V: 04-1] Use templates in core. [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/167114 (owner: 10Jdlrobson) [22:46:22] 3MediaWiki / 3General/Unknown: Bring back the view counter and make it optional - 10https://bugzilla.wikimedia.org/72420#c7 (10Chad H.) (In reply to Subfader from comment #4) > I totally respect the dev but I hate to see all these WP only changes while > punching the face of the standard MW users with such d... [22:47:41] (03CR) 10Krinkle: [C: 04-1] "Breaks with localstorage caching." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/167342 (owner: 10Jdlrobson) [22:48:01] (03CR) 10Krinkle: "This should be mediawiki.template and mediawiki.template.js as the interface is mw.template, not mw.templates. And also per convention and" [core] - 10https://gerrit.wikimedia.org/r/167342 (owner: 10Jdlrobson) [22:49:09] 3Wikimedia / 3Site requests: New "WMDE staff" user group for Wikidata - 10https://bugzilla.wikimedia.org/72459#c2 (10Robin Pepermans (SPQRobin)) I overlooked two things; my original comment should contain: * User rights would be all those of administrators/bureaucrats/translationadmins; except the ability t... [22:52:10] 3MediaWiki-Vagrant: Setting up language links - 10https://bugzilla.wikimedia.org/72460 (10Jon) 3NEW p:3Unprio s:3normal a:3None Setting up language links is a pain in Vagrant You manually have to do something like this on your new install: INSERT INTO interwiki (iw_prefix, iw_url, iw_local, iw_trans) V... [22:53:17] (03CR) 10Krinkle: Add support for delivering templates via ResourceLoader (031 comment) [core] - 10https://gerrit.wikimedia.org/r/167342 (owner: 10Jdlrobson) [22:54:01] (03PS33) 10EBernhardson: Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [22:57:26] (03PS19) 10Krinkle: resourceloader: Add support for delivering templates [core] - 10https://gerrit.wikimedia.org/r/167342 (owner: 10Jdlrobson) [22:57:31] (03CR) 10Krinkle: resourceloader: Add support for delivering templates (031 comment) [core] - 10https://gerrit.wikimedia.org/r/167342 (owner: 10Jdlrobson) [22:58:15] (03CR) 10Legoktm: Add forceRenameUsers.php (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/161632 (owner: 10Legoktm) [22:58:46] (03CR) 10Krinkle: [C: 04-1] "Pending:" [core] - 10https://gerrit.wikimedia.org/r/167342 (owner: 10Jdlrobson) [22:59:08] TrevorParscal: I didn't know you +2'ed until after I finished, but I cancelled yours. [22:59:20] ? [22:59:28] I didn't know you were reviewing [22:59:30] that's awesome [22:59:33] you find some stuff? [22:59:36] (03PS1) 10Legoktm: BatchCAAntiSpoof: Use CentralAuthUser::waitForSlaves() [extensions/CentralAuth] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168513 [22:59:39] I've been reviewing since patch set 2 [22:59:45] (03PS1) 10Legoktm: Allow subclasses of BatchAntiSpoof to override the wfWaitForSlaves() call [extensions/AntiSpoof] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168514 [22:59:50] I had some older unhandled comments and found new problems [22:59:54] yeah, but your stuff was addressed (from what i could tell) [23:00:01] ok, well that's great, thanks for helping review man [23:00:21] sorry I didn't know you were still looking at the revision, Roan and I have been looking at it all day [23:00:37] (03CR) 10Kaldari: [C: 04-1] Use templates in core. (033 comments) [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/167114 (owner: 10Jdlrobson) [23:01:07] TrevorParscal: Yeah, no worries. Ijsut came back home. [23:01:15] And been getting e-mails all day hoping to take a look at it :) [23:07:14] (03PS3) 10Jdlrobson: Drop ResourceLoaderTemplateModule [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/168233 [23:07:54] (03CR) 10jenkins-bot: [V: 04-1] Drop ResourceLoaderTemplateModule [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/168233 (owner: 10Jdlrobson) [23:09:14] (03CR) 10Aaron Schulz: Add forceRenameUsers.php (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/161632 (owner: 10Legoktm) [23:13:08] (03PS8) 10Legoktm: Add forceRenameUsers.php [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/161632 [23:13:53] (03CR) 10Legoktm: Add forceRenameUsers.php (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/161632 (owner: 10Legoktm) [23:14:49] (03CR) 10Aaron Schulz: [C: 032] Add forceRenameUsers.php [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/161632 (owner: 10Legoktm) [23:15:36] (03Merged) 10jenkins-bot: Add forceRenameUsers.php [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/161632 (owner: 10Legoktm) [23:16:50] (03CR) 10Catrope: [C: 032] Update TimedMediaHandler submodule [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168403 (owner: 10Gergő Tisza) [23:16:55] (03CR) 10Catrope: [C: 032] Update TimedMediaHandler submodule [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/168415 (owner: 10Gergő Tisza) [23:17:07] (03CR) 10Catrope: [C: 032] Respect $wgApiFrameOptions in formatted API output mode [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168386 (https://bugzilla.wikimedia.org/72340) (owner: 10Gergő Tisza) [23:17:22] (03CR) 10Catrope: [C: 032] Update UploadWizard submodule [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/168496 (owner: 10Gergő Tisza) [23:17:27] (03CR) 10Catrope: [C: 032] Update UploadWizard submodule [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168487 (owner: 10Gergő Tisza) [23:17:32] (03CR) 10Catrope: [C: 032] BatchCAAntiSpoof: Use CentralAuthUser::waitForSlaves() [extensions/CentralAuth] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168513 (owner: 10Legoktm) [23:17:37] (03CR) 10Catrope: [C: 032] Allow subclasses of BatchAntiSpoof to override the wfWaitForSlaves() call [extensions/AntiSpoof] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168514 (owner: 10Legoktm) [23:23:33] (03Merged) 10jenkins-bot: Update TimedMediaHandler submodule [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168403 (owner: 10Gergő Tisza) [23:23:36] (03Merged) 10jenkins-bot: Update TimedMediaHandler submodule [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/168415 (owner: 10Gergő Tisza) [23:24:25] (03Merged) 10jenkins-bot: Respect $wgApiFrameOptions in formatted API output mode [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168386 (https://bugzilla.wikimedia.org/72340) (owner: 10Gergő Tisza) [23:24:31] (03Merged) 10jenkins-bot: Update UploadWizard submodule [core] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/168496 (owner: 10Gergő Tisza) [23:24:33] (03Merged) 10jenkins-bot: Update UploadWizard submodule [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168487 (owner: 10Gergő Tisza) [23:24:35] (03Merged) 10jenkins-bot: BatchCAAntiSpoof: Use CentralAuthUser::waitForSlaves() [extensions/CentralAuth] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168513 (owner: 10Legoktm) [23:24:37] (03Merged) 10jenkins-bot: Allow subclasses of BatchAntiSpoof to override the wfWaitForSlaves() call [extensions/AntiSpoof] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168514 (owner: 10Legoktm) [23:25:59] (03CR) 10Jdlrobson: "Timo can you elaborate on how to get round the RL caching issue. It's been a while since I looked at that code so I'll need to be reminded" [core] - 10https://gerrit.wikimedia.org/r/167342 (owner: 10Jdlrobson) [23:31:31] (03CR) 10Krinkle: "For the backend: Templates weren't considered in module timestamp and cached invalidation. So in practice, changes to templates would neve" [core] - 10https://gerrit.wikimedia.org/r/167342 (owner: 10Jdlrobson) [23:33:46] (03PS1) 10Legoktm: Update AntiSpoof to 1.25wmf4 HEAD [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168517 [23:33:50] RoanKattouw: ^ [23:34:22] (03PS1) 10Legoktm: Update CentralAuth to 1.25wmf4 HEAD [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168518 [23:35:02] (03PS1) 10Catrope: Update AntiSpoof and CentralAuth extensions for I1e90af4d87e4 and Id0ad48d56 [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168519 [23:35:04] Oh dude [23:35:07] I had just created one [23:35:27] (03Abandoned) 10Legoktm: Update CentralAuth to 1.25wmf4 HEAD [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168518 (owner: 10Legoktm) [23:35:29] (03Abandoned) 10Legoktm: Update AntiSpoof to 1.25wmf4 HEAD [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168517 (owner: 10Legoktm) [23:35:37] well, I just use a script so it's nbd :P [23:36:07] (03CR) 10Catrope: [C: 032] Update AntiSpoof and CentralAuth extensions for I1e90af4d87e4 and Id0ad48d56 [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168519 (owner: 10Catrope) [23:36:24] (03CR) 10Catrope: [V: 032] Update AntiSpoof and CentralAuth extensions for I1e90af4d87e4 and Id0ad48d56 [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168519 (owner: 10Catrope) [23:42:32] (03PS1) 10EBernhardson: Hygiene: exit() should be avoided [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168520 [23:42:35] (03PS1) 10EBernhardson: Hygiene: Files should not be executable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168521 [23:42:38] (03PS1) 10EBernhardson: Hygiene: Pass block instances rather than the factory [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168522 [23:43:37] (03CR) 10Reedy: [C: 032] Hygiene: Files should not be executable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168521 (owner: 10EBernhardson) [23:44:25] (03PS2) 10EBernhardson: Hygiene: Files should not be executable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168521 [23:44:40] (03PS2) 10EBernhardson: Hygiene: Pass block instances rather than the factory [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168522 [23:44:51] (03CR) 10Legoktm: "We typically use die or exit here, but this is a register_globals guard that probably isn't needed anymore?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168520 (owner: 10EBernhardson) [23:47:27] (03PS2) 10EBernhardson: Hygiene: remove unnecessary register_globals guard [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168520 [23:48:03] (03CR) 10EBernhardson: [C: 032] "re-apply reedy +2" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168521 (owner: 10EBernhardson) [23:48:40] 3MediaWiki extensions / 3Scribunto: Show the stack trace on error when using the debug console - 10https://bugzilla.wikimedia.org/72462 (10Mr. Stradivarius) 3NEW p:3Unprio s:3enhanc a:3None It would be nice if errors in the debug console showed the stack trace as well as the error message. For a fun... [23:48:42] (03CR) 10EBernhardson: "even better, lets delete the whole clause :)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168520 (owner: 10EBernhardson) [23:48:53] (03Merged) 10jenkins-bot: Hygiene: Files should not be executable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/168521 (owner: 10EBernhardson)