[00:06:26] (03CR) 10Chad: [C: 032] Added another size limit check to Job::toString [core] - 10https://gerrit.wikimedia.org/r/165661 (owner: 10Aaron Schulz) [00:08:08] (03PS6) 10Mitar: Allow adding custom parameters to the callback for OAuth. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/153983 [00:08:37] (03CR) 10Mitar: "@Siebrand, I added dots." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/153983 (owner: 10Mitar) [00:11:56] (03Merged) 10jenkins-bot: Added another size limit check to Job::toString [core] - 10https://gerrit.wikimedia.org/r/165661 (owner: 10Aaron Schulz) [00:17:26] (03CR) 10Bmansurov: "Buttons usually have a background, but anchors don't." [core] - 10https://gerrit.wikimedia.org/r/165256 (owner: 10Jdlrobson) [00:21:55] (03CR) 10Aaron Schulz: [C: 04-1] Add renameALLtheusers.php (038 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/161632 (owner: 10Legoktm) [00:25:10] (03PS2) 10Spage: J-2a Affix board navigation to viewport top on scroll [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167059 (owner: 10SG) [00:26:08] (03CR) 10jenkins-bot: [V: 04-1] J-2a Affix board navigation to viewport top on scroll [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167059 (owner: 10SG) [00:26:52] (03CR) 10Ori.livneh: "Needs manual rebase and a better commit message" [core] - 10https://gerrit.wikimedia.org/r/167421 (owner: 10Aaron Schulz) [00:29:04] (03CR) 10Aaron Schulz: [C: 04-1] "I really want a backtrace on this" [core] - 10https://gerrit.wikimedia.org/r/165024 (owner: 10Aaron Schulz) [00:30:46] (03PS2) 10Aaron Schulz: Always supported delayed jobs in JobQueueRedis for simplicity [core] - 10https://gerrit.wikimedia.org/r/167421 [00:34:35] (03CR) 10Aaron Schulz: "Can you submit a config patch so we don't forget?" (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/167635 (owner: 10Legoktm) [00:35:47] (03PS2) 10Aaron Schulz: Add oi_sha1, oi_timestamp log_search relations for upload overwrites [core] - 10https://gerrit.wikimedia.org/r/167392 (owner: 10Brian Wolff) [00:38:23] (03PS1) 10Yaron Koren: Changed one last wfMsg() to wfMessage() [extensions/SiteSettings] - 10https://gerrit.wikimedia.org/r/167734 [00:39:09] (03PS3) 10Ori.livneh: Always supported delayed jobs in JobQueueRedis for simplicity [core] - 10https://gerrit.wikimedia.org/r/167421 (owner: 10Aaron Schulz) [00:41:19] (03CR) 10Yaron Koren: [C: 032 V: 031] Changed one last wfMsg() to wfMessage() [extensions/SiteSettings] - 10https://gerrit.wikimedia.org/r/167734 (owner: 10Yaron Koren) [00:41:24] (03Merged) 10jenkins-bot: Changed one last wfMsg() to wfMessage() [extensions/SiteSettings] - 10https://gerrit.wikimedia.org/r/167734 (owner: 10Yaron Koren) [00:43:26] (03CR) 10Aaron Schulz: "Why not just query the oldimage table? Is it just selective deletion that causes problems?" [core] - 10https://gerrit.wikimedia.org/r/167392 (owner: 10Brian Wolff) [00:46:24] (03CR) 10Ori.livneh: [C: 032] Always supported delayed jobs in JobQueueRedis for simplicity [core] - 10https://gerrit.wikimedia.org/r/167421 (owner: 10Aaron Schulz) [00:46:29] (03PS4) 10EBernhardson: J-1: Comment moderation updates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166778 [00:47:36] (03CR) 10jenkins-bot: [V: 04-1] J-1: Comment moderation updates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166778 (owner: 10EBernhardson) [00:49:15] Okay, how do I make a query in Phabricator? [00:49:17] I can't edit the built-ins. [00:49:22] I can only execute them. [00:49:33] They're explicitly locked, adorable. [00:51:57] (03Merged) 10jenkins-bot: Always supported delayed jobs in JobQueueRedis for simplicity [core] - 10https://gerrit.wikimedia.org/r/167421 (owner: 10Aaron Schulz) [00:52:15] (03CR) 10Aaron Schulz: [C: 032] SqlBagOStuff: fix percentage in deleteObjectsExpiringBefore() [core] - 10https://gerrit.wikimedia.org/r/167047 (owner: 10Taueres) [00:58:10] (03Merged) 10jenkins-bot: SqlBagOStuff: fix percentage in deleteObjectsExpiringBefore() [core] - 10https://gerrit.wikimedia.org/r/167047 (owner: 10Taueres) [01:08:48] hey qgil, I'm trying to log into Phabricator, but it's giving me an invalid username and password. Any gotchas that I should be aware of? I've tried my normal wiki user/password, my gerrit user/password, and my wikitech user/password [01:09:43] (03CR) 10Brian Wolff: "This is actually more part 1 of a commit I want to make." [core] - 10https://gerrit.wikimedia.org/r/167392 (owner: 10Brian Wolff) [01:10:01] qgil: aha, it looks like I'm supposed to click the link below to use a wiki user/password, not type it into the login form above. [01:10:13] werdna, that :) [01:10:40] werdna, https://www.mediawiki.org/wiki/Phabricator/Help#Creating_your_account [01:11:09] I guess in the glorious future my LDAP and CentralAuth accounts will be linked in harmony and love [01:11:27] werdna, btw, your wikitech user/password (aka LDAP) should have worked [01:11:37] yeah, not sure why that didn't happen [01:11:39] * werdna shrugs [01:11:44] maybe it's an old password in my pw manager [01:11:55] werdna, that glorious future is happening now :) [01:12:10] so I should choose my username to be my LDAP username? [01:12:42] werdna, from the link above, "In your first login, Phabricator will ask you for a username. In case of doubt, just use your Wikimedia username." [01:12:55] 3Wikimedia / 3Mailing lists: disable the defunct mk-edu list - 10https://bugzilla.wikimedia.org/72289 (10Asaf Bartov) 3NEW p:3Unprio s:3normal a:3None The mk-edu mailing list was created in support of an education program attempted by Wikimedia Macedonia. The program is apparently discontinued, its... [01:13:21] nod, but my LDAP username is 'werdna' and my wikimedia username is "Andrew Garrett (WMF)" [01:14:03] werdna, you wanted a glorious future with just one username, right? Choose it. :) [01:14:34] werdna: You can do OAuth via mediawiki.org if you want. [01:14:43] Carmela: figured it out :) [01:14:48] Nice. [01:15:00] I found the login form confusing. [01:15:05] I made a bugs page. [01:15:07] sadly I think others envision a different glorious future where every Wikimedia employee has a separate account for work and personal stuff. [01:15:13] https://www.mediawiki.org/wiki/Phabricator/Bugs [01:15:24] Wikimedia Foundation employee * [01:15:32] werdna, and you can therefore have separate Phabricator accounts for the same [01:15:49] WELCOME TO THE FUTURE!!! [01:17:50] heh, I will probably keep just one phab account. With two jobs plus two weeks left of university plus a girlfriend on another continent, I don't exactly have a lot of time for coding for fun. [01:18:03] plus moving to said other continent in less than two weeks. [01:20:11] werdna: The same other continent? [01:20:54] yes, it'll be back to Maastricht for 3 months, then 4–6 months in Prague, and then most likely indefinitely in Sweden. [01:21:00] Nice [01:23:31] turns out I don't actually know my labs password [01:35:36] (03PS5) 10EBernhardson: J-1: Comment moderation updates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166778 [01:35:39] (03PS1) 10EBernhardson: I-1: Finish topic moderation updates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167738 [01:36:21] (03CR) 10jenkins-bot: [V: 04-1] J-1: Comment moderation updates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166778 (owner: 10EBernhardson) [01:36:28] (03CR) 10jenkins-bot: [V: 04-1] I-1: Finish topic moderation updates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167738 (owner: 10EBernhardson) [01:40:08] (03PS1) 10Chad: Remove unused variable [core] - 10https://gerrit.wikimedia.org/r/167739 [01:40:31] (03PS2) 10Chad: Remove unused variable in ProfilerMwprof [core] - 10https://gerrit.wikimedia.org/r/167739 [01:41:05] (03PS1) 10Yaron Koren: Simplified querying of page_props table [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/167740 [01:41:56] (03CR) 10Yaron Koren: [C: 032 V: 031] Simplified querying of page_props table [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/167740 (owner: 10Yaron Koren) [01:42:28] (03CR) 10Yaron Koren: [V: 032] Simplified querying of page_props table [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/167740 (owner: 10Yaron Koren) [01:43:59] (03PS1) 10RobinHood70: Fix pagecount output [core] - 10https://gerrit.wikimedia.org/r/167741 [01:45:52] 3Wikimedia / 3Fundraising: Fundraising banner cannot be permanently dismissed on English Wikipedia - 10https://bugzilla.wikimedia.org/72271#c4 (10MZMcBride) Awesome, thank you, Peter! [02:00:39] 3MediaWiki extensions / 3Collection: "Preview with PediaPress" defunct - 10https://bugzilla.wikimedia.org/71675#c12 (10Erik Moeller) That changeset landed on WP last week, yes? If so, how are things on the PP side of things - can we re-enable soon? We're still expecting to phase this out eventually, but for... [02:09:15] (03PS13) 10Werdna: Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) [02:09:30] (03CR) 10Tim Starling: "The revision this is based on was reverted." [core] - 10https://gerrit.wikimedia.org/r/167567 (owner: 10Krinkle) [02:09:59] (03CR) 10jenkins-bot: [V: 04-1] Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [02:23:03] (03CR) 10Brian Wolff: "For people using normal file system to store images (not swift), if they request a thumbnail of the file from Special:UploadStash/thumb, i" [core] - 10https://gerrit.wikimedia.org/r/167296 (owner: 10Aaron Schulz) [02:26:15] (03PS14) 10Werdna: Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) [02:27:00] (03CR) 10jenkins-bot: [V: 04-1] Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [02:27:41] (03PS15) 10Werdna: Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) [02:43:43] (03PS1) 10Milimetric: [WIP] Add schema for edit fact table [data-warehouse] - 10https://gerrit.wikimedia.org/r/167742 [02:53:25] 3Wikimedia / 3IEG grant review: Setup project with translatewiki.net - 10https://bugzilla.wikimedia.org/72291 (10Bryan Davis) 3NEW p:3Unprio s:3enhanc a:3None Setup integration with translatewiki.net as requested by committee members: > Internationalization of interface messages including descriptio... [02:53:37] 3Wikimedia / 3IEG grant review: Setup project with translatewiki.net - 10https://bugzilla.wikimedia.org/72291 (10Bryan Davis) p:5Unprio>3Normal [03:05:10] 3Wikimedia / 3IEG grant review: Integrate with OAuth - 10https://bugzilla.wikimedia.org/72292 (10Bryan Davis) 3NEW p:3Unprio s:3enhanc a:3None Integrating with OAuth would allow authentication without storing and managing passwords in the application. There would probably still be a need to manage au... [03:06:07] 3Wikimedia / 3IEG grant review: Integrate with OAuth - 10https://bugzilla.wikimedia.org/72292 (10Bryan Davis) p:5Unprio>3Low [03:17:15] (03CR) 10Legoktm: [C: 032] Remove unused variable in ProfilerMwprof [core] - 10https://gerrit.wikimedia.org/r/167739 (owner: 10Chad) [03:22:49] (03Merged) 10jenkins-bot: Remove unused variable in ProfilerMwprof [core] - 10https://gerrit.wikimedia.org/r/167739 (owner: 10Chad) [03:41:23] 3MediaWiki extensions / 3Math: MathJax zoomed preview shouldn't be hidden when "click-dragged" on - 10https://bugzilla.wikimedia.org/36091#c6 (10Waldir) 5RESO/WON>3REOP (In reply to physikerwelt from comment #5) > This should be fixed within MathJax. Sure, that's why it is marked "upstream". The bug hasn... [04:05:26] (03PS1) 10Cscott: Add ability to limit the number of simultaneous requests for small wikis. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/167743 (https://bugzilla.wikimedia.org/71895) [04:32:37] (03CR) 10Parent5446: Allow for time-limited tokens (032 comments) [core] - 10https://gerrit.wikimedia.org/r/156336 (owner: 10Anomie) [04:49:20] (03PS5) 10Werdna: Expose replies in API response. [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/165689 [04:54:52] 3Wikimedia / 3Extension setup: Enable #lsth from Labeled Section Transclusion on pt.wikiversity - 10https://bugzilla.wikimedia.org/61804#c10 (10George Orwell III) (In reply to Glaisher from comment #6) > Since this is currently not enabled on any Wikimedia wiki, it probably needs > to be reviewed before enab... [04:59:59] (03CR) 10Mattflaschen: [C: 04-1] "threadIds is an array, not an int." [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/165689 (owner: 10Werdna) [05:00:20] superm401: whoops :/ [05:00:37] werdna, no worries. [05:00:56] (03PS6) 10Werdna: Expose replies in API response. [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/165689 [05:13:55] (03CR) 10Werdna: Expose replies in API response. (033 comments) [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/165689 (owner: 10Werdna) [05:20:10] 3MediaWiki extensions / 3Collection: "Preview with PediaPress" defunct - 10https://bugzilla.wikimedia.org/71675#c13 (10Christoph Kepper) Hi Erik, I talked to Nemo and CScott last week during the bug triage. As you can see above the PediaPress public toolserver could not handle the load from Wikipedia post re... [05:23:44] werdna, nice: https://i.imgur.com/kLA7Anj.png [05:23:44] ding dong, the LQT is dead [05:23:44] (but still needs history) [05:23:44] werdna, yep, but that shouldn't block merge IMHO (although it will block using it). [05:23:45] nod [05:28:36] (03CR) 10Mattflaschen: [C: 04-1] "It works! See https://i.imgur.com/kLA7Anj.png or better yet test. :)" (036 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [05:33:40] superm401: with the topicIterator, the issue is that the iterator is rebuilt [05:33:54] Yeah, that's what I meant re Load More. [05:34:16] oh wait, I see what you mean [05:39:26] I tried changing the loop to this, but now only one result is returned @superm401 https://phabricator.wikimedia.org/P33 [05:41:43] ah, next comes after current() [05:42:26] werdna, I'm done for tonight, but that's not quite what I meant. [05:42:41] I meant that e.g. a call to next on the outer class should be passed along to TopicIterator->topicIdIterator->next (and corresponding things for the others). [05:42:52] But I'm not sure that will work due to how loadMore currently works. [05:43:19] If it's still doing the loop and checking topicId against lastOffset every time you call next, there's no benefit. [05:43:30] The goal is not to tweak the methods used by the loop, but to eliminate it. [05:43:37] Not a blocker, though. [05:43:41] Got to go for tonight. [05:44:56] (03PS16) 10Werdna: Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) [05:45:22] well, there's a small benefit [05:45:27] anyway, sleep well [06:06:53] 3Wikimedia / 3General/Unknown: Allow users to edit via Tor while still being able to fight abuse - 10https://bugzilla.wikimedia.org/69333#c9 (10Arlo Breault) I've expanded on the proposal in comment 7 here: https://lists.wikimedia.org/pipermail/wikitech-l/2014-October/079016.html [06:11:53] 3Wikimedia / 3Fundraising: Add /fundraising to dumps.wikimedia.org - 10https://bugzilla.wikimedia.org/40847#c4 (10Nemo) Same for http://frdata.wikimedia.org/ I guess [06:50:07] 3MediaWiki / 3Database: table_type is removed in MySQL 5.5.3 - 10https://bugzilla.wikimedia.org/71566#c7 (10B. Miller) Created attachment 16827 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16827&action=edit a patch based on getServerVersion() I wonder if something like the attached would work well... [07:23:19] (03CR) 10Werdna: "It's in pretty good shape, but as S suggested we need to record associations between import sources and topic / post IDs so we don't doubl" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [07:24:26] 3Wikimedia / 3Mailing lists: Mailman administration frequently fails on Chrome. - 10https://bugzilla.wikimedia.org/56842#c9 (10Tisza Gergő) A strange but (for me) reliable workaround is to close the browser tab after clicking submit. [07:42:43] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Allow non-text content to use HTML for transclusion. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/132710 (owner: 10Daniel Kinzler) [07:44:23] 3MediaWiki extensions / 3CirrusSearch: Refining typeahead search results for subpages at English Wikisource - 10https://bugzilla.wikimedia.org/69658 (10Andre Klapper) [07:44:23] 3MediaWiki / 3Search: Restring search to subpages of a page - 10https://bugzilla.wikimedia.org/72285 (10Andre Klapper) p:5Unprio>3Low [07:54:15] (03PS6) 10Awight: Extensions may add tests by directory [core] - 10https://gerrit.wikimedia.org/r/163528 [07:54:37] (03CR) 10Awight: Extensions may add tests by directory (031 comment) [core] - 10https://gerrit.wikimedia.org/r/163528 (owner: 10Awight) [07:55:40] (03PS7) 10Awight: Extensions may add tests by directory [core] - 10https://gerrit.wikimedia.org/r/163528 [07:55:52] 3Wikimedia / 3Mailing lists: disable the defunct mk-edu list - 10https://bugzilla.wikimedia.org/72289 (10Andre Klapper) p:5Unprio>3Normal s:5normal>3enhanc [07:58:37] 3MediaWiki / 3JobQueue: Job queue not running (HTTP 411) due to missing Content-Length: header - 10https://bugzilla.wikimedia.org/72274#c10 (10Andre Klapper) Wondering whether that (merged in master) one-liner patch should be backported to 1.23 tarballs - setting backport flag to "?" and CC'ing Mark y Markus. [08:04:23] 3MediaWiki / 3General/Unknown: At least one user is permanently unable to use Special:RecentChanges on translatewiki.net - 10https://bugzilla.wikimedia.org/72228 (10Andre Klapper) p:5Unprio>3High [08:04:38] 3MediaWiki / 3JavaScript: Tipsy popup mispositioned on page load - 10https://bugzilla.wikimedia.org/72267 (10Andre Klapper) p:5Unprio>3Normal [08:04:53] 3MediaWiki / 3General/Unknown: User::isAnon should not cause an unnecessary load() call - 10https://bugzilla.wikimedia.org/72266 (10Andre Klapper) p:5Unprio>3Normal [08:21:16] (03PS1) 10Mglaser: Initialize variable to prevent error message [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/167754 [08:42:38] 3QRpedia: Language is not displayed on language links - 10https://bugzilla.wikimedia.org/71643#c1 (10albin) This bug should not have the LOWEST priority, since it effects the entire QRpedia project for any article not created in the users language. The user will get a message saying "Read this article in anot... [08:43:39] 3QRpedia: Language is not displayed on language links - 10https://bugzilla.wikimedia.org/71643 (10albin) [08:45:11] (03PS1) 10Matthias Mullie: Hygiene: fix feedback from scrutinizer #2 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167757 [09:10:53] (03CR) 10Smuggli: [C: 032 V: 032] Initialize variable to prevent error message [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/167754 (owner: 10Mglaser) [09:27:28] (03PS1) 10Cacycle: Version 1.2.3 (October 21, 2014) [extensions/WikEdDiff] - 10https://gerrit.wikimedia.org/r/167765 [09:30:26] (03CR) 10Cacycle: [C: 032 V: 032] Version 1.2.3 (October 21, 2014) [extensions/WikEdDiff] - 10https://gerrit.wikimedia.org/r/167765 (owner: 10Cacycle) [09:37:12] (03PS8) 10Hashar: Extensions may add tests by directory [core] - 10https://gerrit.wikimedia.org/r/163528 (https://bugzilla.wikimedia.org/70630) (owner: 10Awight) [09:37:44] (03CR) 10Hashar: [C: 031] "Pointed commit summary message to Bug: 70630." [core] - 10https://gerrit.wikimedia.org/r/163528 (https://bugzilla.wikimedia.org/70630) (owner: 10Awight) [09:39:25] (03CR) 10Aude: Make internal ORMTable::unprefixFieldNames private (032 comments) [core] - 10https://gerrit.wikimedia.org/r/166568 (owner: 10Thiemo Mättig (WMDE)) [09:39:47] (03CR) 10Aude: [C: 032] "together with the follow up, looks good" [core] - 10https://gerrit.wikimedia.org/r/166439 (owner: 10Thiemo Mättig (WMDE)) [09:41:26] (03PS1) 10Matthias Mullie: Hygiene: fix feedback from scrutinizer #3 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167767 [09:42:35] (03PS3) 10Mvolz: maps added as allowed value in TD JSON root [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167389 [09:45:33] (03Merged) 10jenkins-bot: Rewrite ORMTable::unprefixFieldNames [core] - 10https://gerrit.wikimedia.org/r/166439 (owner: 10Thiemo Mättig (WMDE)) [09:46:19] (03PS4) 10Mvolz: maps added as allowed value in TD JSON root [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167389 [09:51:46] (03CR) 10Hashar: "When a skin is missing we dump a rather "nice" message on all pages such as : http://people.wikimedia.org/~hashar/skin-repo-missing.png" [core] - 10https://gerrit.wikimedia.org/r/119941 (owner: 10BryanDavis) [09:57:12] (03PS1) 10Christopher Johnson (WMDE): Refactor BurndownDataView [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/167770 [10:04:57] (03CR) 10Christopher Johnson (WMDE): [C: 032 V: 032] Refactor BurndownDataView [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/167770 (owner: 10Christopher Johnson (WMDE)) [10:15:08] (03PS4) 10Thiemo Mättig (WMDE): Make internal ORMTable::unprefixFieldNames private [core] - 10https://gerrit.wikimedia.org/r/166568 [10:23:56] (03PS2) 10Nikerabbit: Add language name for aeb [core] - 10https://gerrit.wikimedia.org/r/167374 [10:29:53] (03CR) 10Phuedx: [C: 032] "Tested in IE8-11, Chrome (38.0.2125.104), Firefox (33.0), Safari (8.0), iPhone 6+, and Opera Mobile (I like to throw a curveball once in a" [core] - 10https://gerrit.wikimedia.org/r/164392 (owner: 10Jdlrobson) [10:32:02] (03CR) 10Nikerabbit: ""Wait for a day to settle apertium-beta instance."" [services/cxserver/deploy] - 10https://gerrit.wikimedia.org/r/167629 (owner: 10KartikMistry) [10:32:56] (03CR) 10Physikerwelt: "Thiemo, you mentioned that you might know someone who has some experience with the mobile extension. Could you add her or him as reviewer?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/167696 (owner: 10Frédéric Wang) [10:35:27] (03Merged) 10jenkins-bot: Add mw-ui-icon-after [core] - 10https://gerrit.wikimedia.org/r/164392 (owner: 10Jdlrobson) [10:38:08] (03CR) 10Nikerabbit: Add defines file so namespace ID is only defined once (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167119 (owner: 10Mattflaschen) [10:54:33] (03PS1) 10Christopher Johnson (WMDE): Refactor SprintQuery [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/167773 [10:55:25] (03CR) 10Christopher Johnson (WMDE): [C: 032 V: 032] Refactor SprintQuery [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/167773 (owner: 10Christopher Johnson (WMDE)) [10:59:58] (03PS1) 10Zfilipin: Prepare repository for running RuboCop after every push to Gerrit [extensions/Echo] - 10https://gerrit.wikimedia.org/r/167774 (https://bugzilla.wikimedia.org/69245) [11:01:39] (03CR) 10Zfilipin: "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/167774 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [11:08:07] 3MediaWiki / 3Search: Restring search to subpages of a page - 10https://bugzilla.wikimedia.org/72285#c1 (10billinghurst) 5NEW>3RESO/WOR You can already, utilise the prefix component as described on the search help. Have a look at how we have a template at English Wikisource to manage this directly https... [11:10:37] 3MediaWiki extensions / 3CirrusSearch: Refining typeahead search results for subpages at English Wikisource - 10https://bugzilla.wikimedia.org/69658#c4 (10billinghurst) I have closed the added bug as it was a search with the "prefix" component, and that is an existing functionality. I have left instruction o... [11:10:47] (03PS1) 10Zfilipin: Prepare repository for running RuboCop after every push to Gerrit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167777 (https://bugzilla.wikimedia.org/69245) [11:11:34] (03CR) 10jenkins-bot: [V: 04-1] Prepare repository for running RuboCop after every push to Gerrit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167777 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [11:12:37] 3MediaWiki / 3Search: Restring search to subpages of a page - 10https://bugzilla.wikimedia.org/72285#c2 (10billinghurst) The search help page is at [[mw:Help:CirrusSearch]] and you should look at the "prefix:" component, and think usage like for "Special:PrefixIndex" [11:24:26] (03CR) 10Aude: Make internal ORMTable::unprefixFieldNames private (031 comment) [core] - 10https://gerrit.wikimedia.org/r/166568 (owner: 10Thiemo Mättig (WMDE)) [11:26:14] (03CR) 10Daniel Kinzler: [C: 031] "Seems fine, did not tests. Unit tests for this kind of thing would be nice." [core] - 10https://gerrit.wikimedia.org/r/164726 (https://bugzilla.wikimedia.org/25163) (owner: 10Tuxilina) [11:31:24] (03CR) 10Daniel Kinzler: [C: 032] Extensions may add tests by directory [core] - 10https://gerrit.wikimedia.org/r/163528 (https://bugzilla.wikimedia.org/70630) (owner: 10Awight) [11:35:38] 3Wikimedia / 3Language setup: Create Oriya Wikisource - 10https://bugzilla.wikimedia.org/71875#c20 (10Glaisher) 5PATC>3RESO/FIX https://or.wikisource.org [11:37:04] (03Merged) 10jenkins-bot: Extensions may add tests by directory [core] - 10https://gerrit.wikimedia.org/r/163528 (https://bugzilla.wikimedia.org/70630) (owner: 10Awight) [11:57:21] (03CR) 10Zfilipin: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167777 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [11:57:28] (03CR) 10Zfilipin: "check experimental" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167777 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [12:00:58] (03PS5) 10Thiemo Mättig (WMDE): Deprecate internal ORMTable::unprefixFieldName(s) [core] - 10https://gerrit.wikimedia.org/r/166568 [12:03:44] (03CR) 10Raimond Spekking: [C: 032] Add language name for aeb [core] - 10https://gerrit.wikimedia.org/r/167374 (owner: 10Nikerabbit) [12:04:55] 3Wikimedia / 3Extension setup: Enable #lsth from Labeled Section Transclusion on pt.wikiversity - 10https://bugzilla.wikimedia.org/61804 (10Glaisher) [12:04:58] 3Wikimedia / 3Extension setup: Enable Labeled Section Transclusion's lsth on mediawiki.org - 10https://bugzilla.wikimedia.org/43612 (10Glaisher) [12:04:58] 3Wikimedia / 3Extension setup: Extensions awaiting code review to be deployed on Wikimedia wikis (tracking) - 10https://bugzilla.wikimedia.org/31235 (10Glaisher) [12:04:58] 3Wikimedia / 3Extension setup: Enable Labeled Section Transclusion's #lsth on Wikimedia - 10https://bugzilla.wikimedia.org/72302 (10Glaisher) 3NEW p:3Unprio s:3normal a:3None Greg, any other review needed for this? and on which wikis are we enabling this? all by default? [12:04:58] 3MediaWiki extensions / 3LabeledSectionTransclusion: Security review of #lsth part of Extension:Labeled_Section_Transclusion - 10https://bugzilla.wikimedia.org/71861 (10Glaisher) [12:05:52] 3Wikimedia / 3Extension setup: Enable Labeled Section Transclusion's #lsth on Wikimedia - 10https://bugzilla.wikimedia.org/72302 (10Glaisher) p:5Unprio>3Normal s:5normal>3enhanc [12:05:54] 3Wikimedia / 3Site requests: Labeled section transclusion installation - 10https://bugzilla.wikimedia.org/26402 (10Glaisher) [12:09:29] (03Merged) 10jenkins-bot: Add language name for aeb [core] - 10https://gerrit.wikimedia.org/r/167374 (owner: 10Nikerabbit) [12:25:49] (03PS1) 10Matthias Mullie: Hygiene: fix feedback from scrutinizer #4 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167785 [12:25:52] (03PS1) 10Matthias Mullie: Hygiene: fix feedback from scrutinizer #5 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167786 [12:26:44] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: fix feedback from scrutinizer #5 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167786 (owner: 10Matthias Mullie) [12:28:37] 3MediaWiki / 3Search: Restring search to subpages of a page - 10https://bugzilla.wikimedia.org/72285#c3 (10VictorPorton) 5RESO/WOR>3REOP I want an where I can easily enter the prefix. The above described features are not enough. [12:33:26] (03PS8) 10Zfilipin: Prepare repository for running RuboCop after every push to Gerrit [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/167549 (https://bugzilla.wikimedia.org/69245) [12:35:58] (03CR) 10Hashar: [C: 031] Prepare repository for running RuboCop after every push to Gerrit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167777 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [12:37:22] 3MediaWiki / 3Internationalization: The values for each "Show"/"Hide" link in recent changes / watchlist options box ('rcshowhideminor' etc.) should be localizable per the show/hide state - 10https://bugzilla.wikimedia.org/62067 (10Niklas Laxström) 5REOP>3NEW p:5Unprio>3Low [12:38:37] (03PS2) 10Matthias Mullie: Hygiene: fix feedback from scrutinizer #5 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167786 [12:42:23] 3MediaWiki / 3Search: Restring search to subpages of a page - 10https://bugzilla.wikimedia.org/72285#c4 (10Glaisher) 5REOP>3RESO/INV This is already possible with the [[mw:Extension:InputBox]]. See the extension documentation page for more parameters. For example, the following wikitext would produce (03PS1) 10Matthias Mullie: Remove unused method ObjectLocator::visitAll [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167789 [12:42:47] (03PS1) 10Matthias Mullie: Remove unused file includes/OutputPage.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167790 [12:42:50] (03PS1) 10Matthias Mullie: Remove unused Workflow lockState [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167791 [12:43:44] (03CR) 10jenkins-bot: [V: 04-1] Remove unused Workflow lockState [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167791 (owner: 10Matthias Mullie) [12:44:23] 3MediaWiki / 3Internationalization: PHP Catchable fatal error: Argument 2 passed to CLDRPluralRuleEvaluator::evaluateCompiled() must be an array, null given, called in Language.php on line 4608 and defined in CLDRPluralRuleEvaluator.php on line 70 - 10https://bugzilla.wikimedia.org/59724#c7 (10Niklas Laxströ... [12:45:07] 3MediaWiki / 3Internationalization: getHumanTimestamp issues - 10https://bugzilla.wikimedia.org/64430 (10Niklas Laxström) p:5Unprio>3High [12:46:37] 3MediaWiki / 3Logging: logentry-upload-overwrite hardcoded in user language - 10https://bugzilla.wikimedia.org/70293 (10Niklas Laxström) p:5Unprio>3Low s:5normal>3minor [12:47:12] (03PS2) 10Matthias Mullie: Remove unused Workflow lockState [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167791 [12:50:24] 3MediaWiki / 3Internationalization: Consider using content language for "html lang", rather than interface language - 10https://bugzilla.wikimedia.org/68490#c3 (10Niklas Laxström) p:5Unprio>3Lowest I'm not sure whether this is something we want to try to fix or just leave it to the upstream to figure out... [12:50:30] (03CR) 10Hoo man: [C: 032] "Let's do this, if no one else cares!" [core] - 10https://gerrit.wikimedia.org/r/166522 (https://bugzilla.wikimedia.org/71545) (owner: 10Jackmcbarn) [12:52:44] (03Abandoned) 10Hoo man: Check for Revision::getContent returning null [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/166510 (https://bugzilla.wikimedia.org/71545) (owner: 10Hoo man) [12:54:07] 3MediaWiki extensions / 3AbuseFilter: Argument 1 passed to AbuseFilter::contentToString() must implement interface Content - 10https://bugzilla.wikimedia.org/71545#c5 (10Marius Hoch) 5PATC>3RESO/FIX Core patch approved, so that we no longer should see such revisions. [12:55:53] 3MediaWiki / 3Internationalization: Plural messages with callback functions for external links no longer work - 10https://bugzilla.wikimedia.org/71368#c1 (10Santhosh Thottingal) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 70617 *** [12:55:53] 3MediaWiki / 3Internationalization: Displays another file instead of a link to "the existing file". - 10https://bugzilla.wikimedia.org/70617#c10 (10Santhosh Thottingal) *** Bug 71368 has been marked as a duplicate of this bug. *** [12:56:05] (03Merged) 10jenkins-bot: Remove negative caching from Revision::getContentInternal [core] - 10https://gerrit.wikimedia.org/r/166522 (https://bugzilla.wikimedia.org/71545) (owner: 10Jackmcbarn) [13:02:15] (03PS17) 10SG: Implement OOJS on Flow JS classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165756 [13:04:25] (03PS1) 10Zfilipin: Prepare repository for running RuboCop after every push to Gerrit [extensions/Math] - 10https://gerrit.wikimedia.org/r/167792 (https://bugzilla.wikimedia.org/69245) [13:04:33] (03CR) 10SG: "This is the GROUP collapser stuff, meaning the button that changes all topics at once. There is still individual collapser code." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166727 (owner: 10SG) [13:04:46] (03PS3) 10SG: Remove topic group collapser [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166727 [13:04:58] (03CR) 10Zfilipin: "check experimental" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/167589 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [13:05:29] (03CR) 10Zfilipin: "check experimental" [extensions/Math] - 10https://gerrit.wikimedia.org/r/167792 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [13:05:32] (03CR) 10jenkins-bot: [V: 04-1] Remove topic group collapser [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166727 (owner: 10SG) [13:05:54] (03PS8) 10SG: Implement boardHistory component features [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166728 [13:06:42] (03PS9) 10SG: Implement boardHistory component features [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166728 [13:10:23] 3MediaWiki / 3Internationalization: Long message key page names cause memcached errors - 10https://bugzilla.wikimedia.org/66284 (10Niklas Laxström) p:5Unprio>3Low s:5normal>3minor [13:13:54] (03PS1) 10Zfilipin: Prepare repository for running RuboCop after every push to Gerrit [core] - 10https://gerrit.wikimedia.org/r/167794 (https://bugzilla.wikimedia.org/69245) [13:14:57] (03PS4) 10SG: Remove topic group collapser [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166727 [13:15:26] (03CR) 10SG: Implement OOJS on Flow JS classes (0314 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165756 (owner: 10SG) [13:15:41] (03CR) 10jenkins-bot: [V: 04-1] Remove topic group collapser [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166727 (owner: 10SG) [13:16:38] 3MediaWiki / 3Internationalization: Parameters can be expanded multiple times when using Message::rawParam - 10https://bugzilla.wikimedia.org/67003 (10Niklas Laxström) p:5Unprio>3High [13:20:24] (03CR) 10SG: JS sanity per Krinkle's patch (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166951 (owner: 10SG) [13:24:19] (03PS3) 10SG: JS sanity per Krinkle's patch [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166951 [13:24:22] (03PS9) 10SG: build: Implement Grunt workflow (via npm test) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163908 (owner: 10Spage) [13:29:47] (03CR) 10Zfilipin: "check experimental" [core] - 10https://gerrit.wikimedia.org/r/167794 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [13:30:08] (03CR) 10Hashar: "check experimental" [core] - 10https://gerrit.wikimedia.org/r/167794 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [13:33:21] (03CR) 10Hashar: [C: 04-1] "rubocop fails with a bunch of errors: https://integration.wikimedia.org/ci/job/mediawiki-core-bundle-rubocop/61/console" [core] - 10https://gerrit.wikimedia.org/r/167794 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [13:33:42] (03CR) 10SG: "I'm having trouble with this. It seems to be ignoring my .jshintignore file." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163908 (owner: 10Spage) [13:36:54] (03PS4) 10SG: JS sanity per Krinkle's patch [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166951 [13:38:11] (03CR) 10Zfilipin: "Not sure why, but mediawiki-core-bundle-rubocop job complains about problems in extensions, not in core." [core] - 10https://gerrit.wikimedia.org/r/167794 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [13:43:28] (03PS54) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [13:48:54] (03CR) 10Hashar: "The experimental check fails because the job is made to process submodules. mediawiki/core wmf branches have a bunch of extensions as sub" [core] - 10https://gerrit.wikimedia.org/r/167794 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [13:50:44] (03PS1) 10Zfilipin: Prepare repository for running RuboCop after every push to Gerrit [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/167801 (https://bugzilla.wikimedia.org/69245) [13:51:02] (03CR) 10Zfilipin: "check experimental" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/167801 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [13:57:56] (03PS1) 10Zfilipin: Prepare repository for running RuboCop after every push to Gerrit [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/167803 (https://bugzilla.wikimedia.org/69245) [13:58:16] (03CR) 10Matthias Mullie: Make watchlist topic title link to topic with with unread posts highlighted (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167218 (owner: 10Matthias Mullie) [13:58:29] (03CR) 10SG: "I don't understand why this is failing." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166727 (owner: 10SG) [14:01:08] 3MediaWiki extensions / 3Collection: "Preview with PediaPress" defunct - 10https://bugzilla.wikimedia.org/71675#c14 (10C. Scott Ananian) Yup. I was on vacation last week, but I'm back now. I'll try to test this new endpoint out today. [14:03:08] 3MediaWiki / 3API: API description of login action is misleading - 10https://bugzilla.wikimedia.org/71638 (10Brad Jorsch) 5PATC>3RESO/FIX [14:07:49] (03PS5) 10Matthias Mullie: J5: Expand action=purge on flow pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167016 (owner: 10EBernhardson) [14:08:10] (03CR) 10Matthias Mullie: [C: 032] J5: Expand action=purge on flow pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167016 (owner: 10EBernhardson) [14:08:22] 3MediaWiki / 3Search: Restring search to subpages of a page - 10https://bugzilla.wikimedia.org/72285#c5 (10billinghurst) or type ... prefix:Automatic_transformation_of_XML_namespaces into a search box, which is only several characters and no need to have a specialised search form, it works anywhere if you kn... [14:09:49] (03CR) 10Anomie: Allow for time-limited tokens (032 comments) [core] - 10https://gerrit.wikimedia.org/r/156336 (owner: 10Anomie) [14:19:16] (03CR) 10Anomie: Treat the "temp" repo zone as private (032 comments) [core] - 10https://gerrit.wikimedia.org/r/167296 (owner: 10Aaron Schulz) [14:22:03] (03Merged) 10jenkins-bot: J5: Expand action=purge on flow pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167016 (owner: 10EBernhardson) [14:27:04] (03CR) 10Anomie: [C: 032] Fix pagecount output [core] - 10https://gerrit.wikimedia.org/r/167741 (owner: 10RobinHood70) [14:30:38] 3QRpedia: Language is not displayed on language links - 10https://bugzilla.wikimedia.org/71643#c2 (10Andre Klapper) If and when somebody decides to work on this, feel free to set a higher priority. Currently, priority reflects reality until reality changes. :) [14:32:52] (03Merged) 10jenkins-bot: Fix pagecount output [core] - 10https://gerrit.wikimedia.org/r/167741 (owner: 10RobinHood70) [14:39:53] 3MediaWiki / 3Watchlist: Show only the last logentry on watchlist - 10https://bugzilla.wikimedia.org/18097#c1 (10Andre Klapper) (In reply to Umherirrender from comment #0) > Only the last edit is shown on the normal watchlist, but by block are all > events shown, this is not the normal behavior of the normal... [14:40:00] Hey folks, it looks like Special:Nearby is down on enwiki. (Hey folks. Who do you know who I should talk to about issues with https://en.wikipedia.org/wiki/Special:Nearby?) Do you know who I'd talk to about that? [14:40:24] Looks like the query over the API still works. [14:42:52] 3MediaWiki extensions / 3CodeReview: Option to collapse whitespace-only changes in CodeReview diffs - 10https://bugzilla.wikimedia.org/18143 (10Andre Klapper) p:5Low>3Lowest [14:49:20] (03PS1) 10Zfilipin: Prepare repository for running RuboCop after every push to Gerrit [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/167813 (https://bugzilla.wikimedia.org/69245) [14:58:52] 3MediaWiki extensions / 3Collection: Column choice is ignored in book creation tool - 10https://bugzilla.wikimedia.org/72003#c1 (10C. Scott Ananian) Workaround: https://en.wikipedia.org/w/index.php?title=Special:Book&bookcmd=render_article&arttitle=Moon&oldid=630518999&writer=rdf2latex&columns=1 But I need... [15:04:23] 3MediaWiki extensions / 3Collection: Column choice is ignored in book creation tool - 10https://bugzilla.wikimedia.org/72003#c2 (10C. Scott Ananian) Hm, the form on Special:Book has been split into three parts. That's not right. :( [15:15:40] (03PS1) 10Cscott: Fix Book Creator settings (switch to `JSON.stringify`) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/167818 (https://bugzilla.wikimedia.org/72003) [15:17:54] 3MediaWiki extensions / 3Collection: All custom settings are ignored in book creation tool - 10https://bugzilla.wikimedia.org/72003 (10C. Scott Ananian) a:3C. Scott Ananian [15:35:09] 3MediaWiki / 3Database: table_type is removed in MySQL 5.5.3 - 10https://bugzilla.wikimedia.org/71566#c8 (10B. Miller) Created attachment 16828 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16828&action=edit a far better patch based on getServerVersion() something like this should actually work for... [15:37:55] <^d> Gah, who broke pretty buttons? [15:38:36] <^d> My search button was all pretty and blue. [15:39:44] we can’t have nice things [15:40:15] <^d> https://phabricator.wikimedia.org/F360 [15:40:29] (03PS1) 10Zfilipin: Prepare repository for running RuboCop after every push to Gerrit [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/167824 (https://bugzilla.wikimedia.org/69245) [15:41:14] <^d> (this is on enwiki, beta, and vagrant for me) [15:43:03] <^d> MatmaRex: You do skin stuff, maybe you know. What happened to pretty blue buttons? [15:43:08] <^d> https://phabricator.wikimedia.org/F360 [15:45:22] ^d: huh. dunno. [15:46:04] <^d> confirmed in a couple of browsers, 2 computers, vagrant, beta and prod. [15:46:11] (03CR) 10BryanDavis: "> Any plans to show a nice error message explaining people what to do instead of just a class not found error?" [core] - 10https://gerrit.wikimedia.org/r/119941 (owner: 10BryanDavis) [15:48:26] ^d: There were some changes that effected those styles merged 2 weeks ago. legoktm, Reedy and I looked at some login bugs that resulted from that. [15:48:30] * bd808 looks for patches [15:51:33] ^d: The patch I was thinking of is but it doesn't link to the core change that made it necessary. :( [15:51:44] ^d: it's apparently guarded on $wgUseMediaWikiUIEverywhere now [15:51:56] ^d: in Html::buttonAttributes() [15:52:04] <^d> Boooooo [15:52:05] <^d> :( [15:52:20] <^d> So I'm stuck with ugly until that thing is turned on everywhere? [15:52:34] ^d: Special:Search.php still has the necessary classes listed, but they're removed for the button, and not removed for the input [15:53:08] actually, hmm. [15:53:47] actually, yes [15:53:54] I still have pretty buttons on http://en.wikipedia.beta.wmflabs.org/wiki/Special:GlobalRenameRequest [15:54:00] !gerrit a155ac55 [15:54:00] https://gerrit.wikimedia.org/r/#q,a155ac55,n,z [15:54:08] ^d: depends on how much you're willing to cheat [15:54:25] <^d> This is a regression for me. [15:54:28] ^d: you could just pass the classes using the $attrs parameter, rather than $modifiers [15:54:50] so, Html::submitButton(…, array('class' => 'mw-ui-button mw-ui-progressive') ) [15:54:52] or whatever [15:55:00] in SpecialSearch::shortDialog() [15:55:11] <^d> Got it. [15:55:16] <^d> Yeah was just seeing that. [15:55:32] <^d> Can I leave the modifiers there? [15:55:41] <^d> s/s// [15:55:47] probably [15:57:15] hmm [15:57:25] i'm pretty sure the code in buttonAttributes() shouldn't work [15:58:13] (03PS1) 10Chad: Make Special:Search's go button pretty again [core] - 10https://gerrit.wikimedia.org/r/167827 [15:58:15] oh huh, Krinkl.e commented about that on the bug. [15:58:38] (03PS2) 10Chad: Make Special:Search's button pretty again [core] - 10https://gerrit.wikimedia.org/r/167827 [15:58:41] <^d> meh, not go. [16:01:19] (03CR) 10Bartosz Dziewoński: "FIXME" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/163775 (owner: 10Jdlrobson) [16:01:55] ^d: verified works? [16:02:02] ^d: verified, works? * [16:02:10] <^d> works locally. [16:02:32] (03CR) 10Bartosz Dziewoński: [C: 032] "This can and probably should be undone when MediaWiki UI becomes the default behavior." [core] - 10https://gerrit.wikimedia.org/r/167827 (owner: 10Chad) [16:04:53] 3MediaWiki / 3Database: table_type is removed in MySQL 5.5.3 - 10https://bugzilla.wikimedia.org/71566#c9 (10Sam Reed (reedy)) You're creating duplicate branches that are probably un-necessary.... Version parsing can be a PITA... Ideally it just needs something like if version >= 5.5.3 default_storage_engin... [16:07:23] 3OCG / 3General/Unknown: [[Dolphin]] makes new PDF renderer crash. - 10https://bugzilla.wikimedia.org/71896 (10C. Scott Ananian) 5PATC>3RESO/FIX [16:08:28] (03Merged) 10jenkins-bot: Make Special:Search's button pretty again [core] - 10https://gerrit.wikimedia.org/r/167827 (owner: 10Chad) [16:14:24] 3MediaWiki / 3Database: table_type is removed in MySQL 5.5.3 - 10https://bugzilla.wikimedia.org/71566#c10 (10Sam Reed (reedy)) You probably want to be using version_compare() http://php.net/manual/en/function.version-compare.php [16:18:23] (03CR) 10Arlolra: [C: 032] PDF can't handle UTF-8 URLs. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/165983 (https://bugzilla.wikimedia.org/71547) (owner: 10Cscott) [16:19:31] (03CR) 10Arlolra: [C: 032] Update bug URL for the package. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/167701 (owner: 10Cscott) [16:20:08] (03Merged) 10jenkins-bot: PDF can't handle UTF-8 URLs. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/165983 (https://bugzilla.wikimedia.org/71547) (owner: 10Cscott) [16:20:12] (03Merged) 10jenkins-bot: Update bug URL for the package. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/167701 (owner: 10Cscott) [16:24:37] (03CR) 10Cscott: [C: 032] "That will work for now. I really shouldn't be overloading the -l option in tests, and the -l option should really move the tmp directory " [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/166677 (https://bugzilla.wikimedia.org/71341) (owner: 10Arlolra) [16:24:39] (03CR) 10Jforrester: "checkexperimental" [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/167824 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [16:24:51] (03CR) 10Jforrester: "check experimental" [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/167824 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [16:25:10] (03CR) 10Jforrester: "check experimental" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/167813 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [16:25:38] (03CR) 10EBernhardson: Make watchlist topic title link to topic with with unread posts highlighted (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167218 (owner: 10Matthias Mullie) [16:25:59] (03CR) 10Jforrester: "check experimental" [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/167803 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [16:26:13] (03CR) 10Jforrester: [C: 032] "CI change; no code affected yet." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/167801 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [16:27:05] (03Merged) 10jenkins-bot: Fix cleaning up while running the tests [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/166677 (https://bugzilla.wikimedia.org/71341) (owner: 10Arlolra) [16:27:37] 3MediaWiki / 3Database: ApiQueryExtLinksUsage::run query has crazy limit - 10https://bugzilla.wikimedia.org/57176#c12 (10Andre Klapper) (In reply to Brad Jorsch from comment #9) > Sean, how does my proposal in comment 7 sound to you? Looks like we can't make Sean answer here. :( [16:28:20] (03CR) 10Jforrester: [C: 032] "CI change; no code affected yet." [extensions/Math] - 10https://gerrit.wikimedia.org/r/167792 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [16:28:24] 3MediaWiki / 3File management: Images not purged from caching servers after deletion - 10https://bugzilla.wikimedia.org/67559#c12 (10Andre Klapper) So is this still a problem, fourteen weeks later? rillke? bawolff? [16:28:47] (03CR) 10Jforrester: [C: 032] "CI change; no code affected yet." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167777 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [16:29:07] 3Wikimedia / 3General/Unknown: Provide non-manual HTML/CSS minimizing for Www.wikipedia.org_template on Meta - 10https://bugzilla.wikimedia.org/65276#c6 (10Andre Klapper) 5UNCO>3RESO/WOR Unfortunately closing this report as no further information has been provided - see comment 3 to comment 5. Thanks! [16:29:24] (03CR) 10Jforrester: "check experimental" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/167549 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [16:29:33] (03CR) 10Jforrester: [C: 032] "CI change; no code affected yet." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/167774 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [16:29:55] (03CR) 10Jforrester: [C: 032 V: 032] "CI change; no code affected yet." [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/167584 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [16:30:23] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166778 (owner: 10EBernhardson) [16:31:05] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167389 (owner: 10Mvolz) [16:31:11] (03CR) 10Jforrester: [C: 032] "CI change; no code affected yet." [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/167824 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [16:31:52] 3Wikimedia / 3General/Unknown: Wikimedia wikis are displaying the incorrect license information - 10https://bugzilla.wikimedia.org/60023#c7 (10Andre Klapper) Reedy: What's left here? Last call. [16:32:32] (03Merged) 10jenkins-bot: Prepare repository for running RuboCop after every push to Gerrit [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/167801 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [16:32:37] 3MediaWiki extensions / 3AbuseFilter: AbuseFilter: PHP Catchable fatal error: Argument 1 passed to RequestContext::setTitle() must be an instance of Title, null given, called in AbuseFilter.class.php on - 10https://bugzilla.wikimedia.org/55435#c16 (10Andre Klapper) Reedy or anybody: Can this still be seen o... [16:32:51] (03Merged) 10jenkins-bot: Prepare repository for running RuboCop after every push to Gerrit [extensions/Math] - 10https://gerrit.wikimedia.org/r/167792 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [16:33:37] 3MediaWiki extensions / 3OATHAuth: Database tables not created on Postgres: ERROR: relation "oathauth_users" does not exist - 10https://bugzilla.wikimedia.org/65658#c5 (10Andre Klapper) Rhiannon: Did you have a chance to test Tyler's patch? [16:34:38] 3MediaWiki / 3JobQueue: Special:RunJobs recursively calling Special:RunJobs again (?) - 10https://bugzilla.wikimedia.org/66225 (10Andre Klapper) p:5High>3Normal [16:35:39] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/153983 (owner: 10Mitar) [16:36:08] (03CR) 10SG: [C: 04-1] "Needs rebase." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166778 (owner: 10EBernhardson) [16:39:49] (03Merged) 10jenkins-bot: Prepare repository for running RuboCop after every push to Gerrit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167777 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [16:40:01] (03Merged) 10jenkins-bot: Prepare repository for running RuboCop after every push to Gerrit [extensions/Echo] - 10https://gerrit.wikimedia.org/r/167774 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [16:40:05] (03Merged) 10jenkins-bot: Prepare repository for running RuboCop after every push to Gerrit [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/167584 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [16:41:11] (03CR) 10Jforrester: [C: 032] "CI change; no code affected yet." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/167813 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [16:42:16] (03Merged) 10jenkins-bot: Prepare repository for running RuboCop after every push to Gerrit [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/167824 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [16:42:32] (03Merged) 10jenkins-bot: Prepare repository for running RuboCop after every push to Gerrit [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/167813 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [16:43:25] 3Wikimedia / 3Deployment systems: Provide mechanism to add/remove minions from git-deploy - 10https://bugzilla.wikimedia.org/72319 (10C. Scott Ananian) 3NEW p:3Unprio s:3normal a:3None cscott: ocg's git deploy set still has tantalum.eqiad.wmnet in it, which has been deactivated for a while now. cscot... [16:45:23] 3Wikimedia / 3General/Unknown: Provide non-manual HTML/CSS minimizing for Www.wikipedia.org_template on Meta - 10https://bugzilla.wikimedia.org/65276#c7 (10Glaisher) I think ResourceLoader has a module for minifying CSS/JS. [16:45:28] 3MediaWiki extensions / 3LocalisationUpdate: sa translation not showing up in interface - 10https://bugzilla.wikimedia.org/65334#c13 (10Andre Klapper) 5NEW>3UNCO p:5High>3Normal NehalDaveND: So on which pages can the problem still be seen with &uselang=sa appended to the URL? I get a 504 error for... [16:45:40] (03CR) 10Arlolra: [C: 032] Fix Book Creator settings (switch to `JSON.stringify`) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/167818 (https://bugzilla.wikimedia.org/72003) (owner: 10Cscott) [16:45:57] (03Merged) 10jenkins-bot: Fix Book Creator settings (switch to `JSON.stringify`) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/167818 (https://bugzilla.wikimedia.org/72003) (owner: 10Cscott) [16:47:52] 3Wikimedia / 3Media storage: Investigate cause of new files that have empty oi_archive_name - 10https://bugzilla.wikimedia.org/65511#c3 (10Andre Klapper) p:5High>3Normal So did anybody ever really investigate (as this task is still open)? And if not, does it still makes sense to keep this ticket open? b... [16:48:56] (03CR) 10Aaron Schulz: Treat the "temp" repo zone as private (031 comment) [core] - 10https://gerrit.wikimedia.org/r/167296 (owner: 10Aaron Schulz) [16:49:08] (03PS7) 10Siebrand: Migrate merge log to new log system [core] - 10https://gerrit.wikimedia.org/r/151683 (owner: 10Umherirrender) [16:49:20] (03CR) 10Siebrand: [C: 032] Migrate merge log to new log system [core] - 10https://gerrit.wikimedia.org/r/151683 (owner: 10Umherirrender) [16:50:00] (03PS5) 10Siebrand: Use new log system when create log entry for revision delete [core] - 10https://gerrit.wikimedia.org/r/152161 (owner: 10Umherirrender) [16:50:31] (03CR) 10Jforrester: [C: 032] "CI improvements." [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/167803 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [16:51:04] (03CR) 10Siebrand: "@anomie: To merge or not to merge?" [core] - 10https://gerrit.wikimedia.org/r/152161 (owner: 10Umherirrender) [16:52:07] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/163029 (https://bugzilla.wikimedia.org/67621) (owner: 10Jforrester) [16:54:21] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84625 (owner: 10MarkTraceur) [16:54:48] (03CR) 10Siebrand: "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/144928 (owner: 10Withoutaname) [16:55:46] (03Merged) 10jenkins-bot: Migrate merge log to new log system [core] - 10https://gerrit.wikimedia.org/r/151683 (owner: 10Umherirrender) [16:55:48] (03Merged) 10jenkins-bot: Prepare repository for running RuboCop after every push to Gerrit [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/167803 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [16:58:07] 3MediaWiki / 3File management: Images not purged from caching servers after deletion - 10https://bugzilla.wikimedia.org/67559#c13 (10Bawolff (Brian Wolff)) Well the original file from comment 0 is gone from cache (i believe varnish kills things after 30 days no matter what) The issue is not occuring often e... [16:58:37] 3MediaWiki / 3File management: Images not purged from caching servers after deletion - 10https://bugzilla.wikimedia.org/67559 (10Bawolff (Brian Wolff)) p:5High>3Low [16:59:53] (03CR) 10Siebrand: "Robin, Kunal, can we try to breathe new life into this? There's still a ton of dependent code that really needs this to be completed..." [core] - 10https://gerrit.wikimedia.org/r/137033 (owner: 10SPQRobin) [17:03:35] (03CR) 10Arlolra: [C: 032] Add ability to limit the number of simultaneous requests for small wikis. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/167743 (https://bugzilla.wikimedia.org/71895) (owner: 10Cscott) [17:05:40] (03Merged) 10jenkins-bot: Add ability to limit the number of simultaneous requests for small wikis. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/167743 (https://bugzilla.wikimedia.org/71895) (owner: 10Cscott) [17:08:55] (03CR) 10Arlolra: [C: 032] Factor out configuration file parsing and logging setup. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/167702 (owner: 10Cscott) [17:09:53] (03Merged) 10jenkins-bot: Factor out configuration file parsing and logging setup. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/167702 (owner: 10Cscott) [17:12:11] (03CR) 10Aaron Schulz: "Why not just query for upload/overwrite log type/action and store these in log_params?" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/167392 (owner: 10Brian Wolff) [17:20:24] (03PS1) 10Legoktm: Allow passing pages to ResourceLoaderWikiModule via constructor parameters [core] - 10https://gerrit.wikimedia.org/r/167834 [17:20:54] (03CR) 10Aaron Schulz: Treat the "temp" repo zone as private (031 comment) [core] - 10https://gerrit.wikimedia.org/r/167296 (owner: 10Aaron Schulz) [17:21:27] (03PS5) 10Aaron Schulz: Treat the "temp" repo zone as private [core] - 10https://gerrit.wikimedia.org/r/167296 [17:24:41] (03PS2) 10Ori.livneh: Recover better from aggregator server network partitions [services/jobrunner] - 10https://gerrit.wikimedia.org/r/167422 (owner: 10Aaron Schulz) [17:24:46] (03CR) 10Ori.livneh: [C: 032] Recover better from aggregator server network partitions [services/jobrunner] - 10https://gerrit.wikimedia.org/r/167422 (owner: 10Aaron Schulz) [17:24:48] (03Merged) 10jenkins-bot: Recover better from aggregator server network partitions [services/jobrunner] - 10https://gerrit.wikimedia.org/r/167422 (owner: 10Aaron Schulz) [17:25:25] 3OCG / 3PDF renderer: PDF output does't render ProofreadPage's tag - 10https://bugzilla.wikimedia.org/71822 (10C. Scott Ananian) a:3C. Scott Ananian [17:26:39] (03CR) 10jenkins-bot: [V: 04-1] Allow passing pages to ResourceLoaderWikiModule via constructor parameters [core] - 10https://gerrit.wikimedia.org/r/167834 (owner: 10Legoktm) [17:31:53] [13php-cssjanus] 15legoktm opened pull request #5: Require PHP >=5.3.2 (06master...06patch-1) 02https://github.com/cssjanus/php-cssjanus/pull/5 [17:31:58] (03CR) 10Siebrand: "Any updates?" [extensions/WebPlatformAuth] - 10https://gerrit.wikimedia.org/r/136152 (owner: 10Renoirb) [17:34:23] (03Abandoned) 10Ori.livneh: Optimize images [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/150146 (owner: 10Ori.livneh) [17:40:42] (03PS1) 10Siebrand: Update spelling and remove uses of title case [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/167837 [17:40:52] 3MediaWiki extensions / 3EducationProgram: "Remove from course" button no longer works - 10https://bugzilla.wikimedia.org/70748 (10Sage Ross) 5PATC>3RESO/FIX [17:42:23] 3MediaWiki extensions / 3EducationProgram: Rename the namespace of the education program for Czech language Wikipedia - 10https://bugzilla.wikimedia.org/71674 (10Sage Ross) 5PATC>3RESO/FIX [17:45:38] 3MediaWiki extensions / 3Collection: "Preview with PediaPress" defunct - 10https://bugzilla.wikimedia.org/71675#c16 (10C. Scott Ananian) Queued the above patch for deploy to beta (ie, http://en.wikipedia.beta.wmflabs.org/ ) on 22 October: https://wikitech.wikimedia.org/wiki/Deployments#Wednesday.2C.C2.A0Octo... [17:46:30] (03CR) 10Mooeypoo: [C: 032] "Mergine despite Seibrand's comment, as per community request." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/163028 (https://bugzilla.wikimedia.org/63389) (owner: 10Jforrester) [17:47:08] (03Merged) 10jenkins-bot: Re-label "Manage template documentation" to "Manage TemplateData" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/163028 (https://bugzilla.wikimedia.org/63389) (owner: 10Jforrester) [17:47:51] (03CR) 10Cscott: [C: 032] Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/167729 (owner: 10Subramanya Sastry) [17:48:02] (03CR) 10Siebrand: "I call BS on merging this with the current motivation." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/163028 (https://bugzilla.wikimedia.org/63389) (owner: 10Jforrester) [17:49:48] (03CR) 10Siebrand: "How will "product" be involved? And who is "product" anyway? :)" [skins/Vector] - 10https://gerrit.wikimedia.org/r/162610 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [17:50:44] (03CR) 10Mooeypoo: [C: 032] "Yes! Good point, and good fix." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/163029 (https://bugzilla.wikimedia.org/67621) (owner: 10Jforrester) [17:53:50] (03Merged) 10jenkins-bot: Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/167729 (owner: 10Subramanya Sastry) [17:53:53] (03Merged) 10jenkins-bot: Let help link target be locally over-ridden; default to the MW help page [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/163029 (https://bugzilla.wikimedia.org/67621) (owner: 10Jforrester) [17:54:54] (03CR) 10Jforrester: "He means me. :-)" [skins/Vector] - 10https://gerrit.wikimedia.org/r/162610 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [17:54:55] 3MediaWiki / 3File management: Large image handling and dependency on $wgMaxImageArea and $wgMemoryLimit - 10https://bugzilla.wikimedia.org/72324 (10Daren Welsh) 3UNCO p:3Unprio s:3normal a:3None On our wiki, we had a page that displayed several image thumbnails. After some time, one of the source im... [17:55:53] (03CR) 10SG: [C: 04-2] "-2 until this lands: https://gerrit.wikimedia.org/r/#/c/167059/" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166727 (owner: 10SG) [17:58:01] (03CR) 10EBernhardson: [C: 032] "be bold" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167789 (owner: 10Matthias Mullie) [17:58:26] (03CR) 10EBernhardson: [C: 032] Remove unused file includes/OutputPage.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167790 (owner: 10Matthias Mullie) [17:58:53] (03CR) 10jenkins-bot: [V: 04-1] Remove unused method ObjectLocator::visitAll [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167789 (owner: 10Matthias Mullie) [17:58:56] (03CR) 10jenkins-bot: [V: 04-1] Remove unused file includes/OutputPage.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167790 (owner: 10Matthias Mullie) [17:59:10] (03CR) 10EBernhardson: [C: 032] Remove unused Workflow lockState [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167791 (owner: 10Matthias Mullie) [17:59:56] (03Merged) 10jenkins-bot: Remove unused method ObjectLocator::visitAll [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167789 (owner: 10Matthias Mullie) [18:00:11] (03Merged) 10jenkins-bot: Remove unused file includes/OutputPage.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167790 (owner: 10Matthias Mullie) [18:00:21] (03Merged) 10jenkins-bot: Remove unused Workflow lockState [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167791 (owner: 10Matthias Mullie) [18:00:47] (03CR) 10Mattflaschen: "> This is the GROUP collapser stuff, meaning the button that changes all topics at once. There is still individual collapser code." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166727 (owner: 10SG) [18:00:54] 3MediaWiki extensions / 3[other]: GraphViz: Warning: creating default object from empty value - 10https://bugzilla.wikimedia.org/72325 (10Keith Welter) 3NEW p:3Unprio s:3normal a:3None Intention: Display a wiki page containing a tag. Steps to Reproduce: Display a wiki page containing a 3MediaWiki extensions / 3[other]: GraphViz: Warning: creating default object from empty value - 10https://bugzilla.wikimedia.org/72325 (10Keith Welter) 5NEW>3ASSI a:3Keith Welter [18:02:43] (03Abandoned) 10QChris: [WIP] Add schema for edit fact table [data-warehouse] - 10https://gerrit.wikimedia.org/r/167742 (owner: 10Milimetric) [18:07:06] (03PS1) 10Dbrant: Make sure that the Footer appears after all other content. [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/167842 (https://bugzilla.wikimedia.org/66322) [18:11:23] (03PS1) 10Siebrand: Fix grammar [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/167843 [18:12:47] (03PS1) 10Anomie: Add qqq message for I1028f56d [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/167844 [18:14:47] (03PS1) 10Reedy: Fix Book Creator settings (switch to `JSON.stringify`) [extensions/Collection] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167845 (https://bugzilla.wikimedia.org/72003) [18:15:02] (03PS1) 10Siebrand: Fix grammar [extensions/HSTS] - 10https://gerrit.wikimedia.org/r/167846 [18:15:04] (03PS1) 10Reedy: Fix Book Creator settings (switch to `JSON.stringify`) [extensions/Collection] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/167847 (https://bugzilla.wikimedia.org/72003) [18:15:20] (03CR) 10Reedy: [C: 032] Fix Book Creator settings (switch to `JSON.stringify`) [extensions/Collection] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/167847 (https://bugzilla.wikimedia.org/72003) (owner: 10Reedy) [18:15:29] (03Merged) 10jenkins-bot: Fix Book Creator settings (switch to `JSON.stringify`) [extensions/Collection] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/167847 (https://bugzilla.wikimedia.org/72003) (owner: 10Reedy) [18:15:38] (03CR) 10Reedy: [C: 032] Fix Book Creator settings (switch to `JSON.stringify`) [extensions/Collection] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167845 (https://bugzilla.wikimedia.org/72003) (owner: 10Reedy) [18:15:48] (03Merged) 10jenkins-bot: Fix Book Creator settings (switch to `JSON.stringify`) [extensions/Collection] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167845 (https://bugzilla.wikimedia.org/72003) (owner: 10Reedy) [18:17:24] 3MediaWiki extensions / 3SemanticDrilldown: Special:BrowseData should be able to display results in map and list at the same time - 10https://bugzilla.wikimedia.org/29463 (10planetenxin) [18:17:26] 3MediaWiki extensions / 3SemanticDrilldown: [SD] Provide export of filtered results as XLS or CSV - 10https://bugzilla.wikimedia.org/72327 (10planetenxin) 3NEW p:3Unprio s:3normal a:3Yaron Koren As a user I'd like to export my filtered results as XLS/CSV file. SD provides an easy to use interface to... [18:18:08] 3MediaWiki extensions / 3SemanticDrilldown: [SD] Provide export of filtered results as XLS or CSV - 10https://bugzilla.wikimedia.org/72327 (10planetenxin) s:5normal>3enhanc [18:19:26] (03PS1) 10Reedy: Update Collection to 1.25wmf4 HEAD [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167848 [18:20:11] (03PS1) 10Reedy: Update Collection to 1.25wmf3 HEAD [core] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/167849 [18:21:50] (03CR) 10Reedy: [C: 032 V: 032] Update Collection to 1.25wmf3 HEAD [core] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/167849 (owner: 10Reedy) [18:22:08] (03CR) 10Reedy: [C: 032 V: 032] Update Collection to 1.25wmf4 HEAD [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167848 (owner: 10Reedy) [18:27:24] 3MediaWiki / 3File management: thumb.php: If upscale: Return original image instead of error - 10https://bugzilla.wikimedia.org/72328 (10Subfader) s:5normal>3enhanc [18:27:26] 3MediaWiki / 3File management: thumb.php: If upscale: Return original image instead of error - 10https://bugzilla.wikimedia.org/72328 (10Subfader) 3NEW p:3Unprio s:3normal a:3None As title says: If a width largher than the original is called, return original image instead of error. [18:31:50] (03CR) 10CSteipp: "Shouldn't this use the MergeAccountFromTo hook, and account for setups where we're not using centralauth / shared ids?" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/167624 (owner: 10Aaron Schulz) [18:34:27] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (44db8292bf) [core] - 10https://gerrit.wikimedia.org/r/167855 [18:34:36] (03CR) 10Legoktm: "By the time that hook runs, the local accounts would have been detached from their global account, so OAuth wouldn't be able to get the ce" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/167624 (owner: 10Aaron Schulz) [18:35:05] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (44db8292bf) [core] - 10https://gerrit.wikimedia.org/r/167855 (owner: 10Jforrester) [18:35:11] cscott: ----^^ [18:36:25] whoo [18:36:40] (03PS6) 10Aaron Schulz: Treat the "temp" repo zone as private [core] - 10https://gerrit.wikimedia.org/r/167296 [18:39:44] (03CR) 10Jdlrobson: [C: 032] Tweak scoring rules [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/167716 (owner: 10MaxSem) [18:42:24] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (44db8292bf) [core] - 10https://gerrit.wikimedia.org/r/167855 (owner: 10Jforrester) [18:42:26] (03Merged) 10jenkins-bot: Tweak scoring rules [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/167716 (owner: 10MaxSem) [18:43:47] (03PS1) 10Siebrand: Avoid usage of {{SITENAME}} [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/167857 [18:44:33] (03CR) 10Mattflaschen: [C: 032] Expose replies in API response. [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/165689 (owner: 10Werdna) [18:44:49] (03Merged) 10jenkins-bot: Expose replies in API response. [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/165689 (owner: 10Werdna) [18:45:09] (03PS1) 10Legoktm: Move password update logic out of CentralAuthUser::matchHash() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/167859 (https://bugzilla.wikimedia.org/71323) [18:45:13] (03CR) 10Siebrand: [C: 032] Add qqq message for I1028f56d [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/167844 (owner: 10Anomie) [18:45:27] (03PS2) 10Legoktm: Move password update logic out of CentralAuthUser::matchHash() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/167859 (https://bugzilla.wikimedia.org/71323) [18:45:31] (03Merged) 10jenkins-bot: Add qqq message for I1028f56d [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/167844 (owner: 10Anomie) [18:46:06] (03PS7) 10Aaron Schulz: Treat the "temp" repo zone as private [core] - 10https://gerrit.wikimedia.org/r/167296 [18:48:54] 3MediaWiki extensions / 3Collection: "Preview with PediaPress" defunct - 10https://bugzilla.wikimedia.org/71675#c18 (10C. Scott Ananian) This was deployed early, it's live on beta now. [18:49:20] (03CR) 10Hoo man: [C: 032] Revert "Make enhanced recent changes and extended watchlist default" [core] - 10https://gerrit.wikimedia.org/r/166719 (owner: 10Thiemo Mättig (WMDE)) [18:49:50] (03PS1) 10Hoo man: Revert "Make enhanced recent changes and extended watchlist default" [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167860 [18:51:04] (03CR) 10Legoktm: "Rationale?" [core] - 10https://gerrit.wikimedia.org/r/166719 (owner: 10Thiemo Mättig (WMDE)) [18:52:52] 3MediaWiki extensions / 3Collection: All custom settings are ignored in book creation tool - 10https://bugzilla.wikimedia.org/72003#c9 (10C. Scott Ananian) 5PATC>3RESO/FIX This patch was SWATted into production. Looks good. [18:54:30] (03PS6) 10EBernhardson: J -1: Comment moderation updates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166778 [18:54:37] (03CR) 10CSteipp: [C: 032] "Works in testing. Thanks!" [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/167252 (https://bugzilla.wikimedia.org/72204) (owner: 10Legoktm) [18:54:53] (03PS1) 10QChris: DO NOT SUBMIT Testing gerrit-phabricator bot [test/gerrit-ping] - 10https://gerrit.wikimedia.org/r/167863 [18:54:54] 3MediaWiki extensions / 3Collection: "Preview with PediaPress" defunct - 10https://bugzilla.wikimedia.org/71675#c19 (10C. Scott Ananian) 5PATC>3ASSI Initial testing looks good. Christoph, could you give it a try on http://en.wikipedia.beta.wmflabs.org/ before I turn it on in production? [18:55:26] (03Merged) 10jenkins-bot: Revert "Make enhanced recent changes and extended watchlist default" [core] - 10https://gerrit.wikimedia.org/r/166719 (owner: 10Thiemo Mättig (WMDE)) [18:55:30] (03Merged) 10jenkins-bot: Add UserMerge support [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/167252 (https://bugzilla.wikimedia.org/72204) (owner: 10Legoktm) [18:55:38] (03Abandoned) 10QChris: DO NOT SUBMIT Testing gerrit-phabricator bot [test/gerrit-ping] - 10https://gerrit.wikimedia.org/r/167863 (owner: 10QChris) [18:56:56] (03CR) 10Hoo man: "https://people.wikimedia.org/~hoo/Watchlist.png" [core] - 10https://gerrit.wikimedia.org/r/166719 (owner: 10Thiemo Mättig (WMDE)) [18:57:59] (03CR) 10Umherirrender: "That sounds not so easy, because some tests define its own hooks and other are testing hooks. Maybe needs more discussion on a own bug or " [core] - 10https://gerrit.wikimedia.org/r/166751 (https://bugzilla.wikimedia.org/55886) (owner: 10Umherirrender) [18:59:18] (03CR) 10Legoktm: "Hmm, I68ce04cd7db26e81fb0103998365b026e5391275 didn't include extendedwatchlist." [core] - 10https://gerrit.wikimedia.org/r/166719 (owner: 10Thiemo Mättig (WMDE)) [19:00:29] ^d: By "a few dozen times" I meant we could do it in test Phabricator instances a few dozen times to show we'd got it right, not in actual production. [19:00:51] <^d> I thought you meant "import things with abandon" [19:00:56] Yeah, no. [19:00:58] <^d> "who cares if it takes a few dozen times" [19:00:59] <^d> :) [19:01:04] (03CR) 10Aaron Schulz: [C: 032] Move password update logic out of CentralAuthUser::matchHash() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/167859 (https://bugzilla.wikimedia.org/71323) (owner: 10Legoktm) [19:01:07] I just want to make some visible progress. :-) [19:01:18] So… repo names. [19:01:31] <^d> Yeah, names and paths are changable, so not end of world if we have to rename. [19:01:39] But let's try to avoid. :-) [19:01:58] (03Merged) 10jenkins-bot: Move password update logic out of CentralAuthUser::matchHash() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/167859 (https://bugzilla.wikimedia.org/71323) (owner: 10Legoktm) [19:02:15] <^d> But the callsign can't change. [19:02:24] <^d> So when we do one on prod, it needs to be For Realz. [19:02:39] (03PS2) 10EBernhardson: I-1: Finish topic moderation updates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/167738 [19:02:49] In my world, I think `unicodejs` is a good name for a repo; `oojs/core` is silly, so let's call it `oojs`; `oojs/ui` should be `oojsui`; `visualeditor/visualeditor` should be `visualeditor`. Simples. [19:02:58] Oh, yeah, there's "name" and "callsign". Sigh. [19:03:04] <^d> callsign is forever. [19:03:20] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166778 (owner: 10EBernhardson) [19:03:24] 3MediaWiki extensions / 3CentralAuth: CentralAuthUser::matchHash should only match the hash, not also update the password - 10https://bugzilla.wikimedia.org/71323 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3Kunal Mehta (Legoktm) [19:03:40] what's callsign? [19:03:51] legoktm: Prefix for git hashes. [19:04:00] <^d> https://phab-01.wmflabs.org/diffusion/CIRRUS/ [19:04:08] <^d> https://phab-01.wmflabs.org/rCIRRUS3bce01145b86b6a18995ae47be255e6f19b723bf [19:04:19] o.O [19:04:53] <^d> The display name and path you clone from can change. [19:05:06] <^d> But the callsign part for referencing them is forever. [19:05:26] (03CR) 10Siebrand: "Now that product has a name... James, please be involved and state your opinion on this change in page rendering." [skins/Vector] - 10https://gerrit.wikimedia.org/r/162610 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [19:05:28] <^d> For MediaWiki, we'd probably use MW [19:05:35] <^d> Maybe VE for VisualEditor. [19:05:38] ^d: Should we start a Phabricator ticket about names? [19:05:38] <^d> SMW for Semantic... [19:05:40] * James_F nods. [19:05:43] all uppercase? [19:05:45] !hss [19:05:45] ZOMG!! https://upload.wikimedia.org/wikipedia/mediawiki/6/69/Hesaidsemanticga2.jpg [19:06:00] I think callsigns are upper case by design... [19:06:03] at least I haven't seen lowercase ones [19:06:09] To make them stand out from the hash. [19:06:22] <^d> "Callsigns must be UPPERCASE, and can not be edited after the repository is created. Generally, you should choose short callsigns." [19:06:26] It's r{CALLSIGN}{hash} [19:07:02] I think project name should be reflected in repo name and callsign as much as possible. [19:07:08] I feel that choosing abbreviations is just going to cause conflicts [19:07:11] So Flow is the name of the project, the repo, and the call sign. [19:07:27] <^d> I think abbreviations are fine where it's unambiguous [19:07:34] But for very major standard items or those with stupidly long names, use abbreviations. [19:07:34] <^d> (see MW, VE, SMW) [19:07:38] 3Wikimedia / 3Site requests: Enable uploads on Hungarian Wikibooks - 10https://bugzilla.wikimedia.org/72231 (10Nemo) 5PATC>3RESO/FIX [19:07:43] <^d> But for stuff like Flow or Echo, yeah James_F is right [19:07:47] So MW gets MW, but LiquidThreads gets stuck with… yeah. [19:08:34] And UniversalLanguageSelector can go cry. [19:08:43] (03PS1) 10Cscott: Limit execution time to 1 hour (which should be very generous). [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/167870 [19:09:07] SyntaxHighlight_GESHI [19:09:29] It's it GeSHI? [19:09:36] No, GeSHi. [19:09:51] It's the CamelCaseWars all over again. [19:10:02] longest extension name I see is MixedNamespaceSearchSuggestions [19:10:26] There's a limit imposed by the HTTP spec, but we're not going to hit it. [19:11:12] What about where we have clashing short names – Vector the skin and Vector the extension. [19:11:47] <^d> I wonder if we could make a big table on mw.org of all extensions in gerrit [19:11:48] you almost have to decide on a char for extensions in general VCE (extensions always end in E) or at least I have seen that done sanely [19:12:01] no perfect way to be sure [19:12:20] extensions end in EX [19:12:21] idk [19:12:43] ^d: I can make it if you point me to a page with the current list. [19:12:52] (03PS6) 10Umherirrender: Migrate import log to new log system [core] - 10https://gerrit.wikimedia.org/r/151701 [19:13:18] chasemp: or VECTOREXTENSION and VECTOR (primary gets the shorter form)? [19:13:32] <^d> James_F: https://gerrit.wikimedia.org/r/#/admin/projects/?filter=mediawiki%252Fextensions%252F [19:13:43] the full vectorextension is going to be a not fun call sign [19:14:01] it's representative or symbolic even [19:14:12] chasemp: Sure, but in that case it's a dead repo that's no longer updated (MW 1.22 and before only). [19:14:21] in that case fair enough :) [19:14:30] chasemp: But there'll be others, probably. [19:14:31] but prefer standard all across [19:14:35] * James_F nods. [19:14:48] Maybe VECTOROMGDONTUSEDEADDEADDEAD [19:14:56] (03PS7) 10Umherirrender: Migrate import log to new log system [core] - 10https://gerrit.wikimedia.org/r/151701 [19:15:18] Hmm. I crashed OpenOffice. [19:15:19] Yay. [19:15:34] (03CR) 10Umherirrender: "Patch Set 6: Rebased" [core] - 10https://gerrit.wikimedia.org/r/151701 (owner: 10Umherirrender) [19:15:45] (03CR) 10Arlolra: [C: 032] Limit execution time to 1 hour (which should be very generous). [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/167870 (owner: 10Cscott) [19:15:46] syntaxhighlight has the stupidest name [19:15:53] (03CR) 10Cscott: [C: 04-1] "looking good." (034 comments) [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/167404 (owner: 10Arlolra) [19:15:53] <^d> I think forcing extensions to have EX(T(ENSION)?)? is kind of lame. [19:16:02] <^d> First come, first served with a sane name. [19:16:06] (03PS3) 10Aaron Schulz: API: Warn when neither rawcontinue nor continue are given to action=query [core] - 10https://gerrit.wikimedia.org/r/160222 (owner: 10Anomie) [19:16:06] geshi stands for "GEneric Syntax HIghlight", i believe. [19:16:24] but that's still super stupid [19:16:25] (03CR) 10Cscott: [V: 032] Limit execution time to 1 hour (which should be very generous). [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/167870 (owner: 10Cscott) [19:16:33] everyone calls it syntaxhighlight anyway [19:17:33] it's not a name persay if you do it correctly it's a taxonomy instead of /extension/foo it's FX or FOOEX [19:20:20] (03PS1) 10Legoktm: GlobalRenameQueue: send emails in content language [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/167874 [19:21:52] (03CR) 10Frédéric Wang: "We should probably test it on math-preview first." [extensions/Math] - 10https://gerrit.wikimedia.org/r/167696 (owner: 10Frédéric Wang) [19:22:10] I have seen the SPECIALSNOFLAKE naming scheme go awry quickly for callsigns better to say [unique_letters|team|type] or [chars|type] so it's representative and not literal [19:23:33] (03PS1) 10Cscott: Updating to latest masters [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/167879 [19:25:01] <^d> chasemp: But how will people know their stuff is special otherwise? :) [19:26:50] (03CR) 10Cscott: [C: 032 V: 032] Updating to latest masters [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/167879 (owner: 10Cscott) [19:27:47] (03CR) 10Siebrand: [C: 031] "L10n reviewed. Leaving the logging code changes for Nikerabbit to approve." [core] - 10https://gerrit.wikimedia.org/r/151701 (owner: 10Umherirrender) [19:28:35] (03PS6) 10Umherirrender: Migrate block log to new log system [core] - 10https://gerrit.wikimedia.org/r/152003 [19:28:55] (03CR) 10Gilles: [C: 032] Try to stop unit tests from acting up by using smaller files [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/164374 (owner: 10Brian Wolff) [19:29:05] (03CR) 10BryanDavis: "We should really be using inLanguage( $user->getOption( 'language' ) ) I think." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/167874 (owner: 10Legoktm) [19:29:27] (03Merged) 10jenkins-bot: Try to stop unit tests from acting up by using smaller files [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/164374 (owner: 10Brian Wolff) [19:30:04] (03PS1) 10Cscott: Merge branch 'master' into wmf-deploy [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/167882 [19:30:24] (03CR) 10Umherirrender: "Patch Set 6: Rebased" [core] - 10https://gerrit.wikimedia.org/r/152003 (owner: 10Umherirrender) [19:31:13] (03PS1) 10MarkTraceur: Fix trivial error in Firefogg upload handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/167883 [19:31:57] (03CR) 10Cscott: [C: 032 V: 032] Merge branch 'master' into wmf-deploy [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/167882 (owner: 10Cscott) [19:32:53] 3MediaWiki extensions / 3Collection: "Preview with PediaPress" defunct - 10https://bugzilla.wikimedia.org/71675#c21 (10Christoph Kepper) Thank you very much Scott. I checked the upload and the preview. Looks good to me :-) [19:33:07] 3Wikimedia / 3General/Unknown: UploadWizard Freezes at Uploading Stage due to Firefogg (Firefox extension) - 10https://bugzilla.wikimedia.org/69374#c14 (10Mark Holmquist) *** Bug 71409 has been marked as a duplicate of this bug. *** [19:33:10] (03PS2) 10MarkTraceur: Fix trivial error in Firefogg upload handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/167883 (https://bugzilla.wikimedia.org/69374) [19:33:41] (03CR) 10Renoirb: "Its running already for a while. Repo isn’t pushed here yet, will do soon. See https://github.com/webplatform/mediawiki-fxa-sso" [extensions/WebPlatformAuth] - 10https://gerrit.wikimedia.org/r/136152 (owner: 10Renoirb) [19:35:54] 3MediaWiki extensions / 3Collection: "Preview with PediaPress" defunct - 10https://bugzilla.wikimedia.org/71675#c22 (10C. Scott Ananian) Ok. I've scheduled the patch to turn this on in production for the same Wednesday morning window. [19:37:09] (03CR) 10Gilles: [C: 04-1] Fix trivial error in Firefogg upload handling (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/167883 (https://bugzilla.wikimedia.org/69374) (owner: 10MarkTraceur) [19:38:55] 3MediaWiki extensions / 3AbuseFilter: "added_lines" is not in "new_wikitext" anymore and causes false positives - 10https://bugzilla.wikimedia.org/72329 (10Helder) 3NEW p:3Unprio s:3normal a:3None As of today, our https://pt.wikipedia.org/wiki/Special:AbuseFilter/52?uselang=en is broken. This appears... [19:39:29] (03PS3) 10MarkTraceur: Fix trivial error in Firefogg upload handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/167883 (https://bugzilla.wikimedia.org/69374) [19:39:42] (03PS1) 10Aaron Schulz: Tweaked chooseBlock() comments [core] - 10https://gerrit.wikimedia.org/r/167887 [19:39:58] ^d: And now I've crashed Atom too. :-) [19:40:09] (03CR) 10Aaron Schulz: [C: 04-1] Handle merging blocks a bit better (032 comments) [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/160872 (https://bugzilla.wikimedia.org/39470) (owner: 10Legoktm) [19:40:13] <^d> huh? [19:40:37] ^d: Apparently a regex on 1000+ lines of wikitext to create a table isn't quick. Oh well. [19:40:44] One moment. [19:41:24] 3Wikimedia / 3Deployment systems: Provide mechanism to add/remove minions from git-deploy - 10https://bugzilla.wikimedia.org/72319#c1 (10Antoine "hashar" Musso (WMF)) tantalum.eqiad.wmnet has been decommissioned beginning of August 2014 by https://gerrit.wikimedia.org/r/#/c/152739/ ( RT: 7947 ). Seems Trebu... [19:41:38] 3MediaWiki extensions / 3AbuseFilter: "added_lines" is not in "new_wikitext" anymore and causes false positives - 10https://bugzilla.wikimedia.org/72329 (10Helder) s:5normal>3major [19:44:07] (03PS4) 10Umherirrender: Migrate protect log to new log system [core] - 10https://gerrit.wikimedia.org/r/152156 [19:44:19] ^d: https://www.mediawiki.org/wiki/User:Jdforrester_(WMF)/Possible_Phabricator_repo_names [19:44:53] 3Wikimedia / 3Site requests: Create "templateeditor" user group on fawiki - 10https://bugzilla.wikimedia.org/72146 (10Calak) 5PATC>3RESO/FIX [19:45:50] (03CR) 10jenkins-bot: [V: 04-1] Migrate protect log to new log system [core] - 10https://gerrit.wikimedia.org/r/152156 (owner: 10Umherirrender) [19:45:57] (03CR) 10CSteipp: "Makes sense. Is there another patch to handle the case for wikis without CentralAuth, but have UserMerge?" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/167624 (owner: 10Aaron Schulz) [19:46:35] (03PS1) 10MaxSem: Fix WikiGrok [vagrant] - 10https://gerrit.wikimedia.org/r/167890 [19:47:09] 3Wikimedia / 3Site requests: redirecting domain tartupeedia.ee to Wikipedia page - 10https://bugzilla.wikimedia.org/44893 (10Raul Kern) 5REOP>3RESO/FIX [19:48:07] (03PS5) 10Umherirrender: Migrate protect log to new log system [core] - 10https://gerrit.wikimedia.org/r/152156 [19:48:11] (03CR) 10Robmoen: [C: 032] Fix WikiGrok [vagrant] - 10https://gerrit.wikimedia.org/r/167890 (owner: 10MaxSem) [19:48:13] <^d> James_F: We really should just give them out randomly ;-) [19:48:19] <^d> Start with A, B, C... [19:48:24] <^d> Or that ^ [19:48:28] <^d> Which isn't random. [19:48:33] * James_F grins. [19:48:42] (03CR) 10Umherirrender: "Patch Set 4: Rebased" [core] - 10https://gerrit.wikimedia.org/r/152156 (owner: 10Umherirrender) [19:48:46] (03Merged) 10jenkins-bot: Fix WikiGrok [vagrant] - 10https://gerrit.wikimedia.org/r/167890 (owner: 10MaxSem) [19:51:06] (03PS1) 10Siebrand: Move $preloadedMessages to LocalisationCache.php [core] - 10https://gerrit.wikimedia.org/r/167891 [19:51:40] (03Abandoned) 10Hoo man: Revert "Make enhanced recent changes and extended watchlist default" [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167860 (owner: 10Hoo man) [19:52:04] (03CR) 10CSteipp: Update CentralAuthAntiSpoof in all code paths that create new accounts (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/167248 (owner: 10Legoktm) [19:52:28] <^d> enhanced rc as default. [19:52:31] <^d> lost that battle :( [19:52:50] ^d: Reverted on master for now :P [19:53:16] (03CR) 10Siebrand: [C: 031] "L10n reviewed. Leaving the logging code changes for Nikerabbit to approve." [core] - 10https://gerrit.wikimedia.org/r/152156 (owner: 10Umherirrender) [19:53:52] 3MediaWiki / 3Database: table_type is removed in MySQL 5.5.3 - 10https://bugzilla.wikimedia.org/71566#c11 (10B. Miller) Created attachment 16832 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16832&action=edit a still better patch based on getServerVersion() and version_compare() thanks for the feed... [19:53:53] hoo: Why? [19:54:06] What? O_o [19:54:09] James_F: Because I thought it was causing a bug :P [19:54:16] But it actually was just a configuration oversight [19:54:34] hoo: So you're going to self-revert, right? [19:54:45] it wasn't my revert [19:54:53] The only revert mentioned in https://gerrit.wikimedia.org/r/#/c/166719/ was abandopned [19:54:56] but anyone can feel free to revert and I'll +2 [19:55:02] but not going to revert and +2 as well [19:55:03] (03PS6) 10Umherirrender: Use new log system when create log entry for revision delete [core] - 10https://gerrit.wikimedia.org/r/152161 [19:55:05] * hoo can't do both [19:55:07] hoo: But it was your merged. :-) [19:55:26] (03CR) 10Umherirrender: "Patch Set 6: Rebased" [core] - 10https://gerrit.wikimedia.org/r/152161 (owner: 10Umherirrender) [19:55:28] (03PS1) 10Jforrester: Revert "Revert "Make enhanced recent changes and extended watchlist default"" [core] - 10https://gerrit.wikimedia.org/r/167894 [19:55:36] hoo: There. [19:55:39] 3MediaWiki / 3Watchlist: Watchlist option to list only last change has been re-setted after MediaWiki update on Commons - 10https://bugzilla.wikimedia.org/72330 (10Rainer Rillke @commons.wikimedia) 3NEW p:3Unprio s:3normal a:3None Previously, there was only one entry per page in my watchlist, even if... [19:55:44] (03PS1) 10Nemo bis: Revert "Revert "Make enhanced recent changes and extended watchlist default"" [core] - 10https://gerrit.wikimedia.org/r/167896 [19:56:18] (03CR) 10Hoo man: [C: 032] "Sorry, I merged the revert in a misunderstanding of the issues happening here." [core] - 10https://gerrit.wikimedia.org/r/167894 (owner: 10Jforrester) [19:56:23] James_F: done [19:56:33] hoo: Thanks. :-) [19:56:33] sorry, Nemo_bis ... to slow :S [19:56:41] (03PS2) 10Nemo bis: Revert "Revert "Make enhanced recent changes and extended watchlist default"" [core] - 10https://gerrit.wikimedia.org/r/167896 [19:56:53] 3MediaWiki / 3Watchlist: Watchlist option to list only last change has been re-setted after MediaWiki update on Commons - 10https://bugzilla.wikimedia.org/72330#c1 (10Rainer Rillke @commons.wikimedia) Reported on https://commons.wikimedia.org/wiki/Commons:Village_pump#Watchlist_broken.3F [[:c:Special:Prefer... [19:57:06] (03Abandoned) 10Nemo bis: Revert "Revert "Make enhanced recent changes and extended watchlist default"" [core] - 10https://gerrit.wikimedia.org/r/167896 (owner: 10Nemo bis) [19:57:22] (03PS1) 10Umherirrender: Move MergeLogFormatter to 1.25 [core] - 10https://gerrit.wikimedia.org/r/167898 [19:57:53] 3MediaWiki extensions / 3AbuseFilter: "added_lines" is not in "new_wikitext" anymore and causes false positives - 10https://bugzilla.wikimedia.org/72329#c1 (10Helder) (In reply to Helder from comment #0) > As of today, our https://pt.wikipedia.org/wiki/Especial:Filtro_de_abusos/history/52/item/1554 (permanen... [19:58:02] (03CR) 10Umherirrender: "Fixed version of MergeLogFormatter with Id18ba7d925062d795bd129af255cc902e48d30f6" [core] - 10https://gerrit.wikimedia.org/r/151683 (owner: 10Umherirrender) [19:58:03] James_F: Would like to push hte configuration change, but am not bold enough(tm) [19:58:07] Want to weigh in? [19:58:31] (03CR) 10Nemo bis: "Followup to config change: I02b798e6f035f85d7e6a7409b4f039f5403474e8" [core] - 10https://gerrit.wikimedia.org/r/124302 (https://bugzilla.wikimedia.org/35785) (owner: 10Nemo bis) [19:58:40] hoo: Should we just do it at 16:00? [19:58:51] is that the late one? [19:59:35] I would be ok with that... but am not going to be around (hopefully... if I am I'll be dead tired tomorrow) [19:59:41] not sure about aude [19:59:47] Yeah, I'll make sure it happens, don't worry. [20:00:09] Awesome! [20:00:30] (03PS1) 1020after4: Don't strip projects from newly created tasks [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/167899 [20:00:40] (03CR) 10Hashar: "The Jenkins browsertests jobs have been switched already to run bundle at the root of the repository i.e. https://integration.wikimedia.o" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/167549 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [20:00:58] (03PS2) 1020after4: Don't strip projects from newly created tasks [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/167899 [20:01:53] ^d: manybubbles do you guys have an irc channel for search ? :D [20:02:21] ^d: manybubbles: anyway the browser test jobs have been updated today and expect the Gemfile to be a the root of the repository. For CirrusSearch https://gerrit.wikimedia.org/r/#/c/167549/ would fix that [20:02:27] (03CR) 10Gilles: [C: 032] Fix trivial error in Firefogg upload handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/167883 (https://bugzilla.wikimedia.org/69374) (owner: 10MarkTraceur) [20:02:45] (03CR) 10Legoktm: "That won't always work properly because users might not have set their language on meta." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/167874 (owner: 10Legoktm) [20:03:11] (03Merged) 10jenkins-bot: Revert "Revert "Make enhanced recent changes and extended watchlist default"" [core] - 10https://gerrit.wikimedia.org/r/167894 (owner: 10Jforrester) [20:03:13] (03Merged) 10jenkins-bot: Fix trivial error in Firefogg upload handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/167883 (https://bugzilla.wikimedia.org/69374) (owner: 10MarkTraceur) [20:03:15] <^d> hashar: No specific channel, although we both hang out in #mediawiki-core too, in addition to here and everywhere else :) [20:03:31] (03CR) 10Chad: [C: 032] Prepare repository for running RuboCop after every push to Gerrit [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/167549 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [20:04:12] (03Merged) 10jenkins-bot: Prepare repository for running RuboCop after every push to Gerrit [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/167549 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [20:04:33] ^d: oh I wasn't aware of #mediawiki-core is that your team channel ? [20:04:44] ^d: Umm. [20:04:52] ^d: That patch wasn't ready to merge yet. [20:05:00] yeah it is fine [20:05:08] just rubocop being screwed up right ? [20:05:14] (03CR) 10Jforrester: "This patch fails the test (see output of check experimental)." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/167549 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [20:05:16] or did you have something else in mind? [20:05:42] hashar: Well, when rubocop goes voting they'll be sad. :-) [20:06:01] James_F: yeah we talked about it with Zeljkof today [20:06:06] * James_F nods. [20:06:18] I guess I should have -1'ed. [20:06:20] Oh well. [20:06:28] James_F: we will make sure to have all repos to pass rubocop AND have some announcement sent before making the rubocop jobs voting [20:06:34] * James_F nods. [20:06:55] (03CR) 10Jforrester: [C: 04-1] "Doesn't yet pass." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/167589 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [20:07:12] (03CR) 10Hashar: "We will make sure rubocop pass on the repository before making the related job voting :-]" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/167549 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [20:07:14] (03PS3) 10Rush: Don't strip projects from newly created tasks [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/167899 (owner: 1020after4) [20:07:23] (03CR) 10Rush: [C: 032] "cool" [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/167899 (owner: 1020after4) [20:07:30] (03CR) 10Rush: [V: 032] "cool" [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/167899 (owner: 1020after4) [20:07:44] James_F: we most probably need to announce it to the devs anyway :° [20:08:04] hashar: Bah, details. :-) [20:08:10] (03CR) 10Aaron Schulz: [C: 032] Add UserMerge support [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156233 (https://bugzilla.wikimedia.org/67766) (owner: 10Legoktm) [20:08:16] hashar: Everyone likes a bit of excitement when things just randomly stop working! [20:08:33] James_F: yeah probably :D [20:08:46] (03Merged) 10jenkins-bot: Add UserMerge support [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156233 (https://bugzilla.wikimedia.org/67766) (owner: 10Legoktm) [20:09:23] 3MediaWiki / 3File management: thumb.php: If upscale: Return original image instead of error - 10https://bugzilla.wikimedia.org/72328#c1 (10Tisza Gergő) Why should this happen? [20:09:52] 3Wikimedia / 3Site requests: redirecting domain tartupeedia.ee to Wikipedia page - 10https://bugzilla.wikimedia.org/44893#c23 (10jeremyb) 5RESO/FIX>3REOP Raul, why did you close the bug? [20:11:10] (03CR) 10Rush: "looks good but merging it seems not to work?" [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/167899 (owner: 1020after4) [20:11:20] (03CR) 10Jforrester: "Product is involved, but thank you for your concern. :-)" [skins/Vector] - 10https://gerrit.wikimedia.org/r/162610 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [20:11:23] 3MediaWiki / 3File management: Allow uploading derivative works and collages (using Upload Wizard?) - 10https://bugzilla.wikimedia.org/67283#c10 (10El Grafo) (In reply to Nicolas Raoul from comment #9) > Created attachment 16770 [details] > Proposed design for integration into the Upload Wizard I'd make tha... [20:11:33] (03Abandoned) 10Rush: Phab: Drop BZ Severity and Whiteboard entries in initial task description [phabricator/tools] - 10https://gerrit.wikimedia.org/r/167548 (owner: 10Aklapper) [20:11:57] (03CR) 10CSteipp: Add maintenance script to send messages (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/144256 (https://bugzilla.wikimedia.org/72123) (owner: 10Legoktm) [20:12:42] (03CR) 10Legoktm: Add maintenance script to send messages (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/144256 (https://bugzilla.wikimedia.org/72123) (owner: 10Legoktm) [20:13:40] (03PS3) 10Legoktm: Update CentralAuthAntiSpoof in all code paths that create new accounts [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/167248 [20:13:42] (03CR) 10Aaron Schulz: Allow extensions to specify a different database object to use (031 comment) [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/165121 (owner: 10Legoktm) [20:14:19] (03CR) 10Legoktm: Update CentralAuthAntiSpoof in all code paths that create new accounts (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/167248 (owner: 10Legoktm) [20:15:52] (03CR) 10Raimond Spekking: [C: 032] Fix grammar [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/167843 (owner: 10Siebrand) [20:16:26] (03CR) 10Raimond Spekking: [C: 032] Fix grammar [extensions/HSTS] - 10https://gerrit.wikimedia.org/r/167846 (owner: 10Siebrand) [20:16:57] (03CR) 10Rush: Make the mediawiki userpage field searchable. (031 comment) [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/165985 (owner: 1020after4) [20:17:01] (03CR) 10Raimond Spekking: [C: 032] Avoid usage of {{SITENAME}} [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/167857 (owner: 10Siebrand) [20:17:44] (03CR) 10Raimond Spekking: [C: 032] Update spelling and remove uses of title case [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/167837 (owner: 10Siebrand) [20:18:46] (03CR) 10jenkins-bot: [V: 04-1] Fix grammar [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/167843 (owner: 10Siebrand) [20:18:53] (03CR) 10Rush: "https://phabricator.wikimedia.org/T783" [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/165985 (owner: 1020after4) [20:19:05] (03Merged) 10jenkins-bot: Fix grammar [extensions/HSTS] - 10https://gerrit.wikimedia.org/r/167846 (owner: 10Siebrand) [20:20:38] (03Merged) 10jenkins-bot: Avoid usage of {{SITENAME}} [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/167857 (owner: 10Siebrand) [20:21:27] (03Merged) 10jenkins-bot: Update spelling and remove uses of title case [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/167837 (owner: 10Siebrand) [20:22:32] (03CR) 10Rush: [C: 04-1] Create a custom security policy for each "secure" task so that the task author can view the task without being a member of a private project (031 comment) [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/163753 (owner: 1020after4) [20:22:57] (03CR) 10Rush: "can't merge because of parent commit. maybe split this off so we can get it through?" [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/167899 (owner: 1020after4) [20:24:05] (03CR) 10Rush: [C: 04-1] "this is set to merge into master, I thought we were going to branch off mwoauth?" [phabricator/phabricator] - 10https://gerrit.wikimedia.org/r/166259 (owner: 1020after4) [20:26:08] 3Wikimedia / 3General/Unknown: UploadWizard Freezes at Uploading Stage due to Firefogg (Firefox extension) - 10https://bugzilla.wikimedia.org/69374#c17 (10Gilles Dubuc) 5PATC>3RESO/FIX Fix confirmed on beta commons [20:27:38] 3MediaWiki / 3File management: Large image handling and dependency on $wgMaxImageArea and $wgMemoryLimit - 10https://bugzilla.wikimedia.org/72324#c1 (10Tisza Gergő) Maybe you have the VipsScaler extension enabled? [20:28:09] 3MediaWiki extensions / 3AntiSpoof: Add UserMerge support to AntiSpoof - 10https://bugzilla.wikimedia.org/72204 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3Kunal Mehta (Legoktm) [20:28:33] (03CR) 10Siebrand: [C: 032] Move MergeLogFormatter to 1.25 [core] - 10https://gerrit.wikimedia.org/r/167898 (owner: 10Umherirrender) [20:30:24] 3MediaWiki / 3Database: table_type is removed in MySQL 5.5.3 - 10https://bugzilla.wikimedia.org/71566#c12 (10Sam Reed (reedy)) You can simplify the regex using something along the lines of \d+\.\d+\.\d+ There might be some letter suffixes, but I suspect these don't make much of a difference but the logi... [20:33:44] (03CR) 10Siebrand: [C: 032] Tweaked chooseBlock() comments [core] - 10https://gerrit.wikimedia.org/r/167887 (owner: 10Aaron Schulz) [20:34:07] (03CR) 10Siebrand: [C: 031] "L10n reviewed. Leaving the logging code changes for Nikerabbit to approve." [core] - 10https://gerrit.wikimedia.org/r/152003 (owner: 10Umherirrender) [20:34:12] (03PS3) 1020after4: Allow task author to view task regardless of project membership [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/163753 [20:34:25] (03PS4) 1020after4: Allow task author to view task regardless of project membership [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/163753 [20:34:29] (03Merged) 10jenkins-bot: Move MergeLogFormatter to 1.25 [core] - 10https://gerrit.wikimedia.org/r/167898 (owner: 10Umherirrender) [20:36:46] (03PS1) 10BryanDavis: sul: Add message overrides for CentralAuth messages [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/167907 [20:38:06] (03CR) 10Hashar: [C: 032] "lanthanum had a full disk. re gating" [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/167843 (owner: 10Siebrand) [20:38:18] (03PS1) 10Aaron Schulz: Made wfWaitForSlaves() support waiting on all clusters as needed [core] - 10https://gerrit.wikimedia.org/r/167908 [20:39:31] (03Merged) 10jenkins-bot: Tweaked chooseBlock() comments [core] - 10https://gerrit.wikimedia.org/r/167887 (owner: 10Aaron Schulz) [20:39:33] (03Merged) 10jenkins-bot: Fix grammar [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/167843 (owner: 10Siebrand) [20:40:23] 3MediaWiki / 3File management: Large image handling and dependency on $wgMaxImageArea and $wgMemoryLimit - 10https://bugzilla.wikimedia.org/72324#c2 (10Daren Welsh) We do not have that extension installed. [20:40:26] (03CR) 10Rush: "getProjectPHID('ops')); => getProjectPHID('operations'));" [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/163753 (owner: 1020after4) [20:40:37] 3MediaWiki / 3Watchlist: Watchlist option to list only last change has been re-setted after MediaWiki update on Commons - 10https://bugzilla.wikimedia.org/72330#c4 (10Marius Hoch) 5PATC>3RESO/FIX Change approved and deployed. [20:40:56] (03PS5) 1020after4: Create a custom security policy for each "secure" task so that the task author can view the task without being a member of a private project. [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/163753 [20:41:03] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/167907 (owner: 10BryanDavis) [20:41:32] (03PS1) 10Aaron Schulz: Wait for all slaves affected by any writes done in MergeUser batches [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/167911 [20:41:46] (03CR) 10jenkins-bot: [V: 04-1] Wait for all slaves affected by any writes done in MergeUser batches [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/167911 (owner: 10Aaron Schulz) [20:41:57] (03CR) 10Aaron Schulz: "Requires https://gerrit.wikimedia.org/r/#/c/167908/1 to work" [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/167911 (owner: 10Aaron Schulz) [20:41:59] ori: I have a question about deferreds. Are you around? [20:43:11] (03Abandoned) 10Siebrand: My first commit! [extensions/examples] - 10https://gerrit.wikimedia.org/r/162886 (owner: 10Andriana) [20:44:52] 3OCG / 3PDF renderer: Links with non-ASCII characters do not work - 10https://bugzilla.wikimedia.org/71547#c7 (10C. Scott Ananian) 5PATC>3RESO/FIX Fix merged and deployed. [20:45:39] (03PS4) 1020after4: Don't strip projects from newly created tasks [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/167899 [20:49:39] (03PS6) 10Rush: Create a custom security policy for each "secure" task so that the task author can view the task without being a member of a private project. [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/163753 (owner: 1020after4) [20:49:58] (03CR) 10Rush: [C: 032 V: 032] Create a custom security policy for each "secure" task so that the task author can view the task without being a member of a private project [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/163753 (owner: 1020after4) [20:50:12] (03PS5) 10Rush: Don't strip projects from newly created tasks [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/167899 (owner: 1020after4) [20:50:22] (03CR) 10Rush: [C: 032 V: 032] Don't strip projects from newly created tasks [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/167899 (owner: 1020after4) [20:54:55] (03PS1) 10Legoktm: Allow subclasses of BatchAntiSpoof to override the wfWaitForSlaves() call [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/167912 [20:55:28] (03PS1) 10Legoktm: BatchCAAntiSpoof: Use CentralAuthUser::waitForSlaves() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/167913 [20:59:51] (03CR) 10Mattflaschen: Implement OOJS on Flow JS classes (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165756 (owner: 10SG) [21:02:14] (03PS2) 10BryanDavis: sul: Add message overrides for CentralAuth messages [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/167907 [21:03:37] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/167907 (owner: 10BryanDavis) [21:03:50] (03Abandoned) 10CSteipp: Always create global account on account creation [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/142464 (https://bugzilla.wikimedia.org/67175) (owner: 10CSteipp) [21:03:57] (03CR) 10BryanDavis: "Cherry-picked to http://sulfinalization.wmflabs.org/ for approval by Product." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/167907 (owner: 10BryanDavis) [21:04:28] kaldari|2: I hope I... resolved... your question. (⌐■_■) [21:04:42] ori: yes, thanks!!!!1 [21:07:06] (03CR) 10Siebrand: "i18n/L10n reviewed." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/102076 (https://bugzilla.wikimedia.org/57727) (owner: 10TTO) [21:07:35] (03CR) 10Siebrand: [C: 032 V: 032] Convert i18n to JSON [extensions/GoToShell] - 10https://gerrit.wikimedia.org/r/161194 (owner: 10Raimond Spekking) [21:08:42] (03CR) 10Siebrand: [C: 032] "Nice." [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/159090 (owner: 10Raimond Spekking) [21:08:49] (03CR) 10Siebrand: [V: 032] Change i18n to JSON [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/159090 (owner: 10Raimond Spekking) [21:10:18] (03CR) 10Siebrand: [C: 032] Consistency tweaks (031 comment) [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/160948 (owner: 10Raimond Spekking) [21:10:36] (03Merged) 10jenkins-bot: Consistency tweaks [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/160948 (owner: 10Raimond Spekking) [21:10:41] (03CR) 10Siebrand: "recheck" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160965 (https://bugzilla.wikimedia.org/70911) (owner: 1001tonythomas) [21:11:46] (03PS55) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [21:12:38] (03PS1) 10EBernhardson: Expose replies in API response. [extensions/LiquidThreads] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167950 [21:12:49] (03CR) 10EBernhardson: [C: 032] Expose replies in API response. [extensions/LiquidThreads] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167950 (owner: 10EBernhardson) [21:13:00] (03Merged) 10jenkins-bot: Expose replies in API response. [extensions/LiquidThreads] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167950 (owner: 10EBernhardson) [21:13:27] (03CR) 10CSteipp: [C: 032] "Works in test for me." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/167248 (owner: 10Legoktm) [21:14:15] (03Merged) 10jenkins-bot: Update CentralAuthAntiSpoof in all code paths that create new accounts [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/167248 (owner: 10Legoktm) [21:14:33] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/SimpleChanges] - 10https://gerrit.wikimedia.org/r/160914 (owner: 10tosfos) [21:15:42] (03CR) 10Siebrand: "Needs to be updated with outcome of discussion." [core] - 10https://gerrit.wikimedia.org/r/137968 (owner: 10UltrasonicNXT) [21:16:33] (03PS1) 10EBernhardson: Bump LQT in 1.25wmf4 [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167951 [21:17:29] (03PS1) 10Aaron Schulz: Use LLEN instead of lSize (a binding alias) [services/jobrunner] - 10https://gerrit.wikimedia.org/r/167952 [21:17:36] (03CR) 10EBernhardson: [C: 032] Bump LQT in 1.25wmf4 [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167951 (owner: 10EBernhardson) [21:18:04] (03CR) 10Aaron Schulz: [C: 032] Use LLEN instead of lSize (a binding alias) [services/jobrunner] - 10https://gerrit.wikimedia.org/r/167952 (owner: 10Aaron Schulz) [21:18:10] (03Merged) 10jenkins-bot: Use LLEN instead of lSize (a binding alias) [services/jobrunner] - 10https://gerrit.wikimedia.org/r/167952 (owner: 10Aaron Schulz) [21:20:51] (03PS1) 10Siebrand: Have Jenkins use the standard configuration for JSLint [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/167954 [21:21:41] (03CR) 10Hashar: "jshint would fails when it runs on the Jenkins slave gallium. That is because it inherits the .jshintrc from integration/docroot.git . T" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160965 (https://bugzilla.wikimedia.org/70911) (owner: 1001tonythomas) [21:23:40] (03PS2) 10Hashar: Have Jenkins use the standard configuration for JSLint [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/167954 (https://bugzilla.wikimedia.org/63959) (owner: 10Siebrand) [21:23:58] (03CR) 10Hashar: [C: 032] Have Jenkins use the standard configuration for JSLint [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/167954 (https://bugzilla.wikimedia.org/63959) (owner: 10Siebrand) [21:24:18] (03Merged) 10jenkins-bot: Bump LQT in 1.25wmf4 [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167951 (owner: 10EBernhardson) [21:24:20] (03Merged) 10jenkins-bot: Have Jenkins use the standard configuration for JSLint [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/167954 (https://bugzilla.wikimedia.org/63959) (owner: 10Siebrand) [21:24:31] (03PS2) 10Hashar: Added GENDER support for message ep-disenroll-success [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160965 (https://bugzilla.wikimedia.org/70911) (owner: 1001tonythomas) [21:25:52] (03CR) 10Hashar: "A dummy .jshintrc is provided with https://gerrit.wikimedia.org/r/#/c/167954/ by Siebrand based on a discussion we had on IRC. So at lea" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160965 (https://bugzilla.wikimedia.org/70911) (owner: 1001tonythomas) [21:26:56] (03CR) 10Siebrand: [C: 032] Added GENDER support for message ep-disenroll-success [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160965 (https://bugzilla.wikimedia.org/70911) (owner: 1001tonythomas) [21:27:08] (03Merged) 10jenkins-bot: Added GENDER support for message ep-disenroll-success [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160965 (https://bugzilla.wikimedia.org/70911) (owner: 1001tonythomas) [21:27:32] 3MediaWiki / 3File management: Large image handling and dependency on $wgMaxImageArea and $wgMemoryLimit - 10https://bugzilla.wikimedia.org/72324#c3 (10Tisza Gergő) Can you share the test file? [21:27:34] 3OCG / 3General/Unknown: Allow to configure HTML fetcher max number of parallel requests - 10https://bugzilla.wikimedia.org/71895#c3 (10C. Scott Ananian) 5PATC>3RESO/FIX Kelson: --parallel-request-limit=1 should do what you want now. [21:27:44] (03PS3) 10BryanDavis: sul: Add message overrides for CentralAuth messages [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/167907 [21:28:37] 3OCG / 3General/Unknown: /tmp/mw-ocg-latexer* directories left on Jenkins workers - 10https://bugzilla.wikimedia.org/71341#c6 (10C. Scott Ananian) 5PATC>3RESO/FIX Should be fixed now. [21:29:00] (03PS1) 10Legoktm: Update CentralAuthAntiSpoof in all code paths that create new accounts [extensions/CentralAuth] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167956 [21:29:07] 3MediaWiki extensions / 3Translate: translatewiki.net so locked down I can't communicate with anyone there - 10https://bugzilla.wikimedia.org/70612 (10Nemo) 5PATC>3NEW [21:31:39] 3Wikimedia / 3SSL related: Disable SSL 3.0 on Wikimedia sites to mitigate POODLE attack (CVE-2014-3566) - 10https://bugzilla.wikimedia.org/72072#c2 (10chmarkine) Has SSL 3.0 been disabled on misc-web-lb.eqiad.wikimedia.org? https://www.ssllabs.com/ssltest/analyze.html?d=gdash.wikimedia.org https://www.sslla... [21:33:55] (03CR) 10Legoktm: [C: 031] Made wfWaitForSlaves() support waiting on all clusters as needed (031 comment) [core] - 10https://gerrit.wikimedia.org/r/167908 (owner: 10Aaron Schulz) [21:36:07] (03PS2) 10Aaron Schulz: Made wfWaitForSlaves() support waiting on all clusters as needed [core] - 10https://gerrit.wikimedia.org/r/167908 [21:36:49] (03CR) 10Legoktm: [C: 032] Made wfWaitForSlaves() support waiting on all clusters as needed [core] - 10https://gerrit.wikimedia.org/r/167908 (owner: 10Aaron Schulz) [21:41:50] (03PS1) 10Aaron Schulz: Made JobRunner wait for all applicable slaves, not just the main cluster [core] - 10https://gerrit.wikimedia.org/r/167959 [21:42:24] 3Wikimedia / 3SSL related: Disable SSL 3.0 on Wikimedia sites to mitigate POODLE attack (CVE-2014-3566) - 10https://bugzilla.wikimedia.org/72072#c3 (10chmarkine) ... and the Tool Labs? https://www.ssllabs.com/ssltest/analyze.html?d=tools.wmflabs.org [21:42:57] (03Merged) 10jenkins-bot: Made wfWaitForSlaves() support waiting on all clusters as needed [core] - 10https://gerrit.wikimedia.org/r/167908 (owner: 10Aaron Schulz) [21:43:59] (03PS2) 10Aaron Schulz: Wait for all slaves affected by any writes done in MergeUser batches [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/167911 [21:44:40] 3MediaWiki / 3JavaScript: mw.Uri: Default URI not updated after pushState - 10https://bugzilla.wikimedia.org/72334 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3None >>> new mw.Uri().toString() "http://127.0.0.1/wiki/Main_Page" >>> window.history.pushState({}, document.title, 'http://127.0.0.1/foo') u... [21:45:27] (03CR) 10Mattflaschen: [C: 04-1] "Looks good. A couple things following-up from previous review, and one new question re the tests. Mainly this needs testing. I did a li" (038 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165756 (owner: 10SG) [21:46:05] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/167907 (owner: 10BryanDavis) [21:46:07] (03CR) 10Legoktm: [C: 032] Wait for all slaves affected by any writes done in MergeUser batches [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/167911 (owner: 10Aaron Schulz) [21:46:22] (03Merged) 10jenkins-bot: Wait for all slaves affected by any writes done in MergeUser batches [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/167911 (owner: 10Aaron Schulz) [21:50:27] (03CR) 10Legoktm: [C: 032] "It's not actually HTML since the emails are being sent as plain text, but it makes it so that they actually work in nearly all clients." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/167907 (owner: 10BryanDavis) [21:50:42] (03Merged) 10jenkins-bot: sul: Add message overrides for CentralAuth messages [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/167907 (owner: 10BryanDavis) [21:54:02] (03CR) 10Siebrand: Convert i18n to json (031 comment) [skins/Splash] - 10https://gerrit.wikimedia.org/r/162519 (owner: 10Isarra) [21:58:12] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/158842 (owner: 10Hiong3-eng5) [22:02:30] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/156989 (owner: 10tosfos) [22:04:11] (03CR) 10Siebrand: [C: 032] Add localization capability to quotation marks [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/157702 (owner: 10Ebe123) [22:06:28] (03Merged) 10jenkins-bot: Add localization capability to quotation marks [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/157702 (owner: 10Ebe123) [22:07:11] (03PS3) 10Renoirb: *Major refactor*, now supporting OAuth2 RS [extensions/WebPlatformAuth] - 10https://gerrit.wikimedia.org/r/136152 [22:07:41] (03CR) 10Siebrand: [C: 04-1] "Needs to be updated, as it currently doesn't merge properly. Entry for RELEASE-NOTES-1.24 should be moved to RELEASE-NOTES-1.25 and refere" [core] - 10https://gerrit.wikimedia.org/r/150171 (owner: 10Withoutaname) [22:07:56] (03PS1) 10Aaron Schulz: Expose job metadata in showJobs and the jobs log [core] - 10https://gerrit.wikimedia.org/r/167963 [22:10:56] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." [extensions/WebPlatformAuth] - 10https://gerrit.wikimedia.org/r/136152 (owner: 10Renoirb) [22:11:02] (03CR) 10Renoirb: "Updated just for you Siebrand!" [extensions/WebPlatformAuth] - 10https://gerrit.wikimedia.org/r/136152 (owner: 10Renoirb) [22:11:53] (03CR) 10Siebrand: "Thanks :)." [extensions/WebPlatformAuth] - 10https://gerrit.wikimedia.org/r/136152 (owner: 10Renoirb) [22:13:59] (03CR) 10jenkins-bot: [V: 04-1] Expose job metadata in showJobs and the jobs log [core] - 10https://gerrit.wikimedia.org/r/167963 (owner: 10Aaron Schulz) [22:14:19] (03CR) 10Renoirb: "I’d like some on making the extension use Composer correctly." [extensions/WebPlatformAuth] - 10https://gerrit.wikimedia.org/r/136152 (owner: 10Renoirb) [22:16:53] (03CR) 10Siebrand: "Recommended reading is https://www.mediawiki.org/wiki/Composer. If you try after reading, and really cannot get it done, best ask this on " [extensions/WebPlatformAuth] - 10https://gerrit.wikimedia.org/r/136152 (owner: 10Renoirb) [22:18:08] (03PS2) 10Aaron Schulz: Expose job metadata in showJobs and the jobs log [core] - 10https://gerrit.wikimedia.org/r/167963 [22:25:29] (03CR) 10Bartosz Dziewoński: Implement page status indicators (031 comment) [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [22:36:53] 3MediaWiki / 3Database: ApiQueryExtLinksUsage::run query has crazy limit - 10https://bugzilla.wikimedia.org/57176#c13 (10Greg Grossmeier) (suggestion: add it (the question for Sean) to the Scrum of Scrums) [22:41:00] (03PS17) 10EBernhardson: Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [22:41:57] (03CR) 10EBernhardson: [C: 032] "code is isolated so safe to merge, followups will make better" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [22:42:44] (03CR) 10jenkins-bot: [V: 04-1] Add conversion infrastructure with LQT API source. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna) [22:44:37] (03CR) 10Aaron Schulz: [C: 04-1] Add maintenance script to send messages (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/144256 (https://bugzilla.wikimedia.org/72123) (owner: 10Legoktm) [22:49:00] (03CR) 10Siebrand: Implement page status indicators (031 comment) [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [22:52:24] (03PS1) 10Bartosz Dziewoński: CoreParserFunctions, CoreTagHooks: Use escaped() rather than text() for output [core] - 10https://gerrit.wikimedia.org/r/167975 [22:52:46] (03CR) 10Bartosz Dziewoński: Implement page status indicators (031 comment) [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [22:53:03] (03CR) 10Bartosz Dziewoński: "DID NOT TEST." [core] - 10https://gerrit.wikimedia.org/r/167975 (owner: 10Bartosz Dziewoński) [22:55:29] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Actually should probably be ->parse()." [core] - 10https://gerrit.wikimedia.org/r/167975 (owner: 10Bartosz Dziewoński) [22:56:28] (03PS1) 10MaxSem: Bump MobileFrontend [core] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/167977 [22:57:52] (03PS1) 10MaxSem: Bump MobileFrontend [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167978 [23:01:09] (03CR) 10MaxSem: [C: 032] Update CentralAuthAntiSpoof in all code paths that create new accounts [extensions/CentralAuth] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167956 (owner: 10Legoktm) [23:01:56] James_F, https://gerrit.wikimedia.org/r/#/c/167884/ is already done, right? [23:01:59] (03Merged) 10jenkins-bot: Update CentralAuthAntiSpoof in all code paths that create new accounts [extensions/CentralAuth] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167956 (owner: 10Legoktm) [23:02:13] MaxSem: Apparently. Success! [23:04:02] (03PS1) 10MaxSem: Bump CentralAuth [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167981 [23:05:11] (03CR) 10MaxSem: [C: 032 V: 032] Bump MobileFrontend [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167978 (owner: 10MaxSem) [23:05:25] (03CR) 10MaxSem: [C: 032 V: 032] Bump CentralAuth [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167981 (owner: 10MaxSem) [23:05:41] (03CR) 10MaxSem: [C: 032 V: 032] Bump MobileFrontend [core] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/167977 (owner: 10MaxSem) [23:14:00] Krinkle|detached: ping on response to https://bugzilla.wikimedia.org/show_bug.cgi?id=71621#c7 ? I'd like to move that patch forward (or explicitly decide we don't plan on supporting it) to make it in this months maint. release [23:15:24] legoktm: (FYI, Krinkle|detached moved today so he may not be around much) [23:16:18] ooh, exciting. [23:16:26] (03PS1) 10MaxSem: Fix exception while bubbling titles [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167982 (https://bugzilla.wikimedia.org/72260) [23:16:40] (03CR) 10MaxSem: [C: 032] Fix exception while bubbling titles [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167982 (https://bugzilla.wikimedia.org/72260) (owner: 10MaxSem) [23:17:38] (03CR) 10MaxSem: "Cherrypicking for SWAT, the issue causes a noticeable amount of fatals in production." [core] - 10https://gerrit.wikimedia.org/r/167603 (https://bugzilla.wikimedia.org/72260) (owner: 10Manybubbles) [23:18:20] RoanKattouw: well maybe you have an opinion on that bug? ;) [23:19:13] I agree with you [23:19:46] (03CR) 10MaxSem: [V: 032] Fix exception while bubbling titles [core] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167982 (https://bugzilla.wikimedia.org/72260) (owner: 10MaxSem) [23:19:53] 3Wikimedia / 3General/Unknown: Varnish: Mobile site redirect interferes with OAuth authorization process - 10https://bugzilla.wikimedia.org/72186#c7 (10Chris Steipp) (In reply to Brad Jorsch from comment #5) > (In reply to Bawolff (Brian Wolff) from comment #4) > > Verified, when editing from a user-agent th... [23:20:28] RoanKattouw: say that on the bug then? :) [23:30:38] 3MediaWiki / 3Database: table_type is removed in MySQL 5.5.3 - 10https://bugzilla.wikimedia.org/71566#c13 (10B. Miller) Created attachment 16836 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16836&action=edit an even better patch based on getServerVersion() and version_compare() with simplified rege... [23:34:38] 3Wikimedia / 3General/Unknown: Varnish: Mobile site redirect interferes with OAuth authorization process - 10https://bugzilla.wikimedia.org/72186#c8 (10Brad Jorsch) I thought we had trouble with OAuth getting confused by internal rewriting somewhere that changed /wiki/Special:OAuth to /w/index.php?title=Spec... [23:38:38] 3MediaWiki / 3Database: table_type is removed in MySQL 5.5.3 - 10https://bugzilla.wikimedia.org/71566#c14 (10B. Miller) Created attachment 16837 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16837&action=edit a still better patch, now with additional correct line endings! [23:41:00] (03CR) 10tosfos: [C: 032] allow ads in content area [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/156729 (owner: 10tosfos) [23:43:35] (03Merged) 10jenkins-bot: allow ads in content area [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/156729 (owner: 10tosfos) [23:45:53] (03CR) 10tosfos: [C: 032] Don't drop zones table before writing, improve success message [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/156989 (owner: 10tosfos) [23:48:09] (03Merged) 10jenkins-bot: Don't drop zones table before writing, improve success message [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/156989 (owner: 10tosfos) [23:54:25] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (531d497d3b) [core] - 10https://gerrit.wikimedia.org/r/167989 [23:56:17] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (531d497d3b) [core] - 10https://gerrit.wikimedia.org/r/167989 (owner: 10Jforrester)