[00:06:59] (03CR) 10Reedy: "Possibly caused bug 71988" [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/158809 (owner: 10MaxSem) [00:10:30] 3MediaWiki extensions / 3Gadgets: Beta: Gadgets tab is missing - 10https://bugzilla.wikimedia.org/71988 (10Sam Reed (reedy)) [00:10:50] (03CR) 10Physikerwelt: [C: 032] "I tested that for quite a while... with IE FF an chrome. I could not find any problems. So I think we can merge this as well." [extensions/Math] - 10https://gerrit.wikimedia.org/r/166179 (https://bugzilla.wikimedia.org/71929) (owner: 10Frédéric Wang) [00:11:00] 3MediaWiki extensions / 3Gadgets: Gadgets tab is missing when $wgGadgetsCaching = false - 10https://bugzilla.wikimedia.org/71988 (10Sam Reed (reedy)) [00:11:43] (03Merged) 10jenkins-bot: SVG images should not be loaded when MathML is used [extensions/Math] - 10https://gerrit.wikimedia.org/r/166179 (https://bugzilla.wikimedia.org/71929) (owner: 10Frédéric Wang) [00:17:56] mmm Gadgets. [00:19:09] whatever happened to gadgets 2.0? i lost track some while ago [00:19:47] xD [00:19:53] There's a branch! [00:19:55] There's a branch [00:20:00] with some open changesets [00:20:06] that I need to review [00:20:12] and one that legoktm needs to fix [00:20:15] https://github.com/wikimedia/mediawiki-extensions-Gadgets/tree/RL2 [00:20:29] legoktm: btw, the more i think about wiki pages being able to pull in rl modules, the more i think we should do it [00:21:13] ohhh, I see it [00:21:15] Still sounds horrible to me [00:21:19] good night [00:21:40] jackmcbarn: should do Gadgets 2.0? :) [00:21:40] for example, i currently have a proposal underway to enable https://en.wikipedia.org/wiki/User:Jackmcbarn/switcher sitewide. when we do it, though, i'll have to unconditionally load it, since it won't be able to tell if a page needs it until it's already loaded [00:22:05] legoktm: i asked you before if gadgets 2.0 could do that, and you said no [00:22:41] oh [00:23:08] gj legoktm [00:24:25] for a gadget like that one, how do you think i should avoid loading it everywhere, since the list of pages that it's needed on is so dynamic? [00:24:42] (03PS1) 10Legoktm: Fix $wgGadgetsCaching = false; [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/166362 (https://bugzilla.wikimedia.org/71988) [00:25:30] jackmcbarn: have a small RL gadget that runs on every page, which in turn loads a bigger module if necessary [00:25:35] That [00:25:36] (03CR) 10Reedy: [C: 04-1] Fix $wgGadgetsCaching = false; (031 comment) [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/166362 (https://bugzilla.wikimedia.org/71988) (owner: 10Legoktm) [00:25:53] or think again whether your problem should actually be fixed on-wiki [00:26:24] legoktm: that makes the client have to do the check per-view, rather than the server doing it per-parse [00:26:35] let me see what your script even does [00:26:36] (03PS2) 10Legoktm: Fix $wgGadgetsCaching = false; [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/166362 (https://bugzilla.wikimedia.org/71988) [00:26:43] Reedy: fixed [00:27:09] (03CR) 10Reedy: [C: 032] Fix $wgGadgetsCaching = false; [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/166362 (https://bugzilla.wikimedia.org/71988) (owner: 10Legoktm) [00:27:16] (03Merged) 10jenkins-bot: Fix $wgGadgetsCaching = false; [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/166362 (https://bugzilla.wikimedia.org/71988) (owner: 10Legoktm) [00:27:22] that was quick [00:29:42] internet here is spotty [00:31:08] (03PS1) 10Legoktm: Add $wgGadgetsEnableLegacyGadgets to allow for disabling of legacy gadgets [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/166363 [00:31:41] ^ had that one sitting around locally for a while [00:35:05] Krenair: https://gerrit.wikimedia.org/r/160432 just adadds some tests [00:35:24] just adds some tests* [00:36:30] ok [00:36:32] 3MediaWiki extensions / 3Gadgets: Gadgets tab is missing when $wgGadgetsCaching = false - 10https://bugzilla.wikimedia.org/71988#c4 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3Kunal Mehta (Legoktm) http://de.wikipedia.beta.wmflabs.org/wiki/Spezial:Helferlein?uselang=en shows gadgets again! [00:36:37] * Krenair adds this to his list [00:40:45] 3Wikimedia / 3General/Unknown: Add users_to_rename table to centralauth database - 10https://bugzilla.wikimedia.org/71924#c1 (10Sean Pringle) 5ASSI>3RESO/FIX Done. [00:46:27] springle: thanks! [01:03:40] (03CR) 10Alex Monk: [C: 032] Use WikiMap directly [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/166355 (owner: 10Hoo man) [01:03:47] (03Merged) 10jenkins-bot: Use WikiMap directly [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/166355 (owner: 10Hoo man) [01:10:15] boo-yah! mobile sidebar proto-gadget now has a toggle button. https://en.wikipedia.org/w/index.php?title=User:Brion_VIBBER/common.js&action=edit <- for the incantation [01:32:29] brion: Nice. :-) [01:32:50] now anyone can see the horror that is too-wide infoboxes on mobile ;) [01:33:21] Nice. [01:33:39] Since it has JS+CSS now, it may make sense to gadgetify soon. [01:33:55] yeah [01:35:07] i think we should turn down the font size on infoboxes, that would probably help :P [01:35:40] Is it set? I thought it mostly just inherited from or whatever. [01:35:54] it looks like the default body size to me yeah [01:35:59] an override might help tho :P [01:40:04] legoktm: You around? [01:40:54] legoktm: In terms of prioritization, I'd put global gadgets above global user pages. [01:44:06] +1 (and it should be simple to create a global gadget to load global user pages from Meta until the feature is available) [01:44:18] a gadget gadget? [01:44:20] I LOVE IT [01:44:27] go-go gadget loader! [02:41:27] (03CR) 10Yaron Koren: "That's a lot of wording! I don't know - it doesn't seem to me like having invalid approvals (in the sense of invalid, and thus ignored) ne" [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [03:04:52] [13cssjanus.github.io] 15Krinkle created 06master (+1 new commit): 02http://git.io/XWal0A [03:04:52] 13cssjanus.github.io/06master 146740a39 15Timo Tijhof: initial commit [03:17:26] [13node-cssjanus] 15Krinkle pushed 2 new commits to 06master: 02https://github.com/cssjanus/node-cssjanus/compare/d1e0d8df0717...7d0c1901068c [03:17:26] 13node-cssjanus/06master 1484d4b23 15Timo Tijhof: Move code from lib/ to src/... [03:17:26] 13node-cssjanus/06master 147d0c190 15Timo Tijhof: build: Add .npmignore file... [03:18:09] cssjanus/node-cssjanus#56 (master - 7d0c190 : Timo Tijhof): The build passed. [03:18:09] Change view : https://github.com/cssjanus/node-cssjanus/compare/d1e0d8df0717...7d0c1901068c [03:18:09] Build details : http://travis-ci.org/cssjanus/node-cssjanus/builds/37789610 [03:23:56] [13cssjanus.github.io] 15Krinkle 04force-pushed 06master from 146740a39 to 146dadbd3: 02http://git.io/AUYvkw [03:23:56] 13cssjanus.github.io/06master 146dadbd3 15Timo Tijhof: initial commit [03:29:25] [13cssjanus.github.io] 15Krinkle 04force-pushed 06master from 146dadbd3 to 14fbbd942: 02http://git.io/AUYvkw [03:29:25] 13cssjanus.github.io/06master 14fbbd942 15Timo Tijhof: initial commit [03:30:47] [13cssjanus] 15Krinkle 04force-pushed 06master from 147d0c190 to 14cf97883: 02https://github.com/cssjanus/cssjanus/commits/master [03:30:47] 13cssjanus/06master 14cf97883 15Timo Tijhof: build: Add .npmignore file... [03:31:36] cssjanus/cssjanus#56 (master - 7d0c190 : Timo Tijhof): The build has errored. [03:31:36] Change view : https://github.com/cssjanus/node-cssjanus/compare/d1e0d8df0717...7d0c1901068c [03:31:36] Build details : http://travis-ci.org/cssjanus/cssjanus/builds/37789610 [03:40:30] (03CR) 10Jamesmontalvo3: "Perhaps overly verbose...it was a stream of consciousness first hack. Feel free to wordsmith. Warning message !== error, though. Alerting " [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [03:40:36] Krinkle! [03:40:47] I'd also take Krenair. [03:41:01] https://en.wikipedia.org/wiki/MediaWiki:Gadget-teahouse/content.js is broken and I'm not sure how. [03:41:11] But I hear 'ok' is deprecated? [03:41:43] yes, for a while now [03:42:12] Carmela: https://www.mail-archive.com/wikitech-l%40lists.wikimedia.org/msg78108.html [03:42:29] Right, but deprecated or disabled? [03:42:43] They've been emitting console warnings for the past few months [03:42:55] For all those Teahouse users reading the JavaScript error console. [03:43:15] That mailing list post is frustrating because it doesn't provide any reference for "Promise interface". [03:43:39] So it looks like https://gerrit.wikimedia.org/r/#/c/118733/ did it... [03:44:42] Carmela: deprecated since 1.23 [03:44:44] removed in 1.25 [03:44:47] So I see. [03:44:52] Krinkle: Is there documentation about Promises? [03:45:22] It's the same as $.ajax() and any other jQuery.Deferred method that does something asynchronous [03:45:32] use .done(), .then() or .fail() [03:45:42] usually you want .done() [03:45:50] something().done( function (data) { .. } ) [03:46:25] Carmela: Also, documentation: https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.Api [03:47:05] Thx. [03:47:09] or http://api.jquery.com/deferred.done/ if you're curious [03:47:12] https://en.wikipedia.org/wiki/Wikipedia_talk:Teahouse#Bottom_posting [03:47:36] Krinkle: that page doesn't actually talk about the interface [03:47:57] I ran into the same problem; in the end I just looked at existing code and mimicked it [03:48:09] There's a certain abstraction level of what someone knows. You can't explain the whole world recursively on the documentation page about something specific. Promises are a common concept. [03:48:33] It's okay not to know what it is, but the interface won't be explained on the mw.api pages [03:49:12] api.get( { }, { 'ok' : function(result) ... [03:49:33] That would become api.get( {} ).done( function(result) ... ? [03:49:37] Yes [03:49:46] Cute. [03:50:18] Usually we indent the .done() handler so that its more readable. [03:50:40] So the edit to that teahouse script will probably only have to be the first and last line of the callback [03:52:36] Krinkle: I disagree; I think it's generally helpful to spell out interfaces (e.g. for .fail(), the callback function can take the error code as a parameter; that's not obvious.) [03:53:03] Otherwise your only resort is pretty much to look at how it's been done before, and then you run into code using deprecated interfaces, etc. [03:53:34] I don't know if whatever mw uses for the js docs can facilitate that easily, but if it's doable it should probably be done. [03:53:35] It's a tough balance to try and create, but it's important that scripts are maintained by someone who's "in the loop". Be that by being subscribed to one of mediawiki-announce/mediawiki-l/wikitech-l, or by reading the weekly deployment updates (e.g. https://www.mediawiki.org/wiki/MediaWiki_1.25/wmf2 ). Or by paying attention to deprecation warnings in the browser console while using the wiki. [03:54:02] Or what? [03:54:05] They just break? :-) [03:54:20] wctaiwan: https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.Api-method-ajax [03:54:24] You're dealing with a very weird subset of volunteers. [03:54:24] Done: API response data and the jqXHR object. Fail: Error code [03:54:47] Carmela: Well, you can't hold upstream compatible to upgrade all code every created by anyone. [03:54:59] I didn't create that gadget and surely can't be responsible for maintaining it. [03:55:18] Nobody's asking you to be responsible for that gadget. [03:55:26] But removing the interface and marking it deprecated are distinct. [03:55:28] In any healthy software project there is iteration, in order to move forward (especially to resolve issues the community is interested in) things have to iterate. [03:55:34] And now I'm wondering what the impact was across Wikimedia wikis. [03:55:42] Historically our frontend is a fucking mess, chaos, undocumneted, untested and nothign ever changes [03:55:44] We can remove interfaces that are unused. [03:55:56] But if interfaces are actively or wildly used... [03:56:05] then 7 years went by and a million gadgets were created, most of which are copies of copies, unmaintained, of which most editors in the history don't even know the first thing about javascript. [03:56:13] Sure. [03:56:37] Now we're starting to iterate. I made sure the first cycle was very slow as to give it a chance to spread far far into the community. [03:56:45] And now those same users are expected to fix up these broken scripts. ;-) [03:56:58] And then eventually we break it, and things unused will be trashed, and the rest will be discovered soon after it breaks and fixed accordingly [03:57:16] at which point you decide to either kill the broken script, or look for a volunteer to maintain it forward. [03:57:38] Krinkle: okay, that helps. I'd prefer it to be a bit more verbose, but that's definitely better than what I thought was the case (i.e. no docs). [03:57:38] Carmela: There's extensive tracking of deprecated usage. [03:57:54] I made sure usage dropped 99.9% before removing them [03:57:58] Krinkle: And "ok" fell below some threshold? [03:58:07] this meant they were removed in 1.25wmf2 instead of the last 1.24 cycle [03:58:10] Yes [03:58:11] Maybe the Teahouse script is just an anomaly then. [03:58:21] I don't think "anyone" uses that. [03:58:32] Where anyone is a significant number of users globally. [03:58:45] Based on data, not personal interpretation. [03:58:52] I know what the teahouse is and it is significantly used. [03:59:12] but it didn't come in the number. Maybe it's only triggered in an edge case, not on every single action taken on the teahouse [03:59:23] Or the tracking is wonky. [03:59:26] Carmela: numbers: http://codepen.io/Krinkle/full/zyodJ/ [03:59:52] Pure usage statistics can be an approximation of importance. [04:00:27] http://graphite.wikimedia.org/render/?title=mediawiki.api+summary&width=900&height=400&hideLegend=false&from=-6months&target=aliasByNode(smartSummarize(mw.js.deprecate.api_async.rate%2C%227d%22%2C%22avg%22)%2C-2)&target=aliasByNode(smartSummarize(mw.js.deprecate.api_cbParam.rate%2C%227d%22%2C%22avg%22)%2C-2) [04:00:40] Carmela: I know, but this isn't the process [04:00:44] this is me being nice [04:00:57] the process is: Deprecation, announcements, removal. The rest is not upstraem's responsibility. [04:01:11] Giving a developer 3 months time seems fair. The rest is irrelevant. [04:01:17] MediaWiki isn't really upstream for Wikipedia. [04:01:19] That's a bit bullshit. [04:01:27] I'm not saying you're responsible for fixing this gadget. [04:01:35] No, users creating random scripts that do stuff without our knowledge is very much downstream. [04:01:39] But let's please not pretend that Wikipedia is some random user of the software. [04:01:50] Creating random scripts? [04:01:55] You mean making a gadget? [04:02:00] And yes, if a highly visible feature was broken, 1) that should not be maintained by users exclusively, 2) it will be fixed. [04:02:03] Using the documented interfaces? [04:02:14] .. by staff if need be. [04:02:16] Naturally. [04:02:26] That's your solution? Staff? [04:02:32] Interesting. [04:02:36] Carmela: Isn't that what you meant by not downstream? [04:02:52] if is' not upstream, then that means staff would get involved? [04:02:58] I'm not sure the use of downstream/upstream is helpful. [04:02:59] downstream* [04:03:04] Anyway, it doesn't matter. [04:03:05] Nobody talks about MediaWiki or Wikipedia using those terms. [04:03:22] Don't forget point 0, which is, most of these scripts are *not* using supported/documented interfaces to begin with [04:03:49] I've nearly finished copying the damn thing to test.wikipedia.org. [04:04:02] they just started hacking away in the console based on what they saw. They often don't (initially) work in any other skin or language. And in terms of interfaces, it's just whatever samples of other poorly written scripts did. [04:04:16] I used to be like that too. And see others doing that every single day. [04:04:19] Gadgets-definition, but Gadget-foo (no S) for everything else... [04:04:30] Right. [04:04:34] That's your userbase. :-) [04:05:36] Personally, I'd describe Wikipedia as being maintained by the foundation, not a user. [04:06:01] But the users of Wikipedia are users, that's downstream (or whatever you call it). They have been given a very very powerful toolset with no restrictions. [04:06:10] Well, I'm not sure equating Wikipedia with a Teahouse gadget is really accurate. [04:06:21] With that comes the responsibility to stay in the loop and maintain it. [04:06:40] (03PS22) 10Pastakhov: refactor and extend usability (v 3.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/163544 [04:06:44] We just as easily could not have user scripts, it would've been an idea in 2007 and they said no instead of yes and nobody would think much of it. [04:06:53] (03CR) 10jenkins-bot: [V: 04-1] refactor and extend usability (v 3.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/163544 (owner: 10Pastakhov) [04:07:09] "User scripts" is a bit vague there. [04:07:21] Gadgets are generally considered much better than the alternative: user JS subpages. [04:07:37] And all types of user scripts have built Wikipedia. [04:07:42] We probably shouldn't forget that. [04:07:43] A gadget is just a user script audited by a user-elected administrator to make sharing easier. [04:07:55] Yes. [04:07:56] i’m just excited that there are auto-generated JS docs! [04:08:03] brion: :) [04:08:45] I'm confident that such a thing (gadgets, user scripts) would not have been implementd nowadays if it were proposed today. It's nuts. And also not necessary because our code review and deployment system are much more frequent and open (you don't need commit access to submit code, having commit access helps you in no way whatsoever to get code deployed because everyone goes through review) [04:08:45] (03PS23) 10Pastakhov: refactor and extend usability (v 3.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/163544 [04:08:51] > Wikipedia Teahouse - Wikimedia Deutschland e.V., Hallo Welt! - Medienwerkstatt GmbH, Robert Vogel [04:09:08] wtf [04:09:14] https://test.wikipedia.org/w/index.php?title=MediaWiki:Gadget-teahouse&action=history [04:09:18] The same reason LocalisationUpdate should be killed imho. Its no longer useful. [04:09:46] I wonder who Osnard is. [04:10:01] 3MediaWiki extensions / 3Math: SVG images should not be loaded when MathML is used - 10https://bugzilla.wikimedia.org/71929 (10Frédéric Wang) 5PATC>3RESO/FIX [04:10:14] > (change visibility) 18:15, 26 September 2014 Legoktm (talk | contribs | block) changed group membership for User:Osnard from (none) to administrator (Tag: HHVM) [04:10:18] The plot thickens. [04:10:23] https://tools.wmflabs.org/guc/?user=Osnard&blocks=true [04:10:48] https://en.wikipedia.org/w/index.php?title=User%3AOsnard%2Fvector.js [04:10:49] Heh. [04:11:32] I'm not sure saying "we wouldn't do it this way today if we started over" gives MediaWiki license to break interfaces. [04:11:40] APIs should be stable. :-( [04:12:01] Also, my personal console is now full of deprecations, apparently. [04:12:11] addPortletLink, etc. [04:13:17] Carmela: I'm not saying that at all. [04:13:21] (03PS1) 10Gnosygnu: v1.10.2.1 [xowa] - 10https://gerrit.wikimedia.org/r/166368 [04:13:21] I'm just saying it wouldn't happen today [04:13:36] it happened in the past, and it not happening today is in no way related to what I described before that. [04:13:36] Everything is going to break. [04:13:58] Code maintenance isn't fun. [04:14:07] APis are stable. This is the first ever breaking change in 10 years and it was after 3-12 months of deprecation. [04:14:18] And even then, most deprecated interfaces are still around [04:14:48] My policy currently is to only remove interfaces introduced/deprecated in the post-resourceloader era. [04:14:56] Legacy is for another time to go away. Who knows when. [04:15:01] Once the interfaces are removed, there's no console.log()? [04:15:06] Indeed. [04:15:20] So how does a developer know that's the reason for breakage? [04:15:35] https://test.wikipedia.org/wiki/Wikipedia:Teahouse/Question-form2 is up now. [04:15:38] How will you know a php program is broken if you run it under php 4? [04:15:48] I don't know, but I'm asking about JavaScript. [04:16:14] it'll throw up with exceptions saying methods don't exist. And this will have been after lots of users have been exposed to it, given the chance to think "hm.. does other code use this as well?" and after users have been exposed to console messages for months [04:17:30] They'll get an exception. At that point it's up to asking peers or Google to find what happened to that method. I don't think there's another feasible approach there. That's how it works in other languages and software packages as well. Our care in this regard is very unusual. [04:18:25] Anyone who has been in the loop would easily recognise it from their own maintenance. E.g. if you ask TheDJ or Edokter etc, They'll recognise the "x.y method doesn't exist" [04:18:33] as would anyone else who has been maintaining scripts. [04:19:30] So in this regard, a developer wouldn't start upgrading a script right away. It'd be wise to catch up on what's changed since the previous version first. [04:20:01] https://www.google.com/search?q=%22mw.user.anon%22 [04:20:04] Not bad at all [04:22:01] https://www.google.com/search?q=%22mediawiki.api%22+ok+parameter is harder, but still not bad in the first 5 results [04:23:08] https://test.wikipedia.org/w/index.php?title=MediaWiki:Gadget-teahouse/content.js&diff=prev&oldid=217340 [04:24:14] (03CR) 10Frédéric Wang: "http://math-preview.wmflabs.org/wiki/Displaystyle#Example_2 still renders incorrectly for me with the patch applied..." [services/mathoid] - 10https://gerrit.wikimedia.org/r/166358 (https://bugzilla.wikimedia.org/66572) (owner: 10Physikerwelt) [04:24:54] Carmela: looks right. There's one more [04:25:06] I fucked up a .done(). [04:25:20] And bleh, yes another. [04:25:30] In-browser command-F is fucking annoying with CodeEditor. [04:25:36] Indeed [04:25:42] Who wants a separate find dialog? Blergh. [04:25:46] Oh, I didn't know they were nested [04:25:48] Yikes [04:26:18] The ) shoudl be on the same indention level as .done( [04:26:54] Yeah, I personally can't use CodeEditor. I just transplant to desktop edior [04:29:44] (03PS24) 10Pastakhov: refactor and extend usability (v 3.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/163544 [04:31:24] > Uncaught TypeError: Cannot read property '0' of undefined [04:31:50] var oldText = page.revisions[0]['*']; [04:31:53] Does Wikipedia:Teahouse/Questions exist? [04:32:08] Hmm, maybe. [04:32:18] Nope [04:32:19] . [04:32:27] The script doesn't account for that error and assumes it exists [04:32:47] Good catch. [04:34:45] Still no luck. No error console message I can see. [04:39:25] Carmela: lemme see if i can help [04:41:59] Oh, I think it's working now. [04:42:00] https://test.wikipedia.org/wiki/Wikipedia:Teahouse/Questions [04:42:02] \o/ [04:42:24] I think the script makes lots of assumptions about page markup, both HTML and wikitext. [04:42:47] (03CR) 10Prtksxna: [C: 032 V: 032] mediawiki.special.changeslist.legend: Match dt/dd line-height [core] - 10https://gerrit.wikimedia.org/r/163564 (owner: 10Bartosz Dziewoński) [04:42:58] :( [04:43:41] Hey, I only had to copy over 7 pages to get it working. ;-) [04:43:51] hehe [04:43:58] welcome to js+template combination hell [04:44:01] At least it didn't use some labyrinth of template subpages. [04:46:06] prtksxna: Please don't bypass Jenkins validation. [04:46:47] prtksxna: You (most likely unintentionally) submitted https://gerrit.wikimedia.org/r/#/c/163564/ with "Verified+2" and "Submit" (instead of CodeReview+2 and "Publish"). [04:47:33] Krinkle: Oops. Yes, I'll take care next time. [04:48:31] We should remove those buttons for humans that aren't jenkins-bot. Many repos have done so already, but for now users in /wmf/ still see them in mediawiki-core. [04:50:09] Krinkle, brion: Thanks for the help. :-) [04:50:50] Krinkle: If one is never supposed to use them then it'd make sense to get rid of them [04:51:41] prtksxna: Yep. Bypassing jenkins will if (for whatever reason) the build is broken cuase the next commit to be indicated as "broken", even though it was a different one. [04:52:33] that should never be done except maybe maybe for a wmf/ branch for an important backport where a test produces a false positive. But in all likelihood that's just gut vs head being at odds ad one should just spend an extra minute and fix the test. [04:52:34] brion: I think the size you mentioned will still take up a lot of space on the screen. There is no harm in adding the option though, people with large screens will still be able to use it. [04:53:07] * brion -> https://en.wikipedia.org/wiki/Wikipedia:Gadget/proposals#Mobile_sidebar \o/ [04:53:47] prtksxna: yeah i’m more concerned with width on mobile stuff though [04:54:04] we might think about just having it take up the full available height, and make a couple different widths selectable [04:54:26] ‘iPhone 5’, ‘iPhone 6’, ‘Galaxy S5’, whatever [04:54:36] Krinkle: If you're gonna edit the page... https://en.wikipedia.org/wiki/MediaWiki_talk:Gadget-teahouse/content.js#Update_request_.28October_2014.29 :P [04:54:48] be like 320px, 360px etc [04:54:50] brion: Ah. But taking the full height might give the wrong idea. [04:55:03] true. things might not fit on screen if too tall :D [04:55:06] brion: Knowing that the screen is that small makes a difference when spotting errors or even making decisions [04:55:16] yeah makes sense [04:55:32] * prtksxna https://en.wikipedia.org/wiki/Wikipedia:Gadget/proposals#Mobile_sidebar <-- [04:55:36] º╲˚\╭ᴖ_ᴖ╮/˚╱º Y A Y ! [04:55:59] brion: Do you mind me adding one size change then? [04:56:10] sure [04:56:19] brion: I haven't checked out the changes you've made yet :\ [04:56:31] brion: Is there a better way to make changes than copy everything over? [04:56:37] mainly i added a toggle button on the tab bar :D [04:56:48] prtksxna: …. we could copy it over to github. :P [04:56:55] (03CR) 10Krinkle: "One more question: "probably go back to just displaytitle" What do you mean by "displaytitle"? Is that what this commit does? Saying "prob" [core] - 10https://gerrit.wikimedia.org/r/164735 (owner: 10Amire80) [04:57:05] brion: I read… [04:57:21] brion: And then mw.loader.load the files from github itself? [04:57:30] O_O omg we could i bet [04:57:38] brion: Raw content from master≥ [04:57:44] (03CR) 10Krinkle: "Also, do we even need the ? The

already has a lang attribute. We can easily instead standardise that across skins (I'll help if" [core] - 10https://gerrit.wikimedia.org/r/164735 (owner: 10Amire80) [04:57:48] brion: Ugh, I think the urls have sha1s though :( [04:57:51] bah [04:57:53] * prtksxna checks [04:58:08] i think you can refer to branches by name though [04:58:15] brion: https://raw.githubusercontent.com/prtksxna/mo/master/mo.py <-- Yes, you can :) [04:58:26] mwahahahah [04:58:41] (☞゚ヮ゚)☞ D O I T ! [04:59:13] brion: I need to run some errands and go to the bank now. Will you make the repo? [04:59:20] sure let’s try it :D [04:59:25] * brion pokes github [04:59:53] brion: I'll be back later, you might be asleep till then :\ [05:00:01] brion: I hope the github stuff works [05:00:13] we’ll see :D [05:00:16] brion: o/ [05:00:21] see ya later [05:07:20] prtksxna: ok it works but i had to use rawgit.com instead of github’s own raw URLs because the css isn’t served with proper content-type otherwise [05:07:26] “scary third-party sites aaaaaah" [05:07:31] :D [05:10:34] Okay, I think the Teahouse is un-broken. [05:11:09] The eternal question of how babby is formed remains unanswered. [05:11:23] lol [05:11:48] https://en.wikipedia.org/w/index.php?title=Wikipedia:Teahouse/Questions&diff=prev&oldid=629395968 :P [05:17:13] https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.Api is pretty. [05:34:52] (03CR) 10Krinkle: "(@Mark: that url is also embedded in jquery.ui.theme.css)" [core] - 10https://gerrit.wikimedia.org/r/145049 (owner: 10Paladox) [06:04:39] (03PS5) 10Awight: Componentize Title permissions logic [core] - 10https://gerrit.wikimedia.org/r/166357 [06:10:21] (03PS3) 10Brion VIBBER: Work in progress: ogv.js media player for Safari/IE (1 of 3) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165477 (https://bugzilla.wikimedia.org/61823) [06:11:14] (03PS6) 10Brion VIBBER: Work in progress: ogv.js media player for Safari/IE (2 of 3) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165478 (https://bugzilla.wikimedia.org/61823) [06:13:01] (03PS7) 10Brion VIBBER: Work in progress: ogv.js media player for Safari/IE (2 of 3) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165478 (https://bugzilla.wikimedia.org/61823) [06:13:10] (03PS7) 10Brion VIBBER: Work in progress: ogv.js media player for Safari/IE (3 of 3) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165479 (https://bugzilla.wikimedia.org/61823) [06:15:14] (03PS8) 10Brion VIBBER: Work in progress: ogv.js media player for Safari/IE (3 of 3) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165479 (https://bugzilla.wikimedia.org/61823) [06:16:21] (03CR) 10Brion VIBBER: "Latest update ensures that playback stops when the player is removed from the DOM, as when the mobile overlay (down in patch #3) is remove" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165477 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER) [06:20:16] is it possible to move the mediawiki installation from the file it in , into the parent directory [06:20:40] without breaking the installation? [06:25:17] (03PS9) 10Krinkle: Update jquery.ui Vector theme to 1.9.2 [skins/Vector] - 10https://gerrit.wikimedia.org/r/154024 (owner: 10Paladox) [06:25:32] (03PS10) 10Krinkle: Update jquery.ui Vector theme to 1.9.2 [skins/Vector] - 10https://gerrit.wikimedia.org/r/154024 (owner: 10Paladox) [06:29:11] (03CR) 10Krinkle: Update jquery.ui Vector theme to 1.9.2 (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/154024 (owner: 10Paladox) [06:29:31] Krinkle/php-cssjanus#9 (tweakReadme - 40c16b3 : Matthew Flaschen): The build passed. [06:29:31] Change view : https://github.com/Krinkle/php-cssjanus/commit/40c16b335eff [06:29:31] Build details : http://travis-ci.org/Krinkle/php-cssjanus/builds/37797023 [07:21:02] (03CR) 10Physikerwelt: "How did you test this. The change has neither been merged nor deployed." [services/mathoid] - 10https://gerrit.wikimedia.org/r/166358 (https://bugzilla.wikimedia.org/66572) (owner: 10Physikerwelt) [07:22:28] (03PS11) 10Krinkle: Update jquery.ui Vector theme to 1.9.2 [skins/Vector] - 10https://gerrit.wikimedia.org/r/154024 (owner: 10Paladox) [07:22:40] (03CR) 10Krinkle: "I'm trying to verify this change, but there's still lots of seemingly arbitrary changes that either come from another source or were made " [skins/Vector] - 10https://gerrit.wikimedia.org/r/154024 (owner: 10Paladox) [07:24:29] (03PS1) 10QChris: Unsubscribe SemanticFormsUniqueValue, as it will be deleted [extensions] (REL1_23) - 10https://gerrit.wikimedia.org/r/166371 [07:24:39] (03PS1) 10QChris: Unsubscribe SemanticFormsDisplayTitle, as it will be deleted [extensions] (REL1_23) - 10https://gerrit.wikimedia.org/r/166372 [07:24:47] (03PS1) 10QChris: Unsubscribe PartitionQuery, as it will be deleted [extensions] (REL1_23) - 10https://gerrit.wikimedia.org/r/166373 [07:30:45] (03CR) 10Krinkle: [C: 031] "Tested by creating a dialog with a button and datepicker:" [skins/Vector] - 10https://gerrit.wikimedia.org/r/154024 (owner: 10Paladox) [07:31:44] (03CR) 10Physikerwelt: "I pinged the author. https://en.wikipedia.org/wiki/User_talk:Jmkim_dot_com" [extensions/Math] - 10https://gerrit.wikimedia.org/r/165667 (owner: 10GWicke) [07:41:43] (03PS2) 10Krinkle: Add mediawiki.userSuggest to Special:ListFiles [core] - 10https://gerrit.wikimedia.org/r/166036 (owner: 10Umherirrender) [07:42:46] (03CR) 10Krinkle: [C: 032] Add mediawiki.userSuggest to Special:ListFiles [core] - 10https://gerrit.wikimedia.org/r/166036 (owner: 10Umherirrender) [07:43:00] (03PS3) 10Krinkle: Add mediawiki.userSuggest to Special:ListFiles [core] - 10https://gerrit.wikimedia.org/r/166036 (https://bugzilla.wikimedia.org/48240) (owner: 10Umherirrender) [07:43:08] (03PS8) 10Physikerwelt: Use radio buttons only for math mode selection [extensions/Math] - 10https://gerrit.wikimedia.org/r/165667 (owner: 10GWicke) [07:43:12] (03CR) 10Krinkle: [C: 032] Add mediawiki.userSuggest to Special:ListFiles [core] - 10https://gerrit.wikimedia.org/r/166036 (https://bugzilla.wikimedia.org/48240) (owner: 10Umherirrender) [07:45:30] (03CR) 10Physikerwelt: [C: 031] "Wait for i18 review." [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/166277 (owner: 10Shirayuki) [07:48:13] (03CR) 10Raimond Spekking: [C: 032] i18n: consistency tweaks [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/166277 (owner: 10Shirayuki) [07:50:08] (03Merged) 10jenkins-bot: Add mediawiki.userSuggest to Special:ListFiles [core] - 10https://gerrit.wikimedia.org/r/166036 (https://bugzilla.wikimedia.org/48240) (owner: 10Umherirrender) [07:50:13] (03Merged) 10jenkins-bot: i18n: consistency tweaks [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/166277 (owner: 10Shirayuki) [07:51:13] (03CR) 10Raimond Spekking: [C: 031] "i18n review" [extensions/Math] - 10https://gerrit.wikimedia.org/r/165667 (owner: 10GWicke) [07:57:33] (03PS5) 10Krinkle: mediawiki.language: Respect $wgTranslateNumerals in convertNumber() [core] - 10https://gerrit.wikimedia.org/r/164730 (https://bugzilla.wikimedia.org/70109) (owner: 10Amire80) [07:57:58] (03CR) 10Krinkle: "Unexplained changes that were removed in this patch set version:" [skins/Vector] - 10https://gerrit.wikimedia.org/r/154024 (owner: 10Paladox) [07:58:28] (03CR) 10Physikerwelt: [C: 032] "Even if we want to chang to mathjax + png this would better be a follow up" [extensions/Math] - 10https://gerrit.wikimedia.org/r/165667 (owner: 10GWicke) [07:59:22] (03Merged) 10jenkins-bot: Use radio buttons only for math mode selection [extensions/Math] - 10https://gerrit.wikimedia.org/r/165667 (owner: 10GWicke) [07:59:32] 3MediaWiki / 3Internationalization: mediawiki.language should respect $wgTranslateNumerals in convertNumber() - 10https://bugzilla.wikimedia.org/70109 (10Krinkle) a:3Krinkle [07:59:51] (03PS6) 10Krinkle: mediawiki.language: Respect $wgTranslateNumerals in convertNumber() [core] - 10https://gerrit.wikimedia.org/r/164730 (https://bugzilla.wikimedia.org/70109) (owner: 10Amire80) [08:00:12] (03CR) 10Krinkle: "Added release notes." [core] - 10https://gerrit.wikimedia.org/r/164730 (https://bugzilla.wikimedia.org/70109) (owner: 10Amire80) [08:02:33] (03PS6) 10Krinkle: build: Implement Grunt workflow (via npm test) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163908 (owner: 10Spage) [08:33:16] 3MediaWiki / 3Unit tests: StructureTest::testUnitTestFileNamesEndWithTest should use a dataprovider - 10https://bugzilla.wikimedia.org/42906#c5 (10dan) divyanshi, have you ever made any commits to the wikimedia code review site, https://gerrit.wikimedia.org? if so, it’s best to commit your changes there, ma... [08:59:26] (03CR) 10Christopher Johnson (WMDE): [C: 032 V: 032] refactored BurndownData and created abstract SprintView class [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/166195 (owner: 10Christopher Johnson (WMDE)) [09:00:04] (03CR) 10Christopher Johnson (WMDE): [C: 032 V: 032] Add public policy to List and Report Controllers [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/166183 (owner: 10Christopher Johnson (WMDE)) [09:00:19] (03PS1) 10Shirayuki: i18n: consistency tweaks [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/166381 [09:26:49] (03PS3) 10Bene: Add the option to register renderers for namespaces [extensions/Popups] - 10https://gerrit.wikimedia.org/r/150731 [09:28:05] (03PS4) 10Bene: Add the option to register renderers for namespaces [extensions/Popups] - 10https://gerrit.wikimedia.org/r/150731 [09:28:32] (03CR) 10Bene: Add the option to register renderers for namespaces (032 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/150731 (owner: 10Bene) [09:37:09] (03CR) 10Paladox: "The reason these were removed were because i downloaded the custom theme from the link inside jquery.ui.theme.css file. and it removed tho" [skins/Vector] - 10https://gerrit.wikimedia.org/r/154024 (owner: 10Paladox) [09:49:22] (03CR) 10Paladox: "This should also be backported to MediaWiki 1.24 which is where jquery.ui was updated." [skins/Vector] - 10https://gerrit.wikimedia.org/r/154024 (owner: 10Paladox) [09:54:52] (03PS41) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [09:55:13] (03CR) 10Paladox: [C: 031] "+1 from prevous commit." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [10:01:15] 3Wikimedia / 3Git/Gerrit: Git.wikimedia.org is down - 10https://bugzilla.wikimedia.org/71974#c2 (10Andre Klapper) 5NEW>3RESO/FIX Up and down could be seen this weekend on #wikimedia-operations: PROBLEM - git.wikimedia.org on antimony is CRITICAL: CRITICAL - Socket timeout after 10 seconds... [10:15:30] 3Wikimedia / 3Site requests: Add domains to $wgCopyUploadsDomains (tracking) - 10https://bugzilla.wikimedia.org/58224 (10Andrea Zanni) [10:15:33] 3Wikimedia / 3Site requests: Please add the domain *.uni-heidelberg.de to the wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/71990 (10Andrea Zanni) 3NEW p:3Unprio s:3normal a:3None please add the following domain(s) to the wgCopyUploadsDomains whitelist: uni-heidelberg.de The spec... [10:17:44] (03PS1) 10Paladox: Update Metrolook add support for MediaWiki 1.22 [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/166387 [10:18:17] (03PS1) 10Paladox: Update Metrolook add support for MediaWiki 1.22 [skins/Metrolook] (REL1_22) - 10https://gerrit.wikimedia.org/r/166388 [10:18:30] (03Abandoned) 10Paladox: Update Metrolook add support for MediaWiki 1.22 [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/166387 (owner: 10Paladox) [10:18:37] (03CR) 10Florianschmidtwelzow: "> @Paladox: There is no need to review your own change :)" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [10:25:58] (03CR) 10Fomafix: [C: 04-1] "Thumbs.db is not necessary." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [10:29:24] (03CR) 10Paladox: [C: 032 V: 032] Update Metrolook add support for MediaWiki 1.22 [skins/Metrolook] (REL1_22) - 10https://gerrit.wikimedia.org/r/166388 (owner: 10Paladox) [10:31:00] 3Wikimedia / 3Site requests: Please add the domain *.uni-heidelberg.de to the wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/71990#c1 (10dan) some example URLs: http://edh-www.adw.uni-heidelberg.de/edh/foto/F015679 http://edh-www.adw.uni-heidelberg.de/fotos/F015679.JPG http://edh-www.adw.... [10:36:24] (03PS1) 10Paladox: Update Metrolook [skins/Metrolook] (REL1_23) - 10https://gerrit.wikimedia.org/r/166389 [10:36:49] (03CR) 10Santhosh: [C: 032] translateAnnotations with partial mapping [services/cxserver] - 10https://gerrit.wikimedia.org/r/156518 (owner: 10Divec) [10:37:30] (03Merged) 10jenkins-bot: translateAnnotations with partial mapping [services/cxserver] - 10https://gerrit.wikimedia.org/r/156518 (owner: 10Divec) [10:38:15] (03CR) 10Santhosh: [C: 032] "We will have to refactor this code a lot to allow alternate algorithms to co-exist. We will plan that in near future while we implement ht" [services/cxserver] - 10https://gerrit.wikimedia.org/r/157141 (owner: 10Divec) [10:38:33] (03PS2) 10Paladox: Update Metrolook [skins/Metrolook] (REL1_23) - 10https://gerrit.wikimedia.org/r/166389 [10:38:41] (03Merged) 10jenkins-bot: Derive MT subsentence map from uppercasing [services/cxserver] - 10https://gerrit.wikimedia.org/r/157141 (owner: 10Divec) [10:38:54] (03CR) 10Paladox: [C: 032 V: 032] Update Metrolook [skins/Metrolook] (REL1_23) - 10https://gerrit.wikimedia.org/r/166389 (owner: 10Paladox) [10:44:40] (03PS1) 10Paladox: Update Metrolook [skins/Metrolook] (REL1_24) - 10https://gerrit.wikimedia.org/r/166392 [10:46:28] (03CR) 10Paladox: [C: 032 V: 032] Update Metrolook [skins/Metrolook] (REL1_24) - 10https://gerrit.wikimedia.org/r/166392 (owner: 10Paladox) [10:46:42] (03CR) 10He7d3r: "Is this supposed to be live on" [extensions/Math] - 10https://gerrit.wikimedia.org/r/165667 (owner: 10GWicke) [10:51:10] (03CR) 10Krinkle: "fixme: PHP Strict Warning (see comment)." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/162286 (https://bugzilla.wikimedia.org/71087) (owner: 10Physikerwelt) [10:51:38] (03CR) 10Krinkle: Add counter to DatabaseUpdater::setAppliedUpdates (031 comment) [core] - 10https://gerrit.wikimedia.org/r/162286 (https://bugzilla.wikimedia.org/71087) (owner: 10Physikerwelt) [10:52:30] 3MediaWiki / 3General/Unknown: HttpRequest: Failing under PHP 5.6 (CURLOPT_CLOSEPOLICY not defined) - 10https://bugzilla.wikimedia.org/71729#c4 (10Krinkle) 5PATC>3RESO/FIX https://travis-ci.org/Krinkle/mediawiki-core/jobs/37801162 (current master on PHP 5.6) no longer shows any CURL related errors. [10:53:00] 3MediaWiki / 3General/Unknown: HttpRequest: Failing under PHP 5.6 (CURLOPT_CLOSEPOLICY not defined) - 10https://bugzilla.wikimedia.org/71729 (10Krinkle) [10:53:53] (03CR) 10Krinkle: "This applies to PHP 5.3 and 5.4 as well. Ignore my comment about PHP 5.6. See also the jenkins output https://integration.wikimedia.org/ci" [core] - 10https://gerrit.wikimedia.org/r/162286 (https://bugzilla.wikimedia.org/71087) (owner: 10Physikerwelt) [10:57:07] (03PS1) 10Paladox: Update Metrolook [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/166394 [10:59:09] (03CR) 10Paladox: "Hi i have renamed all the .less files. and i just need to delete thumb.db file." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [11:00:57] (03CR) 10Paladox: [C: 032 V: 032] Update Metrolook [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/166394 (owner: 10Paladox) [11:01:31] (03CR) 10Physikerwelt: "We have to check if $wgMathValidModes is set explicitly for beta (and core)." [extensions/Math] - 10https://gerrit.wikimedia.org/r/165667 (owner: 10GWicke) [11:05:45] (03CR) 10Fomafix: "See the differences:" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [11:06:30] 3Wikimedia / 3Site requests: Please add the domain *.uni-heidelberg.de to the wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/71990#c4 (10Marius Hoch) 5PATC>3RESO/FIX Change deployed [11:08:15] (03CR) 10Paladox: "Oh ok so you would like me to do rename the file instead of deleting it and adding it." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [11:09:20] (03CR) 10Paladox: "Hi how do I rename files." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [11:09:47] (03CR) 10Reedy: "git mv ?" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [11:10:50] * Reedy facepalms [11:11:56] Reedy: deleting/adding becomes mv once committed [11:12:03] Right [11:12:05] and if he moves it and then changes it, it will become delete/add. [11:12:14] But presumably he's doing something weird [11:12:20] It's Palado [11:12:30] lol [11:12:35] Also, gerrit doesn't display it well [11:13:20] I know I've duplicated, renamed and edited one file in one commit, fine on git side, not so obvious on gerrit [11:14:16] cgit vs. the java git thing [11:14:40] they have subtly different implementations of move etc. here and there [11:14:47] (03CR) 10Krinkle: "Whether they are renamed with 'git mv' or removed, copied, renamed, and 'git add'-ed is irrelevant." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [11:15:01] Reedy: The "R" indication works fine on Gerrit though? [11:15:22] The detection of rename and similarity happens locally though, not part of the commit object [11:15:32] can also be configured [11:15:39] jgit plane sucks [11:15:42] plain [11:15:45] Yep... and cgit has a different threshold of how much can change [11:15:48] jgit just sucks [11:15:53] (and it's still a rename) [11:28:42] (03CR) 10Krinkle: "@Paladox: No, you don't understand. Those things were still there in the files you submitted to Gerrit. I downloaded the files again from " [skins/Vector] - 10https://gerrit.wikimedia.org/r/154024 (owner: 10Paladox) [11:47:47] 3Wikimedia / 3Site requests: Enable $wgCopyUploadsFromSpecialUpload on Wikimedia Commons - 10https://bugzilla.wikimedia.org/71897#c3 (10Manuel Schneider) I think the proposal can be counted as successful as several days no new comments were made and with one exception - which doesn't indicate a clear opinion... [11:54:48] (03CR) 10Daniel Kinzler: "I agree with Anomie that it would be cleaner to have a hook to replace the entire DifferenceEngine (which has badly named, since it's real" [core] - 10https://gerrit.wikimedia.org/r/166143 (https://bugzilla.wikimedia.org/71916) (owner: 10Cacycle) [11:57:28] (03PS4) 10Krinkle: jquery.tablesorter: Use data() instead of DOM Node properties [core] - 10https://gerrit.wikimedia.org/r/98295 (owner: 10TheDJ) [12:01:07] (03PS42) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [12:01:27] (03PS43) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [12:02:19] (03CR) 10Paladox: "Ok thanks." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [12:02:33] 3MediaWiki extensions / 3Collection: Book Creator not working on Gujarati Wikisource - 10https://bugzilla.wikimedia.org/71993 (10Dhaval) 3NEW p:3Unprio s:3normal a:3None on Gujarati (gu) wikisource, book creator is not working. When clicking on Download as PDF, it hangs at Progress: 0.00% and status... [12:02:49] (03PS44) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [12:03:45] 3MediaWiki extensions / 3Collection: Book Creator not working on Gujarati Wikisource - 10https://bugzilla.wikimedia.org/71993 (10Dhaval) p:5Unprio>3Normal s:5normal>3major [12:03:58] (03CR) 10jenkins-bot: [V: 04-1] jquery.tablesorter: Use data() instead of DOM Node properties [core] - 10https://gerrit.wikimedia.org/r/98295 (owner: 10TheDJ) [12:06:56] (03CR) 10Paladox: "Hi i did not do it on purpose i may have changed a few stuff that were custom." [skins/Vector] - 10https://gerrit.wikimedia.org/r/154024 (owner: 10Paladox) [12:12:15] 3MediaWiki / 3General/Unknown: file permissions cause lintian warnings - 10https://bugzilla.wikimedia.org/71972#c1 (10Byfserag) https://bugzilla.wikimedia.org/show_bug.cgi?id=71928 https://bugzilla.wikimedia.org/show_bug.cgi?id=71930 https://bugzilla.wikimedia.org/show_bug.cgi?id=71931 https://bugzilla.wi... [12:16:38] (03PS45) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [12:16:57] (03PS46) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [12:17:00] 3MediaWiki / 3Unit tests: StructureTest::testUnitTestFileNamesEndWithTest should use a dataprovider - 10https://bugzilla.wikimedia.org/42906#c6 (10Andre Klapper) https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker might also be helpful. [12:42:29] (03PS1) 10Smuggli: Readded contenttable styling [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/166403 [12:44:31] (03CR) 10Paladox: "I tryed to use git mv but it wont say that these files have been renamed because they are big changes in some of the files i have deleted " [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [12:45:27] (03CR) 10Paladox: [C: 031] "From previous commit and i do this so that someone else can review it." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [12:48:45] 3MediaWiki extensions / 3Collection: creating PDF page no longer refreshes, hangs on test2wiki, mediawiki.org - 10https://bugzilla.wikimedia.org/71574 (10Andre Klapper) [12:48:45] 3MediaWiki extensions / 3Collection: PDF Book Creator not working on Gujarati Wikisource: "Waiting for job runner to pick up render job" - 10https://bugzilla.wikimedia.org/71993#c1 (10Andre Klapper) p:5Normal>3High Even refreshing the page does not help, so looks different than bug 71574. [12:49:15] 3MediaWiki extensions / 3Collection: creating PDF page no longer refreshes, hangs on test2wiki, mediawiki.org - 10https://bugzilla.wikimedia.org/71574#c3 (10Andre Klapper) p:5Normal>3High Bug 71993 seems related but isn't fixed by reloading the page. [13:02:41] (03CR) 10Gilles: [C: 032] Don't register ResourceLoaderFileModule objects [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/166202 (https://bugzilla.wikimedia.org/71768) (owner: 10Legoktm) [13:03:25] (03Merged) 10jenkins-bot: Don't register ResourceLoaderFileModule objects [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/166202 (https://bugzilla.wikimedia.org/71768) (owner: 10Legoktm) [13:10:03] (03PS1) 10Matthias Mullie: Make sure $found actually contains values [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166404 [13:18:42] (03CR) 10Krinkle: [C: 04-1] "That is just a user-uploaded SVG file. Anyone can upload that. It's a derivative of a derivative of a derivative of an unofficial and unre" [core] - 10https://gerrit.wikimedia.org/r/142860 (https://bugzilla.wikimedia.org/63872) (owner: 10M4tx) [13:19:51] (03CR) 10Krinkle: "Also, older browsers don't support SVG. So a plain switch is out of the question. This should be done via CSS instead." [core] - 10https://gerrit.wikimedia.org/r/142860 (https://bugzilla.wikimedia.org/63872) (owner: 10M4tx) [13:20:50] (03CR) 10Krinkle: "And as said before, until there is an official SVG logo of MediaWiki, there is no point in investing any time in this." [core] - 10https://gerrit.wikimedia.org/r/142860 (https://bugzilla.wikimedia.org/63872) (owner: 10M4tx) [13:25:52] (03PS1) 10Physikerwelt: Fix: FakeDatabasUpdater::setAppliedUpdates [core] - 10https://gerrit.wikimedia.org/r/166405 [13:27:00] 3MediaWiki extensions / 3Translate: JavascriptFFS shouldn't be building JSON manually - 10https://bugzilla.wikimedia.org/31331#c12 (10Nemo) From #mediawiki 2014-10-12 19.57 < Nemo_bis> The bug is about using standard functions to reduce mistakes in JSON production. PleaseStand linked a function in core whic... [13:28:35] (03PS2) 10Physikerwelt: Fix: FakeDatabasUpdater::setAppliedUpdates [core] - 10https://gerrit.wikimedia.org/r/166405 [13:29:40] (03CR) 10Brion VIBBER: "The problem isn't that it's not official (we can simply declare it to be official) but that it's a whopping 515kb :D" [core] - 10https://gerrit.wikimedia.org/r/142860 (https://bugzilla.wikimedia.org/63872) (owner: 10M4tx) [13:29:53] (03PS1) 10Matthias Mullie: (bug 71619) Remove duplicate "created topic" item from watchlist [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166407 (https://bugzilla.wikimedia.org/71619) [13:31:48] (03PS5) 10Matthias Mullie: Hygiene: Finish conversion to new UrlGenerator [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161164 (owner: 10EBernhardson) [13:32:37] (03CR) 10Krinkle: Fix: FakeDatabasUpdater::setAppliedUpdates (031 comment) [core] - 10https://gerrit.wikimedia.org/r/166405 (owner: 10Physikerwelt) [13:34:24] (03PS1) 10Gilles: Add E2E test page import to MV role [vagrant] - 10https://gerrit.wikimedia.org/r/166409 [13:36:11] (03PS3) 10Krinkle: Fix strict warning in FakeDatabasUpdater::setAppliedUpdates [core] - 10https://gerrit.wikimedia.org/r/166405 (owner: 10Physikerwelt) [13:36:11] hello... is it possible to run a usercontribs query against a specfic page? [13:36:17] (03CR) 10Krinkle: Fix strict warning in FakeDatabasUpdater::setAppliedUpdates (031 comment) [core] - 10https://gerrit.wikimedia.org/r/166405 (owner: 10Physikerwelt) [13:36:41] (03CR) 10Krinkle: [C: 032] Fix strict warning in FakeDatabasUpdater::setAppliedUpdates [core] - 10https://gerrit.wikimedia.org/r/166405 (owner: 10Physikerwelt) [13:38:08] for example, this query returns 500 usercontribs [13:38:10] https://en.wikipedia.org/w/api.php?action=query&list=usercontribs&ucuser=Catrope&uclimit=500&ucdir=newer [13:38:27] But I want to show only the contribs for article called "Dry run" [13:39:53] (03PS15) 10Krinkle: mw.config: Show deprecation notices when accessing wg* globals [core] - 10https://gerrit.wikimedia.org/r/133162 (https://bugzilla.wikimedia.org/56550) (owner: 10Gerrit Patch Uploader) [13:39:57] (03CR) 10Matthias Mullie: Hygiene: Finish conversion to new UrlGenerator (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161164 (owner: 10EBernhardson) [13:39:59] (03CR) 10Krinkle: [C: 031] mw.config: Show deprecation notices when accessing wg* globals [core] - 10https://gerrit.wikimedia.org/r/133162 (https://bugzilla.wikimedia.org/56550) (owner: 10Gerrit Patch Uploader) [13:40:05] (03PS6) 10Matthias Mullie: Hygiene: Finish conversion to new UrlGenerator [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161164 (owner: 10EBernhardson) [13:42:44] (03CR) 10Matthias Mullie: [C: 032] Explicitly treat Message plaintext parameters as plaintext [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161101 (https://bugzilla.wikimedia.org/66547) (owner: 10EBernhardson) [13:43:16] (03Merged) 10jenkins-bot: Fix strict warning in FakeDatabasUpdater::setAppliedUpdates [core] - 10https://gerrit.wikimedia.org/r/166405 (owner: 10Physikerwelt) [13:43:32] (03Merged) 10jenkins-bot: Explicitly treat Message plaintext parameters as plaintext [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161101 (https://bugzilla.wikimedia.org/66547) (owner: 10EBernhardson) [13:44:14] (03CR) 10Fomafix: [C: 04-1] "Duplicate files:" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [13:44:46] 3MediaWiki extensions / 3Collection: PDF Book Creator not working on gu.wikisource/de.wikipedia: "Waiting for job runner to pick up render job" - 10https://bugzilla.wikimedia.org/71993#c2 (10Andre Klapper) p:5High>3Highes Bumping priority as it looks like more sites are affected by this. I think C Scott... [13:45:01] 3Wikimedia / 3Site requests: Turn mediawiki.org into a Wikidata client - 10https://bugzilla.wikimedia.org/71685 (10Lydia Pintscher) p:5Low>3Normal [13:47:13] (03PS1) 10Krinkle: Declare dependency jquery.cookie for ext.navigationTiming [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/166411 [13:47:20] (03CR) 10Krinkle: "Fixed in Iea12d9451a13864cfa6d2c113f0c3b26907fd23e." [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/164984 (owner: 10Ori.livneh) [13:48:40] (03PS47) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [13:49:48] (03PS48) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [13:50:03] 3Wikimedia / 3Site requests: Turn mediawiki.org into a Wikidata client - 10https://bugzilla.wikimedia.org/71685 (10Lydia Pintscher) a:3Wikidata bugs [13:50:40] (03CR) 10Paladox: [C: 031] "Please review again." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [13:52:06] Reedy: This change https://gerrit.wikimedia.org/r/#/c/165667/ in combination with the current settings in labs effectivly disables MathJax https://gerrit.wikimedia.org/r/#/c/166410/ solves the problem... If you have no time right now please let me know... I'll create a bug in that case [13:52:56] (03CR) 10Krinkle: "Fixed in I804249ea014786c5c47ce8c0be38e445449ed828." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/162809 (https://bugzilla.wikimedia.org/71276) (owner: 10Hoo man) [14:01:07] (03PS1) 10Smuggli: Fixed some runtime issues [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/166412 [14:02:02] (03CR) 10Matthias Mullie: Hygiene: Finish conversion to new UrlGenerator (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161164 (owner: 10EBernhardson) [14:02:09] (03CR) 10Matthias Mullie: [C: 032] Hygiene: Finish conversion to new UrlGenerator [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161164 (owner: 10EBernhardson) [14:03:02] (03Merged) 10jenkins-bot: Hygiene: Finish conversion to new UrlGenerator [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161164 (owner: 10EBernhardson) [14:05:48] (03PS1) 10Smuggli: Removing jquery dependency [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/166414 [14:14:30] 3MediaWiki extensions / 3Collection: PDF Book Creator not working on gu.wikisource/de.wikipedia: "Waiting for job runner to pick up render job" - 10https://bugzilla.wikimedia.org/71993#c3 (10C. Scott Ananian) Yes, I'm on vacation this week (but checking in via email). Can this be reproduced, or was it a tran... [14:18:48] (03PS1) 10Brion VIBBER: Add HiDPI PNG variants for 'Powered by MediaWiki' footer icon [core] - 10https://gerrit.wikimedia.org/r/166416 (https://bugzilla.wikimedia.org/63872) [14:20:14] (03CR) 10Brion VIBBER: [C: 04-1] "For a more conservative changeset, see https://gerrit.wikimedia.org/r/#/c/166416/ which uses PNG renderings of the SVG at 1.5x and 2x dens" [core] - 10https://gerrit.wikimedia.org/r/142860 (https://bugzilla.wikimedia.org/63872) (owner: 10M4tx) [14:23:55] (03CR) 10Gilles: [C: 031] Work in progress: ogv.js media player for Safari/IE (1 of 3) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165477 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER) [14:24:09] (03CR) 10Matthias Mullie: Hygiene: Finish conversion to new UrlGenerator (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161164 (owner: 10EBernhardson) [14:33:34] (03PS1) 10Matthias Mullie: Headers have no postId [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166418 [14:33:38] (03PS1) 10Matthias Mullie: Anchor's toArray should produce full url [extensions/Flow] - 10https://gerrit.wikimedia.org/r/166419 [14:35:18] (03CR) 10Fomafix: [C: 04-1] "Missing new line at end of file." (035 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [14:38:18] (03CR) 10Fomafix: "https://www.mediawiki.org/wiki/Manual:Coding_conventions/CSS#Whitespace" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [14:39:30] 3MediaWiki extensions / 3CategoryTree: Uncaught ReferenceError: categoryTreeLoadChildren is not defined - 10https://bugzilla.wikimedia.org/60836 (10Lydia Pintscher) 5NEW>3RESO/WOR [14:39:31] 3MediaWiki extensions / 3CategoryTree: Uncaught ReferenceError: categoryTreeLoadChildren is not defined - 10https://bugzilla.wikimedia.org/60836 (10Lydia Pintscher) 5NEW>3RESO/WOR [14:39:46] (03PS1) 10Smuggli: Added support for MW 1.24 [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/166420 [14:40:18] (03CR) 10Smuggli: [C: 032 V: 032] Make it up the user if he wants links on special page [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/166022 (owner: 10Smuggli) [14:41:08] (03PS5) 10Matthias Mullie: Hygiene: Simplify listener for inserting RecentChange [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165426 (owner: 10EBernhardson) [14:43:08] (03PS2) 10Smuggli: Fixed some runtime issues [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/166412 [15:00:54] (03PS4) 10Smuggli: Code corrections to silence jslint [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/165717 [15:10:33] (03PS49) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [15:11:22] (03CR) 10Paladox: [C: 031] "Hi I have now put a ne line at the end and spaced the css out. please review again." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [15:44:47] 3Wikimedia / 3Extension setup: FlaggedRevs for Norwegian (bokmål) Wikipedia - 10https://bugzilla.wikimedia.org/64726#c40 (10jeblad) The discussion about details are now closed and archived. We should initially use the simpler UI with a simple scale. After a while we will probably change to a scale that acco... [15:51:01] 3Wikimedia / 3Extension setup: FlaggedRevs for Norwegian (bokmål) Wikipedia - 10https://bugzilla.wikimedia.org/64726#c41 (10jeblad) Last version of our discussion with the voting and such before archival https://no.wikipedia.org/w/index.php?title=Wikipedia:Tinget&oldid=13445778#Implementering_av_pending_chan... [15:58:57] (03CR) 10Paladox: "ne = new" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [16:11:24] (03CR) 10Gilles: [C: 04-1] "No complaints about code styling/redundancy left :)" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165478 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER) [16:14:17] (03CR) 10Brion VIBBER: "Yeah, it's probably not giving a notification on completion, and it gets a little confused when you try to start it up again. I'll take a " [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165478 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER) [16:17:03] (03CR) 10Giuseppe Lavagetto: [C: 031] Make scap restart HHVM [tools/scap] - 10https://gerrit.wikimedia.org/r/163078 (owner: 10Ori.livneh) [16:19:48] (03CR) 10Frédéric Wang: "http://math-preview.wmflabs.org/wiki/Displaystyle looks good to me now." [services/mathoid] - 10https://gerrit.wikimedia.org/r/166358 (https://bugzilla.wikimedia.org/66572) (owner: 10Physikerwelt) [16:20:19] (03CR) 10Frédéric Wang: [C: 031] Merge recent changes from MathJax [services/mathoid] - 10https://gerrit.wikimedia.org/r/166358 (https://bugzilla.wikimedia.org/66572) (owner: 10Physikerwelt) [16:21:53] (03Abandoned) 10Frédéric Wang: Experimental - Try to cherry-pick fix for MathJax's issue 839 [services/mathoid] - 10https://gerrit.wikimedia.org/r/166198 (https://bugzilla.wikimedia.org/66572) (owner: 10Frédéric Wang) [16:23:52] (03CR) 10Frédéric Wang: [C: 031] Make texvcjs compatible to texvc [services/mathoid] - 10https://gerrit.wikimedia.org/r/166353 (owner: 10Physikerwelt) [16:46:45] 3MediaWiki extensions / 3Collection: PDF Book Creator not working on gu.wikisource/de.wikipedia: "Waiting for job runner to pick up render job" - 10https://bugzilla.wikimedia.org/71993#c4 (10Andre Klapper) According to godog on engineering@, restarting the service (like last week) restarted the queue process... [16:49:21] (03CR) 10CSteipp: [C: 031] "Hopefully those libraries will be updated so the exception isn't needed, but some protection is better than none." [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/166169 (owner: 10BryanDavis) [16:50:48] 3MediaWiki extensions / 3Collection: PDF rendering fails, process died with non zero code 1 - 10https://bugzilla.wikimedia.org/72002 (10Patrik (pajz)) 3NEW p:3Unprio s:3normal a:3None Downloading the article "Finanztransaktionssteuer" on dewiki as a PDF file fails. The process stays at 0,00% with sta... [17:02:43] (03CR) 10Anomie: [WIP] Fully replace Title::moveTo() with MovePage (033 comments) [core] - 10https://gerrit.wikimedia.org/r/166175 (owner: 10Legoktm) [17:11:06] (03PS1) 10Thiemo Mättig (WMDE): Rewrite ORMTable::unprefixFieldNames [core] - 10https://gerrit.wikimedia.org/r/166439 [17:17:28] (03PS8) 10Brion VIBBER: Work in progress: ogv.js media player for Safari/IE (2 of 3) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165478 (https://bugzilla.wikimedia.org/61823) [17:19:22] (03CR) 10Brion VIBBER: "Ok, I just wasn't catching the 'ended' event and passing it on to the proper handler. :P Note that the ending event seems to come a little" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165478 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER) [17:19:31] 3MediaWiki / 3File management: Allow uploading derivative works and collages (using Upload Wizard?) - 10https://bugzilla.wikimedia.org/67283#c7 (10WhatamIdoing) It looks like it's been moved to labs, but not enabled for use: https://tools.wmflabs.org/derivative/ [17:19:34] (03PS9) 10Brion VIBBER: Work in progress: ogv.js media player for Safari/IE (3 of 3) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165479 (https://bugzilla.wikimedia.org/61823) [17:22:47] 3MediaWiki extensions / 3Collection: Column choice is ignored in book creation tool - 10https://bugzilla.wikimedia.org/72003 (10Patrik (pajz)) 3NEW p:3Unprio s:3normal a:3None If you select "1" under "columns" right before you generate the PDF of your book, the articles in the resulting file are stil... [17:35:18] 3OCG / 3PDF renderer: Error while converting Indic source content to PDF - 10https://bugzilla.wikimedia.org/72005 (10Sushant_savla) 3UNCO p:3Unprio s:3normal a:3None This is regarding the error which occurs while converting Gujarati wiki Source books in to PDF format. Many a times bookes written in... [17:38:42] (03CR) 10Gilles: "I think that the window onblur event is pretty well supported, should work on all IEs and desktop Safari for sure. jQuery might even conta" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165478 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER) [17:40:51] (03CR) 10Brion VIBBER: "Looks like I can use page visibility events on current Safari/IE, and onblur for the older versions. The problem with onblur is that it'll" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165478 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER) [17:44:52] (03CR) 10Gilles: "If it's timers getting throttled, have you looked into using requestanimationframe instead of timers?" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165478 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER) [17:45:32] (03CR) 10Brion VIBBER: "requestAnimationFrame is also throttled when the page is hidden. :)" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165478 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER) [17:46:26] (03CR) 10Gilles: "Curses, foiled again!" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165478 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER) [17:57:59] MatmaRex: https://gerrit.wikimedia.org/r/162229 [17:58:03] Any idea for a sane name? [17:59:10] (03PS2) 10Gilles: Add E2E test page import to MV role [vagrant] - 10https://gerrit.wikimedia.org/r/166409 [17:59:52] hoo: personally i liked newFor, but if you want to be more specific, maybe newWithCors or something? [18:00:15] MatmaRex: Well something that doesn't earn a -1 from Krinkle [18:01:17] hoo: eh… just slap some more documentation on it and he'll like it ;) [18:02:16] hehe... will do that [18:02:25] having that in core is much nicer than in Wikibase [18:02:29] where it totally doesn't belong [18:02:50] (03PS1) 10Bartosz Dziewoński: Article: Handle double redirects in data for mediawiki.action.view.redirect [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/166446 (https://bugzilla.wikimedia.org/71002) [18:03:14] (03CR) 10Bartosz Dziewoński: [C: 032] "Let's backport, small straightforward fix for a new feature." [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/166446 (https://bugzilla.wikimedia.org/71002) (owner: 10Bartosz Dziewoński) [18:03:25] indeed [18:04:00] 3MediaWiki / 3JavaScript: mediawiki.action.view.redirect.js: Not idempotent when used on double redirect (refreshing the page redirects the user elsewhere) - 10https://bugzilla.wikimedia.org/71002 (10Bartosz Dziewoński) [18:04:18] 3MediaWiki / 3JavaScript: mediawiki.action.view.redirect.js: Not idempotent when used on double redirect (refreshing the page redirects the user elsewhere) - 10https://bugzilla.wikimedia.org/71002 (10Bartosz Dziewoński) 5PATC>3RESO/FIX [18:05:45] (03CR) 10Tuxilina: "Is there any more work needed on this?" [core] - 10https://gerrit.wikimedia.org/r/164726 (https://bugzilla.wikimedia.org/25163) (owner: 10Tuxilina) [18:09:19] (03PS4) 10Gilles: Include simplified templates into multimedia role [vagrant] - 10https://gerrit.wikimedia.org/r/165710 [18:09:45] (03Merged) 10jenkins-bot: Article: Handle double redirects in data for mediawiki.action.view.redirect [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/166446 (https://bugzilla.wikimedia.org/71002) (owner: 10Bartosz Dziewoński) [18:09:47] (03CR) 10Gilles: "Just fixed the dump_sentinel_page values, which incorrectly had a wiki prefix." [vagrant] - 10https://gerrit.wikimedia.org/r/165710 (owner: 10Gilles) [18:12:07] (03CR) 10Hoo man: Introduce: mw.Api.newFor (031 comment) [core] - 10https://gerrit.wikimedia.org/r/162229 (owner: 10Hoo man) [18:12:11] (03Restored) 10Hoo man: Introduce: mw.Api.newFor [core] - 10https://gerrit.wikimedia.org/r/162229 (owner: 10Hoo man) [18:12:32] (03PS4) 10Hoo man: Introduce: mw.Api.newFor [core] - 10https://gerrit.wikimedia.org/r/162229 [18:13:13] MatmaRex: Added that CORS is required to the docs [18:13:21] good enough? [18:13:54] (03CR) 10Fomafix: "What did you change in the PNG files? I can not see a difference except that the files are larger." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [18:14:54] hoo: probably. you don't need this right now, right? if it can wait, then let's wait for Krinkle :) [18:15:20] (03CR) 10Bartosz Dziewoński: [C: 031] "Not tested, looks reasonable." [core] - 10https://gerrit.wikimedia.org/r/162229 (owner: 10Hoo man) [18:15:20] MatmaRex: No, not right now... but having it this week would be awesome [18:15:39] some wikibase change sets are rotting because of this [18:16:41] right. let's give these pesky lazy americans with their holidays at random days time to notice this and merge afterwards ;) if you want Krinkle to recheck, i'd drop him an email, his bugmail queue is probably enough for a few workdays [18:17:11] (by "i'd", i mean "you should" ;) ) [18:17:39] good idea, I guess [18:23:15] (03CR) 10Paladox: "I just added the file from vector skin which had the arrow down and expand. i then added the svg file." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [18:35:34] (03CR) 10Nemo bis: "Thanks Ori for asking. This patch just changes the default content of the system message which is displayed at the bottom of Special:Stati" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/147505 (https://bugzilla.wikimedia.org/65993) (owner: 10Nemo bis) [18:42:52] (03PS4) 10Brion VIBBER: Work in progress: ogv.js media player for Safari/IE (1 of 3) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165477 (https://bugzilla.wikimedia.org/61823) [18:43:04] (03PS9) 10Brion VIBBER: Work in progress: ogv.js media player for Safari/IE (2 of 3) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165478 (https://bugzilla.wikimedia.org/61823) [18:44:11] (03PS10) 10Brion VIBBER: Work in progress: ogv.js media player for Safari/IE (2 of 3) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165478 (https://bugzilla.wikimedia.org/61823) [18:44:59] (03CR) 10Brion VIBBER: "Ok I've managed to get the player to work in the background by driving decoding off the Web Audio callbacks if we're starved for audio bec" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165478 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER) [18:45:07] (03PS10) 10Brion VIBBER: Work in progress: ogv.js media player for Safari/IE (3 of 3) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165479 (https://bugzilla.wikimedia.org/61823) [18:48:17] 3MediaWiki extensions / 3ConfirmEdit (CAPTCHA extension): ConfirmEdit does not work with QuestyCaptcha - 10https://bugzilla.wikimedia.org/71984#c2 (10bluelupo) Hi Andre, I have debugging enabled in LocalSettings.php with: $ wgDebugLogFile = "debug.log"; Now I have a page in my wiki changed and stored, u... [18:49:23] brion: \o/ [18:51:11] \o\ [18:51:15] /o/ [18:58:50] 3MediaWiki / 3General/Unknown: HHVM: segfault when serializing/unserializing large preprocessor cache items - 10https://bugzilla.wikimedia.org/71486#c12 (10Kevin Israel (PleaseStand)) (In reply to Ori Livneh from comment #11) > It's not good to segfault on user input, so there is still a bit of work to > do... [19:03:36] (03CR) 10Brion VIBBER: [C: 04-1] "Ah crap, I broke pause somehow. Will fix that up again. :P" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165478 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER) [19:17:16] 3MediaWiki extensions / 3Collection: PDF Book Creator not working on gu.wikisource/de.wikipedia: "Waiting for job runner to pick up render job" - 10https://bugzilla.wikimedia.org/71993#c5 (10Andre Klapper) Is bug 72002 a duplicate? "Rendering process died with non zero code: 1" [19:24:45] 3OCG / 3PDF renderer: (Indic) Hindi and sanskrit letters rendered as squares in PDFs - 10https://bugzilla.wikimedia.org/72005#c1 (10Andre Klapper) Currently cannot test as I run into bug 71993. Attaching the PDF is welcome. I assume the "error" is just an incorrect / missing font? Full link: https://gu.wi... [19:27:00] 3MediaWiki / 3Search: Search: Ignore namespace prefix and truncate left - 10https://bugzilla.wikimedia.org/71977#c3 (10Subfader) MW 1.22 - If I eneable "Search suggest" I expect it to work ;) Will disable it. [19:29:15] 3MediaWiki / 3Search: Search: Ignore namespace prefix and truncate left - 10https://bugzilla.wikimedia.org/71977#c4 (10Subfader) Shouldn't https://www.mediawiki.org/wiki/Manual:$wgEnableOpenSearchSuggest read a note that doesn't work properly without further extensions? Frustrating! [19:33:04] (03CR) 10Paladox: "file = images" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [19:34:16] (03PS5) 10Brion VIBBER: Work in progress: ogv.js media player for Safari/IE (1 of 3) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165477 (https://bugzilla.wikimedia.org/61823) [19:34:45] (03CR) 10Brion VIBBER: "Fixes pause regression introduced in the last update which made playback in background tabs work." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165477 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER) [19:34:53] (03PS11) 10Brion VIBBER: Work in progress: ogv.js media player for Safari/IE (2 of 3) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165478 (https://bugzilla.wikimedia.org/61823) [19:37:28] (03PS12) 10Brion VIBBER: Work in progress: ogv.js media player for Safari/IE (2 of 3) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165478 (https://bugzilla.wikimedia.org/61823) [19:38:07] (03CR) 10Brion VIBBER: "Fixed pause, and moved the ogv.js version cachebuster key to the parent commit to make these updates a little more atomic/clear. :)" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165478 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER) [19:38:16] (03PS11) 10Brion VIBBER: Work in progress: ogv.js media player for Safari/IE (3 of 3) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165479 (https://bugzilla.wikimedia.org/61823) [19:42:22] \o\ O_O /o/ WOIOOOOO [19:44:49] Krinkle: FYI: https://gerrit.wikimedia.org/r/162229 [19:45:45] 3MediaWiki / 3Search: Search: Ignore namespace prefix and truncate left - 10https://bugzilla.wikimedia.org/71977#c5 (10Subfader) Sorry, thought this bug is about a related problem I have: Only some characters show proper results. "ri" returns nothing for example. [19:58:48] (03PS12) 10Paladox: Update jquery.ui Vector theme to 1.9.2 [skins/Vector] - 10https://gerrit.wikimedia.org/r/154024 [19:59:15] 3MediaWiki extensions / 3ConfirmEdit (CAPTCHA extension): ConfirmEdit does not work with QuestyCaptcha - 10https://bugzilla.wikimedia.org/71984#c3 (10Andre Klapper) (In reply to bluelupo from comment #2) > ConfirmEdit: no need to show captcha. > > What can I do that the CAPTCHA is working again? Have you a... [19:59:47] 3MediaWiki extensions / 3AbuseFilter: Argument 1 passed to AbuseFilter::contentToString() must implement interface Content - 10https://bugzilla.wikimedia.org/71545#c1 (10Marius Hoch) a:5Wikidata bugs>3None This actually is an AbuseFilter bug where AbuseFilter chokes on Revision::getContent returning null [20:00:45] (03CR) 10Krinkle: Introduce: mw.Api.newFor (031 comment) [core] - 10https://gerrit.wikimedia.org/r/162229 (owner: 10Hoo man) [20:01:01] (03PS5) 10Krinkle: mediawiki.api: Introduce mw.Api.newFor [core] - 10https://gerrit.wikimedia.org/r/162229 (owner: 10Hoo man) [20:01:45] 3MediaWiki extensions / 3Translate: JavascriptFFS shouldn't be building JSON manually - 10https://bugzilla.wikimedia.org/31331#c13 (10Alisha Jain) (In reply to Nemo from comment #12) > From #mediawiki > > 2014-10-12 19.57 < Nemo_bis> The bug is about using standard functions to > reduce mistakes in JSON pro... [20:06:31] 3MediaWiki extensions / 3Translate: JavascriptFFS shouldn't be building JSON manually - 10https://bugzilla.wikimedia.org/31331#c14 (10Nemo) (In reply to Alisha Jain from comment #13) > It will be very helpful if you can give an example of the data being entered > and the corresponding output. I'm not sure t... [20:07:53] (03PS1) 10Hoo man: Check for Revision::getContent returning null [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/166510 (https://bugzilla.wikimedia.org/71545) [20:24:00] 3Wikimedia / 3General/Unknown: Graph User::pingLimiter() actions in gdash - 10https://bugzilla.wikimedia.org/65478#c4 (10Nemo) Hmpf. https://graphite.wikimedia.org/render/?title=PingLimiter&from=-8hours&width=1024&height=500&until=now&areaMode=none&hideLegend=false&logBase=10&lineWidth=1&lineMode=connected&t... [20:28:56] (03CR) 10Krinkle: Allow disabling of legacy gadgets (Mobile support) (031 comment) [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/60954 (https://bugzilla.wikimedia.org/44918) (owner: 10MaxSem) [20:30:10] (03PS2) 10Krinkle: Add $wgGadgetsEnableLegacyGadgets to allow disabling of legacy gadgets [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/166363 (owner: 10Legoktm) [20:36:28] (03CR) 10Fomafix: [C: 04-1] "The name of the directories are usually in plural so use" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [20:37:45] 3MediaWiki-Vagrant: The luasandbox extension is not present, this engine cannot be used. - 10https://bugzilla.wikimedia.org/71901#c8 (10Gilles Dubuc) I have confirmation that despite puppet being asked to install php-luasandbox and hhvm-luasandbox and having them required as dependencies, running a mwscript co... [20:42:01] 3MediaWiki-Vagrant: The luasandbox extension is not present, this engine cannot be used. - 10https://bugzilla.wikimedia.org/71901#c9 (10Gilles Dubuc) I've also noticed that the php-luasandbox has a dirty uninstall. Purging it with puppet leaves the .ini files behind while unlinking the .so library, making PHP... [20:47:17] (03CR) 10Krinkle: [C: 04-1] "I didn't notice 192d37b19a4 going in last year. Things just being disabled like that is rather strange to the user and we should gather da" [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/166363 (owner: 10Legoktm) [20:48:30] 3MediaWiki-Vagrant: The luasandbox extension is not present, this engine cannot be used. - 10https://bugzilla.wikimedia.org/71901#c10 (10Gilles Dubuc) It would be great if people who've been working on php-luasandbox (Ori? Brad?) can shed some light about how it's packaged, and specifically what might be going... [20:53:20] (03CR) 10Gilles: "I suspect that the first two bugs have the same cause, but as you'll see on the first one's bugzilla entry, I've reached my investigation " [vagrant] - 10https://gerrit.wikimedia.org/r/165710 (owner: 10Gilles) [20:55:16] 3MediaWiki-Vagrant: The luasandbox extension is not present, this engine cannot be used. - 10https://bugzilla.wikimedia.org/71901#c11 (10Giuseppe Lavagetto) If vagrant is using hhvm, you need hhvm to be restarted, not apache. I don't think this has anything to do with the packaging. [21:19:57] (03PS50) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [21:20:13] (03PS51) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [21:20:37] (03PS52) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [21:21:00] (03CR) 10Paladox: [C: 031] "I have renamed the folder to components. please review again." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [21:21:11] wow, he must be generating like half of all the bugmail i get [21:21:15] and i get lots of bugmail [21:23:00] (03PS30) 10Paladox: Update jQuery Cookie to v1.4.1 [core] - 10https://gerrit.wikimedia.org/r/139686 [21:23:00] 3MediaWiki-Vagrant: The luasandbox extension is not present, this engine cannot be used. - 10https://bugzilla.wikimedia.org/71901#c12 (10dan) how do you restart hhvm? i tried adding the following to the scribunto role, but it didn’t work: notify => Service['apache2, hhvm'] [21:51:30] 3MediaWiki extensions / 3Scribunto: mwscript importDump.php fails to properly import some valid xml exports - 10https://bugzilla.wikimedia.org/71354#c11 (10Gilles Dubuc) I've managed to track down the crash, it's coming from the first clock_gettime in timer.c of luasandbox being called (I can't tell which cl... [21:51:49] (03CR) 10Cacycle: [C: 032 V: 032] "Thanks." [extensions/WikEdDiff] - 10https://gerrit.wikimedia.org/r/166287 (owner: 10Raimond Spekking) [21:53:18] 3MediaWiki extensions / 3Scribunto: mwscript importDump.php fails to properly import some valid xml exports - 10https://bugzilla.wikimedia.org/71354#c12 (10Gilles Dubuc) Repro steps would be to import a template that needs the luasandbox via "mwscript importDump.php" inside puppet. [21:57:45] 3MediaWiki extensions / 3Scribunto: mwscript importDump.php fails to properly import some valid xml exports - 10https://bugzilla.wikimedia.org/71354#c13 (10Gilles Dubuc) The strace of a crash: https://phabricator.wikimedia.org/P14 I guess the one value that helps narrow down which clock_gettime is the culpr... [21:58:21] (03CR) 10Gilles: "Alright, tracking down the segfault took all my time tonight, I'll look into templatedata tomorrow." [vagrant] - 10https://gerrit.wikimedia.org/r/165710 (owner: 10Gilles) [22:02:30] 3MediaWiki / 3General/Unknown: Implement autocompletion/search suggestion throughout MediaWiki (tracking) - 10https://bugzilla.wikimedia.org/48240#c5 (10Alex Monk) See also Gerrit change 166039, Gerrit change 166045, Gerrit change 166041, Gerrit change 166048 [22:13:28] (03CR) 10Legoktm: [C: 032] "Lets do this! Overall this is great, and any issues that are found should can be handled in follow ups." [core] - 10https://gerrit.wikimedia.org/r/160798 (https://bugzilla.wikimedia.org/30936) (owner: 10Anomie) [22:14:59] (03PS4) 10Legoktm: API: Make jsonfm the default output format [core] - 10https://gerrit.wikimedia.org/r/160819 (owner: 10Anomie) [22:15:45] (03CR) 10Legoktm: [C: 032] "Because https://commons.wikimedia.org/wiki/File:Use_JSON_server_kitty.jpg" [core] - 10https://gerrit.wikimedia.org/r/160819 (owner: 10Anomie) [22:19:49] (03Merged) 10jenkins-bot: API: HTMLize and internationalize the help, add Special:ApiHelp [core] - 10https://gerrit.wikimedia.org/r/160798 (https://bugzilla.wikimedia.org/30936) (owner: 10Anomie) [22:19:52] (03CR) 10Legoktm: [C: 032] Update for core API changes [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/160800 (owner: 10Anomie) [22:20:43] legoktm, <3 [22:22:12] (03Merged) 10jenkins-bot: API: Make jsonfm the default output format [core] - 10https://gerrit.wikimedia.org/r/160819 (owner: 10Anomie) [22:22:23] (03Merged) 10jenkins-bot: Update for core API changes [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/160800 (owner: 10Anomie) [22:27:11] (03CR) 10GOIII: [C: 031] WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [22:28:25] (03PS7) 10Legoktm: API: Add "batchcomplete" to simplified continuation result [core] - 10https://gerrit.wikimedia.org/r/152359 (owner: 10Anomie) [22:28:46] (03CR) 10Legoktm: [C: 032] "PS7: Rebase for release notes" [core] - 10https://gerrit.wikimedia.org/r/152359 (owner: 10Anomie) [22:31:00] 3MediaWiki / 3API: Allow other modules add their sub modules into ApiParamInfo - 10https://bugzilla.wikimedia.org/30936 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX [22:31:32] 3MediaWiki / 3API: API: Help screen not consistently shown on html formats - 10https://bugzilla.wikimedia.org/38126 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3Brad Jorsch [22:31:46] 3MediaWiki / 3API: warning about uselang parameter should be more correct - 10https://bugzilla.wikimedia.org/42343 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3Brad Jorsch [22:32:00] 3MediaWiki / 3API: It should be possible to specify that APIs are internal and shouldn't be documented in api.php's output - 10https://bugzilla.wikimedia.org/62905 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX [22:32:01] 3MediaWiki / 3API: Add ModuleManager support to action=paraminfo (deprecate querymodules) - 10https://bugzilla.wikimedia.org/45641 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3Brad Jorsch [22:32:08] Special:ApiHelp is merged in? [22:32:29] Carmela: yup! [22:32:31] 3MediaWiki / 3API: Add anchors to MediaWiki Web API help output - 10https://bugzilla.wikimedia.org/63211 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:5Kishan Thobhani (kishanio)>3Brad Jorsch [22:32:34] Interesting. [22:32:40] I haven't seen it yet. [22:32:45] http://en.wikipedia.beta.wmflabs.org/wiki/Special:ApiHelp [22:33:06] I guess beta hasn't updated yet [22:33:17] Where is mww beta? [22:33:19] http://mediawiki.beta.wmflabs.org/wiki/Special:ApiHelp [22:33:24] http://www.mediawiki.beta.wmflabs.org/wiki/Special:ApiHelp [22:33:30] (03CR) 10Dan-nl: "thanks for investigating this gilles!" [vagrant] - 10https://gerrit.wikimedia.org/r/165710 (owner: 10Gilles) [22:33:49] Why would it matter [22:34:01] (03PS1) 10Ori.livneh: Update nofile limit for HHVM to 65536 [vagrant] - 10https://gerrit.wikimedia.org/r/166515 [22:34:09] Consistency is nice. [22:34:22] does not exist according to http://en.wikipedia.beta.wmflabs.org/wiki/Special:SiteMatrix#mw-sitematrix-others [22:34:51] lolwut, we have a private wiki in deployment-prep? [22:35:23] (03Merged) 10jenkins-bot: API: Add "batchcomplete" to simplified continuation result [core] - 10https://gerrit.wikimedia.org/r/152359 (owner: 10Anomie) [22:36:52] (03CR) 10Ori.livneh: [C: 032] Update nofile limit for HHVM to 65536 [vagrant] - 10https://gerrit.wikimedia.org/r/166515 (owner: 10Ori.livneh) [22:36:57] (03Merged) 10jenkins-bot: Update nofile limit for HHVM to 65536 [vagrant] - 10https://gerrit.wikimedia.org/r/166515 (owner: 10Ori.livneh) [22:47:56] Carmela: the change is now on beta [22:48:12] http://en.wikipedia.beta.wmflabs.org/w/api.php?action=help&modules=main [22:48:26] Can't honestly tell whether it's broken. [22:48:31] It is supposed to be skinless? [22:48:38] yes [22:48:42] All right. [22:49:22] It's interesting to see it using a feature I think I added years ago [22:49:25] So how do I get to the main API page? [22:49:36] which main page? [22:49:45] Like the full output. [22:49:49] The old one? [22:49:52] Special:ApiHelp --> api.php [22:49:53] Yeah. [22:49:57] Is that deprecated? [22:49:57] http://en.wikipedia.beta.wmflabs.org/w/api.php?action=help&recursivesubmodules=1 [22:50:03] Reedy: This change https://gerrit.wikimedia.org/r/#/c/165667/ in combination with the current settings in labs effectivly disables MathJax https://gerrit.wikimedia.org/r/#/c/166410/ solves the problem... If you have no time right now please let me know... I'll create a bug in that case [22:50:07] Oh, there it is. [22:50:14] "All help in one page" [22:50:45] Interesting. [22:51:18] I like this. But I'm really wondering why not just wrap it in the MediaWiki chrome at this point. [22:54:41] anomie says there's code dependency stuff that'll make it complicated [22:54:53] like skins assume index.php, but this'll run on api.php [22:56:49] You could fake it. [22:57:38] hi, I'm here [22:58:00] Hello. [22:58:05] I said you could fake it. [22:58:10] I don't think it's unsolvable, in any case. [22:58:44] I don't either. [22:58:52] File a bug? :) [23:02:33] 3MediaWiki / 3API: Consider wrapping updated API help output in MediaWiki chrome - 10https://bugzilla.wikimedia.org/72008 (10MZMcBride) 3UNCO p:3Unprio s:3normal a:3None http://en.wikipedia.beta.wmflabs.org/w/api.php?action=help&modules=main The updated API help looks wonderful. But it now feels a b... [23:04:15] Is Special:ApiHelp the main entry point now? [23:04:20] Does it take subpages or anything? [23:04:37] I'm worried about the discoverability of the query module from Special:ApiHelp. [23:05:59] (03CR) 10Legoktm: API: Clean up and internationalize pretty-printed output (033 comments) [core] - 10https://gerrit.wikimedia.org/r/161093 (https://bugzilla.wikimedia.org/65403) (owner: 10Anomie) [23:06:33] en.wikipedia.beta.wmflabs.org/wiki/Special:ApiHelp/query [23:06:50] http://en.wikipedia.beta.wmflabs.org/w/api.php?action=help&modules=query&recursivesubmodules=1 [23:07:12] also you can transclude ApiHelp [23:09:22] (03CR) 10Legoktm: [C: 04-1] Implement 'ApiFormatHighlight' hook (032 comments) [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/161463 (owner: 10Anomie) [23:12:15] 3Wikimedia / 3General/Unknown: Move code in enwiki MediaWiki:Common.js and Gadgets to MediaWiki software - 10https://bugzilla.wikimedia.org/69550 (10Helder) [23:12:16] 3MediaWiki / 3JavaScript: jQuery.makeCollapsible.js should support 'autocollapse', 'innercollapse' and 'outercollapse' options - 10https://bugzilla.wikimedia.org/30352 (10Helder) [23:14:31] (03CR) 10Anomie: API: Clean up and internationalize pretty-printed output (033 comments) [core] - 10https://gerrit.wikimedia.org/r/161093 (https://bugzilla.wikimedia.org/65403) (owner: 10Anomie) [23:17:29] (03PS9) 10Anomie: API: Clean up and internationalize pretty-printed output [core] - 10https://gerrit.wikimedia.org/r/161093 (https://bugzilla.wikimedia.org/65403) [23:17:53] (03PS10) 10Anomie: API: Clean up and internationalize pretty-printed output [core] - 10https://gerrit.wikimedia.org/r/161093 (https://bugzilla.wikimedia.org/65403) [23:18:29] legoktm, we going to use that to replace some mediawikiwiki pages then? [23:18:39] yeah [23:18:46] that keep getting outdated [23:19:42] how dare we improve stuff [23:20:44] legoktm: Nice. [23:22:48] (03CR) 10Anomie: Implement 'ApiFormatHighlight' hook (031 comment) [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/161463 (owner: 10Anomie) [23:23:07] (03PS2) 10Anomie: Implement 'ApiFormatHighlight' hook [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/161463 [23:24:12] (03CR) 10Legoktm: [C: 032] Implement 'ApiFormatHighlight' hook [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/161463 (owner: 10Anomie) [23:24:14] (03Merged) 10jenkins-bot: Implement 'ApiFormatHighlight' hook [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/161463 (owner: 10Anomie) [23:33:04] (03CR) 10Legoktm: [C: 032] API: Clean up and internationalize pretty-printed output [core] - 10https://gerrit.wikimedia.org/r/161093 (https://bugzilla.wikimedia.org/65403) (owner: 10Anomie) [23:36:15] 3MediaWiki extensions / 3Scribunto: mwscript importDump.php fails to properly import some valid xml exports - 10https://bugzilla.wikimedia.org/71354#c14 (10Brad Jorsch) (In reply to Gilles Dubuc from comment #12) > Repro steps would be to import a template that needs the luasandbox via > "mwscript importDump... [23:36:36] (03PS1) 10Legoktm: Check $wgUseSiteCss inside ResourceLoaderGeSHiLocalModule [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/166517 [23:39:11] (03Merged) 10jenkins-bot: API: Clean up and internationalize pretty-printed output [core] - 10https://gerrit.wikimedia.org/r/161093 (https://bugzilla.wikimedia.org/65403) (owner: 10Anomie) [23:48:06] (03CR) 10Anomie: [C: 04-1] [WIP] Fully replace Title::moveTo() with MovePage (031 comment) [core] - 10https://gerrit.wikimedia.org/r/166175 (owner: 10Legoktm) [23:49:30] 3MediaWiki / 3API: API generates invalid HTML for format=jsonfm - 10https://bugzilla.wikimedia.org/65403#c6 (10Brad Jorsch) 5PATC>3RESO/FIX Should be deployed to WMF wikis with 1.25wmf4, see https://www.mediawiki.org/wiki/MediaWiki_1.25/Roadmap for the schedule. [23:51:55] (03PS4) 10Legoktm: Add LocalRenameUserJob::promoteToGlobal() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/165097 [23:52:10] (03CR) 10Legoktm: Add LocalRenameUserJob::promoteToGlobal() (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/165097 (owner: 10Legoktm)