[00:00:40] ragesoss: Yeah, unfortunately we don't have a good way to edit those attributes, so really best to just submit a new one with the correct info [00:06:13] (03Merged) 10jenkins-bot: Log non-MediaWiki exceptions for requests via main entry point [core] - 10https://gerrit.wikimedia.org/r/164976 (https://bugzilla.wikimedia.org/61914) (owner: 10Aude) [00:13:02] (03CR) 10Krinkle: [C: 04-1] mediawiki.searchSuggest: Pass search namespace preferences to API [core] - 10https://gerrit.wikimedia.org/r/164893 (https://bugzilla.wikimedia.org/24214) (owner: 10saper) [00:14:39] (03CR) 10Krinkle: [C: 04-1] Check HTML in Exif (031 comment) [core] - 10https://gerrit.wikimedia.org/r/164726 (https://bugzilla.wikimedia.org/25163) (owner: 10Tuxilina) [00:15:36] csteipp: cool, thanks! [00:16:07] (03PS3) 10Krinkle: upload: Ensure there is no HTML in the Exif data [core] - 10https://gerrit.wikimedia.org/r/164726 (https://bugzilla.wikimedia.org/25163) (owner: 10Tuxilina) [00:22:51] (03PS4) 10Krinkle: upload: Use specific warning for HTML in the Exif (instead of generic) [core] - 10https://gerrit.wikimedia.org/r/164726 (https://bugzilla.wikimedia.org/25163) (owner: 10Tuxilina) [00:23:29] (03CR) 10Krinkle: "Clarified commit message to indicate that this is not a new check (and thus not related to security). It merely re-checks the thing again " [core] - 10https://gerrit.wikimedia.org/r/164726 (https://bugzilla.wikimedia.org/25163) (owner: 10Tuxilina) [00:24:20] (03CR) 10Krinkle: "Note to reviewers, https://www.mediawiki.org/wiki/Remove_Exif_tags is currently under review. Ensure that page is in good condition before" [core] - 10https://gerrit.wikimedia.org/r/164726 (https://bugzilla.wikimedia.org/25163) (owner: 10Tuxilina) [00:24:43] (03CR) 10Krinkle: [C: 032] SpecialWhatlinkshere: Add autocompletion for target input [core] - 10https://gerrit.wikimedia.org/r/132913 (https://bugzilla.wikimedia.org/65209) (owner: 10Gerrit Patch Uploader) [00:26:00] Nemo_bis: Re: https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Pageinfo-recent-edits # Dunno. [00:26:59] 3MediaWiki extensions / 3WikidataRepo: Invalid operand type in MergeItems.php on line 227 - 10https://bugzilla.wikimedia.org/71469 (10Aude) 5PATC>3RESO/FIX [00:29:08] ori, have you ever gotten an EXT4 error that blocked the MWV VirtualBox machine from booting? I've had it multiple times now: [00:29:10] http://i.imgur.com/6AKP31c.png [00:29:20] Probably not a MWV issue per se, but I thought you might have some insight. [00:29:26] never seen it before :/ [00:29:59] It could be drive corruption on the host, but I don't think so since I haven't seen any other symptoms. [00:30:15] And I don't even know if it would get that far if the guest image was seriously corrupted. [00:31:41] (03Merged) 10jenkins-bot: SpecialWhatlinkshere: Add autocompletion for target input [core] - 10https://gerrit.wikimedia.org/r/132913 (https://bugzilla.wikimedia.org/65209) (owner: 10Gerrit Patch Uploader) [00:31:44] (03PS1) 10Kaldari: Updating style documentation for quiet anchors and quiet buttons [core] - 10https://gerrit.wikimedia.org/r/165147 [00:39:00] (03CR) 10Jaredzimmerman: [C: 031] Updating style documentation for quiet anchors and quiet buttons [core] - 10https://gerrit.wikimedia.org/r/165147 (owner: 10Kaldari) [00:39:32] ori, it is recoverable by running fsck.ext4 from a LiveCD. [00:39:53] oh, nice [00:40:42] Yeah, but still annoying obviously. [00:40:56] And you can use an ISO rather than a real CD, as you'd expect. [00:41:14] I used systemrescuecd-x86-4.3.0.iso in this case. [00:42:01] 3Wikimedia / 3General/Unknown: Move https://noc.wikimedia.org/conf/ to a wiki page on wikitech.wikimedia.org - 10https://bugzilla.wikimedia.org/71723 (10MZMcBride) 3NEW p:3Unprio s:3normal a:3None Prior to Git and Puppet and other niceties, https://noc.wikimedia.org/conf/ served a more important purp... [00:44:16] (03PS2) 10Legoktm: Stop using $wgUser in ResourceLoader modules [core] - 10https://gerrit.wikimedia.org/r/164724 [00:44:46] 3MediaWiki extensions / 3WikidataRepo: Crash while serializing Wikibase\DataModel\ReferenceList - 10https://bugzilla.wikimedia.org/71724 (10Tim Starling) 3NEW p:3Unprio s:3normal a:3Wikidata bugs A core dump was collected showing a crash SplObjectStorage::serialize() while serializing a Wikibase\Data... [01:01:21] (03PS1) 10Aude: Update Wikidata, fixes for serialization issues [core] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/165153 [01:02:43] (03CR) 10Ori.livneh: [C: 032] Update Wikidata, fixes for serialization issues [core] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/165153 (owner: 10Aude) [01:02:53] (03PS1) 10Aude: Update Wikidata, fixes for serialization issues [core] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/165155 [01:03:21] (03CR) 10Ori.livneh: [C: 032] Update Wikidata, fixes for serialization issues [core] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/165155 (owner: 10Aude) [01:09:11] (03Merged) 10jenkins-bot: Update Wikidata, fixes for serialization issues [core] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/165153 (owner: 10Aude) [01:10:05] (03Merged) 10jenkins-bot: Update Wikidata, fixes for serialization issues [core] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/165155 (owner: 10Aude) [01:24:13] 3MediaWiki extensions / 3WikidataRepo: Argument 1 passed to Wikibase\Repo\Diff\ClaimDifferenceVisualizer::getSnakListValues() must be an instance of Wikibase\DataModel\Snak\SnakList, string given - 10https://bugzilla.wikimedia.org/71536#c2 (10Aude) this is still occurring.... [01:33:01] (03PS3) 10Krinkle: resourceloader: Add ResourceLoaderContext::getUserObj and replace use of $wgUser [core] - 10https://gerrit.wikimedia.org/r/164724 (owner: 10Legoktm) [01:33:18] (03CR) 10Krinkle: resourceloader: Add ResourceLoaderContext::getUserObj and replace use of $wgUser (031 comment) [core] - 10https://gerrit.wikimedia.org/r/164724 (owner: 10Legoktm) [01:36:59] (03PS2) 10BryanDavis: Change command line api for role management [vagrant] - 10https://gerrit.wikimedia.org/r/164899 [01:37:19] (03CR) 10BryanDavis: Change command line api for role management (033 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/164899 (owner: 10BryanDavis) [01:37:57] (03PS2) 10BryanDavis: Reorganize vagrant roles commands [vagrant] - 10https://gerrit.wikimedia.org/r/164900 [01:38:22] (03PS2) 10BryanDavis: Add `vagrant role info` command [vagrant] - 10https://gerrit.wikimedia.org/r/164901 [02:01:07] (03CR) 10Technical 13: "But the difference is just in how the parser renders the signature, not how readers or editors see the signature in the edit box. So, it " [core] - 10https://gerrit.wikimedia.org/r/130094 (https://bugzilla.wikimedia.org/25141) (owner: 10Gerrit Patch Uploader) [02:33:12] (03CR) 10Jforrester: [C: 031] PrefixSearch: Add unit tests for StringPrefixSearch [core] - 10https://gerrit.wikimedia.org/r/162190 (owner: 10Krinkle) [02:38:13] (03PS1) 10Mattflaschen: MW UI: Improve IE 6 support for anchors, text and buttons [core] - 10https://gerrit.wikimedia.org/r/165161 [02:38:51] (03CR) 10Mattflaschen: "IE 6 follow-up is https://gerrit.wikimedia.org/r/#/c/165161/ . Please review." [core] - 10https://gerrit.wikimedia.org/r/155856 (https://bugzilla.wikimedia.org/69212) (owner: 10SG) [02:39:40] (03Abandoned) 10Mattflaschen: WIP: Fix rendering problems with mw-ui-anchor and mw-ui-text in IE 6 [core] - 10https://gerrit.wikimedia.org/r/164276 (owner: 10Mattflaschen) [02:53:31] (03PS1) 10Mattflaschen: MW UI: Show all permutations of checkboxes in Living Style Guide [core] - 10https://gerrit.wikimedia.org/r/165163 [02:54:20] (03CR) 10Ishegatron: [C: 032 V: 032] Add initial files [extensions/FixedHeaderTable] - 10https://gerrit.wikimedia.org/r/164686 (owner: 10Ishegatron) [02:54:43] (03PS2) 10Mattflaschen: MW UI: Show all permutations of checkboxes in Living Style Guide [core] - 10https://gerrit.wikimedia.org/r/165163 [03:06:30] 3MediaWiki / 3General/Unknown: HttpRequest: Failing under PHP 5.6 (CURLOPT_CLOSEPOLICY not defined) - 10https://bugzilla.wikimedia.org/71729 (10Krinkle) 3NEW p:3Unprio s:3major a:3None Constants CURLOPT_CLOSEPOLICY, CURLCLOSEPOLICY_LEAST_RECENTLY_USED and others are not defined as they were removed i... [03:13:38] (03PS1) 10Krinkle: UploadBaseTest: Use setMwGlobals() instead of juggling globals [core] - 10https://gerrit.wikimedia.org/r/165164 [03:15:28] 3Wikimedia / 3General/Unknown: Increase "remember me" login cookie expiry from 30 days to 1 year on Wikimedia wikis - 10https://bugzilla.wikimedia.org/66699#c39 (10Matthew Flaschen) (In reply to Kunal Mehta (Legoktm) from comment #38) > Right now we have a bunch of CentralAuth code running on login to try an... [03:15:43] 3Wikimedia / 3Site requests: Complete unification of all accounts to SUL - 10https://bugzilla.wikimedia.org/35707 (10Matthew Flaschen) [03:22:21] (03PS1) 10Krinkle: MWCryptHKDFTest: Mock $wgSecretKey to ensure atomicity [core] - 10https://gerrit.wikimedia.org/r/165165 [03:22:42] (03PS2) 10Krinkle: MWCryptHKDFTest: Mock $wgSecretKey to ensure atomicity [core] - 10https://gerrit.wikimedia.org/r/165165 [03:26:02] (03CR) 10John Vandenberg: "Can this be backported to fix the bug in older versions of MediaWiki?" [core] - 10https://gerrit.wikimedia.org/r/125573 (owner: 10Aaron Schulz) [03:29:28] 3MediaWiki / 3Uploading: Can't upload file with non-ASCII name (eg cyrillic) on Windows host - 10https://bugzilla.wikimedia.org/1780#c45 (10John Mark Vandenberg) 5PATC>3NEW (In reply to Gerrit Notification Bot from comment #40) > Change 125573 abandoned by Aaron Schulz: > Added path encoding to FileBacke... [03:35:58] (03PS7) 10Divec: WIP: Derive MT subsentence map from uppercasing [services/cxserver] - 10https://gerrit.wikimedia.org/r/157141 [03:36:15] 3MediaWiki / 3Uploading: Uploaded file size calculations to compare with upload quota - 10https://bugzilla.wikimedia.org/10976 (10John Mark Vandenberg) [03:39:57] (03CR) 10EBernhardson: [C: 032] Hygiene: Improve FlowActions docs and remove dead code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165129 (owner: 10Mattflaschen) [03:40:41] (03Merged) 10jenkins-bot: Hygiene: Improve FlowActions docs and remove dead code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165129 (owner: 10Mattflaschen) [03:43:13] 3MediaWiki extensions / 3SemanticForms: Error when using Special:RunQuery - "Parser state cleared while parsing" - 10https://bugzilla.wikimedia.org/66202#c3 (10Yaron Koren) Yes, trying to embed Special:RunQuery has led to problems for a while now - and it seems to have gotten worse since MediaWiki 1.24, when... [03:43:22] (03CR) 10EBernhardson: Prevent board-level collapsing classes from being applied on non-board pages like topic view (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165015 (owner: 10SG) [03:44:09] (03CR) 10EBernhardson: [C: 032] WrongComment for getPage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165042 (owner: 10Spage) [03:44:46] (03Merged) 10jenkins-bot: WrongComment for getPage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/165042 (owner: 10Spage) [03:49:14] 3MediaWiki / 3Interface: Implement visual interface for changing the categories a page is in - 10https://bugzilla.wikimedia.org/27312 (10John Mark Vandenberg) [03:49:15] 3MediaWiki / 3JavaScript: Implement support for case-insensitive prefix search in mediawiki.api.getCategoriesByPrefix - 10https://bugzilla.wikimedia.org/38785 (10John Mark Vandenberg) [03:49:58] 3MediaWiki / 3Interface: Implement visual interface for changing the categories a page is in - 10https://bugzilla.wikimedia.org/27312 (10John Mark Vandenberg) [03:50:43] 3MediaWiki / 3Uploading: Allow to add categories from a dropdown in Special:Upload - 10https://bugzilla.wikimedia.org/5234#c13 (10John Mark Vandenberg) UploadWizard allows licenses and categorisation. https://www.mediawiki.org/wiki/Extension:UploadWizard HotCat can categorise files on upload https://en.wi... [03:58:01] (03CR) 10EBernhardson: "In addition to the comments, something I just noticed today looking through logs and noticed again in your commit summary, The UUID is ca" (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163589 (https://bugzilla.wikimedia.org/71377) (owner: 10Matthias Mullie) [04:07:39] (03PS2) 10EBernhardson: [WIP] Clean up samples [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163962 (owner: 10Krinkle) [04:21:57] (03CR) 10EBernhardson: "these look quite usefull, thanks for the review. I'll poke SG to look at this." (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163962 (owner: 10Krinkle) [04:30:09] (03Abandoned) 10Yurik: Recursive git-update [vagrant] - 10https://gerrit.wikimedia.org/r/163293 (owner: 10Yurik) [04:30:59] 3Wikimedia / 3Site requests: Complete unification of all accounts to SUL - 10https://bugzilla.wikimedia.org/35707 (10johnnymrninja) [04:30:59] 3MediaWiki extensions / 3CentralAuth: Cross-wiki watchlists - 10https://bugzilla.wikimedia.org/3525 (10johnnymrninja) [04:34:15] (03CR) 10Yurik: "Yes, I know that magic cookie script. But most of the time, it is more convenient to add a debug=1 on any page you are looking at, at any " [core] - 10https://gerrit.wikimedia.org/r/161878 (owner: 10Yurik) [04:38:28] 3MediaWiki extensions / 3CentralAuth: Cross-wiki watchlists - 10https://bugzilla.wikimedia.org/3525 (10Kunal Mehta (Legoktm)) [04:38:29] 3Wikimedia / 3Site requests: Complete unification of all accounts to SUL - 10https://bugzilla.wikimedia.org/35707 (10Kunal Mehta (Legoktm)) [04:40:00] 3Wikimedia / 3General/Unknown: Wikimedia Error on zh.wikivoyage/德國 - 10https://bugzilla.wikimedia.org/71734 (10zhuyifei1999) 3NEW p:3Unprio s:3critic a:3None Request: GET http://zh.wikivoyage.org/wiki/%E5%BE%B7%E5%9C%8B, from 10.64.0.103 via cp1054 cp1054 ([10.64.32.106]:3128), Varnish XID 2664191004... [04:43:01] * legoktm grumbles [04:43:13] 3Wikimedia / 3Site requests: Complete unification of all accounts to SUL - 10https://bugzilla.wikimedia.org/35707 (10Kunal Mehta (Legoktm)) [04:49:40] (03PS2) 10Legoktm: Global user rights API [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/164055 (https://bugzilla.wikimedia.org/71495) (owner: 10Alex Monk) [04:52:22] (03CR) 10Legoktm: [C: 032] "PS2: Rebase for new directory layout" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/164055 (https://bugzilla.wikimedia.org/71495) (owner: 10Alex Monk) [04:53:11] (03Merged) 10jenkins-bot: Global user rights API [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/164055 (https://bugzilla.wikimedia.org/71495) (owner: 10Alex Monk) [04:57:28] 3MediaWiki extensions / 3CentralAuth: Create an API module to edit a user's global group membership - 10https://bugzilla.wikimedia.org/71495#c5 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX Will go out with 1.25wmf3, and on Meta by Oct 14. [05:32:31] (03PS1) 10Tim Starling: HashBagOStuff: use the value itself as the CAS token [core] - 10https://gerrit.wikimedia.org/r/165166 (https://bugzilla.wikimedia.org/71724) [05:33:28] 3MediaWiki extensions / 3AbuseFilter: Blocks from AbuseFilter show up as performed from the target's IP address in Checkuser - 10https://bugzilla.wikimedia.org/42345#c8 (10John Mark Vandenberg) status update: two of the patches have been abandoned, but this one is still under review https://gerrit.wikimedia... [05:39:47] (03PS1) 10Tim Starling: [1.25wmf1] HashBagOStuff: use the value itself as the CAS token [core] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/165167 (https://bugzilla.wikimedia.org/71724) [05:39:56] (03PS2) 10Ori.livneh: HashBagOStuff: use the value itself as the CAS token [core] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/165167 (https://bugzilla.wikimedia.org/71724) (owner: 10Tim Starling) [05:40:00] oops [05:40:07] (03CR) 10Ori.livneh: [C: 032] HashBagOStuff: use the value itself as the CAS token [core] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/165167 (https://bugzilla.wikimedia.org/71724) (owner: 10Tim Starling) [05:40:13] (03PS1) 10Tim Starling: [1.25wmf2] HashBagOStuff: use the value itself as the CAS token [core] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/165168 (https://bugzilla.wikimedia.org/71724) [05:40:24] (03CR) 10Ori.livneh: [C: 032] [1.25wmf2] HashBagOStuff: use the value itself as the CAS token [core] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/165168 (https://bugzilla.wikimedia.org/71724) (owner: 10Tim Starling) [05:43:13] 3MediaWiki / 3Uploading: Generate upload log entry when duplicate file uploaded - 10https://bugzilla.wikimedia.org/14417#c3 (10John Mark Vandenberg) Could duplicate file detection be done in AbuseFilter, which would allow logging, and pre-programmed management? It appears it has the sha as a variable. See h... [05:43:13] 3MediaWiki extensions / 3AbuseFilter: Add more variables to AbuseFilter file uploading evaluation - 10https://bugzilla.wikimedia.org/19565 (10John Mark Vandenberg) [05:44:29] (03CR) 10Santhosh: [C: 04-1] WIP: Derive MT subsentence map from uppercasing (032 comments) [services/cxserver] - 10https://gerrit.wikimedia.org/r/157141 (owner: 10Divec) [05:47:29] (03Merged) 10jenkins-bot: HashBagOStuff: use the value itself as the CAS token [core] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/165167 (https://bugzilla.wikimedia.org/71724) (owner: 10Tim Starling) [05:48:22] (03CR) 10EBernhardson: Refactor BufferedCache (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164311 (https://bugzilla.wikimedia.org/71377) (owner: 10Matthias Mullie) [05:48:28] (03CR) 10EBernhardson: Refactor BufferedCache (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164311 (https://bugzilla.wikimedia.org/71377) (owner: 10Matthias Mullie) [05:48:32] (03Merged) 10jenkins-bot: [1.25wmf2] HashBagOStuff: use the value itself as the CAS token [core] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/165168 (https://bugzilla.wikimedia.org/71724) (owner: 10Tim Starling) [05:51:51] (03CR) 10EBernhardson: "To followup, we currently have the problem on this page:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163589 (https://bugzilla.wikimedia.org/71377) (owner: 10Matthias Mullie) [05:54:40] (03CR) 10EBernhardson: Refactor BufferedCache (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164311 (https://bugzilla.wikimedia.org/71377) (owner: 10Matthias Mullie) [06:04:35] (03CR) 10Santhosh: WIP: Derive MT subsentence map from uppercasing (031 comment) [services/cxserver] - 10https://gerrit.wikimedia.org/r/157141 (owner: 10Divec) [06:06:46] (03CR) 10Ori.livneh: [C: 032] HashBagOStuff: use the value itself as the CAS token [core] - 10https://gerrit.wikimedia.org/r/165166 (https://bugzilla.wikimedia.org/71724) (owner: 10Tim Starling) [06:11:28] 3Wikimedia / 3General/Unknown: Wikimedia Error on zh.wikivoyage/德國 - 10https://bugzilla.wikimedia.org/71734#c1 (10zhuyifei1999) 5NEW>3RESO/WOR Seem fixed somehow. [06:12:13] 3MediaWiki extensions / 3WikidataRepo: Crash while serializing Wikibase\DataModel\ReferenceList - 10https://bugzilla.wikimedia.org/71724#c6 (10Ori Livneh) *** Bug 71734 has been marked as a duplicate of this bug. *** [06:12:13] 3Wikimedia / 3General/Unknown: Wikimedia Error on zh.wikivoyage/德國 - 10https://bugzilla.wikimedia.org/71734#c2 (10Ori Livneh) 5RESO/WOR>3RESO/DUP *** This bug has been marked as a duplicate of bug 71724 *** [06:13:16] (03Merged) 10jenkins-bot: HashBagOStuff: use the value itself as the CAS token [core] - 10https://gerrit.wikimedia.org/r/165166 (https://bugzilla.wikimedia.org/71724) (owner: 10Tim Starling) [06:13:43] 3MediaWiki / 3API: Allow &redirect for action=edit - 10https://bugzilla.wikimedia.org/24330#c7 (10John Mark Vandenberg) Did the merged patch resolve all of this bug? [06:16:14] (03PS3) 10John Vandenberg: Make the badprefix behavior less frustrating [core] - 10https://gerrit.wikimedia.org/r/136546 (owner: 10Marco) [06:18:39] (03CR) 10John Vandenberg: [C: 04-1] "The additional condition should be part of the existing if, so that no modification (indentation) is needed to the other lines." [core] - 10https://gerrit.wikimedia.org/r/136546 (owner: 10Marco) [06:22:13] 3MediaWiki / 3API: Make old images searchable by hash - 10https://bugzilla.wikimedia.org/21345#c11 (10John Mark Vandenberg) (In reply to Rainer Rillke @commons.wikimedia from comment #10) > For the time being: > https://tools.wmflabs.org/rillke/jsonapi.php?action=sha1lookup&sha1= @Maarten Dammers, sho... [06:26:57] (03CR) 10Krinkle: "@MZMcBride: For the record, quality can never be the only factor in merging code. I couldn't care less about how well written a feature is" [core] - 10https://gerrit.wikimedia.org/r/92315 (owner: 10Bartosz Dziewoński) [06:32:35] (03PS1) 10MaxSem: Fix mirroring [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/165169 [06:32:58] 3MediaWiki / 3Uploading: No progress after upload warnings - 10https://bugzilla.wikimedia.org/33357#c2 (10John Mark Vandenberg) Is this the same as bug 26214? [06:33:20] (03PS2) 10Tweichart: InsertFile JavaApplet changes [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/164905 [06:38:26] (03CR) 10Bartosz Dziewoński: [C: 032] MWCryptHKDFTest: Mock $wgSecretKey to ensure atomicity [core] - 10https://gerrit.wikimedia.org/r/165165 (owner: 10Krinkle) [06:40:01] (03CR) 10Bartosz Dziewoński: [C: 032] UploadBaseTest: Use setMwGlobals() instead of juggling globals [core] - 10https://gerrit.wikimedia.org/r/165164 (owner: 10Krinkle) [06:40:06] (03PS7) 10Matthias Mullie: Refactor BufferedCache [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164311 (https://bugzilla.wikimedia.org/71377) [06:42:13] (03PS5) 10Tim Starling: hash_equals(): Avoid division by zero when $known_string is empty [core] - 10https://gerrit.wikimedia.org/r/141643 (owner: 10PleaseStand) [06:42:20] (03CR) 10Tim Starling: [C: 032] hash_equals(): Avoid division by zero when $known_string is empty [core] - 10https://gerrit.wikimedia.org/r/141643 (owner: 10PleaseStand) [06:42:30] (03PS8) 10Matthias Mullie: Refactor BufferedCache [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164311 (https://bugzilla.wikimedia.org/71377) [06:42:38] (03CR) 10Matthias Mullie: Refactor BufferedCache (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164311 (https://bugzilla.wikimedia.org/71377) (owner: 10Matthias Mullie) [06:42:56] (03CR) 10Matthias Mullie: Refactor BufferedCache (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164311 (https://bugzilla.wikimedia.org/71377) (owner: 10Matthias Mullie) [06:43:17] (03CR) 10Krinkle: "@EBernhardson: fyi, it's fine to mark the others here in context, but I purposely only applied changes in one or two places (merely to set" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163962 (owner: 10Krinkle) [06:45:10] (03Merged) 10jenkins-bot: MWCryptHKDFTest: Mock $wgSecretKey to ensure atomicity [core] - 10https://gerrit.wikimedia.org/r/165165 (owner: 10Krinkle) [06:45:51] (03CR) 10Bartosz Dziewoński: Updating style documentation for quiet anchors and quiet buttons (031 comment) [core] - 10https://gerrit.wikimedia.org/r/165147 (owner: 10Kaldari) [06:46:14] (03Merged) 10jenkins-bot: UploadBaseTest: Use setMwGlobals() instead of juggling globals [core] - 10https://gerrit.wikimedia.org/r/165164 (owner: 10Krinkle) [06:49:06] (03CR) 10Robert Vogel: [C: 04-1 V: 04-1] Removed use of deprecated method (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/158600 (owner: 10Smuggli) [06:49:23] (03Merged) 10jenkins-bot: hash_equals(): Avoid division by zero when $known_string is empty [core] - 10https://gerrit.wikimedia.org/r/141643 (owner: 10PleaseStand) [06:49:35] (03PS2) 10Bartosz Dziewoński: Updating style documentation for quiet anchors and quiet buttons [core] - 10https://gerrit.wikimedia.org/r/165147 (owner: 10Kaldari) [06:50:00] (03CR) 10Bartosz Dziewoński: [C: 032] "Fixed typo." [core] - 10https://gerrit.wikimedia.org/r/165147 (owner: 10Kaldari) [06:53:44] (03CR) 10Wctaiwan: "This is used in Thanks and MassMessage, both extensions deployed to WMF wikis. In the case of the former, it is vastly superior to the mod" [core] - 10https://gerrit.wikimedia.org/r/92315 (owner: 10Bartosz Dziewoński) [06:55:59] 3Wikimedia / 3Wikidata: Wikimedia Error page on the item for Germany (Q183) - 10https://bugzilla.wikimedia.org/71519 (10Nemo) [06:55:59] 3MediaWiki extensions / 3WikidataRepo: cannot save badges on Q183 (Germany) - 10https://bugzilla.wikimedia.org/70716 (10Nemo) [06:57:50] (03Merged) 10jenkins-bot: Updating style documentation for quiet anchors and quiet buttons [core] - 10https://gerrit.wikimedia.org/r/165147 (owner: 10Kaldari) [06:57:58] 3Wikimedia / 3Wikidata: Wikimedia Error page on the item for Germany (Q183) - 10https://bugzilla.wikimedia.org/71519#c17 (10Nemo) Cf. https://www.wikidata.org/w/index.php?title=Wikidata:Project_chat&oldid=162432153#Temporary_protection_of_Q183_.28Germany.29 [07:02:17] 3MediaWiki / 3API: Result of chunk upload with warning omits offset - 10https://bugzilla.wikimedia.org/71737 (10John Mark Vandenberg) 3NEW p:3Unprio s:3normal a:3None If a chunked upload causes a warning on the first chunk (e.g. 'exists': File x already exists), the API result does not include an off... [07:02:19] (03PS1) 10MaxSem: WIP: rotation [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/165170 [07:12:56] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Needs rebase." [core] - 10https://gerrit.wikimedia.org/r/165163 (owner: 10Mattflaschen) [07:14:28] 3MediaWiki / 3User login and signup: $wgSecureLogin does not redirect to http if wpStickHTTPS is unchecked - 10https://bugzilla.wikimedia.org/40541 (10Nemo) [07:15:21] 3MediaWiki / 3User login and signup: If coming from a non-secure website to a secured login, if force ssl is not enabled, it should return to the non-secure website. - 10https://bugzilla.wikimedia.org/71716#c4 (10Nemo) This is bug 40541 once again. What version of MediaWiki are you running? We had problems g... [07:19:12] (03PS3) 10Bartosz Dziewoński: MW UI: Show all permutations of checkboxes in Living Style Guide [core] - 10https://gerrit.wikimedia.org/r/165163 (owner: 10Mattflaschen) [07:19:30] (03CR) 10Bartosz Dziewoński: [C: 032] MW UI: Show all permutations of checkboxes in Living Style Guide [core] - 10https://gerrit.wikimedia.org/r/165163 (owner: 10Mattflaschen) [07:26:26] (03Merged) 10jenkins-bot: MW UI: Show all permutations of checkboxes in Living Style Guide [core] - 10https://gerrit.wikimedia.org/r/165163 (owner: 10Mattflaschen) [07:30:16] (03CR) 10Krinkle: "fixme: Document or fixup: What is $modifiers supposed to be? Array with attributes? (e.g. disabled => true, value => x, class => y) or arr" [core] - 10https://gerrit.wikimedia.org/r/163775 (owner: 10Jdlrobson) [07:37:49] (03PS2) 10Krinkle: Remove dir=auto from firstHeading [core] - 10https://gerrit.wikimedia.org/r/164735 (owner: 10Amire80) [07:38:30] (03CR) 10Krinkle: [C: 04-1] "Please be more specific in the commit message. This is not helpful. I want to be able to tell someone who proposed to add this back in a f" [core] - 10https://gerrit.wikimedia.org/r/164735 (owner: 10Amire80) [07:45:13] 3MediaWiki / 3JavaScript: mediawiki.api: Implement support for case-insensitive prefix search in getCategoriesByPrefix() - 10https://bugzilla.wikimedia.org/38785 (10Krinkle) s:5normal>3enhanc [07:49:58] 3MediaWiki / 3User preferences: User specified CSS loads on Special:Preferences / Special:UserLogin - 10https://bugzilla.wikimedia.org/70672#c25 (10[[kgh]]) This is indeed a big problem for wikis which use on-wiki custom skinning. Besides this indeed rather the regular case than a rare one. Now with some day... [07:50:43] 3Wikimedia / 3General/Unknown: Move https://noc.wikimedia.org/conf/ to a wiki page on wikitech.wikimedia.org - 10https://bugzilla.wikimedia.org/71723#c1 (10Krinkle) The main thing conf/ provides (or any dynamically created overview) is listing all files in a directory. You'd have to manually keep it in sync.... [07:50:58] 3Wikimedia / 3General/Unknown: Move https://noc.wikimedia.org/conf/ to a wiki page on wikitech.wikimedia.org - 10https://bugzilla.wikimedia.org/71723 (10Krinkle) p:5Unprio>3Lowest s:5normal>3enhanc [07:56:31] (03CR) 10Siebrand: [C: 04-1] "https://www.mediawiki.org/wiki/Remove_Exif_tags has been deleted/moved." [core] - 10https://gerrit.wikimedia.org/r/164726 (https://bugzilla.wikimedia.org/25163) (owner: 10Tuxilina) [08:03:18] (03CR) 10Hashar: "Code still need to be amended based on my comment in PS1 :-] Also I would prefer to see code actually using that new method, I don't thin" [tools/release] - 10https://gerrit.wikimedia.org/r/164289 (owner: 10MarkAHershberger) [08:07:01] 3MediaWiki extensions / 3WikidataRepo: The edit link is hidden behind the section title on small screens - 10https://bugzilla.wikimedia.org/71739 (10Tpt) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Created attachment 16690 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16690&action=edit Screens... [08:14:33] 3MediaWiki / 3API: Make old images searchable by hash - 10https://bugzilla.wikimedia.org/21345#c12 (10Maarten Dammers) We might as well do it, but should probably keep an pywikibot bug open to keep track of this. [08:16:05] (03CR) 10Siebrand: [C: 04-2] Added GENDER suport for log messages. (032 comments) [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/161032 (https://bugzilla.wikimedia.org/70836) (owner: 1001tonythomas) [08:18:05] (03PS2) 10Thiemo Mättig (WMDE): Drop ORMTable::getFieldPrefix [core] - 10https://gerrit.wikimedia.org/r/165003 [08:18:13] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/165072 (owner: 10Ragesoss) [08:18:15] 3MediaWiki extensions / 3EducationProgram: Rename the namespace of the education program for Czech language Wikipedia - 10https://bugzilla.wikimedia.org/71674 (10Siebrand Mazeland) a:3Sage Ross [08:19:36] (03PS2) 10Florianschmidtwelzow: WIP:Special:NewPages: Prepare for mw-ui [core] - 10https://gerrit.wikimedia.org/r/164733 (https://bugzilla.wikimedia.org/71446) [08:21:58] 3Wikimedia / 3Wikidata: Wikimedia Error page on the item for Germany (Q183) - 10https://bugzilla.wikimedia.org/71519#c18 (10Aude) this can be reproduced with stacktrace, with: $rev = Revision::newFromId( 143201634 ); $content = $rev->getContent(); $pout = $content->getParserOutput( $title ); (consistent wi... [08:25:06] (03CR) 10Florianschmidtwelzow: WIP:Special:NewPages: Prepare for mw-ui (034 comments) [core] - 10https://gerrit.wikimedia.org/r/164733 (https://bugzilla.wikimedia.org/71446) (owner: 10Florianschmidtwelzow) [08:39:29] 3MediaWiki extensions / 3WikidataRepo: Create browser smoke test for a typical item - 10https://bugzilla.wikimedia.org/68094 (10tobias.gritschacher) 5PATC>3RESO/FIX [08:39:43] 3MediaWiki extensions / 3WikidataRepo: Update ApiModules to conform to api conventions - 10https://bugzilla.wikimedia.org/69739 (10tobias.gritschacher) 5PATC>3RESO/FIX [08:40:17] 3MediaWiki extensions / 3WikidataRepo: Test conformance of API modules - 10https://bugzilla.wikimedia.org/67407 (10tobias.gritschacher) 5PATC>3RESO/FIX [08:46:33] (03CR) 10Gergő Tisza: "Was there any consensus about this? There was some FUD about whether removing the link is legal, and the bug discussion doesn't exactly in" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165119 (https://bugzilla.wikimedia.org/23965) (owner: 10Kaldari) [09:21:06] (03CR) 10Qdinar: "Siebrand : "incomplete"" [core] - 10https://gerrit.wikimedia.org/r/164049 (owner: 10Qdinar) [09:38:43] 3Wikimedia / 3Wikidata: Wikimedia Error page on the item for Germany (Q183) - 10https://bugzilla.wikimedia.org/71519#c19 (10Marius Hoch) Aude: Is this (the trace you posted) still a problem after tonights deploy? [09:38:58] 3Wikimedia / 3General/Unknown: Non-WMF staff cannot access graphite.wikimedia.org - 10https://bugzilla.wikimedia.org/54713 (10Krinkle) [09:52:13] 3Wikimedia / 3General/Unknown: Non-WMF staff cannot access graphite.wikimedia.org - 10https://bugzilla.wikimedia.org/54713#c10 (10Alex Monk) So can we mark this as fixed? [09:53:30] 3MediaWiki / 3General/Unknown: HttpRequest: Failing under PHP 5.6 (CURLOPT_CLOSEPOLICY not defined) - 10https://bugzilla.wikimedia.org/71729 (10Andre Klapper) p:5Unprio>3High [09:54:28] 3Wikimedia / 3Wikidata: Wikimedia Error page on the item for Germany (Q183) - 10https://bugzilla.wikimedia.org/71519#c20 (10Aude) @hoo still a problem. I am poking at the code now. If the ReferencedEntitiesFinder code is not executed when generating the used entities for parser output js config, then the e... [10:15:24] (03CR) 10Phuedx: Add mw-ui-icon (032 comments) [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) (owner: 10Jdlrobson) [10:17:58] 3Wikimedia / 3Wikidata: Wikimedia Error page on the item for Germany (Q183) - 10https://bugzilla.wikimedia.org/71519#c21 (10WikidataBugzilla) Commit pushed to getallsnaks at https://github.com/wmde/WikibaseDataModel https://github.com/wmde/WikibaseDataModel/commit/63d006f4316b32c4089cbf317fa7949cc67c9d2d Ca... [10:36:17] (03PS2) 10Bartosz Dziewoński: Deprecate OutputPage::readOnlyPage() [core] - 10https://gerrit.wikimedia.org/r/163540 (owner: 10PleaseStand) [10:36:19] (03PS2) 10Bartosz Dziewoński: Deprecate OutputPage::rateLimited() [core] - 10https://gerrit.wikimedia.org/r/163543 (owner: 10PleaseStand) [10:56:59] 3MediaWiki extensions / 3WikidataRepo: Don't try to add labels in non-existing languages: restrict to Language::isKnownLanguageTag - 10https://bugzilla.wikimedia.org/37459#c14 (10Nemo) Related: https://gerrit.wikimedia.org/r/#/c/164725/3 I asked there to explain better here. [11:10:25] (03CR) 10Bartosz Dziewoński: "Jon, I don't think it makes sense to create language-specific solutions if we can come up with a design that works everywhere. Consistency" [skins/Vector] - 10https://gerrit.wikimedia.org/r/164712 (https://bugzilla.wikimedia.org/70004) (owner: 10Isarra) [11:15:30] (03CR) 10Bartosz Dziewoński: [C: 032] "Thanks." [core] - 10https://gerrit.wikimedia.org/r/165060 (owner: 10Gerrit Patch Uploader) [11:17:15] (03CR) 10Bartosz Dziewoński: "Thanks for the follow-up: b740e46f552bc3a07292f3a9ea0b81c56aaefe45" [core] - 10https://gerrit.wikimedia.org/r/118733 (owner: 10Bartosz Dziewoński) [11:17:42] (03CR) 10Bartosz Dziewoński: "It might be reasonable to fail early (throw exception) is any of the array members contain a '|' themselves. I'll leave it for you to deci" [core] - 10https://gerrit.wikimedia.org/r/164886 (https://bugzilla.wikimedia.org/64570) (owner: 10saper) [11:33:28] 3Wikimedia / 3General/Unknown: *_minor_mime are varbinary(32) on WMF sites, out of sync with varbinary(100) in MW core - 10https://bugzilla.wikimedia.org/71563#c12 (10Sean Pringle) S1 done. [11:38:09] (03CR) 10Divec: "The patch is behaving OK but the Apertium API is acting slightly strangely. See individual comments for details." (032 comments) [services/cxserver] - 10https://gerrit.wikimedia.org/r/157141 (owner: 10Divec) [11:41:13] 3Wikimedia / 3Wikidata: Wikimedia Error page on the item for Germany (Q183) - 10https://bugzilla.wikimedia.org/71519#c22 (10Aude) Created attachment 16691 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16691&action=edit Q183 blob from august 4 dump [11:44:34] (03PS2) 10Krinkle: mediawiki.api: Remove check for callback in postWithToken [core] - 10https://gerrit.wikimedia.org/r/165060 (owner: 10Gerrit Patch Uploader) [11:59:06] (03PS8) 10Divec: WIP: Derive MT subsentence map from uppercasing [services/cxserver] - 10https://gerrit.wikimedia.org/r/157141 [12:10:21] (03CR) 10Divec: "Removed obsolete non-qunit test that called Apertium. (Now we have a proper script bin/apertium-xhtml to do this properly)." [services/cxserver] - 10https://gerrit.wikimedia.org/r/157141 (owner: 10Divec) [12:34:38] (03CR) 10Manybubbles: [C: 032] "I'm not used to +2ing in core but it does indeed look good to me." [core] - 10https://gerrit.wikimedia.org/r/162190 (owner: 10Krinkle) [12:41:11] (03Merged) 10jenkins-bot: PrefixSearch: Add unit tests for StringPrefixSearch [core] - 10https://gerrit.wikimedia.org/r/162190 (owner: 10Krinkle) [13:11:42] (03CR) 10Siebrand: "Qdinar: You write in your commit message "does not work correctly". So this will not be mergable until it works correctly..." [core] - 10https://gerrit.wikimedia.org/r/164049 (owner: 10Qdinar) [13:14:49] (03CR) 10Zfilipin: [C: 04-1] QA: refactor to share code with Echo/MF repos (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163993 (owner: 10Cmcmahon) [14:01:35] (03CR) 10Umherirrender: [C: 032] "Conflict with change of commit message" [core] - 10https://gerrit.wikimedia.org/r/165060 (owner: 10Gerrit Patch Uploader) [14:08:09] (03Merged) 10jenkins-bot: mediawiki.api: Remove check for callback in postWithToken [core] - 10https://gerrit.wikimedia.org/r/165060 (owner: 10Gerrit Patch Uploader) [14:13:15] (03PS1) 10Cscott: Properly resolve URLs to decode titles, rather than blindly removing dots. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/165198 [14:14:54] (03PS28) 10Paladox: Update jQuery Cookie to v1.4.1 [core] - 10https://gerrit.wikimedia.org/r/139686 [14:15:06] PS28! [14:15:24] (03PS11) 10Paladox: TwitterLogin: Update auth link [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/151640 [14:24:14] 3Wikimedia / 3General/Unknown: Move https://noc.wikimedia.org/conf/ to a wiki page on wikitech.wikimedia.org - 10https://bugzilla.wikimedia.org/71723#c2 (10Sam Reed (reedy)) (In reply to Krinkle from comment #1) > The main thing conf/ provides (or any dynamically created overview) is > listing all files in a... [14:32:43] 3Wikimedia / 3General/Unknown: Non-WMF staff cannot access graphite.wikimedia.org - 10https://bugzilla.wikimedia.org/54713#c11 (10se4598) (In reply to Alex Monk from comment #10) > So can we mark this as fixed? No, this bug is about allowing public access, after the necessary security review has been done.... [14:34:01] (03CR) 10Cscott: "Sorry for the long delay on this review!" (037 comments) [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/162540 (owner: 10Arlolra) [14:36:28] 3Wikimedia / 3General/Unknown: Non-NDA users cannot access graphite.wikimedia.org - 10https://bugzilla.wikimedia.org/54713#c12 (10Alex Monk) 'nda' group = non-WMF staff. I'm changing this bug so it's about allowing public access instead. [14:45:15] 3MediaWiki extensions / 3Spam Blacklist: Provide tracking category for pages with SBL links - 10https://bugzilla.wikimedia.org/63601 (10Jackmcbarn) 5NEW>3ASSI a:3Jackmcbarn [14:55:46] (03CR) 10MarkAHershberger: "Agreed. Method and its intended user should be added in a single commit." [tools/release] - 10https://gerrit.wikimedia.org/r/164289 (owner: 10MarkAHershberger) [14:56:00] 3MediaWiki extensions / 3WikidataClient: LUA functions mw.wikibase.label and mw.wikibase.sitelink should not load the whole entity into memory - 10https://bugzilla.wikimedia.org/71743 (10Sergey Vladimirov) 3NEW p:3Unprio s:3normal a:3Wikidata bugs AFAIU current implementation of mw.wikibase.entity.lu... [14:56:01] (03Abandoned) 10MarkAHershberger: Add method for determining if a version is a snapshot [tools/release] - 10https://gerrit.wikimedia.org/r/164289 (owner: 10MarkAHershberger) [15:00:02] (03PS1) 10Cscott: Use article title as download filename. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/165213 (https://bugzilla.wikimedia.org/71720) [15:01:00] 3MediaWiki / 3User login and signup: "Username taken" warning is too fast and alarming - 10https://bugzilla.wikimedia.org/71744 (10Nemo) 3NEW p:3Unprio s:3normal a:3None Today I helped two women register on Wikipedia, observing them from behind their shoulder. In both cases, while they were typing th... [15:02:34] qgil: On fab.wmflabs.org, tasks had points, but not so on phabricator.wikimedia.org, is that a conscious choice? [15:03:30] (03PS1) 10Cscott: Ensure that book creator popup has an opaque background. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/165215 [15:04:43] marktraceur, see https://phabricator.wikimedia.org/T452 (note to self, searching for "points" just worked) [15:05:28] 3MediaWiki extensions / 3Collection: New PDF renderer: One column layout doesn't work. - 10https://bugzilla.wikimedia.org/68836#c12 (10C. Scott Ananian) 5PATC>3RESO/FIX Tested; one column layout works now. [15:06:23] Ah, neat. Thanks. [15:08:50] (03PS1) 10Reedy: minor param doc fixups [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165216 [15:10:27] (03PS2) 10Reedy: minor param doc fixups [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165216 [15:10:59] 3Wikimedia / 3Wikidata: Wikimedia Error page on the item for Germany (Q183) - 10https://bugzilla.wikimedia.org/71519#c24 (10Aude) I have narrowed down this particular issue (the exception) to the ReferenceSerializer. It calls $reference->getHash() and then the value of the reference's snaks gets corrupt. B... [15:12:59] 3Wikimedia / 3Wikidata: Wikimedia Error page on the item for Germany (Q183) - 10https://bugzilla.wikimedia.org/71519#c25 (10Aude) https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/lib/includes/serializers/ReferenceSerializer.php#L58-L67 is the code in question [15:14:43] 3MediaWiki extensions / 3ConfirmEdit (CAPTCHA extension): Removing Asirra integration - 10https://bugzilla.wikimedia.org/71712 (10Sam Reed (reedy)) [15:15:28] 3MediaWiki extensions / 3ConfirmEdit (CAPTCHA extension): Remove Asirra integration - 10https://bugzilla.wikimedia.org/71712 (10Sam Reed (reedy)) [15:18:31] (03PS1) 10Reedy: Remove Asirra integration [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/165218 (https://bugzilla.wikimedia.org/71712) [15:19:20] (03PS1) 10Cscott: Equations should be flush left and not indented. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/165219 (https://bugzilla.wikimedia.org/68838) [15:19:42] (03PS1) 10Christopher Johnson (WMDE): Add points to Tasks Table [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/165220 [15:29:18] (03PS1) 10Cscott: Use narrower margins. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/165223 [15:30:04] (03CR) 10Reedy: "See also bug 71729" [core] - 10https://gerrit.wikimedia.org/r/159159 (https://bugzilla.wikimedia.org/70570) (owner: 10Dan-nl) [15:33:19] (03PS1) 10Cscott: The `rl` writer should be an alias for `rdf2latex`. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/165225 [15:34:00] 3MediaWiki / 3Uploading: illegally named upload files not handled consistently. - 10https://bugzilla.wikimedia.org/27980#c4 (10John Mark Vandenberg) 5NEW>3RESO/WOR WFM per comment 3. Please re-open if the problem still exists, and it doesnt appear to be a config issue. [15:39:30] (03PS2) 10Reedy: Default skin is offline [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/157767 [15:39:34] (03CR) 10Reedy: [C: 032] Default skin is offline [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/157767 (owner: 10Reedy) [15:39:36] (03Merged) 10jenkins-bot: Default skin is offline [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/157767 (owner: 10Reedy) [15:40:09] Nemo_bis: any chance you've got permission bits to edit https://en.wikipedia.org/wiki/Template:Saved_book ? [15:40:52] (03CR) 10Reedy: "I guess we need to get it fixed (again) upstream at least" [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/150622 (https://bugzilla.wikimedia.org/52509) (owner: 10Reedy) [15:42:01] cscott: I have [15:42:51] cscott: note, the template exists on dozens Wikimedia projects and hundreds non-Wikimedia projects [15:43:03] Reedy: as a start, the EPUB, ODT, and ZIM links need to be removed there, since we don't support that any more. [15:43:13] (we should really have something more robust than that) [15:43:22] cscott: Ideall we want to be making multiple updates to the template [15:43:28] 3MediaWiki extensions / 3WikidataRepo: Exception: Can only add Wikibase\DataModel\Snak\Snak implementing objects to Wikibase\DataModel\Snak\SnakList - 10https://bugzilla.wikimedia.org/71479#c21 (10Aude) the stacktrace in comment 1 is result of rethrowing the exception, so we don't have complete log. we adde... [15:43:39] Like replacing it with a tag :D [15:43:40] Reedy: "don't want", you mean? [15:43:47] haha [15:43:48] yeah [15:44:05] It's only on few thousands pages, if that's the concern [15:44:10] * Reedy looks how many transclusions there are [15:44:24] Nemo_bis: Still, if we're making numerous edits in short succession etc, we might aswell group them [15:44:27] Reedy: ok, give me a minute, i need to figure out what the "PDF (A4)" and "PDF (letter)" links should actually point to. i'm not sure that that's actually a feature of the software. [15:44:57] Nemo_bis: and the 'pediapress' link isn't working either, i'm trying to figure out why. [15:45:23] cscott: did you see the bug for the preview on pediapress? [15:45:33] * http://web.archive.org/web/20110800000000/http://code.pediapress.com/wiki/ticket/823 [15:45:36] ** Support other printing options than A4 [15:45:37] is there already a bugzilla for it? [15:45:46] ha! [15:46:02] well, we support it, just not from a direct link I don't think. i might be able to add that, though. [15:46:26] and someone convinced me that OCG should default to A4 as well, although I'm not sure that's a good idea for enwiki. [15:47:06] heh [15:47:16] Silly americans [15:47:31] well, it's more that letter fits on a4, but not the other way 'round. [15:47:37] Nemo_bis: Ther's at least 25,000 that transclude Template:Saved book [15:47:39] or do i have it backwards? [15:47:57] A4 is bigger AFAIK [15:48:30] lol, 27123 [15:48:34] yeah. so a letter default makes some not-just-americentric sense [15:48:37] 27213 [15:49:26] yes, and about 20k on de.wiki, 5k on it.wiki and so on [15:49:34] negligible isn't it? [15:49:54] It's not nothing [15:49:56] But it isn't that much [15:50:01] My original point still stands [15:50:10] We shouldn't make numerous edits in short succession :P [15:50:21] cscott: the bug is https://bugzilla.wikimedia.org/show_bug.cgi?id=71675 [15:50:41] sure sure [15:52:14] 3MediaWiki extensions / 3Collection: "Preview with PediaPress" defunct - 10https://bugzilla.wikimedia.org/71675#c2 (10C. Scott Ananian) a:3C. Scott Ananian It appears that the 'zip_post' command is going to the OCG servers (who can't handle it) instead of the public pediapress servers. [15:52:43] 3MediaWiki extensions / 3ConfirmEdit (CAPTCHA extension): Remove Asirra integration - 10https://bugzilla.wikimedia.org/71712#c5 (10[[kgh]]) 5PATC>3RESO/FIX This was a fast one. Thanks for your work! Thus closing as RESOLVED FIXED. [15:52:44] Wait, Americans don't use A4? What? [15:53:05] Woah. I had no idea. [15:54:23] Really? [15:54:58] Reedy: (copying from a message I just sent Krenair) briefly, the epub, odf, and zim options are no longer supported, so just need to be removed. [15:54:58] the "PDF (A4)" and "PDF (letter)" options exploited a weird bug in the way that OCG and the old mwlib renderers chose paper size, it doesn't work any more either. [15:54:58] the url with `writer=rdf2latex` is the only link that actually works right now, and it generates PDF (A4). [15:54:58] but i'm trying to see if I can come up with a patch to fix the Pediapress link and add the PDF (letter) functionality. [15:57:43] 3MediaWiki-Vagrant: (Cannot contact the database server: Too many connections ()) - 10https://bugzilla.wikimedia.org/71370#c9 (10Nik Everett) OK! I smashed my instance (again again) and rebuilt it and it still fails just like this. The trouble is that the hhvm service hangs on to stuff forever. Just never l... [15:57:55] Krenair: yeah, it's a shock when one discovers [15:58:33] (03CR) 10PleaseStand: "This reverts 2a4dfa169bd4 for HashBagOStuff. I suppose it could possibly cause a problem if there is some code that assumes that two diffe" [core] - 10https://gerrit.wikimedia.org/r/165166 (https://bugzilla.wikimedia.org/71724) (owner: 10Tim Starling) [16:03:45] 3MediaWiki extensions / 3ConfirmEdit (CAPTCHA extension): Remove Asirra integration - 10https://bugzilla.wikimedia.org/71712#c6 (10Nemo) 5RESO/FIX>3REOP Only the twn patch was merged for now [16:05:58] 3MediaWiki extensions / 3ConfirmEdit (CAPTCHA extension): Remove Asirra integration - 10https://bugzilla.wikimedia.org/71712#c7 (10[[kgh]]) Appears pretty awkward but yeah, that true. Sorry for closing this prematurely. [16:07:00] 3Wikimedia / 3General/Unknown: Geolocation not available on wikimediafoundation.org - 10https://bugzilla.wikimedia.org/71747 (10Peter Coombe) 3NEW p:3Unprio s:3normal a:3None On most Wikimedia sites there is a JavaScript global variable 'Geo' which contains information on the client's location. Howev... [16:07:46] (03PS4) 10Ragesoss: Add Czech namespace, alias translations [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/165072 [16:08:13] 3MediaWiki extensions / 3Collection: "Preview with PediaPress" defunct - 10https://bugzilla.wikimedia.org/71675#c3 (10Nemo) (In reply to Marcin Cieślak from comment #1) > Confirmed on plwiki as well. > > But MediaWiki at fd9173e with extension Collection also at its git master > installed locally do work (4... [16:09:53] Where's the geo js variable come from? [16:13:13] 3MediaWiki / 3User login and signup: If coming from a non-secure website to a secured login, if force ssl is not enabled, it should return to the non-secure website. - 10https://bugzilla.wikimedia.org/71716#c5 (10Stephen Liang) I'm running version Mediawiki 1.23.5 (stock). [16:17:15] 3Wikimedia / 3General/Unknown: Geolocation not available on wikimediafoundation.org - 10https://bugzilla.wikimedia.org/71747#c1 (10Sam Reed (reedy)) Is it from CentralNotice? 'wmgUseCentralNotice' => array( 'advisorywiki' => false, // Per Bug # 25519 'default' => true, 'fishbowl' => false, // Pe... [16:18:43] 3MediaWiki-Vagrant: (Cannot contact the database server: Too many connections ()) - 10https://bugzilla.wikimedia.org/71370#c10 (10Nik Everett) Looks like enabling the zend role fixes the problem for me. Sadly, I might have to give up on debugging this for a while and use zend. [16:19:20] manybubbles: SHould we tag that bug hhvm then? [16:19:29] sure, let me do that [16:20:22] (03PS1) 10Cscott: Allow overriding the default server for POD functions. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/165234 (https://bugzilla.wikimedia.org/71675) [16:20:28] (03PS1) 10Cscott: Support plaintext rendering. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/165235 [16:20:49] Nemo_bis: https://gerrit.wikimedia.org/r/165234 would allow the pediapress function to work again, but the pediapress server appears to be overloaded. [16:20:58] 3MediaWiki-Vagrant: (Cannot contact the database server: Too many connections ()) - 10https://bugzilla.wikimedia.org/71370#c11 (10Nik Everett) p:5Unprio>3High Tagging hhvm and setting priority to high. I can no longer develop against hhvm which makes me less confident we'll be able to cut over to it. Sin... [16:23:28] 3Wikimedia / 3Mailing lists: oversight-l subscriber list: "Visit Subscriber List" results in "You must supply a valid email address." - 10https://bugzilla.wikimedia.org/21928#c15 (10John F. Lewis) Assuming there has been no updates and the list is no longer used anymore; does this issue occur on any other li... [16:25:44] 3Wikimedia / 3IEG grant review: Review and deploy IEG grant review application - 10https://bugzilla.wikimedia.org/71597#c1 (10Bryan Davis) Created RT 8578 to track operational dependencies. [16:31:46] Reedy, Krenair: i think the right thing to do with Template:Saved_book is to remove ODT and comment out EPUB, ZIM, and PDF (letter) (since those three might work again in the future). The PDF (A4) link should have 'writer=rdf2latex' instead of 'writer=rl'. [16:32:21] Reedy, Krenair: not sure what to do about the 'order a printed copy' link, since that also doesn't work. Perhaps comment that out for now as well. [16:32:31] I'd kill it [16:32:46] i don't object to that. [16:33:12] i'll make a note on bug 71675 to re-add the link if the pediapress POD function is fixed. [16:34:28] 3MediaWiki extensions / 3Collection: "Preview with PediaPress" defunct - 10https://bugzilla.wikimedia.org/71675#c6 (10C. Scott Ananian) The PediaPress link should be re-added to [[:en:Template:Saved_book]] once this function works again. [16:35:30] (03PS8) 10Arlolra: Resizer [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/162540 [16:35:32] (03PS1) 10Arlolra: Refactor the metabook defaults [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/165241 [16:39:07] (03CR) 10Isarra: "Jon: Normally language-specific edge-case solutions come after the most generic one. This is the generic one, which addresses as many case" [skins/Vector] - 10https://gerrit.wikimedia.org/r/164712 (https://bugzilla.wikimedia.org/70004) (owner: 10Isarra) [16:44:14] (03CR) 10Arlolra: [C: 032] Properly resolve URLs to decode titles, rather than blindly removing dots. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/165198 (owner: 10Cscott) [16:44:54] (03CR) 10Arlolra: [C: 032] Equations should be flush left and not indented. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/165219 (https://bugzilla.wikimedia.org/68838) (owner: 10Cscott) [16:45:01] (03PS1) 10Brion VIBBER: Quick add of full-HD (1080p) transcode configs for TMH [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165243 (https://bugzilla.wikimedia.org/71705) [16:45:15] (03CR) 10Arlolra: [C: 032] Use narrower margins. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/165223 (owner: 10Cscott) [16:46:06] (03Merged) 10jenkins-bot: Properly resolve URLs to decode titles, rather than blindly removing dots. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/165198 (owner: 10Cscott) [16:46:18] (03Merged) 10jenkins-bot: Equations should be flush left and not indented. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/165219 (https://bugzilla.wikimedia.org/68838) (owner: 10Cscott) [16:46:36] (03Merged) 10jenkins-bot: Use narrower margins. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/165223 (owner: 10Cscott) [16:46:39] (03CR) 10Arlolra: [C: 032] Ensure that book creator popup has an opaque background. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/165215 (owner: 10Cscott) [16:46:47] (03Merged) 10jenkins-bot: Ensure that book creator popup has an opaque background. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/165215 (owner: 10Cscott) [16:47:48] (03CR) 10Nemo bis: "Is there any language in which this is *not* ok?" (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/164712 (https://bugzilla.wikimedia.org/70004) (owner: 10Isarra) [16:49:02] (03CR) 10Brion VIBBER: "Possible issue: in the transcode list, the 1080p version sorts before 160p instead of after 720p." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165243 (https://bugzilla.wikimedia.org/71705) (owner: 10Brion VIBBER) [16:50:34] (03CR) 10Arlolra: [C: 032] Allow overriding the default server for POD functions. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/165234 (https://bugzilla.wikimedia.org/71675) (owner: 10Cscott) [16:50:42] (03Merged) 10jenkins-bot: Allow overriding the default server for POD functions. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/165234 (https://bugzilla.wikimedia.org/71675) (owner: 10Cscott) [16:51:14] (03CR) 10Arlolra: [C: 032] Support plaintext rendering. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/165235 (owner: 10Cscott) [16:51:21] (03Merged) 10jenkins-bot: Support plaintext rendering. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/165235 (owner: 10Cscott) [16:51:28] 3Wikimedia / 3IEG grant review: Review and deploy IEG grant review application - 10https://bugzilla.wikimedia.org/71597 (10jeremyb) [16:56:28] 3MediaWiki extensions / 3Math: Release Math 2.0 - 10https://bugzilla.wikimedia.org/65341 (10Frédéric Wang) [16:56:31] 3MediaWiki extensions / 3Math: Display MathML when MathPlayer is installed - 10https://bugzilla.wikimedia.org/71748 (10Frédéric Wang) 3NEW p:3Unprio s:3normal a:3None Currently, we use CSS hacks to choose between MathML or SVG/PNG. We will need to load an additional Javascript file after page load to... [17:01:24] (03CR) 10Isarra: "Nemo: This change doesn't actually fix the typography refresh as a whole, and instead only addresses the largest subset of languages possi" (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/164712 (https://bugzilla.wikimedia.org/70004) (owner: 10Isarra) [17:02:04] (03CR) 10Jeroen De Dauw: "This probably breaks EducationProgram." [core] - 10https://gerrit.wikimedia.org/r/165003 (owner: 10Thiemo Mättig (WMDE)) [17:02:35] lol. [17:09:46] (03CR) 10Nikerabbit: "I am wondering whether there is a risk that wiki which is using this will suddenly be without captcha after update, or is it going to thro" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/165218 (https://bugzilla.wikimedia.org/71712) (owner: 10Reedy) [17:12:03] (03CR) 10Aaron Schulz: "Older than when the sha1 layout patch is merged (which has yet to happen)?" [core] - 10https://gerrit.wikimedia.org/r/125573 (owner: 10Aaron Schulz) [17:12:31] (03Restored) 10Aaron Schulz: Added path encoding to FileBackendStore for Windows support [core] - 10https://gerrit.wikimedia.org/r/125573 (owner: 10Aaron Schulz) [17:12:54] (03CR) 10Arlolra: [C: 032] Use article title as download filename. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/165213 (https://bugzilla.wikimedia.org/71720) (owner: 10Cscott) [17:13:33] (03CR) 10Arlolra: [C: 032] The `rl` writer should be an alias for `rdf2latex`. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/165225 (owner: 10Cscott) [17:13:43] 3MediaWiki extensions / 3Math: Display MathML when MathPlayer is installed - 10https://bugzilla.wikimedia.org/71748#c1 (10physikerwelt) Is there a sample HTML page that detects MathPlayer via JavaScript? [17:14:29] (03CR) 10Nemo bis: Adjust header sizes to scale apparent size according to header weight (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/164712 (https://bugzilla.wikimedia.org/70004) (owner: 10Isarra) [17:14:34] (03CR) 10Physikerwelt: "Would it be helful to seperate the tests to a different commit?" [core] - 10https://gerrit.wikimedia.org/r/162286 (https://bugzilla.wikimedia.org/71087) (owner: 10Physikerwelt) [17:18:05] (03CR) 10Reedy: "I think it'll fatal. I was wondering about keeping the Asirra.php around, and putting a "useful" message." [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/165218 (https://bugzilla.wikimedia.org/71712) (owner: 10Reedy) [17:18:28] 3MediaWiki extensions / 3Math: Display MathML when MathPlayer is installed - 10https://bugzilla.wikimedia.org/71748#c2 (10Frédéric Wang) Searching MathPlayer in the user agent string should be enough to detect MathPlayer: https://github.com/brucemiller/LaTeXML/blob/master/lib/LaTeXML/resources/javascript/La... [17:19:32] (03CR) 10Reedy: "Oh, the wfDeprecated is pointless. It closed yesterday." [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/165218 (https://bugzilla.wikimedia.org/71712) (owner: 10Reedy) [17:21:43] 3MediaWiki extensions / 3Math: Display MathML when MathPlayer is installed - 10https://bugzilla.wikimedia.org/71748#c3 (10physikerwelt) A great. Maybe we should provide a standalone JavaScript function hasMathML support that can be used by different projects... What do you think? [17:21:47] (03PS3) 10Isarra: Adjust header sizes to scale apparent size according to header weight [skins/Vector] - 10https://gerrit.wikimedia.org/r/164712 (https://bugzilla.wikimedia.org/70004) [17:25:28] 3Wikimedia / 3Site requests: Geolocation not available on wikimediafoundation.org - 10https://bugzilla.wikimedia.org/71747 (10Andre Klapper) p:5Unprio>3Normal s:5normal>3enhanc [17:25:43] 3MediaWiki / 3Special pages: Sortable table not working correctly for "Number of files" on Special:MediaStatistics - 10https://bugzilla.wikimedia.org/71696#c1 (10Umherirrender) 5NEW>3RESO/FIX Already fixed in master with gerrit 164416 [17:26:01] (03Merged) 10jenkins-bot: Use article title as download filename. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/165213 (https://bugzilla.wikimedia.org/71720) (owner: 10Cscott) [17:26:45] (03Merged) 10jenkins-bot: The `rl` writer should be an alias for `rdf2latex`. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/165225 (owner: 10Cscott) [17:28:13] 3MediaWiki extensions / 3Math: Display MathML when MathPlayer is installed - 10https://bugzilla.wikimedia.org/71748#c4 (10Frédéric Wang) Unfortunately, this kind of things is not always reliable (for example recent version of IE claims to be "Gecko" and Opera dropped MathML and switched from "Presto" to "Bli... [17:31:14] 3MediaWiki / 3MediaWiki UI: Checkboxes do not work in Firefox OS (Special:MobileOptions) - 10https://bugzilla.wikimedia.org/71750 (10Jon) [17:31:43] 3MediaWiki-Vagrant: (Cannot contact the database server: Too many connections ()) - 10https://bugzilla.wikimedia.org/71370#c12 (10Nik Everett) Since I sunk a day into figuring things out I should make it clear what I found before I put this aside. The issue is that hhvm was holding on to all open files and so... [17:33:13] 3MediaWiki / 3User preferences: Cannot disable signature display with $wgHiddenPrefs - 10https://bugzilla.wikimedia.org/71687#c1 (10Umherirrender) It is a bit tricky, but you can use: $wgHiddenPrefs[] = 'nickname'; $wgHiddenPrefs[] = 'oldsig'; $wgHiddenPrefs[] = 'fancysig'; I am not sure, if there should b... [17:34:08] (03PS1) 10Catrope: Update VisualEditor for cherry-pick of Ief5c5369 [core] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/165247 [17:36:29] 3MediaWiki-Vagrant: Import from en.wp failed: Expected tag, got - 10https://bugzilla.wikimedia.org/70781#c6 (10Jon) I updated vagrant but still hitting issues... vagrant@mediawiki-vagrant:/vagrant/mediawiki$ php maintenance/importDump.php dump.xml Segmentation fault (core dumped) vagrant@mediawiki... [17:36:29] 3Wikimedia / 3Site requests: Geolocation not available on wikimediafoundation.org - 10https://bugzilla.wikimedia.org/71747#c2 (10Peter Coombe) Ah yes, it is CentralNotice which is loading it on the other wikis. It seems that loading