[00:00:48] 3MediaWiki / 3General/Unknown: HHVM: make SlowTimer error log entries have a backtrace - 10https://bugzilla.wikimedia.org/71630 (10Aaron Schulz) 3NEW p:3Unprio s:3normal a:3None HHVM error log has entries like: SlowTimer [10000ms] at runtime/ext_mysql: slow query: SELECT MASTER_POS_WAIT('db1024-bin.... [00:01:01] 3MediaWiki / 3General/Unknown: HHVM: make SlowTimer error log entries have a backtrace - 10https://bugzilla.wikimedia.org/71630 (10Aaron Schulz) a:3Ori Livneh [00:01:27] hey peoples [00:01:31] what is a Unexpected non-MediaWiki exception? [00:01:37] (that's a quote) [00:03:31] jeremyb: usually it means wikidata pooping itself [00:03:40] huh [00:03:41] or maybe flow? [00:03:51] i wonder if this should have either of those [00:03:57] one of the two display silly error messages like this [00:04:00] how would i know whether a wiki is a client? [00:04:08] jeremyb: what's the error message? [00:04:20] Unexpected non-MediaWiki exception encountered, of type "InvalidArgumentException" [00:04:30] 3MediaWiki / 3General/Unknown: HHVM: make SlowTimer error log entries have a backtrace - 10https://bugzilla.wikimedia.org/71630 (10Kunal Mehta (Legoktm)) [00:04:31] there's no hash with it? [00:04:36] no! [00:04:37] (03PS1) 10Yurik: Security and styling fix [extensions/Graph] - 10https://gerrit.wikimedia.org/r/164708 [00:04:40] i would have looked it up already [00:04:50] does that mean something like passed wrong number of arguments? [00:05:19] (03CR) 10CSteipp: [C: 031] Security and styling fix [extensions/Graph] - 10https://gerrit.wikimedia.org/r/164708 (owner: 10Yurik) [00:05:36] nope, it just means something was expecting something else [00:07:00] 3MediaWiki extensions / 3[other]: Graph extension security review - 10https://bugzilla.wikimedia.org/69623#c8 (10Yuri Astrakhan) Thx, please take a look at https://gerrit.wikimedia.org/r/#/c/164708/ [00:09:26] legoktm: doesn't seem to appear in kibana at all. (went back the whole 30 days) [00:09:32] do private wikis go to logstash? [00:09:39] they should [00:09:41] (03CR) 10Yurik: [C: 032] Security and styling fix [extensions/Graph] - 10https://gerrit.wikimedia.org/r/164708 (owner: 10Yurik) [00:09:48] but I didn't see anything in exception.log [00:09:49] (03Merged) 10jenkins-bot: Security and styling fix [extensions/Graph] - 10https://gerrit.wikimedia.org/r/164708 (owner: 10Yurik) [00:12:11] i'm going to try to reproduce at testwikipedia [00:12:28] or test2 maybe [00:15:33] legoktm: so, when i do it on testwikipedia now i get a real stack [00:15:40] in browser not just with hash [00:15:41] :o [00:16:02] test.wp has different exception showing settings iirc [00:16:11] i wonder what the difference is. it's a weekend so all groups are the same version? [00:16:13] oh, ok [00:16:32] but still test gives a hash [00:16:48] of course it's not an exact replica test case [00:17:52] huh... [00:41:53] (03PS1) 10Isarra: Adjust header sizes to scale apparent size according to header weight [skins/Vector] - 10https://gerrit.wikimedia.org/r/164712 (https://bugzilla.wikimedia.org/70004) [00:43:59] 3Wikimedia / 3OTRS: Create OTRS patch for "1-click spam" disposal - 10https://bugzilla.wikimedia.org/54755#c12 (10Kunal Mehta (Legoktm)) (In reply to Alex Monk from comment #11) > This JavaScript 'fix' is basically the equivalent of fixing a MediaWiki core > bug with a default-on gadget. It's not a patch for... [00:45:47] 3MediaWiki / 3General/Unknown: Gadget and Common Mediawiki files not loaded in Special pages - 10https://bugzilla.wikimedia.org/71631 (10Zack) 3NEW p:3Unprio s:3normal a:3None Gadgets and Mediawiki:Common.css and .js do not work in 'Special:Login' and 'Special:Preferences' pages. [00:46:11] (03PS2) 10Isarra: Adjust header sizes to scale apparent size according to header weight [skins/Vector] - 10https://gerrit.wikimedia.org/r/164712 (https://bugzilla.wikimedia.org/70004) [00:50:44] 3MediaWiki / 3General/Unknown: Gadget and Common Mediawiki files not loaded in Special pages - 10https://bugzilla.wikimedia.org/71631#c1 (10Kunal Mehta (Legoktm)) 5NEW>3RESO/WON MediaWiki:Common.js and Gadgets have never worked on those special pages. CSS was recently removed with bug 70672. See also bu... [01:01:47] 3MediaWiki skins / 3MonoBook: MonoBook: h3 should not appear as heavier weight than h2 - 10https://bugzilla.wikimedia.org/69999#c1 (10Isarra) Apparently this has mostly been fixed, and now really only affects some linux distros, where the h3 is essentially the same size as the h2, but darker. The css itself... [01:13:08] (03PS1) 10Isarra: Adjust h3 size to keep it smaller than h2 across normal platforms [core] - 10https://gerrit.wikimedia.org/r/164713 (https://bugzilla.wikimedia.org/69999) [01:13:15] 3Wikimedia / 3OTRS: Create OTRS patch for "1-click spam" disposal - 10https://bugzilla.wikimedia.org/54755#c13 (10Alex Monk) Created attachment 16667 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16667&action=edit OTRS 1 click spam button JS gadget [01:13:38] 3Wikimedia / 3OTRS: Create OTRS patch for "1-click spam" disposal - 10https://bugzilla.wikimedia.org/54755 (10Alex Monk) [01:17:00] (03CR) 10Krinkle: [C: 032] update-oojs-ui.sh: Exclude the minimised distribution files [core] - 10https://gerrit.wikimedia.org/r/161891 (owner: 10Jforrester) [01:23:35] (03Merged) 10jenkins-bot: update-oojs-ui.sh: Exclude the minimised distribution files [core] - 10https://gerrit.wikimedia.org/r/161891 (owner: 10Jforrester) [01:24:02] 3MediaWiki extensions / 3ExpandTemplates: Feature request: ExpandTemplates should show categories - 10https://bugzilla.wikimedia.org/71633 (10Mr. Stradivarius) 3NEW p:3Unprio s:3enhanc a:3None It would be nice if Special:ExpandTemplates showed a list of categories below the preview section. First req... [01:52:18] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (48980881f3) [core] - 10https://gerrit.wikimedia.org/r/164714 [02:19:17] legoktm: i'm ready to give up on this one... stack is skin specific but happens with multiple skins. [02:19:26] we could probably just cast to string somewhere [02:19:34] what's the traceback? [02:19:34] but i want to know how it broke [02:19:50] and no clue *when* it broke [02:19:59] also, it was in a flourine log after all [02:20:06] well, I don't actually know what's broken so... [02:20:14] #wikimedia-dev [02:20:15] gah [02:20:18] https://test.wikipedia.org/wiki/Main_Page [02:20:24] https://test.wikipedia.org/wiki/Main_Page?useskin=monobook [02:20:39] :O [02:20:48] monobook is my default :P [02:20:52] interesting. [02:21:03] * jeremyb too. except i didn't set a default at that wiki apparently [02:24:25] somehow it's being cast to an integery [02:24:27] integer* [02:25:38] // @todo Add wfDeprecated in 1.20 [02:25:40] nice.... [02:25:53] hah [02:25:58] where's that? [02:26:10] SkinTemplate::outputPage() [02:27:15] jeremyb: do you know if this code ever worked? [02:27:29] it did [02:27:45] probably less than 2 years ago [02:27:59] I can look at page history in a but [02:28:03] bit* [02:28:13] ok, well Skin::addToSidebarPlain() is the relevant function [02:30:19] * legoktm boots up his vm [02:40:10] (03PS2) 10Umherirrender: Add comment to AFL_* constants in Defines.php [core] - 10https://gerrit.wikimedia.org/r/164618 [02:43:50] jeremyb: think I found it [02:44:03] https://dpaste.de/utme/raw looks like a phpstupid [02:45:05] https://stackoverflow.com/questions/4100488/a-numeric-string-as-array-key-in-php [02:47:22] jeremyb_: did you get my messages? [02:51:34] errr, where did I go? [02:51:43] not since boots up vm [02:51:57] legoktm [02:52:09] [19:43:43] jeremyb: think I found it [02:52:10] [19:43:56] https://dpaste.de/utme/raw looks like a phpstupid [02:52:10] [19:44:58] https://stackoverflow.com/questions/4100488/a-numeric-string-as-array-key-in-php [02:53:11] I'm trying to think of a solution that doesn't involve updating every skin...vector and monobook look to have the same exact function, one uses a switch and the other uses if/elseif [02:55:16] so no idea how/when it broke? [02:55:21] because it did work [02:55:54] I didn't try to git blame [02:56:39] I should go back to my computer :P [02:59:50] jeremyb: want to file a bug for this? [03:01:09] did I miss something else? [03:02:09] I think not [03:02:16] client was freaking out [03:02:56] huge netsplit and then messages were going to PM windows instead of to channel [03:03:08] anyone else see the split? [03:03:13] brb [03:47:59] (03Abandoned) 10Spage: QA: WIP fix collapsing test for new hide behavior [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164277 (owner: 10Spage) [05:17:19] 3MediaWiki extensions / 3ParserFunctions: {{#ifexist: }} "pollutes" pagelinks table - 10https://bugzilla.wikimedia.org/71636#c1 (10Liangent) I understand that registering {{#ifexist: }} calls as pagelinks is used to make sure that caches are regenerated when a related page is created/deleted. However these c... [05:18:34] 3MediaWiki extensions / 3Scribunto: mw.title.exists "pollutes" pagelinks table - 10https://bugzilla.wikimedia.org/71637 (10Liangent) 3NEW p:3Unprio s:3normal a:3None +++ This bug was initially created as a clone of Bug #71636 +++ I understand that registering such calls as pagelinks is used to make... [05:18:46] 3MediaWiki extensions / 3Scribunto: mw.title.exists "pollutes" pagelinks table - 10https://bugzilla.wikimedia.org/71637 (10Liangent) [05:18:47] 3MediaWiki extensions / 3ParserFunctions: {{#ifexist: }} "pollutes" pagelinks table - 10https://bugzilla.wikimedia.org/71636 (10Liangent) [05:25:54] legoktm: i see no obvious use of arrays in SkinTemplate::outputPage [05:26:22] the bug is in Skin::addToSidebarPlain. [05:28:35] wtf, who chose $bar as a variable name :( [05:29:02] * jeremyb checks out master instead of wmf branch [05:32:51] ewww, pass by reference :( [05:35:43] legoktm: the last edit to that sidebar before I noticed it broken today was august 10 this year by James_F|Away. presumably he wouldn't have left it broken if it was immediately on save [05:35:59] so that's a better timeframe than i thought [05:47:00] * jeremyb has stumbled on some old hashar: http://mediawiki.org/wiki/Special:Code/MediaWiki/5015 [05:48:31] SkinPHPTal [05:50:04] 3MediaWiki / 3API: API description of login action is misleading - 10https://bugzilla.wikimedia.org/71638 (10spage) 3NEW p:3Unprio s:3trivia a:3None The help for action=login says "Log in and get the authentication tokens. In the event of a successful log-in, a cookie will be attached to your session... [05:57:19] 3MediaWiki / 3Interface: [regression] [[mediawiki:sidebar]] no longer supports entirely numeric headers ("* 3829") - 10https://bugzilla.wikimedia.org/71639 (10jeremyb) 3NEW p:3Unprio s:3normal a:3None [regression] [[mediawiki:sidebar]] no longer supports entirely numeric headers ("* 3829") don't hav... [05:58:17] legoktm: ori: ^ [05:58:51] and James_F|Away :) [06:05:30] 3MediaWiki / 3Interface: [regression] [[mediawiki:sidebar]] no longer supports entirely numeric headers ("* 3829") - 10https://bugzilla.wikimedia.org/71639#c1 (10Kunal Mehta (Legoktm)) Most likely caused by I458c0af3114754ddf3d721f6c374e249f482e4cf. The bug is that if you set a string which is also an integ... [06:07:15] 3MediaWiki / 3Interface: [regression] [[mediawiki:sidebar]] no longer supports entirely numeric headers ("* 3829") - 10https://bugzilla.wikimedia.org/71639#c2 (10Kunal Mehta (Legoktm)) Setting milestone to 1.24.0 release. [06:12:30] 3MediaWiki / 3General/Unknown: Implement "actual watchers" count into MediaWiki's info action - 10https://bugzilla.wikimedia.org/49506#c7 (10Nemo) That's easy to fix, step 1 in comment 3 becomes "check recent unvisited edits and if there are some how old/how many they are". We could discuss what's the most s... [06:37:56] (03PS1) 10Spage: QA: remove moderated notion from collape tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164720 [06:49:02] 3MediaWiki skins / 3Vector: Re-evaluate serif font stack for headers - 10https://bugzilla.wikimedia.org/71240#c2 (10Erwin Dokter) See also https://www.mediawiki.org/wiki/Talk:Typography_refresh#Header_fontstack where I propose a Times based font stack. [06:52:57] (03CR) 10Edokter: [C: 04-1] "How is this different from the previous patch 162304?" [skins/Vector] - 10https://gerrit.wikimedia.org/r/164712 (https://bugzilla.wikimedia.org/70004) (owner: 10Isarra) [07:09:26] (03CR) 10Isarra: "Unlike the previous patch, this doesn't change the font and only changes the sizes of the headers in order to address 70004. As a result, " [skins/Vector] - 10https://gerrit.wikimedia.org/r/164712 (https://bugzilla.wikimedia.org/70004) (owner: 10Isarra) [07:54:02] 3MediaWiki / 3Parser: Numbered list and semi column - 10https://bugzilla.wikimedia.org/71640 (10Andyrom75) 3NEW p:3Unprio s:3normal a:3None Only the first two group of numbered list: #'''Item 1''' #'''Item 2''' #;Item 1 #'''Item 2''' #;Item 1 #;Item 2 are shown correctly: 1. Item 1 2. Item 2 1. I... [10:25:06] 3MediaWiki extensions / 3ParserFunctions: {{#ifexist: }} "pollutes" pagelinks table - 10https://bugzilla.wikimedia.org/71636#c2 (10Umherirrender) bug 12019? [10:33:34] (03PS1) 10Legoktm: Stop using $wgUser in ResourceLoader modules [core] - 10https://gerrit.wikimedia.org/r/164724 [10:37:05] (03CR) 10jenkins-bot: [V: 04-1] Stop using $wgUser in ResourceLoader modules [core] - 10https://gerrit.wikimedia.org/r/164724 (owner: 10Legoktm) [10:38:45] 3Wikimedia / 3General/Unknown: *_minor_mime are varbinary(32) on WMF sites, out of sync with varbinary(100) in MW core - 10https://bugzilla.wikimedia.org/71563#c8 (10Umherirrender) (In reply to Bawolff (Brian Wolff) from comment #7) > (In reply to Umherirrender from comment #6) > > Purge does not rewrite the... [10:57:38] (03CR) 10Legoktm: [C: 04-1] Stop using $wgUser in ResourceLoader modules [core] - 10https://gerrit.wikimedia.org/r/164724 (owner: 10Legoktm) [11:08:24] (03PS4) 10Legoktm: Support redirects in JavaScriptContent [core] - 10https://gerrit.wikimedia.org/r/162491 (https://bugzilla.wikimedia.org/71200) [11:12:42] (03CR) 10Legoktm: "@Jackmcbarn: We can't use mw.config.get('wgServer') and other variables, because those will have the values of the wiki being used, not th" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/162491 (https://bugzilla.wikimedia.org/71200) (owner: 10Legoktm) [11:14:59] (03CR) 10jenkins-bot: [V: 04-1] Support redirects in JavaScriptContent [core] - 10https://gerrit.wikimedia.org/r/162491 (https://bugzilla.wikimedia.org/71200) (owner: 10Legoktm) [11:16:43] wut [11:17:08] (03PS2) 10Physikerwelt: Add counter to DatabaseUpdater::setAppliedUpdates [core] - 10https://gerrit.wikimedia.org/r/162286 (https://bugzilla.wikimedia.org/71087) [11:17:16] 3MediaWiki-Vagrant: Unable to push changes to gerrit when using Vagrant - 10https://bugzilla.wikimedia.org/62844#c3 (10Marcin Cieślak) 5NEW>3RESO/INV Can you check your git remote -v If it only lists HTTP remotes ("https://gerrit.wikimedia.org/r/p/mediawiki/core.git"), than the gerrit repo got checked ou... [11:17:37] (03PS8) 10Physikerwelt: Fine grained options for wgMathDisableTeXFilter [extensions/Math] - 10https://gerrit.wikimedia.org/r/158845 [11:18:21] (03PS1) 10Tuxilina: Improved user feedback in html detected upload error [core] - 10https://gerrit.wikimedia.org/r/164726 (https://bugzilla.wikimedia.org/25163) [11:18:52] (03CR) 10jenkins-bot: [V: 04-1] Fine grained options for wgMathDisableTeXFilter [extensions/Math] - 10https://gerrit.wikimedia.org/r/158845 (owner: 10Physikerwelt) [11:19:50] (03CR) 10saper: [C: 031] "Congratulations on your first patch! Happy to see git-review working!" [core] - 10https://gerrit.wikimedia.org/r/164726 (https://bugzilla.wikimedia.org/25163) (owner: 10Tuxilina) [11:20:49] (03PS5) 10Legoktm: Support redirects in JavaScriptContent [core] - 10https://gerrit.wikimedia.org/r/162491 (https://bugzilla.wikimedia.org/71200) [11:24:00] (03CR) 10jenkins-bot: [V: 04-1] Add counter to DatabaseUpdater::setAppliedUpdates [core] - 10https://gerrit.wikimedia.org/r/162286 (https://bugzilla.wikimedia.org/71087) (owner: 10Physikerwelt) [11:25:25] (03CR) 10Amire80: WIP: Add localized and tags (031 comment) [extensions/Cite] - 10https://gerrit.wikimedia.org/r/163467 (https://bugzilla.wikimedia.org/28980) (owner: 10Amire80) [11:25:30] 3MediaWiki / 3File management: Improve user feedback in html detected upload error - 10https://bugzilla.wikimedia.org/25163#c15 (10Roxana Valentina) I changed the message and I added a link to https://www.mediawiki.org/wiki/Remove_Exif_tags . Now I just need some help to make this page accurate, and not full... [11:33:45] 3MediaWiki / 3Internationalization: parser tags such as , , etc. cannot be localized - 10https://bugzilla.wikimedia.org/28980#c19 (10Amir E. Aharoni) I'd like to refocus this issue only on and little else. In actuality, it's not impossible to have these tags localized. It's alrea... [11:34:02] 3MediaWiki / 3Internationalization: parser tags such as , , etc. cannot be localized - 10https://bugzilla.wikimedia.org/28980 (10Amir E. Aharoni) 5NEW>3PATC a:3Amir E. Aharoni [11:42:45] 3MediaWiki-Vagrant: Unable to push changes to gerrit when using Vagrant - 10https://bugzilla.wikimedia.org/62844#c4 (10Marcin Cieślak) If you have any commit outstanding, you need probably to "git commit --amend" again to make sure your Change-Id gets generated and included in the commit message. You can chec... [11:49:50] (03PS3) 10Physikerwelt: Add counter to DatabaseUpdater::setAppliedUpdates [core] - 10https://gerrit.wikimedia.org/r/162286 (https://bugzilla.wikimedia.org/71087) [11:53:15] 3MediaWiki-Vagrant: Unable to push changes to gerrit when using Vagrant - 10https://bugzilla.wikimedia.org/62844#c5 (10Marcin Cieślak) Also, please see https://www.mediawiki.org/wiki/Talk:MediaWiki-Vagrant#SSH_for_default_clone_link.3F for discussion whether default HTTP clone is to blame. [11:54:28] (03CR) 10Umherirrender: "It is possible to use microtime instead of time to avoid the same key in the same second? Or it is possible to get the same key in a mili " [core] - 10https://gerrit.wikimedia.org/r/162286 (https://bugzilla.wikimedia.org/71087) (owner: 10Physikerwelt) [11:58:25] (03PS5) 10Hoo man: Move files into an includes folder [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/164666 [11:58:54] (03CR) 10Hoo man: "Addressed legoktm's comment (thanks for that)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/164666 (owner: 10Hoo man) [11:59:09] (03CR) 10Physikerwelt: "Using milliseconds would solve my problem... but I considered that as a suboptimal solution ... multithreading could be an issue... but it" [core] - 10https://gerrit.wikimedia.org/r/162286 (https://bugzilla.wikimedia.org/71087) (owner: 10Physikerwelt) [12:02:48] (03CR) 10Physikerwelt: "Umherirrender" [core] - 10https://gerrit.wikimedia.org/r/162286 (https://bugzilla.wikimedia.org/71087) (owner: 10Physikerwelt) [12:10:23] (03PS3) 10Hoo man: Convert SpecialRemoveGlobalBlock to use FormSpecialPage [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/145505 (owner: 10Legoktm) [12:17:57] (03CR) 10Hoo man: [C: 032] Convert SpecialRemoveGlobalBlock to use FormSpecialPage [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/145505 (owner: 10Legoktm) [12:20:22] (03Merged) 10jenkins-bot: Convert SpecialRemoveGlobalBlock to use FormSpecialPage [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/145505 (owner: 10Legoktm) [12:23:04] 3MediaWiki-Vagrant: Unable to push changes to gerrit when using Vagrant - 10https://bugzilla.wikimedia.org/62844#c6 (10Helder) (In reply to Marcin Cieślak from comment #3) > Can you check your > > git remote -v > > If it only lists HTTP remotes > ("https://gerrit.wikimedia.org/r/p/mediawiki/core.git"), than... [12:28:01] 3MediaWiki extensions / 3WikidataClient: wikidata entity selector needs adaptation for RTL languges - 10https://bugzilla.wikimedia.org/71552 (10Amir E. Aharoni) [12:29:15] 3MediaWiki extensions / 3AbuseFilter: Warning alternates between default and specified warning - 10https://bugzilla.wikimedia.org/25086#c4 (10se4598) needs no testing, still happening. Toggles between warning and disallow state, -> between (custom) warnmessage and default disallow msg. Thing is, only for war... [12:35:30] 3MediaWiki / 3Unit tests: duplicate key in unittest_updatelog - 10https://bugzilla.wikimedia.org/71087 (10physikerwelt) p:5Unprio>3Normal [12:40:04] (03CR) 10Hoo man: [C: 032] "Going through PDFs is much more fun with this :)" [core] - 10https://gerrit.wikimedia.org/r/150603 (owner: 10Bartosz Dziewoński) [12:46:39] (03Merged) 10jenkins-bot: mediawiki.page.image.pagination: Cache last-loaded pages [core] - 10https://gerrit.wikimedia.org/r/150603 (owner: 10Bartosz Dziewoński) [13:07:00] 3MediaWiki extensions / 3WikidataClient: wikidata entity selector needs adaptation for RTL languges - 10https://bugzilla.wikimedia.org/71552 (10Amir E. Aharoni) 5PATC>3RESO/FIX [13:25:30] 3MediaWiki / 3Internationalization: [Compact links] Respect $wgTranslateNumerals - 10https://bugzilla.wikimedia.org/70109#c2 (10Amir E. Aharoni) My quick guess that it would in core, rather than in ULS. It looks like the JavaScript implementation of number conversion ( mw.language.convertNumber() ) indeed d... [13:30:23] (03PS1) 10Amire80: Whitespace correction [core] - 10https://gerrit.wikimedia.org/r/164728 [13:35:42] (03PS22) 10Hoo man: Adding a JS Class to inputBox to grey out Submit button. [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/120487 (https://bugzilla.wikimedia.org/61606) (owner: 1001tonythomas) [13:40:42] (03CR) 10Hoo man: [C: 032] Adding a JS Class to inputBox to grey out Submit button. [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/120487 (https://bugzilla.wikimedia.org/61606) (owner: 1001tonythomas) [13:43:22] (03PS1) 10Hoo man: Simplify resource definition [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/164729 [13:43:30] (03Merged) 10jenkins-bot: Adding a JS Class to inputBox to grey out Submit button. [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/120487 (https://bugzilla.wikimedia.org/61606) (owner: 1001tonythomas) [13:44:45] 3MediaWiki / 3User login and signup: Not loading site CSS on Special:UserLogin/Preferences breaks wkis which use it to create a skin/theme - 10https://bugzilla.wikimedia.org/71621#c2 (10Zack) Many scripts/styles run on a site level; it does not make sense that they do not work on two pages. CSS is used e.g.... [13:46:18] 3MediaWiki extensions / 3WikidataRepo: Exception from line 202 of ClaimSerializer.php: Invalid claim type specified - 10https://bugzilla.wikimedia.org/71641 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs /w/api.php Exception from line 202 of /srv/mediawiki/php-1.25wmf1/extensions/Wikidata/exten... [13:46:49] (03PS11) 10Florianschmidtwelzow: SpecialVersion: Use Config object instead of globals [core] - 10https://gerrit.wikimedia.org/r/159536 (https://bugzilla.wikimedia.org/70638) [13:47:39] (03CR) 10AndyRussG: Add UserMerge support (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160916 (https://bugzilla.wikimedia.org/67767) (owner: 10Legoktm) [13:48:59] (03CR) 10Brian Wolff: "This error message can also be triggered for non jpeg files too (but that is much more rare). Perhaps something along the lines of If this" [core] - 10https://gerrit.wikimedia.org/r/164726 (https://bugzilla.wikimedia.org/25163) (owner: 10Tuxilina) [13:49:38] (03CR) 10Hoo man: [C: 032] "Let's finally do this" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/145014 (https://bugzilla.wikimedia.org/67793) (owner: 10Liangent) [13:49:58] (03Merged) 10jenkins-bot: Add new variable article_first_contributor [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/145014 (https://bugzilla.wikimedia.org/67793) (owner: 10Liangent) [13:50:01] 3MediaWiki extensions / 3AbuseFilter: Add new variable article_first_contributor - 10https://bugzilla.wikimedia.org/67793 (10Marius Hoch) 5PATC>3RESO/FIX [13:50:19] 3MediaWiki extensions / 3InputBox: type=create allows edit Main page if left empty - 10https://bugzilla.wikimedia.org/62975 (10Marius Hoch) 5PATC>3RESO/FIX [13:52:16] (03PS1) 10Amire80: Respect $wgTranslateNumerals in JavaScript [core] - 10https://gerrit.wikimedia.org/r/164730 (https://bugzilla.wikimedia.org/70109) [13:53:30] 3MediaWiki / 3Internationalization: $wgTranslateNumerals is not respected in JavaScript - 10https://bugzilla.wikimedia.org/70109 (10Amir E. Aharoni) [14:03:02] 3MediaWiki extensions / 3ParserFunctions: ifexist function uses pagelinks table in lieu of better options - 10https://bugzilla.wikimedia.org/12019#c18 (10Jackmcbarn) *** Bug 71636 has been marked as a duplicate of this bug. *** [14:03:02] 3MediaWiki extensions / 3ParserFunctions: {{#ifexist: }} "pollutes" pagelinks table - 10https://bugzilla.wikimedia.org/71636#c3 (10Jackmcbarn) 5NEW>3RESO/DUP Yep. *** This bug has been marked as a duplicate of bug 12019 *** [14:04:02] 3MediaWiki extensions / 3Scribunto: mw.title.exists "pollutes" pagelinks table - 10https://bugzilla.wikimedia.org/71637 (10Jackmcbarn) p:5Unprio>3Low s:5normal>3minor [14:04:02] 3MediaWiki extensions / 3ParserFunctions: ifexist function uses pagelinks table in lieu of better options - 10https://bugzilla.wikimedia.org/12019 (10Jackmcbarn) [14:04:15] 3MediaWiki extensions / 3ParserFunctions: {{#ifexist: }} "pollutes" pagelinks table - 10https://bugzilla.wikimedia.org/71636 (10Jackmcbarn) [14:08:42] (03CR) 10Umherirrender: [C: 032] Whitespace correction [core] - 10https://gerrit.wikimedia.org/r/164728 (owner: 10Amire80) [14:08:42] (03CR) 10Jackmcbarn: [C: 04-1] "The message currently shows up for every upload containing HTML-like things. It should only show up if the HTML is actually in EXIF tags." [core] - 10https://gerrit.wikimedia.org/r/164726 (https://bugzilla.wikimedia.org/25163) (owner: 10Tuxilina) [14:09:23] (03CR) 10Umherirrender: "I have no idea, how to make tests better here. There is a DatabaseTestHelper.php class, maybe you can adapt the TODOs from there." [core] - 10https://gerrit.wikimedia.org/r/162286 (https://bugzilla.wikimedia.org/71087) (owner: 10Physikerwelt) [14:13:09] (03Merged) 10jenkins-bot: Whitespace correction [core] - 10https://gerrit.wikimedia.org/r/164728 (owner: 10Amire80) [14:29:30] 3MediaWiki / 3User preferences: User specified CSS loads on Special:Preferences / Special:UserLogin - 10https://bugzilla.wikimedia.org/70672#c24 (10Bawolff (Brian Wolff)) FWIW, I don't think the security benefit (which is at best minimal) of this change is worth the inconvenience to users who do custom skinn... [14:37:22] (03PS1) 10Amire80: Avoid extra-long code lines [core] - 10https://gerrit.wikimedia.org/r/164732 [14:43:30] 3MediaWiki / 3MediaWiki UI: Fix Special:NewPages - 10https://bugzilla.wikimedia.org/71446#c2 (10Florian) I would like to getting rid of the table layout in this step, too. But this would require to force mw ui for this special page :/ Let me upload a patch to review in WIP-state to discuss this much better :... [14:47:58] (03PS1) 10Florianschmidtwelzow: WIP: Use MediaWiki UI for Special:NewPages [core] - 10https://gerrit.wikimedia.org/r/164733 (https://bugzilla.wikimedia.org/71446) [14:52:35] (03CR) 10BryanDavis: [C: 032] USD suffix for dollar amounts [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/164594 (owner: 10BryanDavis) [15:05:02] 3Wikimedia / 3General/Unknown: Review and deploy IEG grant review application - 10https://bugzilla.wikimedia.org/71597 (10Bryan Davis) [15:05:11] 3MediaWiki / 3MediaWiki UI: Fix Special:NewPages - 10https://bugzilla.wikimedia.org/71446#c4 (10Florian) Created attachment 16669 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16669&action=edit Result of Special:NewPages without table layout [15:05:11] 3Wikimedia / 3Git/Gerrit: Grant submit to JenkinsBot and l10n-bot on wikimedia/iegreview - 10https://bugzilla.wikimedia.org/71642 (10Bryan Davis) 3NEW p:3Unprio s:3normal a:3None The recently created wikimedia/iegreview repository does not allow JenkinsBot to submit patches after it has verified them... [15:05:11] 3Wikimedia / 3Git/Gerrit: Grant submit to JenkinsBot and l10n-bot on wikimedia/iegreview - 10https://bugzilla.wikimedia.org/71642 (10Bryan Davis) [15:05:12] 3Wikimedia / 3General/Unknown: Review and deploy IEG grant review application - 10https://bugzilla.wikimedia.org/71597 (10Bryan Davis) [15:05:13] 3Wikimedia / 3Git/Gerrit: Grant submit to JenkinsBot and l10n-bot on wikimedia/iegreview - 10https://bugzilla.wikimedia.org/71642 (10Bryan Davis) p:5Unprio>3High [15:12:02] 3Wikimedia / 3Git/Gerrit: Grant submit to JenkinsBot and l10n-bot on wikimedia/iegreview - 10https://bugzilla.wikimedia.org/71642 (10Chad H.) 5NEW>3RESO/FIX [15:13:16] (03CR) 10Nikerabbit: Adding a JS Class to inputBox to grey out Submit button. (032 comments) [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/120487 (https://bugzilla.wikimedia.org/61606) (owner: 1001tonythomas) [15:18:24] (03PS1) 10Se4598: code cleanup: $warnMsg is always set before [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/164734 [15:30:33] 3QRpedia: Language is not displayed on language links - 10https://bugzilla.wikimedia.org/71643 (10albin) 3UNCO p:3Unprio s:3normal a:3Kelson [Emmanuel Engelhart] I just tried a QRpedia code for the article "M1 15". The article exists on SVWP and ENWP. When i set my phone to German (as a test) and scann... [15:32:47] 3QRpedia: Language is not displayed on language links - 10https://bugzilla.wikimedia.org/71643 (10albin) [15:34:46] 3QRpedia: Language is not displayed on language links - 10https://bugzilla.wikimedia.org/71643 (10albin) [16:18:18] 3MediaWiki / 3User login and signup: Not loading site CSS on Special:UserLogin/Preferences breaks wkis which use it to create a skin/theme - 10https://bugzilla.wikimedia.org/71621#c3 (10ebrahim) Yes, this is needed on fa, ckb, arz, glk, mzn, ps, pnb. Why? Because all of these wikis are overriding default bro... [16:21:00] 3MediaWiki / 3API: Support for base64 Content-Transfer-Encoding in multipart posts. - 10https://bugzilla.wikimedia.org/35285#c3 (10Fabian) 5RESO/WOR>3REOP I can verify that: The mime is set to png and I upload a png (without using BASE64 it works). --===============3344601353276105990== Content-Type: im... [16:25:22] (03CR) 10Thiemo Mättig (WMDE): [C: 031] Simplify resource definition (031 comment) [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/164729 (owner: 10Hoo man) [16:25:52] (03PS2) 10Umherirrender: Avoid extra-long code lines [core] - 10https://gerrit.wikimedia.org/r/164732 (owner: 10Amire80) [16:25:59] (03CR) 10Umherirrender: [C: 032] Avoid extra-long code lines [core] - 10https://gerrit.wikimedia.org/r/164732 (owner: 10Amire80) [16:33:06] (03Merged) 10jenkins-bot: Avoid extra-long code lines [core] - 10https://gerrit.wikimedia.org/r/164732 (owner: 10Amire80) [16:34:30] (03PS2) 10Amire80: Respect $wgTranslateNumerals in JavaScript [core] - 10https://gerrit.wikimedia.org/r/164730 (https://bugzilla.wikimedia.org/70109) [16:39:18] (03CR) 10Umherirrender: [C: 031] "Needs rebasing" [core] - 10https://gerrit.wikimedia.org/r/161886 (owner: 10Legoktm) [16:53:00] 3Wikimedia / 3General/Unknown: *_minor_mime are varbinary(32) on WMF sites, out of sync with varbinary(100) in MW core - 10https://bugzilla.wikimedia.org/71563#c9 (10Sam Reed (reedy)) (In reply to Bawolff (Brian Wolff) from comment #7) > (In reply to Sam Reed (reedy) from comment #4) > > I just did foundatio... [16:58:22] (03PS1) 10Amire80: Remove dir=auto from firstHeading [core] - 10https://gerrit.wikimedia.org/r/164735 [17:32:13] (03CR) 10Hoo man: [C: 032] code cleanup: $warnMsg is always set before [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/164734 (owner: 10Se4598) [17:32:32] (03Merged) 10jenkins-bot: code cleanup: $warnMsg is always set before [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/164734 (owner: 10Se4598) [17:42:47] 3MediaWiki extensions / 3Math: The MW_MATH_MATHML mode should expose the MathML to accessible tools - 10https://bugzilla.wikimedia.org/66537#c4 (10Frédéric Wang) I wonder whether we want to try something like https://github.com/Khan/KaTeX/issues/38#issuecomment-55802898 instead of the current "display: non... [17:57:52] (03CR) 10Umherirrender: "regression: Notice: Undefined variable: attrs in \includes\actions\HistoryAction.php on line 202" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/163775 (owner: 10Jdlrobson) [18:01:22] Hello. I'm trying to get the MediaWiki-Vagrant up and running, using https://www.mediawiki.org/wiki/MediaWiki-Vagrant#Quick_start and the url in step 4 (get clone https://gerrit.wikimedia.org/r/mediawiki/vagrant) doesn't seem to work. When I go there in the browser, it just tells me 'not found'. Any ideas? [18:02:58] aceforn: browser? [18:03:09] chrome [18:03:18] that's something you have to type in your command line [18:03:22] it has nothing to do with browser [18:04:25] yeah, so when I type it in the command line, it tells me "fatal: destination path 'vagrant' already exists and is not an empty directory" [18:05:43] however, if i try to "git clone https://github.com/wikimedia/mediawiki-vagrant" it clones and says Cloning into 'mediawiki-vagrant' etc. [18:06:13] because that directory doesn't exist [18:06:32] so what's the problem? :) [18:07:59] That's a good question ;) if you think the url in the MediaWiki-Vagrant page is wrong I'll update it to the one that worked for me, but if it's not wrong I must be missing something. Maybe. [18:09:17] I'm at the very starting outs of this, but if the page is wrong I dont' want to leave it for someone else to be confused by, and if its right I'm wondering where I'm going wrong [18:09:23] no big deal though [18:12:53] (03CR) 10Nikerabbit: "This has the same shortcoming as the PHP implementation: it is not language dependent, it just disables all number transliteration." [core] - 10https://gerrit.wikimedia.org/r/164730 (https://bugzilla.wikimedia.org/70109) (owner: 10Amire80) [18:37:36] (03PS6) 10AndyRussG: Add UserMerge support [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160916 (https://bugzilla.wikimedia.org/67767) (owner: 10Legoktm) [18:38:17] 3MediaWiki / 3Database: SQL casting error in Special:ProtectedPages - 10https://bugzilla.wikimedia.org/67065#c4 (10Greg Sabino Mullane) Except MySQL does not support casting to VARCHAR. Sigh. [18:38:57] (03CR) 10AndyRussG: "Moved blob processing to a job. Smoke tested this version, too, seems OK. :)" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160916 (https://bugzilla.wikimedia.org/67767) (owner: 10Legoktm) [18:42:13] (03PS15) 10Bartosz Dziewoński: Implement page status indicators [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) [18:52:46] (03PS16) 10Bartosz Dziewoński: Implement page status indicators [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) [18:52:52] (03PS1) 10Frédéric Wang: Improve the way mathematical formulas are exposed to screen readers. [extensions/Math] - 10https://gerrit.wikimedia.org/r/164736 (https://bugzilla.wikimedia.org/66537) [18:53:08] (03CR) 10Bartosz Dziewoński: "PS15: Rebase. PS16: Fixed per Krinkle." [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [18:57:31] aceforn: I cloned mediawiki/vagrant a couple of days back and it worked fine for me. It created a "vagrant" directory for me. Not "mediawiki-vagrant". I'm on Mac. I remember when I cloned it on Windows a year ago, I had the same problem as yours. Which OS are you on? [18:58:18] (03CR) 10Frédéric Wang: "I tested on Firefox, Chrome, WebKitGTK+ and Opera Presto on Linux and the visual rendering seems correct. The aria-hidden="true" attribute" [extensions/Math] - 10https://gerrit.wikimedia.org/r/164736 (https://bugzilla.wikimedia.org/66537) (owner: 10Frédéric Wang) [19:14:13] (03CR) 10Fomafix: [C: 031] Remove dir=auto from firstHeading [core] - 10https://gerrit.wikimedia.org/r/164735 (owner: 10Amire80) [19:15:58] Niharika: Hmm, I'm on OS X (10.9.5), and while the other (standars?) MediaWiki git link (https://gerrit.wikimedia.org/r/mediawiki/vagrant) didn't work for me, I think I [19:16:34] Not an OS issue then. [19:16:56] Niharika: I think I'm up and running now with the alternate link (https://github.com/wikimedia/mediawiki-vagrant). Then again, if the link worked for you, let's assume that it mostly works :) [19:17:35] Niharika: Thanks for letting me know though. I'll leave the instructions alone. [19:17:58] (03CR) 10Legoktm: [C: 04-1] Respect $wgTranslateNumerals in JavaScript (031 comment) [core] - 10https://gerrit.wikimedia.org/r/164730 (https://bugzilla.wikimedia.org/70109) (owner: 10Amire80) [19:18:01] aceforn: No problem. You should leave a comment on the Talk page though. This needs to be documented. [19:19:56] (03PS3) 10Hashar: make-release: .dir-locals for emacs [tools/release] - 10https://gerrit.wikimedia.org/r/164287 (owner: 10MarkAHershberger) [19:21:48] Niharika: Will do! [19:23:57] (03PS4) 10Hashar: make-release: editors conf for yaml file [tools/release] - 10https://gerrit.wikimedia.org/r/164287 (owner: 10MarkAHershberger) [19:24:04] (03CR) 10Hashar: [C: 032] "PS3: changed commit message to have the first line prefixed with 'make-release: '" [tools/release] - 10https://gerrit.wikimedia.org/r/164287 (owner: 10MarkAHershberger) [19:24:10] (03Merged) 10jenkins-bot: make-release: editors conf for yaml file [tools/release] - 10https://gerrit.wikimedia.org/r/164287 (owner: 10MarkAHershberger) [19:27:02] (03CR) 10Hashar: "I would use bundles and copy paste the list of extension for now. Thought it should not be too hard to add support for bundles inheritanc" [tools/release] - 10https://gerrit.wikimedia.org/r/164288 (owner: 10MarkAHershberger) [19:28:30] 3MediaWiki / 3ResourceLoader: Add configuration option to enable loading modules based on url parameter - 10https://bugzilla.wikimedia.org/27766 (10Helder) [19:28:36] (03CR) 10Hashar: "Still need some tests to be written in tests/test_mwversion.py :-)" [tools/release] - 10https://gerrit.wikimedia.org/r/164289 (owner: 10MarkAHershberger) [19:29:16] (03PS1) 10BryanDavis: Add "required field" description at top of review form [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/164737 [19:29:18] (03PS1) 10BryanDavis: Update wikitext export report [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/164738 [19:29:20] (03PS1) 10BryanDavis: Add sort, pagination and filtering for users table [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/164739 [19:31:20] (03CR) 10BryanDavis: [C: 032] Add "required field" description at top of review form [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/164737 (owner: 10BryanDavis) [19:31:22] (03Merged) 10jenkins-bot: Add "required field" description at top of review form [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/164737 (owner: 10BryanDavis) [19:32:27] (03CR) 10BryanDavis: [C: 032] Update wikitext export report [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/164738 (owner: 10BryanDavis) [19:32:29] (03Merged) 10jenkins-bot: Update wikitext export report [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/164738 (owner: 10BryanDavis) [19:35:06] (03PS2) 10BryanDavis: Add sort, pagination and filtering for users table [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/164739 [19:35:22] (03CR) 10BryanDavis: [C: 032] Add sort, pagination and filtering for users table [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/164739 (owner: 10BryanDavis) [19:35:24] (03Merged) 10jenkins-bot: Add sort, pagination and filtering for users table [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/164739 (owner: 10BryanDavis) [19:54:45] 3MediaWiki / 3Interface: [regression] [[mediawiki:sidebar]] no longer supports entirely numeric headers ("* 3829") - 10https://bugzilla.wikimedia.org/71639 (10Andre Klapper) p:5Unprio>3High [19:55:15] 3MediaWiki extensions / 3ExpandTemplates: ExpandTemplates should show categories - 10https://bugzilla.wikimedia.org/71633 (10Andre Klapper) p:5Unprio>3Low [20:08:24] (03CR) 10Hoo man: [C: 031] "Makes sense to me... If no one minds, I'll merge this soon." [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/162607 (owner: 10Jackmcbarn) [20:13:03] (03CR) 10Aaron Schulz: [C: 032] Add comment to AFL_* constants in Defines.php [core] - 10https://gerrit.wikimedia.org/r/164618 (owner: 10Umherirrender) [20:15:38] (03CR) 10Aaron Schulz: [C: 031] "*bump*" [core] - 10https://gerrit.wikimedia.org/r/152359 (owner: 10Anomie) [20:19:38] (03Merged) 10jenkins-bot: Add comment to AFL_* constants in Defines.php [core] - 10https://gerrit.wikimedia.org/r/164618 (owner: 10Umherirrender) [20:29:01] (03CR) 10Hoo man: [C: 032] Fix for Bug 63980 - Comparison of limits in pingLimiter is incorrect [core] - 10https://gerrit.wikimedia.org/r/138609 (owner: 10Rohan013) [20:35:35] (03Merged) 10jenkins-bot: Fix for Bug 63980 - Comparison of limits in pingLimiter is incorrect [core] - 10https://gerrit.wikimedia.org/r/138609 (owner: 10Rohan013) [20:40:22] Ok, newbie (i.e. me) has one more set-up problem (I think): Following the instructions at https://www.mediawiki.org/wiki/MediaWiki-Vagrant I've cloned the repository and 'vagrant up' gives no error messages, but I'm not sure what is supposed to happen next. I go to the http://127.0.0.1:8080/ address and it says 503 Service Unavailable "The server is temporarily unable to service your request due to maintenance downtime or capacity probl [20:40:22] ems. Please try again later." Any tips on where I go from here? [20:41:16] (03PS15) 10Umherirrender: Use HTMLForms on Special:RevisionDelete [core] - 10https://gerrit.wikimedia.org/r/135197 (https://bugzilla.wikimedia.org/34467) [20:41:42] aceforn: That doesn't sound good. :( A 503 for the main page probably means that the HHVM fcgi container didn't start. [20:42:14] `vagrant ssh` will give you a shell in the VM [20:42:34] from there you can try `sudo service hhvm start` and see if it gives you any error messages [20:43:08] (03CR) 10Umherirrender: "Patch Set 15: Removed all old changes, rebased and now implement the maxlength check by using HTMLForm, but that needs the merge of anothe" [core] - 10https://gerrit.wikimedia.org/r/135197 (https://bugzilla.wikimedia.org/34467) (owner: 10Umherirrender) [20:44:23] There may be errors written to logs/hhvm/error.log in your vagrant directory, /var/log [20:44:40] * bd808 hit return early [20:45:12] other logs may be in /var/log/upstart/hhvm.log [20:46:32] bd808: Ok, cool. Indeed the VM shell gives me an error: "start: Job failed to start" [20:46:54] ok. I guess now we need to figure out why that's failing [20:47:46] /var/log/upstart/hhvm.log may have some clues [20:53:16] 3MediaWiki-Vagrant: Unable to push changes to gerrit when using Vagrant - 10https://bugzilla.wikimedia.org/62844#c7 (10Marcin Cieślak) Is this because of initial MediaWiki checkout as described on https://www.mediawiki.org/wiki/MediaWiki-Vagrant $ git clone https://gerrit.wikimedia.org/r/mediawiki/vagrant $... [20:53:26] (03CR) 10AndyRussG: [C: 04-1] "Hmm got a bug, pls don't merge yet :|" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160916 (https://bugzilla.wikimedia.org/67767) (owner: 10Legoktm) [20:55:47] 3MediaWiki-Vagrant: Unable to push changes to gerrit when using Vagrant - 10https://bugzilla.wikimedia.org/62844#c8 (10Bryan Davis) I just left a longish comment on this topic on the talk page TL;DR is that out of the box the gi... [20:57:43] bd808: Ok. There is no upstart folder in the log file... [21:00:26] I was having some problems initially when I installed, possibly because I already had Vagrant installed. As I got it working there are now two folder in my user, one called 'vagrant' and one called 'mediawiki-vagrant'. Is it possible that my 'vagrant up' command works with the folder that doesn't have any media-wiki stuff in it? [21:04:29] aceforn: It should be fine to have several copies of mediawiki-vagrant on a host computer. I have 5 or 6 copies myself [21:05:24] The vagrant command will try to manage the vm defined in current directory (or a parent dierctory) [21:08:02] 3MediaWiki / 3General/Unknown: Comparison of limits in pingLimiter is incorrect - 10https://bugzilla.wikimedia.org/63980 (10Marius Hoch) 5PATC>3RESO/FIX [21:09:12] bd808: I am finding two folders called hhvm, one under mediawiki-vagrant/puppet/modules, and one under vagrant/logs/hhvm, but the latter is empty [21:10:30] aceforn: Those are on your host computer. Try checking /var/log/upstart/hhvm.log inside the vm. `vagrant ssh` to get a shell there [21:12:56] bd808: Yay! That makes a lot of sense. Thanks! [21:15:36] Hey ho, anyone know about running a debugger on a batch job? [21:16:04] 3OCG / 3PDF renderer: OCG servers fill up their tmpfs - 10https://bugzilla.wikimedia.org/71647 (10Giuseppe Lavagetto) 3NEW p:3Unprio s:3blocke a:3None The tmpfs gets full because of a single page generated. The latest offender, according to the authors.db file, is https://en.wikipedia.org/wiki/Info... [21:16:18] Ok, so in the hhvm.log file, I'm getting the error "Failed to initialize central HHBC repository:\n Failed to open /var/www/.hhvm.hhbc: 14 - unable to open database file\n" [21:16:45] 3OCG / 3PDF renderer: OCG servers fill up their tmpfs - 10https://bugzilla.wikimedia.org/71647#c1 (10Giuseppe Lavagetto) I should have added that it fills up because a 32 gb pdf file gets generated. [21:17:03] 3MediaWiki / 3API: Some French characters break the Lyrics.wikia.com API - 10https://bugzilla.wikimedia.org/71648 (10H.guillaume) 3UNCO p:3Unprio s:3major a:3None Example: http://lyrics.wikia.com/api.php?action=lyrics&func=getSong&artist=MC%20Solaar&song=J%27Connais%20Mon%20R%C3%B4le should return t... [21:17:03] 3MediaWiki-Vagrant: Unable to push changes to gerrit when using Vagrant - 10https://bugzilla.wikimedia.org/62844 (10Marcin Cieślak) 5RESO/INV>3REOP [21:17:08] aceforn: cool. Now we are getting somewhere. I think I may even have an idea what causes that. [21:18:56] The first thing I'd like you to try is checking the version of hhvm that you have installed. I know it *should* be the latest, but maybe it's not. Run `dpkg -l hhvm | grep ii` and see if it says 3.3.0-20140925+wmf2 somewhere in the output. [21:20:35] bd808: That is indeed in the output. Does that mean it's old? [21:21:02] no, that's the lastest greatest. So the fix won't be as easy as I'd hoped. [21:23:08] The problem is that hhvm is trying to create a cache file in the home directory of the www-data user (which is the default place it would put it) and not in the directory that our config should tell it to use [21:23:21] The question is "why?" [21:23:38] Can you tell me what `grep hhvm.repo.local.mode /etc/hhvm/fcgi/php.ini` outputs? [21:25:20] In the VM it outputs 'grep: /etc/hhvm/fcgi/php.ini: No such file or directory'. Should I have done it on my local machine? [21:25:47] aceforn: Nope. That's a command for the vm. And a sign of the problem. :) [21:26:13] When did you clone (or last update) your mediawiki-vagrant directory? [21:27:52] Today. But I did use the link 'https://github.com/wikimedia/mediawiki-vagrant' instead of the one they use in the installation guide on the 'https://www.mediawiki.org/wiki/MediaWiki-Vagrant' page [21:27:54] (03CR) 10Bartosz Dziewoński: [C: 032] Update OOjs UI to v0.1.0-pre (48980881f3) [core] - 10https://gerrit.wikimedia.org/r/164714 (owner: 10Jforrester) [21:28:36] The /etc/hhvm/fcgi/php.ini file was introduced in https://gerrit.wikimedia.org/r/#/c/160571/ which merged about a week ago. [21:28:52] In the output as it was installing I got three errors, but none mention hhvm [21:29:01] Did you have any errors from the initial puppet run when you ran `vagrant up`? [21:29:13] Ah you did have errors [21:29:29] That may be the whole problem then. [21:29:33] And, reading again I realize that one does indeed mention hhvm [21:30:00] Error: Could not start Service[hhvm]: Execution of '/sbin/start hhvm' returned 1: [21:30:00] ==> default: Error: /Stage[main]/Hhvm/Service[hhvm]/ensure: change from stopped to running failed: Could not start Service[hhvm]: Execution of '/sbin/start hhvm' returned 1: [21:30:49] From your host computer, try running `PUPPET_DEBUG=1 vagrant provision | tee puppet.log` and then paste the puppet.log output somewhere so I can check it out. [21:34:27] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (48980881f3) [core] - 10https://gerrit.wikimedia.org/r/164714 (owner: 10Jforrester) [21:37:58] A Vagrant environment or target machine is required to run this [21:37:58] command. Run `vagrant init` to create a new Vagrant environment. Or, [21:37:58] get an ID of a target machine from `vagrant global-status` to run [21:38:00] this command on. A final option is to change to a directory with a [21:38:02] Vagrantfile and to try again. [21:38:49] and then I ran it from a directory with a Vagrantfile, at which point it says "default: VM not created. Moving on..." [21:39:40] aceforn: Where did you try running the command? It should work from the same directory where you ran `vagrant ssh` to connect to the vm. But it should be run on the host computer, not from inside the vm. [21:43:26] Same thing when I run it there... [21:44:32] 3MediaWiki / 3JavaScript: Use latest jQuery - 10https://bugzilla.wikimedia.org/71649 (10Subfader) 3NEW p:3Unprio s:3normal a:3None jQuery 1.8.3 is old. How long to you want it to stay there? Version 2 is a bit faster since it no more supports old IE versions. But I guess MW wants to support old IE... [21:46:33] 3MediaWiki / 3JavaScript: Use latest jQuery - 10https://bugzilla.wikimedia.org/71649#c1 (10Subfader) And since MW uses old jQuery no extension develeoper can use new functions? [21:55:18] aceforn: What version of Vagrant do you have installed? `vagrant --version` [21:56:11] bd808: 1.6.5 [21:57:39] hmmm.. newer than mine. There's something really not right about that output you got though. [21:58:18] So `vagrant ssh` works but `vagrant provision` from the same directory tells you that there is no Vagrant environment to modify [22:02:04] Haven't tried provision. I shut it down and am in the process of restarting it now... [22:04:03] (03PS29) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [22:04:11] (03PS36) 10Paladox: WikiEditor: Fix issue with SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) [22:04:45] (03PS7) 10Paladox: Ace: Update to 08-07-2014 [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/144780 (https://bugzilla.wikimedia.org/60432) (owner: 10TheDJ) [22:08:15] (03PS1) 10Jforrester: OOUI: Switch Minerva skin from deprecated 'Minerva' theme to 'MediaWiki' [core] - 10https://gerrit.wikimedia.org/r/164745 [22:09:29] So, I did vagrant up, and I'm getting the same errors I got when I first did it: https://gist.github.com/anonymous/e1cb2641340e29cf82ec [22:11:01] aceforn: reading the logs ... [22:11:14] (03PS1) 10Jforrester: OOUI: Switch all skins from 'Apex' theme to 'MediaWiki' [core] - 10https://gerrit.wikimedia.org/r/164746 [22:11:42] bd808: Thanks (again) for all your help [22:13:17] (03CR) 10Jforrester: [C: 04-1] "Needs careful testing first." [core] - 10https://gerrit.wikimedia.org/r/164745 (owner: 10Jforrester) [22:13:26] (03CR) 10Jforrester: [C: 04-2] "Not quite yet!" [core] - 10https://gerrit.wikimedia.org/r/164746 (owner: 10Jforrester) [22:14:24] aceforn: yw. During the week I get paid to do this and on the weekend I try to help when I have time. :) [22:16:39] well, that probably makes you awesome :D [22:17:14] aceforn: So it looks like the composer install of mediawiki's dependencies is failing along with several other commands that would be running the hhvm binary. This points back to the config files not being setup correctly for some reason. [22:17:18] aceforn: bd808 just likes to make the rest of us look like slackers. :-) [22:17:41] But interestingly I don't see all of the hhvm configuration output I would expect in the log [22:17:43] (03CR) 10Bartosz Dziewoński: [C: 04-1] OOUI: Switch all skins from 'Apex' theme to 'MediaWiki' (031 comment) [core] - 10https://gerrit.wikimedia.org/r/164746 (owner: 10Jforrester) [22:17:54] James_F: says the guy who never sleeps :) [22:18:06] bd808: :-) [22:18:13] (03CR) 10jenkins-bot: [V: 04-1] OOUI: Switch all skins from 'Apex' theme to 'MediaWiki' [core] - 10https://gerrit.wikimedia.org/r/164746 (owner: 10Jforrester) [22:18:14] hey hey hey, two people get to be awesome [22:18:21] * James_F grins. [22:18:42] I can past the earlier output, to me they look the same, but maybe they're slightly different and there's more stuff there [22:19:37] aceforn: Can you run this for me instead `PUPPET_DEBUG=1 vagrant provision` and paste the long output that it should give you? [22:19:56] That PUPPET_DEBUG bit will add a lot of stuff that may help us [22:20:01] 3Wikimedia / 3Bugzilla: New component for "IEG grant review" - 10https://bugzilla.wikimedia.org/71596#c3 (10Andre Klapper) 5NEW>3RESO/FIX a:3Andre Klapper Created. [22:20:17] (03PS2) 10Jforrester: OOUI: Switch all skins from 'Apex' theme to 'MediaWiki' [core] - 10https://gerrit.wikimedia.org/r/164746 [22:20:33] (03CR) 10Jforrester: OOUI: Switch all skins from 'Apex' theme to 'MediaWiki' (031 comment) [core] - 10https://gerrit.wikimedia.org/r/164746 (owner: 10Jforrester) [22:21:15] (03CR) 10jenkins-bot: [V: 04-1] OOUI: Switch all skins from 'Apex' theme to 'MediaWiki' [core] - 10https://gerrit.wikimedia.org/r/164746 (owner: 10Jforrester) [22:21:20] (03PS3) 10Jforrester: OOUI: Switch all skins from 'Apex' theme to 'MediaWiki' [core] - 10https://gerrit.wikimedia.org/r/164746 [22:21:46] Yes, that is pretty long: https://gist.github.com/anonymous/3aa66fc78362353a68d7 [22:22:17] (03CR) 10jenkins-bot: [V: 04-1] OOUI: Switch all skins from 'Apex' theme to 'MediaWiki' [core] - 10https://gerrit.wikimedia.org/r/164746 (owner: 10Jforrester) [22:23:37] (03PS4) 10Jforrester: OOUI: Switch all skins from 'Apex' theme to 'MediaWiki' [core] - 10https://gerrit.wikimedia.org/r/164746 [22:23:45] Cool. More clues are in there. "Uncaught exception: Could not open extension /usr/lib/hphp/extensions/current/fss.so" [22:25:45] That message tells me that you have an older /etc/hhvm/php.ini that you need [22:26:00] Which leads back to wondering about the state of your mediawiki-vagrant git clone. [22:28:14] `git log --oneline` should show that "9e7f4a1 Add SMTP debugging role" is the HEAD of your checkout if you are up to date. I'm guessing that may not be the case, but confused because I thought you cloned today. [22:28:48] But you don't think it [22:29:35] it's because I cloned from https://github.com/wikimedia/mediawiki-vagrant instead of https://gerrit.wikimedia.org/r/mediawiki/vagrant? [22:30:04] The github mirror updates within minutes (usually seconds). [22:30:08] (03CR) 10jenkins-bot: [V: 04-1] OOUI: Switch all skins from 'Apex' theme to 'MediaWiki' [core] - 10https://gerrit.wikimedia.org/r/164746 (owner: 10Jforrester) [22:30:44] Humor me check the revisions you have locally [22:31:15] 3MediaWiki / 3API: Some French characters break the Lyrics.wikia.com API - 10https://bugzilla.wikimedia.org/71648#c1 (10Sam Reed (reedy)) https://en.wikipedia.org/w/api.php?action=query&prop=info&titles=J%27Connais_Mon_R%C3%B4le (03Merged) 10jenkins-bot: Add role::iegreview [vagrant] - 10https://gerrit.wikimedia.org/r/161950 (owner: 10BryanDavis) [23:08:01] 3Wikimedia / 3IEG grant review: Review and deploy IEG grant review application - 10https://bugzilla.wikimedia.org/71597 (10Bryan Davis) [23:08:30] 3Wikimedia / 3IEG grant review: Security review of IEG grant review - 10https://bugzilla.wikimedia.org/71624 (10Bryan Davis)