[00:02:17] (03PS1) 10Isarra: Fix text colour [skins/Splash] - 10https://gerrit.wikimedia.org/r/164493 [00:02:48] (03CR) 10Isarra: [C: 032] Fix text colour [skins/Splash] - 10https://gerrit.wikimedia.org/r/164493 (owner: 10Isarra) [00:02:52] (03Merged) 10jenkins-bot: Fix text colour [skins/Splash] - 10https://gerrit.wikimedia.org/r/164493 (owner: 10Isarra) [00:02:57] (03CR) 10Cmcmahon: "I agree about the "more radical surgery", the whole looping through a hash is not only far more complicated than it has to be, but is not " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164422 (owner: 10Cmcmahon) [00:04:12] (03CR) 10Gergő Tisza: [C: 032] Switch custom code to wfParseUrl which covers the same bugfix [core] - 10https://gerrit.wikimedia.org/r/164344 (owner: 10Gilles) [00:10:40] (03Merged) 10jenkins-bot: Switch custom code to wfParseUrl which covers the same bugfix [core] - 10https://gerrit.wikimedia.org/r/164344 (owner: 10Gilles) [00:10:59] (03PS4) 10Awight: Extensions can add tests by directory [core] - 10https://gerrit.wikimedia.org/r/163528 [00:16:24] (03CR) 10Kaldari: [C: 032] "Here goes nothing." [core] - 10https://gerrit.wikimedia.org/r/163775 (owner: 10Jdlrobson) [00:22:50] (03Merged) 10jenkins-bot: Hygiene: Make construction of buttons easier [core] - 10https://gerrit.wikimedia.org/r/163775 (owner: 10Jdlrobson) [00:26:42] (03CR) 10Spage: [C: 032] "OK, I'm +2ing but this breaks with locked topics, so needs follow-on work." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164422 (owner: 10Cmcmahon) [00:27:26] (03Merged) 10jenkins-bot: QA: topics that are hidden no longer appear in normal view [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164422 (owner: 10Cmcmahon) [00:31:57] (03CR) 10Hoo man: "This approach is a few lines shorter than using native PHP capabilities, but I'm not convinced." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/163528 (owner: 10Awight) [00:40:46] 3Wikimedia / 3General/Unknown: img_minor_mime (and related fields) are varbinary(32). Not long enough for application/vnd.oasis.opendocument.spreadsheet - 10https://bugzilla.wikimedia.org/71563 (10Sean Pringle) a:3Sean Pringle [00:48:04] (03CR) 10Awight: "That's a good criticism, thanks! I looked around and the author is distributing this class as its own component: phpunit/php-file-iterato" [core] - 10https://gerrit.wikimedia.org/r/163528 (owner: 10Awight) [00:54:07] (03PS19) 10Awight: WIP (bug 56849) Pass true oldid for atomic page save [core] - 10https://gerrit.wikimedia.org/r/94584 [00:55:05] (03CR) 10jenkins-bot: [V: 04-1] WIP (bug 56849) Pass true oldid for atomic page save [core] - 10https://gerrit.wikimedia.org/r/94584 (owner: 10Awight) [00:56:36] (03CR) 10Awight: "PS19: rebase" [core] - 10https://gerrit.wikimedia.org/r/94584 (owner: 10Awight) [01:02:16] (03CR) 10Hoo man: "Somme doc. nitpicking... if you fix that, I'll +2" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/163528 (owner: 10Awight) [01:49:04] 3MediaWiki / 3General/Unknown: Signup broken - FancyCaptcha.class.php: Ran out of captcha images - 10https://bugzilla.wikimedia.org/71587 (10Quiddity) 3NEW p:3Unprio s:3normal a:3None (I'm not sure if this is an extension error (MediaWiki extensions->ConfirmEdit), or server-config error (MediaWiki->M... [02:18:00] 3Wikimedia / 3Site requests: Create Wikivoyage Persian - 10https://bugzilla.wikimedia.org/71382#c6 (10reza1615) (In reply to Aude from comment #5) > populated / updated the sites tables. it now works to add fawikivoyage as a > site link on wikidata. at http://fa.wikivoyage.org/wiki/%D8%B5%D9%81%D8%AD%D9%8... [02:20:52] bawolff: around? [02:20:59] yep [02:21:09] although I'm probably going soonish [02:21:27] bawolff: what was the purpose of https://www.mediawiki.org/wiki/Extension:PageInCat ? [02:22:26] Parser function to find out if a specific page is in a specific category. A friend asked me to make it for some occupy wall street wiki he was involved with [02:22:38] puts pages in cats, and then strokes the cat's belly [02:22:48] i knew the first part :p [02:22:58] you know that's totally fundamentally incompatible with parsoid, right? [02:23:10] and you clearly know about the paradox case since it's documented [02:23:18] Well I think I made it before parsoid existed :P [02:24:04] I think use cases are something like {{#incat:Africa|Display africa specific infobox}} or something like that [02:24:44] i was just posting on the support desk today explaining all the reasons we couldn't add something like that, then i see this, and now i'm waiting for someone to ask for it on enwiki, and we'll have to say no just like we do for Extension:Variables [02:24:45] but yeah, definitely breaks the rule that wikitext cannot depend on the state of the other part of the page [02:25:17] Well we say no to 90% of the extension requests for enwiki, so that shouldn't be too hard [02:25:27] we do? [02:25:58] Hmm, maybe not enwiki - but most extension requests are rejected or ignored [02:26:21] enwiki can't really get it together enough to all agree on something in order to actually request something [02:26:30] But bugzilla is full of denied extension requests [02:27:34] * YuviPanda requests flaggedrevs for enwiki [02:27:55] approved. done. [02:28:04] not kidding. [02:28:10] No, only pending changes [02:28:23] no flagged revisions. That was be too confusing to call it the same thing [02:28:25] pending changes is just flaggedrevs with a strange config flag set [02:28:44] it's enabled on enwiki's Special:Version, and it's only called pending changes because we changed all the system messages [02:43:51] no flagged revs or pending changes please, unless you're going to spend the rest of your waking hours managing them. [02:44:50] Risker: I think it's built into MW 2.0, that's being written in Rust [02:45:26] (since we now have a VPE from Mozilla) [02:46:12] Rust? oh dear. Another term I'm going to have to learn. [02:46:26] Risker: My experiance at wikinews has taught me that flagged revisions is actually a horrible model for "pre-live review" [02:46:54] no kidding, bawolff. especially since you can't actually pick and choose which edits you want to keep [02:47:26] Risker: I was joking about MW2.0 and Rust :) Don't think MW is being rewritten anytime soon [02:47:30] I think it would be an interesting experiment to do a flagged revisions type system, but using a gated-trunk model (like what we do with gerrit) [02:47:45] bawolff: with branches? [02:48:31] aww, YuviPanda, you get me all excited then let me down ;) [02:48:37] Maybe? I haven't thought out the details [02:48:50] Risker: :D one of my specialities, I'm told! [02:49:00] number one thing though, someone would have to make edit conflicts not suck to make that even remotely feasible [02:50:54] * YuviPanda wonders why we don't try to do merges git style on edit confligt, and then throw up only if that fails [03:11:35] YuviPanda: We do (Specificly we shell out to diff3) [03:11:54] huh, so if a EC can be automatically managed, it is? [03:12:00] yep [03:12:18] That's how section editing works [03:12:38] The problem is that edit conflicts are basically taken to be on the unit of a paragraph (Where in code, its on the unit of a line of code) [03:12:58] So you're much more likely to conflict as you have to be editing quite separate areas of the article not to trigger [03:13:29] Someone should experiment with making conflict detection work on the unit of sentences instead of paragraphs maybe [03:16:18] ah [03:16:19] right [03:49:31] 3MediaWiki extensions / 3Collection: Pdf export extension problem with Cquote template - 10https://bugzilla.wikimedia.org/30637#c5 (10reza1615) 5NEW>3RESO/FIX Thanks for new version [03:53:33] (03PS1) 10Ori.livneh: Turn a wfDebug call in MessageCache::get into a wfDebugLog call [core] - 10https://gerrit.wikimedia.org/r/164507 [03:54:45] 3MediaWiki extensions / 3Collection: PDF export extension has problem with &&& in RTL wikis - 10https://bugzilla.wikimedia.org/32316#c7 (10reza1615) most of the bugs are solves except
[03:56:16] 3MediaWiki extensions / 3Collection: PDF export extension fails to render Arabic characters in monospace font - 10https://bugzilla.wikimedia.org/32317#c23 (10reza1615) 5NEW>3RESO/FIX Thanks for new version. [03:58:45] 3MediaWiki extensions / 3Collection: Pdf export doesn't support Justifying Arabic characters - 10https://bugzilla.wikimedia.org/32638#c1 (10reza1615) 5NEW>3RESO/FIX Thanks for new version [04:00:19] 3MediaWiki extensions / 3Collection: Pdf export doesn't support ZWNJ in PDF page titles - 10https://bugzilla.wikimedia.org/32640#c2 (10reza1615) 5NEW>3RESO/FIX Thank for new version [04:03:32] 3MediaWiki extensions / 3Collection: Pdf export doesn't support {{formatnum:}} - 10https://bugzilla.wikimedia.org/30634#c9 (10reza1615) 5NEW>3RESO/FIX Thanks for new version [04:05:00] 3MediaWiki extensions / 3Collection: Bullet points in PDF collection sometimes shown on wrong side for RTL text - 10https://bugzilla.wikimedia.org/41254#c4 (10reza1615) 5RESO/DUP>3RESO/FIX Thanks for new version [04:18:48] 3MediaWiki extensions / 3Collection: Collection extension has problem with inline links - 10https://bugzilla.wikimedia.org/71589 (10reza1615) 3NEW p:3Unprio s:3normal a:3None At http://fa.wikipedia.org/wiki/%DA%A9%D8%A7%D8%B1%D8%A8%D8%B1:Yamaha5/bug_of_pdf The first and Second links at PDF is null b... [04:23:02] 3MediaWiki extensions / 3Collection: Collection extension: external links inside PDF should use local wikis ssl setting - 10https://bugzilla.wikimedia.org/71590 (10reza1615) 3NEW p:3Unprio s:3normal a:3None Form Iran and China Https access is difficult so these two countries use Http for mediawiki pr... [04:25:16] 3MediaWiki / 3General/Unknown: HHVM: segfault when serializing/unserializing large preprocessor cache items - 10https://bugzilla.wikimedia.org/71486#c8 (10Tim Starling) I tried (e), using XML instead of unserialize(): parsing XML was slower than just parsing the original wikitext, and 9 times slower than uns... [04:25:32] 3MediaWiki extensions / 3Collection: Collection extension: at pdf the existing links should be shown in blue - 10https://bugzilla.wikimedia.org/71591 (10reza1615) 3NEW p:3Unprio s:3normal a:3None At http://fa.wikipedia.org/wiki/%DA%A9%D8%A7%D8%B1%D8%A8%D8%B1:Yamaha5/bug_of_pdf At pdf the links (numbe... [04:36:47] 3MediaWiki extensions / 3Collection: Collection extension's font for farsi doesn't have some of unicode characters - 10https://bugzilla.wikimedia.org/71592 (10reza1615) 3NEW p:3Unprio s:3normal a:3None would you please send me the font which is used for Farsi? I edited and sent it to by email. now i... [04:41:29] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: "Automatically enable ..." should actually automatically enable, not require visiting Special:Preferences - 10https://bugzilla.wikimedia.org/62815#c3 (10Matthew Flaschen) Idea: 1. Keep track of date "Automatically enable..." was set to "yes" in a hidden p... [04:42:00] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: "Automatically enable ..." should actually automatically enable, not require visiting Special:Preferences - 10https://bugzilla.wikimedia.org/62815#c4 (10Matthew Flaschen) When you go to the actual preference page, the checkboxes should reflect the logic fr... [04:44:45] 3MediaWiki extensions / 3Collection: Collection extension: external links inside PDF should use IP's loge in ssh - 10https://bugzilla.wikimedia.org/71590 (10reza1615) [04:51:47] 3MediaWiki extensions / 3Scribunto: mw.html doesn't accept tags containing numbers - 10https://bugzilla.wikimedia.org/71594 (10Mr. Stradivarius) 3NEW p:3Unprio s:3normal a:3None In the debug console, the following code: = tostring( mw.html.create( 'h2' ) ) Produces the error "Lua error in mw.html.l... [04:59:02] 3Wikimedia / 3Bugzilla: New component for "IEG grant review" - 10https://bugzilla.wikimedia.org/71596 (10Bryan Davis) 3NEW p:3Unprio s:3normal a:3None The IEG grant review application (bug 62170) is nearing completion of it's initial minimum viable product for the Fall 2014 review cycle. I would like... [05:00:00] 3Wikimedia / 3Bugzilla: New component for "IEG grant review" - 10https://bugzilla.wikimedia.org/71596 (10Bryan Davis) p:5Unprio>3High [05:01:02] 3Wikimedia / 3General/Unknown: Create a proposal review system for IEG and other applications - 10https://bugzilla.wikimedia.org/62170 (10Bryan Davis) [05:01:02] 3Wikimedia / 3Bugzilla: New component for "IEG grant review" - 10https://bugzilla.wikimedia.org/71596 (10Bryan Davis) [05:07:35] 3Wikimedia / 3Bugzilla: New component for "IEG grant review" - 10https://bugzilla.wikimedia.org/71596 (10Bryan Davis) [05:07:35] 3Wikimedia / 3Extension setup: Extensions awaiting code review to be deployed on Wikimedia wikis (tracking) - 10https://bugzilla.wikimedia.org/31235 (10Bryan Davis) [05:07:35] 3Wikimedia / 3General/Unknown: Review and deploy IEG grant review application - 10https://bugzilla.wikimedia.org/71597 (10Bryan Davis) 3NEW p:3Unprio s:3normal a:3None Tracking bug for production deploy of IEG grant review application for the fall 2014 grant review cycle. This is a stand alone PHP a... [05:07:36] 3Wikimedia / 3General/Unknown: Create a proposal review system for IEG and other applications - 10https://bugzilla.wikimedia.org/62170 (10Bryan Davis) [05:08:30] 3Wikimedia / 3General/Unknown: Review and deploy IEG grant review application - 10https://bugzilla.wikimedia.org/71597 (10Bryan Davis) p:5Unprio>3Normal [05:12:01] 3MediaWiki / 3MediaWiki UI: Use mediawiki.ui elements on Special:AllMessages - 10https://bugzilla.wikimedia.org/71254#c6 (10Matthew Flaschen) (In reply to Jared Zimmerman (WMF) from comment #5) > I wouldn't be opposed to using the button style which has icon in it, but I > don't think that control is ready y... [05:13:47] 3MediaWiki extensions / 3Collection: Collection extension doesn't recognize - 10https://bugzilla.wikimedia.org/71598 (10reza1615) 3NEW p:3Unprio s:3normal a:3None Collection extension does not recognize see: http://en.wikipedia.org/wiki/User:Yamaha5/Bug_of_PDF... [05:40:02] 3MediaWiki extensions / 3Collection: Collection extension needs direction improvments for RTL languages - 10https://bugzilla.wikimedia.org/71599 (10reza1615) 3NEW p:3Unprio s:3normal a:3None For RTL languages collection extension detect line direction according to first word. in many cases it is not... [06:05:01] 3MediaWiki extensions / 3Collection: Pdf export doesn't support {{formatnum:}} - 10https://bugzilla.wikimedia.org/30634#c10 (10Nemo) (In reply to reza1615 from comment #9) > Thanks for new version To clarify, did you test the output of the new renderer and verify this bug was fixed? [06:13:15] 3MediaWiki extensions / 3Collection: Pdf export doesn't support {{formatnum:}} - 10https://bugzilla.wikimedia.org/30634#c11 (10reza1615) (In reply to Nemo from comment #10) > (In reply to reza1615 from comment #9) > > Thanks for new version > > To clarify, did you test the output of the new renderer and ver... [06:33:04] (03CR) 10Legoktm: Hygiene: Make construction of buttons easier (032 comments) [core] - 10https://gerrit.wikimedia.org/r/163775 (owner: 10Jdlrobson) [06:43:54] ^demon|away: me not having real internet access :P [07:01:48] 3MediaWiki extensions / 3MassMessage: Skipped delivery due to opting out should not generate watchlist entry - 10https://bugzilla.wikimedia.org/71600 (10wctaiwan) 3NEW p:3Unprio s:3normal a:3None Currently, when a message is delivered, a watchlist entry corresponding to the skipped delivery log entry... [07:08:19] 3MediaWiki extensions / 3MassMessage: MassMessage skipped delivery due to opting out shows up in watchlist anyways - 10https://bugzilla.wikimedia.org/71600 (10Kunal Mehta (Legoktm)) p:5Unprio>3Low [07:12:45] 3Wikimedia / 3Mailing lists: New Mailinglist for Volunteers-Support - 10https://bugzilla.wikimedia.org/69599#c7 (10Muriel Staub) Hi James, would it be possible to set up the list sometime before Sunday? It's WikiCon this weekend in Cologne and we would very much like to work on/with the list already starti... [07:13:48] 3MediaWiki extensions / 3MassMessage: Duplicate message occasionally sent due to redirects not being de-duped properly - 10https://bugzilla.wikimedia.org/71548#c1 (10Kunal Mehta (Legoktm)) This appears to be because we aren't de-duping redirects: https://ba.wikipedia.org/w/index.php?title=%D2%A0%D0%B0%D1%82%... [07:31:11] (03PS8) 10Pastakhov: refactor and extend usability (v 3.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/163544 [07:31:22] (03CR) 10jenkins-bot: [V: 04-1] refactor and extend usability (v 3.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/163544 (owner: 10Pastakhov) [07:36:32] (03PS9) 10Pastakhov: refactor and extend usability (v 3.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/163544 [07:47:01] hello [07:50:14] some changes has check mark , some have +1 , in gerrit. my has +1 . https://gerrit.wikimedia.org/r/164049 . what does it mean? [07:51:31] +1 means that your code doesn't contain any syntax errors, and passes some basic lint checks [07:54:38] there are more changes with empty code review field than with something . is it so hard to make code review? [07:55:13] legoktm: what means check mark ? [07:55:34] not many people know how the language converter actually works unfortunately, so finding reviewers for your patch might be a bit difficult [07:56:19] 3OCG / 3PDF renderer: Change type font, font size, and margins - 10https://bugzilla.wikimedia.org/71581#c1 (10Andre Klapper) p:5Unprio>3Lowest s:5normal>3enhanc Thanks for taking the time to report this! This report covers several aspects, such as type font, font size, and margins. For future refere... [07:58:15] legoktm it is simple modification compared to same uzbek file [08:04:45] 3MediaWiki extensions / 3Collection: Collection extension: at pdf the existing links should be shown in blue - 10https://bugzilla.wikimedia.org/71591#c1 (10Andre Klapper) 5NEW>3RESO/WOR The links are in blue here. [08:06:30] 3MediaWiki extensions / 3Collection: Collection extension's font for farsi lacks some unicode characters - 10https://bugzilla.wikimedia.org/71592#c1 (10Andre Klapper) Creating a PDF based on https://fa.wikipedia.org/wiki/%DA%A9%D8%A7%D8%B1%D8%A8%D8%B1:Yamaha5/bug_of_pdf_2 , I can confirm that many characters... [08:06:45] 3MediaWiki extensions / 3Collection: Collection extension: at pdf the existing links should be shown in blue - 10https://bugzilla.wikimedia.org/71591#c2 (10reza1615) Created attachment 16656 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16656&action=edit pdf [08:07:04] 3MediaWiki extensions / 3Collection: Bullet points in PDF collection sometimes shown on wrong side for RTL text - 10https://bugzilla.wikimedia.org/41254#c5 (10Andre Klapper) 5RESO/FIX>3RESO/WOR rez1615: Please do state explicitly what you have retested a bug report and if the new OCG setup works for you... [08:07:04] 3MediaWiki extensions / 3Collection: Collection extension: at pdf the existing links should be shown in blue - 10https://bugzilla.wikimedia.org/71591#c3 (10reza1615) (In reply to Andre Klapper from comment #1) > The links are in blue here. did you check pdf? please see the attached image. [08:07:04] 3MediaWiki extensions / 3Collection: Pdf export doesn't support ZWNJ in PDF page titles - 10https://bugzilla.wikimedia.org/32640#c3 (10Andre Klapper) reza1615: Please do state explicitly what you have retested a bug report and if the new OCG setup works for you and does not expose the problem anymore. "Than... [08:07:31] 3MediaWiki extensions / 3Collection: PDF export extension fails to render Arabic characters in monospace font - 10https://bugzilla.wikimedia.org/32317#c24 (10Andre Klapper) reza1615: Please do state explicitly what you have retested a bug report and if the new OCG setup works for you and does not expose the... [08:07:45] 3MediaWiki extensions / 3Collection: Pdf export extension problem with Cquote template - 10https://bugzilla.wikimedia.org/30637#c6 (10Andre Klapper) reza1615: Please do state explicitly what you have retested a bug report and if the new OCG setup works for you and does not expose the problem anymore. "Thank... [08:09:00] 3MediaWiki / 3User login and signup: Signup broken - FancyCaptcha.class.php: Ran out of captcha images - 10https://bugzilla.wikimedia.org/71587 (10Andre Klapper) p:5Unprio>3High [08:09:15] 3MediaWiki extensions / 3Collection: Bullet points in PDF collection sometimes shown on wrong side for RTL text - 10https://bugzilla.wikimedia.org/41254#c6 (10reza1615) If you check I was bug reporter and in most of the bugs which are tages the only editor was me! [08:11:30] 3Wikimedia / 3Bugzilla: New component for "IEG grant review" - 10https://bugzilla.wikimedia.org/71596#c1 (10Andre Klapper) See https://www.mediawiki.org/wiki/Bug_management/Project_Maintainers#To_add_a_project_or_component for required information (prefered component name; description). [08:13:45] 3MediaWiki extensions / 3DumpHTML: dumpHTML encounters fatal error: Cannot access protected property LocalRepo::$thumbScriptUrl - 10https://bugzilla.wikimedia.org/69824#c5 (10Nemo) (In reply to s7eph4n from comment #4) > Why not just > revert the patch that introduced the bug? I don't know why, but I'll not... [08:14:30] 3MediaWiki extensions / 3Collection: Collection extension's font for farsi lacks some unicode characters - 10https://bugzilla.wikimedia.org/71592#c2 (10reza1615) (In reply to Andre Klapper from comment #1) > Creating a PDF based on > https://fa.wikipedia.org/wiki/%DA%A9%D8%A7%D8%B1%D8%A8%D8%B1:Yamaha5/ > bug... [08:15:16] 3MediaWiki / 3Page deletion: permalink-curid: missing mw-warning-with-logexcerpt mw-content-ltr section on deleted pages - 10https://bugzilla.wikimedia.org/71578#c1 (10Andre Klapper) p:5Unprio>3Low s:5normal>3minor Thanks for taking the time to report this! Is that a general problem "on deleted page... [08:17:30] 3MediaWiki / 3Database: table_type is removed in MySQL 5.5.3 - 10https://bugzilla.wikimedia.org/71566 (10Andre Klapper) p:5Unprio>3High [08:20:32] 3MediaWiki / 3General/Unknown: Formatting of media player broken inside Listen template - 10https://bugzilla.wikimedia.org/71601 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None Created attachment 16657 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16657&action=edit screenshot of listen tem... [08:21:27] (03PS2) 10Legoktm: table_type -> default_storage_engine [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/164405 (https://bugzilla.wikimedia.org/71566) (owner: 10Reedy) [08:25:44] 3MediaWiki / 3General/Unknown: Formatting of media player broken inside Listen template - 10https://bugzilla.wikimedia.org/71601#c1 (10Ryan Kaldari) Looks like this is caused by a bug in jQuery UI that was fixed a while back: http://bugs.jqueryui.com/ticket/8442 Since we haven't updated jQuery UI in a coupl... [08:29:08] (03CR) 10Legoktm: [C: 032] General cleanup [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/161785 (owner: 10Jack Phoenix) [08:31:26] (03Merged) 10jenkins-bot: General cleanup [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/161785 (owner: 10Jack Phoenix) [08:35:28] (03PS1) 10Kaldari: Backport of jQuery UI bugfix for ui-helper-clearfix class [core] - 10https://gerrit.wikimedia.org/r/164521 (https://bugzilla.wikimedia.org/71601) [08:36:27] (03PS1) 10Legoktm: Remove deprecated GlobalVarConfig::set() [core] - 10https://gerrit.wikimedia.org/r/164522 [08:43:16] (03CR) 10Nemo bis: "Cf. https://gerrit.wikimedia.org/r/#/c/164347/1" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148514 (owner: 10Reedy) [08:52:04] (03PS10) 10Pastakhov: refactor and extend usability (v 3.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/163544 [08:52:11] (03CR) 10jenkins-bot: [V: 04-1] refactor and extend usability (v 3.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/163544 (owner: 10Pastakhov) [08:59:41] (03PS11) 10Pastakhov: refactor and extend usability (v 3.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/163544 [08:59:51] (03CR) 10jenkins-bot: [V: 04-1] refactor and extend usability (v 3.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/163544 (owner: 10Pastakhov) [09:01:58] (03PS12) 10Pastakhov: refactor and extend usability (v 3.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/163544 [09:02:04] (03CR) 10jenkins-bot: [V: 04-1] refactor and extend usability (v 3.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/163544 (owner: 10Pastakhov) [09:04:00] (03PS13) 10Pastakhov: refactor and extend usability (v 3.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/163544 [09:10:43] (03CR) 10Legoktm: "https://github.com/search?q=%22jquery.json%22+%40wikimedia&type=Code&utf8=%E2%9C%93" [core] - 10https://gerrit.wikimedia.org/r/161764 (owner: 10Krinkle) [09:22:27] legoktm: So I can write some SQL queries, but creating tables etc isn't something I know much about... this failed test https://integration.wikimedia.org/ci/job/mwext-BayesianFilter-testextension/2/console (the changeset is merged)... should it be AUTO_INCREMENT instead? [09:24:50] Lcawte: I think that's a mysql vs sqlite difference..try AUTO_INCREMENT? [09:25:15] Hmm, what do the tests use? [09:25:23] jenkins uses sqlite [09:25:43] there are bugs open for it to also run mysql and pgsql [09:27:04] Hmm, how do other files with auto increment pass? [09:27:30] which ones? [09:28:38] Well I assumed there are other sql files using auto increment and somebody would of found a work around to make both mysql and sqlite work? [09:29:24] > cul_id int unsigned not null primary key auto_increment, [09:29:40] that's what CU does, and it works on mysql & sqlite [09:34:07] The file says `wf_id` int(10) unsigned NOT NULL AUTO_INCREMENT... the test is running a slightly different query, I assume there is some MW magic taking place? [09:37:29] no idea...look at DatabaseBase->sourceFile ? [09:45:20] (03PS1) 10Lewis Cawte: [DONOTMERGE] Test test [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/164525 [09:46:15] ... nah, I'm just going to leave this, it's not hurting anyone. [09:47:11] (03Abandoned) 10Lewis Cawte: [DONOTMERGE] Test test [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/164525 (owner: 10Lewis Cawte) [09:49:30] 3MediaWiki / 3JavaScript: Localized brackets can break accesskey handling - 10https://bugzilla.wikimedia.org/65010#c7 (10Fomafix) (In reply to Bartosz Dziewoński from comment #3) > Maybe we could use jQuery attr hooks for this? > http://blog.rodneyrehm.de/archives/11-jQuery-Hooks.html (Just a thought, I > di... [09:53:20] (03PS14) 10Pastakhov: refactor and extend usability (v 3.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/163544 [09:55:00] (03PS1) 10Legoktm: Only load "ext.ajaxpoll" on pages that need it [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/164526 [09:59:11] (03CR) 10Legoktm: "This is currently live on Uncyclopedia, you can see that pages like http://en.uncyclopedia.co/wiki/Uwe_Bowls still have a mw.loader.load([" [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/164526 (owner: 10Legoktm) [10:00:18] 3MediaWiki extensions / 3Collection: External links inside PDF should not be HTTPS when page was accessed via HTTP - 10https://bugzilla.wikimedia.org/71590#c1 (10Andre Klapper) Could you rephrase "use IP's log in ssh"? I'm afraid I don't understand it. Did you mean SSL? What is an "IP's log"? [10:02:25] (03PS15) 10Pastakhov: refactor and extend usability (v 3.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/163544 [10:02:45] 3MediaWiki extensions / 3Collection: Links with non-ASCII characters do not work - 10https://bugzilla.wikimedia.org/71547#c3 (10Andre Klapper) *** Bug 71589 has been marked as a duplicate of this bug. *** [10:02:49] 3MediaWiki extensions / 3Collection: Links with non-ASCII characters do not work - 10https://bugzilla.wikimedia.org/71547 (10Andre Klapper) p:5Unprio>3High [10:02:49] 3MediaWiki extensions / 3Collection: Collection extension has problem with inline links - 10https://bugzilla.wikimedia.org/71589#c1 (10Andre Klapper) 5NEW>3RESO/DUP Hi reza1615. Thanks for taking the time to report this! This particular problem has already been reported into our bug tracking system, but... [10:09:33] 3Wikimedia / 3General/Unknown: Map Warper - No space left on device - 10https://bugzilla.wikimedia.org/71604 (10jeblad) 3NEW p:3Unprio s:3normal a:3None Created attachment 16658 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16658&action=edit Screendump of the error Tried to warp https://com... [10:14:30] 3MediaWiki extensions / 3WikibaseQueryEngine: performance review of WikibaseQueryEngine - 10https://bugzilla.wikimedia.org/67535#c8 (10Jeroen De Dauw) > the tool is being rewritten It is not being "rewritten" - most of it will remain the same. > to remove its dependency on external libraries That is being... [10:21:01] 3MediaWiki / 3General/Unknown: Code quality issues (tracking) - 10https://bugzilla.wikimedia.org/700 (10Kunal Mehta (Legoktm)) [10:21:04] 3MediaWiki / 3General/Unknown: Create a generic container object that stores HTML and ResourceLoader modules - 10https://bugzilla.wikimedia.org/71605 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None In TablePager::getBodyOutput(), a ParserOutput object is currently used because it is a cont... [10:45:15] 3MediaWiki extensions / 3Collection: External links inside PDF should not be HTTPS when page was accessed via HTTP - 10https://bugzilla.wikimedia.org/71590#c2 (10reza1615) (In reply to Andre Klapper from comment #1) > Could you rephrase "use IP's log in ssh"? I'm afraid I don't understand it. > Did you mean... [10:55:20] (03PS6) 10Legoktm: Replace $wgConf->localVHosts by $wgLocalVirtualHosts [core] - 10https://gerrit.wikimedia.org/r/157712 (owner: 10IAlex) [10:56:13] (03CR) 10Legoktm: [C: 032] "PS6: Rebased and changed all the 1.24 --> 1.25." [core] - 10https://gerrit.wikimedia.org/r/157712 (owner: 10IAlex) [11:01:40] Hallo aus WikiCon! :) https://de.wikipedia.org/wiki/Wikipedia:WikiCon_2014 [11:02:38] (03Merged) 10jenkins-bot: Replace $wgConf->localVHosts by $wgLocalVirtualHosts [core] - 10https://gerrit.wikimedia.org/r/157712 (owner: 10IAlex) [11:07:31] 3Wikimedia / 3General/Unknown: Map Warper - No space left on device - 10https://bugzilla.wikimedia.org/71604#c1 (10Tim Waters) Thanks - there was over 200mb left on the / partition however, it probably needed space in /tmp as well. Will free up some space and move thumbnails (only using 100mb so far) over t... [11:12:15] 3Wikimedia / 3General/Unknown: Make Map warper be recognized as a connected app - 10https://bugzilla.wikimedia.org/71257#c2 (10Tim Waters) So...the OAuth admins had not looked at my application for over a month and so the application has expired! A new application is being written. I will CC the OAuth Admin... [11:16:33] 3MediaWiki / 3Database: table_type is removed in MySQL 5.5.3 - 10https://bugzilla.wikimedia.org/71566#c4 (10Sam Reed (reedy)) (In reply to Sam Reed (reedy) from comment #2) > We need to vary on MySQL version to whether we use TABLE_TYPE or > default_storage_engine Unless we want to bump minimum version of M... [11:16:33] 3MediaWiki extensions / 3Collection: Collection extension: in pdf the existing links should be shown in blue - 10https://bugzilla.wikimedia.org/71591#c4 (10Andre Klapper) 5RESO/WOR>3REOP s:5normal>3minor I see, sorry that I misunderstood. The links are in #450000 (using HTML notation). Why should t... [11:20:30] 3MediaWiki extensions / 3Collection: Collection extension: in pdf the existing links should be shown in blue - 10https://bugzilla.wikimedia.org/71591#c5 (10reza1615) In mediawiki pages which existing are blue and none-existing are red. So it is much better to colorize the existing pages in Blue. [11:21:31] 3MediaWiki extensions / 3Collection: Collection extension: in pdf the existing links should be shown in blue - 10https://bugzilla.wikimedia.org/71591#c6 (10reza1615) (In reply to reza1615 from comment #5) > In mediawiki pages which existing are blue and none-existing are red. > So it is much better to color... [11:27:00] 3MediaWiki extensions / 3Collection: Bullet points in PDF collection sometimes shown on wrong side for RTL text - 10https://bugzilla.wikimedia.org/41254 (10Andre Klapper) 5RESO/WOR>3RESO/FIX [11:29:02] 3MediaWiki / 3MediaWiki UI: HTMLMultiSelectField checkboxes do not use MW UI - 10https://bugzilla.wikimedia.org/70473#c2 (10Florian) (In reply to Matthew Flaschen from comment #1) > HTMLMultiSelectField has a TODO to use checkLabel. I'll make this bug about > that class. I wondering, if checkLabel can be us... [11:29:17] 3MediaWiki / 3General/Unknown: Formatting of media player broken inside Listen template - 10https://bugzilla.wikimedia.org/71601#c3 (10Andre Klapper) p:5Unprio>3Normal Is bug 69687 a duplicate of this? [11:30:31] 3MediaWiki / 3General/Unknown: Create a generic container object that stores HTML and ResourceLoader modules - 10https://bugzilla.wikimedia.org/71605 (10Andre Klapper) p:5Unprio>3Low [11:31:30] 3Wikimedia / 3General/Unknown: Map Warper - No space left on device - 10https://bugzilla.wikimedia.org/71604#c2 (10Andre Klapper) What are steps to reproduce to "warp"? I'm not even sure which server this is about and how to be able to see the same outcome / steps to reproduce. [11:32:51] (03CR) 10Bartosz Dziewoński: [C: 032] Split mediawiki.toolbar from mediawiki.action.edit [core] - 10https://gerrit.wikimedia.org/r/161767 (owner: 10Krinkle) [11:37:46] 3Wikimedia / 3General/Unknown: Map Warper - No space left on device - 10https://bugzilla.wikimedia.org/71604#c3 (10Tim Waters) Okay I have moved the warper uploads, to shared project space, which left around 400mb in the /dev/vda1 partition. When the map is added it goes into /tmp first and I believe that... [11:39:12] (03Merged) 10jenkins-bot: Split mediawiki.toolbar from mediawiki.action.edit [core] - 10https://gerrit.wikimedia.org/r/161767 (owner: 10Krinkle) [11:40:45] 3Wikimedia / 3Site requests: Create Wikivoyage Persian - 10https://bugzilla.wikimedia.org/71382#c7 (10Glaisher) (In reply to reza1615 from comment #6) > at > http://fa.wikivoyage.org/wiki/ > %D8%B5%D9%81%D8%AD%D9%87%D9%94_%D8%A7%D8%B5%D9%84%DB%8C and other pages like > http://fa.wikivoyage.org/wiki/%DA%A9%D9... [11:42:04] (03PS4) 10Bartosz Dziewoński: mediawiki.toolbar: Move documentation closer to code [core] - 10https://gerrit.wikimedia.org/r/161780 [11:42:19] (03PS5) 10Bartosz Dziewoński: mediawiki.toolbar: Properly deprecate #init [core] - 10https://gerrit.wikimedia.org/r/161781 [11:44:16] 3Wikimedia / 3Extension setup: Enable Extension:Education Program on Catalan Wikipedia - 10https://bugzilla.wikimedia.org/71381#c6 (10Glaisher) 5NEW>3ASSI a:3Glaisher Thanks. It's now at 81%. I will submit a patch in a few minutes. [11:45:14] (03PS6) 10Bartosz Dziewoński: mediawiki.toolbar: Properly deprecate #init [core] - 10https://gerrit.wikimedia.org/r/161781 [11:48:16] 3MediaWiki extensions / 3Collection: Collection extension: in pdf the existing links should be shown in blue - 10https://bugzilla.wikimedia.org/71591#c7 (10Andre Klapper) (In reply to reza1615 from comment #5) > In mediawiki pages which existing are blue and none-existing are red. How is that relevant in a... [11:48:16] 3Wikimedia / 3General/Unknown: Make Map warper be recognized as a connected app - 10https://bugzilla.wikimedia.org/71257#c3 (10Tim Waters) Actually, all fixed! The application was not expired - it was not in the list of my proposed application because it had actually been approved! Sorry. We can call this... [11:48:30] 3MediaWiki extensions / 3Collection: Existing links in PDF should be shown in blue, non-existing in red - 10https://bugzilla.wikimedia.org/71591 (10Andre Klapper) s:5minor>3enhanc [11:48:34] (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.util: Clean up nextnode logic [core] - 10https://gerrit.wikimedia.org/r/164263 (owner: 10Krinkle) [11:48:46] (03PS1) 10Nikerabbit: Add support for ULS [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/164531 [11:50:00] (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.util: Insert node before updating tooltip for accesskey [core] - 10https://gerrit.wikimedia.org/r/145889 (https://bugzilla.wikimedia.org/67946) (owner: 10Gerrit Patch Uploader) [11:50:53] (03PS1) 10Florianschmidtwelzow: Special:ExpandTemplates: Use MediaWiki UI [core] - 10https://gerrit.wikimedia.org/r/164533 (https://bugzilla.wikimedia.org/71433) [11:51:24] (03CR) 10jenkins-bot: [V: 04-1] Add support for ULS [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/164531 (owner: 10Nikerabbit) [11:52:31] 3MediaWiki extensions / 3WikidataRepo: badge should be shown with label not ID in diff - 10https://bugzilla.wikimedia.org/69832 (10Marius Hoch) 5PATC>3RESO/FIX [11:53:25] (03PS1) 10Jackmcbarn: Allow numbers in tag names [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/164535 (https://bugzilla.wikimedia.org/71594) [11:55:08] (03Merged) 10jenkins-bot: mediawiki.util: Clean up nextnode logic [core] - 10https://gerrit.wikimedia.org/r/164263 (owner: 10Krinkle) [11:56:24] (03Merged) 10jenkins-bot: mediawiki.util: Insert node before updating tooltip for accesskey [core] - 10https://gerrit.wikimedia.org/r/145889 (https://bugzilla.wikimedia.org/67946) (owner: 10Gerrit Patch Uploader) [11:57:32] 3Wikimedia / 3Site requests: Create Wikivoyage Persian - 10https://bugzilla.wikimedia.org/71382#c8 (10Glaisher) 5PATC>3RESO/FIX And this has now been done and the interwiki links at fawikivoyage point to wikivoyage wikis. [12:00:02] 3MediaWiki / 3Patrolling: Add Extension:Patroller to core - 10https://bugzilla.wikimedia.org/71607 (10Subfader) 3NEW p:3Unprio s:3normal a:3None https://www.mediawiki.org/wiki/Extension:Patroller is a great way to patroll through recent changes. It is no more maintained and should be added to core.... [12:02:46] 3MediaWiki / 3Patrolling: Add Extension:Patroller to core - 10https://bugzilla.wikimedia.org/71607#c1 (10Sam Reed (reedy)) I guess someone importing it into git, and bringing it up to date would be a good start... [12:07:22] (03CR) 10Hoo man: [C: 032] "A test case would have been nice" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/164535 (https://bugzilla.wikimedia.org/71594) (owner: 10Jackmcbarn) [12:09:19] (03Merged) 10jenkins-bot: Allow numbers in tag names [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/164535 (https://bugzilla.wikimedia.org/71594) (owner: 10Jackmcbarn) [12:10:18] 3MediaWiki extensions / 3Scribunto: mw.html doesn't accept tags containing numbers - 10https://bugzilla.wikimedia.org/71594 (10Jackmcbarn) 5PATC>3RESO/FIX a:3Jackmcbarn [12:22:00] 3MediaWiki extensions / 3Collection: Existing links in PDF should be shown in blue, non-existing in red - 10https://bugzilla.wikimedia.org/71591#c8 (10Marcin Cieślak) (In reply to reza1615 from comment #3) > (In reply to Andre Klapper from comment #1) > > The links are in blue here. > > did you check pdf? p... [12:25:20] (03PS2) 10Nemo bis: Add support for ULS in language filter selector [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/164531 (owner: 10Nikerabbit) [12:25:28] (03CR) 10jenkins-bot: [V: 04-1] Add support for ULS in language filter selector [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/164531 (owner: 10Nikerabbit) [12:28:01] (03PS3) 10Nemo bis: Add support for ULS in language filter selector [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/164531 (owner: 10Nikerabbit) [12:29:09] hey!! [12:29:42] I am trying to use:git clone https://gerrit.wikimedia.org/r/p/mediawiki/skins/Vector.git [12:30:12] inside my /var/www/html/core folder but i am getting the following error [12:30:34] 3MediaWiki / 3Patrolling: Add Extension:Patroller to core - 10https://bugzilla.wikimedia.org/71607#c2 (10Andre Klapper) p:5Unprio>3Lowest s:5normal>3enhanc [Title does not describe a bug but a solution or feature / new functionality. Hence setting priority to enhancement.] Not sure whether to mark... [12:31:20] https://www.irccloud.com/pastebin/zPGSD2Et [12:32:16] 3MediaWiki / 3JavaScript: accessKeyLabel not available in Firefox for addPortletLink - 10https://bugzilla.wikimedia.org/67946#c5 (10Bartosz Dziewoński) 5PATC>3RESO/FIX As I understand it this issue is fixed, with the jquery.accessKeyLabel patch being a more generic solution. [12:32:16] 3MediaWiki / 3JavaScript: accessKeyLabel not available in Firefox for addPortletLink - 10https://bugzilla.wikimedia.org/67946 (10Bartosz Dziewoński) [12:32:28] (03CR) 10Nemo bis: [C: 031] "Looks good in test" [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/164531 (owner: 10Nikerabbit) [12:34:21] sorry..i did not get you [12:35:00] 3MediaWiki extensions / 3Collection: Existing links in PDF should be shown in blue, non-existing in red - 10https://bugzilla.wikimedia.org/71591#c9 (10reza1615) Created attachment 16660 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16660&action=edit pdf [12:49:18] 3MediaWiki / 3Categories: False positive for non-empty redirected categories - 10https://bugzilla.wikimedia.org/71610 (10Dan) 3UNCO p:3Unprio s:3normal a:3None On rowiki currently exists about 200 empty redirected categories which are considered non-empty by MediaWiki software and therefore are place... [12:49:59] 3MediaWiki / 3Categories: False positive for non-empty redirected categories - 10https://bugzilla.wikimedia.org/71610 (10Dan) [12:54:30] 3Wikimedia / 3General/Unknown: img_minor_mime (and related fields) are varbinary(32). Not long enough for application/vnd.oasis.opendocument.spreadsheet - 10https://bugzilla.wikimedia.org/71563#c2 (10Sam Reed (reedy)) ALTER TABLE /*_*/filearchive MODIFY COLUMN fa_minor_mime varbinary(100) default "unknown"... [12:55:29] 3Wikimedia / 3General/Unknown: img_minor_mime (and related fields) are varbinary(32). Not long enough for application/vnd.oasis.opendocument.spreadsheet - 10https://bugzilla.wikimedia.org/71563#c3 (10Sam Reed (reedy)) Checked enwiki and commons too. I guess it's all "older" sites that haven't been updated [13:12:15] 3Wikimedia / 3General/Unknown: img_minor_mime (and related fields) are varbinary(32). Not long enough for application/vnd.oasis.opendocument.spreadsheet - 10https://bugzilla.wikimedia.org/71563#c4 (10Sam Reed (reedy)) I just did foundationwiki... How do we get the minor_mimie fields to update? [13:18:50] (03CR) 10Jack Phoenix: [C: 031] "+2, except I'm not actually able to +2 this." [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/164526 (owner: 10Legoktm) [13:26:59] 3Wikimedia / 3General/Unknown: *_minor_mime are varbinary(32) on WMF sites, out of sync with varbinary(100) in MW core - 10https://bugzilla.wikimedia.org/71563 (10Sam Reed (reedy)) [13:27:30] (03PS4) 10Anomie: Allow for dynamically-loaded PHP libraries [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/163211 [13:27:34] (03CR) 10Alex Monk: [C: 032] Only load "ext.ajaxpoll" on pages that need it [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/164526 (owner: 10Legoktm) [13:27:43] (03Merged) 10jenkins-bot: Only load "ext.ajaxpoll" on pages that need it [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/164526 (owner: 10Legoktm) [13:50:04] (03PS1) 10Manybubbles: Add support for ngram accelerated regexes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/164551 [13:51:27] (03CR) 10Manybubbles: "We can totally merge this and rebuild the indexes with the change. It can go along with the rebuilds required for Idf0818bd9933edc74704a6" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/164551 (owner: 10Manybubbles) [13:58:01] (03CR) 10Chad: [C: 032] Add support for ngram accelerated regexes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/164551 (owner: 10Manybubbles) [13:58:22] (03Merged) 10jenkins-bot: Add support for ngram accelerated regexes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/164551 (owner: 10Manybubbles) [13:58:24] ^demon|away: thanks! [13:58:36] <^demon|away> yw :) [13:58:45] I wanna try it in beta soon-ish [13:59:00] let me see what the extra size cost is first..... [13:59:11] <^demon|away> We could go ahead and merge the config for beta when you're ready [13:59:13] I'll check in an hour or so once I'm sure its there [13:59:23] <^demon|away> mk [13:59:25] <^demon|away> *mmk [13:59:50] (03CR) 10Jackmcbarn: [C: 032] Allow for dynamically-loaded PHP libraries [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/163211 (owner: 10Anomie) [14:01:47] (03Merged) 10jenkins-bot: Allow for dynamically-loaded PHP libraries [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/163211 (owner: 10Anomie) [14:03:45] https://www.mediawiki.org/wiki/HHVM/Server_Admin_Log - why is this here? :/ [14:27:14] (03PS1) 10Manybubbles: Fix mistake with accelerated regex plugin config [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/164555 [14:27:37] (03PS1) 10Manybubbles: Add url parameter to enable accelerated regexes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/164556 [14:33:45] 3Wikimedia / 3General/Unknown: *_minor_mime are varbinary(32) on WMF sites, out of sync with varbinary(100) in MW core - 10https://bugzilla.wikimedia.org/71563#c5 (10Bawolff (Brian Wolff)) They update next time someone purges the image description page. Suppose we could write a mantinance script, although is... [14:40:01] 3MediaWiki / 3User preferences: User specified CSS loads on Special:Preferences / Special:UserLogin - 10https://bugzilla.wikimedia.org/70672#c22 (10timmrysk) (In reply to Markus Glaser from comment #15) > Giving early access to Wikia What about those of us who are running giant platforms as well such as Gam... [14:42:45] 3MediaWiki / 3User preferences: User specified CSS loads on Special:Preferences / Special:UserLogin - 10https://bugzilla.wikimedia.org/70672#c23 (10Alexia E. Smith) It appears this change is also affecting custom skin CSS(Mediawiki:Vector.css) instead of only cusotm user CSS. This prevents custom site style... [14:48:42] (03PS1) 10Jackmcbarn: Return registerInterface() per Ibdc1f4ef [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/164561 [14:49:16] 3MediaWiki / 3Uploading: Internal error: Could not determine if the copy succeeded. - 10https://bugzilla.wikimedia.org/43967#c10 (10Nemo) Just got this on https://commons.wikimedia.org/wiki/File:Practica_D._magistri_V00241_00000004.tif Error console says the following, dunno if related: 2 Validation error... [14:49:57] (03PS1) 10Jackmcbarn: Return registerInterface() per Ibdc1f4ef [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/164562 [14:52:28] (03PS9) 10Jackmcbarn: Add a Lua library to get stability settings [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/132956 [14:52:37] (03PS10) 10Jackmcbarn: Add a Lua library to get stability settings [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/132956 [15:00:37] Question about the latest security patch. Was it supposed to stop pulling CSS from the standard pages like Mediawiki:Vector.css? [15:02:01] Telshin: only on the login page and Special:Preferences [15:03:52] arguably to prevent a malicious CSS rule to execute JavaScript on those pages (with IE it's possible) or something like that [15:04:37] It kills custom site skins loaded through the Mediawiki namespace though. That is a fairly major bug. [15:05:10] I can see the point of stopping that CSS, but it seems stopping all CSS/JS is a rather nuclear option. [15:05:17] does it kill them everywhere, or just on those 2 pages? and if you have an actual skin, you should set it up as one instead of hacking through the MediaWiki namespace [15:05:51] Considering that the Mediawiki namespace by default requires sysops privileges to edit that should be a non-issue. If the wiki admin is add malicious Javascript through Mediawiki:Vector.css then there are bigger problems for that wiki. [15:05:58] *adding [15:06:56] (03PS1) 10Manybubbles: Move misplaced test [search/extra] - 10https://gerrit.wikimedia.org/r/164564 [15:07:02] if you made your own skin, why don't you install it as a real skin instead of piggybacking off of vector? [15:07:30] (03PS1) 10Manybubbles: Fix installation instructions [search/extra] - 10https://gerrit.wikimedia.org/r/164565 [15:07:38] Telshin: JS wasn't being loaded already, but CSS was [15:07:41] So even minor style tweaks such as a small color change would require an entirely different skin each time. That is pants on head retarded. [15:08:37] (03CR) 10Manybubbles: "These instructions aren't valid yet anyway because we haven't released the project but we may as well be more right." [search/extra] - 10https://gerrit.wikimedia.org/r/164565 (owner: 10Manybubbles) [15:08:58] the security patch was obviously for WMF and other wiki farms [15:09:08] We do run a wiki farm :P [15:10:41] Mihau: why do you care about minor tweaks to the login or preferences pages? [15:11:51] jackmcbarn: Background colors, logo position, anchor colors, etcetera. All minor changes that would suddenly disappear making it look like the user was on a different site for the log in page. [15:13:57] Vulpix - I'm very confused the point of the statement and the security patch. We run a large wiki farm as well. [15:15:23] Telshin: what's the source of your confusion? I don't quite understand [15:18:41] It seems like a simple checking in the parser level when a *.css page is saved for #-moz-binding:.*?url#is and #behavior:.*?url#is would be a more sincere solution by preventing the Javascript from ever getting into the CSS. JS should stay in JS and Mediawiki itself could enforce the CSS to stay clean to allow it to be used. [15:19:14] *Regexs may not be perfect. [15:19:17] *Regexes [15:34:46] (03CR) 10Anomie: [C: 032] Made upload jobs avoid using the user session [core] - 10https://gerrit.wikimedia.org/r/163766 (owner: 10Aaron Schulz) [15:41:18] (03Merged) 10jenkins-bot: Made upload jobs avoid using the user session [core] - 10https://gerrit.wikimedia.org/r/163766 (owner: 10Aaron Schulz) [15:45:00] 3MediaWiki / 3Uploading: Chunked upload of SVGs triggers INVALIDXML exception, but file is valid - 10https://bugzilla.wikimedia.org/65724#c7 (10Brad Jorsch) 5UNCO>3NEW It isn't anything unique to large SVGs, any SVG will trigger this problem. I've been testing locally with SVGs like the following (and ve... [15:54:00] (03PS1) 10Anomie: Don't try to verify XML well-formedness for partial SVG uploads [core] - 10https://gerrit.wikimedia.org/r/164569 (https://bugzilla.wikimedia.org/65724) [15:57:03] (03CR) 10Anomie: "Chris: Do we need to worry about some browser having a non-strict SVG parser that either ignores the invalid XML in the partial upload or " [core] - 10https://gerrit.wikimedia.org/r/164569 (https://bugzilla.wikimedia.org/65724) (owner: 10Anomie) [16:02:28] (03PS1) 10Anomie: Fix Status serialization with cleanupCallback as Closure [core] - 10https://gerrit.wikimedia.org/r/164570 [16:08:38] 3MediaWiki / 3Page deletion: permalink-curid: missing mw-warning-with-logexcerpt mw-content-ltr section on deleted pages - 10https://bugzilla.wikimedia.org/71578#c2 (10boshomi) yes I think it is a general problem. Here are some pages: https://de.wikipedia.org/w/index.php?curid=7457267 https://de.wikipedia... [16:09:23] (03PS1) 10Gilles: Avoid attempting to prerender thumbnails that will fail [core] - 10https://gerrit.wikimedia.org/r/164571 [16:11:50] (03CR) 10Anomie: [C: 032] Return registerInterface() per Ibdc1f4ef [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/164561 (owner: 10Jackmcbarn) [16:12:02] (03Merged) 10jenkins-bot: Return registerInterface() per Ibdc1f4ef [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/164561 (owner: 10Jackmcbarn) [16:12:14] (03CR) 10Anomie: [C: 032] Return registerInterface() per Ibdc1f4ef [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/164562 (owner: 10Jackmcbarn) [16:12:27] (03Merged) 10jenkins-bot: Return registerInterface() per Ibdc1f4ef [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/164562 (owner: 10Jackmcbarn) [16:17:08] (03CR) 10Chad: [C: 032] Fix mistake with accelerated regex plugin config [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/164555 (owner: 10Manybubbles) [16:17:27] (03Merged) 10jenkins-bot: Fix mistake with accelerated regex plugin config [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/164555 (owner: 10Manybubbles) [16:17:43] (03CR) 10Chad: [C: 032] Add url parameter to enable accelerated regexes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/164556 (owner: 10Manybubbles) [16:17:56] (03CR) 10Chad: [C: 032] Move misplaced test [search/extra] - 10https://gerrit.wikimedia.org/r/164564 (owner: 10Manybubbles) [16:18:00] (03Merged) 10jenkins-bot: Add url parameter to enable accelerated regexes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/164556 (owner: 10Manybubbles) [16:18:11] (03CR) 10Chad: [C: 032] Fix installation instructions [search/extra] - 10https://gerrit.wikimedia.org/r/164565 (owner: 10Manybubbles) [16:18:17] (03CR) 10CSteipp: "We do need to be careful about both." [core] - 10https://gerrit.wikimedia.org/r/164569 (https://bugzilla.wikimedia.org/65724) (owner: 10Anomie) [16:18:32] (03Merged) 10jenkins-bot: Move misplaced test [search/extra] - 10https://gerrit.wikimedia.org/r/164564 (owner: 10Manybubbles) [16:19:04] (03Merged) 10jenkins-bot: Fix installation instructions [search/extra] - 10https://gerrit.wikimedia.org/r/164565 (owner: 10Manybubbles) [16:22:29] 3MediaWiki / 3Uploading: Internal error: Could not determine if the copy succeeded. - 10https://bugzilla.wikimedia.org/43967#c11 (10Bawolff (Brian Wolff)) (In reply to Gilles Dubuc from comment #9) > I confirm that this is probably coming from chunked upload-specific APIs. > More specifically "checkStatus",... [16:30:53] (03CR) 10Brian Wolff: "What about if we just add an option to XMLTypeCheck to check partial files, where it leaves the third argument to xml_parse as false?" [core] - 10https://gerrit.wikimedia.org/r/164569 (https://bugzilla.wikimedia.org/65724) (owner: 10Anomie) [16:32:29] (03PS1) 10Cmcmahon: QA: update RSpec assertions and alphabetize [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164572 [16:33:17] (03CR) 10CSteipp: [C: 031] "I'm ok doing it this way. If hoo feels strongly about it, we should probably refactor it. I don't see this getting us into much more tech " [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/164055 (https://bugzilla.wikimedia.org/71495) (owner: 10Alex Monk) [16:36:16] 3Wikimedia / 3General/Unknown: bits.wikimedia.org discourages indexing, resulting in goofy archive.org snapshots - 10https://bugzilla.wikimedia.org/65464#c8 (10Glaisher) (In reply to Nemo from comment #7) > https://bits.wikimedia.org/robots.txt is a 404 now, what happened? Is that > the cause? I85dcec2a168b... [16:40:31] (03PS1) 10QChris: [DO NOT SUBMIT] Test to check whether or nor uploading for review works [extensions/Vector] - 10https://gerrit.wikimedia.org/r/164573 [16:40:52] (03Abandoned) 10QChris: [DO NOT SUBMIT] Test to check whether or nor uploading for review works [extensions/Vector] - 10https://gerrit.wikimedia.org/r/164573 (owner: 10QChris) [16:51:37] (03CR) 10Paladox: [C: 032 V: 032] Add .gitreview file [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/163970 (owner: 10Florianschmidtwelzow) [16:54:35] (03PS1) 10Paladox: Add .gitreview file [skins/Metrolook] (MediaWiki-1.24) - 10https://gerrit.wikimedia.org/r/164575 [16:58:03] (03CR) 10Florianschmidtwelzow: "Is there a reason for such branches? Why not use the MediaWiki release namens for major versions:" [skins/Metrolook] (MediaWiki-1.24) - 10https://gerrit.wikimedia.org/r/164575 (owner: 10Paladox) [16:59:17] (03CR) 10Jdlrobson: [C: 04-1] Special:ExpandTemplates: Use MediaWiki UI (033 comments) [core] - 10https://gerrit.wikimedia.org/r/164533 (https://bugzilla.wikimedia.org/71433) (owner: 10Florianschmidtwelzow) [17:02:23] (03PS2) 10Paladox: Add .gitreview file [skins/Metrolook] (MediaWiki-1.24) - 10https://gerrit.wikimedia.org/r/164575 [17:03:13] (03CR) 10Paladox: "Oh ok I will do that then. how can I do that and rename branches." [skins/Metrolook] (MediaWiki-1.24) - 10https://gerrit.wikimedia.org/r/164575 (owner: 10Paladox) [17:03:27] (03CR) 10Paladox: [C: 032 V: 032] Add .gitreview file [skins/Metrolook] (MediaWiki-1.24) - 10https://gerrit.wikimedia.org/r/164575 (owner: 10Paladox) [17:03:42] (03CR) 10Florianschmidtwelzow: "Ah, great to clarify this :D I think i misunderstood the whole bug report, i thought it should be like Special:Search, that mw ui should b" [core] - 10https://gerrit.wikimedia.org/r/164533 (https://bugzilla.wikimedia.org/71433) (owner: 10Florianschmidtwelzow) [17:05:13] (03PS1) 10Paladox: Add .gitreview file [skins/Metrolook] (MediaWiki-1.23) - 10https://gerrit.wikimedia.org/r/164576 [17:06:45] 3Wikimedia / 3Extension setup: Enable #lsth from Labeled Section Transclusion on pt.wikiversity - 10https://bugzilla.wikimedia.org/61804#c8 (10Greg Grossmeier) (Chris: Just doing due-diligence: Do you feel the need to review Extension:Labeled_Section_Transclusion if we enable another part of it?) After too... [17:07:18] (03PS1) 10Jack Phoenix: Documentation tweaks only [extensions/EditSimilar] - 10https://gerrit.wikimedia.org/r/164577 [17:07:54] (03CR) 10Jack Phoenix: [C: 032 V: 032] Documentation tweaks only [extensions/EditSimilar] - 10https://gerrit.wikimedia.org/r/164577 (owner: 10Jack Phoenix) [17:09:20] (03PS2) 10Paladox: Add .gitreview file [skins/Metrolook] (MediaWiki-1.23) - 10https://gerrit.wikimedia.org/r/164576 [17:09:25] (03CR) 10Florianschmidtwelzow: "Recreate them :) Go to your project, click to branches, copy the sha1 hash and create a new branch with this as initial revision. After th" [skins/Metrolook] (MediaWiki-1.24) - 10https://gerrit.wikimedia.org/r/164575 (owner: 10Paladox) [17:09:46] (03CR) 10Paladox: [C: 032 V: 032] Add .gitreview file [skins/Metrolook] (MediaWiki-1.23) - 10https://gerrit.wikimedia.org/r/164576 (owner: 10Paladox) [17:10:34] ashley: hmm, we should get you +2 on that repo... [17:11:02] legoktm: wha, a major contributor should have +2 on their stuff? nowai! (-; [17:14:16] legoktm: have you one minute for https://gerrit.wikimedia.org/r/#/c/159536 ?? :) [17:15:25] FlorianSW: did you test that it works properly with the installer? it looks like it should, but I haven't had time to test it yet [17:16:14] legoktm: ähm...installer...damn :/ Sorry, give me some minutes [17:18:00] liangent: hey! do you know if wiki is blocked in China again? [17:19:21] bawolff: why are the image URLs for TIFF thumbs now wrong on http://tools.wmflabs.org/glamtools/glamorous.php?doit=1&category=Media_from_BEIC&use_globalusage=1&show_details=1&show_details_limited=1#details [17:20:04] (03CR) 10Legoktm: "" [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/164526 (owner: 10Legoktm) [17:21:23] I don't know if/when they were working, actually. I see the file page links something like .../lossy-page1-187px-Medicina_mentis_176802_1_00007.tif.jpg while the tool loads something like .../80px-Medicina_mentis_176802_1_00007.tif [17:21:27] Nemo_bis: Hmm. The format of the url hasn't changed [17:21:56] I have no idea where the tool gets its url from, but 80px-Medicina_mentis_176802_1_00007.tif never worked afaik [17:22:32] (03PS5) 10Chad: Rewrite BlobStore support [search/repository-swift] - 10https://gerrit.wikimedia.org/r/158279 [17:22:34] (03PS1) 10Chad: Simplify pom and adjust to track upstream a bit better [search/repository-swift] - 10https://gerrit.wikimedia.org/r/164579 [17:22:39] (03PS1) 10Jack Phoenix: Various tweaks and modernization [extensions/EditSimilar] - 10https://gerrit.wikimedia.org/r/164580 [17:22:40] I think you could find out where the tool gets its url from? [17:22:45] (03PS2) 10Florianschmidtwelzow: Special:ExpandTemplates: Use MediaWiki UI [core] - 10https://gerrit.wikimedia.org/r/164533 (https://bugzilla.wikimedia.org/71433) [17:23:02] (03CR) 10Jack Phoenix: [C: 032 V: 032] Various tweaks and modernization [extensions/EditSimilar] - 10https://gerrit.wikimedia.org/r/164580 (owner: 10Jack Phoenix) [17:23:04] (03CR) 10jenkins-bot: [V: 04-1] Simplify pom and adjust to track upstream a bit better [search/repository-swift] - 10https://gerrit.wikimedia.org/r/164579 (owner: 10Chad) [17:23:43] (03CR) 10Florianschmidtwelzow: Special:ExpandTemplates: Use MediaWiki UI (031 comment) [core] - 10https://gerrit.wikimedia.org/r/164533 (https://bugzilla.wikimedia.org/71433) (owner: 10Florianschmidtwelzow) [17:24:20] I feel guilty adding so many tickets when I perhaps sent only one patch ever. Oh well https://bitbucket.org/magnusmanske/glamtools/issues [17:26:02] (03PS2) 10Chad: Simplify pom and adjust to track upstream a bit better [search/repository-swift] - 10https://gerrit.wikimedia.org/r/164579 [17:26:04] (03PS6) 10Chad: Rewrite BlobStore support [search/repository-swift] - 10https://gerrit.wikimedia.org/r/158279 [17:27:05] bawolff: what should it be using, Special:Redirect as Duesentrieb said on commons-l some weeks ago? [17:27:32] That's probably easiest [17:28:39] (03CR) 10Paladox: "Ok thanks I have changed them now." [skins/Metrolook] (MediaWiki-1.24) - 10https://gerrit.wikimedia.org/r/164575 (owner: 10Paladox) [17:28:55] get_thumbnail_url() [17:29:17] 3MediaWiki / 3MediaWiki UI: Fix Special:ExpandTemplates - 10https://bugzilla.wikimedia.org/71433#c2 (10Jon) 5PATC>3RESO/WOR There actually seems to be no problem with this interface. Screenshot to follow. [17:30:29] https://bitbucket.org/magnusmanske/magnustools/src/f829ccc00ca2c4ebff1ccd004b33d44fdc6c04e9/public_html/php/common.php?at=master#cl-379 [17:31:12] (03PS1) 10Paladox: Add .gitreview file [skins/Metrolook] (REL1_24) - 10https://gerrit.wikimedia.org/r/164581 [17:31:29] (03CR) 10Jdlrobson: [C: 04-1] "Discussed on irc" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/164533 (https://bugzilla.wikimedia.org/71433) (owner: 10Florianschmidtwelzow) [17:32:20] legoktm: no problem in installer :) https://gerrit.wikimedia.org/r/#/c/159536 [17:32:28] sweet [17:32:46] (03PS9) 10Florianschmidtwelzow: SpecialVersion: Use Config object instead of globals [core] - 10https://gerrit.wikimedia.org/r/159536 (https://bugzilla.wikimedia.org/70638) [17:32:48] (03PS1) 10Paladox: Add .gitreview file [skins/Metrolook] (REL1_24) - 10https://gerrit.wikimedia.org/r/164582 [17:33:46] (03PS3) 10Florianschmidtwelzow: Special:ExpandTemplates: Use MediaWiki UI [core] - 10https://gerrit.wikimedia.org/r/164533 (https://bugzilla.wikimedia.org/71433) [17:34:02] (03CR) 10Chad: [C: 032] Avoid the page join when not really needed [core] - 10https://gerrit.wikimedia.org/r/164372 (owner: 10Aaron Schulz) [17:34:25] (03CR) 10Jdlrobson: [C: 032] Special:ExpandTemplates: Use MediaWiki UI [core] - 10https://gerrit.wikimedia.org/r/164533 (https://bugzilla.wikimedia.org/71433) (owner: 10Florianschmidtwelzow) [17:37:01] (03PS1) 10Jack Phoenix: Lots and lots of stuff here to make it compatible w/ 1.23 and even so the JS is still buggy as hell [extensions/ImageTagging] - 10https://gerrit.wikimedia.org/r/164586 [17:37:37] (03CR) 10Jack Phoenix: [C: 032 V: 032] Lots and lots of stuff here to make it compatible w/ 1.23 and even so the JS is still buggy as hell [extensions/ImageTagging] - 10https://gerrit.wikimedia.org/r/164586 (owner: 10Jack Phoenix) [17:37:45] (03PS2) 10Paladox: Add .gitreview file [skins/Metrolook] (REL1_24) - 10https://gerrit.wikimedia.org/r/164581 [17:37:47] (03PS2) 10Paladox: Add .gitreview file [skins/Metrolook] (REL1_24) - 10https://gerrit.wikimedia.org/r/164582 [17:38:29] (03CR) 10Aaron Schulz: [C: 032] Avoid attempting to prerender thumbnails that will fail (031 comment) [core] - 10https://gerrit.wikimedia.org/r/164571 (owner: 10Gilles) [17:39:21] (03PS1) 10Jack Phoenix: var -> public [extensions/EditSimilar] - 10https://gerrit.wikimedia.org/r/164589 [17:39:38] (03CR) 10Jack Phoenix: [C: 032 V: 032] var -> public [extensions/EditSimilar] - 10https://gerrit.wikimedia.org/r/164589 (owner: 10Jack Phoenix) [17:40:40] (03PS3) 10Paladox: Add .gitreview file [skins/Metrolook] (REL1_24) - 10https://gerrit.wikimedia.org/r/164581 [17:40:41] (03PS3) 10Paladox: Add .gitreview file [skins/Metrolook] (REL1_24) - 10https://gerrit.wikimedia.org/r/164582 [17:40:53] (03CR) 10Paladox: [C: 032 V: 032] Add .gitreview file [skins/Metrolook] (REL1_24) - 10https://gerrit.wikimedia.org/r/164581 (owner: 10Paladox) [17:41:04] (03CR) 10Chad: [C: 032] Removed $wgAntiLockFlags to unify the code paths [core] - 10https://gerrit.wikimedia.org/r/164115 (owner: 10Aaron Schulz) [17:41:13] (03Merged) 10jenkins-bot: Avoid the page join when not really needed [core] - 10https://gerrit.wikimedia.org/r/164372 (owner: 10Aaron Schulz) [17:41:19] (03Merged) 10jenkins-bot: Special:ExpandTemplates: Use MediaWiki UI [core] - 10https://gerrit.wikimedia.org/r/164533 (https://bugzilla.wikimedia.org/71433) (owner: 10Florianschmidtwelzow) [17:42:30] (03PS2) 10Aaron Schulz: Removed $wgAntiLockFlags to unify the code paths [core] - 10https://gerrit.wikimedia.org/r/164115 [17:42:35] evening [17:42:46] (03CR) 10Paladox: Add .gitreview file [skins/Metrolook] (REL1_24) - 10https://gerrit.wikimedia.org/r/164581 (owner: 10Paladox) [17:42:54] (03CR) 10Paladox: [C: 032 V: 032] Add .gitreview file [skins/Metrolook] (REL1_24) - 10https://gerrit.wikimedia.org/r/164581 (owner: 10Paladox) [17:45:17] (03Merged) 10jenkins-bot: Avoid attempting to prerender thumbnails that will fail [core] - 10https://gerrit.wikimedia.org/r/164571 (owner: 10Gilles) [17:45:48] (03CR) 10Aaron Schulz: [C: 032] "RL rebased" [core] - 10https://gerrit.wikimedia.org/r/164115 (owner: 10Aaron Schulz) [17:46:30] (03PS1) 10Paladox: Add .gitreview file [skins/Metrolook] (REL1_23) - 10https://gerrit.wikimedia.org/r/164591 [17:47:05] (03Abandoned) 10Paladox: Add .gitreview file [skins/Metrolook] (REL1_24) - 10https://gerrit.wikimedia.org/r/164582 (owner: 10Paladox) [17:47:46] (03CR) 10Paladox: [C: 032 V: 032] Add .gitreview file [skins/Metrolook] (REL1_23) - 10https://gerrit.wikimedia.org/r/164591 (owner: 10Paladox) [17:49:00] 3Wikimedia / 3Bugzilla: New component for "IEG grant review" - 10https://bugzilla.wikimedia.org/71596#c2 (10Bryan Davis) Name: IEG grant review Description: Grant proposal review tool for Individual Engagement Grants project. [[:meta:Grants:IdeaLab/Application_scoring_system]] Subcomponent of: Wikimedia D... [17:49:25] (03CR) 10jenkins-bot: [V: 04-1] Removed $wgAntiLockFlags to unify the code paths [core] - 10https://gerrit.wikimedia.org/r/164115 (owner: 10Aaron Schulz) [17:49:30] 3MediaWiki / 3MediaWiki UI: Fix Special:ExpandTemplates - 10https://bugzilla.wikimedia.org/71433#c4 (10Jon) 5RESO/WOR>3REOP Seems title should be inline though. Prateek don't open such confusing bug reports :P [17:49:30] (03Abandoned) 10Paladox: Add .gitreview file [skins/Metrolook] (REL1_24) - 10https://gerrit.wikimedia.org/r/164581 (owner: 10Paladox) [17:49:48] 3Wikimedia / 3Language setup: Add grammatical cases of Wikidata for Czech - 10https://bugzilla.wikimedia.org/71615 (10Matěj) 3UNCO p:3Unprio s:3normal a:3None nominative: Wikidata genitive: Wikidat dative: Wikidatům acusative: Wikidata locative: Wikidatech instr.: Wikidaty Thanks [17:50:32] 3MediaWiki / 3MediaWiki UI: Fix Special:ExpandTemplates - 10https://bugzilla.wikimedia.org/71433#c3 (10Jon) Created attachment 16661 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16661&action=edit WFM [17:50:47] 3MediaWiki extensions / 3SecurePoll: SecurePoll Redesign: Voter Eligibility form throws error if you only fill out basic options - 10https://bugzilla.wikimedia.org/68132#c3 (10Dan Garry) 5PATC>3RESO/FIX This patch was merged so I'm assuming this is fixed. [17:51:47] (03PS1) 10Paladox: Add .gitreview file [skins/Metrolook] (REL1_24) - 10https://gerrit.wikimedia.org/r/164592 [17:52:02] (03CR) 10Paladox: [C: 032 V: 032] Add .gitreview file [skins/Metrolook] (REL1_24) - 10https://gerrit.wikimedia.org/r/164592 (owner: 10Paladox) [17:53:17] 3MediaWiki / 3MediaWiki UI: Fix Special:ExpandTemplates - 10https://bugzilla.wikimedia.org/71433#c6 (10Jon) 5REOP>3RESO/FIX Now fixed. [17:54:43] (03PS1) 10BryanDavis: USD suffix for dollar amounts [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/164594 [17:55:14] (03Merged) 10jenkins-bot: Removed $wgAntiLockFlags to unify the code paths [core] - 10https://gerrit.wikimedia.org/r/164115 (owner: 10Aaron Schulz) [17:58:28] (03CR) 10Jdlrobson: [C: 032] mediawiki.toolbar: Move documentation closer to code [core] - 10https://gerrit.wikimedia.org/r/161780 (owner: 10Bartosz Dziewoński) [17:59:10] (03CR) 10Jdlrobson: [C: 032] mediawiki.toolbar: Properly deprecate #init [core] - 10https://gerrit.wikimedia.org/r/161781 (owner: 10Bartosz Dziewoński) [18:00:19] (03PS1) 10Paladox: Add .gitreview file [skins/Metrolook] (REL1_22) - 10https://gerrit.wikimedia.org/r/164595 [18:01:53] (03CR) 10Aaron Schulz: [C: 032] Turn a wfDebug call in MessageCache::get into a wfDebugLog call [core] - 10https://gerrit.wikimedia.org/r/164507 (owner: 10Ori.livneh) [18:03:51] (03CR) 10Manybubbles: [C: 04-1] Simplify pom and adjust to track upstream a bit better (031 comment) [search/repository-swift] - 10https://gerrit.wikimedia.org/r/164579 (owner: 10Chad) [18:05:20] (03Merged) 10jenkins-bot: mediawiki.toolbar: Move documentation closer to code [core] - 10https://gerrit.wikimedia.org/r/161780 (owner: 10Bartosz Dziewoński) [18:05:45] (03Merged) 10jenkins-bot: mediawiki.toolbar: Properly deprecate #init [core] - 10https://gerrit.wikimedia.org/r/161781 (owner: 10Bartosz Dziewoński) [18:05:47] (03PS1) 10Paladox: Add .gitreview file [skins/Metrolook] (REL1_22) - 10https://gerrit.wikimedia.org/r/164596 [18:07:40] (03PS2) 10Paladox: Add .gitreview file [skins/Metrolook] (REL1_22) - 10https://gerrit.wikimedia.org/r/164596 [18:07:43] (03PS1) 10Anomie: API: Log usage of action=tokens [core] - 10https://gerrit.wikimedia.org/r/164598 [18:07:47] (03PS1) 10MaxSem: MobileFrontend: grab https://gerrit.wikimedia.org/r/#/c/164543/ [core] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/164599 [18:08:08] (03CR) 10Paladox: [C: 032 V: 032] Add .gitreview file [skins/Metrolook] (REL1_22) - 10https://gerrit.wikimedia.org/r/164596 (owner: 10Paladox) [18:08:28] (03Merged) 10jenkins-bot: Turn a wfDebug call in MessageCache::get into a wfDebugLog call [core] - 10https://gerrit.wikimedia.org/r/164507 (owner: 10Ori.livneh) [18:08:35] (03PS1) 10Paladox: Add .gitreview file [skins/Metrolook] (REL1_21) - 10https://gerrit.wikimedia.org/r/164600 [18:10:43] (03PS1) 10MaxSem: MobileFrontend: grab https://gerrit.wikimedia.org/r/#/c/164543/ [core] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/164601 [18:10:45] 3Wikimedia / 3General/Unknown: Review and deploy IEG grant review application - 10https://bugzilla.wikimedia.org/71597 (10Bryan Davis) [18:11:06] (03PS2) 10Paladox: Add .gitreview file [skins/Metrolook] (REL1_21) - 10https://gerrit.wikimedia.org/r/164600 [18:11:20] (03CR) 10Paladox: [C: 032 V: 032] Add .gitreview file [skins/Metrolook] (REL1_21) - 10https://gerrit.wikimedia.org/r/164600 (owner: 10Paladox) [18:11:22] (03CR) 10Aaron Schulz: [C: 032] API: Log usage of action=tokens [core] - 10https://gerrit.wikimedia.org/r/164598 (owner: 10Anomie) [18:11:47] (03CR) 10MaxSem: [C: 032 V: 032] MobileFrontend: grab https://gerrit.wikimedia.org/r/#/c/164543/ [core] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/164599 (owner: 10MaxSem) [18:12:02] (03CR) 10MaxSem: [C: 032 V: 032] MobileFrontend: grab https://gerrit.wikimedia.org/r/#/c/164543/ [core] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/164601 (owner: 10MaxSem) [18:14:14] (03CR) 10Manybubbles: [C: 04-1] Rewrite BlobStore support (035 comments) [search/repository-swift] - 10https://gerrit.wikimedia.org/r/158279 (owner: 10Chad) [18:16:27] (03CR) 10Krinkle: [C: 04-1] "Sounds like this class method should be "setIndicator(s?)", not "addIndicator(s?)" because it can be overwritten trivially without any war" [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [18:16:29] (03PS1) 10Paladox: Add .gitreview file [skins/Metrolook] (PidgiWiki) - 10https://gerrit.wikimedia.org/r/164604 [18:18:18] (03PS2) 10Paladox: Add .gitreview file [skins/Metrolook] (PidgiWiki) - 10https://gerrit.wikimedia.org/r/164604 [18:18:30] (03CR) 10Paladox: [C: 032 V: 032] Add .gitreview file [skins/Metrolook] (PidgiWiki) - 10https://gerrit.wikimedia.org/r/164604 (owner: 10Paladox) [18:19:13] (03CR) 10Krinkle: "Please document what "contents" are. Both in the API response, OutputPage and ParserOutput, there is only a vague description "value is th" [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [18:19:33] (03CR) 10BryanDavis: "recheck" [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/164594 (owner: 10BryanDavis) [18:19:35] (03PS1) 10Paladox: Add .gitreview file [skins/Metrolook] (test) - 10https://gerrit.wikimedia.org/r/164606 [18:20:00] (03Merged) 10jenkins-bot: API: Log usage of action=tokens [core] - 10https://gerrit.wikimedia.org/r/164598 (owner: 10Anomie) [18:21:37] (03CR) 10Aaron Schulz: [C: 032] "LGTM" [core] - 10https://gerrit.wikimedia.org/r/164570 (owner: 10Anomie) [18:22:07] (03PS2) 10Paladox: Add .gitreview file [skins/Metrolook] (test) - 10https://gerrit.wikimedia.org/r/164606 [18:22:25] (03CR) 10Paladox: [C: 032 V: 032] Add .gitreview file [skins/Metrolook] (test) - 10https://gerrit.wikimedia.org/r/164606 (owner: 10Paladox) [18:23:50] (03PS1) 10Paladox: Revert "Add .gitreview file" [skins/Metrolook] (test) - 10https://gerrit.wikimedia.org/r/164608 [18:23:59] ........ [18:24:05] (03CR) 10Paladox: [C: 032 V: 032] Revert "Add .gitreview file" [skins/Metrolook] (test) - 10https://gerrit.wikimedia.org/r/164608 (owner: 10Paladox) [18:24:12] (03PS1) 10Paladox: Revert "Revert "Add .gitreview file"" [skins/Metrolook] (test) - 10https://gerrit.wikimedia.org/r/164609 [18:25:18] (03PS2) 10Paladox: Revert "Revert "Add .gitreview file"" [skins/Metrolook] (test) - 10https://gerrit.wikimedia.org/r/164609 [18:25:48] (03CR) 10Paladox: [C: 032 V: 032] Revert "Revert "Add .gitreview file"" [skins/Metrolook] (test) - 10https://gerrit.wikimedia.org/r/164609 (owner: 10Paladox) [18:26:29] (03PS1) 10Paladox: Add .gitreview file [skins/Metrolook] (develop) - 10https://gerrit.wikimedia.org/r/164610 [18:26:58] is Paladox some kind of random git action robot? [18:28:49] yo yo SF peeps if anybody want to come to the Mesosphere BBQ tonight all are welcome http://www.evite.com/l/9tmxnER5Py [18:28:56] (03PS2) 10Paladox: Add .gitreview file [skins/Metrolook] (develop) - 10https://gerrit.wikimedia.org/r/164610 [18:29:37] (03PS3) 10Paladox: Add .gitreview file [skins/Metrolook] (develop) - 10https://gerrit.wikimedia.org/r/164610 [18:30:03] (03CR) 10Paladox: [C: 032 V: 032] Add .gitreview file [skins/Metrolook] (develop) - 10https://gerrit.wikimedia.org/r/164610 (owner: 10Paladox) [18:30:07] oh wow [18:30:33] he's a human [18:30:35] or so he claims [18:30:49] but i'm having doubts too [18:33:33] (03Merged) 10jenkins-bot: Fix Status serialization with cleanupCallback as Closure [core] - 10https://gerrit.wikimedia.org/r/164570 (owner: 10Anomie) [18:36:37] (03PS1) 10Cscott: Don't guess at mime type; use proper extension for downloaded file. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164613 [18:36:39] (03PS1) 10Cscott: Log the total user-experienced render time to statsd. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164614 [18:36:41] (03PS1) 10Cscott: Shrink expiry for temp files and postmortem files. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164615 [18:41:22] (03CR) 10Chad: Simplify pom and adjust to track upstream a bit better (031 comment) [search/repository-swift] - 10https://gerrit.wikimedia.org/r/164579 (owner: 10Chad) [18:45:43] (03PS1) 10Umherirrender: Add comment to AFL_* constants in Defines.php [core] - 10https://gerrit.wikimedia.org/r/164618 [18:55:59] 3Wikimedia / 3General/Unknown: *_minor_mime are varbinary(32) on WMF sites, out of sync with varbinary(100) in MW core - 10https://bugzilla.wikimedia.org/71563#c6 (10Umherirrender) Purge does not rewrite these values, a reupload would do it, but than oldimage table contains that broken value. Some one has t... [18:56:03] (03CR) 10Krinkle: "fixme: Undefined variable: groups in SpecialCentralAuth.php on line 264" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/162809 (https://bugzilla.wikimedia.org/71276) (owner: 10Hoo man) [18:56:39] (03CR) 10Chad: Rewrite BlobStore support (035 comments) [search/repository-swift] - 10https://gerrit.wikimedia.org/r/158279 (owner: 10Chad) [18:58:02] (03PS10) 10Florianschmidtwelzow: SpecialVersion: Use Config object instead of globals [core] - 10https://gerrit.wikimedia.org/r/159536 (https://bugzilla.wikimedia.org/70638) [19:01:29] (03PS1) 10Hoo man: Fix group count passed to message in SpecialCentralAuth [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/164624 [19:01:40] (03CR) 10Krinkle: [C: 04-1] "This makes a breaking change to a public static function (softwareInformation) by adding a required parameter." [core] - 10https://gerrit.wikimedia.org/r/159536 (https://bugzilla.wikimedia.org/70638) (owner: 10Florianschmidtwelzow) [19:04:48] (03PS2) 10Krinkle: jquery.ui: Collapse border in ui-helper-clearfix [core] - 10https://gerrit.wikimedia.org/r/164521 (https://bugzilla.wikimedia.org/71601) (owner: 10Kaldari) [19:07:15] (03PS1) 10Umherirrender: Add comment for messages on 'mediawiki.action.edit.editWarning' [core] - 10https://gerrit.wikimedia.org/r/164625 [19:09:48] I have been working practical working solution for bug 70672 that does not destroy functionality while implementing security for the described issue. https://github.com/Alexia/Bug70672 http://imgur.com/a/TnsTY#0 [19:11:19] 3MediaWiki / 3MediaWiki UI: Loginpage doesn't use mw-ui-button anymore - 10https://bugzilla.wikimedia.org/71618 (10Florian) 3NEW p:3Unprio s:3normal a:3None Created attachment 16662 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16662&action=edit no mw-ui buttons On beta labs, login and crea... [19:11:35] (03CR) 10Krinkle: [C: 031] jquery.ui: Collapse border in ui-helper-clearfix [core] - 10https://gerrit.wikimedia.org/r/164521 (https://bugzilla.wikimedia.org/71601) (owner: 10Kaldari) [19:14:47] Mihau: I think you want to do a little more normalization for the css before the match-- e.g., IE6 excepts "expre�ion". Cfr how style attributes are filtered. [19:15:26] (03CR) 10Alex Monk: [C: 032] Fix group count passed to message in SpecialCentralAuth [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/164624 (owner: 10Hoo man) [19:16:17] (03Merged) 10jenkins-bot: Fix group count passed to message in SpecialCentralAuth [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/164624 (owner: 10Hoo man) [19:16:41] csteipp: Can do! I'll add that to the test cases I am coding up at the moment. [19:17:37] (03CR) 10Manybubbles: Simplify pom and adjust to track upstream a bit better (031 comment) [search/repository-swift] - 10https://gerrit.wikimedia.org/r/164579 (owner: 10Chad) [19:22:31] (03PS1) 10Florianschmidtwelzow: Fix missing mw-ui-button on Login and create page [core] - 10https://gerrit.wikimedia.org/r/164629 (https://bugzilla.wikimedia.org/71618) [19:23:23] (03PS2) 10Florianschmidtwelzow: Fix missing mw-ui-button on Login and create page [core] - 10https://gerrit.wikimedia.org/r/164629 (https://bugzilla.wikimedia.org/71618) [19:24:47] IE6 accepts "expreßion"! that's disgusting... [19:25:34] (03CR) 10jenkins-bot: [V: 04-1] Fix missing mw-ui-button on Login and create page [core] - 10https://gerrit.wikimedia.org/r/164629 (https://bugzilla.wikimedia.org/71618) (owner: 10Florianschmidtwelzow) [19:28:15] 3MediaWiki extensions / 3WikidataRepo: Exception: Can only add Wikibase\DataModel\Snak\Snak implementing objects to Wikibase\DataModel\Snak\SnakList - 10https://bugzilla.wikimedia.org/71479#c5 (10Aude) it seems to make a difference if FingerprintView::getHtmlForLabel is called (via EntityView::getHtmlForFing... [19:29:33] (03CR) 10Hashar: "Sorry I made a mistake in the CI system which caused it to loop over this change. You might want to abandon this change and resubmit your" [core] - 10https://gerrit.wikimedia.org/r/164629 (https://bugzilla.wikimedia.org/71618) (owner: 10Florianschmidtwelzow) [19:31:00] (03PS1) 10Florianschmidtwelzow: Fix missing mw-ui-button on Login and create page [core] - 10https://gerrit.wikimedia.org/r/164630 (https://bugzilla.wikimedia.org/71618) [19:32:21] (03Abandoned) 10Florianschmidtwelzow: Fix missing mw-ui-button on Login and create page [core] - 10https://gerrit.wikimedia.org/r/164629 (https://bugzilla.wikimedia.org/71618) (owner: 10Florianschmidtwelzow) [19:35:08] (03PS1) 10Manybubbles: WIP: Query boosting nearby matches [search/extra] - 10https://gerrit.wikimedia.org/r/164632 [19:39:15] 3MediaWiki / 3MediaWiki UI: Use mediawiki.ui elements on Special:AllMessages - 10https://bugzilla.wikimedia.org/71254#c7 (10Jared Zimmerman (WMF)) ​icon+text ​ [19:45:18] 3MediaWiki extensions / 3WikidataRepo: Exception: Can only add Wikibase\DataModel\Snak\Snak implementing objects to Wikibase\DataModel\Snak\SnakList - 10https://bugzilla.wikimedia.org/71479#c6 (10Aude) note that "$idInParentheses = wfMessage( 'parentheses', $id )" is something new in the branch we deployed t... [19:48:31] (03PS1) 10Paladox: Add .gitreview [skins/Metrolook] (test) - 10https://gerrit.wikimedia.org/r/164636 [19:50:11] (03PS2) 10Paladox: Add .gitreview [skins/Metrolook] (test) - 10https://gerrit.wikimedia.org/r/164636 [19:50:33] (03CR) 10Paladox: [C: 032 V: 032] Add .gitreview [skins/Metrolook] (test) - 10https://gerrit.wikimedia.org/r/164636 (owner: 10Paladox) [19:50:42] (03PS1) 10Cscott: Further tweak cache parameters: reduce basic expiry time to 2 days. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164637 [19:50:44] (03PS1) 10Cscott: Bug fix: utime was setting directory times to 1000 years in the future. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164638 [19:51:14] (03Abandoned) 10Paladox: Add .gitreview file [skins/Metrolook] (REL1_22) - 10https://gerrit.wikimedia.org/r/164595 (owner: 10Paladox) [19:51:33] 3MediaWiki / 3User login and signup: Bug 70672 breaks functionality - Proposing a fix to keep functionality while patching the security hole. - 10https://bugzilla.wikimedia.org/71621 (10Alexia E. Smith) 3UNCO p:3Unprio s:3major a:3None Bug 70672 fixes the security hole of allowing Javascript in CSS i... [19:51:43] (03PS1) 10Hoo man: Avoid duplicating arrays if not needed [core] - 10https://gerrit.wikimedia.org/r/164639 [19:52:58] doh [19:53:49] (03Abandoned) 10Hoo man: Avoid duplicating arrays if not needed [core] - 10https://gerrit.wikimedia.org/r/164639 (owner: 10Hoo man) [19:54:37] (03PS1) 10Paladox: Add .gitreview [skins/Metrolook] (develop) - 10https://gerrit.wikimedia.org/r/164640 [19:54:49] (03CR) 10Paladox: [C: 032 V: 032] Add .gitreview [skins/Metrolook] (develop) - 10https://gerrit.wikimedia.org/r/164640 (owner: 10Paladox) [19:55:00] 3MediaWiki / 3User login and signup: Bug 70672 breaks functionality - Proposing a fix to keep functionality while patching the security hole. - 10https://bugzilla.wikimedia.org/71621#c1 (10Kunal Mehta (Legoktm)) 5UNCO>3NEW Also bawolff's email: https://lists.wikimedia.org/pipermail/wikitech-l/2014-Octobe... [19:55:18] (03CR) 10Manybubbles: Rewrite BlobStore support (032 comments) [search/repository-swift] - 10https://gerrit.wikimedia.org/r/158279 (owner: 10Chad) [19:56:30] 3MediaWiki / 3User login and signup: Not loading site CSS on Special:UserLogin/Preferenc es breaks wkis which use it to create a skin/theme - 10https://bugzilla.wikimedia.org/71621 (10Kunal Mehta (Legoktm)) [19:56:35] (03PS1) 10Cmcmahon: QA: remove moderation_anon test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164641 [20:03:12] (03CR) 10Paladox: "Hi I still carnt upload normaly it sill says I need the push rights and I have been added back to the owner list." [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/163970 (owner: 10Florianschmidtwelzow) [20:03:57] (03CR) 10Chad: Simplify pom and adjust to track upstream a bit better (031 comment) [search/repository-swift] - 10https://gerrit.wikimedia.org/r/164579 (owner: 10Chad) [20:04:07] (03PS1) 10Cscott: Bug fix: fix `force` variable aliasing. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164644 [20:04:39] (03CR) 10Paladox: "Hi it has had that problem ever since this https://git.wikimedia.org/summary/mediawiki%2Fskins%2FMetrolook.git" [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/163970 (owner: 10Florianschmidtwelzow) [20:07:33] (03PS1) 10Paladox: Revert "Update Metrolook" [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/164645 [20:07:41] (03Abandoned) 10Paladox: Revert "Update Metrolook" [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/164645 (owner: 10Paladox) [20:08:00] (03PS1) 10Paladox: Revert "Update Metrolook" [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/164646 [20:08:04] (03PS2) 10Paladox: Revert "Update Metrolook" [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/164646 [20:08:25] (03CR) 10Paladox: [C: 032 V: 032] Revert "Update Metrolook" [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/164646 (owner: 10Paladox) [20:09:03] (03PS1) 10Paladox: Revert "Update Metrolook" [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/164647 [20:09:07] (03PS2) 10Paladox: Revert "Update Metrolook" [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/164647 [20:09:13] (03CR) 10Paladox: [C: 032 V: 032] Revert "Update Metrolook" [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/164647 (owner: 10Paladox) [20:10:02] (03CR) 10Jdlrobson: "Can we just force the global on in these pages?" [core] - 10https://gerrit.wikimedia.org/r/164630 (https://bugzilla.wikimedia.org/71618) (owner: 10Florianschmidtwelzow) [20:15:52] (03CR) 10Jdlrobson: [C: 04-1] "So I think we should simply enable the global inside SpecialUserLogin" [core] - 10https://gerrit.wikimedia.org/r/164630 (https://bugzilla.wikimedia.org/71618) (owner: 10Florianschmidtwelzow) [20:16:20] 3MediaWiki / 3MediaWiki UI: Loginpage doesn't use mw-ui-button anymore - 10https://bugzilla.wikimedia.org/71618#c4 (10Jon) Whoops. [20:18:06] (03CR) 10Florianschmidtwelzow: "agreed." [core] - 10https://gerrit.wikimedia.org/r/164630 (https://bugzilla.wikimedia.org/71618) (owner: 10Florianschmidtwelzow) [20:21:22] (03PS3) 10Chad: Less dependencies -> quicker release process for me [search/repository-swift] - 10https://gerrit.wikimedia.org/r/164579 [20:21:24] (03PS7) 10Chad: Rewrite BlobStore support [search/repository-swift] - 10https://gerrit.wikimedia.org/r/158279 [20:23:38] (03PS2) 10Florianschmidtwelzow: Fix missing mw-ui-button on Login and create page [core] - 10https://gerrit.wikimedia.org/r/164630 (https://bugzilla.wikimedia.org/71618) [20:26:14] (03CR) 10Spage: [C: 032] "OK. I added your pearl of wisdom to https://www.mediawiki.org/wiki/Quality_Assurance/Browser_testing/Writing_tests#Anonymous_tests" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164641 (owner: 10Cmcmahon) [20:26:45] 3MediaWiki / 3MediaWiki UI: Fix Special:ProtectedPages - 10https://bugzilla.wikimedia.org/71449#c1 (10Prateek Saxena) Parts of this got fixed with bug 71526 - Input should be inline - Button should be progressive - Button should say search - Style checkboxes ✔ - Pagination controls should not have icons and... [20:26:46] (03CR) 10Jdlrobson: [C: 032] Fix missing mw-ui-button on Login and create page [core] - 10https://gerrit.wikimedia.org/r/164630 (https://bugzilla.wikimedia.org/71618) (owner: 10Florianschmidtwelzow) [20:27:01] (03Merged) 10jenkins-bot: QA: remove moderation_anon test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164641 (owner: 10Cmcmahon) [20:27:35] (03PS2) 10Chad: Treat other English variants as English instead of falling back [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/164225 [20:28:09] (03PS1) 10Paladox: Update Metrolook [skins/Metrolook] (REL1_24) - 10https://gerrit.wikimedia.org/r/164652 [20:28:15] (03PS1) 10Spage: QA: WIP revive moderation.feature [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164655 (https://bugzilla.wikimedia.org/71588) [20:30:20] (03CR) 10Manybubbles: [C: 04-1] "This lets the version of some of those plugins float which might cause trouble. Best to leave them specified. Probably best to leave jav" [search/repository-swift] - 10https://gerrit.wikimedia.org/r/164579 (owner: 10Chad) [20:30:30] 3MediaWiki / 3MediaWiki UI: Fix Special:NewPages - 10https://bugzilla.wikimedia.org/71446#c1 (10Prateek Saxena) Parts of this got fixed with bug 71526 - Inputs should be inline - Style checkboxes ✔ - "Go" button should say "Search" - Button should be progressive [20:30:59] (03PS2) 10Paladox: Update Metrolook [skins/Metrolook] (REL1_24) - 10https://gerrit.wikimedia.org/r/164652 [20:31:27] (03CR) 10Spage: "The commented steps serve as a TODO. Jenkins doesn't run this feature test and it wasn't working before, so IMO we can merge this." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164655 (https://bugzilla.wikimedia.org/71588) (owner: 10Spage) [20:31:54] (03PS1) 10Paladox: Revert "Revert "Update Metrolook"" [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/164656 [20:32:04] (03CR) 10Paladox: [C: 032 V: 032] Revert "Revert "Update Metrolook"" [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/164656 (owner: 10Paladox) [20:32:17] (03PS1) 10Paladox: Revert "Revert "Update Metrolook"" [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/164657 [20:32:21] (03PS2) 10Paladox: Revert "Revert "Update Metrolook"" [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/164657 [20:32:30] (03CR) 10Paladox: [C: 032 V: 032] Revert "Revert "Update Metrolook"" [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/164657 (owner: 10Paladox) [20:33:15] 3MediaWiki / 3MediaWiki UI: Fix Special:ListUsers - 10https://bugzilla.wikimedia.org/71441#c1 (10Prateek Saxena) Parts of this got fixed with bug 71526 - Input should be inline - Checkboxes should be styled ✔ - Go should be Search - Button should be progressive [20:33:18] (03Merged) 10jenkins-bot: Fix missing mw-ui-button on Login and create page [core] - 10https://gerrit.wikimedia.org/r/164630 (https://bugzilla.wikimedia.org/71618) (owner: 10Florianschmidtwelzow) [20:33:39] (03PS3) 10Paladox: Update Metrolook [skins/Metrolook] (REL1_24) - 10https://gerrit.wikimedia.org/r/164652 [20:35:01] 3MediaWiki / 3MediaWiki UI: Fix Special:ListFiles - 10https://bugzilla.wikimedia.org/71440#c2 (10Prateek Saxena) Parts of this got fixed with bug 71526 - checkboxes are now styled [20:36:10] (03CR) 10Paladox: [C: 032 V: 032] Update Metrolook [skins/Metrolook] (REL1_24) - 10https://gerrit.wikimedia.org/r/164652 (owner: 10Paladox) [20:37:01] 3MediaWiki / 3MediaWiki UI: Fix Special:Export - 10https://bugzilla.wikimedia.org/71434#c1 (10Prateek Saxena) Parts of this got fixed with bug 71526 - checkboxes are now styled [20:39:15] (03CR) 10Manybubbles: [C: 032] Treat other English variants as English instead of falling back [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/164225 (owner: 10Chad) [20:39:36] (03Merged) 10jenkins-bot: Treat other English variants as English instead of falling back [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/164225 (owner: 10Chad) [20:43:29] (03PS1) 10Paladox: Update Metrolook [skins/Metrolook] (REL1_23) - 10https://gerrit.wikimedia.org/r/164658 [20:44:36] (03PS2) 10Paladox: Update Metrolook [skins/Metrolook] (REL1_23) - 10https://gerrit.wikimedia.org/r/164658 [20:45:03] (03CR) 10Paladox: [C: 032 V: 032] Update Metrolook [skins/Metrolook] (REL1_23) - 10https://gerrit.wikimedia.org/r/164658 (owner: 10Paladox) [20:47:02] 3Wikimedia / 3General/Unknown: Review and deploy IEG grant review application - 10https://bugzilla.wikimedia.org/71597 (10Bryan Davis) [20:47:03] 3Wikimedia / 3General/Unknown: Security review of IEG grant review - 10https://bugzilla.wikimedia.org/71624 (10Bryan Davis) 3NEW p:3Unprio s:3normal a:3None Security review needed before initial production deployment. Code is at https://git.wikimedia.org/summary/wikimedia%2Fiegreview and a test serv... [20:47:41] (03PS2) 10EBernhardson: flow-hide role should not be considered for locked topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164475 [20:47:44] (03PS1) 10EBernhardson: Hygiene: Push page creation to DeferredUpdates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164660 [20:47:47] (03PS1) 10EBernhardson: Refactor out calls to RequestContext::getMain() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164661 [20:47:50] (03PS1) 10EBernhardson: Hygiene: Output content/format pair for moderateReason [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164662 [20:47:53] (03PS1) 10EBernhardson: Separate lock reason from summary [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164663 [20:47:56] (03PS1) 10EBernhardson: Hygiene: Use this->context->msg instead of wfMessage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164664 [20:48:50] (03CR) 10jenkins-bot: [V: 04-1] Refactor out calls to RequestContext::getMain() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164661 (owner: 10EBernhardson) [20:49:01] 3MediaWiki / 3General/Unknown: Implement "actual watchers" count into MediaWiki's info action - 10https://bugzilla.wikimedia.org/49506#c4 (10john_of_reading) @Nemo - If user A is watching page B, I don't think it should matter whether user A has *visited* page B recently. What's important is whether user A i... [20:49:02] (03CR) 10jenkins-bot: [V: 04-1] Separate lock reason from summary [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164663 (owner: 10EBernhardson) [20:49:15] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Output content/format pair for moderateReason [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164662 (owner: 10EBernhardson) [20:49:41] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use this->context->msg instead of wfMessage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164664 (owner: 10EBernhardson) [20:52:19] (03PS1) 10Paladox: Fix missing mw-ui-button on Login and create page [core] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/164665 (https://bugzilla.wikimedia.org/71618) [20:53:39] (03CR) 10BryanDavis: "recheck" [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/164594 (owner: 10BryanDavis) [20:53:42] (03CR) 10jenkins-bot: [V: 04-1] USD suffix for dollar amounts [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/164594 (owner: 10BryanDavis) [20:53:47] (03CR) 10Florianschmidtwelzow: "In 1.25wmf2, the required classes are added to the button, so i see no reason to backport? :)" [core] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/164665 (https://bugzilla.wikimedia.org/71618) (owner: 10Paladox) [20:55:35] (03CR) 10Bartosz Dziewoński: [C: 032] Add comment for messages on 'mediawiki.action.edit.editWarning' [core] - 10https://gerrit.wikimedia.org/r/164625 (owner: 10Umherirrender) [20:56:15] 3MediaWiki / 3General/Unknown: Implement "actual watchers" count into MediaWiki's info action - 10https://bugzilla.wikimedia.org/49506#c5 (10Nemo) (In reply to john_of_reading from comment #4) > @Nemo - If user A is watching page B, I don't think it should matter whether > user A has *visited* page B recentl... [20:57:43] (03PS1) 10Hoo man: Move files into an includes folder [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/164666 [20:57:56] (03CR) 10jenkins-bot: [V: 04-1] Move files into an includes folder [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/164666 (owner: 10Hoo man) [20:59:51] (03PS2) 10Hoo man: Move files into an includes folder [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/164666 [20:59:55] (03PS2) 10BryanDavis: USD suffix for dollar amounts [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/164594 [20:59:57] (03CR) 10jenkins-bot: [V: 04-1] USD suffix for dollar amounts [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/164594 (owner: 10BryanDavis) [21:00:00] (03CR) 10jenkins-bot: [V: 04-1] Move files into an includes folder [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/164666 (owner: 10Hoo man) [21:00:52] (03PS3) 10BryanDavis: USD suffix for dollar amounts [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/164594 [21:00:54] (03CR) 10jenkins-bot: [V: 04-1] USD suffix for dollar amounts [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/164594 (owner: 10BryanDavis) [21:01:58] (03PS3) 10Hoo man: Move files into an includes folder [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/164666 [21:02:15] (03Merged) 10jenkins-bot: Add comment for messages on 'mediawiki.action.edit.editWarning' [core] - 10https://gerrit.wikimedia.org/r/164625 (owner: 10Umherirrender) [21:03:00] 3Wikimedia / 3Site requests: Create wiki for Wikimedia Venezuela - 10https://bugzilla.wikimedia.org/70579 (10Carlos Mora) 5PATC>3RESO/WON [21:03:15] 3Wikimedia / 3Site requests: Create wiki for Wikimedia Venezuela - 10https://bugzilla.wikimedia.org/70579 (10Carlos Mora) 5RESO/WON>3RESO/FIX [21:03:46] 3Wikimedia / 3General/Unknown: Security review of IEG grant review - 10https://bugzilla.wikimedia.org/71624#c1 (10Bryan Davis) p:5Unprio>3High a:3Chris Steipp The app is based on code base from the Wikimania Scholarships app. Hopefully knowing that will make it easier for Chris to focus his review. [21:03:48] (03PS4) 10Hoo man: Move files into an includes folder [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/164666 [21:04:20] anyone wants to review that fast? [21:04:26] * hoo is afraid of the rebase hell [21:05:32] I am glad to see CentralAuth getting lots of love. :D [21:06:08] hoo: So you'll push the rebase hell down on my pending patches instead :) [21:06:28] (03Abandoned) 10Paladox: Fix missing mw-ui-button on Login and create page [core] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/164665 (https://bugzilla.wikimedia.org/71618) (owner: 10Paladox) [21:06:41] bd808: Uh :S [21:06:47] This has to happen at some point [21:06:54] agreed [21:07:24] I wanted to do other changes to it ... and decided that more classes wont make things nicer [21:07:37] (with the current layout) [21:07:58] (03CR) 10Aaron Schulz: "I'd rather just remove it, but lets see what Chad thinks." [core] - 10https://gerrit.wikimedia.org/r/162009 (owner: 10Aaron Schulz) [21:08:38] * hoo needs to go... battery [21:08:50] bd808: Would be awesome if you could have a look at it [21:09:44] hoo: I'm looking but probably don't have time to +2 today. Gotta finish iegreview [21:11:15] 3MediaWiki / 3MediaWiki UI: Loginpage doesn't use mw-ui-button anymore - 10https://bugzilla.wikimedia.org/71618 (10Florian) 5PATC>3RESO/FIX [21:11:47] (03CR) 10BryanDavis: "+1 for the concept. I'll try to figure out if breaks anything soon, but I don't have time today. Maybe Kunal and/or Chris can verify thing" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/164666 (owner: 10Hoo man) [21:16:13] (03Abandoned) 10Prtksxna: buttons: Revert to old focus state [core] - 10https://gerrit.wikimedia.org/r/164376 (owner: 10Prtksxna) [21:18:20] (03PS1) 10Prtksxna: Revert "buttons: Update focus for quiet buttons" [core] - 10https://gerrit.wikimedia.org/r/164671 [21:18:57] (03PS1) 10Prtksxna: Revert "buttons: Update focus state" [core] - 10https://gerrit.wikimedia.org/r/164672 [21:19:30] (03CR) 10jenkins-bot: [V: 04-1] Revert "buttons: Update focus state" [core] - 10https://gerrit.wikimedia.org/r/164672 (owner: 10Prtksxna) [21:19:58] (03CR) 10Prtksxna: [C: 04-1] "Depends on Ic8c40498abe9201bdf4e740737467d2d88211442" [core] - 10https://gerrit.wikimedia.org/r/164672 (owner: 10Prtksxna) [21:20:26] (03CR) 10Arlolra: [C: 032] Don't guess at mime type; use proper extension for downloaded file. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164613 (owner: 10Cscott) [21:21:05] (03Merged) 10jenkins-bot: Don't guess at mime type; use proper extension for downloaded file. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164613 (owner: 10Cscott) [21:29:47] (03CR) 10Nemo bis: "Partly fixed bug 71286?" [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164613 (owner: 10Cscott) [21:30:45] 3Wikimedia / 3Mailing lists: Mailing moderator interface sometimes hangs up when trying to log in - 10https://bugzilla.wikimedia.org/71390#c11 (10James Alexander) (In reply to Andre Klapper from comment #10) > https://mail.python.org/pipermail/mailman-users/2014-February/076067.html is > the upstream thread.... [21:31:29] (03CR) 10Jdlrobson: [C: 032] Revert "buttons: Update focus for quiet buttons" [core] - 10https://gerrit.wikimedia.org/r/164671 (owner: 10Prtksxna) [21:37:02] 3MediaWiki / 3MediaWiki UI: Use neutral buttons for non-primary actions on edit page - 10https://bugzilla.wikimedia.org/71628 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3Matthew Flaschen Use neutral buttons for preview and show changes. [21:38:02] (03Merged) 10jenkins-bot: Revert "buttons: Update focus for quiet buttons" [core] - 10https://gerrit.wikimedia.org/r/164671 (owner: 10Prtksxna) [21:41:16] (03CR) 10tosfos: "OK. Will do. Should I abandon this or is it at least a food temporary fix?" [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/164034 (owner: 10tosfos) [21:41:30] (03CR) 10tosfos: "good*" [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/164034 (owner: 10tosfos) [21:43:15] 3Wikimedia / 3General/Unknown: *_minor_mime are varbinary(32) on WMF sites, out of sync with varbinary(100) in MW core - 10https://bugzilla.wikimedia.org/71563#c7 (10Bawolff (Brian Wolff)) (In reply to Umherirrender from comment #6) > Purge does not rewrite these values, a reupload would do it, but than > ol... [21:43:39] (03CR) 10Arlolra: [C: 032] Log the total user-experienced render time to statsd. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164614 (owner: 10Cscott) [21:44:10] (03PS1) 10Mattflaschen: Use neutral instead of progressive for secondary edit page buttons [core] - 10https://gerrit.wikimedia.org/r/164677 (https://bugzilla.wikimedia.org/71628) [21:44:15] (03Merged) 10jenkins-bot: Log the total user-experienced render time to statsd. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164614 (owner: 10Cscott) [21:49:30] 3MediaWiki / 3MediaWiki UI: Use neutral buttons for non-primary actions on edit page - 10https://bugzilla.wikimedia.org/71628#c2 (10Jared Zimmerman (WMF)) +1 [21:50:47] (03CR) 10Jdlrobson: [C: 032] Use neutral instead of progressive for secondary edit page buttons [core] - 10https://gerrit.wikimedia.org/r/164677 (https://bugzilla.wikimedia.org/71628) (owner: 10Mattflaschen) [21:51:59] https://wikimediafoundation.org/wiki/Special:ProtectedPages - why are the timestamp/user/reason fields broken here? :/ [21:53:13] protected before we added that info to the log or db or where ever its pulling it from maybe [21:54:27] (03CR) 10Arlolra: [C: 032] Shrink expiry for temp files and postmortem files. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164615 (owner: 10Cscott) [21:54:58] bawolff, well for example, the September 2012 entries? [21:56:35] renames? [21:57:08] but it's not usernames only [21:57:12] That wouldn't do stuff like set pr_user=NULL in the DB (well, hopefully.) [21:57:21] (03Merged) 10jenkins-bot: Use neutral instead of progressive for secondary edit page buttons [core] - 10https://gerrit.wikimedia.org/r/164677 (https://bugzilla.wikimedia.org/71628) (owner: 10Mattflaschen) [21:57:25] (03Merged) 10jenkins-bot: Shrink expiry for temp files and postmortem files. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164615 (owner: 10Cscott) [21:59:20] Although it doesn't look at pr_user [21:59:47] It does a left join on log_search, and then a left join on logging, to look for log_user [22:00:20] (03CR) 10Arlolra: [C: 032] Further tweak cache parameters: reduce basic expiry time to 2 days. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164637 (owner: 10Cscott) [22:00:57] (03Merged) 10jenkins-bot: Further tweak cache parameters: reduce basic expiry time to 2 days. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164637 (owner: 10Cscott) [22:01:00] 3MediaWiki / 3MediaWiki UI: Use neutral buttons for non-primary actions on edit page - 10https://bugzilla.wikimedia.org/71628 (10Jon) 5PATC>3RESO/FIX [22:04:37] (03PS2) 10EBernhardson: Refactor out calls to RequestContext::getMain() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164661 [22:05:20] (03CR) 10jenkins-bot: [V: 04-1] Refactor out calls to RequestContext::getMain() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164661 (owner: 10EBernhardson) [22:09:04] (03PS3) 10EBernhardson: Refactor out calls to RequestContext::getMain() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164661 [22:09:38] (03PS1) 10Prtksxna: Html: Use https for @see tag of buttonAttributes [core] - 10https://gerrit.wikimedia.org/r/164685 [22:09:42] (03CR) 10jenkins-bot: [V: 04-1] Refactor out calls to RequestContext::getMain() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164661 (owner: 10EBernhardson) [22:10:11] (03CR) 10Prtksxna: Hygiene: Make construction of buttons easier (032 comments) [core] - 10https://gerrit.wikimedia.org/r/163775 (owner: 10Jdlrobson) [22:11:00] (03CR) 10Prtksxna: "recheck" [core] - 10https://gerrit.wikimedia.org/r/164672 (owner: 10Prtksxna) [22:11:22] https://github.com/wikimedia/mediawiki-extensions-TemplateData/blob/master/Specification.md#living-standard [22:11:48] (03PS4) 10EBernhardson: Refactor out calls to RequestContext::getMain() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164661 [22:12:03] (03PS2) 10Krinkle: Revert "buttons: Update focus state" [core] - 10https://gerrit.wikimedia.org/r/164672 (owner: 10Prtksxna) [22:12:18] (03PS1) 10Ishegatron: Add initial files [extensions/FixedHeaderTable] - 10https://gerrit.wikimedia.org/r/164686 [22:12:28] (03CR) 10jenkins-bot: [V: 04-1] Refactor out calls to RequestContext::getMain() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164661 (owner: 10EBernhardson) [22:12:43] (03PS2) 10Krinkle: Html: Use https for @see url of buttonAttributes() [core] - 10https://gerrit.wikimedia.org/r/164685 (owner: 10Prtksxna) [22:12:45] (03CR) 10Prtksxna: Revert "buttons: Update focus state" [core] - 10https://gerrit.wikimedia.org/r/164672 (owner: 10Prtksxna) [22:13:32] (03CR) 10Arlolra: [C: 032] Bug fix: utime was setting directory times to 1000 years in the future. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164638 (owner: 10Cscott) [22:14:03] (03CR) 10Krinkle: Html: Use https for @see url of buttonAttributes() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/164685 (owner: 10Prtksxna) [22:14:10] (03Merged) 10jenkins-bot: Bug fix: utime was setting directory times to 1000 years in the future. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164638 (owner: 10Cscott) [22:14:12] (03CR) 10Krinkle: [C: 032] Html: Use https for @see url of buttonAttributes() [core] - 10https://gerrit.wikimedia.org/r/164685 (owner: 10Prtksxna) [22:14:25] (03PS5) 10EBernhardson: Refactor out calls to RequestContext::getMain() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164661 [22:14:38] (03Abandoned) 10Yuvipanda: Use textarea instead of input for wpReason on Special:Userlogin/signup [core] - 10https://gerrit.wikimedia.org/r/107042 (owner: 10Yuvipanda) [22:15:14] (03CR) 10jenkins-bot: [V: 04-1] Refactor out calls to RequestContext::getMain() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164661 (owner: 10EBernhardson) [22:15:17] (03Abandoned) 10Yuvipanda: Add an &wpWatchlist option [core] - 10https://gerrit.wikimedia.org/r/107043 (owner: 10Yuvipanda) [22:15:28] (03Abandoned) 10Yuvipanda: Fix for IP detection. [core] - 10https://gerrit.wikimedia.org/r/107044 (owner: 10Yuvipanda) [22:15:34] (03CR) 10Prtksxna: Html: Use https for @see url of buttonAttributes() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/164685 (owner: 10Prtksxna) [22:15:40] (03Abandoned) 10Yuvipanda: Update Installer.php [core] - 10https://gerrit.wikimedia.org/r/107045 (owner: 10Yuvipanda) [22:16:30] (03PS6) 10EBernhardson: Refactor out calls to RequestContext::getMain() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164661 [22:17:02] (03CR) 10Arlolra: [C: 032] Bug fix: fix `force` variable aliasing. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164644 (owner: 10Cscott) [22:18:25] (03PS2) 10EBernhardson: Hygiene: Use this->context->msg instead of wfMessage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164664 [22:18:28] (03PS2) 10EBernhardson: Separate lock reason from summary [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164663 [22:18:31] (03PS2) 10EBernhardson: Hygiene: Output content/format pair for moderateReason [extensions/Flow] - 10https://gerrit.wikimedia.org/r/164662 [22:20:49] (03Merged) 10jenkins-bot: Html: Use https for @see url of buttonAttributes() [core] - 10https://gerrit.wikimedia.org/r/164685 (owner: 10Prtksxna) [22:20:51] (03Merged) 10jenkins-bot: Bug fix: fix `force` variable aliasing. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164644 (owner: 10Cscott) [22:27:32] (03PS1) 10Jack Phoenix: "Initial" version of SiteScout, compatible with MW 1.23+ [extensions/SiteScout] - 10https://gerrit.wikimedia.org/r/164689 [22:28:15] (03CR) 10Jack Phoenix: [C: 032 V: 032] "Initial" version of SiteScout, compatible with MW 1.23+ [extensions/SiteScout] - 10https://gerrit.wikimedia.org/r/164689 (owner: 10Jack Phoenix) [22:31:22] (03Abandoned) 10Chad: Less dependencies -> quicker release process for me [search/repository-swift] - 10https://gerrit.wikimedia.org/r/164579 (owner: 10Chad) [22:31:53] (03PS8) 10Chad: Rewrite BlobStore support [search/repository-swift] - 10https://gerrit.wikimedia.org/r/158279 [22:31:56] (03CR) 10jenkins-bot: [V: 04-1] Rewrite BlobStore support [search/repository-swift] - 10https://gerrit.wikimedia.org/r/158279 (owner: 10Chad) [22:33:27] (03PS9) 10Chad: Rewrite BlobStore support [search/repository-swift] - 10https://gerrit.wikimedia.org/r/158279 [22:33:32] (03CR) 10BryanDavis: "recheck" [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/164594 (owner: 10BryanDavis) [22:46:49] (03PS1) 10Isarra: Add empty strings for empty messages, remove footer-footer [skins/Splash] - 10https://gerrit.wikimedia.org/r/164691 [22:48:55] (03CR) 10BryanDavis: "recheck" [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/164594 (owner: 10BryanDavis) [22:50:31] 3MediaWiki extensions / 3Collection: Download link should save to a sensible filename with extension etc. - 10https://bugzilla.wikimedia.org/71286#c2 (10C. Scott Ananian) a:3C. Scott Ananian Partially fixed by https://gerrit.wikimedia.org/r/164613 (which adds the missing extension). We could do better abo... [22:52:14] 3MediaWiki / 3Uploading: SVG upload get blocked on correct encoding (windows-1252, with wrong/unspecific warning) - 10https://bugzilla.wikimedia.org/70937#c6 (10Chris Steipp) (In reply to Bawolff (Brian Wolff) from comment #4) > windows-1252 is almost the same as ISO-8859-1 (just c0 and c1 control > characte... [22:53:54] (03CR) 10Legoktm: [C: 04-1] "Need to update the CentralAuthHooks::onRunExtensionFunctions function." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/164666 (owner: 10Hoo man) [22:55:59] 3Wikimedia / 3OTRS: Create OTRS patch for "1-click spam" disposal - 10https://bugzilla.wikimedia.org/54755#c11 (10Alex Monk) This JavaScript 'fix' is basically the equivalent of fixing a MediaWiki core bug with a default-on gadget. It's not a patch for the software itself. It could also be a lot simpler than... [22:59:16] (03PS1) 10BryanDavis: Fix Jenkins tests [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/164699 [22:59:41] (03CR) 10BryanDavis: [C: 032] Fix Jenkins tests [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/164699 (owner: 10BryanDavis) [23:04:57] AndyRussG: did you see my question on https://gerrit.wikimedia.org/r/#/c/160916/ ? [23:05:10] Hi legoktm [23:05:12] Yes I did [23:05:28] Sorry for putting it off [23:06:11] legoktm: I'll answer and propose something to move forward on it this evening, is that OK? [23:06:16] sure [23:06:28] :) thanks!!! [23:06:39] 3MediaWiki / 3General/Unknown: Implement "actual watchers" count into MediaWiki's info action - 10https://bugzilla.wikimedia.org/49506#c6 (10WhatamIdoing) The problem with counting only people who visited the page in the last 30 days is that many pages aren't edited every 30 days, and thus even though I, as... [23:07:06] (03CR) 10BryanDavis: "recheck" [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/164699 (owner: 10BryanDavis) [23:15:28] (03PS1) 10Isarra: Add webfonts to the skin itself [skins/Splash] - 10https://gerrit.wikimedia.org/r/164701 [23:16:16] (03CR) 10Isarra: [C: 032] Add webfonts to the skin itself [skins/Splash] - 10https://gerrit.wikimedia.org/r/164701 (owner: 10Isarra) [23:16:18] (03Merged) 10jenkins-bot: Add webfonts to the skin itself [skins/Splash] - 10https://gerrit.wikimedia.org/r/164701 (owner: 10Isarra) [23:16:27] (03CR) 10Isarra: [C: 032] Add empty strings for empty messages, remove footer-footer [skins/Splash] - 10https://gerrit.wikimedia.org/r/164691 (owner: 10Isarra) [23:16:29] (03Merged) 10jenkins-bot: Add empty strings for empty messages, remove footer-footer [skins/Splash] - 10https://gerrit.wikimedia.org/r/164691 (owner: 10Isarra) [23:19:45] (03CR) 10Legoktm: "Initial" version of SiteScout, compatible with MW 1.23+ (034 comments) [extensions/SiteScout] - 10https://gerrit.wikimedia.org/r/164689 (owner: 10Jack Phoenix) [23:20:32] (03PS4) 10BryanDavis: USD suffix for dollar amounts [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/164594 [23:27:59] 3MediaWiki extensions / 3[other]: Graph extension security review - 10https://bugzilla.wikimedia.org/69623#c7 (10Chris Steipp) (In reply to Yuri Astrakhan from comment #6) > Chris, thanks, and the defaults have always been exactly as you describe - > extension sets wgEnableGraphParserTag=false and wgGraphDat... [23:46:32] (03PS1) 10Jack Phoenix: Spaces to tabs, as it should be (how'd I miss these?!) [extensions/SiteScout] - 10https://gerrit.wikimedia.org/r/164703 [23:50:04] (03CR) 10Jack Phoenix: [C: 032 V: 032] Spaces to tabs, as it should be (how'd I miss these?!) [extensions/SiteScout] - 10https://gerrit.wikimedia.org/r/164703 (owner: 10Jack Phoenix) [23:57:04] (03PS1) 10Jack Phoenix: Changes, as per legoktm's code review [extensions/SiteScout] - 10https://gerrit.wikimedia.org/r/164706 [23:58:40] (03CR) 10Legoktm: [C: 032 V: 032] Changes, as per legoktm's code review (031 comment) [extensions/SiteScout] - 10https://gerrit.wikimedia.org/r/164706 (owner: 10Jack Phoenix)