[00:00:08] (03CR) 10MSyed: [C: 032 V: 032] Translations for French [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/156499 (owner: 10Prtksxna) [00:12:05] (03PS2) 10Prtksxna: Fixed spacing and other typos [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/158273 (owner: 10MSyed) [00:14:49] (03CR) 10Prtksxna: [C: 032] Fixed spacing and other typos [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/158273 (owner: 10MSyed) [00:14:58] (03CR) 10Prtksxna: [V: 032] Fixed spacing and other typos [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/158273 (owner: 10MSyed) [00:18:15] (03PS1) 10Cscott: Improve statistics collection; track cache effectiveness. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164003 [00:20:59] (03CR) 10Arlolra: [C: 032] Update CHANGELOG. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/163864 (owner: 10Cscott) [00:21:24] (03CR) 10Arlolra: [C: 032] Release 1.1.0. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/163865 (owner: 10Cscott) [00:21:48] (03CR) 10Arlolra: [C: 032] Bump version after release. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/163866 (owner: 10Cscott) [00:23:40] (03Merged) 10jenkins-bot: Update CHANGELOG. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/163864 (owner: 10Cscott) [00:24:12] (03Merged) 10jenkins-bot: Release 1.1.0. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/163865 (owner: 10Cscott) [00:24:14] (03Merged) 10jenkins-bot: Bump version after release. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/163866 (owner: 10Cscott) [00:32:06] (03PS1) 10Cscott: Fix `-j` option to loadtest.js script. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164004 [00:35:12] (03CR) 10Legoktm: [C: 032] Strip signatures for Flow and LQT [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/162533 (owner: 10Wctaiwan) [00:35:52] (03Merged) 10jenkins-bot: Strip signatures for Flow and LQT [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/162533 (owner: 10Wctaiwan) [00:35:55] (03PS1) 10Cscott: Move load testing scripts to `mw-ocg-service` package. [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/164005 [00:47:06] (03CR) 10Arlolra: "Makes sense, but I've got some patches against it that haven't been reviewed." [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/164005 (owner: 10Cscott) [00:48:52] (03CR) 10Cscott: "If it's not too much trouble, then rebasing it over into mw-ocg-service would probably be good." [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/164005 (owner: 10Cscott) [00:49:28] (03CR) 10Arlolra: [C: 032] "No problem." [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/164005 (owner: 10Cscott) [00:54:24] (03CR) 10Krinkle: PrefixSearch: Add unit tests for StringPrefixSearch (031 comment) [core] - 10https://gerrit.wikimedia.org/r/162190 (owner: 10Krinkle) [01:00:00] 3MediaWiki / 3File management: Find a better solution for a "clickable image" on file pages - 10https://bugzilla.wikimedia.org/71485#c2 (10Bawolff (Brian Wolff)) > > Some of our users have limited data plans and this can be quite costly for > them. Given we have an `original file` link it seems surplus. I... [01:00:07] (03PS14) 10Jackmcbarn: Implement page status indicators [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [01:00:40] (03CR) 10Jackmcbarn: "PS14: Rebase with conflict in release notes" [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [01:02:02] 3MediaWiki extensions / 3CirrusSearch: Redirects should appear in Cirrus's results - 10https://bugzilla.wikimedia.org/71491 (10Gryllida) 3NEW p:3Unprio s:3normal a:3None [ It is advised that this bug is treated with higher priority, as deprecation of Lucene search has rendered a Wikilinker Gadget unu... [01:02:15] 3MediaWiki extensions / 3CirrusSearch: Stemming: CirrusSearch does not find Биология for a Биологии query on ru.wp (but LuceneSearch does) - 10https://bugzilla.wikimedia.org/69766#c16 (10Gryllida) Ok, filed bug 71491. Thanks! :) [01:05:32] 3MediaWiki / 3MediaWiki UI: Remove $wgUseMediaWikiUIEverywhere dependency for button and text input styling (tracking) - 10https://bugzilla.wikimedia.org/70913 (10Matthew Flaschen) [01:05:32] 3MediaWiki / 3MediaWiki UI: Information & Discussion links on Beta features page should use mw.ui quiet neutral state - 10https://bugzilla.wikimedia.org/71346#c1 (10Matthew Flaschen) I don't agree that it blocks that. It's neither a button nor an input, nor is there anything on other pages it looks inconsis... [01:06:15] (03PS3) 10EBernhardson: Detect signature using Title class [extensions/Echo] - 10https://gerrit.wikimedia.org/r/163651 (https://bugzilla.wikimedia.org/71353) [01:11:31] (03PS3) 10Spage: Don't fatal if a notification fails to initialize [extensions/Echo] - 10https://gerrit.wikimedia.org/r/163979 (https://bugzilla.wikimedia.org/71489) (owner: 10EBernhardson) [01:12:09] (03CR) 10Spage: [C: 032] "Let's try it." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/163979 (https://bugzilla.wikimedia.org/71489) (owner: 10EBernhardson) [01:12:40] (03Merged) 10jenkins-bot: Don't fatal if a notification fails to initialize [extensions/Echo] - 10https://gerrit.wikimedia.org/r/163979 (https://bugzilla.wikimedia.org/71489) (owner: 10EBernhardson) [01:13:26] gwicke: Do you know that bug where you were talking about IE usage and dropping support for login? I can't find it. [01:17:35] (03CR) 10Jackmcbarn: Detect signature using Title class (034 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/163651 (https://bugzilla.wikimedia.org/71353) (owner: 10EBernhardson) [01:18:12] ebernhardson: what do you think of hooking the PST to tell you when it expands a ~~~~, instead of looking for the result after the fact? [01:20:14] (03CR) 10Mattflaschen: [C: 04-1] "It doesn't seem necessary to separate the IE 6 code into a separate patch, when we already have the code." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/155856 (https://bugzilla.wikimedia.org/69212) (owner: 10SG) [01:28:01] James_F: https://bugzilla.wikimedia.org/show_bug.cgi?id=56575 [01:28:24] gwicke: Aha, thanks. [01:28:31] jackmcbarn: hmm, at least for echo's use case it should be workable and provide a stronger guarantee. There were other use cases mentioned, but i suppose echo is the only one i really care about :) [01:44:38] (03CR) 10Waldir: "@Isarra indeed, I find the skin visually appealling but fairly confusing. I'll be experimenting on the next few weeks with alternative way" [skins/erudite] - 10https://gerrit.wikimedia.org/r/162958 (owner: 10Waldir) [01:57:45] 3MediaWiki extensions / 3CirrusSearch: Redirects should appear in Cirrus's results - 10https://bugzilla.wikimedia.org/71491#c1 (10Chad H.) I can't help but think we've got something backwards here. Wasn't the point of gerrit 118592 to always include them? [02:00:22] (03CR) 10EBernhardson: Detect signature using Title class (034 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/163651 (https://bugzilla.wikimedia.org/71353) (owner: 10EBernhardson) [02:00:26] (03PS4) 10EBernhardson: Detect signature using Title class [extensions/Echo] - 10https://gerrit.wikimedia.org/r/163651 (https://bugzilla.wikimedia.org/71353) [02:03:23] ebernhardson: why do you need to strip signatures? [02:03:44] (03PS6) 10PleaseStand: Special:BookSources: Correct validation of ISBNs containing X [core] - 10https://gerrit.wikimedia.org/r/141654 (https://bugzilla.wikimedia.org/67021) [02:04:25] (03CR) 10PleaseStand: "Moved release note to new file and clarified it a little." [core] - 10https://gerrit.wikimedia.org/r/141654 (https://bugzilla.wikimedia.org/67021) (owner: 10PleaseStand) [02:06:26] (03PS5) 10EBernhardson: Detect signature using Title class [extensions/Echo] - 10https://gerrit.wikimedia.org/r/163651 (https://bugzilla.wikimedia.org/71353) [02:06:44] jackmcbarn: because thats how it was written before i started working on mediawiki :P [02:07:54] sec i'll have to lookup which notifications are using getTextSnippet [02:08:33] (03CR) 10Anomie: "It seems what's happening there is that some 'SpecialPage_initList' hook function is getting into SpecialPageFactory::getAliasListObject()" [core] - 10https://gerrit.wikimedia.org/r/162956 (owner: 10MaxSem) [02:08:39] ebernhardson: while working on the PST hook for this, i ran into the concern that if the extension learned what the sig looked like, it has to somehow store that info until OnArticleSaveComplete, and it seems rather hacky to just dump it into a static var [02:12:35] jackmcbarn: hmm, yea that would be a bit messy [02:17:46] ebernhardson: i guess scrap that idea and just carry on with the regex way you already have in gerrit [02:18:02] jackmcbarn: actually, it may be that we no longer include that context in notifications, i see the section-text removed from user talk and mention notifications back in july. another usage of it was removed in may. but i'm not sure enough to go around deleting code :P [02:19:17] when i started i asked kaldari about this DiscussionParser and he said noone knows how it works, so i think most people just adjust the notifications to output what they want and not bother adjusting this parser along with those changes [03:09:26] (03CR) 10Arlolra: [C: 032] Move load testing script from `ocg-collection` repository. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163985 (owner: 10Cscott) [03:10:02] (03Merged) 10jenkins-bot: Move load testing script from `ocg-collection` repository. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163985 (owner: 10Cscott) [03:20:05] (03CR) 10Arlolra: [C: 032] Reduce default job lifetime from 5 days to 3. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163986 (owner: 10Cscott) [03:20:38] (03Merged) 10jenkins-bot: Reduce default job lifetime from 5 days to 3. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163986 (owner: 10Cscott) [03:27:17] 3MediaWiki extensions / 3CentralAuth: Create an API module to edit a user's global group membership - 10https://bugzilla.wikimedia.org/71495 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3enhanc a:3None Will be useful for (03PS1) 10Cscott: Fix node 0.8 builds on travis by updating npm only to 1.4.28. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/164028 [03:28:15] 3MediaWiki extensions / 3CentralAuth: CentralAuth/global user rights/groups API; Get global user rights, membership to global groups; and userlist of global groups - 10https://bugzilla.wikimedia.org/16860#c27 (10Kunal Mehta (Legoktm)) (In reply to MZMcBride from comment #26) > (In reply to comment #19) > >... [03:28:16] (03PS1) 10Anomie: Fix SpecialPageFactory list handling [core] - 10https://gerrit.wikimedia.org/r/164029 [03:29:32] (03CR) 10Arlolra: [C: 032] Fix node 0.8 builds on travis by updating npm only to 1.4.28. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/164028 (owner: 10Cscott) [03:30:09] (03PS1) 10Cscott: Fix node 0.8 builds on travis by updating npm only to 1.4.28. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/164030 [03:31:34] (03Merged) 10jenkins-bot: Fix node 0.8 builds on travis by updating npm only to 1.4.28. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/164028 (owner: 10Cscott) [03:32:06] (03CR) 10Arlolra: [C: 032] Disable folder size computation in health check unless explicitly requested. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163997 (owner: 10Cscott) [03:32:50] (03Merged) 10jenkins-bot: Disable folder size computation in health check unless explicitly requested. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163997 (owner: 10Cscott) [03:33:18] (03PS1) 10Cscott: Fix node 0.8 builds on travis by updating npm to 1.4.28. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/164031 [03:33:42] (03CR) 10Cscott: [C: 032] Fix node 0.8 builds on travis by updating npm to 1.4.28. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/164031 (owner: 10Cscott) [03:33:54] (03Merged) 10jenkins-bot: Fix node 0.8 builds on travis by updating npm to 1.4.28. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/164031 (owner: 10Cscott) [03:34:24] (03CR) 10jenkins-bot: [V: 04-1] Fix SpecialPageFactory list handling [core] - 10https://gerrit.wikimedia.org/r/164029 (owner: 10Anomie) [03:45:34] (03CR) 10Arlolra: [C: 032] Use `Promise.method` to ensure function return value is always a promise. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163999 (owner: 10Cscott) [03:46:10] (03Merged) 10jenkins-bot: Use `Promise.method` to ensure function return value is always a promise. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163999 (owner: 10Cscott) [03:49:28] (03CR) 10Arlolra: [C: 032] Improve statistics collection; track cache effectiveness. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164003 (owner: 10Cscott) [03:50:00] (03Merged) 10jenkins-bot: Improve statistics collection; track cache effectiveness. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164003 (owner: 10Cscott) [03:51:29] (03CR) 10Arlolra: [C: 032] Fix `-j` option to loadtest.js script. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164004 (owner: 10Cscott) [03:51:58] (03CR) 10Arlolra: Move load testing scripts to `mw-ocg-service` package. [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/164005 (owner: 10Cscott) [03:52:04] (03CR) 10Arlolra: [C: 032] Move load testing scripts to `mw-ocg-service` package. [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/164005 (owner: 10Cscott) [03:52:10] (03Merged) 10jenkins-bot: Fix `-j` option to loadtest.js script. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164004 (owner: 10Cscott) [03:52:45] 3MediaWiki extensions / 3VectorBeta: CPB: change hover to tap behavior when touchevent is supported. - 10https://bugzilla.wikimedia.org/71424#c2 (10Matthew Flaschen) Most of these desktop touchscreens still have/support mice in addition, right? I think this makes sense. The only risk is if people perceive... [03:52:57] (03CR) 10Arlolra: "Gerrit doesn't like me." [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/164005 (owner: 10Cscott) [03:54:00] (03CR) 10Arlolra: [C: 032] Fix node 0.8 builds on travis by updating npm only to 1.4.28. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/164030 (owner: 10Cscott) [03:55:56] (03PS2) 10PleaseStand: hash_equals(): Avoid division by zero when $known_string is empty [core] - 10https://gerrit.wikimedia.org/r/141643 [03:58:37] (03PS3) 10PleaseStand: hash_equals(): Avoid division by zero when $known_string is empty [core] - 10https://gerrit.wikimedia.org/r/141643 [04:01:56] (03PS7) 10Santhosh: mediawiki.jqueryMsg: Support arbitrary expressions in plural forms [core] - 10https://gerrit.wikimedia.org/r/163460 (https://bugzilla.wikimedia.org/70617) [04:02:19] (03PS2) 10Mattflaschen: Clarify documentation for icons [core] - 10https://gerrit.wikimedia.org/r/163800 [04:02:53] (03CR) 10Mattflaschen: "Spelling fixed in patch set 2." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/163800 (owner: 10Mattflaschen) [04:06:20] 3MediaWiki extensions / 3VectorBeta: CPB: change hover to tap behavior when touchevent is supported. - 10https://bugzilla.wikimedia.org/71424#c3 (10Jared Zimmerman (WMF)) Sounds like you want to work in this Matt ;) [04:11:40] oblivion v. oblivian, eh. [04:12:18] That was more relevant to -operations. [04:12:25] I was reading https://wikitech.wikimedia.org/wiki/Server_Admin_Log [04:12:46] (03CR) 10Arlolra: [C: 032] Save and restore stack of inline decorations around environments, \item, etc. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/163989 (owner: 10Cscott) [04:13:47] (03Merged) 10jenkins-bot: Save and restore stack of inline decorations around environments, \item, etc. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/163989 (owner: 10Cscott) [04:14:20] (03Merged) 10jenkins-bot: Fix node 0.8 builds on travis by updating npm only to 1.4.28. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/164030 (owner: 10Cscott) [04:14:56] (03PS3) 10Yurik: Recursive git-update [vagrant] - 10https://gerrit.wikimedia.org/r/163293 [04:15:36] bd808|BUFFER, ping me when around, bash is misbehaving in ^ [04:15:37] :) [04:27:50] (03PS1) 10Arlolra: Whitespace cleanup [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164032 [04:27:52] (03PS1) 10Arlolra: Group latex errors [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164033 [04:29:01] (03CR) 10jenkins-bot: [V: 04-1] Group latex errors [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164033 (owner: 10Arlolra) [04:29:36] (03Abandoned) 10Arlolra: Whitespace cleanup [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/163214 (owner: 10Arlolra) [04:30:13] (03Abandoned) 10Arlolra: Group latex errors [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/163081 (owner: 10Arlolra) [04:32:16] (03PS1) 10tosfos: Fix for page titles that have commas in them [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/164034 [04:36:01] (03CR) 10Cscott: [V: 032] "oh, right, this repo doesn't have jenkins running so you have to publish and submit." [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/164005 (owner: 10Cscott) [04:37:09] (03CR) 10Arlolra: [C: 031] "Needs a rebase." [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163064 (owner: 10Arlolra) [04:37:26] (03CR) 10Arlolra: [C: 04-1] "I mean minus." [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163064 (owner: 10Arlolra) [04:37:47] (03CR) 10Arlolra: [C: 04-1] "Needs a rebase." [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164033 (owner: 10Arlolra) [04:50:52] (03PS2) 10Arlolra: Group latex errors [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164033 [04:50:54] (03PS4) 10Arlolra: Parse and display latex errors from child processes [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163064 [05:18:33] 3MediaWiki-Vagrant: Please rename mediawiki-vagrant.gemspec to another name - 10https://bugzilla.wikimedia.org/71496 (10Yuri Astrakhan) 3NEW p:3Unprio s:3enhanc a:3None Would it be ok to rename mediawiki-vagrant.gemspec to any name that doesn't start with mediawiki? This way autocomplete completes the... [06:02:38] (03PS1) 10Mattflaschen: Use skinStyles for mediawiki.ui.icon [core] - 10https://gerrit.wikimedia.org/r/164036 [06:11:18] 3MediaWiki / 3MediaWiki UI: Fix Special:PasswordReset - 10https://bugzilla.wikimedia.org/71448 (10Matthew Flaschen) a:3Matthew Flaschen [06:18:40] (03PS1) 10Mattflaschen: Fix input regression affecting HTMLForms that use VForm [core] - 10https://gerrit.wikimedia.org/r/164037 (https://bugzilla.wikimedia.org/71448) [06:21:00] 3MediaWiki / 3MediaWiki UI: Fix Special:PasswordReset - 10https://bugzilla.wikimedia.org/71448#c2 (10Matthew Flaschen) (In reply to Prateek Saxena from comment #0) > - Input should be inline Actually, it's intended to use the VForm layout that login/signup do; this means it should not be inline. It was add... [06:59:58] (03PS4) 10Pastakhov: refactor and extend usability (v 3.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/163544 [07:19:13] (03PS5) 10Pastakhov: refactor and extend usability (v 3.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/163544 [07:20:11] (03CR) 10Bartosz Dziewoński: [C: 032] Use skinStyles for mediawiki.ui.icon [core] - 10https://gerrit.wikimedia.org/r/164036 (owner: 10Mattflaschen) [07:25:35] (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.jqueryMsg: Support arbitrary expressions in plural forms [core] - 10https://gerrit.wikimedia.org/r/163460 (https://bugzilla.wikimedia.org/70617) (owner: 10Santhosh) [07:26:44] (03Merged) 10jenkins-bot: Use skinStyles for mediawiki.ui.icon [core] - 10https://gerrit.wikimedia.org/r/164036 (owner: 10Mattflaschen) [07:26:47] 3MediaWiki / 3Internationalization: Displays another file instead of a link to "the existing file". - 10https://bugzilla.wikimedia.org/70617#c8 (10Bartosz Dziewoński) 5PATC>3RESO/FIX Thanks Santhosh! [07:32:02] (03Merged) 10jenkins-bot: mediawiki.jqueryMsg: Support arbitrary expressions in plural forms [core] - 10https://gerrit.wikimedia.org/r/163460 (https://bugzilla.wikimedia.org/70617) (owner: 10Santhosh) [08:07:50] (03CR) 10Zfilipin: "Antoine did some work on generating the documentation from the source code comments recently (for Ruby), he should know how to set it up." [search/extra] - 10https://gerrit.wikimedia.org/r/163268 (owner: 10Manybubbles) [08:09:07] (03PS6) 10Pastakhov: refactor and extend usability (v 3.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/163544 [08:11:54] (03CR) 10Zfilipin: "It is really hard for me to do a good review when a commit does a lot of stuff, especially both moving code around _and_ changing it. Per" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163901 (owner: 10Cmcmahon) [08:18:01] 3Wikimedia / 3Site requests: Add domain metilli.com to wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/71460 (10Andre Klapper) p:5Unprio>3Normal s:5normal>3enhanc [08:18:15] 3Wikimedia / 3Site requests: Enable the MediaWiki UI / "Form Refresh" Beta Feature in production - 10https://bugzilla.wikimedia.org/71477 (10Andre Klapper) p:5Unprio>3Normal s:5normal>3enhanc [08:24:43] (03PS7) 10Pastakhov: refactor and extend usability (v 3.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/163544 [09:35:47] 3Wikimedia / 3SSL related: OpenSearch is not using https in its content even it's being accessed via https - 10https://bugzilla.wikimedia.org/31325#c3 (10Andre Klapper) (In reply to Roan Kattouw from comment #2) > liangent RoanKattouw: Bug 31325 - what if I want to access https pages from > my firefox search... [09:36:49] hello . i have added LanguageTt.php and added tt in LanguageConverter.php . how to make converter links appear (in every page) ? i have checked uzbek language and it also do not make it appear as in wikipedia. [09:37:02] oh this is wrong [09:37:06] channel [09:37:45] no it is ok [09:40:41] it is said in #mediawiki topic [09:51:04] springle: hey, thanks for the feedback! [09:51:50] quick question: if i split a big insert or delete into batches, should each batch be in a separate transaction? That would kind of defeat the purpose of transactions... [09:53:05] qdb: #mediawiki is better for that kind of question, #wikimedia-dev is about writing software, not using it. But it's not a big deal, and the relevant people are in both channels anyway. [09:53:32] qdb: i don't know the answer to your question, but maybe liangent does... [09:54:16] qdb: hm, re-reading your question, perhaps it is about coding :) [09:54:57] DanielK_WMDE: right, multiple transactions isn't really useful. that will be the point where we discuss making it an async job if $rows > N or something [09:55:19] yes you are right ... additionally we can see that i have to make some coding ... [09:57:16] springle: ok. but that would be done on a more abstract level. UsageUpdater would be triggered via the job queue (or put stuff on the job queue). [09:57:20] thanks! [09:57:26] yep [09:57:28] yw [09:57:43] DanielK_WMDE: if you come to benchmark it on beta or something, ping me [09:57:59] and AaronSchultz too [09:58:19] springle: ok. we'll first need content that makes use of the new feature. [09:58:29] of and by itself, it will generate next to no load. [09:58:49] only when people start using wikidata items across pages will this have any impact [09:59:26] springle: actually, i'll file a bug for benchmarking this, so it's in the queue. will cc you [09:59:32] tahnks [10:04:48] 3MediaWiki extensions / 3WikidataRepo: benchmark database performance of usage tracking - 10https://bugzilla.wikimedia.org/71498 (10Daniel Kinzler) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Once we have usage tracking enabled on clients, and have some page content making use of "random" entities, we... [10:05:02] 3MediaWiki extensions / 3WikidataClient: benchmark database performance of usage tracking - 10https://bugzilla.wikimedia.org/71498 (10Daniel Kinzler) [10:05:02] 3MediaWiki extensions / 3WikidataClient: track entity usage on client pages - 10https://bugzilla.wikimedia.org/47288 (10Daniel Kinzler) [10:05:29] 3MediaWiki extensions / 3WikidataClient: Usage Tracking: changes should trigger an appropriate update of pages that use the corresponding aspect of the change item - 10https://bugzilla.wikimedia.org/71352 (10Daniel Kinzler) [10:05:45] 3MediaWiki extensions / 3WikidataClient: Usage Tracking: hook up Lua functions to record entity usage - 10https://bugzilla.wikimedia.org/71288 (10Daniel Kinzler) [10:06:00] 3MediaWiki extensions / 3WikidataClient: Maintenance scripts for populating the untity_usage table from the item_per_site table. - 10https://bugzilla.wikimedia.org/71050 (10Daniel Kinzler) [10:06:38] springle: https://bugzilla.wikimedia.org/show_bug.cgi?id=71498 [10:07:46] DanielK_WMDE: LGTM [10:08:14] :) [10:13:04] qdb: hi [10:13:20] liangent: hi [10:14:47] basically you'll need a TtConverter class (extending LanguageConverter class) [10:15:07] then set $this->mConverter to its instance in the constructor of LanguageTt [10:15:17] 3MediaWiki extensions / 3CentralAuth: Create an API module to edit a user's global group membership - 10https://bugzilla.wikimedia.org/71495 (10billinghurst) [10:15:30] 3Wikimedia / 3General/Unknown: Steward, global sysop and SWMT tasks bugs (tracking) - 10https://bugzilla.wikimedia.org/41492 (10billinghurst) [10:16:44] liangent: i have made it . my problem is i do not see language switcher [10:17:26] qdb: can I have a look at your patch? [10:17:29] liangent: seems it require something like template because it is not shown also in uzbek [10:18:04] also I'm not quite sure what is “language switcher” [10:18:47] liangent: let us make that with uzbek or qazaq first in my local install as it is in wikipedia. what it is ? - look at wikipedia [10:19:12] http://uz.wikipedia.org/ [10:19:40] oh, nice mediawiki.jqueryMsg: Support arbitrary expressions in plural forms [10:19:44] 3MediaWiki extensions / 3CirrusSearch: Redirects should appear in Cirrus's results - 10https://bugzilla.wikimedia.org/71491#c2 (10Gryllida) Please see problem description, (1). How to get "Биология" (and NOT 'Категория:Биология') appear in these results? [10:20:13] Bosh Sahifa Munozara > lotin/кирилл < here it is , liangent [10:20:43] qdb: got it [10:21:14] qdb: might be a local JS hack, not as core feature at all. [10:21:27] (03CR) 10Springle: "Plan seems sane." [core] - 10https://gerrit.wikimedia.org/r/163470 (https://bugzilla.wikimedia.org/10593) (owner: 10Umherirrender) [10:21:45] 3MediaWiki extensions / 3WikidataRepo: Exception: Can only add Wikibase\DataModel\Snak\Snak implementing objects to Wikibase\DataModel\Snak\SnakList - 10https://bugzilla.wikimedia.org/71479#c1 (10Aude) 2014-10-01 09:15:28 mw1122 wikidatawiki: [846d5661] /w/api.php Exception from line 145 of /srv/mediawiki/... [10:21:54] DanielK_WMDE: no it's a core feature in uz [10:21:58] qdb: so what's your patch for tt then? [10:22:22] liangent: i have just edited files [10:22:51] how to turn that feature on ? [10:23:04] qdb: how did you edit files then? [10:23:11] liangent: as you said [10:23:21] but i am not at that step [10:23:46] qdb: is there any exact code that I can have a look at? [10:23:48] as i said , i want to get it with uzbek language [10:24:16] anyway it dows not work because uzbek also does not work [10:24:41] i have copie code from uzbek files and edited [10:25:15] qdb: you copied LanguageUz.php to LanguageTt.php, right? [10:25:28] and added 'tt', in lang. conv. php line 46/47 [10:25:34] yes [10:25:38] then how did you edit it; can you pastebin your LanguageTt.php? [10:27:12] o you think there is error ? it is simple [10:27:22] i ll check qazaq [10:28:02] i have an ides [10:28:14] i should change it from php config [10:28:22] not from persona config [10:28:32] eh you didn't set $wgLanguageCode='tt'? [10:30:11] liangent: yes i did not . now uzbek works [10:30:37] tatar also [10:32:30] qdb: nice [10:32:59] my converter does not work correctly but at least it is ready to further corrections . should i uploa it ? and it can be turned off as i see [10:33:33] 3MediaWiki extensions / 3WikibaseDatabase: Revive WikibaseDatabase - 10https://bugzilla.wikimedia.org/71499 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Get WikibaseDatabase back to life to reduce dependencies of WikibaseQueryEngine to DBAL. [10:34:01] 3MediaWiki extensions / 3WikibaseDatabase: Revive WikibaseDatabase - 10https://bugzilla.wikimedia.org/71499 (10tobias.gritschacher) p:5Unprio>3High [10:34:31] i ll try to uploa it via git-gui [10:35:48] qdb: if you speak tatar, maybe you'd better improve it a little bit, and most importantly, the conversion table, before uploading. [10:36:14] I guess it'll be not so easy to find a reviewer speaking tatar [10:36:56] liangent: i think i will make a commit now , but do not uploa [10:37:50] but what reason to not upload then ? i think this on was separate step . further corrections will be very long . now it is simple table [10:39:31] 3MediaWiki extensions / 3WikibaseDatabase: Creating the DBAL implementation of WikibaseDatabase interfaces - 10https://bugzilla.wikimedia.org/71500 (10tobias.gritschacher) p:5Unprio>3High [10:39:35] it is not like erroneus ... but it is too simple , it is correct for that level of simplicity ... [10:39:37] qdb: then say "conversion table is not ready" or something in the commit message? [10:39:52] yes am writing it [10:40:31] 3MediaWiki extensions / 3WikibaseQueryEngine: Switch QueryEngine over from executing queries via DBAL to use WikibaseDatabase - 10https://bugzilla.wikimedia.org/71501 (10tobias.gritschacher) p:5Unprio>3High [10:41:17] 3MediaWiki extensions / 3WikidataRepo: add browsertest for editing property pages - 10https://bugzilla.wikimedia.org/71502 (10Jan Zerebecki) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Add browsertest(s) for editing property pages. [10:41:47] 3MediaWiki extensions / 3WikibaseQueryEngine: Investigate how to prevent schema definition code from not breaking - 10https://bugzilla.wikimedia.org/71503 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs e.g. by including a small part of DBAL in QueryEngine [10:42:01] 3MediaWiki extensions / 3WikibaseQueryEngine: Switch QueryEngine over from executing queries via DBAL to use WikibaseDatabase - 10https://bugzilla.wikimedia.org/71501 (10tobias.gritschacher) [10:42:05] 3MediaWiki extensions / 3WikibaseQueryEngine: Investigate how to prevent schema definition code from not breaking - 10https://bugzilla.wikimedia.org/71503 (10tobias.gritschacher) p:5Unprio>3High [10:43:49] i am at detached head , i should take another branch ? which ? [10:44:40] current branch : head [10:45:57] cannot i just commit? [10:46:13] i think not [10:46:25] i ll look at branches view ... [10:47:14] may be i should make my own branch first [10:48:09] that was mentioned in some wiki ... [10:54:21] 3MediaWiki extensions / 3WikibaseQueryEngine: Adapt build script for entity store - 10https://bugzilla.wikimedia.org/71505 (10tobias.gritschacher) p:5Unprio>3High [11:00:36] liangent: can you help me? https://www.mediawiki.org/wiki/Gerrit/Tutorial#Create_a_branch says to crete a branch but i cannot find any other such branch names , to take as example [11:00:51] liangent: or i can just commit? [11:01:18] 3MediaWiki / 3MediaWiki UI: False height of checkbox focus ::after - 10https://bugzilla.wikimedia.org/71506 (10Florian) 3NEW p:3Unprio s:3normal a:3None Created attachment 16638 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16638&action=edit invalid negative height result in Google Chrome L... [11:01:47] 3MediaWiki extensions / 3SemanticForms: "text with autocomplete" input does not autocomplete when using custom separators - 10https://bugzilla.wikimedia.org/71507 (10Leonard Wallentin) 3NEW p:3Unprio s:3normal a:3Yaron Koren It seems, in SF 2.7, like if text_with_autocomplete only works when using th... [11:03:02] 3Wikimedia / 3General/Unknown: Next wmf deployment (tracking) - 10https://bugzilla.wikimedia.org/38865 (10Florian) [11:03:12] 3MediaWiki / 3MediaWiki UI: False height of checkbox focus ::after - 10https://bugzilla.wikimedia.org/71506 (10Florian) [11:03:12] 3MediaWiki / 3MediaWiki UI: Dimensions of checkboxes are defined in pixels and margins are not to spec - 10https://bugzilla.wikimedia.org/70133 (10Florian) [11:03:12] 3MediaWiki / 3MediaWiki UI: Implement checkbox spec in mediawiki.ui - 10https://bugzilla.wikimedia.org/69200 (10Florian) [11:04:19] 3MediaWiki extensions / 3WikidataRepo: Argument 1 passed to LegacyClaimDeserializer::setRank() must be an instance of Wikibase\DataModel\Claim\Statement, Wikibase\DataModel\Statement\Statement - 10https://bugzilla.wikimedia.org/71508 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs this is happenin... [11:04:35] 3Wikimedia / 3Site requests: Add domain metilli.com to wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/71460 (10Glaisher) 5PATC>3RESO/FIX [11:05:47] 3MediaWiki extensions / 3WikidataRepo: Argument 1 passed to LegacyClaimDeserializer::setRank() must be an instance of Wikibase\DataModel\Claim\Statement, Wikibase\DataModel\Statement\Statement - 10https://bugzilla.wikimedia.org/71508 (10Aude) [11:05:47] 3MediaWiki extensions / 3WikidataRepo: Argument 1 passed to Wikibase\TermSqlIndex::getTermsOfEntity() must be an instance of Wikibase\EntityId, Wikibase\DataModel\Entity\ItemId given - 10https://bugzilla.wikimedia.org/71509 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs from test.wikidata... Fat... [11:06:04] 3MediaWiki extensions / 3WikidataRepo: Argument 1 passed to Wikibase\TermSqlIndex::getTermsOfEntity() must be an instance of Wikibase\EntityId, Wikibase\DataModel\Entity\ItemId given - 10https://bugzilla.wikimedia.org/71509 (10Aude) [11:06:04] 3MediaWiki extensions / 3WikidataRepo: [HHVM] Get rid of class aliases - 10https://bugzilla.wikimedia.org/71295 (10Aude) [11:06:04] 3MediaWiki extensions / 3WikidataRepo: [HHVM] Get rid of class aliases - 10https://bugzilla.wikimedia.org/71295 (10Aude) [11:06:45] 3MediaWiki / 3MediaWiki UI: False height of checkbox focus ::after - 10https://bugzilla.wikimedia.org/71506#c1 (10Florian) P.S.: Can be reproduced on each wmf-wiki running 1.25wmf1 (testwiki, mediawiki, wikinews, wikisource, e.g.) on the login form, e.g.: https://www.mediawiki.org/wiki/Special:UserLogin [11:07:31] 3MediaWiki extensions / 3WikidataRepo: [HHVM] Get rid of class aliases - 10https://bugzilla.wikimedia.org/71295 (10Aude) [11:07:32] 3MediaWiki extensions / 3WikidataRepo: Argument 3 passed to Wikibase\LabelDescriptionDuplicateDetector::detectTerm Conflicts() must be an instance of Wikibase\EntityId, Wikibase\DataModel\Entity\ItemId given - 10https://bugzilla.wikimedia.org/71510 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs S... [11:09:45] 3Wikimedia / 3Site requests: Move wiki.toolserver.org to WMF - 10https://bugzilla.wikimedia.org/60220#c36 (10Merlijn van Deen) Moving to Site requests as this is a request for a WMF-hosted wiki. [11:10:00] 3MediaWiki extensions / 3CentralAuth: Error while merging accounts with MergeAccount on WikiVoyage: "1062: Duplicate entry for key 'wl_user'" - 10https://bugzilla.wikimedia.org/45035#c5 (10RolandUnger) I think it was Special:MergeAccount. But this service was stopped some time ago to our wiki. It seems that... [11:10:02] 3Wikimedia / 3Site requests: Wikis waiting for creation (tracking) - 10https://bugzilla.wikimedia.org/16976 (10Merlijn van Deen) [11:11:58] i ll just commit and see what people say [11:14:24] fatal: Authentication failed for 'https://gerrit.wikimedia.org/r/p/mediawiki/core.git/' Pushing to https://gerrit.wikimedia.org/r/p/mediawiki/core.git [11:16:52] should i indeed create a branch for me? [11:17:41] please show me your branch names , if you have them an can show [11:18:52] i see https://git.wikimedia.org/log/mediawiki%2Fcore.git - seems there are branched here [11:19:06] how to see their names? [11:19:40] Merge "Use skinStyles for mediawiki.ui.icon" - seems this is b. name in quootes [11:20:01] 3Wikimedia / 3Apache configuration: Set up redirect webserver for toolserver.org - 10https://bugzilla.wikimedia.org/60238#c6 (10Liu Xin Yu) jira.toolserver.org ditto [11:25:27] i have created new branch and commit. [11:34:01] but i cannot push [11:36:54] need i gerrit software ? [11:37:06] local? [11:37:08] which error are you seeing? [11:37:21] cannot authenticate [11:37:44] with http(s)? [11:38:22] fatal: Authentication failed for 'https://gerrit.wikimedia.org/r/p/mediawiki/core.git/' Pushing to https://gerrit.wikimedia.org/r/p/mediawiki/core.git [11:38:37] (it aske for login and password ) [11:38:56] then type in your username and password [11:39:01] i typed [11:39:11] what happened then? [11:39:25] that above message [11:39:43] is your username/password wrong? [11:39:45] i have trie also another password ) ssh's [11:40:26] you have to use the password and username which can be seen from https://gerrit.wikimedia.org/r/#/settings/http-password [11:40:47] thank you [11:41:57] ! [remote rejected] TtConverter -> TtConverter (prohibited by Gerrit) ... error: failed to push some refs to 'https://gerrit.wikimedia.org/r/p/mediawiki/core.git' [11:41:57] Hello, I'm wm-bot. The database for this channel is published at http://bots.wmflabs.org/~wm-bot/db/%23mediawiki.htm More about WM-Bot: https://meta.wikimedia.org/wiki/wm-bot [11:43:14] hm [11:43:14] also text before that : POST git-receive-pack (2515 bytes) remote: Resolving deltas: 100% (4/4) remote: Resolving deltas: 100% (4/4) remote: Processing changes: refs: 1remote: Processing changes: refs: 1, done  Pushing to https://gerrit.wikimedia.org/r/p/mediawiki/core.git To https://gerrit.wikimedia.org/r/p/mediawiki/core.git [11:43:31] I've never seen taht error [11:43:49] are you sure you are pushing to the correct repo? [11:44:06] Glaisher: no [11:44:20] what are you trying to do? [11:44:23] Glaisher: i have edited files i downloaded from that repo [11:44:36] which repo? [11:44:43] mediawiki/core ? [11:44:45] Glaisher: i added converter classes and files [11:44:52] for tatar language [11:44:54] yes [11:45:17] i am not sure ... i just press push ... [11:46:53] qdb: can you pastebin your complete terminal scrollback [11:46:58] i do not see repo name here [11:47:09] liangent: i am using git gui [11:47:32] eh I guess I can't help much here [11:47:41] I'm pretty sure there's a log in git gui [11:47:53] that is what you just copy pasted [11:49:05] i ll try terminal [12:00:03] https://www.mediawiki.org/wiki/Gerrit/Tutorial#Commit_Hook_and_Change-ID [12:00:07] https://www.mediawiki.org/wiki/Gerrit/Tutorial#Commit_Hook_and_Change-ID [12:00:09] https://www.mediawiki.org/wiki/Gerrit/Tutorial#Commit_Hook_and_Change-ID [12:00:12] https://www.mediawiki.org/wiki/Gerrit/Tutorial#Commit_Hook_and_Change-ID [12:00:16] https://www.mediawiki.org/wiki/Gerrit/Tutorial#Commit_Hook_and_Change-ID [12:00:31] oh [12:00:43] my chat was scrolled [12:01:21] what to write in to Bug: xxxxxx ? [12:01:39] bug number [12:02:30] public static function whoIs( $wikiID, $id ) { [12:02:30] $user = self::newFromId( $wikiID, $id ); // FIXME: newFromId is undefined [12:02:39] CentralAuth, wat. [12:03:34] hoo, you seen CentralAuthGroupMembershipProxy::whoIs ? [12:03:41] (03PS1) 10Qdinar: Tatar converter, does not work correctly, as it has just very simple conversion tables now Change-Id: I18768eb1b13c04a6cb597930fc1e8a3977ec5c74 [core] - 10https://gerrit.wikimedia.org/r/164049 [12:04:01] I guess so [12:04:19] Glaisher: i have left it empty [12:04:30] iremoved it [12:04:32] 3MediaWiki extensions / 3CentralAuth: Create an API module to edit a user's global group membership - 10https://bugzilla.wikimedia.org/71495 (10Alex Monk) 5NEW>3ASSI a:3Alex Monk [12:04:36] that also works [12:04:38] Anyway I want to make that function and I'm not giving it a wikiID param [12:04:43] if there is no relevant bug [12:05:26] Krenair: How should that work? [12:05:49] What, whoIs with a foreign wiki ID... in centralauth? No clue. [12:06:03] I think I'll just make it ignore the wiki ID parameter. [12:06:14] Anything using that function at the moment will crash anyway, so... [12:08:30] 3MediaWiki extensions / 3SemanticForms: "text with autocomplete" input does not autocomplete when using custom separators - 10https://bugzilla.wikimedia.org/71507#c1 (10Yaron Koren) Is this still the case with the latest version, 2.8? I should note that, in SF 2.8, "text with autocomplete" for lists is some... [12:09:56] (03PS1) 10Alex Monk: User rights API: Abstract out some stuff about core's form into separate methods [core] - 10https://gerrit.wikimedia.org/r/164051 (https://bugzilla.wikimedia.org/71495) [12:12:16] (03PS2) 10Alex Monk: User rights API: Abstract out some stuff about core's form into separate methods [core] - 10https://gerrit.wikimedia.org/r/164051 (https://bugzilla.wikimedia.org/71495) [12:16:01] 3MediaWiki extensions / 3SemanticForms: "text with autocomplete" input does not autocomplete when using custom separators - 10https://bugzilla.wikimedia.org/71507#c2 (10Leonard Wallentin) Ok, I didn't know that. Will upgrade, and tell you how it goes! [12:16:52] (03PS1) 10Alex Monk: Global user rights API [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/164055 (https://bugzilla.wikimedia.org/71495) [12:17:58] (03CR) 10Liangent: [C: 04-1] Tatar converter, does not work correctly, as it has just very simple conversion tables now Change-Id: I18768eb1b13c04a6cb597930fc1e8a3977ec5 (033 comments) [core] - 10https://gerrit.wikimedia.org/r/164049 (owner: 10Qdinar) [12:19:18] 3MediaWiki extensions / 3WikidataRepo: create filter by language that can be applied to objects before passing to serialization - 10https://bugzilla.wikimedia.org/71512 (10Jan Zerebecki) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Create filter by language that can be applied to objects before passing... [12:21:47] 3MediaWiki extensions / 3WikidataRepo: create filter by language that can be applied to objects before passing to serialization - 10https://bugzilla.wikimedia.org/71512 (10Jan Zerebecki) p:5Unprio>3Normal [12:21:47] 3MediaWiki extensions / 3CirrusSearch: Handle plurals better - 10https://bugzilla.wikimedia.org/71513 (10Liangent) 3NEW p:3Unprio s:3normal a:3None I was looking for https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines but I can't remember the exact page name. I typed "Commit message guide... [12:22:00] 3MediaWiki extensions / 3WikidataRepo: Replace old serialization code in lib with datamodel serialization - 10https://bugzilla.wikimedia.org/62188 (10Jan Zerebecki) [12:23:04] hello [12:23:08] hey qdb [12:23:43] liangent: i have seen your comments in email but i cannot access them from https://gerrit.wikimedia.org/r/#/c/164049/ . and i see they are 3 but see only 2 of them [12:24:15] You need to view the diffs [12:24:19] there is one comment on each file [12:24:59] ok [12:26:59] 3MediaWiki extensions / 3WikidataRepo: create filter by language that can be applied to objects before passing to serialization - 10https://bugzilla.wikimedia.org/71512 (10Jan Zerebecki) [12:32:16] qdb, did you find them? :) [12:32:23] Gerrit is a pain at first. [12:32:44] yes [12:33:01] You'll get used to it. Although we are planning to migrate away soon [12:34:33] (03PS2) 10Qdinar: Add Tatar Converter Tatar converter, does not work correctly, as it has just very simple conversion tables now Change-Id: I18768eb1b13c04a6cb597930fc1e8a3977ec5c74 [core] - 10https://gerrit.wikimedia.org/r/164049 [12:34:48] 3MediaWiki extensions / 3WikidataRepo: Overlapping text in wb-section-heading - 10https://bugzilla.wikimedia.org/71514 (10Sjoerd de Bruin) 3UNCO p:3Unprio s:3normal a:3Wikidata bugs Created attachment 16639 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16639&action=edit Screenshot of the iss... [12:36:15] i made incorrect commit [12:36:24] changes are not uploaed [12:38:07] (03PS3) 10Qdinar: Add Tatar Converter Tatar converter, does not work correctly, as it has just very simple conversion tables now Change-Id: I18768eb1b13c04a6cb597930fc1e8a3977ec5c74 [core] - 10https://gerrit.wikimedia.org/r/164049 [12:38:37] i have mae new commit [12:39:56] can password be entered automatically? [12:40:23] in windows git bash or git gui [12:45:16] 3MediaWiki / 3Interface: #jump-to-nav links make absolutely positioned elements jump - 10https://bugzilla.wikimedia.org/48687 (10Andre Klapper) p:5High>3Normal [12:47:17] 3MediaWiki / 3MediaWiki UI: False height of checkbox focus ::after - 10https://bugzilla.wikimedia.org/71506 (10Andre Klapper) [12:49:00] 3MediaWiki / 3MediaWiki UI: False height of checkbox focus ::after - 10https://bugzilla.wikimedia.org/71506#c2 (10Andre Klapper) Florian: As you marked this as blocking bug 38865, could you elaborate how severe the problem is, and which functionality this problem destroys from a user point of view? [12:50:02] 3Wikimedia / 3General/Unknown: 503s when using HHVM - 10https://bugzilla.wikimedia.org/71515 (10Elitre) 3NEW p:3Unprio s:3normal a:3None There are several reports by editors using HHVM at https://www.mediawiki.org/wiki/Talk:HHVM/About and https://www.mediawiki.org/wiki/Talk:HHVM ; 503 error messages... [12:50:17] 3Wikimedia / 3General/Unknown: Intermittent 403s when using HHVM - 10https://bugzilla.wikimedia.org/71385 (10Elitre) [12:50:17] 3Wikimedia / 3General/Unknown: 503s when using HHVM - 10https://bugzilla.wikimedia.org/71515 (10Elitre) [12:50:20] 3MediaWiki / 3JavaScript: jQuery's .ui-helper-clearfix class is broken/outdated - 10https://bugzilla.wikimedia.org/48858 (10Andre Klapper) p:5High>3Normal [12:50:47] 3MediaWiki / 3JavaScript: Wrong sorting in tables with {{formatnum}} in Spanish Wikipedia (es.wp) due to spaces to separate thousands - 10https://bugzilla.wikimedia.org/42924 (10Andre Klapper) p:5High>3Normal [12:50:47] 3MediaWiki / 3ResourceLoader: Mediawiki no longer accepts unicode object property name without quotes - 10https://bugzilla.wikimedia.org/51539 (10Andre Klapper) p:5High>3Normal [12:54:53] (03CR) 10QChris: Initial commit (031 comment) [extensions/XAnalytics] - 10https://gerrit.wikimedia.org/r/157841 (owner: 10Ori.livneh) [13:00:01] 3Wikimedia / 3Mailing lists: New Mailinglist for Volunteers-Support - 10https://bugzilla.wikimedia.org/69599#c6 (10Muriel Staub) Hi Andre & James, thanks a lot for your feedback. I talked to people from Austria and Germany about this challenge, and we are very much in favour of giving the list the following... [13:04:45] 3Wikimedia / 3Site requests: Add domain metilli.com to wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/71460#c3 (10Mushroom) Thanks! [13:10:45] 3Wikimedia / 3General/Unknown: 503s when using HHVM - 10https://bugzilla.wikimedia.org/71515 (10Ori Livneh) p:5Unprio>3High s:5normal>3major [13:11:45] 3Wikimedia / 3General/Unknown: 503s when using HHVM - 10https://bugzilla.wikimedia.org/71515#c1 (10Ori Livneh) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 71486 *** [13:11:50] 3MediaWiki / 3General/Unknown: HHVM http status code 503 on long pages - 10https://bugzilla.wikimedia.org/71486#c3 (10Ori Livneh) *** Bug 71515 has been marked as a duplicate of this bug. *** [13:12:31] 3MediaWiki / 3General/Unknown: HHVM http status code 503 on long pages - 10https://bugzilla.wikimedia.org/71486 (10Ori Livneh) p:5Unprio>3High s:5normal>3major a:3Ori Livneh [13:21:14] (03CR) 10Hoo man: "You sure inheritance is the way to go here?" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/164055 (https://bugzilla.wikimedia.org/71495) (owner: 10Alex Monk) [13:22:17] 3MediaWiki / 3MediaWiki UI: False height of checkbox focus ::after - 10https://bugzilla.wikimedia.org/71506#c3 (10Florian) (In reply to Andre Klapper from comment #2) > Florian: As you marked this as blocking bug 38865, could you elaborate how > severe the problem is, and which functionality this problem des... [13:22:17] 3Wikimedia / 3General/Unknown: Next wmf deployment (tracking) - 10https://bugzilla.wikimedia.org/38865 (10Florian) [13:22:27] (03CR) 10Alex Monk: "Well, that's what the special page does..." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/164055 (https://bugzilla.wikimedia.org/71495) (owner: 10Alex Monk) [13:22:46] hoo, I guess you're concerned about someone making a change in core and breaking everything? [13:23:07] Krenair: That and that this is CentralAuth 2009 style [13:24:14] 3MediaWiki extensions / 3WikidataRepo: Argument 1 passed to LegacyClaimDeserializer::setRank() must be an instance of Wikibase\DataModel\Claim\Statement, Wikibase\DataModel\Statement\Statement - 10https://bugzilla.wikimedia.org/71508#c1 (10WikidataBugzilla) Commit pushed to evilclassalias at https://github.c... [13:24:22] hoo, so you want to duplicate the whole core api file instead, and change a few calls? [13:24:42] or if you have a better idea, I'd love to hear it [13:25:17] Either that or use composition in a sane way [13:26:15] 3MediaWiki extensions / 3WikidataRepo: Argument 1 passed to LegacyClaimDeserializer::setRank() must be an instance of Wikibase\DataModel\Claim\Statement, Wikibase\DataModel\Statement\Statement - 10https://bugzilla.wikimedia.org/71508#c2 (10WikidataBugzilla) Commit pushed to evilclassalias at https://github.c... [13:26:41] (03CR) 10Hoo man: [C: 032] "No matter what, these changes don't harm" [core] - 10https://gerrit.wikimedia.org/r/164051 (https://bugzilla.wikimedia.org/71495) (owner: 10Alex Monk) [13:27:15] 3MediaWiki extensions / 3WikidataRepo: Argument 1 passed to LegacyClaimDeserializer::setRank() must be an instance of Wikibase\DataModel\Claim\Statement, Wikibase\DataModel\Statement\Statement - 10https://bugzilla.wikimedia.org/71508#c3 (10WikidataBugzilla) Commit pushed to evilclassalias at https://github.c... [13:29:15] 3MediaWiki extensions / 3CirrusSearch: Redirects should appear in Cirrus's results - 10https://bugzilla.wikimedia.org/71491#c3 (10Nik Everett) What Cirrus does now is always search for pages by their redirects but its always the target of the redirect that is returned and never the redirect itself. Cirrus t... [13:32:01] 3MediaWiki extensions / 3WikidataRepo: Argument 1 passed to LegacyClaimDeserializer::setRank() must be an instance of Wikibase\DataModel\Claim\Statement, Wikibase\DataModel\Statement\Statement - 10https://bugzilla.wikimedia.org/71508#c4 (10WikidataBugzilla) Commit pushed to evilclassalias at https://github.c... [13:33:13] (03Merged) 10jenkins-bot: User rights API: Abstract out some stuff about core's form into separate methods [core] - 10https://gerrit.wikimedia.org/r/164051 (https://bugzilla.wikimedia.org/71495) (owner: 10Alex Monk) [13:33:18] (03CR) 10Aklapper: "Can I just self-merge this?" [phabricator/tools] - 10https://gerrit.wikimedia.org/r/157021 (owner: 10Aklapper) [13:33:30] 3MediaWiki extensions / 3WikidataRepo: Argument 1 passed to LegacyClaimDeserializer::setRank() must be an instance of Wikibase\DataModel\Claim\Statement, Wikibase\DataModel\Statement\Statement - 10https://bugzilla.wikimedia.org/71508#c5 (10WikidataBugzilla) Commit pushed to evilclassalias at https://github.c... [13:49:45] 3MediaWiki extensions / 3CirrusSearch: Make sure CirrusSearch recognizes "guidelines" as the plural of "guideline" - 10https://bugzilla.wikimedia.org/71513#c1 (10Nik Everett) p:5Unprio>3Normal Weird - that should work. Cirrus uses kstem which tries to err on the side of being less aggressive with stemmi... [14:03:28] (03CR) 10Anomie: Allow for dynamically-loaded PHP libraries (035 comments) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/163211 (owner: 10Anomie) [14:08:38] (03PS1) 10Manybubbles: Add stemmer_override filter for English [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/164069 (https://bugzilla.wikimedia.org/71513) [14:12:24] (03CR) 10Jackmcbarn: Allow for dynamically-loaded PHP libraries (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/163211 (owner: 10Anomie) [14:15:48] (03PS3) 10Anomie: Allow for dynamically-loaded PHP libraries [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/163211 [14:23:01] (03PS2) 10Anomie: Fix SpecialPageFactory list handling [core] - 10https://gerrit.wikimedia.org/r/164029 [14:26:32] (03PS1) 10Amire80: iEarly return for readability [extensions/Cite] - 10https://gerrit.wikimedia.org/r/164074 [14:28:47] (03CR) 10Hoo man: [C: 032] iEarly return for readability [extensions/Cite] - 10https://gerrit.wikimedia.org/r/164074 (owner: 10Amire80) [14:28:59] (03Merged) 10jenkins-bot: iEarly return for readability [extensions/Cite] - 10https://gerrit.wikimedia.org/r/164074 (owner: 10Amire80) [14:37:29] (03CR) 10Jackmcbarn: [C: 031] "Code looks good, one issue with a comment." (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/163211 (owner: 10Anomie) [14:37:42] hoo: what sort of further discussion should we have about preprocess? [14:38:07] jackmcbarn: didn't cam to that yet [14:38:10] probably next week [14:38:21] huh? [14:38:32] * didn't come [14:38:50] oh [14:40:08] (03PS2) 10Alex Monk: Add initial version of Phabricator Greasemonkey triage script [phabricator/tools] - 10https://gerrit.wikimedia.org/r/157021 (owner: 10Aklapper) [14:40:10] (03CR) 10jenkins-bot: [V: 04-1] Add initial version of Phabricator Greasemonkey triage script [phabricator/tools] - 10https://gerrit.wikimedia.org/r/157021 (owner: 10Aklapper) [14:42:15] (03CR) 10Cscott: [C: 032] Whitespace cleanup [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164032 (owner: 10Arlolra) [14:42:59] (03Merged) 10jenkins-bot: Whitespace cleanup [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164032 (owner: 10Arlolra) [14:44:38] (03PS1) 10Amire80: Replace srting comparison with boolean condition [extensions/Cite] - 10https://gerrit.wikimedia.org/r/164078 [14:46:30] 3Wikimedia / 3Site requests: Move wiki.toolserver.org to WMF - 10https://bugzilla.wikimedia.org/60220#c37 (10Silke Meyer (WMDE)) Cool, thanks for the backup, Nosy! [14:46:48] (03CR) 10Hoo man: [C: 032] "No-op" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/164078 (owner: 10Amire80) [14:46:57] (03Merged) 10jenkins-bot: Replace srting comparison with boolean condition [extensions/Cite] - 10https://gerrit.wikimedia.org/r/164078 (owner: 10Amire80) [14:48:00] (03CR) 10Cscott: [C: 032] Parse and display latex errors from child processes (032 comments) [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163064 (owner: 10Arlolra) [14:48:34] (03Merged) 10jenkins-bot: Parse and display latex errors from child processes [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163064 (owner: 10Arlolra) [14:49:01] (03PS15) 10Jamesmontalvo3: Add file approval and fine-tuned permissions; bump to v1.0 [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 [14:51:03] (03CR) 10Jamesmontalvo3: "Hello from Vienna. The items below from our last several comments have been completed." [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [14:51:59] hoo: I'm not sure what did you mean by "No-op" in https://gerrit.wikimedia.org/r/#/c/164078/ , [14:52:11] but if you replace == with === there, stuff breaks awfully. [14:52:29] aharoni: But you didn't [14:52:46] I did initially :) [14:52:50] Good that I tested. [14:52:50] you replaced $foo == '' with !$foo which boils down to the same thing [14:53:12] PHP is weird... and I'm trying to tell people not to use !$stringVar for ages [14:53:25] ahm, not to use == '' [14:53:31] !$var is actually ok sometimes [14:53:31] Key was added [14:53:40] delete !var [14:53:43] !var [14:53:43] There is no such key, you probably want to try: !@param, !api, !debug, !hooks, !mw-config, !selinux, !subst, !transclusion, !unicode_test, !variables, !oid, !hosts, !$var, [14:53:57] !$var [14:53:57] actually ok sometimes [14:53:59] meh [14:54:00] :P [14:56:22] delete !$var [14:56:34] am i not authorized to use the bot? :( [14:56:49] delete !$var [14:56:55] I don't think it works like that [14:57:01] hoo, jackmcbarn - are there any automatic tests for the Cite extension? [14:57:13] yes [14:57:18] aharoni: When I worked on it it had parser tests [14:57:23] (03CR) 10Cscott: [C: 04-1] "Minor things." (034 comments) [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164033 (owner: 10Arlolra) [14:57:56] So if I commit something bad, Jenkins might catch it? [14:58:15] yes [14:58:39] (03PS1) 10Amire80: Change == to === according to coding conventions [extensions/Cite] - 10https://gerrit.wikimedia.org/r/164081 [14:58:48] (03CR) 10jenkins-bot: [V: 04-1] Change == to === according to coding conventions [extensions/Cite] - 10https://gerrit.wikimedia.org/r/164081 (owner: 10Amire80) [14:58:59] ... and looks like it just did :) [14:59:16] https://integration.wikimedia.org/ci/job/mwext-Cite-testextension/17/console [15:02:18] 3MediaWiki extensions / 3WikidataRepo: Browser smoke test for property - 10https://bugzilla.wikimedia.org/71516 (10tobias.gritschacher) p:5Unprio>3Normal [15:13:00] (03PS3) 10SG: Hygiene: Add tests for the Pager [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163094 (owner: 10EBernhardson) [15:13:04] (03PS4) 10SG: Hygiene: Simplify Pager [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163095 (owner: 10EBernhardson) [15:13:08] (03PS5) 10SG: Add post-query filtering to Pager [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163096 (owner: 10EBernhardson) [15:13:13] (03PS6) 10SG: Change results of moderation dialogs to match filtering [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163097 (owner: 10EBernhardson) [15:15:01] (03PS1) 10Aude: Update Wikidata, fix for editing properties and api debugging [core] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/164082 [15:15:20] (03CR) 10SG: [C: 032] Hygiene: Add tests for the Pager [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163094 (owner: 10EBernhardson) [15:17:34] (03CR) 10Anomie: [C: 032] "SWAT" [core] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/164082 (owner: 10Aude) [15:18:31] 3Wikimedia / 3Site requests: Modify Collection format variables from PDF to ODT for Tamil Wikiprojects - 10https://bugzilla.wikimedia.org/37154#c4 (10C. Scott Ananian) Just as a heads up: the new PDF renderer should render Tamil correctly now -- and the old ODF renderer is going to be shut down on Oct 3. So... [15:19:41] (03Merged) 10jenkins-bot: Hygiene: Add tests for the Pager [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163094 (owner: 10EBernhardson) [15:21:29] (03CR) 10SG: [C: 032] Hygiene: Simplify Pager [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163095 (owner: 10EBernhardson) [15:21:50] hello [15:23:24] Hi qdb [15:23:27] What's up? [15:23:40] is my changeset ok ? it does not have green v mark [15:23:49] https://gerrit.wikimedia.org/r/164049 [15:24:00] https://gerrit.wikimedia.org/r/#/q/status:open,n,003027b2000280e0 [15:24:07] I'll look :) [15:24:29] qdb: It looks like it's passed the basic sanity tests [15:25:28] (03Merged) 10jenkins-bot: Update Wikidata, fix for editing properties and api debugging [core] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/164082 (owner: 10Aude) [15:25:30] (03Merged) 10jenkins-bot: Hygiene: Simplify Pager [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163095 (owner: 10EBernhardson) [15:27:12] (03PS1) 10Amire80: Replace == with isset [extensions/Cite] - 10https://gerrit.wikimedia.org/r/164085 [15:28:48] (03CR) 10SG: [C: 04-1] Add post-query filtering to Pager (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163096 (owner: 10EBernhardson) [15:32:05] (03PS1) 10Amire80: Replace == with isset [extensions/Cite] - 10https://gerrit.wikimedia.org/r/164086 [15:32:07] (03CR) 10Arlolra: Group latex errors (034 comments) [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164033 (owner: 10Arlolra) [15:32:14] (03PS3) 10Arlolra: Group latex errors [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164033 [15:34:04] (03PS4) 10Arlolra: Group latex errors [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164033 [15:37:32] (03PS2) 10Amire80: Change == to === according to coding conventions [extensions/Cite] - 10https://gerrit.wikimedia.org/r/164081 [15:37:39] (03PS7) 10Arlolra: Resizer [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/162540 [15:38:53] (03PS3) 10Amire80: Change == to === according to coding conventions [extensions/Cite] - 10https://gerrit.wikimedia.org/r/164081 [15:43:15] (03PS1) 10Cscott: Update the README for the Collection extension. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/164089 [15:50:49] (03PS1) 10Cscott: Add `rl` as an alias for the `rdf2latex` writer. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164091 [15:51:53] (03PS1) 10Florianschmidtwelzow: Use ems instead of pixels for checkbox [core] - 10https://gerrit.wikimedia.org/r/164092 (https://bugzilla.wikimedia.org/71506) [15:56:43] (03PS1) 10Cscott: Allow setting the desired backend from the loadtest command line. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164094 [16:00:47] (03PS1) 10Gergő Tisza: Enable X11 forwarding for "vagrant ssh" [vagrant] - 10https://gerrit.wikimedia.org/r/164095 [16:09:19] 3Wikimedia / 3Site requests: Don't hardcode list of linked wikis in the "other projects" sidebar - 10https://bugzilla.wikimedia.org/70169 (10Glaisher) 5PATC>3RESO/FIX [16:23:20] (03CR) 10BryanDavis: "Cherry-picked into beta. I'd like it to run there for a while before we call this good to go to prod. My concern is the possibility of 503" [tools/scap] - 10https://gerrit.wikimedia.org/r/163078 (owner: 10Ori.livneh) [16:24:59] (03CR) 10SG: [C: 032] Change results of moderation dialogs to match filtering [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163097 (owner: 10EBernhardson) [16:29:38] (03CR) 10Anomie: Allow for dynamically-loaded PHP libraries (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/163211 (owner: 10Anomie) [16:36:03] (03CR) 10Arlolra: [C: 032] Allow setting the desired backend from the loadtest command line. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164094 (owner: 10Cscott) [16:36:40] (03Merged) 10jenkins-bot: Allow setting the desired backend from the loadtest command line. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164094 (owner: 10Cscott) [16:43:39] (03CR) 10Jdlrobson: [C: 032] Fix input regression affecting HTMLForms that use VForm [core] - 10https://gerrit.wikimedia.org/r/164037 (https://bugzilla.wikimedia.org/71448) (owner: 10Mattflaschen) [16:50:04] (03Merged) 10jenkins-bot: Fix input regression affecting HTMLForms that use VForm [core] - 10https://gerrit.wikimedia.org/r/164037 (https://bugzilla.wikimedia.org/71448) (owner: 10Mattflaschen) [16:53:00] 3MediaWiki / 3MediaWiki UI: Fix Special:PasswordReset - 10https://bugzilla.wikimedia.org/71448 (10Jon) 5PATC>3RESO/FIX [16:53:24] (03CR) 10Jdlrobson: [C: 032] Clarify documentation for icons [core] - 10https://gerrit.wikimedia.org/r/163800 (owner: 10Mattflaschen) [16:55:14] (03CR) 10Jdlrobson: "The IE6 code was broken, as you pointed out hence its removal. I really think blocking this change which effects certain pages on all brow" [core] - 10https://gerrit.wikimedia.org/r/155856 (https://bugzilla.wikimedia.org/69212) (owner: 10SG) [16:58:01] (03CR) 10Jdlrobson: [C: 032] Use ems instead of pixels for checkbox [core] - 10https://gerrit.wikimedia.org/r/164092 (https://bugzilla.wikimedia.org/71506) (owner: 10Florianschmidtwelzow) [16:59:53] (03Merged) 10jenkins-bot: Clarify documentation for icons [core] - 10https://gerrit.wikimedia.org/r/163800 (owner: 10Mattflaschen) [17:04:15] (03PS6) 10EBernhardson: Add post-query filtering to Pager [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163096 [17:04:18] (03Merged) 10jenkins-bot: Use ems instead of pixels for checkbox [core] - 10https://gerrit.wikimedia.org/r/164092 (https://bugzilla.wikimedia.org/71506) (owner: 10Florianschmidtwelzow) [17:05:22] 3MediaWiki / 3MediaWiki UI: False height of checkbox focus ::after - 10https://bugzilla.wikimedia.org/71506 (10Florian) 5PATC>3RESO/FIX [17:10:19] (03PS1) 10Aaron Schulz: Removed $wgPageShowWatchingUsers [core] - 10https://gerrit.wikimedia.org/r/164111 [17:11:10] (03CR) 10Kaldari: "Late review." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) (owner: 10Jdlrobson) [17:12:54] (03CR) 10Kaldari: Add mw-ui-icon (031 comment) [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) (owner: 10Jdlrobson) [17:13:25] (03PS2) 10Aaron Schulz: Removed $wgPageShowWatchingUsers [core] - 10https://gerrit.wikimedia.org/r/164111 [17:14:36] (03PS1) 10Aaron Schulz: Added some profiling calls [core] - 10https://gerrit.wikimedia.org/r/164113 [17:18:44] anomie: i'm running into an issue with a vagrant puppet role for gwtoolset which i'm trying to troubleshoot and need some help narrowing down whether it's a scribunto issue or something else. would you be able to take a look at https://bugzilla.wikimedia.org/show_bug.cgi?id=71354 when you have a chance? [17:18:58] dan-nl: Sure [17:19:19] thanks [17:23:10] (03PS1) 10Aaron Schulz: Removed $wgAntiLockFlags to unify the code paths [core] - 10https://gerrit.wikimedia.org/r/164115 [17:24:17] 3MediaWiki / 3ResourceLoader: CSSMin: Don't generate double rules for IE < 8 when embedding SVG files - 10https://bugzilla.wikimedia.org/71003 (10Bartosz Dziewoński) 5PATC>3RESO/FIX a:3Bartosz Dziewoński [17:24:46] 3MediaWiki / 3ResourceLoader: CSSMin: Embed non-binary data URIs using plain text instead of base64 - 10https://bugzilla.wikimedia.org/67341 (10Bartosz Dziewoński) 5PATC>3RESO/FIX p:5Low>3Normal [17:25:51] dan-nl: At first glance, is it not setting up php-luasandbox or hhvm-luasandbox (depending if it's using zend or hhvm) before it tries to import the dump? [17:27:39] anomie: doesn't this statement, require ::role::scribunto, take care of that? [17:28:38] dan-nl: I'm wondering about ordering, since you said Special:Version shows LuaSandbox is installed if you skip the import. [17:30:27] anomie: yes, so, you'd change the require order? here's the actual role atm [17:30:28] http://git.wikimedia.org/blob/mediawiki%2Fvagrant.git/1376a9298d20fca4e7caa1b4ca1675b37e0dec3e/puppet%2Fmodules%2Frole%2Fmanifests%2Fgwtoolset.pp [17:31:16] the odd thing is that it's only a few of the templates and one module that fails now [17:32:18] i can enable the role and it will pull in the Mediawiki: dumps without issue, but not the more complex templates or the ModuleTemplatePar [17:33:50] spagewmf, RoanKattouw_away, kaldari - are y'all joining SOS? [17:34:19] marktraceur: no, Core features Quarterly Review happening as I type. I updated the Etherpad [17:34:37] Ah [17:44:16] 3Wikimedia / 3General/Unknown: Intermittent 403s when using HHVM - 10https://bugzilla.wikimedia.org/71385 (10Erwin Dokter) [17:44:17] 3MediaWiki / 3General/Unknown: HHVM http status code 503 on long pages - 10https://bugzilla.wikimedia.org/71486 (10Erwin Dokter) [17:47:06] (03CR) 10Arlolra: [C: 032] Add `rl` as an alias for the `rdf2latex` writer. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164091 (owner: 10Cscott) [17:47:41] (03Merged) 10jenkins-bot: Add `rl` as an alias for the `rdf2latex` writer. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164091 (owner: 10Cscott) [17:48:01] 3Wikimedia / 3Site requests: Wikis waiting for creation (tracking) - 10https://bugzilla.wikimedia.org/16976 (10glavkos) [17:48:14] 3Wikimedia / 3Wikidata: Wikimedia Error page on the item for Germany - 10https://bugzilla.wikimedia.org/71519#c1 (10Glaisher) p:5Unprio>3High s:5blocke>3major Confirmed. [17:49:57] anomie: running another session, starting from scratch and enabling the gwtoolset role before the first vagrant up ... [17:51:01] (03CR) 10Cscott: [C: 032] Group latex errors [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164033 (owner: 10Arlolra) [17:51:44] (03Merged) 10jenkins-bot: Group latex errors [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/164033 (owner: 10Arlolra) [17:52:40] anomie: i no longer get any scribunto exceptions, but the importDump.php does continue to fail with what appears to be all exports that have transcludes in them. [17:52:52] anyway, if you don't have anymore time i understand [17:58:14] (03PS3) 10Anomie: Fix SpecialPageFactory list handling [core] - 10https://gerrit.wikimedia.org/r/164029 [17:59:14] dan-nl: Not so much "no time" as "vagrant wants NFS, and I don't want to mess with NFS right now so I can't test it myself" [17:59:34] i see [17:59:45] 3Wikimedia / 3Wikidata: InvalidArgumentException not in exception logs - 10https://bugzilla.wikimedia.org/61914 (10denny vrandecic) [17:59:53] anomie: ah nfs [18:00:07] anomie: vagrant config nfs_shares no [18:00:21] That will turn nfs off for that vm [18:01:07] `vagrant config --list` shows all the flags/settings we have right now [18:01:27] (03CR) 10Anomie: "So now that I thought about it a little more, there's no particular reason the recursive call couldn't succeed for at least limited values" [core] - 10https://gerrit.wikimedia.org/r/162956 (owner: 10MaxSem) [18:01:47] bd808: Awesome, thanks [18:03:48] (03PS1) 10Aaron Schulz: Lowered RENAMEUSER_CONTRIBJOB to avoid query timeouts [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/164121 [18:12:22] 3MediaWiki / 3ResourceLoader: Disabling javascript on olderbrowsers should turn on the