[00:00:33] (03CR) 10Tim Starling: "> What font did you use for tests? Here some examples with DejaVu (IIRC the same Aaron used last time): http://imgur.com/a/nneSy" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/162858 (owner: 10Tim Starling) [00:02:46] (03CR) 10Arlolra: Unify configuration file parsing. (032 comments) [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163527 (owner: 10Cscott) [00:06:21] TimStarling: can i bother you about https://gerrit.wikimedia.org/r/#/c/160367/ ? [00:07:49] yes [00:08:09] are you okay with removing it, even though some wiki asked for it a while ago? [00:08:17] 3Wikimedia / 3SSL related: replace SHA1 certificates with SHA256 - 10https://bugzilla.wikimedia.org/71156#c7 (10chmarkine) I see. Thanks for your explanation. (In reply to Andre Klapper from comment #6) > To some extent that's still to be defined, but the Bugzilla domain will > change to something like bugz... [00:08:26] was there a mailing list announcement? [00:08:37] no. should there be? [00:08:57] (and do you remember which wiki wanted it?) [00:09:18] I think it was a person rather than a wiki [00:10:24] possibly vvv or someone else who was experimenting with it early [00:10:56] and yes, I think there should be an announcement, since we've had no comments on the change [00:11:30] wikitech-l good? [00:11:34] yes [00:11:54] just announce it as a thing that's going to happen unless there are objections [00:12:56] I'll give it +1 for now [00:13:45] 3MediaWiki extensions / 3WikidataRepo: Moving article on client removes badges - 10https://bugzilla.wikimedia.org/70687 (10Marius Hoch) 5PATC>3RESO/FIX [00:14:19] (03CR) 10Tim Starling: [C: 031] "Looks good to me, it just needs a bit more community review." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/160367 (owner: 10Jackmcbarn) [00:14:36] (03CR) 10Arlolra: [C: 04-1] Factor out a method to fork a subprocess and handle messages from the child. (033 comments) [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163525 (owner: 10Cscott) [00:15:14] Nemo_bis: it seems strange to talk about "captcha security" [00:15:50] we've been using this captcha for years, and it turns out it was about as secure as SimpleAntiSpam [00:18:06] realistically, it is at best a proof of work [00:18:44] TimStarling: https://lists.wikimedia.org/pipermail/wikitech-l/2014-September/078806.html [00:19:01] (03CR) 10Jackmcbarn: "https://lists.wikimedia.org/pipermail/wikitech-l/2014-September/078806.html" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/160367 (owner: 10Jackmcbarn) [00:19:38] jackmcbarn: thanks [00:39:51] is plugins.jquery.com down for everyone? [02:04:27] TimStarling, should we include scribunto stuff in the RFC? I could write a simple proposal for that (e.g. readonly API access + "raw" data output capability) [02:05:27] in the API roadmap RFC? I don't think so [02:14:54] TimStarling: If the CAPTCHA is completely ineffective, it raises the obvious question of why have it at all. [02:15:12] no kidding [02:15:36] You know there's an entire account creation subculture? [02:15:52] Like there's apparently enough volume for there to be dedicated infrastructure to account creations. [02:15:59] And it's been like this for years. [02:16:05] wasn't there a WMF proposal to get rid of account creation captchas, which was shouted down by the community? [02:16:13] s/to account/for account/ [02:16:22] Dunno. Spam is still a real problem. [02:16:35] If people think the CAPTCHA is helping with the spam problem, they'll be hesitant to throw it away. [02:17:11] It's not just account creations, of course. All sorts of users suffer it. [02:17:24] Speaking of, is there a reason we output blacklisted spam links? [02:17:56] Carmela: performance [02:18:05] I think if you can bypass the spam filter, you can create an actual link (). We could output nothing or output just the link URL. [02:18:07] it's too expensive to check the blacklist every parse [02:18:17] I don't think that's right. [02:18:28] I think we are checking several blacklists on every(?) edit. [02:18:34] yes, but edits are rare [02:18:36] parses are common [02:18:49] You mean non-edit reparses? [02:18:52] yes [02:19:01] Those are common? [02:19:05] you could make blacklist checking fast if you wanted to [02:19:06] i got a change that did almost exactly that merged, and it was reverted the day after it hit enwp because it doubled memcached traffic [02:19:08] yes, very common [02:19:16] TimStarling: really? how? [02:19:17] * jackmcbarn wants [02:19:24] Is it currently slow? [02:19:36] not time-slow, but it kills memcached [02:20:08] stop using regexes, for most of the blacklist entries [02:20:24] TimStarling: actually checking wasn't the issue. fetching the global blacklist was [02:20:24] some regexes could be automatically converted to hashtable lookups [02:20:40] if you can convert it to a hashtable lookup, then you can cache the hashtable as a CDB file [02:20:54] then you can have single digit microsecond check times [02:21:00] (plus any remaining regexes) [02:22:24] jackmcbarn: Fetching the global blacklist was the issue? [02:23:33] i think so [02:24:05] paravoid said doubling memcached was the problem, and getSharedBlacklists() is the only thing in SpamBlacklist that involves memcached [02:24:14] You seem to be suggesting that the fetching is the slow part while Tim seems to be suggesting the parsing is the slow part. [02:24:16] well, with regexes you have the overhead of fetching the whole list across the network from memcached, plus decompression, plus regex compilation time, plus regex execution [02:24:21] Though neither seems like it should be very slow. [02:24:43] it would not surprise me if the first three were larger than the last one, but not using regexes fixes all of them [02:25:13] Fair enough. [02:25:29] What would the migration path be? A new MediaWiki message that's MediaWiki:Spamblacklist-plain ? [02:25:38] if we saved a cdb locally, why couldn't we also save a file of regexes locally? [02:26:07] Or would you be able to detect individual entries in the same list for regex capability? [02:26:20] because then you would only remove the first item on my list [02:26:32] well, possibly the second [02:26:41] I'm not sure how valuable regex are. [02:26:50] but you would still have compilation, note that we use the study modifier /S [02:27:22] you would also need to allocate memory for the whole list, and copy it [02:27:55] TimStarling: but that's potentially fast enough, since we did do all of this for a few days, and memcached was the only thing we noticed that was bad [02:28:08] couldn't we do that for now, and then maybe switch away from regexes later? [02:28:35] I'm not sure I followed the memory allocation part. That's for the .cdb approach? [02:28:58] jackmcbarn: you're not sure how slow it will be, but you just want to deploy it anyway? [02:29:11] That's the standard for most code. [02:29:17] TimStarling: we've had it deployed before [02:29:26] it only got undeployed because it hit memcached too hard [02:30:04] and this time, we could put it behind a config flag and control the rollout better, since we expect possible issues [02:30:05] yeah, well you could have easily fixed that at the time if you wanted to [02:30:59] how? [02:31:09] with a file cache obviously [02:31:27] you know $wgCacheDirectory [02:31:28] How often are .cdbs updated? On every edit to the global blacklist? [02:31:50] Carmela: there are no CDB files for the spam blacklist, I am just proposing that [02:32:12] Right, I'm asking how often they would be updated. [02:32:33] if i were to do that, how would i handle updating? [02:32:36] jackmcbarn doesn't even want to implement it [02:32:45] yes i do... [02:32:45] so it's a bit of a moot point [02:32:50] I think you have to fetch three blacklist MediaWiki pages (global, local, and the whitelist). [02:33:05] And it'd be nice if edits to those would reflect quickly, though probably could be up to a day? [02:33:27] i'm just saying we can try a non-breaking change first, then a breaking change if it's still necessary [02:34:30] anyway, you could handle updating the same way as we did it with the local message cache [02:35:20] on update, write a content hash to memcached, and the whole value in another key [02:35:38] then on access, check if the content hash in the file matches the one in memcached [02:35:56] if it is a mismatch, get the new data from the other memcached key and save it locally [02:36:20] if there is no global memcached key, enter a pool counter protected section to avoid a stampede and then fetch it from the database [02:36:22] the global blacklist is longer than i thought, so i guess that would be a big win [02:36:27] i'll try that [02:37:02] Spamblacklist would probably also benefit from ContentHandler, but that's a whole other project. :-) [02:39:21] it's important to use a pool counter if you are doing it on parse [02:39:33] with edits it doesn't matter so much [02:39:49] I was trying to think of places where we use CDB and I only came up with the interwiki map, which is a weird case. [02:39:56] trusted-xff.cdb the other one I see off-hand. [02:40:12] is the * [02:40:26] someone made https://www.mediawiki.org/wiki/CDB so you don't have to [02:40:46] Nice. [02:41:09] We're still listing the Lucene search configuration on https://noc.wikimedia.org/conf/ [02:41:23] we still use lucene, don't we? [02:41:34] I think so, though the file link is broken. [02:42:11] I'm told the switch to better search is waiting on server provisioning. [02:42:37] what operation specifically is going behind the pool counter? the fetch of the full blacklist? [02:43:09] Yep, lucene is still in prod. [02:43:41] BaseBlacklist::buildSharedBlacklists [02:44:34] note that we have PoolCounterWorkViaCallback now, so you can add poolcounter there in about 3 lines of code [02:44:41] TimStarling: the whole function always, or should i split out the case that requires a full fetch? [02:46:09] just wrap the buildSharedBlacklists call in getSharedBlacklists [02:46:58] the memcached call happens before buildSharedBlacklists though [02:47:05] with a pool key that includes $wgDBname, since that is in the cache key [02:47:19] Carmela, mediawiki-config/docroot/noc/conf/lsearch-global-2.1.conf -> /home/wikipedia/conf/lucene/lsearch-global-2.1.conf [02:47:22] yeah, the idea is to protect the cache miss case [02:47:44] Krenair: I think there's a separate whitelist now, maybe? Since the incident. [02:47:46] the scenario is disappearance of the cache key [02:47:51] That was my guess, anyway. [02:48:05] the incident? [02:48:41] say if it takes 3 seconds to rebuild, and say if we do 300 parses per second, then you end up with 900 threads simultaneously loading the blacklist from the DB [02:49:30] that's not nice, so you wrap the cache miss in a pool so 1 thread loads from the database while 899 wait patiently [02:50:04] that would make sense in a normal world, but in our topsy-turvy world (at least as i understand it), the cache *hit* was what was too slow [02:50:13] or am i misunderstanding? [02:51:28] when the cache is updated, you will have a stampede of threads hitting memcached asking for their new data [02:51:42] local cache miss, remote cache hit [02:51:49] oh, now i get it [02:52:02] but pool counter doesn't help there [02:52:04] Carmela, ? [02:52:06] well, not very much [02:52:21] Krenair: I meant highlight.php. [02:52:36] with pool counter, you have those 899 threads waiting, and then you can wake them all up simultaneously once the new data is in the cache [02:52:57] then they can all check the cache (simultaneously) and get their data [02:53:18] Krenair: Maybe the Wikimedia config file just moved? Dunno. [02:53:30] there will be a spike on that memcached server, and it will saturate its network for a bit [02:53:46] but that is about as good as you can do without multicast or sneakernet or something [02:54:06] so i should check the local cache, and if it misses, guard via the poolcounter and try memcached, and if it also misses, then proceed the same as we do now? [02:54:14] Carmela, maybe... [02:54:20] if you did have a pool counter around the remote cache fetch, you would fail to saturate the network and so it would be inefficient [02:54:40] so no, I don't think you should guard the remote cache fetch [02:54:49] nearly saturating the network is why this got reverted last time [02:55:11] or am i really confused? [02:55:31] no, you're not confused [02:56:33] then how is this fix going to be different than the last fix? is it because we'll only saturate right after the blacklist updates, instead of all the time? [02:57:17] yes, it is an improvement [02:57:23] let me just do some sums... [03:00:29] so enwiki:spam_blacklist_regexes is about 100KB compressed [03:00:51] there are 218 apaches in the apaches group [03:01:12] so after an update, 21MB needs to be sent from memcached through a single interface [03:02:53] memcached servers have 1Gbit ethernet, so the spike should be over in about 170ms [03:03:39] so the question is whether it is better to saturate the link for 170ms once every few hours as opposed to all the time [03:04:40] now it all makes sense. [03:17:20] (03CR) 10Arlolra: [C: 04-1] Improve the gc `cleanDir` function to handle nested directories. (031 comment) [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163523 (owner: 10Cscott) [03:20:14] (03PS1) 10Luis Felipe Schenone: Updated and enhanced the extension [extensions/MobileDetect] - 10https://gerrit.wikimedia.org/r/163539 [03:25:43] (03PS2) 10Luis Felipe Schenone: Updated and enhanced the extension [extensions/MobileDetect] - 10https://gerrit.wikimedia.org/r/163539 [03:26:23] (03PS3) 10Luis Felipe Schenone: Updated and enhanced the extension [extensions/MobileDetect] - 10https://gerrit.wikimedia.org/r/163539 [03:26:58] (03CR) 10Luis Felipe Schenone: [C: 032 V: 032] "Tested, it works fine." [extensions/MobileDetect] - 10https://gerrit.wikimedia.org/r/163539 (owner: 10Luis Felipe Schenone) [03:39:10] (03PS1) 10PleaseStand: Deprecate OutputPage::readOnlyPage() [core] - 10https://gerrit.wikimedia.org/r/163540 [03:40:14] (03PS1) 10Gnosygnu: v1.9.5.1 [xowa] - 10https://gerrit.wikimedia.org/r/163541 [03:48:57] (03CR) 10Cscott: Improve the gc `cleanDir` function to handle nested directories. (031 comment) [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163523 (owner: 10Cscott) [03:55:41] (03CR) 10Cscott: Factor out a method to fork a subprocess and handle messages from the child. (033 comments) [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163525 (owner: 10Cscott) [03:57:16] 3Wikimedia / 3Site requests: Move oldwikisource on www.wikisource.org to mul.wikisource.org - 10https://bugzilla.wikimedia.org/62717#c7 (10billinghurst) The mul: interwiki now works within the WSes to point to //wikisource.org [04:00:00] 3Wikimedia / 3Interwiki links: An interlanguage link to oldwikisource is required - 10https://bugzilla.wikimedia.org/32189#c49 (10billinghurst) 5PATC>3RESO/FIX The interlanguage link works beautifully. It was apparently quietly rolled out last week in https://gerrit.wikimedia.org/r/#/c/94593 I am going... [04:05:06] (03PS1) 10PleaseStand: Deprecate OutputPage::rateLimited() [core] - 10https://gerrit.wikimedia.org/r/163543 [04:07:30] 3Wikimedia / 3Mailing lists: Adminship of Hindi Wikipedia Mailing List - 10https://bugzilla.wikimedia.org/71388#c6 (10Muzammil) (In reply to Andre Klapper from comment #5) > [This is getting a bit offtopic now due to my fault, anyway:] > > (In reply to Muzammil from comment #4) > > 1) There are several tech... [04:08:35] (03CR) 10Ori.livneh: "Not to free resources but to keep the caching layer simple and free of application logic. Mark and Giuseppe were in favor of this approach" [extensions/XAnalytics] - 10https://gerrit.wikimedia.org/r/157841 (owner: 10Ori.livneh) [04:09:13] (03CR) 10Gnosygnu: [C: 032 V: 032] "changes for v1.9.4" [xowa] - 10https://gerrit.wikimedia.org/r/161903 (owner: 10Gnosygnu) [04:09:53] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own commit" [xowa] - 10https://gerrit.wikimedia.org/r/159008 (owner: 10Gnosygnu) [04:10:19] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own commit" [xowa] - 10https://gerrit.wikimedia.org/r/160385 (owner: 10Gnosygnu) [04:10:43] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own commit" [xowa] - 10https://gerrit.wikimedia.org/r/163541 (owner: 10Gnosygnu) [04:14:30] 3Wikimedia / 3Interwiki links: An interlanguage link to oldwikisource is required - 10https://bugzilla.wikimedia.org/32189#c50 (10billinghurst) To note that mul: also works betawikiversity, over in the WV space. [04:22:45] 3Wikimedia / 3Mailing lists: Adminship of Hindi Wikipedia Mailing List - 10https://bugzilla.wikimedia.org/71388#c7 (10Andre Klapper) [No need to full-quote my entire previous comment :) ] (In reply to Muzammil from comment #6) > Basically what is the role of a mailing list administrator? As I understand: >... [04:23:46] (03PS1) 10Pastakhov: refactor and extend usability (v 3.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/163544 [04:26:02] (03CR) 10jenkins-bot: [V: 04-1] refactor and extend usability (v 3.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/163544 (owner: 10Pastakhov) [04:28:11] (03PS3) 10Lilu: [WIP] PermissionManager Recode [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/159678 [04:29:57] (03PS2) 10Pastakhov: refactor and extend usability (v 3.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/163544 [04:30:03] (03CR) 10jenkins-bot: [V: 04-1] refactor and extend usability (v 3.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/163544 (owner: 10Pastakhov) [04:31:10] (03PS1) 10PleaseStand: LqtView::simplePageMove(): Throw a ThrottledError directly [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/163546 [04:33:46] (03PS3) 10Pastakhov: refactor and extend usability (v 3.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/163544 [04:45:29] 3Wikimedia / 3Mailing lists: Adminship of Hindi Wikipedia Mailing List - 10https://bugzilla.wikimedia.org/71388#c8 (10Muzammil) (In reply to Andre Klapper from comment #7) > [No need to full-quote my entire previous comment :) -Andre Klapper ] > So have there been any signs/indication of "malicious activity... [04:46:57] (03CR) 10Pastakhov: [C: 04-2] "not ready yet" [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/163544 (owner: 10Pastakhov) [04:52:35] (03PS2) 10Cscott: Remove blocking (sync) operations in backend. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163524 [04:52:37] (03PS3) 10Cscott: Factor out a method to fork a subprocess and handle messages from the child. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163525 [04:52:39] (03PS3) 10Cscott: Write output files in subdirectories. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163526 [04:52:41] (03PS4) 10Cscott: Unify configuration file parsing. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163527 [04:52:43] (03PS2) 10Cscott: Improve the gc `cleanDir` function to handle nested directories. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163523 [04:52:45] (03CR) 10jenkins-bot: [V: 04-1] Factor out a method to fork a subprocess and handle messages from the child. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163525 (owner: 10Cscott) [05:03:48] (03CR) 10Cscott: "recheck" [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163525 (owner: 10Cscott) [05:48:31] 3Wikimedia / 3Mailing lists: Adminship of Hindi Wikipedia Mailing List - 10https://bugzilla.wikimedia.org/71388#c9 (10James Alexander) (In reply to Muzammil from comment #8) > (In reply to Andre Klapper from comment #7) > > [No need to full-quote my entire previous comment :) -Andre Klapper ] > > > So have... [05:51:57] TimStarling: I don't see what's strange about it [05:52:12] There's a serious risk of making captchas which discourage good faith contributions more than spambots [05:52:41] So it's crucial to know which captcha features actually work and which only damage us [05:53:12] (03CR) 10Florianschmidtwelzow: [C: 031] "Lua-Modules without functionallity doesn't make sense. Code, we accept, should be at least "syntax error"-free :)" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/160367 (owner: 10Jackmcbarn) [05:53:35] We've known for years that fancycaptcha is totally useless, but its damage is limited by the ample skipcaptcha permissions... except on pt.wiki, which was severely (and probably irreversibly) damaged [05:54:42] yes, I agree with all that [05:55:30] I'm just making a semantic point, i.e. whether discouraging spammers deserves to be called security [05:55:47] since it is not very secure, by normal standards of security [05:56:41] (03CR) 10Nemo bis: Add language override and extra link support for dumpInterwiki (031 comment) [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/94593 (https://bugzilla.wikimedia.org/56207) (owner: 10TTO) [05:57:00] TimStarling: well, I just quoted [05:57:21] for example, SimpleAntiSpam discourages bots without affecting user experience at all [05:57:30] you wouldn't call it secure though, would you? [05:57:52] yes; there is a patch for an alternative in the SimpleAntiSpam repo FYI [05:58:08] I don't know, from the users' perspective it's secure [05:58:24] Like not having a cop in your street is secure for less chances of being shot, especially if you're black [05:59:49] I mostly worry that an association with security tends to give you the wrong answer to the question [06:00:16] yes, we want to know how to discourage spammers without affecting regular users [06:00:21] you ask: what about increasing the hash length? [06:00:51] well, the hash length could be 8 bits and it would have about the same amount of security [06:01:19] I just asked if that comment was still current and Chris said yes [06:01:43] I don't know if security is a wrong or bad word to use, it's merely what people working in this area used [06:01:50] discussions about hash lengths are fine if you are talking about SSL or .deb package signing or something [06:01:57] But I think it may make sense, if we remember what we're actually trying to secure [06:02:05] Sure [06:03:10] What we're trying to secure are editors, edits and pages. Spambots "steal" from us even by just existing as a threat, because of how we react to them [06:03:57] I think heuristic defenses are probably best [06:04:03] So if I raise a protection wall from an invader which only shoots inside my house I'd call that insecure [06:04:58] you know I once found two bugs in the spambot software XRumer which were exploitable for edit rejection [06:05:14] Yes, akismet seems to prove it; but improving captcha is possible, for instance while reCAPTCHA is broken it seems the Google captcha is still resisting [06:05:28] Funny, I didn't know :) [06:05:53] Part of the problem is that we have no idea of what our attackers are (or at least our countervandalism users don't) [06:06:01] one was deployed as part of AntiBot, the other held in reserve [06:06:17] but people stopped caring and it turned out to be too much trouble to deploy private code [06:06:33] I didn't want to publish the code because the XRumer devs are able to google themselves [06:06:38] they're not idiots [06:07:51] I don't know if WMF even has an archive of that code now, it may have been lost, apart from on my hard drive [06:09:44] part of our defenses only work because spambots are not targeting us specifically [06:10:11] This works well for 95 % of MediaWiki wikis, where QuestyCaptcha is perfect [06:10:42] there was a time when brion and I used to be heavily involved in spam defence [06:10:55] So, on the word "security"... I made some tests at https://gerrit.wikimedia.org/r/#/c/121255/ for multilingual captcha [06:11:00] now, I guess nobody at WMF is really interested [06:11:17] one is enough, if it's TimStarling :p [06:11:43] owww [06:11:47] It's almost certain that using chinese or russian characters is not harder to break, but if it's easier to resolve for humans editing those wikis I'd call it more secure [06:13:01] I see you rebased it on top of my work [06:13:52] yes, unrelated areas [06:14:10] Private rules for spam protection, à la akismet, could fall in the SaaS, aka Service as a Software Substitute like FSF calls it [06:14:35] I thought chinese captcha's didn't exist, but apparently there's at least one implementation. [06:15:03] I mean, they're not really covered by the "let's only use free software" rule, so for specific cases one could get a sort of exception there [06:15:55] If it's just a trick to add a line of private code for one spambot it's not worth it, but if one is already making a system like a central https://www.mediawiki.org/wiki/Extension:BayesianFilter maybe yes [06:16:02] (03PS2) 10Santhosh: mediawiki.jqueryMsg: Support arbitrary expressions in plural forms [core] - 10https://gerrit.wikimedia.org/r/163460 (https://bugzilla.wikimedia.org/70617) [06:19:07] I considered making the captcha language user-selectable, that would be user-friendly [06:19:55] I hadn't considered making it monolingual in Chinese, that could potentially be a hassle [06:25:16] (03PS3) 10Santhosh: mediawiki.jqueryMsg: Support arbitrary expressions in plural forms [core] - 10https://gerrit.wikimedia.org/r/163460 (https://bugzilla.wikimedia.org/70617) [06:25:18] Chinese is not the best example perhaps, I doubt we even have a usable font for the purpose [06:26:04] Some indic wikis have abusefilters which disallow you from editing if you use words in the wrong variant/ortography/dialect, so they'd probably be happy :p [06:26:16] tesseract has training files for chinese [06:26:47] 3Wikimedia / 3Mailing lists: Adminship of Hindi Wikipedia Mailing List - 10https://bugzilla.wikimedia.org/71388#c10 (10jeremyb) (In reply to p858snake from comment #1) > Just because the user isn't active on wiki, doesn't mean they aren't > checking their emails :). In addition to discussing on list or a di... [06:27:05] and russian and finish [06:27:19] of course you did say already that it wouldn't be harder to break [06:29:35] but here is the list of tesseract languages, if you are interested: https://code.google.com/p/tesseract-ocr/downloads/list [06:33:22] (03PS4) 10Santhosh: mediawiki.jqueryMsg: Support arbitrary expressions in plural forms [core] - 10https://gerrit.wikimedia.org/r/163460 (https://bugzilla.wikimedia.org/70617) [06:34:31] 3MediaWiki / 3Internationalization: Displays another file instead of a link to "the existing file". - 10https://bugzilla.wikimedia.org/70617#c6 (10Santhosh Thottingal) 5NEW>3PATC a:3Santhosh Thottingal Patch: https://gerrit.wikimedia.org/r/#/c/163460/ [06:43:29] Nemo_bis: where did you get that blacklist from? it is pretty funny [06:44:35] +Great Firewall of China [06:44:50] TimStarling: it's from en.wiktionary [06:44:52] +G@Shoulder-PalmDown G@Abdomen-PalmDown [06:45:10] +hello yourself, and see how you like it [06:45:21] Wiktionary is weird, yes [06:46:08] My idea is that instead of the regular blamewheel mailing list thread on "why was the word X not blacklisted" we could just point people to edit [06:46:38] +take a long walk on a short pier [06:46:51] that's actually a sad thing to do [06:47:43] I didn't code that extraction, Amgine did: https://www.mediawiki.org/wiki/User:Amgine/Dump_processing/test_xml.php [06:47:52] +cdesign proponentsist [06:47:59] I had to look that one up [06:48:05] :D [06:48:57] I see, it must include [[Category:English pejoratives]] [06:49:46] (vulgar(?:ity?)\b|obscen(?:e|ity)|offensive|pejorative|medicine|slang) [06:53:31] (03CR) 10Nemo bis: Make captcha.py produce images in arbitrary language (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (https://bugzilla.wikimedia.org/5309) (owner: 10Nemo bis) [06:53:47] (03CR) 10Tim Starling: "The old regex had the effect of filtering proper nouns, which will now be included. I don't think that is desirable. Also, I think the bla" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (https://bugzilla.wikimedia.org/5309) (owner: 10Nemo bis) [06:54:07] (03PS14) 10Nemo bis: Make captcha.py produce images in arbitrary language [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (https://bugzilla.wikimedia.org/5309) [06:56:34] (03CR) 10Nemo bis: "Frankly I don't remember, but I think I had left proper nouns because in some languages they are the vast majority of words en.wiktionary " [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (https://bugzilla.wikimedia.org/5309) (owner: 10Nemo bis) [06:58:45] 3Wikimedia / 3Mailing lists: New Mailinglist for Volunteers-Support - 10https://bugzilla.wikimedia.org/69599#c3 (10Muriel Staub) Hi Andre, may I ask what's the status on the mailinglist? We would very much like to use it as soon as possible. Thanks for your help and my best wishes, Muriel [07:04:00] 3Wikimedia / 3Mailing lists: New Mailinglist for Volunteers-Support - 10https://bugzilla.wikimedia.org/69599#c4 (10Andre Klapper) 5UNCO>3NEW James: ping? (Nothing I can set up myself, sorry.) [07:04:00] (03CR) 10Nikerabbit: [C: 032] LqtView::simplePageMove(): Throw a ThrottledError directly [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/163546 (owner: 10PleaseStand) [07:04:15] (03Merged) 10jenkins-bot: LqtView::simplePageMove(): Throw a ThrottledError directly [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/163546 (owner: 10PleaseStand) [07:04:47] (03CR) 10Nikerabbit: "Please add documentation for this behavior includnig the version it was introduced." [core] - 10https://gerrit.wikimedia.org/r/163528 (owner: 10Awight) [07:08:06] would you please merge https://gerrit.wikimedia.org/r/#/c/163356/ [07:08:14] (03CR) 10TTO: Add language override and extra link support for dumpInterwiki (031 comment) [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/94593 (https://bugzilla.wikimedia.org/56207) (owner: 10TTO) [07:08:16] we want to open Persian Wikivoyage on truism week! [07:10:36] "truism week" made me think it was a week where every captcha solution is true [07:11:09] :) [07:11:48] (03CR) 10Raimond Spekking: [C: 032] Set rup/roa-rup autonym to "armãneashti" [core] - 10https://gerrit.wikimedia.org/r/157349 (https://bugzilla.wikimedia.org/69477) (owner: 10Nemo bis) [07:18:21] (03Merged) 10jenkins-bot: Set rup/roa-rup autonym to "armãneashti" [core] - 10https://gerrit.wikimedia.org/r/157349 (https://bugzilla.wikimedia.org/69477) (owner: 10Nemo bis) [07:25:47] 3MediaWiki / 3Internationalization: Bad language name for 'rup' (Aromanian) - 10https://bugzilla.wikimedia.org/69477 (10Nemo) 5PATC>3RESO/FIX a:3Nemo [07:27:55] 3MediaWiki extensions / 3General/Unknown: bad link address - 10https://bugzilla.wikimedia.org/71393#c2 (10Andre Klapper) Hi po2evans, if the address is "non-existant", what is the exact error that makes you think it is "non-existant"? Also see https://www.mediawiki.org/wiki/How_to_report_a_bug [07:42:01] 3Wikimedia / 3Mailing lists: New Mailinglist for Volunteers-Support - 10https://bugzilla.wikimedia.org/69599#c5 (10James Alexander) hmm, honestly I don't like the name. volunteersupport@ sounds very much like you are using the list itself to give volunteer support (as in 'if you need help email here!') and n... [07:45:45] reza1615_: you mean "tourism"? [07:45:59] :) yes [07:50:04] k :) [07:53:44] reza1615_: shabahey(sp?) [07:58:32] jeremyb: I didn't understand :( [07:58:48] was supposed to be good night :) [07:59:01] but i've only said it, not written it [07:59:47] hmm shab bekhair شب بخیر [07:59:53] :) [08:00:17] here is morning :) [08:00:21] errrr, yeah [08:00:22] right! [08:01:07] oh, you just had a time change [08:01:26] $ zdump -v Asia/Tehran | fgrep 2014 | fgrep Sep [08:01:26] Asia/Tehran Sun Sep 21 19:29:59 2014 UTC = Sun Sep 21 23:59:59 2014 IRDT isdst=1 gmtoff=16200 [08:01:26] Asia/Tehran Sun Sep 21 19:30:00 2014 UTC = Sun Sep 21 23:00:00 2014 IRST isdst=0 gmtoff=12600 [08:02:10] so, was +0430, now +0330 [08:02:23] Iran now is 11:23 AM [08:02:35] [08:02:23] Iran now is 11:23 AM [08:02:54] right, 8:02:23 +0330 == 11:32:23 [08:03:08] so, 9 mins off? [08:04:04] it was typo 11:34 [08:04:10] right [08:04:47] anyway, nacht [08:05:13] jeremyb: do you have access for merging? [08:05:40] https://gerrit.wikimedia.org/r/#/c/163356/ [08:09:11] (03PS1) 10IAlex: Add "returntoquery" URL parameter support in Special:ChangeEmail [core] - 10https://gerrit.wikimedia.org/r/163552 [08:17:30] 3Wikimedia / 3Site requests: 300GB of files on a hard disk in need of a URI or WMF direct upload - 10https://bugzilla.wikimedia.org/67477#c25 (10Fæ) I believe the disk with the first tranche of 50,000 images has been sitting with Sam for a fortnight. Any update? The Wellcome are keen to get on with this proj... [08:24:01] 3MediaWiki / 3General/Unknown: EditPage member variable visibility changes broke compatibility for extensions - 10https://bugzilla.wikimedia.org/67984 (10s7eph4n) [08:24:02] 3MediaWiki extensions / 3DumpHTML: dumpHTML encounters fatal error: Cannot access protected property LocalRepo::$thumbScriptUrl - 10https://bugzilla.wikimedia.org/69824 (10s7eph4n) [08:26:30] 3MediaWiki / 3General/Unknown: Member variable visibility changes broke compatibility for extensions - 10https://bugzilla.wikimedia.org/67984 (10s7eph4n) [08:30:59] 3MediaWiki extensions / 3ConfirmAccount: Message strings from i18n files are no longer showing in Special:AllMessages with MW 1.23.3 - 10https://bugzilla.wikimedia.org/71300#c2 (10Neill Mitchell) Just to clarify, I have only noticed this issue with the ConfirmAccount extension. Thanks. [08:32:59] 3MediaWiki extensions / 3ParserFunctions: Unwanted line breaks in if statements - 10https://bugzilla.wikimedia.org/66027#c2 (10Neill Mitchell) Hi. That is the excellent Pipe Escape extension. https://www.mediawiki.org/wiki/Extension:Pipe_Escape However, the superfluous
occurs with the #if whether pipe... [08:39:20] (03Abandoned) 10Hashar: Convert read_wfMsgCalls.py to Git [tools/code-utils] - 10https://gerrit.wikimedia.org/r/118263 (https://bugzilla.wikimedia.org/43777) (owner: 10Seb35) [08:39:43] (03CR) 10Hashar: [C: 032] "As discussed, would be better done has a PHP CodeSniffer rule :)" [tools/code-utils] - 10https://gerrit.wikimedia.org/r/162205 (owner: 10Seb35) [08:39:46] (03Merged) 10jenkins-bot: Delete read_wfMsgCalls.py (obsolete) [tools/code-utils] - 10https://gerrit.wikimedia.org/r/162205 (owner: 10Seb35) [08:48:46] 3Wikimedia / 3Site requests: Disable local uploads where unused: some wikis with little or no local file work - 10https://bugzilla.wikimedia.org/71403 (10Nemo) 3NEW p:3Unprio s:3enhanc a:3None Created attachment 16620 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16620&action=edit Local uplo... [09:12:08] (03PS4) 10Matthias Mullie: [WIP] Display search results [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161947 [09:26:02] (03PS25) 10Matthias Mullie: [WIP] search [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126996 [09:26:11] (03PS5) 10Matthias Mullie: [WIP] Display search results [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161947 [09:49:22] 3Datasets / 3General/Unknown: Medium-sized image dump - 10https://bugzilla.wikimedia.org/71405 (10Régis Behmo) 3UNCO p:3Unprio s:3normal a:3Ariel T. Glenn Current image dumps include the full-resolution files; as such, it is very difficult to download a large (> 10⁶) number of images. E.g: the 2013-1... [09:54:36] aharoni: will it work if you rewrite all [[{{Language screenshot URL|name=VisualEditor_toolbar}}|frameless|center|800px|alt=Screenshot of the VisualEditor toolbar]] as something like {{Language screenshot image|VisualEditor_toolbar|frameless|center|800px|alt=Screenshot of the VisualEditor toolbar}} [09:54:56] maybe [09:55:28] It will need tight and consistent usage of image parameters. [09:55:41] And it may have Parser caveats of which I cannot think right now. [09:57:39] aharoni: I guess simply composing a [[File: ]] call with given params will work? [09:58:15] 3Datasets / 3General/Unknown: Medium-sized image dump - 10https://bugzilla.wikimedia.org/71405#c1 (10Antoine "hashar" Musso) I have met Régis in my coworking place. I believe a dump of 800px images thumbnails can probably be useful to a wide researching audience :) [10:00:37] liangent: You are welcome to try :) [10:00:47] I'm busy with something else atm [10:07:42] (03CR) 10Amire80: [C: 032] Stylize MungTitle.inc [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/157768 (owner: 10Reedy) [10:07:45] (03Merged) 10jenkins-bot: Stylize MungTitle.inc [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/157768 (owner: 10Reedy) [10:21:19] 3MediaWiki extensions / 3DumpHTML: dumpHTML encounters fatal error: Cannot access protected property LocalRepo::$thumbScriptUrl - 10https://bugzilla.wikimedia.org/69824#c1 (10Antoine "hashar" Musso) FileRepo properties have been changed to protected with by https://gerrit.wikimedia.org/r/97371 de6b4e7c whic... [10:24:30] 3MediaWiki extensions / 3DumpHTML: dumpHTML encounters fatal error: Cannot access protected property LocalRepo::$thumbScriptUrl - 10https://bugzilla.wikimedia.org/69824#c2 (10Daniel Friesen) (In reply to Antoine "hashar" Musso from comment #1) > FileRepo properties have been changed to protected with by > ht... [10:42:45] 3Wikimedia / 3Shop: Enable IPv6 on shop.wikimedia.org - 10https://bugzilla.wikimedia.org/71263#c4 (10jeremyb) (In reply to Daniel Zahn from comment #3) definitely in this case. (just rejected the RT) not sure about in general. added some shop people to CC so maybe they can find out. [10:44:16] (03PS26) 10Matthias Mullie: [WIP] search [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126996 [10:44:28] (03PS6) 10Matthias Mullie: [WIP] Display search results [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161947 [10:47:16] 3Wikimedia / 3Shop: Enable IPv6 on shop.wikimedia.org - 10https://bugzilla.wikimedia.org/71263#c5 (10jeremyb) a:3Victoria Shchepakina oops, missed vshchepakina was here already. [10:51:14] (03PS7) 10Matthias Mullie: [WIP] Display search results [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161947 [10:59:15] 3MediaWiki extensions / 3WikidataRepo: Store the badges of sitelinks in a queryable format - 10https://bugzilla.wikimedia.org/70229 (10Lydia Pintscher) p:5Low>3Normal [11:03:18] (03PS8) 10Matthias Mullie: [WIP] Display search results [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161947 [11:10:04] (03CR) 10Bartosz Dziewoński: Implement page status indicators (032 comments) [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [11:11:18] 3MediaWiki extensions / 3WikibaseDatabase: mul: interwiki now available for oldwikisource //wikisource.org - 10https://bugzilla.wikimedia.org/71406 (10billinghurst) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Following gerrit changes released in 1.24wmf22 there is now the capacity to have interwiki lin... [11:11:47] 3MediaWiki extensions / 3WikibaseDatabase: mul: interwiki now available for oldwikisource //wikisource.org -> Wikidata - 10https://bugzilla.wikimedia.org/71406 (10billinghurst) [11:11:47] 3Wikimedia / 3General/Unknown: Wikisource related bugs and enhancements (tracking) - 10https://bugzilla.wikimedia.org/35925 (10billinghurst) [11:13:29] (03PS11) 10Bartosz Dziewoński: Implement page status indicators [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) [11:14:55] (03PS12) 10Bartosz Dziewoński: Implement page status indicators [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) [11:17:06] (03Abandoned) 10Matthias Mullie: Replace both opening & closing script tag by flowprogressivescript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162580 (owner: 10Matthias Mullie) [11:17:40] (03PS2) 10Bartosz Dziewoński: Add support for page status indicators [skins/Vector] - 10https://gerrit.wikimedia.org/r/162610 (https://bugzilla.wikimedia.org/23796) [11:30:40] (03PS1) 10Bartosz Dziewoński: Add support for page status indicators [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/163558 (https://bugzilla.wikimedia.org/23796) [11:35:04] (03PS1) 10Bartosz Dziewoński: Add support for page status indicators [skins/Modern] - 10https://gerrit.wikimedia.org/r/163559 (https://bugzilla.wikimedia.org/23796) [11:37:53] (03PS1) 10Bartosz Dziewoński: Add support for page status indicators [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/163560 (https://bugzilla.wikimedia.org/23796) [11:38:16] 3MediaWiki extensions / 3WikidataRepo: Sitelinks to Incubator, OldWikisource and BetaWikiversity - 10https://bugzilla.wikimedia.org/52971#c11 (10billinghurst) mul for OldWikisource and BetaWikiversity both work now. I haven't checked incubator [11:48:05] (03CR) 10Matthias Mullie: [C: 032] Deprecate use of data-parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162820 (owner: 10EBernhardson) [11:48:43] (03Merged) 10jenkins-bot: Deprecate use of data-parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162820 (owner: 10EBernhardson) [11:48:46] 3MediaWiki extensions / 3WikidataRepo: Store the badges of sitelinks in a queryable format - 10https://bugzilla.wikimedia.org/70229#c2 (10Daniel Kinzler) I'm not sure I agree that we need such a table (but I can be convinced). In any case, the basic structure should be: ( badge, siteId, page ) with the... [11:50:00] 3MediaWiki / 3Page editing: Provide a way to set page meta-data flags ("featured article", "protected", etc.), configure which ones are available for a wiki, and display icons indicating these statuses - 10https://bugzilla.wikimedia.org/23796#c58 (10Bartosz Dziewoński) Patches: * MediaWiki: https://gerrit.... [11:51:31] 3MediaWiki extensions / 3EasyTimeline: easy timeline should render numbers in local numbers - 10https://bugzilla.wikimedia.org/71407 (10reza1615) 3NEW p:3Unprio s:3normal a:3None Now easy timeline renders the time line number in Latin. please set it to render them in local number http://fa.wikipedia.... [11:52:00] 3MediaWiki extensions / 3EasyTimeline: easy timeline should render numbers in local numbers - 10https://bugzilla.wikimedia.org/71407 (10reza1615) [11:56:45] (03CR) 10Matthias Mullie: [C: 04-1] "Some PHPDoc needs fixing" (035 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162888 (owner: 10EBernhardson) [11:57:16] (03PS4) 10Matthias Mullie: Hygiene: Only create DOMDocument once in ContentFixer [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162888 (owner: 10EBernhardson) [11:58:26] (03CR) 10Bartosz Dziewoński: Watchlist: changed "all" for the max number of days available (031 comment) [core] - 10https://gerrit.wikimedia.org/r/163142 (owner: 10Luis Felipe Schenone) [11:58:33] (03CR) 10Bartosz Dziewoński: [C: 031] Watchlist: changed "all" for the max number of days available [core] - 10https://gerrit.wikimedia.org/r/163142 (owner: 10Luis Felipe Schenone) [12:01:39] (03PS1) 10Bartosz Dziewoński: mediawiki.special.changeslist.legend: Match dt/dd line-height [core] - 10https://gerrit.wikimedia.org/r/163564 [12:02:47] 3MediaWiki / 3General/Unknown: PHP fatal error: Call to a member function getTitle() on a non-object in /includes/Feed.php:309 - 10https://bugzilla.wikimedia.org/70709#c12 (10taraathan@gmail.com) So far I haven't figured out what the page is that triggers this "Fatal error". The frequency pattern in the log... [12:04:00] 3Wikimedia / 3Extension setup: Activating File Upload Wizard in ta.wiki - 10https://bugzilla.wikimedia.org/63863#c5 (10Glaisher) Hello. English Wikipedia does not have [[mw:Extension:UploadWizard]] enabled currently. See [[Special:UploadWizard]]. They use javascript to create a custom form for uploading file... [12:04:19] 3Wikimedia / 3Extension setup: Activating File Upload Wizard in ta.wiki - 10https://bugzilla.wikimedia.org/63863 (10Glaisher) 5NEW>3UNCO [12:05:36] (03CR) 10Daniel Kinzler: [C: 031] "We definitely want that functionality. Didn't look closely at the implementation though." [core] - 10https://gerrit.wikimedia.org/r/163528 (owner: 10Awight) [12:19:46] 3MediaWiki extensions / 3EasyTimeline: EasyTimeline svg2png method has a clickable map with wrong coordinates. - 10https://bugzilla.wikimedia.org/53502#c2 (10reza1615) (In reply to Siebrand Mazeland from comment #1) > Removed i18n related CCs. still remaining the bug! [12:21:32] 3MediaWiki extensions / 3ConfirmEdit (CAPTCHA extension): ConfirmEdit do not let me create a page and keep asking the same question - 10https://bugzilla.wikimedia.org/71408 (10Helder) 3NEW p:3Unprio s:3normal a:3None 1. Go to http://wikipapers.referata.com/wiki/Form:Publication 2. Type "Testing" and... [12:21:47] 3MediaWiki extensions / 3ConfirmEdit (CAPTCHA extension): ConfirmEdit do not let me create a page and keep asking the same question - 10https://bugzilla.wikimedia.org/71408 (10Helder) [12:21:47] 3MediaWiki extensions / 3ConfirmEdit (CAPTCHA extension): ConfirmEdit prompting for CAPTCHA breaks saving of new page from Semantic Forms - 10https://bugzilla.wikimedia.org/46342 (10Helder) [12:32:48] 3MediaWiki extensions / 3DumpHTML: dumpHTML encounters fatal error: Cannot access protected property LocalRepo::$thumbScriptUrl - 10https://bugzilla.wikimedia.org/69824#c3 (10Antoine "hashar" Musso) So I guess whatever *Repo class is used should pass the option 'thumbScriptUrl' which defaults to $wgThumbnail... [12:33:53] (03CR) 10Matthias Mullie: [C: 032] Hygiene: Only create DOMDocument once in ContentFixer [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162888 (owner: 10EBernhardson) [12:34:30] (03Merged) 10jenkins-bot: Hygiene: Only create DOMDocument once in ContentFixer [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162888 (owner: 10EBernhardson) [12:48:31] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Thank you, this is actually the same approach I envisioned :) I spotted some little bugs, commented inline." (0310 comments) [core] - 10https://gerrit.wikimedia.org/r/163460 (https://bugzilla.wikimedia.org/70617) (owner: 10Santhosh) [12:52:38] (03CR) 10Bartosz Dziewoński: "By the way, you can cause some rather goofy behavior with messages like these:" [core] - 10https://gerrit.wikimedia.org/r/163460 (https://bugzilla.wikimedia.org/70617) (owner: 10Santhosh) [12:53:30] 3MediaWiki extensions / 3ConfirmEdit (CAPTCHA extension): ConfirmEdit do not let me create a page and keep asking the same question - 10https://bugzilla.wikimedia.org/71408#c1 (10Nemo) Skipcaptcha permission is assigned to groups: emailconfirmed, bot, sysop. http://wikipapers.referata.com/wiki/Special:SiteSe... [12:53:59] 3MediaWiki extensions / 3WikidataRepo: Store the badges of sitelinks in a queryable format - 10https://bugzilla.wikimedia.org/70229#c3 (10Aude) @daniel if we don't need such table, then how do you suggest we make badges / badge usage queryable? [13:01:13] (03CR) 10Matthias Mullie: [C: 032] Hygiene: Subdir ContentFixer implementations [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162889 (owner: 10EBernhardson) [13:03:01] (03CR) 10Matthias Mullie: [C: 032] Hygiene: ExtractorInterface -> Extractor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162890 (owner: 10EBernhardson) [13:06:44] anybody here who could do some mwgrepping for me? [13:16:30] 3MediaWiki extensions / 3WikidataRepo: Sitelinks to Incubator, OldWikisource and BetaWikiversity - 10https://bugzilla.wikimedia.org/52971#c12 (10MF-Warburg) Doesn't help much if you can only link to one page per wiki. [13:18:57] (03CR) 10Bartosz Dziewoński: "I just fixed all occurrences in the MediaWiki: namespace found by previous mwgreps linked/pasted here. Can anyone mwgrep for 'mw.user.name" [core] - 10https://gerrit.wikimedia.org/r/111422 (owner: 10Ori.livneh) [13:23:47] 3MediaWiki extensions / 3DumpHTML: dumpHTML encounters fatal error: Cannot access protected property LocalRepo::$thumbScriptUrl - 10https://bugzilla.wikimedia.org/69824#c4 (10s7eph4n) I know this will be regarded as a rhetoric question, still: Why not just revert the patch that introduced the bug? [13:32:45] 3MediaWiki / 3API: Add revid handling (revids=, drstartid= and drendid=) to list=deletedrevs - 10https://bugzilla.wikimedia.org/71396#c2 (10Brad Jorsch) s:5normal>3enhanc The reason for the "badrevids" is because deletedrevs is a bit of a strange module: it tries to combine the equivalent of both "list=a... [13:37:57] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [13:40:11] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161947 (owner: 10Matthias Mullie) [13:42:14] 3MediaWiki / 3API: action=query&list=deletedrevs with a new-style continuation fails - 10https://bugzilla.wikimedia.org/71389#c1 (10Brad Jorsch) The root cause here is that "list=deletedrevs" is pretending to be a "prop" module when it's actually not. The new-style continuation doesn't know it's pretending t... [13:42:31] 3MediaWiki / 3API: Add revid handling (revids=, drstartid= and drendid=) to list=deletedrevs - 10https://bugzilla.wikimedia.org/71396#c3 (10Brad Jorsch) (In reply to Brad Jorsch from comment #2) > I'm inclined to deprecate list=deletedrevs using the pageset at all, and > instead add all three of "drtitles",... [13:43:35] (03CR) 10Siebrand: "Raimond, can you easily remove $3 from all translations?" [core] - 10https://gerrit.wikimedia.org/r/163142 (owner: 10Luis Felipe Schenone) [13:44:58] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/XAnalytics] - 10https://gerrit.wikimedia.org/r/157841 (owner: 10Ori.livneh) [13:47:48] Nemo_bis, Nikerabbit are you aware about translate tags visible in many mediawiki.org pages i.e. https://www.mediawiki.org/wiki/Phabricator ? [13:48:12] qgil: many? [13:48:20] or all of them [13:48:33] (03CR) 10Siebrand: "i18n/L10n reviewed." (032 comments) [extensions/MobileDetect] - 10https://gerrit.wikimedia.org/r/163539 (owner: 10Luis Felipe Schenone) [13:48:34] dunno [13:49:18] doubt it, it's just using wrong syntax [13:50:13] Nemo_bis: probably from a template? [13:50:23] that could explain "many pages" [13:50:37] of course [13:51:53] (03CR) 10Siebrand: "i18n/L10n reviewed." (031 comment) [extensions/NewSignupPage] - 10https://gerrit.wikimedia.org/r/163466 (owner: 10Jack Phoenix) [13:52:38] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/138840 (https://bugzilla.wikimedia.org/65297) (owner: 10PleaseStand) [13:53:38] page fixed, translation admin warned [13:53:59] anomie: can you merge https://gerrit.wikimedia.org/r/#/c/160572/ and https://gerrit.wikimedia.org/r/#/c/160550/ now that aaron merged the core change that was holding them up? [13:54:12] (03PS1) 10Aude: Update Wikidata, fix hhvm issues [core] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/163569 [13:54:49] (03CR) 10Matthias Mullie: [C: 04-1] Hygiene: Remove duplication between ContentFixer implementations (0311 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162891 (owner: 10EBernhardson) [13:54:50] jackmcbarn: I'll have a look. Rebase them or ping me in the comments to remind me. [13:54:59] sooo, anybody wants to mwgrep? 'mw.user.name()' and 'mw.user.anonymous()' [13:55:07] (03PS3) 10Jackmcbarn: Improve compatibility with TemplateSandbox [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/160550 (https://bugzilla.wikimedia.org/70495) [13:55:57] MatmaRex: http://dpaste.com/2CP0VP4 [13:55:59] and [13:56:35] http://dpaste.com/12G0F67 [13:57:02] (03PS5) 10Matthias Mullie: Hygiene: Subdir ContentFixer implementations [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162889 (owner: 10EBernhardson) [13:57:03] 3MediaWiki / 3API: Add revid handling (revids=, drstartid= and drendid=) to list=deletedrevs - 10https://bugzilla.wikimedia.org/71396#c4 (10Brad Jorsch) I added this to the list at https://www.mediawiki.org/wiki/Requests_for_comment/API_roadmap#Fix_list.3Ddeletedrevs for some further discussion. [13:57:03] 3MediaWiki / 3API: action=query&list=deletedrevs with a new-style continuation fails - 10https://bugzilla.wikimedia.org/71389#c2 (10Brad Jorsch) I added this to the list at https://www.mediawiki.org/wiki/Requests_for_comment/API_roadmap#Fix_list.3Ddeletedrevs for some further discussion. [13:57:11] (03CR) 10Matthias Mullie: [C: 032] Hygiene: Subdir ContentFixer implementations [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162889 (owner: 10EBernhardson) [13:57:17] (03PS4) 10Matthias Mullie: Hygiene: ExtractorInterface -> Extractor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162890 (owner: 10EBernhardson) [13:57:56] aude: thanks! [13:57:58] (03Merged) 10jenkins-bot: Hygiene: Subdir ContentFixer implementations [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162889 (owner: 10EBernhardson) [13:58:02] sure [13:59:10] (03PS5) 10Matthias Mullie: Hygiene: Remove duplication between ContentFixer implementations [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162891 (owner: 10EBernhardson) [13:59:39] (03CR) 10Matthias Mullie: [C: 032] Hygiene: Remove duplication between ContentFixer implementations [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162891 (owner: 10EBernhardson) [13:59:52] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/120962 (https://bugzilla.wikimedia.org/51260) (owner: 10Alex Monk) [14:00:13] (03Merged) 10jenkins-bot: Hygiene: Remove duplication between ContentFixer implementations [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162891 (owner: 10EBernhardson) [14:01:00] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/160798 (https://bugzilla.wikimedia.org/30936) (owner: 10Anomie) [14:04:34] (03PS10) 10Jackmcbarn: Use current revision callback instead of template callback [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/160572 (https://bugzilla.wikimedia.org/70495) [14:04:57] (03CR) 10Bartosz Dziewoński: "Updated mwgrep, courtesy of Aude: http://dpaste.com/2CP0VP4 + http://dpaste.com/12G0F67 . Fixed these, too." [core] - 10https://gerrit.wikimedia.org/r/111422 (owner: 10Ori.livneh) [14:07:59] (03PS4) 10Manybubbles: Initial [search/extra] - 10https://gerrit.wikimedia.org/r/163268 [14:11:51] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/160610 (owner: 10Yurik) [14:13:14] (03CR) 10Gilles: [C: 031] fix spurious upload uis being created [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/163235 (owner: 10Neilk) [14:16:08] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/161093 (https://bugzilla.wikimedia.org/65403) (owner: 10Anomie) [14:18:49] (03CR) 10Siebrand: "i18n/L10n reviewed." (031 comment) [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/163224 (owner: 10Legoktm) [14:24:33] (03CR) 10Raimond Spekking: "@Siebrand: Should be easily doable" [core] - 10https://gerrit.wikimedia.org/r/163142 (owner: 10Luis Felipe Schenone) [14:25:12] (03CR) 10Siebrand: [C: 032] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/163142 (owner: 10Luis Felipe Schenone) [14:31:51] (03Merged) 10jenkins-bot: Watchlist: changed "all" for the max number of days available [core] - 10https://gerrit.wikimedia.org/r/163142 (owner: 10Luis Felipe Schenone) [14:34:32] 3MediaWiki / 3Watchlist: On watchlist page "days all" should be reworded to "| up to 90 days". - 10https://bugzilla.wikimedia.org/26022 (10Bartosz Dziewoński) 5PATC>3RESO/FIX a:3Luis Felipe Schenone [14:35:10] (03CR) 10Anomie: API: HTMLize and internationalize the help, add Special:ApiHelp (036 comments) [core] - 10https://gerrit.wikimedia.org/r/160798 (https://bugzilla.wikimedia.org/30936) (owner: 10Anomie) [14:35:31] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/163190 (owner: 10Brian Wolff) [14:41:22] (03CR) 10Anomie: API: Clean up and internationalize pretty-printed output (031 comment) [core] - 10https://gerrit.wikimedia.org/r/161093 (https://bugzilla.wikimedia.org/65403) (owner: 10Anomie) [14:45:04] (03CR) 10Manybubbles: [C: 031] "Would be nice to include the changeids of what this picks up. Not required though because I trust aude." [core] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/163569 (owner: 10Aude) [14:45:06] (03CR) 10Anomie: [C: 031] Don't clobber revision size of 0 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/163458 (owner: 10Jackmcbarn) [14:46:24] (03PS2) 10Jackmcbarn: Don't clobber revision size of 0 [core] - 10https://gerrit.wikimedia.org/r/163458 [14:47:19] (03PS2) 10Aude: Update Wikidata, fix hhvm issues [core] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/163569 [14:48:25] (03CR) 10Anomie: [C: 032] "Looks like the sanest behavior to me." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/163359 (https://bugzilla.wikimedia.org/71045) (owner: 10Jackmcbarn) [14:49:30] 3Wikimedia / 3General/Unknown: UploadWizard Freezes at Uploading Stage due to Firefogg (Firefox extension) - 10https://bugzilla.wikimedia.org/69374#c13 (10Mark Holmquist) We aren't sure why Firefogg stopped working, but it's not currently a priority. I'd say it's a valid bug that we need to deal with eventua... [14:50:16] (03Merged) 10jenkins-bot: Throw an exception if LuaSandboxFunction::call returns false [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/163359 (https://bugzilla.wikimedia.org/71045) (owner: 10Jackmcbarn) [14:50:51] (03CR) 10Anomie: [C: 032] Don't clobber revision size of 0 [core] - 10https://gerrit.wikimedia.org/r/163458 (owner: 10Jackmcbarn) [14:52:43] (03CR) 10Anomie: [C: 032] Improve compatibility with TemplateSandbox [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/160550 (https://bugzilla.wikimedia.org/70495) (owner: 10Jackmcbarn) [14:52:48] (03CR) 10Anomie: [C: 032] Use current revision callback instead of template callback [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/160572 (https://bugzilla.wikimedia.org/70495) (owner: 10Jackmcbarn) [14:53:47] 3MediaWiki extensions / 3ProofreadPage: Moving index should optionally re-align extant Page: s to new location. - 10https://bugzilla.wikimedia.org/71414 (10wiki) 3UNCO p:3Unprio s:3enhanc a:3None Recently at English Wikisource, I noted that some Index: pages had generic titles that were less clear th... [14:55:24] (03CR) 10Marcoil: Factor out a method to fork a subprocess and handle messages from the child. (031 comment) [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163525 (owner: 10Cscott) [14:55:47] (03PS1) 10Gilles: UploadWizard submodule update [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/163575 [14:57:02] (03CR) 10Subramanya Sastry: "looks reasonable. i can +2 .. couple minor comments (dont need fixing), but my qn. about force could reveal something i might be missing." (032 comments) [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163523 (owner: 10Cscott) [14:57:31] (03Merged) 10jenkins-bot: Don't clobber revision size of 0 [core] - 10https://gerrit.wikimedia.org/r/163458 (owner: 10Jackmcbarn) [14:57:33] (03Merged) 10jenkins-bot: Improve compatibility with TemplateSandbox [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/160550 (https://bugzilla.wikimedia.org/70495) (owner: 10Jackmcbarn) [14:57:38] (03Merged) 10jenkins-bot: Use current revision callback instead of template callback [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/160572 (https://bugzilla.wikimedia.org/70495) (owner: 10Jackmcbarn) [14:58:03] (03CR) 10Cscott: Factor out a method to fork a subprocess and handle messages from the child. (031 comment) [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163525 (owner: 10Cscott) [14:58:05] (03CR) 10Nikerabbit: Implement page status indicators (031 comment) [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [14:59:14] 3MediaWiki extensions / 3ProofreadPage: Moving index should optionally re-align extant Page: s to new location. - 10https://bugzilla.wikimedia.org/71414 (10Tpt) 5UNCO>3NEW p:5Unprio>3Normal [15:00:22] (03CR) 10Marcoil: [C: 031] Unify configuration file parsing. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163527 (owner: 10Cscott) [15:00:42] (03CR) 10Anomie: [C: 031] "Code looks sane. Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/138840 (https://bugzilla.wikimedia.org/65297) (owner: 10PleaseStand) [15:00:51] 3MediaWiki extensions / 3TemplateSandbox: TemplateSandbox doesn't handle things like #ifexist and Scribunto's getContent - 10https://bugzilla.wikimedia.org/70495 (10Jackmcbarn) 5PATC>3RESO/FIX a:3Jackmcbarn [15:02:36] (03CR) 10Cscott: Improve the gc `cleanDir` function to handle nested directories. (032 comments) [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163523 (owner: 10Cscott) [15:04:10] (03CR) 10Manybubbles: [C: 032] Update Wikidata, fix hhvm issues [core] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/163569 (owner: 10Aude) [15:05:28] (03CR) 10Anomie: Add language override and extra link support for dumpInterwiki (031 comment) [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/94593 (https://bugzilla.wikimedia.org/56207) (owner: 10TTO) [15:09:52] (03CR) 10Manybubbles: [C: 032] Update Wikidata, fix hhvm issues [core] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/163569 (owner: 10Aude) [15:10:13] (03CR) 10Subramanya Sastry: [C: 031] Remove blocking (sync) operations in backend. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163524 (owner: 10Cscott) [15:11:19] (03CR) 10Subramanya Sastry: [C: 031] Improve the gc `cleanDir` function to handle nested directories. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163523 (owner: 10Cscott) [15:11:50] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "In my opinion this patch is making the situation worse. This adds another place where users can hard-code individual CSS properties per-ar" (031 comment) [extensions/Cite] - 10https://gerrit.wikimedia.org/r/120962 (https://bugzilla.wikimedia.org/51260) (owner: 10Alex Monk) [15:12:31] (03Merged) 10jenkins-bot: Update Wikidata, fix hhvm issues [core] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/163569 (owner: 10Aude) [15:12:37] (03CR) 10Anomie: "On that topic, https://www.usenix.org/system/files/conference/woot14/woot14-bursztein.pdf" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/162858 (owner: 10Tim Starling) [15:16:26] (03CR) 10Anomie: "Abandon in favor of I7185e186d?" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/163334 (https://bugzilla.wikimedia.org/71045) (owner: 10Ori.livneh) [15:17:29] (03CR) 10Manybubbles: [C: 032] UploadWizard submodule update [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/163575 (owner: 10Gilles) [15:20:25] (03CR) 10Hashar: [C: 04-1] "I more than welcome this change. I tested it and that works fine to me using the PHPUnit version we have in integration/phpunit.git" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/163528 (owner: 10Awight) [15:21:01] (03Merged) 10jenkins-bot: UploadWizard submodule update [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/163575 (owner: 10Gilles) [15:23:14] (03CR) 10Manybubbles: "Normally best to reference the changeid of what you updated. Its cool as is though." [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/163575 (owner: 10Gilles) [15:23:33] (03CR) 10Anomie: [C: 031] "I say feel free to ignore the nitpick, it's just maintaining the old behavior." [core] - 10https://gerrit.wikimedia.org/r/149621 (https://bugzilla.wikimedia.org/16793) (owner: 10TTO) [15:24:03] (03CR) 10Subramanya Sastry: [C: 031] "Looks a good cleanup, but I haven't carefully reviewed that the refactored calls do the same thing as what existed before." [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163525 (owner: 10Cscott) [15:27:01] (03CR) 10Cscott: [C: 032] Treat 'zh' as if it were 'zh-Hans' (that is, use Simplified Chinese). [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/163332 (owner: 10Cscott) [15:29:30] (03Merged) 10jenkins-bot: Treat 'zh' as if it were 'zh-Hans' (that is, use Simplified Chinese). [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/163332 (owner: 10Cscott) [15:30:32] 3MediaWiki extensions / 3WikidataRepo: Exception from line 43 of AliasSerializer.php: AliasSerializer can only serialize an array of aliases - 10https://bugzilla.wikimedia.org/70753#c4 (10Aude) kitten is broken again :( Unexpected non-MediaWiki exception encountered, of type "UnexpectedValueException" [b988... [15:41:08] (03CR) 10Nischayn22: [C: 032 V: 032] "Will revert if didn't work :P" [extensions/RecentActivityFeed] - 10https://gerrit.wikimedia.org/r/162964 (owner: 10Nischayn22) [15:42:00] 3MediaWiki extensions / 3RecentActivityFeed: change "inspect diff" to "show diff" - 10https://bugzilla.wikimedia.org/70732 (10Nischay Nahata) 5PATC>3RESO/FIX [15:54:14] (03PS6) 10Jackmcbarn: Use preview content when it transcludes itself [core] - 10https://gerrit.wikimedia.org/r/137153 (https://bugzilla.wikimedia.org/5278) [15:54:18] (03PS1) 10Matthias Mullie: Instead of flat out failing, fall back to piecemeal loading [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163589 [15:54:26] (03PS7) 10Jackmcbarn: Use preview content when it transcludes itself [core] - 10https://gerrit.wikimedia.org/r/137153 (https://bugzilla.wikimedia.org/5278) [15:54:46] (03CR) 10Jackmcbarn: Use preview content when it transcludes itself [core] - 10https://gerrit.wikimedia.org/r/137153 (https://bugzilla.wikimedia.org/5278) (owner: 10Jackmcbarn) [16:00:00] 3Wikimedia / 3Extension setup: Enable extension Collection on svwikiversity - 10https://bugzilla.wikimedia.org/64994#c3 (10Glaisher) 5PATC>3RESO/FIX https://sv.wikiversity.org/wiki/Special:Bok working [16:00:15] (03PS1) 10Cscott: Redis key expiration lifetimes should be in seconds, not milliseconds. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163590 [16:05:47] 3Wikimedia / 3Extension setup: Enable Collection by default on most sites - 10https://bugzilla.wikimedia.org/71416 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3enhanc a:3None It seems somewhat silly that Collection is default off, and then is opt in. zh is known to be buggy with the PediaPress backend (at... [16:07:05] (03CR) 10Subramanya Sastry: [C: 032] Redis key expiration lifetimes should be in seconds, not milliseconds. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163590 (owner: 10Cscott) [16:09:29] 3Wikimedia / 3Extension setup: Enable Collection by default on most sites - 10https://bugzilla.wikimedia.org/71416#c1 (10Nemo) (In reply to Sam Reed (reedy) from comment #0) > It seems somewhat silly that Collection is default off, and then is opt in. > zh is known to be buggy with the PediaPress backend (at... [16:10:29] Nemo_bis: If it's completely unuseable, it seems worth considering disabling it [16:10:41] But certainly, we shouldn't disable it for a reason of "people will report bugs" [16:15:24] Reedy: it's never "completely unusable", because non-PDF formats work [16:15:43] or are those broken too in zh [16:15:53] I've honestly no idea [16:16:16] Hence asking these questions :) [16:19:14] (03PS1) 10Cscott: Ensure postmortem moves complete before cleanup. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163592 [16:19:31] (03PS1) 10Nischayn22: Log entries in RecentActivityFeed have formatting problem [extensions/RecentActivityFeed] - 10https://gerrit.wikimedia.org/r/163593 [16:21:12] (03CR) 10Nischayn22: [C: 032 V: 032] "Can't go wrong here (I think)" [extensions/RecentActivityFeed] - 10https://gerrit.wikimedia.org/r/163593 (owner: 10Nischayn22) [16:21:44] 3MediaWiki extensions / 3RecentActivityFeed: Log entries in RecentActivityFeed have formatting problem - 10https://bugzilla.wikimedia.org/70730#c1 (10Nischay Nahata) 5NEW>3RESO/FIX https://gerrit.wikimedia.org/r/#/c/163593/ [16:23:08] (03CR) 10Ottomata: "Ori, could we use this to log the mediawiki page_id for requests?" [extensions/XAnalytics] - 10https://gerrit.wikimedia.org/r/157841 (owner: 10Ori.livneh) [16:23:43] (03CR) 10Ori.livneh: "@Ottomata: Sure, yeah." [extensions/XAnalytics] - 10https://gerrit.wikimedia.org/r/157841 (owner: 10Ori.livneh) [16:24:46] (03PS1) 10MarkTraceur: Update MultimediaViewer submodule [core] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/163594 [16:25:00] 3MediaWiki / 3API: ApiQueryAllUsers-related queries causing lag on Wikidata - 10https://bugzilla.wikimedia.org/52979#c10 (10Brad Jorsch) 5PATC>3RESO/WOR Let's WORKSFORME this one and chalk it up to a bad query plan per comment 4. People can reopen if it's still a problem. [16:31:50] (03PS4) 10Cscott: Factor out a method to fork a subprocess and handle messages from the child. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163525 [16:31:52] (03PS4) 10Cscott: Write output files in subdirectories. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163526 [16:31:54] (03PS2) 10Cscott: Ensure postmortem moves complete before cleanup. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163592 [16:31:56] (03PS5) 10Cscott: Unify configuration file parsing. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163527 [16:31:58] (03PS2) 10Cscott: Redis key expiration lifetimes should be in seconds, not milliseconds. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163590 [16:36:08] (03PS1) 10Anomie: API: Rewrite queries for list=allusers [core] - 10https://gerrit.wikimedia.org/r/163596 (https://bugzilla.wikimedia.org/70496) [16:36:16] (03CR) 10Anomie: "Try again in Ic87dbc3b2d933775ca71a72932e0658e2f082bb6" [core] - 10https://gerrit.wikimedia.org/r/158889 (https://bugzilla.wikimedia.org/70496) (owner: 10Anomie) [16:37:36] I wish MediaWiki provided a diff for the first revision of a page (as in, the diff between nothing and the initial text) [16:37:56] Why? [16:38:03] I think you can "make" it by playing with urls [16:41:34] yep [16:45:23] Reedy: the current reason is because of some js that uses the diff links to let people pull up the revision diff without leaving the page: http://education.wmflabs.org/w/index.php?title=Education_Program:WikiWorks/MediaWiki_Extension_Design_%28Fall_2014%29&days=30&from=&action=epcourseactivity [16:46:05] but in general, on Special:Contribs and such, it's a confusing interface that you can click "diff" to see any change except the first one. [16:47:28] (03PS1) 10Umherirrender: Register missing messages for mediawiki.special.upload [core] - 10https://gerrit.wikimedia.org/r/163599 [16:47:49] (03CR) 10Anomie: [C: 032] "As for this patch, let's do it." [core] - 10https://gerrit.wikimedia.org/r/162241 (owner: 10Gergő Tisza) [16:48:53] (03CR) 10Umherirrender: Add window close warning to Special:Upload (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151140 (owner: 10MarkTraceur) [16:49:23] (03CR) 10Arlolra: [C: 032] Unify configuration file parsing. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163527 (owner: 10Cscott) [16:51:41] (03PS2) 10Anomie: Allow for dynamically-loaded PHP libraries [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/163211 [16:52:39] (03CR) 10Umherirrender: "Maybe the confirm close code in mediawiki.special.preferences (Idb00f50ad8148cd80bd0af81b4cd06a0eb217d96) can also be migrated to this new" [core] - 10https://gerrit.wikimedia.org/r/151128 (owner: 10MarkTraceur) [16:53:19] (03CR) 10Arlolra: [C: 032] Ensure postmortem moves complete before cleanup. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163592 (owner: 10Cscott) [16:53:28] (03CR) 10Anomie: [C: 04-1] "We're in 1.25 now." [core] - 10https://gerrit.wikimedia.org/r/161471 (owner: 10Gergő Tisza) [16:54:51] (03Merged) 10jenkins-bot: Move addTrackingCategory from Parser to ParserOutput [core] - 10https://gerrit.wikimedia.org/r/162241 (owner: 10Gergő Tisza) [16:55:14] (03CR) 10Arlolra: [C: 032] Write output files in subdirectories. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163526 (owner: 10Cscott) [16:56:27] (03PS1) 10Cscott: Match language codes case-insensitively. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/163601 [16:59:42] legoktm: I am still getting this though - https://bugzilla.wikimedia.org/71325 - Will it just get fixed after a while [17:01:14] (03CR) 10Arlolra: [C: 032] Match language codes case-insensitively. (032 comments) [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/163601 (owner: 10Cscott) [17:02:18] (03Merged) 10jenkins-bot: Match language codes case-insensitively. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/163601 (owner: 10Cscott) [17:02:20] (03CR) 10Arlolra: [C: 032] Factor out a method to fork a subprocess and handle messages from the child. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163525 (owner: 10Cscott) [17:02:26] 3Wikimedia / 3Site requests: Please re-enable file upload function at noboard-chapters.wm.o - 10https://bugzilla.wikimedia.org/71367#c6 (10Glaisher) As noboard-chapters is a private wiki and as I do not have access there, I can't tell whether the page has been created. Can you do the following? 1. While log... [17:06:23] (03PS1) 10Cmcmahon: QA: WIP get rid of sleep [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163606 [17:20:36] (03CR) 10Arlolra: [C: 032] Improve the gc `cleanDir` function to handle nested directories. (032 comments) [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163523 (owner: 10Cscott) [17:20:48] (03Merged) 10jenkins-bot: Improve the gc `cleanDir` function to handle nested directories. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163523 (owner: 10Cscott) [17:20:50] (03Merged) 10jenkins-bot: Remove blocking (sync) operations in backend. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163524 (owner: 10Cscott) [17:22:06] (03PS2) 10Awight: Extensions can add tests by directory [core] - 10https://gerrit.wikimedia.org/r/163528 [17:22:31] (03PS1) 10Cscott: Adjust the nesting inside `cleanDir` for greater clarity. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163612 [17:23:32] (03CR) 10Arlolra: [C: 032] Adjust the nesting inside `cleanDir` for greater clarity. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163612 (owner: 10Cscott) [17:23:46] (03Merged) 10jenkins-bot: Factor out a method to fork a subprocess and handle messages from the child. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163525 (owner: 10Cscott) [17:23:48] (03Merged) 10jenkins-bot: Write output files in subdirectories. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163526 (owner: 10Cscott) [17:23:50] (03Merged) 10jenkins-bot: Unify configuration file parsing. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163527 (owner: 10Cscott) [17:23:52] (03Merged) 10jenkins-bot: Redis key expiration lifetimes should be in seconds, not milliseconds. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163590 (owner: 10Cscott) [17:23:54] (03Merged) 10jenkins-bot: Ensure postmortem moves complete before cleanup. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163592 (owner: 10Cscott) [17:24:51] (03PS1) 10Umherirrender: Replace wfMsgReplaceArgs by RawMessage [core] - 10https://gerrit.wikimedia.org/r/163613 [17:26:16] (03PS4) 10Prtksxna: Special:Contributions: Use mediawiki.ui [core] - 10https://gerrit.wikimedia.org/r/162121 (https://bugzilla.wikimedia.org/71137) [17:26:53] (03CR) 10Prtksxna: Special:Contributions: Use mediawiki.ui (032 comments) [core] - 10https://gerrit.wikimedia.org/r/162121 (https://bugzilla.wikimedia.org/71137) (owner: 10Prtksxna) [17:27:18] (03CR) 10Prtksxna: [C: 04-1] "The tag filter label still shifts to the right" [core] - 10https://gerrit.wikimedia.org/r/162121 (https://bugzilla.wikimedia.org/71137) (owner: 10Prtksxna) [17:29:02] Nemo_bis, re: "page fixed, translation admin warned" Thank you! [17:29:40] (03CR) 10Arlolra: Adjust the nesting inside `cleanDir` for greater clarity. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163612 (owner: 10Cscott) [17:29:47] (03CR) 10Arlolra: [C: 032] Adjust the nesting inside `cleanDir` for greater clarity. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163612 (owner: 10Cscott) [17:29:58] (03Merged) 10jenkins-bot: Adjust the nesting inside `cleanDir` for greater clarity. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163612 (owner: 10Cscott) [17:32:55] :) [17:33:04] (03CR) 10Parent5446: [C: 032] Replace wfMsgReplaceArgs by RawMessage [core] - 10https://gerrit.wikimedia.org/r/163613 (owner: 10Umherirrender) [17:33:45] (03PS2) 10Umherirrender: Article: Handle double redirects in data for mediawiki.action.view.redirect [core] - 10https://gerrit.wikimedia.org/r/163465 (https://bugzilla.wikimedia.org/71002) (owner: 10Bartosz Dziewoński) [17:35:21] (03CR) 10Umherirrender: [C: 032] "The problem that the rdfrom hint is missing when refresh the page is not a problem of this patch set and is also visible on non redirects." [core] - 10https://gerrit.wikimedia.org/r/163465 (https://bugzilla.wikimedia.org/71002) (owner: 10Bartosz Dziewoński) [17:35:23] (03CR) 10SG: [C: 032] Fix Feature name and requirement [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161417 (owner: 10Spage) [17:36:10] (03PS1) 10Cscott: Updating to latest masters [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/163617 [17:36:17] 3MediaWiki / 3General/Unknown: Text displayed out of bounds in browser - 10https://bugzilla.wikimedia.org/71420 (10Tony Thomas) 3NEW p:3Unprio s:3normal a:3None Created attachment 16624 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16624&action=edit The text getting out of bounds Consider h... [17:38:01] (03CR) 10Cscott: [C: 032 V: 032] Updating to latest masters [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/163617 (owner: 10Cscott) [17:39:16] (03PS1) 10Cscott: Merge branch 'master' into wmf-deploy [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/163618 [17:39:18] 3MediaWiki / 3User login and signup: Fatal error: Argument 2 passed to hash_pbkdf2() must be an instance of string, null given - 10https://bugzilla.wikimedia.org/71421 (10Ori Livneh) 3NEW p:3Unprio s:3normal a:3None Fatal error: Argument 2 passed to hash_pbkdf2() must be an instance of string, null g... [17:39:41] (03Merged) 10jenkins-bot: Replace wfMsgReplaceArgs by RawMessage [core] - 10https://gerrit.wikimedia.org/r/163613 (owner: 10Umherirrender) [17:40:19] (03PS2) 10Cmcmahon: QA: WIP get rid of sleep [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163606 [17:40:23] (03CR) 10Cscott: [C: 032 V: 032] Merge branch 'master' into wmf-deploy [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/163618 (owner: 10Cscott) [17:41:43] (03CR) 10Anomie: "-1, if Parent5446 hadn't merged too quickly." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/163613 (owner: 10Umherirrender) [17:41:58] (03PS1) 10Anomie: Revert "Replace wfMsgReplaceArgs by RawMessage" [core] - 10https://gerrit.wikimedia.org/r/163619 [17:42:00] (03Merged) 10jenkins-bot: Article: Handle double redirects in data for mediawiki.action.view.redirect [core] - 10https://gerrit.wikimedia.org/r/163465 (https://bugzilla.wikimedia.org/71002) (owner: 10Bartosz Dziewoński) [17:42:03] (03Merged) 10jenkins-bot: Fix Feature name and requirement [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161417 (owner: 10Spage) [17:42:13] (03CR) 10Anomie: [C: 032] "Reverts a just-merged commit." [core] - 10https://gerrit.wikimedia.org/r/163619 (owner: 10Anomie) [17:42:31] 3MediaWiki / 3General/Unknown: Text displayed out of bounds in browser - 10https://bugzilla.wikimedia.org/71420#c1 (10Glaisher) 5NEW>3RESO/INV There is no bug here. This is due to the
 HTML tag in the wikitext. 
[17:50:30] 	 3MediaWiki / 3MediaWiki UI: Enable form refresh as beta feature - 10https://bugzilla.wikimedia.org/71202#c4 (10Jared Zimmerman (WMF)) Does this go live on mw.org on thursday?
[17:50:47] 	 (03PS1) 10Anomie: Test for string in Pbkdf2Password::crypt() [core] - 10https://gerrit.wikimedia.org/r/163624 (https://bugzilla.wikimedia.org/71421) 
[17:50:52] 	 (03Merged) 10jenkins-bot: Revert "Replace wfMsgReplaceArgs by RawMessage" [core] - 10https://gerrit.wikimedia.org/r/163619 (owner: 10Anomie)
[17:51:29] 	 (03PS3) 10Cmcmahon: QA: WIP get rid of sleep [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163606 
[17:51:43] 	 chrismcmahon: ^ nice change!
[17:51:45] * YuviPanda hates sleeping
[17:51:51] 	 takes up so much of our time...
[17:52:13] 	 (03PS1) 10Ori.livneh: Test for string in Pbkdf2Password::crypt() [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/163626 (https://bugzilla.wikimedia.org/71421) 
[17:53:03] 	 YuviPanda: yeah, it's just bad design and cargo culting. this particular one is wasting 170 seconds on every build
[17:53:15] 	 3MediaWiki-Vagrant: (Cannot contact the database server: Too many connections ()) - 10https://bugzilla.wikimedia.org/71370#c1 (10Vogone) I experience this problem, too.
[17:53:18] 	 chrismcmahon: haha :D I was talking about human sleep, but that is true too
[17:53:18] 	 (03CR) 10Ori.livneh: [C: 032] Test for string in Pbkdf2Password::crypt() [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/163626 (https://bugzilla.wikimedia.org/71421) (owner: 10Ori.livneh)
[17:53:46] 	 YuviPanda: hard-coded sleeps are evil :-)
[17:53:50] 	 :D
[17:54:15] 	 3MediaWiki / 3General/Unknown: Text displayed out of bounds in browser - 10https://bugzilla.wikimedia.org/71420#c2 (10Glaisher) [[m:Special:Diff/10042755]] is a possible solution.
[17:54:31] 	 3MediaWiki / 3MediaWiki UI: Enable form refresh as beta feature - 10https://bugzilla.wikimedia.org/71202#c5 (10Jon) There's no patch for it yet. Prateek said he'd get a patch up today in which case I'll get merged. In case this happens can you coordinate with James F / Greg about deploying to wikis and if th...
[17:55:30] 	 3MediaWiki-Vagrant: (Cannot contact the database server: Too many connections ()) - 10https://bugzilla.wikimedia.org/71370#c2 (10Bryan Davis) Any particular workflow or steps to reproduce? If you can reproduce reliably, I'd be interested to know if `vagrant enable-role zend` (switching wiki runtime from hhvm t...
[17:56:00] 	 (03CR) 10Phuedx: Make require_package() variadic; stop creating stub classes (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/158912 (owner: 10Ori.livneh)
[17:56:12] 	 (03Merged) 10jenkins-bot: Test for string in Pbkdf2Password::crypt() [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/163626 (https://bugzilla.wikimedia.org/71421) (owner: 10Ori.livneh)
[17:57:59] 	 3MediaWiki-Vagrant: (Cannot contact the database server: Too many connections ()) - 10https://bugzilla.wikimedia.org/71370#c3 (10Jon) It's happening every hour or so for me. I've switched to zend, will report back my experience later.
[17:59:02] 	 (03PS4) 10Cmcmahon: QA: WIP get rid of sleep [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163606 
[17:59:38] 	 (03PS2) 10Umherirrender: Add "returntoquery" URL parameter support in Special:ChangeEmail [core] - 10https://gerrit.wikimedia.org/r/163552 (owner: 10IAlex)
[17:59:46] 	 (03CR) 10Umherirrender: [C: 032] Add "returntoquery" URL parameter support in Special:ChangeEmail [core] - 10https://gerrit.wikimedia.org/r/163552 (owner: 10IAlex)
[18:01:13] 	 bd808: I've tried zend and it didn't resolve the problem … I don't really know how to reproduce as it just suddenly happens without me doing anything specific
[18:02:37] 	 Vogone: Ok. I'm at least happy to hear that it happens under php5 as well as hhvm. Possibly some core bug?
[18:03:10] 	 ragesoss: yt?
[18:03:19] 	 ori: yep
[18:03:31] * Vogone shrugs
[18:03:44] 	 ragesoss: could you try CreateAccount one more time, with HHVM enabled? i don't think it'll work, but we'll get better log output now
[18:03:56] 	 okay
[18:05:11] 	 [c2e29ca0] 2014-09-29 18:05:01: Fatal exception of type MWException
[18:05:14] 	 (03PS5) 10Cmcmahon: QA: WIP get rid of sleep [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163606 
[18:05:14] 	 3Wikimedia / 3General/Unknown: Intermittent 403s when using HHVM - 10https://bugzilla.wikimedia.org/71385 (10Ori Livneh) 5PATC>3RESO/FIX
[18:05:22] 	 ragesoss: awesome, thanks!
[18:05:27] 	 np
[18:06:54] 	 (03Merged) 10jenkins-bot: Add "returntoquery" URL parameter support in Special:ChangeEmail [core] - 10https://gerrit.wikimedia.org/r/163552 (owner: 10IAlex)
[18:09:42] 	 (03PS6) 10Cmcmahon: QA: WIP get rid of sleep [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163606 
[18:17:45] 	 (03PS1) 10Umherirrender: Replace some wfMsgReplaceArgs by RawMessage [core] - 10https://gerrit.wikimedia.org/r/163633 
[18:18:46] 	 (03PS7) 10Cmcmahon: QA: WIP get rid of sleep [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163606 
[18:21:09] 	 hi lilatretikov
[18:23:34] 	 (03PS1) 10Ragesoss: Change "Disenroll" to "Unenroll" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/163634 
[18:23:40] 	 (03CR) 10jenkins-bot: [V: 04-1] Change "Disenroll" to "Unenroll" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/163634 (owner: 10Ragesoss)
[18:26:02] 	 3MediaWiki / 3MediaWiki UI: Top Drop down menu not working properly with touch screen - 10https://bugzilla.wikimedia.org/71424 (10Shivaji Varma) 3UNCO p:3Unprio s:3normal a:3None Created attachment 16627   --> https://bugzilla.wikimedia.org/attachment.cgi?id=16627&action=edit Top Dropdown menu  On my...
[18:28:56] 	 Nemo_bis: I just deployed the latest OCG bits -- anything in particular you want to (re)test?
[18:28:59] 	 (03CR) 10Aaron Schulz: API: Rewrite queries for list=allusers (032 comments) [core] - 10https://gerrit.wikimedia.org/r/163596 (https://bugzilla.wikimedia.org/70496) (owner: 10Anomie)
[18:29:16] 	 3MediaWiki / 3MediaWiki UI: Top Drop down menu not working properly with touch screen - 10https://bugzilla.wikimedia.org/71424#c1 (10Jared Zimmerman (WMF)) Thank for bringing this up, touch screen desktops are certainly an edge case for this ( the number of users accessing the desktop site from touch devices...
[18:29:29] 	 3MediaWiki / 3MediaWiki UI: Top Drop down menu not working properly with touch screen - 10https://bugzilla.wikimedia.org/71424 (10Jared Zimmerman (WMF)) 5UNCO>3NEW
[18:29:43] 	 cscott: not today
[18:30:15] 	 3MediaWiki-Vagrant: Duplicate definition: Package - 10https://bugzilla.wikimedia.org/53222#c6 (10Sam Smith) 5RESO/FIX>3REOP This appears to be happening again after the redefinition of the require_package function in https://gerrit.wikimedia.org/r/#/c/158912/.
[18:30:49] 	 3MediaWiki extensions / 3VectorBeta: CPB: change hover to tap behavior when touchevent is supported. - 10https://bugzilla.wikimedia.org/71424 (10Jared Zimmerman (WMF))
[18:31:12] 	 (03PS8) 10Cmcmahon: QA: WIP get rid of sleep [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163606 
[18:31:18] 	 3MediaWiki extensions / 3VectorBeta: CPB: change hover to tap behavior when touchevent is supported. - 10https://bugzilla.wikimedia.org/71424 (10Jared Zimmerman (WMF)) p:5Unprio>3Normal
[18:31:31] 	 3MediaWiki extensions / 3VectorBeta: CPB: change hover to tap behavior when touchevent is supported. - 10https://bugzilla.wikimedia.org/71424 (10Jared Zimmerman (WMF))
[18:33:00] 	 3MediaWiki-Vagrant: Duplicate definition: Package - 10https://bugzilla.wikimedia.org/53222#c7 (10Sam Smith) $ vagrant provision ==> default: Running provisioner: lsb_check... ==> default: Running provisioner: puppet... ==> default: Running Puppet with site.pp... ==> default: Error: Duplicate declaration: Packa...
[18:36:47] 	 (03PS9) 10Cmcmahon: QA: refactor to get rid of sleep [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163606 
[18:36:52] * hoo looks for legoktm 
[18:40:08] 	 (03PS2) 10MaxSem: Recursive git-update [vagrant] - 10https://gerrit.wikimedia.org/r/163293 (owner: 10Yurik)
[18:42:51] 	 (03PS5) 10Prtksxna: Special:Contributions: Use mediawiki.ui [core] - 10https://gerrit.wikimedia.org/r/162121 (https://bugzilla.wikimedia.org/71137) 
[18:43:38] 	 (03PS1) 10Aaron Schulz: Lowered ActiveUsers query period to reduce timeouts [core] - 10https://gerrit.wikimedia.org/r/163638 
[18:44:30] 	 (03CR) 10Jforrester: [C: 031] Remove "Allow saving code with errors" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/160367 (owner: 10Jackmcbarn)
[18:46:42] 	 (03PS6) 10Gergő Tisza: Introduce ContentAlterParserOutput hook [core] - 10https://gerrit.wikimedia.org/r/161471 
[18:47:05] 	 (03PS1) 10Umherirrender: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/163639 
[18:47:18] 	 (03CR) 10Gergő Tisza: "Rebased, bumped the version." [core] - 10https://gerrit.wikimedia.org/r/161471 (owner: 10Gergő Tisza)
[18:51:18] 	 (03PS1) 10Anomie: PasswordFactory::newFromPlaintext( null ) needs to work [core] - 10https://gerrit.wikimedia.org/r/163640 (https://bugzilla.wikimedia.org/71421) 
[18:55:45] 	 3MediaWiki / 3MediaWiki UI: Enable form refresh as beta feature - 10https://bugzilla.wikimedia.org/71202#c6 (10Jared Zimmerman (WMF)) Created attachment 16628   --> https://bugzilla.wikimedia.org/attachment.cgi?id=16628&action=edit rtl image for beta feature
[18:56:04] 	 (03PS1) 10Umherirrender: Do not read metadata from non-existing djvu image [core] - 10https://gerrit.wikimedia.org/r/163641 
[18:56:29] 	 (03Abandoned) 10Jdlrobson: Add watchlist count to compact personal bar [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/116920 (owner: 10JGonera)
[18:59:36] 	 (03CR) 10Reedy: [C: 04-1] PasswordFactory::newFromPlaintext( null ) needs to work (031 comment) [core] - 10https://gerrit.wikimedia.org/r/163640 (https://bugzilla.wikimedia.org/71421) (owner: 10Anomie)
[19:03:17] 	 (03CR) 10Ori.livneh: [C: 031] "LGTM." [core] - 10https://gerrit.wikimedia.org/r/163640 (https://bugzilla.wikimedia.org/71421) (owner: 10Anomie)
[19:09:16] 	 (03CR) 10Umherirrender: "Seems to work (at least the print in the jenkins log is gone)" [core] - 10https://gerrit.wikimedia.org/r/163641 (owner: 10Umherirrender)
[19:10:39] 	 (03CR) 10Anomie: API: Rewrite queries for list=allusers (032 comments) [core] - 10https://gerrit.wikimedia.org/r/163596 (https://bugzilla.wikimedia.org/70496) (owner: 10Anomie)
[19:11:32] 	 (03CR) 10Umherirrender: "Seems to work (at least two skipped testMediaWikiTestCaseParentSetupCalled now running, see jenkins log)" [core] - 10https://gerrit.wikimedia.org/r/163340 (owner: 10Umherirrender)
[19:11:58] 	 (03CR) 10Anomie: PasswordFactory::newFromPlaintext( null ) needs to work (032 comments) [core] - 10https://gerrit.wikimedia.org/r/163640 (https://bugzilla.wikimedia.org/71421) (owner: 10Anomie)
[19:13:42] 	 is it possible to get the user's edit count in JS without an API query?
[19:13:43] 	 (03CR) 10Gergő Tisza: [C: 032] "Thanks for the fix!" [core] - 10https://gerrit.wikimedia.org/r/163599 (owner: 10Umherirrender)
[19:14:54] 	 (03PS2) 10Krinkle: Register missing messages for mediawiki.special.upload [core] - 10https://gerrit.wikimedia.org/r/163599 (owner: 10Umherirrender)
[19:16:02] 	 (03CR) 10Krinkle: [C: 04-1] Register missing messages for mediawiki.special.upload (031 comment) [core] - 10https://gerrit.wikimedia.org/r/163599 (owner: 10Umherirrender)
[19:16:59] 	 (03CR) 10Anomie: [C: 04-1] Replace some wfMsgReplaceArgs by RawMessage (033 comments) [core] - 10https://gerrit.wikimedia.org/r/163633 (owner: 10Umherirrender)
[19:17:13] 	 Eloquence: Nope. meta=userinfo query.
[19:17:53] 	 Eloquence: I stand corrected. Someone added mw.config.get('wgUserEditCount')
[19:17:57] 	 So, yes :)
[19:18:22] 	 (03CR) 10Umherirrender: Register missing messages for mediawiki.special.upload (031 comment) [core] - 10https://gerrit.wikimedia.org/r/163599 (owner: 10Umherirrender)
[19:18:37] 	 (03CR) 10Gergő Tisza: Register missing messages for mediawiki.special.upload (031 comment) [core] - 10https://gerrit.wikimedia.org/r/163599 (owner: 10Umherirrender)
[19:20:47] 	 (03CR) 10Anomie: [C: 032] Lowered ActiveUsers query period to reduce timeouts [core] - 10https://gerrit.wikimedia.org/r/163638 (owner: 10Aaron Schulz)
[19:22:53] 	 (03CR) 10Anomie: [C: 032] Introduce ContentAlterParserOutput hook [core] - 10https://gerrit.wikimedia.org/r/161471 (owner: 10Gergő Tisza)
[19:27:20] 	 (03Merged) 10jenkins-bot: Lowered ActiveUsers query period to reduce timeouts [core] - 10https://gerrit.wikimedia.org/r/163638 (owner: 10Aaron Schulz)
[19:28:58] 	 (03Merged) 10jenkins-bot: Introduce ContentAlterParserOutput hook [core] - 10https://gerrit.wikimedia.org/r/161471 (owner: 10Gergő Tisza)
[19:35:46] 	 3MediaWiki / 3General/Unknown: Main WebRequest object an instance of FauxRequest - 10https://bugzilla.wikimedia.org/61273#c9 (10jimmy conway) 5RESO/WOR>3VERI Same issue with versio 1.23.4
[19:36:23] 	 (03PS1) 10Prtksxna: Add BetaFeature for form refresh and UI standardization experiment [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/163649 (https://bugzilla.wikimedia.org/71202) 
[19:36:38] 	 (03CR) 10Prtksxna: [C: 04-2] Add BetaFeature for form refresh and UI standardization experiment [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/163649 (https://bugzilla.wikimedia.org/71202) (owner: 10Prtksxna)
[19:36:48] 	 (03CR) 10Alex Monk: "That sounds like a discussion for the bug rather than this patch." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/120962 (https://bugzilla.wikimedia.org/51260) (owner: 10Alex Monk)
[19:38:14] 	 3MediaWiki / 3General/Unknown: Main WebRequest object an instance of FauxRequest - 10https://bugzilla.wikimedia.org/61273#c10 (10jimmy conway) backtrace while requesting main page  [c03a7291] [no req] Exception from line 1325 of /var/www/includes/WebRequest.php: FauxRequest::getRequestURL() not implemented B...
[19:39:42] 	 (03CR) 10Parent5446: "That was my bad on the last patch. I tested it and it looked good and I guess I didn't realize the escaping was wrong." [core] - 10https://gerrit.wikimedia.org/r/163633 (owner: 10Umherirrender)
[19:40:40] 	 (03CR) 10Krinkle: Register missing messages for mediawiki.special.upload (031 comment) [core] - 10https://gerrit.wikimedia.org/r/163599 (owner: 10Umherirrender)
[19:41:14] 	 3MediaWiki / 3General/Unknown: Main WebRequest object an instance of FauxRequest - 10https://bugzilla.wikimedia.org/61273#c11 (10jimmy conway) Created attachment 16629   --> https://bugzilla.wikimedia.org/attachment.cgi?id=16629&action=edit LocalSettings.php  Attaching LocalSettings.php as requested.
[19:42:11] 	 (03PS3) 10Krinkle: Register missing messages for mediawiki.special.upload [core] - 10https://gerrit.wikimedia.org/r/163599 (owner: 10Umherirrender)
[19:42:35] 	 (03CR) 10Krinkle: "Documented message usage. Without clarification like this, this will most likely get removed and subsequently reintroduce the brokenness p" [core] - 10https://gerrit.wikimedia.org/r/163599 (owner: 10Umherirrender)
[19:42:42] 	 (03CR) 10Krinkle: [C: 032] Register missing messages for mediawiki.special.upload [core] - 10https://gerrit.wikimedia.org/r/163599 (owner: 10Umherirrender)
[19:42:45] 	 3MediaWiki / 3General/Unknown: Main WebRequest object an instance of FauxRequest - 10https://bugzilla.wikimedia.org/61273#c12 (10jimmy conway) Thanks for looking at it!
[19:43:41] 	 (03CR) 10Parent5446: [C: 04-1] "If possible, could we just add a quick unit test for this?" [core] - 10https://gerrit.wikimedia.org/r/163640 (https://bugzilla.wikimedia.org/71421) (owner: 10Anomie)
[19:43:43] 	 (03PS2) 10Spage: piecemeal loading instead of fail in getRootPost [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163589 (https://bugzilla.wikimedia.org/71377) (owner: 10Matthias Mullie)
[19:43:50] 	 (03PS1) 10EBernhardson: Detect signature using Title class [extensions/Echo] - 10https://gerrit.wikimedia.org/r/163651 (https://bugzilla.wikimedia.org/71353) 
[19:44:59] 	 (03CR) 10Parent5446: [C: 032] Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/163639 (owner: 10Umherirrender)
[19:49:27] 	 (03Abandoned) 10MaxSem: Revert "More sensible behavior when special page aliases conflict" [core] - 10https://gerrit.wikimedia.org/r/162956 (owner: 10MaxSem)
[19:49:30] 	 (03Merged) 10jenkins-bot: Register missing messages for mediawiki.special.upload [core] - 10https://gerrit.wikimedia.org/r/163599 (owner: 10Umherirrender)
[19:50:32] 	 (03CR) 10Spage: [C: 04-1] "use Flow log, and wondering if there's other info to log to track this down." (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163589 (https://bugzilla.wikimedia.org/71377) (owner: 10Matthias Mullie)
[19:51:14] 	 (03CR) 10Aaron Schulz: [C: 032] Do not read metadata from non-existing djvu image [core] - 10https://gerrit.wikimedia.org/r/163641 (owner: 10Umherirrender)
[19:51:33] 	 (03Merged) 10jenkins-bot: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/163639 (owner: 10Umherirrender)
[19:52:52] 	 (03PS1) 10MaxSem: Revert "Revert "More sensible behavior when special page aliases conflict"" [core] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/163657 
[19:53:25] 	 (03PS1) 10MaxSem: Implement FauxRequest::getRequestURL() - needed for MF tests [core] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/163658 
[19:54:45] 	 3Wikimedia / 3Deployment systems: [OPS] Jenkins: Package php5-parsekit missing in Trusty - 10https://bugzilla.wikimedia.org/68255#c23 (10Antoine "hashar" Musso) The JJB macro phplint already uses "xargs -n1 -t php -l"  And on gallium:   $ fgrep -i parsekit /var/lib/jenkins/jobs/*/config.xml  $   $ fgrep -Ri...
[19:55:04] 	 greg-g: We have a bunch of stuff that needs to be SWAT deployed in mobile, so we were thinking about just deploying the current master branch rather than a ton of cherry-picks. First to wmf1 and then to wmf22. Would that be OK with you?
[19:55:55] 	 (03CR) 10EBernhardson: [C: 031] "simple easy patch, and worth the couple extra characters IMO" [core] - 10https://gerrit.wikimedia.org/r/130094 (https://bugzilla.wikimedia.org/25141) (owner: 10Gerrit Patch Uploader)
[19:56:46] 	 3MediaWiki / 3General/Unknown: Main WebRequest object an instance of FauxRequest - 10https://bugzilla.wikimedia.org/61273#c13 (10Jesús Martínez Novo (Ciencia Al Poder)) jimmy: could you please test it on a fresh MediaWiki installation? Proceeding with uploading MediaWiki installation files on your server, se...
[19:57:03] 	 (03Abandoned) 10EBernhardson: Make signatures within parser output findable [core] - 10https://gerrit.wikimedia.org/r/163327 (https://bugzilla.wikimedia.org/71353) (owner: 10EBernhardson)
[19:57:38] 	 (03Merged) 10jenkins-bot: Do not read metadata from non-existing djvu image [core] - 10https://gerrit.wikimedia.org/r/163641 (owner: 10Umherirrender)
[19:59:50] 	 anomie: what do you think about https://bugzilla.wikimedia.org/show_bug.cgi?id=54035#c6 ?
[19:59:51] 	 (03PS2) 10Prtksxna: Add BetaFeature for form refresh and UI standardization experiment [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/163649 (https://bugzilla.wikimedia.org/71202) 
[20:00:02] 	 (03CR) 10Prtksxna: Add BetaFeature for form refresh and UI standardization experiment [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/163649 (https://bugzilla.wikimedia.org/71202) (owner: 10Prtksxna)
[20:00:27] 	 specifically about the "If I understand correctly, code written for option 2 could be reused when implementing option 4, so going with that option now would not be wasted effort" part
[20:00:51] 	 (03CR) 10Jdlrobson: [C: 04-1] "Small change and then this looks good to merge!" (031 comment) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/163649 (https://bugzilla.wikimedia.org/71202) (owner: 10Prtksxna)
[20:00:59] 	 would you object to me working on that?
[20:01:06] 	 tgr: I'm sad that having a multi-value 'params' is going to be a major pain since we can't just pipe-separate them like everything else in the API does.
[20:01:44] 	 (03PS3) 10Prtksxna: Add BetaFeature for form refresh and UI standardization experiment [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/163649 (https://bugzilla.wikimedia.org/71202) 
[20:01:59] 	 (03CR) 10Prtksxna: Add BetaFeature for form refresh and UI standardization experiment (031 comment) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/163649 (https://bugzilla.wikimedia.org/71202) (owner: 10Prtksxna)
[20:02:43] 	 tgr: Splitting metadata into a separate prop module... Meh. Does it really need to be separate? Significant changes, +2, it's a mess right now with three slightly-different sets of metadata.
[20:03:50] 	 tgr: JSON inputs, no, that's ugly and doesn't fit at all with the rest of the API.
[20:04:02] 	 (03CR) 10Jdlrobson: [C: 032] Add BetaFeature for form refresh and UI standardization experiment [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/163649 (https://bugzilla.wikimedia.org/71202) (owner: 10Prtksxna)
[20:04:04] 	 anomie: I want to completely rewrite extmetadata to work with Wikibase and have a much wider scope than it currently does
[20:04:09] 	 (03Merged) 10jenkins-bot: Add BetaFeature for form refresh and UI standardization experiment [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/163649 (https://bugzilla.wikimedia.org/71202) (owner: 10Prtksxna)
[20:04:17] 	 tgr: "long-term thing", it would be nice if someone would help me with it ;)
[20:04:37] 	 I'll have an RFC up about that next week, probably
[20:05:21] 	 I don't have a strong opinion on the other metadata modules, but I would prefer to drop them from the successor of extmetadata
[20:06:10] 	 so no overlap anymore, extmetadata would deal with template & wikibase based metadata, the others (which probably should be merged) with EXIF
[20:06:10] 	 I just want one metadata thing, not three.
[20:06:52] 	 so they would have very different levels of abstraction
[20:07:36] 	 (03CR) 10Siebrand: [C: 032] i18n: move "nowiki" tags from "en.json" to body [extensions/ReassignEdits] - 10https://gerrit.wikimedia.org/r/159452 (owner: 10Shirayuki)
[20:07:57] 	 I could see extracted-from-the-file and template-or-wikidata being separate, I suppose.
[20:07:59] 	 (03CR) 10Kaldari: [C: 04-1] (bug 42979) Allow more than 50 flickr images. (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/45951 (owner: 10Nischayn22)
[20:08:28] 	 (03PS1) 10Jdlrobson: i18n: Use sentence case [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/163664 
[20:08:30] 	 anyway, there's a lot of change planned there (it's part of the turn-commons-into-wikidata-for-images project), I'll write a proper proposal about that
[20:09:09] 	 but unrelated to that, I would love to find a solution for multiple thumbnails per request soonish
[20:09:31] 	 3MediaWiki / 3MediaWiki UI: Enable form refresh as beta feature - 10https://bugzilla.wikimedia.org/71202 (10Prateek Saxena) 5PATC>3RESO/FIX
[20:09:35] 	 (03CR) 10Siebrand: [C: 032] Bidi-isolate and nowrap parser tags on Special:Version [core] - 10https://gerrit.wikimedia.org/r/145758 (owner: 10Amire80)
[20:09:53] 	 (03Merged) 10jenkins-bot: i18n: move "nowiki" tags from "en.json" to body [extensions/ReassignEdits] - 10https://gerrit.wikimedia.org/r/159452 (owner: 10Shirayuki)
[20:09:58] 	 (03CR) 10Prtksxna: [C: 032] i18n: Use sentence case [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/163664 (owner: 10Jdlrobson)
[20:10:01] 	 because it's required to a bugfix in MediaViewer that's relatively urgent, and the alternative would be to fire a dozen separate requests
[20:11:45] 	 (03PS2) 10EBernhardson: Hygiene: Simplify Pager [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163095 
[20:11:51] 	 anomie: as for the params thing, we can always exclamation-mark-separate them or something
[20:11:57] 	 (03PS2) 10EBernhardson: Add post-query filtering to Pager [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163096 
[20:12:02] 	 (03PS2) 10EBernhardson: [WIP] Change results of moderation dialogs to match filtering [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163097 
[20:12:25] 	 tgr: But what if the value for some param contains exclamation marks?
[20:12:26] 	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Simplify Pager [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163095 (owner: 10EBernhardson)
[20:12:53] 	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Change results of moderation dialogs to match filtering [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163097 (owner: 10EBernhardson)
[20:13:40] 	 tgr: We may have to go with double-pipes to separate groups of params. Something like foo=1|bar=2||foo=3|bar=12.
[20:13:44] 	 anomie: the set of thumbnail parameters is fairly small AFAIK
[20:14:11] 	 that could work, too
[20:14:19] 	 tgr: Not for long: https://lists.wikimedia.org/pipermail/wikitech-l/2014-September/078653.html
[20:15:01] 	 or go the other way and use double-pipe to escape literal pipes
[20:15:05] 	 (03CR) 10EBernhardson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163095 (owner: 10EBernhardson)
[20:15:15] 	 (03CR) 10Jdlrobson: [C: 032] Special:Contributions: Use mediawiki.ui [core] - 10https://gerrit.wikimedia.org/r/162121 (https://bugzilla.wikimedia.org/71137) (owner: 10Prtksxna)
[20:15:16] 	 robla: Who's covering for greg-g today?
[20:16:06] 	 kaldari|2: chrismcmahon or James_F
[20:16:14] 	 thanks
[20:16:14] 	 (03Merged) 10jenkins-bot: Bidi-isolate and nowrap parser tags on Special:Version [core] - 10https://gerrit.wikimedia.org/r/145758 (owner: 10Amire80)
[20:16:16] 	 (03Merged) 10jenkins-bot: i18n: Use sentence case [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/163664 (owner: 10Jdlrobson)
[20:16:47] 	 I have to take off in about 15 minutes for about two hours though
[20:16:58] 	 chrismcmahon: We have a bunch of stuff that needs to be SWAT deployed in mobile, so we were thinking about just deploying the current master branch rather than a ton of cherry-picks. First to wmf1 and then to wmf22. Would that be OK with you?
[20:17:00] 	 (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/163097 (owner: 10EBernhardson)
[20:18:20] 	 kaldari|2: fine by me. that seems simple enough.
[20:18:30] 	 (03CR) 10Siebrand: "Thanks." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/163664 (owner: 10Jdlrobson)
[20:19:25] 	 tgr: Encoding literal pipes is an entirely different problem, the double pipes are for separating sets-of-parameters. How does [[File:Example.jpg|foo=a{{!}}b]] get seen by the media handler?
[20:20:11] 	 sets of parameters?
[20:20:23] 	 chrismcmahon: Follow-up question: when I try to update the extension for the wmf1 branch, I get "fatal: Not possible to fast-forward, aborting." The branch doesn't have any other commits since the branch was cut, so not sure why it's failing. Any idea what else I could try (besides git merge --ff-only origin/master).
[20:20:29] 	 there's tons of file links around with double pipes fyi
[20:21:40] 	 (03Merged) 10jenkins-bot: Special:Contributions: Use mediawiki.ui [core] - 10https://gerrit.wikimedia.org/r/162121 (https://bugzilla.wikimedia.org/71137) (owner: 10Prtksxna)
[20:21:57] 	 chrismcmahon: I could try it without the --ff-only flag I suppose, but seems evil
[20:21:59] 	 anomie: well, from the point of view of the low-level API functions they would be literal pipes
[20:22:11] 	 Nemo_bis: Being able to get thumbnails for both [[File:Example.xxx|width=100|height=100]] and [[File:Example.xxx|width=200|height=250]] with one call to the API, with something like prop=fileinfo&fithumbparams=width=100|height=100||width=200|height=250
[20:22:17] 	 kaldari|2: I don't know that error. maybe ^d or someone could help out?
[20:22:21] 	 or are you thinking of a new API parameter type that returns deep arrays?
[20:22:41] 	 anomie: ah, API; ok :)
[20:23:47] 	 3MediaWiki / 3MediaWiki UI: Beta feature not enabling new UI for edit page - 10https://bugzilla.wikimedia.org/71428 (10Jon) 3NEW p:3Unprio s:3normal a:3None With the beta feature enabled, I am not seeing the styles (although the classes are there). I suspect the hook `onRequestContextCreateSkin` runs...
[20:23:57] 	 tgr: I'm thinking foreach ( explode( '||', $param['thumbparams'] ) as $paramset ) { $params = explode( '|', $paramset ); $thumbnails[] = makeThumbnail( $file, $params ); } }
[20:24:57] 	 anomie: as a breaking change, or introducing PARAM_ISMULTIGROUP?
[20:25:02] 	 tgr: My question at the moment is whether the "foo=a{{!}}b" actually gets parsed in [[File:Example.jpg|foo=a{{!}}b]] so the media handler sees "foo=a|b", or whether it sees "foo=a" and "b" or "foo=a{{!}}b" unparsed.
[20:25:29] 	 tgr: As the parameter isn't even declared PARAM_ISMULTI, the module just parses out the string.
[20:26:16] 	 3MediaWiki / 3MediaWiki UI: Use mediawiki.ui elements on Special:Contributions - 10https://bugzilla.wikimedia.org/71137 (10Prateek Saxena) 5PATC>3RESO/FIX
[20:26:51] 	 (03CR) 10Siebrand: "Ehr... I would recommend to abandon this." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/163634 (owner: 10Ragesoss)
[20:29:31] 	 (03CR) 10Ragesoss: "Whether or not dictionaries have caught up, "unenroll" is common usage, while users consistently find the term "disenroll" confusing." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/163634 (owner: 10Ragesoss)
[20:30:02] 	 (03CR) 10Aaron Schulz: [C: 032] API: Rewrite queries for list=allusers (032 comments) [core] - 10https://gerrit.wikimedia.org/r/163596 (https://bugzilla.wikimedia.org/70496) (owner: 10Anomie)
[20:30:03] 	 anomie: the media handler takes parameter arrays, {{!}} is dealt with somewhere in the parser
[20:30:48] 	 Parser::makeImage does the exploding and {{!}} is already transcluded by that point
[20:31:33] 	 tgr: In that case, I'd think it should see "foo=a" and "b". So we shouldn't have to worry about escaping literal pipes, because there's no way to get them into the parameter array in wikitext.
[20:35:24] 	 3MediaWiki / 3MediaWiki UI: Beta feature not enabling new UI for edit, history and delete pages - 10https://bugzilla.wikimedia.org/71428#c1 (10Jon) Seems to also effect delete and history. I guess onRequestContextCreateSkin runs after those lines of code.
[20:35:45] 	 3Wikimedia / 3Bugzilla: Enable IPv6 on phabricator.wikimedia.org - 10https://bugzilla.wikimedia.org/71270#c5 (10Quim Gil) Get ipv6 working for phabricator.wikimedia.org https://phabricator.wikimedia.org/T509
[20:36:11] 	 (03PS5) 10Jdlrobson: HistoryAction: Use correct classes for buttons [core] - 10https://gerrit.wikimedia.org/r/162808 (https://bugzilla.wikimedia.org/71141) (owner: 10Prtksxna)
[20:36:35] 	 (03Merged) 10jenkins-bot: API: Rewrite queries for list=allusers [core] - 10https://gerrit.wikimedia.org/r/163596 (https://bugzilla.wikimedia.org/70496) (owner: 10Anomie)
[20:37:37] 	 anomie: what I don't like about this is that it seems to introduce a third image parameter syntax
[20:37:56] 	 so far there are two, the parser syntax and the thumbnail URL syntax
[20:38:02] <^d>	 chrismcmahonafk: kaldari|2 and I got it figured out :)
[20:38:37] 	 (03CR) 10Jdlrobson: [C: 04-1] HistoryAction: Use correct classes for buttons (032 comments) [core] - 10https://gerrit.wikimedia.org/r/162808 (https://bugzilla.wikimedia.org/71141) (owner: 10Prtksxna)
[20:38:53] 	 but the URL syntax is too limited (no height) and the parser syntax is handled inside the parser and probably can't be used for this without lots of refactoring
[20:39:29] 	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/161093 (https://bugzilla.wikimedia.org/65403) (owner: 10Anomie)
[20:39:38] 	 media handlers have their own parameter names which so far were not exposed anywhere, AFAIK
[20:40:05] 	 tgr: My goal here is that the syntax for this fithumbparams is === the parser syntax. With multiple parser-syntax sets separated by double-pipes for input purposes.
[20:42:07] 	 (03PS6) 10Prtksxna: HistoryAction: Use correct classes for buttons [core] - 10https://gerrit.wikimedia.org/r/162808 (https://bugzilla.wikimedia.org/71141) 
[20:42:14] 	 (03CR) 10Prtksxna: HistoryAction: Use correct classes for buttons (032 comments) [core] - 10https://gerrit.wikimedia.org/r/162808 (https://bugzilla.wikimedia.org/71141) (owner: 10Prtksxna)
[20:43:14] 	 anomie: yeah, from a user point of view that makes a lot of sense
[20:43:16] 	 tgr: So basically fithumbparams=foo=1|bar=2||foo=12|baz=something would give you the same two image URLs that would be used for [[File:Whatever.jpg|foo=1|bar=2]] and [[File:Whatever.jpg|foo=12|baz=something]]. To the point where ideally both the parser and the API would pass a File object and "foo=1|bar=2" to the same function to get the thumbnail url.
[20:43:17] 	 in English?
[20:43:26] 	 or would it tak a language as well?
[20:43:34] 	 image parameters are translatable
[20:44:43] 	 tgr: Well, the keys depend on content language, don't they? As for what the media handler does with them, hopefully it takes a ContextSource.
[20:46:02] 	 ori: James_F: http://www.chromestatus.com/metrics/feature/timeline/popularity/494
[20:46:13] 	 chrome's anonymised measurements of intenral features is now published
[20:46:34] 	 (03PS7) 10Prtksxna: HistoryAction: Use correct classes for buttons [core] - 10https://gerrit.wikimedia.org/r/162808 (https://bugzilla.wikimedia.org/71141) 
[20:46:56] 	 anomie: AFAIK the media handler has its own keys, those are not language-dependent
[20:47:05] 	 (03CR) 10Siebrand: "Google gives twice as many result for disenroll (116k) as for unenroll (63,3k). I'm not convinced." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/163634 (owner: 10Ragesoss)
[20:47:23] 	 the parser translates image wikitext parameters to media handler parameters
[20:47:37] 	 tgr: True. Those shouldn't be exposed, IMO.
[20:47:49] 	 (03PS5) 10Manybubbles: Initial [search/extra] - 10https://gerrit.wikimedia.org/r/163268 
[20:49:50] 	 anomie: so how about this? I'll try to refactor the parser to expose the wikitext-params-to-mediahandler-params translation (at a glance does not look scary),
[20:50:16] 	 3MediaWiki / 3JavaScript: mediawiki.action.view.redirect.js: Not idempotent when used on double redirect (refreshing the page redirects the user elsewhere) - 10https://bugzilla.wikimedia.org/71002 (10Bartosz Dziewoński) 5PATC>3RESO/FIX
[20:50:58] 	 add a new iiwikitextparam parameter to imageinfo, using the double-pipe syntax you suggested, return the format described in https://bugzilla.wikimedia.org/show_bug.cgi?id=54035#c6 option 2
[20:51:32] 	 and whenever imageinfo gets rewritten, that code could should be easy to reuse
[20:52:05] 	 and the whole thing can still be done quickly enough that the MediaViewer bugfix can wait until it's done
[20:52:30] 	 3MediaWiki / 3API: ApiQueryAllUsers with auactiveusers fails on duplicate querycachetwo rows - 10https://bugzilla.wikimedia.org/71086#c8 (10Aaron Schulz) (In reply to Brad Jorsch from comment #7) > (In reply to Aaron Schulz from comment #3) > > As for the duplicates already there, I guess the cache can just...
[20:52:33] 	 (03CR) 10Ragesoss: "Half as many results for the one that not yet included in most dictionaries... that should at least establish that it is in fact a widely " [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/163634 (owner: 10Ragesoss)
[20:53:57] 	 tgr: I suppose. I just hate messing with ApiQueryImageInfo.
[20:57:00] 	 3MediaWiki / 3MediaWiki UI: Beta feature not enabling new UI for edit, history and delete pages - 10https://bugzilla.wikimedia.org/71428#c2 (10Jon) I think we need to use onMediaWikiPerformAction here...
[20:58:00] 	 3MediaWiki / 3MediaWiki UI: Fix Special:BlockList for mw.ui - 10https://bugzilla.wikimedia.org/71144 (10Jon) 5PATC>3RESO/FIX
[20:58:14] 	 (03PS17) 10Jdlrobson: Fix styling of deletion page when $wgUseMediaWikiUIEverywhere enabled [core] - 10https://gerrit.wikimedia.org/r/154121 (https://bugzilla.wikimedia.org/70134) 
[21:01:20] 	 (03Abandoned) 10Anomie: Test for string in Pbkdf2Password::crypt() [core] - 10https://gerrit.wikimedia.org/r/163624 (https://bugzilla.wikimedia.org/71421) (owner: 10Anomie)
[21:03:31] 	 3MediaWiki / 3MediaWiki UI: Remove $wgUseMediaWikiUIEverywhere dependency for button and text input styling (tracking) - 10https://bugzilla.wikimedia.org/70913 (10Matthew Flaschen)
[21:03:35] 	 3MediaWiki / 3MediaWiki UI: Fix action=history for mw.ui - 10https://bugzilla.wikimedia.org/71141 (10Matthew Flaschen)
[21:03:35] 	 3MediaWiki / 3History/Diffs: Use  instead of