[00:00:40] (03CR) 10Bartosz Dziewoński: mediawiki.api.options: New module for user preferences API (action=options) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/160308 (owner: 10Bartosz Dziewoński) [00:00:49] (03PS4) 10Bartosz Dziewoński: mediawiki.api.options: New module for user preferences API (action=options) [core] - 10https://gerrit.wikimedia.org/r/160308 [00:29:17] (03Abandoned) 10Paladox: Delete skins/common/ [core] - 10https://gerrit.wikimedia.org/r/163210 (https://bugzilla.wikimedia.org/69277) (owner: 10Paladox) [00:29:54] (03PS28) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [00:30:08] (03PS7) 10Paladox: Update jquery.ui Vector theme to 1.9.2 [skins/Vector] - 10https://gerrit.wikimedia.org/r/154024 [00:36:56] 3MediaWiki / 3Special pages: SpecialImport accesses $this->getConfig() in constructor, before context is set - 10https://bugzilla.wikimedia.org/71376 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None See CR on https://gerrit.wikimedia.org/r/#/c/151535/2/includes/specials/SpecialImport.php,cm... [00:37:09] 3MediaWiki / 3General/Unknown: Code quality issues (tracking) - 10https://bugzilla.wikimedia.org/700 (10Kunal Mehta (Legoktm)) [00:37:09] 3MediaWiki / 3Special pages: SpecialImport accesses $this->getConfig() in constructor, before context is set - 10https://bugzilla.wikimedia.org/71376 (10Kunal Mehta (Legoktm)) p:5Unprio>3Low [01:04:06] (03CR) 10Bartosz Dziewoński: [C: 032] "I want this done and I'm sure no one is going to review this list anyway, so let me share you the effort of pretending." [core] - 10https://gerrit.wikimedia.org/r/163171 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [01:04:10] (03CR) 10Bartosz Dziewoński: [C: 032] "I want this done and I'm sure no one is going to review this list anyway, so let me share you the effort of pretending." [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/163169 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [01:10:33] (03Merged) 10jenkins-bot: Add release notes for skins/common/ removal [core] - 10https://gerrit.wikimedia.org/r/163171 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [01:11:07] (03Merged) 10jenkins-bot: Add release notes for skins/common/ removal [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/163169 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [01:12:08] 3MediaWiki / 3Interface: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277#c77 (10Bartosz Dziewoński) 5PATC>3ASSI (In reply to Bartosz Dziewoński from comment #59) > Release notes listing what exactly was removed Done for 1.2... [01:13:04] Krinkle: If I have an object with property "class", jscs suggests the removal of the quotes. But if I remember correctly this specific property should have quotes to avoid some bug [01:13:11] what to do in cases like this? [01:13:27] Helder: If you need to support older browsers, there are certain property names that are reserved such as 'class' and you need to quote htem [01:13:29] Does the same applies to the property "for", which is another reserved word in Javascript? [01:13:35] But in new browsers this bug was fixed and they work just fine [01:13:44] >> x = { foo: 1, class: 2 }; x.class [01:13:44] Krinkle: (number) 2 [01:14:01] Helder: Set your jscs setting to "allButReserved" for object quotes if you need to support older browsers [01:14:06] ecmabot-wm: ? [01:14:06] Helder: There is no command: ? [01:14:16] https://github.com/jscs-dev/node-jscs#disallowquotedkeysinobjects [01:14:38] ah, great! [01:14:44] I missed that option :-) [01:15:48] thanks [01:17:00] Krinkle: what is this ecmabot-wm ? [01:17:24] Helder: It's a robot to evaluate snippets of ECMAScript programs in a sandbox [01:17:31] like the console in your browser [01:17:48] ECMAScript is the official name of the programming language implemented as javascript, jscript, v8 etc. [01:17:50] neat! :-) [01:18:03] but just the pure language, not a browser or server [01:19:41] >> 'Krinkle: Should I just type ' + '>>' + ' before a JS command to use it?' [01:19:42] Helder: (string) 'Krinkle: Should I just type >> before a JS command to use it?' [01:19:57] cool! [01:20:49] (03PS1) 10Catrope: Add node_modules directory [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/163320 [01:21:40] >> window [01:21:40] liangent: ReferenceError: window is not defined [01:21:51] >> alert [01:21:51] liangent: (function) log [01:22:02] >> confirm [01:22:03] liangent: ReferenceError: confirm is not defined [01:23:10] ecmabot-wm: mdn indexOf [01:23:10] Krinkle: Array.prototype.indexOf() - JavaScript | MDN 2 [01:23:35] liangent: Yeah it doesn't include any of the browser stuff unfortunately [01:23:37] ecmabot-wm: ecma strict mode [01:23:37] Krinkle: Found: 10.1.1 Strict Mode Code [01:23:41] >> document.createElement('div') [01:23:42] RoanKattouw: ReferenceError: document is not defined [01:23:54] unfortunately? Think of all the security problems [01:24:11] Who on earth would be stupid enough to install a *browser* on their server? [01:24:51] Like curl? [01:24:54] Or phantomjs? [01:25:03] Or lynx? [01:26:00] Carmela: As we speak Krinkle is sitting next to me figuring out how to puppetize his hacked-up installation of Chromium on the CI servers [01:26:04] to run unit tests in [01:26:11] :D [01:26:13] i did it already in vagrant [01:26:32] (03PS1) 10Catrope: [WIP] Add build of Zotero translation server [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/163321 [01:26:38] And I am weighing whether I should ask ops to install firefox-dev (which depends on firefox) on the services cluster or put 58 MB of libxul binaries in a git repo [01:26:39] oh, i may have removed it [01:26:39] hm [01:26:40] Can server-side Chromium parse/execute JS? [01:26:52] Based on which one will get fewer people to kill me in my sleep [01:28:04] Carmela: Apparently, because his plan is to replace PhantomJS with Chromium for running JS unit tests [01:28:18] https://github.com/wikimedia/mediawiki-vagrant/tree/6b879cfa80e2d9f34a6a9724a449a88f641d5901/puppet/modules/chromium [01:28:34] specifically https://github.com/wikimedia/mediawiki-vagrant/blob/6b879cfa80e2d9f34a6a9724a449a88f641d5901/puppet/modules/chromium/manifests/init.pp [01:28:48] i deleted it at one point because nothing was using it [01:30:09] the xvfb module was part of the same commit: https://github.com/wikimedia/mediawiki-vagrant/commit/beb115184ab5717327b5e41a7f4abdbeca23c1c0 [01:30:37] it should be easy to port it to operations/puppet; "apt::ppa" is a vagrant thing but the other puppet resources are generic [01:31:25] you get an upstart script that runs chromium in headless mode via xvfb and with remote debugging set up and everything :P [01:31:39] RoanKattouw: ^ [01:31:53] anyways, have a good weekend folks. [01:32:17] RoanKattouw: I tried phantomjs and wasn't in love with it. Why the siwtch? [01:32:29] switch [01:32:38] its JS engine is horribly out of date [01:33:02] phantomjs seemed slow, crash-y, and not multi-threaded. [01:33:07] Though maybe I was doing it wrong. [01:34:54] ori: Wait that sounds like what Krinkle is trying to puppetize [01:35:00] xvfb and upstart and everything [01:35:50] Carmela: PhantomJS uses JavaScriptCore, which was Webkit's JS engine before they switched to V8 [01:36:10] ori: I need 1) to puppet ensure a xvfb window is always running, 2) be able to start chromium from a jenkins job with a specified tmp user directory [01:36:18] Which is because they use the Qt port of Webkit, which was initially ported for Konqueror (and HTML rendering widgets in Qt/KDE) [01:36:51] Krinkle: the chromium and xvfb modules do 90% of what you're asking for [01:36:53] At this point there is no real browser out there that still uses JSC [01:37:23] keep the xvfb upstart job so ensure xvfb is always running, but instead of running chromium as a service just copy the invocation into your jenkins job and adapt as needed [01:37:28] Correction from Krinkle: Safari still does [01:37:35] So essentially we're running our unit tests on Safari [01:37:38] (03PS1) 10Jforrester: Add some more repos to #mediawiki-visualeditor [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/163322 [01:37:44] Except like an old version of Safari without things like Function.prototype.bind [01:38:39] And that is why PhantomJS is garbage and I'd love to move away from it ASAP [01:38:56] I hear someone (like one person) is working on porting it to V8, which will probably solve a lot of issues [01:39:03] ori: What does the https://github.com/wikimedia/mediawiki-vagrant/blob/beb115184ab5717327b5e41a7f4abdbeca23c1c0/puppet/modules/xvfb/templates/xvfb.conf.erb file do? [01:39:07] But I'd much rather use a headless version of a real browser [01:39:08] respawn limit 10 5 etc. [01:39:08] I thought PhantomJS had a lot of backers. [01:39:20] A lot of users [01:39:22] Not the same thing [01:39:40] Apparently not that many people are excited about ripping the JSC guts out of it and putting V8 in [01:39:44] Well, I don't really like JavaScript, so I'm not among them! [01:39:45] It sounds like a difficult projecr [01:39:56] WebKit, unlike Chromium, isn't cross-platform with shared code base, but is ported. [01:40:03] For a long while all these ports were maintained in the same svn repo [01:40:09] among them QtWebKit [01:40:16] (for Nokia's WebEngine suite) [01:40:24] Krinkle: browsers need an x server; xvfb (X virtual framebuffer) doesn't show any screen output; doesn't require a monitor; etc. [01:40:40] ori: I know, I'm already using Xvfb [01:40:52] I just made a screen capture using xwd on a labs instance with chromium running [01:40:59] the file you linked to is the upstart job, it makes it a system service that init spawns when the machine is booting [01:41:00] But it's not puppetised [01:42:10] it's an .erb file; puppet will replace <%= @display %> and <%= @resolution %> with the values of the parameters of the same name [01:42:15] ori: this is what I have so far [01:42:16] https://gist.github.com/Krinkle/0dec5eefdeb44f40bc4a [01:43:04] nod [01:43:44] i gotta run, sorry! roan should be able to help you tweak the module to do what you want [01:44:06] It does throw errors: https://gist.github.com/Krinkle/0dec5eefdeb44f40bc4a#file-02-out [01:44:15] but doesn't seem to affect the running of the browser [01:44:24] ori: could you take a peek at https://gist.github.com/Krinkle/0dec5eefdeb44f40bc4a#file-02-out and tell me it's OKish ? [01:44:40] I googled each, didn't get me anywhere [01:44:56] it's okish, but it's an imperative script and not a puppet module [01:45:30] (03Abandoned) 10Luis Felipe Schenone: Changed the
    and
  • of galleries for
    and
    [core] - 10https://gerrit.wikimedia.org/r/62207 (owner: 10Luis Felipe Schenone) [01:45:53] yea that looks ok, chromium tends to have some additional output. the randr and gl stuff can certainly be ignored thats just reporting missing capabilities essentially [01:46:11] libexif is the only one i would potentially check, but i [01:46:16] ebernhardson: Funny though, when I run Xvfb manually and look at the extensions it loads, RANDR *is* among them [01:46:36] Krinkle: really? that is suprising [01:47:41] <_figital> question: i just finally got mediawiki installed with parsoid/VE .. very nice !!! :) .... there doesn't seem to be any FK indexes on the tables. is this correct? [01:47:48] Yes [01:47:52] Krinkle: so i imagine `DISPLAY=:94.0 xrandr` works as well? i'm kinda curious because i've been wanting to get this same stuff going but havn't had time to look into it :) [01:48:01] ebernhardson: https://gist.github.com/Krinkle/0dec5eefdeb44f40bc4a#file-03-sample [01:48:05] (03CR) 10Jforrester: [C: 031] "Eww." [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/163320 (owner: 10Catrope) [01:53:13] Krinkle: i can confirm that while xvfb says it turned on RANDR, its not available via any of the x11 api's. https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/516123 seems to indicate its a known problem, but again i don't think this effects the browser testsing [01:53:22] xrandr just allows programs to change things about the display like size/rotation/etc. [01:53:39] k [01:56:29] (03CR) 10Jackmcbarn: [C: 032] Pass correct function name to checkType [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/163272 (owner: 10Amire80) [01:58:28] (03Merged) 10jenkins-bot: Pass correct function name to checkType [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/163272 (owner: 10Amire80) [01:59:08] 3MediaWiki / 3General/Unknown: Provide an easy-to-run suite of performance regression tests - 10https://bugzilla.wikimedia.org/68821 (10Ori Livneh) [01:59:52] 3MediaWiki extensions / 3Scribunto: There is no way to obtain the language variant in Scribunto module code - 10https://bugzilla.wikimedia.org/71366#c3 (10Jackmcbarn) I don't really think this bug is related to that bug. Also, I think that adding this functionality would be a bad idea, since it could break... [02:01:18] 3MediaWiki extensions / 3TorBlock: Warning: Invalid argument supplied for foreach() in TorExitNodes.php on line 210 - 10https://bugzilla.wikimedia.org/69017#c3 (10Ori Livneh) Nemo, is this still an issue? [02:02:07] 3MediaWiki / 3JobRunner: Jobrunner will fail to spawn jobs on HHVM - 10https://bugzilla.wikimedia.org/69428#c4 (10Ori Livneh) 5NEW>3RESO/FIX Fixed by https://github.com/facebook/hhvm/commit/7061ff24162b2afba3738614d9f210cd8fba4a6c [02:05:01] (03CR) 10Jackmcbarn: Implement page status indicators (031 comment) [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [02:07:47] (03PS1) 10Spage: QA: be explicit about unread notification timing [extensions/Echo] - 10https://gerrit.wikimedia.org/r/163324 [02:11:38] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: "Automatically enable ..." should actually automatically enable, not require visiting Special:Preferences - 10https://bugzilla.wikimedia.org/62815#c2 (10Jared Zimmerman (WMF)) Once again, with HHVM, and soon with Form refresh, we're losing out on lots of p... [02:19:54] 3MediaWiki extensions / 3Capiunto: performance review for Capiunto - 10https://bugzilla.wikimedia.org/69540#c13 (10Jackmcbarn) (In reply to Brad Jorsch from comment #11) > (In reply to Jackmcbarn from comment #9) > > I wonder if this tradeoff was worth it. Maybe we should have > > $wgScribuntoAllowedResource... [02:20:56] (03PS1) 10Cscott: Fix redis gc. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163326 [02:27:54] (03PS1) 10EBernhardson: Make signatures within parser output findable [core] - 10https://gerrit.wikimedia.org/r/163327 [02:28:55] (03PS2) 10EBernhardson: Make signatures within parser output findable [core] - 10https://gerrit.wikimedia.org/r/163327 (https://bugzilla.wikimedia.org/71353) [02:29:21] (03PS3) 10EBernhardson: Make signatures within parser output findable [core] - 10https://gerrit.wikimedia.org/r/163327 (https://bugzilla.wikimedia.org/71353) [02:30:42] (03CR) 10Jackmcbarn: Make signatures within parser output findable (031 comment) [core] - 10https://gerrit.wikimedia.org/r/163327 (https://bugzilla.wikimedia.org/71353) (owner: 10EBernhardson) [02:31:51] (03CR) 10EBernhardson: Make signatures within parser output findable (031 comment) [core] - 10https://gerrit.wikimedia.org/r/163327 (https://bugzilla.wikimedia.org/71353) (owner: 10EBernhardson) [02:32:25] (03PS1) 10Foxtrott: New component Menu [skins/chameleon] - 10https://gerrit.wikimedia.org/r/163328 [02:33:10] (03CR) 10Jackmcbarn: Make signatures within parser output findable (031 comment) [core] - 10https://gerrit.wikimedia.org/r/163327 (https://bugzilla.wikimedia.org/71353) (owner: 10EBernhardson) [02:33:48] ebernhardson: btw, jenkins is almost certainly going to V-1 you [02:35:46] (03CR) 10jenkins-bot: [V: 04-1] Make signatures within parser output findable [core] - 10https://gerrit.wikimedia.org/r/163327 (https://bugzilla.wikimedia.org/71353) (owner: 10EBernhardson) [02:36:08] yea theres probably a parser test somewhere that needs updating, will do :) [02:37:00] (03CR) 10EBernhardson: Deprecate use of data-parsoid (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162820 (owner: 10EBernhardson) [02:38:05] (03PS2) 10Foxtrott: New component Menu [skins/chameleon] - 10https://gerrit.wikimedia.org/r/163328 [02:38:31] jackmcbarn: hmm, mw-user-date feels wrong, but mw-date would be even more wrong [02:38:34] for ~~~~~ [02:38:51] yeah, you're right [02:38:52] unless it really is a user specific date? [02:38:58] (03CR) 10Foxtrott: [C: 032 V: 032] New component Menu [skins/chameleon] - 10https://gerrit.wikimedia.org/r/163328 (owner: 10Foxtrott) [02:39:05] It's a site-specific date. [02:39:16] ebernhardson: actually, maybe there's a better way to solve your root issue [02:39:18] It's based on some global configuration variable, I believe. [02:39:36] jackmcbarn: that would work too :) because this would require re-working echo to use the parser result instead of the wikitext input [02:39:38] what if you ran the line you're looking at through the new parser, and looked at the links recorded in its output? [02:39:45] s/the new/a new/ [02:40:02] jackmcbarn: i dont think just the links is enough to determine that an edit was signed? [02:40:04] (where "new" is a new instance of the Parser class, not any new code) [02:40:08] isn't it? [02:40:23] i mean, you could edit anything and put a User:EBernhardson link in it [02:40:52] i dont think there is anything unique about the link in signatures, but i've been mistaken before :) [02:41:34] the root of the issue is that echo is trying to guess signatures by first looking for a timestamp, and then making a long list of regexp's for each namespace it thinks is a User namespace of alias [02:41:49] then it looks for [[$prefix: in the wikitext for each on the same line as the timestamp :( [02:42:04] okay, new idea then: [02:42:26] make the regexp match any wikilink, but then when it finds them, turn them into Titles and check their namespace that way to confirm the match [02:42:40] hmmm [02:44:26] 3MediaWiki-Vagrant: Failure to provision role::gwtoolset due to scrubunto dependency - 10https://bugzilla.wikimedia.org/71354#c7 (10dan) Created attachment 16612 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16612&action=edit another debug session with complete debug output and steps taken [02:48:14] (03PS1) 10Foxtrott: Add Menu component to NavBar; clean-up autoloading; fix print styles; new layout stickyhead [skins/chameleon] - 10https://gerrit.wikimedia.org/r/163329 [02:50:02] (03CR) 10Jackmcbarn: [C: 04-1] "After discussion on IRC, I'm not sure this is the right way to solve this. Instead, I think we can solve it entirely within Echo:" [core] - 10https://gerrit.wikimedia.org/r/163327 (https://bugzilla.wikimedia.org/71353) (owner: 10EBernhardson) [02:51:43] (03PS2) 10Foxtrott: Add Menu component to NavBar; clean-up autoloading; fix print styles; new layout stickyhead [skins/chameleon] - 10https://gerrit.wikimedia.org/r/163329 [02:52:49] (03CR) 10Foxtrott: [C: 032 V: 032] Add Menu component to NavBar; clean-up autoloading; fix print styles; new layout stickyhead [skins/chameleon] - 10https://gerrit.wikimedia.org/r/163329 (owner: 10Foxtrott) [02:53:34] jackmcbarn: oh i guess i didn't get back to you, thats a good idea! i'm trying it out now [03:00:09] sigh...now to figure out why this doesnt match, i love regex: "\\<[^\\d\\W]+ [^\\d\\W]+\\='[^\\d\\W]+\\-[^\\d\\W]+\\-[^\\d\\W]+'\\>\\d+\\:\\d+, \\d+ [^\\d\\W]+ \\d+ \\([^\\d\\W]+\\)\\<\\/[^\\d\\W]+\\>" [03:00:36] * jackmcbarn eyebleed [03:00:52] is that double-escaped? [03:00:59] probably, it came out of hhvm [03:01:09] the cli debugger, i'm not sure but its likely it escapes [03:01:45] (03CR) 10Foxtrott: "See Iaa758f782efdd464001b5b21d556039024882b1c for an alternative (object-oriented, recursive) approach." [core] - 10https://gerrit.wikimedia.org/r/108045 (owner: 10Jack Phoenix) [03:01:46] fun stuff, that regex is not defined strictly within the file its generated :P [03:02:06] sigh [03:02:18] https://github.com/wikimedia/mediawiki-extensions-Echo/blob/master/includes/DiscussionParser.php#L847 [03:02:31] the < and > in that worries me [03:02:36] is this matching against html or wikitext? [03:02:50] wikitext, yea i'm not sure yet what the <> is about [03:03:17] wow, actually i bet that was me that broke that with the patch in core [03:03:27] this literally runs ~~~~ through the parser and attempts to tweak the output into a regex [03:04:02] i don't like the idea of generating a regex at all, tbh [03:04:13] neither do i, blame werda [03:04:17] this whole discussion parser is his doing :P [03:05:23] ebernhardson: i note that that appears to be just for the timestamp [03:05:56] err, yes it uses 5 ~. [03:06:09] so it's unsurprising that it's not matching wikilinks [03:06:22] its not supposed to, that part is the first half of determining a signature [03:06:39] echo splits the wikitext into lines, finds lines that match the timestamp regex, then looks for stuff in that line [03:06:51] so matching that timestamp regex is like saying "this kinda/sorta looks like a signature, check closer" [03:06:54] its a giant hack :( [03:07:08] ok, it is indeed the core change breaking it then [03:07:21] for now, just switch back to master in core, since we're probably going to lose it anyway [03:07:26] yea [03:07:34] i see what's going on, but it's probably not worth trying to fix [03:15:51] fwiw, MassMessage also uses that ~~~~ regex [03:16:04] I just copied it out of Echo. [03:18:05] why does MassMessage need that? [03:19:03] it warns the user if they didn't include a timestamp in their message [03:19:36] why not look for ~~~~ or ~~~~~ pre-PST? [03:20:10] because we also support people pasting in a raw timestamp [03:25:52] (03PS8) 10Anomie: API: Clean up and internationalize pretty-printed output [core] - 10https://gerrit.wikimedia.org/r/161093 (https://bugzilla.wikimedia.org/65403) [05:49:54] 3Wikimedia / 3lucene-search-2: Search index not updating on en.wikipedia - 10https://bugzilla.wikimedia.org/66011#c14 (10John C. Watson) How long should it take for the index of new primary search engine to update? (I made some edits over 24 hours ago, but the searches I just made have yet to "notice" them.) [06:29:02] 3Wikimedia / 3Extension setup: Enable extension Collection on svwikiversity - 10https://bugzilla.wikimedia.org/64994 (10Glaisher) 5NEW>3ASSI a:3Glaisher [06:29:52] 3MediaWiki extensions / 3TorBlock: Warning: Invalid argument supplied for foreach() in TorExitNodes.php on line 210 - 10https://bugzilla.wikimedia.org/69017#c4 (10Nemo) (In reply to Ori Livneh from comment #3) > Nemo, is this still an issue? If comment 2 is right, certainly yes; that patch has not been merg... [06:30:23] 3MediaWiki extensions / 3TorBlock: Warning: Invalid argument supplied for foreach() in TorExitNodes.php on line 210 - 10https://bugzilla.wikimedia.org/69017 (10Nemo) [06:36:53] (03PS1) 10Cscott: Treat 'zh' as if it were 'zh-Hans' (that is, use Simplified Chinese). [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/163332 [06:45:08] 3Wikimedia / 3Extension setup: Enable #lsth from Labeled Section Transclusion on pt.wikiversity - 10https://bugzilla.wikimedia.org/61804#c6 (10Glaisher) Since this is currently not enabled on any Wikimedia wiki, it probably needs to be reviewed before enabling? [07:22:31] (03PS10) 10Yurik: abstract CodeContent, reworked JsonContent [core] - 10https://gerrit.wikimedia.org/r/160575 [07:25:11] (03PS1) 10Ori.livneh: Fix handling of return value from mw.ustring.gsub callbacks [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/163334 (https://bugzilla.wikimedia.org/71045) [07:26:42] 3MediaWiki extensions / 3Lua: Undefined index: 0 in /UstringLibrary.php:638 - 10https://bugzilla.wikimedia.org/71045 (10Ori Livneh) a:5Fran Rogers>3Ori Livneh [07:32:51] (03PS3) 10Yurik: CSV content handler [core] - 10https://gerrit.wikimedia.org/r/160610 [07:37:08] 3MediaWiki extensions / 3Translate: [HHVM] phpunit assertion failure: in progress after first translation - 10https://bugzilla.wikimedia.org/68675#c2 (10Ori Livneh) Created attachment 16613 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16613&action=edit Log of successful test run with HHVM [07:37:16] 3MediaWiki extensions / 3Translate: [HHVM] phpunit assertion failure: in progress after first translation - 10https://bugzilla.wikimedia.org/68675 (10Ori Livneh) 5NEW>3RESO/WOR [07:59:32] (03PS1) 10Yurik: Added missing JsonFormat::parse() RELEASE NOTES, fixed docs [core] - 10https://gerrit.wikimedia.org/r/163335 [08:24:44] (03PS1) 10Umherirrender: Add test for class names in SpecialPageFactory::$list [core] - 10https://gerrit.wikimedia.org/r/163336 [08:26:25] (03CR) 10Umherirrender: "This should fail until the both patch sets from the commit messages are merged and this gets rebased." [core] - 10https://gerrit.wikimedia.org/r/163336 (owner: 10Umherirrender) [08:31:17] (03CR) 10jenkins-bot: [V: 04-1] Add test for class names in SpecialPageFactory::$list [core] - 10https://gerrit.wikimedia.org/r/163336 (owner: 10Umherirrender) [08:39:26] (03PS1) 10Umherirrender: Remove explict autoload from phpunit tests [core] - 10https://gerrit.wikimedia.org/r/163337 [08:40:31] (03CR) 10Nikerabbit: "https://he.wikipedia.org/wiki/%D7%9E%D7%99%D7%95%D7%97%D7%93:%D7%92%D7%A8%D7%A1%D7%94?uselang=he" [core] - 10https://gerrit.wikimedia.org/r/147733 (owner: 10Amire80) [08:45:27] 3MediaWiki / 3Interface: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277#c78 (10Erwin Dokter) Where will bullet.gif end up? Please don't tell me "it depends" or anything like that... Monobook (as does Common.css) still needs thi... [08:48:17] (03CR) 10Nikerabbit: [C: 032] Remove explict autoload from phpunit tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/163337 (owner: 10Umherirrender) [08:53:40] 3MediaWiki / 3Installer: mediawiki-1.23.4.patch tries to patch non-existent UploadBaseTest.php - 10https://bugzilla.wikimedia.org/71379 (10Rob Kam) 3UNCO p:3Unprio s:3major a:3None Intention: Trying to patch mediawiki 1.23.3 to mediawiki-1.23.4.patch. Steps to Reproduce: patch -p 1 --dry-run < media... [08:54:22] (03Merged) 10jenkins-bot: Remove explict autoload from phpunit tests [core] - 10https://gerrit.wikimedia.org/r/163337 (owner: 10Umherirrender) [09:06:15] 3MediaWiki / 3Interface: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277#c79 (10Erwin Dokter) Never mind... found it in /skins/MonoBook. [09:41:21] (03PS1) 10Umherirrender: Do not skip tests on setUp [core] - 10https://gerrit.wikimedia.org/r/163340 [09:44:17] (03PS1) 10Umherirrender: Skip MailAddressTest::testNewFromUser on windows [core] - 10https://gerrit.wikimedia.org/r/163341 [09:53:27] (03PS1) 10Umherirrender: Set content language for ContentHandlerTest::testGetAutosummary [core] - 10https://gerrit.wikimedia.org/r/163342 [10:00:00] 3MediaWiki extensions / 3WikidataRepo: Add ability to output objects instead of arrays for maps in WikibaseDataModelSerialization to not confuse them with lists when they are empty - 10https://bugzilla.wikimedia.org/70606 (10Jan Zerebecki) 5PATC>3RESO/FIX [10:05:48] (03PS1) 10Umherirrender: Fix GitInfoTest::testValidJsonData on windows [core] - 10https://gerrit.wikimedia.org/r/163343 [10:06:46] 3MediaWiki / 3General/Unknown: Edit by admin marked as [pending revision] - 10https://bugzilla.wikimedia.org/71369#c1 (10Redrose64) It is now showing as "[accepted revision]". The page history [2] shows that it was "accepted by Param Mudgal". Why was that extra step necessary? [2] http://en.wikipedia.org/w/... [10:21:31] (03PS1) 10Yurik: FormatJson::parse( TRY_FIXING ) - remove trailing commas [core] - 10https://gerrit.wikimedia.org/r/163344 [11:41:17] 3MediaWiki extensions / 3FlaggedRevs: Edit by admin marked as [pending revision] - 10https://bugzilla.wikimedia.org/71369 (10Andre Klapper) p:5Unprio>3Low [11:43:15] 3Wikimedia / 3Extension setup: Enable #lsth from Labeled Section Transclusion on pt.wikiversity - 10https://bugzilla.wikimedia.org/61804#c7 (10Andre Klapper) (In reply to Glaisher from comment #6) > Since this is currently not enabled on any Wikimedia wiki, it probably needs > to be reviewed before enabling?... [11:57:16] 3Wikimedia / 3Site requests: Please re-enable file upload function at noboard-chapters.wm.o - 10https://bugzilla.wikimedia.org/71367#c1 (10Andre Klapper) (In reply to Erlend Bjoertvedt from comment #0) > To be able to use this special page to upload to this wiki, an administrator > needs to add one or more l... [11:59:58] 3MediaWiki extensions / 3Nuke: Allow nuke to revert a mass delete - 10https://bugzilla.wikimedia.org/69933#c1 (10Helder) Real use case from yesterday, on Portuguese Wikipedia: https://pt.wikipedia.org/w/index.php?diff=40162059&oldid=40049699&uselang=en https://pt.wikipedia.org/w/index.php?diff=40158734&oldid... [12:04:31] (03CR) 10Parent5446: "Why? In what scenarios would we need to support invalid JSON?" [core] - 10https://gerrit.wikimedia.org/r/163344 (owner: 10Yurik) [12:23:31] 3MediaWiki / 3Interface: Newtalk status remains set even after viewing talk page - 10https://bugzilla.wikimedia.org/57840#c4 (10This, that and the other (TTO)) Is this still an issue for you? In cases like these you should always try disabling all extensions and see if the issue persists [12:43:05] 3Wikimedia / 3Extension setup: FlaggedRevs for Norwegian (bokmål) Wikipedia - 10https://bugzilla.wikimedia.org/64726#c36 (10jeblad) Outcome of voting over FlaggedRevs is in thread "Implementering av pending changes #2" [1], result in subthread "Resultat av avstemming" [2]. Of 29 votes 16 was for pending cha... [12:43:33] 3OCG / 3PDF renderer: Japanese-language texts on translated pages not rendered - 10https://bugzilla.wikimedia.org/71380 (10Yusuke Matsubara) 3NEW p:3Unprio s:3normal a:3None Japanese-language characters are rendered as tofu when I try to export a page translated into Japanese using the Translate exte... [12:46:59] 3OCG / 3PDF renderer: Japanese-language texts on translated pages not rendered - 10https://bugzilla.wikimedia.org/71380#c1 (10Yusuke Matsubara) Just to add: the description above is based on what I see on GNOME Document Viewer (evince) 3.10.3. [13:02:32] 3Wikimedia / 3Mailing lists: Create a mailing list for Maithili (mai) Wikipedia - 10https://bugzilla.wikimedia.org/44938#c8 (10John F. Lewis) 5RESO/INV>3REOP a:5Thehelpfulone>3John F. Lewis There has been an increase in activity. THO forwarded me an email regarding a reconsideration of this request,... [13:02:47] 3Wikimedia / 3Mailing lists: Create a mailing list for Maithili (mai) Wikipedia - 10https://bugzilla.wikimedia.org/44938 (10John F. Lewis) 5REOP>3ASSI [13:12:00] 3Wikimedia / 3Site requests: Disable miser mode ($wgMiserMode) on small wikis (wikis in small.dblist) - 10https://bugzilla.wikimedia.org/46098#c2 (10John F. Lewis) CCing Sean for a comment on the database load and viability of this. [13:21:31] 3OCG / 3PDF renderer: Japanese fonts on translated pages rendered as Tofu (square boxes) - 10https://bugzilla.wikimedia.org/71380 (10Andre Klapper) [13:27:18] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Duplicate of https://gerrit.wikimedia.org/r/#/c/130094/1 (bug 25141)." [core] - 10https://gerrit.wikimedia.org/r/163327 (https://bugzilla.wikimedia.org/71353) (owner: 10EBernhardson) [13:30:47] 3Wikimedia / 3Extension setup: Enable Extension:Education Program on Catalan Wikipedia - 10https://bugzilla.wikimedia.org/71381 (10Paucabot) 3NEW p:3Unprio s:3normal a:3None Please, enable this extension in catalan Wikipedia. We discussed this issue here: https://ca.wikipedia.org/wiki/Portal_Discuss... [13:31:15] 3Wikimedia / 3Extension setup: Enable Extension:Education Program on Catalan Wikipedia - 10https://bugzilla.wikimedia.org/71381 (10Paucabot) [13:43:05] (03CR) 10He7d3r: "Wikimedia Commons and Wikidata uses something similar for the talk link:" [core] - 10https://gerrit.wikimedia.org/r/130094 (https://bugzilla.wikimedia.org/25141) (owner: 10Gerrit Patch Uploader) [14:16:16] (03PS1) 10Jack Phoenix: No more legacy i18n (or $dir) [extensions/RandomUsersWithAvatars] - 10https://gerrit.wikimedia.org/r/163346 [14:17:50] (03CR) 10Jack Phoenix: [C: 032 V: 032] No more legacy i18n (or $dir) [extensions/RandomUsersWithAvatars] - 10https://gerrit.wikimedia.org/r/163346 (owner: 10Jack Phoenix) [14:22:46] 3Wikimedia / 3Site requests: Wikis waiting for creation (tracking) - 10https://bugzilla.wikimedia.org/16976 (10MF-Warburg) [14:22:48] 3Wikimedia / 3Site requests: Create Wikivoyage Persian - 10https://bugzilla.wikimedia.org/71382 (10MF-Warburg) 3NEW p:3Unprio s:3enhanc a:3None The language committee and WMF Board have approved the creation of Wikivoyage Persian. Language code: fa Site URL: fa.wikivoyage.org Project name: ویکی‌سفر... [14:24:17] (03PS1) 10Jack Phoenix: Fix htmlspecialchars() call [extensions/UserStatus] - 10https://gerrit.wikimedia.org/r/163347 [14:24:34] (03CR) 10Jack Phoenix: [C: 032 V: 032] Fix htmlspecialchars() call [extensions/UserStatus] - 10https://gerrit.wikimedia.org/r/163347 (owner: 10Jack Phoenix) [14:27:59] (03PS1) 10Jack Phoenix: Fix yet another bad htmlspecialchars() call [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/163348 [14:28:16] (03CR) 10Jack Phoenix: [C: 032 V: 032] Fix yet another bad htmlspecialchars() call [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/163348 (owner: 10Jack Phoenix) [14:30:16] (03PS1) 10Jack Phoenix: Aaaaand yet another botched htmlspecialchars() call fixed [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/163349 [14:30:35] (03CR) 10Jack Phoenix: [C: 032 V: 032] Aaaaand yet another botched htmlspecialchars() call fixed [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/163349 (owner: 10Jack Phoenix) [14:31:14] 3Wikimedia / 3lucene-search-2: Search index not updating on en.wikipedia - 10https://bugzilla.wikimedia.org/66011#c15 (10Chad H.) I'm not entirely sure as I hadn't managed to track down *all* of the problems with indexing, just some. There are many :( Some pages are definitely being updated: [[2014]] is now... [14:41:01] 3MediaWiki extensions / 3WikidataRepo: Repo UI for article badges - 10https://bugzilla.wikimedia.org/58990 (10Bene*) [14:41:01] 3MediaWiki extensions / 3WikidataRepo: special page for setting sitelinks needs to allow setting of badges - 10https://bugzilla.wikimedia.org/56693 (10Bene*) [14:41:59] 3MediaWiki extensions / 3WikidataRepo: Repo UI for article badges - 10https://bugzilla.wikimedia.org/58990 (10Bene*) [14:42:13] 3MediaWiki extensions / 3WikidataRepo: Redesign Item UI for Wikidata repo - 10https://bugzilla.wikimedia.org/52136 (10Bene*) [14:42:32] 3MediaWiki / 3Recent changes: Bot edits are shown in recent changes when bot posted on user talk page - 10https://bugzilla.wikimedia.org/69826#c1 (10Dan) 5UNCO>3RESO/DUP *** This bug has been marked as a duplicate of bug 61239 *** [14:42:32] 3MediaWiki / 3Recent changes: Sometimes edits by bots still show up on Recent changes and watchlist with hidebot=1 - 10https://bugzilla.wikimedia.org/61239#c6 (10Dan) *** Bug 69826 has been marked as a duplicate of this bug. *** [14:51:45] 3MediaWiki extensions / 3Scribunto: Undefined index: 0 in /UstringLibrary.php:638 - 10https://bugzilla.wikimedia.org/71045 (10Jackmcbarn) [14:53:00] 3MediaWiki extensions / 3WikidataRepo: Store the badges of sitelinks in a queryable format - 10https://bugzilla.wikimedia.org/70229#c1 (10Bene*) I think this should get higher priority because it blocks removal of the badge templates from some Wikipedias. I want some discussion in the development team first... [14:55:56] (03CR) 10Jackmcbarn: [C: 04-1] "Daniel's comment on PS8 still needs resolved." [core] - 10https://gerrit.wikimedia.org/r/160575 (owner: 10Yurik) [15:00:03] 3MediaWiki / 3Watchlist: Options to clean out watchlist of redirects and deleted pages - 10https://bugzilla.wikimedia.org/71383 (10Dan) 3UNCO p:3Unprio s:3enhanc a:3None It would be good to add a option in page [[Special:EditWatchlist]] to clean out watchlist by removing all pages which are redirects... [15:03:52] (03CR) 10Nikerabbit: "Hmm I can't think of any reason why we would keep this up to date manually. I can't avoid wondering that the script could probably generat" [core] - 10https://gerrit.wikimedia.org/r/163304 (owner: 10EBernhardson) [15:22:15] (03CR) 10Nikerabbit: Implement page status indicators (032 comments) [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [15:31:40] (03CR) 10Nikerabbit: [C: 031] "Code looks good. I currently don't have any legacy log entries to test this with." [core] - 10https://gerrit.wikimedia.org/r/151683 (owner: 10Umherirrender) [15:43:32] 3Wikimedia / 3General/Unknown: Global-rename which needs sysadmin's attention - 10https://bugzilla.wikimedia.org/71384 (10Revi) 3UNCO p:3Unprio s:3normal a:3None I have requested rename of my own account at [[m:SRUC#Hym411@global]], but [[m:Global rename policy]] states that "Without supervision of a... [15:45:45] 3Wikimedia / 3General/Unknown: Global-rename which needs sysadmin's attention - 10https://bugzilla.wikimedia.org/71384#c1 (10John F. Lewis) 5UNCO>3NEW p:5Unprio>3Normal +ops +hoo [15:55:44] (03PS1) 10Foxtrott: Fix comments; reorder methods in Component.php [skins/chameleon] - 10https://gerrit.wikimedia.org/r/163352 [15:56:35] (03CR) 10Foxtrott: [C: 032 V: 032] Fix comments; reorder methods in Component.php [skins/chameleon] - 10https://gerrit.wikimedia.org/r/163352 (owner: 10Foxtrott) [16:04:00] 3Wikimedia / 3General/Unknown: Global-rename which needs sysadmin's attention - 10https://bugzilla.wikimedia.org/71384#c2 (10Anatoliy Goncharov) Global renamers can rename such accounts but there may be problems like here: http://goo.gl/L87Q1R [16:04:14] 3MediaWiki extensions / 3FlaggedRevs: Edit by admin marked as [pending revision] - 10https://bugzilla.wikimedia.org/71369#c2 (10Jackmcbarn) 5NEW>3RESO/INV The revision was automatically accepted. It became unaccepted because another reviewer manually unaccepted it. See https://en.wikipedia.org/w/index.ph... [16:08:00] 3MediaWiki / 3Installer: mediawiki-1.23.4.patch tries to patch non-existent UploadBaseTest.php - 10https://bugzilla.wikimedia.org/71379#c1 (10Jackmcbarn) 5UNCO>3NEW Confirmed. [16:17:06] (03PS1) 10Amire80: Credits for en.json [extensions/Cite] - 10https://gerrit.wikimedia.org/r/163353 [16:17:17] 3MediaWiki / 3General/Unknown: Upgrade patches include changes to files under tests/ even though the tarball does not include these files - 10https://bugzilla.wikimedia.org/71379#c2 (10Jackmcbarn) p:5Unprio>3Normal s:5major>3normal The problem is that you installed 1.23.3 from a tarball, but the patc... [16:23:57] (03PS2) 10Amire80: Credits for en.json [extensions/Cite] - 10https://gerrit.wikimedia.org/r/163353 [16:23:59] (03PS1) 10Amire80: Convert spaces to tabs in en.json [extensions/Cite] - 10https://gerrit.wikimedia.org/r/163354 [16:32:07] (03CR) 10Arlolra: [C: 032] Fix redis gc. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163326 (owner: 10Cscott) [16:32:27] (03Merged) 10jenkins-bot: Fix redis gc. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/163326 (owner: 10Cscott) [16:36:54] (03CR) 10Yurik: "Whenever user edits json directly. In Zero, we frequently edit json content configurations, and trailing commas has been a huge annoyance," [core] - 10https://gerrit.wikimedia.org/r/163344 (owner: 10Yurik) [16:38:58] (03PS2) 10Jackmcbarn: Preserve log comment text field value across import attempts [core] - 10https://gerrit.wikimedia.org/r/149621 (https://bugzilla.wikimedia.org/16793) (owner: 10TTO) [16:48:26] (03CR) 10Jackmcbarn: [C: 031] "Tested, works, looks good except for one minor nitpick." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/149621 (https://bugzilla.wikimedia.org/16793) (owner: 10TTO) [16:54:33] (03PS1) 10Amire80: Code cleanup for phpcs [extensions/Cite] - 10https://gerrit.wikimedia.org/r/163357 [16:54:37] (03CR) 10Jackmcbarn: "Note that the sort of functionality being requested here is already used elsewhere in MediaWiki: For example, the links under the tagline " [core] - 10https://gerrit.wikimedia.org/r/154377 (https://bugzilla.wikimedia.org/27976) (owner: 10Helder.wiki) [16:56:04] (03CR) 10Jackmcbarn: [C: 04-1] "Needs rebase." [core] - 10https://gerrit.wikimedia.org/r/155692 (owner: 10Legoktm) [16:57:22] (03PS2) 10Amire80: Code cleanup for phpcs [extensions/Cite] - 10https://gerrit.wikimedia.org/r/163357 [17:07:01] 3Wikimedia / 3Mailing lists: Create a mailing list for Maithili (mai) Wikipedia - 10https://bugzilla.wikimedia.org/44938#c9 (10Rajesh Ranjan) (In reply to John F. Lewis from comment #8) > There has been an increase in activity. > > THO forwarded me an email regarding a reconsideration of this request, I > p... [17:18:15] (03CR) 10Jackmcbarn: [C: 031] "Looks good, one question." (031 comment) [extensions/Cite] - 10https://gerrit.wikimedia.org/r/163357 (owner: 10Amire80) [17:20:47] (03CR) 10Amire80: Code cleanup for phpcs (031 comment) [extensions/Cite] - 10https://gerrit.wikimedia.org/r/163357 (owner: 10Amire80) [17:45:16] 3Wikimedia / 3Site requests: Please re-enable file upload function at noboard-chapters.wm.o - 10https://bugzilla.wikimedia.org/71367#c2 (10Glaisher) 5UNCO>3RESO/INV Just create https://noboard-chapters.wikimedia.org/wiki/MediaWiki:Licenses and local uploading would be enabled. This happened due to a chan... [17:47:21] 3Wikimedia / 3General/Unknown: Intermittent 403s when using HHVM - 10https://bugzilla.wikimedia.org/71385 (10Jackmcbarn) 3NEW p:3Unprio s:3normal a:3None The image https://en.wikipedia.org/w/skins/Vector/images/arrow-expanded.svg and others intermittently 403 when the HHVM cookie is set. [17:55:15] 3MediaWiki / 3Internationalization: parser tags such as , , etc. cannot be localized - 10https://bugzilla.wikimedia.org/28980 (10Amir E. Aharoni) [17:55:18] 3MediaWiki / 3Parser: the Sanitizer allows only ASCII and a some punctuation in extension tag attributes - 10https://bugzilla.wikimedia.org/71386 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None I took a stab at resolving Bug 28980 and adding a non-ASCII tag name. This was surprisingly easy unti... [18:08:42] (03PS1) 10Jackmcbarn: Throw an exception if LuaSandboxFunction::call returns false [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/163359 (https://bugzilla.wikimedia.org/71045) [18:10:32] (03CR) 10Jackmcbarn: [C: 04-1] "Per discussion on IRC, this is covering up the problem rather than fixing it." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/163334 (https://bugzilla.wikimedia.org/71045) (owner: 10Ori.livneh) [18:16:26] (03CR) 10Robert Vogel: [C: 032] [WIP] Stub implementation [extensions/Teahouse] - 10https://gerrit.wikimedia.org/r/159371 (owner: 10Robert Vogel) [18:16:38] (03CR) 10Robert Vogel: [V: 032] [WIP] Stub implementation [extensions/Teahouse] - 10https://gerrit.wikimedia.org/r/159371 (owner: 10Robert Vogel) [18:17:32] (03CR) 10Robert Vogel: [C: 032 V: 032] Removed dependency [skins/BlueSpiceSkin] (REL1_22) - 10https://gerrit.wikimedia.org/r/161220 (owner: 10Swidmann) [18:22:12] (03PS1) 10IAlex: Remove executable bit from non-executable files [core] - 10https://gerrit.wikimedia.org/r/163377 [18:23:18] (03CR) 10Ori.livneh: [C: 031] "Looks good to me. I'm going to cherry-pick this to the production branches so we can start capturing traces for this issue, but I'm leavin" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/163359 (https://bugzilla.wikimedia.org/71045) (owner: 10Jackmcbarn) [18:24:23] (03PS1) 10Ori.livneh: Throw an exception if LuaSandboxFunction::call returns false [extensions/Scribunto] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/163378 (https://bugzilla.wikimedia.org/71045) [18:25:05] (03CR) 10Ori.livneh: [C: 032] Throw an exception if LuaSandboxFunction::call returns false [extensions/Scribunto] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/163378 (https://bugzilla.wikimedia.org/71045) (owner: 10Ori.livneh) [18:25:57] (03PS1) 10Ori.livneh: Throw an exception if LuaSandboxFunction::call returns false [extensions/Scribunto] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/163389 (https://bugzilla.wikimedia.org/71045) [18:27:07] (03CR) 10Ori.livneh: [C: 032] Throw an exception if LuaSandboxFunction::call returns false [extensions/Scribunto] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/163389 (https://bugzilla.wikimedia.org/71045) (owner: 10Ori.livneh) [18:28:16] (03Merged) 10jenkins-bot: Throw an exception if LuaSandboxFunction::call returns false [extensions/Scribunto] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/163378 (https://bugzilla.wikimedia.org/71045) (owner: 10Ori.livneh) [18:30:08] (03Merged) 10jenkins-bot: Throw an exception if LuaSandboxFunction::call returns false [extensions/Scribunto] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/163389 (https://bugzilla.wikimedia.org/71045) (owner: 10Ori.livneh) [18:30:17] (03PS1) 10Ori.livneh: Update Scribunto for I7185e186d [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/163419 [18:31:24] (03PS1) 10Ori.livneh: Update Scribunto for I7185e186d [core] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/163429 [18:31:53] (03CR) 10Bartosz Dziewoński: [C: 032] "Grumble, why do we not have a CI check for this yet?" [core] - 10https://gerrit.wikimedia.org/r/163377 (owner: 10IAlex) [18:31:55] (03CR) 10Ori.livneh: [C: 032 V: 032] Update Scribunto for I7185e186d [core] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/163429 (owner: 10Ori.livneh) [18:33:26] (03CR) 10Ori.livneh: [C: 032 V: 032] Update Scribunto for I7185e186d [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/163419 (owner: 10Ori.livneh) [18:34:17] 3MediaWiki extensions / 3[other]: Semantic results format gallery captionproperty - 10https://bugzilla.wikimedia.org/71387 (10Papaver Josepherum) 3UNCO p:3Unprio s:3normal a:3None Some issues I am finding with MW 1.23, SMW 2.0, SRF 1.9: Text properties containing wikitext are not parsed as expected... [18:38:20] (03Abandoned) 10IAlex: Coding standard fixes in SpecialChangeEmail.php [core] - 10https://gerrit.wikimedia.org/r/160919 (owner: 10IAlex) [18:38:49] (03Merged) 10jenkins-bot: Remove executable bit from non-executable files [core] - 10https://gerrit.wikimedia.org/r/163377 (owner: 10IAlex) [18:49:01] (03PS1) 10IAlex: Remove dead code after removal of cancel button on Special:ChangeEmail [core] - 10https://gerrit.wikimedia.org/r/163447 [18:53:19] 3MediaWiki extensions / 3[other]: Semantic results format gallery captionproperty - 10https://bugzilla.wikimedia.org/71387#c1 (10Papaver Josepherum) [Edit: captionproperty when set as a semantic property for (example, captionproperty=Caption, a text type) will return a caption below the image in the Special:... [18:54:15] 3Wikimedia / 3Site requests: request www.soumaya.com.mx be added to Glamwiki Toolset domain whitelist - 10https://bugzilla.wikimedia.org/70986#c4 (10jeremyb) FWIW, apparently they launched a new website and it does look substantially different. but it's IIS :-(((( [18:56:30] 3MediaWiki / 3General/Unknown: Upgrade patches include changes to files under tests/ even though the tarball does not include these files - 10https://bugzilla.wikimedia.org/71379#c3 (10Rob Kam) Thanks. [19:03:00] 3Wikimedia / 3Site requests: request www.soumaya.com.mx be added to Glamwiki Toolset domain whitelist - 10https://bugzilla.wikimedia.org/70986#c5 (10Liam Wyatt) (In reply to jeremyb from comment #4) > FWIW, apparently they launched a new website and it does look substantially > different. but it's IIS :-((((... [19:27:03] (03CR) 10Bartosz Dziewoński: [C: 032] "Weird, I can see the issue on he.wp, but I can't on my local wiki with uselang=he. Oh well." [core] - 10https://gerrit.wikimedia.org/r/147733 (owner: 10Amire80) [19:27:25] (03CR) 10Parent5446: [C: 032] FormatJson::parse( TRY_FIXING ) - remove trailing commas (031 comment) [core] - 10https://gerrit.wikimedia.org/r/163344 (owner: 10Yurik) [19:28:57] (03CR) 10Parent5446: [C: 032] Remove dead code after removal of cancel button on Special:ChangeEmail [core] - 10https://gerrit.wikimedia.org/r/163447 (owner: 10IAlex) [19:30:59] 3Wikimedia / 3Mailing lists: Create a mailing list for Maithili (mai) Wikipedia - 10https://bugzilla.wikimedia.org/44938#c10 (10Muzammil) (In reply to John F. Lewis from comment #8) > There has been an increase in activity. > > THO forwarded me an email regarding a reconsideration of this request, I > perso... [19:33:26] (03Merged) 10jenkins-bot: Bidi-isolate extension version on Special:Version [core] - 10https://gerrit.wikimedia.org/r/147733 (owner: 10Amire80) [19:33:29] 3Wikimedia / 3Extension setup: Enable Extension:Education Program on Catalan Wikipedia - 10https://bugzilla.wikimedia.org/71381 (10Paucabot) p:5Unprio>3Normal [19:33:35] (03Merged) 10jenkins-bot: FormatJson::parse( TRY_FIXING ) - remove trailing commas [core] - 10https://gerrit.wikimedia.org/r/163344 (owner: 10Yurik) [19:35:12] (03Merged) 10jenkins-bot: Remove dead code after removal of cancel button on Special:ChangeEmail [core] - 10https://gerrit.wikimedia.org/r/163447 (owner: 10IAlex) [19:35:32] (03PS1) 10Robert Vogel: [WIP] Implemented "Ask a question" link [extensions/Teahouse] - 10https://gerrit.wikimedia.org/r/163449 [19:36:22] (03CR) 10Robert Vogel: [C: 032 V: 032] [WIP] Implemented "Ask a question" link [extensions/Teahouse] - 10https://gerrit.wikimedia.org/r/163449 (owner: 10Robert Vogel) [19:42:07] (03CR) 10He7d3r: "Exactly" [core] - 10https://gerrit.wikimedia.org/r/154377 (https://bugzilla.wikimedia.org/27976) (owner: 10Helder.wiki) [20:10:54] (03PS5) 10IAlex: Replace $wgConf->localVHosts by $wgLocalVirtualHosts [core] - 10https://gerrit.wikimedia.org/r/157712 [20:24:29] (03CR) 10Jackmcbarn: "Haven't tested or looked closely yet." (036 comments) [core] - 10https://gerrit.wikimedia.org/r/160798 (https://bugzilla.wikimedia.org/30936) (owner: 10Anomie) [20:32:36] aharoni: i'd +2 your phpcs change now, but i notice there's an unmerged commit it depends on [20:32:58] yes, and it's even easier [20:33:25] and that dependency also has a dependency... [20:33:56] (03CR) 10Jackmcbarn: [C: 032] Convert spaces to tabs in en.json [extensions/Cite] - 10https://gerrit.wikimedia.org/r/163354 (owner: 10Amire80) [20:34:08] (03Merged) 10jenkins-bot: Convert spaces to tabs in en.json [extensions/Cite] - 10https://gerrit.wikimedia.org/r/163354 (owner: 10Amire80) [20:34:56] aharoni: where'd the credits list come from? [20:35:05] git log, git blame [20:39:59] (03CR) 10Jackmcbarn: [C: 032] Credits for en.json [extensions/Cite] - 10https://gerrit.wikimedia.org/r/163353 (owner: 10Amire80) [20:40:09] (03Merged) 10jenkins-bot: Credits for en.json [extensions/Cite] - 10https://gerrit.wikimedia.org/r/163353 (owner: 10Amire80) [20:41:09] (03CR) 10Jackmcbarn: [C: 032] Code cleanup for phpcs [extensions/Cite] - 10https://gerrit.wikimedia.org/r/163357 (owner: 10Amire80) [20:41:20] (03Merged) 10jenkins-bot: Code cleanup for phpcs [extensions/Cite] - 10https://gerrit.wikimedia.org/r/163357 (owner: 10Amire80) [20:44:33] 3MediaWiki extensions / 3FlaggedRevs: Edit by admin marked as [pending revision] - 10https://bugzilla.wikimedia.org/71369#c3 (10Redrose64) OK thanks. I guess I need to ask that person why they unaccepted it. [20:44:43] jackmcbarn: thanks! [20:44:47] np [21:41:00] 3MediaWiki extensions / 3[other]: Semantic results format gallery captionproperty - 10https://bugzilla.wikimedia.org/71387#c2 (10Papaver Josepherum) 5UNCO>3RESO/WOR Nevermind, it seems a stray ?# in my query was messing up the result.. All of these issues are resolved upon removal of the condition. [21:54:29] (03PS1) 10Foxtrott: Introduce Modifications [skins/chameleon] - 10https://gerrit.wikimedia.org/r/163451 [22:10:18] (03PS2) 10Foxtrott: Introduce concept of Modifications [skins/chameleon] - 10https://gerrit.wikimedia.org/r/163451 [22:20:12] (03PS3) 10Foxtrott: Introduce concept of Modifications [skins/chameleon] - 10https://gerrit.wikimedia.org/r/163451 [22:21:25] (03CR) 10Foxtrott: [C: 032 V: 032] Introduce concept of Modifications [skins/chameleon] - 10https://gerrit.wikimedia.org/r/163451 (owner: 10Foxtrott) [22:23:24] (03PS12) 10Amire80: Support setting column-width and mode in tag [extensions/Cite] - 10https://gerrit.wikimedia.org/r/120962 (https://bugzilla.wikimedia.org/51260) (owner: 10Alex Monk) [22:28:50] (03PS1) 10Jackmcbarn: Update CREDITS [core] - 10https://gerrit.wikimedia.org/r/163452 [22:29:01] really easy merge. any takers? ^ [22:53:07] (03CR) 10Ori.livneh: [C: 032] Update CREDITS [core] - 10https://gerrit.wikimedia.org/r/163452 (owner: 10Jackmcbarn) [22:59:17] (03Merged) 10jenkins-bot: Update CREDITS [core] - 10https://gerrit.wikimedia.org/r/163452 (owner: 10Jackmcbarn) [23:28:14] 3Wikimedia / 3General/Unknown: Intermittent 403s when using HHVM - 10https://bugzilla.wikimedia.org/71385#c1 (10Chad H.) p:5Unprio>3High s:5normal>3major Confirmed here, raising priority + severity. [23:47:30] 3Wikimedia / 3General/Unknown: Intermittent 403s when using HHVM - 10https://bugzilla.wikimedia.org/71385#c2 (10Ori Livneh) Confirmed; it's mw1018, specifically, and it issues a 403 regardless of whether or not the HHVM cookie is set. [23:50:39] (03CR) 10Yurik: FormatJson::parse( TRY_FIXING ) - remove trailing commas (031 comment) [core] - 10https://gerrit.wikimedia.org/r/163344 (owner: 10Yurik) [23:52:45] (03PS2) 10Jackmcbarn: Fix case of SpecialShortPages in SpecialPageFactory [core] - 10https://gerrit.wikimedia.org/r/163276 (owner: 10Umherirrender) [23:52:53] (03CR) 10Jackmcbarn: [C: 032] Fix case of SpecialShortPages in SpecialPageFactory [core] - 10https://gerrit.wikimedia.org/r/163276 (owner: 10Umherirrender) [23:53:11] from zuul: ETA: unknown, queued -1 hr -1 min ago [23:58:57] (03PS2) 10Yurik: Added missing JsonFormat::parse() RELEASE NOTES, fixed docs [core] - 10https://gerrit.wikimedia.org/r/163335 [23:59:06] parent5446, ^ [23:59:15] (03Merged) 10jenkins-bot: Fix case of SpecialShortPages in SpecialPageFactory [core] - 10https://gerrit.wikimedia.org/r/163276 (owner: 10Umherirrender)