[00:02:46] (03PS2) 10Jdlrobson: Special:BookSources Add global [core] - 10https://gerrit.wikimedia.org/r/162512 (owner: 10Prtksxna) [00:02:52] (03PS1) 10Prtksxna: buttons: Update focus state [core] - 10https://gerrit.wikimedia.org/r/162514 (https://bugzilla.wikimedia.org/62924) [00:02:58] (03CR) 10Jdlrobson: [C: 032] Special:BookSources Add global [core] - 10https://gerrit.wikimedia.org/r/162512 (owner: 10Prtksxna) [00:03:00] (03PS1) 10Prtksxna: buttons: Update focus for quiet buttons [core] - 10https://gerrit.wikimedia.org/r/162515 (https://bugzilla.wikimedia.org/62924) [00:03:55] (03CR) 10Jdlrobson: [C: 031] "Shahyar: Okay I didn't realise that IE6 worked that way - it's been a while. I updated the comment to document this better (at least for m" [core] - 10https://gerrit.wikimedia.org/r/155856 (https://bugzilla.wikimedia.org/69212) (owner: 10SG) [00:04:37] 3MediaWiki / 3MediaWiki UI: Have mediawiki.ui buttons show focus in a clear and accessible way - 10https://bugzilla.wikimedia.org/62924#c13 (10Jared Zimmerman (WMF)) Depending on the browser/platform that could render differently than having it draw the correct color, but arrive at that color programmatically [00:06:23] 3MediaWiki / 3MediaWiki UI: Dimensions of checkboxes are defined in pixels and margins are not to spec - 10https://bugzilla.wikimedia.org/70133 (10Jon) 5PATC>3RESO/FIX [00:06:26] (03CR) 10Reedy: "So why did the tests pass before, but not now?" [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135289 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [00:07:27] chrismcmahon: Is image embedding broken on beta labs? [00:08:31] guess I'll check bugzilla [00:08:54] (btw hi kaldari|2 and hope you are doing well) [00:09:51] kaldari|2: not to my knowledge, but anything is possible. got a link? [00:10:11] (03Merged) 10jenkins-bot: Special:BookSources Add global [core] - 10https://gerrit.wikimedia.org/r/162512 (owner: 10Prtksxna) [00:11:41] 3MediaWiki / 3MediaWiki UI: Update disabled state for buttons - 10https://bugzilla.wikimedia.org/71209 (10Prateek Saxena) 3NEW p:3Unprio s:3normal a:3None Created attachment 16571 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16571&action=edit buttons-disabled Update the buttons styling to... [00:11:42] 3MediaWiki / 3MediaWiki UI: Update disabled state for buttons - 10https://bugzilla.wikimedia.org/71209 (10Prateek Saxena) a:3Prateek Saxena [00:16:52] 3MediaWiki / 3MediaWiki UI: Update disabled state for buttons - 10https://bugzilla.wikimedia.org/71209 (10Prateek Saxena) [00:17:07] 3MediaWiki / 3MediaWiki UI: Remove $wgUseMediaWikiUIEverywhere dependency for button and input styling (tracking) - 10https://bugzilla.wikimedia.org/70913 (10Prateek Saxena) [00:17:24] (03CR) 10Mattflaschen: "FWIW, I am okay with a class approach. I don't feel so strongly pro-mixin that I prefer not having it in core at all." [core] - 10https://gerrit.wikimedia.org/r/151792 (owner: 10Jdlrobson) [00:18:40] 3Wikimedia / 3Apache configuration: Make it possible to quickly and programmaticly pool and depool application servers - 10https://bugzilla.wikimedia.org/71211 (10Ori Livneh) 3NEW p:3Unprio s:3normal a:3None HHVM takes more time to initialize than PHP5, because it needs to translate PHP to byte code,... [00:18:54] 3MediaWiki / 3Installer: Stress the importance of a cache during install (APC or memcached) - 10https://bugzilla.wikimedia.org/34236 (10Sumana Harihareswara) [00:18:57] 3Wikimedia / 3Apache configuration: Make it possible to quickly and programmaticly pool and depool application servers - 10https://bugzilla.wikimedia.org/71212 (10Ori Livneh) 3NEW p:3Unprio s:3normal a:3None HHVM takes more time to initialize than PHP5, because it needs to translate PHP to byte code,... [00:19:06] (03CR) 10Isarra: "Loading something that important with js does not seem like a good idea. Having a conditional somewhere in the skin itself or something to" [core] - 10https://gerrit.wikimedia.org/r/160797 (owner: 10Anomie) [00:19:12] (03CR) 10Aaron Schulz: Add script to make a list of users who will be renamed (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159266 (owner: 10Legoktm) [00:20:39] 3Wikimedia / 3Apache configuration: Make it possible to quickly and programmaticly pool and depool application servers - 10https://bugzilla.wikimedia.org/71212#c1 (10Ori Livneh) *** Bug 71211 has been marked as a duplicate of this bug. *** [00:20:39] 3Wikimedia / 3Apache configuration: Make it possible to quickly and programmaticly pool and depool application servers - 10https://bugzilla.wikimedia.org/71211#c1 (10Ori Livneh) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 71212 *** [00:22:03] (03CR) 10Legoktm: "Please please please do not introduce new uses of global variables like this. The Config interfaces should be used instead." [core] - 10https://gerrit.wikimedia.org/r/162145 (https://bugzilla.wikimedia.org/71145) (owner: 10Prtksxna) [00:22:40] prtksxna: $this->getConfig()->get( 'UseMediaWikiUIEverywhere' ); [00:23:08] legoktm: Oh, so I don't have 'global' then? [00:23:25] no [00:23:49] legoktm: Sorry about that :( [00:23:50] legoktm: I'll submit follow up patches [00:23:56] thanks [00:24:52] legoktm: I am just going to add you as a review to ALL my patches [00:24:57] dealwithit [00:25:02] lol ok :D [00:25:55] legoktm: -1 this too https://gerrit.wikimedia.org/r/#/c/162509/ [00:26:13] (03PS1) 10Aaron Schulz: Fixed bug in BloomCacheRedis::getConnection [core] - 10https://gerrit.wikimedia.org/r/162516 [00:26:15] ori: ^ [00:26:38] (03CR) 10Legoktm: [C: 04-1] HtmlForm: Use mw-ui-checkbox only if wgUseMediaWikiUIEverywhere is enabled (031 comment) [core] - 10https://gerrit.wikimedia.org/r/162509 (owner: 10Prtksxna) [00:26:44] (03CR) 10Mattflaschen: "Sorry if I jumped the gun. I've removed the -1." [core] - 10https://gerrit.wikimedia.org/r/161261 (https://bugzilla.wikimedia.org/70909) (owner: 10Prtksxna) [00:26:48] (03CR) 10Ori.livneh: [C: 032] Fixed bug in BloomCacheRedis::getConnection [core] - 10https://gerrit.wikimedia.org/r/162516 (owner: 10Aaron Schulz) [00:27:09] 3MediaWiki-Vagrant: /usr/lib/hphp/hphpize/hphpize.cmake has /root/hhvm/joe/hhvm in HHVM_INCLUDE_DIRS - 10https://bugzilla.wikimedia.org/71177#c1 (10Bryan Davis) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 68944 *** [00:30:37] (03CR) 10Yaron Koren: "Hi - I don't know; I haven't really thought about it. At the very least, I would probably make the change myself after merging in the code" [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [00:32:01] (03PS1) 10Prtksxna: Special:BookSources: Use getConfig instead of Global [core] - 10https://gerrit.wikimedia.org/r/162518 [00:32:09] legoktm: Is that all ^ [00:32:38] 3MediaWiki / 3MediaWiki UI: Create primary button with indeterminate loader - 10https://bugzilla.wikimedia.org/70417 (10Kunal Mehta (Legoktm)) [00:32:38] 3Wikimedia / 3Site requests: Change $wgPasswordDefault to PBKDF2 on WMF wikis - 10https://bugzilla.wikimedia.org/68766 (10Kunal Mehta (Legoktm)) [00:32:53] 3Wikimedia / 3General/Unknown: Deploy HHVM for all users - 10https://bugzilla.wikimedia.org/70418 (10Kunal Mehta (Legoktm)) [00:33:03] (03Merged) 10jenkins-bot: Fixed bug in BloomCacheRedis::getConnection [core] - 10https://gerrit.wikimedia.org/r/162516 (owner: 10Aaron Schulz) [00:33:17] (03CR) 10Legoktm: [C: 032] "Thanks!" [core] - 10https://gerrit.wikimedia.org/r/162518 (owner: 10Prtksxna) [00:33:22] yup! [00:33:49] (03PS3) 10Prtksxna: HtmlForm: Use mw-ui-checkbox only if wgUseMediaWikiUIEverywhere is enabled [core] - 10https://gerrit.wikimedia.org/r/162509 [00:34:50] legoktm: Its being used at a couple of other places too [00:34:58] legoktm: I'll submit a single patch to replace it though :\ [00:35:06] in special pages? [00:36:15] legoktm: Yes, I think so, I'll just grep [00:36:43] :D [00:36:53] 3Wikimedia / 3Apache configuration: Make it possible to quickly and programmaticly pool and depool application servers - 10https://bugzilla.wikimedia.org/71212#c2 (10Bryan Davis) p:5Unprio>3Normal Adding hhvm keyword. This is not directly related to the HHVM code base but it is an important component for... [00:39:50] (03Merged) 10jenkins-bot: Special:BookSources: Use getConfig instead of Global [core] - 10https://gerrit.wikimedia.org/r/162518 (owner: 10Prtksxna) [00:39:58] (03CR) 10jenkins-bot: [V: 04-1] HtmlForm: Use mw-ui-checkbox only if wgUseMediaWikiUIEverywhere is enabled [core] - 10https://gerrit.wikimedia.org/r/162509 (owner: 10Prtksxna) [00:41:07] 3Wikimedia / 3General/Unknown: Deploy HHVM for all users - 10https://bugzilla.wikimedia.org/70418#c6 (10Bryan Davis) This is a tracking bug without the tracking keyword that is not blocking any other bugs. Can we resolve to resolve it? [00:43:25] 3MediaWiki extensions / 3CentralAuth: Request global account rename from home wiki before forced SUL name change - 10https://bugzilla.wikimedia.org/68886 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX [00:47:15] (03CR) 10Mattflaschen: "Question inline about self::$features" (031 comment) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/159538 (https://bugzilla.wikimedia.org/69823) (owner: 10Jforrester) [00:48:56] Krenair: Number.parseInt? [00:49:02] https://gerrit.wikimedia.org/r/#/c/150391/3 [00:50:23] (03CR) 10Krinkle: [C: 04-1] "Number.parseInt is non-standard, use parseInt." [core] - 10https://gerrit.wikimedia.org/r/150391 (https://bugzilla.wikimedia.org/53058) (owner: 10Alex Monk) [00:51:02] oops [00:51:36] 3MediaWiki / 3Installer: Provide default time zone selection in installer - 10https://bugzilla.wikimedia.org/19991 (10Sumana Harihareswara) [00:56:36] (03PS1) 10Isarra: Convert i18n to json [skins/Splash] - 10https://gerrit.wikimedia.org/r/162519 [00:58:09] (03PS4) 10Alex Monk: Make mediawiki.action.view.dblClickEdit recheck preference [core] - 10https://gerrit.wikimedia.org/r/150391 (https://bugzilla.wikimedia.org/53058) [00:58:21] (03CR) 10Isarra: [C: 032] "Seems to work. LU LU LU." [skins/Splash] - 10https://gerrit.wikimedia.org/r/162519 (owner: 10Isarra) [00:58:39] (03Merged) 10jenkins-bot: Convert i18n to json [skins/Splash] - 10https://gerrit.wikimedia.org/r/162519 (owner: 10Isarra) [00:58:54] (03PS1) 10Chad: Remove old i18n fallback. We don't support anything below 1.23 anyway [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/162522 [00:58:58] (03CR) 10Isarra: "Oh, do I actually have to verify here? This is all bizarro." [skins/Splash] - 10https://gerrit.wikimedia.org/r/162519 (owner: 10Isarra) [00:59:10] (03CR) 10Isarra: "Oh, fine, bloody slow thingy." [skins/Splash] - 10https://gerrit.wikimedia.org/r/162519 (owner: 10Isarra) [00:59:25] (03CR) 10Isarra: "THING." [skins/Splash] - 10https://gerrit.wikimedia.org/r/162519 (owner: 10Isarra) [00:59:53] 3MediaWiki / 3ResourceLoader: LESS compiler should preserve the position of CSSMin / CSSJanus annotations - 10https://bugzilla.wikimedia.org/54673#c13 (10Matthew Flaschen) Considering Bartosz's patch (https://gerrit.wikimedia.org/r/#/c/161245/) solved this in a different way, and this is an upstream (lessphp... [00:59:57] (03PS2) 10Ori.livneh: Slave lag check tweaks to JobRunner [core] - 10https://gerrit.wikimedia.org/r/161749 (owner: 10Aaron Schulz) [01:00:01] (03CR) 10Ori.livneh: [C: 032] Slave lag check tweaks to JobRunner [core] - 10https://gerrit.wikimedia.org/r/161749 (owner: 10Aaron Schulz) [01:00:18] (03CR) 10Legoktm: [C: 04-1] "Need to also remove the $wgExtensionMessagesFiles entry." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/162522 (owner: 10Chad) [01:00:54] 3MediaWiki / 3ResourceLoader: LESS compiler should preserve the position of CSSMin / CSSJanus annotations - 10https://bugzilla.wikimedia.org/54673 (10Krinkle) 5NEW>3RESO/WON [01:03:38] 3MediaWiki / 3Uploading: Can't upload file with non-ASCII name (eg cyrillic) on Windows host - 10https://bugzilla.wikimedia.org/1780 (10Sumana Harihareswara) [01:04:58] (03CR) 10jenkins-bot: [V: 04-1] Make mediawiki.action.view.dblClickEdit recheck preference [core] - 10https://gerrit.wikimedia.org/r/150391 (https://bugzilla.wikimedia.org/53058) (owner: 10Alex Monk) [01:06:38] (03Merged) 10jenkins-bot: Slave lag check tweaks to JobRunner [core] - 10https://gerrit.wikimedia.org/r/161749 (owner: 10Aaron Schulz) [01:07:09] 3MediaWiki / 3User preferences: Changes to user preferences should be automatically saved - 10https://bugzilla.wikimedia.org/56561#c7 (10Matthew Flaschen) (In reply to Jared Zimmerman (WMF) from comment #6) > would submitting the whole form give us bad data in our preference logging > schema? e.g. would we b... [01:10:52] 3MediaWiki / 3Interface: Set $wgUseTwoButtonsSearchForm = false by default - 10https://bugzilla.wikimedia.org/40622#c11 (10Trevor Parscal) As stated, we should move away from having a "Go" button. Also, please notice that the search suggestions for Monobook are now the same as Vector, so they contain both ex... [01:11:07] 3MediaWiki / 3MediaWiki UI: checkboxes hover, focus, and click states are not to spec - 10https://bugzilla.wikimedia.org/70909 (10Matthew Flaschen) [01:11:34] (03PS2) 10Aaron Schulz: Randomize the JobRunner slave lags checks a bit [core] - 10https://gerrit.wikimedia.org/r/161577 [01:12:22] (03PS3) 10Aaron Schulz: Limit active DB connections spawned in waitForAll() to one [core] - 10https://gerrit.wikimedia.org/r/161500 [01:13:39] (03CR) 10Ori.livneh: [C: 032] Randomize the JobRunner slave lags checks a bit [core] - 10https://gerrit.wikimedia.org/r/161577 (owner: 10Aaron Schulz) [01:13:52] (03CR) 10Aaron Schulz: [C: 04-1] Add script to make a list of users who will be renamed [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159266 (owner: 10Legoktm) [01:14:41] (03PS5) 10Alex Monk: Make mediawiki.action.view.dblClickEdit recheck preference [core] - 10https://gerrit.wikimedia.org/r/150391 (https://bugzilla.wikimedia.org/53058) [01:17:22] 3MediaWiki / 3Database: Image and oldimage tables lack auto-incrementing primary keys - 10https://bugzilla.wikimedia.org/71198#c2 (10Nathan Larson) Aaron, I notice you were the one who added that TODO. What did you have in mind, adding an img_id field and an oi_img_id field? So then, an image entry with img_... [01:17:40] 3MediaWiki / 3Interface: Set $wgUseTwoButtonsSearchForm = false by default - 10https://bugzilla.wikimedia.org/40622#c12 (10Daniel Friesen) (In reply to Trevor Parscal from comment #11) > 2. We drop the advanced search button, since we have it through the > suggestions. If we must keep it, it needs to actuall... [01:18:22] 3MediaWiki / 3MediaWiki UI: Remove $wgUseMediaWikiUIEverywhere dependency for button and text input styling (tracking) - 10https://bugzilla.wikimedia.org/70913 (10Matthew Flaschen) [01:19:52] 3MediaWiki / 3Internationalization: Math expressions in RTL wikis should have LTR alignment - 10https://bugzilla.wikimedia.org/30630 (10Sumana Harihareswara) [01:20:26] (03CR) 10Aaron Schulz: [C: 032] MediaWikiTestCase: Centralise insertPage() logic from SearchEngineTest [core] - 10https://gerrit.wikimedia.org/r/161139 (owner: 10Krinkle) [01:20:36] (03Merged) 10jenkins-bot: Randomize the JobRunner slave lags checks a bit [core] - 10https://gerrit.wikimedia.org/r/161577 (owner: 10Aaron Schulz) [01:21:22] 3MediaWiki / 3MediaWiki UI: Set $wgUseMediaWikiUIEverywhere = true (tracking) - 10https://bugzilla.wikimedia.org/70424 (10Matthew Flaschen) [01:21:24] 3MediaWiki extensions / 3BetaFeatures: Use HTMLCheckField and remove NewHTMLCheckField - 10https://bugzilla.wikimedia.org/71215 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3None Since core's HTMLCheckField now has support for styled checkboxes (but only if $wgUseMediaWikiUIEverywhere is true), Ne... [01:25:37] 3MediaWiki / 3Special pages: Inverse selection for [[Special:Log]] - 10https://bugzilla.wikimedia.org/11739 (10Sumana Harihareswara) [01:26:58] (03Merged) 10jenkins-bot: MediaWikiTestCase: Centralise insertPage() logic from SearchEngineTest [core] - 10https://gerrit.wikimedia.org/r/161139 (owner: 10Krinkle) [01:28:32] (03CR) 10Wctaiwan: [C: 032] Add Flow support [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/162379 (https://bugzilla.wikimedia.org/71082) (owner: 10Legoktm) [01:29:08] (03Merged) 10jenkins-bot: Add Flow support [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/162379 (https://bugzilla.wikimedia.org/71082) (owner: 10Legoktm) [01:29:39] 3MediaWiki extensions / 3MassMessage: Add Flow support to MassMessage - 10https://bugzilla.wikimedia.org/71082 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3Kunal Mehta (Legoktm) [01:29:39] 3MediaWiki extensions / 3SecurePoll: Add UserMerge support to SecurePoll - 10https://bugzilla.wikimedia.org/67777#c3 (10James Alexander) Talking to Philippe I think this is an edge case that isn't worth worrying too much about. Right now we don't change it for renames (for example it still shows my test vote... [01:31:23] 3MediaWiki extensions / 3SecurePoll: Add UserMerge support to SecurePoll - 10https://bugzilla.wikimedia.org/67777 (10Kunal Mehta (Legoktm)) 5NEW>3RESO/WON [01:33:53] 3MediaWiki / 3MediaWiki UI: MediaWiki UI styles are applied to core instead of relevant skins, not overridable - 10https://bugzilla.wikimedia.org/70351#c24 (10Matthew Flaschen) (In reply to Isarra from comment #22) > In this case that the skin-specific styles now at least can be disabled is > an improvement,... [01:38:58] (03PS1) 10Wctaiwan: Make MassMessageJob methods protected [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/162528 [01:41:16] Flow support for MassMessage is nice. [01:41:42] (03CR) 10Legoktm: [C: 032] Make MassMessageJob methods protected [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/162528 (owner: 10Wctaiwan) [01:42:02] legoktm + wctaiwan: <3 [01:42:09] (03Merged) 10jenkins-bot: Make MassMessageJob methods protected [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/162528 (owner: 10Wctaiwan) [01:42:09] :) [01:42:13] :D [01:42:22] Carmela: mind if I PM you about something completely unrelated? [01:42:30] Go for it. [01:45:10] Why isn't this RSS feed working?? https://www.mediawiki.org/wiki/HHVM#Current_work There is no whitelist configured at https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FRSS/HEAD/RSS.php I'm baffled. [01:46:10] quiddity: because of the proxy probably. [01:47:21] proxy? it's just a bugzilla search, with "&ctype=atom" appended. [01:47:42] RSS is configured to use a proxy because on wmfwiki, it embeds the feed from the blog, which is now on an external host [01:47:54] so it needs to use the url-downloader proxy to access that RSS feed. [01:48:09] but if you try to use that proxy to access something inside the cluster like BZ, it'll have issues. [01:48:20] >.< [01:48:26] so we probably just need to disable usage of the proxy on mw.o [01:48:52] well I'm glad you understand. Should I file a bug under Extension:RSS ? [01:49:05] nah, I'll submit submit a config change in a few minutes. [01:49:08] <3 [01:52:37] 3MediaWiki / 3MediaWiki UI: MediaWiki UI styles are applied to core instead of relevant skins, not overridable - 10https://bugzilla.wikimedia.org/70351#c25 (10Isarra) (In reply to Matthew Flaschen from comment #24) > (In reply to Isarra from comment #22) > > In this case that the skin-specific styles now at... [01:56:08] (03CR) 10Legoktm: Add ESCAPE identifier to MS SQL LIKE queries so that the escaping would work as expected. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/162508 (https://bugzilla.wikimedia.org/71207) (owner: 10Emadelwany) [01:56:54] 3MediaWiki / 3Database: MS SQL Driver doesn't handle escaping for LIKE patterns correctly - 10https://bugzilla.wikimedia.org/71207 (10Kunal Mehta (Legoktm)) [01:56:54] 3MediaWiki / 3Database: Microsoft SQL Server/MSSQL support (tracking) - 10https://bugzilla.wikimedia.org/9767 (10Kunal Mehta (Legoktm)) [02:04:49] (03PS2) 10BryanDavis: Add some Wikibase client settings [vagrant] - 10https://gerrit.wikimedia.org/r/162284 (owner: 10Aude) [02:05:52] Is there any way to search for "=====" (5 equals signs in a row) in Enwiki's article source? (I'm looking for H5s) insource:"=====" doesn't work in Cirrus, and "=====" doesn't work in lucene. [02:06:59] (03CR) 10Skizzerz: [C: 04-1] "You should also override DatabaseBase::escapeLikeInternal so that only wildcard characters recognized by SQL Server are escaped. The defau" [core] - 10https://gerrit.wikimedia.org/r/162508 (https://bugzilla.wikimedia.org/71207) (owner: 10Emadelwany) [02:08:01] legoktm: Did you test the patches? [02:08:15] er, which one? [02:09:09] The booksouce one and the html from one [02:09:31] (03PS1) 10Wctaiwan: Strip signatures for Flow and LQT [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/162533 [02:09:31] I already merged the booksource one [02:09:32] didn't look at the html one yet [02:09:45] legoktm: ^ could you please test that for me? (I have neither flow nor LQT) [02:11:53] legoktm: No getConfig on this https://integration.wikimedia.org/ci/job/mediawiki-vendor-integration/1962/console [02:12:35] legoktm: nvm, you've already left a comment [02:15:09] (03PS4) 10Prtksxna: HtmlForm: Use mw-ui-checkbox only if wgUseMediaWikiUIEverywhere is enabled [core] - 10https://gerrit.wikimedia.org/r/162509 [02:15:14] legoktm: fixed ^ [02:15:55] wctaiwan: boolean parameters :< [02:16:29] legoktm: so add a constant? [02:16:50] yeah that would make it better. [02:16:54] okay [02:17:38] should we also strip ~~~? [02:18:27] (03CR) 10SG: "LGTM. Matt, any issues with this?" [core] - 10https://gerrit.wikimedia.org/r/155856 (https://bugzilla.wikimedia.org/69212) (owner: 10SG) [02:21:21] 3MediaWiki / 3MediaWiki UI: MediaWiki UI styles are applied to core instead of relevant skins, not overridable - 10https://bugzilla.wikimedia.org/70351#c26 (10Matthew Flaschen) (In reply to Isarra from comment #25) > > That's your opinion. No other skin writers have expressed that opinion, as > > far as I k... [02:21:53] (03PS1) 10BryanDavis: Fix role:commons duplicate definition [vagrant] - 10https://gerrit.wikimedia.org/r/162535 [02:22:28] (03CR) 10BryanDavis: [C: 032] Fix role:commons duplicate definition [vagrant] - 10https://gerrit.wikimedia.org/r/162535 (owner: 10BryanDavis) [02:22:32] (03Merged) 10jenkins-bot: Fix role:commons duplicate definition [vagrant] - 10https://gerrit.wikimedia.org/r/162535 (owner: 10BryanDavis) [02:22:48] (03PS2) 10Wctaiwan: Strip signatures for Flow and LQT [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/162533 [02:23:04] legoktm: I don't think so. [02:23:10] also added a constant ^ [02:23:24] cheated a bit because self::NO_STRIP_TILDES is dumb. [02:25:45] (03PS3) 10BryanDavis: Add some Wikibase client settings [vagrant] - 10https://gerrit.wikimedia.org/r/162284 (owner: 10Aude) [02:36:57] (03PS4) 10BryanDavis: Add some Wikibase client settings [vagrant] - 10https://gerrit.wikimedia.org/r/162284 (owner: 10Aude) [02:40:43] (03CR) 10BryanDavis: [C: 032] "Tweaked slightly to use hiera vars to construct the url to the repo wiki." [vagrant] - 10https://gerrit.wikimedia.org/r/162284 (owner: 10Aude) [02:40:48] (03Merged) 10jenkins-bot: Add some Wikibase client settings [vagrant] - 10https://gerrit.wikimedia.org/r/162284 (owner: 10Aude) [02:42:03] (03PS3) 10BryanDavis: Add memcached role [vagrant] - 10https://gerrit.wikimedia.org/r/162285 (owner: 10Aude) [02:55:05] ori: I was looking at aude's patch for adding memcached and wondering if this deserves something fancier. Like maybe reverting https://gerrit.wikimedia.org/r/#/c/89153/ What do you think? [02:56:57] (03PS1) 10BryanDavis: Revert "Remove memcached" [vagrant] - 10https://gerrit.wikimedia.org/r/162537 [03:32:09] (03PS2) 10BryanDavis: Restore puppet module for provisioning memcached [vagrant] - 10https://gerrit.wikimedia.org/r/162537 [03:34:05] (03CR) 10Mattflaschen: [C: 04-1] "Please also add them for IE 9 (the last supported browser for conditional comments)." [core] - 10https://gerrit.wikimedia.org/r/161051 (owner: 10SG) [03:37:51] (03CR) 10Mattflaschen: "> Please also add them for IE 9 (the last supported browser for conditional comments)." [core] - 10https://gerrit.wikimedia.org/r/161051 (owner: 10SG) [03:43:41] legoktm: Are you familiar with HtmlForm? [03:44:55] (03CR) 10Mattflaschen: "> Make this configurable, e.g. LocalSettings.php variable that allows admins to turn on conditional support for ie6/7/8/9. After reading M" [core] - 10https://gerrit.wikimedia.org/r/161051 (owner: 10SG) [03:47:21] (03PS4) 10BryanDavis: Add memcached role [vagrant] - 10https://gerrit.wikimedia.org/r/162285 (owner: 10Aude) [03:50:58] (03CR) 10BryanDavis: "I'm wondering if this role should also bump the RAM requirement of the VM." [vagrant] - 10https://gerrit.wikimedia.org/r/162285 (owner: 10Aude) [03:54:52] (03PS3) 10BryanDavis: Provision MMV browser-test dependencies [vagrant] - 10https://gerrit.wikimedia.org/r/160786 (owner: 10Dduvall) [03:55:46] (03CR) 10BryanDavis: [C: 032] "Dan, you should feel free to self merge changes this simple. :)" [vagrant] - 10https://gerrit.wikimedia.org/r/160786 (owner: 10Dduvall) [03:55:51] (03Merged) 10jenkins-bot: Provision MMV browser-test dependencies [vagrant] - 10https://gerrit.wikimedia.org/r/160786 (owner: 10Dduvall) [03:56:07] 3MediaWiki extensions / 3Interwiki (extension): Clean up inconsistent _ vs - formatting across i18n message keys - 10https://bugzilla.wikimedia.org/70080#c6 (10Isarra) 5REOP>3RESO/WON Okay, yeah, you're right. It's just bloody horrible. [03:58:12] (03CR) 10BryanDavis: [C: 031] "LGTM, but I'll give Ori a chance to advocate for some other solution that fixes bug 70979 while still making the tests independent of netw" [vagrant] - 10https://gerrit.wikimedia.org/r/161223 (https://bugzilla.wikimedia.org/70979) (owner: 10Gergő Tisza) [03:58:33] (03PS2) 10BryanDavis: labs-vagrant: add git-update command [vagrant] - 10https://gerrit.wikimedia.org/r/161360 [04:08:52] 3MediaWiki extensions / 3MediaWikiAuth: Core patches still block account creation when extension is not enabled - 10https://bugzilla.wikimedia.org/66823#c2 (10Isarra) 5NEW>3RESO/FIX I think this was fixed in a patch I forgot to link because I forgot I filed a bug. Seems to be, though. [04:10:22] 3MediaWiki extensions / 3Interwiki (extension): Add a hook (or general support) so that Extension:InterwikiMagic (or similar) are compatible without a patch - 10https://bugzilla.wikimedia.org/55417#c2 (10Isarra) 5NEW>3RESO/FIX Fixed by fixing Bug 68241! [04:22:37] (03PS1) 10Arlolra: WIP: Resizer [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/162540 [04:23:02] (03CR) 10jenkins-bot: [V: 04-1] WIP: Resizer [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/162540 (owner: 10Arlolra) [04:27:58] (03PS2) 10Arlolra: WIP: Resizer [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/162540 [04:30:58] (03PS3) 10Arlolra: WIP: Resizer [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/162540 [04:31:57] prtksxna: kind of [04:37:08] 3MediaWiki extensions / 3Scribunto: Script error "attempt to concatenate a nil value" when running in HHVM - 10https://bugzilla.wikimedia.org/71174#c5 (10Tim Starling) I think the correct thing to do is to clear EG(exception) at the end of zend_wrap_func(). In Zend, EG(exception) is an "active" exception, i.... [04:38:35] (03PS4) 10Emadelwany: Add ESCAPE identifier to MS SQL LIKE queries so that the escaping would work as expected and handle additional MS SQL pattern operators. [core] - 10https://gerrit.wikimedia.org/r/162508 (https://bugzilla.wikimedia.org/71207) [04:40:43] (03PS5) 10Emadelwany: Add ESCAPE identifier to MS SQL LIKE queries so that the escaping would work as expected and handle additional MS SQL pattern operators. [core] - 10https://gerrit.wikimedia.org/r/162508 (https://bugzilla.wikimedia.org/71207) [04:43:12] (03PS6) 10Emadelwany: Add ESCAPE identifier to MS SQL LIKE queries so that the escaping would work as expected and handle additional MS SQL pattern operators. [core] - 10https://gerrit.wikimedia.org/r/162508 (https://bugzilla.wikimedia.org/71207) [04:53:37] 3MediaWiki / 3MediaWiki UI: Special:Contributions margin between form elements is incorrect with MediaWiki UI - 10https://bugzilla.wikimedia.org/70920#c2 (10Matthew Flaschen) 5PATC>3NEW It's now more readable in some ways, but less in others (I'll add an attachment right after this post). There's no mor... [04:54:07] 3MediaWiki / 3MediaWiki UI: Special:Contributions margin between form elements is incorrect with MediaWiki UI - 10https://bugzilla.wikimedia.org/70920#c3 (10Matthew Flaschen) (In reply to Matthew Flaschen from comment #2) > There's no more space between checkbox+label sets, including the example I > mentione... [04:54:37] 3MediaWiki / 3MediaWiki UI: Special:Contributions margin between form elements is incorrect with MediaWiki UI - 10https://bugzilla.wikimedia.org/70920#c4 (10Matthew Flaschen) Created attachment 16573 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16573&action=edit Updated screenshot [04:59:12] (03PS4) 10BryanDavis: Make Mathoid role configurable via hiera [vagrant] - 10https://gerrit.wikimedia.org/r/160694 (owner: 10Physikerwelt) [04:59:36] (03CR) 10BryanDavis: [C: 032] Make Mathoid role configurable via hiera [vagrant] - 10https://gerrit.wikimedia.org/r/160694 (owner: 10Physikerwelt) [04:59:40] (03Merged) 10jenkins-bot: Make Mathoid role configurable via hiera [vagrant] - 10https://gerrit.wikimedia.org/r/160694 (owner: 10Physikerwelt) [05:03:35] (03PS7) 10Brian Wolff: Make tiff thumbnail in 2 steps. [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135289 (https://bugzilla.wikimedia.org/52045) [05:03:50] (03PS3) 10BryanDavis: labs-vagrant: add git-update command [vagrant] - 10https://gerrit.wikimedia.org/r/161360 [05:03:57] (03CR) 10BryanDavis: [C: 032] labs-vagrant: add git-update command [vagrant] - 10https://gerrit.wikimedia.org/r/161360 (owner: 10BryanDavis) [05:04:02] (03Merged) 10jenkins-bot: labs-vagrant: add git-update command [vagrant] - 10https://gerrit.wikimedia.org/r/161360 (owner: 10BryanDavis) [05:05:54] (03CR) 10Brian Wolff: "Note in regards to max memory: This change is the last pre-requisite for VIPS support of tiffs (other than changing the vips config), whic" [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135289 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [05:06:47] (03CR) 10Brian Wolff: "PS7: Make the error message for that failing test be more descriptive (but do not change the test). Oh Wait! Now it doesn't fail. Isn't th" [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135289 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [05:07:46] (03PS1) 10Cscott: Improve Metabook.fromArticles. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/162542 [05:09:52] 3MediaWiki / 3MediaWiki UI: Determine how to set input[type=number] visual width (and maybe visual widths of other inputs) - 10https://bugzilla.wikimedia.org/70973 (10Matthew Flaschen) [05:10:39] 3MediaWiki / 3MediaWiki UI: Determine how to set input[type=number] visual width (and maybe visual widths of other inputs) - 10https://bugzilla.wikimedia.org/70973 (10Matthew Flaschen) [05:10:39] 3MediaWiki / 3MediaWiki UI: Special:Preferences: Custom (other) input field for Time offset is too long - 10https://bugzilla.wikimedia.org/70405#c18 (10Matthew Flaschen) 5RESO/FIX>3REOP It's not fixed. Let's use a dependency so we don't forget about it. [05:12:06] 3MediaWiki extensions / 3Scribunto: Script error "attempt to concatenate a nil value" when running in HHVM - 10https://bugzilla.wikimedia.org/71174#c6 (10Tim Starling) https://github.com/facebook/hhvm/pull/3834 [05:13:58] (03PS2) 10BryanDavis: Add force flag when cleaning up generated files [vagrant] - 10https://gerrit.wikimedia.org/r/160910 [05:16:52] (03CR) 10Mattflaschen: [C: 04-1] "There's a pending question at the bug." [core] - 10https://gerrit.wikimedia.org/r/162153 (https://bugzilla.wikimedia.org/71150) (owner: 10Prtksxna) [05:18:56] (03CR) 10Mattflaschen: "Also, can you explain why it's being changed? A reason is given at the bug (this is also related to the question I asked)." [core] - 10https://gerrit.wikimedia.org/r/162153 (https://bugzilla.wikimedia.org/71150) (owner: 10Prtksxna) [05:19:12] (03CR) 10BryanDavis: "The ruby documentation says that using the *_f variants is equivalent to adding the ":force => true" option and that suppresses all Standa" [vagrant] - 10https://gerrit.wikimedia.org/r/160910 (owner: 10BryanDavis) [05:19:21] (03CR) 10BryanDavis: Add force flag when cleaning up generated files (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/160910 (owner: 10BryanDavis) [05:22:54] 3Wikimedia / 3Site requests: request www.soumaya.com.mx be added to Glamwiki Toolset domain whitelist - 10https://bugzilla.wikimedia.org/70986 (10jeremyb) a:5jeremyb>3None [05:25:22] 3MediaWiki / 3MediaWiki UI: Fix Special:ActiveUsers for mw.ui - 10https://bugzilla.wikimedia.org/71142#c4 (10Matthew Flaschen) (In reply to Jared Zimmerman (WMF) from comment #1) > we should kill those non standard play/fast forward icons and make them > me.ui neutral. Is this referring to this page, or som... [05:27:37] 3MediaWiki / 3User login and signup: Can't authenticate using my mother language username (UNICODE) when I only have (a public) access to Wikipedia with an ASCII (english) keyboard - 10https://bugzilla.wikimedia.org/34590#c33 (10Nemo) (In reply to Nicolas Brouard from comment #32) > The Universal Language Se... [05:27:38] 3Wikimedia / 3Extension setup: Deploy ULS/UniversalLanguageSelector to all Wikimedia wikis (tracking) - 10https://bugzilla.wikimedia.org/13097 (10Nemo) [05:28:37] 3Wikimedia / 3Site requests: Allow embedding RSS feeds from bugzilla into mediawiki.org - 10https://bugzilla.wikimedia.org/56287#c4 (10Nemo) (In reply to Tim Landscheidt from comment #3) > The current state of things makes > https://www.mediawiki.org/wiki/HHVM#Current_work look ugly. Definitely; in the mean... [05:28:52] 3MediaWiki / 3MediaWiki UI: Fix action=history for mw.ui - 10https://bugzilla.wikimedia.org/71141#c1 (10Matthew Flaschen) (In reply to Prateek Saxena from comment #0) > - Use mw-ui-constructive for "Go" button Why is this mw-ui-constructive whereas bug 71141 ("Use mediawiki.ui elements on Special:Contributi... [05:29:53] (03PS1) 10Cscott: Don't crash if PNG has bogus resolution information. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/162543 [05:31:22] 3MediaWiki skins / 3Vector: Vector: insufficent text contrast impairs legibility - 10https://bugzilla.wikimedia.org/66021#c25 (10Isarra) Some actual papers and things: * http://www.w3.org/WAI/RD/2012/text-customization/r11 seems to indicate that lower contrast is better for dyslexics and worse for normal us... [05:32:24] 3MediaWiki extensions / 3TwnMainPage: Tests intermittently fail with an error about cookies - 10https://bugzilla.wikimedia.org/71217 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None Recently tests have been occasionally failing with an error about lack of support of cookies: https://integration.w... [05:33:09] (03PS1) 10Spage: WIP: Add docs grunt task to build KSS styleguide [core] - 10https://gerrit.wikimedia.org/r/162544 (https://bugzilla.wikimedia.org/58620) [05:34:10] 3Datasets / 3General/Unknown: Enable IPv6 on dumps.wikimedia.org - 10https://bugzilla.wikimedia.org/66996 (10wp mirror) [05:34:37] 3MediaWiki skins / 3Vector: Vector: insufficent text contrast impairs legibility - 10https://bugzilla.wikimedia.org/66021#c26 (10Bawolff (Brian Wolff)) (In reply to Isarra from comment #21) > (In reply to Andre Klapper from comment #19) > > I think "At this time I do not want to make an additional change to... [05:35:49] (03CR) 10Spage: "I was chatting to Krinkle and the alternative is to add the grunt code to existing tests/frontend Gruntfile.js , which the jenkins build a" [core] - 10https://gerrit.wikimedia.org/r/161998 (https://bugzilla.wikimedia.org/58620) (owner: 10Prtksxna) [05:38:10] 3MediaWiki extensions / 3TwnMainPage: Tests intermittently fail with an error about cookies - 10https://bugzilla.wikimedia.org/71217#c1 (10Niklas Laxström) No idea unless it coincides with server reboots. I would prefer to move sandbox to somewhere else as it takes my limited maintenance resources away from... [05:38:10] 3Datasets / 3General/Unknown: Enable IPv6 on dumps.wikimedia.org - 10https://bugzilla.wikimedia.org/66996 (10jeremyb) [05:38:49] (03PS1) 10Cscott: Add force_render option to help page. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/162545 [05:39:23] (03CR) 10Spage: "`grunt docs` builds something. I'm not sure why it builds KSS from" [core] - 10https://gerrit.wikimedia.org/r/162544 (https://bugzilla.wikimedia.org/58620) (owner: 10Spage) [05:39:31] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add docs grunt task to build KSS styleguide [core] - 10https://gerrit.wikimedia.org/r/162544 (https://bugzilla.wikimedia.org/58620) (owner: 10Spage) [05:39:37] 3Datasets / 3General/Unknown: Enable IPv6 on dumps.wikimedia.org - 10https://bugzilla.wikimedia.org/66996 (10jeremyb) [05:42:40] 3MediaWiki-Vagrant / 3labs-vagrant: labs-vagrant provision failing in createAndPromote Selenium_user - 10https://bugzilla.wikimedia.org/71219 (10spage) 3NEW p:3Unprio s:3normal a:3None My latest attempt to run sudo labs-vagrant provision on flow-tests.eqiad.wmflabs, with latest /vagrant and /vagrant/... [05:48:23] 3MediaWiki / 3Parser: Add "view-source://" to wgUrlProtocols - 10https://bugzilla.wikimedia.org/71166#c2 (10Bawolff (Brian Wolff)) I was going to object on the basis it wasn't an official registered uri schema, but apparently it is. So I'm going to object on the basis of lack of support on IE7+. If these so... [05:48:52] 3Wikimedia / 3Deployment systems: [l10n] LocalisationUpdate doesn't seem to run for VisualEditor - 10https://bugzilla.wikimedia.org/70267#c3 (10Amir E. Aharoni) 5NEW>3RESO/FIX The message that triggered this bug was imported successfully, so I guess that it's fixed now, but I don't know what caused or wh... [05:52:08] 3MediaWiki-Vagrant / 3labs-vagrant: labs-vagrant provision failing in Mediawiki::Import_dump[labs_privacy]/Exec[import_dump_labs_privacy] - 10https://bugzilla.wikimedia.org/70959#c11 (10spage) Labs provision is still failing in this script, but now with a different error, Notice: /Stage[main]/Role::Labs_ini... [05:53:40] (03Abandoned) 10Mattflaschen: DRAFT - Add workaround to placeholder shim for password input boxes. [core] - 10https://gerrit.wikimedia.org/r/65871 (owner: 10Mattflaschen) [06:01:07] 3Wikimedia / 3Apache configuration: Make it possible to quickly and programmaticly pool and depool application servers - 10https://bugzilla.wikimedia.org/71212#c3 (10Giuseppe Lavagetto) This is a long-standing issue we encounter for a number of reasons: we need an orchestration tool different from "vi". So... [06:02:07] 3Wikimedia / 3Deployment systems: [l10n] LocalisationUpdate doesn't seem to run for VisualEditor - 10https://bugzilla.wikimedia.org/70267#c4 (10Niklas Laxström) This has been going since August 14th so there is something broken still: PHP Warning: filemtime(): stat failed for /resources/projects/mediawiki-e... [06:03:23] 3Wikimedia / 3Deployment systems: [l10n] LocalisationUpdate doesn't seem to run for VisualEditor - 10https://bugzilla.wikimedia.org/70267#c5 (10Amir E. Aharoni) 5RESO/FIX>3REOP So REOPENED? [06:04:24] (03CR) 10Mattflaschen: "Minor coding convention issue inline." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/162153 (https://bugzilla.wikimedia.org/71150) (owner: 10Prtksxna) [06:15:39] 3MediaWiki extensions / 3CirrusSearch: Fatal error: Call to undefined function Elastica\Transport\curl_init() - 10https://bugzilla.wikimedia.org/71221 (10wp mirror) 3NEW p:3Unprio s:3major a:3None To whom it may concern, 0) Context I have a working wiki farm that mirrors one or more of the WMF wiki... [06:23:38] 3MediaWiki / 3Parser: Add "view-source://" to wgUrlProtocols - 10https://bugzilla.wikimedia.org/71166#c3 (10jeremyb) (In reply to Bawolff (Brian Wolff) from comment #2) +1 [06:32:08] 3Wikimedia / 3Deployment systems: [l10n] LocalisationUpdate doesn't seem to run for VisualEditor - 10https://bugzilla.wikimedia.org/70267#c6 (10Nemo) 5REOP>3RESO/FIX (In reply to Amir E. Aharoni from comment #3) > The message that triggered this bug was imported successfully, so I guess > that it's fixed... [06:34:39] 3MediaWiki / 3API: API XHR requests from mediawiki do not transmit cookies when editing - 10https://bugzilla.wikimedia.org/71222 (10Giuseppe Lavagetto) [06:34:40] 3MediaWiki / 3API: API XHR requests from mediawiki do not transmit cookies when editing - 10https://bugzilla.wikimedia.org/71222 (10Giuseppe Lavagetto) 3NEW p:3Unprio s:3major a:3None Looking at the network traffic from visiting a page on enwiki, I saw that when editing a page (both with VE enabled a... [06:47:40] (03CR) 10Adrian Lang: "I still think it makes sense for mw.Api to have a handy utility function for getting an instance pre-configured for CORS. We might want to" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/162229 (owner: 10Hoo man) [06:49:10] 3MediaWiki extensions / 3CentralAuth: User with unattached accounts unable to login (504) after 1.24wmf22 deployment - 10https://bugzilla.wikimedia.org/71223 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3critic a:3None User:NickK reported in IRC that they're getting 504 timeout errors when trying to lo... [06:51:20] (03CR) 10PleaseStand: [C: 04-1] Add ESCAPE identifier to MS SQL LIKE queries so that the escaping would work as expected and handle additional MS SQL pattern operators. (034 comments) [core] - 10https://gerrit.wikimedia.org/r/162508 (https://bugzilla.wikimedia.org/71207) (owner: 10Emadelwany) [06:52:07] 3MediaWiki extensions / 3CentralAuth: User with unattached accounts unable to login (504) after 1.24wmf22 deployment - 10https://bugzilla.wikimedia.org/71223#c1 (10Nemo) p:5Unprio>3Highes (In reply to Kunal Mehta (Legoktm) from comment #0) > My initial hunch is that I3a219d86a8837ed9c0c3788604dc3229ee124... [06:56:10] (03PS1) 10Legoktm: Revert "Auto-migrate matching accounts where no global account exists" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/162549 (https://bugzilla.wikimedia.org/71223) [06:56:39] (03PS1) 10Legoktm: Revert "Auto-migrate matching accounts where no global account exists" [extensions/CentralAuth] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162550 (https://bugzilla.wikimedia.org/71223) [07:08:22] 3MediaWiki extensions / 3CentralAuth: User with unattached accounts unable to login (504) after 1.24wmf22 deployment - 10https://bugzilla.wikimedia.org/71223#c4 (10Kunal Mehta (Legoktm)) (In reply to Nemo from comment #1) > (In reply to Kunal Mehta (Legoktm) from comment #0) > > My initial hunch is that I3a2... [07:09:45] (03CR) 10Legoktm: [C: 032] Revert "Auto-migrate matching accounts where no global account exists" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/162549 (https://bugzilla.wikimedia.org/71223) (owner: 10Legoktm) [07:10:39] (03Merged) 10jenkins-bot: Revert "Auto-migrate matching accounts where no global account exists" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/162549 (https://bugzilla.wikimedia.org/71223) (owner: 10Legoktm) [07:12:00] (03PS15) 10Florianschmidtwelzow: Show Captcha after click on edit over buttons on EditPage [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/136323 (https://bugzilla.wikimedia.org/19648) [07:12:38] (03CR) 10Legoktm: "See bug 71223." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/158578 (https://bugzilla.wikimedia.org/70392) (owner: 10Legoktm) [07:21:35] (03PS7) 10Emadelwany: Add ESCAPE identifier to MS SQL LIKE queries so that the escaping would work as expected and handle additional MS SQL pattern operators. [core] - 10https://gerrit.wikimedia.org/r/162508 (https://bugzilla.wikimedia.org/71207) [07:40:32] (03CR) 10Legoktm: [C: 031] "Code looks fine, minor thing." (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/162533 (owner: 10Wctaiwan) [07:42:32] (03CR) 10Bartosz Dziewoński: "I also think this is a good idea." [core] - 10https://gerrit.wikimedia.org/r/162229 (owner: 10Hoo man) [07:44:05] (03CR) 10Legoktm: [C: 031] "The method in which you're checking the config setting is correct, I'll leave it for Jon to make sure the actual change is good :)" [core] - 10https://gerrit.wikimedia.org/r/162509 (owner: 10Prtksxna) [07:52:22] 3MediaWiki / 3JavaScript: jquery.tablesorter: Add support for a "fixed" column - 10https://bugzilla.wikimedia.org/40618#c26 (10Michael M.) (In reply to Bartosz Dziewoński from comment #20) > 1. Obviously, no support for old browsers. I understand that this is a > trade-off that we're willing to make. Acc... [07:59:07] 3MediaWiki extensions / 3CentralAuth: User with unattached accounts unable to login (504) after 1.24wmf22 deployment - 10https://bugzilla.wikimedia.org/71223#c6 (10Nemo) (In reply to Kunal Mehta (Legoktm) from comment #4) > We > need to make matchHash aware whether it is meant to be a check only, or > actual... [08:07:52] 3Wikimedia / 3Site requests: New England Wikimedians website - 10https://bugzilla.wikimedia.org/64557#c66 (10This, that and the other (TTO)) 5PATC>3NEW Since http://ne-wikimedians.org has been set up, I suppose this request is no longer necessary? [08:14:41] (03CR) 10Nikerabbit: "Please add @since annotations when adding new public methods. As an extension developer I find it painful to have to go through git blame " [core] - 10https://gerrit.wikimedia.org/r/162484 (https://bugzilla.wikimedia.org/71144) (owner: 10Prtksxna) [08:21:08] 3Wikimedia / 3Site requests: New England Wikimedians website - 10https://bugzilla.wikimedia.org/64557#c67 (10jeremyb) 5NEW>3RESO/WON closing for now. reopening bugs is cheap. [08:28:55] 3Wikimedia / 3General/Unknown: texvc missing under HHVM - 10https://bugzilla.wikimedia.org/71224 (10Michael M.) 3NEW p:3Unprio s:3normal a:3None The texvc executable seems to be missing on the servers running HHVM. To reproduce make sure you have MathJax disabled and HHVM enabled. Open any page for e... [08:38:22] 3Wikimedia / 3Site requests: add *.nijmegen.nl to wgCopyUploadsDomains - 10https://bugzilla.wikimedia.org/71191 (10Steinsplitter) s:5normal>3enhanc [08:39:22] 3Wikimedia / 3Site requests: add *.nijmegen.nl to wgCopyUploadsDomains - 10https://bugzilla.wikimedia.org/71191#c1 (10Steinsplitter) 5NEW>3PATC https://gerrit.wikimedia.org/r/#/c/162556/ [09:07:37] 3Wikimedia / 3Mailing lists: Create a mailing list for Maithili (mai) Wikipedia - 10https://bugzilla.wikimedia.org/44938#c7 (10Muzammil) (In reply to Andre Klapper from comment #6) > Hi Muzammil, > > > 1) Activity level has increased - 16 active users and about 60 overall users. > > Where exactly? Link wel... [09:28:07] 3MediaWiki extensions / 3WikidataRepo: Create browser smoke test for a typical item - 10https://bugzilla.wikimedia.org/68094#c2 (10Lydia Pintscher) It does make sense. We have had too many cases where our specific tests didn't catch issues that would have been caught with this. [09:30:07] 3MediaWiki extensions / 3WikidataRepo: date in claim diff formatted as timestamp - 10https://bugzilla.wikimedia.org/70086 (10Lydia Pintscher) p:5Low>3Normal [09:32:07] 3MediaWiki extensions / 3WikidataClient: Special:UnconnectedPages should be includable - 10https://bugzilla.wikimedia.org/70018 (10Lydia Pintscher) [09:33:08] 3MediaWiki extensions / 3WikidataRepo: Wrong century rounding is applied when entering Time values - 10https://bugzilla.wikimedia.org/64742 (10tobias.gritschacher) [09:33:37] 3MediaWiki extensions / 3WikidataRepo: allow editing aliases via the "in other languages" box - 10https://bugzilla.wikimedia.org/53344#c5 (10Lydia Pintscher) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 70033 *** [09:33:39] 3MediaWiki extensions / 3WikidataRepo: Integrate aliases into fingerprintview - 10https://bugzilla.wikimedia.org/70033#c2 (10Lydia Pintscher) *** Bug 53344 has been marked as a duplicate of this bug. *** [09:38:22] 3MediaWiki / 3Interface: Interface messages needing rewording or documentation and other issues with existing messages (tracking) - 10https://bugzilla.wikimedia.org/38638 (10Amir E. Aharoni) [09:38:55] 3MediaWiki extensions / 3WikidataRepo: Section-edit mode for SiteLinks - 10https://bugzilla.wikimedia.org/68908 (10tobias.gritschacher) 5PATC>3RESO/FIX [09:40:22] 3MediaWiki extensions / 3WikidataRepo: Support non-Wikimedia projects as sitelinks - 10https://bugzilla.wikimedia.org/70264#c4 (10Lydia Pintscher) 5NEW>3RESO/WON I've been thinking about this some more. I don't want us to treat them exactly like sitelinks. I'd like to keep them as statements and just hav... [09:40:38] 3MediaWiki extensions / 3WikidataRepo: Redesign Item UI for Wikidata repo - 10https://bugzilla.wikimedia.org/52136 (10Lydia Pintscher) [09:41:37] 3MediaWiki extensions / 3WikidataRepo: Mono-lingual text datatype should support "no linguistic content" and "undetermined language" - 10https://bugzilla.wikimedia.org/70205#c1 (10Lydia Pintscher) Can you please link to a specific example? Thanks! [09:41:50] (03CR) 10Fomafix: "Is it possible to create an endless redirect circle?" [core] - 10https://gerrit.wikimedia.org/r/162491 (https://bugzilla.wikimedia.org/71200) (owner: 10Legoktm) [09:51:10] 3MediaWiki extensions / 3GoogleLogin: "Create with Google" button on UserCreate page - 10https://bugzilla.wikimedia.org/71226 (10Florian) 3NEW p:3Unprio s:3enhanc a:3None Comes from: https://www.mediawiki.org/wiki/Thread:Extension_talk:GoogleLogin/On_Create_account_page%3F [10:05:22] 3MediaWiki extensions / 3WikidataRepo: StorageException in EditEntityActionTest::testActionForPage (edit-already-exists) and related failures - 10https://bugzilla.wikimedia.org/70710 (10Lydia Pintscher) p:5Unprio>3Low s:5normal>3minor [10:05:52] 3MediaWiki extensions / 3WikidataRepo: AbuseFilter doesn't log creating redirects in mainspace - 10https://bugzilla.wikimedia.org/70715 (10Lydia Pintscher) [10:06:07] 3MediaWiki extensions / 3WikidataRepo: AbuseFilter doesn't log creating redirects in mainspace - 10https://bugzilla.wikimedia.org/70715 (10Lydia Pintscher) [10:06:53] (03CR) 10Gilles: [C: 032] Fix missing tutorial steps in the funnel logging [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/162499 (owner: 10Gergő Tisza) [10:08:52] 3MediaWiki extensions / 3WikidataRepo: add test that fails when tests will not be run because of missing @group - 10https://bugzilla.wikimedia.org/70555 (10Lydia Pintscher) p:5Unprio>3Normal [10:09:22] 3MediaWiki extensions / 3WikidataRepo: Moving article on client removes badges - 10https://bugzilla.wikimedia.org/70687 (10Lydia Pintscher) [10:09:56] (03Merged) 10jenkins-bot: Fix missing tutorial steps in the funnel logging [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/162499 (owner: 10Gergő Tisza) [10:10:38] 3MediaWiki extensions / 3CirrusSearch: Fatal error: Call to undefined function Elastica\Transport\curl_init() - 10https://bugzilla.wikimedia.org/71221#c1 (10wp mirror) 5NEW>3RESO/FIX 5) Fix 5.1) Apparently, I neglected to restart `apache2' after installing `php5-curl'. (rootshell)# /etc/init.d/apache2... [10:11:22] 3MediaWiki extensions / 3WikidataRepo: Reference bars shouldn't have all styling done with JS - 10https://bugzilla.wikimedia.org/70701#c1 (10Lydia Pintscher) 5NEW>3RESO/DUP Agreed. Going to mark this as a dupe of the UI redesign however as those things will be redone there. *** This bug has been marked... [10:11:52] 3MediaWiki extensions / 3WikidataRepo: Redesign Item UI for Wikidata repo - 10https://bugzilla.wikimedia.org/52136#c6 (10Lydia Pintscher) *** Bug 70701 has been marked as a duplicate of this bug. *** [10:12:22] 3Wikimedia / 3General/Unknown: Deploy HHVM for all users - 10https://bugzilla.wikimedia.org/70418#c7 (10Antoine "hashar" Musso) 5NEW>3RESO/FIX HHVM related issues impacts a wide range of bugzilla components so they are tracked via the keyword 'hhvm'. The dashboard of pending bug is: https://bugzilla.wi... [10:12:37] 3MediaWiki extensions / 3WikidataRepo: wbformatvalue called twice when creating statement - 10https://bugzilla.wikimedia.org/71100 (10Lydia Pintscher) p:5Unprio>3Normal [10:14:37] 3MediaWiki extensions / 3WikidataRepo: Maintenance scripts for populating the untity_usage table from the item_per_site table. - 10https://bugzilla.wikimedia.org/71050 (10Lydia Pintscher) p:5Unprio>3Normal [10:15:40] 3MediaWiki extensions / 3WikidataRepo: Save-Button not disabled when editing a reference - 10https://bugzilla.wikimedia.org/71039 (10Lydia Pintscher) [10:16:39] 3MediaWiki extensions / 3Graph: No fallback for non-JavaScript browsers - 10https://bugzilla.wikimedia.org/71227 (10Brad Jorsch) 3NEW p:3Unprio s:3major a:3None Having the graph be entirely missing when the user has JavaScript off is no good, there needs to be some reasonable fallback. [10:18:22] 3MediaWiki extensions / 3WikidataRepo: Wikidata: CTRL+click and middle click on search suggestions doesn't open the page in a new tab - 10https://bugzilla.wikimedia.org/57709#c11 (10Lydia Pintscher) 5REOP>3RESO/FIX Marking this as fixed. We have bug 66432 for the remaining issue. [10:18:37] 3MediaWiki extensions / 3WikidataRepo: Right/middle click on "containing..." still triggers the search - 10https://bugzilla.wikimedia.org/66432 (10Lydia Pintscher) [10:18:54] 3MediaWiki extensions / 3WikidataRepo: Right/middle click on "containing..." still triggers the search - 10https://bugzilla.wikimedia.org/66432 (10Lydia Pintscher) p:5High>3Normal [10:20:10] 3MediaWiki extensions / 3WikidataRepo: When click edit, the snak value disappears from text field - 10https://bugzilla.wikimedia.org/63566 (10Lydia Pintscher) 5NEW>3RESO/WOR [10:23:22] 3MediaWiki extensions / 3WikidataRepo: Allow middle click on suggester - 10https://bugzilla.wikimedia.org/69908 (10Lydia Pintscher) p:5Low>3Normal s:5minor>3normal [10:25:22] 3MediaWiki extensions / 3WikidataRepo: Forward according to user's preferred language on Special:GoToLinkedPage - 10https://bugzilla.wikimedia.org/70159#c1 (10Lydia Pintscher) p:5Unprio>3Normal s:5enhanc>3normal It should not link to the sitelink section but just to the item in general. [10:26:38] 3MediaWiki extensions / 3WikidataRepo: Error messages for Special:GoToLinkedPage - 10https://bugzilla.wikimedia.org/70127 (10Lydia Pintscher) p:5Unprio>3Normal [10:26:52] 3MediaWiki extensions / 3WikidataRepo: Forward according to user's preferred language on Special:GoToLinkedPage - 10https://bugzilla.wikimedia.org/70159 (10Lydia Pintscher) [10:27:07] 3MediaWiki extensions / 3WikidataRepo: Error messages for Special:GoToLinkedPage when requested target doesn't exist - 10https://bugzilla.wikimedia.org/70127 (10Lydia Pintscher) [10:39:52] 3MediaWiki extensions / 3WikidataRepo: allow editing aliases via the "in other languages" box - 10https://bugzilla.wikimedia.org/53344#c6 (10Deryck Chan) I'm still unable to edit aliases in the "in other languages" boxes. Are you sure this is a duplicate of bug 70033, which has been marked as solved? [10:49:38] 3MediaWiki / 3API: API XHR requests from mediawiki do not transmit cookies when editing - 10https://bugzilla.wikimedia.org/71222 (10Andre Klapper) p:5Unprio>3High [10:56:53] 3Wikimedia / 3Site requests: Add 'unwatchedpages' right for the 'patroller' user group on Hebrew Wikibooks - 10https://bugzilla.wikimedia.org/71193#c1 (10Andre Klapper) 5UNCO>3NEW p:5Unprio>3Normal s:5normal>3enhanc [Moving to "Wikimedia" product as this request is about settings / configuration... [10:57:07] 3Wikimedia / 3Site requests: Add new .no domains to the wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/71195 (10Andre Klapper) p:5Unprio>3Normal s:5normal>3enhanc [10:58:53] (03PS2) 10Lewis Cawte: General cleanup [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/161785 (owner: 10Jack Phoenix) [11:03:24] 3Wikimedia / 3SSL related: replace SHA1 certificates with SHA256 - 10https://bugzilla.wikimedia.org/71156#c3 (10Andre Klapper) p:5Unprio>3Normal Official announcement: http://googleonlinesecurity.blogspot.cz/2014/09/gradually-sunsetting-sha-1.html (In reply to chmarkine from comment #0) > Chrome 39 will... [11:03:24] 3MediaWiki / 3Database: MS SQL Driver doesn't handle escaping for LIKE patterns correctly - 10https://bugzilla.wikimedia.org/71207 (10Andre Klapper) p:5Unprio>3Normal [11:08:55] 3Wikimedia / 3Site requests: Add 'delete' right to "Image-reviewer" group on fa.wiki - 10https://bugzilla.wikimedia.org/71229 (10Calak) 3NEW p:3Unprio s:3normal a:3None Hello. Please add 'delete' right to "Image-reviewer" group on fa.wiki. Thanks. [11:10:06] 3Wikimedia / 3Site requests: Add 'delete' right to "Image-reviewer" group on fa.wiki - 10https://bugzilla.wikimedia.org/71229 (10Calak) p:5Unprio>3Normal s:5normal>3enhanc [11:10:23] 3Wikimedia / 3Site requests: Add 'delete' right to "Image-reviewer" group on fa.wiki - 10https://bugzilla.wikimedia.org/71229#c1 (10Calak) p:5Unprio>3Normal s:5normal>3enhanc Change 162565 had a related patch set uploaded by Reza: Add delete right to fawiki Image-reviewer https://gerrit.wikimedia.or... [11:21:09] 3Wikimedia / 3SSL related: replace SHA1 certificates with SHA256 - 10https://bugzilla.wikimedia.org/71156#c4 (10Andre Klapper) ...and Mozilla: https://blog.mozilla.org/security/2014/09/23/phasing-out-certificates-with-sha-1-based-signature-algorithms/ [11:55:41] (03CR) 10Jackmcbarn: "Not in any way that isn't already possible today." [core] - 10https://gerrit.wikimedia.org/r/162491 (https://bugzilla.wikimedia.org/71200) (owner: 10Legoktm) [11:56:37] 3MediaWiki extensions / 3UniversalLanguageSelector: Oriya webfont not getting loaded for edit field on wikisource (FF31 on Windows XP) - 10https://bugzilla.wikimedia.org/70929#c5 (10Subhashish Panigrahi) (In reply to Andre Klapper from comment #4) > And what kind of workshop? When? Are all machines still run... [12:09:30] (03CR) 10Wmat: [C: 031] Add Oracle version of update-keys.sql [core] - 10https://gerrit.wikimedia.org/r/161491 (https://bugzilla.wikimedia.org/71040) (owner: 10Brian Wolff) [12:09:54] 3MediaWiki / 3Export/Import: Special:Import doesn't respect $wgMaxArticleSize - 10https://bugzilla.wikimedia.org/71230 (10Nemo) 3NEW p:3Unprio s:3normal a:3None Created attachment 16574 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16574&action=edit Example XML 1) Set $wgMaxArticleSize to 1... [12:10:07] 3MediaWiki extensions / 3UniversalLanguageSelector: Oriya webfont not getting loaded for edit field on wikisource (FF31 on Windows XP) - 10https://bugzilla.wikimedia.org/70929#c6 (10Andre Klapper) Am I correct that the Oriya script is still readable in the editing field, just that the font looks less good? [12:10:22] 3MediaWiki extensions / 3UniversalLanguageSelector: Oriya webfont not getting loaded for edit field on wikisource (FF31 on Windows XP) - 10https://bugzilla.wikimedia.org/70929#c7 (10Subhashish Panigrahi) (In reply to Andre Klapper from comment #6) > Am I correct that the Oriya script is still readable in the... [12:26:19] is jenkins stuck? a job is pending for 5 or so minutes [12:26:27] https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-language-screenshot-linux-firefox-69535/ [12:26:36] (03PS1) 10Manybubbles: Add more retry logic to reindexing [extensions/CirrusSearch] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162571 [12:31:06] 3MediaWiki extensions / 3CirrusSearch: Fatal error: Call to undefined function Elastica\Transport\curl_init() - 10https://bugzilla.wikimedia.org/71221#c2 (10Nik Everett) Sorry for the trouble! [12:33:17] (03CR) 10Reedy: [C: 032] Make tiff thumbnail in 2 steps. [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135289 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [12:42:45] (03CR) 10Manybubbles: "Ping for speedy review please. Sorry for the pressure but I think this will help with out load spikes." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/162240 (owner: 10Manybubbles) [12:51:54] 3MediaWiki / 3Special pages: Evolution for Special:ListRedirects : Special page listing redirect linking to a category of page - 10https://bugzilla.wikimedia.org/71231 (10MACARENO Richard) 3NEW p:3Unprio s:3major a:3None Special:ListRedirects is mostly unused/useful, it can show only EVERY redirect (... [13:00:25] 3MediaWiki / 3Special pages: Evolution of Special:ListRedirects : Special page listing redirect linking to a category of pages - 10https://bugzilla.wikimedia.org/71231 (10MACARENO Richard) [13:03:25] 3MediaWiki extensions / 3WikidataRepo: Special:SetSiteLink broken on beta - 10https://bugzilla.wikimedia.org/71232 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs http://wikidata.beta.wmflabs.org/wiki/Special:SetSiteLink/Q2558/enwiki Unexpected non-MediaWiki exception encountered, of type "UserIn... [13:05:37] 3MediaWiki / 3Special pages: Evolution of Special:ListRedirects : Special page listing redirect linking to a category of pages - 10https://bugzilla.wikimedia.org/71231#c1 (10Jesús Martínez Novo (Ciencia Al Poder)) s:5major>3enhanc not a bug, but a wish --> enhancement [13:08:22] 3MediaWiki extensions / 3WikidataRepo: allow editing aliases via the "in other languages" box - 10https://bugzilla.wikimedia.org/53344#c7 (10Lydia Pintscher) Yes. It is not deployed yet. [13:08:37] 3MediaWiki / 3Special pages: Evolution of Special:ListRedirects : Special page listing redirect linking to a category of pages - 10https://bugzilla.wikimedia.org/71231#c2 (10MACARENO Richard) yes an enhancement, or even more a request, or a dream ^^ [13:14:19] (03Merged) 10jenkins-bot: Make tiff thumbnail in 2 steps. [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135289 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [13:14:41] yay [13:16:09] 3Wikimedia / 3Site requests: request www.soumaya.com.mx be added to Glamwiki Toolset domain whitelist - 10https://bugzilla.wikimedia.org/70986#c3 (10dan) * after a bit of further investigation, it looks like this web server may have been hacked: http://www.soumaya.com.mx/imagenes/2003/ * and the images in th... [13:18:07] (03PS2) 10Reedy: Make replaceInternal return the colours array [core] - 10https://gerrit.wikimedia.org/r/143220 [13:18:30] anyone feel like taking a punt on https://gerrit.wikimedia.org/r/#/c/143220/ ? [13:23:23] 3MediaWiki extensions / 3WikidataRepo: Create browser smoke test for a typical item - 10https://bugzilla.wikimedia.org/68094#c3 (10tobias.gritschacher) (In reply to Jeroen De Dauw from comment #1) > We already have many tests tauching items in some way. So what is the point > of adding a smoke test? Adding a... [13:27:08] 3MediaWiki extensions / 3WikidataRepo: Create browser smoke test for a typical item - 10https://bugzilla.wikimedia.org/68094#c4 (10tobias.gritschacher) (In reply to tobias.gritschacher from comment #3) > (In reply to Jeroen De Dauw from comment #1) > > We already have many tests tauching items in some way. S... [13:27:37] 3MediaWiki extensions / 3WikidataRepo: Create browser smoke test for a typical item - 10https://bugzilla.wikimedia.org/68094#c5 (10tobias.gritschacher) 5ASSI>3PATC https://github.com/wmde/WikidataBrowserTests/pull/11 [13:35:35] (03PS1) 10Matthias Mullie: Make recursive progressiveEnhancements work on non-FF browsers [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162579 [13:35:38] (03PS1) 10Matthias Mullie: Replace both opening & closing script tag by flowprogressivescript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162580 [13:35:41] (03Abandoned) 10Reedy: Add CiteThisPage [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/157832 (owner: 10Reedy) [13:35:44] (03Abandoned) 10Reedy: Add CiteThisPage [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/157834 (owner: 10Reedy) [13:37:09] 3MediaWiki extensions / 3CirrusSearch: Tables not being indexed - 10https://bugzilla.wikimedia.org/71233 (10Jeremy) 3NEW p:3Unprio s:3normal a:3None CirrusSearch does not appear to be indexing tables, not even into "auxiliary_text". In fact, the "auxiliary_text" field in my index appears to be empty... [13:41:22] 3Wikimedia / 3General/Unknown: Wiktionary needs usable API - 10https://bugzilla.wikimedia.org/36881#c9 (10Lydia Pintscher) To make this happen Wiktionary needs to store its data in a structured and machine readable format. We have proposals for how to make this happen at https://www.wikidata.org/wiki/Wikidat... [13:42:52] 3MediaWiki extensions / 3CirrusSearch: Tables not being indexed - 10https://bugzilla.wikimedia.org/71233#c1 (10Nik Everett) Its certainly _supposed_ to index them in the auxiliary text. What is in the index for pages with just tables? Can you run ?action=cirrusdump on one? Can you null edit a page and see... [13:49:28] (03CR) 10Chad: [C: 032] Add more retry logic to reindexing [extensions/CirrusSearch] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162571 (owner: 10Manybubbles) [13:50:01] (03Merged) 10jenkins-bot: Add more retry logic to reindexing [extensions/CirrusSearch] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162571 (owner: 10Manybubbles) [13:54:01] (03CR) 10Chad: [C: 032] Redo job that counts incoming links [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/162240 (owner: 10Manybubbles) [13:54:23] (03Merged) 10jenkins-bot: Redo job that counts incoming links [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/162240 (owner: 10Manybubbles) [13:54:45] Reedy: what is https://gerrit.wikimedia.org/r/#/c/143220/ going to actually fix? [13:55:04] (03PS1) 10Manybubbles: Redo job that counts incoming links [extensions/CirrusSearch] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/162587 [13:55:13] (03PS1) 10Manybubbles: Redo job that counts incoming links [extensions/CirrusSearch] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162588 [13:55:32] jackmcbarn: the fixme :D [13:55:49] Reedy: but if nothing is broken without it returning the array, why don't we just make the outer function not return it? [13:56:51] because LinkHolderArray::replace is just called by Parser::replaceLinkHolders, and Parser::replaceLinkHolders doesn't use its return value [13:56:55] err [13:57:02] the place that Parser::replaceLinkHolders is called from i mean [13:59:39] (03CR) 10Chad: [C: 032] Redo job that counts incoming links [extensions/CirrusSearch] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/162587 (owner: 10Manybubbles) [13:59:44] (03CR) 10Chad: [C: 032] Redo job that counts incoming links [extensions/CirrusSearch] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162588 (owner: 10Manybubbles) [14:00:11] (03Merged) 10jenkins-bot: Redo job that counts incoming links [extensions/CirrusSearch] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/162587 (owner: 10Manybubbles) [14:00:13] (03Merged) 10jenkins-bot: Redo job that counts incoming links [extensions/CirrusSearch] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162588 (owner: 10Manybubbles) [14:02:11] (03PS1) 10Manybubbles: SWAT update Cirrus [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162591 [14:04:32] (03PS1) 10Manybubbles: SWAT update Cirrus [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/162592 [14:06:03] (03CR) 10Jackmcbarn: "Is there anything that actually makes use of $colors, or that expects it? I don't see any, since replace calls replaceInternal, Parser::re" [core] - 10https://gerrit.wikimedia.org/r/143220 (owner: 10Reedy) [14:07:11] (03CR) 10Chad: [C: 031] "Ready for swat." [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/162592 (owner: 10Manybubbles) [14:07:17] (03CR) 10Chad: [C: 031] "Ready for swat." [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162591 (owner: 10Manybubbles) [14:08:31] (03CR) 10Manybubbles: [C: 032] SWAT update Cirrus [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162591 (owner: 10Manybubbles) [14:11:22] 3MediaWiki / 3API: Version the API - 10https://bugzilla.wikimedia.org/39592#c14 (10Brad Jorsch) (In reply to Sam Reed (reedy) from comment #1) > If you've got a way to have all the changes without either a load of > duplicate classes, or classes with tonnes of version related > hacks/conditionals... This is... [14:11:59] (03Merged) 10jenkins-bot: SWAT update Cirrus [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162591 (owner: 10Manybubbles) [14:17:51] (03CR) 10Manybubbles: [C: 032] SWAT update Cirrus [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/162592 (owner: 10Manybubbles) [14:20:37] (03Merged) 10jenkins-bot: SWAT update Cirrus [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/162592 (owner: 10Manybubbles) [14:21:57] (03PS2) 10Matthias Mullie: [WIP] Display search results [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161947 [14:22:00] (03PS21) 10Matthias Mullie: [WIP] search [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126996 [14:34:32] (03PS1) 10Jackmcbarn: Don't check interwiki redirect targets against the blacklist [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/162597 (https://bugzilla.wikimedia.org/54769) [14:36:31] (03PS1) 10Manybubbles: Make method public so it works with zend [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/162598 [14:38:29] 3MediaWiki / 3JavaScript: API XHR requests from mediawiki do not transmit cookies when editing - 10https://bugzilla.wikimedia.org/71222#c1 (10Brad Jorsch) I cannot reproduce this. According to Firebug the cookies are being included in XHR requests to the API when I visit enwiki pages, including the request t... [14:42:52] 3MediaWiki / 3Special pages: Special:ListRedirects: Special page listing redirect linking to a category of pages - 10https://bugzilla.wikimedia.org/71231 (10Andre Klapper) p:5Unprio>3Low [14:43:12] (03CR) 10Anomie: [C: 032] Fixes to prevent duplicate rows in ActiveUser cache [core] - 10https://gerrit.wikimedia.org/r/162287 (owner: 10Aaron Schulz) [14:43:19] :) [14:43:32] anomie: Did you clear out the duplicates on s4? [14:43:34] (03CR) 10Bartosz Dziewoński: "It makes no sense to require JS for that basic functionality. Isarra's idea might work, but that's not what the fallback skin was meant fo" [core] - 10https://gerrit.wikimedia.org/r/160797 (owner: 10Anomie) [14:44:33] hoo: It'd be easy enough to just do, but I'm not sure whether I should go poking at the database directly so I haven't. [14:45:11] as long as you use a transaction and know what you're doing(tm) it's ok [14:45:27] I did that a couple of times before with nasty CA stuffs [14:49:39] (03Merged) 10jenkins-bot: Fixes to prevent duplicate rows in ActiveUser cache [core] - 10https://gerrit.wikimedia.org/r/162287 (owner: 10Aaron Schulz) [14:57:07] 3MediaWiki-Vagrant / 3labs-vagrant: labs-vagrant provision failing in createAndPromote Selenium_user - 10https://bugzilla.wikimedia.org/71219#c1 (10Bryan Davis) This is directly related to the git::clone issue that I emailed labs-l about recently ( (03CR) 10Chad: [C: 032] Make method public so it works with zend [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/162598 (owner: 10Manybubbles) [14:58:23] (03Merged) 10jenkins-bot: Make method public so it works with zend [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/162598 (owner: 10Manybubbles) [14:58:45] (03PS1) 10Manybubbles: Make method public so it works with zend [extensions/CirrusSearch] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162600 [14:58:56] 3MediaWiki-Vagrant / 3labs-vagrant: labs-vagrant provision failing in Mediawiki::Import_dump[labs_privacy]/Exec[import_dump_labs_privacy] - 10https://bugzilla.wikimedia.org/70959#c12 (10Bryan Davis) 5PATC>3RESO/FIX (In reply to spage from comment #11) > Labs provision is still failing in this script, but... [15:00:52] (03PS2) 10Anomie: Add API output skin [core] - 10https://gerrit.wikimedia.org/r/160797 [15:01:18] aude: I messed with your role::memcached a bit last night and made it depend on a restored version of our old memcached provisioning class. Test it out when you get a chance and +/-1 or +2 as you feel comfortable. [15:01:28] bd808: yay [15:02:23] (03CR) 10Anomie: "PS2: Since people are getting confused by the purpose of the "fallback" skin and I expect Design is going to want to add some chrome event" [core] - 10https://gerrit.wikimedia.org/r/160797 (owner: 10Anomie) [15:05:25] I'm trying to think of a better way to manage things like that where we want to choose one of two or three variants to provision. It would be nice to do something similar for php5/hhvm, mysql/mariadb. The tricky bit is that we'd like things to "just work" with no user configuration but allow a role to swap one for the other. Puppet doesn't seem to handle that sort of behavior easily as far as I can tell. [15:06:16] It might end up being something we stuff into the initial setup.sh script I guess. [15:06:51] 3MediaWiki / 3API: ApiQueryAllUsers with auactiveusers fails on duplicate querycachetwo rows - 10https://bugzilla.wikimedia.org/71086#c7 (10Brad Jorsch) (In reply to Aaron Schulz from comment #3) > As for the duplicates already there, I guess the cache can just be > cleared/rebuilt. Do we have a script for... [15:06:58] (03CR) 10Chad: [C: 032] Make method public so it works with zend [extensions/CirrusSearch] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162600 (owner: 10Manybubbles) [15:07:18] (03Merged) 10jenkins-bot: Make method public so it works with zend [extensions/CirrusSearch] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162600 (owner: 10Manybubbles) [15:07:21] 3MediaWiki / 3API: ApiQueryAllUsers with auactiveusers fails on duplicate querycachetwo rows - 10https://bugzilla.wikimedia.org/71086 (10Brad Jorsch) 5PATC>3NEW [15:08:07] (03PS3) 10Anomie: Add API output skin [core] - 10https://gerrit.wikimedia.org/r/160797 [15:09:21] 3MediaWiki / 3JavaScript: API XHR requests from mediawiki do not transmit cookies when editing - 10https://bugzilla.wikimedia.org/71222#c2 (10Giuseppe Lavagetto) 5NEW>3RESO/INV Upon further analysis; this happened because of a bug in a chromium adblocking extension I was using, which blocked cookies in G... [15:10:47] (03PS1) 10Phuedx: Fix missing global variable declaration [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/162601 [15:13:05] (03PS1) 10Manybubbles: SWAT update Cirrus [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162602 [15:14:02] (03CR) 10Bartosz Dziewoński: [C: 032] "Let's do this. This is perhaps a bit weird, but reasonable given the overall state of things." [core] - 10https://gerrit.wikimedia.org/r/160797 (owner: 10Anomie) [15:14:09] (03CR) 10Chad: [C: 032] SWAT update Cirrus [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162602 (owner: 10Manybubbles) [15:20:10] 3MediaWiki-Vagrant: Add ability to choose between alternate roles (redis/memcached, php5/hhvm, mysql/mariadb) - 10https://bugzilla.wikimedia.org/71235 (10Bryan Davis) 3NEW p:3Unprio s:3enhanc a:3None We have several roles or potential roles that provide conflicting or redundant services: HHVM vs PHP5,... [15:20:26] 3MediaWiki-Vagrant: Add ability to choose between alternate roles (redis/memcached, php5/hhvm, mysql/mariadb) - 10https://bugzilla.wikimedia.org/71235 (10Bryan Davis) p:5Unprio>3Low [15:20:43] (03Merged) 10jenkins-bot: Add API output skin [core] - 10https://gerrit.wikimedia.org/r/160797 (owner: 10Anomie) [15:22:09] (03PS5) 10Divec: translateAnnotations with partial mapping [services/cxserver] - 10https://gerrit.wikimedia.org/r/156518 [15:22:18] (03PS3) 10Divec: WIP: Derive MT subsentence map from uppercasing [services/cxserver] - 10https://gerrit.wikimedia.org/r/157141 [15:23:39] (03CR) 10Anomie: "Code looks like it'll do what is intended." [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/162597 (https://bugzilla.wikimedia.org/54769) (owner: 10Jackmcbarn) [15:25:39] (03CR) 10Chad: [C: 032] Revert "Auto-migrate matching accounts where no global account exists" [extensions/CentralAuth] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162550 (https://bugzilla.wikimedia.org/71223) (owner: 10Legoktm) [15:26:08] 3MediaWiki / 3Parser: Tidy sometimes goes ballistic when a block-level element is wrapped in an inline element - 10https://bugzilla.wikimedia.org/9737#c15 (10Pravin) This seems to be problem with IE only. When I write: #One #Two #Three #One #Two #Three I see (screenshot in Firefo... [15:26:17] (03Merged) 10jenkins-bot: Revert "Auto-migrate matching accounts where no global account exists" [extensions/CentralAuth] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162550 (https://bugzilla.wikimedia.org/71223) (owner: 10Legoktm) [15:26:24] (03PS1) 10Jack Phoenix: MatmaRex, I owe you one [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/162603 [15:26:32] (03CR) 10Jackmcbarn: "I'm not too worried about that. (In fact, I'm not even sure why we check redirect targets at all. This "feature" was only added in https:/" [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/162597 (https://bugzilla.wikimedia.org/54769) (owner: 10Jackmcbarn) [15:26:42] (03CR) 10MaxSem: [C: 032] Restore puppet module for provisioning memcached [vagrant] - 10https://gerrit.wikimedia.org/r/162537 (owner: 10BryanDavis) [15:26:50] (03Merged) 10jenkins-bot: Restore puppet module for provisioning memcached [vagrant] - 10https://gerrit.wikimedia.org/r/162537 (owner: 10BryanDavis) [15:27:00] (03CR) 10Jack Phoenix: [C: 032 V: 032] MatmaRex, I owe you one [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/162603 (owner: 10Jack Phoenix) [15:27:45] anomie: should i just rip the entire redirect check out, or can you think of a useful purpose it serves? [15:27:51] (03CR) 10Chad: [C: 032] Add cURL constants test [core] - 10https://gerrit.wikimedia.org/r/159159 (https://bugzilla.wikimedia.org/70570) (owner: 10Dan-nl) [15:28:17] (03Abandoned) 10Chad: Require PHP 5.4.0 [core] - 10https://gerrit.wikimedia.org/r/158895 (owner: 10Withoutaname) [15:28:18] jackmcbarn: Check when it was added to see if the commit summary included reasoning or a bug link? [15:28:24] anomie: i did, it did not [15:28:51] jackmcbarn: I have no idea then. [15:29:12] i'll create a second patch to do that, and if it gets merged, i'll abandon this one [15:29:22] 3Wikimedia / 3Wikidata: blacklist a number of properties in the entity suggester - 10https://bugzilla.wikimedia.org/70346 (10Aude) 5PATC>3RESO/FIX [15:30:29] (03CR) 10Chad: [C: 031] "I think Timo's comments still need a response from Ori :)" [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/120592 (owner: 10Ori.livneh) [15:30:39] (03PS1) 10Legoktm: Update CentralAuth to I3a8ec44c66a [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162605 [15:30:51] ^demon|away: ^ [15:31:27] (03PS1) 10Reedy: Update CentralAuth to 1.24wmf22 HEAD [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162606 [15:31:33] (03CR) 10Chad: [C: 032] Update CentralAuth to I3a8ec44c66a [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162605 (owner: 10Legoktm) [15:33:37] 3MediaWiki extensions / 3CirrusSearch: Tables not being indexed - 10https://bugzilla.wikimedia.org/71233#c2 (10Jeremy) Performing action=cirrusdump shows "auxiliary_text":[] The actual table is indexed in the "source_text" field. Also, it appears that the page *did* get indexed, I just couldn't find it in... [15:35:36] (03Merged) 10jenkins-bot: Add cURL constants test [core] - 10https://gerrit.wikimedia.org/r/159159 (https://bugzilla.wikimedia.org/70570) (owner: 10Dan-nl) [15:35:38] (03CR) 10Hoo man: [C: 032] Fix missing global variable declaration [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/162601 (owner: 10Phuedx) [15:35:41] (03Merged) 10jenkins-bot: Update CentralAuth to I3a8ec44c66a [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162605 (owner: 10Legoktm) [15:36:27] (03CR) 10Gergő Tisza: [C: 032] "Tested, works fine." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/162227 (https://bugzilla.wikimedia.org/71160) (owner: 10Gilles) [15:36:30] (03Merged) 10jenkins-bot: Fix missing global variable declaration [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/162601 (owner: 10Phuedx) [15:36:38] 3MediaWiki-Vagrant: /usr/lib/hphp/hphpize/hphpize.cmake has /root/hhvm/joe/hhvm in HHVM_INCLUDE_DIRS - 10https://bugzilla.wikimedia.org/71177#c2 (10Antoine "hashar" Musso) As described on bug 68944, I wrote a workaround for that issue https://gerrit.wikimedia.org/r/#/c/150895/ Basically run: hphpize sed... [15:36:59] (03PS1) 10Jackmcbarn: Don't test against redirect targets [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/162607 [15:37:05] (03Merged) 10jenkins-bot: Make options of a custom campaign field parseable [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/162227 (https://bugzilla.wikimedia.org/71160) (owner: 10Gilles) [15:37:50] (03CR) 10Jackmcbarn: "If https://gerrit.wikimedia.org/r/162607 gets merged (which does rip it out entirely), then this can be abandoned." [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/162597 (https://bugzilla.wikimedia.org/54769) (owner: 10Jackmcbarn) [15:38:37] 3MediaWiki extensions / 3CentralAuth: User with unattached accounts unable to login (504) after 1.24wmf22 deployment - 10https://bugzilla.wikimedia.org/71223#c8 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX Revert has been deployed. [15:39:37] 3MediaWiki extensions / 3CentralAuth: Allow to automatically unify on login absent clashes - 10https://bugzilla.wikimedia.org/70392#c3 (10Kunal Mehta (Legoktm)) 5RESO/FIX>3REOP Patch was reverted due to bug 71223. [15:41:25] 3MediaWiki extensions / 3CirrusSearch: Tables not being indexed - 10https://bugzilla.wikimedia.org/71233#c3 (10Nik Everett) 5NEW>3ASSI a:3Nik Everett If the json comes back with "auxiliary_text":[] that means Cirrus is sending the table empty. Do you have any auxiliary text in the index at all? Maybe... [15:42:30] (03PS1) 10Bartosz Dziewoński: Split SkinTemplate.php per-class [core] - 10https://gerrit.wikimedia.org/r/162608 [15:42:32] (03PS1) 10Bartosz Dziewoński: Implement page status indicators [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) [15:42:39] (03PS1) 10Bartosz Dziewoński: Add support for page status indicators [skins/Vector] - 10https://gerrit.wikimedia.org/r/162610 (https://bugzilla.wikimedia.org/23796) [15:43:10] 3MediaWiki / 3Change tagging: Automatically tag edits that make a redirect, or that converts a redirected page to a normal page - 10https://bugzilla.wikimedia.org/71236 (10Jesús Martínez Novo (Ciencia Al Poder)) 3NEW p:3Unprio s:3enhanc a:3None When one creates a redirect without filling an edit summ... [15:43:28] (03PS1) 10Anomie: API: ApiBase::PROP_* constants are deprecated [core] - 10https://gerrit.wikimedia.org/r/162611 [15:43:39] 3MediaWiki / 3Special pages: Special:ListRedirects: Special page listing redirect linking to a category of pages - 10https://bugzilla.wikimedia.org/71231 (10Jesús Martínez Novo (Ciencia Al Poder)) [15:43:52] 3MediaWiki / 3Change tagging: Automatically tag edits that make a redirect, or that converts a redirected page to a normal page - 10https://bugzilla.wikimedia.org/71236 (10Jesús Martínez Novo (Ciencia Al Poder)) [15:44:32] (03CR) 10Anomie: "I plan to backport this to REL1_24 once it's merged." [core] - 10https://gerrit.wikimedia.org/r/162611 (owner: 10Anomie) [15:45:26] (03CR) 10Legoktm: [C: 032] API: ApiBase::PROP_* constants are deprecated [core] - 10https://gerrit.wikimedia.org/r/162611 (owner: 10Anomie) [15:45:34] (03PS1) 10Legoktm: API: ApiBase::PROP_* constants are deprecated [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/162614 [15:45:46] (03CR) 10Legoktm: [C: 032] API: ApiBase::PROP_* constants are deprecated [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/162614 (owner: 10Legoktm) [15:46:54] 3MediaWiki / 3Page protection: Tag protected items with a padlock - 10https://bugzilla.wikimedia.org/62554 (10Bartosz Dziewoński) a:5Wikidata bugs>3None [15:48:03] (03CR) 10Jackmcbarn: "Why do indicators need to have a key?" [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [15:48:24] 3MediaWiki / 3Documentation: Link translatable help pages on mediawiki.org from the relevant special pages, actions etc. - 10https://bugzilla.wikimedia.org/43591#c8 (10Bartosz Dziewoński) The implementation proposed by Nemo looks like it would benefit from having bug 23796 solved first, so I'm marking this a... [15:48:24] 3MediaWiki / 3Page editing: Provide a way to set page meta-data flags ("featured article", "protected", etc.), configure which ones are available for a wiki, and display icons indicating these statuses - 10https://bugzilla.wikimedia.org/23796 (10Bartosz Dziewoński) [15:48:59] (03PS1) 10Anomie: Fix API-related 1.25 release notes [core] - 10https://gerrit.wikimedia.org/r/162615 [15:49:32] (03CR) 10Anomie: [C: 032] "RELEASE-NOTES only change" [core] - 10https://gerrit.wikimedia.org/r/162615 (owner: 10Anomie) [15:50:51] (03CR) 10Jackmcbarn: Implement page status indicators (032 comments) [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [15:51:07] (03CR) 10Bartosz Dziewoński: "To provide the 'id' attributes mentioned under "Wiki-customizable", to prevent duplicates when an indicator is added more than once as men" [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [15:51:11] (03CR) 10Legoktm: "Hmm, r40805 doesn't really have a rationale on it. :/ I added Fran as a reviewer though." [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/162607 (owner: 10Jackmcbarn) [15:52:00] (03CR) 10Jackmcbarn: "Couldn't we make IDs optional and still get all of those benefits?" [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [15:52:02] (03PS1) 10Jack Phoenix: LightBox fix, removed legacy i18n file, removed $dir [extensions/PictureGame] - 10https://gerrit.wikimedia.org/r/162616 [15:52:08] (03CR) 10Legoktm: [C: 032] Split SkinTemplate.php per-class [core] - 10https://gerrit.wikimedia.org/r/162608 (owner: 10Bartosz Dziewoński) [15:52:17] (03Merged) 10jenkins-bot: API: ApiBase::PROP_* constants are deprecated [core] - 10https://gerrit.wikimedia.org/r/162611 (owner: 10Anomie) [15:52:21] (03CR) 10Jack Phoenix: [C: 032 V: 032] LightBox fix, removed legacy i18n file, removed $dir [extensions/PictureGame] - 10https://gerrit.wikimedia.org/r/162616 (owner: 10Jack Phoenix) [15:53:07] 3MediaWiki / 3Documentation: Link translatable help pages on mediawiki.org from the relevant special pages, actions etc. - 10https://bugzilla.wikimedia.org/43591#c9 (10Nemo) (In reply to Bartosz Dziewoński from comment #8) > The implementation proposed by Nemo looks like it would benefit from having > bug 23... [15:53:22] 3MediaWiki / 3Page editing: Provide a way to set page meta-data flags ("featured article", "protected", etc.), configure which ones are available for a wiki, and display icons indicating these statuses - 10https://bugzilla.wikimedia.org/23796 (10Nemo) [15:53:32] (03Merged) 10jenkins-bot: API: ApiBase::PROP_* constants are deprecated [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/162614 (owner: 10Legoktm) [15:53:34] (03PS1) 10Jack Phoenix: LightBox fix, removed legacy i18n file, removed $dir [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/162617 [15:53:48] (03CR) 10Jack Phoenix: [C: 032 V: 032] LightBox fix, removed legacy i18n file, removed $dir [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/162617 (owner: 10Jack Phoenix) [15:54:28] (03CR) 10Bartosz Dziewoński: Implement page status indicators (031 comment) [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [15:54:53] (03CR) 10Legoktm: "> Indicators are not stored, tracked or accessible outside of ParserOutput" [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [15:56:44] (03Merged) 10jenkins-bot: Fix API-related 1.25 release notes [core] - 10https://gerrit.wikimedia.org/r/162615 (owner: 10Anomie) [15:57:54] 3MediaWiki extensions / 3WikidataRepo: Tag protected items with a padlock - 10https://bugzilla.wikimedia.org/62554 (10Lydia Pintscher) a:3Wikidata bugs [15:58:52] 3MediaWiki / 3Documentation: Link translatable help pages on mediawiki.org from the relevant special pages, actions etc. - 10https://bugzilla.wikimedia.org/43591#c10 (10Bartosz Dziewoński) I did that as a note-to-self to implement this later. But okay. [15:59:10] (03Merged) 10jenkins-bot: Split SkinTemplate.php per-class [core] - 10https://gerrit.wikimedia.org/r/162608 (owner: 10Bartosz Dziewoński) [16:02:21] (03CR) 10Jackmcbarn: Implement page status indicators (031 comment) [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [16:02:46] (03CR) 10Legoktm: "Thanks! I wish we could have spotted this with CentralAuth tests themselves..." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/162601 (owner: 10Phuedx) [16:02:56] (03PS2) 10Anomie: Profiling for Language::fetchLanguageNames [core] - 10https://gerrit.wikimedia.org/r/162202 (owner: 10Tim Starling) [16:03:03] (03CR) 10Anomie: [C: 032] "I note the followup Ib826ea6f basically undoes this, but that's no harm." [core] - 10https://gerrit.wikimedia.org/r/162202 (owner: 10Tim Starling) [16:03:18] (03PS2) 10Anomie: Add a process cache for fetchLanguageNames [core] - 10https://gerrit.wikimedia.org/r/162203 (owner: 10Tim Starling) [16:03:23] (03CR) 10Bartosz Dziewoński: "Jackmcbarn, probably, we could still get these benefits for the indicators that have a name and just check it was provided everywhere. I'm" [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [16:03:26] (03CR) 10Anomie: [C: 032] Add a process cache for fetchLanguageNames [core] - 10https://gerrit.wikimedia.org/r/162203 (owner: 10Tim Starling) [16:04:34] (03CR) 10Jackmcbarn: "It's not a big deal. It just seems odd to require names, since there's nothing else like this that requires names." [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [16:04:37] 3MediaWiki / 3Documentation: Link translatable help pages on mediawiki.org from the relevant special pages, actions etc. - 10https://bugzilla.wikimedia.org/43591#c11 (10Nemo) (In reply to Bartosz Dziewoński from comment #10) > I did that as a note-to-self to implement this later. But okay. That's appreciate... [16:06:00] (03CR) 10Bartosz Dziewoński: "Legoktm, I'm going to implement page protection indicator in core in a follow-up patch (guarded by a config variable, just in case). Most " [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [16:07:00] (03CR) 10Edokter: [C: 04-1] "Not an improvement, and bound to conflict with other people's preferences. This could be solved using a more consistent font stack for the" [skins/Vector] - 10https://gerrit.wikimedia.org/r/162304 (owner: 10Isarra) [16:07:03] (03CR) 10Bartosz Dziewoński: "s/difficult/ugly/" [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [16:07:57] (03CR) 10Bartosz Dziewoński: [C: 031] Make h1-6 sizes consistently different [skins/Vector] - 10https://gerrit.wikimedia.org/r/162304 (owner: 10Isarra) [16:08:50] (03PS10) 10Anomie: API: HTMLize and internationalize the help, add Special:ApiHelp [core] - 10https://gerrit.wikimedia.org/r/160798 (https://bugzilla.wikimedia.org/30936) [16:10:05] (03Merged) 10jenkins-bot: Profiling for Language::fetchLanguageNames [core] - 10https://gerrit.wikimedia.org/r/162202 (owner: 10Tim Starling) [16:10:58] (03PS3) 10Anomie: API: Make jsonfm the default output format [core] - 10https://gerrit.wikimedia.org/r/160819 [16:11:16] (03Merged) 10jenkins-bot: Add a process cache for fetchLanguageNames [core] - 10https://gerrit.wikimedia.org/r/162203 (owner: 10Tim Starling) [16:11:50] (03CR) 10Isarra: ""Not an improvement" - elaborate, please? That's not much to go on." [skins/Vector] - 10https://gerrit.wikimedia.org/r/162304 (owner: 10Isarra) [16:12:03] (03CR) 10Jackmcbarn: "If a template makes an indicator appear on a page, it needs to be visible through the API somehow (either not discarded in expandtemplates" [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [16:13:40] (03CR) 10Bartosz Dziewoński: "Ugh, right, I should add support for this to some API modules. Should be easy, but I forgot about it. Will do later today." [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [16:14:51] (03PS2) 10Chad: Remove old i18n fallback. We don't support anything below 1.23 anyway [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/162522 [16:15:08] 3MediaWiki skins / 3Vector: h4, h5, and h6 headers should not have the same styling - 10https://bugzilla.wikimedia.org/70004#c13 (10Nemo) (In reply to Brandon Harris from comment #12) > Let's not forget that individual wikis [...] should [...] adjust [...] > Common.css. This is particularly true > for wikis... [16:15:40] (03CR) 10SG: [C: 032] Make recursive progressiveEnhancements work on non-FF browsers [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162579 (owner: 10Matthias Mullie) [16:15:54] (03CR) 10Nemo bis: "It would be useful if the bug stated in what version this bug is present: is it in 1.23 already? Will backports be needed? (Please answer " [skins/Vector] - 10https://gerrit.wikimedia.org/r/162304 (owner: 10Isarra) [16:16:25] (03Merged) 10jenkins-bot: Make recursive progressiveEnhancements work on non-FF browsers [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162579 (owner: 10Matthias Mullie) [16:23:07] (03CR) 10Legoktm: [C: 032] Remove old i18n fallback. We don't support anything below 1.23 anyway [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/162522 (owner: 10Chad) [16:23:12] (03PS6) 10Anomie: API: Clean up and internationalize pretty-printed output [core] - 10https://gerrit.wikimedia.org/r/161093 (https://bugzilla.wikimedia.org/65403) [16:23:28] <^demon|away> legoktm: micro-optimizations! [16:23:28] (03Merged) 10jenkins-bot: Remove old i18n fallback. We don't support anything below 1.23 anyway [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/162522 (owner: 10Chad) [16:23:56] :D [16:26:26] 3OCG / 3General/Unknown: Re-examine icinga warning thresholds and job expiry. - 10https://bugzilla.wikimedia.org/71239 (10C. Scott Ananian) 3NEW p:3Unprio s:3normal a:3None Before OCG was turned on for everyone, we had a 30k icinga warning limit for the job status queue. Since entries expire from th... [16:27:24] (03CR) 10Anomie: Return coordinates from a given point (031 comment) [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/161623 (owner: 10MaxSem) [16:30:23] 3Wikimedia / 3lucene-search-2: Search index not updating on en.wikipedia - 10https://bugzilla.wikimedia.org/66011#c12 (10SpontaneousGrumbler) Well, LuceneSearch's index got updated today (24 September 2014). Thanks to the person who got it running! [16:30:39] 3MediaWiki skins / 3Vector: Re-evaluate serif font stack for headers - 10https://bugzilla.wikimedia.org/71240 (10Isarra) 3NEW p:3Unprio s:3normal a:3None In vector, the h1 and h2 use serif fonts (everything else is sans-serif). Unfortunately the font stack used results in a highly inconsistent user e... [16:35:10] 3Wikimedia / 3Site requests: Complete unification of all accounts to SUL - 10https://bugzilla.wikimedia.org/35707 (10Nemo) [16:35:10] 3Wikimedia / 3Site requests: Maintenance scripts waiting to be run on Wikimedia wikis (tracking) - 10https://bugzilla.wikimedia.org/29782 (10Nemo) [16:35:12] 3Wikimedia / 3Site requests: Run sendConfirmAndMigrateEmail.php for all unconfirmed emails on all wikis - 10https://bugzilla.wikimedia.org/71241 (10Nemo) 3NEW p:3Unprio s:3normal a:3None We can't unify nor notify users if we don't know their email addresses for sure. This script was written last year... [16:35:51] (03CR) 10Anomie: "Code looks good. Wording nitpicks." (032 comments) [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/161623 (owner: 10MaxSem) [16:36:40] (03CR) 10Anomie: Return coordinates from a given point (031 comment) [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/161623 (owner: 10MaxSem) [16:36:52] 3MediaWiki / 3MediaWiki UI: Use mw-ui-icon (tracking) - 10https://bugzilla.wikimedia.org/71180 (10Jon) 5PATC>3NEW [16:40:47] (03PS1) 10Chad: Use proper page sizes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/162627 (https://bugzilla.wikimedia.org/70919) [16:40:52] 3MediaWiki skins / 3Vector: Vector: h3 should not appear as heavier weight than h2 - 10https://bugzilla.wikimedia.org/69998#c16 (10Isarra) Related: Bug 71240 - Re-evaluate serif font stack for headers (I know bugzilla has a thing for related bugs somewhere, but the interface doesn't really give any hints as... [16:41:53] (03CR) 10Isarra: "Nemo: Aiight. Why can't comments be imported, though?" [skins/Vector] - 10https://gerrit.wikimedia.org/r/162304 (owner: 10Isarra) [16:42:56] (03CR) 10Legoktm: [C: 032] Remove $wgTitle usage [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/162151 (owner: 10Chad) [16:45:23] (03Merged) 10jenkins-bot: Remove $wgTitle usage [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/162151 (owner: 10Chad) [16:45:28] Isarra: if you discover the answer, please document it: https://www.mediawiki.org/wiki/Gerrit/Tutorial#How_to_comment_on.2C_review.2C_and_merge_code_in_Gerrit [16:46:15] (03PS1) 10SG: Add back flow-menu to no-JS, but hide edit/moderation actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162629 [16:46:22] (03PS1) 10Jack Phoenix: Get rid of the do/endHover JS functions in favor of a pure CSS solution, as suggested by MatmaRex [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/162630 [16:46:55] (03PS1) 10BryanDavis: Do not start puppet agent in Labs [vagrant] - 10https://gerrit.wikimedia.org/r/162631 (https://bugzilla.wikimedia.org/70421) [16:47:06] (03CR) 10jenkins-bot: [V: 04-1] Add back flow-menu to no-JS, but hide edit/moderation actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162629 (owner: 10SG) [16:47:13] (03Abandoned) 10Aude: Add Wikidata / test wikidata site link section messages [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148389 (owner: 10Aude) [16:47:52] 3MediaWiki skins / 3Vector: Re-evaluate serif font stack for headers - 10https://bugzilla.wikimedia.org/71240 (10Jesús Martínez Novo (Ciencia Al Poder)) [16:47:54] 3MediaWiki skins / 3Vector: Vector: h3 should not appear as heavier weight than h2 - 10https://bugzilla.wikimedia.org/69998#c17 (10Jesús Martínez Novo (Ciencia Al Poder)) (In reply to Isarra from comment #16) > Related: Bug 71240 - Re-evaluate serif font stack for headers > > (I know bugzilla has a thing fo... [16:48:22] 3MediaWiki skins / 3Vector: h4, h5, and h6 headers should not have the same styling - 10https://bugzilla.wikimedia.org/70004#c14 (10Isarra) General note: This was changed in 1.23. Also still waiting for a confirmation of why it was done. [16:48:32] (03Abandoned) 10Aude: Add script for renaming a user option [core] - 10https://gerrit.wikimedia.org/r/117872 (owner: 10Aude) [16:49:10] 3MediaWiki extensions / 3CentralAuth: sendConfirmAndMigrateEmail.php: add an option to include emailconfirmed accounts - 10https://bugzilla.wikimedia.org/54760 (10Nemo) [16:49:10] 3Wikimedia / 3Site requests: Run sendConfirmAndMigrateEmail.php for all unconfirmed emails on all wikis - 10https://bugzilla.wikimedia.org/71241 (10Nemo) [16:49:10] 3MediaWiki skins / 3Vector: Vector: h3 should not appear as heavier weight than h2 - 10https://bugzilla.wikimedia.org/69998#c18 (10Isarra) Thanks. [16:49:47] (03PS2) 10SG: Implement closeOutClick option in mw.Modal [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162196 [16:49:51] (03PS2) 10SG: Hide mw.Modal next button [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162197 [16:50:38] (03CR) 10Bartosz Dziewoński: [C: 032] Get rid of the do/endHover JS functions in favor of a pure CSS solution, as suggested by MatmaRex [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/162630 (owner: 10Jack Phoenix) [16:52:48] (03Merged) 10jenkins-bot: Get rid of the do/endHover JS functions in favor of a pure CSS solution, as suggested by MatmaRex [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/162630 (owner: 10Jack Phoenix) [16:54:52] (03CR) 10Aude: "this worked fine for me, as-is, but might be nice to increase the RAM" [vagrant] - 10https://gerrit.wikimedia.org/r/162285 (owner: 10Aude) [16:57:01] (03PS1) 10Chad: $wgTitle is not needed for running parser tests [core] - 10https://gerrit.wikimedia.org/r/162633 [16:57:06] <^demon|away> legoktm: ^ :D [16:57:34] :o [16:57:37] * legoktm waits for jenkins to run [16:58:16] <^demon|away> Jenkins doesn't run that script. [16:58:20] <^demon|away> But yeah :) [16:58:25] (03CR) 10BryanDavis: "Upping the minimum ram requirement can be done with a vagrant::settings resource. There is an example in role::cirrussearch oh it doesn't? [16:59:37] 3MediaWiki extensions / 3CirrusSearch: Tables not being indexed - 10https://bugzilla.wikimedia.org/71233#c4 (10Jeremy) As far as I can tell auxiliary_text is completely empty in the index. I'm on MW 1.23.3, PHP 5.3.10. [17:01:39] <^demon|away> legoktm: Nope. That's the standalone non-phpunit test thingie. [17:02:43] (03CR) 10Chad: [C: 032] Rewrite BlobStore support [search/repository-swift] - 10https://gerrit.wikimedia.org/r/158279 (owner: 10Chad) [17:03:02] (03CR) 10Chad: Rewrite BlobStore support [search/repository-swift] - 10https://gerrit.wikimedia.org/r/158279 (owner: 10Chad) [17:03:04] (03CR) 10jenkins-bot: [V: 04-1] Rewrite BlobStore support [search/repository-swift] - 10https://gerrit.wikimedia.org/r/158279 (owner: 10Chad) [17:04:52] 3Wikimedia / 3SVG rendering: SVG renderer does not support the tag - 10https://bugzilla.wikimedia.org/8552#c23 (10PRO) (In reply to Antoine "hashar" Musso from comment #22) > The example usage mentioned in Comment #5 still fails rendering properly. Ie: > > https://commons.wikimedia.org/wiki/File:P... [17:07:51] (03CR) 10Manybubbles: [C: 032] Use proper page sizes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/162627 (https://bugzilla.wikimedia.org/70919) (owner: 10Chad) [17:08:06] (03Merged) 10jenkins-bot: Use proper page sizes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/162627 (https://bugzilla.wikimedia.org/70919) (owner: 10Chad) [17:09:25] (03PS2) 10EBernhardson: Set a maximum height to auto-expanding text fields [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162363 (https://bugzilla.wikimedia.org/58657) [17:09:39] ^demon|away: did you test that? I'm running the parser tests right now but have no idea how long it'll take. [17:09:46] <^demon|away> I diddddd [17:09:52] <^demon|away> Only took about a minute or two for me. [17:10:11] hm, I'm already at 4 minues, I guess my vm is being slow [17:10:26] yeah, it's maxing out on CPU [17:13:02] (03CR) 10Legoktm: [C: 032] $wgTitle is not needed for running parser tests [core] - 10https://gerrit.wikimedia.org/r/162633 (owner: 10Chad) [17:14:48] (03PS1) 10Legoktm: Change prop=flowinfo prefix to "fli" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162640 [17:14:55] anomie: ^ [17:15:40] 3OCG / 3General/Unknown: More specific logging - 10https://bugzilla.wikimedia.org/71242 (10C. Scott Ananian) 3NEW p:3Unprio s:3normal a:3None From Jeff Green: "I noticed that logging changed around 9/11 in a way that broke syslog collation into /var/log/ocg.log. Before that date we had ident strings... [17:15:54] 3Wikimedia / 3Wikidata: $wgAppleTouchIcon is wrong for Wikidata (showing Wikipedia logo) - 10https://bugzilla.wikimedia.org/70996#c5 (10Glaisher) a:5Wikidata bugs>3Glaisher I just uploaded a 180 x 101 file. Is that an okay size? [17:16:09] 3Wikimedia / 3lucene-search-2: Search index not updating on en.wikipedia - 10https://bugzilla.wikimedia.org/66011#c13 (10Nik Everett) 5RESO/WON>3RESO/FIX a:3Chad H. Chad got it! He fixed it yesterday but it takes a day to really be sure it worked. [17:16:37] 3Wikimedia / 3Wikidata: $wgAppleTouchIcon is wrong for Wikidata (showing Wikipedia logo) - 10https://bugzilla.wikimedia.org/70996#c6 (10Sjoerd de Bruin) It should be square and I think with the same background as the Wikipedia one. Transparent looks ugly. [17:17:05] (03PS1) 10SG: Fix autofocus textareas being compressed into inputs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162641 [17:17:08] (03PS1) 10SG: Remove title from moderation modal [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162642 [17:18:05] (03CR) 10jenkins-bot: [V: 04-1] Remove title from moderation modal [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162642 (owner: 10SG) [17:18:07] 3MediaWiki skins / 3Vector: h4, h5, and h6 headers should not have the same styling - 10https://bugzilla.wikimedia.org/70004#c15 (10Jon) Note, LESS could be utilised to allow you to style things differently based on the current language. e.g. use a different font We can also add different css files to diffe... [17:19:05] (03Merged) 10jenkins-bot: $wgTitle is not needed for running parser tests [core] - 10https://gerrit.wikimedia.org/r/162633 (owner: 10Chad) [17:19:10] (03PS2) 10SG: Remove title from moderation modal [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162642 [17:19:52] 3MediaWiki extensions / 3CirrusSearch: Byte counts under-reported in search results - 10https://bugzilla.wikimedia.org/70919#c8 (10Chad H.) 5PATC>3RESO/FIX Should be fixed, sizes will slowly correct as patch goes out and pages are reindexed. [17:20:21] (03PS2) 10SG: Add back flow-menu to no-JS, but hide edit/moderation actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162629 [17:20:22] 3Wikimedia / 3Wikidata: $wgAppleTouchIcon is wrong for Wikidata (showing Wikipedia logo) - 10https://bugzilla.wikimedia.org/70996#c7 (10Glaisher) (In reply to Sjoerd de Bruin from comment #6) > It should be square and I think with the same background as the Wikipedia > one. Transparent looks ugly. Could you... [17:20:24] (03CR) 10Dduvall: [C: 032] "I thought it might have been the call to `Dir[]` that was failing and not `FileUtils.rm_f` but I can't reproduce it now... In any case, th" [vagrant] - 10https://gerrit.wikimedia.org/r/160910 (owner: 10BryanDavis) [17:20:26] (03CR) 10Aaron Schulz: [C: 032] Per 5a4a33a, remove support for magic quotes gpc [core] - 10https://gerrit.wikimedia.org/r/162146 (owner: 10Chad) [17:22:08] (03CR) 10SG: [C: 04-1] Set a maximum height to auto-expanding text fields (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162363 (https://bugzilla.wikimedia.org/58657) (owner: 10EBernhardson) [17:22:10] 3MediaWiki / 3MediaWiki UI: Baseline for icon buttons incorrect if there is no text - 10https://bugzilla.wikimedia.org/71243 (10Prateek Saxena) 3NEW p:3Unprio s:3normal a:3None This might only be happening on the styleguide. http://tools.wmflabs.org/styleguide/desktop/section-4.html [17:22:25] 3MediaWiki / 3MediaWiki UI: Baseline for icon buttons incorrect if there is no text - 10https://bugzilla.wikimedia.org/71243 (10Prateek Saxena) [17:22:25] 3MediaWiki / 3MediaWiki UI: Remove $wgUseMediaWikiUIEverywhere dependency for button and text input styling (tracking) - 10https://bugzilla.wikimedia.org/70913 (10Prateek Saxena) [17:23:32] (03CR) 10Chad: [C: 032] Remove unused system messages "loginstart", "loginend" and "loginend-https" [core] - 10https://gerrit.wikimedia.org/r/151536 (owner: 10Withoutaname) [17:25:17] (03CR) 10Legoktm: "To be clear, this patch only leaves something behind when you move a page, it doesn't actually redirect you to the new page when you visit" [core] - 10https://gerrit.wikimedia.org/r/162491 (https://bugzilla.wikimedia.org/71200) (owner: 10Legoktm) [17:26:59] (03Merged) 10jenkins-bot: Per 5a4a33a, remove support for magic quotes gpc [core] - 10https://gerrit.wikimedia.org/r/162146 (owner: 10Chad) [17:27:46] (03PS4) 10EBernhardson: Introduce Message::plaintextParam [core] - 10https://gerrit.wikimedia.org/r/161095 [17:29:13] (03PS11) 10Anomie: API: HTMLize and internationalize the help, add Special:ApiHelp [core] - 10https://gerrit.wikimedia.org/r/160798 (https://bugzilla.wikimedia.org/30936) [17:29:47] (03CR) 10SG: [C: 032] H-99: Dont collapse away the title of moderated topics in topic namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162198 (owner: 10EBernhardson) [17:29:56] (03Merged) 10jenkins-bot: Remove unused system messages "loginstart", "loginend" and "loginend-https" [core] - 10https://gerrit.wikimedia.org/r/151536 (owner: 10Withoutaname) [17:30:39] (03Merged) 10jenkins-bot: H-99: Dont collapse away the title of moderated topics in topic namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162198 (owner: 10EBernhardson) [17:32:31] (03CR) 10SG: [C: 031] Dont add permalink to topic in new-topic notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162138 (owner: 10EBernhardson) [17:34:37] 3MediaWiki / 3Database: Image and oldimage tables lack auto-incrementing primary keys - 10https://bugzilla.wikimedia.org/71198#c3 (10Nathan Larson) Or did you have in mind a system in which image would be like the page table, which stores no revision data, and only links to the latest revision; and oldimage... [17:36:47] (03CR) 10EBernhardson: "yes it appears necessary, but there may be a different way to hack arround" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162363 (https://bugzilla.wikimedia.org/58657) (owner: 10EBernhardson) [17:38:22] 3MediaWiki extensions / 3CirrusSearch: Tables not being indexed - 10https://bugzilla.wikimedia.org/71233#c5 (10Nik Everett) Ok. It won't work properly right now with MW version 1.24wmf10. That version has a change where the HtmlFormatter can return the text that it filtered out. This is how auxiliary text... [17:39:30] (03CR) 10SG: [C: 032] Change prop=flowinfo prefix to "fli" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162640 (owner: 10Legoktm) [17:40:10] (03Merged) 10jenkins-bot: Change prop=flowinfo prefix to "fli" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162640 (owner: 10Legoktm) [17:40:31] (03CR) 10SG: [C: 032] Make hide available to anonymous users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161493 (https://bugzilla.wikimedia.org/71051) (owner: 10EBernhardson) [17:40:53] (03CR) 10SG: [C: 032] Hygiene: Add missing qqq messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161490 (owner: 10EBernhardson) [17:41:09] (03Merged) 10jenkins-bot: Make hide available to anonymous users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161493 (https://bugzilla.wikimedia.org/71051) (owner: 10EBernhardson) [17:41:28] (03Merged) 10jenkins-bot: Hygiene: Add missing qqq messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161490 (owner: 10EBernhardson) [17:45:42] (03CR) 10Cscott: [C: 032] Improve Metabook.fromArticles. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/162542 (owner: 10Cscott) [17:45:57] (03CR) 10Phuedx: [C: 04-1] "This API shouldn't be exposed to the developer. Instead, logEvent should use it when it's available." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/162194 (https://bugzilla.wikimedia.org/52287) (owner: 10Prtksxna) [17:46:02] (03CR) 10Matthias Mullie: "Haven't taken a proper look at the code yet, but can't we just set a max-height on the textarea?" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162363 (https://bugzilla.wikimedia.org/58657) (owner: 10EBernhardson) [17:46:12] phuedx: I was discussing that with nuria_ [17:46:28] phuedx: If we could just use sendBeacon when available, that should be better [17:46:34] prtksxna: cool [17:46:35] sendBacon, mmmm [17:46:52] yarrrp, it should be transparent to the developer [17:46:56] i just want to send events [17:46:59] Now thats the method we should be implementing [17:47:12] if possible, i'd like to know that they've been delivered, but that's secondary [17:47:12] prtksxna on meeting, can talk later [17:47:26] (03Merged) 10jenkins-bot: Improve Metabook.fromArticles. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/162542 (owner: 10Cscott) [17:47:39] phuedx: Yeah, one will return a promise the other a boolean (mostly true) [17:47:47] (03CR) 10SG: [C: 032] I3: Include board name in topic html title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161479 (owner: 10EBernhardson) [17:47:50] nuria_: Sure, after the phabricator demo? [17:48:02] (03PS6) 10Legoktm: Add initial tests for MergeUser [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/162012 [17:48:09] phuedx, prtksxna: sure, ping me [17:48:18] (03CR) 10jenkins-bot: [V: 04-1] Add initial tests for MergeUser [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/162012 (owner: 10Legoktm) [17:48:22] * phuedx might not be around in a bit [17:48:28] (03Merged) 10jenkins-bot: I3: Include board name in topic html title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161479 (owner: 10EBernhardson) [17:48:30] * phuedx is feeling rotten at the moment [17:48:44] excited about the change though :) [17:48:44] phuedx: I'll update the patch with our discussion [17:48:50] phuedx: Oh, what happened? [17:48:50] prtksxna: thanks! [17:48:56] prtksxna: super-tired [17:48:59] (03PS1) 10Cscott: Improve load testing tool. [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/162651 [17:49:00] might have a cold [17:49:30] gonna say g'night to my kid [17:49:50] (03PS2) 10Cscott: Improve load testing tool. [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/162651 [17:49:58] phuedx: Take care o/ [17:50:07] (03CR) 10SG: [C: 04-1] Replace both opening & closing script tag by flowprogressivescript (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162580 (owner: 10Matthias Mullie) [17:52:19] (03PS3) 10Cscott: Improve load testing tool. [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/162651 [17:53:33] (03PS1) 10Jforrester: [WIP] In VisualEditor, show
elements and let them be edited [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/162652 (https://bugzilla.wikimedia.org/70581) [17:54:43] (03PS2) 10EBernhardson: Hygiene: Share pipelist decoration between history and author links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161361 [17:54:56] 3Wikimedia / 3General/Unknown: texvc missing under HHVM - 10https://bugzilla.wikimedia.org/71224#c1 (10Quiddity) AuFCL writes, at https://www.mediawiki.org/wiki/Topic:S2x174x44fnr5xx7 : when previewing results of modifying a expression on English WikiSource with HHVM enabled, this error is presented:... [17:55:49] (03CR) 10jenkins-bot: [V: 04-1] [WIP] In VisualEditor, show
elements and let them be edited [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/162652 (https://bugzilla.wikimedia.org/70581) (owner: 10Jforrester) [17:55:50] ori, legoktm ^ [17:55:54] (2 above) [17:56:23] (03PS1) 10Manybubbles: Don't remove auxiliary text if mw is too old [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/162653 (https://bugzilla.wikimedia.org/71233) [17:57:00] (03CR) 10Manybubbles: [C: 04-1] "Haven't finished running regression tests on this but it ought to work." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/162653 (https://bugzilla.wikimedia.org/71233) (owner: 10Manybubbles) [17:57:12] 3Wikimedia / 3General/Unknown: texvc missing under HHVM - 10https://bugzilla.wikimedia.org/71224#c2 (10Sam Reed (reedy)) (In reply to Michael M. from comment #0) > I don't know whether just installing texvc on the respective servers is > enough, or if there is a real issue with the extension Math under HHVM.... [17:57:16] (03CR) 10EBernhardson: "the patch title says closeOutClick, the code says clickOutClose. Tbh both names suck :P" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162196 (owner: 10SG) [17:58:40] 3MediaWiki-Vagrant: Add ability to choose between alternate roles (redis/memcached, php5/hhvm, mysql/mariadb) - 10https://bugzilla.wikimedia.org/71235#c1 (10Dan Duvall) I've been thinking about the idea of role variants as well. In addition to the conflicting-resources problem that you mentioned, there seems t... [17:58:53] (03PS12) 10Bartosz Dziewoński: API: HTMLize and internationalize the help, add Special:ApiHelp [core] - 10https://gerrit.wikimedia.org/r/160798 (https://bugzilla.wikimedia.org/30936) (owner: 10Anomie) [17:59:09] 3MediaWiki extensions / 3CirrusSearch: Tables not being indexed - 10https://bugzilla.wikimedia.org/71233#c7 (10Nik Everett) I've uploaded a patch to Cirrus that should leave the table text in the "text" field if MediaWiki doesn't yet support what we need to build the auxiliary text properly. [17:59:30] (03CR) 10Edokter: "Not an improvement; the font sizes are to close together and the H3-H6 headers look too thin. But again, the Typography page is a better v" [skins/Vector] - 10https://gerrit.wikimedia.org/r/162304 (owner: 10Isarra) [18:00:34] (03PS3) 10SG: Implement closeOutClick option in mw.Modal [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162196 [18:01:05] is that phabricator talk starting? [18:01:10] nothing on G+ [18:02:26] (03PS4) 10SG: Implement closeOnOutsideClick option in mw.Modal [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162196 [18:02:37] (03PS3) 10SG: Hide mw.Modal next button [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162197 [18:02:41] (03PS2) 10SG: Fix autofocus textareas being compressed into inputs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162641 [18:02:44] (03PS3) 10SG: Remove title from moderation modal [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162642 [18:03:54] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Slick." [core] - 10https://gerrit.wikimedia.org/r/160798 (https://bugzilla.wikimedia.org/30936) (owner: 10Anomie) [18:04:11] neilk_: https://www.youtube.com/watch?v=-fpkHyCGX1Y [18:05:03] (03PS1) 10Aaron Schulz: Fixed bug in BloomCacheRedis::getConnection [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162656 [18:07:37] (03PS7) 10Legoktm: Add initial tests for MergeUser [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/162012 [18:07:46] (03CR) 10jenkins-bot: [V: 04-1] Add initial tests for MergeUser [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/162012 (owner: 10Legoktm) [18:08:00] noooooo [18:08:18] Reedy: it was another problem, thanks, fixed :) [18:08:30] Reedy: I have blocks on sites that are likely to distract me [18:08:58] (03CR) 10Jdlrobson: [C: 032] HtmlForm: Use mw-ui-checkbox only if wgUseMediaWikiUIEverywhere is enabled [core] - 10https://gerrit.wikimedia.org/r/162509 (owner: 10Prtksxna) [18:10:12] phuedx, prtksxna: free, can talk now. [18:10:34] nuria_: At the phabricator demo, in a bit? [18:10:38] (03PS5) 10SG: Implement disableCloseOnOutsideClick option in mw.Modal [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162196 [18:10:56] (03PS1) 10Prtksxna: HtmlForm: Add @since annotation for methods added to UI standardization [core] - 10https://gerrit.wikimedia.org/r/162657 [18:11:06] prtksxna i have a meeting until 12pm, after will be fine [18:11:29] (03CR) 10Prtksxna: "Nikerabbit: Could you please review I74f58df9de79d2ad055eaf9760763005996dc0a0" [core] - 10https://gerrit.wikimedia.org/r/162484 (https://bugzilla.wikimedia.org/71144) (owner: 10Prtksxna) [18:11:40] nuria_: Sure [18:15:11] (03PS2) 10Jforrester: [WIP] In VisualEditor, show
elements and let them be edited [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/162652 (https://bugzilla.wikimedia.org/70581) [18:15:22] (03Merged) 10jenkins-bot: HtmlForm: Use mw-ui-checkbox only if wgUseMediaWikiUIEverywhere is enabled [core] - 10https://gerrit.wikimedia.org/r/162509 (owner: 10Prtksxna) [18:15:53] (03CR) 10EBernhardson: "this line didn't make it into PS5, but should" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162196 (owner: 10SG) [18:15:59] (03CR) 10Bartosz Dziewoński: "* The definition list "terms" and "definitions" don't quite align: http://i.imgur.com/1qk4tos.png. You might want to fix this with "dt { l" [core] - 10https://gerrit.wikimedia.org/r/160798 (https://bugzilla.wikimedia.org/30936) (owner: 10Anomie) [18:18:08] (03CR) 10jenkins-bot: [V: 04-1] [WIP] In VisualEditor, show
elements and let them be edited [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/162652 (https://bugzilla.wikimedia.org/70581) (owner: 10Jforrester) [18:18:28] (03PS6) 10EBernhardson: Implement disableCloseOnOutsideClick option in mw.Modal [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162196 (owner: 10SG) [18:20:06] (03CR) 10Bartosz Dziewoński: "* Example lists can be generatedwith empty
elements. Not sure if that's intentional." [core] - 10https://gerrit.wikimedia.org/r/160798 (https://bugzilla.wikimedia.org/30936) (owner: 10Anomie) [18:21:07] 3MediaWiki skins / 3Vector: Re-evaluate serif font stack for headers - 10https://bugzilla.wikimedia.org/71240#c1 (10Jared Zimmerman (WMF)) While we'd love to deliver a web font, I don't think we have the resources to fully test this for compatibility and performance at this time, but I think a lot of other p... [18:21:39] 3MediaWiki skins / 3Vector: Re-evaluate serif font stack for headers - 10https://bugzilla.wikimedia.org/71240 (10Jared Zimmerman (WMF)) p:5Unprio>3Low s:5normal>3enhanc [18:23:35] (03PS2) 10Umherirrender: HtmlForm: Add @since annotation for methods added to UI standardization [core] - 10https://gerrit.wikimedia.org/r/162657 (owner: 10Prtksxna) [18:24:03] (03CR) 10Umherirrender: [C: 032] "Corresponding changes are I1d6691dce3e7dab662bda9a718e16c5caee6c041 and I56969edb6651a26ff2579e1ed9f9da34a9536e46" [core] - 10https://gerrit.wikimedia.org/r/162657 (owner: 10Prtksxna) [18:24:23] (03CR) 10EBernhardson: [C: 04-1] Implement disableCloseOnOutsideClick option in mw.Modal (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162196 (owner: 10SG) [18:26:20] (03PS7) 10SG: Implement disableCloseOnOutsideClick option in mw.Modal [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162196 [18:29:42] (03PS1) 10Cscott: Clean up directory size computation. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/162662 [18:29:57] (03PS1) 10Yurik: timer on finally [extensions/Graph] - 10https://gerrit.wikimedia.org/r/162663 [18:29:59] (03CR) 10jenkins-bot: [V: 04-1] Clean up directory size computation. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/162662 (owner: 10Cscott) [18:30:24] (03Merged) 10jenkins-bot: HtmlForm: Add @since annotation for methods added to UI standardization [core] - 10https://gerrit.wikimedia.org/r/162657 (owner: 10Prtksxna) [18:31:25] (03CR) 10Prtksxna: "It might make sense to move this to the 'dispatch' method and use it when available. The return values will change to boolean or jQuery pr" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/162194 (https://bugzilla.wikimedia.org/52287) (owner: 10Prtksxna) [18:32:00] (03CR) 10Yurik: [C: 032] timer on finally [extensions/Graph] - 10https://gerrit.wikimedia.org/r/162663 (owner: 10Yurik) [18:32:17] (03Merged) 10jenkins-bot: timer on finally [extensions/Graph] - 10https://gerrit.wikimedia.org/r/162663 (owner: 10Yurik) [18:32:35] (03CR) 10EBernhardson: [C: 032] Implement disableCloseOnOutsideClick option in mw.Modal [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162196 (owner: 10SG) [18:32:44] (03PS4) 10EBernhardson: Hide mw.Modal next button [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162197 (owner: 10SG) [18:33:16] (03Merged) 10jenkins-bot: Implement disableCloseOnOutsideClick option in mw.Modal [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162196 (owner: 10SG) [18:34:11] (03PS1) 10Cmcmahon: QA update feature descriptions for messages test [extensions/Echo] - 10https://gerrit.wikimedia.org/r/162666 [18:35:57] (03PS1) 10Yurik: Updated Graph, ZeroPortal, ZeroBanner, JsonConfig to master [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162667 [18:36:17] (03PS2) 10Prtksxna: inputs.less: Change focus state [core] - 10https://gerrit.wikimedia.org/r/162153 (https://bugzilla.wikimedia.org/71150) [18:36:32] (03PS1) 10Yurik: Updated Graph, ZeroPortal, ZeroBanner, JsonConfig to master [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/162668 [18:36:44] (03CR) 10Yurik: [C: 032] Updated Graph, ZeroPortal, ZeroBanner, JsonConfig to master [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/162668 (owner: 10Yurik) [18:36:50] (03CR) 10Yurik: [C: 032] Updated Graph, ZeroPortal, ZeroBanner, JsonConfig to master [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162667 (owner: 10Yurik) [18:37:17] (03CR) 10Prtksxna: inputs.less: Change focus state (031 comment) [core] - 10https://gerrit.wikimedia.org/r/162153 (https://bugzilla.wikimedia.org/71150) (owner: 10Prtksxna) [18:38:10] superm401: I'll talk to violetto about 71150 and reply on the patch/bug [18:38:20] prtksxna, thanks. [18:39:13] superm401 prtksxna i actually got StevenW to reply to that bug cus he was the one who saw most of the flaw [18:39:20] (03CR) 10Arlolra: [C: 032] Add force_render option to help page. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/162545 (owner: 10Cscott) [18:39:40] (03CR) 10EBernhardson: [C: 032] Hide mw.Modal next button [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162197 (owner: 10SG) [18:39:43] violetto: I don't see his reply [18:39:49] (03PS3) 10EBernhardson: Fix autofocus textareas being compressed into inputs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162641 (owner: 10SG) [18:40:02] ping StevenW [18:40:23] * prtksxna pings StevenW for https://bugzilla.wikimedia.org/71150 [18:40:37] 3Wikimedia / 3Apache configuration: Make it possible to quickly and programmaticly pool and depool application servers - 10https://bugzilla.wikimedia.org/71212 (10Greg Grossmeier) [18:40:42] 3MediaWiki / 3General/Unknown: Tracking bug (tracking) - 10https://bugzilla.wikimedia.org/2007 (10Greg Grossmeier) [18:40:42] 3Wikimedia / 3General/Unknown: Deploy HHVM for all users (tracking) - 10https://bugzilla.wikimedia.org/70418#c8 (10Greg Grossmeier) 5RESO/FIX>3REOP (In reply to Antoine "hashar" Musso from comment #7) > HHVM related issues impacts a wide range of bugzilla components so they are > tracked via the keyword... [18:41:01] (03Merged) 10jenkins-bot: Updated Graph, ZeroPortal, ZeroBanner, JsonConfig to master [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/162668 (owner: 10Yurik) [18:42:04] (03Merged) 10jenkins-bot: Updated Graph, ZeroPortal, ZeroBanner, JsonConfig to master [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162667 (owner: 10Yurik) [18:42:06] (03Merged) 10jenkins-bot: Add force_render option to help page. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/162545 (owner: 10Cscott) [18:42:08] (03Merged) 10jenkins-bot: Hide mw.Modal next button [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162197 (owner: 10SG) [18:43:02] (03CR) 10Isarra: "This isn't personal taste, though - this is the only size progression I could find that maintained the set upward bound while still keepin" [skins/Vector] - 10https://gerrit.wikimedia.org/r/162304 (owner: 10Isarra) [18:43:39] 3Wikimedia / 3General/Unknown: Write Quips extension for Phabricator - 10https://bugzilla.wikimedia.org/71245 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3enhanc a:3None It's important! [18:44:22] 3Wikimedia / 3General/Unknown: Write Quips extension for Phabricator - 10https://bugzilla.wikimedia.org/71245 (10Sam Reed (reedy)) p:5Unprio>3High [18:44:26] not a blocker? [18:44:37] 3Wikimedia / 3General/Unknown: Write Quips extension for Phabricator - 10https://bugzilla.wikimedia.org/71245 (10Peter Bena) s:5enhanc>3blocke [18:44:43] LOL [18:44:56] (03CR) 10Prtksxna: "Matt, the problem is that the current focus state doesn't show up on older browsers because we are using 'box-shadow'. The new design allo" [core] - 10https://gerrit.wikimedia.org/r/162153 (https://bugzilla.wikimedia.org/71150) (owner: 10Prtksxna) [18:45:41] violetto: I think I see what happened, I didn't see the see also bug [18:45:51] violetto: I've replied to superm401 on the patch [18:46:02] koo prtksxna [18:46:37] (03PS4) 10SG: Fix autofocus textareas being compressed into inputs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162641 [18:46:38] 3Wikimedia / 3General/Unknown: Write Quips extension for Phabricator - 10https://bugzilla.wikimedia.org/71245#c1 (10Peter Bena) in order to follow the phabricator extension naming it should be called 'quiphs' :) [18:46:42] (03PS4) 10SG: Remove title from moderation modal [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162642 [18:46:53] violetto: http://ushumor.net/wp-content/uploads/2013/11/Cool-pigeon.jpg [18:47:15] prtksxna: lol [18:48:12] (03PS2) 10Cmcmahon: QA update feature descriptions for messages test [extensions/Echo] - 10https://gerrit.wikimedia.org/r/162666 [18:49:10] (03PS1) 10Reedy: Point cawikimedia's interwikis to English wikis [extensions/WikimediaMaintenance] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162672 [18:49:22] (03CR) 10Reedy: [C: 032] Point cawikimedia's interwikis to English wikis [extensions/WikimediaMaintenance] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162672 (owner: 10Reedy) [18:49:24] 3MediaWiki extensions / 3Translate: useability issues - 10https://bugzilla.wikimedia.org/71247 (10John McClure) 3NEW p:3Unprio s:3normal a:3None 1. Special:PagePreparation does not prefill its pagename field when it's been called as Special:PagePreparation/fullpagename or as Special:PagePreparation?t... [18:49:29] (03Merged) 10jenkins-bot: Point cawikimedia's interwikis to English wikis [extensions/WikimediaMaintenance] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162672 (owner: 10Reedy) [18:50:28] (03PS3) 10Cmcmahon: QA update feature descriptions for messages test [extensions/Echo] - 10https://gerrit.wikimedia.org/r/162666 [18:50:41] (03PS3) 10Wctaiwan: Strip signatures for Flow and LQT [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/162533 [18:51:00] (03PS1) 10Reedy: Update WikimediaMaintenance to 1.24wmf22 HEAD [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162673 [18:51:02] (03PS1) 10Umherirrender: Fix function case: WebRequest::getIntorNull -> getIntOrNull [core] - 10https://gerrit.wikimedia.org/r/162674 [18:51:15] (03CR) 10Arlolra: [C: 032] Don't crash if PNG has bogus resolution information. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/162543 (owner: 10Cscott) [18:51:37] 3MediaWiki-Vagrant: Add ability to choose between alternate roles (redis/memcached, php5/hhvm, mysql/mariadb) - 10https://bugzilla.wikimedia.org/71235#c2 (10Bryan Davis) (In reply to Dan Duvall from comment #1) > > Role parameters could either be set via the `vagrant hiera` command or, if > that's too cryptic... [18:52:28] (03CR) 10Reedy: [C: 032 V: 032] Update WikimediaMaintenance to 1.24wmf22 HEAD [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162673 (owner: 10Reedy) [18:54:12] (03PS8) 10Legoktm: Add initial tests for MergeUser [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/162012 [18:54:45] (03Merged) 10jenkins-bot: Don't crash if PNG has bogus resolution information. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/162543 (owner: 10Cscott) [18:55:00] (03PS1) 10Cscott: Support inline images. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/162675 [18:55:27] Reedy: https://gerrit.wikimedia.org/r/#/c/162012/ passed! [18:57:06] (03CR) 10EBernhardson: [C: 032] Fix autofocus textareas being compressed into inputs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162641 (owner: 10SG) [18:57:45] (03Merged) 10jenkins-bot: Fix autofocus textareas being compressed into inputs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162641 (owner: 10SG) [18:58:48] (03CR) 10jenkins-bot: [V: 04-1] Fix function case: WebRequest::getIntorNull -> getIntOrNull [core] - 10https://gerrit.wikimedia.org/r/162674 (owner: 10Umherirrender) [19:00:17] (03CR) 10Legoktm: "(This is ready to be merged now)" [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/162012 (owner: 10Legoktm) [19:00:23] 3MediaWiki extensions / 3CirrusSearch: Tables not being indexed - 10https://bugzilla.wikimedia.org/71233#c8 (10Jeremy) Thanks for the quick turnaround! I confirmed that editing a page with tables now causes the the table contents to be indexed into the "text" field. I will rebuild the index to take care of t... [19:03:37] 3MediaWiki extensions / 3CirrusSearch: Tables not being indexed - 10https://bugzilla.wikimedia.org/71233#c9 (10Nik Everett) Glad it worked! [19:05:07] 3MediaWiki-Vagrant: Add ability to choose between alternate roles (redis/memcached, php5/hhvm, mysql/mariadb) - 10https://bugzilla.wikimedia.org/71235#c3 (10Dan Duvall) Some sort of `vagrant role info` command to show possible options would be great, especially if we could just print out the puppet class docum... [19:07:10] (03CR) 10Hoo man: "recheck" [core] - 10https://gerrit.wikimedia.org/r/162674 (owner: 10Umherirrender) [19:07:39] (03CR) 10Krinkle: "Setting up a post-merge publication pipeline will have to be done either way, but yeah, I would recommend not maintaining a separate packa" [core] - 10https://gerrit.wikimedia.org/r/161998 (https://bugzilla.wikimedia.org/58620) (owner: 10Prtksxna) [19:07:52] (03PS1) 10Mglaser: SECURITY: Enhance CSS filtering in SVG files [core] - 10https://gerrit.wikimedia.org/r/162678 (https://bugzilla.wikimedia.org/69008) [19:08:20] (03PS1) 10Mglaser: SECURITY: Enhance CSS filtering in SVG files [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/162679 (https://bugzilla.wikimedia.org/69008) [19:08:22] (03PS1) 10Mglaser: Updated release notes and version number for MediaWiki 1.22.11 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/162680 [19:08:28] (03PS1) 10Mglaser: SECURITY: Enhance CSS filtering in SVG files [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/162681 (https://bugzilla.wikimedia.org/69008) [19:08:30] (03PS1) 10Mglaser: Updated release notes and version number for MediaWiki 1.23.4 [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/162682 [19:08:40] (03PS1) 10Mglaser: SECURITY: Enhance CSS filtering in SVG files [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/162683 (https://bugzilla.wikimedia.org/69008) [19:08:42] (03PS1) 10Mglaser: Updated release notes and version number for MediaWiki 1.19.19 [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/162684 [19:09:10] 3MediaWiki / 3MediaWiki UI: Button groups and icon only buttons should have separate minimum width from other controls - 10https://bugzilla.wikimedia.org/71248 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None for button groups or other square components (icon buttons) the minimum width shou... [19:09:24] 3MediaWiki / 3MediaWiki UI: Remove $wgUseMediaWikiUIEverywhere dependency for button and text input styling (tracking) - 10https://bugzilla.wikimedia.org/70913 (10Jared Zimmerman (WMF)) [19:09:26] 3MediaWiki / 3MediaWiki UI: Button groups and icon only buttons should have separate minimum width from other controls - 10https://bugzilla.wikimedia.org/71248 (10Jared Zimmerman (WMF)) a:3Prateek Saxena [19:13:21] (03CR) 10jenkins-bot: [V: 04-1] SECURITY: Enhance CSS filtering in SVG files [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/162683 (https://bugzilla.wikimedia.org/69008) (owner: 10Mglaser) [19:13:50] (03CR) 10jenkins-bot: [V: 04-1] Updated release notes and version number for MediaWiki 1.19.19 [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/162684 (owner: 10Mglaser) [19:15:57] eh, does nobody ever check whether tests for release branches work unless we need to make a security release? [19:16:05] lol [19:16:11] oh wait [19:16:16] the failing tests are the ones introduced… [19:16:37] does nobody ever check whether tests for security patches pass before pushing them? [19:16:40] only on 1.19 apparently. [19:17:05] yeah, in 1.19 XmlTypeCheck class doesn't have an $isFile option in the constructor and is missing a validate from string method, so the tests don't run as is [19:17:31] (03CR) 10Hoo man: [C: 032] Fix function case: WebRequest::getIntorNull -> getIntOrNull [core] - 10https://gerrit.wikimedia.org/r/162674 (owner: 10Umherirrender) [19:20:09] (03CR) 10Mglaser: [C: 032 V: 032] "Code Review in bugzilla. Already live in production." [core] - 10https://gerrit.wikimedia.org/r/162678 (https://bugzilla.wikimedia.org/69008) (owner: 10Mglaser) [19:20:35] (03CR) 10Mglaser: [C: 032 V: 032] "Code Review in bugzilla. Already live in production" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/162679 (https://bugzilla.wikimedia.org/69008) (owner: 10Mglaser) [19:20:51] (03CR) 10Mglaser: [C: 032 V: 032] "Code Review in bugzilla. Already live in production" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/162681 (https://bugzilla.wikimedia.org/69008) (owner: 10Mglaser) [19:22:34] (03PS1) 10Cscott: Handle redirects from subpages. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/162687 [19:24:41] (03Merged) 10jenkins-bot: Fix function case: WebRequest::getIntorNull -> getIntOrNull [core] - 10https://gerrit.wikimedia.org/r/162674 (owner: 10Umherirrender) [19:30:10] (03CR) 10MarkAHershberger: [C: 032] Updated release notes and version number for MediaWiki 1.23.4 [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/162682 (owner: 10Mglaser) [19:31:18] (03CR) 10Manybubbles: "Tests passed." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/162653 (https://bugzilla.wikimedia.org/71233) (owner: 10Manybubbles) [19:32:01] (03CR) 10MarkAHershberger: [C: 032] Updated release notes and version number for MediaWiki 1.22.11 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/162680 (owner: 10Mglaser) [19:33:01] (03PS2) 10Mglaser: SECURITY: Enhance CSS filtering in SVG files [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/162683 (https://bugzilla.wikimedia.org/69008) [19:34:29] (03PS4) 10Arlolra: WIP: Resizer [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/162540 [19:34:38] 3Wikimedia / 3General/Unknown: PHP Fatal error: Call to a member function getParserOutput() on a non-object in FlaggedRevs.class.php on line 575 - 10https://bugzilla.wikimedia.org/55471#c7 (10Bartosz Dziewoński) *** Bug 52362 has been marked as a duplicate of this bug. *** [19:34:39] 3MediaWiki extensions / 3FlaggedRevs: Call to a member function getParserOutput() on a non-object in FlaggedRevs.class.php on line 575 - 10https://bugzilla.wikimedia.org/52362#c2 (10Bartosz Dziewoński) 5RESO/WOR>3RESO/DUP *** This bug has been marked as a duplicate of bug 55471 *** [19:35:07] 3Wikimedia / 3General/Unknown: PHP Fatal error: Call to a member function getParserOutput() on a non-object in FlaggedRevs.class.php on line 575 - 10https://bugzilla.wikimedia.org/55471#c8 (10Bartosz Dziewoński) 5NEW>3RESO/WOR Per Aaron on bug 52362. [19:35:09] (03CR) 10Nikerabbit: "Thanks for insightful code review." [core] - 10https://gerrit.wikimedia.org/r/156093 (owner: 10Nikerabbit) [19:35:35] (03CR) 10jenkins-bot: [V: 04-1] SECURITY: Enhance CSS filtering in SVG files [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/162683 (https://bugzilla.wikimedia.org/69008) (owner: 10Mglaser) [19:37:09] (03PS1) 10Yurik: Updated ZeroBanner to master [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/162692 [19:37:41] (03PS1) 10Yurik: Updated ZeroBanner to master [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162693 [19:38:26] (03CR) 10Yurik: [C: 032] Updated ZeroBanner to master [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162693 (owner: 10Yurik) [19:38:29] (03CR) 10Yurik: [C: 032] Updated ZeroBanner to master [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/162692 (owner: 10Yurik) [19:40:26] (03Merged) 10jenkins-bot: Updated release notes and version number for MediaWiki 1.23.4 [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/162682 (owner: 10Mglaser) [19:40:28] (03CR) 10jenkins-bot: [V: 04-1] Updated release notes and version number for MediaWiki 1.22.11 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/162680 (owner: 10Mglaser) [19:42:33] (03Merged) 10jenkins-bot: Updated ZeroBanner to master [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162693 (owner: 10Yurik) [19:43:01] (03Merged) 10jenkins-bot: Updated ZeroBanner to master [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/162692 (owner: 10Yurik) [19:49:08] (03CR) 10Aaron Schulz: Add option to send confirm and migrate email to already-confirmed accounts (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/153760 (https://bugzilla.wikimedia.org/54760) (owner: 10Legoktm) [19:50:37] 3MediaWiki extensions / 3Translate: Special:PagePreparation usability issues - 10https://bugzilla.wikimedia.org/71247#c1 (10Nemo) Thanks for the report, let's try to break it down in separate reports so that it gets actionable. (In reply to John McClure from comment #0) > 1. Special:PagePreparation does not... [19:50:40] (03CR) 10Mglaser: "recheck" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/162680 (owner: 10Mglaser) [19:50:52] 3MediaWiki extensions / 3Translate: Special page for migration of legacy translation pages (tracking) - 10https://bugzilla.wikimedia.org/65740 (10Nemo) [19:53:41] (03CR) 10Anomie: [C: 04-1] "> Example lists can be generatedwith empty
elements. Not sure if that's intentional." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/160798 (https://bugzilla.wikimedia.org/30936) (owner: 10Anomie) [19:57:07] 3MediaWiki skins / 3Vector: h4, h5, and h6 headers should not have the same styling - 10https://bugzilla.wikimedia.org/70004#c16 (10Bartosz Dziewoński) That can be easily done with plain CSS too, we have quite a few language-specific tweaks in shared.css. [19:58:56] (03Abandoned) 10Reedy: Update CentralAuth to 1.24wmf22 HEAD [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162606 (owner: 10Reedy) [20:00:39] 3MediaWiki extensions / 3WikidataRepo: Tag protected items with a padlock - 10https://bugzilla.wikimedia.org/62554#c1 (10Bartosz Dziewoński) Is this considered a Wikidata-specific issue? [20:01:25] 3MediaWiki / 3Database: With version 1.23.0 MW with Oracle database fails to connect to DB - 10https://bugzilla.wikimedia.org/71251 (10Bill Traynor) 3NEW p:3Unprio s:3blocke a:3None Installing MediaWiki with an Oracle database fails after version 1.22.10. A fresh, completely extension free installat... [20:08:16] (03PS1) 10Aaron Schulz: Made JobQueueDB::doWaitForBackups wait for the right slaves [core] - 10https://gerrit.wikimedia.org/r/162701 [20:09:37] (03CR) 10Ori.livneh: [C: 032] Made JobQueueDB::doWaitForBackups wait for the right slaves [core] - 10https://gerrit.wikimedia.org/r/162701 (owner: 10Aaron Schulz) [20:12:27] (03CR) 10Cscott: [C: 032 V: 032] Improve load testing tool. [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/162651 (owner: 10Cscott) [20:13:18] (03CR) 10Cscott: [C: 032] Support inline images. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/162675 (owner: 10Cscott) [20:13:34] (03CR) 10Cscott: [C: 032] Handle redirects from subpages. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/162687 (owner: 10Cscott) [20:15:52] 3MediaWiki / 3Database: With version 1.23.0 MW with Oracle database fails to connect to DB - 10https://bugzilla.wikimedia.org/71251#c1 (10Andre Klapper) s:5blocke>3critic Thanks for taking the time to report this! Please try with the latest stable version (MediaWiki 1.23.3) and report back. The 1.23.x... [20:16:01] (03Merged) 10jenkins-bot: Made JobQueueDB::doWaitForBackups wait for the right slaves [core] - 10https://gerrit.wikimedia.org/r/162701 (owner: 10Aaron Schulz) [20:16:03] (03Merged) 10jenkins-bot: Support inline images. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/162675 (owner: 10Cscott) [20:16:05] (03Merged) 10jenkins-bot: Handle redirects from subpages. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/162687 (owner: 10Cscott) [20:18:51] (03PS2) 10Cscott: Clean up directory size computation. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/162662 [20:19:21] 3MediaWiki / 3User login and signup: 'Keep me logged in' checkbox should specify expiry time (if any) - 10https://bugzilla.wikimedia.org/60437#c11 (10Isarra) *** Bug 70348 has been marked as a duplicate of this bug. *** [20:19:22] 3MediaWiki / 3User login and signup: 'Keep me logged in' doesn't keep me logged in - 10https://bugzilla.wikimedia.org/70348#c4 (10Isarra) 5UNCO>3RESO/DUP Nevermind, I forgot the login expiry was just set to really short on wikimedia. *** This bug has been marked as a duplicate of bug 60437 *** [20:20:51] (03CR) 10Cscott: [C: 032 V: 032] Clean up directory size computation. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/162662 (owner: 10Cscott) [20:21:09] 3MediaWiki / 3Database: With version 1.23.0 MW with Oracle database fails to connect to DB - 10https://bugzilla.wikimedia.org/71251#c2 (10Bill Traynor) With 1.23.3 I receive the same error. I also receive this error with the master branch. It would seem 1.22.10 is the last working version with Oracle as th... [20:21:18] (03PS3) 10Mglaser: SECURITY: Enhance CSS filtering in SVG files [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/162683 (https://bugzilla.wikimedia.org/69008) [20:21:20] (03CR) 10EBernhardson: [C: 032] Remove title from moderation modal [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162642 (owner: 10SG) [20:21:59] (03CR) 10Mattflaschen: "> I'd like to start experimenting with this and porting mobile's icons into a shared repository derived from Wikifont." [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) (owner: 10Jdlrobson) [20:22:36] (03PS1) 10Aaron Schulz: Removed mid-transaction wfWaitForSlaves() calls [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/162744 [20:22:38] (03CR) 10EBernhardson: [C: 032] Remove lower-level posts' right padding [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162280 (owner: 10Matthias Mullie) [20:22:46] (03Merged) 10jenkins-bot: Remove title from moderation modal [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162642 (owner: 10SG) [20:23:11] (03CR) 10EBernhardson: [C: 032] Add mediawiki.ui.text to loader [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162179 (owner: 10SG) [20:23:18] (03Merged) 10jenkins-bot: Remove lower-level posts' right padding [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162280 (owner: 10Matthias Mullie) [20:23:51] (03Merged) 10jenkins-bot: Add mediawiki.ui.text to loader [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162179 (owner: 10SG) [20:27:11] 3MediaWiki extensions / 3Popups: Hovercards: small images are increased in size on cards, causing them to become blurry or pixelated - 10https://bugzilla.wikimedia.org/62947 (10Prateek Saxena) a:5Prateek Saxena>3None [20:27:25] 3MediaWiki extensions / 3Popups: Hovercards: Disambiguation text should not be displayed - 10https://bugzilla.wikimedia.org/63164 (10Prateek Saxena) a:5Prateek Saxena>3None [20:27:25] 3MediaWiki / 3Interface: Move editOptions styling into mediawiki.skinning.interfac e module - 10https://bugzilla.wikimedia.org/58254#c4 (10Isarra) Should probably be in the mediawiki.skinning.interface module with the other stuff intended for monobook, vector, and similar skins. Probably interface.css would... [20:27:25] 3MediaWiki extensions / 3Popups: Hovercards: use "less" variables - 10https://bugzilla.wikimedia.org/61265 (10Prateek Saxena) a:5Prateek Saxena>3None [20:27:54] (03PS6) 10Prtksxna: Create render.reference [extensions/Popups] - 10https://gerrit.wikimedia.org/r/139827 (https://bugzilla.wikimedia.org/65114) [20:27:56] (03CR) 10jenkins-bot: [V: 04-1] Create render.reference [extensions/Popups] - 10https://gerrit.wikimedia.org/r/139827 (https://bugzilla.wikimedia.org/65114) (owner: 10Prtksxna) [20:29:45] (03PS1) 10Cscott: Load testing tool: Don't report deleted articles as failures. [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/162746 [20:30:19] (03CR) 10Cscott: [C: 032] Load testing tool: Don't report deleted articles as failures. [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/162746 (owner: 10Cscott) [20:32:39] (03PS1) 10Chad: Don't rely on global title state for url generation [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/162753 [20:32:55] (03CR) 10Reedy: [C: 04-1] "Needs rebasing" [core] - 10https://gerrit.wikimedia.org/r/159529 (owner: 10Reedy) [20:34:11] (03CR) 10Mglaser: [C: 032 V: 032] "Code Review on bugzilla. Backport to REL1_19 verified by Grunny. Removed the tests, as there is no validateFromString method in XmlTypeChe" [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/162683 (https://bugzilla.wikimedia.org/69008) (owner: 10Mglaser) [20:34:19] (03CR) 10Legoktm: [C: 032] Don't rely on global title state for url generation [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/162753 (owner: 10Chad) [20:36:45] (03CR) 10Cscott: [V: 032] Load testing tool: Don't report deleted articles as failures. [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/162746 (owner: 10Cscott) [20:37:12] (03Merged) 10jenkins-bot: Don't rely on global title state for url generation [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/162753 (owner: 10Chad) [20:38:21] (03CR) 10Aaron Schulz: [C: 032] Fixed bug in BloomCacheRedis::getConnection [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162656 (owner: 10Aaron Schulz) [20:39:08] 3MediaWiki / 3MediaWiki UI: Enable form refresh as beta feature - 10https://bugzilla.wikimedia.org/71202 (10Matthew Flaschen) a:3Matthew Flaschen [20:40:05] (03PS1) 10Chad: Don't rely on $wgTitle in WebRequest [core] - 10https://gerrit.wikimedia.org/r/162754 [20:40:43] (03PS4) 10Reedy: Don't cast SpecialPageFactory::$aliases to an object either [core] - 10https://gerrit.wikimedia.org/r/159529 [20:41:45] (03CR) 10Mglaser: "recheck" [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/162684 (owner: 10Mglaser) [20:42:13] (03Merged) 10jenkins-bot: Fixed bug in BloomCacheRedis::getConnection [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162656 (owner: 10Aaron Schulz) [20:42:20] (03PS1) 10Cscott: Updating to latest masters [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/162755 [20:43:05] (03CR) 10Cscott: [C: 032 V: 032] Updating to latest masters [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/162755 (owner: 10Cscott) [20:44:07] (03PS2) 10Mglaser: Updated release notes and version number for MediaWiki 1.19.19 [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/162684 [20:44:19] (03CR) 10Chad: [C: 032] Don't remove auxiliary text if mw is too old [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/162653 (https://bugzilla.wikimedia.org/71233) (owner: 10Manybubbles) [20:44:28] (03CR) 10Mglaser: "recheck" [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/162684 (owner: 10Mglaser) [20:44:49] (03PS1) 10Cscott: Merge branch 'master' into wmf-deploy [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/162756 [20:45:01] (03Merged) 10jenkins-bot: Don't remove auxiliary text if mw is too old [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/162653 (https://bugzilla.wikimedia.org/71233) (owner: 10Manybubbles) [20:46:19] (03PS1) 10Isarra: Remove white background from table.diff [core] - 10https://gerrit.wikimedia.org/r/162757 [20:46:40] (03CR) 10jenkins-bot: [V: 04-1] Don't rely on $wgTitle in WebRequest [core] - 10https://gerrit.wikimedia.org/r/162754 (owner: 10Chad) [20:47:16] (03CR) 10Chad: "boo qunit." [core] - 10https://gerrit.wikimedia.org/r/162754 (owner: 10Chad) [20:47:54] ^demon|away: it looks like a legit failure. [20:47:55] 3MediaWiki extensions / 3VectorBeta: CPB: Echo flyout does not open when compact personal bar is enabled - 10https://bugzilla.wikimedia.org/64862 (10Prateek Saxena) a:3Prateek Saxena [20:48:10] 20:40:54 Unknown error: Use of WebRequest::appendQueryArray was deprecated in MediaWiki 1.25. [Called from WebRequest::appendQueryValue in /srv/ssd/jenkins-slave/workspace/mediawiki-core-qunit/src/includes/WebRequest.php at line 724] in /srv/ssd/jenkins-slave/workspace/mediawiki-core-qunit/src/includes/debug/MWDebug.php on line 302 [20:49:19] (03CR) 10Gergő Tisza: "Tested, works fine." [core] - 10https://gerrit.wikimedia.org/r/157157 (owner: 10Gilles) [20:49:22] <^demon|away> Ah, logic is backwards. [20:49:38] (03PS1) 10Cscott: Add a package.json for the loadtest code. [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/162758 [20:49:45] (03PS2) 10Chad: Don't rely on $wgTitle in WebRequest [core] - 10https://gerrit.wikimedia.org/r/162754 [20:50:24] 3MediaWiki / 3MediaWiki UI: Fix special:eidtwatchlist for mw.ui - 10https://bugzilla.wikimedia.org/71147 (10Prateek Saxena) 5PATC>3RESO/FIX [20:50:29] (03CR) 10Cscott: [C: 032 V: 032] Merge branch 'master' into wmf-deploy [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/162756 (owner: 10Cscott) [20:50:37] 3MediaWiki / 3MediaWiki UI: Fix Special:EditWatchlist for mw.ui - 10https://bugzilla.wikimedia.org/71147 (10Matthew Flaschen) [20:54:10] 3MediaWiki extensions / 3CirrusSearch: Tables not being indexed - 10https://bugzilla.wikimedia.org/71233 (10Nik Everett) 5PATC>3RESO/FIX [20:54:55] (03CR) 10MarkAHershberger: [C: 032] Updated release notes and version number for MediaWiki 1.19.19 [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/162684 (owner: 10Mglaser) [20:55:08] 3MediaWiki extensions / 3WikidataRepo: Create browser smoke test for a typical item - 10https://bugzilla.wikimedia.org/68094#c6 (10Jeroen De Dauw) > Hope that explained the task a bit more. It did. [20:56:54] 3Wikimedia / 3Bugzilla: Write Quips extension for Phabricator - 10https://bugzilla.wikimedia.org/71245#c2 (10Andre Klapper) Uhm, this issue somehow slipped through SB2PMRDP (sophisticated Bugzilla to Phabricator migration regression detection program) it seems. [20:57:07] (03Merged) 10jenkins-bot: Updated release notes and version number for MediaWiki 1.19.19 [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/162684 (owner: 10Mglaser) [20:59:34] legoktm: About HtmlForm, is there a way to apply a css class to just the input field and not the parents as well [21:00:23] I'm not sure... [21:01:37] 3MediaWiki / 3General/Unknown: Update branches in mediawiki/extensions/* for REL1_23 - 10https://bugzilla.wikimedia.org/64157#c29 (10Greg Grossmeier) (In reply to Mark A. Hershberger from comment #28) > (In reply to Tisza Gergő from comment #27) > > Not sure, if this is a bug in the one-off update process, o... [21:01:43] legoktm: I don't see a way of doing it without changing HtmlForm… [21:04:38] I don't think I can resolve https://bugzilla.wikimedia.org/71144 without it [21:12:10] 3Wikimedia / 3General/Unknown: Deploy HHVM for all users (tracking) - 10https://bugzilla.wikimedia.org/70418 (10Andre Klapper) [21:13:26] 3MediaWiki / 3Database: Oracle DB support (tracking) - 10https://bugzilla.wikimedia.org/38916 (10Andre Klapper) [21:13:26] 3MediaWiki / 3Database: With version 1.23.0 MW with Oracle database fails to connect to DB - 10https://bugzilla.wikimedia.org/71251 (10Andre Klapper) [21:21:04] violetto, I like your design for the button focus state [21:22:25] (03CR) 10Nuria: Add sendBeacon function (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/162194 (https://bugzilla.wikimedia.org/52287) (owner: 10Prtksxna) [21:24:11] (03CR) 10Cscott: [C: 032 V: 032] Add a package.json for the loadtest code. [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/162758 (owner: 10Cscott) [21:25:52] (03CR) 10Nuria: ">This API shouldn't be exposed to the developer. Instead, logEvent should use it when it's available." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/162194 (https://bugzilla.wikimedia.org/52287) (owner: 10Prtksxna) [21:26:30] (03CR) 10Prtksxna: Add sendBeacon function (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/162194 (https://bugzilla.wikimedia.org/52287) (owner: 10Prtksxna) [21:28:37] (03PS2) 10Bartosz Dziewoński: Implement page status indicators [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) [21:28:45] (03CR) 10Bartosz Dziewoński: "PS2 responds to inline comments." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [21:30:37] (03PS1) 10Isarra: Move editoptions styling to mediawiki.skinning/interface.css [core] - 10https://gerrit.wikimedia.org/r/162763 [21:31:38] 3MediaWiki / 3MediaWiki UI: Fix action=history for mw.ui - 10https://bugzilla.wikimedia.org/71141#c2 (10Prateek Saxena) (In reply to Matthew Flasched from comment #1) > Why is this mw-ui-constructive whereas bug 71141 > says, "search button should be progressive"? I think you mean bug 71137. Yes, you are... [21:38:31] (03PS1) 10Cmcmahon: QA: replace hard-coded 7 seconds sleep with poll method [extensions/Echo] - 10https://gerrit.wikimedia.org/r/162764 [21:39:15] (03PS3) 10Bartosz Dziewoński: Implement page status indicators [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) [21:39:31] (03CR) 10Bartosz Dziewoński: "PS3 adds API support." [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [21:40:08] (03CR) 10Nuria: Add sendBeacon function (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/162194 (https://bugzilla.wikimedia.org/52287) (owner: 10Prtksxna) [21:40:15] (03PS4) 10Bartosz Dziewoński: Implement page status indicators [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) [21:42:36] (03CR) 10Prtksxna: Add sendBeacon function (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/162194 (https://bugzilla.wikimedia.org/52287) (owner: 10Prtksxna) [21:42:58] (03CR) 10Nuria: "Please Phuedx see my comment regarding x-domain." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/162194 (https://bugzilla.wikimedia.org/52287) (owner: 10Prtksxna) [21:44:37] (03CR) 10MaxSem: "Can we just use memc by default?" [vagrant] - 10https://gerrit.wikimedia.org/r/162285 (owner: 10Aude) [21:45:40] 3MediaWiki / 3MediaWiki UI: Use mediawiki.ui elements on Special:AllMessages - 10https://bugzilla.wikimedia.org/71254 (10Prateek Saxena) [21:45:40] 3MediaWiki / 3MediaWiki UI: Remove $wgUseMediaWikiUIEverywhere dependency for button and text input styling (tracking) - 10https://bugzilla.wikimedia.org/70913 (10Prateek Saxena) [21:45:41] 3MediaWiki / 3MediaWiki UI: Use mediawiki.ui elements on Special:AllMessages - 10https://bugzilla.wikimedia.org/71254 (10Prateek Saxena) 3NEW p:3Unprio s:3normal a:3None - we should kill those non standard play/fast forward icons and make them me.ui neutral. - checkboxes are unstyled [21:46:57] (03CR) 10BryanDavis: "Having both redis and memcached at the same time is a lot of ram to steal from a small vm. We are currently (this could be changed) using " [vagrant] - 10https://gerrit.wikimedia.org/r/162285 (owner: 10Aude) [21:47:22] 3MediaWiki / 3MediaWiki UI: Fix Special:ActiveUsers for mw.ui - 10https://bugzilla.wikimedia.org/71142#c5 (10Prateek Saxena) (In reply to Matthew Flaschen from comment #4) >> we should kill those non standard play/fast forward icons and make them >> me.ui neutral. > Is this referring to this page, or somethi... [21:48:11] (03CR) 10EBernhardson: "The actual daemons should use <1M of memory each, is there really a memory pressure issue running both daemons?" [vagrant] - 10https://gerrit.wikimedia.org/r/162285 (owner: 10Aude) [21:48:36] 3Wikimedia / 3Shop: shop.wikimedia.org should be HTTPS only - 10https://bugzilla.wikimedia.org/37790#c21 (10Elliott Eggleston) Hi chmarkine@hotmail.com, Thanks for catching that! I updated that link and the matching one on the registration page, and also fixed the 'added to cart' popup link. [21:49:41] (03CR) 10EBernhardson: "by daemons i mean the process and code itself, certainly the contents of the cache could blow up, but i don't believe this patch is turnin" [vagrant] - 10https://gerrit.wikimedia.org/r/162285 (owner: 10Aude) [21:49:51] (03CR) 10Aude: "for wikidata development, i'd want both. we use the job queue (and plan to use delayed jobs, which is redis specific)" [vagrant] - 10https://gerrit.wikimedia.org/r/162285 (owner: 10Aude) [21:51:25] 3MediaWiki / 3Interface: File history table header incomplete - 10https://bugzilla.wikimedia.org/71122 (10Robert Morley) a:3Robert Morley [21:52:27] (03PS5) 10Arlolra: WIP: Resizer [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/162540 [21:54:21] shahyar, I'm reviewing the anchor patch now. [21:55:31] (03CR) 10BryanDavis: "Maybe we could tune the max memory for both down to a reasonable level? Redis currently is allowed to grow to 256M and mememcached is allo" [vagrant] - 10https://gerrit.wikimedia.org/r/162285 (owner: 10Aude) [22:05:26] (03PS4) 10EBernhardson: Add "View source" link to post actions menu [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160160 (https://bugzilla.wikimedia.org/60465) [22:06:20] (03CR) 10jenkins-bot: [V: 04-1] Add "View source" link to post actions menu [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160160 (https://bugzilla.wikimedia.org/60465) (owner: 10EBernhardson) [22:07:41] (03PS2) 10Cmcmahon: QA: replace hard-coded 7 seconds sleep with poll method [extensions/Echo] - 10https://gerrit.wikimedia.org/r/162764 [22:09:50] (03CR) 10Mattflaschen: "With IE 6 support, another use case is dealing with IE6's problems with compound classes. I think this may be a little more readable than" [core] - 10https://gerrit.wikimedia.org/r/161051 (owner: 10SG) [22:13:21] (03PS1) 10Prtksxna: buttons: Re-use 48px min-width for button groups [core] - 10https://gerrit.wikimedia.org/r/162771 (https://bugzilla.wikimedia.org/71248) [22:13:45] (03PS1) 10Aaron Schulz: Fixed doc typo [core] - 10https://gerrit.wikimedia.org/r/162772 [22:14:22] (03CR) 10Reedy: [C: 032] Fixed doc typo [core] - 10https://gerrit.wikimedia.org/r/162772 (owner: 10Aaron Schulz) [22:14:32] (03CR) 10Krinkle: Add sendBeacon function (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/162194 (https://bugzilla.wikimedia.org/52287) (owner: 10Prtksxna) [22:14:45] (03PS5) 10EBernhardson: Add "View source" link to post actions menu [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160160 (https://bugzilla.wikimedia.org/60465) [22:15:48] (03CR) 10Aaron Schulz: [C: 032] Fixed doc typo [core] - 10https://gerrit.wikimedia.org/r/162772 (owner: 10Aaron Schulz) [22:16:08] (03CR) 10Aaron Schulz: [C: 032] Removed mid-transaction wfWaitForSlaves() calls [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/162744 (owner: 10Aaron Schulz) [22:16:40] (03CR) 10EBernhardson: [C: 031] "based on the comments at https://trello.com/c/d2X5Q1dN/622-mark-new-topic-notifications-as-read-when-you-visit-the-board-page this is the " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161170 (owner: 10EBernhardson) [22:17:19] (03Abandoned) 10EBernhardson: Force logging of exceptions in Hooks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159523 (owner: 10EBernhardson) [22:17:36] (03PS1) 10RobinHood70: Fixed header in file history [core] - 10https://gerrit.wikimedia.org/r/162773 [22:18:55] thanks superm401. it's easy to apply to other controls as well. [22:18:57] (03CR) 10Krinkle: Add sendBeacon function (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/162194 (https://bugzilla.wikimedia.org/52287) (owner: 10Prtksxna) [22:19:04] Very exciting to see sendBeacon be used [22:19:04] and more importantly simple [22:20:37] 3MediaWiki / 3MediaWiki UI: Fix Special:ActiveUsers for mw.ui - 10https://bugzilla.wikimedia.org/71142#c6 (10Jared Zimmerman (WMF)) Sorry, yes. wrong bug [22:21:04] (03Merged) 10jenkins-bot: Fixed doc typo [core] - 10https://gerrit.wikimedia.org/r/162772 (owner: 10Aaron Schulz) [22:21:06] (03Merged) 10jenkins-bot: Removed mid-transaction wfWaitForSlaves() calls [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/162744 (owner: 10Aaron Schulz) [22:21:54] (03PS3) 10Prtksxna: Add sendBeacon function [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/162194 (https://bugzilla.wikimedia.org/52287) [22:22:05] (03CR) 10Prtksxna: Add sendBeacon function (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/162194 (https://bugzilla.wikimedia.org/52287) (owner: 10Prtksxna) [22:23:14] (03CR) 10Mattflaschen: [C: 04-1] "It doesn't work in IE 6. However, I'm going to suggest an idea to fix it." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/155856 (https://bugzilla.wikimedia.org/69212) (owner: 10SG) [22:23:22] thanks superm401 [22:25:07] shahyar, ugh, even if you are aware of IE6's compound class issue and specifically target it (which can be down with * html .whatever-selector), there's still no way I know to work around it. [22:25:23] 3MediaWiki / 3Interface: File history table header incomplete - 10https://bugzilla.wikimedia.org/71122#c3 (10Robert Morley) 5NEW>3RESO/FIX This is my very first attempt to submit an update, and I was basically following the Gerrit tutorial blindly, so please let me know if I did anything wrong. The comm... [22:28:22] 3MediaWiki / 3Interface: File history table header incomplete - 10https://bugzilla.wikimedia.org/71122#c4 (10Matthew Flaschen) 5RESO/FIX>3REOP Thanks, Robert. Normally, we mark commits as FIXED when they are merged, not when they are uploaded. I'll review it later today if someone else doesn't beat me... [22:28:37] superm401, yeah, imo, having ie6-ie9 as html classes with my other patch would really be handy for situations like this [22:29:23] shahyar, it would, but that's not the main problem (* html foo can be used as an unreadable substitute of .ie6 foo). [22:29:26] (03PS3) 10EBernhardson: Handlebars helpers have different signature than used [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162117 [22:29:31] But that doesn't really let you solve the compound class issue. [22:29:59] (03CR) 10EBernhardson: "PS3: manual rebase" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162117 (owner: 10EBernhardson) [22:30:02] correct. this is basically just to give SOME context color to IE6 [22:30:29] it doesn't help entirely, but at least something that is destructive shows up as red in ie6 [22:32:55] (03CR) 10Nuria: Add sendBeacon function (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/162194 (https://bugzilla.wikimedia.org/52287) (owner: 10Prtksxna) [22:33:24] shahyar, I'm still reviewing, but the IE 6 issues are: https://i.imgur.com/B8aCukc.png [22:33:33] Quiet works, but not the others. [22:34:06] eh, that's odd [22:34:27] ohh [22:34:37] superm401, that's because my other mw-ui-button patch got reverted [22:34:58] IE6 with my other patch is not supposed to apply any button style at all [22:35:41] shahyar, I don't follow. These are not buttons. [22:35:53] It looks like these are because .mw-ui-anchor is at the end. [22:35:55] 3MediaWiki / 3Uploading: Chunked upload of TIFF files - 10https://bugzilla.wikimedia.org/71256 (10jeblad) 3NEW p:3Unprio s:3normal a:3None Created attachment 16576 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16576&action=edit Error report as shown on Special:Upload Chunked upload of TIFF... [22:36:09] I see that is deliberate, but I don't understand why. [22:37:05] (03PS1) 10Legoktm: SECURITY: Enhance CSS filtering in SVG files [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/162777 (https://bugzilla.wikimedia.org/69008) [22:37:17] (03CR) 10Legoktm: [C: 032] SECURITY: Enhance CSS filtering in SVG files [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/162777 (https://bugzilla.wikimedia.org/69008) (owner: 10Legoktm) [22:37:49] (03PS2) 10Aaron Schulz: Created DabaseBase::trxTimestamp method and added usage in ActiveUsers query [core] - 10https://gerrit.wikimedia.org/r/162490 [22:38:37] (03PS3) 10Reedy: Created DatabaseBase::trxTimestamp method and added usage in ActiveUsers query [core] - 10https://gerrit.wikimedia.org/r/162490 (owner: 10Aaron Schulz) [22:39:39] (03CR) 10Ori.livneh: [C: 032] Use a less confusing column alias in findMissingFiles.php [core] - 10https://gerrit.wikimedia.org/r/162309 (owner: 10Aaron Schulz) [22:40:07] 3MediaWiki / 3File management: Upload should disallow SVGs with third-party content in style elements (not just style attributes) - 10https://bugzilla.wikimedia.org/69008#c24 (10Markus Glaser) 5PATC>3RESO/FIX Published the security fix in the tarballs. As of now, this bug can be publicly accessible. [22:40:26] 3Wikimedia / 3General/Unknown: Map warper is no longer recognized as a connected app - 10https://bugzilla.wikimedia.org/71257 (10jeblad) 3NEW p:3Unprio s:3normal a:3None When trying to connect to map warper with my account on Wikimedia Commons I get a error. The content of the message on Commons is b... [22:40:32] (03PS4) 10Ori.livneh: Limit active DB connections spawned in waitForAll() to one [core] - 10https://gerrit.wikimedia.org/r/161500 (owner: 10Aaron Schulz) [22:40:49] superm401, styles from mw-ui-button are bleeding because of multi-selector issue [22:41:47] shahyar, I think that might be the reason for the background color, but I think the foreground color issue is in this patch. [22:41:49] .mw-ui-button.mw-ui-progressive becomes .mw-ui-progressive, so it applies to even anchors [22:41:59] correct, the foreground is this patch. [22:42:32] shahyar, is there a way to see what CSS rules are applying in the IE6 inspector? [22:42:41] I know you can inspect the actual current style values. [22:43:56] (03Merged) 10jenkins-bot: SECURITY: Enhance CSS filtering in SVG files [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/162777 (https://bugzilla.wikimedia.org/69008) (owner: 10Legoktm) [22:44:03] superm401, mw-ui-text is wrong. the selector & is inverted. it should be at the beginning instead of at the end. [22:44:04] (03CR) 10Dduvall: "I'm not sure about the "reload the page" step. It's better than the ambiguous "grabbing a cup of coffee" but maybe errors on the other sid" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/162764 (owner: 10Cmcmahon) [22:44:52] this is causing .mw-ui-destructive.mw-ui-text to be interpreted as .mw-ui-text thus applying it to all text. [22:44:56] shahyar, yeah. [22:45:08] 3MediaWiki / 3Uploading: Chunked upload of TIFF files - 10https://bugzilla.wikimedia.org/71256#c1 (10jeblad) Strangly enough, the file show up in Uploads after some time and seems to work. https://commons.wikimedia.org/wiki/File:Oslo_byarkiv,_Grosch_1830-%C3%A5rene,_001_004.tif [22:45:13] in addition, the same thing is happening for mw-ui-anchor. we need an IE6-incapable selector to stop that. [22:45:22] 3MediaWiki / 3Export/Import: Importing does not work with HHVM - 10https://bugzilla.wikimedia.org/66023#c12 (10Ori Livneh) 5PATC>3RESO/FIX https://github.com/facebook/hhvm/pull/3840 [22:45:52] (03CR) 10Ori.livneh: [C: 04-1] "Obsoleted by https://github.com/facebook/hhvm/pull/3840" [core] - 10https://gerrit.wikimedia.org/r/159973 (https://bugzilla.wikimedia.org/66023) (owner: 10Dan-nl) [22:46:15] (03Merged) 10jenkins-bot: Use a less confusing column alias in findMissingFiles.php [core] - 10https://gerrit.wikimedia.org/r/162309 (owner: 10Aaron Schulz) [22:46:18] shahyar, can't we just switch the order again? [22:46:30] superm401, durr. yes, that could work too. [22:46:37] 3MediaWiki extensions / 3Scribunto: Count of arrays from LuaSandbox incorrect under HHVM - 10https://bugzilla.wikimedia.org/71061#c8 (10Ori Livneh) 5NEW>3RESO/FIX (In reply to Tim Starling from comment #7) > https://github.com/facebook/hhvm/pull/3811 Nice; thanks. [22:47:01] I gotta run, but I'll fix this patch up and test it tonight, superm401 [22:47:14] shahyar, cool, finishing my review now (although we covered a lot of it). [22:48:55] 3Wikimedia / 3General/Unknown: Memcached::increment/decrement doesn't work with HHVM - 10https://bugzilla.wikimedia.org/71258 (10Ori Livneh) 3NEW p:3Unprio s:3normal a:3None Caused by . Bsimmers is going to take a stab at fixing it. [22:52:37] 3MediaWiki / 3Interface: Sidebar toolbox is too crowded (tracking) - 10https://bugzilla.wikimedia.org/43170#c10 (10John McClure) (In reply to Nemo from comment #1) > 1) "What links here" must be in the sidebar, it's a crucial feature for > navigation. > 2) Related changes is related to history (but not in ca... [22:55:47] (03PS1) 10Hoo man: SepcialCentralAuth: Don't place the unmerge button in the table [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/162782 [22:56:41] prtksxna: ori: Beacon also landed in Chrome (no longer behind experimental flag) as of M38 and higher [22:57:01] * prtksxna should upgrade [22:57:02] stable is currently on 36, Canary on 39, 38 will go out in beta soon and then stable a few weeks later [22:57:03] https://code.google.com/p/chromium/issues/detail?id=402991& [22:57:16] Krinkle: Awesome [22:57:19] nuria_: ^ [22:57:56] (03CR) 10TTO: "I still think this is still worth considering for merging. Particularly the increased test coverage." [core] - 10https://gerrit.wikimedia.org/r/159973 (https://bugzilla.wikimedia.org/66023) (owner: 10Dan-nl) [22:57:58] with no extra flags or config: http://i.imgur.com/gRTkREh.png [22:58:00] hello 22:56: [22:58:08] hello prtksxna [22:58:25] woo [22:58:32] https://code.google.com/p/chromium/issues/detail?id=360603#c9 [22:58:35] Hey nuria_ [22:59:09] yes [23:00:07] (03CR) 10EBernhardson: Set a maximum height to auto-expanding text fields (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162363 (https://bugzilla.wikimedia.org/58657) (owner: 10EBernhardson) [23:00:11] (03PS3) 10EBernhardson: Set a maximum height to auto-expanding text fields [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162363 (https://bugzilla.wikimedia.org/58657) [23:00:15] nuria_: Should we change the title of 52287 to sendBeacon or just raise a different bug? [23:01:02] prtksxna isn't all this related to teh original issue? the only way when send beacon is useful is for jumps across pages [23:01:37] in any other case logging as it was works, right? [23:01:48] nuria_: Yes, but using some them in other cases doesn't hurt either [23:02:29] nuria_: If the feature is available that is [23:04:13] prtksxna: i rather not chnaged code without testing it, so yes, it does hurt. did you test in IE at all? [23:04:33] we do not know as to the behaviour of sendbeacon and chrome and cross domain [23:04:42] we have to verify it works before changing it. [23:04:53] to be the default. [23:04:56] nuria_: I am not saying we merge it, I am saying do you think it makes sense for it to be in dispatch rather that its own method (whenever that might be) [23:05:28] prtksxna: sorry but no, i would say that once cors is enabled we should merge it and use it in teh cases in which it makes sense [23:05:36] once teh Api has baked [23:05:44] we can change it to be the default [23:05:48] It'll fall back to the image loading anyway [23:06:06] It won't be *default*, just another option if its available [23:06:48] prtksxna: that would work if teh API works perfectly and logs as advertized but it wouldn't be teh 1st chrome new api to silently fail [23:07:06] for example: did you tested chrome on windows? [23:07:08] (03CR) 10Cmcmahon: "Given I am on the wiki" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/162764 (owner: 10Cmcmahon) [23:07:45] prtksxna: in the absence of more test we can use it on a small feature anf decide on available support [23:07:49] nuria_: Nothing will get merged until its tested. I am just suggesting it be part of dispatch rather than a different method. It won't be merged till we know it works everywhere [23:07:51] based of feature data [23:08:09] 3OCG / 3General/Unknown: Speed up health check. - 10https://bugzilla.wikimedia.org/71260 (10C. Scott Ananian) 3NEW p:3Unprio s:3normal a:3None icinga warning: icinga-wm: PROBLEM - LVS HTTP IPv4 on ocg.svc.eqiad.wmnet is CRITICAL: CRITICAL - Socket timeout after 10 seconds The port is responsive in... [23:08:41] nuria_: er, is there a reason you keep using bold? [23:08:48] prtksxna: i prefer the aproach of merging it without being teh default (afer testing) using it in your feature, gather data and decide what to do after  [23:08:52] (03PS1) 10Catrope: Update VisualEditor for cherry-pick [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162788 [23:08:53] *approach [23:09:00] (03PS1) 10Kaldari: Removing if statements that will never be true [extensions/cldr] - 10https://gerrit.wikimedia.org/r/162789 [23:10:23] nuria_: Why are all your messages to Prateek bolded? :) [23:10:35] (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor for cherry-pick [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162788 (owner: 10Catrope) [23:10:44] Not all. [23:10:53] (03Abandoned) 10Kaldari: Removing if statements that will never be true [extensions/cldr] - 10https://gerrit.wikimedia.org/r/162789 (owner: 10Kaldari) [23:11:06] RoanKattouw: man , now that you mention it [23:11:21] all my messages are bolded today, lemmme see [23:11:34] nuria_: Only ones in which you mention someone [23:11:37] Only the ones addressed to people [23:11:44] How are you addressing people, are you copypasting their nicknames or something? [23:11:46] Not even that consistently :\ [23:11:52] one of them only bolded the name you were adressing [23:13:03] (03PS1) 10Ejegg: Update DonationInterface submodule for WP fix [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/162792 [23:13:16] (03CR) 10Catrope: [C: 032 V: 032] Update OOjs UI for cherry-pick [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162485 (owner: 10Catrope) [23:13:21] ya that must be it, i always copy prtksxna 's name [23:13:25] (03Abandoned) 10Kaldari: Create plural rules for variants of zh (Chinese) [core] - 10https://gerrit.wikimedia.org/r/116278 (owner: 10Liangent) [23:13:26] ah no [23:13:29] (03CR) 10Ejegg: [C: 032] Update DonationInterface submodule for WP fix [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/162792 (owner: 10Ejegg) [23:13:37] nuria_: Did you know that you can tab-complete nicknames in most IRC clients? [23:13:39] prt [23:14:02] RoanKattouw : ooohhhh [23:14:09] but it makes no diff [23:14:41] ah , no, wait, it does [23:14:52] :) [23:14:57] It's also much less effort :) [23:16:53] RoanKattouw haha, very true [23:18:23] (03PS6) 10Arlolra: Resizer [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/162540 [23:27:08] 3Wikimedia / 3SSL related: replace SHA1 certificates with SHA256 - 10https://bugzilla.wikimedia.org/71156#c5 (10chmarkine) (In reply to Andre Klapper from comment #3) > > Bugzilla -- ‎November ‎5, ‎2017 > > bug-attachment.wikimedia.org -- September ‎7, ‎2017 > > Gerrit -- April ‎24, ‎2017 > > These three i... [23:37:07] (03CR) 10Mattflaschen: "I'm looking forward to getting rid of this IE 6 stuff, even for static content. But I'm in agreement we're not yet at the point where we " (035 comments) [core] - 10https://gerrit.wikimedia.org/r/155856 (https://bugzilla.wikimedia.org/69212) (owner: 10SG) [23:45:53] (03CR) 10Parent5446: [C: 032] Limit active DB connections spawned in waitForAll() to one [core] - 10https://gerrit.wikimedia.org/r/161500 (owner: 10Aaron Schulz) [23:47:49] (03CR) 10Parent5446: [C: 04-1] Created DatabaseBase::trxTimestamp method and added usage in ActiveUsers query (031 comment) [core] - 10https://gerrit.wikimedia.org/r/162490 (owner: 10Aaron Schulz) [23:48:00] (03CR) 10Jdlrobson: [C: 04-1] "I don't really understand the commit message. What is being reused?" [core] - 10https://gerrit.wikimedia.org/r/162771 (https://bugzilla.wikimedia.org/71248) (owner: 10Prtksxna) [23:48:36] (03CR) 10Parent5446: [C: 032] Fixed header in file history [core] - 10https://gerrit.wikimedia.org/r/162773 (owner: 10RobinHood70) [23:52:25] (03Merged) 10jenkins-bot: Limit active DB connections spawned in waitForAll() to one [core] - 10https://gerrit.wikimedia.org/r/161500 (owner: 10Aaron Schulz) [23:52:34] (03CR) 10Jackmcbarn: "Parsoid would be getting this via action=expandtemplates, so you should expose it there too. (Note that it should be expanded wikitext whe" [core] - 10https://gerrit.wikimedia.org/r/162609 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [23:54:22] (03CR) 10Aaron Schulz: Created DatabaseBase::trxTimestamp method and added usage in ActiveUsers query (031 comment) [core] - 10https://gerrit.wikimedia.org/r/162490 (owner: 10Aaron Schulz) [23:54:50] (03Merged) 10jenkins-bot: Fixed header in file history [core] - 10https://gerrit.wikimedia.org/r/162773 (owner: 10RobinHood70) [23:59:25] (03PS1) 10Krinkle: jshintrc: Remove unused globals [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/162794