[00:03:38] (03Abandoned) 10Bmansurov: adding a lowercase comment [extensions/examples] - 10https://gerrit.wikimedia.org/r/162167 (owner: 10Bmansurov) [00:03:48] (03Abandoned) 10Bmansurov: add test commit [extensions/examples] - 10https://gerrit.wikimedia.org/r/162162 (owner: 10Bmansurov) [00:04:41] (03PS1) 10EBernhardson: Repair individual post collapse in Topic namespace [extensions/Flow] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162174 (https://bugzilla.wikimedia.org/71132) [00:11:44] (03PS14) 10SG: Change mw-ui anchors to require mw-ui-anchor base class [core] - 10https://gerrit.wikimedia.org/r/155856 (https://bugzilla.wikimedia.org/69212) [00:12:15] (03PS1) 10BryanDavis: Set "normal" ownership on /srv [vagrant] - 10https://gerrit.wikimedia.org/r/162177 [00:14:26] (03PS15) 10SG: Change mw-ui anchors to require mw-ui-anchor base class, and introduce mw-ui-text base class [core] - 10https://gerrit.wikimedia.org/r/155856 (https://bugzilla.wikimedia.org/69212) [00:14:37] 3MediaWiki / 3JavaScript: Placeholders appear as password characters in IE6-9 - 10https://bugzilla.wikimedia.org/48918#c8 (10Steven Walling) 5ASSI>3RESO/FIX Tested in Sauce for IE 6-9. No longer an issue, though there other problems natch. [00:20:31] (03PS1) 10SG: Add mediawiki.ui.text to loader [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162179 [00:20:54] 3MediaWiki / 3MediaWiki UI: Focus indicator broken in IE8 - 10https://bugzilla.wikimedia.org/71155 (10Steven Walling) [00:20:58] 3MediaWiki / 3MediaWiki UI: [Focus indicator broken in IE8 - 10https://bugzilla.wikimedia.org/71155 (10Steven Walling) 3NEW p:3Unprio s:3normal a:3None Created attachment 16544 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16544&action=edit Username field selected The focus indicator (blue... [00:21:22] 3MediaWiki / 3MediaWiki UI: Use a new focus indicator on MediaWiki UI text fields - 10https://bugzilla.wikimedia.org/71150 (10Steven Walling) [00:21:24] 3MediaWiki / 3MediaWiki UI: Focus indicator broken in IE8 - 10https://bugzilla.wikimedia.org/71155 (10Steven Walling) [00:21:53] 3MediaWiki / 3API: ApiQueryAllUsers with auactiveusers fails on duplicate querycachetwo rows - 10https://bugzilla.wikimedia.org/71086#c3 (10Aaron Schulz) (In reply to Brad Jorsch from comment #2) > But the rows there *should* be unique: > SpecialActiveUsers::doQueryCacheUpdate() takes a lock to make sure onl... [00:24:07] (03PS1) 10EBernhardson: I-2. Change the default number of Flow Messages in the flyout, from 3 to 25 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/162180 [00:24:33] (03PS1) 10Legoktm: Actually register GadgetRepos properly [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/162181 [00:25:06] (03CR) 10Krinkle: [C: 032] Actually register GadgetRepos properly [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/162181 (owner: 10Legoktm) [00:25:10] 3Wikimedia / 3SSL related: replace SHA1 certificates with SHA256 - 10https://bugzilla.wikimedia.org/71156 (10chmarkine) 3NEW p:3Unprio s:3normal a:3None Chrome 39 will warn users if SHA1 certificates are used and expire after January 1, 2017. Chrome 40 will warn users if SHA1 certificates are used an... [00:26:49] (03Merged) 10jenkins-bot: Actually register GadgetRepos properly [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/162181 (owner: 10Legoktm) [00:30:37] (03PS2) 10SG: Update wikiglyph to support inline text for screen readers on icons [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155612 [00:31:16] (03CR) 10jenkins-bot: [V: 04-1] Update wikiglyph to support inline text for screen readers on icons [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155612 (owner: 10SG) [00:33:01] (03PS1) 10BryanDavis: Sync /etc/apt/sources.list.d/wikimedia.list with WMF production [vagrant] - 10https://gerrit.wikimedia.org/r/162183 [00:34:20] PHP Deprecated: Comments starting with '#' are deprecated in /etc/php5/cli/conf.d/fss.ini on line 1 in Unknown on line 0 [00:34:37] interesting lint error [00:35:06] (03PS3) 10SG: Update wikiglyph to support inline text for screen readers on icons [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155612 [00:35:50] That one always annoys me but never enought to submit a patch [00:36:35] https://bugzilla.wikimedia.org/show_bug.cgi?id=66092 [00:37:13] hashar to the rescue :) [00:37:27] (03CR) 10SG: [C: 04-1] "This is written the way it is expected to function. It's there to support nesting of progressiveEnhancement. What is this supposed to fix?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161158 (https://bugzilla.wikimedia.org/70982) (owner: 10EBernhardson) [00:37:51] (03CR) 10PleaseStand: Database: Remove use of strencode() in replaceVars() [core] - 10https://gerrit.wikimedia.org/r/146363 (owner: 10PleaseStand) [00:38:19] (03CR) 10SG: [C: 032] Don't treat topic title as wikitext [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161159 (owner: 10EBernhardson) [00:38:58] (03CR) 10SG: [C: 032] Properly escape topic title in compare-post-revisions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161163 (owner: 10EBernhardson) [00:39:13] (03CR) 10SG: "Please rebase, but otherwise +2." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161163 (owner: 10EBernhardson) [00:41:21] (03CR) 10SG: Handlebars helpers have different signature than used (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162117 (owner: 10EBernhardson) [00:43:01] (03CR) 10EBernhardson: "The flow_reply_form template is rendered inside of a progressive enhancement. This template can include any content provided by a user, su" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161158 (https://bugzilla.wikimedia.org/70982) (owner: 10EBernhardson) [00:43:37] (03PS4) 10Krinkle: MediaWikiTestCase: Centralise insertPage() logic from SearchEngineTest [core] - 10https://gerrit.wikimedia.org/r/161139 [00:43:39] (03PS1) 10Krinkle: PrefixSearch: Add unit tests for StringPrefixSearch [core] - 10https://gerrit.wikimedia.org/r/162190 [00:43:53] (03PS4) 10Krinkle: PrefixSearch: Enforce including the exact match as first result [core] - 10https://gerrit.wikimedia.org/r/161148 (https://bugzilla.wikimedia.org/70958) [00:50:37] 3MediaWiki / 3MediaWiki UI: Focus indicator broken in IE8 - 10https://bugzilla.wikimedia.org/71155 (10Matthew Flaschen) p:5Unprio>3Low [00:52:07] 3MediaWiki / 3MediaWiki UI: Focus indicator broken in IE8 - 10https://bugzilla.wikimedia.org/71155#c1 (10Matthew Flaschen) To be specific, it just doesn't show. There's no artifacts or anything, though, so we have the option of just considering this progressive enhancement. There is a patch up to change it... [00:54:24] (03PS2) 10BryanDavis: [WIP] Add role::iegreview [vagrant] - 10https://gerrit.wikimedia.org/r/161950 [00:54:37] 3MediaWiki / 3MediaWiki UI: Focus indicator broken in IE8 - 10https://bugzilla.wikimedia.org/71155#c2 (10Matthew Flaschen) Also, it does show the more subtle focus indicator of the darkened border. [00:54:51] (03PS4) 10SG: Clean up watchlist icon markup and CSS [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155214 [00:56:22] 3MediaWiki / 3MediaWiki UI: Focus indicator broken in IE8 - 10https://bugzilla.wikimedia.org/71155#c3 (10Prateek Saxena) The current approach uses a shadow which is why it doesn't show up in older browsers. The patch I24f33a40cd0126ae95698c2a46858a15f502ca5 for bug 71150 uses border along with box-shadow so... [00:59:08] (03PS4) 10EBernhardson: Don't treat topic title as wikitext [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161159 [00:59:18] (03CR) 10EBernhardson: "re-apply sg+2" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161159 (owner: 10EBernhardson) [00:59:28] (03PS4) 10EBernhardson: Properly escape topic title in compare-post-revisions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161163 [00:59:35] (03CR) 10EBernhardson: "re-apply sg+2" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161163 (owner: 10EBernhardson) [01:00:58] (03CR) 10EBernhardson: [C: 032] "re-apply sg+2" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161159 (owner: 10EBernhardson) [01:01:37] (03Merged) 10jenkins-bot: Don't treat topic title as wikitext [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161159 (owner: 10EBernhardson) [01:01:40] (03Merged) 10jenkins-bot: Properly escape topic title in compare-post-revisions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161163 (owner: 10EBernhardson) [01:02:43] (03PS10) 10Krinkle: PrefixSearch: Implement searching in multiple namespaces [core] - 10https://gerrit.wikimedia.org/r/141660 (https://bugzilla.wikimedia.org/65752) (owner: 10Nikerabbit) [01:03:15] (03CR) 10Krinkle: [C: 04-1] "Rebased to resolve conflicts. Moved out irrelevant test into separate commit. Turns out the tests I added were already passes. We're still" [core] - 10https://gerrit.wikimedia.org/r/141660 (https://bugzilla.wikimedia.org/65752) (owner: 10Nikerabbit) [01:08:55] (03CR) 10Jdlrobson: [C: 04-1] "Only -1ing so it is more likely to get your attention. I'm confused." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/155856 (https://bugzilla.wikimedia.org/69212) (owner: 10SG) [01:17:22] (03CR) 10EBernhardson: Handlebars helpers have different signature than used (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162117 (owner: 10EBernhardson) [01:24:12] Isarra: ping [01:24:45] let me know when you want to talk gerrit :-) [01:27:26] (03PS2) 10EBernhardson: Handlebars helpers have different signature than used [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162117 [01:27:52] 3MediaWiki / 3Parser: Provide a recursive subst: function in the PST – {{substall:foo}} - 10https://bugzilla.wikimedia.org/2777 (10James Forrester) 5REOP>3NEW [01:29:07] 3MediaWiki / 3Parser: Provide a recursive subst: function in the PST – {{substall:foo}} - 10https://bugzilla.wikimedia.org/2777#c28 (10Jackmcbarn) If a template wants itself to be substed all the way, it can do so by putting {{{|safesubst:}}} before all of its template calls. I see no reason to complicate th... [02:00:00] (03PS2) 10Dan-nl: Add title tests [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/134078 [02:01:40] (03CR) 10Dan-nl: "* attempting to import the artwork template and have the wiki generate the templatedata" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/134078 (owner: 10Dan-nl) [02:08:11] (03PS3) 10Dan-nl: Add title tests [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/134078 (https://bugzilla.wikimedia.org/69241) [02:09:21] (03CR) 10Dan-nl: "* added a bug id" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/134078 (https://bugzilla.wikimedia.org/69241) (owner: 10Dan-nl) [02:19:31] (03PS1) 10Prtksxna: Add sendBeacon function [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/162194 [02:19:50] (03CR) 10Prtksxna: [C: 04-2] Add sendBeacon function [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/162194 (owner: 10Prtksxna) [02:23:43] (03CR) 10Prtksxna: "Tested locally by logging to and listening on a random port." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/162194 (owner: 10Prtksxna) [02:24:17] (03PS2) 10Prtksxna: Add sendBeacon function [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/162194 (https://bugzilla.wikimedia.org/52287) [02:24:51] 3Wikimedia / 3Fundraising: foundationwiki making requests to "Unknown MySQL server host 'db1008.eqiad.wmnet'" - 10https://bugzilla.wikimedia.org/53975#c24 (10Jeff Green) 5NEW>3RESO/FIX as far as I can tell, this has been fixed [02:30:55] bd808|BUFFER, hi ,any updates on labs? it still fails to provision, even after sudo chmod g+w /srv/vagrant/mediawiki/cache [02:31:20] Notice: /Stage[main]/Role::Labs_initial_content/Mediawiki::Import_dump[labs_privacy]/Exec[import_dump_labs_privacy]/returns: PHP Warning: chdir(): Permission denied (errno 13) in /var/www/w/MWVersion.php on line 62 [02:31:20] N [02:38:13] (03CR) 10jenkins-bot: [V: 04-1] Add title tests [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/134078 (https://bugzilla.wikimedia.org/69241) (owner: 10Dan-nl) [02:43:07] 3MediaWiki skins / 3Vector: Vector: Default icon for "profile" in personal tools should be gender neutral and fit with other site icons look & feel - 10https://bugzilla.wikimedia.org/41484#c66 (10Jason Quinn) Postscript: Blue is for boys. Pink is for girls. Yellow or green are neutral. This is a cultural c... [02:48:09] yurikR: what box is that? [02:48:24] jeremyb, graphtest [02:49:01] oh, this is vagrant… [02:49:17] yep [02:49:20] good luck :) [02:55:25] legoktm: around? [03:01:25] 3MediaWiki / 3ContentHandler: Exception from line 594 of /srv/mediawiki/php-1.24wmf22/includes/content/ContentH andler.php: Format text/x-wiki is not supported for content model css - 10https://bugzilla.wikimedia.org/71163 (10Jackmcbarn) 3NEW p:3Unprio s:3normal a:3None 2014-09-23 02:55:34 mw1020 med... [03:07:14] (03PS3) 10Krinkle: doxygen: Fix trailing star in class member descriptions [core] - 10https://gerrit.wikimedia.org/r/157351 [03:07:20] (03PS3) 10Krinkle: doxygen: Fix leading space in class member descriptions [core] - 10https://gerrit.wikimedia.org/r/157352 [03:16:10] (03PS3) 10Krinkle: doxygen: Document problem with slashes and fix a few [core] - 10https://gerrit.wikimedia.org/r/157353 [03:17:55] (03CR) 10SG: [C: 032] Don't run progressiveEnhancements through handlebars.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161158 (https://bugzilla.wikimedia.org/70982) (owner: 10EBernhardson) [03:18:37] (03Merged) 10jenkins-bot: Don't run progressiveEnhancements through handlebars.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161158 (https://bugzilla.wikimedia.org/70982) (owner: 10EBernhardson) [03:19:15] (03CR) 10Santhosh: "Thanks Niklas and Nemo." [extensions/cldr] - 10https://gerrit.wikimedia.org/r/161912 (owner: 10Santhosh) [03:28:27] (03PS2) 10EBernhardson: Dont add permalink to topic in new-topic notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162138 [03:32:09] (03PS6) 10Krinkle: Use confirmCloseWindow from mediawiki-core [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151127 (owner: 10MarkTraceur) [03:32:16] (03PS3) 10EBernhardson: Dont add permalink to topic in new-topic notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162138 [03:32:19] (03Abandoned) 10Prtksxna: Add logUnlessTimeout function [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/116260 (https://bugzilla.wikimedia.org/52287) (owner: 10Prtksxna) [03:32:52] (03PS13) 10Krinkle: Implement mediawiki.confirmCloseWindow module [core] - 10https://gerrit.wikimedia.org/r/151128 (owner: 10MarkTraceur) [03:33:07] (03CR) 10jenkins-bot: [V: 04-1] Use confirmCloseWindow from mediawiki-core [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151127 (owner: 10MarkTraceur) [03:34:50] (03CR) 10Krinkle: [C: 04-1] "There's issues with this. It makes it too tolerant causing "foo bar" to now become a valid url, too (hence tests are failing)." [core] - 10https://gerrit.wikimedia.org/r/139584 (owner: 10Yuvipanda) [03:37:47] (03CR) 10Krinkle: "@Bartosz: It's not about the extra abort method. It's about the promiseDeferred.promise object properties themselves and their beha" [core] - 10https://gerrit.wikimedia.org/r/160949 (owner: 10Adrian Lang) [04:02:29] (03PS1) 10Tim Starling: Profiling of Language::fetchLanguageNames [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/162195 [04:07:12] (03CR) 10Tim Starling: [C: 032] Profiling of Language::fetchLanguageNames [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/162195 (owner: 10Tim Starling) [04:09:24] 3QRpedia: QRpedia should point to Wikidata entity - 10https://bugzilla.wikimedia.org/63463#c4 (10albin) I think this is an important change. I know that QRpedia codes have been printed on signs in a town in Sweden, codes pointing to the article [[:sv:Teaterladan]] ("Theatre barn", [[:en:Hedemora Gamla Theater... [04:09:54] (03Merged) 10jenkins-bot: Profiling of Language::fetchLanguageNames [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/162195 (owner: 10Tim Starling) [04:14:00] TimStarling, around? [04:14:05] yes [04:14:19] hi, wanted to pick your brain re my project with zero [04:14:23] have a sec? [04:14:35] involves lua ;) [04:15:03] ok [04:16:27] TimStarling, basically i have this: http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FZeroPortal.git/1500beb5c95702c58138780f2f09c6e5a4491b1c/includes%2FPortalSpecialPage.php [04:16:27] (03PS1) 10SG: Implement closeOutClick option in mw.Modal [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162196 [04:16:30] (03PS1) 10SG: Hide mw.Modal next button [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162197 [04:18:00] we need to build a portal, with a complex workflow/state for each user. To do this, i decided to use scribunto to describe what each user should see. Users and Anonymous have identical rights (except admins), and they see evyrthing through a special page which simply transposes lua module's output [04:19:12] (ignore the iterate* func call - i might remove it soonish) [04:19:53] the admins have full control of the lua module, hence no security issues [04:19:58] (at least from that angle) [04:21:14] my question - how to better invoke lua module and pass it a few params, how to better return values from lua (preferably - multiple values), and how to expose some api functionality (or maybe even all functionality) to lua [04:22:23] btw, lua module by itself does not generate much of the content, instead it transcludes various templates [04:22:58] you could use the engine directly, instead of using it via the parser [04:24:15] I suppose you want to keep Scribunto's libraries [04:24:19] mw.* etc. [04:25:21] correct [04:26:09] i want lua to be almost sa powerful as php - basically full api access [04:26:12] in Scribunto/common/Hooks.php have a look at invokeHook [04:26:30] maybe you can set up your own engine, like what it does there, instead of using #invoke [04:27:00] that might work too - any difficulties with passing params both ways? [04:27:08] complex data structures? [04:27:35] and obviously it will need the frame object (or something similar) to do template resolution [04:28:33] you can pass arrays, if that is what you mean by complex data structures [04:28:36] that will mostly work [04:28:52] you can't pass objects from PHP to Lua, it doesn't really work that way [04:29:29] instead we have an object interface implemented on the Lua side, which wraps method calls, serializes as necessary [04:30:04] array of array (or stdClass of stdClass ) [04:30:23] no need to pass code objects like Title [04:32:12] you can use mw.getCurrentFrame() [04:32:42] this will all be very fragile though [04:33:26] well, I guess that is not my problem [04:33:48] (03PS1) 10EBernhardson: H-99: Dont collapse away the title of moderated topics in topic namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162198 [04:34:02] if you get an engine object, then you can get a module object, and on the module object you can call getInitChunk() [04:34:03] but i will need to wrap FauxRequest API calls somehow to allow lua to make any kinds of api calls, possibly including the data-modifying ones. Any suggestions on that? As an alternative, I could keep lua as read-only, and provide additional php api modules to let clientside javascript make changes [04:34:18] sorry, pls go on [04:34:40] hmm, but setupCurrentFrames() is private, so that won't work [04:35:37] are you sure you need to do all this? [04:36:53] maybe it is better to just use the normal #invoke entry point [04:37:03] there is not really a proper API behind that [04:38:45] if you use #invoke with the ScribuntoExternalLibraries hook then you will be on more stable ground [04:39:04] the idea is to have all the custom portal logic in an easy-to-modify lua module [04:39:09] you can just have a library which provides relevant input and output [04:39:18] not sure i understand [04:40:03] i'm currently creating a wiki markup {{#invoke:...}}, with all the params, and return back the wiki to output [04:40:10] well, you have some structured input and some structured output [04:40:20] not structured output (yet) [04:40:40] what you want to do is {{#invoke:doTheThing|$structuredInput}} [04:40:55] i either treat it as wiki markup, or i strip the

...

, and treat the result as raw output [04:40:57] what you probably should do instead is {{#invoke:doTheThing}} [04:41:29] and where is the $structuredInput? [04:42:12] then have Module:doTheThing do: local in = mw.ext.ZeroPortal.getStructuredInput() [04:42:33] oh. i see. sounds good :) [04:42:35] you provide the implementation of that with some mix of lua and PHP code [04:42:48] will i be able to do mw.ext.ZeroPortal.setOutput(...); ? [04:42:52] yeah [04:43:10] yes, this will work beautifully [04:43:15] any examples of that? [04:44:30] Wikidata, ParserFunctions and TitleBlacklist currently register their own Lua libraries [04:44:36] and this way i won't have to mess with the custom engine instantiation [04:44:42] yeah [04:45:04] the interface already exists and is used by multiple extensions, so it will be much less likely to break [04:45:55] gothca, thx, sounds awesome. Gives me much more flexibility [04:46:36] actually wikidata is currently in mw.wikibase not mw.ext.wikibase [04:46:54] so maybe you would put your library in mw.ZeroPortal or some such [04:47:14] I'm boggling a bit at the idea of a ParserFunctions Lua library. [04:50:08] 3MediaWiki extensions / 3OpenStackManager: Add projectadmins to project page - 10https://bugzilla.wikimedia.org/43515 (10jeremyb) [04:50:09] 3MediaWiki extensions / 3OpenStackManager: adding/removing project members updates project page, changing projectadmins does not - 10https://bugzilla.wikimedia.org/71164 (10jeremyb) 3NEW p:3Unprio s:3normal a:3Ryan Lane adding/removing project members updates project page, changing projectadmins does... [04:59:25] TimStarling, thx, i will poke at it [05:03:32] np [05:07:19] TimStarling, another thing, if you are not too busy - I have gotten a lot of issues resolved with the graph ext, and it is now live on mediawiki and a number of other wiki. See demo at https://www.mediawiki.org/wiki/Extension:Graph/Demo [05:07:46] when you have a chance, I would like to discuss how to optimize it for mass consumption, e.g. server side rendering [05:11:38] that is quite nice [05:12:44] heh, JSON in an HTML attribute is not the most efficient encoding is it? [05:12:57] heh, it has to get there somehow :) [05:14:41] but you are correct, ideally there should be some sort of a "json storage", identified by a hash [05:15:05] and that storage will be used by both the backend and client-side rendering if the client has "editor" enabled [05:15:17] 896 bytes of JSON encoded as 1865 bytes of HTML [05:16:13] if you did a base64 encode, that would be 1208 bytes, much smaller [05:16:35] i'm looking forward to gwicke's engine on that - i don't want to premature optimize it and spend time on it [05:17:03] json shouldn't even be in html - it should be requested as a resource [05:17:33] Bytes compressed or uncompressed? [05:18:07] i can just see us adding all that data as base64 gz blob... [05:18:09] uncompressed: gzdeflate then base64 you get 484 bytes [05:18:46] that is, base64_encode(gzdeflate(...)) [05:18:47] wouldn't that be double-zipping - html is already gziped [05:19:07] the other way, gzdeflate(base64_encode()) it is 569 bytes [05:19:41] jackmcbarn: hey [05:20:14] sigh. TimStarling, in any case, my question is: this is where the "magic" happens... and it does'nt happen too well in some cases: http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FGraph.git/997fce39cee0f8299fc987263cb1aafebd051934/Graph.body.php [05:20:53] e.g. it does not happen here - https://www.mediawiki.org/wiki/Graph:Examples:Template -- the template is not resolved [05:21:08] but it does resolve template when inserting it into other pages [05:21:55] (inside the json, there is "value": "{{{1|#ccc}}}" -- which should become "value": "#ccc", but i think it doesn't [05:23:37] also, i would like "edit source" to automatically start with the "preview" mode [05:24:18] because i will have on-the-fly graph refresh on edit, and want the graph to show from the start, not after clicking "show preview" [05:25:23] and last, and most important - is there an easy way to make LUA produce raw data as oppose to html? This way we can hook lua to produce data for the graphs. Are there any security implications? [05:29:38] you can insert strip tags [05:29:56] (03PS1) 10Tim Starling: Profiling for Language::fetchLanguageNames [core] - 10https://gerrit.wikimedia.org/r/162202 [05:29:58] (03PS1) 10Tim Starling: Add a process cache for fetchLanguageNames [core] - 10https://gerrit.wikimedia.org/r/162203 [05:32:48] (03CR) 10Tim Starling: "Already live on enwiki: I4da11fa55bb23026da528981a112385bb0f88a32" [core] - 10https://gerrit.wikimedia.org/r/162202 (owner: 10Tim Starling) [05:36:20] TimStarling, what do you mean? [05:36:39] is that the answer to the 3rd point? [05:37:02] obviously you can't have unprivileged Lua return raw unfiltered HTML if that is what you mean [05:37:46] but you could provide a Lua function which sets extension data in ParserOutput [05:38:27] with ParserOutput::setExtensionData() [05:38:53] then that could send the JSON out in a script tag or whatever [05:39:57] alternatively you could provide a function to Lua which called Parser::insertStripItem() with some appropriately validated HTML as the $text argument [05:40:15] and returned the resulting strip tag to Lua, which Lua would then return into wikitext [05:48:22] TimStarling, i don't want LUA to return unfiltered HTML, but i do want it to return unfiltred "something else" that browser will not attempt to treat as html, but various graphs could reference as outside data sources. [05:48:45] can either hold data internally (good for tiny datasets), or reference outside source [05:49:01] if lua can provide some data manipulation capacity, we can use it as api [05:49:37] Just Lua, no need to shout. ;-) [05:49:55] to generate a dataset with possibly some custom filtering/maping based on some data stored ... somewhere in wiki/wikidata/... [05:50:07] lua it is [05:51:00] (03CR) 10Seb35: "I am the original author, Platonides added it to SVN because I had no access to mediawiki/tools (see his comment)." [tools/code-utils] - 10https://gerrit.wikimedia.org/r/118263 (https://bugzilla.wikimedia.org/43777) (owner: 10Seb35) [05:57:21] (03PS1) 10Seb35: Delete read_wfMsgCalls.py (obsolete) [tools/code-utils] - 10https://gerrit.wikimedia.org/r/162205 [05:58:51] (03CR) 10Seb35: [C: 04-1] "Deletion commit: I3e88c545313dfcfa14982005ac47f0264702c334" [tools/code-utils] - 10https://gerrit.wikimedia.org/r/118263 (https://bugzilla.wikimedia.org/43777) (owner: 10Seb35) [06:17:16] 3Wikimedia / 3Site requests: Set $wgUploadNavigationUrl on eo.wikipedia - 10https://bugzilla.wikimedia.org/69055 (10Nemo) 5PATC>3RESO/FIX [06:23:52] 3Datasets / 3General/Unknown: Enable IPv6 on dumps.wikimedia.org - 10https://bugzilla.wikimedia.org/66996#c3 (10wp mirror) Please also assign an IPv6 address for . [06:31:23] 3Datasets / 3General/Unknown: Enable IPv6 on dumps.wikimedia.org - 10https://bugzilla.wikimedia.org/66996#c4 (10jeremyb) (In reply to wp mirror from comment #3) > Please also assign an IPv6 address for . not on this bug... (you could search for or file a new one) [06:40:55] 3MediaWiki / 3Page editing: MediaWiki external link syntax parsing of URI schemes - 10https://bugzilla.wikimedia.org/71166 (10David Condrey) 3UNCO p:3Unprio s:3trivia a:3None MediaWiki external link syntax parsing does not appear to support the view-source [URI schemes][1] potentially others as well.... [06:45:08] 3Wikimedia / 3Site requests: Account creation for GLAM event - 10https://bugzilla.wikimedia.org/70953 (10jeremyb) 5PATC>3RESO/WON [06:45:23] 3MediaWiki extensions / 3Extensions requests: Need a webpage to produce Pie chart according to Graphic Lab's recommendations - 10https://bugzilla.wikimedia.org/12603#c7 (10Yuri Astrakhan) Graph extension might be applicable. See https://www.mediawiki.org/wiki/Extension:Graph and samples at https://www.mediaw... [06:47:37] 3Wikimedia / 3Extension setup: Support for text/syntax/markup driven or WYSIWYG editable charts, diagrams, graphs, flowcharts etc. (Identify, develop, review and deploy extension on Wikimedia wikis to add) - 10https://bugzilla.wikimedia.org/54221#c12 (10Yuri Astrakhan) Graph extension might be applicable, ev... [06:48:07] 3MediaWiki / 3Parser: MediaWiki external link syntax parsing of URI schemes - 10https://bugzilla.wikimedia.org/71166 (10jeremyb) [06:48:57] (03PS1) 10Isarra: Fix and update SpecialUserlogin.php patch so core still works without the extension installed. [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/162206 [06:49:21] 3MediaWiki extensions / 3Extensions requests: Provide a way to create interactive 2D/3D timelines and infographics e.g. Java applets, AJAX, Flash - 10https://bugzilla.wikimedia.org/43616#c3 (10Yuri Astrakhan) Graph extension might be applicable, even though it is not dynamic (yet), or even in production wiki... [06:50:37] 3Wikimedia / 3Extension setup: Support for text/syntax/markup driven or WYSIWYG editable charts, diagrams, graphs, flowcharts etc. (Identify, develop, review and deploy extension on Wikimedia wikis to add) - 10https://bugzilla.wikimedia.org/54221#c13 (10Yuri Astrakhan) Sorry, meant to post last comment for b... [06:52:52] 3Wikimedia / 3Site requests: Deploy LuaSandbox 2.0-5 to remaining hosts - 10https://bugzilla.wikimedia.org/70173#c1 (10Giuseppe Lavagetto) We need to rebuild the package for ubuntu precise first. On my todo list. [07:03:22] (03CR) 10Nikerabbit: "The warnings this produces are not useful: [23-Sep-2014 06:58:41 UTC] PHP Notice: Linker::link: Requires $target to be a Title object. [C" [core] - 10https://gerrit.wikimedia.org/r/144646 (owner: 10Withoutaname) [07:05:37] 3MediaWiki extensions / 3Translate: Conflict of Special:MyLanguage: Extension and MW core use the same special page name - 10https://bugzilla.wikimedia.org/69461#c14 (10Amir E. Aharoni) 5PATC>3RESO/FIX Patches deployed. https://translatewiki.net/wiki/Special:AdvancedTranslate works now. Thanks to Nikl... [07:05:55] DBQueryError: A database error has occurred. Did you forget to run maintenance/update.php after upgrading? See: https://www.mediawiki.org/wiki/Manual:Upgrading#Run_the_update_script [07:05:55] Query: SELECT w2.wl_namespace,w2.wl_title FROM `unittest_watchlist` `w1` INNER JOIN `unittest_watchlist` `w2` ON ((w1.wl_namespace = w2.wl_namespace) AND (w1.wl_title = w2.wl_title)) WHERE w1.wl_user = '11' AND w2.wl_user = '10' FOR UPDATE [07:05:55] Function: MergeUser::deduplicateWatchlistEntries [07:05:55] Error: 1137 Can't reopen table: 'w1' () [07:06:11] I'm only running into that whenever the unittest_ prefix is added to tables. [07:07:17] anyone have an idea why? [07:12:35] (03PS5) 10Legoktm: Add initial tests for MergeUser [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/162012 [07:12:46] (03CR) 10jenkins-bot: [V: 04-1] Add initial tests for MergeUser [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/162012 (owner: 10Legoktm) [07:14:01] (03PS1) 10Nikerabbit: Make linker warning useful [core] - 10https://gerrit.wikimedia.org/r/162207 [07:14:34] legoktm: probably bad code in mergeuser not adding prefixes [07:17:56] Nikerabbit: well https://github.com/wikimedia/mediawiki-extensions-UserMerge/blob/master/MergeUser.php#L142 is the query. But I thought extensions shouldn't care directly what the prefix is and that the database class would automatically take care of it? [07:20:34] legoktm: apparently not if you do table aliases [07:23:12] hmm. [07:24:46] legoktm: though I don't really understand the code, can you dump the exact sql it generates? [07:24:52] 3MediaWiki extensions / 3LiquidThreads: Make invalid type parameter in ApiFeedLQTThreads fail more gracefully - 10https://bugzilla.wikimedia.org/22510#c9 (10Nemo) (In reply to Sam Reed (reedy) from comment #0) > Translatewiki has been having some hits meant for Joomla, attempting > exploits.. > > /w/api.php... [07:25:50] Nikerabbit: Query wiki (399) (slave): SELECT /* MergeUser::deduplicateWatchlistEntries 127.0.0.1 */ w2.wl_namespace,w2.wl_title FROM `unittest_watchlist` `w1` INNER JOIN `unittest_watchlist` `w2` ON ((w1.wl_namespace = w2.wl_namespace) AND (w1.wl_title = w2.wl_title)) WHERE w1.wl_user = '11' AND w2.wl_user = '10' FOR UPDATE [07:26:52] 3MediaWiki extensions / 3LiquidThreads: PHP Fatal error: Call to a member function getContent() on a non-object in /www/w/extensions/LiquidThreads/api/ApiFeedLQTThreads.php on line 80 - 10https://bugzilla.wikimedia.org/25008 (10Nemo) [07:26:52] 3MediaWiki extensions / 3LiquidThreads: LQT Call to a member function ... on a non-object at different places - 10https://bugzilla.wikimedia.org/17553 (10Nemo) [07:27:37] 3MediaWiki / 3General/Unknown: Bugs affecting translatewiki.net (errors from MediaWiki master) (tracking) - 10https://bugzilla.wikimedia.org/39480 (10Nemo) [07:27:38] 3MediaWiki extensions / 3LiquidThreads: Linker::link: Requires $target to be a Title object [Called from ApiFeedLQTThreads::createFeedItem] - 10https://bugzilla.wikimedia.org/71168 (10Nemo) 3NEW p:3Unprio s:3normal a:3None With https://gerrit.wikimedia.org/r/162207 we learn that: -rakkaus:#mediawiki... [07:27:45] normally it looks like: [07:27:46] Query wiki (713) (slave): SELECT /* MergeUser::deduplicateWatchlistEntries */ w2.wl_namespace,w2.wl_title FROM `watchlist` `w1` INNER JOIN `watchlist` `w2` ON ((w1.wl_namespace = w2.wl_namespace) AND (w1.wl_title = w2.wl_title)) WHERE w1.wl_user = '345' AND w2.wl_user = '344' FOR UPDATE [07:31:52] (03CR) 10Legoktm: [C: 032] Make linker warning useful [core] - 10https://gerrit.wikimedia.org/r/162207 (owner: 10Nikerabbit) [07:37:23] 3Wikimedia / 3SSL related: replace SHA1 certificates with SHA256 - 10https://bugzilla.wikimedia.org/71156#c1 (10chmarkine) And stats.wikimedia.org -- June 20, 2017 [07:38:19] (03Merged) 10jenkins-bot: Make linker warning useful [core] - 10https://gerrit.wikimedia.org/r/162207 (owner: 10Nikerabbit) [07:51:51] legoktm: hmm isn't that correct sql? [07:52:21] perhaps that does not work with temporary tables... anyway it does not seem to be issue with prefixes [07:54:07] 3MediaWiki extensions / 3WikidataRepo: Implement terms-lookup based on terms-table - 10https://bugzilla.wikimedia.org/71169 (10tobias.gritschacher) p:5Unprio>3Normal [07:54:37] 3MediaWiki extensions / 3WikidataRepo: Implement terms-lookup based on terms-table - 10https://bugzilla.wikimedia.org/71169 (10tobias.gritschacher) [07:54:38] 3MediaWiki extensions / 3WikidataRepo: Do not load full entities when invoking LinkBegin hook - 10https://bugzilla.wikimedia.org/70767 (10tobias.gritschacher) [08:00:10] 3MediaWiki extensions / 3WikidataRepo: Ensure WikibaseDataModelSerialization feature parity with WikibaseLib - 10https://bugzilla.wikimedia.org/71170 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs https://github.com/wmde/WikibaseDataModelSerialization/milestones/WikibaseLib%20featu... [08:00:10] 3MediaWiki extensions / 3WikidataRepo: Ensure WikibaseDataModelSerialization feature parity with WikibaseLib - 10https://bugzilla.wikimedia.org/71170 (10tobias.gritschacher) p:5Unprio>3High [08:03:53] 3MediaWiki extensions / 3WikidataRepo: Replace old serialization code in lib with datamodel serialization - 10https://bugzilla.wikimedia.org/62188 (10tobias.gritschacher) [08:03:54] 3MediaWiki extensions / 3WikidataRepo: Ensure WikibaseDataModelSerialization feature parity with WikibaseLib - 10https://bugzilla.wikimedia.org/71170 (10tobias.gritschacher) [08:07:41] 3MediaWiki extensions / 3WikidataRepo: Replace old serialization code in lib with datamodel serialization - 10https://bugzilla.wikimedia.org/62188 (10tobias.gritschacher) [08:07:41] 3MediaWiki extensions / 3WikidataRepo: allow statements on properties - 10https://bugzilla.wikimedia.org/49554 (10tobias.gritschacher) [08:08:39] 3MediaWiki extensions / 3WikidataRepo: Allow adding references for statements on properties in the UI - 10https://bugzilla.wikimedia.org/68379 (10tobias.gritschacher) [08:08:40] 3MediaWiki extensions / 3WikidataRepo: Replace old serialization code in lib with datamodel serialization - 10https://bugzilla.wikimedia.org/62188 (10tobias.gritschacher) [08:20:20] (03PS6) 10Addshore: Remove use of deprecated $wgPasswordSenderName [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/157109 [08:39:04] (03CR) 10Gilles: [C: 031] Implement mediawiki.confirmCloseWindow module [core] - 10https://gerrit.wikimedia.org/r/151128 (owner: 10MarkTraceur) [08:57:05] (03CR) 10Gilles: [C: 032] Add model base class, description model [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/121308 (owner: 10MarkTraceur) [08:57:35] (03Merged) 10jenkins-bot: Add model base class, description model [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/121308 (owner: 10MarkTraceur) [09:00:08] 3Wikimedia / 3Deployment systems: [Trebuchet] Salt times out on parsoid restarts - 10https://bugzilla.wikimedia.org/61882#c8 (10Antoine "hashar" Musso) Ryan Lane wrote: > The problem here is that publish.runner has a default timeout. When that > timeout is reached, the runner stops executing. Part of the iss... [09:18:09] (03PS2) 10Gergő Tisza: Introduce ContentAlterParserOutput hook [core] - 10https://gerrit.wikimedia.org/r/161471 [09:24:40] (03CR) 10Gergő Tisza: "Removed from TextContent & updated the docs." [core] - 10https://gerrit.wikimedia.org/r/161471 (owner: 10Gergő Tisza) [09:46:52] 3MediaWiki / 3General/Unknown: PHP fatal error: Call to a member function getTitle() on a non-object in /includes/Feed.php:309 - 10https://bugzilla.wikimedia.org/70709#c5 (10Andre Klapper) 5UNCO>3RESO/WOR "The errors seem to have disappeared on their own, so this seems like a likely culprit." [10:06:36] 3MediaWiki extensions / 3Translate: Conflict of Special:MyLanguage: Extension and MW core use the same special page name - 10https://bugzilla.wikimedia.org/69461#c15 (10Lokal_Profil) Thanks to everyone who made this work again [10:13:09] 3QRpedia: QRpedia should point to Wikidata entity - 10https://bugzilla.wikimedia.org/63463#c5 (10Lokal_Profil) The GoToLinkedPage functionality in Wikidata should be the first piece needed in order to get this to work. It doesn't have it's own language fallback yet but the existing one could possibly be reused... [10:13:09] 3MediaWiki extensions / 3WikidataRepo: Input extender is closed on mouse-click-and-hold in Chrome - 10https://bugzilla.wikimedia.org/68913 (10Lydia Pintscher) 5PATC>3RESO/FIX [10:14:24] 3MediaWiki extensions / 3WikidataRepo: Forward according to user's preferred language on Special:GoToLinkedPage - 10https://bugzilla.wikimedia.org/70159 (10Lokal_Profil) [10:14:24] 3QRpedia: QRpedia should point to Wikidata entity - 10https://bugzilla.wikimedia.org/63463 (10Lokal_Profil) [10:20:03] (03PS1) 10IAlex: Add missing space to log message [core] - 10https://gerrit.wikimedia.org/r/162216 [11:05:00] (03CR) 10Erik Zachte: "I am no longer involved in Easytimeline since 200?" [extensions/timeline] - 10https://gerrit.wikimedia.org/r/130027 (https://bugzilla.wikimedia.org/4) (owner: 10Gerrit Patch Uploader) [11:23:36] 3MediaWiki / 3General/Unknown: PHP fatal error: Call to a member function getTitle() on a non-object in /includes/Feed.php:309 - 10https://bugzilla.wikimedia.org/70709#c6 (10Tara Athan) I was mistaken about the errors disappearing - I was just looking for them in the wrong place. The errors continue to appea... [11:25:44] (03CR) 10Springle: [C: 031] Randomize the JobRunner slave lags checks a bit [core] - 10https://gerrit.wikimedia.org/r/161577 (owner: 10Aaron Schulz) [11:27:24] (03CR) 10Springle: [C: 031] Slave lag check tweaks to JobRunner [core] - 10https://gerrit.wikimedia.org/r/161749 (owner: 10Aaron Schulz) [11:27:37] 3MediaWiki / 3General/Unknown: PHP fatal error: Call to a member function getTitle() on a non-object in /includes/Feed.php:309 - 10https://bugzilla.wikimedia.org/70709#c7 (10Sam Reed (reedy)) A stack trace would be useful for debugging this further. Can you add "$wgShowExceptionDetails = true;" (without the... [11:28:42] (03CR) 10Springle: [C: 031] Limit new active DB connections in waitForAll() to one [core] - 10https://gerrit.wikimedia.org/r/161500 (owner: 10Aaron Schulz) [11:46:48] (03PS4) 10Florianschmidtwelzow: SpecialVersion: Use Config object instead of globals [core] - 10https://gerrit.wikimedia.org/r/159536 (https://bugzilla.wikimedia.org/70638) [11:54:25] (03PS5) 10Florianschmidtwelzow: SpecialVersion: Use Config object instead of globals [core] - 10https://gerrit.wikimedia.org/r/159536 (https://bugzilla.wikimedia.org/70638) [11:59:39] 3MediaWiki / 3Maintenance scripts: namespaceDupes.php doesn't update references in other tables for pages it moved - 10https://bugzilla.wikimedia.org/71171 (10Matthias Mullie) 3NEW p:3Unprio s:3normal a:3None namespaceDupes.php is used when introducing a new namespace, to check/move titles that alrea... [12:00:09] 3MediaWiki / 3Maintenance scripts: namespaceDupes.php doesn't update references in other tables for pages it moved - 10https://bugzilla.wikimedia.org/71171 (10Matthias Mullie) [12:11:01] (03PS1) 10TTO: Point cawikimedia's interwikis to English wikis [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/162223 [12:12:36] (03PS6) 10Florianschmidtwelzow: SpecialVersion: Use Config object instead of globals [core] - 10https://gerrit.wikimedia.org/r/159536 (https://bugzilla.wikimedia.org/70638) [12:13:10] (03CR) 10TTO: "@Reedy: Once this is merged, could you please update the copy of dumpInterwiki you use to generate interwiki.cdb? Thanks!" [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/162223 (owner: 10TTO) [12:15:12] (03PS2) 10Reedy: Point cawikimedia's interwikis to English wikis [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/162223 (owner: 10TTO) [12:15:34] (03CR) 10Reedy: [C: 032] "It gets updated/re-branched like every other extension every wednesday..." [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/162223 (owner: 10TTO) [12:16:35] (03Merged) 10jenkins-bot: Point cawikimedia's interwikis to English wikis [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/162223 (owner: 10TTO) [12:19:52] 3MediaWiki / 3General/Unknown: PHP fatal error: Call to a member function getTitle() on a non-object in /includes/Feed.php:309 - 10https://bugzilla.wikimedia.org/70709#c8 (10Florian) 5RESO/WOR>3REOP (In reply to Tara Athan from comment #6) > The errors continue to appear -> Ropen [12:20:23] 3MediaWiki extensions / 3WikidataRepo: Badge for quality articles on Wikidata - 10https://bugzilla.wikimedia.org/70268 (10Lydia Pintscher) [12:20:37] 3MediaWiki extensions / 3WikidataRepo: add featured list badge - 10https://bugzilla.wikimedia.org/70332 (10Lydia Pintscher) [12:22:23] 3MediaWiki extensions / 3WikidataRepo: Badge for quality articles on Wikidata - 10https://bugzilla.wikimedia.org/70268 (10Lydia Pintscher) [12:22:55] 3MediaWiki extensions / 3WikidataRepo: add featured list badge - 10https://bugzilla.wikimedia.org/70332 (10Lydia Pintscher) [12:22:55] 3MediaWiki extensions / 3WikidataRepo: Create browser smoke test for a typical item - 10https://bugzilla.wikimedia.org/68094 (10Lydia Pintscher) [12:23:08] 3MediaWiki extensions / 3WikidataRepo: check compatibility of DataModel 1.0 with entity blobs in a (old) dump - 10https://bugzilla.wikimedia.org/70750 (10Lydia Pintscher) [12:23:09] 3MediaWiki / 3General/Unknown: PHP fatal error: Call to a member function getTitle() on a non-object in /includes/Feed.php:309 - 10https://bugzilla.wikimedia.org/70709#c9 (10Tara Athan) I have added $wgShowExceptionDetails = true; to LocalSettings.php Where do I look for the stack trace? [12:23:40] 3MediaWiki extensions / 3SemanticForms: WSF 2.8 throws warning: Missing argument 2 for WikiEditorHooks::editPageShowEditFormInitial() - 10https://bugzilla.wikimedia.org/71172 (10Neill Mitchell) 3NEW p:3Unprio s:3normal a:3Yaron Koren Hi. I have MW 1.23.3 including its bundled WikiEditor, SF 2.8 and... [12:27:22] 3MediaWiki extensions / 3WikidataRepo: Allow adding references for statements on properties in the UI - 10https://bugzilla.wikimedia.org/68379#c1 (10Jan Zerebecki) This also depends on https://github.com/wmde/WikibaseDataModel/milestones/1.1 being released. [12:30:20] (03CR) 10Manybubbles: [C: 031] MediaWikiTestCase: Centralise insertPage() logic from SearchEngineTest [core] - 10https://gerrit.wikimedia.org/r/161139 (owner: 10Krinkle) [12:31:22] 3MediaWiki extensions / 3WikidataRepo: Implement terms-lookup based on terms-table - 10https://bugzilla.wikimedia.org/71169 (10Lydia Pintscher) [12:32:28] (03CR) 10Manybubbles: [C: 032] PrefixSearch: Add unit tests for StringPrefixSearch (031 comment) [core] - 10https://gerrit.wikimedia.org/r/162190 (owner: 10Krinkle) [12:32:32] (03CR) 10Manybubbles: [C: 031] PrefixSearch: Add unit tests for StringPrefixSearch [core] - 10https://gerrit.wikimedia.org/r/162190 (owner: 10Krinkle) [12:35:07] 3MediaWiki extensions / 3WikidataRepo: Investigate issues with globe coordinate precision - 10https://bugzilla.wikimedia.org/70934 (10Lydia Pintscher) [12:36:50] qgil: is https://phabricator.wikimedia.org/M1 from https://www.mediawiki.org/wiki/Phabricator/versus_Bugzilla also a 404 for you? [12:43:08] 3MediaWiki extensions / 3WikidataClient: Usage Tracking: design database schema for service that registers where data is used - 10https://bugzilla.wikimedia.org/64586 (10Lydia Pintscher) [12:43:08] 3MediaWiki extensions / 3WikidataClient: Usage Tracking: implement the service - 10https://bugzilla.wikimedia.org/64587 (10Lydia Pintscher) [12:43:37] 3MediaWiki extensions / 3WikidataClient: Usage Tracking: design database schema for service that registers where data is used - 10https://bugzilla.wikimedia.org/64586 (10Lydia Pintscher) [12:45:38] (03PS22) 10Phuedx: Add mw-ui-icon [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) (owner: 10Jdlrobson) [12:46:08] 3Wikimedia / 3General/Unknown: Allow uploading of Blender or other 3D files to Wikimedia Commons - 10https://bugzilla.wikimedia.org/1790#c42 (10Jean-Fred) > Is this bug about 3D support in general, or a specific file format in > particular? Shall I open a bug for, say, AMF support, or shall we consider > th... [12:46:22] 3MediaWiki extensions / 3WikidataClient: Usage Tracking: hook up property parser and Lua functions to record usage - 10https://bugzilla.wikimedia.org/64588 (10Lydia Pintscher) [12:48:22] 3MediaWiki extensions / 3WikidataRepo: Investigate issues with time value precision - 10https://bugzilla.wikimedia.org/70935 (10Lydia Pintscher) [12:49:37] 3MediaWiki extensions / 3WikidataRepo: Fix empty map serialization behaviour - 10https://bugzilla.wikimedia.org/70606 (10Lydia Pintscher) [12:50:38] 3MediaWiki extensions / 3WikidataRepo: maintenance/importDump.php fails for wikidatawiki XML incremental dump files - 10https://bugzilla.wikimedia.org/70898 (10Marius Hoch) a:3Wikidata bugs [12:50:52] 3MediaWiki extensions / 3WikidataRepo: Move JS WikibaseAPI code into its own component - 10https://bugzilla.wikimedia.org/66419 (10Lydia Pintscher) [12:52:15] (03CR) 10Phuedx: "Tested in Chrome (37.0.2062.122), Firefox (32.0.2), Safari (7.0.6) and IE8-11." [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) (owner: 10Jdlrobson) [12:52:21] 3MediaWiki extensions / 3WikidataRepo: Section-edit mode for SiteLinks - 10https://bugzilla.wikimedia.org/68908 (10Lydia Pintscher) [12:52:37] 3MediaWiki extensions / 3WikidataRepo: Create an edit widget to edit badges - 10https://bugzilla.wikimedia.org/67669 (10Lydia Pintscher) [12:54:15] (03Abandoned) 10Phuedx: [EXPERIMENT] Add icon mixins to mediawiki.ui [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx) [12:55:19] hi jzerebecki [12:55:37] hey [12:56:53] 3MediaWiki extensions / 3WikidataRepo: prevent import of items - 10https://bugzilla.wikimedia.org/63228 (10Marius Hoch) [12:56:53] 3MediaWiki extensions / 3WikidataRepo: maintenance/importDump.php fails for wikidatawiki XML incremental dump files - 10https://bugzilla.wikimedia.org/70898#c4 (10Marius Hoch) We prevent this in Wikibase as importing Wikibase content usually doesn't work because entities are being referred to by entity ids,... [12:57:20] jzerebecki, good catch. Someone updated the fab URL, but we don't have mockups in the production instance yet. Let me add one mockup in Labs so people can still see what are we talking about. Thanks! [12:57:44] thx [13:07:21] (03CR) 10Matthias Mullie: [C: 04-1] Clean up watchlist icon markup and CSS (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155214 (owner: 10SG) [13:08:49] (03PS1) 10Gilles: Make options of a custom campaign field parseable [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/162227 (https://bugzilla.wikimedia.org/71160) [13:09:22] jzerebecki, fixed, now it links to https://phab-01.wmflabs.org/M1 [13:17:55] jzerebecki, if you have suggestions to improve that page, I'm all ears/eyes. [13:24:25] 3MediaWiki extensions / 3Scribunto: Script error "attempt to concatenate a nil value" when running in HHVM - 10https://bugzilla.wikimedia.org/71174 (10Liangent) 3NEW p:3Unprio s:3normal a:3None Lua错误 模块:Wikidata的第16行：attempt to concatenate a nil value 回溯： [C]: 在函数“getExpandedArgument”中 mw.l... [13:24:38] (03CR) 10Gergő Tisza: Make options of a custom campaign field parseable (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/162227 (https://bugzilla.wikimedia.org/71160) (owner: 10Gilles) [13:24:53] (03CR) 10Gilles: [C: 032] Make tutorial step a controller and UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 (owner: 10MarkTraceur) [13:24:56] (03CR) 10jenkins-bot: [V: 04-1] Make tutorial step a controller and UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 (owner: 10MarkTraceur) [13:27:22] 3MediaWiki extensions / 3WikidataRepo: Update ApiModules to conform to api conventions - 10https://bugzilla.wikimedia.org/69739 (10Lucie Kaffee) [13:27:23] 3MediaWiki extensions / 3Scribunto: Script error "attempt to concatenate a nil value" when running in HHVM - 10https://bugzilla.wikimedia.org/71174#c1 (10Liangent) s:5normal>3major Bumping severity because it causes (recoverable) data loss in *links table when someone triggering a linksupdate is using HH... [13:27:42] (03CR) 10Gilles: Make options of a custom campaign field parseable (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/162227 (https://bugzilla.wikimedia.org/71160) (owner: 10Gilles) [13:34:37] 3Wikimedia / 3Wikidata: blacklist a number of properties in the entity suggester - 10https://bugzilla.wikimedia.org/70346 (10Lydia Pintscher) [13:34:46] (03PS2) 10Gilles: Make options of a custom campaign field parseable [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/162227 (https://bugzilla.wikimedia.org/71160) [13:34:52] 3Wikimedia / 3Wikidata: blacklist a number of properties in the entity suggester - 10https://bugzilla.wikimedia.org/70346 (10Lydia Pintscher) 5PATC>3ASSI [13:35:07] 3Wikimedia / 3Wikidata: blacklist a number of properties in the entity suggester - 10https://bugzilla.wikimedia.org/70346#c4 (10Lydia Pintscher) As discussed P45, P71, P74, P643 and P1384 are still missing. [13:37:22] 3MediaWiki extensions / 3WikidataRepo: Test conformance of API modules - 10https://bugzilla.wikimedia.org/67407 (10Lydia Pintscher) [13:38:23] 3MediaWiki extensions / 3WikidataRepo: check compatibility of DataModel 1.0 with entity blobs in a (old) dump - 10https://bugzilla.wikimedia.org/70750 (10Lydia Pintscher) 5NEW>3ASSI [13:38:24] 3MediaWiki extensions / 3WikidataRepo: Investigate issues with globe coordinate precision - 10https://bugzilla.wikimedia.org/70934 (10Lydia Pintscher) 5NEW>3ASSI [13:38:52] 3MediaWiki extensions / 3WikidataRepo: Badge for quality articles on Wikidata - 10https://bugzilla.wikimedia.org/70268 (10Lydia Pintscher) 5NEW>3ASSI [13:38:54] 3MediaWiki extensions / 3WikidataRepo: Investigate issues with time value precision - 10https://bugzilla.wikimedia.org/70935 (10Lydia Pintscher) 5NEW>3ASSI [13:39:09] 3MediaWiki extensions / 3WikidataRepo: add featured list badge - 10https://bugzilla.wikimedia.org/70332 (10Lydia Pintscher) 5NEW>3ASSI [13:39:37] 3MediaWiki extensions / 3WikidataRepo: Implement terms-lookup based on terms-table - 10https://bugzilla.wikimedia.org/71169 (10Lydia Pintscher) 5NEW>3ASSI [13:39:52] 3MediaWiki extensions / 3WikidataRepo: Update ApiModules to conform to api conventions - 10https://bugzilla.wikimedia.org/69739 (10Lydia Pintscher) 5NEW>3ASSI [13:45:03] (03CR) 10He7d3r: "Looks like a follow-up to" [core] - 10https://gerrit.wikimedia.org/r/162123 (owner: 10Jackmcbarn) [13:46:37] (03CR) 10Reedy: "Thanks for fixing up, as per my comment above, it wasn't my intention to merge this into master, just the "easiest" route for getting a re" [core] - 10https://gerrit.wikimedia.org/r/161324 (owner: 10Reedy) [13:50:34] (03PS1) 10Hoo man: Introduce: mw.Api.newFor [core] - 10https://gerrit.wikimedia.org/r/162229 [13:52:23] (03CR) 10Marcoil: "This patch will help a lot in making Parsoid's output render visually equal HTML+CSS. Just a question: Why is the prop 'rlmodules' instead" [core] - 10https://gerrit.wikimedia.org/r/162123 (owner: 10Jackmcbarn) [13:52:54] 3MediaWiki / 3Templates: Non-included tables break parser - 10https://bugzilla.wikimedia.org/35476#c5 (10Bachsau) Well, de-prioritising bugs open since 2012 instead of fixing them is really the best way to solve problems, I think. :/ [13:56:55] (03CR) 10Aude: [C: 031] "would be useful for many use cases (wikibase, gadgets, other extensions), that makes sense to have this in core." [core] - 10https://gerrit.wikimedia.org/r/162229 (owner: 10Hoo man) [13:57:08] (03CR) 10jenkins-bot: [V: 04-1] Introduce: mw.Api.newFor [core] - 10https://gerrit.wikimedia.org/r/162229 (owner: 10Hoo man) [13:57:49] (03PS3) 10Gilles: Make options of a custom campaign field parseable [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/162227 (https://bugzilla.wikimedia.org/71160) [13:58:12] (03CR) 10Gilles: Make options of a custom campaign field parseable (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/162227 (https://bugzilla.wikimedia.org/71160) (owner: 10Gilles) [13:59:45] (03PS2) 10Hoo man: Introduce: mw.Api.newFor [core] - 10https://gerrit.wikimedia.org/r/162229 [14:06:13] (03PS1) 10Matthias Mullie: Show error message at correct location [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162231 [14:06:16] (03PS1) 10Matthias Mullie: Prevent ConfirmEdit captcha from attempting to leave the page in FF [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162232 [14:06:19] (03PS1) 10Manybubbles: SWAT Update Cirrus [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/162233 [14:06:21] (03CR) 10jenkins-bot: [V: 04-1] Introduce: mw.Api.newFor [core] - 10https://gerrit.wikimedia.org/r/162229 (owner: 10Hoo man) [14:07:54] wow... that's picky [14:09:34] (03PS3) 10Hoo man: Introduce: mw.Api.newFor [core] - 10https://gerrit.wikimedia.org/r/162229 [14:10:52] (03PS1) 10Manybubbles: SWAT update Cirrus [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162235 [14:16:08] 3Wikimedia / 3Deployment systems: [Regression] foreachwiki should not run on labswiki (wikitech.wm.o) - 10https://bugzilla.wikimedia.org/70311#c4 (10Antoine "hashar" Musso) > Is this really major? IIRC it'll just skip the wiki and carry on, so it's not a great inconvience foreachwikiindblist does not have s... [14:17:12] (03CR) 10Jackmcbarn: "Because there's too many things that we call modules. I didn't realize action=parse did it too, though. I'll change it to that here." [core] - 10https://gerrit.wikimedia.org/r/162123 (owner: 10Jackmcbarn) [14:18:02] (03PS2) 10Jackmcbarn: Expose ResourceLoader modules to action=expandtemplates [core] - 10https://gerrit.wikimedia.org/r/162123 [14:18:20] (03PS1) 10Manybubbles: Fix total_shards_per_node config [extensions/CirrusSearch] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162237 [14:18:37] 3Wikimedia / 3Deployment systems: [ops] Monitor that LVS config and mw_install are in sync - 10https://bugzilla.wikimedia.org/23662#c6 (10Antoine "hashar" Musso) That is still valid. I heard very recently of an application server being pooled back with a wrong wmf version :-/ This bug probably needs to be... [14:18:49] (03CR) 10Manybubbles: [C: 032] Fix total_shards_per_node config [extensions/CirrusSearch] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162237 (owner: 10Manybubbles) [14:28:56] (03Merged) 10jenkins-bot: Fix total_shards_per_node config [extensions/CirrusSearch] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162237 (owner: 10Manybubbles) [14:29:23] (03PS1) 10Manybubbles: Redo job that counts incoming links [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/162240 [14:30:41] (03PS2) 10Manybubbles: SWAT update Cirrus [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162235 [14:44:14] (03PS1) 10Gergő Tisza: Move addTrackingCategory from Parser to ParserOutput [core] - 10https://gerrit.wikimedia.org/r/162241 [14:46:09] 3MediaWiki extensions / 3Scribunto: Script error "attempt to concatenate a nil value" when running in HHVM - 10https://bugzilla.wikimedia.org/71174#c2 (10Jackmcbarn) It looks like nested Lua calls are propagating errors up further than they should. I'm investigating why. [14:46:38] (03PS1) 10Matthias Mullie: Fix [Object object] placeholder text in topic reply field [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162243 [14:46:57] (03CR) 10Jackmcbarn: Move addTrackingCategory from Parser to ParserOutput (031 comment) [core] - 10https://gerrit.wikimedia.org/r/162241 (owner: 10Gergő Tisza) [14:47:35] (03CR) 10jenkins-bot: [V: 04-1] Fix [Object object] placeholder text in topic reply field [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162243 (owner: 10Matthias Mullie) [14:50:22] 3MediaWiki extensions / 3Scribunto: Script error "attempt to concatenate a nil value" when running in HHVM - 10https://bugzilla.wikimedia.org/71174#c3 (10Brad Jorsch) Created attachment 16553 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16553&action=edit Test case I've reduced this to a more minim... [14:51:07] jackmcbarn: Re bug 71174, I tracked it down [14:52:01] kk [14:53:34] (03PS1) 10Matthias Mullie: Placeholder should only contain text of exactly the topic being replied to [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162276 [14:53:37] (03PS1) 10Matthias Mullie: First trim content, then truncate [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162277 [14:53:40] (03PS3) 10Gergő Tisza: Introduce ContentAlterParserOutput hook [core] - 10https://gerrit.wikimedia.org/r/161471 [14:55:01] (03CR) 10Gergő Tisza: "Reverted to the original concept (a hook called by all Content classes), removed Parser dependency." [core] - 10https://gerrit.wikimedia.org/r/161471 (owner: 10Gergő Tisza) [14:56:29] (03CR) 10jenkins-bot: [V: 04-1] Placeholder should only contain text of exactly the topic being replied to [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162276 (owner: 10Matthias Mullie) [14:56:50] (03CR) 10jenkins-bot: [V: 04-1] First trim content, then truncate [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162277 (owner: 10Matthias Mullie) [15:01:14] (03CR) 10Manybubbles: [C: 032] SWAT update Cirrus [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162235 (owner: 10Manybubbles) [15:02:29] (03PS2) 10Matthias Mullie: Fix [Object object] placeholder text in topic reply field [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162243 [15:03:26] (03CR) 10Manybubbles: [C: 032] SWAT update Cirrus [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162235 (owner: 10Manybubbles) [15:05:16] (03PS2) 10Matthias Mullie: Placeholder should only contain text of exactly the topic being replied to [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162276 [15:06:23] 3MediaWiki / 3Uploading: Generate thumbnails based on buckets - 10https://bugzilla.wikimedia.org/67525#c22 (10Gilles Dubuc) I can finally repro and I know why it's happening: currently mediawiki doesn't do any sharpening for PNGs. It does for JPGs, and the extra sharpening passes in the chaining compensate t... [15:06:30] (03Merged) 10jenkins-bot: SWAT update Cirrus [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162235 (owner: 10Manybubbles) [15:09:51] (03PS1) 10Gilles: Disable thumbnail chaining support for PNGs [core] - 10https://gerrit.wikimedia.org/r/162279 (https://bugzilla.wikimedia.org/67525) [15:12:06] (03CR) 10Gilles: "I remember now that this was added as a last-minute addition to the changing changeset. "PNG should just work" was the reasoning, and I di" [core] - 10https://gerrit.wikimedia.org/r/162279 (https://bugzilla.wikimedia.org/67525) (owner: 10Gilles) [15:12:19] (03CR) 10Manybubbles: [C: 032] SWAT Update Cirrus [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/162233 (owner: 10Manybubbles) [15:12:27] (03CR) 10SG: Change mw-ui anchors to require mw-ui-anchor base class, and introduce mw-ui-text base class (031 comment) [core] - 10https://gerrit.wikimedia.org/r/155856 (https://bugzilla.wikimedia.org/69212) (owner: 10SG) [15:15:15] (03Merged) 10jenkins-bot: SWAT Update Cirrus [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/162233 (owner: 10Manybubbles) [15:17:25] (03PS1) 10Matthias Mullie: Remove lower-level posts' right padding [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162280 [15:19:24] 3MediaWiki / 3Internationalization: MessageCache cloning of parser breaks stuff if it happens while in the process of parsing something - 10https://bugzilla.wikimedia.org/56226#c24 (10Brad Jorsch) 5PATC>3RESO/FIX This should be fixed now. The fix should be deployed to WMF wikis with 1.24wmf23 or 1.25wmf1... [15:26:46] (03CR) 10Gergő Tisza: [C: 032] Disable thumbnail chaining support for PNGs [core] - 10https://gerrit.wikimedia.org/r/162279 (https://bugzilla.wikimedia.org/67525) (owner: 10Gilles) [15:30:08] 3Wikimedia / 3Site requests: please add *.beeldbank.cultureelerfgoed.nl to the wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/70840#c4 (10Glaisher) 5PATC>3RESO/FIX a:3Glaisher Sorry for the delay. [15:33:08] (03Merged) 10jenkins-bot: Disable thumbnail chaining support for PNGs [core] - 10https://gerrit.wikimedia.org/r/162279 (https://bugzilla.wikimedia.org/67525) (owner: 10Gilles) [15:35:09] 3MediaWiki-Vagrant: /usr/lib/hphp/hphpize/hphpize.cmake has /root/hhvm/joe/hhvm in HHVM_INCLUDE_DIRS - 10https://bugzilla.wikimedia.org/71177 (10Jackmcbarn) 3NEW p:3Unprio s:3normal a:3Giuseppe Lavagetto When trying to compile an HHVM extension in Vagrant, it fails because it tries to look in /root/hhv... [15:35:52] 3Wikimedia / 3Site requests: Remove namespace alias on ckb wikipedia - 10https://bugzilla.wikimedia.org/70564#c5 (10Calak) 5PATC>3RESO/FIX Thank you. [15:35:52] 3MediaWiki-Vagrant: /usr/lib/hphp/hphpize/hphpize.cmake has /root/hhvm/joe/hhvm in HHVM_INCLUDE_DIRS - 10https://bugzilla.wikimedia.org/71177 (10Bryan Davis) [15:40:36] 3Wikimedia / 3Deployment systems: [Regression] foreachwiki should not run on labswiki (wikitech.wm.o) - 10https://bugzilla.wikimedia.org/70311#c5 (10Sam Reed (reedy)) (In reply to Antoine "hashar" Musso from comment #4) > > From tin (et al), they can't actually access the wikitech database (currently at > >... [15:49:28] (03CR) 10Yaron Koren: "Sorry for the delay. After all this time reviewing the code, I finally tried it out on my wiki. The overall functionality seems to work ve" [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [15:50:24] 3Wikimedia / 3Site requests: Remove namespace alias on ckb wikipedia - 10https://bugzilla.wikimedia.org/70564#c6 (10Glaisher) a:3Glaisher Sorry for the delay. The link tables have also been updated, thanks to Nik. [15:50:59] 3MediaWiki / 3API: API imageinfo should allow fetching multiple thumbnail sizes - 10https://bugzilla.wikimedia.org/54035 (10Tisza Gergő) [15:52:19] (03CR) 10Subramanya Sastry: [C: 031] "Will let others look at it as well." [core] - 10https://gerrit.wikimedia.org/r/162123 (owner: 10Jackmcbarn) [15:56:17] (03CR) 10Jdlrobson: Change mw-ui anchors to require mw-ui-anchor base class, and introduce mw-ui-text base class (031 comment) [core] - 10https://gerrit.wikimedia.org/r/155856 (https://bugzilla.wikimedia.org/69212) (owner: 10SG) [15:57:08] 3Wikimedia / 3Site requests: Remove namespace alias on ckb wikipedia - 10https://bugzilla.wikimedia.org/70564#c7 (10Calak) No problem. Thank you for your good work. [16:00:51] (03CR) 10Jdlrobson: [C: 031] "Let's get using this and see where it gets us :)" [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) (owner: 10Jdlrobson) [16:01:01] qgil: FYI http://blog.jetbrains.com/blog/2014/09/23/jetbrains-makes-its-products-free-for-students/ [16:01:57] "free" [16:02:48] marktraceur: behave [16:03:07] I never do [16:03:26] 3MediaWiki extensions / 3CirrusSearch: Create red link suggestion on searching categories - 10https://bugzilla.wikimedia.org/71179 (10Teles) 3NEW p:3Unprio s:3normal a:3None Created attachment 16555 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16555&action=edit Searching category with no re... [16:04:23] 3MediaWiki extensions / 3CirrusSearch: Create red link suggestion on searching categories - 10https://bugzilla.wikimedia.org/71179#c1 (10Teles) Created attachment 16556 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16556&action=edit Searching category with ":" but no similar results That would be "... [16:07:38] 3MediaWiki extensions / 3EducationProgram: "Remove from course" button no longer works - 10https://bugzilla.wikimedia.org/70748#c6 (10vojtech.dostal@wikimedia.cz) Hi, the same problem occurs on Czech Wikipedia. Can you estimate when this gets solved? [16:15:54] 3Wikimedia / 3Extension setup: add easy timeline extension on urdu wiki - 10https://bugzilla.wikimedia.org/70667#c1 (10Glaisher) 5NEW>3RESO/INV EasyTimeline is enabled on all Wikimedia projects by default. In fact, it's even currently being used at urwiki; see [[ur:بلھن]] for example. [16:16:22] 3MediaWiki extensions / 3LiquidThreads: Linker::link: Requires $target to be a Title object [Called from ApiFeedLQTThreads::createFeedItem] - 10https://bugzilla.wikimedia.org/71168#c1 (10Sam Reed (reedy)) Presumably it's null then? :/ [16:22:18] (03CR) 10Phuedx: [C: 032] Add mw-ui-icon [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) (owner: 10Jdlrobson) [16:23:03] (03CR) 10Anomie: [C: 04-1] "Besides the inline comment, it doesn't seem to actually output any modules when used with Babel. Probably because Babel uses addModuleStyl" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/162123 (owner: 10Jackmcbarn) [16:23:29] (03CR) 10Jamesmontalvo3: "* I'll fix the nav links" [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [16:27:22] 3MediaWiki / 3API: API imageinfo should allow fetching multiple thumbnail sizes - 10https://bugzilla.wikimedia.org/54035#c4 (10Tisza Gergő) Client-defined multivalue will be needed by a lot of applications including bug 54033 and bug 67323. The current syntax looks like this: https://commons.wikimedia.org/... [16:27:23] (03CR) 10Anomie: [C: 031] Move addTrackingCategory from Parser to ParserOutput (031 comment) [core] - 10https://gerrit.wikimedia.org/r/162241 (owner: 10Gergő Tisza) [16:27:47] (03CR) 10Anomie: [C: 031] "Looks good now at a glance. Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/161471 (owner: 10Gergő Tisza) [16:28:36] (03Merged) 10jenkins-bot: Add mw-ui-icon [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) (owner: 10Jdlrobson) [16:28:45] (03PS1) 10Aude: Add some Wikibase client settings [vagrant] - 10https://gerrit.wikimedia.org/r/162284 [16:28:54] 3MediaWiki / 3API: ApiQueryAllUsers with auactiveusers fails on duplicate querycachetwo rows - 10https://bugzilla.wikimedia.org/71086#c4 (10Aaron Schulz) Also could be the connection dropping and reconnecting in cli mode when run for $wgSpecialPageCacheUpdates. The DB layer will reconnect but the lock will b... [16:30:37] 3MediaWiki extensions / 3EducationProgram: "Remove from course" button no longer works - 10https://bugzilla.wikimedia.org/70748#c7 (10Sage Ross) @vojtech: The fix got merged last week before the new deployment branch, which means it should go live this Thursday. [16:31:53] 3MediaWiki extensions / 3EducationProgram: "Remove from course" button no longer works - 10https://bugzilla.wikimedia.org/70748#c8 (10vojtech.dostal@wikimedia.cz) @sage Thank you for information, that's brilliant:) [16:32:10] (03PS1) 10Aude: Add memcached role [vagrant] - 10https://gerrit.wikimedia.org/r/162285 [16:32:15] (03CR) 10jenkins-bot: [V: 04-1] Add memcached role [vagrant] - 10https://gerrit.wikimedia.org/r/162285 (owner: 10Aude) [16:33:30] (03PS2) 10Aude: Add memcached role [vagrant] - 10https://gerrit.wikimedia.org/r/162285 [16:37:39] (03CR) 10Jdlrobson: [C: 04-1] "1 comment. I think you forgot to add Resources.php change or do a git rename?" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155612 (owner: 10SG) [16:42:40] (03PS1) 10Physikerwelt: Add counter to DatabaseUpdater::setAppliedUpdates [core] - 10https://gerrit.wikimedia.org/r/162286 (https://bugzilla.wikimedia.org/71087) [16:45:27] 3MediaWiki / 3MediaWiki UI: Use mw-ui-icon (tracking) - 10https://bugzilla.wikimedia.org/71180 (10Jon) 3NEW p:3Unprio s:3normal a:3None Various projects are making use of icons. Let's all use the same markup as documented here [1] and upstream the common icon classes into some kind of sharing library... [16:46:39] 3MediaWiki / 3MediaWiki UI: Use mw-ui-icon (tracking) - 10https://bugzilla.wikimedia.org/71180 (10Jon) [16:47:08] (03PS2) 10Gergő Tisza: Move addTrackingCategory from Parser to ParserOutput [core] - 10https://gerrit.wikimedia.org/r/162241 [16:48:26] (03PS1) 10Aaron Schulz: Fixes to prevent duplicate rows in ActiveUser cache [core] - 10https://gerrit.wikimedia.org/r/162287 [16:49:20] (03CR) 10jenkins-bot: [V: 04-1] Add counter to DatabaseUpdater::setAppliedUpdates [core] - 10https://gerrit.wikimedia.org/r/162286 (https://bugzilla.wikimedia.org/71087) (owner: 10Physikerwelt) [16:52:38] 3MediaWiki / 3Templates: Non-included tables break parser - 10https://bugzilla.wikimedia.org/35476#c6 (10Andre Klapper) Bachsau: You moved the priority yourself up from 'normal' to 'high'. I reverted that as priority is meant to reflect reality and as I have seen no signs here that you plan to work on fixin... [16:55:43] (03PS1) 10Cscott: Don't crash on images in subpages, or images with invalid titles. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/162289 [16:57:36] (03CR) 10jenkins-bot: [V: 04-1] Don't crash on images in subpages, or images with invalid titles. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/162289 (owner: 10Cscott) [17:01:54] (03CR) 10Aaron Schulz: [C: 032] Avoided use of deprecated job method [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/162007 (owner: 10Aaron Schulz) [17:03:22] 3MediaWiki / 3MediaWiki UI: Add icon support for mediawiki.ui buttons - 10https://bugzilla.wikimedia.org/55535#c16 (10Jon) 5PATC>3RESO/FIX Actually using these buttons should be put into a separate bug report and tied to bug 71180 [17:03:55] (03Merged) 10jenkins-bot: Avoided use of deprecated job method [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/162007 (owner: 10Aaron Schulz) [17:05:11] (03CR) 10Krinkle: Introduce: mw.Api.newFor (032 comments) [core] - 10https://gerrit.wikimedia.org/r/162229 (owner: 10Hoo man) [17:06:06] (03CR) 10Gergő Tisza: Move addTrackingCategory from Parser to ParserOutput (031 comment) [core] - 10https://gerrit.wikimedia.org/r/162241 (owner: 10Gergő Tisza) [17:09:25] 3MediaWiki / 3MediaWiki UI: Use mw-ui-icon (tracking) - 10https://bugzilla.wikimedia.org/71180 (10Jon) [17:10:18] (03PS2) 10Cscott: Don't crash on images in subpages, or images with invalid titles. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/162289 [17:12:19] 3MediaWiki / 3API: API imageinfo should allow fetching multiple thumbnail sizes - 10https://bugzilla.wikimedia.org/54035#c5 (10Brad Jorsch) (In reply to Tisza Gergő from comment #4) > 1) make iiurlwidth & co. multivalue, use empty values to match up the values: [...] > This is fully BC but extremely hacky.... [17:17:04] (03CR) 10Arlolra: [C: 032] Don't crash on images in subpages, or images with invalid titles. (031 comment) [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/162289 (owner: 10Cscott) [17:18:45] (03CR) 10Anomie: Move addTrackingCategory from Parser to ParserOutput (031 comment) [core] - 10https://gerrit.wikimedia.org/r/162241 (owner: 10Gergő Tisza) [17:18:52] (03Merged) 10jenkins-bot: Don't crash on images in subpages, or images with invalid titles. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/162289 (owner: 10Cscott) [17:19:10] (03CR) 10Yaron Koren: "Hi," [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [17:25:10] legoktm, hi, anything to hold https://gerrit.wikimedia.org/r/#/c/160541/ back? [17:32:37] 3MediaWiki / 3Templates: Non-included tables break parser - 10https://bugzilla.wikimedia.org/35476#c7 (10Bachsau) If I'd plan on fixing this myself I hadn't reported it as a bug. Sure I'm a registered developer, but not a core developer, and I don't habe time do to complex work for every possible software. [17:33:09] (03PS2) 10Matthias Mullie: First trim content, then truncate [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162277 [17:34:07] 3MediaWiki extensions / 3Collection: Images embedded in PDF have an excessive resolution - 10https://bugzilla.wikimedia.org/68576#c8 (10C. Scott Ananian) 1200px x 1200px is 300dpi for a 4" wide image (single column). That is "print-appropriate" -- but many of our articles happen to have a large number of ex... [17:34:25] (03PS1) 10Cscott: Reduce default image resolution to 150dpi. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/162296 (https://bugzilla.wikimedia.org/68576) [17:35:38] 3MediaWiki / 3Special pages: Add largest files maintenance report - 10https://bugzilla.wikimedia.org/71183 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3enhanc a:3None Possibly doesn't even need to be a maintenance report per se, the img_size field is indexed... select img_name, img_size from image order b... [17:36:07] 3MediaWiki / 3Internationalization: MessageCache cloning of parser breaks stuff if it happens while in the process of parsing something - 10https://bugzilla.wikimedia.org/56226 (10Nemo) [17:40:04] (03CR) 10Gergő Tisza: Move addTrackingCategory from Parser to ParserOutput (031 comment) [core] - 10https://gerrit.wikimedia.org/r/162241 (owner: 10Gergő Tisza) [17:40:07] (03CR) 10Arlolra: "Does this mean you don't need a resizer?" [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/162296 (https://bugzilla.wikimedia.org/68576) (owner: 10Cscott) [17:43:55] (03PS4) 10Gergő Tisza: Introduce ContentAlterParserOutput hook [core] - 10https://gerrit.wikimedia.org/r/161471 [17:44:22] (03CR) 10Gergő Tisza: "Added release notes." [core] - 10https://gerrit.wikimedia.org/r/161471 (owner: 10Gergő Tisza) [17:44:24] (03CR) 10jenkins-bot: [V: 04-1] Introduce ContentAlterParserOutput hook [core] - 10https://gerrit.wikimedia.org/r/161471 (owner: 10Gergő Tisza) [17:46:37] (03PS5) 10Gergő Tisza: Introduce ContentAlterParserOutput hook [core] - 10https://gerrit.wikimedia.org/r/161471 [17:47:31] (03CR) 10Krinkle: "Hm.. is this supposed to make requests without a callback parameter or with callback? E.g. logged in or logged out?" [core] - 10https://gerrit.wikimedia.org/r/162229 (owner: 10Hoo man) [17:47:37] (03CR) 10Krinkle: [C: 04-1] Introduce: mw.Api.newFor [core] - 10https://gerrit.wikimedia.org/r/162229 (owner: 10Hoo man) [17:48:32] AaronSchulz: can you guesstimate how much work is required for manual fix of RT 6804? who is able to do it? [17:49:09] (03CR) 10BryanDavis: [C: 032] Set "normal" ownership on /srv [vagrant] - 10https://gerrit.wikimedia.org/r/162177 (owner: 10BryanDavis) [17:49:14] (03Merged) 10jenkins-bot: Set "normal" ownership on /srv [vagrant] - 10https://gerrit.wikimedia.org/r/162177 (owner: 10BryanDavis) [17:49:41] (03PS2) 10BryanDavis: Sync /etc/apt/sources.list.d/wikimedia.list with WMF production [vagrant] - 10https://gerrit.wikimedia.org/r/162183 [17:49:55] (03CR) 10BryanDavis: [C: 032] Sync /etc/apt/sources.list.d/wikimedia.list with WMF production [vagrant] - 10https://gerrit.wikimedia.org/r/162183 (owner: 10BryanDavis) [17:49:58] (03Merged) 10jenkins-bot: Sync /etc/apt/sources.list.d/wikimedia.list with WMF production [vagrant] - 10https://gerrit.wikimedia.org/r/162183 (owner: 10BryanDavis) [17:50:09] 3MediaWiki / 3MediaWiki UI: Use mw-ui-icon (tracking) - 10https://bugzilla.wikimedia.org/71180 (10Sam Smith) [17:59:05] jeremyb: that should be moved out of RT, someone from MM can look at it [18:00:16] well already discussed with tgr. sounded like there were very few people able to do it [18:06:00] (03PS1) 10Cscott: Don't crash if
begins a figure caption. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/162299 [18:07:22] (03PS1) 10Manybubbles: Reduce queries to count links [extensions/CirrusSearch] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162300 [18:13:09] 3MediaWiki extensions / 3MassMessage: MassMessage LQT support broken - 10https://bugzilla.wikimedia.org/71081#c14 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3Kunal Mehta (Legoktm) Backported to WMF sites yesterday, confirmed working again: (03CR) 10Jack Phoenix: [C: 032] Fix and update SpecialUserlogin.php patch so core still works without the extension installed. [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/162206 (owner: 10Isarra) [18:15:20] (03CR) 10Jamesmontalvo3: "For #2: I'll change it back to pipe-separators and we can find a cleaner solution in a later patch." [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [18:16:15] (03PS1) 10Isarra: Make h1-6 sizes consistently different [skins/Vector] - 10https://gerrit.wikimedia.org/r/162304 [18:17:00] (03Merged) 10jenkins-bot: Fix and update SpecialUserlogin.php patch so core still works without the extension installed. [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/162206 (owner: 10Isarra) [18:17:23] (03PS6) 10BryanDavis: [WIP] Special page to manage global rename requests [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159331 (https://bugzilla.wikimedia.org/68924) [18:17:28] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Special page to manage global rename requests [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159331 (https://bugzilla.wikimedia.org/68924) (owner: 10BryanDavis) [18:18:45] (03CR) 10Legoktm: [C: 032] Add missing space to log message [core] - 10https://gerrit.wikimedia.org/r/162216 (owner: 10IAlex) [18:20:40] (03CR) 10Anomie: Fixes to prevent duplicate rows in ActiveUser cache (032 comments) [core] - 10https://gerrit.wikimedia.org/r/162287 (owner: 10Aaron Schulz) [18:25:06] (03PS1) 10Jeremyb: on master [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/162305 [18:25:12] (03Merged) 10jenkins-bot: Add missing space to log message [core] - 10https://gerrit.wikimedia.org/r/162216 (owner: 10IAlex) [18:25:21] oh, that goes here, huh [18:27:05] (03PS1) 10Jeremyb: on b1 [test/mediawiki/extensions/examples] (b1) - 10https://gerrit.wikimedia.org/r/162307 [18:27:43] K4-713: huh, no ejegg here [18:27:58] * K4-713 frowns [18:28:21] (03PS1) 10EBernhardson: Don't treat topic title as wikitext [extensions/Flow] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162308 [18:29:02] (03PS2) 10Krinkle: PrefixSearch: Add unit tests for StringPrefixSearch [core] - 10https://gerrit.wikimedia.org/r/162190 [18:29:11] (03PS1) 10Aaron Schulz: Use a less confusing column alias in findMissingFiles.php [core] - 10https://gerrit.wikimedia.org/r/162309 [18:29:56] (03PS1) 10EBernhardson: Don't run progressiveEnhancements through handlebars.js [extensions/Flow] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162311 (https://bugzilla.wikimedia.org/70982) [18:29:59] (03PS1) 10Cscott: Don't crash if we encounter uncontained
  • . [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/162312 [18:30:08] (03CR) 10Krinkle: "Done." [core] - 10https://gerrit.wikimedia.org/r/162190 (owner: 10Krinkle) [18:30:11] 3Wikimedia / 3Extension setup: Expand deployment of UserMerge to all CentralAuth-enabled Wikimedia wikis - 10https://bugzilla.wikimedia.org/68844 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX [18:30:57] (03PS1) 10EBernhardson: Properly escape topic title in compare-post-revisions [extensions/Flow] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162314 [18:31:00] (03Abandoned) 10Jeremyb: on b1 [test/mediawiki/extensions/examples] (b1) - 10https://gerrit.wikimedia.org/r/162307 (owner: 10Jeremyb) [18:31:18] (03CR) 10EBernhardson: [C: 032] Properly escape topic title in compare-post-revisions [extensions/Flow] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162314 (owner: 10EBernhardson) [18:31:40] (03CR) 10EBernhardson: [C: 032] (bug 71109) Fix broken Special:EditWatchlist [extensions/Flow] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162169 (https://bugzilla.wikimedia.org/71109) (owner: 10EBernhardson) [18:31:47] (03CR) 10EBernhardson: [C: 032] Repair individual post collapse in Topic namespace [extensions/Flow] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162174 (https://bugzilla.wikimedia.org/71132) (owner: 10EBernhardson) [18:31:57] (03CR) 10EBernhardson: [C: 032] Don't treat topic title as wikitext [extensions/Flow] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162308 (owner: 10EBernhardson) [18:32:02] (03Merged) 10jenkins-bot: Properly escape topic title in compare-post-revisions [extensions/Flow] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162314 (owner: 10EBernhardson) [18:32:05] (03CR) 10EBernhardson: [C: 032] Don't run progressiveEnhancements through handlebars.js [extensions/Flow] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162311 (https://bugzilla.wikimedia.org/70982) (owner: 10EBernhardson) [18:32:10] 3MediaWiki extensions / 3WikimediaEvents: Make the HHVM BetaFeature up to snuff (BetaFeature-wise) - 10https://bugzilla.wikimedia.org/71048 (10James Forrester) a:3James Forrester [18:32:17] (03Merged) 10jenkins-bot: (bug 71109) Fix broken Special:EditWatchlist [extensions/Flow] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162169 (https://bugzilla.wikimedia.org/71109) (owner: 10EBernhardson) [18:32:25] (03Merged) 10jenkins-bot: Repair individual post collapse in Topic namespace [extensions/Flow] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162174 (https://bugzilla.wikimedia.org/71132) (owner: 10EBernhardson) [18:33:00] (03CR) 10Cscott: "This is just a kludge. When we have inline and double-column images we'll still need a proper resizer." [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/162296 (https://bugzilla.wikimedia.org/68576) (owner: 10Cscott) [18:33:44] (03CR) 10Arlolra: "Ok, just confirming 'cause I was going to work on that today." [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/162296 (https://bugzilla.wikimedia.org/68576) (owner: 10Cscott) [18:35:23] (03CR) 10jenkins-bot: [V: 04-1] Don't treat topic title as wikitext [extensions/Flow] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162308 (owner: 10EBernhardson) [18:35:41] (03PS3) 10Krinkle: PrefixSearch: Add unit tests for StringPrefixSearch [core] - 10https://gerrit.wikimedia.org/r/162190 [18:35:45] quiddity: o/ [18:36:01] (03Merged) 10jenkins-bot: Don't run progressiveEnhancements through handlebars.js [extensions/Flow] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162311 (https://bugzilla.wikimedia.org/70982) (owner: 10EBernhardson) [18:36:04] (03CR) 10Jeremyb: [C: 032 V: 032] on master [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/162305 (owner: 10Jeremyb) [18:36:06] (03PS1) 10Manybubbles: Reduce queries to count links [extensions/CirrusSearch] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/162316 [18:36:38] (03CR) 10EBernhardson: [C: 032] "something bugged on jenkins during qunit run, try again" [extensions/Flow] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162308 (owner: 10EBernhardson) [18:36:56] 3MediaWiki extensions / 3Collection: bundler shouldn't need prefix - 10https://bugzilla.wikimedia.org/71186 (10C. Scott Ananian) 3NEW p:3Unprio s:3normal a:3None We should use the v2 parsoid API, which doesn't require magic prefix mapping. Eg: http://parsoid-lb.eqiad.wikimedia.org/v2/en.wikipedia.or... [18:37:06] (03PS1) 10Jeremyb: on master still [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/162317 [18:37:18] (03Merged) 10jenkins-bot: Don't treat topic title as wikitext [extensions/Flow] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162308 (owner: 10EBernhardson) [18:37:36] quiddity: I am trying to make some changes to the styling of NavPopups, do you think you could use the same stylesheet so that we can spot any errors? [18:37:40] (03PS1) 10Jeremyb: branched. this is on master only [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/162318 [18:37:42] quiddity: thedj https://en.wikipedia.org/wiki/User:Prtksxna/common.css [18:38:28] (03PS1) 10EBernhardson: Bump Flow submodule in 1.24wmf22 [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162319 [18:39:45] (03CR) 10Arlolra: [C: 032] Reduce default image resolution to 150dpi. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/162296 (https://bugzilla.wikimedia.org/68576) (owner: 10Cscott) [18:40:13] MatmaRex, how does e('/* @embed */') work? [18:40:14] (03PS5) 10Krinkle: PrefixSearch: Enforce including the exact match as first result [core] - 10https://gerrit.wikimedia.org/r/161148 (https://bugzilla.wikimedia.org/70958) [18:40:26] (03CR) 10Subramanya Sastry: [C: 032] "Suggestion for possible improvement later. This is independent of the bug fix in Parsoid." (031 comment) [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/162312 (owner: 10Cscott) [18:40:28] bd808|LUNCH, hi, any updates on labs vagrant? [18:40:56] (03PS11) 10Krinkle: PrefixSearch: Implement searching in multiple namespaces [core] - 10https://gerrit.wikimedia.org/r/141660 (https://bugzilla.wikimedia.org/65752) (owner: 10Nikerabbit) [18:41:18] (03Merged) 10jenkins-bot: Reduce default image resolution to 150dpi. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/162296 (https://bugzilla.wikimedia.org/68576) (owner: 10Cscott) [18:43:24] yurikR: I think it's all fixed. I sent an email to labs-l [18:43:41] superm401: e() outputs its argument directly into the result CSS. it just produces the comment, which is handled by CSSMin later. [18:43:59] yurikR: There is one manual step to unf*ck the file permissions [18:44:04] MatmaRex, is that a lessphp feature? [18:44:10] e() I mean [18:44:25] superm401: less feature. every less compiler shou;ld support it [18:44:33] bd808, thx, looking for the step :) [18:44:47] yurikR: sudo chmod -R o+rX /srv/vagrant [18:45:00] superm401: i stole that from oojs ui, who use node less for compilation, it works the same there [18:45:13] bd808, thx! for some reason i don't see the email, need to get to yet another email list i guess [18:45:18] MatmaRex, cool, thanks. [18:45:31] yei, it provisioned! bd808 thx! [18:45:47] (03PS2) 10Legoktm: Make h1-6 sizes consistently different [skins/Vector] - 10https://gerrit.wikimedia.org/r/162304 (https://bugzilla.wikimedia.org/70004) (owner: 10Isarra) [18:46:10] 3MediaWiki skins / 3Vector: Vector: Grey content text impairs legibility - 10https://bugzilla.wikimedia.org/66021#c14 (10Jared Zimmerman (WMF)) 5PATC>3UNCO In the simulated images I'm not seeing any legibility issues, in general we strive to not recreate browser or OS functionality, in both windows, os x... [18:46:16] yurikR: Sweet. Sorry it was broken for so long. (I had a really fun weekend though, so I'm not too sorry) [18:46:26] 3Wikimedia / 3Extension setup: Review and deploy ImageMetrics extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/70402 (10Tisza Gergő) [18:46:37] (03PS1) 10Jeremyb: Merge branch 'master' into b1 [test/mediawiki/extensions/examples] (b1) - 10https://gerrit.wikimedia.org/r/162321 [18:46:45] (03PS3) 10Isarra: Make h1-6 sizes consistently different [skins/Vector] - 10https://gerrit.wikimedia.org/r/162304 [18:46:58] MatmaRex, apparently it can also be done with ~ if it's a static string: http://leafo.net/lessphp/docs/#string_unquoting [18:46:58] bd808, fun is good :) but we ought to have an automated jenkins provisioning some [18:47:07] However, this way is fine too. [18:47:14] someher - with an automated rollback after each try [18:47:22] (03CR) 10Jeremyb: [C: 032 V: 032] on master still [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/162317 (owner: 10Jeremyb) [18:47:24] (03PS1) 10Grunny: Replace deprecated mw.user.name() with mw.user.getName() [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/162322 [18:47:27] (03CR) 10Umherirrender: [C: 032] "Resubmit" [core] - 10https://gerrit.wikimedia.org/r/157352 (owner: 10Krinkle) [18:47:40] (03CR) 10Jeremyb: [C: 032 V: 032] branched. this is on master only [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/162318 (owner: 10Jeremyb) [18:48:12] yurikR: That would be nice, but not trivial to setup. I think Antoine has some ideas on a future where we can automate things in Openstack from Jenkins. [18:48:15] (03CR) 10Krinkle: [C: 032] Replace deprecated mw.user.name() with mw.user.getName() [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/162322 (owner: 10Grunny) [18:48:17] superm401: yeah, and at least the PHP compiler we use generally preserves regular /**/ comments too; i used e() because i already knew that works :) [18:48:47] (03CR) 10Krinkle: "It can't be merged because of an unmerged dependency." [core] - 10https://gerrit.wikimedia.org/r/157352 (owner: 10Krinkle) [18:48:49] (03CR) 10Jeremyb: [C: 032 V: 032] Merge branch 'master' into b1 [test/mediawiki/extensions/examples] (b1) - 10https://gerrit.wikimedia.org/r/162321 (owner: 10Jeremyb) [18:48:54] MatmaRex, it moves the regular ones (without e() and ~) sometimes. That was the issue we ran into before, I believe. [18:49:10] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/157351/3 [18:49:12] yeah [18:49:22] 3MediaWiki skins / 3Vector: Vector: h3 should not appear as heavier weight than h2 - 10https://bugzilla.wikimedia.org/69998#c2 (10Jared Zimmerman (WMF)) I'm not able to reproduce this. I'm seeing H2 and H3 as visually identical, but properly affecting the information hierarchy in the TOC, which seems reasona... [18:49:37] 3MediaWiki skins / 3Vector: Vector: h3 should not appear as heavier weight than h2 - 10https://bugzilla.wikimedia.org/69998 (10Jared Zimmerman (WMF)) 5PATC>3UNCO [18:51:04] (03Merged) 10jenkins-bot: Replace deprecated mw.user.name() with mw.user.getName() [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/162322 (owner: 10Grunny) [18:53:07] 3MediaWiki skins / 3Vector: h4, h5, and h6 headers should not have the same styling - 10https://bugzilla.wikimedia.org/70004#c5 (10Jared Zimmerman (WMF)) H1-H5 are properly affecting the information hierarchy in the TOC, which seems reasonable to me. I'm not sure I see the value in a proliferation of stylist... [18:53:10] 3MediaWiki skins / 3Vector: h4, h5, and h6 headers should not have the same styling - 10https://bugzilla.wikimedia.org/70004 (10Jared Zimmerman (WMF)) 5PATC>3UNCO [18:53:37] 3Wikimedia / 3Mailing lists: Create a mailing list for Maithili (mai) Wikipedia - 10https://bugzilla.wikimedia.org/44938#c5 (10Muzammil) There is need to re-examine the refusal: 1) Activity level has increased - 16 active users and about 60 overall users. 2) Likelihood of the Wikipedia in the near future (se... [18:54:10] (03CR) 10Legoktm: "This means vagrant is now back to using LCStoreDB instead of LCStoreCDB :(" [vagrant] - 10https://gerrit.wikimedia.org/r/161140 (https://bugzilla.wikimedia.org/70959) (owner: 10Dduvall) [18:55:18] legoktm: Have you tested that? Dan added the wgFileCacheDirectory setting to our wikifarm config files for each wiki. [18:55:48] I just git pulled and provisioned and now my vagrant is using LCStoreDB. [18:55:56] hmmm.... [18:55:57] I think wgCacheDirectory needs to be set too. [18:56:36] Ah. Yup [18:56:39] Easy fix [18:57:03] LocalisationCache::__construct [18:57:19] $storeClass = $wgCacheDirectory ? 'LCStoreCDB' : 'LCStoreDB'; [18:58:16] (03CR) 10Umherirrender: [C: 04-1] Reduce duplication in some Special:ListGroupRights code (032 comments) [core] - 10https://gerrit.wikimedia.org/r/162023 (owner: 10Alex Monk) [18:58:36] iOS-devs: https://lists.wikimedia.org/pipermail/mobile-l/2014-September/008075.html [18:58:49] (03CR) 10Legoktm: [C: 04-1] "Only one thing, everything else looked great and ready to be merged." (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156488 (https://bugzilla.wikimedia.org/68886) (owner: 10BryanDavis) [18:59:02] Josve05a: try #wikimedia-mobile ? [18:59:14] (03CR) 10Spage: [C: 04-1] "tip of this branch is 7706246. This bump is missing" [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162319 (owner: 10EBernhardson) [18:59:21] (03PS1) 10BryanDavis: Restore LCStoreCDB usage [vagrant] - 10https://gerrit.wikimedia.org/r/162334 [18:59:26] Oh, thnaks legoktm ! [18:59:29] legoktm: test that out ^^ [18:59:31] thanks* [19:04:32] (03PS2) 10Umherirrender: Use as strict comparison to check whether an user name was provided in Special:ListFiles [core] - 10https://gerrit.wikimedia.org/r/156688 (owner: 10IAlex) [19:04:40] (03CR) 10Umherirrender: [C: 032] Use as strict comparison to check whether an user name was provided in Special:ListFiles [core] - 10https://gerrit.wikimedia.org/r/156688 (owner: 10IAlex) [19:08:08] 3MediaWiki extensions / 3LiquidThreads: "My new messages" badge number is wrong - 10https://bugzilla.wikimedia.org/31251#c22 (10Sumana Harihareswara) 5NEW>3RESO/WOR I don't think I can still reproduce this. [19:08:27] (03CR) 10Legoktm: [C: 032] "Thanks" [vagrant] - 10https://gerrit.wikimedia.org/r/162334 (owner: 10BryanDavis) [19:08:33] (03Merged) 10jenkins-bot: Restore LCStoreCDB usage [vagrant] - 10https://gerrit.wikimedia.org/r/162334 (owner: 10BryanDavis) [19:10:28] (03PS1) 10Cscott: Don't crash if section/chapter title contains a URL. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/162361 [19:11:07] (03PS4) 10Isarra: Make h1-6 sizes consistently different [skins/Vector] - 10https://gerrit.wikimedia.org/r/162304 [19:11:07] 3MediaWiki / 3Redirects: Article redirect: act correctly regarding capitalization and markup - 10https://bugzilla.wikimedia.org/38660#c1 (10Sumana Harihareswara) (I still think this would be a cool idea.) [19:11:14] (03Merged) 10jenkins-bot: Use as strict comparison to check whether an user name was provided in Special:ListFiles [core] - 10https://gerrit.wikimedia.org/r/156688 (owner: 10IAlex) [19:11:56] (03CR) 10Catrope: [C: 032] doxygen: Fix trailing star in class member descriptions [core] - 10https://gerrit.wikimedia.org/r/157351 (owner: 10Krinkle) [19:12:42] (03PS2) 10Alex Monk: Reduce duplication in some Special:ListGroupRights code [core] - 10https://gerrit.wikimedia.org/r/162023 [19:13:12] > [GlobalTitleFail] RequestContext::getTitle called by MediaWiki::getTitlewith no title set. [19:14:06] (03Abandoned) 10Reza: Prevent join of Arabic translation [core] - 10https://gerrit.wikimedia.org/r/159993 (owner: 10Reza) [19:15:49] (03CR) 10Umherirrender: Add link to Special:PrefixIndex to Delete dialog (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151061 (https://bugzilla.wikimedia.org/30666) (owner: 10Ebe123) [19:17:22] 3MediaWiki / 3Page editing: Etherpad functionality within MediaWiki editing - 10https://bugzilla.wikimedia.org/28373#c4 (10Sumana Harihareswara) 5NEW>3RESO/FIX https://www.mediawiki.org/wiki/Extension:EtherEditor is an implementation, by Mark Holmquist, of Etherpad editing within a MediaWiki installation... [19:18:52] ^d: MediaWiki::getTitle() looks like it intentionally checks that no title is set, triggering the GlobalTitleFail log [19:18:53] cscott dearest: https://bugzilla.wikimedia.org/show_bug.cgi?id=28373 [19:18:54] 3MediaWiki extensions / 3CodeReview: from the author view, when I click on a path, show all commits in a path, not just by that author - 10https://bugzilla.wikimedia.org/36117#c2 (10Sumana Harihareswara) 5NEW>3RESO/WON Extension:CodeReview is unmaintained so we should probably mark all of its bugs WONTFI... [19:18:54] 3MediaWiki / 3Page editing: Etherpad functionality within MediaWiki editing - 10https://bugzilla.wikimedia.org/28373#c5 (10Mark Holmquist) 5RESO/FIX>3REOP Ehhh, but it's broken. A lot. I think cscott had a few ideas on the burner, so I'll reopen and ping him to add some details. [19:19:00] (03CR) 10BryanDavis: "LCStoreCDB restored in Ica007cf01978d58b1a9305916861e2ad085361d9 \o/" [vagrant] - 10https://gerrit.wikimedia.org/r/161140 (https://bugzilla.wikimedia.org/70959) (owner: 10Dduvall) [19:19:09] sumanah: CodeReview is not unmaintained... [19:19:14] ok [19:19:52] 3MediaWiki extensions / 3CodeReview: from the author view, when I click on a path, show all commits in a path, not just by that author - 10https://bugzilla.wikimedia.org/36117#c3 (10Kunal Mehta (Legoktm)) 5RESO/WON>3REOP (In reply to Sumana Harihareswara from comment #2) > Extension:CodeReview is unmaint... [19:19:53] Oh, who's maintaining it? [19:19:58] ashley :) [19:20:03] ah! [19:20:06] thanks ashley [19:20:10] sorry for missing that [19:21:08] 3MediaWiki / 3Special pages: Add largest files maintenance report - 10https://bugzilla.wikimedia.org/71183#c1 (10Umherirrender) Special:ListFiles already supports this ... https://commons.wikimedia.org/w/index.php?title=Special:ListFiles&sort=img_size&limit=500&asc=&desc=1 [19:22:17] the autocomplete box for bugzilla's cc field just reminded me that Aaron Swartz was one of our Bugzilla users :( [19:25:37] 3MediaWiki skins / 3Vector: Vector: h3 should not appear as heavier weight than h2 - 10https://bugzilla.wikimedia.org/69998#c3 (10Bartosz Dziewoński) 5UNCO>3NEW Jared, your system must be horribly misconfigured then. Can you provide a screenshot? For a more visible effect, try looking at a page in Russia... [19:25:39] 3Wikimedia / 3Git/Gerrit: Improve "There's a problem with this change, please improve" message - 10https://bugzilla.wikimedia.org/43783#c5 (10Sumana Harihareswara) CC'ing Quim so he can manage the messaging for the glorious Phabricator phuture. :) [19:26:38] (03Merged) 10jenkins-bot: doxygen: Fix trailing star in class member descriptions [core] - 10https://gerrit.wikimedia.org/r/157351 (owner: 10Krinkle) [19:26:41] (03Merged) 10jenkins-bot: doxygen: Fix leading space in class member descriptions [core] - 10https://gerrit.wikimedia.org/r/157352 (owner: 10Krinkle) [19:26:45] (03PS1) 10Manybubbles: Add more retry logic to reindexing [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/162362 [19:27:23] (03PS3) 10Umherirrender: Reduce duplication in some Special:ListGroupRights code [core] - 10https://gerrit.wikimedia.org/r/162023 (owner: 10Alex Monk) [19:27:30] (03CR) 10Umherirrender: [C: 032] Reduce duplication in some Special:ListGroupRights code [core] - 10https://gerrit.wikimedia.org/r/162023 (owner: 10Alex Monk) [19:28:23] 3Wikimedia / 3General/Unknown: ishmael shows blank graphs - 10https://bugzilla.wikimedia.org/64581#c2 (10Sumana Harihareswara) Whoever fixes this: please then update https://www.mediawiki.org/wiki/Performance_profiling_for_Wikimedia_code . Thanks. [19:28:23] 3MediaWiki skins / 3Vector: h4, h5, and h6 headers should not have the same styling - 10https://bugzilla.wikimedia.org/70004#c6 (10Isarra) 5UNCO>3PATC Jared, please don't change bug statuses when they already accurately reflect the status of the bug. (In reply to Jared Zimmerman (WMF) from comment #5) >... [19:29:07] 3MediaWiki skins / 3Vector: Vector: h3 should not appear as heavier weight than h2 - 10https://bugzilla.wikimedia.org/69998#c4 (10Jared Zimmerman (WMF)) Bartosz, can you provide a link to a page where the effect is prominent. [19:29:23] 3MediaWiki skins / 3Vector: Vector: h3 should not appear as heavier weight than h2 - 10https://bugzilla.wikimedia.org/69998#c5 (10Jon) Bartosz can you provide a screenshot? This could be platform specific. [19:29:47] (03PS1) 10EBernhardson: Set a maximum height to auto-expanding text fields [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162363 (https://bugzilla.wikimedia.org/58657) [19:30:28] 3Wikimedia / 3Git/Gerrit: Implement a way to bring GitHub pull requests into Phabricator - 10https://bugzilla.wikimedia.org/35497#c28 (10Sumana Harihareswara) a:5Yuvi Panda>3None If Yuvi does not have time to do this (and, presumably, to get GitHub->Phabricator syndication going), does anyone else? [19:30:59] (03CR) 10Arlolra: [C: 032] Don't crash if
    begins a figure caption. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/162299 (owner: 10Cscott) [19:32:13] sumanah, yeah :( looks like he only used it to report one bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=16007 [19:32:15] (03PS4) 10Krinkle: doxygen: Document problem with slashes and fix a few [core] - 10https://gerrit.wikimedia.org/r/157353 [19:32:41] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/157353/4 [19:32:59] Krenair: :( Well at least we responded to it before he died. [19:33:59] (03CR) 10Anomie: API: HTMLize and internationalize the help, add Special:ApiHelp (0314 comments) [core] - 10https://gerrit.wikimedia.org/r/160798 (https://bugzilla.wikimedia.org/30936) (owner: 10Anomie) [19:34:11] (03PS9) 10Anomie: API: HTMLize and internationalize the help, add Special:ApiHelp [core] - 10https://gerrit.wikimedia.org/r/160798 (https://bugzilla.wikimedia.org/30936) [19:34:43] (03CR) 10jenkins-bot: [V: 04-1] API: HTMLize and internationalize the help, add Special:ApiHelp [core] - 10https://gerrit.wikimedia.org/r/160798 (https://bugzilla.wikimedia.org/30936) (owner: 10Anomie) [19:34:46] (03Merged) 10jenkins-bot: Reduce duplication in some Special:ListGroupRights code [core] - 10https://gerrit.wikimedia.org/r/162023 (owner: 10Alex Monk) [19:34:48] (03Merged) 10jenkins-bot: Don't crash if
    begins a figure caption. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/162299 (owner: 10Cscott) [19:34:50] (03Merged) 10jenkins-bot: Don't crash if we encounter uncontained
  • . [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/162312 (owner: 10Cscott) [19:34:54] (03CR) 10Arlolra: [C: 032] Don't crash if section/chapter title contains a URL. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/162361 (owner: 10Cscott) [19:35:03] (03CR) 10Legoktm: [C: 031] "This really confused me when trying to add a tracking category to a custom content page in MassMessage, so thanks for doing this." [core] - 10https://gerrit.wikimedia.org/r/162241 (owner: 10Gergő Tisza) [19:35:52] (03Abandoned) 10Krinkle: [WIP] resourceloader: Regression test for bug 62068 [core] - 10https://gerrit.wikimedia.org/r/116143 (owner: 10Krinkle) [19:36:17] (03Merged) 10jenkins-bot: Don't crash if section/chapter title contains a URL. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/162361 (owner: 10Cscott) [19:37:03] (03PS2) 10Cscott: WIP: indic languages fixes [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/159192 [19:37:23] (03PS1) 10BryanDavis: Restore Composer hook providing MediaWiki version [core] - 10https://gerrit.wikimedia.org/r/162367 [19:37:54] (03PS5) 10Krinkle: Split mediawiki.toolbar from mediawiki.action.edit [core] - 10https://gerrit.wikimedia.org/r/161767 [19:38:06] (03PS2) 10Krinkle: EditPage: Prettify inline scripts for mw.toolbar in debug mode [core] - 10https://gerrit.wikimedia.org/r/161768 [19:38:37] 3MediaWiki skins / 3Vector: h4, h5, and h6 headers should not have the same styling - 10https://bugzilla.wikimedia.org/70004#c7 (10Jon) I think status is justified.. During the refresh we experimented with various font sizes and purposely made these all the same size. I wrote that code... Let's discuss this... [19:38:38] anomie, hey. you there? [19:38:52] (03PS4) 10EBernhardson: Move code to load User data from cache out of loadFromId [core] - 10https://gerrit.wikimedia.org/r/100371 (owner: 10Matthias Mullie) [19:38:54] (03CR) 10Catrope: [C: 032] doxygen: Document problem with slashes and fix a few [core] - 10https://gerrit.wikimedia.org/r/157353 (owner: 10Krinkle) [19:38:58] sumanah: let us know if you want someone else to take a look before you get a chance. (but then you have to add someone to the tool) [19:39:22] (bug 70199) [19:39:31] Thanks jeremyb [19:39:51] (03CR) 10EBernhardson: [C: 032] Move code to load User data from cache out of loadFromId [core] - 10https://gerrit.wikimedia.org/r/100371 (owner: 10Matthias Mullie) [19:40:03] (03CR) 10Anomie: "@Bartosz: That's 20 lines just for styles (API may need scripts and such in the future), and then it's duplicated code that has to be main" [core] - 10https://gerrit.wikimedia.org/r/160797 (owner: 10Anomie) [19:40:13] Krenair: Yes [19:40:26] anomie, okay. did we talk about categories + redirects? [19:40:26] (03PS3) 10Cscott: WIP: indic languages fixes [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/159192 [19:40:59] Krenair: Possibly. I'd need more context to have a better chance of remembering. [19:41:25] (03CR) 10BryanDavis: "Related to https://www.mediawiki.org/wiki/Requests_for_comment/Extension_management_with_Composer and the hard work that Jeroen has alread" [core] - 10https://gerrit.wikimedia.org/r/162367 (owner: 10BryanDavis) [19:42:17] (03PS6) 10Krinkle: API: Remove XML tag highlighting from non-XML formats [core] - 10https://gerrit.wikimedia.org/r/133739 (https://bugzilla.wikimedia.org/65403) (owner: 10PleaseStand) [19:42:48] (03CR) 10jenkins-bot: [V: 04-1] API: Remove XML tag highlighting from non-XML formats [core] - 10https://gerrit.wikimedia.org/r/133739 (https://bugzilla.wikimedia.org/65403) (owner: 10PleaseStand) [19:43:37] 3MediaWiki extensions / 3wikidiff2: Enhance line matching in diffs - 10https://bugzilla.wikimedia.org/13462#c14 (10Sumana Harihareswara) I'm removing myself from cc as I prepare to leave Wikimedia Foundation, but I will leave my 2 cents here: improving the line matching in diffs seems, to me, a cool project... [19:44:11] (03CR) 10Anomie: "The XML tag highlighting is being removed entirely in I04b1a3842abdf1fb360c54aa7164fc7cd2e50f4b." [core] - 10https://gerrit.wikimedia.org/r/133739 (https://bugzilla.wikimedia.org/65403) (owner: 10PleaseStand) [19:44:13] (03PS7) 10Krinkle: API: Remove XML tag highlighting from non-XML formats [core] - 10https://gerrit.wikimedia.org/r/133739 (https://bugzilla.wikimedia.org/65403) (owner: 10PleaseStand) [19:44:26] (03PS8) 10Krinkle: API: Remove XML tag highlighting from non-XML formats [core] - 10https://gerrit.wikimedia.org/r/133739 (https://bugzilla.wikimedia.org/65403) (owner: 10PleaseStand) [19:44:33] (03PS9) 10Krinkle: API: Remove XML tag highlighting from non-XML formats [core] - 10https://gerrit.wikimedia.org/r/133739 (https://bugzilla.wikimedia.org/65403) (owner: 10PleaseStand) [19:44:33] anomie, So you can do list=allcategories&acprefix=R to get a list of categories beginning with R. [19:44:37] 3MediaWiki extensions / 3InputBox: useful preload parameters for title/edit summary, etc. - 10https://bugzilla.wikimedia.org/14623 (10Sumana Harihareswara) [19:44:38] (03CR) 10Krinkle: [C: 032] API: Remove XML tag highlighting from non-XML formats [core] - 10https://gerrit.wikimedia.org/r/133739 (https://bugzilla.wikimedia.org/65403) (owner: 10PleaseStand) [19:44:51] anomie, but can I get other information like where it redirects etc.? [19:45:23] (without another query) [19:45:41] (03PS4) 10Cscott: WIP: need to hack polyglossia definitions for indic languages. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/159192 [19:45:43] (03PS1) 10Cscott: Add font and language information for indic languages. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/162377 [19:45:45] (03PS1) 10Cscott: Fix CJK definition in polyglossia. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/162378 [19:46:17] (03CR) 10Krinkle: "Hm.. not sure it makes sense to have both "fallback" and "bare"." [core] - 10https://gerrit.wikimedia.org/r/160797 (owner: 10Anomie) [19:46:21] &redirects and &prop=redirects do nothing for this query [19:46:35] (03Merged) 10jenkins-bot: doxygen: Document problem with slashes and fix a few [core] - 10https://gerrit.wikimedia.org/r/157353 (owner: 10Krinkle) [19:47:09] (03Merged) 10jenkins-bot: Move code to load User data from cache out of loadFromId [core] - 10https://gerrit.wikimedia.org/r/100371 (owner: 10Matthias Mullie) [19:47:39] Reedy, Ori: any idea what caused those errors? I can reach the servers from the hosts that I sampled. [19:47:39] Krenair: generator=allcategories&gacprefix=R&redirects=1 should do it, &redirects=1 will have effect for the generated titles. If bug 29115 were to get fixed, generator=allcategories&gacprefix=R&prop=info (&inprop=something, possibly). [19:47:59] AaronSchulz: which errors? I'm missing context [19:48:10] 3MediaWiki extensions / 3Wikilog: Wikilog articles with Tables of Content break the CSS of the Blog: pages - 10https://bugzilla.wikimedia.org/71190 (10apfister) 3UNCO p:3Unprio s:3normal a:3Juliano F. Ravasi Created attachment 16563 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16563&action=... [19:48:20] anomie, hm okay. [19:48:37] anomie, I'm wanting to avoid following the redirects like this does. Just get the information about them [19:48:51] 10.64.32.45 apache2[21373]: PHP Warning: Redis::connect() [redis.connect]: php_network_getaddresses: getaddrinfo failed: Name or service not known in /srv/mediawiki/php-1.24wmf21/includes/clientpool/RedisConnectionPool.php on line 206 [19:48:52] 3MediaWiki / 3Page editing: Etherpad functionality within MediaWiki editing - 10https://bugzilla.wikimedia.org/28373#c6 (10C. Scott Ananian) Try out the TogetherJS collaboration for the text field: https://en.wikipedia.org/wiki/User:Cscott/common.js [19:48:56] (03PS2) 10EBernhardson: Show error message at correct location [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162231 (owner: 10Matthias Mullie) [19:49:02] Or... Maybe following them to get hidden status of the target... urgh :( [19:49:08] ori: in apache log on fenari [19:49:19] * AaronSchulz wonders if it was sporadic [19:50:51] (03CR) 10EBernhardson: [C: 032] "simple and works as advertised" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162231 (owner: 10Matthias Mullie) [19:51:37] 3MediaWiki skins / 3Vector: Vector: h3 should not appear as heavier weight than h2 - 10https://bugzilla.wikimedia.org/69998#c6 (10Isarra) Created attachment 16564 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16564&action=edit Headers on enwp Screenshot of https://en.wikipedia.org/wiki/User:Isarra/... [19:51:46] (03CR) 10Krinkle: "Removing myself from review list. I don't know this extension, never heard of it, I don't maintain it." [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/151640 (owner: 10Paladox) [19:52:09] 3Wikimedia / 3Site requests: Add domains to $wgCopyUploadsDomains (tracking) - 10https://bugzilla.wikimedia.org/58224 (10Basvb) [19:52:10] 3Wikimedia / 3Site requests: add *nijmegen.nl to GWtoolset whitelist - 10https://bugzilla.wikimedia.org/71191 (10Basvb) 3NEW p:3Unprio s:3normal a:3None please add the following domain(s) to the wgCopyUploadsDomains whitelist: http://www.nijmegen.nl/opendata/archief/XXX or some shorter form (*nijmeg... [19:52:21] (03Merged) 10jenkins-bot: API: Remove XML tag highlighting from non-XML formats [core] - 10https://gerrit.wikimedia.org/r/133739 (https://bugzilla.wikimedia.org/65403) (owner: 10PleaseStand) [19:52:52] 3MediaWiki skins / 3Vector: Vector: h3 should not appear as heavier weight than h2 - 10https://bugzilla.wikimedia.org/69998#c7 (10Isarra) Created attachment 16565 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16565&action=edit Headers on enwp (windows) Same thing, different fonts. [19:53:24] 3Wikimedia / 3Site requests: Text layer of DjVu files doesn't appear in Page namespace due to higher memory consumption after upgrade to Ubuntu 12.04 - 10https://bugzilla.wikimedia.org/42466#c22 (10Sumana Harihareswara) What is the current status regarding memory consumption? Has it gone to a sustainable and... [19:53:24] (03PS1) 10Legoktm: Add Flow support [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/162379 (https://bugzilla.wikimedia.org/71082) [19:54:08] 3Wikimedia / 3General/Unknown: Set up dev.wikimedia.org portal - 10https://bugzilla.wikimedia.org/65074#c9 (10Sumana Harihareswara) Removing myself from cc on this as I prepare to leave Wikimedia Foundation. [19:54:08] 3Wikimedia / 3Git/Gerrit: Implement a way to bring GitHub pull requests into Phabricator - 10https://bugzilla.wikimedia.org/35497#c29 (10Quim Gil) If Phabricator is the focus of this report now, then we will have a duplicate after the migration: GitHub->Phabricator bridge for new contributors https://phabr... [19:54:23] 3MediaWiki skins / 3Vector: Vector: h3 should not appear as heavier weight than h2 - 10https://bugzilla.wikimedia.org/69998 (10Isarra) 5NEW>3PATC [19:54:37] (03CR) 10Cscott: [C: 032] Add font and language information for indic languages. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/162377 (owner: 10Cscott) [19:55:23] 3MediaWiki skins / 3Vector: h4, h5, and h6 headers should not have the same styling - 10https://bugzilla.wikimedia.org/70004#c8 (10Isarra) (In reply to Jon from comment #7) > I think status is justified.. During the refresh we experimented with > various font sizes and purposely made these all the same size.... [19:55:53] 3MediaWiki extensions / 3Extensions requests: Extension for storing non-default $wgGroupPermission's in MySQL table - 10https://bugzilla.wikimedia.org/7750#c7 (10Sumana Harihareswara) The config overhaul - you mean https://www.mediawiki.org/wiki/Requests_for_comment/Configuration_database_2 ? [19:56:07] 3Wikimedia / 3Site requests: Add a "OTRS member" userright to enwiki - 10https://bugzilla.wikimedia.org/70386 (10Jackmcbarn) 5PATC>3RESO/FIX [19:56:49] (03CR) 10Cscott: [C: 032] Fix CJK definition in polyglossia. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/162378 (owner: 10Cscott) [19:56:53] 3MediaWiki extensions / 3Drafts: Drafts are discarded without any user confirmation - 10https://bugzilla.wikimedia.org/19689 (10Sumana Harihareswara) [19:57:56] (03Merged) 10jenkins-bot: Show error message at correct location [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162231 (owner: 10Matthias Mullie) [19:57:59] (03Merged) 10jenkins-bot: Add font and language information for indic languages. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/162377 (owner: 10Cscott) [19:58:01] (03Merged) 10jenkins-bot: Fix CJK definition in polyglossia. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/162378 (owner: 10Cscott) [19:58:22] (03CR) 10Anomie: ""fallback" has a big ugly header to get people to install real skins, which is helpful for its purpose and is something we want to keep. B" [core] - 10https://gerrit.wikimedia.org/r/160797 (owner: 10Anomie) [19:58:58] (03CR) 10EBernhardson: [C: 04-1] "In a quick test it does not appear that document.body.innerHTML += ...; triggers script tags to be executed, It seems we may need to inste" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162232 (owner: 10Matthias Mullie) [20:00:33] anomie: i notice extensions/Scribunto/common/Hooks.php calls $outputPage->addInlineScript(). what do you think the best way is to expose the result of that to action=expandtemplates? [20:01:36] btw, the reason i make the OutputPage instead of using ParserOutput directly is so that the stuff in $wgParserOutputHooks gets ran [20:01:39] 3MediaWiki / 3Parser: Add "view-source://" to wgUrlProtocols - 10https://bugzilla.wikimedia.org/71166#c1 (10James Forrester) 5UNCO>3NEW p:5Unprio>3Low s:5trivia>3enhanc This is simple to do; no particular view either way on whether we should. [20:02:06] jackmcbarn: With a prop, like the 'modules' thing. [20:04:37] 3MediaWiki skins / 3Vector: Vector: Grey content text impairs legibility - 10https://bugzilla.wikimedia.org/66021#c15 (10Isarra) 5UNCO>3PATC (In reply to Jared Zimmerman (WMF) from comment #14) > In the simulated images I'm not seeing any legibility issues, in general we > strive to not recreate browser... [20:04:40] 3MediaWiki extensions / 3CirrusSearch: Search using insource and regex returns irregular and different set of articles each time - 10https://bugzilla.wikimedia.org/71098#c1 (10SpontaneousGrumbler) Today I'm getting "An error has occurred while searching: We could not complete your search due to a temporary p... [20:04:55] (03PS1) 10Cscott: Updating to latest masters [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/162446 [20:05:05] anomie: i mean how should i get it out of OutputPage? getScript() would be good if it weren't deprecated. should i use getScriptsForBottomQueue directly, or should i use one of its callers (HeadElement or something)? [20:05:38] 3MediaWiki skins / 3Vector: h4, h5, and h6 headers should not have the same styling - 10https://bugzilla.wikimedia.org/70004#c9 (10Jared Zimmerman (WMF)) Hi Issara, I changed the status, because I don't agree that there is consensus at this point, and as Jon pointed out this is as designed currently [20:06:22] 3MediaWiki skins / 3Vector: Vector: Grey content text impairs legibility - 10https://bugzilla.wikimedia.org/66021#c16 (10Isarra) (In reply to Isarra from comment #15) > That's a nice goal, but it's not taking things far enough. The standards are > made on assumptions that just do not necessarily hold in the... [20:06:52] (03CR) 10Cscott: [C: 032 V: 032] Updating to latest masters [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/162446 (owner: 10Cscott) [20:06:53] 3MediaWiki skins / 3Vector: Vector: h3 should not appear as heavier weight than h2 - 10https://bugzilla.wikimedia.org/69998#c8 (10Jared Zimmerman (WMF)) Looks like a weird platform specific bug then? [20:07:01] (03PS14) 10BryanDavis: Request a global account rename [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156488 (https://bugzilla.wikimedia.org/68886) [20:07:44] (03PS1) 10Cscott: Merge branch 'master' into wmf-deploy [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/162452 [20:07:56] (03PS1) 10Ejegg: Submodule bump for DonationInterface deploy [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/162453 [20:07:59] (03CR) 10BryanDavis: Request a global account rename (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156488 (https://bugzilla.wikimedia.org/68886) (owner: 10BryanDavis) [20:08:35] (03CR) 10Ejegg: [C: 032] Submodule bump for DonationInterface deploy [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/162453 (owner: 10Ejegg) [20:08:48] ebernhardson: (out of context) body.innerHTML += would serialise the existing dom recursively into an html string (expensive), append some html, then parse it again (invalidate all existing state, form values, event handlers, data, and node object references) as a new body. [20:09:17] (03CR) 10BryanDavis: "Patch set #14 was a manual rebase plus the fix for SpecialGlobalRenameRequest::suggestedUsername() pointed out by Kunal." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156488 (https://bugzilla.wikimedia.org/68886) (owner: 10BryanDavis) [20:09:30] (03PS7) 10BryanDavis: [WIP] Special page to manage global rename requests [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159331 (https://bugzilla.wikimedia.org/68924) [20:09:37] (03PS1) 10Cscott: Update `node-icu-bidi`. [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/162454 [20:09:41] ebernhardson: because there is no such thing as html in a browser. [20:09:42] jackmcbarn: I'd say to undeprecate getScript(), if you need access to only the scripts from OutputPage. I'm still not sure how sensible those OutputPage hooks are when there hasn't been any actual parse, though. [20:10:40] (03CR) 10Cscott: [C: 032 V: 032] Merge branch 'master' into wmf-deploy [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/162452 (owner: 10Cscott) [20:10:52] 3MediaWiki skins / 3Vector: Vector: Grey content text impairs legibility - 10https://bugzilla.wikimedia.org/66021#c17 (10Jared Zimmerman (WMF)) 5PATC>3RESO/WOR We define the default color, this is required, and we've defined a color which complies with the highest standards with a an agreed metric for co... [20:10:58] (03CR) 10Cscott: [C: 032 V: 032] Update `node-icu-bidi`. [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/162454 (owner: 10Cscott) [20:11:07] (03CR) 10EBernhardson: Fix [Object object] placeholder text in topic reply field (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162243 (owner: 10Matthias Mullie) [20:11:09] 3MediaWiki extensions / 3CirrusSearch: Search using insource and regex returns irregular and different set of articles each time - 10https://bugzilla.wikimedia.org/71098#c2 (10Nik Everett) 5UNCO>3ASSI a:3Nik Everett Yay? I've started work to speed it up by a pretty wide margin which should improve mat... [20:11:13] (03PS3) 10EBernhardson: Fix [Object object] placeholder text in topic reply field [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162243 (owner: 10Matthias Mullie) [20:13:44] (03CR) 10Krinkle: "(unless this ensures es5-shim is loaded, you should probably use $.map instead since Array#map is new in ES5)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162243 (owner: 10Matthias Mullie) [20:13:58] (03CR) 10Yaron Koren: "For #5: my overall goal for the UI, for all of my extensions, is to make it as consistent as possible with the existing MediaWiki look-and" [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [20:16:08] 3MediaWiki skins / 3Vector: h4, h5, and h6 headers should not have the same styling - 10https://bugzilla.wikimedia.org/70004#c10 (10Jared Zimmerman (WMF)) The rational as far as I remember was partly what I enumerated above, the Header levels are correctly being used as a way of structuring data, and that b... [20:16:09] 3MediaWiki / 3Patrolling: Add 'unwatchedpages' right for the 'patroller' user group on Hebrew Wikibooks - 10https://bugzilla.wikimedia.org/71193 (10Guycn2) 3UNCO p:3Unprio s:3normal a:3None Hello, Currently, on Hebrew Wikibooks, the right 'unwatchedpages' which allows users to access the page "Speci... [20:16:21] 3MediaWiki extensions / 3CirrusSearch: Search using insource and regex returns irregular and different set of articles each time - 10https://bugzilla.wikimedia.org/71098#c3 (10Nik Everett) The error you are seeing is that the queue for new regex queries is full and it won't let you add another. I have a err... [20:17:38] Krinkle: ouch, that sounds quite horrible. Any suggestions on how to rewrite the document.write() that comes out of captchas that prompted the patch? [20:18:37] 3MediaWiki skins / 3Vector: Vector: insufficent text contrast impairs legibility - 10https://bugzilla.wikimedia.org/66021 (10Jared Zimmerman (WMF)) [20:18:45] ebernhardson: Well, it's not really a lack in the browser. It's a conceptual mismatch about how a DOM works vs. a serialisation. It's like trying to append JSON to a JSON string, you can't. You add properties to the object you already have. the innerHTML is basically just a misnamed .toHTML() function. [20:18:50] (03CR) 10Legoktm: [C: 032] Request a global account rename [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156488 (https://bugzilla.wikimedia.org/68886) (owner: 10BryanDavis) [20:19:09] 3Wikimedia / 3Site requests: Add domains to $wgCopyUploadsDomains (tracking) - 10https://bugzilla.wikimedia.org/58224 (10jeblad) [20:19:11] 3Wikimedia / 3Site requests: Add new domains to the wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/71195 (10jeblad) 3NEW p:3Unprio s:3normal a:3None Please add the following domain(s) to the wgCopyUploadsDomains whitelist: digitaltmuseum.no www.byarkivet.oslo.kommune.no www.nb.no... [20:19:11] (03PS1) 10Cscott: Clarify that developers should follow the first set of instructions. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/162455 [20:19:28] it being a magic property that triggers that synchronously only hides it. The browser doesn't and shouldn't have any concept of HTML associated with an element. [20:19:31] (03Merged) 10jenkins-bot: Request a global account rename [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156488 (https://bugzilla.wikimedia.org/68886) (owner: 10BryanDavis) [20:19:40] Krinkle: so your suggesting to write a helper function that receives the string that would have gone to document.write, and something like $( document ).append( $(contentThatWouldHaveBeenDocumentWrite) ) ? [20:19:46] (03CR) 10Anomie: API: Remove XML tag highlighting from non-XML formats (031 comment) [core] - 10https://gerrit.wikimedia.org/r/133739 (https://bugzilla.wikimedia.org/65403) (owner: 10PleaseStand) [20:20:02] (03CR) 10Subramanya Sastry: [C: 032] Clarify that developers should follow the first set of instructions. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/162455 (owner: 10Cscott) [20:20:07] ebernhardson: parse it in isolation and append the new nodes to the existing document, yes. [20:20:13] (03Merged) 10jenkins-bot: Clarify that developers should follow the first set of instructions. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/162455 (owner: 10Cscott) [20:20:15] $nodes = $.parseHTML( ... ); [20:20:19] $body.append( $nodes ); [20:20:37] 3MediaWiki skins / 3Vector: Vector: h3 should not appear as heavier weight than h2 - 10https://bugzilla.wikimedia.org/69998#c9 (10Isarra) (In reply to Jared Zimmerman (WMF) from comment #8) > Looks like a weird platform specific bug then? If 'everything that isn't your personal computer' is 'platform specif... [20:21:05] Krinkle: ok i think we can handle that. [20:21:33] (03CR) 10Hoo man: "Well, I can add a comment about this... in a nutshell I don't think it's this code's responsibility to know which hosts it can talk to or " [core] - 10https://gerrit.wikimedia.org/r/162229 (owner: 10Hoo man) [20:21:36] as opposed to: var bodyhtml = body.toHTML(); bodyhtml += extrahtml; nodes = $.parseHTML( bodyhtml ); document.body.removeChild( ... ); document.body.appendChild( nodes.. ) [20:21:42] which is what body.innerhTML += does [20:22:35] Krinkle: ^ would that be ok with you? We need that functionality and I don't want to have it in wikibase... [20:22:46] because gadgets etc. would make use of it [20:23:13] Krinkle: as long as i have you here :) This particular code also has: Object.prototype.toString.call( result ) === '[object Function]', there is probably a better isFunction() type method? [20:23:22] 3MediaWiki skins / 3Vector: Vector: h3 should not appear as heavier weight than h2 - 10https://bugzilla.wikimedia.org/69998#c10 (10Jon) Isarra I personally see nothing wrong in that screenshot. There is nothing that says an h3 need to be a stronger font weight than h2. I can tell the h2 is more important t... [20:23:40] ebernhardson: link to code? [20:23:59] hoo: Well, a comment doesn't justify adding a public method that doesn't work in most cases. [20:24:00] Krinkle: https://gerrit.wikimedia.org/r/#/c/162243/2/modules/new/flow-handlebars.js line 233 (same patch as the Array#map) [20:25:07] ebernhardson: There is a typeof operator that detects callable objects as 'function'. Though there are minor edge cases with native host functions (not regular javascript functions) not being detected by typeof in old browsers, and as such toString-ing the object is often done as a work-around. [20:25:09] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (4ea8e2cba9) [core] - 10https://gerrit.wikimedia.org/r/162456 [20:25:16] its not being changed here, but while touching up the other part that just looks wrong but i can't place my finger on why. [20:25:21] 3MediaWiki skins / 3Vector: Vector: h3 should not appear as heavier weight than h2 - 10https://bugzilla.wikimedia.org/69998#c11 (10Jared Zimmerman (WMF)) Created attachment 16566 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16566&action=edit Headings test Mac/chrome I've added the example as rende... [20:25:31] ebernhardson: but 1) only do that if you know why you'd do that. Because if you expect only regular functions as callbacks, typeof x === 'function' works fine. [20:25:36] (03Abandoned) 10Jforrester: Update OOjs UI to v0.1.0-pre (bab8befc94) [core] - 10https://gerrit.wikimedia.org/r/162137 (owner: 10Jforrester) [20:25:36] 3MediaWiki skins / 3Vector: Vector: insufficent text contrast impairs legibility - 10https://bugzilla.wikimedia.org/66021#c18 (10Isarra) 5RESO/WOR>3PATC Please stop changing the status. [20:25:44] Krinkle: Do you have any way forward here? Or shall I consider this a -2? If so, this will probably stay in Wikibase, which is awry [20:25:45] 2) if you want the toString, use $.isFunction for readability [20:27:05] Krinkle: ok excellent, thanks [20:27:15] (03CR) 10Spage: "Probably won't work on Topic: pages, I'm OK with assuming admins won't do that." (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/162379 (https://bugzilla.wikimedia.org/71082) (owner: 10Legoktm) [20:27:26] hoo: Correct me if I'm wrong but this is a method that is only for communicating with 'local' (mutually trusted) domains and only for newer browsers. You can't use it striaght-up in regular code that works everywhere where mediawiki works, so 1) any call to this *must* be guarded by a feature test and fallback somehow, 2) you must only call this for trusted domains, not for e.g. communicating with fore [20:27:26] ign APIs for media information or wiki data information from a third-party wiki. [20:28:24] Yes, that's fully true [20:29:07] (03PS6) 10Cmcmahon: QA: Refactoring and making the nojs test dtrt [extensions/Echo] - 10https://gerrit.wikimedia.org/r/162144 [20:29:15] So as much as I'd like to have it in core, it doesn't make sense to put in a module that is otherwise aimed at wider browser support and for any mediawiki API. No documentation can explain why mw.Api.newFor wouldn't work in a supported browser to a JSON-P wiki. [20:29:30] So it should probaly be maintained in a code base that is armed with those conditions already. [20:29:33] (03PS4) 10EBernhardson: Fix [Object object] placeholder text in topic reply field [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162243 (owner: 10Matthias Mullie) [20:30:10] (03CR) 10EBernhardson: "PS4: share normalization code between l10n and l10nParse methods. Additionally switch to $.map to address browser compatibility." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162243 (owner: 10Matthias Mullie) [20:30:30] Krinkle: Mh... right now this is at wikibase.api.getLocationAgnosticMwApi [20:30:36] which is IMO totally awry [20:30:50] Gadgets will use that [20:31:05] and they will probably use it out of the Wikibase context (eg. for commons) [20:31:17] Existing methods exposed unconditionally causing gadgets to write bad code is not a justification [20:31:29] (03CR) 10Brion VIBBER: initial commit (031 comment) [extensions/DebugMode] - 10https://gerrit.wikimedia.org/r/161362 (owner: 10tosfos) [20:31:31] (03CR) 10Dduvall: "Left some minor comments about Ruby style that are just suggestions seeing as it wasn't your implementation (just moved)." (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/162144 (owner: 10Cmcmahon) [20:31:32] In fact, it would make it worse, obviously. [20:31:42] we actually implemented that partly for gadgets [20:32:02] they can't be bothered to figure out cors and stuff on their own just to contact Wikidata [20:32:59] hoo: Why does the API require logged-in? [20:33:11] don't they just read info? [20:33:32] Krinkle: In our extension, we do writes... and I know of at least one more gadget taht writes [20:33:39] For authenticated actions you probably want to very much discourage user scripts from doing write actions. (I guess they'd lack an edit token, though that could be fetched) [20:33:40] for the others I haven't looked into enough [20:33:52] But do you want users to be doing write actions from the local wiki context? [20:34:02] Or send them to a frame hosted by wikidata.org and exec locally? [20:34:20] We do write actions from remote wikis for 1 1/2 years now [20:34:42] Either way, you know this would encourage even more broken code to be written taht doesn't work properly for many domains and many browsers, so no. I think that's your own inner voice not wanting me to say yes :P [20:34:54] (03CR) 10EBernhardson: "More context from talking to krinkle:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162232 (owner: 10Matthias Mullie) [20:34:58] Yeah... maybe. [20:35:12] I had another possible design in mind tomake it easy for gadgets while staying sane [20:35:23] not sure Wikidata folks will like it :P [20:36:00] (03PS7) 10Cmcmahon: QA: Refactoring and making the nojs test dtrt [extensions/Echo] - 10https://gerrit.wikimedia.org/r/162144 [20:36:13] Just going to create wb.getRepoApi (or something) method which just fiddles out a Api module for Wikidata (or whatever the rpeo is) [20:36:48] black magic global state stuff, but whatever [20:36:49] prtksxna, Re: your navpop css: I'd suggest these tweaks (links all blue, slightly tweaked font-sizes): https://en.wikipedia.org/w/index.php?title=User%3AQuiddity_%28WMF%29%2Fvector.css&diff=626809768&oldid=626800685 [20:37:11] (03PS2) 10EBernhardson: Prevent ConfirmEdit captcha from attempting to leave the page in FF [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162232 (owner: 10Matthias Mullie) [20:38:27] (03Abandoned) 10Hoo man: Introduce: mw.Api.newFor [core] - 10https://gerrit.wikimedia.org/r/162229 (owner: 10Hoo man) [20:38:50] quiddity: Cool [20:39:08] quiddity: Do you think we can get these merged into the gadget? Whom should we speak to? [20:42:04] (03PS2) 10Legoktm: Add Flow support [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/162379 (https://bugzilla.wikimedia.org/71082) [20:43:02] (03CR) 10Legoktm: Add Flow support (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/162379 (https://bugzilla.wikimedia.org/71082) (owner: 10Legoktm) [20:43:27] (03CR) 10Dduvall: [C: 032] "Looks good and all green!" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/162144 (owner: 10Cmcmahon) [20:43:44] (03CR) 10Prtksxna: settings: Add help dialog (036 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/157037 (owner: 10Prtksxna) [20:44:05] (03PS6) 10Prtksxna: settings: Add help dialog [extensions/Popups] - 10https://gerrit.wikimedia.org/r/157037 [20:44:57] (03PS2) 10tosfos: initial commit [extensions/DebugMode] - 10https://gerrit.wikimedia.org/r/161362 [20:45:23] (03CR) 10Prtksxna: "Right, hm, I'll remap the close button to reload the page as well then (when on the help dialog)." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/157037 (owner: 10Prtksxna) [20:45:59] (03CR) 10tosfos: "Thank you!" [extensions/DebugMode] - 10https://gerrit.wikimedia.org/r/161362 (owner: 10tosfos) [20:46:18] (03CR) 10Krinkle: [C: 032] mediawiki.api: Support assert parameter in getToken and postWithToken [core] - 10https://gerrit.wikimedia.org/r/156093 (owner: 10Nikerabbit) [20:47:24] (03PS11) 10BryanDavis: Allow login with pre-rename username and password [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/147020 (https://bugzilla.wikimedia.org/67995) [20:47:54] (03CR) 10BryanDavis: "Patch set #11 was a manual rebase." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/147020 (https://bugzilla.wikimedia.org/67995) (owner: 10BryanDavis) [20:48:08] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (4ea8e2cba9) [core] - 10https://gerrit.wikimedia.org/r/162456 (owner: 10Jforrester) [20:48:31] (03PS3) 10EBernhardson: Placeholder should only contain text of exactly the topic being replied to [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162276 (owner: 10Matthias Mullie) [20:48:49] (03CR) 10EBernhardson: [C: 032] "simple, works as advertised" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162276 (owner: 10Matthias Mullie) [20:48:58] (03PS3) 10EBernhardson: First trim content, then truncate [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162277 (owner: 10Matthias Mullie) [20:49:02] (03CR) 10EBernhardson: "LGTM" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162277 (owner: 10Matthias Mullie) [20:49:09] (03CR) 10EBernhardson: [C: 032] "LGTM" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162277 (owner: 10Matthias Mullie) [20:50:20] (03PS3) 10Jackmcbarn: Expose scripts to action=expandtemplates [core] - 10https://gerrit.wikimedia.org/r/162123 [20:50:29] (03PS5) 10BryanDavis: Check for renamed user on login [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156947 (https://bugzilla.wikimedia.org/67995) (owner: 10CSteipp) [20:50:53] (03CR) 10BryanDavis: "Patch set #5 was a manual rebase." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156947 (https://bugzilla.wikimedia.org/67995) (owner: 10CSteipp) [20:51:03] (03PS2) 10EBernhardson: Remove lower-level posts' right padding [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162280 (owner: 10Matthias Mullie) [20:52:56] (03Merged) 10jenkins-bot: mediawiki.api: Support assert parameter in getToken and postWithToken [core] - 10https://gerrit.wikimedia.org/r/156093 (owner: 10Nikerabbit) [20:53:17] (03PS3) 10tosfos: initial commit [extensions/DebugMode] - 10https://gerrit.wikimedia.org/r/161362 [20:53:23] 3MediaWiki extensions / 3WikidataRepo: add quality article badge - 10https://bugzilla.wikimedia.org/70268 (10Bene*) [20:54:21] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (4ea8e2cba9) [core] - 10https://gerrit.wikimedia.org/r/162456 (owner: 10Jforrester) [20:55:17] (03PS1) 10Addshore: Add tests for Job::toString [core] - 10https://gerrit.wikimedia.org/r/162460 [20:55:22] 3Wikimedia / 3General/Unknown: Allow uploading of Blender or other 3D files to Wikimedia Commons - 10https://bugzilla.wikimedia.org/1790#c43 (10Marco) Having a quick look at the comments suggests that this should be considered a tracking bug covering the 3D support in general. Also, it is probably more clea... [20:55:46] addshore: https://gerrit.wikimedia.org/r/#/c/162460/1/includes/content/JsonContentHandler.php,cm ??? [20:56:08] bah wtf, that definatly wasnt in my commit... [20:56:10] 3MediaWiki / 3Database: Image and oldimage tables lack primary keys - 10https://bugzilla.wikimedia.org/71198 (10Nathan Larson) 3NEW p:3Unprio s:3normal a:3None Image and oldimage tables lack primary keys. Therefore, img_id and oi_id should be added. There is a comment in LocalFile::recordUpload2() no... [20:57:44] AndyRussG: Does it make more sense to use getPageViewLanguage on $wgTitle? [20:57:45] (03CR) 10jenkins-bot: [V: 04-1] Add tests for Job::toString [core] - 10https://gerrit.wikimedia.org/r/162460 (owner: 10Addshore) [20:57:51] (03PS2) 10Addshore: Add tests for Job::toString [core] - 10https://gerrit.wikimedia.org/r/162460 [20:57:58] AndyRussG: https://doc.wikimedia.org/mediawiki-core/master/php/html/classTitle.html#a49ad0dc9aed65ed9d12f37facc8ed04e [20:58:28] (03CR) 10EBernhardson: "idea is great, but this causes the highlights when using a url like:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162280 (owner: 10Matthias Mullie) [20:58:31] prtksxna: using $wgTitle is always wrong [20:58:40] legoktm: https://gerrit.wikimedia.org/r/#/c/142481/2/Popups.hooks.php [20:59:01] legoktm: Why is that? [20:59:40] you want to use the MakeGlobalVariablesScript hook instead. [21:00:06] legoktm: im still a bit confused as to how jobs with objects in their params are handeled.. [21:00:24] 3MediaWiki / 3Database: Some tables lack unique or primary keys, may allow confusing duplicate data - 10https://bugzilla.wikimedia.org/15441 (10Nathan Larson) [21:00:24] prtksxna: I'll comment. [21:00:27] 3MediaWiki / 3Database: Image and oldimage tables lack auto-incrementing primary keys - 10https://bugzilla.wikimedia.org/71198#c1 (10Nathan Larson) p:5Unprio>3Lowest s:5normal>3enhanc a:3Nathan Larson Oh, I guess image has a primary key (img_name), but it should be an auto-incrementing primary key. [21:00:39] ebernhardson: Looking around and found https://gerrit.wikimedia.org/r/#/c/162277/3 - fyi, String#trim is also new in ES5. Use $.trim unless Flow is only loaded in es5-supported browsers and guarded by feature test [21:01:02] (03PS1) 10BryanDavis: Remove duplicate qqq.json for logentry-gblrename-rename [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/162462 [21:01:15] legoktm: easy one ^ [21:01:52] (03CR) 10Legoktm: [C: 04-1] Add 'lang' and 'dir' attributes to '.mwe-popups-extract' (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/142481 (https://bugzilla.wikimedia.org/66114) (owner: 10Prtksxna) [21:01:59] (03CR) 10Legoktm: [C: 032] Remove duplicate qqq.json for logentry-gblrename-rename [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/162462 (owner: 10BryanDavis) [21:02:36] (03Merged) 10jenkins-bot: Remove duplicate qqq.json for logentry-gblrename-rename [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/162462 (owner: 10BryanDavis) [21:03:23] 3MediaWiki skins / 3Vector: h4, h5, and h6 headers should not have the same styling - 10https://bugzilla.wikimedia.org/70004#c11 (10Isarra) So, to clarify, the reasons for making h4-6 the same were the following: * Most projects have no use for h4-6 in the first place * Having different styles for h4-h6 mig... [21:03:45] (03PS12) 10BryanDavis: Allow login with pre-rename username and password [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/147020 (https://bugzilla.wikimedia.org/67995) [21:03:57] (03PS6) 10BryanDavis: Check for renamed user on login [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156947 (https://bugzilla.wikimedia.org/67995) (owner: 10CSteipp) [21:06:19] (03PS7) 10BryanDavis: Check for renamed user on login [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156947 (https://bugzilla.wikimedia.org/67995) (owner: 10CSteipp) [21:06:25] (03PS12) 10Krinkle: Message: Correct output of wfMessage( 'non-existent-msg' )->text() [core] - 10https://gerrit.wikimedia.org/r/137458 (https://bugzilla.wikimedia.org/66199) (owner: 10EBernhardson) [21:07:18] Krinkle: doh, its so easy to forget all these different es5 functions. Thanks i'll update it [21:08:29] (03PS6) 10BryanDavis: [WIP] Interstitial notification page for renamed users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/148420 (https://bugzilla.wikimedia.org/67995) [21:08:57] (03CR) 10Krinkle: [C: 032] Message: Correct output of wfMessage( 'non-existent-msg' )->text() [core] - 10https://gerrit.wikimedia.org/r/137458 (https://bugzilla.wikimedia.org/66199) (owner: 10EBernhardson) [21:08:59] (03CR) 10Parent5446: "Just curious, what is the cause of this problem?" [core] - 10https://gerrit.wikimedia.org/r/157353 (owner: 10Krinkle) [21:09:02] Krinkle: http://gadgets-gadgets.wmflabs.org/wiki/Main_Page looks like it's working now. [21:10:47] (03PS8) 10BryanDavis: [WIP] Special page to manage global rename requests [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159331 (https://bugzilla.wikimedia.org/68924) [21:13:31] prtksxna, re: css - At a new sandbox page: Add the code here https://en.wikipedia.org/wiki/MediaWiki:Gadget-navpop.css to that sandbox. Then add in your suggested changes. Take the diff link from there, and 2 or 3 screenshots of the final result, and post them in a new section at https://en.wikipedia.org/wiki/MediaWiki_talk:Gadget-popups.js asking for technical feedback. Once the devs are all in agreement, it'll need a wider discussi [21:13:31] on (or announcement). [21:14:06] (03PS2) 10EBernhardson: Bump Flow submodule in 1.24wmf22 [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162319 [21:14:27] legoktm, that clearly needs some scripts/functions called Inspector, Penny, Claw, Brain, and Quimby. [21:14:31] (03CR) 10EBernhardson: [C: 032] Bump Flow submodule in 1.24wmf22 [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162319 (owner: 10EBernhardson) [21:14:37] 3MediaWiki extensions / 3Scribunto: Script error "attempt to concatenate a nil value" when running in HHVM - 10https://bugzilla.wikimedia.org/71174#c4 (10Jackmcbarn) p:5Unprio>3High This problem appears quite widespread. Setting High importance. [21:14:49] (03PS1) 10Cmcmahon: QA: add modern assertions to flyout tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/162467 [21:15:04] (03Merged) 10jenkins-bot: Message: Correct output of wfMessage( 'non-existent-msg' )->text() [core] - 10https://gerrit.wikimedia.org/r/137458 (https://bugzilla.wikimedia.org/66199) (owner: 10EBernhardson) [21:15:06] (03CR) 10Parent5446: [C: 04-1] "composer update" [core] - 10https://gerrit.wikimedia.org/r/162367 (owner: 10BryanDavis) [21:15:20] (03CR) 10Legoktm: [C: 032] Check for renamed user on login [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156947 (https://bugzilla.wikimedia.org/67995) (owner: 10CSteipp) [21:15:24] 3MediaWiki skins / 3Vector: Vector: h3 should not appear as heavier weight than h2 - 10https://bugzilla.wikimedia.org/69998#c13 (10Bartosz Dziewoński) (In reply to Jared Zimmerman (WMF) from comment #4) > Bartosz, can you provide a link to a page where the effect is prominent. Try these: https://en.wikiped... [21:16:25] parent5446: What does "composer update" mean? [21:16:58] bd808: Sorry. :P You gotta run "composer update", otherwise it gives you a warning about an outdated lock file when you try to install [21:17:01] (03CR) 10EBernhardson: [C: 032] (bug 71109) Fix broken Special:EditWatchlist [extensions/Flow] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/162168 (https://bugzilla.wikimedia.org/71109) (owner: 10EBernhardson) [21:17:08] ah ha [21:17:34] wait... we have a checked in lock file? [21:18:29] we don't? [21:18:30] (03Merged) 10jenkins-bot: Bump Flow submodule in 1.24wmf22 [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162319 (owner: 10EBernhardson) [21:18:32] (03Merged) 10jenkins-bot: (bug 71109) Fix broken Special:EditWatchlist [extensions/Flow] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/162168 (https://bugzilla.wikimedia.org/71109) (owner: 10EBernhardson) [21:18:57] (03CR) 10Legoktm: [C: 04-1] "Hmm, this hook should probably check $wgCentralAuthCheckSULMigration." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156947 (https://bugzilla.wikimedia.org/67995) (owner: 10CSteipp) [21:19:04] We don't but MediaWiki-Vagrant probably needs to be smarter about changes to composer.json [21:19:07] :/ both composer.json and composer.lock are in .gitignore, yet we have composer.json checked in and composer.lock not checked in [21:19:17] yeah madness [21:19:19] composer.lock is *supposed* to be checked in [21:19:25] No, it's not [21:19:41] Yeah it is: https://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file [21:19:44] (03PS1) 10EBernhardson: Bump Flow submodule in 1.24wmf21 [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/162470 [21:19:59] (03CR) 10EBernhardson: [C: 032] Bump Flow submodule in 1.24wmf21 [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/162470 (owner: 10EBernhardson) [21:20:03] parent5446: On a tracking branch, yes [21:20:08] in mw-core, no [21:20:25] Hmm I guess you've got a point [21:20:36] "After installing the dependencies. ..." which we don't do into core [21:20:39] (03CR) 10Parent5446: [C: 032] Restore Composer hook providing MediaWiki version [core] - 10https://gerrit.wikimedia.org/r/162367 (owner: 10BryanDavis) [21:20:57] But this is all still a bit of a mess [21:21:10] Yeah, it'll sort itself out over time I guess [21:21:32] I'm hoping to get allocated time to work on it more starting next month [21:21:57] Hi prtksxna, sorry I just saw your ping [21:22:26] I'm not sure which it makes most sense to use [21:22:33] AndyRussG: legoktm left a comment on that patch too. I guess its best to add there [21:22:59] OK, I'll check it out :) [21:23:07] (03CR) 10Legoktm: [C: 031] "Super minor thing. Yay tests!" (033 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/147020 (https://bugzilla.wikimedia.org/67995) (owner: 10BryanDavis) [21:24:17] (03Merged) 10jenkins-bot: Bump Flow submodule in 1.24wmf21 [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/162470 (owner: 10EBernhardson) [21:24:33] (03PS2) 10Dduvall: Provision MMV browser-test dependencies [vagrant] - 10https://gerrit.wikimedia.org/r/160786 [21:24:54] prtksxna: OK, legoktm's suggestions sound very sound :) [21:25:32] (03PS9) 10BryanDavis: [WIP] Special page to manage global rename requests [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159331 (https://bugzilla.wikimedia.org/68924) [21:25:34] legoktm: What color should the bike shed be? :) New log bucket with a better name or the normal CentralAuth bucket? [21:26:03] I'd just dump it in CentralAuth unless there's a good reason for us to have it separate? [21:26:32] Loads of detailed caching gotchas... [21:26:56] Normal is fine with me I think. When I wrote that I was thinking having a new bucket would be easier to watch, but logstash should make that a moot point. [21:27:22] :DD [21:27:37] (03Merged) 10jenkins-bot: Restore Composer hook providing MediaWiki version [core] - 10https://gerrit.wikimedia.org/r/162367 (owner: 10BryanDavis) [21:27:42] bd808: uh, what was that chmod command to fix /srv/vagrant permissions? [21:27:52] g+w ? [21:28:12] marxarelli: sudo chmod -R o+rX /srv/vagrant [21:28:23] 3Wikimedia / 3Bugzilla: Create additional components for PDF Rendering - 10https://bugzilla.wikimedia.org/69603#c9 (10C. Scott Ananian) Yes, the architecture consists of a WMF extension (Collection) which talks to a service (mw-ocg-service) which schedules jobs and communicates with the extension. Jobs star... [21:28:47] (03PS4) 10Prtksxna: Special:BookSources: Use appropriate mediawiki.ui classes and update strings [core] - 10https://gerrit.wikimedia.org/r/162145 (https://bugzilla.wikimedia.org/71145) [21:28:48] bd808: cool. i'm testing https://gerrit.wikimedia.org/r/#/c/160908/ on labs [21:28:56] legoktm: Speaking of logstash -- "Disabling contenthandler features because $wgContentHandlerUseDB = false" 1.8M times in the last hour [21:29:11] (03CR) 10Aaron Schulz: [C: 032] Fixed --maxtime handling by JobRunner [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/161621 (owner: 10Aaron Schulz) [21:29:22] (03CR) 10Prtksxna: Special:BookSources: Use appropriate mediawiki.ui classes and update strings (031 comment) [core] - 10https://gerrit.wikimedia.org/r/162145 (https://bugzilla.wikimedia.org/71145) (owner: 10Prtksxna) [21:29:31] bd808: uhhhh, I thought I backported the patch to disable that. [21:29:46] I thought you did too? DId it not get swatted? [21:30:14] ugh no, I just forgot to add it to the list. [21:30:15] (03PS4) 10Krinkle: ResourceLoaderWikiModule: Only check content format instead of namespace [core] - 10https://gerrit.wikimedia.org/r/160392 (https://bugzilla.wikimedia.org/70835) (owner: 10Legoktm) [21:30:20] (03CR) 10Dduvall: [C: 04-1] "This looks good barring one minor spacing issue." (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/160908 (https://bugzilla.wikimedia.org/70421) (owner: 10BryanDavis) [21:30:25] I'll put it on todays [21:30:31] cool beans [21:32:09] (03CR) 10Krinkle: [C: 032] ResourceLoaderWikiModule: Only check content format instead of namespace [core] - 10https://gerrit.wikimedia.org/r/160392 (https://bugzilla.wikimedia.org/70835) (owner: 10Legoktm) [21:32:12] (03CR) 10Dduvall: "I should add that it not only looks good but was verified against both MWV and labs. :)" [vagrant] - 10https://gerrit.wikimedia.org/r/160908 (https://bugzilla.wikimedia.org/70421) (owner: 10BryanDavis) [21:32:53] (03Merged) 10jenkins-bot: Fixed --maxtime handling by JobRunner [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/161621 (owner: 10Aaron Schulz) [21:33:39] (03CR) 10BryanDavis: "Tyler's comment about "composer update" was made more clear on irc. He noticed that he got a complaint about an out of date composer.lock " [core] - 10https://gerrit.wikimedia.org/r/162367 (owner: 10BryanDavis) [21:35:45] (03Abandoned) 10Alex Monk: Re-add TitleIsCssOrJsPage hook, still necessary for a few things [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160253 (owner: 10Legoktm) [21:36:06] (03CR) 10Aaron Schulz: [C: 032] Add tests for Job::toString [core] - 10https://gerrit.wikimedia.org/r/162460 (owner: 10Addshore) [21:37:49] (03PS2) 10Dduvall: Disable puppet service [vagrant] - 10https://gerrit.wikimedia.org/r/160908 (https://bugzilla.wikimedia.org/70421) (owner: 10BryanDavis) [21:37:55] 3MediaWiki skins / 3Vector: Vector: h3 should not appear as heavier weight than h2 - 10https://bugzilla.wikimedia.org/69998#c12 (10Isarra) (In reply to Jon from comment #10) > Isarra I personally see nothing wrong in that screenshot. > > There is nothing that says an h3 need to be a stronger font weight tha... [21:38:02] (03CR) 10Dduvall: [C: 032] Disable puppet service [vagrant] - 10https://gerrit.wikimedia.org/r/160908 (https://bugzilla.wikimedia.org/70421) (owner: 10BryanDavis) [21:38:07] (03Merged) 10jenkins-bot: Disable puppet service [vagrant] - 10https://gerrit.wikimedia.org/r/160908 (https://bugzilla.wikimedia.org/70421) (owner: 10BryanDavis) [21:38:14] (03Merged) 10jenkins-bot: ResourceLoaderWikiModule: Only check content format instead of namespace [core] - 10https://gerrit.wikimedia.org/r/160392 (https://bugzilla.wikimedia.org/70835) (owner: 10Legoktm) [21:38:40] (03CR) 10Greg Grossmeier: [C: 031] HHVM BetaFeature: Add screenshot; improve text [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/162008 (https://bugzilla.wikimedia.org/71048) (owner: 10Jforrester) [21:38:55] (03PS9) 10Legoktm: Add some basic tests for LocalGadgetRepo & ForeignDBGadgetRepo [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160432 [21:38:57] (03PS3) 10Legoktm: Get rid of the GadgetPageList class [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160199 [21:40:38] 3Wikimedia / 3General/Unknown: Allow uploading of Blender or other 3D files to Wikimedia Commons - 10https://bugzilla.wikimedia.org/1790#c44 (10Bawolff (Brian Wolff)) Well in theory they should be separate, in practise i doubt it would do much good unless someone was specificly comitted to implementing some... [21:42:31] (03Merged) 10jenkins-bot: Add tests for Job::toString [core] - 10https://gerrit.wikimedia.org/r/162460 (owner: 10Addshore) [21:43:38] 3MediaWiki skins / 3Vector: Vector: insufficent text contrast impairs legibility - 10https://bugzilla.wikimedia.org/66021#c19 (10Andre Klapper) 5PATC>3RESO/WOR I think "At this time I do not want to make an additional change to this value since insufficient evidence that a higher contrast value provides... [21:45:52] 3MediaWiki skins / 3Vector: Vector: h3 should not appear as heavier weight than h2 - 10https://bugzilla.wikimedia.org/69998#c14 (10Jared Zimmerman (WMF)) Bartosz, I think from this we can surmise the problem primarily exists in windows, as I'm not seeing anything I would refer to as confusing, or awful on a... [21:46:07] (03PS13) 10BryanDavis: Allow login with pre-rename username and password [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/147020 (https://bugzilla.wikimedia.org/67995) [21:46:36] (03CR) 10BryanDavis: Allow login with pre-rename username and password (033 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/147020 (https://bugzilla.wikimedia.org/67995) (owner: 10BryanDavis) [21:46:37] 3MediaWiki / 3User login and signup: User has to _change_ their password every time they open a new window - 10https://bugzilla.wikimedia.org/71148#c1 (10WhatamIdoing) The problems are appearing on a relatively new iMac. When she logs in on a MacBook Air, it is working better (possibly correctly?). She n... [21:47:07] 3Wikimedia / 3General/Unknown: User has to _change_ their password every time they open a new window - 10https://bugzilla.wikimedia.org/71148 (10Kunal Mehta (Legoktm)) [21:47:07] legoktm: with the new ResourceLoader and/or the new Gadgets, will it be feasible to do something like Foo.js in a wiki page and have MediaWiki:NameToBeBikesheddedLater/Foo.js loaded for all users who view that page? [21:47:31] (03CR) 10Legoktm: [C: 032] Allow login with pre-rename username and password [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/147020 (https://bugzilla.wikimedia.org/67995) (owner: 10BryanDavis) [21:47:43] as of right now, any time we want to do that, we have to add if(we're on page X){load the code;} to MediaWiki:Common.js every time [21:47:49] jackmcbarn: no but [21:48:17] (03Merged) 10jenkins-bot: Allow login with pre-rename username and password [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/147020 (https://bugzilla.wikimedia.org/67995) (owner: 10BryanDavis) [21:48:40] but...? [21:48:43] jackmcbarn: https://bugzilla.wikimedia.org/show_bug.cgi?id=61007 I think that's what you're looking for, and should be doable once Gadgets 2.0 is in place [21:49:17] legoktm: so it will have to be the gadget picks the pages, rather than the page picking the gadgets? [21:49:20] See also https://bugzilla.wikimedia.org/show_bug.cgi?id=15075 [21:49:25] 3MediaWiki extensions / 3Gadgets: Allow specifying what pages a gadget should run on in the definition - 10https://bugzilla.wikimedia.org/61007 (10Helder) [21:49:25] 3MediaWiki / 3General/Unknown: Per book, category and/or template CSS and JavaScript - 10https://bugzilla.wikimedia.org/15075 (10Helder) [21:49:26] yes. [21:49:42] Helder: yes, exactly that [21:50:05] legoktm: why does it have to be that way? that seems really bad for flexibility [21:50:22] because normal users shouldn't be allowed to specify what JS or CSS runs on a page or doesn't. [21:50:53] even if the JS in question came from a repository set up just for that purpose, that only admins could edit? [21:51:06] IMO yes. [21:51:07] 3MediaWiki skins / 3Vector: Vector: insufficent text contrast impairs legibility - 10https://bugzilla.wikimedia.org/66021#c20 (10Jared Zimmerman (WMF)) Thank you Andre, and thank you Issara for bringing this to everyone's attention. In the future I'll try to make an effort to add my notes, and let the origin... [21:53:23] 3Wikimedia / 3SSL related: replace SHA1 certificates with SHA256 - 10https://bugzilla.wikimedia.org/71156#c2 (10Waldir) Background reading: https://konklone.com/post/why-google-is-hurrying-the-web-to-kill-sha-1 [21:53:27] (03PS8) 10BryanDavis: Check for renamed user on login [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156947 (https://bugzilla.wikimedia.org/67995) (owner: 10CSteipp) [21:53:29] (03CR) 10jenkins-bot: [V: 04-1] Check for renamed user on login [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156947 (https://bugzilla.wikimedia.org/67995) (owner: 10CSteipp) [21:53:38] ori: Given greg-g's +1, do you want to +2 https://gerrit.wikimedia.org/r/#/c/162008/ and we'll put it in the SWAT? [21:53:59] (03PS1) 10Prtksxna: Special:EditWatchlist: Use destructive button and style checkboxes [core] - 10https://gerrit.wikimedia.org/r/162477 (https://bugzilla.wikimedia.org/71147) [21:54:07] 3Wikimedia / 3Mailing lists: Create a mailing list for Maithili (mai) Wikipedia - 10https://bugzilla.wikimedia.org/44938#c6 (10Andre Klapper) Hi Muzammil, > 1) Activity level has increased - 16 active users and about 60 overall users. Where exactly? Link welcome. [21:55:29] (03PS9) 10BryanDavis: Check for renamed user on login [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156947 (https://bugzilla.wikimedia.org/67995) (owner: 10CSteipp) [21:56:29] (03PS7) 10BryanDavis: [WIP] Interstitial notification page for renamed users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/148420 (https://bugzilla.wikimedia.org/67995) [21:59:54] 3MediaWiki extensions / 3Gadgets: Implement Gadgets 2.0 (tracking) - 10https://bugzilla.wikimedia.org/29272 (10Kunal Mehta (Legoktm)) [21:59:57] 3MediaWiki / 3ContentHandler: Support redirects in JavaScriptContent - 10https://bugzilla.wikimedia.org/71200 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3enhanc a:3None During the Gadgets 2.0 migration, we will be moving a lot of JS pages around. In order not to break existing mw.loader.load calls to... [22:00:51] (03PS2) 10Catrope: Don't make the notifications list 5px taller than the screen [extensions/Echo] - 10https://gerrit.wikimedia.org/r/161409 [22:01:24] 3MediaWiki extensions / 3Gadgets: Implement Gadgets 2.0 (tracking) - 10https://bugzilla.wikimedia.org/29272 (10Kunal Mehta (Legoktm)) [22:01:26] 3MediaWiki / 3ContentHandler: Support redirects in CssContent - 10https://bugzilla.wikimedia.org/71201 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3enhanc a:3None During the Gadgets 2.0 migration, we will be moving a lot of CSS pages around. In order not to break existing @import calls to MediaWiki:Ga... [22:01:40] 3MediaWiki / 3ContentHandler: Support redirects in CssContent - 10https://bugzilla.wikimedia.org/71201 (10Kunal Mehta (Legoktm)) [22:01:40] 3MediaWiki / 3ContentHandler: Support redirects in JavaScriptContent - 10https://bugzilla.wikimedia.org/71200 (10Kunal Mehta (Legoktm)) [22:02:37] (03CR) 10MaxSem: [C: 032] Remove spammy debug log [extensions/MassMessage] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161002 (owner: 10Reedy) [22:03:11] (03Merged) 10jenkins-bot: Remove spammy debug log [extensions/MassMessage] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161002 (owner: 10Reedy) [22:03:41] 3MediaWiki / 3MediaWiki UI: Enable form refresh as beta feature - 10https://bugzilla.wikimedia.org/71202 (10Jon) 3NEW p:3Unprio s:3normal a:3None Jared has requested that there be a beta feature that enables the new form styling (e.g. sets $wgUseMediaWikiUIEverywhere to be true) to gather feedback fr... [22:03:53] 3MediaWiki / 3ContentHandler: Support redirects in JavaScriptContent - 10https://bugzilla.wikimedia.org/71200#c1 (10Helder) This looks like a dupe of bug 33973 to me. [22:04:24] 3MediaWiki / 3MediaWiki UI: Remove $wgUseMediaWikiUIEverywhere dependency for button and input styling (tracking) - 10https://bugzilla.wikimedia.org/70913 (10Jon) [22:04:24] 3MediaWiki / 3MediaWiki UI: Enable form refresh as beta feature - 10https://bugzilla.wikimedia.org/71202 (10Jon) [22:04:37] 3MediaWiki / 3ContentHandler: Support redirects in CssContent - 10https://bugzilla.wikimedia.org/71201#c1 (10Helder) Dupe of bug 33973? [22:04:48] ori: ready when you are [22:09:21] (03CR) 10Aaron Schulz: [C: 032] Move non-user specific things from Title::isValidMoveOperation() to MovePage [core] - 10https://gerrit.wikimedia.org/r/161505 (owner: 10Legoktm) [22:10:43] Helder: maybe.... [22:11:37] 3MediaWiki-Vagrant: Audit base install to see if resource footprint can be reduced - 10https://bugzilla.wikimedia.org/70421#c5 (10Bryan Davis) 5PATC>3NEW (In reply to Bryan Davis from comment #2) > > I have seen `puppet agent` running occasionally too, but not consistently. This should be fixed by https:... [22:12:28] (03CR) 10Aaron Schulz: Fixes to prevent duplicate rows in ActiveUser cache (032 comments) [core] - 10https://gerrit.wikimedia.org/r/162287 (owner: 10Aaron Schulz) [22:13:13] (03CR) 10Chad: [C: 032] Reduce queries to count links [extensions/CirrusSearch] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162300 (owner: 10Manybubbles) [22:13:20] (03CR) 10Chad: [C: 032] Reduce queries to count links [extensions/CirrusSearch] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/162316 (owner: 10Manybubbles) [22:13:41] (03PS1) 10Cscott: Set parsoid endpoint for OCG on wikisource. [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/162481 [22:13:52] 3MediaWiki / 3MediaWiki UI: Enable form refresh as beta feature - 10https://bugzilla.wikimedia.org/71202#c1 (10Jared Zimmerman (WMF)) Proposed Title for beta feature: Interface Refresh and Standardization Proposed body for beta feature: Use an updated look and feel for basic controls on the site, initially... [22:14:06] 3MediaWiki / 3MediaWiki UI: Enable form refresh as beta feature - 10https://bugzilla.wikimedia.org/71202#c2 (10Jared Zimmerman (WMF)) Created attachment 16567 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16567&action=edit image for mwui beta feature [22:15:26] (03PS2) 10Aaron Schulz: Fixes to prevent duplicate rows in ActiveUser cache [core] - 10https://gerrit.wikimedia.org/r/162287 [22:16:02] (03CR) 10jenkins-bot: [V: 04-1] Move non-user specific things from Title::isValidMoveOperation() to MovePage [core] - 10https://gerrit.wikimedia.org/r/161505 (owner: 10Legoktm) [22:16:22] (03CR) 10Legoktm: "recheck" [core] - 10https://gerrit.wikimedia.org/r/161505 (owner: 10Legoktm) [22:16:29] (03PS1) 10MaxSem: MassMessage: grab https://gerrit.wikimedia.org/r/#/c/161002/ [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/162483 [22:16:37] 3MediaWiki / 3MediaWiki UI: Enable form refresh as beta feature - 10https://bugzilla.wikimedia.org/71202#c3 (10Jared Zimmerman (WMF)) Project page https://www.mediawiki.org/wiki/MediaWiki_UI Discussion page needs to be flow enabled https://www.mediawiki.org/wiki/Talk:MediaWiki_UI [22:17:32] (03CR) 10Cscott: [C: 032 V: 032] Set parsoid endpoint for OCG on wikisource. [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/162481 (owner: 10Cscott) [22:18:39] (03CR) 10Chad: [C: 032] Add more retry logic to reindexing [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/162362 (owner: 10Manybubbles) [22:19:07] 3MediaWiki skins / 3Vector: Vector: h3 should not appear as heavier weight than h2 - 10https://bugzilla.wikimedia.org/69998#c15 (10Andre Klapper) Created attachment 16568 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16568&action=edit URLs in comment 13; Firefox 32 private session (logged out), 100%... [22:23:00] (03Merged) 10jenkins-bot: Reduce queries to count links [extensions/CirrusSearch] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162300 (owner: 10Manybubbles) [22:23:14] (03Merged) 10jenkins-bot: Reduce queries to count links [extensions/CirrusSearch] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/162316 (owner: 10Manybubbles) [22:23:16] (03Merged) 10jenkins-bot: Add more retry logic to reindexing [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/162362 (owner: 10Manybubbles) [22:23:23] 3MediaWiki skins / 3Vector: Vector: insufficent text contrast impairs legibility - 10https://bugzilla.wikimedia.org/66021#c21 (10Isarra) (In reply to Andre Klapper from comment #19) > I think "At this time I do not want to make an additional change to this > value since insufficient evidence that a higher co... [22:23:24] (03CR) 10Jackmcbarn: [C: 032] "I'd really like to see this done properly, but this is a good stopgap for now." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/161409 (owner: 10Catrope) [22:23:54] (03Merged) 10jenkins-bot: Don't make the notifications list 5px taller than the screen [extensions/Echo] - 10https://gerrit.wikimedia.org/r/161409 (owner: 10Catrope) [22:24:22] When constructing a form using HtmlForm, is there no way to apply a class to just the input field? 'cssclass' seems to apply it on the parent as well, is that a feature or bug? [22:24:32] (03CR) 10Legoktm: "If this is a stopgap for something, a bug should be filed so it gets fixed properly..." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/161409 (owner: 10Catrope) [22:25:41] (03PS1) 10Prtksxna: Special:BlockList: Use mw-ui-progressive for search button [core] - 10https://gerrit.wikimedia.org/r/162484 (https://bugzilla.wikimedia.org/71144) [22:27:03] (03PS1) 10Catrope: Update OOjs UI for cherry-pick [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162485 [22:28:52] 3MediaWiki skins / 3Vector: Vector: insufficent text contrast impairs legibility - 10https://bugzilla.wikimedia.org/66021#c22 (10Isarra) Oh, sorry, I was looking at the wrong patch. If you'll read what Jon said, he put the -2 there pending consensus on the bug. If the bug is closed because of a -2 on the pat... [22:30:08] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (880100c45e) [core] - 10https://gerrit.wikimedia.org/r/162488 [22:30:09] 3MediaWiki / 3MediaWiki UI: Enable form refresh as beta feature - 10https://bugzilla.wikimedia.org/71202 (10Prateek Saxena) [22:33:39] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (880100c45e) [core] - 10https://gerrit.wikimedia.org/r/162488 (owner: 10Jforrester) [22:35:16] (03CR) 10Isarra: "I'm afraid I don't bookmark these things when they come up, but I've seen it at least once on the village pump, as well as with new users " [core] - 10https://gerrit.wikimedia.org/r/110279 (https://bugzilla.wikimedia.org/47694) (owner: 10Bartosz Dziewoński) [22:36:09] 3Wikimedia / 3Bugzilla: Create additional components for PDF Rendering - 10https://bugzilla.wikimedia.org/69603#c10 (10Andre Klapper) 5NEW>3RESO/FIX a:3Andre Klapper Created: https://bugzilla.wikimedia.org/describecomponents.cgi?product=OCG Not entirely happy with the name yet (discoverability). I g... [22:36:18] (03CR) 10Isarra: "And no, you don't need to change the login button. The (for blah days) thing that wikipedia has had for years works just fine, and will be" [core] - 10https://gerrit.wikimedia.org/r/110279 (https://bugzilla.wikimedia.org/47694) (owner: 10Bartosz Dziewoński) [22:38:14] [13node-cssjanus] 15Krinkle pushed 2 new commits to 06master: 02https://github.com/cssjanus/node-cssjanus/compare/75581a28ab11...d1e0d8df0717 [22:38:14] 13node-cssjanus/06master 14de363b5 15Timo Tijhof: Add test for "/*!" syntax with @noflip [22:38:14] 13node-cssjanus/06master 14d1e0d8d 15Timo Tijhof: Tag v1.1.0 [22:38:27] [13node-cssjanus] 15Krinkle tagged 06v1.1.0 at 06master: 02https://github.com/cssjanus/node-cssjanus/commits/v1.1.0 [22:38:30] TrevorParscal: RoanKattouw: ^ [22:38:56] (03PS1) 10Aaron Schulz: Created DabaseBase::trxTimestamp method and added usage in ActiveUsers query [core] - 10https://gerrit.wikimedia.org/r/162490 [22:39:09] (03CR) 10Jackmcbarn: "https://bugzilla.wikimedia.org/show_bug.cgi?id=71205" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/161409 (owner: 10Catrope) [22:39:09] 3MediaWiki extensions / 3ConfirmEdit (CAPTCHA extension): CAPTCHA doesn't work for blind people - 10https://bugzilla.wikimedia.org/4845#c19 (10Sumana Harihareswara) Adding a few people to cc who are interested in helping with accessibility issues - see https://www.mediawiki.org/wiki/Accessibility#People_and_... [22:39:12] Krinkle: that's hot [22:39:34] [travis-ci] cssjanus/node-cssjanus#52 (master - d1e0d8d : Timo Tijhof): The build passed. [22:39:35] [travis-ci] Change view : https://github.com/cssjanus/node-cssjanus/compare/75581a28ab11...d1e0d8df0717 [22:39:35] [travis-ci] Build details : http://travis-ci.org/cssjanus/node-cssjanus/builds/36100044 [22:39:58] Krinkle: https://gerrit.wikimedia.org/r/161754 got time for this any time soon? [22:39:58] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (880100c45e) [core] - 10https://gerrit.wikimedia.org/r/162488 (owner: 10Jforrester) [22:40:11] MatmaRex: Totally [22:40:12] (03PS3) 10EBernhardson: Remove lower-level posts' right padding [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162280 (owner: 10Matthias Mullie) [22:40:21] It's blocking my release of php-cssjanus and it being used by mediawiki [22:40:47] [travis-ci] cssjanus/node-cssjanus#53 (v1.1.0 - d1e0d8d : Timo Tijhof): The build passed. [22:40:47] [travis-ci] Change view : https://github.com/cssjanus/node-cssjanus/compare/v1.1.0 [22:40:47] [travis-ci] Build details : http://travis-ci.org/cssjanus/node-cssjanus/builds/36100052 [22:41:05] (03CR) 10EBernhardson: "PS3: updated .minimalPostHighlight() mixin calls to match the adjusted padding/border change." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162280 (owner: 10Matthias Mullie) [22:41:22] 3Wikimedia / 3General/Unknown: Access to HTTP 404 logs for Wiktionary - 10https://bugzilla.wikimedia.org/32514#c9 (10Sumana Harihareswara) Pinging Srikanth once more. :) [22:41:54] legoktm: re https://bugzilla.wikimedia.org/show_bug.cgi?id=71201#c1, couldn't we make css pages leave behind an @import to wherever the new page is, instead of a #redirect? see also https://gerrit.wikimedia.org/r/#/c/146608/ where i want to do the equivalent for scribunto [22:42:01] (03CR) 10Legoktm: [C: 032] "Re-apply +2" [core] - 10https://gerrit.wikimedia.org/r/161505 (owner: 10Legoktm) [22:42:23] jackmcbarn: yeah, exactly my plan [22:43:49] (03CR) 1020after4: [C: 031] "looks good to me but it's not my call." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/153983 (owner: 10Mitar) [22:44:09] 3MediaWiki / 3MediaWiki UI: Have mediawiki.ui buttons show focus in a clear and accessible way - 10https://bugzilla.wikimedia.org/62924 (10Prateek Saxena) a:3Prateek Saxena [22:45:56] (03PS1) 10Legoktm: Support redirects in JavaScriptContent [core] - 10https://gerrit.wikimedia.org/r/162491 (https://bugzilla.wikimedia.org/71200) [22:46:04] jackmcbarn: ^ [22:47:07] legoktm: that's the easy one. the hard one is css, since i really don't want to bake $wgScriptPath into them [22:47:28] er, how is it any different? [22:47:55] (03PS3) 10Krinkle: Make "/*@noflip*/ /*@embed*/" annotation work without CSSJanus hacks [core] - 10https://gerrit.wikimedia.org/r/161754 (https://bugzilla.wikimedia.org/69698) (owner: 10Bartosz Dziewoński) [22:48:36] legoktm: we don't have an mw.loader.load function from css [22:48:46] (03Merged) 10jenkins-bot: Move non-user specific things from Title::isValidMoveOperation() to MovePage [core] - 10https://gerrit.wikimedia.org/r/161505 (owner: 10Legoktm) [22:48:49] you just use @import... [22:48:58] legoktm: right, and we bake in $wgScriptPath by doing so [22:49:05] my JS patch does that too? [22:49:09] does it? /me looks [22:49:10] that's not a bad thing either... [22:49:30] why do it unnecessarily? you don't have to for js [22:49:49] alternative is? [22:50:04] sorry, bbl in 15 [22:50:20] (03CR) 10Krinkle: [C: 032] Make "/*@noflip*/ /*@embed*/" annotation work without CSSJanus hacks [core] - 10https://gerrit.wikimedia.org/r/161754 (https://bugzilla.wikimedia.org/69698) (owner: 10Bartosz Dziewoński) [22:51:12] (03CR) 10Jdlrobson: [C: 032] Add page images to mobile watchlist A-Z view [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/161498 (owner: 10MaxSem) [22:51:58] Krinkle: thanks. should we backport to 1.24? [22:52:56] 3MediaWiki / 3User login and signup: Login as another user no longer works - 10https://bugzilla.wikimedia.org/70855#c20 (10Jon) So to be clear the fix has reopened bug 15484 [22:53:37] 3MediaWiki / 3General/Unknown: Redirect to Special:UserLogin when logging is in required to proceed, instead of showing an error message - 10https://bugzilla.wikimedia.org/15484#c26 (10Jon) 5RESO/FIX>3REOP Sadly bug 70855 broke this. This is a sad day (personally I think this bug was a bigger deal than n... [22:53:52] 3MediaWiki skins / 3Vector: h4, h5, and h6 headers should not have the same styling - 10https://bugzilla.wikimedia.org/70004#c12 (10Brandon Harris) Let's not forget that individual wikis can (and should) adjust font weights and styles based on their own need in Common.css. This is particularly true for wikis... [22:54:30] (03CR) 10Jdlrobson: "I think this change was premature and should have been discussed more on the bug. I didn't realise we were reverting this functionality :(" [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/162120 (https://bugzilla.wikimedia.org/70855) (owner: 10Legoktm) [22:56:01] (03CR) 10Jdlrobson: "I also don't think it is a good idea to have both a bare and fallback skin. One only please..." [core] - 10https://gerrit.wikimedia.org/r/160797 (owner: 10Anomie) [22:56:33] (03CR) 10Reedy: [C: 032] Make tiff thumbnail in 2 steps. [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135289 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [22:56:52] (03PS3) 10Jackmcbarn: Add redirect support to modules [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/146608 [22:57:19] (03CR) 10Jdlrobson: [C: 04-1] "Suggested course of action:" [core] - 10https://gerrit.wikimedia.org/r/160797 (owner: 10Anomie) [22:57:21] (03Merged) 10jenkins-bot: Make "/*@noflip*/ /*@embed*/" annotation work without CSSJanus hacks [core] - 10https://gerrit.wikimedia.org/r/161754 (https://bugzilla.wikimedia.org/69698) (owner: 10Bartosz Dziewoński) [22:57:24] (03Merged) 10jenkins-bot: Add page images to mobile watchlist A-Z view [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/161498 (owner: 10MaxSem) [22:57:26] (03PS4) 10Jackmcbarn: Add redirect support to modules [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/146608 [22:57:32] (03CR) 10jenkins-bot: [V: 04-1] Make tiff thumbnail in 2 steps. [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135289 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [22:58:20] 22:56:51 Failed asserting that true is false. [22:58:21] haha [22:58:49] (03CR) 10Reedy: "22:56:48 Configuration read from /srv/ssd/jenkins-slave/workspace/mwext-PagedTiffHandler-testextension/src/tests/phpunit/suite.xml" [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135289 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [22:59:36] (03PS3) 10MaxSem: Return coordinates from a given point [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/161623 [22:59:41] (03CR) 10MaxSem: Return coordinates from a given point (033 comments) [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/161623 (owner: 10MaxSem) [22:59:43] (03CR) 10Reedy: "recheck" [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135289 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [22:59:51] 3MediaWiki extensions / 3WikidataRepo: check compatibility of DataModel 1.0 with entity blobs in a (old) dump - 10https://bugzilla.wikimedia.org/70750#c1 (10Jeroen De Dauw) The title seems wrong. This is about the deserialization code no? Not the DataModel itself? [23:01:30] jackmcbarn: back. So how else would you do it in JS? [23:01:37] 3MediaWiki extensions / 3WikidataRepo: check compatibility of DataModel 1.0 with entity blobs in a (old) dump - 10https://bugzilla.wikimedia.org/70750#c2 (10Jeroen De Dauw) Infrastructure is already in place to do such compat testing. See the data and integration folders at https://github.com/wmde/WikibaseIn... [23:01:43] legoktm: use https://gerrit.wikimedia.org/r/#/c/83834/5/resources/mediawiki/mediawiki.util.js [23:01:46] (03PS4) 10EBernhardson: First trim content, then truncate [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162277 (owner: 10Matthias Mullie) [23:02:22] 3MediaWiki extensions / 3WikidataRepo: check compatibility of DataModel 1.0 with entity blobs in a (old) dump - 10https://bugzilla.wikimedia.org/70750#c3 (10Jeroen De Dauw) Actually it is not clear to me what the exact thing to solve here is. No clear bug is reported, and "test more" is not well defined. So... [23:02:35] but then you need a mw.loader.using('mediawiki.util') and everything else. [23:03:17] eww [23:03:19] (03CR) 10Legoktm: "You probably want to comment on a94f11d625ea70f253e0d9620a44b447dd830b6b, and not this patchset since I just backported it." [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/162120 (https://bugzilla.wikimedia.org/70855) (owner: 10Legoktm) [23:03:20] hmm [23:03:21] (03CR) 10MaxSem: [C: 032 V: 032] MassMessage: grab https://gerrit.wikimedia.org/r/#/c/161002/ [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/162483 (owner: 10MaxSem) [23:03:22] 3MediaWiki extensions / 3WikidataRepo: Move JS WikibaseAPI code into its own component - 10https://bugzilla.wikimedia.org/66419#c2 (10Jeroen De Dauw) \o/ [23:04:11] 3MediaWiki / 3ResourceLoader: Using "/*@noflip*/ /*@embed*/" annotation doesn't work (although other combinations do) - 10https://bugzilla.wikimedia.org/69698 (10Bartosz Dziewoński) 5PATC>3RESO/FIX [23:04:24] 3MediaWiki / 3ResourceLoader: Using "/*@noflip*/ /*@embed*/" annotation doesn't work (although other combinations do) - 10https://bugzilla.wikimedia.org/69698 (10Bartosz Dziewoński) [23:04:24] 3MediaWiki skins / 3Vector: Vector: insufficent text contrast impairs legibility - 10https://bugzilla.wikimedia.org/66021#c23 (10Brandon Harris) It's actually fairly well proven that human eyes endure greater strain when the contrast is perfect (e.g., #000 on #fff). There's links and documentation someplace... [23:05:52] 3MediaWiki extensions / 3WikidataRepo: Create browser smoke test for a typical item - 10https://bugzilla.wikimedia.org/68094#c1 (10Jeroen De Dauw) We already have many tests tauching items in some way. So what is the point of adding a smoke test? Adding a smoke test when there are more detailed tests already... [23:05:59] (03CR) 10Legoktm: [C: 032] Check for renamed user on login [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156947 (https://bugzilla.wikimedia.org/67995) (owner: 10CSteipp) [23:05:59] legoktm: ok, mw.loader.load(mw.config.get('wgScriptPath') + '/index.php?title=' + /* blah blah the rest */) [23:07:03] (03Merged) 10jenkins-bot: Check for renamed user on login [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156947 (https://bugzilla.wikimedia.org/67995) (owner: 10CSteipp) [23:07:36] What's the actual advantage to doing that? [23:07:36] Why is hardcoding the script path wrong? [23:07:36] s/wrong/bad/ [23:07:51] 3MediaWiki / 3General/Unknown: Redirect to Special:UserLogin when logging is in required to proceed, instead of showing an error message - 10https://bugzilla.wikimedia.org/15484#c27 (10Jon) 5REOP>3RESO/FIX My mistake. Seems I uncovered a mobile bug. http://en.wikipedia.beta.wmflabs.org/wiki/Special:Watch... [23:08:06] 3MediaWiki extensions / 3WikidataRepo: Implement terms-lookup based on terms-table - 10https://bugzilla.wikimedia.org/71169#c1 (10Jeroen De Dauw) What does this actually mean? We already have term lookup methods based on the terms table. What additional ones do we need? Or is this about changing existing one... [23:08:28] legoktm: because if a user sets up a wiki, sets up some javascript, then moves say from http://cheap.webhost/~them/wiki/index.php tp http://their.real.nice.webhost/w/index.php, it shouldn't all break on them [23:09:47] (03PS1) 10Gergő Tisza: Fix missing tutorial steps in the funnel logging [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/162499 [23:10:19] (03CR) 10jenkins-bot: [V: 04-1] Fix missing tutorial steps in the funnel logging [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/162499 (owner: 10Gergő Tisza) [23:11:04] (03CR) 10EBernhardson: [C: 032] Fix [Object object] placeholder text in topic reply field [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162243 (owner: 10Matthias Mullie) [23:11:10] 3MediaWiki / 3Database: MS SQL Driver doesn't handle escaping for LIKE patterns correctly - 10https://bugzilla.wikimedia.org/71207 (10Emad Elwany) 3UNCO p:3Unprio s:3normal a:3None MS SQL requires specifying the escape character in the query using the ESCAPE directive. The way it is currently handled... [23:11:31] (03PS2) 10Gergő Tisza: Fix missing tutorial steps in the funnel logging [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/162499 [23:11:44] (03CR) 10Jdlrobson: [C: 032] Special:BookSources: Use appropriate mediawiki.ui classes and update strings [core] - 10https://gerrit.wikimedia.org/r/162145 (https://bugzilla.wikimedia.org/71145) (owner: 10Prtksxna) [23:11:59] (03Merged) 10jenkins-bot: Fix [Object object] placeholder text in topic reply field [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162243 (owner: 10Matthias Mullie) [23:12:02] (03Merged) 10jenkins-bot: Placeholder should only contain text of exactly the topic being replied to [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162276 (owner: 10Matthias Mullie) [23:12:40] (03CR) 10EBernhardson: [C: 032] First trim content, then truncate [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162277 (owner: 10Matthias Mullie) [23:12:50] jackmcbarn: I guess.... [23:13:47] (03PS16) 10SG: Change mw-ui anchors to require mw-ui-anchor base class, and introduce mw-ui-text base class [core] - 10https://gerrit.wikimedia.org/r/155856 (https://bugzilla.wikimedia.org/69212) [23:14:43] (03CR) 10jenkins-bot: [V: 04-1] Change mw-ui anchors to require mw-ui-anchor base class, and introduce mw-ui-text base class [core] - 10https://gerrit.wikimedia.org/r/155856 (https://bugzilla.wikimedia.org/69212) (owner: 10SG) [23:15:21] (03CR) 10EBernhardson: "more context from shahyar:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162232 (owner: 10Matthias Mullie) [23:15:58] (03CR) 10Bartosz Dziewoński: "See https://bugzilla.wikimedia.org/show_bug.cgi?id=15484#c27 , as I understand it Jon meant something else." [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/162120 (https://bugzilla.wikimedia.org/70855) (owner: 10Legoktm) [23:16:01] (03CR) 10Jdlrobson: [C: 04-2] "This makes various design changes. Changing heading by .1em, dropping a bold and line height willy nilly doesn't seem a good idea/worth it" [skins/Vector] - 10https://gerrit.wikimedia.org/r/162304 (owner: 10Isarra) [23:16:32] (03CR) 10SG: Change mw-ui anchors to require mw-ui-anchor base class, and introduce mw-ui-text base class (031 comment) [core] - 10https://gerrit.wikimedia.org/r/155856 (https://bugzilla.wikimedia.org/69212) (owner: 10SG) [23:17:07] 3MediaWiki / 3User login and signup: Login as another user no longer works - 10https://bugzilla.wikimedia.org/70855#c21 (10Bartosz Dziewoński) (Per bug 15484 comment 27 it hasn't. The fix here only changes any behavior if a user types "Special:UserLogin" in the search box or address bar, or otherwise directl... [23:17:39] 3MediaWiki / 3Documentation: Api documentation on mw.org is out of date, incomplete - 10https://bugzilla.wikimedia.org/29936#c10 (10Sumana Harihareswara) https://www.mediawiki.org/wiki/Data_%26_Developer_Hub is related. [23:17:39] 3Wikimedia / 3General/Unknown: Set up dev.wikimedia.org portal - 10https://bugzilla.wikimedia.org/65074 (10Sumana Harihareswara) [23:18:29] (03Merged) 10jenkins-bot: Special:BookSources: Use appropriate mediawiki.ui classes and update strings [core] - 10https://gerrit.wikimedia.org/r/162145 (https://bugzilla.wikimedia.org/71145) (owner: 10Prtksxna) [23:18:35] (03Merged) 10jenkins-bot: First trim content, then truncate [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162277 (owner: 10Matthias Mullie) [23:18:54] (03CR) 10Legoktm: "On IRC, jackmcbarn suggested that we do something like mw.loader.load(mw.config.get('wgScriptPath') + '/index.php?title=' + /* blah blah t" [core] - 10https://gerrit.wikimedia.org/r/162491 (https://bugzilla.wikimedia.org/71200) (owner: 10Legoktm) [23:18:56] 3MediaWiki / 3MediaWiki UI: Have mediawiki.ui buttons show focus in a clear and accessible way - 10https://bugzilla.wikimedia.org/62924#c8 (10May) Created attachment 16569 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16569&action=edit All states of a button Added new spec [23:18:57] (03CR) 10Jamesmontalvo3: "It doesn't seem like we'll reach an agreement. Are you saying you won't approve the patch unless I revert it?" [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [23:19:24] 3MediaWiki / 3MediaWiki UI: Fix special:booksource for mw.ui - 10https://bugzilla.wikimedia.org/71145 (10Prateek Saxena) 5PATC>3RESO/FIX [23:19:38] (03PS17) 10SG: Change mw-ui anchors to require mw-ui-anchor base class, and introduce mw-ui-text base class [core] - 10https://gerrit.wikimedia.org/r/155856 (https://bugzilla.wikimedia.org/69212) [23:19:52] 3MediaWiki / 3User login and signup: Can't authenticate using my mother language username (UNICODE) when I only have (a public) access to Wikipedia with an ASCII (english) keyboard - 10https://bugzilla.wikimedia.org/34590 (10Sumana Harihareswara) [23:20:52] 3MediaWiki / 3User login and signup: Login as another user no longer works - 10https://bugzilla.wikimedia.org/70855#c22 (10Steven Walling) (In reply to Bartosz Dziewoński from comment #21) > (Per bug 15484 comment 27 it hasn't. The fix here only changes any behavior > if a user types "Special:UserLogin" in t... [23:21:58] (03CR) 10Kaldari: [C: 04-1] Tweak checkbox sizes to be relative depending on where used. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/154125 (https://bugzilla.wikimedia.org/70133) (owner: 10Jdlrobson) [23:23:01] (03CR) 10SG: [C: 04-1] "TL;DR: Change false to true. Get rid of safeHtml." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/162232 (owner: 10Matthias Mullie) [23:23:10] (03CR) 10Jdlrobson: [C: 04-1] "When $wgUseMediaWikiUIEverywhere = false; the checkboxes are display block..." [core] - 10https://gerrit.wikimedia.org/r/162484 (https://bugzilla.wikimedia.org/71144) (owner: 10Prtksxna) [23:25:41] (03CR) 10Jdlrobson: [C: 032] Special:EditWatchlist: Use destructive button and style checkboxes [core] - 10https://gerrit.wikimedia.org/r/162477 (https://bugzilla.wikimedia.org/71147) (owner: 10Prtksxna) [23:25:52] 3Wikimedia / 3Site requests: Allow embedding RSS feeds from bugzilla into mediawiki.org - 10https://bugzilla.wikimedia.org/56287#c3 (10Tim Landscheidt) The current state of things makes https://www.mediawiki.org/wiki/HHVM#Current_work look ugly. [23:26:08] 3Wikimedia / 3Deployment systems: MWMultiVersion can fatal for bad Host headers - 10https://bugzilla.wikimedia.org/69419 (10Greg Grossmeier) p:5Unprio>3Normal [23:26:53] 3Wikimedia / 3Deployment systems: [scap] Syncing wmf-config/PrivateSettings.php syncs symlink and not file contents - 10https://bugzilla.wikimedia.org/70054 (10Greg Grossmeier) p:5Unprio>3Low [23:26:53] (03PS1) 10Tim Starling: Use a larger alphabet for shortcodes [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/162507 [23:28:07] (03CR) 10Jdlrobson: [C: 032] "Oh wait that was done in the commit I just merged." [core] - 10https://gerrit.wikimedia.org/r/162484 (https://bugzilla.wikimedia.org/71144) (owner: 10Prtksxna) [23:29:52] 3Wikimedia / 3Deployment systems: [l10n] LocalisationUpdate doesn't seem to run for VisualEditor - 10https://bugzilla.wikimedia.org/70267#c2 (10Greg Grossmeier) p:5Unprio>3High Is this still a problem? If so, can someone (Niklas/Amir/?) on this bug help point out where the problem might be? [23:31:56] 3MediaWiki / 3User login and signup: Login as another user no longer works - 10https://bugzilla.wikimedia.org/70855#c23 (10Jon) My bad. Thanks for the clarification and sorry for the confusion :) [23:31:56] 3MediaWiki skins / 3Vector: Vector: insufficent text contrast impairs legibility - 10https://bugzilla.wikimedia.org/66021#c24 (10Isarra) This has nothing to do with CRTs, nor how monitors degrade over time in general. I already explained that. Nor is there any such thing as 'perfect' contrast. You can have... [23:32:02] (03Merged) 10jenkins-bot: Special:EditWatchlist: Use destructive button and style checkboxes [core] - 10https://gerrit.wikimedia.org/r/162477 (https://bugzilla.wikimedia.org/71147) (owner: 10Prtksxna) [23:32:53] 3MediaWiki / 3Database: Deleting of pages with high number of revisions makes server cry - 10https://bugzilla.wikimedia.org/11402 (10Sumana Harihareswara) [23:33:02] (03PS14) 10Jdlrobson: Tweak checkbox sizes to be relative depending on where used. [core] - 10https://gerrit.wikimedia.org/r/154125 (https://bugzilla.wikimedia.org/70133) [23:33:28] (03CR) 10Kaldari: [C: 032] "Looks OK to me." [core] - 10https://gerrit.wikimedia.org/r/154125 (https://bugzilla.wikimedia.org/70133) (owner: 10Jdlrobson) [23:34:28] (03PS1) 10Emadelwany: Add ESCAPE identifier to MS SQL LIKE queries so that the escaping would work as expected. [core] - 10https://gerrit.wikimedia.org/r/162508 (https://bugzilla.wikimedia.org/71207) [23:34:30] (03Merged) 10jenkins-bot: Special:BlockList: Use mw-ui-progressive for search button [core] - 10https://gerrit.wikimedia.org/r/162484 (https://bugzilla.wikimedia.org/71144) (owner: 10Prtksxna) [23:36:03] (03PS1) 10Prtksxna: HtmlForm: Use mw-ui-checkbox only if wgUseMediaWikiUIEverywhere is enabled [core] - 10https://gerrit.wikimedia.org/r/162509 [23:36:40] (03PS2) 10Emadelwany: Add ESCAPE identifier to MS SQL LIKE queries so that the escaping would work as expected. [core] - 10https://gerrit.wikimedia.org/r/162508 (https://bugzilla.wikimedia.org/71207) [23:37:34] (03PS1) 10Kaldari: Update MobileFrontend [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162510 [23:38:01] (03CR) 10Jdlrobson: [C: 04-1] HtmlForm: Use mw-ui-checkbox only if wgUseMediaWikiUIEverywhere is enabled (031 comment) [core] - 10https://gerrit.wikimedia.org/r/162509 (owner: 10Prtksxna) [23:38:28] TimStarling: i'm ready in the hangout when you are [23:39:11] (03PS3) 10Emadelwany: Add ESCAPE identifier to MS SQL LIKE queries so that the escaping would work as expected. [core] - 10https://gerrit.wikimedia.org/r/162508 (https://bugzilla.wikimedia.org/71207) [23:39:42] (03PS2) 10Prtksxna: HtmlForm: Use mw-ui-checkbox only if wgUseMediaWikiUIEverywhere is enabled [core] - 10https://gerrit.wikimedia.org/r/162509 [23:40:02] (03CR) 10Prtksxna: HtmlForm: Use mw-ui-checkbox only if wgUseMediaWikiUIEverywhere is enabled (031 comment) [core] - 10https://gerrit.wikimedia.org/r/162509 (owner: 10Prtksxna) [23:40:30] (03Merged) 10jenkins-bot: Tweak checkbox sizes to be relative depending on where used. [core] - 10https://gerrit.wikimedia.org/r/154125 (https://bugzilla.wikimedia.org/70133) (owner: 10Jdlrobson) [23:43:09] (03CR) 10Isarra: "Yes, all the changes are outlined in the commit message (except maybe the margin - I couldn't quite figure out what was going on with that" [skins/Vector] - 10https://gerrit.wikimedia.org/r/162304 (owner: 10Isarra) [23:43:54] (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162510 (owner: 10Kaldari) [23:51:39] (03PS18) 10Jdlrobson: Change mw-ui anchors to require mw-ui-anchor base class, and introduce mw-ui-text base class [core] - 10https://gerrit.wikimedia.org/r/155856 (https://bugzilla.wikimedia.org/69212) (owner: 10SG) [23:52:23] 3MediaWiki / 3Watchlist: Add a direct unwatch link to entries on Special:Watchlist - 10https://bugzilla.wikimedia.org/424 (10Sumana Harihareswara) [23:54:10] (03PS1) 10Prtksxna: Special:BookSources: Follow up patch to add the global for $wgUseMediaWikiUIEverywhere [core] - 10https://gerrit.wikimedia.org/r/162512 [23:55:08] 3MediaWiki / 3MediaWiki UI: Have mediawiki.ui buttons show focus in a clear and accessible way - 10https://bugzilla.wikimedia.org/62924#c9 (10Jared Zimmerman (WMF)) for the lighter and darker versions of the mw.ui colors cna you calculate the HSB differecnes so we can code these with LESS variables rather th... [23:57:08] 3MediaWiki / 3MediaWiki UI: Have mediawiki.ui buttons show focus in a clear and accessible way - 10https://bugzilla.wikimedia.org/62924#c10 (10Prateek Saxena) (In reply to Jared in comment #9) We could use the same approach as with the bevel where instead of specifying a color we just set it to black with a... [23:58:24] 3Wikimedia / 3Deployment systems: App servers get into bad states when coming back online/are newly provisioned due to puppet/salt craziness - 10https://bugzilla.wikimedia.org/66050 (10Greg Grossmeier) [23:58:24] 3Wikimedia / 3Deployment systems: [ops] Monitor that LVS config and mw_install are in sync - 10https://bugzilla.wikimedia.org/23662 (10Greg Grossmeier)