[00:00:33] (03PS14) 10Krinkle: mediawiki.api: Remove deprecated function parameters [core] - 10https://gerrit.wikimedia.org/r/118733 (owner: 10Bartosz Dziewoński) [00:01:56] (03CR) 10Chad: [C: 032] "It's less for reporting, more for helping people figure out what's going on when their query failed. Considering regular expression search" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/161039 (owner: 10Manybubbles) [00:02:19] (03Merged) 10jenkins-bot: Add error messages for pool queue full [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/161039 (owner: 10Manybubbles) [00:02:38] 3MediaWiki / 3General/Unknown: Redirect does not appear in browser history - 10https://bugzilla.wikimedia.org/70962#c6 (10Waldir) Why not use pushState() rather than replaceState()? IIUC, that would rewrite the url while only appending --not replacing-- the history entry, so going back to the redirect url wo... [00:04:19] (03PS13) 10Krinkle: mediawiki.user: Remove deprecated name() and anonymous() methods [core] - 10https://gerrit.wikimedia.org/r/111422 (owner: 10Ori.livneh) [00:07:46] (03PS15) 10Krinkle: mediawiki.api: Remove deprecated function parameters [core] - 10https://gerrit.wikimedia.org/r/118733 (owner: 10Bartosz Dziewoński) [00:07:48] (03PS1) 10Krinkle: Remove deprecated "jquery.json" module [core] - 10https://gerrit.wikimedia.org/r/161764 [00:08:05] (03PS16) 10Krinkle: mediawiki.api: Remove deprecated function parameters [core] - 10https://gerrit.wikimedia.org/r/118733 (owner: 10Bartosz Dziewoński) [00:08:23] (03PS2) 10Krinkle: Remove deprecated "jquery.json" module [core] - 10https://gerrit.wikimedia.org/r/161764 [00:18:33] (03CR) 10Krinkle: "Who is Mike Samuel? Why was he added?" [core] - 10https://gerrit.wikimedia.org/r/138908 (owner: 10PleaseStand) [00:20:43] 3MediaWiki / 3File management: File not generating thumbnails - 10https://bugzilla.wikimedia.org/71096 (10Chad H.) 3NEW p:3Unprio s:3normal a:3None https://commons.wikimedia.org/wiki/File:Teatro_Municipal_de_S%C3%A3o_Paulo_8.jpg is not generating thumbnails. The original file exists: https://upload.w... [00:22:12] (03PS3) 10Krinkle: CSSJanus: Add Apache license header [core] - 10https://gerrit.wikimedia.org/r/161761 (owner: 10PleaseStand) [00:25:37] 3MediaWiki / 3Redirects: Use history.replaceState to rewrite redirect urls - 10https://bugzilla.wikimedia.org/35045#c19 (10Daniel Friesen) (In reply to Matthias Becker from comment #18) > I consider resolving this bug IS a bug. For people who work with redirects, > as for example fixing them, moving pages an... [00:25:44] (03CR) 10Krinkle: [C: 031] CSSJanus: Add Apache license header [core] - 10https://gerrit.wikimedia.org/r/161761 (owner: 10PleaseStand) [00:26:04] (03CR) 10Catrope: [C: 031] CSSJanus: Add Apache license header [core] - 10https://gerrit.wikimedia.org/r/161761 (owner: 10PleaseStand) [00:28:33] (03CR) 10Jforrester: [C: 032] CSSJanus: Add Apache license header [core] - 10https://gerrit.wikimedia.org/r/161761 (owner: 10PleaseStand) [00:28:37] 3MediaWiki skins / 3Vector: h4, h5, and h6 headers should not have the same styling - 10https://bugzilla.wikimedia.org/70004#c2 (10Quiddity) Created attachment 16529 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16529&action=edit screenshot of the staff page and sandbox A screenshot of the Staff pa... [00:32:52] 3MediaWiki / 3Page editing: Collapse templates in editor - 10https://bugzilla.wikimedia.org/28684 (10James Forrester) s:5normal>3enhanc [00:34:52] (03Merged) 10jenkins-bot: CSSJanus: Add Apache license header [core] - 10https://gerrit.wikimedia.org/r/161761 (owner: 10PleaseStand) [00:57:23] 3MediaWiki / 3File management: File not generating thumbnails - 10https://bugzilla.wikimedia.org/71096#c1 (10Bawolff (Brian Wolff)) Probably a progressive jpg that is too big. Resaving as baseline jpg will probably fix. For reference, 137 = Out of memory. [01:13:55] 3MediaWiki-Vagrant / 3labs-vagrant: labs-vagrant provision fails on existing instance - 10https://bugzilla.wikimedia.org/71093#c1 (10Yuri Astrakhan) Updated info: just built a new instance: created instance, added vagrant-labs role, waited until it was done, and did a labs-vagrant provision. The first provis... [01:43:24] (03CR) 10Krinkle: Use event binding from a module instead of inline javascript (032 comments) [extensions/CharInsert] - 10https://gerrit.wikimedia.org/r/152076 (https://bugzilla.wikimedia.org/9424) (owner: 10Helder.wiki) [01:43:28] (03CR) 10Krinkle: [C: 04-1] Use event binding from a module instead of inline javascript [extensions/CharInsert] - 10https://gerrit.wikimedia.org/r/152076 (https://bugzilla.wikimedia.org/9424) (owner: 10Helder.wiki) [01:45:54] (03CR) 10Krinkle: [C: 04-1] Use
instead of for action menu (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/154453 (https://bugzilla.wikimedia.org/42241) (owner: 10Gerrit Patch Uploader) [01:49:34] (03PS3) 10Krinkle: Postpone autoHide timer of notifications if window is not focused [core] - 10https://gerrit.wikimedia.org/r/154227 (https://bugzilla.wikimedia.org/40322) (owner: 10Helder.wiki) [01:49:59] (03PS4) 10Krinkle: mediawiki.notification: Postpone autoHide timer if window is unfocused [core] - 10https://gerrit.wikimedia.org/r/154227 (https://bugzilla.wikimedia.org/40322) (owner: 10Helder.wiki) [01:50:06] 3MediaWiki / 3File management: File not generating thumbnails - 10https://bugzilla.wikimedia.org/71096#c2 (10Bawolff (Brian Wolff)) 5NEW>3RESO/FIX losslessly converted (At least I think its lossless) using jpegtran -optimize -copy all -outfile out.jpg Teatro_Municipal_de_São_Paulo_8.jpg [01:50:31] (03PS3) 10Krinkle: Remove usage of deprecated Xml::escapeJsString [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/147712 (owner: 10PleaseStand) [01:52:29] (03CR) 10Krinkle: [C: 032] Remove usage of deprecated Xml::escapeJsString [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/147712 (owner: 10PleaseStand) [01:53:17] (03Merged) 10jenkins-bot: Remove usage of deprecated Xml::escapeJsString [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/147712 (owner: 10PleaseStand) [01:54:45] (03PS6) 10Krinkle: Add window close warning to Special:Upload [core] - 10https://gerrit.wikimedia.org/r/151140 (owner: 10MarkTraceur) [01:54:53] (03PS11) 10Krinkle: Move confirmCloseWindow to core [core] - 10https://gerrit.wikimedia.org/r/151128 (owner: 10MarkTraceur) [01:56:04] (03CR) 10Krinkle: [C: 04-1] "#wpTextbox1 and #wpSummary are each being queries three times from the DOM. Please cache or re-use these." [core] - 10https://gerrit.wikimedia.org/r/151128 (owner: 10MarkTraceur) [02:08:18] (03CR) 10Krinkle: [C: 04-1] Move confirmCloseWindow to core (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151127 (owner: 10MarkTraceur) [02:08:52] 3Wikimedia / 3Site requests: Account creation exemption lift - 10https://bugzilla.wikimedia.org/71090#c8 (10James Heilman) We start in 20 minutes. Has this been carried out yet? J [02:10:01] (03CR) 10Krinkle: "The file should be in resources/src/mediawiki/ or resources/src/mediawiki.toolbar/ depending on whether there are other associated files." [core] - 10https://gerrit.wikimedia.org/r/156229 (owner: 10Helder.wiki) [02:14:07] 3Wikimedia / 3Site requests: Account creation exemption lift - 10https://bugzilla.wikimedia.org/71090#c9 (10Bawolff (Brian Wolff)) I don't see anything in gerrit for this bug. There is a patch being proposed for bug 70953 ( https://gerrit.wikimedia.org/r/#/c/161191/ ) but it has not been approved. I suggest... [02:19:37] 3Wikimedia / 3Site requests: Account creation exemption lift - 10https://bugzilla.wikimedia.org/71090#c10 (10James Heilman) I already have. How exactly does one get something approved? A RfC? J [02:23:07] 3Wikimedia / 3Site requests: Account creation exemption lift - 10https://bugzilla.wikimedia.org/71090#c11 (10Bawolff (Brian Wolff)) Typically you should make sure someone has agreed to do it more than 20 minutes before the event, especially when event is on a saturday evening (I believe it is usually suggest... [02:32:53] (03PS1) 10Krinkle: [WIP] Restructure resources/ [core] - 10https://gerrit.wikimedia.org/r/161765 [02:36:07] 3MediaWiki extensions / 3ProofreadPage: phpunit: SKIPPED: djvu binaries do not exist or are not executable - 10https://bugzilla.wikimedia.org/68638#c10 (10George Orwell III) Some seven years later, http://sourceforge.net/p/djvu/bugs/71/ still manages to provide some background and a possible candidate. CC'... [02:39:48] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Restructure resources/ [core] - 10https://gerrit.wikimedia.org/r/161765 (owner: 10Krinkle) [02:42:23] 3Wikimedia / 3Site requests: Account creation exemption lift - 10https://bugzilla.wikimedia.org/71090#c13 (10Bawolff (Brian Wolff)) (In reply to Gerrit Notification Bot from comment #12) > Change 161766 had a related patch set uploaded by Brian Wolff: > Increase account creation throttle on enwiki for Cochra... [02:49:37] 3Wikimedia / 3Site requests: Account creation exemption lift - 10https://bugzilla.wikimedia.org/71090#c15 (10Bawolff (Brian Wolff)) 5PATC>3RESO/FIX Ori was kind enough to approve the throttle increase. Throttle limit should now be increased. [02:49:51] bawolff: thanks! [02:50:21] Thank you for deploying that [02:50:29] I was really expecting that guy would be out of luck [02:54:06] pretty reasonable expectation given the circumstances [02:54:37] 3MediaWiki extensions / 3ProofreadPage: phpunit: SKIPPED: djvu binaries do not exist or are not executable - 10https://bugzilla.wikimedia.org/68638#c11 (10Bawolff (Brian Wolff)) Can you tell me what the output of the following commands are: which ddjvu which djvudump which djvutoxml which djvutxt Additiona... [02:57:16] (03CR) 10He7d3r: Use event binding from a module instead of inline javascript (031 comment) [extensions/CharInsert] - 10https://gerrit.wikimedia.org/r/152076 (https://bugzilla.wikimedia.org/9424) (owner: 10Helder.wiki) [03:05:18] (03CR) 10Springle: [C: 031] Add Oracle version of update-keys.sql [core] - 10https://gerrit.wikimedia.org/r/161491 (https://bugzilla.wikimedia.org/71040) (owner: 10Brian Wolff) [03:07:32] (03PS1) 10Krinkle: Rename mediawiki.action.edit.toolbar to mediawiki.toolbar [core] - 10https://gerrit.wikimedia.org/r/161767 [03:07:34] (03PS1) 10Krinkle: EditPage: Prettify inline scripts for mw.toolbar in debug mode [core] - 10https://gerrit.wikimedia.org/r/161768 [03:08:46] (03PS3) 10Krinkle: findHooks.php, importSiteScripts.php: Use format=json [core] - 10https://gerrit.wikimedia.org/r/143028 (owner: 10PleaseStand) [03:10:01] (03CR) 10Krinkle: "This changes format=php to json, it implements query continuation, and abstracts it into a method." [core] - 10https://gerrit.wikimedia.org/r/143028 (owner: 10PleaseStand) [03:12:22] 3Wikimedia / 3Extension setup: Review and deploy ThrottleOverride extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/25000#c38 (10Ori Livneh) Needs security and performance review. I can do the latter. Chris, could you do the security review? [03:12:27] Carmela: ^ [03:12:40] the extension looks all right, at a glance [03:14:01] ori: Nice. [03:14:18] Hooks::register (!) [03:14:19] I'm not sure what happened with it... it had forward momentum a few times. [03:14:30] * bawolff has never seen anyone actually use the Hooks class. Ever [03:14:35] (03CR) 10jenkins-bot: [V: 04-1] Rename mediawiki.action.edit.toolbar to mediawiki.toolbar [core] - 10https://gerrit.wikimedia.org/r/161767 (owner: 10Krinkle) [03:15:28] csteipp had a kid two or three days ago [03:15:33] so it might take him a while [03:16:29] I don't like how the query does [03:16:32] 'thr_type' . $dbr->buildLike( $dbr->anyString(), $action, $dbr->anyString() ) [03:16:46] (03CR) 10Krinkle: "Hm... the same logic is on both, so nvm. Let's do this as it is." [core] - 10https://gerrit.wikimedia.org/r/143028 (owner: 10PleaseStand) [03:18:51] Oh its using mysql SET types, not just a string. I guess that's a bit better [03:21:52] 3MediaWiki extensions / 3ProofreadPage: phpunit: SKIPPED: djvu binaries do not exist or are not executable - 10https://bugzilla.wikimedia.org/68638#c12 (10George Orwell III) (In reply to Bawolff (Brian Wolff) from comment #11) > Can you tell me what the output of the following commands are: Whoa. Sorry if I... [03:22:04] (03CR) 10Krinkle: [C: 032] findHooks.php, importSiteScripts.php: Use format=json [core] - 10https://gerrit.wikimedia.org/r/143028 (owner: 10PleaseStand) [03:28:24] (03Merged) 10jenkins-bot: findHooks.php, importSiteScripts.php: Use format=json [core] - 10https://gerrit.wikimedia.org/r/143028 (owner: 10PleaseStand) [03:30:14] (03CR) 10Krinkle: [C: 04-1] "Where does $wgExtraSignatureNamespaces come from?" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/102076 (https://bugzilla.wikimedia.org/57727) (owner: 10TTO) [03:31:07] 3MediaWiki extensions / 3ProofreadPage: phpunit: SKIPPED: djvu binaries do not exist or are not executable - 10https://bugzilla.wikimedia.org/68638#c13 (10Bawolff (Brian Wolff)) (In reply to George Orwell III from comment #12) > (In reply to Bawolff (Brian Wolff) from comment #11) > > Can you tell me what th... [03:32:07] (03PS8) 10Krinkle: Replace hidesig module with a more robust implementation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/102076 (https://bugzilla.wikimedia.org/57727) (owner: 10TTO) [03:38:09] 3MediaWiki extensions / 3CirrusSearch: Search using insource and regex returns irregular and different set of articles each time - 10https://bugzilla.wikimedia.org/71098 (10SpontaneousGrumbler) 3UNCO p:3Unprio s:3normal a:3None On repeat runs of https://en.wikipedia.org/w/index.php?title=Special:Sear... [03:54:37] 3MediaWiki extensions / 3ProofreadPage: phpunit: SKIPPED: djvu binaries do not exist or are not executable - 10https://bugzilla.wikimedia.org/68638#c14 (10George Orwell III) All points well taken here & my local Windows nonsense is my problem (mentioning it was more so for illustrative purposes than anything... [04:01:22] 3Wikimedia / 3Extension setup: Review and deploy ThrottleOverride extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/25000#c39 (10Bawolff (Brian Wolff)) Some thoughts on this extension: I think there should be different types of rights for different throttles. I have no problem with an admin in... [04:01:37] 3MediaWiki extensions / 3ProofreadPage: phpunit: SKIPPED: djvu binaries do not exist or are not executable - 10https://bugzilla.wikimedia.org/68638#c15 (10George Orwell III) Created attachment 16530 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16530&action=edit short and simple djvu file with LINEs... [04:08:21] 3MediaWiki extensions / 3ProofreadPage: phpunit: SKIPPED: djvu binaries do not exist or are not executable - 10https://bugzilla.wikimedia.org/68638#c16 (10Bawolff (Brian Wolff)) (In reply to George Orwell III from comment #14) > > That said, it begs the question: Can one actually generate such an .xml > f... [04:30:52] 3MediaWiki extensions / 3ProofreadPage: Merge proofread text back into Djvu files - 10https://bugzilla.wikimedia.org/57807#c3 (10George Orwell III) Created attachment 16531 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16531&action=edit simple DjVu test file A simple .DjVu test file where the embed... [04:34:22] 3MediaWiki extensions / 3ProofreadPage: Merge proofread text back into Djvu files - 10https://bugzilla.wikimedia.org/57807#c4 (10George Orwell III) Created attachment 16532 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16532&action=edit resulting XML file Command line used to generate XML file C:\... [04:42:16] (03CR) 10TTO: "It comes from the dependent change mentioned in the commit message. I see that you noticed that :)" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/102076 (https://bugzilla.wikimedia.org/57727) (owner: 10TTO) [05:03:52] (03CR) 10Legoktm: [C: 032] jquery.confirmable: Add a space between buttons [core] - 10https://gerrit.wikimedia.org/r/160067 (owner: 10Bartosz Dziewoński) [05:04:00] (03PS1) 10Legoktm: jquery.confirmable: Add a space between buttons [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/161769 [05:04:06] (03CR) 10Legoktm: [C: 032] jquery.confirmable: Add a space between buttons [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/161769 (owner: 10Legoktm) [05:10:40] (03Merged) 10jenkins-bot: jquery.confirmable: Add a space between buttons [core] - 10https://gerrit.wikimedia.org/r/160067 (owner: 10Bartosz Dziewoński) [05:11:14] (03Merged) 10jenkins-bot: jquery.confirmable: Add a space between buttons [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/161769 (owner: 10Legoktm) [05:12:13] (03CR) 10Legoktm: [C: 032] Remove unused JS checkbox code [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/161695 (owner: 10Bartosz Dziewoński) [05:12:17] (03CR) 10Legoktm: [C: 032] HTMLFeatureFieldTest: Set $wgWellFormedXml = true [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/161693 (https://bugzilla.wikimedia.org/68823) (owner: 10Bartosz Dziewoński) [05:12:24] (03Merged) 10jenkins-bot: Remove unused JS checkbox code [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/161695 (owner: 10Bartosz Dziewoński) [05:12:29] (03Merged) 10jenkins-bot: HTMLFeatureFieldTest: Set $wgWellFormedXml = true [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/161693 (https://bugzilla.wikimedia.org/68823) (owner: 10Bartosz Dziewoński) [05:13:24] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: HTMLFeatureFieldTest should set $wgWellFormedXml - 10https://bugzilla.wikimedia.org/68823 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3Bartosz Dziewoński [05:16:22] 3MediaWiki extensions / 3ProofreadPage: Merge proofread text back into Djvu files - 10https://bugzilla.wikimedia.org/57807#c5 (10George Orwell III) (In reply to vladjohn2013 from comment #0) > Merge proofread text back into Djvu files > > . . . The idea is to create an > export tool that will get word posit... [05:17:30] (03CR) 10Legoktm: [C: 032] "I assume you'll add release notes for this :)" [core] - 10https://gerrit.wikimedia.org/r/159290 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [05:17:41] (03PS1) 10Legoktm: Move default logo to resources/assets/ directory [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/161770 (https://bugzilla.wikimedia.org/69277) [05:18:05] (03CR) 10Legoktm: [C: 032] Move default logo to resources/assets/ directory [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/161770 (https://bugzilla.wikimedia.org/69277) (owner: 10Legoktm) [05:23:56] (03Merged) 10jenkins-bot: Move default logo to resources/assets/ directory [core] - 10https://gerrit.wikimedia.org/r/159290 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [05:24:57] (03Merged) 10jenkins-bot: Move default logo to resources/assets/ directory [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/161770 (https://bugzilla.wikimedia.org/69277) (owner: 10Legoktm) [05:25:43] https://github.com/wikimedia/mediawiki-core/tree/master/skins/common :D [05:25:46] nearly there! [05:27:08] 3MediaWiki extensions / 3ProofreadPage: phpunit: SKIPPED: djvu binaries do not exist or are not executable - 10https://bugzilla.wikimedia.org/68638#c17 (10George Orwell III) Understood and thank you for your input. Apologies again to Nemo for the unintended trolling. If anyone is still interested, please se... [05:47:23] 3MediaWiki / 3Interface: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277#c67 (10James Forrester) 5PATC>3ASSI Still a few files left to go… [05:49:17] (03CR) 10Jforrester: "I like this direction." [core] - 10https://gerrit.wikimedia.org/r/161765 (owner: 10Krinkle) [07:19:53] 3MediaWiki extensions / 3Scribunto: Count of arrays from LuaSandbox incorrect under HHVM - 10https://bugzilla.wikimedia.org/71061#c3 (10Ori Livneh) I think it has to do with ArrayData::m_size being a uint32_t but getting initialized to -1 in hphp/runtime/base/proxy-array.cpp:67. [08:00:02] (03PS4) 10Amire80: Bidi-isolate extension version on Special:Version [core] - 10https://gerrit.wikimedia.org/r/147733 [08:08:53] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: Settings pane looks ugly with JavaScript disabled - 10https://bugzilla.wikimedia.org/69778#c4 (10Seb35) Thanks a lot! From ugly without JS, it is now as beautiful as with JS. [08:37:23] (03PS14) 10Bartosz Dziewoński: mediawiki.user: Remove deprecated name() and anonymous() methods [core] - 10https://gerrit.wikimedia.org/r/111422 (owner: 10Ori.livneh) [08:38:56] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Krinkle, I don't think your changes to RELEASE-NOTES-1.25 were intentional? Also, comments from PS12 need addressing." [core] - 10https://gerrit.wikimedia.org/r/118733 (owner: 10Bartosz Dziewoński) [08:45:13] (03PS17) 10Bartosz Dziewoński: mediawiki.api: Remove deprecated function parameters [core] - 10https://gerrit.wikimedia.org/r/118733 [08:56:21] (03CR) 10Nikerabbit: [C: 032] Unset redirect param in MoveLogFormatter::getMessageParameters [core] - 10https://gerrit.wikimedia.org/r/152011 (owner: 10Umherirrender) [08:57:32] (03PS18) 10Bartosz Dziewoński: mediawiki.api: Remove deprecated function parameters [core] - 10https://gerrit.wikimedia.org/r/118733 [08:57:39] (03CR) 10Bartosz Dziewoński: mediawiki.api: Remove deprecated function parameters (032 comments) [core] - 10https://gerrit.wikimedia.org/r/118733 (owner: 10Bartosz Dziewoński) [08:58:19] (03CR) 10Bartosz Dziewoński: "PS18 addresses comments from PS12. Please re-review." [core] - 10https://gerrit.wikimedia.org/r/118733 (owner: 10Bartosz Dziewoński) [08:58:36] (03PS3) 10Bartosz Dziewoński: Remove deprecated "jquery.json" module [core] - 10https://gerrit.wikimedia.org/r/161764 (owner: 10Krinkle) [09:00:00] (03CR) 10Nikerabbit: [C: 031] "Code looks okay, but didn't have time to test yet." [core] - 10https://gerrit.wikimedia.org/r/152161 (owner: 10Umherirrender) [09:03:11] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I don't think this is worth the effort and the mess in the code. We can pull this out of the inline script and into proper module code now" [core] - 10https://gerrit.wikimedia.org/r/161768 (owner: 10Krinkle) [09:03:16] (03Merged) 10jenkins-bot: Unset redirect param in MoveLogFormatter::getMessageParameters [core] - 10https://gerrit.wikimedia.org/r/152011 (owner: 10Umherirrender) [09:04:08] (03CR) 10Nikerabbit: "Generally, doing fallbacks when there is logic involved is not a good idea unless we can ensure correct data matches correct logic." [core] - 10https://gerrit.wikimedia.org/r/157180 (https://bugzilla.wikimedia.org/58139) (owner: 10Legoktm) [09:06:21] (03CR) 10Bartosz Dziewoński: [C: 04-1] "JSDuck config needs updating, looks sane otherwise." [core] - 10https://gerrit.wikimedia.org/r/161767 (owner: 10Krinkle) [09:08:39] (03CR) 10Bartosz Dziewoński: "https://gerrit.wikimedia.org/r/#/c/161767/ reimplements a part of this. It does't prevent loading of the toolbar code if "showtoolbar" is " [core] - 10https://gerrit.wikimedia.org/r/156229 (owner: 10Helder.wiki) [09:09:26] (03PS2) 10Bartosz Dziewoński: Rename mediawiki.action.edit.toolbar to mediawiki.toolbar, split toolbar code from mediawiki.action.edit [core] - 10https://gerrit.wikimedia.org/r/161767 (owner: 10Krinkle) [09:10:59] (03CR) 10Fomafix: [C: 031] mediawiki.api: Remove deprecated function parameters [core] - 10https://gerrit.wikimedia.org/r/118733 (owner: 10Bartosz Dziewoński) [09:11:40] (03CR) 10Bartosz Dziewoński: Use event binding from a module instead of inline javascript (031 comment) [extensions/CharInsert] - 10https://gerrit.wikimedia.org/r/152076 (https://bugzilla.wikimedia.org/9424) (owner: 10Helder.wiki) [09:14:48] (03CR) 10Fomafix: [C: 031] mediawiki.user: Remove deprecated name() and anonymous() methods [core] - 10https://gerrit.wikimedia.org/r/111422 (owner: 10Ori.livneh) [09:16:07] (03CR) 10jenkins-bot: [V: 04-1] Rename mediawiki.action.edit.toolbar to mediawiki.toolbar, split toolbar code from mediawiki.action.edit [core] - 10https://gerrit.wikimedia.org/r/161767 (owner: 10Krinkle) [09:19:07] (03PS3) 10Nikerabbit: Copy translations of Special:MyLanguage alias from Translate [core] - 10https://gerrit.wikimedia.org/r/161377 (https://bugzilla.wikimedia.org/69461) (owner: 10Amire80) [09:21:37] (03CR) 10Nikerabbit: [C: 032] Copy translations of Special:MyLanguage alias from Translate [core] - 10https://gerrit.wikimedia.org/r/161377 (https://bugzilla.wikimedia.org/69461) (owner: 10Amire80) [09:22:03] (03PS1) 10Nikerabbit: Copy translations of Special:MyLanguage alias from Translate [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/161773 (https://bugzilla.wikimedia.org/69461) [09:23:22] (03PS1) 10Nikerabbit: Fix typo in release notes [core] - 10https://gerrit.wikimedia.org/r/161774 [09:23:50] (03PS1) 10Nikerabbit: Fix typo in release notes [core] - 10https://gerrit.wikimedia.org/r/161775 [09:24:53] (03PS1) 10Nikerabbit: Fix typo in release notes [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/161776 [09:25:45] (03Abandoned) 10Nikerabbit: Fix typo in release notes [core] - 10https://gerrit.wikimedia.org/r/161775 (owner: 10Nikerabbit) [09:28:43] (03Merged) 10jenkins-bot: Copy translations of Special:MyLanguage alias from Translate [core] - 10https://gerrit.wikimedia.org/r/161377 (https://bugzilla.wikimedia.org/69461) (owner: 10Amire80) [09:32:33] (03PS7) 10Nikerabbit: mediawiki.api: Support assert parameter in getToken and postWithToken [core] - 10https://gerrit.wikimedia.org/r/156093 [09:48:31] (03CR) 10MaxSem: [C: 032] Copy translations of Special:MyLanguage alias from Translate [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/161773 (https://bugzilla.wikimedia.org/69461) (owner: 10Nikerabbit) [09:49:00] (03CR) 10MaxSem: [C: 032] Fix typo in release notes [core] - 10https://gerrit.wikimedia.org/r/161774 (owner: 10Nikerabbit) [09:49:38] (03CR) 10MaxSem: [C: 032] Fix typo in release notes [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/161776 (owner: 10Nikerabbit) [09:55:09] (03Merged) 10jenkins-bot: Copy translations of Special:MyLanguage alias from Translate [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/161773 (https://bugzilla.wikimedia.org/69461) (owner: 10Nikerabbit) [09:55:55] (03Merged) 10jenkins-bot: Fix typo in release notes [core] - 10https://gerrit.wikimedia.org/r/161774 (owner: 10Nikerabbit) [09:56:15] (03Merged) 10jenkins-bot: Fix typo in release notes [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/161776 (owner: 10Nikerabbit) [09:57:03] (03CR) 10Liangent: "Unit testing this is not quite easy, particularly because of the direct require __DIR__ . "/../../includes/ZhConversion.php";" [core] - 10https://gerrit.wikimedia.org/r/158366 (owner: 10Liangent) [09:58:44] (03PS2) 10Liangent: Change loading order of Chinese conversion tables [core] - 10https://gerrit.wikimedia.org/r/158366 [10:03:54] 3MediaWiki extensions / 3WikidataRepo: wbformatvalue called twice when creating statement - 10https://bugzilla.wikimedia.org/71100 (10Bene*) 3NEW p:3Unprio s:3normal a:3Wikidata bugs When creating a statement through the Wikidata ui the wbformatvalue api gets called twice with exactly the same parame... [10:05:07] 3MediaWiki extensions / 3WikidataRepo: wbformatvalue called twice when creating statement - 10https://bugzilla.wikimedia.org/71100#c1 (10Bene*) Created attachment 16533 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16533&action=edit Screenshot of Firebug console [10:17:51] 3MediaWiki / 3ResourceLoader: [Regression] Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c29 (10Bartosz Dziewoński) 5ASSI>3RESO/FIX It wasn't backported in the end :( The fix will roll out with 1.24wmf22. [12:16:23] 3Wikimedia / 3Site requests: please add *.beeldbank.cultureelerfgoed.nl to the wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/70840 (10Andre Klapper) [12:16:38] 3Wikimedia / 3Site requests: Add domains to $wgCopyUploadsDomains (tracking) - 10https://bugzilla.wikimedia.org/58224 (10Andre Klapper) [12:51:22] (03CR) 10Bartosz Dziewoński: "So... we're not doing this?" [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/150622 (https://bugzilla.wikimedia.org/52509) (owner: 10Reedy) [13:15:38] (03CR) 10Chiefwei: [C: 031] "The conversion priority was modified in order to improve reading exprience for different Chinese varients." [core] - 10https://gerrit.wikimedia.org/r/158366 (owner: 10Liangent) [13:18:15] (03CR) 10He7d3r: "What is the recommended way to set a common handler for all api requests analogous to the following use of the ok/err in the ajax paramete" [core] - 10https://gerrit.wikimedia.org/r/118733 (owner: 10Bartosz Dziewoński) [13:29:50] (03CR) 10Bartosz Dziewoński: Rename mediawiki.action.edit.toolbar to mediawiki.toolbar, split toolbar code from mediawiki.action.edit (031 comment) [core] - 10https://gerrit.wikimedia.org/r/161767 (owner: 10Krinkle) [13:31:38] (03PS1) 10Bartosz Dziewoński: mediawiki.toolbar: Move documentation closer to code [core] - 10https://gerrit.wikimedia.org/r/161780 [13:31:40] (03PS1) 10Bartosz Dziewoński: mediawiki.toolbar: Properly deprecate #init [core] - 10https://gerrit.wikimedia.org/r/161781 [13:38:32] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.toolbar: Move documentation closer to code [core] - 10https://gerrit.wikimedia.org/r/161780 (owner: 10Bartosz Dziewoński) [13:38:58] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.toolbar: Properly deprecate #init [core] - 10https://gerrit.wikimedia.org/r/161781 (owner: 10Bartosz Dziewoński) [13:46:30] How to float infoboxes throught wiki in a 1.23 new install? CSS was easy, but no clue where to add infobox global styling using LESS? [13:46:49] semanticc: Just use CSS [13:48:15] hoo: Thanks but Wiki switched to LESS as of 1.22 and I don't want to screw up something. [13:48:44] then convert your less into CSS and apply that [13:49:33] I tried that using online auto conveerters but they return errors saying unable to resolve external links in LESS files... [14:05:09] 3MediaWiki / 3General/Unknown: author name with special character causes problem in Special:Version - 10https://bugzilla.wikimedia.org/71063#c3 (10Dr Brains) By "crash", I mean that all the HTML after the UniversalLanguageSelector "authors" cell (including footer and all the page end) is considered as text a... [14:13:22] 3MediaWiki / 3General/Unknown: author name with special character causes problem in Special:Version - 10https://bugzilla.wikimedia.org/71063#c4 (10Dr Brains) Oups... i continue ... above the "installed extensions" section, the sidebar, action and personnal tabs are also misplaced. There is no "fatal error"... [14:35:26] 3MediaWiki extensions / 3CirrusSearch: Cirrus misses many JS pages on some searches (Lucene finds them) - 10https://bugzilla.wikimedia.org/71101 (10Helder) 3NEW p:3Unprio s:3normal a:3None Here is another regression I noticed when searching for things in JS pages: Searching for "Tools/APC" on MediaW... [14:35:40] 3MediaWiki extensions / 3CirrusSearch: Cirrus finds no results but Lucene finds 500+ (when searching outside main namespace) - 10https://bugzilla.wikimedia.org/68920 (10Helder) [14:35:40] 3MediaWiki extensions / 3CirrusSearch: Cirrus misses many JS pages on some searches (Lucene finds them) - 10https://bugzilla.wikimedia.org/71101 (10Helder) [14:36:52] anyone with access to mwgrep around? [14:37:00] sure [14:38:51] (03PS1) 10Jack Phoenix: Use one tab instead of four spaces for indentation in English (en) JSON i18n files [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/161782 [14:39:31] (03CR) 10Jack Phoenix: [C: 032] Use one tab instead of four spaces for indentation in English (en) JSON i18n files [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/161782 (owner: 10Jack Phoenix) [14:40:11] (03CR) 10Jack Phoenix: [V: 032] Use one tab instead of four spaces for indentation in English (en) JSON i18n files [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/161782 (owner: 10Jack Phoenix) [15:19:58] (03PS1) 10Jack Phoenix: General cleanup [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/161785 [15:20:52] (03CR) 10Fomafix: "You can use 'success' instead of 'ok':" [core] - 10https://gerrit.wikimedia.org/r/118733 (owner: 10Bartosz Dziewoński) [15:34:27] (03PS1) 10Jack Phoenix: Hacky "threshold" support for user profiles as a cheap anti-spam measure [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/161786 [15:36:35] (03CR) 10Jack Phoenix: [C: 032] Hacky "threshold" support for user profiles as a cheap anti-spam measure [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/161786 (owner: 10Jack Phoenix) [15:36:41] (03Merged) 10jenkins-bot: Hacky "threshold" support for user profiles as a cheap anti-spam measure [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/161786 (owner: 10Jack Phoenix) [15:53:43] (03PS1) 10Jack Phoenix: Removing legacy (PHP) i18n support, as pre-1.23 MediaWikis aren't supported by SocialProfile anymore [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/161788 [15:54:05] (03CR) 10Jack Phoenix: [C: 032] Removing legacy (PHP) i18n support, as pre-1.23 MediaWikis aren't supported by SocialProfile anymore [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/161788 (owner: 10Jack Phoenix) [15:54:11] (03Merged) 10jenkins-bot: Removing legacy (PHP) i18n support, as pre-1.23 MediaWikis aren't supported by SocialProfile anymore [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/161788 (owner: 10Jack Phoenix) [16:01:15] (03PS1) 10Jack Phoenix: Since $wgSpecialPageGroups has been deprecated since MW 1.21, group the special pages under the correct headers using the modern, recommended way [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/161789 [16:02:04] (03CR) 10Jack Phoenix: [C: 032] Since $wgSpecialPageGroups has been deprecated since MW 1.21, group the special pages under the correct headers using the modern, recommende [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/161789 (owner: 10Jack Phoenix) [16:02:10] (03Merged) 10jenkins-bot: Since $wgSpecialPageGroups has been deprecated since MW 1.21, group the special pages under the correct headers using the modern, recommended way [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/161789 (owner: 10Jack Phoenix) [16:12:19] (03PS1) 10Jack Phoenix: Use addModuleStyles() for loading CSS to avoid a Flash of Unstyled Content [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/161790 [16:12:35] (03CR) 10Jack Phoenix: [C: 032] Use addModuleStyles() for loading CSS to avoid a Flash of Unstyled Content [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/161790 (owner: 10Jack Phoenix) [16:12:41] (03Merged) 10jenkins-bot: Use addModuleStyles() for loading CSS to avoid a Flash of Unstyled Content [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/161790 (owner: 10Jack Phoenix) [16:23:12] (03PS1) 10Jack Phoenix: s/four spaces/one tab/g in every (non-en) i18n JSON file [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/161791 [16:25:42] (03CR) 10Jack Phoenix: [C: 032] s/four spaces/one tab/g in every (non-en) i18n JSON file [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/161791 (owner: 10Jack Phoenix) [16:35:49] (03PS1) 10Jack Phoenix: Removing a bunch of PHP i18n files I forgot in a previous commit [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/161792 [16:36:10] (03CR) 10Jack Phoenix: [C: 032] Removing a bunch of PHP i18n files I forgot in a previous commit [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/161792 (owner: 10Jack Phoenix) [16:36:15] (03Merged) 10jenkins-bot: Removing a bunch of PHP i18n files I forgot in a previous commit [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/161792 (owner: 10Jack Phoenix) [16:37:39] 3Wikimedia / 3Site requests: Remove namespace alias on ckb wikipedia - 10https://bugzilla.wikimedia.org/70564#c2 (10Glaisher) Scheduled for Monday's SWAT [16:38:53] 3Wikimedia / 3Site requests: please add *.beeldbank.cultureelerfgoed.nl to the wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/70840#c2 (10Glaisher) Scheduled for Monday's SWAT [16:40:45] (03PS1) 10Jack Phoenix: Removing last instances of $wgSpecialPageGroups [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/161793 [16:41:27] (03CR) 10Jack Phoenix: [C: 032] Removing last instances of $wgSpecialPageGroups [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/161793 (owner: 10Jack Phoenix) [16:41:33] (03Merged) 10jenkins-bot: Removing last instances of $wgSpecialPageGroups [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/161793 (owner: 10Jack Phoenix) [16:41:53] 3Wikimedia / 3Site requests: Remove namespace alias on ckb wikipedia - 10https://bugzilla.wikimedia.org/70564#c3 (10Calak) Thanks a lot. [16:47:14] (03PS1) 10Jack Phoenix: Removing PHP i18n file [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/161794 [16:47:35] (03CR) 10Jack Phoenix: [C: 032 V: 032] Removing PHP i18n file [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/161794 (owner: 10Jack Phoenix) [16:54:46] (03PS1) 10Jack Phoenix: Modernization [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/161795 [16:54:59] (03CR) 10Jack Phoenix: [C: 032] Modernization [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/161795 (owner: 10Jack Phoenix) [16:55:05] (03Merged) 10jenkins-bot: Modernization [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/161795 (owner: 10Jack Phoenix) [17:01:00] (03PS1) 10Jack Phoenix: Ran stylize.php, manually fixed documentation, etc. [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/161796 [17:01:12] (03CR) 10Jack Phoenix: [C: 032] Ran stylize.php, manually fixed documentation, etc. [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/161796 (owner: 10Jack Phoenix) [17:01:18] (03Merged) 10jenkins-bot: Ran stylize.php, manually fixed documentation, etc. [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/161796 (owner: 10Jack Phoenix) [17:03:59] (03PS1) 10Jack Phoenix: Use wgExtensionAssetsPath + mw.config.get() in the JS file [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/161797 [17:04:15] (03CR) 10Jack Phoenix: [C: 032] Use wgExtensionAssetsPath + mw.config.get() in the JS file [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/161797 (owner: 10Jack Phoenix) [17:04:21] (03Merged) 10jenkins-bot: Use wgExtensionAssetsPath + mw.config.get() in the JS file [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/161797 (owner: 10Jack Phoenix) [17:06:51] (03PS1) 10Jack Phoenix: s/four spaces/one tab/g [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/161798 [17:07:03] (03CR) 10Jack Phoenix: [C: 032] s/four spaces/one tab/g [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/161798 (owner: 10Jack Phoenix) [17:07:09] (03Merged) 10jenkins-bot: s/four spaces/one tab/g [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/161798 (owner: 10Jack Phoenix) [17:10:06] (03PS1) 10Jack Phoenix: Removed old PHP i18n file, got rid of $wgSpecialPageGroups & $dir [extensions/Comments] - 10https://gerrit.wikimedia.org/r/161799 [17:10:18] (03CR) 10Jack Phoenix: [C: 032] Removed old PHP i18n file, got rid of $wgSpecialPageGroups & $dir [extensions/Comments] - 10https://gerrit.wikimedia.org/r/161799 (owner: 10Jack Phoenix) [17:10:54] (03CR) 10Jack Phoenix: [V: 032] Removed old PHP i18n file, got rid of $wgSpecialPageGroups & $dir [extensions/Comments] - 10https://gerrit.wikimedia.org/r/161799 (owner: 10Jack Phoenix) [17:18:38] 3MediaWiki / 3General/Unknown: author name with special character causes problem in Special:Version - 10https://bugzilla.wikimedia.org/71063#c5 (10Bawolff (Brian Wolff)) Bugzilla isn't really meant as a support forum... There seems to be quite a few things screwed up with your wiki (Although looking at the p... [17:21:11] (03PS1) 10Jack Phoenix: Ran stylize.php and manually fixed function documentation [extensions/Comments] - 10https://gerrit.wikimedia.org/r/161800 [17:22:40] (03CR) 10Jack Phoenix: [C: 032] Ran stylize.php and manually fixed function documentation [extensions/Comments] - 10https://gerrit.wikimedia.org/r/161800 (owner: 10Jack Phoenix) [17:22:47] (03Merged) 10jenkins-bot: Ran stylize.php and manually fixed function documentation [extensions/Comments] - 10https://gerrit.wikimedia.org/r/161800 (owner: 10Jack Phoenix) [17:24:37] (03PS1) 10Jack Phoenix: Split CSS and JS into their own ResourceLoader modules [extensions/Comments] - 10https://gerrit.wikimedia.org/r/161801 [17:24:50] (03CR) 10Jack Phoenix: [C: 032] Split CSS and JS into their own ResourceLoader modules [extensions/Comments] - 10https://gerrit.wikimedia.org/r/161801 (owner: 10Jack Phoenix) [17:24:56] (03Merged) 10jenkins-bot: Split CSS and JS into their own ResourceLoader modules [extensions/Comments] - 10https://gerrit.wikimedia.org/r/161801 (owner: 10Jack Phoenix) [17:45:39] 3MediaWiki / 3Interface: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277#c68 (10Waldir) (In reply to James Forrester from comment #67) > Still a few files left to go… Link for convenience: http://git.wikimedia.org/tree/mediawiki... [18:00:26] 3MediaWiki extensions / 3StopForumSpam: StopForumSpam: Implement tagging of edits by IPs that were in the blacklist, but didn't meet the threshold - 10https://bugzilla.wikimedia.org/71102 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3enhanc a:3None Right now we just discard any IPs that didn't meet the... [18:42:56] (03PS1) 10Gerrit Patch Uploader: mediawiki.api.edit: Remove format: 'json' [core] - 10https://gerrit.wikimedia.org/r/161805 [18:42:58] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/161805 (owner: 10Gerrit Patch Uploader) [18:45:36] earth to bd808|BUFFER :) [18:47:27] (03CR) 10PleaseStand: [C: 04-1] Allow logged-in users to view and use the login form (031 comment) [core] - 10https://gerrit.wikimedia.org/r/161465 (https://bugzilla.wikimedia.org/70855) (owner: 10Bartosz Dziewoński) [18:47:36] (03PS2) 10Bartosz Dziewoński: mediawiki.api.edit: Remove "format: 'json'" [core] - 10https://gerrit.wikimedia.org/r/161805 (owner: 10Gerrit Patch Uploader) [18:47:41] (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.api.edit: Remove "format: 'json'" [core] - 10https://gerrit.wikimedia.org/r/161805 (owner: 10Gerrit Patch Uploader) [18:54:40] (03Merged) 10jenkins-bot: mediawiki.api.edit: Remove "format: 'json'" [core] - 10https://gerrit.wikimedia.org/r/161805 (owner: 10Gerrit Patch Uploader) [18:55:37] (03PS1) 10Nischayn22: Remove usage of innerHTML [extensions/RecentActivityFeed] - 10https://gerrit.wikimedia.org/r/161807 [18:57:38] 3MediaWiki extensions / 3RecentActivityFeed: Security review of RecentActivityFeed - 10https://bugzilla.wikimedia.org/69798#c2 (10Nischay Nahata) https://gerrit.wikimedia.org/r/#/c/161807/ Addresses point 1 More yet to come. [19:20:24] 3MediaWiki extensions / 3RecentActivityFeed: Security review of RecentActivityFeed - 10https://bugzilla.wikimedia.org/69798#c3 (10Nischay Nahata) Chris, Can you explain the points you made regarding escaping? This extension really just outputs data from the DB with no user input except a few options which sh... [20:39:31] (03CR) 10Florianschmidtwelzow: "@Alex Monk: Can you review this patch or do you know, who can? :)" [extensions/OnlineStatus] - 10https://gerrit.wikimedia.org/r/150154 (https://bugzilla.wikimedia.org/68750) (owner: 10Florianschmidtwelzow) [20:47:05] (03Abandoned) 10Florianschmidtwelzow: Use Parser::replaceVariables instead of Parser::strip [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/153355 (https://bugzilla.wikimedia.org/69378) (owner: 10Florianschmidtwelzow) [20:48:22] 3MediaWiki / 3General/Unknown: author name with special character causes problem in Special:Version - 10https://bugzilla.wikimedia.org/71063#c6 (10Andre Klapper) 5UNCO>3RESO/INV So far the problems do not look like problems in the codebase to me (plus I cannot see any issues with character enconding anym... [20:49:11] 3Wikimedia / 3Bugzilla: Missing "Graph" extension in bugzilla list - 10https://bugzilla.wikimedia.org/71103 (10Yuri Astrakhan) 3NEW p:3Unprio s:3normal a:3None Unable to report bugs related to "Graph" extension in bugzilla [20:57:23] 3MediaWiki / 3Templates: REVISIONID cannot be substituted - 10https://bugzilla.wikimedia.org/6181#c14 (10GregH) Well, so much for "the fabric of the universe" meaning there was "no possible way" to fix this bug. [20:59:38] 3MediaWiki extensions / 3WikidataRepo: use checkboxes for badge selection on Special:SetSitelinks - 10https://bugzilla.wikimedia.org/70333 (10Bene*) 5PATC>3RESO/FIX [20:59:50] (03CR) 10Brian Wolff: Make $file->getLength() return duration of GIF and APNG files. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/160304 (owner: 10Brian Wolff) [21:03:08] 3MediaWiki extensions / 3GlobalUserPage: GlobalUserPage: Improve border around footer - 10https://bugzilla.wikimedia.org/70629#c1 (10Quiddity) Note: Support for the footer was added in bug 66931 and https://gerrit.wikimedia.org/r/158605 The reason I chose #aaa as the border color in the mockup suggested the... [21:24:37] (03CR) 10PleaseStand: "Hmm... SpecialRecentChanges doesn't seem to have these seek() calls. Are they even necessary?" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/161582 (owner: 10Umherirrender) [21:25:37] 3Wikimedia / 3Bugzilla: Missing "Graph" extension in bugzilla list - 10https://bugzilla.wikimedia.org/71103#c1 (10Andre Klapper) In case this is a request to create such a component, see https://www.mediawiki.org/wiki/Bug_management/Project_Maintainers#To_add_a_project_or_component for required information. [21:27:07] 3MediaWiki / 3API: ApiQueryAllUsers with auactiveusers fails on duplicate querycachetwo rows - 10https://bugzilla.wikimedia.org/71086 (10Andre Klapper) p:5Unprio>3High [21:27:10] 3MediaWiki / 3Uploading: Uppercase picture extensions like .PNG are not allowed - 10https://bugzilla.wikimedia.org/66667 (10Andre Klapper) [21:31:04] 3MediaWiki / 3Email: Special:Emailuser can leak target's email address if SPF fails - 10https://bugzilla.wikimedia.org/71035 (10Andre Klapper) p:5Unprio>3High [21:31:08] 3MediaWiki / 3Page editing: Allow "suppressredirect" and "move-subpages" within userspace - 10https://bugzilla.wikimedia.org/69162#c4 (10Andre Klapper) I'm going to move this to the "MediaWiki" product as this requires code changes; patches welcome. [21:33:21] 3MediaWiki extensions / 3CentralNotice: CentralNotice reloads old translatable messages on form submit - 10https://bugzilla.wikimedia.org/70939#c3 (10Andre Klapper) (In reply to Kai Nissen from comment #2) > Most probably it is a translation sync issue. So somewhere between Language Engineering and Deployme... [21:33:53] 3MediaWiki extensions / 3GlobalUserPage: GlobalUserPage: Improve border around footer - 10https://bugzilla.wikimedia.org/70629#c2 (10Isarra) #aaa does tend to work a lot better when the background colour is also changed, yeah. By itself it stands out (on white) as much too harsh and dark. So yeah, do thatn... [21:33:56] 3MediaWiki / 3JavaScript: mediawiki.action.view.redirect.js: Not idempotent when used on double redirect (refreshing the page redirects the user elsewhere) - 10https://bugzilla.wikimedia.org/71002 (10Andre Klapper) p:5Unprio>3Low [21:34:07] 3MediaWiki / 3General/Unknown: Don't use the same 'ArticleView' poolcounter for anonymous and logged in users - 10https://bugzilla.wikimedia.org/71010 (10Andre Klapper) p:5Unprio>3Normal [21:34:22] 3MediaWiki extensions / 3Disambiguator: mw-disambig class should be added in special pages too - 10https://bugzilla.wikimedia.org/71012 (10Andre Klapper) p:5Unprio>3Low [21:34:37] 3MediaWiki / 3Interface: Local and global images should be distinguishable using a CSS class - 10https://bugzilla.wikimedia.org/71013 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc [21:34:53] 3MediaWiki / 3ResourceLoader: CSSMin: Don't generate double rules for IE < 8 when embedding SVG files - 10https://bugzilla.wikimedia.org/71003 (10Andre Klapper) p:5Unprio>3Low [21:35:52] (03PS1) 10Yurik: Keep debug flag while editing a page [core] - 10https://gerrit.wikimedia.org/r/161878 [21:40:52] 3MediaWiki / 3Templates: Non-included tables break parser - 10https://bugzilla.wikimedia.org/35476 (10Andre Klapper) p:5High>3Normal [21:42:22] 3MediaWiki / 3General/Unknown: Implement connection timeout in MediaWiki's Http class - 10https://bugzilla.wikimedia.org/47027#c5 (10Andre Klapper) https://gerrit.wikimedia.org/r/#/c/67095/ was merged ages ago. Is more work needed here, or can this be closed? [21:43:09] 3MediaWiki extensions / 3ConfirmEdit (CAPTCHA extension): The version of ConfirmEdit bundled with 1.20.0 is not compatible with 1.20.0 - 10https://bugzilla.wikimedia.org/42391#c4 (10Andre Klapper) 5NEW>3RESO/WOR I'm closing this as 1.20 is obsolete and unsupported now. Please add a comment if this is sti... [21:44:23] 3Wikimedia / 3Fundraising: foundationwiki making requests to "Unknown MySQL server host 'db1008.eqiad.wmnet'" - 10https://bugzilla.wikimedia.org/53975 (10Andre Klapper) p:5High>3Normal [21:47:59] (03Abandoned) 10PleaseStand: Restore recentchanges.rc_cur_time (breaks psql) [core] - 10https://gerrit.wikimedia.org/r/99068 (owner: 10saper) [21:49:37] 3MediaWiki extensions / 3LiquidThreads: LiquidThreads: Live preview of a reply doesn't work anymore - 10https://bugzilla.wikimedia.org/55463#c6 (10Andre Klapper) 5PATC>3NEW p:5High>3Normal https://gerrit.wikimedia.org/r/#/c/88619/ was merged ages ago. (In reply to Helder from comment #5) > Should we... [21:50:07] 3MediaWiki extensions / 3Extensions requests: Provide a way to create interactive 2D/3D timelines and infographics e.g. Java applets, AJAX, Flash - 10https://bugzilla.wikimedia.org/43616#c2 (10Andre Klapper) p:5High>3Low Obviously not high prio if nobody works on this... [21:52:07] 3Wikimedia / 3General/Unknown: Opening Commons Delinker command page on wiki sometimes returns HTTP 504: Gateway Timeout -- SQL query sometimes super slow - 10https://bugzilla.wikimedia.org/54122#c13 (10Andre Klapper) Is that still an issue experienced? [21:52:38] 3MediaWiki / 3Interface: Add css "onlyinprint" class to hide content from anything except print output - 10https://bugzilla.wikimedia.org/50750 (10Andre Klapper) p:5High>3Normal [21:53:43] (03PS2) 10Bartosz Dziewoński: Allow logged-in users to view and use the login form [core] - 10https://gerrit.wikimedia.org/r/161465 (https://bugzilla.wikimedia.org/70855) [21:54:02] (03CR) 10Bartosz Dziewoński: Allow logged-in users to view and use the login form (031 comment) [core] - 10https://gerrit.wikimedia.org/r/161465 (https://bugzilla.wikimedia.org/70855) (owner: 10Bartosz Dziewoński) [21:54:16] (03PS2) 10Yurik: Keep debug flag while editing a page [core] - 10https://gerrit.wikimedia.org/r/161878 [21:56:51] 3MediaWiki / 3General/Unknown: Redirect does not appear in browser history - 10https://bugzilla.wikimedia.org/70962#c7 (10Bartosz Dziewoński) (In reply to Waldir from comment #6) > Why not use pushState() rather than replaceState()? IIUC, that would rewrite > the url while only appending --not replacing-- th... [21:57:36] 3Wikimedia / 3Bugzilla: Missing "Graph" extension in bugzilla list - 10https://bugzilla.wikimedia.org/71103#c2 (10Yuri Astrakhan) Extension: https://www.mediawiki.org/wiki/Extension:Graph In production: zerowiki, colabwiki, metawiki, possibly more Subcomponent: extension Default CC: yurik@wikimedia.org [21:58:10] andre__, ^ :) [22:03:53] 3Wikimedia / 3Bugzilla: Missing "Graph" extension in bugzilla list - 10https://bugzilla.wikimedia.org/71103#c3 (10Andre Klapper) 5NEW>3RESO/FIX a:3Andre Klapper Created. https://www.mediawiki.org/wiki/Extension:Graph should be in https://www.mediawiki.org/wiki/Category:Extensions_used_on_Wikimedia th... [22:03:55] yurikR, ^ ^ :) [22:08:23] 3Wikimedia / 3Bugzilla: Missing "Graph" extension in bugzilla list - 10https://bugzilla.wikimedia.org/71103#c4 (10Yuri Astrakhan) Added {{OnWikimedia}} to ext page. Thanks! [22:08:44] (03CR) 10MZMcBride: "I'm fine with this change, even if it has the faint smell of . :-)" [core] - 10https://gerrit.wikimedia.org/r/161465 (https://bugzilla.wikimedia.org/70855) (owner: 10Bartosz Dziewoński) [22:11:07] 3Wikimedia / 3Extension setup: Review and deploy ThrottleOverride extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/25000#c40 (10MZMcBride) Taking a step back, my understanding is that the primary request here was to be solved by a quick MediaWiki extension, an extension being preferable to fur... [22:13:19] (03PS2) 10Legoktm: Get rid of the GadgetPageList class [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160199 [22:23:08] 3MediaWiki / 3Maintenance scripts: maintenance/importDump.php fails for wikidatawiki XML incremental dump files - 10https://bugzilla.wikimedia.org/70898#c2 (10wp mirror) To reproduce: 0) set up wiki farm using wikimedia method See 1) wri... [22:23:52] 3MediaWiki skins / 3Vector: h4, h5, and h6 headers should not have the same styling - 10https://bugzilla.wikimedia.org/70004#c3 (10Kunal Mehta (Legoktm)) (In reply to Quiddity from comment #1) > https://en.wikipedia.org/w/index.php?title=User:Quiddity/ > sandbox&oldid=626297051 https://en.wikipedia.org/w/i... [22:41:07] (03PS1) 10Jack Phoenix: Removed old PHP i18n file, no longer needed [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/161879 [22:41:20] (03CR) 10Jack Phoenix: [C: 032 V: 032] Removed old PHP i18n file, no longer needed [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/161879 (owner: 10Jack Phoenix) [22:52:53] 3MediaWiki extensions / 3Scribunto: Count of arrays from LuaSandbox incorrect under HHVM - 10https://bugzilla.wikimedia.org/71061#c4 (10Ori Livneh) (In reply to Jackmcbarn from comment #2) > I've tracked this down to a bug in LuaSandbox. When an array from LuaSandbox > is passed to count() under HHVM, count(... [22:54:36] 3MediaWiki extensions / 3Scribunto: Count of arrays from LuaSandbox incorrect under HHVM - 10https://bugzilla.wikimedia.org/71061#c5 (10Ori Livneh) Created attachment 16534 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16534&action=edit Python script based on Jackmcbarn's test case This script will... [22:54:53] 3MediaWiki extensions / 3Scribunto: Count of arrays from LuaSandbox incorrect under HHVM - 10https://bugzilla.wikimedia.org/71061 (10Ori Livneh) a:3Tim Starling [23:11:16] (03CR) 10Gergő Tisza: "getParserOutput has no access to the parser, and no way to ensure that the parser has not been reused. (If the parser has been reused e.g." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/161471 (owner: 10Gergő Tisza) [23:34:38] 3MediaWiki / 3General/Unknown: Redirect does not appear in browser history - 10https://bugzilla.wikimedia.org/70962#c8 (10Waldir) (In reply to Bartosz Dziewoński from comment #7) > The browser will not reload the page by itself, we'd need to reload all of > the content or trigger page refresh from JS. This s...