[00:03:17] (03PS1) 10Legoktm: [WIP] Add renameALLtheusers.php [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/161632 [00:04:44] (03CR) 10Jdlrobson: "Since we don't seem to have any consensus I think moving this into core is probably premature. Maybe we are better using our own mixins fo" [core] - 10https://gerrit.wikimedia.org/r/151792 (owner: 10Jdlrobson) [00:05:18] (03Abandoned) 10Jdlrobson: Add truncated-text utility mixin [core] - 10https://gerrit.wikimedia.org/r/151792 (owner: 10Jdlrobson) [00:16:10] (03PS4) 10Paladox: Fix CSSJanus flipping in LESS mixins and remove broken custom LESS functions [core] - 10https://gerrit.wikimedia.org/r/161245 (https://bugzilla.wikimedia.org/67368) (owner: 10Bartosz Dziewoński) [00:18:38] 3MediaWiki / 3User preferences: Add a "You've not saved your changes" dialogue - 10https://bugzilla.wikimedia.org/55966 (10James Forrester) 5PATC>3RESO/FIX [00:19:26] 3MediaWiki extensions / 3MassMessage: MassMessage LQT support broken - 10https://bugzilla.wikimedia.org/71081 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3major a:3None From bug comment 7: > It is not working anymore: > https://pt.wikibooks.org/wiki/Special:Log/massmessage?uselang=en > > When I trie... [00:19:53] 3MediaWiki extensions / 3MassMessage: MassMessage should support LiquidThreads - 10https://bugzilla.wikimedia.org/52729#c8 (10Kunal Mehta (Legoktm)) 5REOP>3RESO/FIX (In reply to Helder from comment #7) In the future, please file a new bug instead of opening old ones. I re-filed this as bug 71081. [00:20:22] 3MediaWiki extensions / 3MassMessage: MassMessage LQT support broken - 10https://bugzilla.wikimedia.org/71081#c1 (10Kunal Mehta (Legoktm)) (In reply to Kunal Mehta (Legoktm) from comment #0) > From bug comment 7: bug 52729 comment 7* [00:30:37] 3MediaWiki extensions / 3MassMessage: MassMessage LQT support broken - 10https://bugzilla.wikimedia.org/71081 (10Helder) [00:41:23] 3MediaWiki extensions / 3ProofreadPage: WikiEditor loads in different places in the Page namespace depending upon which user preferences are selected - 10https://bugzilla.wikimedia.org/70431#c5 (10George Orwell III) 5NEW>3RESO/FIX While a separate issue with the positioning of the CharInsert toolbar ment... [00:41:26] 3MediaWiki / 3Redirects: Use history.replaceState to rewrite redirect urls - 10https://bugzilla.wikimedia.org/35045#c16 (10Benjamin Mako Hill) I've a researcher who has studied redirects in Wikipedia. I'm also active from time to time on https://en.wikipedia.org/wiki/Wikipedia:Redirects_for_discussion where... [00:57:52] 3MediaWiki extensions / 3MassMessage: MassMessage LQT support broken - 10https://bugzilla.wikimedia.org/71081#c2 (10Kunal Mehta (Legoktm)) I'm debugging this locally right now, it appears to be getting stuck at Thread::validateSubject() (via the LQT API) and my VM starts maxing out the CPU it has... [01:03:08] 3MediaWiki extensions / 3MassMessage: MassMessage LQT support broken - 10https://bugzilla.wikimedia.org/71081#c3 (10Kunal Mehta (Legoktm)) Aaaand as I suspected it looks like Thread::validateSubject() for whatever reason is going into an infinite loop. [01:07:06] 3MediaWiki extensions / 3MassMessage: MassMessage LQT support broken - 10https://bugzilla.wikimedia.org/71081#c4 (10Kunal Mehta (Legoktm)) error=MWException: Empty $mTitle in OutputPage::parse [01:08:12] I hate hate hate LQT. [01:08:36] putting a catch ( Exception $e ) {} inside a infinte while loop totally won't go wrong [01:08:38] I wouldn't put much energy into supporting it. [01:08:52] legoktm, are you already part of the conversion effort? if not it's being discussed right now on the ee@ list [01:09:22] 3MediaWiki / 3Redirects: Use history.replaceState to rewrite redirect urls - 10https://bugzilla.wikimedia.org/35045#c17 (10MZMcBride) (In reply to jeremyb from comment #13) > (In reply to Ricordisamoa from comment #11) >> Now MediaWiki behaves very differently with JavaScript disabled. > > Yes Can someone... [01:09:53] Eloquence: I'm aware of the thread and think I read it, but don't have much time to help [01:09:59] np [01:10:35] Carmela: well, if it's doing in prod what it's doing locally for me, it's totally broken and just wasting job runner time until it hits the timeout [01:11:18] legoktm: Sounds like a good excuse to disable the extension. <_< [01:11:32] Isn't there a conversion/dump script of some kind? [01:11:39] nope. [01:11:44] Lame. [01:11:51] Bugzilla is now warning about https://www.mediawiki.org/wiki/Phabricator#Migration_timeline [01:11:53] Threads::stripWikitext() is the problem. [01:12:45] someone probably killed a $wgTitle somewhere [01:13:34] I'm hope you're shaking your fist in their general direction. [01:14:33] okay, fixed it. [01:18:22] 3MediaWiki extensions / 3MassMessage: MassMessage LQT support broken - 10https://bugzilla.wikimedia.org/71081#c5 (10Kunal Mehta (Legoktm)) 5NEW>3ASSI Threads::stripWikitext() calls $wgOut->parseInline() which dies if a Title isn't set. [01:22:30] (03PS1) 10Legoktm: ApiThreadAction: Make sure a Title is set [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/161638 (https://bugzilla.wikimedia.org/71081) [01:31:23] 3MediaWiki extensions / 3ProofreadPage: {{{pagenum}}} should be substituted with a Roman number if specified - 10https://bugzilla.wikimedia.org/51106#c1 (10George Orwell III) Is this still an issue (if it ever was)? Seems like this has been the normal behavior (on en.WS) for as long as I can remember now -... [01:49:59] Krenair: if you could look at https://gerrit.wikimedia.org/r/161638 sometime, I'd like to get that backported on monday [01:56:44] legoktm, I've looked at it but I'm not approving it. [01:57:52] why not? [01:58:35] You're not actually fixing the issue. [01:58:51] "I don't want to fix this extension" is actually in the commit message. [01:59:43] I'm fixing the bug, which I think is more important atm. I don't think anyones time trying to fix it properly when we're actively trying to kill it. [01:59:51] You set $wgTitle to a obviously-broken value. Which will likely break other things. [02:00:09] How is it obviously broken? [02:00:27] the API normally sets it to "API" [02:00:35] I set $wgTitle to a Title object instead of null. [02:01:14] And yes, it will break other things, but at least they'll be broken instead of an infinite loop that just wastes time and resources [02:01:33] actually, I'm not sure what this will break, except things that were already broken. [02:01:59] Have you tested this patch? [02:02:03] yes. [02:02:34] That it fixes MassMessage, or that LQT seems to still run OK? [02:03:25] I tested that it fixed MassMessage, and then that a normal reply and thread addition to a talk addition worked fine [02:03:42] via the web ui which uses the API I think. [02:04:18] Well, it shouldn't be too difficult to check that it's going through this API. [02:05:34] * legoktm checks [02:06:24] it does [02:08:37] 3MediaWiki extensions / 3ProofreadPage: phpunit: SKIPPED: djvu binaries do not exist or are not executable - 10https://bugzilla.wikimedia.org/68638#c6 (10George Orwell III) (In follow-up to George Orwell III from comment #5) > . . . > Can't you first verify the presence - or lack thereof - of the ' > DjVuXM... [02:09:30] (03CR) 10Legoktm: [C: 04-1] "I'll fix in a minute." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135439 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [02:13:47] (03PS11) 10Legoktm: Completely remove skin autodiscovery [core] - 10https://gerrit.wikimedia.org/r/135439 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [02:15:03] (03CR) 10Legoktm: [C: 032] Completely remove skin autodiscovery [core] - 10https://gerrit.wikimedia.org/r/135439 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [02:20:51] 3MediaWiki / 3MediaWiki UI: checkboxes hover and click states are not to spec - 10https://bugzilla.wikimedia.org/70909#c2 (10Matthew Flaschen) (In reply to Jared Zimmerman (WMF) from comment #0) > currently checkboxes do not carry the bottom border on hover, only on focus. Can you update mw.ui.checkbox.fw.... [02:21:51] (03Merged) 10jenkins-bot: Completely remove skin autodiscovery [core] - 10https://gerrit.wikimedia.org/r/135439 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [02:32:19] (03PS1) 10Legoktm: Improve coverage of MassMessage::getDBName() [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/161639 [02:45:37] (03CR) 10Mattflaschen: [C: 04-1] "Looks good. The spec could use some slight clarification (commented on the bug), there are a few small issues inline, and one of the PNGs" (035 comments) [core] - 10https://gerrit.wikimedia.org/r/161261 (https://bugzilla.wikimedia.org/70909) (owner: 10Prtksxna) [02:47:15] (03PS1) 10Legoktm: Clean up test directory structure [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/161640 [03:18:37] 3MediaWiki / 3Interface: Deprecate and remove skin autodiscovery (autoloading) mechanism - 10https://bugzilla.wikimedia.org/65748 (10James Forrester) 5PATC>3RESO/FIX [03:20:06] 3Wikimedia / 3OTRS: Update OTRS to 3.2.16 (address XSS and clickjacking vulnerability) - 10https://bugzilla.wikimedia.org/63685#c3 (10David C. Rankin) All, My 1.22.2 MediaWiki install was completely compromised in the past 20 days. I think every RIPE, RU and APNIC address logged in and apparently autocr... [03:20:47] (03PS1) 10Legoktm: Refactor and add tests for MassMessageSubmitJob [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/161641 [03:32:22] 3MediaWiki / 3Page editing: Revert bug 27860 or add configuration variable to restore "Mark all edits minor by default" preference behaviour - 10https://bugzilla.wikimedia.org/42008#c11 (10George Orwell III) (In reply to Nemo from comment #9) > Dunno what qualifies for "strongly care" but I still think this... [03:41:44] legoktm: i thought 1.24 wasn't supposed to branch until next week [03:43:52] 3MediaWiki / 3MediaWiki UI: MediaWiki UI styles are applied to core instead of relevant skins, not overridable - 10https://bugzilla.wikimedia.org/70351#c19 (10Matthew Flaschen) (In reply to Isarra from comment #18) > (In reply to Bartosz Dziewoński from comment #17) > > You can now override or disable MediaW... [04:03:08] 3MediaWiki extensions / 3WikimediaEvents: The HHVM BetaFeature needs an image - 10https://bugzilla.wikimedia.org/71048#c5 (10Matthew Flaschen) (In reply to Jared Zimmerman (WMF) from comment #4) > My understanding of talking to Ori about HHVM is that as more pages were > accessed by users via HHVM is that su... [04:06:08] 3MediaWiki skins / 3Vector: h4, h5, and h6 headers should not have the same styling - 10https://bugzilla.wikimedia.org/70004#c1 (10Quiddity) This changed during the [[mw:Typography refresh]]. The lines at fault are in https://git.wikimedia.org/blob/mediawiki%2Fskins%2FVector.git/HEAD/components%2Fcommon.les... [04:10:07] 3MediaWiki extensions / 3Scribunto: mw.ustring.gmatch does not find all matches on HHVM - 10https://bugzilla.wikimedia.org/71061#c1 (10Jackmcbarn) I've created a reduced version of the test that reveals the bug, at https://test2.wikipedia.org/wiki/Module:71061 and https://test2.wikipedia.org/wiki/Module:7106... [04:12:07] (03CR) 10Mattflaschen: "I'm okay with merging -o-background-size; we can bear in mind this issue if we get any reports from ancient (9.5) Opera." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/154125 (https://bugzilla.wikimedia.org/70133) (owner: 10Jdlrobson) [04:18:16] (03CR) 10Chad: Bump 1.25 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/161584 (owner: 10Jforrester) [04:24:00] (03CR) 10Mattflaschen: "Minor style comment inline" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) (owner: 10Jdlrobson) [04:44:07] (03CR) 10Wctaiwan: [C: 032] Improve coverage of MassMessage::getDBName() [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/161639 (owner: 10Legoktm) [04:44:38] (03Merged) 10jenkins-bot: Improve coverage of MassMessage::getDBName() [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/161639 (owner: 10Legoktm) [04:46:51] 3MediaWiki extensions / 3Scribunto: Count of arrays from LuaSandbox incorrect under HHVM - 10https://bugzilla.wikimedia.org/71061#c2 (10Jackmcbarn) p:5Unprio>3High s:5normal>3major I've tracked this down to a bug in LuaSandbox. When an array from LuaSandbox is passed to count() under HHVM, count() re... [04:51:22] 3Wikimedia / 3OTRS: Update OTRS to 3.2.16 (address XSS and clickjacking vulnerability) - 10https://bugzilla.wikimedia.org/63685#c4 (10jeremyb) (In reply to David C. Rankin from comment #3) this bug is not related to MediaWiki. Please limit your searches to MediaWiki related components. This message is prob... [05:00:53] 3MediaWiki / 3User preferences: Changes to user preferences should be automatically saved - 10https://bugzilla.wikimedia.org/56561#c4 (10Matthew Flaschen) (In reply to Quim Gil from comment #1) > Does anybody know the estimate effort of this task? Would it be simple for a > newcomer to dive into it? Is there... [05:04:08] 3MediaWiki / 3User preferences: Changes to user preferences should be automatically saved - 10https://bugzilla.wikimedia.org/56561#c5 (10Matthew Flaschen) (In reply to Matthew Flaschen from comment #4) > It could also be done by posting the entire preferences form every time you > change anything. Note, I m... [05:20:37] 3MediaWiki / 3MediaWiki UI: MediaWiki UI styles are applied to core instead of relevant skins, not overridable - 10https://bugzilla.wikimedia.org/70351#c20 (10Quiddity) If I understand correctly, Isarra is suggesting there should be an alternative UI option, which uses the previous/classic styling. Secondly... [05:20:53] 3Wikimedia / 3General/Unknown: Add ContentHandler columns to Wikimedia wikis, and set $wgContentHandlerUseDB = true - 10https://bugzilla.wikimedia.org/49193 (10Matthew Flaschen) [05:20:53] 3MediaWiki extensions / 3MassMessage: Add Flow support to MassMessage - 10https://bugzilla.wikimedia.org/71082 (10Matthew Flaschen) [05:24:36] (03CR) 10Legoktm: [C: 032] Clean up SpecialMassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/160792 (owner: 10Wctaiwan) [05:25:16] superm401: ? why did you add that dependency? [05:25:38] 3Wikimedia / 3General/Unknown: Add ContentHandler columns to Wikimedia wikis, and set $wgContentHandlerUseDB = true - 10https://bugzilla.wikimedia.org/49193 (10Kunal Mehta (Legoktm)) [05:25:39] 3MediaWiki extensions / 3MassMessage: Add Flow support to MassMessage - 10https://bugzilla.wikimedia.org/71082#c1 (10Kunal Mehta (Legoktm)) Er, this doesn't depend upon bug 49193...? [05:26:06] legoktm, I thought that was what you meant at https://lists.wikimedia.org/pipermail/ee/2014-September/001170.html ? [05:26:24] Anyway, isn't it a real dependency (so MassMessage knows what kind of page it's adding the message too)? [05:26:35] no I meant that before "Kill LQT on mediawiki.org" we need to fix MM [05:26:55] you can already do $title->hasContentModel('flow-board') [05:27:09] legoktm, oh, okay. My bad. [05:37:07] 3MediaWiki / 3MediaWiki UI: MediaWiki UI styles are applied to core instead of relevant skins, not overridable - 10https://bugzilla.wikimedia.org/70351#c21 (10Matthew Flaschen) (In reply to Quiddity from comment #20) > If I understand correctly, Isarra is suggesting there should be an > alternative UI option... [05:44:14] (03CR) 10Legoktm: [C: 04-1] "It works fine, but I think we should cache the targets so we don't have to re-parse entire pages when they hit submit." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/160787 (https://bugzilla.wikimedia.org/57472) (owner: 10Wctaiwan) [06:03:27] (03CR) 10Wctaiwan: [C: 032] Refactor and add tests for MassMessageSubmitJob [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/161641 (owner: 10Legoktm) [06:09:28] (03CR) 10Wctaiwan: [C: 032] Clean up test directory structure [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/161640 (owner: 10Legoktm) [06:09:58] (03Merged) 10jenkins-bot: Clean up test directory structure [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/161640 (owner: 10Legoktm) [06:10:26] (03Merged) 10jenkins-bot: Refactor and add tests for MassMessageSubmitJob [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/161641 (owner: 10Legoktm) [06:11:54] (03PS1) 10Legoktm: Add tests for CentralAuthUser::getInstance() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/161643 [06:22:54] (03CR) 10Legoktm: [C: 032] "wctaiwan will add caching in a follow-up." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/160787 (https://bugzilla.wikimedia.org/57472) (owner: 10Wctaiwan) [06:23:26] (03Merged) 10jenkins-bot: Output the number of recipients on preview [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/160787 (https://bugzilla.wikimedia.org/57472) (owner: 10Wctaiwan) [06:23:39] (03Abandoned) 10Legoktm: Output the number of recipients on preview [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97628 (https://bugzilla.wikimedia.org/57472) (owner: 10Legoktm) [06:23:53] (03Merged) 10jenkins-bot: Clean up SpecialMassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/160792 (owner: 10Wctaiwan) [06:24:38] 3MediaWiki extensions / 3MassMessage: MassMessage preview should output the number of recipients - 10https://bugzilla.wikimedia.org/57472 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:5Kunal Mehta (Legoktm)>3wctaiwan [06:27:38] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch should provide a way to find hyphenated words, as Lucene-search always has - 10https://bugzilla.wikimedia.org/70950#c6 (10Mikhail Ryazanov) (In reply to Chad H. from comment #5) > In English I can't think of any, but I'd really like to look further into > w... [07:05:47] (03PS1) 10Legoktm: Use canonical parser options when getting targets [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/161644 [07:05:49] (03PS1) 10Legoktm: Don't require context for MassMessage::submit() [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/161645 [08:46:08] 3MediaWiki extensions / 3MassMessage: MassMessage LQT support broken - 10https://bugzilla.wikimedia.org/71081#c7 (10Nemo) (In reply to Gerrit Notification Bot from comment #6) > Change 161638 had a related patch set uploaded by Legoktm: > ApiThreadAction: Make sure a Title is set > > https://gerrit.wikimedi... [08:49:28] (03PS1) 10Tpt: Adds a test to be sure that {{{pagenum}}} is replaced by a roman number if needed [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/161649 [09:14:03] (03CR) 10Nikerabbit: Unset redirect param in MoveLogFormatter::getMessageParameters (031 comment) [core] - 10https://gerrit.wikimedia.org/r/152011 (owner: 10Umherirrender) [09:43:39] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: Show a message on the BF preferences pane with details of how to write your own - 10https://bugzilla.wikimedia.org/70154#c2 (10Seb35) I don’t think it would be a good idea because the ratio "concerned people / unconcerned people" will be very low, and I do... [10:14:37] 3MediaWiki extensions / 3WikidataRepo: Unexpected non-MediaWiki exception encountered, of type "BadMethodCallException" on line 275 of Entity.php - 10https://bugzilla.wikimedia.org/70736 (10Lydia Pintscher) p:5Unprio>3Normal [10:23:08] 3MediaWiki extensions / 3ProofreadPage: phpunit: SKIPPED: djvu binaries do not exist or are not executable - 10https://bugzilla.wikimedia.org/68638#c7 (10Bartosz Dziewoński) (Sorry, I know little about our CI setup and even less about DJVU stuff, so I can't help much.) [10:26:35] (03CR) 10Addshore: [C: 032] Add tests for CentralAuthUser::getInstance() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/161643 (owner: 10Legoktm) [10:27:12] (03Merged) 10jenkins-bot: Add tests for CentralAuthUser::getInstance() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/161643 (owner: 10Legoktm) [10:27:48] (03CR) 10Addshore: [C: 031] ApiThreadAction: Make sure a Title is set [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/161638 (https://bugzilla.wikimedia.org/71081) (owner: 10Legoktm) [10:34:37] (03CR) 10Fomafix: Bump 1.25 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/161584 (owner: 10Jforrester) [10:34:39] (03PS1) 10PleaseStand: DatabaseMysqlBase: Use VERSION() rather than server_info [core] - 10https://gerrit.wikimedia.org/r/161652 [10:52:51] (03CR) 10GOIII: [C: 031] Adds a test to be sure that {{{pagenum}}} is replaced by a roman number if needed [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/161649 (owner: 10Tpt) [10:54:07] (03CR) 10Tpt: [C: 032] "Reviewed by George Orwell III (thanks a lot!)" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/161649 (owner: 10Tpt) [10:54:27] (03Merged) 10jenkins-bot: Adds a test to be sure that {{{pagenum}}} is replaced by a roman number if needed [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/161649 (owner: 10Tpt) [10:57:36] 3MediaWiki extensions / 3ProofreadPage: {{{pagenum}}} should be substituted with a Roman number if specified - 10https://bugzilla.wikimedia.org/51106#c4 (10Tpt) 5PATC>3RESO/FIX Was fixed long time ago and a unit test have just been added in order to avoid any regressions in the future. [11:04:44] (03CR) 10GOIII: [C: 031] Adds tests for Context class [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/157506 (owner: 10Tpt) [11:05:31] (03CR) 10Tpt: [C: 032] "Reviewed by George Orwell III (thanks a lot!)" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/157506 (owner: 10Tpt) [11:05:51] (03Merged) 10jenkins-bot: Adds tests for Context class [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/157506 (owner: 10Tpt) [11:44:23] (03Abandoned) 10Yuvipanda: Remove duplication of -multimedia extensions from -dev [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/134154 (owner: 10Yuvipanda) [11:58:29] (03PS3) 10Physikerwelt: WIP: Workaround for a potential phpUnit bug [extensions/Math] - 10https://gerrit.wikimedia.org/r/161610 [12:08:52] 3MediaWiki extensions / 3ProofreadPage: phpunit: SKIPPED: djvu binaries do not exist or are not executable - 10https://bugzilla.wikimedia.org/68638#c8 (10George Orwell III) (In reply to Bartosz Dziewoński from comment #7) > (Sorry, I know little about our CI setup and even less about DJVU stuff, so > I can't... [12:13:21] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/160911 (https://bugzilla.wikimedia.org/68836) (owner: 10Arlolra) [12:17:10] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/161039 (owner: 10Manybubbles) [12:30:00] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (0314 comments) [core] - 10https://gerrit.wikimedia.org/r/160798 (https://bugzilla.wikimedia.org/30936) (owner: 10Anomie) [12:32:20] (03PS1) 10PleaseStand: CurlHttpRequest: Follow redirects even under open_basedir [core] - 10https://gerrit.wikimedia.org/r/161656 [12:34:42] (03CR) 10Siebrand: [C: 031] "L10n reviewed. Leaving the logging code changes for Nikerabbit to approve." [core] - 10https://gerrit.wikimedia.org/r/151683 (owner: 10Umherirrender) [12:35:00] (03CR) 10Siebrand: "L10n reviewed. Leaving the logging code changes for Nikerabbit to approve." [core] - 10https://gerrit.wikimedia.org/r/151701 (owner: 10Umherirrender) [12:35:23] (03CR) 10Siebrand: "L10n reviewed. Leaving the logging code changes for Nikerabbit to approve." [core] - 10https://gerrit.wikimedia.org/r/152003 (owner: 10Umherirrender) [12:36:11] (03CR) 10Siebrand: [C: 031] "L10n reviewed. Leaving the logging code changes for Nikerabbit to approve." [core] - 10https://gerrit.wikimedia.org/r/152156 (owner: 10Umherirrender) [13:15:21] (03PS1) 10Jack Phoenix: Fix fatal on Special:ArticleLists caused by I9f19d817f4a4a9acf6794fc2706c81a7312ec126 [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/161658 [13:16:01] (03CR) 10Jack Phoenix: [C: 032] Fix fatal on Special:ArticleLists caused by I9f19d817f4a4a9acf6794fc2706c81a7312ec126 [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/161658 (owner: 10Jack Phoenix) [13:16:08] (03Merged) 10jenkins-bot: Fix fatal on Special:ArticleLists caused by I9f19d817f4a4a9acf6794fc2706c81a7312ec126 [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/161658 (owner: 10Jack Phoenix) [13:18:44] (03PS1) 10Jack Phoenix: Use $wgExtensionAssetsPath instead of $wgScriptPath [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/161659 [13:19:40] (03CR) 10Jack Phoenix: [C: 032] Use $wgExtensionAssetsPath instead of $wgScriptPath [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/161659 (owner: 10Jack Phoenix) [13:19:47] (03Merged) 10jenkins-bot: Use $wgExtensionAssetsPath instead of $wgScriptPath [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/161659 (owner: 10Jack Phoenix) [13:21:51] hey werdna! around for a little chat? :) [13:22:08] "a little chat", sounds foreboding :p [13:29:53] (03PS8) 10PleaseStand: Database: Remove use of strencode() in replaceVars() [core] - 10https://gerrit.wikimedia.org/r/146363 [13:30:31] (03PS1) 10Jack Phoenix: Ran stylize.php & manually updated documentation format [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/161660 [13:30:45] (03CR) 10Jack Phoenix: [C: 032] Ran stylize.php & manually updated documentation format [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/161660 (owner: 10Jack Phoenix) [13:30:51] (03Merged) 10jenkins-bot: Ran stylize.php & manually updated documentation format [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/161660 (owner: 10Jack Phoenix) [13:31:38] (03PS1) 10Jack Phoenix: Fix a fatal typo [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/161661 [13:31:51] (03CR) 10Jack Phoenix: [C: 032] Fix a fatal typo [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/161661 (owner: 10Jack Phoenix) [13:31:57] (03Merged) 10jenkins-bot: Fix a fatal typo [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/161661 (owner: 10Jack Phoenix) [13:34:44] (03PS1) 10Jack Phoenix: Fix a logic error and tweak comments a bit [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/161662 [13:38:09] (03PS1) 10Jack Phoenix: CSS loading fixes -- swapped addModules() to addModuleStyles() where appropriate [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/161663 [13:38:31] (03CR) 10Jack Phoenix: [C: 032] CSS loading fixes -- swapped addModules() to addModuleStyles() where appropriate [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/161663 (owner: 10Jack Phoenix) [13:38:39] (03CR) 10PleaseStand: "Moved release notes to the 1.25 file and adjusted the "1.23 and older" comment accordingly. Also tweaked the comment at the top of the add" [core] - 10https://gerrit.wikimedia.org/r/146363 (owner: 10PleaseStand) [13:38:55] (03CR) 10Jack Phoenix: [C: 032] Fix a logic error and tweak comments a bit [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/161662 (owner: 10Jack Phoenix) [13:38:56] !class Block [13:38:56] See https://doc.wikimedia.org/mediawiki-core/master/php/html/classBlock.html [13:39:03] (03Merged) 10jenkins-bot: Fix a logic error and tweak comments a bit [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/161662 (owner: 10Jack Phoenix) [13:42:16] (03CR) 10Martineznovo: [C: 04-1] Handle merging blocks a bit better (031 comment) [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/160872 (https://bugzilla.wikimedia.org/39470) (owner: 10Legoktm) [14:13:40] 3MediaWiki / 3API: ApiQueryAllUsers with auactiveusers fails on duplicate querycachetwo rows - 10https://bugzilla.wikimedia.org/71086 (10Marius Hoch) 3NEW p:3Unprio s:3normal a:3None Rows in querycachetwo aren't enforced to be unique... that can lead to the following error: 2014-09-20 13:11:57 mw11... [14:15:12] (03PS1) 10Hoo man: Don't INNER JOIN querycachetwo in ApiQueryAllUsers [core] - 10https://gerrit.wikimedia.org/r/161664 (https://bugzilla.wikimedia.org/71086) [14:38:23] 3Wikimedia / 3Media storage: File missing on Commons (Charles_I_of_Austria; uploaded 2010) - 10https://bugzilla.wikimedia.org/62629#c3 (10DaB.) (In reply to Ankry from comment #2) > file transfered again from elwiki Thanks :-) [15:04:25] (03CR) 10Umherirrender: Bump 1.25 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/161584 (owner: 10Jforrester) [15:06:34] (03PS4) 10Umherirrender: Unset redirect param in MoveLogFormatter::getMessageParameters [core] - 10https://gerrit.wikimedia.org/r/152011 [15:07:12] (03CR) 10Umherirrender: "Patch Set 4: Addressed inline comment" [core] - 10https://gerrit.wikimedia.org/r/152011 (owner: 10Umherirrender) [15:07:23] 3MediaWiki extensions / 3ProofreadPage: phpunit: SKIPPED: djvu binaries do not exist or are not executable - 10https://bugzilla.wikimedia.org/68638#c9 (10Andre Klapper) (In reply to Bartosz Dziewoński from comment #7) > (Sorry, I know little about our CI setup https://lists.wikimedia.org/mailman/listinfo/qa... [15:17:25] (03PS4) 10Physikerwelt: WIP: Workaround for a potential phpUnit bug [extensions/Math] - 10https://gerrit.wikimedia.org/r/161610 [15:18:34] (03CR) 10jenkins-bot: [V: 04-1] WIP: Workaround for a potential phpUnit bug [extensions/Math] - 10https://gerrit.wikimedia.org/r/161610 (owner: 10Physikerwelt) [15:22:07] 3MediaWiki / 3Installer: Installer should detect mod_security(2) via get_apache_modules() and give warning - 10https://bugzilla.wikimedia.org/39463 (10Jackmcbarn) p:5Low>3Normal [15:25:14] (03PS11) 10Addshore: Special:Import not importing Special:Export XMLs [core] - 10https://gerrit.wikimedia.org/r/159973 (https://bugzilla.wikimedia.org/66023) (owner: 10Dan-nl) [15:26:46] (03CR) 10Umherirrender: Make $file->getLength() return duration of GIF and APNG files. (032 comments) [core] - 10https://gerrit.wikimedia.org/r/160304 (owner: 10Brian Wolff) [15:26:55] 3MediaWiki / 3Unit tests: duplicate key in unittest_updatelog - 10https://bugzilla.wikimedia.org/71087 (10physikerwelt) 3NEW p:3Unprio s:3normal a:3None Probably a duplicate but I could not find a reference to another bug number... If more than one new table is added per second an error is thrown due... [15:27:29] (03CR) 10Raimond Spekking: [C: 032] Add grammar forms for Wikidata in Polish [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/161580 (owner: 10Bartosz Dziewoński) [15:27:41] (03Merged) 10jenkins-bot: Add grammar forms for Wikidata in Polish [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/161580 (owner: 10Bartosz Dziewoński) [15:30:44] (03PS1) 10Jackmcbarn: Improve mod_security warning [core] - 10https://gerrit.wikimedia.org/r/161669 (https://bugzilla.wikimedia.org/39463) [15:32:07] 3MediaWiki / 3Installer: Installer should detect mod_security(2) via get_apache_modules() and give warning - 10https://bugzilla.wikimedia.org/39463#c3 (10Jackmcbarn) I'm also wondering if we should add something to Special:Version that says if mod_security(2) is loaded, so that we can point it out immediatel... [15:42:05] (03PS1) 10Aude: Fix edit count UserTest which incorrectly adds user to db [core] - 10https://gerrit.wikimedia.org/r/161670 (https://bugzilla.wikimedia.org/68626) [15:48:46] aude: Whoops :D [15:48:54] (03CR) 10jenkins-bot: [V: 04-1] Fix edit count UserTest which incorrectly adds user to db [core] - 10https://gerrit.wikimedia.org/r/161670 (https://bugzilla.wikimedia.org/68626) (owner: 10Aude) [15:49:13] one of the few core tests I've written [15:57:08] 3Wiki Loves Monuments / 3Database: sk id gets truncated - 10https://bugzilla.wikimedia.org/70806#c3 (10Maarten Dammers) 5PATC>3RESO/FIX a:3Maarten Dammers Fixed and deployed [16:01:05] (03PS3) 10Arlolra: Conform settings to metabook.json spec [extensions/Collection] - 10https://gerrit.wikimedia.org/r/160911 (https://bugzilla.wikimedia.org/68836) [16:01:54] (03PS4) 10Arlolra: Conform settings to metabook.json spec [extensions/Collection] - 10https://gerrit.wikimedia.org/r/160911 (https://bugzilla.wikimedia.org/68836) [16:17:11] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: the VisualEditor section appears before the introduction - 10https://bugzilla.wikimedia.org/71088 (10Seb35) 3NEW p:3Unprio s:3minor a:3Seb35 Created attachment 16526 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16526&action=edit The Visua... [16:19:20] (03CR) 10Nikerabbit: API: HTMLize and internationalize the help, add Special:ApiHelp (031 comment) [core] - 10https://gerrit.wikimedia.org/r/160798 (https://bugzilla.wikimedia.org/30936) (owner: 10Anomie) [16:28:44] (03CR) 10Bartosz Dziewoński: [C: 032] Fix edit count UserTest which incorrectly adds user to db [core] - 10https://gerrit.wikimedia.org/r/161670 (https://bugzilla.wikimedia.org/68626) (owner: 10Aude) [16:35:28] (03CR) 10jenkins-bot: [V: 04-1] Fix edit count UserTest which incorrectly adds user to db [core] - 10https://gerrit.wikimedia.org/r/161670 (https://bugzilla.wikimedia.org/68626) (owner: 10Aude) [16:41:13] aude: why is that failing :( ^ [16:42:08] (03CR) 10Bartosz Dziewoński: [C: 04-1] "16:35:23 There was 1 failure:" [core] - 10https://gerrit.wikimedia.org/r/161670 (https://bugzilla.wikimedia.org/68626) (owner: 10Aude) [16:47:37] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: the VisualEditor section appears before the introduction - 10https://bugzilla.wikimedia.org/71088#c1 (10Seb35) Since the VisualEditor registers its preference 'visualeditor-enable' in the standard GetPreferences and in the BF’s GetBetaFeaturePreferences, o... [16:48:51] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: the VisualEditor section appears before the introduction - 10https://bugzilla.wikimedia.org/71088 (10Seb35) p:5Unprio>3Low [16:58:09] (03PS2) 10Bartosz Dziewoński: UserTest: Fix edit count test which incorrectly added user to db [core] - 10https://gerrit.wikimedia.org/r/161670 (https://bugzilla.wikimedia.org/68626) (owner: 10Aude) [16:58:11] (03PS1) 10Bartosz Dziewoński: UserTest: Don't rely on the behavior of unknown user options [core] - 10https://gerrit.wikimedia.org/r/161675 [16:58:29] aude: wanna merge? should fix your change too. ^ [16:58:42] (03PS4) 10Amire80: Add talk link to excontentauthor [core] - 10https://gerrit.wikimedia.org/r/124158 [16:58:58] (03CR) 10Bartosz Dziewoński: [C: 032] "The other test was broken, fixed in https://gerrit.wikimedia.org/r/#/c/161675/1" [core] - 10https://gerrit.wikimedia.org/r/161670 (https://bugzilla.wikimedia.org/68626) (owner: 10Aude) [16:59:01] (03PS5) 10Amire80: Add talk link to excontentauthor [core] - 10https://gerrit.wikimedia.org/r/124158 [17:00:53] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: the VisualEditor section appears before the introduction - 10https://bugzilla.wikimedia.org/71088#c2 (10Bartosz Dziewoński) Yeah. VE should just check for the presence of 'BetaFeatures' class, instead of relying on the order. You can just use class_exists(... [17:01:01] (03PS3) 10Amire80: Bidi-isolate extension version on Special:Version [core] - 10https://gerrit.wikimedia.org/r/147733 [17:01:51] (03PS3) 10Amire80: Bidi-isolate and nowrap parser tags on Special:Version [core] - 10https://gerrit.wikimedia.org/r/145758 [17:02:55] 3Wikimedia / 3Site requests: Account creation exemption lift - 10https://bugzilla.wikimedia.org/71090 (10James Heilman) 3NEW p:3Unprio s:3normal a:3None I need a few IPs exempt for the creation limit. I need this one start in 14 hours 182.72.146.126 for 12 hours. I need these ones exempted for all w... [17:03:29] (03PS2) 10Amire80: Automatic direction for the license in Special:Version [core] - 10https://gerrit.wikimedia.org/r/147734 [17:05:10] 3Wikimedia / 3Site requests: Account creation exemption lift - 10https://bugzilla.wikimedia.org/71090#c1 (10Alex Monk) Which wiki is this for? English Wikipedia [17:05:18] (03CR) 10jenkins-bot: [V: 04-1] UserTest: Fix edit count test which incorrectly added user to db [core] - 10https://gerrit.wikimedia.org/r/161670 (https://bugzilla.wikimedia.org/68626) (owner: 10Aude) [17:06:06] (03CR) 10Hoo man: [C: 032] UserTest: Don't rely on the behavior of unknown user options [core] - 10https://gerrit.wikimedia.org/r/161675 (owner: 10Bartosz Dziewoński) [17:06:35] (03PS1) 10Seb35: Unset the preference key before adding it [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/161677 (https://bugzilla.wikimedia.org/71088) [17:07:22] 3Wikimedia / 3Site requests: Account creation exemption lift - 10https://bugzilla.wikimedia.org/71090#c2 (10James Heilman) This is for English Wikipedia My user page is here https://en.wikipedia.org/wiki/User:Jmh649 The conference page is here https://colloquium.cochrane.org/ [17:08:54] 3Wikimedia / 3Site requests: Account creation exemption lift - 10https://bugzilla.wikimedia.org/71090#c3 (10James Heilman) Times are IST (Indian Standard Time) [17:09:58] (03PS3) 10Bartosz Dziewoński: UserTest: Fix edit count test which incorrectly added user to db [core] - 10https://gerrit.wikimedia.org/r/161670 (https://bugzilla.wikimedia.org/68626) (owner: 10Aude) [17:10:00] (03PS1) 10Bartosz Dziewoński: Strict standards: Static function PasswordTestCase::providePasswordTests() should not be abstract [core] - 10https://gerrit.wikimedia.org/r/161678 [17:11:09] (03CR) 10jenkins-bot: [V: 04-1] UserTest: Fix edit count test which incorrectly added user to db [core] - 10https://gerrit.wikimedia.org/r/161670 (https://bugzilla.wikimedia.org/68626) (owner: 10Aude) [17:11:18] (03CR) 10Bartosz Dziewoński: [C: 032] "Thank you!" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/161629 (https://bugzilla.wikimedia.org/70814) (owner: 10Seb35) [17:11:30] (03CR) 10jenkins-bot: [V: 04-1] Strict standards: Static function PasswordTestCase::providePasswordTests() should not be abstract [core] - 10https://gerrit.wikimedia.org/r/161678 (owner: 10Bartosz Dziewoński) [17:12:15] okaaaaay [17:12:34] wtf is wrong with jenkins today [17:12:38] 3Wikimedia / 3Site requests: Account creation exemption lift - 10https://bugzilla.wikimedia.org/71090#c4 (10James Heilman) Basically 8 am IST to 8 pm IST on the 21st for IP 182.72.146.126 Than the 22nd to 27th for the other three IPs. We are running a Wikipedia editing table. There are about 2000 to 3000 at... [17:12:46] MatmaRex: Bcryptpasswordtestcase or so :P [17:12:51] you broke that with that change [17:13:05] (03Merged) 10jenkins-bot: UserTest: Don't rely on the behavior of unknown user options [core] - 10https://gerrit.wikimedia.org/r/161675 (owner: 10Bartosz Dziewoński) [17:13:07] (03Merged) 10jenkins-bot: Display allowed skins if and only if the current skin is not allowed [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/161629 (https://bugzilla.wikimedia.org/70814) (owner: 10Seb35) [17:13:26] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: Warnings about allowed skins are not displayed - 10https://bugzilla.wikimedia.org/70814#c12 (10Bartosz Dziewoński) 5PATC>3RESO/FIX Change 161629 merged by jenkins-bot: Display allowed skins if and only if the current skin is not allowed https://gerrit... [17:14:12] grumble [17:17:12] (03PS4) 10Bartosz Dziewoński: UserTest: Fix edit count test which incorrectly added user to db [core] - 10https://gerrit.wikimedia.org/r/161670 (https://bugzilla.wikimedia.org/68626) (owner: 10Aude) [17:17:14] (03PS2) 10Bartosz Dziewoński: Strict standards: Static function PasswordTestCase::providePasswordTests() should not be abstract [core] - 10https://gerrit.wikimedia.org/r/161678 [17:17:19] hoo: that should be better [17:18:03] (03CR) 10Bartosz Dziewoński: UserTest: Fix edit count test which incorrectly added user to db [core] - 10https://gerrit.wikimedia.org/r/161670 (https://bugzilla.wikimedia.org/68626) (owner: 10Aude) [17:18:23] (03CR) 10Bartosz Dziewoński: [C: 032] "Three times the charm?" [core] - 10https://gerrit.wikimedia.org/r/161670 (https://bugzilla.wikimedia.org/68626) (owner: 10Aude) [17:18:31] (03CR) 10Hoo man: [C: 032] Strict standards: Static function PasswordTestCase::providePasswordTests() should not be abstract [core] - 10https://gerrit.wikimedia.org/r/161678 (owner: 10Bartosz Dziewoński) [17:18:58] hope it merges now... [17:21:49] (03CR) 10Wctaiwan: [C: 032] Use canonical parser options when getting targets [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/161644 (owner: 10Legoktm) [17:24:26] (03CR) 10jenkins-bot: [V: 04-1] UserTest: Fix edit count test which incorrectly added user to db [core] - 10https://gerrit.wikimedia.org/r/161670 (https://bugzilla.wikimedia.org/68626) (owner: 10Aude) [17:24:39] hahahaha.... *sigh* [17:24:55] yay jenkins. [17:24:58] /s [17:25:14] the fuck. [17:25:43] (03Merged) 10jenkins-bot: Strict standards: Static function PasswordTestCase::providePasswordTests() should not be abstract [core] - 10https://gerrit.wikimedia.org/r/161678 (owner: 10Bartosz Dziewoński) [17:26:16] (03Merged) 10jenkins-bot: Use canonical parser options when getting targets [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/161644 (owner: 10Legoktm) [17:26:47] hmm. [17:27:22] (03PS2) 10Wctaiwan: Don't require context for MassMessage::submit() [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/161645 (owner: 10Legoktm) [17:28:23] (03CR) 10Wctaiwan: [C: 032] Don't require context for MassMessage::submit() [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/161645 (owner: 10Legoktm) [17:28:31] (03PS5) 10Bartosz Dziewoński: UserTest: Fix edit count test which incorrectly added user to db [core] - 10https://gerrit.wikimedia.org/r/161670 (https://bugzilla.wikimedia.org/68626) (owner: 10Aude) [17:28:53] (03Merged) 10jenkins-bot: Don't require context for MassMessage::submit() [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/161645 (owner: 10Legoktm) [17:29:11] (03CR) 10Bartosz Dziewoński: [C: 032] "I know no proverbs about things failing three times in the row and working the fourth time." [core] - 10https://gerrit.wikimedia.org/r/161670 (https://bugzilla.wikimedia.org/68626) (owner: 10Aude) [17:29:31] i am totally out of snake oil to apply, so i really hope this works. [17:30:38] (03PS6) 10Bartosz Dziewoński: UserTest: Fix edit count test which incorrectly added user to db [core] - 10https://gerrit.wikimedia.org/r/161670 (https://bugzilla.wikimedia.org/68626) (owner: 10Aude) [17:30:54] (03CR) 10Bartosz Dziewoński: [C: 032] "Not making stupid mistakes helps" [core] - 10https://gerrit.wikimedia.org/r/161670 (https://bugzilla.wikimedia.org/68626) (owner: 10Aude) [17:31:49] MatmaRex: doh :D [17:31:56] At least it should be good now [17:35:48] (03CR) 10Bartosz Dziewoński: [C: 032] Unset the preference key before adding it [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/161677 (https://bugzilla.wikimedia.org/71088) (owner: 10Seb35) [17:36:38] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: the VisualEditor section appears before the introduction - 10https://bugzilla.wikimedia.org/71088#c4 (10Bartosz Dziewoński) 5PATC>3RESO/FIX Oh, I misread your solution 1. That also makes sense. Thanks for the patch! [17:37:27] (03CR) 10jenkins-bot: [V: 04-1] UserTest: Fix edit count test which incorrectly added user to db [core] - 10https://gerrit.wikimedia.org/r/161670 (https://bugzilla.wikimedia.org/68626) (owner: 10Aude) [17:37:35] oh fuck me, qunit randomly failed this time. [17:38:22] (03Merged) 10jenkins-bot: Unset the preference key before adding it [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/161677 (https://bugzilla.wikimedia.org/71088) (owner: 10Seb35) [17:38:49] (03PS7) 10Bartosz Dziewoński: UserTest: Fix edit count test which incorrectly added user to db [core] - 10https://gerrit.wikimedia.org/r/161670 (https://bugzilla.wikimedia.org/68626) (owner: 10Aude) [17:45:22] (03CR) 10jenkins-bot: [V: 04-1] UserTest: Fix edit count test which incorrectly added user to db [core] - 10https://gerrit.wikimedia.org/r/161670 (https://bugzilla.wikimedia.org/68626) (owner: 10Aude) [17:47:33] (03PS1) 10Wctaiwan: Integrate normalizeTargets into getTargets [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/161683 [17:53:54] 3MediaWiki / 3Interface: WebKit look wrong - 10https://bugzilla.wikimedia.org/71091 (10paladox2015) 3UNCO p:3Unprio s:3normal a:3None Hi I am running Mediawiki 1.24 wmf 22 to be updated to 1.25 wmf 1 but in mediawiki it looks horrible like it was a few months ago but was fixed the problem has come ba... [17:55:22] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: the VisualEditor section appears before the introduction - 10https://bugzilla.wikimedia.org/71088#c7 (10Seb35) Thanks for merging, Bartosz. I propose a patch for the second solution also, I find it better to check the existence of BetaFeatures. [17:55:32] 3MediaWiki / 3Interface: WebKit look wrong - 10https://bugzilla.wikimedia.org/71091#c1 (10Bartosz Dziewoński) Screenshot? [17:59:25] 3MediaWiki extensions / 3OAuth: mwoauth-form-description-* messages need refreshed parameters documentation - 10https://bugzilla.wikimedia.org/71092 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None Some of these messages have the parameter $5, but from looking at the code in SpecialMWOAuth I am n... [17:59:37] 3MediaWiki extensions / 3OAuth: mwoauth-form-description-* messages need refreshed parameters documentation - 10https://bugzilla.wikimedia.org/71092#c1 (10Amir E. Aharoni) (This probably affects not only translation, but the English messages as well.) [18:03:51] (03PS1) 10Amire80: Add
tags to mwoauth-form-description-* messages [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/161687 [18:05:11] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Okay, so I'm not sure why the tests are failing… but I'm pretty sure we should never be directly calling loadDefaults(). I'll try out some" [core] - 10https://gerrit.wikimedia.org/r/161670 (https://bugzilla.wikimedia.org/68626) (owner: 10Aude) [18:13:37] 3MediaWiki extensions / 3TemplateSandbox: Preview page with this template should be enabled on protected pages - 10https://bugzilla.wikimedia.org/58515#c2 (10Jackmcbarn) As a workaround for this problem, there's a hidden form field called wpTemplateSandboxTemplate that controls which template is replaced. If... [18:15:52] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: the VisualEditor section appears before the introduction - 10https://bugzilla.wikimedia.org/71088#c9 (10Seb35) 5PATC>3RESO/FIX Re-close. Thanks! [18:17:07] 3Wikimedia / 3Site requests: Account creation exemption lift - 10https://bugzilla.wikimedia.org/71090#c5 (10Andre Klapper) Are you asking to allow 3000 people to register? Please clarify. Canonical place for required info: https://meta.wikimedia.org/wiki/Mass_account_creation#Requesting_temporary_lift_of_IP... [18:26:56] (03PS2) 10Bartosz Dziewoński: Populate $features even if there aren't any requirements [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/159538 (https://bugzilla.wikimedia.org/69823) (owner: 10Jforrester) [18:30:07] (03CR) 10Bartosz Dziewoński: [C: 032] Populate $features even if there aren't any requirements [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/159538 (https://bugzilla.wikimedia.org/69823) (owner: 10Jforrester) [18:30:17] (03Merged) 10jenkins-bot: Populate $features even if there aren't any requirements [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/159538 (https://bugzilla.wikimedia.org/69823) (owner: 10Jforrester) [18:32:52] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: wgBetaFeaturesFeatures is incomplete, causing wrong UI in preferences - 10https://bugzilla.wikimedia.org/69823#c6 (10Bartosz Dziewoński) 5PATC>3RESO/FIX Underlying issue is only fixed by James's patch, but Seb35's patch has already fixed the display fo... [18:33:39] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: Warnings about allowed skins are not displayed - 10https://bugzilla.wikimedia.org/70814 (10Bartosz Dziewoński) [18:33:39] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: Some beta features are incorrectly reporting javascript is need (when it is already enabled) - 10https://bugzilla.wikimedia.org/70371 (10Bartosz Dziewoński) 5PATC>3RESO/FIX [18:33:39] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: wgBetaFeaturesFeatures is incomplete, causing wrong UI in preferences - 10https://bugzilla.wikimedia.org/69823 (10Bartosz Dziewoński) [18:37:41] (03PS1) 10Bartosz Dziewoński: Use the existing .client-js class to hide items when JS is enabled [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/161690 [18:38:08] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: wgBetaFeaturesFeatures is incomplete, causing wrong UI in preferences - 10https://bugzilla.wikimedia.org/69823#c7 (10Bartosz Dziewoński) (In reply to Matthew Flaschen from comment #0) > Side note, you can use: > > .client-js .mw-ui-feature-requirements-ja... [18:38:22] 3MediaWiki / 3ContentHandler: Templates in CSS and JS pages should not be expanded - 10https://bugzilla.wikimedia.org/8449#c3 (10Jackmcbarn) This bug also applies to user JS and CSS pages; description updated. (In reply to Nemo from comment #2) > Is this fixed by ContentHandler? No. [18:38:37] 3MediaWiki / 3Templates: Template transclusion done "behind the scenes" when saving a user .js page - 10https://bugzilla.wikimedia.org/8761#c6 (10Jackmcbarn) 5NEW>3RESO/DUP (In reply to Andre Klapper from comment #4) > (In reply to Dan Collins from comment #3) > > This problem may be a duplicate of bug 8... [18:38:37] 3MediaWiki / 3ContentHandler: Templates in CSS and JS pages should not be expanded - 10https://bugzilla.wikimedia.org/8449#c4 (10Jackmcbarn) *** Bug 8761 has been marked as a duplicate of this bug. *** [18:40:07] 3MediaWiki extensions / 3ParserFunctions: including text elsewhere on the page - 10https://bugzilla.wikimedia.org/17757#c2 (10Jackmcbarn) 5NEW>3RESO/INV This is outside the scope of ParserFunctions. https://www.mediawiki.org/wiki/Extension:Variables does exactly what you want. [18:41:39] (03PS8) 10Bartosz Dziewoński: UserTest: Fix edit count test which incorrectly added user to db [core] - 10https://gerrit.wikimedia.org/r/161670 (https://bugzilla.wikimedia.org/68626) (owner: 10Aude) [18:44:36] 3MediaWiki / 3Templates: REVISIONID cannot be substituted - 10https://bugzilla.wikimedia.org/6181#c13 (10Jackmcbarn) (In reply to James Forrester from comment #8) > Possibly for consistency we could disable subst:'ing of the rest of the > revision-time information magic words – REVISIONDAY, REVISIONDAY2, > R... [18:45:07] 3Wikimedia / 3Site requests: Account creation exemption lift - 10https://bugzilla.wikimedia.org/71090#c6 (10Sydney Poore) There will 3000 people attending the conference but only a fraction of them will be attending sessions where they will create new accounts. But the number will still be over the usual lim... [18:47:43] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Does not merge." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/122086 (https://bugzilla.wikimedia.org/62897) (owner: 10Legoktm) [18:47:49] legoktm: around? [18:48:14] (03CR) 10jenkins-bot: [V: 04-1] UserTest: Fix edit count test which incorrectly added user to db [core] - 10https://gerrit.wikimedia.org/r/161670 (https://bugzilla.wikimedia.org/68626) (owner: 10Aude) [18:49:51] 3Wikimedia / 3Site requests: Account creation exemption lift - 10https://bugzilla.wikimedia.org/71090#c7 (10James Heilman) 100 people per day should be enough J [18:50:03] (03CR) 10Bartosz Dziewoński: "I am certain this is correct now. I don't know why it's failing." [core] - 10https://gerrit.wikimedia.org/r/161670 (https://bugzilla.wikimedia.org/68626) (owner: 10Aude) [18:50:09] 3MediaWiki extensions / 3[other]: Parameterless templates incorrectly cache dynamic functions - 10https://bugzilla.wikimedia.org/58929#c1 (10Jackmcbarn) The core now supports this via PPFrame::setVolatile(). Any extensions that still exhibit the problem require a fix to the extension itself. [18:53:24] 3MediaWiki / 3Templates: Template transclusion done "behind the scenes" when saving a user .js page - 10https://bugzilla.wikimedia.org/8761#c7 (10Helder) 5RESO/DUP>3REOP This is not a duplicate. See comment 5. [18:53:24] 3MediaWiki / 3ContentHandler: Templates in CSS and JS pages should not be expanded - 10https://bugzilla.wikimedia.org/8449#c5 (10Helder) 5NEW>3RESO/FIX This is fixed, since https://ca.wikipedia.org/w/index.php?title=MediaWiki:Common.js&action=raw&ctype=text/javascript keeps every ocurrence of "{{referènc... [18:53:45] (03PS1) 10Bartosz Dziewoński: HTMLFeatureFieldTest: Set $wgWellFormedXml = true [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/161693 (https://bugzilla.wikimedia.org/68823) [18:54:40] legoktm: never mind [19:00:37] 3MediaWiki / 3Interface: WebKit look wrong - 10https://bugzilla.wikimedia.org/71091#c2 (10paladox2015) Created attachment 16527 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16527&action=edit A screenshot Please use chrome or safari. This is a htm file. [19:06:42] (03CR) 10Prtksxna: "Matt, this is still a WIP. Which is why I had -2'd it." [core] - 10https://gerrit.wikimedia.org/r/161261 (https://bugzilla.wikimedia.org/70909) (owner: 10Prtksxna) [19:07:29] (03CR) 10Seb35: [C: 031] "Tested (with Opera). Works fine." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/161690 (owner: 10Bartosz Dziewoński) [19:08:07] 3MediaWiki extensions / 3[other]: Parameterless templates incorrectly cache dynamic functions - 10https://bugzilla.wikimedia.org/58929#c2 (10Jackmcbarn) 5NEW>3RESO/FIX I've fixed the DynamicFunctions extension. See https://www.mediawiki.org/w/index.php?diff=1175414 for the fix. Note that unless you upgra... [19:10:06] 3MediaWiki / 3ContentHandler: Templates in CSS and JS pages should not be expanded - 10https://bugzilla.wikimedia.org/8449#c6 (10Jackmcbarn) 5RESO/FIX>3REOP It's not actually completely fixed. Things like subst still present a problem, and pages still end up in erroneous categories. [19:11:19] (03PS1) 10Bartosz Dziewoński: Provide styles when JavaScript is disabled [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/161694 (https://bugzilla.wikimedia.org/69778) [19:11:22] 3MediaWiki / 3Templates: Template transclusion done "behind the scenes" when saving a user .js page - 10https://bugzilla.wikimedia.org/8761#c8 (10Jackmcbarn) IMO, bug 8449 was never completely fixed, and this is just another symptom of it. [19:11:25] (03PS1) 10Bartosz Dziewoński: Remove unused JS checkbox code [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/161695 [19:14:21] (03CR) 10Bartosz Dziewoński: "Follow-up to remove more unused code: https://gerrit.wikimedia.org/r/#/c/161695/" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/149122 (owner: 10Jdlrobson) [19:18:01] (03Abandoned) 10Bartosz Dziewoński: Hide the 'JavaScript needed' warning reliably [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/159098 (https://bugzilla.wikimedia.org/70371) (owner: 10Jforrester) [19:25:06] 3MediaWiki / 3Page editing: Collapse templates in editor - 10https://bugzilla.wikimedia.org/28684 (10Jackmcbarn) [19:26:38] 3MediaWiki / 3Interface: WebKit look wrong - 10https://bugzilla.wikimedia.org/71091#c3 (10Bartosz Dziewoński) A HTM file is not a screenshot. I can not reproduce this bug. [19:27:22] 3MediaWiki / 3Interface: WebKit look wrong - 10https://bugzilla.wikimedia.org/71091#c4 (10Andre Klapper) 5UNCO>3RESO/WOR Me neither. Please provide a screenshot. See https://en.wikipedia.org/wiki/Screenshot [19:27:52] (03CR) 10Bartosz Dziewoński: [C: 032] Automatic direction for the license in Special:Version [core] - 10https://gerrit.wikimedia.org/r/147734 (owner: 10Amire80) [19:28:08] 3MediaWiki / 3Templates: Force a magic word to apply to the included page - 10https://bugzilla.wikimedia.org/8982#c2 (10Jackmcbarn) 5NEW>3RESO/INV I can't make sense of what's being asked for here, and this is 7 years old. Closing. Note that you can use {{REVISIONMONTH}}, etc. on other pages by doing {{... [19:32:22] 3MediaWiki / 3Templates: Add a magic word for the document protocol - 10https://bugzilla.wikimedia.org/26623#c2 (10Jackmcbarn) 5NEW>3RESO/WON It sounds like you're asking for a parser function that emits "http" when viewed from "http://wiki.example/Some_page", and "https" from "https://wiki.example/Some_... [19:32:51] bd808|BUFFER, around? labs vagrant provisioning is barfing -- PHP Warning: chdir(): Permission denied (errno 13) in /var/www/w/MWVersion.php on line 62 [19:33:04] running labs-vagrant provision [19:33:04] as a root [19:34:33] (03Merged) 10jenkins-bot: Automatic direction for the license in Special:Version [core] - 10https://gerrit.wikimedia.org/r/147734 (owner: 10Amire80) [19:35:51] 3MediaWiki extensions / 3ParserFunctions: Add parser function to verify that a string is a valid language code - 10https://bugzilla.wikimedia.org/35752#c4 (10Jackmcbarn) 5NEW>3RESO/WON (In reply to Siebrand Mazeland from comment #1) > Could be a use case for Lua, but not as a parser function. Wikitext is... [19:36:38] 3MediaWiki / 3Interface: WebKit look wrong - 10https://bugzilla.wikimedia.org/71091#c5 (10Andre Klapper) ...plus version 1.25 wmf1 does not even exist yet. > steps to reproduce is go to mediawiki Those are not "steps to reproduce". See https://www.mediawiki.org/wiki/How_to_report_a_bug for how to provide p... [19:38:22] 3MediaWiki extensions / 3ParserFunctions: add tracking category for time errors - 10https://bugzilla.wikimedia.org/61425#c1 (10Jackmcbarn) You can already do this by adding the category to [[MediaWiki:Pfunc time error]] (and the other time error messages). [19:39:36] 3MediaWiki extensions / 3ParserFunctions: add tracking category for expression errors - 10https://bugzilla.wikimedia.org/23959#c5 (10Jackmcbarn) You can already do this by adding the category to [[MediaWiki:Pfunc expr unexpected number]] (and the other expression error messages). [19:43:07] 3MediaWiki extensions / 3ParserFunctions: Add a parser function to return the fallback language for a given language code - 10https://bugzilla.wikimedia.org/28596#c7 (10Jackmcbarn) 5NEW>3RESO/WON Scribunto now exposes this via mw.language.getFallbacksFor(). Adding a parser function to do it would seem to... [19:44:39] 3MediaWiki-Vagrant / 3labs-vagrant: labs-vagrant provision fails on existing instance - 10https://bugzilla.wikimedia.org/71093 (10Yuri Astrakhan) 3NEW p:3Unprio s:3normal a:3None vagrant 9c2935d7b656473b77825a1effd2e45b51a5f6b1 when running labs provision on an existing instance: See http://pastebin... [19:48:52] 3MediaWiki / 3Parser: Bracketing violation parsing template parameters and surrounding HTML code - 10https://bugzilla.wikimedia.org/33815#c2 (10Jackmcbarn) This has nothing to do with templates. The same behavior is also exhibited with the following wikitext:
This is an unordered list: * foo * bar * ba... [19:54:49] (03PS7) 10Umherirrender: Set mw.config wgFileCanRotate only on Special:Upload instead of site-wide [core] - 10https://gerrit.wikimedia.org/r/132017 (owner: 10Gerrit Patch Uploader) [19:55:17] (03CR) 10Umherirrender: "Patch Set 7: Rebased and moved release notes to 1.25" [core] - 10https://gerrit.wikimedia.org/r/132017 (owner: 10Gerrit Patch Uploader) [19:57:02] (03CR) 10Bartosz Dziewoński: [C: 032] Set mw.config wgFileCanRotate only on Special:Upload instead of site-wide [core] - 10https://gerrit.wikimedia.org/r/132017 (owner: 10Gerrit Patch Uploader) [20:03:24] (03Merged) 10jenkins-bot: Set mw.config wgFileCanRotate only on Special:Upload instead of site-wide [core] - 10https://gerrit.wikimedia.org/r/132017 (owner: 10Gerrit Patch Uploader) [20:06:29] (03PS3) 10Bartosz Dziewoński: [DO NOT MERGE] mediawiki.action.view.redirect: Remove deployment hack [core] - 10https://gerrit.wikimedia.org/r/157183 [20:06:41] (03CR) 10Bartosz Dziewoński: "Rebased." [core] - 10https://gerrit.wikimedia.org/r/157183 (owner: 10Bartosz Dziewoński) [20:06:52] (03PS1) 10Bartosz Dziewoński: mediawiki.action.view.redirect: Remove deployment hack [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/161747 [20:10:54] 3MediaWiki extensions / 3ParserFunctions: Add parser function to verify that a string is a valid language code - 10https://bugzilla.wikimedia.org/35752#c5 (10Nemo) (In reply to Jackmcbarn from comment #4) > I see no reason we should add a > parser function to do it. Well, the reason is explained in comment... [20:11:37] (03Abandoned) 10Bartosz Dziewoński: Inline confirmation for rollback links [core] - 10https://gerrit.wikimedia.org/r/90729 (owner: 10Bartosz Dziewoński) [20:13:04] (03CR) 10Umherirrender: [C: 032] mediawiki.action.view.redirect: Remove deployment hack [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/161747 (owner: 10Bartosz Dziewoński) [20:13:33] (03CR) 10Bartosz Dziewoński: "This patch is targeting MW 1.24. Expedited reviews, please? :)" [core] - 10https://gerrit.wikimedia.org/r/161465 (https://bugzilla.wikimedia.org/70855) (owner: 10Bartosz Dziewoński) [20:14:01] (03CR) 10Bartosz Dziewoński: "This patch is targeting MW 1.24. Expedited reviews, please? :)" [core] - 10https://gerrit.wikimedia.org/r/161245 (https://bugzilla.wikimedia.org/67368) (owner: 10Bartosz Dziewoński) [20:15:32] (03CR) 10Bartosz Dziewoński: "This should be backported to MW 1.24. I expected that it would get merged quicker…" [core] - 10https://gerrit.wikimedia.org/r/160067 (owner: 10Bartosz Dziewoński) [20:16:06] 3MediaWiki extensions / 3Translate: Add {{#translation}} as parser function in the Translate extension - 10https://bugzilla.wikimedia.org/68385#c12 (10Nemo) 5NEW>3RESO/FIX 1.24 was branched, let's have a closed bug against 1.24 for bugzilla searchers. (In reply to Nemo from comment #10) > (In reply to P... [20:16:50] (03Abandoned) 10Bartosz Dziewoński: Allow skins to provide a screenshot for Special:Version [core] - 10https://gerrit.wikimedia.org/r/138110 (owner: 10Bartosz Dziewoński) [20:19:31] (03Merged) 10jenkins-bot: mediawiki.action.view.redirect: Remove deployment hack [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/161747 (owner: 10Bartosz Dziewoński) [20:20:52] 3MediaWiki / 3Interface: WebKit look wrong - 10https://bugzilla.wikimedia.org/71091#c6 (10paladox2015) Created attachment 16528 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16528&action=edit Screenshot on chrome Screenshot of mediawiki on chrome. [20:28:23] (03PS5) 10Krinkle: Fix CSSJanus flipping in LESS mixins and remove broken custom LESS functions [core] - 10https://gerrit.wikimedia.org/r/161245 (https://bugzilla.wikimedia.org/67368) (owner: 10Bartosz Dziewoński) [20:28:59] (03CR) 10Jforrester: ":-(" [core] - 10https://gerrit.wikimedia.org/r/90729 (owner: 10Bartosz Dziewoński) [20:37:15] (03PS11) 10Bartosz Dziewoński: mediawiki.user: Remove deprecated name() and anonymous() methods [core] - 10https://gerrit.wikimedia.org/r/111422 (owner: 10Ori.livneh) [20:37:17] (03PS12) 10Bartosz Dziewoński: mediawiki.api: Remove deprecated function parameters [core] - 10https://gerrit.wikimedia.org/r/118733 [20:37:18] If I want to change the markup of XML::dateMenu should I do it in the the method itself or make a copy of it? Its being used in HistoryAction, LogEventList and SpecialContributions (the place where I need it changed) [20:37:44] (03CR) 10Bartosz Dziewoński: "Rebased, retargeted for MW 1.25." [core] - 10https://gerrit.wikimedia.org/r/111422 (owner: 10Ori.livneh) [20:38:01] (03CR) 10Bartosz Dziewoński: "Rebased, retargeted for MW 1.25." [core] - 10https://gerrit.wikimedia.org/r/118733 (owner: 10Bartosz Dziewoński) [20:39:16] prtksxna: if the change you want to make will work everywhere, fix the method; if not, fix the caller [20:41:23] 3MediaWiki / 3Interface: WebKit look wrong - 10https://bugzilla.wikimedia.org/71091#c7 (10Andre Klapper) Looks perfectly correct. A good bug report should describe the actual problem. [20:42:01] MatmaRex: A little work will have to be done to make it work at other places. But we'll have to do that anyway if we want to use mw.ui at those places [20:43:33] MatmaRex: And I don't want to do that all in one commit [20:44:18] MatmaRex: It seems that something will be broken for a while (by a while I mean between commits) [20:45:20] that's probably reasonable [20:45:39] is it impossible to make the changed to dateMenu() non-breaking? [20:45:52] (03PS5) 10Bartosz Dziewoński: Move default logo to resources/assets/ directory [core] - 10https://gerrit.wikimedia.org/r/159290 (https://bugzilla.wikimedia.org/69277) [20:46:08] It shouldn't break anything, just that there might be useless markup (extra divs) for a while [20:46:30] Or maybe even classes [20:46:37] (03CR) 10Bartosz Dziewoński: "Let's do this? Needs a backport to 1.24." [core] - 10https://gerrit.wikimedia.org/r/159290 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [20:46:48] prtksxna: i don't think that's a problem [20:46:53] :D [20:47:01] Awesome :) [20:49:54] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: wgBetaFeaturesFeatures is incomplete, causing wrong UI in preferences - 10https://bugzilla.wikimedia.org/69823 (10James Forrester) a:3Bartosz Dziewoński [20:50:14] (03CR) 10Jforrester: [C: 032] Use the existing .client-js class to hide items when JS is enabled [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/161690 (owner: 10Bartosz Dziewoński) [20:50:23] (03Merged) 10jenkins-bot: Use the existing .client-js class to hide items when JS is enabled [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/161690 (owner: 10Bartosz Dziewoński) [20:54:40] (03PS1) 10Aaron Schulz: Slave lag check tweaks to JobRunner [core] - 10https://gerrit.wikimedia.org/r/161749 [20:55:25] 3MediaWiki extensions / 3Collection: Problem when rendering footnotes (references) - 10https://bugzilla.wikimedia.org/71094 (10T. Gries) 3NEW p:3Unprio s:3normal a:3None RE: https://de.wikipedia.org/wiki/Herbert_Mataré When rendering this article, I noticed, that the reference number 3 (after "… an... [20:56:23] 3MediaWiki / 3Interface: WebKit look wrong - 10https://bugzilla.wikimedia.org/71091#c8 (10paladox2015) The problem is that in chrome it doesent look like it is in high def. [20:57:17] (03CR) 10Krinkle: [C: 031] "This changes and increases CSS output from:" [core] - 10https://gerrit.wikimedia.org/r/161245 (https://bugzilla.wikimedia.org/67368) (owner: 10Bartosz Dziewoński) [20:58:07] (03CR) 10Bartosz Dziewoński: "I know. I filed bug 71003 about that." [core] - 10https://gerrit.wikimedia.org/r/161245 (https://bugzilla.wikimedia.org/67368) (owner: 10Bartosz Dziewoński) [20:58:51] (03CR) 10Krinkle: [C: 032] Fix CSSJanus flipping in LESS mixins and remove broken custom LESS functions [core] - 10https://gerrit.wikimedia.org/r/161245 (https://bugzilla.wikimedia.org/67368) (owner: 10Bartosz Dziewoński) [20:59:31] (03PS1) 10Krinkle: Fix CSSJanus flipping in LESS mixins and remove broken custom LESS functions [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/161751 (https://bugzilla.wikimedia.org/67368) [21:00:12] (03CR) 10Krinkle: [C: 032] Fix CSSJanus flipping in LESS mixins and remove broken custom LESS functions [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/161751 (https://bugzilla.wikimedia.org/67368) (owner: 10Krinkle) [21:00:20] (03CR) 10Jforrester: [C: 032] Provide styles when JavaScript is disabled [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/161694 (https://bugzilla.wikimedia.org/69778) (owner: 10Bartosz Dziewoński) [21:00:52] 3MediaWiki / 3ResourceLoader: CSSMin: Don't generate double rules for IE < 8 when embedding SVG files - 10https://bugzilla.wikimedia.org/71003 (10Krinkle) [21:01:09] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: Settings pane looks ugly with JavaScript disabled - 10https://bugzilla.wikimedia.org/69778 (10James Forrester) 5PATC>3RESO/FIX a:3Bartosz Dziewoński [21:01:27] MatmaRex: Are you interested in working on fixing CSSMin to support @embed/@noflip so that we don't need that patch in CSSJanus that removes the @noflip comment? [21:01:48] I'm currently working on unifying cssjanus-node/php/python and in backporting patches from the PHP side, I decided to drop that one [21:01:58] It breaks round-tripping and removes information it shouldn't remove. [21:02:39] Basically revert https://github.com/wikimedia/mediawiki-core/commit/2d842f14250646475b5c2ffa2fe4f5a131f94236 and fix another way [21:05:32] (03Merged) 10jenkins-bot: Fix CSSJanus flipping in LESS mixins and remove broken custom LESS functions [core] - 10https://gerrit.wikimedia.org/r/161245 (https://bugzilla.wikimedia.org/67368) (owner: 10Bartosz Dziewoński) [21:05:41] (03CR) 10Aaron Schulz: [C: 032] DatabaseMysqlBase: Use VERSION() rather than server_info [core] - 10https://gerrit.wikimedia.org/r/161652 (owner: 10PleaseStand) [21:06:59] (03Merged) 10jenkins-bot: Fix CSSJanus flipping in LESS mixins and remove broken custom LESS functions [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/161751 (https://bugzilla.wikimedia.org/67368) (owner: 10Krinkle) [21:07:08] Krinkle: what you're asking me for is to make the regexes cssjanus uses even more horrible. [21:07:15] (03Merged) 10jenkins-bot: Provide styles when JavaScript is disabled [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/161694 (https://bugzilla.wikimedia.org/69778) (owner: 10Bartosz Dziewoński) [21:07:38] i can do that, but it seemed more evil than that patch when i was doing it. [21:09:01] (03PS1) 10Krinkle: maintenance: Remove cssjanus.py [core] - 10https://gerrit.wikimedia.org/r/161752 [21:09:31] (03CR) 10jenkins-bot: [V: 04-1] maintenance: Remove cssjanus.py [core] - 10https://gerrit.wikimedia.org/r/161752 (owner: 10Krinkle) [21:10:02] (03PS2) 10Krinkle: maintenance: Remove cssjanus.py [core] - 10https://gerrit.wikimedia.org/r/161752 [21:10:04] (03CR) 10Bartosz Dziewoński: "1.24?" [core] - 10https://gerrit.wikimedia.org/r/161752 (owner: 10Krinkle) [21:10:05] MatmaRex: Well, yeah. [21:11:24] 3MediaWiki / 3ResourceLoader: LESS compiler should preserve the position of CSSMin / CSSJanus annotations - 10https://bugzilla.wikimedia.org/54673 (10Bartosz Dziewoński) [21:11:24] 3MediaWiki / 3ResourceLoader: ResourceLoader: Remove custom LESS functions - 10https://bugzilla.wikimedia.org/67368 (10Bartosz Dziewoński) 5PATC>3RESO/FIX [21:11:29] (03CR) 10Krinkle: [C: 04-1] "Please provide non-theoretical use cases for when and where these would be used." [core] - 10https://gerrit.wikimedia.org/r/161051 (owner: 10SG) [21:11:39] 3MediaWiki / 3Interface: Arrow with mw-icon-arrow-collapsed points the wrong way in RTL wikis - 10https://bugzilla.wikimedia.org/66773#c7 (10Bartosz Dziewoński) 5PATC>3RESO/DUP *** This bug has been marked as a duplicate of bug 66091 *** [21:11:39] 3MediaWiki / 3ResourceLoader: ResourceLoaderLESSFunctions::embed does not support CSSJanus flipping for RTL, affecting .background-image-svg() and others - 10https://bugzilla.wikimedia.org/66091#c12 (10Bartosz Dziewoński) *** Bug 66773 has been marked as a duplicate of this bug. *** [21:12:03] (03CR) 10Krinkle: "(In the commit message)" [core] - 10https://gerrit.wikimedia.org/r/161051 (owner: 10SG) [21:12:08] 3MediaWiki / 3ResourceLoader: ResourceLoaderLESSFunctions::embed does not support CSSJanus flipping for RTL, affecting .background-image-svg() and others - 10https://bugzilla.wikimedia.org/66091#c13 (10Bartosz Dziewoński) *** Bug 68326 has been marked as a duplicate of this bug. *** [21:12:08] 3MediaWiki / 3ResourceLoader: External link icon is not flipped in RTL - 10https://bugzilla.wikimedia.org/68326#c7 (10Bartosz Dziewoński) 5PATC>3RESO/DUP *** This bug has been marked as a duplicate of bug 66091 *** [21:12:22] 3MediaWiki / 3ResourceLoader: ResourceLoaderLESSFunctions::embed does not support CSSJanus flipping for RTL, affecting .background-image-svg() and others - 10https://bugzilla.wikimedia.org/66091#c14 (10Bartosz Dziewoński) 5PATC>3RESO/FIX Fixed and backported. [21:12:38] (03Merged) 10jenkins-bot: DatabaseMysqlBase: Use VERSION() rather than server_info [core] - 10https://gerrit.wikimedia.org/r/161652 (owner: 10PleaseStand) [21:12:39] 3MediaWiki / 3Interface: Arrow with mw-icon-arrow-collapsed points the wrong way in RTL wikis - 10https://bugzilla.wikimedia.org/66773 (10Bartosz Dziewoński) [21:12:53] Krinkle: alright. [21:14:16] https://www.mediawiki.org/wiki/Requests_for_comment/CentralNotice_backend_improvements is a good read. [21:16:53] 3MediaWiki / 3User preferences: Changes to user preferences should be automatically saved - 10https://bugzilla.wikimedia.org/56561#c6 (10Jared Zimmerman (WMF)) would submitting the whole form give us bad data in our preference logging schema? e.g. would we be submitting that a user had "changed" a value from... [21:18:36] https://bugzilla.wikimedia.org/show_bug.cgi?id=67835#c1 <-- I heh'd. [21:19:51] 3MediaWiki extensions / 3WikimediaEvents: The HHVM BetaFeature needs an image - 10https://bugzilla.wikimedia.org/71048#c6 (10Jared Zimmerman (WMF)) I talked to Ori friday, he's fine with the proposed text. We also need to convert the talk page to a flow enabled one. Ori will work with the Flow team on this. [21:20:15] Krinkle: did you mean to target https://gerrit.wikimedia.org/r/#/c/161752/ for 1.24? [21:20:24] MatmaRex: Yes [21:20:41] (03CR) 10Bartosz Dziewoński: [C: 032] maintenance: Remove cssjanus.py [core] - 10https://gerrit.wikimedia.org/r/161752 (owner: 10Krinkle) [21:20:52] (03PS1) 10Bartosz Dziewoński: maintenance: Remove cssjanus.py [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/161753 [21:20:57] (03CR) 10Bartosz Dziewoński: [C: 032] maintenance: Remove cssjanus.py [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/161753 (owner: 10Bartosz Dziewoński) [21:21:01] Thx [21:21:37] 3MediaWiki extensions / 3WikimediaEvents: The HHVM BetaFeature needs an image - 10https://bugzilla.wikimedia.org/71048#c7 (10Jared Zimmerman (WMF)) Danny/S we need to Flow enable https://www.mediawiki.org/wiki/Talk:HHVM/About can you please work with Ori if you have any questions or clarifications. [21:23:52] 3MediaWiki / 3MediaWiki UI: checkboxes hover and click states are not to spec - 10https://bugzilla.wikimedia.org/70909#c3 (10Jared Zimmerman (WMF)) focus = hover in this case. We're handling the keyboard/accessibility focus in a separate bug. [21:26:46] (03PS1) 10Bartosz Dziewoński: Make "/*@noflip*/ /*@embed*/" annotation work without CSSJanus hacks [core] - 10https://gerrit.wikimedia.org/r/161754 [21:27:04] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Not implemented yet." [core] - 10https://gerrit.wikimedia.org/r/161754 (owner: 10Bartosz Dziewoński) [21:27:34] (03Merged) 10jenkins-bot: maintenance: Remove cssjanus.py [core] - 10https://gerrit.wikimedia.org/r/161752 (owner: 10Krinkle) [21:28:05] (03Merged) 10jenkins-bot: maintenance: Remove cssjanus.py [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/161753 (owner: 10Bartosz Dziewoński) [21:33:50] (03CR) 10jenkins-bot: [V: 04-1] Make "/*@noflip*/ /*@embed*/" annotation work without CSSJanus hacks [core] - 10https://gerrit.wikimedia.org/r/161754 (owner: 10Bartosz Dziewoński) [21:40:04] spagewmf: Where did you say was the vform that has elements side by side? [21:58:13] (03PS9) 10Aude: UserTest: Fix edit count test which incorrectly added user to db [core] - 10https://gerrit.wikimedia.org/r/161670 (https://bugzilla.wikimedia.org/68626) [22:03:23] (03PS2) 10Aaron Schulz: Limit new active DB connections in waitForAll() to one [core] - 10https://gerrit.wikimedia.org/r/161500 [22:24:18] (03CR) 10Hoo man: [C: 032] "Finally :)" [core] - 10https://gerrit.wikimedia.org/r/161670 (https://bugzilla.wikimedia.org/68626) (owner: 10Aude) [22:25:27] \o/ [22:26:39] 3MediaWiki / 3Categories: Categories should not be rendered in a table (do not display well on mobile) - 10https://bugzilla.wikimedia.org/53130#c6 (10Matthias Becker) Actually the user should be able to adjust the number of columns shown in his preferences. Me for example often works in categories with typic... [22:30:54] (03Merged) 10jenkins-bot: UserTest: Fix edit count test which incorrectly added user to db [core] - 10https://gerrit.wikimedia.org/r/161670 (https://bugzilla.wikimedia.org/68626) (owner: 10Aude) [22:41:39] 3Wikimedia / 3Site requests: Account creation exemption lift - 10https://bugzilla.wikimedia.org/71090 (10Andre Klapper) p:5Unprio>3Highes s:5normal>3enhanc [22:42:37] 3MediaWiki extensions / 3BetaFeatures: Fatal error: Call to a member function getOption() on a non-object in extensions/BetaFeatures/BetaFeaturesHooks.php on line 115 - 10https://bugzilla.wikimedia.org/68626 (10Aude) 5PATC>3RESO/FIX [22:45:53] 3MediaWiki / 3General/Unknown: Redirect does not appear in browser histori - 10https://bugzilla.wikimedia.org/70962#c3 (10Matthias Becker) 5RESO/INV>3REOP I think you misunderstood. I now searched and found the reason of my bug report. Implementing gerrit 143852 is the bug. This never should have been d... [22:46:09] 3MediaWiki extensions / 3BetaFeatures: Fatal error: Call to a member function getOption() on a non-object in extensions/BetaFeatures/BetaFeaturesHooks.php on line 115 - 10https://bugzilla.wikimedia.org/68626 (10James Forrester) a:3Aude [22:51:37] 3MediaWiki / 3General/Unknown: Redirect does not appear in browser histori - 10https://bugzilla.wikimedia.org/70962#c4 (10MZMcBride) (In reply to Matthias Becker from comment #3) > Implementing Gerrit change #143852 is the bug. This never should have been > done. For users who work to fix redirects this new... [22:52:07] 3MediaWiki / 3Interface: WebKit look wrong - 10https://bugzilla.wikimedia.org/71091#c9 (10Andre Klapper) If there is some difference, please provide screenshots to compare (either a different browser not affected, or a different page which is still running an older MediaWiki version). [22:56:55] 3MediaWiki / 3General/Unknown: Redirect does not appear in browser history - 10https://bugzilla.wikimedia.org/70962 (10MZMcBride) [22:56:55] 3MediaWiki / 3Redirects: Use history.replaceState to rewrite redirect urls - 10https://bugzilla.wikimedia.org/35045#c18 (10Matthias Becker) I consider resolving this bug IS a bug. For people who work with redirects, as for example fixing them, moving pages and so on, after looking into another page like the... [22:59:53] (03CR) 10Fomafix: mediawiki.api: Remove deprecated function parameters (032 comments) [core] - 10https://gerrit.wikimedia.org/r/118733 (owner: 10Bartosz Dziewoński) [22:59:53] 3MediaWiki / 3General/Unknown: Redirect does not appear in browser history - 10https://bugzilla.wikimedia.org/70962 (10Andre Klapper) [22:59:54] 3MediaWiki / 3Redirects: Use history.replaceState to rewrite redirect urls - 10https://bugzilla.wikimedia.org/35045 (10Andre Klapper) [23:10:42] (03PS1) 10PleaseStand: Revert "maintenance: Remove cssjanus.py" [core] - 10https://gerrit.wikimedia.org/r/161761 [23:11:21] (03PS2) 10PleaseStand: Revert "maintenance: Remove cssjanus.py" [core] - 10https://gerrit.wikimedia.org/r/161761 [23:12:07] 3MediaWiki / 3General/Unknown: Redirect does not appear in browser history - 10https://bugzilla.wikimedia.org/70962#c5 (10Nathan Ridge) (In reply to MZMcBride from comment #4) > However, I like the fact that the URL now updates for redirects and I don't > imagine this feature will be reverted. +1 I describ... [23:23:08] (03CR) 10Krinkle: [C: 04-1] "This is not related to skins, and should also not be extending a legacy module. There's plenty of places for this to go. One I can think o" [core] - 10https://gerrit.wikimedia.org/r/147733 (owner: 10Amire80) [23:24:23] (03PS1) 10Mormegil: Fix special case at Special:MediaStatistics [core] - 10https://gerrit.wikimedia.org/r/161762 [23:24:45] (03CR) 10Krinkle: Bidi-isolate extension version on Special:Version (031 comment) [core] - 10https://gerrit.wikimedia.org/r/147733 (owner: 10Amire80) [23:42:41] (03CR) 10Krinkle: "No?" [core] - 10https://gerrit.wikimedia.org/r/161761 (owner: 10PleaseStand) [23:42:53] 3MediaWiki / 3MediaWiki UI: MediaWiki UI styles are applied to core instead of relevant skins, not overridable - 10https://bugzilla.wikimedia.org/70351#c22 (10Isarra) Quiddity got a lot of it, I think. (In reply to Matthew Flaschen from comment #19) > MediaWiki has never been fully backwards compatible wit... [23:58:43] (03PS12) 10Krinkle: mediawiki.user: Remove deprecated name() and anonymous() methods [core] - 10https://gerrit.wikimedia.org/r/111422 (owner: 10Ori.livneh) [23:58:54] (03PS13) 10Krinkle: mediawiki.api: Remove deprecated function parameters [core] - 10https://gerrit.wikimedia.org/r/118733 (owner: 10Bartosz Dziewoński)