[00:00:55] (03PS3) 10MaxSem: Add a hook to allow extensions to prevent HTML file caching [core] - 10https://gerrit.wikimedia.org/r/160563 (https://bugzilla.wikimedia.org/68106) [00:01:14] AaronS, ^ [00:02:09] (03CR) 10Aaron Schulz: [C: 032] Add a hook to allow extensions to prevent HTML file caching [core] - 10https://gerrit.wikimedia.org/r/160563 (https://bugzilla.wikimedia.org/68106) (owner: 10MaxSem) [00:02:17] thanks :) [00:02:26] any time, poker face [00:07:53] (03PS4) 10Aaron Schulz: Deprecate HTMLFileCache::newFromTitle() in favor of constructor [core] - 10https://gerrit.wikimedia.org/r/160547 (owner: 10MaxSem) [00:08:36] 3Wikimedia / 3Deployment systems: Update wikitech wiki with deployment train - 10https://bugzilla.wikimedia.org/68751 (10Alex Monk) [00:08:46] (03CR) 10Mattflaschen: "> The alternative is to create a separate class for mw-ui-text, but that seems a bit redundant. I was really trying to avoid that." [core] - 10https://gerrit.wikimedia.org/r/155856 (https://bugzilla.wikimedia.org/69212) (owner: 10SG) [00:09:00] (03Merged) 10jenkins-bot: Add a hook to allow extensions to prevent HTML file caching [core] - 10https://gerrit.wikimedia.org/r/160563 (https://bugzilla.wikimedia.org/68106) (owner: 10MaxSem) [00:09:19] !worstcase | wctaiwan [00:09:19] wctaiwan: Generally, the worst that can happen is that someone compromises your site, steals your data, deletes it and replaces it with kiddy porn. Then they start a spam service on your server advertising the kiddy porn to twenty million email addresses, daily. Then your home gets raided, you get fired and your wife leaves you. Then you get killed in your sleep by ninjas. [00:09:29] :> [00:09:42] thanks matanya [00:09:43] er [00:09:45] MatmaRex:** [00:09:46] sorry. [00:17:46] (03PS1) 10Cscott: Merge branch 'master' into wmf-deploy [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/161394 [00:17:48] (03PS1) 10Cscott: Rebuilt dependencies. [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/161395 [00:17:54] (03CR) 10Aaron Schulz: [C: 032] Deprecate HTMLFileCache::newFromTitle() in favor of constructor [core] - 10https://gerrit.wikimedia.org/r/160547 (owner: 10MaxSem) [00:18:55] (03CR) 10Cscott: [C: 032 V: 032] Merge branch 'master' into wmf-deploy [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/161394 (owner: 10Cscott) [00:20:16] (03CR) 10Cscott: [C: 032 V: 032] Rebuilt dependencies. [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/161395 (owner: 10Cscott) [00:22:46] (03PS1) 10Ori.livneh: Lowercase HHVM cookie name [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/161396 [00:22:48] ^ legoktm [00:22:52] legoktm: not case-insensitive :/ [00:23:08] (03PS1) 10Ori.livneh: Lowercase HHVM cookie name [extensions/WikimediaEvents] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161397 [00:23:26] (03CR) 10Ori.livneh: [C: 032] Lowercase HHVM cookie name [extensions/WikimediaEvents] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161397 (owner: 10Ori.livneh) [00:23:38] (03PS1) 10Ori.livneh: Lowercase HHVM cookie name [extensions/WikimediaEvents] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/161398 [00:23:49] (03CR) 10Ori.livneh: [C: 032] Lowercase HHVM cookie name [extensions/WikimediaEvents] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/161398 (owner: 10Ori.livneh) [00:24:18] (03Merged) 10jenkins-bot: Deprecate HTMLFileCache::newFromTitle() in favor of constructor [core] - 10https://gerrit.wikimedia.org/r/160547 (owner: 10MaxSem) [00:24:20] (03Merged) 10jenkins-bot: Lowercase HHVM cookie name [extensions/WikimediaEvents] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161397 (owner: 10Ori.livneh) [00:24:22] (03Merged) 10jenkins-bot: Lowercase HHVM cookie name [extensions/WikimediaEvents] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/161398 (owner: 10Ori.livneh) [00:24:40] (03PS1) 10Ori.livneh: Update WikimediaEvents for cherry-picks [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/161399 [00:25:08] (03PS1) 10Ori.livneh: Update WikimediaEvents for cherry-picks [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161400 [00:25:15] (03CR) 10Ori.livneh: [C: 032 V: 032] Update WikimediaEvents for cherry-picks [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/161399 (owner: 10Ori.livneh) [00:25:26] (03CR) 10Ori.livneh: [C: 032 V: 032] Update WikimediaEvents for cherry-picks [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161400 (owner: 10Ori.livneh) [00:25:37] 3MediaWiki / 3Uploading: SVG upload get blocked on correct encoding (windows-1252, with wrong/unspecific warning) - 10https://bugzilla.wikimedia.org/70937#c4 (10Bawolff (Brian Wolff)) (In reply to PRO from comment #3) > (In reply to Tisza Gergő from comment #1) > Yes, the [[Windows-1252]] encoding is preferr... [00:29:28] (03PS3) 10Arlolra: Hash all metabook props for the collection id [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/160235 (https://bugzilla.wikimedia.org/68836) [00:33:20] (03PS1) 10Jack Phoenix: "Fixing" the by line and some other stuff [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/161401 [00:35:37] 3MediaWiki / 3Parser: Packed gallery with 2 arguments outputs invalid HTML - 10https://bugzilla.wikimedia.org/71030 (10Jon) 3NEW p:3Unprio s:3normal a:3None Copy the following into your wiki page: File:Image.png|link=Foo|Air Assault You'll notice this gener... [00:35:43] (03CR) 10Jack Phoenix: [C: 032] "Fixing" the by line and some other stuff [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/161401 (owner: 10Jack Phoenix) [00:36:06] 3MediaWiki / 3Parser: Packed gallery with 2 arguments outputs invalid HTML - 10https://bugzilla.wikimedia.org/71030#c1 (10Jon) *** Bug 68228 has been marked as a duplicate of this bug. *** [00:38:53] (03PS1) 10Jack Phoenix: Removing legacy (PHP) i18n support [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/161404 [00:39:40] (03CR) 10Jack Phoenix: [C: 032 V: 032] Removing legacy (PHP) i18n support [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/161404 (owner: 10Jack Phoenix) [00:43:06] 3MediaWiki / 3MediaWiki UI: Special:Preferences: Custom (other) input field for Time offset is too long - 10https://bugzilla.wikimedia.org/70405#c9 (10Jared Zimmerman (WMF)) What are your concerns Matt? If the form only accepts certain inputs why should we allow users to create input that will result in an e... [00:52:58] (03PS8) 10Tim Starling: Add "unsaved changes" warning to Special:Preferences [core] - 10https://gerrit.wikimedia.org/r/92677 (https://bugzilla.wikimedia.org/55966) (owner: 10Anomie) [00:57:43] (03CR) 10Legoktm: [C: 04-1] "Thanks for the patch!" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/161349 (https://bugzilla.wikimedia.org/71024) (owner: 10Emadelwany) [00:59:25] (03PS1) 10Jack Phoenix: New resources/ subfolder for CSS & JS assets [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/161406 [00:59:52] (03CR) 10jenkins-bot: [V: 04-1] Add "unsaved changes" warning to Special:Preferences [core] - 10https://gerrit.wikimedia.org/r/92677 (https://bugzilla.wikimedia.org/55966) (owner: 10Anomie) [01:00:02] (03CR) 10Jack Phoenix: [C: 032 V: 032] New resources/ subfolder for CSS & JS assets [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/161406 (owner: 10Jack Phoenix) [01:01:21] (03PS1) 10Legoktm: Add tag-HHVM-description message [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/161408 [01:01:43] Eloquence: ^ [01:01:53] <3 [01:04:53] (03PS9) 10Tim Starling: Add "unsaved changes" warning to Special:Preferences [core] - 10https://gerrit.wikimedia.org/r/92677 (https://bugzilla.wikimedia.org/55966) (owner: 10Anomie) [01:07:54] (03CR) 10Legoktm: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/157011 (owner: 10Legoktm) [01:07:57] (03CR) 10Legoktm: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/160648 (owner: 10Matthias Mullie) [01:08:47] (03PS5) 10Legoktm: Use Title::hasContentModel() instead of a direct comparison [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/157011 [01:09:31] (03CR) 10Legoktm: [C: 032] "Re-applying original +2" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/157011 (owner: 10Legoktm) [01:09:59] (03Merged) 10jenkins-bot: Use Title::hasContentModel() instead of a direct comparison [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/157011 (owner: 10Legoktm) [01:11:40] (03PS14) 10Jdlrobson: Add mw-ui-icon [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) [01:12:14] (03PS2) 10Legoktm: Use postWithToken [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/160648 (owner: 10Matthias Mullie) [01:12:55] (03CR) 10Legoktm: Use postWithToken [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/160648 (owner: 10Matthias Mullie) [01:12:59] (03CR) 10Legoktm: [C: 032] Use postWithToken [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/160648 (owner: 10Matthias Mullie) [01:13:30] (03CR) 10Tim Starling: [C: 032] "PS8/9: fixed test failure" [core] - 10https://gerrit.wikimedia.org/r/92677 (https://bugzilla.wikimedia.org/55966) (owner: 10Anomie) [01:13:32] (03Merged) 10jenkins-bot: Use postWithToken [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/160648 (owner: 10Matthias Mullie) [01:15:11] (03Abandoned) 10Legoktm: Changed "OK" to "Thank" in confirmation dialog box [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/107350 (https://bugzilla.wikimedia.org/59853) (owner: 10Anjanasasindran123) [01:16:28] ori: :/ [01:19:54] (03Merged) 10jenkins-bot: Add "unsaved changes" warning to Special:Preferences [core] - 10https://gerrit.wikimedia.org/r/92677 (https://bugzilla.wikimedia.org/55966) (owner: 10Anomie) [01:24:35] (03CR) 10Jdlrobson: Tweak checkbox sizes to be relative depending on where used. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/154125 (https://bugzilla.wikimedia.org/70133) (owner: 10Jdlrobson) [01:40:35] (03PS1) 10Catrope: Don't make the notifications list 5px taller than the screen [extensions/Echo] - 10https://gerrit.wikimedia.org/r/161409 [01:41:30] spagewmf: Who is it that maintains Echo? Is it your team? https://gerrit.wikimedia.org/r/161409 [01:46:38] (03PS15) 10Jdlrobson: Add mw-ui-icon [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) [01:47:51] (03PS16) 10Jdlrobson: Add mw-ui-icon [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) [01:49:40] (03CR) 10Jdlrobson: [C: 031] "There are still a few issues with it in MobileFrontend but as a first draft I think it's good to go. We can iterate on it as we go." [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) (owner: 10Jdlrobson) [01:54:21] (03PS17) 10Jdlrobson: Add mw-ui-icon [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) [01:55:06] (03CR) 10Jdlrobson: [C: 031] Add mw-ui-icon [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) (owner: 10Jdlrobson) [02:02:22] 3MediaWiki / 3Email: Not receiving e-mail confirmation mail - 10https://bugzilla.wikimedia.org/65328#c3 (10Fernando Ugalde) 5UNCO>3RESO/FIX Good news! Today I received the confirmation mail! [02:05:52] 3MediaWiki / 3MediaWiki UI: Special:Preferences: Custom (other) input field for Time offset is too long - 10https://bugzilla.wikimedia.org/70405#c10 (10Matthew Flaschen) (In reply to Jared Zimmerman (WMF) from comment #9) > What are your concerns Matt? If the form only accepts certain inputs why > should we... [02:14:31] anyone want to look at https://gerrit.wikimedia.org/r/#/c/136123/ ? it's been open a little under 3 months [02:17:46] (03CR) 10Mattflaschen: "Question inline" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) (owner: 10Jdlrobson) [02:20:19] [13node-cssjanus] 15Krinkle pushed 1 new commit to 06master: 02https://github.com/cssjanus/node-cssjanus/commit/9c70709650364918aa6c4cc14c9cf61e8079990e [02:20:19] 13node-cssjanus/06master 149c70709 15Timo Tijhof: test: Overal clean up and improvement of test cases... [02:21:08] [13node-cssjanus] 15Krinkle pushed 1 new commit to 06master: 02https://github.com/cssjanus/node-cssjanus/commit/29b7ce7f0c61844df5ce128c185ca2e3070063e4 [02:21:09] 13node-cssjanus/06master 1429b7ce7 15Roan Kattouw: Account for minified values in border-radius... [02:21:11] [travis-ci] cssjanus/node-cssjanus#48 (master - 9c70709 : Timo Tijhof): The build passed. [02:21:11] [travis-ci] Change view : https://github.com/cssjanus/node-cssjanus/compare/e5d7c95e1b7d...9c7070965036 [02:21:11] [travis-ci] Build details : http://travis-ci.org/cssjanus/node-cssjanus/builds/35693611 [02:21:21] 3MediaWiki / 3Email: Not receiving e-mail confirmation mail - 10https://bugzilla.wikimedia.org/65328#c4 (10Fernando Ugalde) 5RESO/FIX>3RESO/INV Got a problem: Can't upload images (Special:Upload tells me I have to confirm my e-mail, but I already did). [02:21:54] [travis-ci] cssjanus/node-cssjanus#49 (master - 29b7ce7 : Roan Kattouw): The build passed. [02:21:54] [travis-ci] Change view : https://github.com/cssjanus/node-cssjanus/compare/9c7070965036...29b7ce7f0c61 [02:21:54] [travis-ci] Build details : http://travis-ci.org/cssjanus/node-cssjanus/builds/35693629 [02:26:31] (03CR) 10Jackmcbarn: [C: 032] Add tag-HHVM-description message [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/161408 (owner: 10Legoktm) [02:26:39] (03Merged) 10jenkins-bot: Add tag-HHVM-description message [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/161408 (owner: 10Legoktm) [02:27:35] (03CR) 10Cscott: [C: 032] Upgrade node-icu-bidi to v0.1.3 [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/161000 (owner: 10Arlolra) [02:29:19] (03Merged) 10jenkins-bot: Upgrade node-icu-bidi to v0.1.3 [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/161000 (owner: 10Arlolra) [02:31:26] (03PS6) 10Brian Wolff: Make tiff thumbnail in 2 steps. [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135289 (https://bugzilla.wikimedia.org/52045) [02:33:20] (03CR) 10Jackmcbarn: [C: 04-1] "This works for me in Chrome, but in Firefox, it needs to be 140." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/161409 (owner: 10Catrope) [02:33:26] RoanKattouw: ^ [02:33:36] you should probably just change it to the better way you mentioned in the commit message [02:35:09] Yeeaaahh [02:35:32] (03CR) 10Jackmcbarn: [C: 032] Lowercase HHVM cookie name [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/161396 (owner: 10Ori.livneh) [02:35:41] (03Merged) 10jenkins-bot: Lowercase HHVM cookie name [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/161396 (owner: 10Ori.livneh) [02:35:52] (03CR) 10Brian Wolff: "PS6: add unit tests for transforming a big tiff file (5000x5000)." [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135289 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [02:37:52] 3MediaWiki / 3Interface: Remove yellow padlock icons on HTTPS links - 10https://bugzilla.wikimedia.org/61178#c9 (10Filipus Klutiero) Padlocks have now been removed from the English Wikipedia. [02:43:30] (03PS1) 10Spage: QA: fix Topic collapsing for new modal dialog [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161411 [02:44:57] (03CR) 10Jackmcbarn: Make $file->getLength() return duration of GIF and APNG files. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/160304 (owner: 10Brian Wolff) [02:45:21] 3MediaWiki / 3General/Unknown: Gallery element renders image height and width inconsistently - 10https://bugzilla.wikimedia.org/70926#c4 (10Bawolff (Brian Wolff)) Its a feature that the heights are adaptive (in the packed mode) to fill width of screen, and that different rows will have different heights in o... [02:45:36] 3MediaWiki / 3General/Unknown: Gallery element renders image height and width inconsistently when you specify packed mode - 10https://bugzilla.wikimedia.org/70926 (10Bawolff (Brian Wolff)) [02:53:06] 3MediaWiki extensions / 3DynamicPageList2: DPL breaks the update script? - 10https://bugzilla.wikimedia.org/71017#c3 (10Bawolff (Brian Wolff)) Moving component. DPL appears to be at fault, not the core upgrade script. (At least I'm blaming it) [02:56:29] Does anyone knows why this namespace appears to be empty? [02:56:30] https://en.wikipedia.org/wiki/Special:PrefixIndex/Education_Program: [02:56:38] 3MediaWiki extensions / 3DynamicPageList2: ExtDynamicPageList::commonSetup() uses Title::exists() and causes problems in update.php - 10https://bugzilla.wikimedia.org/60492#c5 (10Bawolff (Brian Wolff)) *** Bug 71017 has been marked as a duplicate of this bug. *** [02:56:38] 3MediaWiki extensions / 3DynamicPageList2: DPL breaks the update script? - 10https://bugzilla.wikimedia.org/71017#c4 (10Bawolff (Brian Wolff)) 5UNCO>3RESO/DUP Hmm, its a dupe. And there's a patch in core apparently. But not backported I guess. *** This bug has been marked as a duplicate of bug 60492 *** [02:56:38] if there are changes on it: [02:56:39] https://en.wikipedia.org/w/index.php?namespace=446&tagfilter=&title=Special%3ARecentChanges [02:58:19] Helder: note that none of those are edits. they're all logged actions [02:58:31] but the pages exist [02:59:11] Helder: {{#ifexist:Education Program:University of Pittsburgh/Social Computing (Fall 2014)|yes|no}} says no [02:59:22] i'm assuming that extension is doing weird stuff, like the MediaWiki namespace does [02:59:25] which seems like another bug [02:59:27] =/ [02:59:34] (03PS1) 10Brian Wolff: Don't check for Template:Extension_DPL during update [extensions/DynamicPageList] (REL1_23) - 10https://gerrit.wikimedia.org/r/161415 (https://bugzilla.wikimedia.org/60492) [03:00:08] I don't understand the point of the education_program namespace [03:00:12] there's no pages in it! [03:00:19] there are! https://en.wikipedia.org/wiki/Education_Program:University_of_Pittsburgh/Social_Computing_%28Fall_2014%29 [03:00:23] many! [03:00:31] when i link to the pages, it knows whether they should be blue/red [03:00:37] but they don't appear in what links here, or prefixindex [03:00:42] so i'm going to say that it is pulling the same crap that the mediawiki namespace does [03:01:09] and ifexist do not detect them either [03:01:22] Helder: They're all fake [03:01:27] ouch [03:01:39] Education_Program namespace is like the special namespace sort of, but not quite [03:01:42] Helder: as luck would have it, i literally just added a way for extensions to hook #ifexist today [03:01:46] (for my own evil purposes) [03:01:51] bawolff: #ifexist works for special pages [03:02:03] (i think, either that or Lua's .exists) [03:02:16] * bawolff emphasizes the but not quite [03:02:45] i also notice i don't get a watchlist star for these "pages" [03:03:00] and the search box does not auto complete either [03:03:02] Can't watch a page that doesn't have an entry in the page table of the db [03:03:39] oh wow, this is evil: it stores the actual content in the talk namespace [03:03:43] (its talk) [03:03:47] There was a bug a while back because it caused Special:Random to try to search through every page in the database for an EducationProgram page, and not find any [03:03:57] wow, that's even more evil than I though [03:03:58] t [03:04:13] BTW: a user reported that Special:Log/newusers appeared on his watchlist: https://pt.wikipedia.org/w/index.php?title=Usu%C3%A1rio%28a%29_Discuss%C3%A3o%3AHe7d3r&diff=40093369&oldid=40067298 [03:04:14] actually, "it" may be enwiki's templates [03:04:23] but still, the fact that they resorted to that... [03:04:53] * jackmcbarn is pt-0 [03:04:53] * jackmcbarn goes to google translate [03:05:12] Helder: that's normal [03:05:20] find an account that just got created and watchlist their user page [03:05:21] 3MediaWiki-Vagrant: oauth plugin doesn't work in vagrant, seemingly due to the https reverse-proxy - 10https://bugzilla.wikimedia.org/70964#c2 (10Mukunda Modell) It's the standard mediawiki vagrant box, not customized in any significant way. I'm referring to the proxy that sits between mediawiki and the world... [03:05:23] how? I've never seen it [03:05:26] then refresh your watchlist [03:05:32] hmm [03:06:00] ha! got it :-) [03:06:01] thanks! [03:06:07] one problem less [03:07:00] (03CR) 10Spage: "Comments on my own patch." (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161411 (owner: 10Spage) [03:07:36] 3MediaWiki-Vagrant: oauth plugin doesn't work in vagrant, seemingly due to the https reverse-proxy - 10https://bugzilla.wikimedia.org/70964#c3 (10Mukunda Modell) @bd808: I'm planning to test this further, just filed to bug to remind myself because it had slipped my mind for a while and I didn't want to forget... [03:11:12] (03PS1) 10Brian Wolff: Don't check for Template:Extension_DPL during update [extensions/DynamicPageList] (REL1_22) - 10https://gerrit.wikimedia.org/r/161416 (https://bugzilla.wikimedia.org/60492) [03:11:49] (03CR) 10Brian Wolff: [C: 032] Don't check for Template:Extension_DPL during update [extensions/DynamicPageList] (REL1_22) - 10https://gerrit.wikimedia.org/r/161416 (https://bugzilla.wikimedia.org/60492) (owner: 10Brian Wolff) [03:11:55] (03Merged) 10jenkins-bot: Don't check for Template:Extension_DPL during update [extensions/DynamicPageList] (REL1_22) - 10https://gerrit.wikimedia.org/r/161416 (https://bugzilla.wikimedia.org/60492) (owner: 10Brian Wolff) [03:12:06] tsk :P [03:12:08] (03CR) 10Brian Wolff: [C: 032] Don't check for Template:Extension_DPL during update [extensions/DynamicPageList] (REL1_23) - 10https://gerrit.wikimedia.org/r/161415 (https://bugzilla.wikimedia.org/60492) (owner: 10Brian Wolff) [03:12:16] (03Merged) 10jenkins-bot: Don't check for Template:Extension_DPL during update [extensions/DynamicPageList] (REL1_23) - 10https://gerrit.wikimedia.org/r/161415 (https://bugzilla.wikimedia.org/60492) (owner: 10Brian Wolff) [03:16:23] 3MediaWiki extensions / 3DynamicPageList2: ExtDynamicPageList::commonSetup() uses Title::exists() and causes problems in update.php - 10https://bugzilla.wikimedia.org/60492#c10 (10Bawolff (Brian Wolff)) 5PATC>3RESO/FIX This fix is now backported to REL1_23 and REL1_22 branches, so if you're using the ver... [03:22:22] (03PS1) 10Spage: Fix Feature name and requirement [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161417 [03:27:06] 3MediaWiki / 3Parser: Packed gallery with 2 arguments outputs invalid HTML - 10https://bugzilla.wikimedia.org/71030#c2 (10Bawolff (Brian Wolff)) Well that's embarrassing... [03:30:50] (03PS1) 10Brian Wolff: Add missing tag to packed-overlay galleries [core] - 10https://gerrit.wikimedia.org/r/161418 (https://bugzilla.wikimedia.org/71030) [03:31:30] (03PS1) 10Spage: WIP: QA: use topic and post names correctly [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161419 [03:32:08] 3MediaWiki extensions / 3EducationProgram: Many typical wiki page features do not work on course pages (tracking) - 10https://bugzilla.wikimedia.org/43975 (10Helder) [03:32:10] 3MediaWiki extensions / 3EducationProgram: Preview button is not available on "Education Program" namespace - 10https://bugzilla.wikimedia.org/71032 (10Helder) 3NEW p:3Unprio s:3normal a:3None I'm unable to preview my changes to pages in the "Education Program" namespace ("Ensino", on Portuguese Wiki... [03:34:08] 3MediaWiki extensions / 3EducationProgram: Many typical wiki page features do not work on course pages (tracking) - 10https://bugzilla.wikimedia.org/43975 (10Helder) [03:34:11] 3MediaWiki extensions / 3EducationProgram: "Preview page with this template" doesn't work with pages from "Education Program" namespace - 10https://bugzilla.wikimedia.org/71033 (10Helder) 3NEW p:3Unprio s:3normal a:3None If I attempt to change a template like https://en.wikipedia.org/w/index.php?titl... [03:42:36] (03PS3) 10Brian Wolff: Make $file->getLength() return duration of GIF and APNG files. [core] - 10https://gerrit.wikimedia.org/r/160304 [03:42:54] (03PS2) 10Spage: WIP: QA: use topic and post names correctly [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161419 [03:47:23] 3MediaWiki / 3General/Unknown: Gallery element renders image height and width inconsistently when you specify packed mode - 10https://bugzilla.wikimedia.org/70926#c5 (10Jared Zimmerman (WMF)) Would it be possible for the heights to be adjusted dynamically per row, rather than just during page load, this woul... [03:50:37] 3MediaWiki / 3MediaWiki UI: Special:Preferences: Custom (other) input field for Time offset is too long - 10https://bugzilla.wikimedia.org/70405#c11 (10Jared Zimmerman (WMF)) Does that mean that phone number and credit card fields that limit both characters and string length are using JavaScript for client s... [03:52:52] 3MediaWiki / 3General/Unknown: Gallery element renders image height and width inconsistently when you specify packed mode - 10https://bugzilla.wikimedia.org/70926#c6 (10Bawolff (Brian Wolff)) Its possible, involves more than a couple line fix though. Would require someone to actually do it(tm), but definitel... [03:58:52] 3MediaWiki / 3User preferences: Changes to user preferences should be automatically saved - 10https://bugzilla.wikimedia.org/56561 (10Jared Zimmerman (WMF)) [03:58:52] 3MediaWiki / 3User preferences: Add a "You've not saved your changes" dialogue - 10https://bugzilla.wikimedia.org/55966 (10Jared Zimmerman (WMF)) [04:01:37] 3MediaWiki / 3User preferences: Add a "You've not saved your changes" dialogue - 10https://bugzilla.wikimedia.org/55966#c12 (10Jared Zimmerman (WMF)) (In reply to Marcin Cieślak from comment #8) > Please don't. Preferences are not critical in any way and additional > confirmation like this will be just an an... [04:09:07] 3MediaWiki / 3MediaWiki UI: Set input[type=number] width according to the maxlength attribute - 10https://bugzilla.wikimedia.org/70973#c4 (10Matthew Flaschen) Could we just use size (i.e. not strip it)? You said it affected rendering. Do you remember exactly what the issue was? AFAICT, width: 100% takes p... [04:12:19] the Education Program namespace is fake [04:23:38] ? [04:35:06] 3Wikimedia / 3Media storage: File missing on Commons (LSB_ZEMELAPIS.jpg) - 10https://bugzilla.wikimedia.org/71018#c3 (10Ankry) 5NEW>3RESO/WOR (In reply to Bawolff (Brian Wolff) from comment #2) > File is still available under old name ( > https://upload.wikimedia.org/wikipedia/commons/8/89/LSB_ZEMELAPIS_... [04:39:08] 3MediaWiki / 3User preferences: maxlength html form values are not used in preferences - 10https://bugzilla.wikimedia.org/70974 (10Matthew Flaschen) a:5Matthew Flaschen>3None [04:40:32] (03PS1) 10Mattflaschen: Add maxlength of 6 for time correction in preferences [core] - 10https://gerrit.wikimedia.org/r/161421 (https://bugzilla.wikimedia.org/70405) [04:41:28] (03PS2) 10Mattflaschen: Add maxlength of 6 for time correction in preferences [core] - 10https://gerrit.wikimedia.org/r/161421 (https://bugzilla.wikimedia.org/70405) [04:47:37] 3MediaWiki / 3MediaWiki UI: Special:Preferences: Custom (other) input field for Time offset is too long - 10https://bugzilla.wikimedia.org/70405#c13 (10Matthew Flaschen) We're already using input[type=text] here, so we can add the maxlength here, as long as we know what the right value is. I looked into it,... [04:50:37] 3MediaWiki / 3MediaWiki UI: Special:Preferences: Custom (other) input field for Time offset is too long - 10https://bugzilla.wikimedia.org/70405#c14 (10Jared Zimmerman (WMF)) Thanks Matt, very illuminating. [04:53:36] (03CR) 10Jdlrobson: [C: 032] "Thanks Brian!" [core] - 10https://gerrit.wikimedia.org/r/161418 (https://bugzilla.wikimedia.org/71030) (owner: 10Brian Wolff) [05:00:21] (03Merged) 10jenkins-bot: Add missing tag to packed-overlay galleries [core] - 10https://gerrit.wikimedia.org/r/161418 (https://bugzilla.wikimedia.org/71030) (owner: 10Brian Wolff) [05:02:57] (03PS3) 10Emadelwany: Fix Bugs in MS SQL Driver [core] - 10https://gerrit.wikimedia.org/r/161349 (https://bugzilla.wikimedia.org/71024) [05:08:52] 3MediaWiki / 3Parser: Packed gallery with 2 arguments outputs invalid HTML - 10https://bugzilla.wikimedia.org/71030#c5 (10Jon) 5PATC>3RESO/FIX thanks Brian! embarrassing indeed! :) [05:12:54] (03CR) 10Skizzerz: [C: 031] "Looks good to me, verified the changes in SQL Server Management Studio and the old way was certainly invalid while the new way works." [core] - 10https://gerrit.wikimedia.org/r/161349 (https://bugzilla.wikimedia.org/71024) (owner: 10Emadelwany) [05:18:40] (03CR) 10Legoktm: [C: 031] "LGTM" [core] - 10https://gerrit.wikimedia.org/r/136123 (https://bugzilla.wikimedia.org/69964) (owner: 10Jackmcbarn) [05:18:56] jackmcbarn: if no one complains or comments in a few days I'll merge it [05:28:07] 3Wikimedia / 3General/Unknown: Special:MovePage disappeared from tet.wikipedia - 10https://bugzilla.wikimedia.org/70686#c16 (10Nemo) This bug has been marked "Highest" for a week now, would need an assignee. (Hint: translatewiki.net is not the assignee.) [06:10:44] (03PS1) 10Legoktm: Improve test coverage of Title::isValidMoveOperation [core] - 10https://gerrit.wikimedia.org/r/161425 [06:17:25] (03CR) 10jenkins-bot: [V: 04-1] Improve test coverage of Title::isValidMoveOperation [core] - 10https://gerrit.wikimedia.org/r/161425 (owner: 10Legoktm) [06:19:51] hmm, and I thought I would be the only person who used "meatball" as an interwiki link in tests [06:24:57] (03PS2) 10Legoktm: Improve test coverage of Title::isValidMoveOperation [core] - 10https://gerrit.wikimedia.org/r/161425 [06:27:21] stil failing :( [06:27:42] (03PS3) 10Legoktm: Improve test coverage of Title::isValidMoveOperation [core] - 10https://gerrit.wikimedia.org/r/161425 [06:28:22] 3MediaWiki extensions / 3UniversalLanguageSelector: Oriya webfont not getting loaded for edit field on wikisource (FF31 on Windows XP) - 10https://bugzilla.wikimedia.org/70929#c2 (10Subhashish Panigrahi) The problem still persists for FF31 and FF32 on Windows XP. The reason it displays correctly is because o... [06:43:12] gi11es: i'm supposed to review something from tgr -- do you remember what it is? i don't think it's in my review queue [06:43:26] gi11es: performance review of a new extension or something like that [06:46:26] (03PS1) 10BryanDavis: Add SMTP debugging role [vagrant] - 10https://gerrit.wikimedia.org/r/161428 (https://bugzilla.wikimedia.org/51216) [07:04:58] ori: ImageMetrics probably [07:06:18] ori: yes, ImageMetrics [07:06:35] ori: https://www.mediawiki.org/wiki/Extension:ImageMetrics [07:07:04] it measures the time it takes for the image on the file page to appear [07:07:31] which is something we'd like to measure reliably in order to compare to the same metric we're already measuring on users for media viewer [07:08:44] gi11es, legoktm: yep. thanks! i'm on it. [07:26:28] (03CR) 10Chiefwei: [C: 031] "necessary for Chinese conversion." [core] - 10https://gerrit.wikimedia.org/r/158366 (owner: 10Liangent) [07:31:53] 3MediaWiki / 3Uploading: Generate thumbnails based on buckets - 10https://bugzilla.wikimedia.org/67525#c21 (10Gilles Dubuc) That's very odd, the chaining-free one I had was equally fuzzy as the chained one, which is why I didn't notice the difference. I'll try to figure out what happened there. This might be... [07:45:26] (03CR) 10Gilles: [C: 032] Fix API help for query=videoinfo [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/157619 (https://bugzilla.wikimedia.org/55744) (owner: 10Brian Wolff) [07:45:50] (03Merged) 10jenkins-bot: Fix API help for query=videoinfo [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/157619 (https://bugzilla.wikimedia.org/55744) (owner: 10Brian Wolff) [07:49:40] 3MediaWiki extensions / 3Translate: Special:MyLanguage now in Core - 10https://bugzilla.wikimedia.org/71034 (10Raimond Spekking) 3NEW p:3Unprio s:3normal a:3None Special:MyLanguage is since some weeks a special page in Core too. This dupe results into errors at translatewiki.net, see https://transla... [07:51:24] (03PS1) 10Nikerabbit: Remove unused message [core] - 10https://gerrit.wikimedia.org/r/161433 [07:52:25] (03CR) 10Gilles: Make $file->getLength() return duration of GIF and APNG files. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/160304 (owner: 10Brian Wolff) [07:57:20] (03CR) 10Gilles: [C: 032] Add Special:MediaStatistics page for file type stats [core] - 10https://gerrit.wikimedia.org/r/150131 (owner: 10Brian Wolff) [07:57:56] (03CR) 10jenkins-bot: [V: 04-1] Remove unused message [core] - 10https://gerrit.wikimedia.org/r/161433 (owner: 10Nikerabbit) [08:03:44] (03Merged) 10jenkins-bot: Add Special:MediaStatistics page for file type stats [core] - 10https://gerrit.wikimedia.org/r/150131 (owner: 10Brian Wolff) [08:20:07] (03PS2) 10Nikerabbit: Remove unused message [core] - 10https://gerrit.wikimedia.org/r/161433 [08:22:07] (03CR) 10Nikerabbit: "Please remove messages when you make them unused. Otherwise translators will waste their time translating them. I have submitted Ib1cecfe7" [core] - 10https://gerrit.wikimedia.org/r/161340 (https://bugzilla.wikimedia.org/56363) (owner: 10Prtksxna) [08:25:23] 3MediaWiki extensions / 3Translate: Special:MyLanguage now in Core - 10https://bugzilla.wikimedia.org/71034#c1 (10Nemo) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 69461 *** [08:25:24] 3MediaWiki extensions / 3Translate: Conflict of Special:MyLanguage: Extension and MW core use the same special page name - 10https://bugzilla.wikimedia.org/69461#c7 (10Nemo) *** Bug 71034 has been marked as a duplicate of this bug. *** [08:29:53] 3MediaWiki extensions / 3ReplaceText: RegExp search and replace doesn't work with MS Sql SERVER - 10https://bugzilla.wikimedia.org/71027 (10Andre Klapper) [08:29:53] 3MediaWiki / 3Database: Microsoft SQL Server/MSSQL support (tracking) - 10https://bugzilla.wikimedia.org/9767 (10Andre Klapper) [08:31:56] 3MediaWiki / 3Email: Special:Emailuser can leak target's email address if SPF fails - 10https://bugzilla.wikimedia.org/71035 (10Marcin Cieślak) 3NEW p:3Unprio s:3major a:3None Alice can send a Bob an email via [[Special:Emailuser]] feature and, if it gets rejected by SPF, Bob's email address will be... [08:32:11] (03CR) 10Gilles: Log errors (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/161363 (owner: 10Gergő Tisza) [08:40:52] 3MediaWiki / 3Email: Special:Emailuser can leak target's email address if SPF fails - 10https://bugzilla.wikimedia.org/71035#c1 (10Marcin Cieślak) One simple idea to prevent this is to send confirmation emails from some special email address *not* covered by SPF (for example emailconfirm@wikimailconfirm.org)... [08:41:36] 3MediaWiki / 3Email: Not receiving e-mail confirmation mail - 10https://bugzilla.wikimedia.org/65328#c5 (10Andre Klapper) https://www.mediawiki.org/wiki/Project:Support_desk might be more suited. [08:52:52] 3MediaWiki extensions / 3Extensions requests: Add proper email bounce handling to MediaWiki (with VERP) - 10https://bugzilla.wikimedia.org/46640#c26 (10Tony Thomas) Updates: *) http://deployment.wikimedia.beta.wmflabs.org/wiki/Special:EmailUser sending VERPed emails after https://gerrit.wikimedia.org/r/#/c/1... [09:11:46] (03CR) 10Gergő Tisza: Log errors (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/161363 (owner: 10Gergő Tisza) [09:21:21] 3MediaWiki extensions / 3UniversalLanguageSelector: Oriya webfont not getting loaded for edit field on wikisource (FF31 on Windows XP) - 10https://bugzilla.wikimedia.org/70929#c3 (10Andre Klapper) Errrm, am I correct that the Oriya script is still entirely correctly displayed on your Windows XP system and is... [09:21:59] (03PS2) 10Gergő Tisza: Log errors [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/161363 [09:25:38] tgr: i'll have ImageMetrics reviewed by EOD, SF time. Sorry for the delay with that. [09:25:39] 3MediaWiki / 3General/Unknown: Default timezone always UTC when using HHVM despite settings in config - 10https://bugzilla.wikimedia.org/71036 (10James Alexander) 3NEW p:3Unprio s:3normal a:3None Currently we have just under 200 wikis using 'non standard' default time zones (set in http://noc.wikimed... [09:36:54] 3MediaWiki extensions / 3UniversalLanguageSelector: Oriya webfont not getting loaded for edit field on wikisource (FF31 on Windows XP) - 10https://bugzilla.wikimedia.org/70929#c4 (10Andre Klapper) And what kind of workshop? When? Are all machines still running on ancient XP? [10:13:25] (03PS1) 10Gerrit Patch Uploader: Fix warning thrown by PHP 5.3 when array_combining empty arrays [skins/chameleon] - 10https://gerrit.wikimedia.org/r/161440 [10:13:27] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [skins/chameleon] - 10https://gerrit.wikimedia.org/r/161440 (owner: 10Gerrit Patch Uploader) [10:15:16] (03CR) 10Foxtrott: [C: 032 V: 032] Fix warning thrown by PHP 5.3 when array_combining empty arrays [skins/chameleon] - 10https://gerrit.wikimedia.org/r/161440 (owner: 10Gerrit Patch Uploader) [10:16:59] (03PS1) 10Gerrit Patch Uploader: Do not display footer places when printing [skins/chameleon] - 10https://gerrit.wikimedia.org/r/161442 [10:17:01] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [skins/chameleon] - 10https://gerrit.wikimedia.org/r/161442 (owner: 10Gerrit Patch Uploader) [10:17:44] (03CR) 10Foxtrott: [C: 032 V: 032] Do not display footer places when printing [skins/chameleon] - 10https://gerrit.wikimedia.org/r/161442 (owner: 10Gerrit Patch Uploader) [10:28:56] (03CR) 10Ori.livneh: "Yikes, I'm sorry for not attending to this sooner. Dan-nl, thanks a ton for the careful bug triage and the patch. I'll review this ASAP. (" [core] - 10https://gerrit.wikimedia.org/r/159973 (owner: 10Dan-nl) [10:39:58] (03CR) 10Nikerabbit: [C: 04-1] "I could merge but I'd like to see examples of what is broken & fixed by this commit. If possible in the form of unit tests." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/158366 (owner: 10Liangent) [10:46:30] (03CR) 10Bartosz Dziewoński: [C: 04-1] "This seems like an unnecessary limitation for no gain. Editing fields with such limits is annoying. If you want to control the display wid" [core] - 10https://gerrit.wikimedia.org/r/161421 (https://bugzilla.wikimedia.org/70405) (owner: 10Mattflaschen) [10:52:18] (03CR) 10Nikerabbit: Degrade gracefully on missing special page description message. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/144253 (https://bugzilla.wikimedia.org/67547) (owner: 10Brian Wolff) [10:56:56] 3MediaWiki extensions / 3UniversalLanguageSelector: When I change a language I need to refresh the page before it comes into effect - 10https://bugzilla.wikimedia.org/70859#c2 (10Niklas Laxström) Special:RecentChanges has caching with If-Modified-Since or similar. That doesn't take into account the language... [11:02:23] 3MediaWiki extensions / 3CirrusSearch: Provide a way to find "really exact" matches, as Lucene-search always has - 10https://bugzilla.wikimedia.org/70950#c1 (10Nemo) (In reply to SpontaneousGrumbler from comment #0) > find hyphenated words, such as "he was > assigned to follow-up on the discovery", without f... [11:12:36] 3Wikimedia / 3Apache configuration: http://wikipedia.org/index.html takes you somewhere unexpected. - 10https://bugzilla.wikimedia.org/70721#c14 (10Bartosz Dziewoński) 5UNCO>3RESO/WON Thanks for getting this to everyone's attention :) [12:09:25] 3MediaWiki extensions / 3Lockdown: visit a page where read access is denied without login using lockdown, then login, see Bad Title - 10https://bugzilla.wikimedia.org/71037 (10Tara Athan) 3UNCO p:3Unprio s:3minor a:3None I have installed MW 1.23.3 and Lockdown d08bcd8ab4ffaee3f4df4b4d62016a17796b0a83... [12:10:09] 3MediaWiki extensions / 3Scribunto: Scribunto should show script error details to JavaScriptless users - 10https://bugzilla.wikimedia.org/71038 (10Gryllida) 3NEW p:3Unprio s:3normal a:3None str; 0) disable js 1) visit a page with a lua script error expect 'script error' note with the full error mess... [12:11:39] (03PS5) 10Jackmcbarn: Display the full error message in wikitext [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/143061 (https://bugzilla.wikimedia.org/71038) [12:15:07] 3MediaWiki extensions / 3Lockdown: visit a page where read access is denied without login using lockdown, then login, see Bad Title - 10https://bugzilla.wikimedia.org/71037#c1 (10Tara Athan) On further testing, I see that this only happens when I use the login button in the top menu, not the login button wit... [12:23:54] (03Draft2) 10Aude: Re-apply Ic917c7d, don't cast SpecialPageFactory::$list to an object [core] - 10https://gerrit.wikimedia.org/r/161448 [12:25:16] (03CR) 10Aude: "see https://gerrit.wikimedia.org/r/#/c/161448/" [core] - 10https://gerrit.wikimedia.org/r/152755 (owner: 10Daniel Kinzler) [12:25:37] (03CR) 10Aude: "see https://gerrit.wikimedia.org/r/#/c/161448/ as alternative to fix this" [core] - 10https://gerrit.wikimedia.org/r/161324 (owner: 10Reedy) [12:27:07] 3MediaWiki extensions / 3CharInsert: CharInsert should not show up to JavaScriptless users - 10https://bugzilla.wikimedia.org/70923#c3 (10Gryllida) Every modern browser allows that. Firefox: javascript.enabled in about:config Google Chrome: https://productforums.google.com/d/msg/chrome/BYOQskiuGU0/5PRO2P-1W... [12:31:17] (03CR) 10Daniel Kinzler: [C: 031] "Seems fine to re-apply the change that changed this from crazy object-as-an-array logic to a plain array." [core] - 10https://gerrit.wikimedia.org/r/161448 (owner: 10Aude) [12:32:19] (03CR) 10Daniel Kinzler: [C: 04-1] "oppose this for master, prefer aude's patch" [core] - 10https://gerrit.wikimedia.org/r/161324 (owner: 10Reedy) [12:44:38] 3MediaWiki / 3General/Unknown: When I change a language I need to refresh the page before it comes into effect - 10https://bugzilla.wikimedia.org/70859 (10Nemo) [12:47:15] (03CR) 10Fomafix: "hasOwnProperty" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/160308 (owner: 10Bartosz Dziewoński) [12:53:24] 3MediaWiki extensions / 3WikidataRepo: Support statements on properties in WikibaseDataModelSerialization - 10https://bugzilla.wikimedia.org/66425#c4 (10Jan Zerebecki) https://github.com/wmde/WikibaseDataModelSerialization/pull/83 Deployment of this blocks on https://github.com/wmde/WikibaseDataModel/milesto... [12:59:42] (03PS4) 10Skizzerz: (bug 71024) Fix issues with Microsoft SQL Server Driver: 1. INSERT IGNORE now works properly 2. Only return an inserted id if the INSERT was actually successful 3. Fix syntax error when doing LIMIT queries [core] - 10https://gerrit.wikimedia.org/r/161349 (owner: 10Emadelwany) [13:05:11] 3MediaWiki extensions / 3WikidataRepo: Save-Button not disabled when editing a reference - 10https://bugzilla.wikimedia.org/71039 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs The save-button is initially not disabled when editing an existing reference. [13:05:23] 3MediaWiki extensions / 3WikidataRepo: Save-Button not disabled when editing a reference - 10https://bugzilla.wikimedia.org/71039 (10tobias.gritschacher) p:5Unprio>3Normal [13:15:19] (03CR) 10Se4598: Cleaned up workflow for fetching nodes to use Status. (031 comment) [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/62026 (owner: 10Parent5446) [13:19:42] (03CR) 10Se4598: [C: 04-1] "There seems to be an error introduced by rebase." (031 comment) [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/62026 (owner: 10Parent5446) [13:29:23] 3MediaWiki / 3Uploading: SVG upload get blocked on correct encoding (windows-1252, with wrong/unspecific warning) - 10https://bugzilla.wikimedia.org/70937#c5 (10PRO) (In reply to Bawolff (Brian Wolff) from comment #4) > Its not like one is better than the other really. If the file is > windows-1252, you shou... [13:38:07] 3MediaWiki / 3Installer: Installation to Oracle backend fails with a ORA-00947 'Not Enough Values' - 10https://bugzilla.wikimedia.org/71022#c4 (10Bill Traynor) In looking closer at the code, I think the Create a dummy page to satisfy fk constraints is missing a NULL value at the end of: INSERT INTO &mw_pref... [14:13:37] 3MediaWiki extensions / 3Extensions requests: Automatically (?semi-)protect high edit-rate pages (based on some general threshold?) - 10https://bugzilla.wikimedia.org/69426#c1 (10Jackmcbarn) Won't happen in core, but an extension could be written. (Though I doubt it would end up getting used on the WMF clust... [14:14:53] 3Wikimedia / 3Site requests: Allow "suppressredirect" and "move-subpages" within userspace - 10https://bugzilla.wikimedia.org/69162#c3 (10Jackmcbarn) There's not a switch we can flip to turn this on. Someone will have to write the code to let us do this. [14:15:08] 3Wikimedia / 3Site requests: Allow "suppressredirect" and "move-subpages" within userspace - 10https://bugzilla.wikimedia.org/69162 (10Jackmcbarn) [14:27:24] (03CR) 10Anomie: [C: 032] "You should get an announcement put into Tech News so people don't get surprised by suddenly having long error messages displayed in the pa" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/143061 (https://bugzilla.wikimedia.org/71038) (owner: 10Jackmcbarn) [14:31:19] (03CR) 10Jackmcbarn: "https://meta.wikimedia.org/w/index.php?diff=9930882" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/143061 (https://bugzilla.wikimedia.org/71038) (owner: 10Jackmcbarn) [14:32:58] (03Merged) 10jenkins-bot: Display the full error message in wikitext [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/143061 (https://bugzilla.wikimedia.org/71038) (owner: 10Jackmcbarn) [14:34:53] 3MediaWiki extensions / 3Scribunto: Scribunto should show script error details to JavaScriptless users - 10https://bugzilla.wikimedia.org/71038#c3 (10Jackmcbarn) 5PATC>3RESO/FIX p:5Unprio>3Normal a:3Jackmcbarn The fix will be deployed to all WMF wikis as of October 2nd. [14:53:07] 3Wikimedia / 3General/Unknown: Special:MovePage disappeared from tet.wikipedia - 10https://bugzilla.wikimedia.org/70686#c17 (10Jesús Martínez Novo (Ciencia Al Poder)) (In reply to Nemo from comment #16) > This bug has been marked "Highest" for a week now, would need an assignee. > (Hint: translatewiki.net is... [15:01:16] (03PS5) 10Anomie: API: Clean up and internationalize pretty-printed output [core] - 10https://gerrit.wikimedia.org/r/161093 (https://bugzilla.wikimedia.org/65403) [15:01:48] (03PS1) 10Anomie: Implement 'ApiFormatHighlight' hook [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/161463 [15:01:51] (03CR) 10jenkins-bot: [V: 04-1] API: Clean up and internationalize pretty-printed output [core] - 10https://gerrit.wikimedia.org/r/161093 (https://bugzilla.wikimedia.org/65403) (owner: 10Anomie) [15:04:52] 3MediaWiki / 3Installer: Installation to Oracle backend fails with a ORA-00947 'Not Enough Values' - 10https://bugzilla.wikimedia.org/71022#c5 (10Bill Traynor) Adding a NULL to the end of: INSERT INTO &mw_prefix.page VALUES (0, 0, ' ', NULL, 0, 0, 0, 0, current_timestamp, NULL, 0, 0, NULL); Fixed this er... [15:08:25] 3MediaWiki / 3Installer: 923 ORA-00923: FROM keyword not found where expected - 10https://bugzilla.wikimedia.org/71040 (10Bill Traynor) 3NEW p:3Unprio s:3blocke a:3None Installing a fresh MediaWiki (git master) to Oracle 11: 923 ORA-00923: FROM keyword not found where expected Query: INSERT INTO... [15:21:01] (03CR) 10Anomie: Add parser callback to get a page's current revision (034 comments) [core] - 10https://gerrit.wikimedia.org/r/160570 (https://bugzilla.wikimedia.org/70495) (owner: 10Jackmcbarn) [15:23:36] (03PS1) 10Bartosz Dziewoński: Allow logged-in users to view and use the login form [core] - 10https://gerrit.wikimedia.org/r/161465 (https://bugzilla.wikimedia.org/70855) [15:24:08] 3MediaWiki / 3User login and signup: Login as another user no longer works - 10https://bugzilla.wikimedia.org/70855 (10Bartosz Dziewoński) p:5Low>3High a:3Bartosz Dziewoński [15:24:53] anomie: instead of doing all that, could i just keep track of the last parser used in CoreParserFunctions, and dump the cache if they don't match? [15:25:10] it feels rather hacky to do so much work in Parser for something only intended for CoreParserFunctions [15:25:28] if php had weak references, i'd want to create a weak map of parsers to caches in CoreParserFunctions [15:25:39] (stupid PHP.) [15:27:06] jackmcbarn: Remember though that the message cache sometimes uses a different parser object. Not likely to be a problem in practice, though. [15:30:11] anomie: good point. what if i just made the cache into a regular revision cache, didn't bother caching false in it or handling expensive, and let the fetchCurrentRevisionOfTitle method try it before calling the callback? [15:31:51] (03CR) 10Bartosz Dziewoński: "The bug this fixes is marked as blocking the 1.24 release. Can anybody who deals with language support respond to Krinkle's concerns?" [core] - 10https://gerrit.wikimedia.org/r/157180 (https://bugzilla.wikimedia.org/58139) (owner: 10Legoktm) [15:32:36] 3Wikimedia / 3General/Unknown: Special:MovePage disappeared from tet.wikipedia - 10https://bugzilla.wikimedia.org/70686#c18 (10Brad Jorsch) (In reply to Nemo from comment #13) > It would be mentally cleaner to > make canonical names win over any alias: then we'd "only" have to bother > about conflicts in can... [15:33:38] jackmcbarn: I'm not clear on what you're proposing there. How would CoreParserFunctions know whether to increment the expensive count then? [15:33:56] anomie: make the cache object public, and let it do the ->has() on it before calling the get method [15:34:52] 3MediaWiki / 3Export/Import: Import of Commons partial export fails with error about plurals-mediawiki.xml - 10https://bugzilla.wikimedia.org/56439#c12 (10Bartosz Dziewoński) According to comments on the patch, it is not clear if it actually fixes the issue or not. [15:34:54] jackmcbarn: If by "make the cache object public" you mean either "add Parser::isCurrentRevisionOfTitleCached()" or "add Parser::getCurrentRevisionOfTitleCache()", sure. [15:35:16] jackmcbarn: Or really make it public, and lose the silly 'm' prefix [15:35:24] * jackmcbarn prefers the latter [15:37:07] 3Wikimedia / 3General/Unknown: Special:MovePage disappeared from tet.wikipedia - 10https://bugzilla.wikimedia.org/70686#c19 (10Nemo) (In reply to Brad Jorsch from comment #18) > Define "canonical". Is it the one that gets redirected to (which is just the > first alias in the alias list, often localized), or... [15:39:37] (03CR) 10AndyRussG: "Just noting two places where the legacy activity feed is still visible:" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/153421 (owner: 10Nischayn22) [15:42:53] 3Wikimedia / 3General/Unknown: Special:MovePage disappeared from tet.wikipedia - 10https://bugzilla.wikimedia.org/70686#c20 (10Brad Jorsch) (In reply to Nemo from comment #19) > (In reply to Brad Jorsch from comment #18) > > Define "canonical". Is it the one that gets redirected to (which is just the > > fir... [15:44:21] 3Wikimedia / 3General/Unknown: Special:MovePage disappeared from tet.wikipedia - 10https://bugzilla.wikimedia.org/70686#c21 (10Jesús Martínez Novo (Ciencia Al Poder)) In JavaScript there's a global variable called wgCanonicalSpecialPageName [1], which is often used by scripts to detect if the current page is... [15:46:36] (03PS5) 10Jackmcbarn: Add parser callback to get a page's current revision [core] - 10https://gerrit.wikimedia.org/r/160570 (https://bugzilla.wikimedia.org/70495) [15:46:56] (03PS1) 10Gergő Tisza: Prevent warning when not fully configured [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/161466 [15:50:37] 3MediaWiki / 3JavaScript: mw.trackSubscribe should prevent infinite recursion - 10https://bugzilla.wikimedia.org/67481#c3 (10Bartosz Dziewoński) Actually, I don't see any way to implement this, given that everything can be asynchronous. I might be missing something, but this seems impossible. We can impleme... [15:51:14] (03CR) 10jenkins-bot: [V: 04-1] Add parser callback to get a page's current revision [core] - 10https://gerrit.wikimedia.org/r/160570 (https://bugzilla.wikimedia.org/70495) (owner: 10Jackmcbarn) [15:53:51] 3MediaWiki / 3General/Unknown: Investigate whether taking an action on a page (delete, import, etc.) should require being able to edit it - 10https://bugzilla.wikimedia.org/69380#c29 (10Bartosz Dziewoński) What is the status of this bug? [16:00:07] (03PS6) 10Jackmcbarn: Add parser callback to get a page's current revision [core] - 10https://gerrit.wikimedia.org/r/160570 (https://bugzilla.wikimedia.org/70495) [16:00:27] (03CR) 10Mattflaschen: "This patch is specifically about the actual limit, not the visual size. See https://bugzilla.wikimedia.org/show_bug.cgi?id=70973 for some" [core] - 10https://gerrit.wikimedia.org/r/161421 (https://bugzilla.wikimedia.org/70405) (owner: 10Mattflaschen) [16:02:54] 3Wikimedia / 3General/Unknown: Varnish 503s with HHVM on account creation - 10https://bugzilla.wikimedia.org/71042 (10John F. Lewis) 3NEW p:3Unprio s:3normal a:3None While trying to create an account (on enwiki in this instance) with HHVM enabled, Varnish returns 503 errors every time. For clarificat... [16:10:59] (03CR) 10Bartosz Dziewoński: "Eh, I dunno. Okay." [core] - 10https://gerrit.wikimedia.org/r/161421 (https://bugzilla.wikimedia.org/70405) (owner: 10Mattflaschen) [16:14:03] (03PS1) 10Gergő Tisza: Introduce ContentAlterParserOutput hook [core] - 10https://gerrit.wikimedia.org/r/161471 [16:30:38] 3MediaWiki skins / 3Vector: Text typed into search box not visible when using white text on black. - 10https://bugzilla.wikimedia.org/62668#c3 (10mossiegeek) I've just retested prior to taking a screen shot and I no longer get the problem. I suggest this report is closed. If the problem recurrs I'll try to... [16:44:22] 3MediaWiki skins / 3Vector: Text typed into search box not visible when using white text on black. - 10https://bugzilla.wikimedia.org/62668 (10Jesús Martínez Novo (Ciencia Al Poder)) 5UNCO>3RESO/FIX p:5High>3Normal [16:50:43] (03CR) 10Prtksxna: [C: 031] Remove unused message [core] - 10https://gerrit.wikimedia.org/r/161433 (owner: 10Nikerabbit) [16:52:02] prtksxna: y u no +2 [16:52:37] 3MediaWiki / 3Database: Oracle DB support (tracking) - 10https://bugzilla.wikimedia.org/38916 (10Jesús Martínez Novo (Ciencia Al Poder)) [16:52:40] 3MediaWiki / 3Installer: 923 ORA-00923: FROM keyword not found where expected - 10https://bugzilla.wikimedia.org/71040 (10Jesús Martínez Novo (Ciencia Al Poder)) p:5Unprio>3High [16:52:42] yuvipanda: core etc [16:52:47] prtksxna: trivial, etc [16:52:50] prtksxna: do a git grep, then merge [16:53:42] * prtksxna does that [16:56:01] yuvipanda: Do they get removed from other languages automatically? [16:56:11] prtksxna: translatewiki.net takes care of it [16:56:15] you usually remove only from en and qq [16:56:33] (03CR) 10Prtksxna: [C: 032] Remove unused message [core] - 10https://gerrit.wikimedia.org/r/161433 (owner: 10Nikerabbit) [16:56:48] prtksxna: congratulations [16:56:51] * prtksxna merges to core, runs away [16:56:55] º╲˚\╭ᴖ_ᴖ╮/˚╱º Y A Y ! [16:56:56] WHAT DID YOU DO [16:57:01] * ori flames prtksxna [16:57:22] -2's ori's flame [16:58:36] prtksxna: https://www.youtube.com/watch?v=I_vzG5nYk1I [16:58:43] be confident! be confident! [16:59:28] (03PS1) 10Manybubbles: Fix multiple phrase queries in same search [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/161474 [17:01:23] I made it! I made it! [17:01:29] That is exactly how it felt like :P [17:01:52] You can always mention a relevant quip, given the author of the patch: [17:01:53] What's the current development/deployment model we use? Commit then flee! [17:02:13] heh [17:02:17] hehe [17:02:33] lol [17:02:56] Nemo_bis: btw, if i ever give some indication that i'm considering posting to wikimedia-l again, please slap me [17:03:22] ori: we should build an automatic machine for this purpose [17:03:33] +1 [17:03:49] it just throws scalding hot water on your face [17:03:54] that's almost certainly better [17:04:01] the problem is that no reliable way was found yet to predict when a person will suffer from the irresistible temptation to email wikimedia-l [17:04:19] it's about as hard as predicting pancreas cancer [17:04:23] 3Wikimedia / 3SVG rendering: SVG renderer does not support the tag - 10https://bugzilla.wikimedia.org/8552#c21 (10PRO) 5NEW>3RESO/FIX In general librsvg 2.36 support the pattern tag. If not open a new concrete bug report. [17:04:32] but as you know a teen recently helped with that, so we may have hopes [17:05:57] heh [17:09:40] 3MediaWiki / 3Logging: log_params in page merge log events isn't serialized - 10https://bugzilla.wikimedia.org/71044 (10Nathan Larson) 3NEW p:3Unprio s:3normal a:3None log_params in page merge log events isn't serialized. It should be. [17:09:40] (03PS5) 10Legoktm: Fix some issues with Microsoft SQL Server Driver [core] - 10https://gerrit.wikimedia.org/r/161349 (https://bugzilla.wikimedia.org/71024) (owner: 10Emadelwany) [17:09:52] (03CR) 10Legoktm: [C: 032] Fix some issues with Microsoft SQL Server Driver [core] - 10https://gerrit.wikimedia.org/r/161349 (https://bugzilla.wikimedia.org/71024) (owner: 10Emadelwany) [17:10:09] 3MediaWiki / 3Logging: log_params in page merge log events isn't serialized - 10https://bugzilla.wikimedia.org/71044 (10Nathan Larson) p:5Unprio>3Lowest s:5normal>3minor a:3Nathan Larson [17:10:22] 3MediaWiki / 3Logging: log_params in history merge log events isn't serialized - 10https://bugzilla.wikimedia.org/71044 (10Nathan Larson) [17:15:04] (03CR) 10Kaldari: "@Gilles: I agree it should be upstreamed. Thanks for noticing that. I don't, however, think we should delay merging this fix in the meanti" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/161174 (https://bugzilla.wikimedia.org/53840) (owner: 10Kaldari) [17:16:42] (03Merged) 10jenkins-bot: Fix some issues with Microsoft SQL Server Driver [core] - 10https://gerrit.wikimedia.org/r/161349 (https://bugzilla.wikimedia.org/71024) (owner: 10Emadelwany) [17:20:31] [13node-cssjanus] 15Krinkle pushed 1 new commit to 06master: 02https://github.com/cssjanus/node-cssjanus/commit/77646dce84937a5f6e131af4aac3f46a437041a6 [17:20:31] 13node-cssjanus/06master 1477646dc 15Timo Tijhof: Flip border-style [17:21:57] (03PS1) 10Manybubbles: Remove useless file [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/161476 [17:22:24] [travis-ci] cssjanus/node-cssjanus#50 (master - 77646dc : Timo Tijhof): The build passed. [17:22:24] [travis-ci] Change view : https://github.com/cssjanus/node-cssjanus/compare/29b7ce7f0c61...77646dce8493 [17:22:24] [travis-ci] Build details : http://travis-ci.org/cssjanus/node-cssjanus/builds/35751953 [17:23:08] 3MediaWiki extensions / 3CirrusSearch: Provide a way to find "really exact" matches, as Lucene-search always has - 10https://bugzilla.wikimedia.org/70950#c2 (10SpontaneousGrumbler) (In reply to Nemo from comment #1) > (In reply to SpontaneousGrumbler from comment #0) > > find hyphenated words, such as "he wa... [17:28:53] Does anyone knows who has access to perform user renames on gerrit/wikitech/labs? https://wikitech.wikimedia.org/wiki/Renaming_users [17:29:19] Helder: you might poke andrewbogott on #wikimedia-labs, but I vaguely remember it might be hard? [17:29:51] (03CR) 10Jdlrobson: Add mw-ui-icon (031 comment) [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) (owner: 10Jdlrobson) [17:30:42] (03PS1) 10EBernhardson: I3: Include board name in topic html title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161479 [17:31:40] * Helder will check [17:32:17] yuvipanda: Helder: it's possible [17:32:55] or used to be, at least, it just took someone running a few manual commands [17:33:47] MatmaRex: apparently not [17:35:20] I also wanted to change my username but they said no :( [17:35:29] it was like a yer a go though [17:36:42] so, nothing in that page can be done anymore? https://wikitech.wikimedia.org/wiki/Renaming_users [17:37:46] lol, it requires restarting gerrit... [17:38:06] well, or not, but it won't notice [17:38:12] spagewmf, ebernhardson: Sep 19 17:35:10 mw1020 hhvm: #012Notice: Undefined index: submitted in /srv/mediawiki/php-1.24wmf21/extensions/Flow/handlebars/compiled/flow_post.handlebars.php on line 553 [17:38:20] spagewmf: debugging some other issue so i can't submit a bug right now, sorry [17:41:59] 3MediaWiki extensions / 3Lua: Undefined index: 0 in /UstringLibrary.php:638 - 10https://bugzilla.wikimedia.org/71045 (10Ori Livneh) 3NEW p:3Unprio s:3normal a:3Fran Rogers Sep 19 16:36:40 mw1020 hhvm: message repeated 17 times: [ #012Notice: Undefined index: 0 in /srv/mediawiki/php-1.24wmf21/extensio... [17:41:59] 3MediaWiki extensions / 3WikidataRepo: Support statements on properties in WikibaseDataModelSerialization - 10https://bugzilla.wikimedia.org/66425#c5 (10Jeroen De Dauw) Someone should review https://github.com/wmde/WikibaseDataModel/pull/196 so we can get to https://github.com/wmde/WikibaseDataModel/issues/1... [17:42:23] 3Wikimedia / 3General/Unknown: Install Q&A system at ask.wikimedia.org - 10https://bugzilla.wikimedia.org/29923#c20 (10Jan Kucera (Kozuch)) The Ponder on Phabricator might not be a bad solution. Better something than nothing :). But loads of traffic must be directed to such Q&A site so that some content is b... [17:42:28] legoktm: got a minute to help debug something? [17:42:32] legoktm: Sep 19 17:32:02 mw1020 hhvm: #012Notice: Undefined index: rc_id in /srv/mediawiki/php-1.24wmf21/includes/rcfeed/MachineReadableRCFeedFormatter.php on line 48 [17:43:52] 3MediaWiki extensions / 3CirrusSearch: Provide a way to find "really exact" matches, as Lucene-search always has - 10https://bugzilla.wikimedia.org/70950#c3 (10Nemo) (In reply to SpontaneousGrumbler from comment #2) > The updated summary about "exact > match" seems to be a setup for deflecting this back to s... [17:44:48] ori: hmm, I merged a patch for that [17:45:09] https://gerrit.wikimedia.org/r/#/c/155738/ [17:45:27] ori: ^ is only in wmf22, should we backport it? [17:45:43] yes plz [17:46:00] (03PS1) 10Legoktm: Use safe attribute accessor for RecentChange [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161482 [17:46:33] ori: is it urgent enough to do it now or should I put it in SWAT? [17:50:34] legoktm: SWAT. thanks [17:50:39] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch should provide a way to find hyphenated words, as Lucene-search always has - 10https://bugzilla.wikimedia.org/70950#c4 (10Nik Everett) I think he's right in that hyphenated words are the only thing that lsearchd has special handling for. There could be mor... [17:51:00] ori: ok, putting it up for monday [17:52:22] 3MediaWiki extensions / 3CirrusSearch: Byte counts under-reported in search results - 10https://bugzilla.wikimedia.org/70919#c1 (10Chad H.) p:5Unprio>3Normal If I had to guess I'd say we're reporting the pre-expansion size. I'll have a look at this next week. [17:53:10] Vulpix, MatmaRex, yuvipanda: Marked the page as outdated then, since these accounts seems to be so tied up together that none of them can be renamed without causing problems in the others... [17:53:11] https://wikitech.wikimedia.org/wiki/Renaming_users?diff=127746 [17:54:01] are you sure it's outdated? it was last edited this august [17:54:31] well, if users can't be renamed, then at least this info is missing there [17:55:05] (03PS1) 10EBernhardson: Fix noop error on topic pages [extensions/Flow] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161484 [17:55:38] 3MediaWiki / 3Installer: 923 ORA-00923: FROM keyword not found where expected - 10https://bugzilla.wikimedia.org/71040#c1 (10Bawolff (Brian Wolff)) For reference, issue introduced in https://gerrit.wikimedia.org/r/#/c/135756/ [17:55:39] well, it describes the technical process of renaming users, but not how to request a user rename or what requirements one must meet [17:56:33] Vulpix: how to: ask pretty-please. requirements: someone needs to care. [17:57:22] (03PS1) 10Wmat: Bug71022: Added missing NULL value to sql insert statement. [core] - 10https://gerrit.wikimedia.org/r/161485 [17:57:51] heh [17:59:45] MatmaRex: does the user itself counts for "someone needs to care"? :-) [17:59:59] (03CR) 10Nikerabbit: API: HTMLize and internationalize the help, add Special:ApiHelp (038 comments) [core] - 10https://gerrit.wikimedia.org/r/160798 (https://bugzilla.wikimedia.org/30936) (owner: 10Anomie) [18:00:50] (03PS7) 10Kaldari: Protect against exceeding memory errors when parsing Ogg files [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/161174 (https://bugzilla.wikimedia.org/53840) [18:00:53] (03CR) 10jenkins-bot: [V: 04-1] Protect against exceeding memory errors when parsing Ogg files [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/161174 (https://bugzilla.wikimedia.org/53840) (owner: 10Kaldari) [18:01:06] (03PS2) 10Brian Wolff: Added missing NULL value to sql insert statement. [core] - 10https://gerrit.wikimedia.org/r/161485 (https://bugzilla.wikimedia.org/71022) (owner: 10Wmat) [18:02:26] 3MediaWiki / 3General/Unknown: Default timezone always UTC when using HHVM despite settings in config - 10https://bugzilla.wikimedia.org/71036#c3 (10Ori Livneh) James: thanks a ton for the excellent bug report. I pushed out a fix just now and I think the problem is gone. Can you confirm? [18:02:38] 3MediaWiki / 3Logging: log_params in history merge log events isn't serialized - 10https://bugzilla.wikimedia.org/71044 (10Nathan Larson) [18:02:38] 3MediaWiki / 3Logging: log_params isn't always serialized - 10https://bugzilla.wikimedia.org/70999 (10Nathan Larson) [18:03:22] 3MediaWiki extensions / 3WikidataClient: Usage Tracking: hook up property parser and Lua functions to record usage - 10https://bugzilla.wikimedia.org/64588#c2 (10Daniel Kinzler) Note that I0d342700c tracks usage via the parser function, but not via Lua. [18:03:54] 3MediaWiki / 3General/Unknown: The HHVM BetaFeature needs an image - 10https://bugzilla.wikimedia.org/71048 (10Greg Grossmeier) 3NEW p:3Unprio s:3normal a:3None Sorry Jared :( [18:04:06] (03PS8) 10Kaldari: Protect against exceeding memory errors when parsing Ogg files [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/161174 (https://bugzilla.wikimedia.org/53840) [18:04:07] 3MediaWiki / 3General/Unknown: The HHVM BetaFeature needs an image - 10https://bugzilla.wikimedia.org/71048 (10Greg Grossmeier) p:5Unprio>3Normal [18:05:10] 3Wikimedia / 3Bugzilla: Create a component 'Uploads' for MobileFrontend product - 10https://bugzilla.wikimedia.org/71049 (10Jon) 3NEW p:3Unprio s:3normal a:3None We have various bugs relating to photo uploads but we are not actively supporting it and it would be good to distinguish these from other m... [18:05:23] 3MediaWiki extensions / 3EducationProgram: enrollment token should be mandatory - 10https://bugzilla.wikimedia.org/47081#c1 (10Sage Ross) 5NEW>3RESO/FIX This hasn't turned out to be a problem, so I'm marking it WONTFIX unless and until and proves necessary and users of the extension say they need it. [18:05:53] 3MediaWiki / 3MediaWiki UI: MediaWiki UI styles are applied to core instead of relevant skins, not overridable - 10https://bugzilla.wikimedia.org/70351#c18 (10Isarra) (In reply to Bartosz Dziewoński from comment #17) > You can now override or disable MediaWiki UI styling in your skin. That's backwards, thou... [18:06:03] (03CR) 10SG: [C: 031] Fix noop error on topic pages [extensions/Flow] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161484 (owner: 10EBernhardson) [18:06:40] 3MediaWiki extensions / 3WikidataRepo: Maintenance scripts for populating the untity_usage table from the item_per_site table. - 10https://bugzilla.wikimedia.org/71050 (10Daniel Kinzler) 3NEW p:3Unprio s:3normal a:3Wikidata bugs An initial population of untity_usage could be done based on the item_pe... [18:07:07] 3MediaWiki extensions / 3CirrusSearch: Byte counts under-reported in search results - 10https://bugzilla.wikimedia.org/70919#c2 (10Nik Everett) Cirrus's bytes count is just PHP's strlen function on the text field which is probably wrong now that we're stripping out 'aux_text'. Should we make sure that its t... [18:07:22] 3MediaWiki extensions / 3WikidataClient: track entity usage on client pages - 10https://bugzilla.wikimedia.org/47288 (10Daniel Kinzler) [18:07:23] 3MediaWiki extensions / 3WikidataRepo: Maintenance scripts for populating the untity_usage table from the item_per_site table. - 10https://bugzilla.wikimedia.org/71050 (10Daniel Kinzler) [18:08:08] 3MediaWiki extensions / 3WikimediaEvents: The HHVM BetaFeature needs an image - 10https://bugzilla.wikimedia.org/71048 (10Kunal Mehta (Legoktm)) [18:09:00] (03CR) 10Brian Wolff: [C: 031] "This sounds reasonable to me. I have no ability to test, and really no knowledge about oracle, but I also doubt that there's anyone other " [core] - 10https://gerrit.wikimedia.org/r/161485 (https://bugzilla.wikimedia.org/71022) (owner: 10Wmat) [18:10:09] 3MediaWiki extensions / 3WikidataRepo: Implement "entity change subscription" service - 10https://bugzilla.wikimedia.org/71052 (10Daniel Kinzler) [18:10:11] 3MediaWiki extensions / 3WikidataRepo: Implement "entity change subscription" service - 10https://bugzilla.wikimedia.org/71052 (10Daniel Kinzler) 3NEW p:3Unprio s:3normal a:3Wikidata bugs An "entity change subscription"allows a client wiki to subscribe to changes to a given entity. These subscription... [18:10:22] 3MediaWiki extensions / 3WikidataClient: track entity usage on client pages - 10https://bugzilla.wikimedia.org/47288 (10Daniel Kinzler) [18:10:29] (03CR) 10Kaldari: "Created an upstream pull request: https://github.com/pear/File_Ogg/pull/2" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/161174 (https://bugzilla.wikimedia.org/53840) (owner: 10Kaldari) [18:13:17] (03PS1) 10EBernhardson: Hygiene: Add missing qqq messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161490 [18:13:54] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: insource:// should allow spaces between the /s - 10https://bugzilla.wikimedia.org/71053 (10Nik Everett) 3NEW p:3Unprio s:3normal a:3None insource:// should allow spaces between the /s. Right now you have to do insource:"/spaces ok here/" which is... [18:14:08] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: insource:// should allow spaces between the /s - 10https://bugzilla.wikimedia.org/71053 (10Nik Everett) p:5Unprio>3Normal [18:14:09] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: insource:// should allow spaces between the /s - 10https://bugzilla.wikimedia.org/71053 (10Nik Everett) a:3Nik Everett [18:14:37] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch should provide a way to find hyphenated words, as Lucene-search always has - 10https://bugzilla.wikimedia.org/70950#c5 (10Chad H.) p:5Unprio>3High (In reply to Nik Everett from comment #4) > I think he's right in that hyphenated words are the only thing... [18:14:43] (03CR) 10MaxSem: [C: 032] "looks plausible" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/161174 (https://bugzilla.wikimedia.org/53840) (owner: 10Kaldari) [18:14:56] (03Merged) 10jenkins-bot: Protect against exceeding memory errors when parsing Ogg files [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/161174 (https://bugzilla.wikimedia.org/53840) (owner: 10Kaldari) [18:16:49] (03PS1) 10Brian Wolff: [UNTESTED] Add Oracle version of update-keys.sql [core] - 10https://gerrit.wikimedia.org/r/161491 (https://bugzilla.wikimedia.org/71040) [18:16:55] 3MediaWiki extensions / 3CirrusSearch: Send ES stats to graphite - 10https://bugzilla.wikimedia.org/71055 (10Yuvi Panda) 3NEW p:3Unprio s:3normal a:3None Labs has no ganglia, only graphite. https://github.com/spinscale/elasticsearch-graphite-plugin seems to be a good idea. This will also be super us... [18:19:33] brion: you coming to the meeting today, in person? [18:19:44] TrevorParscal: yep [18:21:01] (03PS2) 10EBernhardson: Fix noop error on topic pages [extensions/Flow] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161484 (https://bugzilla.wikimedia.org/71054) [18:22:39] 3Wikimedia / 3IRC: Wikimania 2015 recent changes not propagated to IRC channel - 10https://bugzilla.wikimedia.org/69741#c1 (10Daniel Zahn) Where does this need to be fixed? really on the IRC server or on the wikimania2015 wiki? do we already know? [18:24:52] 3MediaWiki extensions / 3CirrusSearch: Byte counts under-reported in search results - 10https://bugzilla.wikimedia.org/70919#c3 (10Chad H.) I think it should be the size of the full post-expanded text...we should be able to fetch that from the Revision or Page objects we have on hand during indexing. [18:24:54] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: insource highlighting - 10https://bugzilla.wikimedia.org/71057 (10Nik Everett) 3NEW p:3Unprio s:3normal a:3None We should highlight results of insource queries. If there is a regex in the query then we should only highlight regex matches. If ther... [18:24:55] (03PS1) 10EBernhardson: Make hide available to anonymous users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161493 (https://bugzilla.wikimedia.org/71051) [18:25:29] My vagrant suddenly started throwing sql errors http://pastie.org/9576382 [18:25:32] (03CR) 10jenkins-bot: [V: 04-1] Make hide available to anonymous users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161493 (https://bugzilla.wikimedia.org/71051) (owner: 10EBernhardson) [18:26:17] I am not able to start manually either [18:26:22] (03CR) 10Chad: [C: 032] Remove useless file [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/161476 (owner: 10Manybubbles) [18:26:22] 3MediaWiki extensions / 3CirrusSearch: Byte counts under-reported in search results - 10https://bugzilla.wikimedia.org/70919#c4 (10Nik Everett) You want it with the html? [18:26:42] (03Merged) 10jenkins-bot: Remove useless file [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/161476 (owner: 10Manybubbles) [18:28:37] 3Wikimedia / 3General/Unknown: Install Q&A system at ask.wikimedia.org - 10https://bugzilla.wikimedia.org/29923#c21 (10Andre Klapper) (In reply to Jan Kucera (Kozuch) from comment #20) > a voting system on Q&A site will give you 1000 times better results > in knowing what people want Voting on followup comm... [18:29:47] prtksxna: do you see anything in /var/log/mysql/error.log while starting mysql manually? [18:30:37] 3Wikimedia / 3Deployment systems: Math related warnings in l10nupdate on 1.24wmf9 - 10https://bugzilla.wikimedia.org/66586#c8 (10Andre Klapper) 5PATC>3RESO/FIX Got reopened due to typo in commit message; closing again. [18:31:23] marxarelli: http://pastie.org/pastes/9576418/text [18:32:33] (03PS1) 10Manybubbles: Test regexes with spaces [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/161494 [18:32:37] 3MediaWiki / 3General/Unknown: Default timezone always UTC when using HHVM despite settings in config - 10https://bugzilla.wikimedia.org/71036 (10Andre Klapper) [18:32:48] (03PS2) 10Manybubbles: Test regexes with spaces [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/161494 (https://bugzilla.wikimedia.org/71053) [18:34:54] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: insource:// should allow spaces between the /s - 10https://bugzilla.wikimedia.org/71053#c1 (10Nik Everett) 5NEW>3PATC Added a test for regex queries with spaces here: https://gerrit.wikimedia.org/r/#/c/161494/ I imagine they looked like they didn't wo... [18:34:55] 3Wikimedia / 3Bugzilla: Create a component 'Uploads' for MobileFrontend product - 10https://bugzilla.wikimedia.org/71049#c1 (10Andre Klapper) Created; but who should be on the default CC list? [18:36:08] 3MediaWiki / 3Installer: 923 ORA-00923: FROM keyword not found where expected - 10https://bugzilla.wikimedia.org/71040#c3 (10Bill Traynor) Testing resulted in new error: A database query error has occurred. This may indicate a bug in the software. Query: INSERT IGNORE INTO UPDATELOG (ul_key, ul_value) VAL... [18:36:20] (03PS4) 10AndyRussG: Add UserMerge support [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160916 (https://bugzilla.wikimedia.org/67767) (owner: 10Legoktm) [18:36:51] (03PS2) 10EBernhardson: Make hide available to anonymous users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161493 (https://bugzilla.wikimedia.org/71051) [18:37:27] (03CR) 10jenkins-bot: [V: 04-1] Make hide available to anonymous users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161493 (https://bugzilla.wikimedia.org/71051) (owner: 10EBernhardson) [18:38:30] (03PS2) 10Brian Wolff: [UNTESTED] Add Oracle version of update-keys.sql [core] - 10https://gerrit.wikimedia.org/r/161491 (https://bugzilla.wikimedia.org/71040) [18:38:40] 3MediaWiki extensions / 3Scribunto: mw.ustring.gmatch does not find all matches on HHVM - 10https://bugzilla.wikimedia.org/71061 (10Mormegil) 3NEW p:3Unprio s:3normal a:3None When trying HHVM, I noticed pages using [[cs:Module:Diagram]] on cswiki displayed script error. After testing a little bit, it... [18:38:46] greg-g, Reedy: So… are we switching to 1.25wmf1 [18:39:15] (03PS3) 10EBernhardson: Make hide available to anonymous users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161493 (https://bugzilla.wikimedia.org/71051) [18:40:26] (03CR) 10BryanDavis: [C: 031] "I wrote the patch that is being backported here, but I think backporting it is a good thing. If nothing else it will get rid of some noise" [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161482 (owner: 10Legoktm) [18:40:50] prtksxna: those log entries appear to have been from a few days ago. what do you get from `tail -fn0 /var/log/mysql/error.log` while executing `start mysql`? [18:41:09] (03CR) 10AndyRussG: "Added support for article_reviewers in ep_articles. Smoke tested, seems to work." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160916 (https://bugzilla.wikimedia.org/67767) (owner: 10Legoktm) [18:41:53] prtksxna: the only thing i can find on the errors in what you posted is related to botched mysql upgrades due to a bad postinst script in the package (https://bugs.launchpad.net/ubuntu/+source/mysql-5.5/+bug/1208729) [18:42:26] prtksxna: perhaps a recent upgrade went haywire... [18:42:45] I haven't updated anything, just been pulling code. [18:43:02] marxarelli: Just a minute, let me get the fresh (mm) logs [18:43:23] (03PS1) 10MaxSem: Add page images to mobile watchlist A-Z view [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/161498 [18:43:38] 3MediaWiki extensions / 3CirrusSearch: Byte counts under-reported in search results - 10https://bugzilla.wikimedia.org/70919#c5 (10Chad H.) (In reply to Nik Everett from comment #4) > You want it with the html? Actually probably not. Revision stores it as the strlen() of the wikitext. We just need to get th... [18:44:41] marxarelli: /var/log/mysql.err is empty now [18:44:58] prtksxna: what about /var/log/mysql/error.log? [18:46:23] 3MediaWiki extensions / 3WikimediaEvents: The HHVM BetaFeature needs an image - 10https://bugzilla.wikimedia.org/71048#c1 (10Jared Zimmerman (WMF)) Updated test string… "This experiment improve browsing and editing speed and performance. As more users enable the experiment the system will actually improve... [18:46:37] 3MediaWiki extensions / 3WikimediaEvents: The HHVM BetaFeature needs an image - 10https://bugzilla.wikimedia.org/71048#c2 (10Jared Zimmerman (WMF)) Created attachment 16520 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16520&action=edit beta features image [18:46:41] marxarelli: Nothing new there either [18:46:59] [13node-cssjanus] 15Krinkle pushed 1 new commit to 06master: 02https://github.com/cssjanus/node-cssjanus/commit/75581a28ab112f8048523d180b9f66ca7e829842 [18:46:59] 13node-cssjanus/06master 1475581a2 15Roan Kattouw: Account for decimals and lack of vertical value in background-position [18:47:05] marxarelli: Same as http://pastie.org/pastes/9576418/text [18:47:22] 3Wikimedia / 3General/Unknown: Special:MovePage disappeared from tet.wikipedia - 10https://bugzilla.wikimedia.org/70686#c22 (10Brad Jorsch) (In reply to Jesús Martínez Novo (Ciencia Al Poder) from comment #21) > In JavaScript there's a global variable called wgCanonicalSpecialPageName > [1], which is often u... [18:47:46] (03PS1) 10Anomie: More sensible behavior when special page aliases conflict [core] - 10https://gerrit.wikimedia.org/r/161499 (https://bugzilla.wikimedia.org/70686) [18:48:27] [travis-ci] cssjanus/node-cssjanus#51 (master - 75581a2 : Roan Kattouw): The build passed. [18:48:27] [travis-ci] Change view : https://github.com/cssjanus/node-cssjanus/compare/77646dce8493...75581a28ab11 [18:48:27] [travis-ci] Build details : http://travis-ci.org/cssjanus/node-cssjanus/builds/35760176 [18:48:28] (03PS1) 10Aaron Schulz: Bound the number of DB connections in waitForAll() to 1 [core] - 10https://gerrit.wikimedia.org/r/161500 [18:49:44] (03CR) 10AndyRussG: "Thanks a ton for doing this!!! :) Since to make it work with EP's ORM classes, the ep_users_per_course table got omitted from onUserMergeA" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160954 (owner: 10Reedy) [18:49:57] (03PS3) 10Brian Wolff: Add Oracle version of update-keys.sql [core] - 10https://gerrit.wikimedia.org/r/161491 (https://bugzilla.wikimedia.org/71040) [18:50:53] (03CR) 10Brian Wolff: "Wmat tested this and said it worked:" [core] - 10https://gerrit.wikimedia.org/r/161491 (https://bugzilla.wikimedia.org/71040) (owner: 10Brian Wolff) [18:50:53] 3MediaWiki extensions / 3Mantle: Merge Mantle event emitter and OO.EventEmitter - 10https://bugzilla.wikimedia.org/67107 (10Jon) 5PATC>3RESO/FIX [18:53:07] prtksxna: yikes. i would try starting mysqld with the --no-defaults option (`sudo -u mysql mysqld --no-defaults`) [18:53:34] marxarelli: I am trying to provision vagrant again. I'll try that once that is done [18:54:38] (03CR) 10jenkins-bot: [V: 04-1] More sensible behavior when special page aliases conflict [core] - 10https://gerrit.wikimedia.org/r/161499 (https://bugzilla.wikimedia.org/70686) (owner: 10Anomie) [18:54:45] prtksxna: if all else fails, you can always `vagrant destroy -f` and start fresh [18:54:51] 3Wikimedia / 3Bugzilla: Create a component 'Uploads' for MobileFrontend product - 10https://bugzilla.wikimedia.org/71049#c2 (10Jon) 5NEW>3RESO/FIX That's perfected. No need for a cc list on this one :) Thanks! [18:54:55] marxarelli: Hehe, yeah! [18:55:20] marxarelli: As yuvipanda says, vms are cattle not pets. [18:55:23] A bit mean I think [18:55:33] prtksxna: haha, precisely! [18:55:54] 3MediaWiki / 3General/Unknown: Default timezone always UTC when using HHVM despite settings in config - 10https://bugzilla.wikimedia.org/71036 (10James Alexander) 5PATC>3RESO/FIX [18:55:54] 3MediaWiki / 3General/Unknown: Default timezone always UTC when using HHVM despite settings in config - 10https://bugzilla.wikimedia.org/71036#c4 (10James Alexander) (In reply to Ori Livneh from comment #3) > James: thanks a ton for the excellent bug report. I pushed out a fix just > now and I think the prob... [18:55:58] poor tasty cattle... [18:57:10] 3MediaWiki extensions / 3UniversalLanguageSelector: author name with special character causes problem in Special:Version - 10https://bugzilla.wikimedia.org/71063 (10Dr Brains) 3NEW p:3Unprio s:3normal a:3None Hello, on a personnal installation, the author name "Niklas Laxström" causes Special:Versio... [18:57:44] ..... [18:57:46] * legoktm facepalms [18:58:21] (03CR) 10Wmat: [C: 031] "Tested and the installation completed." [core] - 10https://gerrit.wikimedia.org/r/161491 (https://bugzilla.wikimedia.org/71040) (owner: 10Brian Wolff) [18:59:14] (03PS3) 10Jdlrobson: OOJS: Kill use of super [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/159552 [18:59:29] hm, so pets can be used to shepherd them? [18:59:41] (03PS4) 10Jdlrobson: OOJS: Kill use of super [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/159552 [18:59:47] marxarelli: Grand success! [18:59:55] marxarelli: I destroyed it! [18:59:56] (03PS4) 10Jdlrobson: OOJS: Use OO for class inheritance [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/159553 [19:00:04] prtksxna: \o/ [19:02:07] 3MediaWiki / 3Installer: 923 ORA-00923: FROM keyword not found where expected - 10https://bugzilla.wikimedia.org/71040#c4 (10Bill Traynor) Second patch applied and test and the installation process completed. [19:02:24] 3MediaWiki extensions / 3UniversalLanguageSelector: author name with special character causes problem in Special:Version - 10https://bugzilla.wikimedia.org/71063#c1 (10Bawolff (Brian Wolff)) I can verify that ö is correctly encoded as UTF-8 in the version of UniversalLanguageSelector.php in our git repo. --... [19:02:25] 3MediaWiki extensions / 3WikimediaEvents: The HHVM BetaFeature needs an image - 10https://bugzilla.wikimedia.org/71048#c3 (10Kunal Mehta (Legoktm)) (In reply to Jared Zimmerman (WMF) from comment #1) > Updated test string… > > > "This experiment improve browsing and editing speed and performance. As more >... [19:02:36] (03PS1) 10Anomie: Don't use $wgContLang->specialPage [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/161504 [19:03:15] (03CR) 10jenkins-bot: [V: 04-1] OOJS: Use OO for class inheritance [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/159553 (owner: 10Jdlrobson) [19:06:05] (03CR) 10Umherirrender: [V: 032] "sql is safe and working on any dbms, so no special test for oracle needed" [core] - 10https://gerrit.wikimedia.org/r/161485 (https://bugzilla.wikimedia.org/71022) (owner: 10Wmat) [19:06:24] superm401: Should I continue using the rawElement stuff in Special:Contributions and just make it use vform? I don't see any other way of getting this done [19:06:32] (03CR) 10Umherirrender: [C: 032] Added missing NULL value to sql insert statement. [core] - 10https://gerrit.wikimedia.org/r/161485 (https://bugzilla.wikimedia.org/71022) (owner: 10Wmat) [19:07:22] prtksxna, yeah, I think so (if it's XSS, fix that, but it's totally reasonable to put off HTMLForm for now) [19:11:46] (03PS2) 10Anomie: More sensible behavior when special page aliases conflict [core] - 10https://gerrit.wikimedia.org/r/161499 (https://bugzilla.wikimedia.org/70686) [19:12:03] (03PS1) 10Legoktm: Move non-user specific things from Title::isValidMoveOperation() to MovePage [core] - 10https://gerrit.wikimedia.org/r/161505 [19:12:06] 3MediaWiki / 3Logging: log_params isn't always serialized - 10https://bugzilla.wikimedia.org/70999#c6 (10Umherirrender) Following patches already exists: - gerrit 151683 - Migrate merge log to new log system - gerrit 151701 - Migrate import log to new log system - gerrit 152003 - Migrate block log to new lo... [19:12:56] (03Merged) 10jenkins-bot: Added missing NULL value to sql insert statement. [core] - 10https://gerrit.wikimedia.org/r/161485 (https://bugzilla.wikimedia.org/71022) (owner: 10Wmat) [19:15:26] 3MediaWiki / 3Installer: Installation to Oracle backend fails with a ORA-00947 'Not Enough Values' - 10https://bugzilla.wikimedia.org/71022#c8 (10Umherirrender) 5PATC>3RESO/FIX a:3Bill Traynor successfully merged [19:16:01] (03CR) 10Legoktm: "Anything in the logging table will be taken care of by UserMerge, unless you put user ids inside log_params..." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160916 (https://bugzilla.wikimedia.org/67767) (owner: 10Legoktm) [19:17:48] (03PS5) 10Umherirrender: Set mw.config wgFileCanRotate only on Special:Upload instead of site-wide [core] - 10https://gerrit.wikimedia.org/r/132017 (owner: 10Gerrit Patch Uploader) [19:23:04] (03PS6) 10Umherirrender: Set mw.config wgFileCanRotate only on Special:Upload instead of site-wide [core] - 10https://gerrit.wikimedia.org/r/132017 (owner: 10Gerrit Patch Uploader) [19:23:20] (03PS4) 10Addshore: Improve test coverage of Title::isValidMoveOperation [core] - 10https://gerrit.wikimedia.org/r/161425 (owner: 10Legoktm) [19:23:25] (03CR) 10Addshore: [C: 032] Improve test coverage of Title::isValidMoveOperation [core] - 10https://gerrit.wikimedia.org/r/161425 (owner: 10Legoktm) [19:23:30] (03PS2) 10Addshore: Move non-user specific things from Title::isValidMoveOperation() to MovePage [core] - 10https://gerrit.wikimedia.org/r/161505 (owner: 10Legoktm) [19:23:32] (03CR) 10Umherirrender: "Patch Set 6: Added release notes as suggested by Krinkle and me" [core] - 10https://gerrit.wikimedia.org/r/132017 (owner: 10Gerrit Patch Uploader) [19:27:06] (03CR) 10Addshore: Add UserMerge support (033 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160916 (https://bugzilla.wikimedia.org/67767) (owner: 10Legoktm) [19:29:40] (03CR) 10Umherirrender: Couple of type hints for Block (031 comment) [core] - 10https://gerrit.wikimedia.org/r/160856 (owner: 10Reedy) [19:30:52] 3Wikimedia / 3General/Unknown: Install Q&A system at ask.wikimedia.org - 10https://bugzilla.wikimedia.org/29923#c22 (10Nemo) (In reply to Quim Gil from comment #19) > ... and now you can try it out at https://phab-01.wmflabs.org/ponder/ Can a ponder item be transformed in a maniphest task? [19:30:57] (03Merged) 10jenkins-bot: Improve test coverage of Title::isValidMoveOperation [core] - 10https://gerrit.wikimedia.org/r/161425 (owner: 10Legoktm) [19:31:22] (03CR) 10Addshore: [C: 04-1] "per Umherirrender" [core] - 10https://gerrit.wikimedia.org/r/160856 (owner: 10Reedy) [19:33:43] (03PS2) 10Umherirrender: i18n: Native digits on 'mergehistory-success' [core] - 10https://gerrit.wikimedia.org/r/160173 (owner: 10Reza) [19:33:49] (03CR) 10Umherirrender: [C: 032] i18n: Native digits on 'mergehistory-success' [core] - 10https://gerrit.wikimedia.org/r/160173 (owner: 10Reza) [19:36:51] 3Wikimedia / 3Media storage: File missing on Commons (Charles_I_of_Austria; uploaded 2010) - 10https://bugzilla.wikimedia.org/62629#c2 (10Ankry) file transfered again from elwiki [19:40:54] (03Merged) 10jenkins-bot: i18n: Native digits on 'mergehistory-success' [core] - 10https://gerrit.wikimedia.org/r/160173 (owner: 10Reza) [19:48:33] (03PS5) 10Krinkle: OOjs: Use OO for class inheritance [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/159553 (owner: 10Jdlrobson) [19:50:03] (03PS6) 10Umherirrender: Migrate merge log to new log system [core] - 10https://gerrit.wikimedia.org/r/151683 [19:50:16] (03PS5) 10Krinkle: OOjs: Kill use of _super() [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/159552 (owner: 10Jdlrobson) [19:50:21] (03PS1) 10Manybubbles: Clarify documentation around speed up options [search/highlighter] - 10https://gerrit.wikimedia.org/r/161522 [19:50:28] (03CR) 10Umherirrender: "Patch Set 6: Rebased" [core] - 10https://gerrit.wikimedia.org/r/151683 (owner: 10Umherirrender) [19:51:14] (03CR) 10Krinkle: [C: 031] "Under OOjs you'll be able to use "View.parent" in place of EventEmitter (if you want)." [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/159552 (owner: 10Jdlrobson) [19:51:18] (03PS6) 10Krinkle: OOjs: Use OO for class inheritance [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/159553 (owner: 10Jdlrobson) [19:51:34] (03PS2) 10Umherirrender: Remove 'move' from LogPage::getTitleLink [core] - 10https://gerrit.wikimedia.org/r/151684 [19:53:44] (03PS1) 10Manybubbles: Fix mistake in compatiblity matrix [search/highlighter] - 10https://gerrit.wikimedia.org/r/161523 [19:54:57] And happy ending it is! :o https://lists.wikimedia.org/pipermail/wikimedia-l/2014-September/074685.html [19:55:52] (03CR) 10Adrian Lang: "From my point of view, jQuery's Promises have the obvious disadvantage of being non-standard, but also lack in terms of features compared " [core] - 10https://gerrit.wikimedia.org/r/160949 (owner: 10Adrian Lang) [19:55:58] Nemo_bis: :) [19:57:35] (03PS5) 10Umherirrender: Migrate import log to new log system [core] - 10https://gerrit.wikimedia.org/r/151701 [19:57:53] (03PS4) 10Umherirrender: Migrate block log to new log system [core] - 10https://gerrit.wikimedia.org/r/152003 [19:58:06] (03PS3) 10Umherirrender: Unset redirect param in MoveLogFormatter::getMessageParameters [core] - 10https://gerrit.wikimedia.org/r/152011 [19:59:52] (03PS3) 10Umherirrender: Migrate protect log to new log system [core] - 10https://gerrit.wikimedia.org/r/152156 [20:00:10] (03CR) 10jenkins-bot: [V: 04-1] OOjs: Use OO for class inheritance [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/159553 (owner: 10Jdlrobson) [20:00:18] (03CR) 10Umherirrender: "Patch Set 3: Rebased" [core] - 10https://gerrit.wikimedia.org/r/152156 (owner: 10Umherirrender) [20:00:36] (03PS4) 10Umherirrender: Use new log system when create log entry for revision delete [core] - 10https://gerrit.wikimedia.org/r/152161 [20:01:13] (03CR) 10AndyRussG: "(Sorry if the above comment wasn't clear 8p. This change is potentially superseded by the latest patch sets in https://gerrit.wikimedia.or" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160954 (owner: 10Reedy) [20:03:52] 3MediaWiki extensions / 3Collection: Animated gifs (eg, [[Comet]]) confuse the new PDF renderer - 10https://bugzilla.wikimedia.org/70865 (10C. Scott Ananian) 5PATC>3RESO/FIX [20:03:52] 3MediaWiki extensions / 3Collection: Animated gifs (eg, [[Comet]]) confuse the new PDF renderer - 10https://bugzilla.wikimedia.org/70865#c4 (10C. Scott Ananian) Merged, deployed, tested, confirmed fixed. [20:04:44] (03CR) 10Ragesoss: [C: 031] "I tested this with edge cases and extant bugs related to the Students table, and everything seems to be working well." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160916 (https://bugzilla.wikimedia.org/67767) (owner: 10Legoktm) [20:05:09] 3MediaWiki / 3User login and signup: Users are not logged out when logging in as another user - 10https://bugzilla.wikimedia.org/71066 (10Tyler Romeo) 3NEW p:3Unprio s:3normal a:3None When already logged in, the login form (after I7e40c13a6ca5) will allow users to log in again as another user. Howeve... [20:05:24] 3MediaWiki / 3User login and signup: Login as another user no longer works - 10https://bugzilla.wikimedia.org/70855 (10Tyler Romeo) [20:05:24] 3MediaWiki / 3User login and signup: Users are not logged out when logging in as another user - 10https://bugzilla.wikimedia.org/71066 (10Tyler Romeo) [20:05:56] (03CR) 10Kaldari: [C: 04-1] "Just a question" [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/159553 (owner: 10Jdlrobson) [20:06:09] 3MediaWiki extensions / 3Collection: TIFF images make the new PDF renderer crash (eg [[de:Zweiter Weltkrieg]]) - 10https://bugzilla.wikimedia.org/70866#c4 (10C. Scott Ananian) 5PATC>3RESO/FIX Merged, deployed, tested, confirmed fixed. [20:06:24] (03CR) 10Kaldari: OOjs: Use OO for class inheritance (031 comment) [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/159553 (owner: 10Jdlrobson) [20:07:09] 3MediaWiki extensions / 3Collection: New PDF renderer: [[en:Integral]] fails. - 10https://bugzilla.wikimedia.org/68835#c5 (10C. Scott Ananian) 5REOP>3RESO/FIX Confirmed fixed with latest deployed renderer. [20:08:53] 3MediaWiki extensions / 3Collection: GIFs not supported - 10https://bugzilla.wikimedia.org/70776#c1 (10C. Scott Ananian) 5NEW>3RESO/DUP Fixed by I70a9a6a08cc3f65e775f872728e2e90097fda4b3 (bug 70865). *** This bug has been marked as a duplicate of bug 70865 *** [20:08:53] 3MediaWiki extensions / 3Collection: Animated gifs (eg, [[Comet]]) confuse the new PDF renderer - 10https://bugzilla.wikimedia.org/70865#c5 (10C. Scott Ananian) *** Bug 70776 has been marked as a duplicate of this bug. *** [20:09:18] (03CR) 10MaxSem: [C: 032] Re-apply Ic917c7d, don't cast SpecialPageFactory::$list to an object [core] - 10https://gerrit.wikimedia.org/r/161448 (owner: 10Aude) [20:11:22] 3MediaWiki extensions / 3Collection: [[Corps]], [[Comet]], [[de:Zweiter Weltkrieg]], [[First-move advantage in chess]], and [[United States]] make the PDF renderer crash - 10https://bugzilla.wikimedia.org/68929#c16 (10C. Scott Ananian) 5ASSI>3RESO/FIX Tested, confirmed latest deployment fixes all these a... [20:11:45] (03PS3) 10Legoktm: Move non-user specific things from Title::isValidMoveOperation() to MovePage [core] - 10https://gerrit.wikimedia.org/r/161505 [20:12:01] (03PS4) 10Legoktm: Move non-user specific things from Title::isValidMoveOperation() to MovePage [core] - 10https://gerrit.wikimedia.org/r/161505 [20:12:24] 3MediaWiki / 3Database: PHP Fatal error: Call to undefined function oci_error() with Oracle backend - 10https://bugzilla.wikimedia.org/71068 (10Bill Traynor) 3NEW p:3Unprio s:3normal a:3None Following installation of Mediawiki (git master) with Oracle 11 backend, the MainPage displays: Warning: oci... [20:13:20] (03PS1) 10Ori.livneh: Update Wikidata for a22b5fdad1... Drop type hints [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161570 [20:13:42] (03CR) 10Ori.livneh: [C: 032] Update Wikidata for a22b5fdad1... Drop type hints [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161570 (owner: 10Ori.livneh) [20:14:18] (03PS1) 10Ori.livneh: Update Wikidata for a22b5fdad1... Drop type hints [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/161571 [20:14:36] (03CR) 10Ori.livneh: [C: 032] Update Wikidata for a22b5fdad1... Drop type hints [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/161571 (owner: 10Ori.livneh) [20:16:08] (03CR) 10Cscott: "Nice! I'm just going to add a comment explaining the encodeURI magic, then +2 it." [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/160235 (https://bugzilla.wikimedia.org/68836) (owner: 10Arlolra) [20:16:42] (03Merged) 10jenkins-bot: Re-apply Ic917c7d, don't cast SpecialPageFactory::$list to an object [core] - 10https://gerrit.wikimedia.org/r/161448 (owner: 10Aude) [20:17:44] (03Merged) 10jenkins-bot: Update Wikidata for a22b5fdad1... Drop type hints [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161570 (owner: 10Ori.livneh) [20:19:06] (03Merged) 10jenkins-bot: Update Wikidata for a22b5fdad1... Drop type hints [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/161571 (owner: 10Ori.livneh) [20:19:53] congrats cscott :) https://bugzilla.wikimedia.org/show_bug.cgi?id=68929 [20:20:04] hopefully on Monday I'll debug some more [20:21:33] (03PS4) 10Cscott: Hash all metabook props for the collection id [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/160235 (https://bugzilla.wikimedia.org/68836) (owner: 10Arlolra) [20:21:37] 3MediaWiki extensions / 3WikimediaEvents: The HHVM BetaFeature needs an image - 10https://bugzilla.wikimedia.org/71048#c4 (10Jared Zimmerman (WMF)) Too technical, too many acronyms, its not in the voice and tone that we should be writing in. Someone should not have to understand what any of those concepts ar... [20:22:07] 3MediaWiki / 3Database: PHP Fatal error: Call to undefined function oci_error() with Oracle backend - 10https://bugzilla.wikimedia.org/71068 (10Jesús Martínez Novo (Ciencia Al Poder)) [20:22:23] 3MediaWiki / 3Database: Oracle DB support (tracking) - 10https://bugzilla.wikimedia.org/38916 (10Jesús Martínez Novo (Ciencia Al Poder)) [20:22:24] (03CR) 10Cscott: [C: 032] Hash all metabook props for the collection id [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/160235 (https://bugzilla.wikimedia.org/68836) (owner: 10Arlolra) [20:22:42] (03Merged) 10jenkins-bot: Hash all metabook props for the collection id [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/160235 (https://bugzilla.wikimedia.org/68836) (owner: 10Arlolra) [20:23:30] (03CR) 10Cscott: Conform settings to metabook.json spec (031 comment) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/160911 (https://bugzilla.wikimedia.org/68836) (owner: 10Arlolra) [20:28:39] (03PS1) 10Aaron Schulz: Randomize the JobRunner slave lags checks a bit [core] - 10https://gerrit.wikimedia.org/r/161577 [20:33:37] (03PS5) 10AndyRussG: Add UserMerge support [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160916 (https://bugzilla.wikimedia.org/67767) (owner: 10Legoktm) [20:35:57] (03PS2) 10Umherirrender: Remove redundant $db->resultObject() calls [core] - 10https://gerrit.wikimedia.org/r/159969 (owner: 10PleaseStand) [20:36:05] (03CR) 10Umherirrender: [C: 032] Remove redundant $db->resultObject() calls [core] - 10https://gerrit.wikimedia.org/r/159969 (owner: 10PleaseStand) [20:38:33] (03PS1) 10Bartosz Dziewoński: Add grammar forms for Wikidata in Polish [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/161580 [20:41:38] (03PS2) 10Bartosz Dziewoński: Add grammar forms for Wikidata in Polish [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/161580 [20:42:38] (03Merged) 10jenkins-bot: Remove redundant $db->resultObject() calls [core] - 10https://gerrit.wikimedia.org/r/159969 (owner: 10PleaseStand) [20:46:51] (03PS1) 10Umherirrender: Database::dataSeek -> ResultWrapper::seek [core] - 10https://gerrit.wikimedia.org/r/161582 [20:52:28] (03PS1) 10Jforrester: Bump 1.25 [core] - 10https://gerrit.wikimedia.org/r/161584 [20:53:13] (Someone had to.) [20:55:07] James_F: did we already branch? [20:55:31] legoktm: 1.24wmf22 went out yesterday. [20:55:40] well let me create REL1_24 right now [20:55:41] legoktm: REL1_24 will follow in a while. [20:55:52] legoktm: Eh, shouldn't we leave that to Mark and Marcus? [20:56:07] "Bump 1.25" shouldn't be in REL1_24 [20:56:07] legoktm: It's their ship to run… [20:56:23] * bawolff would say that 1.25 should be bumped immediately after REL1_24 is branched, whenever that is [20:56:37] Sure, but that just means they need to make sure when they branch REL1_24 that they pick the patch before "bump 1.25". [20:56:52] Creating branches doesn't have to be from master. :-) [20:56:57] ture [20:56:59] *true [20:57:12] We can come back in a month and decide what's in REL1_24. [20:57:16] But yeah, sooner is better. [20:58:29] (03CR) 10Legoktm: [C: 04-1] Bump 1.25 (032 comments) [core] - 10https://gerrit.wikimedia.org/r/161584 (owner: 10Jforrester) [20:58:51] 3MediaWiki / 3Uploading: Uppercase picture extensions like .PNG are not allowed - 10https://bugzilla.wikimedia.org/66667#c8 (10Cindy Cicalese) We also experienced this bug after upgrading a wiki from 1.13.2 to 1.23.1. Following the suggestion above ("Removing the ! in includes/libs/IEUrlExtension.php at line... [20:59:07] I'd say in the ideal world there would be some cut off date decided which is advertised in advanced so that people could try to get specific patches merged if for some reason they really want it in the next version [20:59:56] (possibly that could even be the case already, I haven't been reading the 1.24 related emails on wikitech-l) [21:00:24] (03PS2) 10Jforrester: Bump 1.25 [core] - 10https://gerrit.wikimedia.org/r/161584 [21:00:41] (03CR) 10Jforrester: Bump 1.25 (032 comments) [core] - 10https://gerrit.wikimedia.org/r/161584 (owner: 10Jforrester) [21:01:23] (03CR) 10Umherirrender: "You have to chance the version also in PhpVersionError.php" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/161584 (owner: 10Jforrester) [21:01:27] (03CR) 10Legoktm: [C: 032] Bump 1.25 [core] - 10https://gerrit.wikimedia.org/r/161584 (owner: 10Jforrester) [21:01:45] (03CR) 10Legoktm: Bump 1.25 [core] - 10https://gerrit.wikimedia.org/r/161584 (owner: 10Jforrester) [21:02:58] (03CR) 10Umherirrender: "*chance* -> *change*" [core] - 10https://gerrit.wikimedia.org/r/161584 (owner: 10Jforrester) [21:03:46] (03CR) 10Jforrester: "This was based on cd97e613. Clearly I should have not trusted that. :-)" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/161584 (owner: 10Jforrester) [21:03:50] (03PS3) 10Jforrester: Bump 1.25 [core] - 10https://gerrit.wikimedia.org/r/161584 [21:05:21] (03CR) 10Anomie: API: HTMLize and internationalize the help, add Special:ApiHelp (035 comments) [core] - 10https://gerrit.wikimedia.org/r/160798 (https://bugzilla.wikimedia.org/30936) (owner: 10Anomie) [21:05:22] 3MediaWiki / 3Installer: Installation to Oracle backend fails with a ORA-00947 'Not Enough Values' - 10https://bugzilla.wikimedia.org/71022#c9 (10Andre Klapper) Was that only broken in git master, or also in 1.23 tarballs (-> consider backporting)? [21:05:27] (03PS8) 10Anomie: API: HTMLize and internationalize the help, add Special:ApiHelp [core] - 10https://gerrit.wikimedia.org/r/160798 (https://bugzilla.wikimedia.org/30936) [21:05:56] (03CR) 10jenkins-bot: [V: 04-1] API: HTMLize and internationalize the help, add Special:ApiHelp [core] - 10https://gerrit.wikimedia.org/r/160798 (https://bugzilla.wikimedia.org/30936) (owner: 10Anomie) [21:08:52] (03CR) 10Anomie: "Why not call the hook from AbstractContent::getParserOutput, instead of reproducing it there and having to do so for any other content mod" [core] - 10https://gerrit.wikimedia.org/r/161471 (owner: 10Gergő Tisza) [21:09:11] (03Abandoned) 10Legoktm: Double check its safe before dropping new table during db cloning [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/142018 (https://bugzilla.wikimedia.org/65654) (owner: 10MarkAHershberger) [21:09:37] 3MediaWiki / 3Unit tests: parser tests drops anything in $wgSharedTables - 10https://bugzilla.wikimedia.org/65654 (10Kunal Mehta (Legoktm)) [21:09:39] (03CR) 10Anomie: Introduce ContentAlterParserOutput hook (031 comment) [core] - 10https://gerrit.wikimedia.org/r/161471 (owner: 10Gergő Tisza) [21:10:38] 3MediaWiki / 3Installer: Installation to Oracle backend fails with a ORA-00947 'Not Enough Values' - 10https://bugzilla.wikimedia.org/71022#c10 (10Umherirrender) (In reply to Andre Klapper from comment #9) > Was that only broken in git master, or also in 1.23 tarballs (-> consider > backporting)? The new co... [21:11:41] (03CR) 10Legoktm: [C: 032] Bump 1.25 [core] - 10https://gerrit.wikimedia.org/r/161584 (owner: 10Jforrester) [21:12:12] 3MediaWiki / 3General/Unknown: Investigate whether taking an action on a page (delete, import, etc.) should require being able to edit it - 10https://bugzilla.wikimedia.org/69380#c30 (10Brad Jorsch) 5PATC>3RESO/FIX Probably RESOLVED FIXED since comment 28. Let's just be bold and close it that way, if pe... [21:12:13] I'll email wikitech-l about ^ after lunch [21:13:08] (03CR) 10Bartosz Dziewoński: "> Right now, mw.Api leaks implementation details by returning non-standard Promises." [core] - 10https://gerrit.wikimedia.org/r/160949 (owner: 10Adrian Lang) [21:13:31] (03CR) 10Umherirrender: "> This was based on cd97e613. Clearly I should have not" [core] - 10https://gerrit.wikimedia.org/r/161584 (owner: 10Jforrester) [21:14:08] 3MediaWiki / 3General/Unknown: author name with special character causes problem in Special:Version - 10https://bugzilla.wikimedia.org/71063 (10Andre Klapper) 5NEW>3UNCO [21:14:28] eek [21:14:43] legoktm: James_F: are you planning to branch REL1_24 from some random point that isn't master at the time? [21:14:57] i guess everyone is going to have fun figuring out which patches made it and which didn't… [21:17:47] (03Merged) 10jenkins-bot: Bump 1.25 [core] - 10https://gerrit.wikimedia.org/r/161584 (owner: 10Jforrester) [21:17:54] 3MediaWiki / 3Unit tests: Assert that ResourceLoader modules loaded successfully - 10https://bugzilla.wikimedia.org/44299#c24 (10spage) Note that the mediawiki_selenium gem also implements this, so you can add step "page has no ResourceLoader errors" to browser tests. https://github.com/wikimedia/mediawik... [21:19:07] 3MediaWiki / 3User login and signup: Users are not logged out when logging in as another user - 10https://bugzilla.wikimedia.org/71066#c1 (10Bartosz Dziewoński) (In reply to Tyler Romeo from comment #0) > Extensions may be expecting the appropriate hooks to be called any time a > user ends their session (and... [21:19:37] 3MediaWiki / 3Page editing: Revert bug 27860 or add configuration variable to restore "Mark all edits minor by default" preference behaviour - 10https://bugzilla.wikimedia.org/42008#c8 (10Bawolff (Brian Wolff)) Do people still strongly care about this issue/Want me to fix it (by fix I mean add a global to co... [21:21:52] (03CR) 10Dan-nl: "no worries Ori.livneh, i just hope it helps resolve the issue. thanks for taking a look at it when you can." [core] - 10https://gerrit.wikimedia.org/r/159973 (owner: 10Dan-nl) [21:22:21] 3Wikimedia / 3General/Unknown: Install Q&A system at ask.wikimedia.org - 10https://bugzilla.wikimedia.org/29923#c23 (10Jan Kucera (Kozuch)) (In reply to Andre Klapper from comment #21) > Voting on followup comments to a question? Voting on questions themselves? > I hope the former. (Personally wondering... [21:22:32] (03PS10) 10Brian Wolff: Special:Import not importing Special:Export XMLs [core] - 10https://gerrit.wikimedia.org/r/159973 (https://bugzilla.wikimedia.org/66023) (owner: 10Dan-nl) [21:22:39] (03CR) 10Spage: [C: 032] "Tested locally: avoids exception, 'ext.flow.new' module loads, and Topic JS enhancements work." [extensions/Flow] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161484 (https://bugzilla.wikimedia.org/71054) (owner: 10EBernhardson) [21:23:17] (03PS7) 10Jdlrobson: OOjs: Use OO for class inheritance [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/159553 [21:23:45] (03Merged) 10jenkins-bot: Fix noop error on topic pages [extensions/Flow] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161484 (https://bugzilla.wikimedia.org/71054) (owner: 10EBernhardson) [21:23:51] (03CR) 10jenkins-bot: [V: 04-1] OOjs: Use OO for class inheritance [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/159553 (owner: 10Jdlrobson) [21:23:55] MatmaRex: Yeah. [21:24:12] (03CR) 10Bartosz Dziewoński: [C: 032] "I was convinced." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/160213 (https://bugzilla.wikimedia.org/70814) (owner: 10Seb35) [21:24:23] (03Merged) 10jenkins-bot: Display the required skins [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/160213 (https://bugzilla.wikimedia.org/70814) (owner: 10Seb35) [21:24:28] (03PS8) 10Jdlrobson: OOjs: Use OO for class inheritance [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/159553 [21:24:39] 3MediaWiki / 3Page editing: Revert bug 27860 or add configuration variable to restore "Mark all edits minor by default" preference behaviour - 10https://bugzilla.wikimedia.org/42008#c9 (10Nemo) Dunno what qualifies for "strongly care" but I still think this was very wrong and would love to have the checkboxe... [21:24:52] 3MediaWiki / 3Installer: Installation to Oracle backend fails with a ORA-00947 'Not Enough Values' - 10https://bugzilla.wikimedia.org/71022#c11 (10Umherirrender) (In reply to Umherirrender from comment #10) > (In reply to Andre Klapper from comment #9) > > Was that only broken in git master, or also in 1.23... [21:24:58] (03CR) 10jenkins-bot: [V: 04-1] OOjs: Use OO for class inheritance [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/159553 (owner: 10Jdlrobson) [21:25:07] 3MediaWiki extensions / 3BetaFeatures: Allowed skins are not displayed - 10https://bugzilla.wikimedia.org/70814#c7 (10Bartosz Dziewoński) 5PATC>3NEW Hah, fascinating. Okay, let's do this then. Should we mark this as resolved after merging the patch, or do you want to actually display this information? [21:26:29] (03CR) 10Bartosz Dziewoński: "Is this still needed after https://gerrit.wikimedia.org/r/160213 ?" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/159538 (https://bugzilla.wikimedia.org/69823) (owner: 10Jforrester) [21:26:35] (03CR) 10Bartosz Dziewoński: [C: 04-1] Populate $features even if there aren't any requirements [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/159538 (https://bugzilla.wikimedia.org/69823) (owner: 10Jforrester) [21:27:52] MatmaRex: Umm. [21:28:00] (03PS9) 10Jdlrobson: OOjs: Use OO for class inheritance [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/159553 [21:28:06] MatmaRex: I'm trying to get my head around what you just merged in BetaFeatures. [21:28:27] (03CR) 10jenkins-bot: [V: 04-1] OOjs: Use OO for class inheritance [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/159553 (owner: 10Jdlrobson) [21:28:43] MatmaRex: The bug isn't even yet vetted by me and I think it's based on a mistaken idea of what the requirement warnings are for… [21:28:49] James_F: the patch makes it actually check the skin requirements instead of always ignoring them [21:29:09] MatmaRex: https://gerrit.wikimedia.org/r/#/c/160213/3/resources/betafeatures.less looks like it completely missed the point. [21:29:24] MatmaRex: The intent of the warnings is to display only if they are unmet. [21:29:31] James_F: when i tested, it showed big red warnings under every beta feature [21:29:43] MatmaRex: Then that's a bug and you should fix it… [21:29:47] i poked you about this yesterday [21:29:50] You did? [21:30:11] i believe i did, grep your logs for bug number :) [21:30:31] It doesn't come up in local scrollback… [21:30:47] Anyway, what was your question? [21:30:49] James_F: given that it previously showed big red warnings about requiring javascript under every beta feature, i thought big red warnings are expected, and also though they're a really poor idea. [21:31:04] MatmaRex: So… you didn't see https://gerrit.wikimedia.org/r/159538 ? [21:31:37] not before today [21:31:49] :-( [21:31:56] the entire thing seems really underspecced and under-cared-for, eh… [21:32:07] 3Wikimedia / 3General/Unknown: Install Q&A system at ask.wikimedia.org - 10https://bugzilla.wikimedia.org/29923#c24 (10Quim Gil) If i18n needs to be part of the equation, then Flow with votes might be indeed more feasible than Phabricator with a multilingual environment. (In reply to Nemo from comment #22)... [21:32:12] never liked it myself, either [21:32:20] so, what needs fixing then? [21:32:22] MatmaRex: Well, yes, it's my tenth-priority project after VE, WT, etc. [21:32:58] James_F: (i think i actually asked you who's the person who takes care of BF. so i guess that's you. :P) [21:33:43] Yes, it's me. [21:34:01] I took it over from Fabrice six months ago or so. [21:34:08] But in a "caretaker" capacity, mostly. [21:34:31] (03PS12) 10Jdlrobson: Tweak checkbox sizes to be relative depending on where used. [core] - 10https://gerrit.wikimedia.org/r/154125 (https://bugzilla.wikimedia.org/70133) [21:36:50] MatmaRex: Have replied on the bug. [21:36:54] 3MediaWiki extensions / 3BetaFeatures: Allowed skins are not displayed - 10https://bugzilla.wikimedia.org/70814#c8 (10James Forrester) I'm… confused. The purpose of the Beta Feature warning section is to inform you why enabling it won't be useful to you. I.e.: * if you don't have JS working, tell you if i... [21:38:28] (03PS1) 10Spage: Update Flow with bug 71054 backport [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161591 [21:38:38] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: Warnings about allowed skins are not displayed (NOTABUG?) - 10https://bugzilla.wikimedia.org/70814 (10James Forrester) [21:40:36] 3MediaWiki / 3General/Unknown: author name with special character causes problem in Special:Version - 10https://bugzilla.wikimedia.org/71063#c2 (10Bawolff (Brian Wolff)) To clarify, I originally skimmed this and missed the word "crash". Crash is a bit ambiguous (Do you mean php segfaults? something else), bu... [21:40:55] MatmaRex: Also, http://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences?useskin=cologneblue#mw-prefsection-betafeatures doesn't seem to have changed much. [21:44:16] (03PS1) 10EBernhardson: Delete unused user_subs from container.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161593 [21:44:19] (03PS1) 10EBernhardson: Don't statically access the container for cache.version [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161594 [21:46:06] (03PS7) 10Physikerwelt: Fine grained options for wgMathDisableTeXFilter [extensions/Math] - 10https://gerrit.wikimedia.org/r/158845 [21:47:06] (03CR) 10Spage: [C: 032] "OK to backport" [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161591 (owner: 10Spage) [21:47:18] (03CR) 10jenkins-bot: [V: 04-1] Fine grained options for wgMathDisableTeXFilter [extensions/Math] - 10https://gerrit.wikimedia.org/r/158845 (owner: 10Physikerwelt) [21:47:23] James_F: without the CSS hack that commit added, it'd look like this in Vector: http://i.imgur.com/Q1ytbvB.png [21:47:37] (03CR) 10jenkins-bot: [V: 04-1] Don't statically access the container for cache.version [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161594 (owner: 10EBernhardson) [21:47:52] James_F: if the requirement information is not supposed to be shown, then that's a bug… [21:49:06] 3MediaWiki / 3Page editing: Revert bug 27860 or add configuration variable to restore "Mark all edits minor by default" preference behaviour - 10https://bugzilla.wikimedia.org/42008#c10 (10Laurence 'GreenReaper' Parry) Yes, what Nemo said. I have a patch for this against 1.23 at: http://pool.wikifur.com/Ed... [21:49:54] (03Merged) 10jenkins-bot: Update Flow with bug 71054 backport [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161591 (owner: 10Spage) [21:51:14] (03PS1) 10Manybubbles: Better error logging [search/highlighter] - 10https://gerrit.wikimedia.org/r/161598 [21:51:23] (03PS1) 10Manybubbles: Switch regex enum from bytes to chars [search/highlighter] - 10https://gerrit.wikimedia.org/r/161599 [21:52:38] 3Wikimedia / 3General/Unknown: Install Q&A system at ask.wikimedia.org - 10https://bugzilla.wikimedia.org/29923#c25 (10Jan Kucera (Kozuch)) To not only bite I add an idea - there probably should be multiple strictly THEMATIC Q&A site instances around - exactly as Stack Exchnge sites do it - i can imagime som... [21:53:40] (03PS1) 10EBernhardson: @root.submitted may not exist in flow_reply_form [extensions/Flow] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161604 [21:53:52] 3MediaWiki extensions / 3Math: Release Math 2.0 - 10https://bugzilla.wikimedia.org/65341 (10physikerwelt) [21:55:37] (03PS1) 10Ori.livneh: Update Wikidata for cherry-pick of I1a872d12e [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161606 [21:55:50] (03PS1) 10Ori.livneh: Update Wikidata for cherry-pick of I1a872d12e [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/161607 [21:56:03] (03CR) 10Ori.livneh: [C: 032 V: 032] Update Wikidata for cherry-pick of I1a872d12e [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161606 (owner: 10Ori.livneh) [21:56:06] MatmaRex: I'm branching core to the commit before the "Bump 1.25", but what do you need reviewed? [21:56:10] (03CR) 10Ori.livneh: [C: 032 V: 032] Update Wikidata for cherry-pick of I1a872d12e [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/161607 (owner: 10Ori.livneh) [21:57:24] (branched) [21:57:41] legoktm: okay, that's cool with me [21:57:55] i'll need to backport some stuff, but some of that stuff isn't written yet [21:58:05] tomorrow, or monday. [21:58:48] legoktm: i also have two less/css/cssjanus/cssmin patches targeting 1.24, https://gerrit.wikimedia.org/r/161245 and https://gerrit.wikimedia.org/r/161091 , but i was hoping some of the guys who wrote the stuff i'm changing would review that [21:59:18] wooh, scary [21:59:24] :D [21:59:41] i like the one where i remove 150 lines of code and fix four bugs [21:59:52] 3MediaWiki / 3Export/Import: Importing does not work with HHVM - 10https://bugzilla.wikimedia.org/66023#c11 (10Andre Klapper) *** Bug 70658 has been marked as a duplicate of this bug. *** [21:59:57] (well, two actually, krinkl.e did some dupe'ing :( ) [22:00:04] (03CR) 10Kaldari: [C: 032] OOjs: Use OO for class inheritance [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/159553 (owner: 10Jdlrobson) [22:00:29] (03CR) 10Kaldari: [C: 032] OOjs: Kill use of _super() [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/159552 (owner: 10Jdlrobson) [22:01:20] (03Draft2) 10Physikerwelt: WIP: Workaround for JUnit bug [extensions/Math] - 10https://gerrit.wikimedia.org/r/161608 [22:01:25] (03PS2) 10Cmcmahon: QA: fix Topic collapsing for new modal dialog [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161411 (owner: 10Spage) [22:01:44] (03PS3) 10Physikerwelt: WIP: Workaround for JUnit bug [extensions/Math] - 10https://gerrit.wikimedia.org/r/161608 [22:03:50] MatmaRex: oooh, we can merge your kill skin autodiscovery patch now! [22:04:34] (03PS1) 10Physikerwelt: WIP: Workaround for JUnit bug [extensions/Math] - 10https://gerrit.wikimedia.org/r/161610 [22:04:36] (03PS1) 10Manybubbles: Highlighting for insource [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/161611 (https://bugzilla.wikimedia.org/71057) [22:04:49] (03PS3) 10Cmcmahon: QA: fix Topic collapsing for new modal dialog [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161411 (owner: 10Spage) [22:04:52] (03PS18) 10Jdlrobson: Add mw-ui-icon [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) [22:04:52] 3MediaWiki / 3API: Disable minor edit for page/section creation by API - 10https://bugzilla.wikimedia.org/40111#c3 (10Laurence 'GreenReaper' Parry) Not sure if this should be reopened, but I don't think it should ever have been done, since there was no justification or consensus for removing this functionali... [22:05:01] (03Abandoned) 10Physikerwelt: WIP: Workaround for JUnit bug [extensions/Math] - 10https://gerrit.wikimedia.org/r/161608 (owner: 10Physikerwelt) [22:06:08] (03CR) 10Legoktm: [C: 04-1] "Needs rebase, but today is 19 Sept." [core] - 10https://gerrit.wikimedia.org/r/154831 (https://bugzilla.wikimedia.org/69673) (owner: 10Bartosz Dziewoński) [22:06:30] (03CR) 10Legoktm: "Should this be cherry-picked into REL1_24?" [core] - 10https://gerrit.wikimedia.org/r/157183 (owner: 10Bartosz Dziewoński) [22:06:47] (03CR) 10Legoktm: [C: 04-1] "Needs rebase, but ready to go!" [core] - 10https://gerrit.wikimedia.org/r/135439 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [22:07:54] (03CR) 10Chad: [C: 031] "lgtm if i18n is ok'd." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/161039 (owner: 10Manybubbles) [22:08:28] (03CR) 10Chad: [C: 032] Add stats to "get" searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/161338 (owner: 10Manybubbles) [22:08:52] (03CR) 10Chad: [C: 032] Clarify documentation around speed up options [search/highlighter] - 10https://gerrit.wikimedia.org/r/161522 (owner: 10Manybubbles) [22:08:56] Does anyone see why Jenkins does not run tests for this commit https://gerrit.wikimedia.org/r/#/c/161610/ [22:09:20] (03CR) 10Manybubbles: "recheck" [extensions/Math] - 10https://gerrit.wikimedia.org/r/161610 (owner: 10Physikerwelt) [22:10:19] physikerwelt: https://integration.wikimedia.org/zuul/ looks like jenkins is stuck? [22:10:47] ok thank you [22:10:51] legoktm: yes. tomorrow? [22:11:07] sure [22:11:30] (03CR) 10Jdlrobson: [C: 032] "go to go gadget jenkins" [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/159552 (owner: 10Jdlrobson) [22:11:46] (03CR) 10Chad: [C: 032] Fix multiple phrase queries in same search [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/161474 (owner: 10Manybubbles) [22:12:23] legoktm: Strange jenkins does not seem to be very busy https://integration.wikimedia.org/ci/ [22:13:45] (03PS2) 10Physikerwelt: WIP: Workaround for a potential phpUnit bug [extensions/Math] - 10https://gerrit.wikimedia.org/r/161610 [22:14:06] (03CR) 10Chad: [C: 032] Better error logging [search/highlighter] - 10https://gerrit.wikimedia.org/r/161598 (owner: 10Manybubbles) [22:14:31] legoktm: never mind... I'll come back to this later cu [22:17:23] 3MediaWiki / 3Recent changes: Make enhanced recentchanges the default - 10https://bugzilla.wikimedia.org/35785 (10Kunal Mehta (Legoktm)) [22:18:21] 3MediaWiki / 3General/Unknown: QA tests in mediawiki-core should have no logic or mention of Wikimedia Foundation wikis - 10https://bugzilla.wikimedia.org/67616#c3 (10Kunal Mehta (Legoktm)) Has any progress been made on this? [22:19:06] 3MediaWiki / 3Installer: Include short descriptions for extensions bundled in the release - 10https://bugzilla.wikimedia.org/43817 (10Kunal Mehta (Legoktm)) [22:19:38] (03CR) 10Jeroen De Dauw: Bump 1.25 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/161584 (owner: 10Jforrester) [22:20:39] 3MediaWiki / 3JobQueue: JobQueue does not respect --maxtime - 10https://bugzilla.wikimedia.org/71073 (10Niklas Laxström) 3NEW p:3Unprio s:3major a:3None translatewiki.net suffered degraded service today after changes to Template:Identical caused a huge amount of jobs generated. The issue was that I... [22:22:10] 3MediaWiki / 3JobQueue: JobQueue does not respect --maxtime - 10https://bugzilla.wikimedia.org/71073 (10Nemo) [22:22:10] 3MediaWiki / 3General/Unknown: Bugs affecting translatewiki.net (errors from MediaWiki master) (tracking) - 10https://bugzilla.wikimedia.org/39480 (10Nemo) [22:22:47] (03CR) 10MaxSem: Bump 1.25 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/161584 (owner: 10Jforrester) [22:23:38] (03Merged) 10jenkins-bot: Clarify documentation around speed up options [search/highlighter] - 10https://gerrit.wikimedia.org/r/161522 (owner: 10Manybubbles) [22:24:10] (03CR) 10Legoktm: "https://lists.wikimedia.org/pipermail/wikitech-l/2014-September/078716.html" [core] - 10https://gerrit.wikimedia.org/r/161584 (owner: 10Jforrester) [22:25:10] (03Merged) 10jenkins-bot: Better error logging [search/highlighter] - 10https://gerrit.wikimedia.org/r/161598 (owner: 10Manybubbles) [22:26:37] (03CR) 10Kaldari: "Min-width 80px is too large for mobile. We could probably live with min-width 70px though." [core] - 10https://gerrit.wikimedia.org/r/161248 (https://bugzilla.wikimedia.org/70972) (owner: 10Prtksxna) [22:27:27] (03PS1) 10Aaron Schulz: Fixed --maxtime handling by JobRunner [core] - 10https://gerrit.wikimedia.org/r/161618 [22:28:24] (03Abandoned) 10Aaron Schulz: Removed LCStoreDB class [core] - 10https://gerrit.wikimedia.org/r/153944 (owner: 10Aaron Schulz) [22:28:52] (03PS1) 10Kaldari: Reduce new button min-width from 80px to 70px [core] - 10https://gerrit.wikimedia.org/r/161620 [22:29:48] (03Abandoned) 10Manybubbles: Add script to squash deletes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/160473 (owner: 10Manybubbles) [22:30:34] MatmaRex: Can you merge https://gerrit.wikimedia.org/r/#/c/161620/ ? [22:31:04] (03CR) 10Bartosz Dziewoński: [C: 032] Reduce new button min-width from 80px to 70px [core] - 10https://gerrit.wikimedia.org/r/161620 (owner: 10Kaldari) [22:31:05] heh. [22:31:12] MatmaRex: Thanks! [22:31:31] MatmaRex: That saves me from having to do a bunhc of overrides in MobileFrontend :) [22:32:17] (03PS1) 10Aaron Schulz: Fixed --maxtime handling by JobRunner [core] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/161621 [22:32:52] 3MediaWiki / 3MediaWiki UI: Normal buttons should have a minimum width to provide accessible targets - 10https://bugzilla.wikimedia.org/70972#c3 (10Ryan Kaldari) I changed it from 80px to 70px since 80px was too large for some mobile uses. See https://gerrit.wikimedia.org/r/#/c/161620/. [22:33:49] MatmaRex: So… yeah, that bug sounds worse, not better. [22:34:52] (03CR) 10Jforrester: Bump 1.25 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/161584 (owner: 10Jforrester) [22:35:30] James_F: you mean betafeatures? i'll give that a detailed look tomorrow morning [22:35:50] probably [22:35:59] perhaps later, but before you wake up on monday ;) [22:40:36] 3MediaWiki / 3Export/Import: Import of Commons partial export fails with error about plurals-mediawiki.xml - 10https://bugzilla.wikimedia.org/56439#c13 (10This, that and the other (TTO)) Not sure if any of those commenters actually tested it... [22:40:41] MatmaRex: Yeah. [22:40:53] MatmaRex: I'll be here from ~07:30 SF time, so… :-) [22:42:00] James_F: that still leaves me with the entire weekend and about half of my monday ;) [22:42:51] (03CR) 10Jforrester: "Yes." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/159538 (https://bugzilla.wikimedia.org/69823) (owner: 10Jforrester) [22:42:52] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: Settings pane looks ugly with JavaScript disabled - 10https://bugzilla.wikimedia.org/69778 (10James Forrester) [22:44:22] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: Provide an anchor link for each beta feature - 10https://bugzilla.wikimedia.org/65315 (10James Forrester) [22:46:00] (03PS2) 10Nikerabbit: Fixed --maxtime handling by JobRunner [core] - 10https://gerrit.wikimedia.org/r/161618 (https://bugzilla.wikimedia.org/71073) (owner: 10Aaron Schulz) [22:46:41] (03CR) 10Nikerabbit: [C: 032] "Tested at translatewiki.net" [core] - 10https://gerrit.wikimedia.org/r/161618 (https://bugzilla.wikimedia.org/71073) (owner: 10Aaron Schulz) [22:48:36] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: Show a message on the BF preferences pane with details of how to write your own - 10https://bugzilla.wikimedia.org/70154 (10James Forrester) [22:49:54] (03Merged) 10jenkins-bot: OOjs: Kill use of _super() [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/159552 (owner: 10Jdlrobson) [22:49:56] (03CR) 10jenkins-bot: [V: 04-1] OOjs: Use OO for class inheritance [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/159553 (owner: 10Jdlrobson) [22:50:07] (03Merged) 10jenkins-bot: Add stats to "get" searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/161338 (owner: 10Manybubbles) [22:50:15] (03PS2) 10Arlolra: Conform settings to metabook.json spec [extensions/Collection] - 10https://gerrit.wikimedia.org/r/160911 (https://bugzilla.wikimedia.org/68836) [22:50:22] (03Merged) 10jenkins-bot: Fix multiple phrase queries in same search [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/161474 (owner: 10Manybubbles) [22:50:36] (03PS1) 10Arlolra: Add support for metabook toc auto string [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/161622 [22:55:23] 3MediaWiki / 3MediaWiki UI: Normal buttons should have a minimum width to provide accessible targets - 10https://bugzilla.wikimedia.org/70972#c4 (10Jared Zimmerman (WMF)) Ryan, what screens were the issues present on? also this doesn't affect "square" buttons (e.g. button groups) [22:56:11] (03PS1) 10MaxSem: Return coordinates from a given point [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/161623 [22:57:18] (03Merged) 10jenkins-bot: Reduce new button min-width from 80px to 70px [core] - 10https://gerrit.wikimedia.org/r/161620 (owner: 10Kaldari) [22:57:47] (03Merged) 10jenkins-bot: Fixed --maxtime handling by JobRunner [core] - 10https://gerrit.wikimedia.org/r/161618 (https://bugzilla.wikimedia.org/71073) (owner: 10Aaron Schulz) [23:08:39] (03CR) 10Jforrester: "Yes, this should be cherry-picked to REL1_24." [core] - 10https://gerrit.wikimedia.org/r/157183 (owner: 10Bartosz Dziewoński) [23:11:54] (03PS5) 10Jforrester: Remove WMF deployment hack for 'Enlarge' image [core] - 10https://gerrit.wikimedia.org/r/154831 (https://bugzilla.wikimedia.org/69673) (owner: 10Bartosz Dziewoński) [23:12:05] (03CR) 10Nuria: [C: 032] Prevent warning when not fully configured [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/161466 (owner: 10Gergő Tisza) [23:12:10] (03CR) 10Jforrester: [C: 032] "PS5 is a rebase." [core] - 10https://gerrit.wikimedia.org/r/154831 (https://bugzilla.wikimedia.org/69673) (owner: 10Bartosz Dziewoński) [23:12:19] (03PS1) 10Jforrester: Remove WMF deployment hack for 'Enlarge' image [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/161625 (https://bugzilla.wikimedia.org/69673) [23:15:29] (03Merged) 10jenkins-bot: Prevent warning when not fully configured [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/161466 (owner: 10Gergő Tisza) [23:15:31] (03PS10) 10Jforrester: Completely remove skin autodiscovery [core] - 10https://gerrit.wikimedia.org/r/135439 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [23:15:49] (03CR) 10Jforrester: "PS10 is a rebase." [core] - 10https://gerrit.wikimedia.org/r/135439 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [23:18:22] 3MediaWiki / 3JavaScript: mw.trackSubscribe should prevent infinite recursion - 10https://bugzilla.wikimedia.org/67481 (10Bartosz Dziewoński) 5NEW>3UNCO [23:19:15] (03Merged) 10jenkins-bot: Remove WMF deployment hack for 'Enlarge' image [core] - 10https://gerrit.wikimedia.org/r/154831 (https://bugzilla.wikimedia.org/69673) (owner: 10Bartosz Dziewoński) [23:19:40] (03PS1) 10Legoktm: Fixed --maxtime handling by JobRunner [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/161626 (https://bugzilla.wikimedia.org/71073) [23:19:50] (03CR) 10Legoktm: [C: 032] Fixed --maxtime handling by JobRunner [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/161626 (https://bugzilla.wikimedia.org/71073) (owner: 10Legoktm) [23:20:02] (03CR) 10Legoktm: [C: 032] Remove WMF deployment hack for 'Enlarge' image [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/161625 (https://bugzilla.wikimedia.org/69673) (owner: 10Jforrester) [23:21:10] legoktm: Woo. :-) [23:21:28] :D [23:22:07] 3MediaWiki / 3Interface: Stop using inline for thumbnail magnify icon - 10https://bugzilla.wikimedia.org/69673 (10James Forrester) 5PATC>3RESO/FIX [23:22:15] hey legoktm: do you know the latest approximage ETA for bug 49193 ($wgContentHandlerUseDB = true) on production? [23:22:40] 3MediaWiki / 3JobQueue: JobQueue does not respect --maxtime - 10https://bugzilla.wikimedia.org/71073#c6 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX Marking as fixed, Niklas said it worked on twn. I backported it to REL1_24. [23:22:49] spagewmf: I don't, but https://bugzilla.wikimedia.org/show_bug.cgi?id=70901 is blocking it. [23:24:16] (03PS19) 10Jdlrobson: Add mw-ui-icon [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) [23:26:56] (03Merged) 10jenkins-bot: Fixed --maxtime handling by JobRunner [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/161626 (https://bugzilla.wikimedia.org/71073) (owner: 10Legoktm) [23:27:08] (03Merged) 10jenkins-bot: Remove WMF deployment hack for 'Enlarge' image [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/161625 (https://bugzilla.wikimedia.org/69673) (owner: 10Jforrester) [23:28:08] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: Warnings about allowed skins are not displayed - 10https://bugzilla.wikimedia.org/70814#c9 (10Seb35) Yes, I didn’t describe exactly the bug: the allowed skins were never displayed in the HTML, neither when the current skin is an allowed skin, neither when... [23:29:01] (03PS1) 10MaxSem: Fix indentation [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/161628 [23:29:27] (03CR) 10MaxSem: [C: 032] Fix indentation [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/161628 (owner: 10MaxSem) [23:29:34] (03Merged) 10jenkins-bot: Fix indentation [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/161628 (owner: 10MaxSem) [23:40:15] (03PS1) 10Seb35: Display allowed skins if and only if the current skin is not allowed [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/161629 (https://bugzilla.wikimedia.org/70814) [23:43:49] (03CR) 10Jforrester: [C: 031] Display allowed skins if and only if the current skin is not allowed [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/161629 (https://bugzilla.wikimedia.org/70814) (owner: 10Seb35) [23:47:38] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: wgBetaFeaturesFeatures is incomplete, causing wrong UI in preferences - 10https://bugzilla.wikimedia.org/69823#c3 (10Seb35) https://gerrit.wikimedia.org/r/161629 should have resolved this bug. Is it confirmed? [23:48:07] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: Warnings about allowed skins are not displayed - 10https://bugzilla.wikimedia.org/70814#c11 (10James Forrester) (In reply to Seb35 from comment #9) > Yes, I didn’t describe exactly the bug: the allowed skins were never > displayed in the HTML, neither when... [23:48:45] (03PS10) 10Jdlrobson: OOjs: Use OO for class inheritance [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/159553 [23:49:09] (03CR) 10Jdlrobson: [C: 032] OOjs: Use OO for class inheritance [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/159553 (owner: 10Jdlrobson) [23:49:38] (03Merged) 10jenkins-bot: OOjs: Use OO for class inheritance [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/159553 (owner: 10Jdlrobson) [23:50:07] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: wgBetaFeaturesFeatures is incomplete, causing wrong UI in preferences - 10https://bugzilla.wikimedia.org/69823#c4 (10Seb35) Ah, sorry. I meant https://gerrit.wikimedia.org/r/160213.