[00:00:29] 3MediaWiki / 3MediaWiki UI: Remove $wgUseMediaWikiUIEverywhere dependency for button and input styling (tracking) - 10https://bugzilla.wikimedia.org/70913 (10Jon) [00:00:31] 3MediaWiki / 3MediaWiki UI: VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages - 10https://bugzilla.wikimedia.org/56363 (10Jon) [00:00:41] (03PS7) 10Jdlrobson: Correct button colours of preference page when $wgUseMediaWikiUIEverywhere is enabled [core] - 10https://gerrit.wikimedia.org/r/157709 (https://bugzilla.wikimedia.org/65317) [00:00:49] 3MediaWiki / 3MediaWiki UI: Preferences: Update button classes and layout to use mediawiki.ui classes and conventions - 10https://bugzilla.wikimedia.org/65317 (10Jon) [00:00:49] 3MediaWiki / 3MediaWiki UI: neutral mw-ui-quiet anchors should lighten on hover and have no outline - 10https://bugzilla.wikimedia.org/69212 (10Jon) [00:00:49] 3MediaWiki / 3MediaWiki UI: Deletion page has mw-ui-constructive button, Other/additional reason input is tiny - 10https://bugzilla.wikimedia.org/70134 (10Jon) [00:02:05] (03PS3) 10Wctaiwan: Use Title::hasContentModel() instead of a direct comparison [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/160873 [00:02:31] (03CR) 10jenkins-bot: [V: 04-1] Use Title::hasContentModel() instead of a direct comparison [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/160873 (owner: 10Wctaiwan) [00:04:00] 3MediaWiki / 3Page editing: Require POST for all changes; Never change content on HEAD-request - 10https://bugzilla.wikimedia.org/44602#c7 (10Matthew Flaschen) (In reply to Jesús Martínez Novo (Ciencia Al Poder) from comment #1) > Also, the plugin is bad designed, since it should send HEAD requests, not > GE... [00:07:56] (03Abandoned) 10Wctaiwan: Use Title::hasContentModel() instead of a direct comparison [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/160873 (owner: 10Wctaiwan) [00:08:30] 3MediaWiki / 3Installer: Fill the iw_api column of the interwiki table - 10https://bugzilla.wikimedia.org/46992 (10Alex Monk) [00:10:47] (03CR) 10Springle: [C: 031] "Yeah, once-off small or empty tables, just go ahead and ALTER. I went ahead and did this one just now." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159357 (owner: 10BryanDavis) [00:10:49] (03PS1) 10Reedy: /a/common -> /srv/mediawiki [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/160878 [00:13:14] (03CR) 10Reedy: [C: 032] /a/common -> /srv/mediawiki [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/160878 (owner: 10Reedy) [00:13:21] (03Merged) 10jenkins-bot: /a/common -> /srv/mediawiki [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/160878 (owner: 10Reedy) [00:14:18] (03CR) 10Isarra: "Who wrote outputpage? Seems like that would be who you would want to ask about this." [core] - 10https://gerrit.wikimedia.org/r/160797 (owner: 10Anomie) [00:18:08] (03CR) 10Yaron Koren: "Ooh, that's a good point... I hadn't thought of that. There's a lot of current MediaWiki and MW extension code that deals with namespaces " [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [00:18:25] legoktm: can you add me to the translationadmin group on mediawikiwiki? [00:18:36] (03PS1) 10Aaron Schulz: Removed redundant begin/commit calls [core] - 10https://gerrit.wikimedia.org/r/160882 [00:18:37] Reedy: trivial ^ [00:20:01] 3MediaWiki extensions / 3CirrusSearch: Byte counts under-reported in search results - 10https://bugzilla.wikimedia.org/70919 (10Yusuke Matsubara) 3NEW p:3Unprio s:3normal a:3None It seems that CirrusSearch (as of the version deployed on English Wikipedia) has a problem with byte counts. I assume they... [00:20:19] (03CR) 10Reedy: [C: 032] Removed redundant begin/commit calls [core] - 10https://gerrit.wikimedia.org/r/160882 (owner: 10Aaron Schulz) [00:20:37] (03PS1) 10Aaron Schulz: Made the DB profiler use startAtomic() [core] - 10https://gerrit.wikimedia.org/r/160883 [00:20:39] Reedy: another one ^ [00:20:54] * AaronSchulz trying to cut down on begin/commit calls [00:21:43] (03CR) 10Reedy: [C: 032] Made the DB profiler use startAtomic() [core] - 10https://gerrit.wikimedia.org/r/160883 (owner: 10Aaron Schulz) [00:21:49] AaronSchulz: When we upgrade to MySQL 4.1+... [00:26:24] (03PS1) 10Aaron Schulz: Replaced more trx DIY with startAtomic() [core] - 10https://gerrit.wikimedia.org/r/160884 [00:26:25] Reedy: wee ^ [00:26:29] 3MediaWiki / 3MediaWiki UI: Input fields should be relative to input strings - 10https://bugzilla.wikimedia.org/70404#c9 (10Jon) Let's apply the mw-ui-inline class and see how that looks. http://tools.wmflabs.org/styleguide/desktop/section-1.html#section-1.1 [00:26:51] (03Merged) 10jenkins-bot: Removed redundant begin/commit calls [core] - 10https://gerrit.wikimedia.org/r/160882 (owner: 10Aaron Schulz) [00:28:20] (03Merged) 10jenkins-bot: Made the DB profiler use startAtomic() [core] - 10https://gerrit.wikimedia.org/r/160883 (owner: 10Aaron Schulz) [00:29:31] (03PS1) 10Aaron Schulz: Made QueryPage use startAtomic() for trx handling [core] - 10https://gerrit.wikimedia.org/r/160886 [00:29:57] (03CR) 10CSteipp: [C: 032] "Let's go ahead and merge this. We may want a followup that actually logs the user in globally when they are merged, so they can benefit fr" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/158578 (https://bugzilla.wikimedia.org/70392) (owner: 10Legoktm) [00:30:42] (03Merged) 10jenkins-bot: Auto-migrate matching accounts where no global account exists [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/158578 (https://bugzilla.wikimedia.org/70392) (owner: 10Legoktm) [00:38:32] 3MediaWiki / 3MediaWiki UI: Special:Contributions margin between form elements is incorrect with MediaWiki UI - 10https://bugzilla.wikimedia.org/70920 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16496 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16496&action=edi... [00:38:44] 3MediaWiki / 3MediaWiki UI: Special:Contributions margin between form elements is incorrect with MediaWiki UI - 10https://bugzilla.wikimedia.org/70920 (10Matthew Flaschen) [00:38:45] 3MediaWiki / 3MediaWiki UI: Set $wgUseMediaWikiUIEverywhere = true (tracking) - 10https://bugzilla.wikimedia.org/70424 (10Matthew Flaschen) [00:40:29] 3MediaWiki / 3MediaWiki UI: Special:Contributions margin between form elements is incorrect with MediaWiki UI - 10https://bugzilla.wikimedia.org/70920#c1 (10Jon) I believe https://gerrit.wikimedia.org/r/#/c/154125/ fixes this. It's been sitting around for a while so I'd appreciate the review! [00:40:30] (03PS10) 10Jdlrobson: Tweak checkbox sizes to be relative depending on where used. [core] - 10https://gerrit.wikimedia.org/r/154125 (https://bugzilla.wikimedia.org/70133) [00:41:22] (03CR) 10Aaron Schulz: Don't update the entire table in one query to avoid melting servers (031 comment) [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/158310 (https://bugzilla.wikimedia.org/70376) (owner: 10Reedy) [00:42:58] (03PS1) 10MaxSem: Add a newline after warnings_as_errors mmessages [vagrant] - 10https://gerrit.wikimedia.org/r/160889 [00:43:40] fuck [00:47:55] (03PS1) 10Shirayuki: i18n: remove unused messages and fix comment [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/160891 [00:50:39] (03PS1) 10Spage: QA: Update selenium-webdriver so Firefox 32 works [extensions/Echo] - 10https://gerrit.wikimedia.org/r/160892 [00:52:02] (03CR) 10CSteipp: [C: 032] "Thanks!" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159357 (owner: 10BryanDavis) [00:52:40] (03Merged) 10jenkins-bot: Make renameuser_queue.rq_wiki nullable [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159357 (owner: 10BryanDavis) [00:53:10] (03CR) 10Aaron Schulz: "InitialiseSettings sets variables to a big array before CommonSettings applies those based on the wiki to the actual $wg globals. So the f" [extensions/Math] - 10https://gerrit.wikimedia.org/r/158845 (owner: 10Physikerwelt) [00:55:04] (03PS1) 10MaxSem: Add a newline after warnings_as_errors messages [vagrant] - 10https://gerrit.wikimedia.org/r/160893 [00:55:29] (03Abandoned) 10MaxSem: Add a newline after warnings_as_errors mmessages [vagrant] - 10https://gerrit.wikimedia.org/r/160889 (owner: 10MaxSem) [00:55:43] (03CR) 10Jjanes: "I think that this will break PostgreSQL because UPDATE...LIMIT is not allowed in any existing version (maybe it will be in 9.5)." [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/158310 (https://bugzilla.wikimedia.org/70376) (owner: 10Reedy) [00:57:14] 3Wikimedia / 3Site requests: Logout users with MD5 password hash - 10https://bugzilla.wikimedia.org/70910#c1 (10Chris Steipp) It would be nice if we could wrap them in another hash instead of trying to force a login. I'd rather not have the hash in our DB at all. From what I remember, there's a reason the s... [00:57:39] (03PS2) 10MaxSem: Add a newline after warnings_as_errors messages [vagrant] - 10https://gerrit.wikimedia.org/r/160893 [00:59:20] (03CR) 10Jjanes: [C: 04-1] "Conflicts with just-merged Ia0a36b87a9e577c41b0c3796dcdecd1a5f7edf19" [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/158310 (https://bugzilla.wikimedia.org/70376) (owner: 10Reedy) [01:01:29] 3MediaWiki / 3Interface: Remove yellow padlock icons on HTTPS links - 10https://bugzilla.wikimedia.org/61178#c6 (10Filipus Klutiero) This appears to be OK on mediawiki.org. However, I am still seeing these icons on en.wikipedia.org. This discusses the problem: http://ux.stackexchange.com/questions/29004/why... [01:01:44] (03PS1) 10Shirayuki: i18n: replace "login" by "log in" [core] - 10https://gerrit.wikimedia.org/r/160894 [01:02:36] jackmcbarn: done [01:02:42] thanks [01:02:49] (for some reason there was a page i couldn't delete without it) [01:03:00] 3Wikimedia / 3Site requests: enable CategoryCollation on frwikiversity - 10https://bugzilla.wikimedia.org/69782 (10Sam Reed (reedy)) 5PATC>3RESO/FIX a:3Sam Reed (reedy) [01:04:16] 3MediaWiki / 3Interface: Remove yellow padlock icons on HTTPS links - 10https://bugzilla.wikimedia.org/61178#c7 (10Bartosz Dziewoński) English Wikipedia editors have decided to add their own little padlocks. See the very bottom of https://en.wikipedia.org/wiki/MediaWiki:Vector.css . You could probably raise... [01:04:29] 3Wikimedia / 3Site requests: Category collation for Estonian projects - 10https://bugzilla.wikimedia.org/54168#c16 (10Sam Reed (reedy)) 5PATC>3NEW This is done now... Any further improvements needed, or can we close the bug? [01:05:41] (03CR) 10Legoktm: "recheck" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/160688 (https://bugzilla.wikimedia.org/66986) (owner: 10Legoktm) [01:05:43] (03CR) 10Kaldari: [C: 032] Correct button colours of preference page when $wgUseMediaWikiUIEverywhere is enabled [core] - 10https://gerrit.wikimedia.org/r/157709 (https://bugzilla.wikimedia.org/65317) (owner: 10Jdlrobson) [01:09:21] (03CR) 10Legoktm: Don't update the entire table in one query to avoid melting servers (031 comment) [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/158310 (https://bugzilla.wikimedia.org/70376) (owner: 10Reedy) [01:12:39] (03Merged) 10jenkins-bot: Correct button colours of preference page when $wgUseMediaWikiUIEverywhere is enabled [core] - 10https://gerrit.wikimedia.org/r/157709 (https://bugzilla.wikimedia.org/65317) (owner: 10Jdlrobson) [01:12:44] 3MediaWiki / 3General/Unknown: GlobalVarConfig throws exceptions for globals with null value - 10https://bugzilla.wikimedia.org/66986#c10 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX Will also be included in the next 1.23.x release. [01:13:14] 3MediaWiki / 3Configuration: GlobalVarConfig throws exceptions for globals with null value - 10https://bugzilla.wikimedia.org/66986 (10Kunal Mehta (Legoktm)) [01:16:51] csteipp_afk: dumb question: who's S? [01:17:02] 3Wikimedia / 3Site requests: $wgCategoryCollation for sh.wikipedia.org - 10https://bugzilla.wikimedia.org/67287 (10Sam Reed (reedy)) 5PATC>3RESO/FIX [01:17:28] jackmcbarn: spagewmf [01:17:45] his first name is literally just S [01:29:22] [travis-ci] cssjanus/node-cssjanus#43 (master - ed298b9 : Timo Tijhof): The build passed. [01:29:22] [travis-ci] Change view : https://github.com/cssjanus/node-cssjanus/compare/d8eb7baada86...ed298b9d890c [01:29:22] [travis-ci] Build details : http://travis-ci.org/cssjanus/node-cssjanus/builds/35494543 [01:32:53] TimStarling: around? [01:33:10] yes [01:33:28] [13node-cssjanus] 15Krinkle pushed 1 new commit to 06master: 02https://github.com/cssjanus/node-cssjanus/commit/66d0361d2ba994577247dc4dd7fd5f3feae8e76b [01:33:28] 13node-cssjanus/06master 1466d0361 15Timo Tijhof: Do not flip unknown properties starting with "left" or "right"... [01:33:37] TimStarling: i'm thinking of trying to implement dynamic file generation via scribunto (finally). do you have any thoughts on the best way to support dynamic files? [01:33:42] [13node-cssjanus] 15Krinkle pushed 1 new commit to 06master: 02https://github.com/cssjanus/node-cssjanus/commit/2f7f368047a9a3a8fadc77b166f4ea21284f94db [01:33:42] 13node-cssjanus/06master 142f7f368 15Timo Tijhof: Do not flip five or more consecutive values... [01:34:04] my two thoughts right now are 1) a pseudo-namespace and 2) something like that turns anything in it into a file [01:34:34] [travis-ci] cssjanus/node-cssjanus#44 (master - 66d0361 : Timo Tijhof): The build passed. [01:34:35] [travis-ci] Change view : https://github.com/cssjanus/node-cssjanus/compare/ed298b9d890c...66d0361d2ba9 [01:34:35] [travis-ci] Build details : http://travis-ci.org/cssjanus/node-cssjanus/builds/35494751 [01:34:47] (03PS8) 10Dan-nl: Special:Import not importing Special:Export XMLs [core] - 10https://gerrit.wikimedia.org/r/159973 [01:35:01] sounds quite challenging [01:35:28] the pseudo-namespace would work like the file namespace? [01:35:54] yes [01:36:51] the problem with the pseudo-namespace is how to separate the name of the generating module from the parameters you want to pass it [01:37:09] (03CR) 10Dan-nl: "* addressed Jackmcbarn’s comments in ps7" [core] - 10https://gerrit.wikimedia.org/r/159973 (owner: 10Dan-nl) [01:37:40] are you thinking of SVG generation, or raster images as well? [01:38:13] in practice, primarily SVG, but i see no reason to limit it. in theory, they should be able to generate audio and even video [01:38:36] I think that would depend on what theory you used [01:39:13] lack of integer arithmetic might be a bit of a barrier to efficient implementation of video encoding in lua ;) [01:40:16] anyway, if it is unlimited, you would presumably want transformations of generated files, like scaling [01:41:05] https://gerrit.wikimedia.org/r/#/c/113759/ was a previous attempt at it [01:41:09] so you would want some way to pass arbitrary handler parameters, like in Parser::makeImage [01:41:16] yes. that's the key [01:41:24] the big problem with the previous attempt was that you couldn't do tath [01:41:27] that* [01:42:22] a good point raised was things like Extension:ImageMap. whatever we do should be fully compatible with them [01:43:27] (03CR) 10Aude: [C: 032] i18n: replace "login" by "log in" [core] - 10https://gerrit.wikimedia.org/r/160894 (owner: 10Shirayuki) [01:43:52] there were some patches a while ago to allow images to be in multiple namespaces [01:43:54] (03PS4) 10Jjanes: PHPUnit: Add Database tags [core] - 10https://gerrit.wikimedia.org/r/154338 [01:44:23] nobody really cared about them and I think they rotted in bugzilla [01:44:41] (03CR) 10Aude: [C: 032] Replaced more trx DIY with startAtomic() [core] - 10https://gerrit.wikimedia.org/r/160884 (owner: 10Aaron Schulz) [01:44:54] i could probably revive those if i found them [01:45:09] but I guess my question is: why a separate namespace rather than a separate repo? [01:45:45] the issue anomie said was, what if someone already has a file called File:Module:foo.png? [01:46:38] move it [01:46:50] and double-namespaces seem really really hacky to me [01:47:10] you know enwp uses Module:User:whoever/sandbox to organize module sandboxes? [01:47:15] that is probably a better argument [01:48:16] I guess I am imagining a file object which represents a lua module [01:48:47] and the parameters to the lua module would be transform parameters [01:48:47] i don't see how that could work, since you'd want the same module to be able to generate several files depending on its input [01:48:52] i.e. module execution would be transformation [01:49:02] hmm [01:49:08] aren't all transformations today basic things like scaling? [01:49:19] page selection [01:49:42] good point [01:49:45] maybe it's not an enormous conceptual jump from page selection to parameter selection [01:50:22] (03Merged) 10jenkins-bot: i18n: replace "login" by "log in" [core] - 10https://gerrit.wikimedia.org/r/160894 (owner: 10Shirayuki) [01:50:42] [travis-ci] cssjanus/node-cssjanus#46 (master - a6168e3 : Timo Tijhof): The build passed. [01:50:42] [travis-ci] Change view : https://github.com/cssjanus/node-cssjanus/compare/2f7f368047a9...a6168e385dc8 [01:50:42] [travis-ci] Build details : http://travis-ci.org/cssjanus/node-cssjanus/builds/35495664 [01:50:54] so say we have ModuleFile:Foo. you'd want to do [[ModuleFile:Foo|200px|foo=bar|baz=qux]]? [01:51:00] and how would we handle caching of these? [01:51:22] (03Merged) 10jenkins-bot: Replaced more trx DIY with startAtomic() [core] - 10https://gerrit.wikimedia.org/r/160884 (owner: 10Aaron Schulz) [01:51:25] same way we handle caching of thumbnails [01:51:46] do thumbnail caches get deleted automatically after a while? [01:51:52] no [01:52:03] that could be bad [01:52:10] [13node-cssjanus] 15none pushed 3 new commits to 06master: 02https://github.com/cssjanus/node-cssjanus/compare/66d0361d2ba9...a6168e385dc8 [01:52:10] 13node-cssjanus/06master 142f7f368 15Timo Tijhof: Do not flip five or more consecutive values... [01:52:10] 13node-cssjanus/06master 149d99898 15Timo Tijhof: Support CSS3 rgb(a) and hsl(a) color notation... [01:52:10] 13node-cssjanus/06master 14a6168e3 15Timo Tijhof: Flip text-shadow and box-shadow... [01:52:22] there's a potentially infinite number of "thumbnails" a module file could generate [01:53:09] well, there are a lot of thumbnails that each PDF could potentially generate [01:53:33] there's an RFC proposing improving the situation, and whatever improvements we get for PDF would also apply to modules, in this scheme [01:53:42] do you know the link to that? [01:54:31] https://www.mediawiki.org/wiki/Requests_for_comment/Simplify_thumbnail_cache [01:55:06] jackmcbarn: We can't duplicate the File syntax. [01:55:09] It's a nightmare. [01:55:33] really can't? [01:55:48] I guess we could make a better version of it, but I'm not sure why {{#dynamicfile:}} wouldn't work. [01:56:11] File inclusion syntax is weird. [01:56:21] Carmela: because it needs to be compatible with things like Extension:ImageMap [01:56:30] I don't follow. [01:56:48] Extension:ImageMap just takes the (full) filename and attributes as a parameter [01:57:03] and probably other things too [01:57:16] Perhaps we should re-think ImageMap's syntax as well. [01:57:22] Though I think it has a parser function as well, maybe. [01:57:40] here is the file namespace thing: https://bugzilla.wikimedia.org/show_bug.cgi?id=9887 [01:57:58] but I am not promoting that idea for this, I am just mentioning it [01:59:10] (03PS1) 10AndyRussG: Fix RemoveStudentAction after API token overhaul [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160901 [01:59:14] jackmcbarn: FWIW, I've always considered it a pretty easy attack vector to generate large thumbnails (CPU usage, disk space usage, etc.), but either someone has rate-limited it or people don't do it to excess. [01:59:43] I don't hear many complaints about it, anyway. [02:01:08] (03PS2) 10AndyRussG: Fix RemoveStudentAction after API token overhaul [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160901 (https://bugzilla.wikimedia.org/70748) [02:02:00] (03CR) 10Jackmcbarn: [C: 031] "Tested, working." [core] - 10https://gerrit.wikimedia.org/r/159973 (owner: 10Dan-nl) [02:04:41] TimStarling: so basically either [[File:Module:Foo|bar=baz]] or {{#invokefile:Foo|main|bar=baz}} ? [02:06:53] one possibility is to have the description page be involved in deciding whether a file is real or generated [02:06:57] like a redirect [02:07:30] (03CR) 10Jackmcbarn: Special:Import not importing Special:Export XMLs (031 comment) [core] - 10https://gerrit.wikimedia.org/r/159973 (owner: 10Dan-nl) [02:08:02] TimStarling: the problem with that is, as of now, doesn't editing the description page not trigger purges of all pages that use the file? [02:08:15] actually... [02:08:28] maybe give Scribunto a shot at redlinked files [02:08:38] making a description page be a redirect presumably does trigger purges [02:09:07] yes, a redirect might [02:09:38] Re-uploading a file triggers purges. [02:09:38] what if any redlinked file got processed by [[Module:FileHandler/whatever filename you tried]] if it existed? [02:09:50] Just editing the file description page doesn't (why would it?). [02:09:50] well, there would be no source file [02:10:05] but editing the source page would be the equivalent of reuploading, I guess [02:10:23] or have a prefix listed in the MediaWiki namespace and give all files that start with it to Scribunto [02:13:02] a math/score-style feature would be about 10 times simpler, you know [02:13:48] even though math/score is badly in need of factoring out of common code [02:14:08] [13node-cssjanus] 15Krinkle pushed 1 new commit to 06master: 02https://github.com/cssjanus/node-cssjanus/commit/e5d7c95e1b7d657d823bb95b5bed84699dc17c1c [02:14:08] 13node-cssjanus/06master 14e5d7c95 15Timo Tijhof: Account for attribute selectors in open brace lookahead... [02:14:17] if we limit people to math/score, they'll use what we gave them in a really complicated and inefficient way to draw generic stuff anyway [02:14:21] look what we do with divs [02:14:43] You don't have to limit people to math/score. [02:15:09] You could refactor the code to be more modular/flexible. [02:15:13] [travis-ci] cssjanus/node-cssjanus#47 (master - e5d7c95 : Timo Tijhof): The build passed. [02:15:13] [travis-ci] Change view : https://github.com/cssjanus/node-cssjanus/compare/a6168e385dc8...e5d7c95e1b7d [02:15:13] [travis-ci] Build details : http://travis-ci.org/cssjanus/node-cssjanus/builds/35496650 [02:15:28] Krinkle: That's a bit annoying. [02:16:07] Carmela: easy for you to say [02:16:49] I'm not really sure what the underlying problem is, exactly. SVG generation via Lua seems, uh, complicated. [02:16:59] how so? [02:17:08] Brion did some work with an SVG editor at some point. [02:17:09] Carmela: have you seen the syria map in lua yet? [02:17:13] I'd rather see that. [02:17:16] I saw the map. [02:17:34] An SVG editor (like a visual one) would allow people to make things. [02:17:35] an svg would certainly be less complicated than that [02:17:49] Carmela: you prefer {{#dynamicfile:}}, right? [02:17:51] Needing to know Lua, Scribunto modules, and SVG syntax seems like... [02:18:05] a lot. [02:18:06] to bikeshed a bit, if we did that, i'd prefer {{#invokefile:}} [02:18:14] with transformations specified in some way that is not like file links? [02:18:27] TimStarling: I was mostly arguing against duplicating file inclusion syntax. [02:18:33] Which is crazy difficult to parse, AIUI. [02:18:43] {{#invokefile:Whatever the module name is|Function name|Whatever parameters|width=20px}} [02:19:07] but now it's not a real file again [02:19:13] so we have to figure out how to use it like it's a real file [02:19:20] even for caching [02:19:35] you'd rather have two different ways to specify transformations than have a single consistently awkward one? [02:19:39] {{#invokefile:}} would pair with {{#invoke:}}? [02:19:54] yeah [02:21:02] I'd like to learn lessons of the past. [02:22:04] (03PS9) 10Dan-nl: Special:Import not importing Special:Export XMLs [core] - 10https://gerrit.wikimedia.org/r/159973 [02:23:29] well, we're probably just about ready for a wikitech-l discussion [02:24:00] (03CR) 10Dan-nl: "* addressed Jackmcbarn’s comment in ps8. removed the comment from the Template-!!.xml file." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/159973 (owner: 10Dan-nl) [02:24:11] it'd be good to have a list of implementation options for discussion [02:24:49] ok, i'll try to write something up [02:27:56] TimStarling: another more exotic option: you can't use the files from wikitext. you can only use them from lua, where you'd call a function with the file content as a parameter, and it would give you a strip marker that would turn in to the html to view the file [02:28:00] 3MediaWiki / 3MediaWiki UI: Preferences: Update button classes and layout to use mediawiki.ui classes and conventions - 10https://bugzilla.wikimedia.org/65317 (10Jon) 5PATC>3RESO/FIX [02:28:11] TimStarling: If we could do it over, I'd have strongly preferred {{#category:}} and {{#file:}} over re-using link syntax. [02:28:22] +1 to that [02:28:42] [[:File:Foo.png]] really does pain me. [02:28:49] jackmcbarn: sounds very exotic [02:28:55] I'm still not convinced we can't deprecate that syntax. [02:37:05] (03CR) 10AndyRussG: [C: 032] ";)" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/159898 (owner: 10Ragesoss) [02:37:15] (03Merged) 10jenkins-bot: Fix permissions for course coordinators [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/159898 (owner: 10Ragesoss) [02:41:03] email sent [02:41:25] https://lists.wikimedia.org/pipermail/wikitech-l/2014-September/078653.html [02:42:33] thanks [02:42:55] btw Carmela is normally known as MZMcBride on the lists and wikis [02:44:36] Such outing. [02:46:10] Ah, I see the mention now, heh. [02:46:28] yeah, on wikitech-l he said he talked with Carmela [02:46:40] True enough. :-) [02:46:43] some list participants are probably not quite up to date on your latest IRC pseudonym [02:46:51] Their loss, I suppose! [02:47:18] yep [02:49:22] I'm not sure how you'd have SVG output via Lua. [02:49:33] I thought everything was unconditionally run through the parser and sanitizer? [02:50:13] Carmela: that happens after it gets out of lua. with #invoke, it gets dropped into the page where it came from, then that carries through it [02:50:27] with this new way, it would go through the file procedures instead, just like an upload [02:51:42] I just had several thoughts about SVG generation and invalid markup and renderer leniency. And then I remembered HTML. [02:52:39] I guess it'll be fine. [02:52:49] the syria map is actually a really good example of why we need this. [[Template:Syrian and Iraqi insurgency detailed map]] takes about 0.3 seconds for lua to build the wikitext, then 14 seconds for the parser to turn the wikitext into html [02:53:04] by skipping everything except the file sanitizer, we could save a lot of time [02:53:12] (and not kill clients with 6000 divs) [02:53:23] Right, but I think editors generally want a way to see a map and place a dot on it. [02:53:38] Carmela: they put the longitude and latitude, and lua figures out where it goes [02:53:45] I'm not sure Lua and SVG is getting us there, exactly. Though it could provide a sensible backend, I suppose. [02:54:34] Is that what you want to build? Or you want something more generic? [02:55:06] that's just one use. there's also currently a lua module that abuses the way css borders get angled at the corners. it makes pie charts [02:55:21] Right. [02:56:22] Would you go through the SVG --> PNG rasterization layer as well? [02:56:35] yes [02:57:04] for the specific case of the map with 2000 points, that's still a net time saver, because that can happen a lot faster than someone's mobile phone from 2011 can render 6000 divs [02:57:48] Right. [02:58:17] (i can't believe i just said "mobile phone") [03:03:08] (03CR) 10Dan-nl: "Jackmcbarn, thanks for your help" [core] - 10https://gerrit.wikimedia.org/r/159973 (owner: 10Dan-nl) [03:17:31] (03PS4) 10Jackmcbarn: Display the full error message in wikitext [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/143061 [03:23:24] (03CR) 10Jackmcbarn: [C: 04-1] (bug 45470) Adds support of JSON encoding and decoding (032 comments) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/85426 (owner: 10Tpt) [03:26:33] 3MediaWiki / 3Interface: Remove yellow padlock icons on HTTPS links - 10https://bugzilla.wikimedia.org/61178#c8 (10Filipus Klutiero) Thank you Bartosz. I have done just that: https://en.wikipedia.org/wiki/MediaWiki_talk:Vector.css#Padlock_for_secure_links After looking at Vector.css, I think it is misleadin... [03:36:45] SVGs via Lua sounds fun. [03:37:38] jackmcbarn: I don't think you should constrain yourself by saying we need to support things like E:ImageMap...we should just fix ImageMap to support Scribunto-files [03:38:45] I vote for #5 and then 4. [03:41:29] 3MediaWiki-Vagrant: apt-get update does not always run on initial provision of new vm - 10https://bugzilla.wikimedia.org/70646#c1 (10Bryan Davis) 5NEW>3RESO/WOR Updating the base image available on my laptop seems to fix this issue: $ vagrant box add -f --name trusty-cloud https://cloud-images.ubuntu.com/... [03:47:54] (03PS1) 10Legoktm: Add tests for GlobalRenameUserValidator [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/160907 [03:48:31] (03CR) 10jenkins-bot: [V: 04-1] Add tests for GlobalRenameUserValidator [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/160907 (owner: 10Legoktm) [03:50:00] (03PS1) 10BryanDavis: Disable puppet service [vagrant] - 10https://gerrit.wikimedia.org/r/160908 (https://bugzilla.wikimedia.org/70421) [03:54:29] 3MediaWiki extensions / 3CharInsert: CharInsert should not show up to JavaScriptless users - 10https://bugzilla.wikimedia.org/70923#c1 (10Gryllida) oops, i had wrong component [03:55:40] (03PS1) 10BryanDavis: Add force flag when cleaning up generated files [vagrant] - 10https://gerrit.wikimedia.org/r/160910 [04:06:44] 3MediaWiki extensions / 3EducationProgram: course coordinator userrights should include all the rights of online and campus volunteers - 10https://bugzilla.wikimedia.org/56101 (10Sage Ross) 5PATC>3RESO/FIX [04:06:47] (03PS2) 10SG: Revert "Revert "Introduce flowSpawnedBy handler to forward events from outside of FlowComponent"" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160675 (owner: 10Matthias Mullie) [04:06:50] (03PS3) 10SG: Revert "Revert "Introduce flowSpawnedBy handler to forward events from outside of FlowComponent"" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160675 (owner: 10Matthias Mullie) [04:09:57] (03PS4) 10SG: Revert "Revert "Introduce flowSpawnedBy handler to forward events from outside of FlowComponent"" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160675 (owner: 10Matthias Mullie) [04:10:22] (03PS5) 10SG: Revert "Revert "Introduce flowSpawnedBy handler to forward events from outside of FlowComponent"" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160675 (owner: 10Matthias Mullie) [04:11:58] (03PS5) 10SG: Implement mw-ui-modal and remove jquery.ui usage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160612 [04:15:17] 3MediaWiki / 3Watchlist: Watchlist does not have unwatch button next to items - 10https://bugzilla.wikimedia.org/70924 (10Gryllida) 3NEW p:3Unprio s:3normal a:3None Each watchlist item should have an unwatch button next to it. I know this can be done through Special:EditWatchlist, but I'd like to als... [04:16:14] 3MediaWiki / 3Watchlist: Watchlist does not have unwatch button next to items - 10https://bugzilla.wikimedia.org/70924#c1 (10Kunal Mehta (Legoktm)) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 424 *** [04:16:29] 3MediaWiki / 3Watchlist: Add a direct unwatch link to entries on Special:Watchlist - 10https://bugzilla.wikimedia.org/424#c44 (10Kunal Mehta (Legoktm)) *** Bug 70924 has been marked as a duplicate of this bug. *** [04:16:32] (03PS3) 10BryanDavis: Add a newline after warnings_as_errors messages [vagrant] - 10https://gerrit.wikimedia.org/r/160893 (owner: 10MaxSem) [04:16:40] (03CR) 10BryanDavis: [C: 032] Add a newline after warnings_as_errors messages [vagrant] - 10https://gerrit.wikimedia.org/r/160893 (owner: 10MaxSem) [04:16:45] (03Merged) 10jenkins-bot: Add a newline after warnings_as_errors messages [vagrant] - 10https://gerrit.wikimedia.org/r/160893 (owner: 10MaxSem) [04:26:19] (03CR) 10BryanDavis: Make Mathoid role configurable via hiera (032 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/160694 (owner: 10Physikerwelt) [04:31:46] (03PS22) 10SG: mw-ui-button: Revamp the LESS to be simpler, and improve cross-browser support [core] - 10https://gerrit.wikimedia.org/r/123804 [04:32:31] (03CR) 10BryanDavis: Make Mathoid role configurable via hiera (034 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/160694 (owner: 10Physikerwelt) [04:32:41] (03PS2) 10Arlolra: Include settings in collection id [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/160235 (https://bugzilla.wikimedia.org/68836) [04:36:24] (03PS2) 10Legoktm: Add tests for GlobalRenameUserValidator [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/160907 [04:39:07] (03PS23) 10SG: mw-ui-button: Revamp the LESS to be simpler, and improve cross-browser support [core] - 10https://gerrit.wikimedia.org/r/123804 [04:40:05] (03PS1) 10Arlolra: Conform settings to metabook.json spec [extensions/Collection] - 10https://gerrit.wikimedia.org/r/160911 (https://bugzilla.wikimedia.org/68836) [04:41:11] (03PS2) 10Legoktm: Set a ratelimit of one global merge per minute per user [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/158311 [04:42:31] (03CR) 10Legoktm: [C: 032] "Fixed a merge conflict in the i18n files." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/158311 (owner: 10Legoktm) [04:43:03] (03Merged) 10jenkins-bot: Set a ratelimit of one global merge per minute per user [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/158311 (owner: 10Legoktm) [04:44:19] (03PS4) 10SG: mw-ui-button revamp: Add .mw-ui-regressive color state [core] - 10https://gerrit.wikimedia.org/r/145298 [04:44:23] (03PS5) 10SG: mw-ui-button revamp: Adds .mw-ui-sleeper visual type [core] - 10https://gerrit.wikimedia.org/r/145302 [04:44:27] (03PS4) 10SG: mw-ui-button revamp: Add .mw-ui-buttonspacer class to mimic button spacing [core] - 10https://gerrit.wikimedia.org/r/145308 [04:46:03] (03CR) 10SG: [C: 032] "Based on the discussion here, I don't see any reason to wait for this to be merged any longer. All concerns seem to be addressed, and have" [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG) [04:47:12] (03PS2) 10Arlolra: Accept papersize setting from metabook [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/160237 (https://bugzilla.wikimedia.org/68836) [04:47:46] 3MediaWiki extensions / 3CentralAuth: Allow to automatically unify on login absent clashes - 10https://bugzilla.wikimedia.org/70392 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX [04:51:10] (03CR) 10jenkins-bot: [V: 04-1] mw-ui-button revamp: Add .mw-ui-regressive color state [core] - 10https://gerrit.wikimedia.org/r/145298 (owner: 10SG) [04:51:56] (03PS3) 10Arlolra: Accept papersize setting from metabook [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/160237 (https://bugzilla.wikimedia.org/68836) [04:52:15] (03Merged) 10jenkins-bot: mw-ui-button: Revamp the LESS to be simpler, and improve cross-browser support [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG) [05:05:50] (03PS1) 10SG: Override vector anchor hover and visited styles on mw-ui-button [core] - 10https://gerrit.wikimedia.org/r/160912 [05:11:43] (03PS1) 10SG: Remove mw-ui-button min sizing for inline mode [core] - 10https://gerrit.wikimedia.org/r/160913 [05:12:44] (03PS2) 10SG: Override vector anchor hover and visited styles on mw-ui-button [core] - 10https://gerrit.wikimedia.org/r/160912 [05:14:09] (03PS2) 10SG: Clean up watchlist icon markup and CSS [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155214 [05:14:47] (03PS1) 10tosfos: change global name, fix whitespace, rename alias file, modernize [extensions/SimpleChanges] - 10https://gerrit.wikimedia.org/r/160914 [05:44:02] 3MediaWiki / 3General/Unknown: Gallery element renders image height and width inconsistently - 10https://bugzilla.wikimedia.org/70925 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None see https://www.mediawiki.org/wiki/Design#Team reload the page at different browser widths to see images siz... [05:45:17] 3MediaWiki / 3General/Unknown: Gallery element renders image height and width inconsistently - 10https://bugzilla.wikimedia.org/70926 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None see https://www.mediawiki.org/wiki/Design#Team reload the page at different browser widths to see images siz... [05:50:29] 3MediaWiki / 3General/Unknown: Gallery element renders image height and width inconsistently - 10https://bugzilla.wikimedia.org/70926 (10Jared Zimmerman (WMF)) p:5Unprio>3Normal [06:02:26] (03PS2) 10Tim Starling: Update wfMessage doc [core] - 10https://gerrit.wikimedia.org/r/160782 (owner: 10Anomie) [06:02:32] (03CR) 10Tim Starling: [C: 032] Update wfMessage doc [core] - 10https://gerrit.wikimedia.org/r/160782 (owner: 10Anomie) [06:05:30] (03PS1) 10EBernhardson: Hygiene: Submit an array of parameters intead of a WebRequest [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160915 [06:09:05] (03Merged) 10jenkins-bot: Update wfMessage doc [core] - 10https://gerrit.wikimedia.org/r/160782 (owner: 10Anomie) [06:13:08] (03CR) 10Tim Starling: "It would be nice to get this merged, but it looks like Anomie needs to respond to Daniel's inline comment." [core] - 10https://gerrit.wikimedia.org/r/131210 (https://bugzilla.wikimedia.org/62856) (owner: 10Anomie) [06:21:32] (03PS1) 10Legoktm: Add UserMerge support [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160916 (https://bugzilla.wikimedia.org/67767) [06:22:07] (03CR) 10Legoktm: "I didn't test this." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160916 (https://bugzilla.wikimedia.org/67767) (owner: 10Legoktm) [06:23:29] (03PS1) 10EBernhardson: Hygiene: Move SpecialFlow.php into includes/ [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160917 [06:27:18] (03CR) 10Nemo bis: [C: 031] i18n: remove unused messages and fix comment [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/160891 (owner: 10Shirayuki) [06:36:25] (03CR) 10Legoktm: "recheck" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159266 (owner: 10Legoktm) [06:38:56] (03PS1) 10IAlex: Coding standard fixes in SpecialChangeEmail.php [core] - 10https://gerrit.wikimedia.org/r/160919 [06:43:20] (03CR) 10Nemo bis: "I thought there was already a bug report for" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159266 (owner: 10Legoktm) [06:46:53] (03CR) 10Nikerabbit: Coding standard fixes in SpecialChangeEmail.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/160919 (owner: 10IAlex) [06:47:14] (03PS3) 10Legoktm: Add tests for CentralAuthUser::getHomeWiki() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/160611 [06:49:07] (03CR) 10Legoktm: Add tests for CentralAuthUser::getHomeWiki() (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/160611 (owner: 10Legoktm) [06:49:49] 3MediaWiki extensions / 3OAuth: With SQLite only first consumer can be created - 10https://bugzilla.wikimedia.org/70927 (10Mitar) 3UNCO p:3Unprio s:3normal a:3None For next consumer MediaWiki reports a query error. (Not sure how to get details of it.) [06:52:42] Nemo_bis: hmm, I think I can reproduce it locally-ish. [06:54:34] (03PS4) 10Legoktm: Add script to make a list of users who will be renamed [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159266 [06:54:50] 3MediaWiki extensions / 3UniversalLanguageSelector: Webfonts not getting loaded for edit field - 10https://bugzilla.wikimedia.org/70929 (10Subhashish Panigrahi) 3NEW p:3Unprio s:3normal a:3None Created attachment 16499 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16499&action=edit Screensho... [06:55:15] 3MediaWiki extensions / 3UniversalLanguageSelector: Webfonts not getting loaded for edit field - 10https://bugzilla.wikimedia.org/70929 (10Subhashish Panigrahi) p:5Unprio>3Normal [06:55:55] yaaaay [06:56:36] Nemo_bis: my schema update patch file was broken, so it failed somewhere later down the line causing a weird error. [07:00:05] legoktm: such a relief when tests actually capture a true error :P [07:04:11] (03PS1) 10EBernhardson: [WIP] End occupation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160923 [07:04:46] (03CR) 10jenkins-bot: [V: 04-1] [WIP] End occupation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160923 (owner: 10EBernhardson) [07:04:59] 3MediaWiki extensions / 3PubSubHubbub: Performance review of PubSubHubbub extension - 10https://bugzilla.wikimedia.org/67117#c8 (10Dimitris Kontokostas) Without looking at the code we had a few comments on this extension that also relate to performance [1] [2]. The basic idea is whether the client (wiki mir... [07:08:39] (03PS2) 10EBernhardson: [WIP] End occupation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160923 [07:09:25] (03PS3) 10EBernhardson: [WIP] End occupation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160923 [07:10:00] (03CR) 10jenkins-bot: [V: 04-1] [WIP] End occupation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160923 (owner: 10EBernhardson) [07:13:49] (03PS4) 10EBernhardson: [WIP] End occupation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160923 [07:18:14] 3MediaWiki / 3Interface: toaster overlay for watchlisting is inconsistent between mobile and desktop - 10https://bugzilla.wikimedia.org/65983#c7 (10Jared Zimmerman (WMF)) Created attachment 16500 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16500&action=edit toaster on mobile [07:18:47] 3MediaWiki / 3Interface: toaster overlay for watchlisting is inconsistent between mobile and desktop - 10https://bugzilla.wikimedia.org/65983#c8 (10Jared Zimmerman (WMF)) Created attachment 16501 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16501&action=edit toaster on desktop [07:19:54] (03CR) 10Matthias Mullie: [C: 032] Use updated RecentChanges class alias [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160850 (owner: 10EBernhardson) [07:20:27] (03Merged) 10jenkins-bot: Use updated RecentChanges class alias [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160850 (owner: 10EBernhardson) [07:21:14] 3MediaWiki / 3User preferences: Preferences saved notification should use overlay style toaster notification rather than altering the page - 10https://bugzilla.wikimedia.org/65984#c3 (10Jared Zimmerman (WMF)) Created attachment 16502 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16502&action=edit to... [07:22:29] 3MediaWiki / 3User preferences: Preferences saved notification should use overlay style toaster notification rather than altering the page - 10https://bugzilla.wikimedia.org/65984#c4 (10Jared Zimmerman (WMF)) Created attachment 16503 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16503&action=edit in... [07:25:35] (03CR) 10Zfilipin: [C: 032] QA: Update selenium-webdriver so Firefox 32 works [extensions/Echo] - 10https://gerrit.wikimedia.org/r/160892 (owner: 10Spage) [07:26:05] (03Merged) 10jenkins-bot: QA: Update selenium-webdriver so Firefox 32 works [extensions/Echo] - 10https://gerrit.wikimedia.org/r/160892 (owner: 10Spage) [07:27:18] (03CR) 10Beta16: [C: 031] i18n: remove unused messages and fix comment [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/160891 (owner: 10Shirayuki) [07:31:47] (03CR) 10Matthias Mullie: [C: 04-1] Hygiene: Submit an array of parameters intead of a WebRequest (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160915 (owner: 10EBernhardson) [07:32:05] (03PS2) 10Matthias Mullie: Hygiene: Submit an array of parameters intead of a WebRequest [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160915 (owner: 10EBernhardson) [07:32:21] (03CR) 10Matthias Mullie: [C: 032] Hygiene: Submit an array of parameters intead of a WebRequest [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160915 (owner: 10EBernhardson) [07:32:55] (03Merged) 10jenkins-bot: Hygiene: Submit an array of parameters intead of a WebRequest [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160915 (owner: 10EBernhardson) [07:33:29] (03CR) 10Matthias Mullie: [C: 04-1] Hygiene: Move SpecialFlow.php into includes/ (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160917 (owner: 10EBernhardson) [07:37:44] (03CR) 10Nemo bis: "utf_status should also be able to tell if a user is later found not to need rename. So this table could be populated before bug 39817 is f" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159266 (owner: 10Legoktm) [07:41:00] (03CR) 10Hashar: [C: 031] "Thx :)" [core] - 10https://gerrit.wikimedia.org/r/159159 (https://bugzilla.wikimedia.org/70570) (owner: 10Dan-nl) [07:45:54] (03CR) 10Hashar: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/160648 (owner: 10Matthias Mullie) [07:48:22] (03CR) 10Hashar: "recheck" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/134078 (owner: 10Dan-nl) [07:48:52] (03CR) 10Hashar: "recheck" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/134167 (https://bugzilla.wikimedia.org/58507) (owner: 10Dan-nl) [07:48:54] (03CR) 10jenkins-bot: [V: 04-1] Add pretty JSON output to the GWToolset namespace [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/134167 (https://bugzilla.wikimedia.org/58507) (owner: 10Dan-nl) [08:07:54] (03CR) 10Robert Vogel: [C: 032 V: 032] Fixed unparsed greeting messages in mails [extensions/BlueSpiceFoundation] (REL1_22) - 10https://gerrit.wikimedia.org/r/160637 (owner: 10Pwirth) [08:10:01] 3MediaWiki / 3Email: MediaWiki emails from yahoo accounts end up in spam - 10https://bugzilla.wikimedia.org/70930 (10Strainu) 3NEW p:3Unprio s:3normal a:3None Some users report that mails sent through MW from yahoo accounts end up in the spam folder on gmail: https://ro.wikipedia.org/wiki/Wikipedia:C... [08:30:51] (03CR) 10Robert Vogel: [C: 04-1] [WIP] PermissionManager Recode (036 comments) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/159678 (owner: 10Lilu) [08:35:17] 3MediaWiki / 3General/Unknown: Thumbnails not shown in Special:ListFiles when using Postgres - 10https://bugzilla.wikimedia.org/70931 (10gebhkla) 3UNCO p:3Unprio s:3normal a:3None In Special:ListFiles the column Thumbnail is not showing the thumbnail, instead the name is shown. This is because the ti... [08:38:00] 3MediaWiki / 3General/Unknown: Thumbnails not shown in Special:ListFiles when using Postgres - 10https://bugzilla.wikimedia.org/70931#c1 (10gebhkla) We have noticed the same problem with 1.23.0 and the fixed the same way. [08:48:13] (03PS1) 10Mglaser: Fix for undefined index error on a fresh installation [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/160929 [08:50:29] 3Wikimedia / 3General/Unknown: Get mail relay out of Yahoo! blacklist: apply to Yahoo for whitelisting bulk mail - 10https://bugzilla.wikimedia.org/56414#c25 (10Andre Klapper) *** Bug 70930 has been marked as a duplicate of this bug. *** [08:50:29] 3MediaWiki / 3Email: MediaWiki emails from yahoo accounts end up in spam - 10https://bugzilla.wikimedia.org/70930#c1 (10Andre Klapper) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 56414 *** [08:51:28] 3Wikimedia / 3Media storage: skwiki image table contains non existing image - 10https://bugzilla.wikimedia.org/70896 (10Andre Klapper) p:5Unprio>3Low [08:52:28] 3MediaWiki / 3Maintenance scripts: maintenance/importDump.php fails for wikidatawiki XML incremental dump files - 10https://bugzilla.wikimedia.org/70898#c1 (10Andre Klapper) If it 'fails', what is the error? And what are exact steps to reproduce? [08:56:43] (03CR) 10Robert Vogel: [C: 032 V: 032] Fix for undefined index error on a fresh installation [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/160929 (owner: 10Mglaser) [08:58:29] 3MediaWiki extensions / 3UniversalLanguageSelector: Oriya webfont not getting loaded for edit field on wikisource (FF31 on Windows XP) - 10https://bugzilla.wikimedia.org/70929#c1 (10Andre Klapper) p:5Normal>3Unprio Link in screenshot: https://wikisource.org/w/index.php?title=Page:Amari_jatir_agua_neta.pd... [09:04:45] 3MediaWiki / 3Email: MediaWiki emails from yahoo accounts end up in spam - 10https://bugzilla.wikimedia.org/70930#c2 (10Nemo) *** This bug has been marked as a duplicate of bug 64795 *** [09:04:45] 3Wikimedia / 3General/Unknown: DMARC: Users cannot send emails via a wiki (from Yahoo addresses etc) - 10https://bugzilla.wikimedia.org/64795#c11 (10Nemo) *** Bug 70930 has been marked as a duplicate of this bug. *** [09:04:59] 3MediaWiki / 3General/Unknown: Gallery element renders image height and width inconsistently - 10https://bugzilla.wikimedia.org/70926#c1 (10Andre Klapper) Seeing six photos in the first row and five in the second, both rows having the same total width, this might simply be a feature?
  • (03CR) 10Nemo bis: "Cannot Merge" [tools/code-utils] - 10https://gerrit.wikimedia.org/r/118263 (https://bugzilla.wikimedia.org/43777) (owner: 10Seb35) [09:17:44] (03CR) 10Zfilipin: "Well, Cucumber code just describes the behaviour. There is no implementation yet." [core] - 10https://gerrit.wikimedia.org/r/144976 (owner: 10Zfilipin) [09:18:10] (03CR) 10Nikerabbit: [C: 031] API: Make jsonfm the default output format [core] - 10https://gerrit.wikimedia.org/r/160819 (owner: 10Anomie) [09:19:18] 3MediaWiki / 3Parser: GENDER (tracking) - 10https://bugzilla.wikimedia.org/30443 (10Andre Klapper) [09:19:18] 3MediaWiki extensions / 3EducationProgram: EducationProgram: improve GENDER support in message strings - 10https://bugzilla.wikimedia.org/70911 (10Andre Klapper) [09:20:45] (03PS1) 10Mglaser: Fixed undefined object when no user is logged on read protected wikis [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/160935 [09:23:01] 3MediaWiki / 3API: Document how to implement tokens in (extension) api modules - 10https://bugzilla.wikimedia.org/41956#c3 (10Niklas Laxström) Wonderful. Can someone make sure this ends up in a some wiki page which extension developers can easily find? [09:23:31] 3MediaWiki / 3File management: Undefined $scaler in TransformationalImageHandler::rotate() - 10https://bugzilla.wikimedia.org/70903 (10Andre Klapper) p:5Unprio>3Low [09:25:45] 3MediaWiki / 3User login and signup: Login as another user no longer works - 10https://bugzilla.wikimedia.org/70855 (10Andre Klapper) p:5Unprio>3Low [09:26:01] (03CR) 10Nikerabbit: "gzip doesn't solve everything: it is not uncommon to have server/mw misconfigured so that it is not used. It also does not help (to my kno" [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx) [09:29:00] 3MediaWiki / 3Email: MediaWiki emails from yahoo accounts end up in spam - 10https://bugzilla.wikimedia.org/70930#c3 (10Strainu) Thanks Nemo, I was quite sure this was not duplicate of bug 56414. :) [09:31:16] 3MediaWiki / 3Parser: Links with attributes containing escaped right square brackets don't close properly - 10https://bugzilla.wikimedia.org/70875 (10Andre Klapper) p:5Unprio>3Low [09:32:02] 3MediaWiki extensions / 3CentralAuth: Not possible to filter Special:Log/gblrename by old CentralAuth account name - 10https://bugzilla.wikimedia.org/70850 (10Andre Klapper) p:5Unprio>3Normal [09:32:02] 3MediaWiki extensions / 3CentralAuth: Global renames should leave local log entries on affected wikis - 10https://bugzilla.wikimedia.org/70851 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc [09:34:50] (03PS1) 10KartikMistry: Log error if config.js is invalid [services/cxserver] - 10https://gerrit.wikimedia.org/r/160937 (https://bugzilla.wikimedia.org/66701) [09:41:48] 3MediaWiki / 3Database: PostgreSQL/pgsql support (tracking) - 10https://bugzilla.wikimedia.org/384 (10Andre Klapper) [09:41:48] 3MediaWiki / 3General/Unknown: Thumbnails not shown in Special:ListFiles when using Postgres - 10https://bugzilla.wikimedia.org/70931#c2 (10Andre Klapper) Thanks for taking the time to report this! Trying the *latest* 1.23.x or 1.22.x versions is highly welcome. [09:41:49] 3MediaWiki extensions / 3WikidataRepo: Investigate issues with globe coordinate precision - 10https://bugzilla.wikimedia.org/70934 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs See https://bugzilla.wikimedia.org/show_bug.cgi?id=64820 and https://bugzilla.wikimedia.org/show_bug.cgi... [09:42:00] 3MediaWiki extensions / 3WikidataRepo: Investigate issues with globe coordinate precision - 10https://bugzilla.wikimedia.org/70934 (10tobias.gritschacher) [09:42:30] 3MediaWiki extensions / 3WikidataRepo: coordinate precision issue - 10https://bugzilla.wikimedia.org/64820 (10tobias.gritschacher) [09:42:31] 3MediaWiki extensions / 3WikidataRepo: Investigate issues with globe coordinate precision - 10https://bugzilla.wikimedia.org/70934 (10tobias.gritschacher) p:5Unprio>3High [09:42:45] 3MediaWiki extensions / 3WikidataRepo: GeoCoordinateFormatter interprets precision as number of decimal places - 10https://bugzilla.wikimedia.org/66653 (10tobias.gritschacher) [09:43:01] 3MediaWiki extensions / 3WikidataRepo: Implement a "sameAs" - 10https://bugzilla.wikimedia.org/55653#c4 (10jeblad) What Daniel describe is rdfs:seeAlso, not owl:sameAs. Those two are quite different even if they seem similar. I think this again centers around a model that isn't quite what it should be. Perh... [09:44:02] 3MediaWiki extensions / 3WikidataRepo: Investigate issues with time value precision - 10https://bugzilla.wikimedia.org/70935 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs See https://bugzilla.wikimedia.org/show_bug.cgi?id=64742 [09:44:32] 3MediaWiki extensions / 3WikidataRepo: Wrong century rounding is applied when entering Time values - 10https://bugzilla.wikimedia.org/64742 (10tobias.gritschacher) [09:44:33] 3MediaWiki extensions / 3WikidataRepo: Investigate issues with time value precision - 10https://bugzilla.wikimedia.org/70935 (10tobias.gritschacher) p:5Unprio>3High [09:45:28] (03CR) 10Daniel Kinzler: "I agree that having a JSON handler in core would be very useful for conflig-like stuff (e.g. gadget definitions). I don't really see the c" [core] - 10https://gerrit.wikimedia.org/r/160610 (owner: 10Yurik) [09:50:01] (03PS2) 10Santhosh: Fail if config.js is invalid [services/cxserver] - 10https://gerrit.wikimedia.org/r/160937 (https://bugzilla.wikimedia.org/66701) (owner: 10KartikMistry) [09:55:10] (03CR) 10Robert Vogel: [C: 032 V: 032] Fixed undefined object when no user is logged on read protected wikis [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/160935 (owner: 10Mglaser) [09:59:02] (03CR) 10KartikMistry: [C: 032] "Thanks Santhosh! Tested." [services/cxserver] - 10https://gerrit.wikimedia.org/r/160937 (https://bugzilla.wikimedia.org/66701) (owner: 10KartikMistry) [09:59:38] (03Merged) 10jenkins-bot: Fail if config.js is invalid [services/cxserver] - 10https://gerrit.wikimedia.org/r/160937 (https://bugzilla.wikimedia.org/66701) (owner: 10KartikMistry) [10:08:57] (03CR) 10Hashar: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/157011 (owner: 10Legoktm) [10:10:34] (03CR) 10Hashar: "Seems a few parent::tearDown() were still missing. The job now fails with some:" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/157011 (owner: 10Legoktm) [10:13:24] (03PS3) 10Tpt: Introduces a JSON serialization for Page: pages [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/138355 [10:21:07] (03CR) 10Matthias Mullie: [C: 032] H106: Locked topics should not appear collapsed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160843 (owner: 10EBernhardson) [10:21:43] (03Merged) 10jenkins-bot: H106: Locked topics should not appear collapsed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160843 (owner: 10EBernhardson) [10:25:11] (03CR) 10Mglaser: "Added some comments" (0324 comments) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/159678 (owner: 10Lilu) [10:25:33] (03PS2) 10Seb35: Version 1.1 [extensions/HSTS] - 10https://gerrit.wikimedia.org/r/160665 [10:34:00] (03Abandoned) 10Raimond Spekking: Consistency tweak: Wrap variable names into [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/157510 (owner: 10Raimond Spekking) [10:56:06] 3Wikimedia / 3Site requests: Category collation for Estonian projects - 10https://bugzilla.wikimedia.org/54168#c17 (10Pikne) Great. Thanks for doing the hacky part and the rest. Though, as for the upstream part of this bug, today is about the day when CLDR v26 is expected to be released and the w and v diff... [10:57:54] 3Wikimedia / 3Site requests: Localizing dv.wikipedia namespace and sitename - 10https://bugzilla.wikimedia.org/48075 (10Glaisher) 5PATC>3RESO/FIX [11:01:38] (03CR) 10Tpt: "I think we can merge this change now as new versions are saved in the default serialization (see change Iaba368f7725a1564c94c2d71dc4acef93" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/138355 (owner: 10Tpt) [11:30:11] (03CR) 10Reedy: "I've not actually looked at the code to confirm the fields and such yet (will do that). I guess it doesn't support the BLOB fields which a" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160916 (https://bugzilla.wikimedia.org/67767) (owner: 10Legoktm) [11:41:51] 3Wikimedia / 3Interwiki links: Provide a non-JavaScript means of including a "Complete list" link in the interlanguage sidebar - 10https://bugzilla.wikimedia.org/16962#c14 (10This, that and the other (TTO)) 5PATC>3NEW Patch is merged; this is just waiting on a manual update of interwiki.cdb [11:42:06] 3Wikimedia / 3Interwiki links: Please add ISO code interwikis for non-standard language codes - 10https://bugzilla.wikimedia.org/21915#c3 (10This, that and the other (TTO)) 5PATC>3NEW Patch is merged; this is just waiting on a manual update of interwiki.cdb [11:48:07] 3MediaWiki / 3ResourceLoader: CSSMin::encodeImageAsDataURI() should be smarter about SVG images (tracking) - 10https://bugzilla.wikimedia.org/57777 (10Bartosz Dziewoński) [11:48:24] 3MediaWiki / 3ResourceLoader: Embedded SVG files should be optimized in ResourceLoader/CSSMin - 10https://bugzilla.wikimedia.org/63491 (10Bartosz Dziewoński) [11:48:24] 3MediaWiki / 3ResourceLoader: Allow minification of SVG files - 10https://bugzilla.wikimedia.org/34812 (10Bartosz Dziewoński) [11:48:26] 3MediaWiki / 3ResourceLoader: Investigate embedding some data URLs without base 64 - 10https://bugzilla.wikimedia.org/67341 (10Bartosz Dziewoński) [11:48:36] 3MediaWiki / 3ResourceLoader: CSSMin::encodeImageAsDataURI() should be smarter about SVG images (tracking) - 10https://bugzilla.wikimedia.org/57777 (10Bartosz Dziewoński) [11:48:36] 3MediaWiki / 3ResourceLoader: Embedded SVG files should be optimized in ResourceLoader/CSSMin - 10https://bugzilla.wikimedia.org/63491 (10Bartosz Dziewoński) [11:54:40] 3MediaWiki / 3General/Unknown: Tracking bug (tracking) - 10https://bugzilla.wikimedia.org/2007 (10Andre Klapper) [11:59:09] 3MediaWiki / 3Uploading: SVG encoding get blocked (windows-1252, with wrong/unspecific warning) - 10https://bugzilla.wikimedia.org/70937 (10PRO) 3NEW p:3Unprio s:3normal a:3None I got an ERROR unspecific warning: "This file contains HTML or script code that may be erroneously interpreted by a web bro... [11:59:50] 3MediaWiki / 3Uploading: SVG upload get blocked on correct encoding (windows-1252, with wrong/unspecific warning) - 10https://bugzilla.wikimedia.org/70937 (10PRO) [12:00:36] 3MediaWiki / 3Uploading: SVG upload get blocked on correct encoding (windows-1252, with wrong/unspecific warning) - 10https://bugzilla.wikimedia.org/70937 (10PRO) [12:00:37] 3MediaWiki / 3Uploading: Scripted SVG checks blacklist all filter attributes, even if local to current svg doc - 10https://bugzilla.wikimedia.org/67044 (10PRO) [12:13:49] (03PS1) 10Raimond Spekking: Consistency tweaks [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/160948 [12:17:11] (03CR) 10Helder.wiki: "@Hoo: I believe the logs should NOT be purged, since this is what allow us to detect regressions on updates to filters (e.g. a filter whic" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/145156 (https://bugzilla.wikimedia.org/25377) (owner: 10Legoktm) [12:18:09] (03PS1) 10Adrian Lang: Start switching to ES6 Promises [core] - 10https://gerrit.wikimedia.org/r/160949 [12:19:23] 3MediaWiki extensions / 3EducationProgram: Confusing/out of date comment in ep_users_per_course table SQL - 10https://bugzilla.wikimedia.org/70938 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3minor a:3None -- Links the students with their courses. CREATE TABLE IF NOT EXISTS /*_*/ep_users_per_course ( upc... [12:21:07] 3MediaWiki extensions / 3EducationProgram: Confusing/out of date comment in ep_users_per_course table SQL - 10https://bugzilla.wikimedia.org/70938 (10Sam Reed (reedy)) p:5Unprio>3High [12:21:07] 3MediaWiki extensions / 3EducationProgram: Confusing/out of date comment in ep_users_per_course table SQL - 10https://bugzilla.wikimedia.org/70938 (10Sam Reed (reedy)) p:5Unprio>3High [12:21:15] (03CR) 10Reedy: "LGTM as is. Possibly missing ep_users_per_course.upc_user_id (see comment on revision), and ep_courses per commit summary" (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160916 (https://bugzilla.wikimedia.org/67767) (owner: 10Legoktm) [12:27:52] (03PS1) 10Reedy: Note that columns are serialized PHP arrays [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160951 [12:29:37] (03CR) 10Yuvipanda: [C: 032] Note that columns are serialized PHP arrays [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160951 (owner: 10Reedy) [12:29:46] (03Merged) 10jenkins-bot: Note that columns are serialized PHP arrays [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160951 (owner: 10Reedy) [12:32:50] (03CR) 10jenkins-bot: [V: 04-1] Start switching to ES6 Promises [core] - 10https://gerrit.wikimedia.org/r/160949 (owner: 10Adrian Lang) [12:34:47] (03PS2) 10Adrian Lang: Start switching to ES6 Promises [core] - 10https://gerrit.wikimedia.org/r/160949 [12:40:05] (03CR) 10Florianschmidtwelzow: Redo WhatLinksHere query and add a *_from_namespace field to link tables (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117373 (https://bugzilla.wikimedia.org/60618) (owner: 10Aaron Schulz) [12:41:27] (03CR) 10jenkins-bot: [V: 04-1] Start switching to ES6 Promises [core] - 10https://gerrit.wikimedia.org/r/160949 (owner: 10Adrian Lang) [12:45:19] Does running $dbw->update() inside a $dbw->select() loop work? [12:46:48] Probably not reliably. [12:47:38] That's what I presumed [12:48:50] (03PS1) 10Reedy: Add UserMerge support for ep_courses table [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160954 [12:48:53] legoktm: ^^ [12:48:56] * Reedy feels dirty [13:01:10] (03CR) 10Manybubbles: "I'm not actually sure how useful this will be. I had thought we'd be able to let users specify stuff like extra character transforms and " [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/160811 (owner: 10Manybubbles) [13:03:01] (03PS1) 10Reedy: ep_user -> user [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160955 (https://bugzilla.wikimedia.org/70938) [13:13:00] (03CR) 10AndyRussG: [C: 032] ep_user -> user [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160955 (https://bugzilla.wikimedia.org/70938) (owner: 10Reedy) [13:13:09] (03Merged) 10jenkins-bot: ep_user -> user [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160955 (https://bugzilla.wikimedia.org/70938) (owner: 10Reedy) [13:15:14] (03PS2) 10Reedy: Add UserMerge support [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160916 (https://bugzilla.wikimedia.org/67767) (owner: 10Legoktm) [13:15:52] 3MediaWiki extensions / 3EducationProgram: Confusing/out of date comment in ep_users_per_course table SQL - 10https://bugzilla.wikimedia.org/70938#c3 (10Andrew Green) 5PATC>3RESO/FIX Yes, that's it. [13:20:01] (03PS13) 10Jamesmontalvo3: Add file approval and fine-tuned permissions; bump to v1.0 [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 [13:25:07] (03CR) 10Jamesmontalvo3: "* Changed ApprovedRevs::mediaIsApprovable to fileIsApprovable" [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [13:30:06] 3Wikimedia / 3General/Unknown: Special:MovePage disappeared from tet.wikipedia - 10https://bugzilla.wikimedia.org/70686#c15 (10MF-Warburg) (In reply to MF-Warburg from comment #14) > I changed the alias now > ( SpecialPageAliases/tet&acti... [13:42:44] (03PS4) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/143591 [13:47:35] 3MediaWiki / 3Parser: Bogus entries in externallinks table due to unescaping of &%=+ - 10https://bugzilla.wikimedia.org/57909 (10Brad Jorsch) 5PATC>3RESO/FIX [13:47:44] (03CR) 10Reedy: Add UserMerge support for ep_courses table (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160954 (owner: 10Reedy) [13:52:51] (03CR) 10Phe: [C: 031] Introduces a JSON serialization for Page: pages [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/138355 (owner: 10Tpt) [13:52:56] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/143591 (owner: 10Hashar) [13:57:34] (03CR) 10Nikerabbit: "If there is discussion about this please point me to it." [core] - 10https://gerrit.wikimedia.org/r/160949 (owner: 10Adrian Lang) [14:09:06] 3MediaWiki / 3Interface: toaster overlay for watchlisting is inconsistent between mobile and desktop - 10https://bugzilla.wikimedia.org/65983#c9 (10Jon) Note Flow's toaster is also inconsistent (specifically it has a pointer arrow. [14:11:06] 3MediaWiki extensions / 3SemanticFormsInputs: SemanticFormsInputs should pass jshint - 10https://bugzilla.wikimedia.org/61631#c7 (10Antoine "hashar" Musso) 5PATC>3RESO/FIX I have updated Zuul to -2 whenever jshint is not passing. Thank you! [14:12:07] (03PS2) 10Shirayuki: i18n: remove unused messages and fix comment [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/160891 [14:12:51] 3MediaWiki / 3Uploading: SVG upload get blocked on correct encoding (windows-1252, with wrong/unspecific warning) - 10https://bugzilla.wikimedia.org/70937#c1 (10Tisza Gergő) I am not sure I understand the role of encoding in this bug. Do you get the error with some encoding but not with another one? [14:21:36] 3Wikimedia / 3Site requests: [Regression] Wikitech should not be set up as a Wikipedia (interwiki for "wikipedia:" missing, canonical url labs.wikipedia.org) - 10https://bugzilla.wikimedia.org/70641#c4 (10Andre Klapper) (In reply to Krinkle from comment #1) > Ugh, there's other weird stuff as well: > 3Wikimedia / 3Site requests: Creation of 'Author' namespace on Assamese Wikisource (aswikisource) - 10https://bugzilla.wikimedia.org/70464#c9 (10Gitartha Bordoloi) (In reply to James Forrester from comment #8) > Should be now done. It's working now. Thank you. [14:28:42] (03PS1) 1001tonythomas: Added GENDER support for message ep-disenroll-success [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160965 (https://bugzilla.wikimedia.org/70911) [14:31:27] (03CR) 10jenkins-bot: [V: 04-1] Added GENDER support for message ep-disenroll-success [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160965 (https://bugzilla.wikimedia.org/70911) (owner: 1001tonythomas) [14:35:52] 3Wikimedia / 3Site requests: [Regression] Wikitech should not be set up as a Wikipedia (interwiki for "wikipedia:" missing, canonical url labs.wikipedia.org) - 10https://bugzilla.wikimedia.org/70641#c5 (10Andrew Bogott) Nope, still broken [14:49:20] (03CR) 10Gilles: [C: 04-1] "Needs rebase" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/159625 (https://bugzilla.wikimedia.org/46741) (owner: 10MarkTraceur) [15:04:36] 3MediaWiki extensions / 3Translate: Kazakh keyboard doesn't show up in Special:TranslationStash - 10https://bugzilla.wikimedia.org/69216#c1 (10Niklas Laxström) I just tested this again and I could find the keyboard. As far as I know there has not been changed to this area of code. Could the confusion be re... [15:04:58] (03CR) 10Matthias Mullie: Remove special Watchlist star handling on Flow boards (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159756 (owner: 10Matthias Mullie) [15:09:24] 3Wikimedia / 3General/Unknown: CentralNotice reloads old translatable messages on form submit - 10https://bugzilla.wikimedia.org/70939 (10Kai Nissen) 3NEW p:3Unprio s:3normal a:3None After submitting updated translatable messages of a banner, the page reloads and displays the old messages. After rel... [15:19:52] 3Wikimedia / 3Site requests: [Regression] Wikitech should not be set up as a Wikipedia (interwiki for "wikipedia:" missing, canonical url labs.wikipedia.org) - 10https://bugzilla.wikimedia.org/70641#c6 (10Sam Reed (reedy)) reedy@tin:/srv/mediawiki-staging/multiversion$ mwscript eval.php mediawikiwiki > var_d... [15:21:53] (03PS2) 10Matthias Mullie: Remove special Watchlist star handling on Flow boards [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159756 [15:23:22] (03CR) 10Seb35: [C: 032 V: 032] "Thanks Siebrand for the l10n review!" [extensions/HSTS] - 10https://gerrit.wikimedia.org/r/160665 (owner: 10Seb35) [15:25:31] (03PS1) 10Gergő Tisza: Fix EventLogging schema declarations [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/160972 [15:25:34] (03CR) 10Tpt: [C: 032] Introduces a JSON serialization for Page: pages [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/138355 (owner: 10Tpt) [15:25:55] (03Merged) 10jenkins-bot: Introduces a JSON serialization for Page: pages [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/138355 (owner: 10Tpt) [15:26:29] (03CR) 10Gergő Tisza: "Could not test locally because EL is broken in vagrant but this seems to be the only change that could have caused problems." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/160972 (owner: 10Gergő Tisza) [15:26:44] (03CR) 10Physikerwelt: "The same argument holds for" [extensions/Math] - 10https://gerrit.wikimedia.org/r/158845 (owner: 10Physikerwelt) [15:27:50] 3Wikimedia / 3Site requests: [Regression] Wikitech should not be set up as a Wikipedia (interwiki for "wikipedia:" missing, canonical url labs.wikipedia.org) - 10https://bugzilla.wikimedia.org/70641#c7 (10Sam Reed (reedy)) > reedy@tin:/srv/mediawiki-staging/multiversion$ mwscript eval.php labswiki > var_dump... [15:30:05] (03CR) 10Gilles: [C: 032] Fix EventLogging schema declarations [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/160972 (owner: 10Gergő Tisza) [15:30:32] (03CR) 10jenkins-bot: [V: 04-1] Fix EventLogging schema declarations [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/160972 (owner: 10Gergő Tisza) [15:31:22] 3Wikimedia / 3Site requests: [Regression] Wikitech should not be set up as a Wikipedia (interwiki for "wikipedia:" missing, canonical url labs.wikipedia.org) - 10https://bugzilla.wikimedia.org/70641#c8 (10Sam Reed (reedy)) Found it: 3Wikimedia / 3Site requests: [Regression] Wikitech should not be set up as a Wikipedia (interwiki for "wikipedia:" missing, canonical url labs.wikipedia.org) - 10https://bugzilla.wikimedia.org/70641#c9 (10Sam Reed (reedy)) Versus wikitech-static 3Wikimedia / 3Site requests: [Regression] Wikitech should not be set up as a Wikipedia (interwiki for "wikipedia:" missing, canonical url labs.wikipedia.org) - 10https://bugzilla.wikimedia.org/70641#c10 (10Sam Reed (reedy)) 5NEW>3RESO/FIX a:3Sam Reed (reedy) Fixed [15:38:20] (03CR) 10Gergő Tisza: [C: 032] "per Gilles" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/160972 (owner: 10Gergő Tisza) [15:38:48] (03Merged) 10jenkins-bot: Fix EventLogging schema declarations [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/160972 (owner: 10Gergő Tisza) [15:39:06] 3Wikimedia / 3Site requests: [Regression] Wikitech should not be set up as a Wikipedia (interwiki for "wikipedia:" missing, canonical url labs.wikipedia.org) - 10https://bugzilla.wikimedia.org/70641#c11 (10Sam Reed (reedy)) Fix was https://gerrit.wikimedia.org/r/160973 [15:47:35] 3MediaWiki extensions / 3OAuth: With SQLite only first consumer can be created - 10https://bugzilla.wikimedia.org/70927#c1 (10Sam Reed (reedy)) If you could set the code below in your LocalSettings, then report back with the actual SQL error, that'd be really helpful $wgShowSQLErrors = true; $wgDebugDumpSql... [15:49:05] no bawolff? :) [15:49:07] *:( [15:49:22] He's probably back to school by now [15:49:28] how dare he [15:49:38] Agreed [15:50:36] (03CR) 10Matthias Mullie: [C: 032] H99: Never collapse on topic pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160822 (owner: 10EBernhardson) [15:50:44] (03CR) 1001tonythomas: "Jenkins error report is due to some code issue in the patch ?" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160965 (https://bugzilla.wikimedia.org/70911) (owner: 1001tonythomas) [15:51:12] (03Merged) 10jenkins-bot: H99: Never collapse on topic pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160822 (owner: 10EBernhardson) [15:51:20] 3MediaWiki extensions / 3OAuth: With SQLite only first consumer can be created - 10https://bugzilla.wikimedia.org/70927#c2 (10Mitar) Query: INSERT INTO oauth_registered_consumer (oarc_id,oarc_consumer_key,oarc_name,oarc_user_id,oarc_version,oarc_callback_url,oarc_callback_is_prefix,oarc_description,oarc_emai... [15:52:15] (03CR) 10Physikerwelt: "Thanks Bryan." (034 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/160694 (owner: 10Physikerwelt) [15:56:48] (03PS1) 10Reedy: Array to string conversion in TransformationalImageHandler.php:167 [core] - 10https://gerrit.wikimedia.org/r/160978 (https://bugzilla.wikimedia.org/70902) [15:56:52] marktraceur: ^^ [16:01:09] Reedy: multimedia@lists.wikimedia.org :D [16:01:15] Or -multimedia or whatever [16:01:38] (03PS1) 10Reedy: Undefined $scaler in TransformationalImageHandler::rotate() [core] - 10https://gerrit.wikimedia.org/r/160979 (https://bugzilla.wikimedia.org/70903) [16:01:40] lol [16:02:02] I was trying to get the code to use vips for Tiffs reviewed, tested and merged :P [16:03:18] Reedy: Not really my expertise anyway, reaching the team is probably more u.seful [16:03:34] (03PS1) 10Aude: Implement LinkFormatter [WIP, DO NOT MERGE!] [core] - 10https://gerrit.wikimedia.org/r/160980 [16:04:25] (03CR) 10jenkins-bot: [V: 04-1] Implement LinkFormatter [WIP, DO NOT MERGE!] [core] - 10https://gerrit.wikimedia.org/r/160980 (owner: 10Aude) [16:05:37] 3MediaWiki / 3Uploading: SVG upload get blocked on correct encoding (windows-1252, with wrong/unspecific warning) - 10https://bugzilla.wikimedia.org/70937#c2 (10Chris Steipp) Currently, we only allow encodings: $safeXmlEncodings = array( 'UTF-8', 'ISO-8859-1', 'ISO-8859-2', 'UTF-16', 'UT... [16:08:36] 3MediaWiki extensions / 3OAuth: With SQLite only first consumer can be created - 10https://bugzilla.wikimedia.org/70927#c3 (10Sam Reed (reedy)) CREATE UNIQUE INDEX /*i*/oarc_consumer_key ON /*_*/oauth_registered_consumer (oarc_consumer_key); CREATE UNIQUE INDEX /*i*/oarc_name_version_user ON /*_*/oau... [16:13:39] 3Wikimedia / 3Mailing lists: Mail list Deletion WLM-CN - 10https://bugzilla.wikimedia.org/70943 (10addiswang94) 3NEW p:3Unprio s:3normal a:3None Hi We are no longer using the mail list WLM-CN@lists.wikimedia.org, and hosting WLM in China. I request to delete this mail list. * Bug 53696 [16:14:36] 3MediaWiki / 3Uploading: SVG upload get blocked on correct encoding (windows-1252, with wrong/unspecific warning) - 10https://bugzilla.wikimedia.org/70937#c3 (10PRO) (In reply to Tisza Gergő from comment #1) Yes, the [[Windows-1252]] encoding is preferred by the W3C (validator) to encoding="ISO-8859-1", also... [16:15:56] (03PS2) 10Seb35: Convert read_wfMsgCalls.py to Git [tools/code-utils] - 10https://gerrit.wikimedia.org/r/118263 (https://bugzilla.wikimedia.org/43777) [16:17:20] 3MediaWiki extensions / 3OAuth: With SQLite only first consumer can be created - 10https://bugzilla.wikimedia.org/70927#c4 (10Mitar) I removed all indexes and it is still failing. I think the issue is that you are explicitly setting oarc_id to '0'. I think it should be NULL to be autogenerated/autoincremented. [16:21:50] (03CR) 10Seb35: "It is a known "bug" that half of the program (output messageStrings.csv) doesn’t work with MediaWiki 1.23+ because the messages are no mor" [tools/code-utils] - 10https://gerrit.wikimedia.org/r/118263 (https://bugzilla.wikimedia.org/43777) (owner: 10Seb35) [16:23:01] (03PS1) 10KartikMistry: Display better error message for MT processing [services/cxserver] - 10https://gerrit.wikimedia.org/r/160982 [16:31:37] (03CR) 10Amire80: "Yes, look at the comment by jenkins-bot above and click on the link next to the FAILURE marker. The output is quite easy, but if you have " [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160965 (https://bugzilla.wikimedia.org/70911) (owner: 1001tonythomas) [16:32:36] 3MediaWiki / 3General/Unknown: Thumbnails not shown in Special:ListFiles when using Postgres - 10https://bugzilla.wikimedia.org/70931#c3 (10Sam Reed (reedy)) (In reply to Andre Klapper from comment #2) > Thanks for taking the time to report this! > Trying the *latest* 1.23.x or 1.22.x versions is highly welc... [16:32:59] (03CR) 10Yaron Koren: "Fantastic!" (038 comments) [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [16:34:14] (03CR) 10AndyRussG: "It seems to be an intermittent problem. I believe it's related to Jenkins somehow, but I haven't had time to chase it down. Here is the bu" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160965 (https://bugzilla.wikimedia.org/70911) (owner: 1001tonythomas) [16:38:53] (03CR) 10Anomie: Record redirect target in ParserOptions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/131210 (https://bugzilla.wikimedia.org/62856) (owner: 10Anomie) [16:40:36] (03PS4) 10Anomie: Record redirect target in ParserOptions [core] - 10https://gerrit.wikimedia.org/r/131210 (https://bugzilla.wikimedia.org/62856) [16:40:41] (03PS5) 10Anomie: Record redirect target in ParserOptions [core] - 10https://gerrit.wikimedia.org/r/131210 (https://bugzilla.wikimedia.org/62856) [16:40:58] (03CR) 10Anomie: "PS4: Rebase" [core] - 10https://gerrit.wikimedia.org/r/131210 (https://bugzilla.wikimedia.org/62856) (owner: 10Anomie) [16:48:18] (03CR) 10Physikerwelt: Make Mathoid role configurable via hiera (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/160694 (owner: 10Physikerwelt) [16:52:46] (03PS1) 10Reedy: Doc param updates [extensions/DynamicSidebar] - 10https://gerrit.wikimedia.org/r/160985 [16:53:00] (03CR) 10Cscott: [C: 04-1] "Some tweaks." (035 comments) [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/160237 (https://bugzilla.wikimedia.org/68836) (owner: 10Arlolra) [16:54:22] (03PS2) 10Reedy: Doc param updates [extensions/DynamicSidebar] - 10https://gerrit.wikimedia.org/r/160985 [16:55:21] (03PS1) 1001tonythomas: Added .jshintrc file to pass Jenkins [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160986 [16:55:34] (03CR) 10jenkins-bot: [V: 04-1] Added .jshintrc file to pass Jenkins [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160986 (owner: 1001tonythomas) [16:55:37] (03CR) 10Cscott: "(This probably needs a corresponding patch to the bundler, but I can handle that. The bundler is where we'd look at /etc/papersize to get" [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/160237 (https://bugzilla.wikimedia.org/68836) (owner: 10Arlolra) [16:56:01] (03PS2) 10Cscott: WIP: tighter query for images [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/152085 [16:56:07] 3Wikimedia / 3Site requests: Category collation for Estonian projects - 10https://bugzilla.wikimedia.org/54168 (10Bartosz Dziewoński) 5NEW>3RESO/FIX [16:57:16] (03CR) 10Anomie: "I note this blows up without core change I521f1f68" [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/160572 (https://bugzilla.wikimedia.org/70495) (owner: 10Jackmcbarn) [16:58:29] (03CR) 10Anomie: [C: 032] Call Title::exists() instead of checking the ID [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/160549 (https://bugzilla.wikimedia.org/70495) (owner: 10Jackmcbarn) [17:00:47] (03Merged) 10jenkins-bot: Call Title::exists() instead of checking the ID [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/160549 (https://bugzilla.wikimedia.org/70495) (owner: 10Jackmcbarn) [17:04:52] (03CR) 10Anomie: [C: 032] Add TitleExists hook [core] - 10https://gerrit.wikimedia.org/r/160546 (https://bugzilla.wikimedia.org/70495) (owner: 10Jackmcbarn) [17:10:46] (03CR) 10Anomie: [C: 04-1] Hook TitleExists when previewing (031 comment) [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/160555 (https://bugzilla.wikimedia.org/70495) (owner: 10Jackmcbarn) [17:11:31] (03Merged) 10jenkins-bot: Add TitleExists hook [core] - 10https://gerrit.wikimedia.org/r/160546 (https://bugzilla.wikimedia.org/70495) (owner: 10Jackmcbarn) [17:12:27] manybubbles: i replied to your comment [17:12:50] (03PS2) 1001tonythomas: Added .jshintrc file to pass Jenkins [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160986 (https://bugzilla.wikimedia.org/63959) [17:13:01] (03CR) 10jenkins-bot: [V: 04-1] Added .jshintrc file to pass Jenkins [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160986 (https://bugzilla.wikimedia.org/63959) (owner: 1001tonythomas) [17:13:06] (03CR) 10Aaron Schulz: [C: 032] Undefined $scaler in TransformationalImageHandler::rotate() [core] - 10https://gerrit.wikimedia.org/r/160979 (https://bugzilla.wikimedia.org/70903) (owner: 10Reedy) [17:15:30] (03PS1) 10Manybubbles: [tests] Fix some bugs with page creation [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/160988 [17:16:23] 3MediaWiki extensions / 3CentralNotice: CentralNotice reloads old translatable messages on form submit - 10https://bugzilla.wikimedia.org/70939#c1 (10Andre Klapper) Not sure if this is actually a code issue, or some caching on the server / syncing with translations issue, or a client browser cache issue. Do... [17:17:31] (03CR) 10Aaron Schulz: [C: 031] Deprecate HTMLFileCache::newFromTitle() in favor of constructor (031 comment) [core] - 10https://gerrit.wikimedia.org/r/160547 (owner: 10MaxSem) [17:19:19] (03CR) 10Aaron Schulz: [C: 032] Array to string conversion in TransformationalImageHandler.php:167 [core] - 10https://gerrit.wikimedia.org/r/160978 (https://bugzilla.wikimedia.org/70902) (owner: 10Reedy) [17:20:27] (03Merged) 10jenkins-bot: Undefined $scaler in TransformationalImageHandler::rotate() [core] - 10https://gerrit.wikimedia.org/r/160979 (https://bugzilla.wikimedia.org/70903) (owner: 10Reedy) [17:21:07] 3MediaWiki extensions / 3CentralAuth: Global renames should leave local log entries on affected wikis - 10https://bugzilla.wikimedia.org/70851#c1 (10Kunal Mehta (Legoktm)) I don't like the idea of putting a permanent log entry on every single wiki, there are plenty of other actions that would affect the wiki... [17:21:31] (03CR) 10MaxSem: Deprecate HTMLFileCache::newFromTitle() in favor of constructor (031 comment) [core] - 10https://gerrit.wikimedia.org/r/160547 (owner: 10MaxSem) [17:22:06] 3MediaWiki / 3File management: Undefined $scaler in TransformationalImageHandler::rotate() - 10https://bugzilla.wikimedia.org/70903#c3 (10Umherirrender) 5PATC>3RESO/FIX successfully merged [17:26:04] (03CR) 10jenkins-bot: [V: 04-1] WIP: tighter query for images [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/152085 (owner: 10Cscott) [17:26:19] (03CR) 10Anomie: [C: 031] "Code seems ok." [core] - 10https://gerrit.wikimedia.org/r/160570 (https://bugzilla.wikimedia.org/70495) (owner: 10Jackmcbarn) [17:27:40] (03CR) 10Anomie: [C: 031] "Not +2ing yet just in case anyone nitpicks the name of "fetchLatestRevisionOfTitle"." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/160550 (https://bugzilla.wikimedia.org/70495) (owner: 10Jackmcbarn) [17:29:24] (03Merged) 10jenkins-bot: Array to string conversion in TransformationalImageHandler.php:167 [core] - 10https://gerrit.wikimedia.org/r/160978 (https://bugzilla.wikimedia.org/70902) (owner: 10Reedy) [17:30:12] (03PS1) 10Manybubbles: Add asciifolding to some French analyzers [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/160990 (https://bugzilla.wikimedia.org/70561) [17:32:37] (03PS1) 10Cscott: Use default papersize from /etc/papersize when bundling. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160991 (https://bugzilla.wikimedia.org/68836) [17:33:46] (03CR) 10Cscott: "See If9657503522a95fc3c30867c71526415a3bc9d15 for the corresponding bundler patch." [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/160237 (https://bugzilla.wikimedia.org/68836) (owner: 10Arlolra) [17:33:48] (03CR) 10Anomie: [C: 04-2] "Code looks good, +2, but can't merge without the core patch." [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/160572 (https://bugzilla.wikimedia.org/70495) (owner: 10Jackmcbarn) [17:34:36] 3MediaWiki extensions / 3CirrusSearch: Accents are not ignored by autocompletion in fr.wiktionary - 10https://bugzilla.wikimedia.org/70561#c9 (10Nik Everett) I've added a proposal to flatten all accented characters into non-accented ones for prefix search and exact title matches. It'll require rebuilding th... [17:34:38] 3MediaWiki extensions / 3OAuth: OAuth should be autoblock-exempt / "IP address had been blocked automatically" in croptool - 10https://bugzilla.wikimedia.org/66639#c7 (10Rainer Rillke @commons.wikimedia) (In reply to Chris Steipp from comment #6) > Yes, the app's key can be revoked I get a permission error... [17:39:04] (03PS3) 10MaxSem: Deprecate HTMLFileCache::newFromTitle() in favor of constructor [core] - 10https://gerrit.wikimedia.org/r/160547 [17:39:58] (03CR) 10Anomie: [C: 031] "Code looks sane. Haven't tested." (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159785 (owner: 10Legoktm) [17:40:23] DanielK_WMDE_, around? [17:40:54] (03CR) 10Rillke: "FYI, there is an empty repo for this purpose now: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/DetectLanguage" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152177 (owner: 10Rillke) [17:44:35] yurikR: about to call it a day... [17:46:58] yurikR: write mail? [17:47:20] (03PS3) 10SG: Override vector anchor hover and visited styles on mw-ui-button [core] - 10https://gerrit.wikimedia.org/r/160912 [17:47:24] (03PS2) 10SG: Remove mw-ui-button min sizing for inline mode [core] - 10https://gerrit.wikimedia.org/r/160913 [17:47:30] DanielK_WMDE_, sure, but maybe you know off top of your head: [17:47:50] is there a way to make stored text differ from the text in the edit box [17:48:24] i keep seeing that outside code sometimes uses getNativeData() and sometimes - handler:serialize...() [17:49:05] should code not being using ->serialize? [17:49:05] yurikR: getNativeData should really not exist - instead, TextContent should have getText(). getNativeData should never be called on anything that isn't text. [17:49:19] yurikR: have a look at preloadTransform [17:49:25] not sure when that is triggered though [17:49:56] DanielK_WMDE_, ok, will outline in an email - i was trying to make json content store compact json, and show pretty-printed [17:49:58] yurikR: serialize() generates what is *stored*. in EditPage, it's also what will be edited. but EditPage is a horrible horribel hack in so many way... [17:50:04] (03CR) 10Krinkle: [C: 04-1] "As long as these are jQuery based and jQuery has not yet made plans on potentially using a native Promise when available, it seems presump" [core] - 10https://gerrit.wikimedia.org/r/160949 (owner: 10Adrian Lang) [17:50:10] (03CR) 10Krinkle: [C: 04-2] Start switching to ES6 Promises [core] - 10https://gerrit.wikimedia.org/r/160949 (owner: 10Adrian Lang) [17:50:42] DanielK_WMDE_, yeah, i'v noteced :) seems like the editpage calls getnativedata to pull one version of data, followed by serialize to get another [17:50:51] yurikR: having different serializations for editing and saving could be done by, well, making them duifferent serializations. e.g. application/json;pretty or whatever [17:51:19] DanielK_WMDE_, true, except that we really should stop using getnativedata outside of the content object [17:51:40] yes, use serialize instead [17:51:47] that also gives you control over the serialization format [17:51:50] ok, will try to fix it to address this issue [17:52:07] ok, ttfn [17:52:12] DanielK_WMDE_, but what part of the code actually decides the format to pass serializeR [17:52:29] ok, will continue over email [17:54:08] (03PS2) 10Anomie: Update for core API changes [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/160800 [17:56:03] (03PS3) 10Cscott: Tighter query for images. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/152085 [17:57:43] (03CR) 10Anomie: "> Another problem is that help doesn't point people to ApiSandbox anymore." [core] - 10https://gerrit.wikimedia.org/r/160798 (https://bugzilla.wikimedia.org/30936) (owner: 10Anomie) [18:01:42] (03CR) 10Matthias Mullie: [C: 032] Override vector anchor hover and visited styles on mw-ui-button [core] - 10https://gerrit.wikimedia.org/r/160912 (owner: 10SG) [18:02:40] (03CR) 10jenkins-bot: [V: 04-1] Use default papersize from /etc/papersize when bundling. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160991 (https://bugzilla.wikimedia.org/68836) (owner: 10Cscott) [18:03:22] (03CR) 10Matthias Mullie: [C: 032] Remove mw-ui-button min sizing for inline mode [core] - 10https://gerrit.wikimedia.org/r/160913 (owner: 10SG) [18:03:37] 3MediaWiki extensions / 3CentralAuth: Global renames should leave local log entries on affected wikis - 10https://bugzilla.wikimedia.org/70851#c2 (10Vogone) (In reply to Kunal Mehta (Legoktm) from comment #1) > I don't like the idea of putting a permanent log entry on every single wiki, > there are plenty of... [18:03:53] 3Wikimedia / 3Site requests: English Wikisource: Tweak to search results elevating weighting for a specific namespace - 10https://bugzilla.wikimedia.org/69771 (10Nik Everett) 5NEW>3ASSI a:3Nik Everett [18:04:21] (03PS1) 10Legoktm: Remove spammy debug log [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/160997 [18:04:43] (03CR) 10Reedy: [C: 032] "reedy@ubuntu64-web-esxi:/var/www/wiki/mediawiki/core/tests/phpunit$ php phpunit.php --with-phpunitdir /var/www/wiki/mediawiki ../../extens" [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/86413 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [18:04:56] (03CR) 10Arlolra: Use default papersize from /etc/papersize when bundling. (031 comment) [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160991 (https://bugzilla.wikimedia.org/68836) (owner: 10Cscott) [18:04:58] (03Merged) 10jenkins-bot: Make PagedTiffHandler extend TransformationalImageHandler [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/86413 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [18:05:49] (03CR) 10Reedy: [C: 032] Remove spammy debug log [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/160997 (owner: 10Legoktm) [18:05:55] Krinkle: production is actually a mix of node 0.10 and 0.8 currently [18:06:18] (03Merged) 10jenkins-bot: Remove spammy debug log [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/160997 (owner: 10Legoktm) [18:06:23] (03PS1) 10SG: Ignore browser test screenshots [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160998 [18:06:34] (03PS17) 10Lewis Cawte: New class for parsing MediaWiki:Sidebar-like messages into modern, nested navigation menus. [core] - 10https://gerrit.wikimedia.org/r/108045 (owner: 10Jack Phoenix) [18:07:27] (03PS1) 10Arlolra: Upgrade to node-icu-bidi to v0.1.3 [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/161000 [18:07:59] (03Merged) 10jenkins-bot: Override vector anchor hover and visited styles on mw-ui-button [core] - 10https://gerrit.wikimedia.org/r/160912 (owner: 10SG) [18:08:01] (03CR) 10Reedy: "Parent patch merged, plus some updates to core" [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135289 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [18:08:05] (03PS1) 10SG: Update compiled templates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161001 [18:08:08] (03PS2) 10Arlolra: Upgrade node-icu-bidi to v0.1.3 [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/161000 [18:08:17] (03PS1) 10Reedy: Remove spammy debug log [extensions/MassMessage] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161002 [18:08:19] (03CR) 10SG: [C: 032] Ignore browser test screenshots [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160998 (owner: 10SG) [18:08:22] (03CR) 10SG: [C: 032] Update compiled templates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161001 (owner: 10SG) [18:08:57] (03CR) 10Spage: [C: 032] "WFM, no "screenshots" under Untracked files in `git status`." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160998 (owner: 10SG) [18:09:16] (03Merged) 10jenkins-bot: Ignore browser test screenshots [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160998 (owner: 10SG) [18:09:35] (03Merged) 10jenkins-bot: Remove mw-ui-button min sizing for inline mode [core] - 10https://gerrit.wikimedia.org/r/160913 (owner: 10SG) [18:09:39] (03Merged) 10jenkins-bot: Update compiled templates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161001 (owner: 10SG) [18:10:51] 3MediaWiki extensions / 3Collection: TIFF images make the new PDF renderer crash (eg [[de:Zweiter Weltkrieg]]) - 10https://bugzilla.wikimedia.org/70866#c1 (10C. Scott Ananian) Turns out that [[de:Zweiter Weltkrieg]] has a TIFF image, which causes the renderer to crash. [18:11:02] (03PS1) 10Cscott: Convert TIFF images to PNG. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/161003 (https://bugzilla.wikimedia.org/70866) [18:11:14] (03CR) 10jenkins-bot: [V: 04-1] Remove spammy debug log [extensions/MassMessage] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161002 (owner: 10Reedy) [18:13:18] (03CR) 10Reedy: "var_dump( $srcWidth, $srcHeight, $wgTiffIntermediaryScaleStep, $rx );" [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135289 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [18:13:51] 3MediaWiki / 3MediaWiki UI: Buttons have text of same colour when focused - 10https://bugzilla.wikimedia.org/70801#c4 (10Shahyar Ghobadpour) Resolved by https://gerrit.wikimedia.org/r/#/c/123804/ (Note: I don't appear to have permission to modify this bug.) [18:14:03] (03PS2) 10Physikerwelt: Make Mathoid role configurable via hiera [vagrant] - 10https://gerrit.wikimedia.org/r/160694 [18:14:50] (03CR) 10Legoktm: [C: 032] Make Special:CentralAuth list local accounts in all cases [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/160526 (https://bugzilla.wikimedia.org/53919) (owner: 10Hoo man) [18:14:57] (03CR) 10SG: "Those regressions should be fixed." [core] - 10https://gerrit.wikimedia.org/r/155856 (https://bugzilla.wikimedia.org/69212) (owner: 10SG) [18:15:00] (03PS6) 10Matthias Mullie: Revert "Revert "Introduce flowSpawnedBy handler to forward events from outside of FlowComponent"" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160675 [18:15:18] (03CR) 10Matthias Mullie: [C: 032] Revert "Revert "Introduce flowSpawnedBy handler to forward events from outside of FlowComponent"" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160675 (owner: 10Matthias Mullie) [18:15:21] (03PS13) 10SG: Change mw-ui anchors to require mw-ui-anchor base class [core] - 10https://gerrit.wikimedia.org/r/155856 (https://bugzilla.wikimedia.org/69212) [18:15:31] (03Merged) 10jenkins-bot: Make Special:CentralAuth list local accounts in all cases [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/160526 (https://bugzilla.wikimedia.org/53919) (owner: 10Hoo man) [18:15:50] (03PS1) 10Yurik: JsonConfig,ZeroBanner,ZeroPortal to master [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161006 [18:15:56] (03Merged) 10jenkins-bot: Revert "Revert "Introduce flowSpawnedBy handler to forward events from outside of FlowComponent"" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160675 (owner: 10Matthias Mullie) [18:16:08] (03PS6) 10SG: Implement mw-ui-modal and remove jquery.ui usage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160612 [18:16:20] (03PS3) 10SG: Clean up watchlist icon markup and CSS [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155214 [18:16:35] gwicke: Cool. Just let me know which you want to run on 0.10 and I'll make it happen [18:16:37] OK RoanKattouw, FYI the patch I'm working on is https://gerrit.wikimedia.org/r/160814 and basically I'm having trouble because I think the choose event isn't firing when my InlineMenuWidget is changed [18:16:40] gwicke: Also https://gerrit.wikimedia.org/r/#/c/160589/ [18:16:47] Much grrrit-wm [18:16:51] The IMW in question is for the download size selection dropdown [18:17:01] Lcawte: Very bot. Wow. [18:17:23] 3MediaWiki extensions / 3CentralAuth: Show always unattached account on Special:CentralAuth - 10https://bugzilla.wikimedia.org/53898 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3Marius Hoch [18:17:24] 3MediaWiki extensions / 3CentralAuth: Show editcount for unattached accounts on Special:CentralAuth - 10https://bugzilla.wikimedia.org/53919 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3Marius Hoch [18:17:25] (03PS1) 10Yurik: JsonConfig,ZeroBanner,ZeroPortal to master [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/161007 [18:18:02] Krinkle: nice! that looks like it'll test both [18:18:06] 3MediaWiki extensions / 3CentralAuth: Some enhancements for the CentralAuth GUI (that sulutil/stalktoy/others have) (tracking) - 10https://bugzilla.wikimedia.org/23391#c6 (10Kunal Mehta (Legoktm)) 5REOP>3RESO/FIX Special:CentralAuth should now be at feature parity with sulutil. [18:18:36] Krinkle: let me check the job names [18:18:40] gwicke: Yeah, but that[s the wrong job. that's not the job you want I think [18:18:49] *nod* [18:19:36] Krinkle: the normal parsertests run is called parsoidsvc-parsertests-run-harder [18:19:50] (03PS18) 10Lewis Cawte: New class for parsing MediaWiki:Sidebar-like messages into modern, nested navigation menus. [core] - 10https://gerrit.wikimedia.org/r/108045 (owner: 10Jack Phoenix) [18:20:59] (03PS9) 10Umherirrender: Add better error message for files which exceeds $wgMaxImageArea [core] - 10https://gerrit.wikimedia.org/r/142046 [18:21:12] (03CR) 10Lewis Cawte: "Patchset 17 - rebase, patchset 18 - clean up some issues pointed out by the phpcs-strict test." [core] - 10https://gerrit.wikimedia.org/r/108045 (owner: 10Jack Phoenix) [18:21:23] (03CR) 10Umherirrender: "Patch Set 9: Rebased" [core] - 10https://gerrit.wikimedia.org/r/142046 (owner: 10Umherirrender) [18:21:50] marktraceur: In which file is that dropdown created? [18:22:28] (03CR) 10Legoktm: "18:11:13 Could not open input file: maintenance/install.php" [extensions/MassMessage] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161002 (owner: 10Reedy) [18:22:35] (03CR) 10Legoktm: "recheck" [extensions/MassMessage] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161002 (owner: 10Reedy) [18:23:25] RoanKattouw: In resources/mmv/ui/mmv.ui.download.pane.js [18:23:28] AFAIK. [18:23:39] And the styling is in mmv.ui.download.pane.less [18:24:47] https://gerrit.wikimedia.org/r/#/c/108045/18 https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs-strict-HEAD/15424/console ... so line 174 is fixable by splitting the comment onto two lines, but line 29, I'm guessing it'll never pass phpcs-strict ? [18:24:52] marktraceur: On a side note, DYK that $.proxy( download.handleSizeSwitch, download ); and function ( item ) { download.handleSizeSwitch( item ); } are equivalent? [18:24:56] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (24ac83a472) [core] - 10https://gerrit.wikimedia.org/r/161009 [18:24:59] Krinkle: asked cscott to have a look as well -- he is more up to date on the parsoid jobs [18:26:07] (03CR) 10jenkins-bot: [V: 04-1] Tighter query for images. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/152085 (owner: 10Cscott) [18:26:23] (03CR) 10Yurik: [C: 032] JsonConfig,ZeroBanner,ZeroPortal to master [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161006 (owner: 10Yurik) [18:26:36] 3MediaWiki / 3Interface: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277#c60 (10Dan Andreescu) I ran the query again for September 16th, but I got some fairly detailed URLs that I'm not sure I should post. I'm checking with some... [18:26:40] RoanKattouw: Yeah, I switched it to stick a console.log line in the callback directly [18:26:40] (03CR) 10Reedy: Make tiff thumbnail in 2 steps. (031 comment) [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135289 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [18:26:46] (03CR) 10Yurik: [C: 032] JsonConfig,ZeroBanner,ZeroPortal to master [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/161007 (owner: 10Yurik) [18:27:02] And I also hate using jquery for things that aren't DOM-modifications. [18:27:14] Oh, right [18:27:20] (03CR) 10Matthias Mullie: [C: 031] "Tested and works as advertised!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160612 (owner: 10SG) [18:27:30] Yeah we tend to use OO.ui.bind(), which to be fair is just $.proxy as well [18:27:41] In VE we use the native .bind() but that's not available in older browsers [18:28:16] (03CR) 10Lewis Cawte: "recheck" [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/155010 (owner: 10Jack Phoenix) [18:29:06] 3MediaWiki extensions / 3Collection: Animated gifs (eg, [[Comet]]) confuse the new PDF renderer - 10https://bugzilla.wikimedia.org/70865#c1 (10C. Scott Ananian) These don't lead to crashes (I don't think), but the converted filenames are foo-0.png, foo-1.png, foo-2.png (etc) instead of foo.png, which causes... [18:29:32] (03Merged) 10jenkins-bot: JsonConfig,ZeroBanner,ZeroPortal to master [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161006 (owner: 10Yurik) [18:29:38] (03Merged) 10jenkins-bot: JsonConfig,ZeroBanner,ZeroPortal to master [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/161007 (owner: 10Yurik) [18:29:38] 3Wikimedia / 3Bugzilla: Remove yuvipanda from default cc for bugs in Wikipedia Apps product - 10https://bugzilla.wikimedia.org/70949 (10Yuvi Panda) 3NEW p:3Unprio s:3normal a:3None Since I'm transitioning off the team. [18:29:59] (03PS5) 10Reedy: Make tiff thumbnail in 2 steps. [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135289 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [18:30:09] marktraceur: RoanKattouw: If your project loads es5-shim though, you can use it. I think one of the multimedia projects does that, not sure if this one does [18:30:19] (03PS1) 10Aaron Schulz: Doc typo fixes [core] - 10https://gerrit.wikimedia.org/r/161011 [18:30:29] Pretty sure it's MMV, yeah. [18:30:45] But I'm pretty sure that's not the issue, because I don't think the choose callback is fired in any case. [18:31:26] Yeah I'm setting MMV up locally so I can reproduce the bug [18:31:57] Cool. [18:32:04] I'm going to do slightly early lunchtime, brb [18:32:20] (this only involves walking across the kitchen to create peanut butter sandwich) [18:32:25] (03CR) 10Reedy: [C: 04-1] "So the tests now pass, but AFAIK, based on the test images we actually have currently, not are going to be 2 step thumbnails." [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135289 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [18:35:03] (03PS1) 10Reedy: Fixup whitespace in tests/ShowMetadata.php [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/161014 [18:35:11] marktraceur: Uhm, so 1) how do I get to this download button? Is it only for local images? 2) I used MMV on a Commons image and upon closing I got infinite recursion in DP.unattach so now my screen stays black [18:36:22] Oh I found it, except for InstantCommons images it seems to be totally broken because it's populating both options with   [18:36:33] (03PS19) 10Lewis Cawte: New class for parsing MediaWiki:Sidebar-like messages into modern, nested navigation menus. [core] - 10https://gerrit.wikimedia.org/r/108045 (owner: 10Jack Phoenix) [18:36:37] 3MediaWiki / 3User login and signup: Login as another user no longer works - 10https://bugzilla.wikimedia.org/70855#c13 (10Jon) *** Bug 69475 has been marked as a duplicate of this bug. *** [18:37:05] RoanKattouw: But you see the choose event fired? Weird. [18:37:08] Or is that a different dropdown thing... I don't know [18:37:12] (03PS4) 10Arlolra: Accept papersize setting from metabook [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/160237 (https://bugzilla.wikimedia.org/68836) [18:37:13] No I haven't even found the widget yet [18:37:15] Where is it? [18:37:28] RoanKattouw: There's a download icon in the canvas, it looks like a an arrow pointing at a line [18:37:34] Yeah I clicked that [18:37:44] Then I see what's trying to be a green button with a green dropdown icon next to it [18:37:48] Right. [18:37:50] Except all the labels are empty strings so it's broken [18:37:51] That's the issue [18:37:58] RoanKattouw: Is that it? Hm. [18:38:17] Oh here's the inlineMenuWidget [18:38:22] Oh, herp, I didn't add the messages to the module [18:38:22] It has 0 height [18:38:36] But I still don't see the choose event, so... [18:38:57] Oh it's display: none [18:39:00] (I actually *did* add the messages, so not sure what's happening [18:39:02] Ohhhh [18:39:12] Well how do I get a choose event if I can't even *see* the widget let alone interact with it? [18:39:43] RoanKattouw: A choose event should get fired because we call chooseItem() manually on the default option [18:39:46] Even when I do make it visible, the styling looks terribly broken [18:40:14] (03CR) 10Arlolra: [C: 032] Convert TIFF images to PNG. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/161003 (https://bugzilla.wikimedia.org/70866) (owner: 10Cscott) [18:40:24] Yes, that should emit a 'choose' event [18:40:34] But no dice [18:40:43] Enter my confusion [18:41:04] (03Merged) 10jenkins-bot: Convert TIFF images to PNG. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/161003 (https://bugzilla.wikimedia.org/70866) (owner: 10Cscott) [18:41:23] Looking [18:41:24] BTW: [18:41:26] WHOOOAAAA this.constructor['super'].prototype.unattach.call( this ); [18:41:34] You absolutely cannot do that [18:41:37] Oh? [18:41:41] Think about it [18:41:45] this.constructor isn't the current class [18:41:50] It's the class that this is part of [18:41:53] Ah. [18:42:03] If this is a subclass of the current class, then this.constructor.super is the current class [18:42:10] And this.constructor.super.prototype.unattach is the current method [18:42:12] So it'll get called over and over again [18:42:18] Which is why I'm getting infinite recursion trying to close MMV [18:42:50] That probably explains the black screen of death. OK, will fix those [18:43:05] It's really sad that it doesn't work that way, and it's so tempting that we've made this mistake several times over [18:43:35] marktraceur: So tell me about DP.set() and DP.attach()? When do you call which, and in what order? [18:44:08] Sorry that's Pane.prototype.set and .attach [18:44:25] RoanKattouw: .set() gets called when we get image information from the API; if the pane isn't loaded then it happens whenever we load the module and construct the object [18:44:39] .attach() happens whenever someone loads the viewer [18:45:37] (03CR) 10Dduvall: [C: 04-1] "Hmm... I wasn't sure how to repro the behavior that you're seeing but setting mode 0500 on one of the directories still results in an exce" (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/160910 (owner: 10BryanDavis) [18:46:24] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch needs to provide a way to find hyphenated words, as Lucene-search always has - 10https://bugzilla.wikimedia.org/70950 (10SpontaneousGrumbler) 3UNCO p:3Unprio s:3major a:3None Before CirrusSearch can be considered a replacement for Lucene-search (not... [18:46:43] OK well .attach() is never called on the download pane [18:47:13] And that's where the event is bound [18:47:45] Oh, hm [18:47:52] Maybe it needs to be called when the thing is loaded [18:47:56] I'll look into that then [18:48:00] RoanKattouw: Thanks for the help [18:48:42] Oh wow, there it is. :) [18:50:19] (03PS1) 10Prtksxna: inputs.less: Use .mw-ui-input-inline for type="number" [core] - 10https://gerrit.wikimedia.org/r/161016 [18:52:27] (03PS2) 10Prtksxna: inputs.less: Use .mw-ui-input-inline for type="number" [core] - 10https://gerrit.wikimedia.org/r/161016 (https://bugzilla.wikimedia.org/70404) [18:54:24] (03PS11) 10Jdlrobson: Add mw-ui-icon [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) [18:55:58] (03PS2) 10Jsahleen: Display better error message for MT processing [services/cxserver] - 10https://gerrit.wikimedia.org/r/160982 (owner: 10KartikMistry) [18:59:15] (03CR) 10Ragesoss: [C: 031] "Looks good, and tested working locally." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/160901 (https://bugzilla.wikimedia.org/70748) (owner: 10AndyRussG) [19:00:53] 3Wikimedia / 3Bugzilla: Add component for Wikimedia Labs --> "extdist" - 10https://bugzilla.wikimedia.org/70951 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None Description: Issues relating to extdist.wmflabs.org Default CC: myself and YuviPanda Thanks! [19:01:29] (03PS3) 10Jsahleen: Display better error message for MT processing and other errors. [services/cxserver] - 10https://gerrit.wikimedia.org/r/160982 (owner: 10KartikMistry) [19:04:04] (03CR) 10Jsahleen: [C: 032] "Kartik's patch was implicitly converting the error to a string. The new patch does the same thing explicitly and uses the Winston logging " [services/cxserver] - 10https://gerrit.wikimedia.org/r/160982 (owner: 10KartikMistry) [19:04:33] (03Merged) 10jenkins-bot: Display better error message for MT processing and other errors. [services/cxserver] - 10https://gerrit.wikimedia.org/r/160982 (owner: 10KartikMistry) [19:05:16] (03CR) 10BryanDavis: "For repro of the problem I hit, you could delete the files/directories yourself before running destroy. In my particular case I messed up " [vagrant] - 10https://gerrit.wikimedia.org/r/160910 (owner: 10BryanDavis) [19:06:00] (03CR) 10Lewis Cawte: "Shouldn't this be added to the release notes?" [core] - 10https://gerrit.wikimedia.org/r/154843 (owner: 10Legoktm) [19:07:12] (03CR) 10Legoktm: "Yes, I usually do it after merge so I don't have to worry about rebasing and annoying things." [core] - 10https://gerrit.wikimedia.org/r/154843 (owner: 10Legoktm) [19:08:27] (03PS1) 10Manybubbles: Support strings in namespace weights [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/161020 (https://bugzilla.wikimedia.org/69771) [19:08:59] (03CR) 10Foxtrott: "Is there a particular reason for the result to be a flat array instead of an array of arrays?" [core] - 10https://gerrit.wikimedia.org/r/108045 (owner: 10Jack Phoenix) [19:09:52] 3Wikimedia / 3General/Unknown: Firefox search bar not using Secure search - 10https://bugzilla.wikimedia.org/45765#c18 (10Andre Klapper) Will be fixed in Firefox 35: https://hg.mozilla.org/mozilla-central/rev/612fedcc26e1 (maybe earlier, depends on the flags Mozilla devs set) [19:14:21] 3Wikimedia / 3Site requests: English Wikisource: Tweak to search results elevating weighting for a specific namespace - 10https://bugzilla.wikimedia.org/69771#c4 (10Nik Everett) 5PATC>3RESO/FIX Uploaded two patches - one to support configuring namespace weights by name rather than number and one to actu... [19:15:29] (03CR) 10Dduvall: [C: 04-1] "There's some unnecessary duplication here as an `api` method is provided by mediawiki_selenium since 0.3.0. [1] You could make use of it i" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/160988 (owner: 10Manybubbles) [19:17:21] (03CR) 10Krinkle: "FIXME: All the files in assets/ from this and other commits can and should be moved to a proper ResourceLoader module. The only one that c" [core] - 10https://gerrit.wikimedia.org/r/158648 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [19:21:37] MatmaRex: Can we fix these icons the proper way before 1.25? Creating a new directory requiring site admins to do maintenance for a directory containing only legacy resources seems a waste of time and effort. I'm convinved that by design this directory can only ever contain deprecated or legacy files that are either to be removed or converted to a proper stylesheet for the skin or software. I've gone [19:21:38] through the files in there currently @master and the files currently left in skins/common. They're all deprecated or easily converted to modules. [19:21:55] I'd strongly recommend reverting (if no time) to skins/common or fixing. I don't want assets/ in the 1.25 release. [19:22:13] Krinkle: i wanted to make it resources/assets/, which would avoid these problems [19:22:37] It doesn't need a separate directory. [19:23:08] Krinkle: making these RL modules with images embedded in CSS is a tedious exercise that it pointless at best and harmful at worst [19:23:15] But if we don't have the time to write a few stylesheets and change html output classes before 1.25, and if we do need skins/ to be empty (not even symlinks) before 1.25, then we can do resources/assets, no problem. [19:23:56] but if skins/ can remain non-empty for 1.25, just move 'em back. It's just moving around deprecated or legacy stuff which doesn't improve anything it just moves todo items around. [19:24:07] 3MediaWiki extensions / 3Translate: Conflict of Special:MyLanguage: Extension and MW core use the same special page name - 10https://bugzilla.wikimedia.org/69461#c4 (10Niklas Laxström) 5NEW>3ASSI a:3Amir E. Aharoni Included in current language engineering team sprint. [19:24:10] or ideally, convert to css, but that might take more time. [19:24:13] i think james and someone else complained about resources/ being for RL resources and not random junk [19:25:10] (03CR) 10Robmoen: "This is a BREAKING CHANGE in ie8." [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG) [19:25:13] Krinkle: the HTML for these is generally output by skins, which makes upgrading hard or impossible [19:25:41] I agree. But I'm more than willing to excempt that but if and only if there is a goal that for 1.25 skins/ *must* be empty. If that is not true and the symlinks remain, then we can just move 'em back. and keep them there until we fix them 'right' way. [19:25:55] Krinkle: as for file type icons, they are used somewhere deep in PHP file handlers code and i'm not going to dig into that; besides, we'd need to create 27 RL modules, or one RL module incuding 27 icons while only using one [19:25:56] agree with not using resources/ for non RL, but &^ [19:26:11] MatmaRex: one stylesheet using 27 icons is fine. [19:26:15] Krinkle: do you mean 1.25 or 1.24? [19:26:24] legoktm: The one cut soon [19:26:25] that's 1.24 [19:26:39] ok. [19:26:50] Krinkle: not "must", but "should" if you ask me. keeping skins/common/ is just cumbersome for everyone [19:26:58] Whatever the case having a new /assets is imho clearly unjustified and not needed. It's overhead and breaking with no improvement. It moves around deprecated or legacy files we haven't yet converted. [19:27:19] Krinkle: Krinkle: the HTML for these is generally output by skins, which makes upgrading hard or impossible [19:27:22] Yes, but that cumbersome is a boolean state. Having more or less files in it makes no difference from admin and dev point of view [19:27:56] or to put it differently, i'm not going to work on that anytime soon, since i believe it'd be a waste of effort [19:27:58] We will eventually get rid of them into a stylesheet. If we do that now, great. If we don't do that now, keep it in skins/. [19:28:05] If we can't have skins/, move 'em to resources/assets. [19:28:05] i converted the ones that were worth it for me [19:28:43] okay. later [19:28:48] or do it and i'll +2 [19:29:59] MatmaRex: Well, assets/ is going to break production and already broke beta I understand. I don't want them to waste effort on supporting assets/. I'll see what I can do but I may have to revert. [19:30:21] Which, if the commits were clean, would be the same as moving, right? [19:30:32] oh ugh, we're branch-cutting tomorrow [19:30:49] blergh [19:30:52] okay, let's do this. [19:30:56] * MatmaRex git stashes [19:30:59] (03PS1) 10Gergő Tisza: Fix EventLogging schema declarations [extensions/UploadWizard] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161026 [19:31:36] (03PS1) 10Gergő Tisza: Fix EventLogging schema declarations [extensions/UploadWizard] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/161027 [19:31:48] (03PS1) 10Robmoen: Revert "mw-ui-button: Revamp the LESS to be simpler, and improve cross-browser support" [core] - 10https://gerrit.wikimedia.org/r/161028 [19:32:16] (03CR) 10jenkins-bot: [V: 04-1] Revert "mw-ui-button: Revamp the LESS to be simpler, and improve cross-browser support" [core] - 10https://gerrit.wikimedia.org/r/161028 (owner: 10Robmoen) [19:34:18] (03CR) 10jenkins-bot: [V: 04-1] Fix EventLogging schema declarations [extensions/UploadWizard] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161026 (owner: 10Gergő Tisza) [19:34:21] (03CR) 10jenkins-bot: [V: 04-1] Fix EventLogging schema declarations [extensions/UploadWizard] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/161027 (owner: 10Gergő Tisza) [19:34:36] pity you didn't comment on it earlier, now i'll have fun rechecking all of the extensions i fixed [19:35:39] YuviPanda: Hm.. are you sure about the cpu values? I always get confused because they're not a total of 'usage' [19:35:46] YuviPanda: Should we sum .user and .system? [19:35:58] or use a under=>true measure for .idle? [19:36:00] Krinkle: so... we should, but I'm atm a bit lazy to figure out how to do that properly :) [19:36:03] (03CR) 10Gergő Tisza: [C: 032 V: 032] "Error caused by tests not existing in this branch" [extensions/UploadWizard] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/161027 (owner: 10Gergő Tisza) [19:36:14] Krinkle: ah, under => true for idle doesn't seem like a bad solution, actually [19:36:14] YuviPanda: What does ganglia/incinga do? [19:36:23] (03CR) 10Gergő Tisza: [C: 032 V: 032] "Error caused by tests not existing in this branch" [extensions/UploadWizard] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161026 (owner: 10Gergő Tisza) [19:36:36] Krinkle: I think they check load, rather than CPU? [19:36:45] Krinkle: but we don't have core-normalized load values yet, so that's a bit effy [19:37:34] YuviPanda: http://ganglia.wikimedia.org/latest/graph_all_periods.php?h=gallium.wikimedia.org&m=cpu_report&c=Miscellaneous%20eqiad [19:37:44] they add user+nice+system+wait [19:38:15] (03PS4) 10Mitar: Allow adding custom parameters to the callback for OAuth. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/153983 [19:38:39] Krinkle: right [19:38:47] I have no idea where .irq, .softirq, gues and gues_nice factor in [19:38:51] and .steal [19:39:03] Krinkle: so we could do that (graphite has summing functions) [19:39:07] I hope idle is the reverse total of all, or maybe irq, gues and steal are on top of that? [19:39:10] Krinkle: I can get to it in the next few days (have to sign off soon) [19:39:19] Krinkle: I think idle is the reverse total, but unsure [19:39:26] YuviPanda: Cook. I'll submit a patch for idle under [19:39:29] cool* [19:39:45] and ask ops about how cpu measures work so you can do the sum() later [19:40:08] (03PS1) 10Bartosz Dziewoński: Move assets/ to resources/assets/ [core] - 10https://gerrit.wikimedia.org/r/161030 [19:40:10] 3MediaWiki / 3Special pages: Special:Version: Link to tree instead of commit for git hashes - 10https://bugzilla.wikimedia.org/39994#c8 (10Lewis Cawte) Can this be closed now? [19:40:16] Krinkle: https://gerrit.wikimedia.org/r/161030 , did not test [19:40:26] Krinkle: cool [19:40:38] (03CR) 10Bartosz Dziewoński: "https://gerrit.wikimedia.org/r/161030" [core] - 10https://gerrit.wikimedia.org/r/158648 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [19:41:02] (03CR) 10Bartosz Dziewoński: "DID NOT TEST." [core] - 10https://gerrit.wikimedia.org/r/161030 (owner: 10Bartosz Dziewoński) [19:41:42] (03CR) 10Bartosz Dziewoński: "After this is merged, a few extensions which I already fixed will need fixing again." [core] - 10https://gerrit.wikimedia.org/r/161030 (owner: 10Bartosz Dziewoński) [19:41:55] (03CR) 10jenkins-bot: [V: 04-1] Allow adding custom parameters to the callback for OAuth. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/153983 (owner: 10Mitar) [19:42:47] (03PS1) 1001tonythomas: Added GENDER suport for log messages [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/161032 (https://bugzilla.wikimedia.org/70836) [19:43:20] (03PS5) 10Mitar: Allow adding custom parameters to the callback for OAuth. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/153983 [19:45:14] (03CR) 10Mitar: "I updated the patch with the checkbox. I noticed some issues with SQLite query for adding the column you used in the in the other changese" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/153983 (owner: 10Mitar) [19:45:40] (03CR) 10Krinkle: "Hm.. while DefaultSettings doesn't document it right now, I guess we should use $wgResourceBasePath/resources for this. Similar to $wgStyl" [core] - 10https://gerrit.wikimedia.org/r/161030 (owner: 10Bartosz Dziewoński) [19:46:47] (03CR) 10Bartosz Dziewoński: "Feel free to amend." [core] - 10https://gerrit.wikimedia.org/r/161030 (owner: 10Bartosz Dziewoński) [19:53:08] 3Wikimedia / 3Site requests: Account creation for GLAM event - 10https://bugzilla.wikimedia.org/70953 (10khenningsen) 3UNCO p:3Unprio s:3normal a:3None I would like to request a lift of the account creation limit for a GLAM Edit-a-thon. Event time: Saturday, 9/20/2014, 2:00 p.m. - 4:00 p.m. local ti... [19:54:58] (03PS5) 10Anomie: API: HTMLize and internationalize the help, add Special:ApiHelp [core] - 10https://gerrit.wikimedia.org/r/160798 (https://bugzilla.wikimedia.org/30936) [19:55:24] 3MediaWiki-Vagrant / 3labs-vagrant: vagrant parsoid PHP path warning - 10https://bugzilla.wikimedia.org/70955 (10spage) 3NEW p:3Unprio s:3normal a:3None On flow-tests labs instance I updated git of /vagrant , /vagrant/mediawiki, and all my extensions, then ran `sudo labs provision` That fails in Med... [19:55:46] (03PS1) 10Alex Monk: Fill the iw_api column of the interwiki table when installing [core] - 10https://gerrit.wikimedia.org/r/161034 (https://bugzilla.wikimedia.org/46992) [19:56:36] (03CR) 10jenkins-bot: [V: 04-1] Fill the iw_api column of the interwiki table when installing [core] - 10https://gerrit.wikimedia.org/r/161034 (https://bugzilla.wikimedia.org/46992) (owner: 10Alex Monk) [19:57:24] (03CR) 10Anomie: "PS5: Move 'uselang' to ApiMain (I04b1a3842 needs it), and extract the code to convert Special:ApiHelp/foo links to api.php?action=help&mod" [core] - 10https://gerrit.wikimedia.org/r/160798 (https://bugzilla.wikimedia.org/30936) (owner: 10Anomie) [19:58:20] 3Wikimedia / 3Site requests: Account creation for GLAM event - 10https://bugzilla.wikimedia.org/70953#c1 (10Steinsplitter) 5UNCO>3RESO/WON Please request the flag on your wiki, in this case enwiki (can by assigned by crats): https://en.wikipedia.org/wiki/Wikipedia:Account_creator [20:00:10] ^ uh [20:00:16] Have we stopped lifting throttles for events? [20:01:21] 3Wikimedia / 3Site requests: Account creation for GLAM event - 10https://bugzilla.wikimedia.org/70953 (10John F. Lewis) p:5Unprio>3Normal [20:01:22] 3Wikimedia / 3Site requests: Account creation for GLAM event - 10https://bugzilla.wikimedia.org/70953#c2 (10John F. Lewis) Or as an alternative, direct users to ACC and we'll handle them. [20:01:32] (03PS3) 10EBernhardson: Remove special Watchlist star handling on Flow boards [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159756 (owner: 10Matthias Mullie) [20:02:04] (03PS2) 10Alex Monk: Fill the iw_api column of the interwiki table when installing [core] - 10https://gerrit.wikimedia.org/r/161034 (https://bugzilla.wikimedia.org/46992) [20:02:53] (03CR) 10jenkins-bot: [V: 04-1] Fill the iw_api column of the interwiki table when installing [core] - 10https://gerrit.wikimedia.org/r/161034 (https://bugzilla.wikimedia.org/46992) (owner: 10Alex Monk) [20:03:39] (03CR) 10Mattflaschen: "It's not okay to self-merge a patch this big and with this wide an impact." [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG) [20:03:46] (03CR) 10EBernhardson: "PS3: To address jon's concerns i've adjusted this so it still uses mw.notification as it normally would, we just replace the content of th" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159756 (owner: 10Matthias Mullie) [20:03:49] (03CR) 10Wikinaut: [C: 04-1] Added GENDER suport for log messages (031 comment) [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/161032 (https://bugzilla.wikimedia.org/70836) (owner: 1001tonythomas) [20:04:09] (03PS1) 10Gergő Tisza: Update UploadWizard submodule [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/161035 [20:05:22] 3Wikimedia / 3Site requests: Account creation for GLAM event - 10https://bugzilla.wikimedia.org/70953#c3 (10Sam Reed (reedy)) (In reply to khenningsen from comment #0) > I would like to request a lift of the account creation limit for a GLAM > Edit-a-thon. > > Event time: Saturday, 9/20/2014, 2:00 p.m. - 4:... [20:05:52] (03CR) 10EBernhardson: Hygiene: Move SpecialFlow.php into includes/ (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160917 (owner: 10EBernhardson) [20:06:01] (03CR) 10Ori.livneh: "I think we failed as reviewers too, so piling on on SG doesn't make sense." [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG) [20:06:39] (03PS1) 10Spage: Fix Parsoid.php entrypoint [vagrant] - 10https://gerrit.wikimedia.org/r/161036 (https://bugzilla.wikimedia.org/70955) [20:07:45] (03CR) 10Jdlrobson: "I'd recommend breaking this up into a few patches." [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG) [20:07:51] (03PS2) 10BryanDavis: Fix Parsoid.php entrypoint [vagrant] - 10https://gerrit.wikimedia.org/r/161036 (https://bugzilla.wikimedia.org/70955) (owner: 10Spage) [20:08:07] 3MediaWiki / 3General/Unknown: Gallery element renders image height and width inconsistently - 10https://bugzilla.wikimedia.org/70926#c3 (10Jared Zimmerman (WMF)) doesn't *feel* like a feature, especially when you resize you browser and you see things lot line up. [20:08:07] (03CR) 10BryanDavis: [C: 032] "Thanks S!" [vagrant] - 10https://gerrit.wikimedia.org/r/161036 (https://bugzilla.wikimedia.org/70955) (owner: 10Spage) [20:08:12] (03Merged) 10jenkins-bot: Fix Parsoid.php entrypoint [vagrant] - 10https://gerrit.wikimedia.org/r/161036 (https://bugzilla.wikimedia.org/70955) (owner: 10Spage) [20:09:35] (03PS3) 10Alex Monk: Fill the iw_api column of the interwiki table when installing [core] - 10https://gerrit.wikimedia.org/r/161034 (https://bugzilla.wikimedia.org/46992) [20:10:23] (03PS1) 10Gergő Tisza: Update UploadWizard submodule [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161037 [20:11:30] (03CR) 10Jdlrobson: [C: 04-1] inputs.less: Use .mw-ui-input-inline for type="number" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/161016 (https://bugzilla.wikimedia.org/70404) (owner: 10Prtksxna) [20:12:21] 3Wikimedia / 3Site requests: Account creation for GLAM event - 10https://bugzilla.wikimedia.org/70953#c4 (10jeremyb) 5RESO/WON>3REOP (In reply to Sam Reed (reedy) from comment #3) > Are we not using server side throttle lifting anymore? I believe we are? And this one is even a few days in advance (bette... [20:12:36] 3Wikimedia / 3Site requests: Account creation for GLAM event - 10https://bugzilla.wikimedia.org/70953 (10jeremyb) 5REOP>3NEW [20:13:28] (03PS14) 10Jdlrobson: Fix styling of deletion page when $wgUseMediaWikiUIEverywhere enabled [core] - 10https://gerrit.wikimedia.org/r/154121 (https://bugzilla.wikimedia.org/70134) [20:13:54] 3Wikimedia / 3Bugzilla: Remove yuvipanda from default cc for bugs in Wikipedia Apps product - 10https://bugzilla.wikimedia.org/70949#c1 (10Andre Klapper) 5NEW>3RESO/FIX a:3Andre Klapper Done. Note that you're also CC on most components under "Commons App" and "Wiki Loves Monuments > Mobile" when it c... [20:14:12] (03PS2) 10Jdlrobson: Add a hook to allow extensions to prevent HTML file caching [core] - 10https://gerrit.wikimedia.org/r/160563 (https://bugzilla.wikimedia.org/68106) (owner: 10MaxSem) [20:15:05] (03PS1) 10Mattflaschen: Revert buggy MediaWiki UI change and dependent changes [core] - 10https://gerrit.wikimedia.org/r/161038 [20:17:11] 3Wikimedia / 3Bugzilla: Add component for Wikimedia Labs --> "extdist" - 10https://bugzilla.wikimedia.org/70951#c1 (10Andre Klapper) 5NEW>3RESO/FIX a:3Andre Klapper Done [20:17:26] (03CR) 10Mattflaschen: "Reverted in https://gerrit.wikimedia.org/r/#/c/161038/ (this reverts two further patches in the same directory as well)" [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG) [20:17:58] (03CR) 10Mattflaschen: "Replaced with https://gerrit.wikimedia.org/r/#/c/161038/" [core] - 10https://gerrit.wikimedia.org/r/161028 (owner: 10Robmoen) [20:18:33] (03PS2) 10EBernhardson: Hygiene: Move SpecialFlow.php into includes/ [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160917 [20:18:45] (03PS1) 10Manybubbles: Add error messages for pool queue full [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/161039 [20:20:08] 3MediaWiki / 3Installer: Fill the iw_api column of the interwiki table - 10https://bugzilla.wikimedia.org/46992 (10Alex Monk) a:3Alex Monk [20:20:26] 3Wikimedia / 3General/Unknown: OpenHistoricalMap & Wikimaps - 10https://bugzilla.wikimedia.org/62257#c11 (10JaimeLyn) My apologies for the delay, @qgil. Everything I put on hold over the summer to work on OPW came crashing down around me this month. Such is life! My wrap-up blog post: http://jaimelynschatz.... [20:24:24] (03CR) 10Robmoen: [C: 031] "Confirmed fix. Tested in class A browsers and ie8 and above." [core] - 10https://gerrit.wikimedia.org/r/161038 (owner: 10Mattflaschen) [20:25:10] (03Abandoned) 10Robmoen: Revert "mw-ui-button: Revamp the LESS to be simpler, and improve cross-browser support" [core] - 10https://gerrit.wikimedia.org/r/161028 (owner: 10Robmoen) [20:28:14] 3MediaWiki / 3API: OpenSearch should check if input exists as a title and return that, regardless of results - 10https://bugzilla.wikimedia.org/70958 (10James Forrester) 3NEW p:3Unprio s:3normal a:3Krinkle Currently it is possible for OpenSearch to fail to return the input in its results even if the... [20:28:44] (03PS3) 10Prtksxna: inputs.less: Use .mw-ui-input-inline for type="number" [core] - 10https://gerrit.wikimedia.org/r/161016 (https://bugzilla.wikimedia.org/70404) [20:28:52] 3MediaWiki / 3API: OpenSearch should check if input exists as a title and return that, regardless of results - 10https://bugzilla.wikimedia.org/70958 (10James Forrester) p:5Unprio>3High s:5normal>3enhanc [20:30:08] (03PS4) 10Prtksxna: inputs.less: Use .mw-ui-input-inline for type="number" [core] - 10https://gerrit.wikimedia.org/r/161016 (https://bugzilla.wikimedia.org/70404) [20:30:41] (03CR) 10Theaitetos: [C: 032 V: 031] Don't check for Template:Extension_DPL during update [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/159658 (owner: 10MarkAHershberger) [20:30:43] (03CR) 10Prtksxna: inputs.less: Use .mw-ui-input-inline for type="number" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/161016 (https://bugzilla.wikimedia.org/70404) (owner: 10Prtksxna) [20:32:03] (03PS2) 10Mattflaschen: Revert buggy MediaWiki UI change and dependent changes [core] - 10https://gerrit.wikimedia.org/r/161038 [20:32:09] 3MediaWiki-Vagrant / 3labs-vagrant: labs-vagrant provision failing in Mediawiki::Import_dump[labs_privacy]/Exec[import_dump_ labs_privacy] - 10https://bugzilla.wikimedia.org/70959 (10spage) 3NEW p:3Unprio s:3normal a:3None When I run `sudo labs-vagrant provision` on flow-tests labs instance, it repor... [20:32:57] (03Merged) 10jenkins-bot: Don't check for Template:Extension_DPL during update [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/159658 (owner: 10MarkAHershberger) [20:33:06] 3MediaWiki extensions / 3OAuth: OAuth should be autoblock-exempt / "IP address had been blocked automatically" in croptool - 10https://bugzilla.wikimedia.org/66639#c8 (10Chris Steipp) (In reply to Rainer Rillke @commons.wikimedia from comment #7) > I get a permission error when trying to access the cited pag... [20:36:34] (03CR) 10Aaron Schulz: [C: 032] Doc typo fixes [core] - 10https://gerrit.wikimedia.org/r/161011 (owner: 10Aaron Schulz) [20:43:11] (03Merged) 10jenkins-bot: Doc typo fixes [core] - 10https://gerrit.wikimedia.org/r/161011 (owner: 10Aaron Schulz) [20:43:58] (03PS1) 10SG: Add IE conditional classes to HTML tag [core] - 10https://gerrit.wikimedia.org/r/161051 [20:44:58] (03CR) 10Jdlrobson: [C: 04-1] "I'd recommend reverting them separately and in commit message detailing why they are being reverted so it's obvious how those patches can " [core] - 10https://gerrit.wikimedia.org/r/161038 (owner: 10Mattflaschen) [20:46:37] (03PS1) 10SG: Remove mw-ui-button min-height, as it causes unaligned height in many situations [core] - 10https://gerrit.wikimedia.org/r/161074 [20:46:55] (03CR) 10SG: "It's not a _breaking_ change, as the form still works. It is, however, not the best at the moment. There's a separate patch which I forgot" [core] - 10https://gerrit.wikimedia.org/r/161028 (owner: 10Robmoen) [20:47:37] (03CR) 10SG: [C: 04-2] "Copying my comment from previous patch." [core] - 10https://gerrit.wikimedia.org/r/161038 (owner: 10Mattflaschen) [20:48:58] r u srs? https://gerrit.wikimedia.org/r/#/c/161051/1/includes/Html.php [20:49:20] that's scary at least [20:50:16] srs about what? conditional comments? [20:52:01] conditional comments inside the tag ( (03CR) 10MaxSem: [C: 04-1] "Looks like a step backwards, especially since no justification has been provided." [core] - 10https://gerrit.wikimedia.org/r/161051 (owner: 10SG) [20:52:52] 3MediaWiki-Vagrant / 3labs-vagrant: labs-vagrant provision failing in Mediawiki::Import_dump[labs_privacy]/Exec[import_dump_labs_privacy] - 10https://bugzilla.wikimedia.org/70959#c1 (10spage) bd808 suggested commenting out the "classes: ..." line in puppet/hieradata/environment/labs.yaml , that didn't help.... [20:54:02] (03PS2) 10SG: Add IE conditional classes to HTML tag [core] - 10https://gerrit.wikimedia.org/r/161051 [20:56:55] (03CR) 10SG: "We cannot provide CSS targeting to IE8. IE6 and 7 have hacks that we use, but this is not the case for 8. The CSS to do such a thing would" [core] - 10https://gerrit.wikimedia.org/r/161051 (owner: 10SG) [20:58:07] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (24ac83a472) [core] - 10https://gerrit.wikimedia.org/r/161009 (owner: 10Jforrester) [20:59:23] (03PS1) 10Yurik: Updated ZeroPortal to master [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161088 [20:59:43] (03CR) 10Yurik: [C: 032] Updated ZeroPortal to master [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161088 (owner: 10Yurik) [21:04:34] (03PS3) 10SG: Add ie8 and lte-ie8 conditional classes to HTML tag [core] - 10https://gerrit.wikimedia.org/r/161051 [21:04:53] (03PS1) 10Cscott: Handle animated GIFs; remove `easyimage` dependency. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/161090 [21:05:00] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (24ac83a472) [core] - 10https://gerrit.wikimedia.org/r/161009 (owner: 10Jforrester) [21:05:02] (03Merged) 10jenkins-bot: Updated ZeroPortal to master [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161088 (owner: 10Yurik) [21:07:48] (03CR) 10SG: "I have removed ie6 and ie7 support from this patch, per jdlrobson linking to https://www.mediawiki.org/wiki/Compatibility#Browser_support_" [core] - 10https://gerrit.wikimedia.org/r/161051 (owner: 10SG) [21:14:47] (03PS12) 10Jdlrobson: Add mw-ui-icon [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) [21:16:58] (03PS1) 10Bartosz Dziewoński: CSSMin: Do not base64-encode non-binary files when embedding [core] - 10https://gerrit.wikimedia.org/r/161091 (https://bugzilla.wikimedia.org/67341) [21:17:33] (03Abandoned) 10Bartosz Dziewoński: Handling svg images in CSSMin::encodeImageAsDataURI() [core] - 10https://gerrit.wikimedia.org/r/116490 (https://bugzilla.wikimedia.org/57777) (owner: 10Deepali) [21:20:53] 3MediaWiki / 3ResourceLoader: Investigate embedding some data URLs without base 64 - 10https://bugzilla.wikimedia.org/67341 (10Bartosz Dziewoński) a:3Bartosz Dziewoński [21:22:00] (03CR) 10Jdlrobson: "Sam and I spoke. Hopefully latest patch is to his liking." [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) (owner: 10Jdlrobson) [21:22:21] (03PS2) 10Cscott: Use default papersize when bundling. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160991 (https://bugzilla.wikimedia.org/68836) [21:22:53] 3MediaWiki / 3General/Unknown: Redirect does not appear in browser histori - 10https://bugzilla.wikimedia.org/70962 (10Matthias Becker) 3NEW p:3Unprio s:3normal a:3None If one is searching for a page and gets redirected and then changes to the talk page or the history page, it is not possible to navi... [21:23:08] (03PS6) 10Anomie: API: HTMLize and internationalize the help, add Special:ApiHelp [core] - 10https://gerrit.wikimedia.org/r/160798 (https://bugzilla.wikimedia.org/30936) [21:23:27] (03CR) 10Cscott: Use default papersize when bundling. (031 comment) [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160991 (https://bugzilla.wikimedia.org/68836) (owner: 10Cscott) [21:25:27] (03PS1) 10Anomie: API: Clean up and internationalize pretty-printed output [core] - 10https://gerrit.wikimedia.org/r/161093 (https://bugzilla.wikimedia.org/65403) [21:27:08] (03CR) 10Jdlrobson: Add ie8 and lte-ie8 conditional classes to HTML tag (031 comment) [core] - 10https://gerrit.wikimedia.org/r/161051 (owner: 10SG) [21:29:36] 3MediaWiki / 3ResourceLoader: Embedded SVG files should be optimized in ResourceLoader/CSSMin - 10https://bugzilla.wikimedia.org/63491#c4 (10Bartosz Dziewoński) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 34812 *** [21:29:52] 3MediaWiki / 3ResourceLoader: Consider safely optimizing embedded SVG icons in MediaWiki core - 10https://bugzilla.wikimedia.org/59744 (10Bartosz Dziewoński) [21:29:52] 3MediaWiki / 3ResourceLoader: Allow minification of SVG files - 10https://bugzilla.wikimedia.org/34812#c3 (10Bartosz Dziewoński) *** Bug 63491 has been marked as a duplicate of this bug. *** [21:30:07] 3MediaWiki / 3ResourceLoader: Allow minification of SVG files - 10https://bugzilla.wikimedia.org/34812 (10Bartosz Dziewoński) [21:30:07] 3MediaWiki / 3ResourceLoader: Consider safely optimizing embedded SVG icons in MediaWiki core - 10https://bugzilla.wikimedia.org/59744 (10Bartosz Dziewoński) [21:30:45] (03PS2) 10Cscott: Handle animated GIFs; remove `easyimage` dependency. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/161090 (https://bugzilla.wikimedia.org/70865) [21:32:18] (03CR) 10jenkins-bot: [V: 04-1] API: Clean up and internationalize pretty-printed output [core] - 10https://gerrit.wikimedia.org/r/161093 (https://bugzilla.wikimedia.org/65403) (owner: 10Anomie) [21:36:04] shahyar: When you find yourself in a hole, it's usually best to stop digging. [21:36:36] 3MediaWiki / 3Page editing: Require POST for all changes; Never change content on HEAD-request - 10https://bugzilla.wikimedia.org/44602#c8 (10Jesús Martínez Novo (Ciencia Al Poder)) Not able to open rollback links on a new page means there's no way to rollback a lot of edits and also see what has been revert... [21:40:12] (03CR) 10SG: Add ie8 and lte-ie8 conditional classes to HTML tag (031 comment) [core] - 10https://gerrit.wikimedia.org/r/161051 (owner: 10SG) [21:41:04] is gerrit randomly 503'ing for anyone else? [21:42:05] (Discussing in -operations.) [21:42:39] (03CR) 10MZMcBride: "SG: +2 and -2 are quite potent. I strongly recommend using them judiciously." [core] - 10https://gerrit.wikimedia.org/r/161038 (owner: 10Mattflaschen) [21:42:48] (03PS1) 10EBernhardson: Introduce Message::plaintextParam [core] - 10https://gerrit.wikimedia.org/r/161095 [21:42:52] Carmela, what? [21:43:02] and why do you keep naming yourself as random women [21:43:14] shahyar: I left a note on 161038. :-) [21:43:21] shahyar: And to keep things interesting, of course. [21:45:35] (03CR) 10Jdlrobson: Add ie8 and lte-ie8 conditional classes to HTML tag (031 comment) [core] - 10https://gerrit.wikimedia.org/r/161051 (owner: 10SG) [21:45:53] (03CR) 10Cscott: [C: 04-1] Accept papersize setting from metabook (031 comment) [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/160237 (https://bugzilla.wikimedia.org/68836) (owner: 10Arlolra) [21:47:30] (03CR) 10Arlolra: Accept papersize setting from metabook (031 comment) [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/160237 (https://bugzilla.wikimedia.org/68836) (owner: 10Arlolra) [21:48:32] (03PS5) 10Arlolra: Accept papersize setting from metabook [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/160237 (https://bugzilla.wikimedia.org/68836) [21:48:52] (03PS1) 10Ori.livneh: Add $wgBetaFeatures, allowing non-hook registertration of beta features [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/161097 [21:52:04] (03CR) 10Awight: [C: 032] Merge remote-tracking branch 'origin/REL1_23' into fundraising/REL1_22 [core] (fundraising/REL1_23) - 10https://gerrit.wikimedia.org/r/160027 (owner: 10Awight) [21:52:23] (03CR) 10jenkins-bot: [V: 04-1] Use default papersize when bundling. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160991 (https://bugzilla.wikimedia.org/68836) (owner: 10Cscott) [21:52:52] (03PS4) 10SG: Add ie8 and lte-ie8 conditional classes to HTML tag [core] - 10https://gerrit.wikimedia.org/r/161051 [21:52:55] (03CR) 10Awight: "This should still get another pair of eyes before we use on production machines." [core] (fundraising/REL1_23) - 10https://gerrit.wikimedia.org/r/160027 (owner: 10Awight) [21:53:15] (03CR) 10Cscott: "recheck" [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160991 (https://bugzilla.wikimedia.org/68836) (owner: 10Cscott) [21:53:25] (03CR) 10Addshore: [C: 031] PHPUnit: Add Database tags [core] - 10https://gerrit.wikimedia.org/r/154338 (owner: 10Jjanes) [21:54:46] (03CR) 10Addshore: Add tests for CentralAuthUser::getHomeWiki() (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/160611 (owner: 10Legoktm) [21:55:13] (03CR) 10Addshore: [C: 032] Add tests for CentralAuthUser::getHomeWiki() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/160611 (owner: 10Legoktm) [21:55:21] (03PS3) 10Addshore: Add tests for GlobalRenameUserValidator [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/160907 (owner: 10Legoktm) [21:55:36] (03CR) 10MaxSem: [C: 032] PHPUnit: Add Database tags [core] - 10https://gerrit.wikimedia.org/r/154338 (owner: 10Jjanes) [21:55:53] (03Merged) 10jenkins-bot: Add tests for CentralAuthUser::getHomeWiki() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/160611 (owner: 10Legoktm) [21:57:25] (03PS2) 10MZMcBride: Add $wgBetaFeatures, allowing non-hook registration of beta features [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/161097 (owner: 10Ori.livneh) [21:59:09] legoktm: ^ [21:59:17] or marktraceur ^ [21:59:56] I'll look in a bit [22:00:08] 3Wikimedia / 3General/Unknown: Firefox search bar not using Secure search - 10https://bugzilla.wikimedia.org/45765#c19 (10Chris Peterson) Both Firefox desktop and Android browsers have been updated in Firefox's Nightly 35 channel, which will reach all Firefox users on 2015-01-06: https://bugzilla.mozilla.or... [22:01:39] 3MediaWiki-Vagrant: oauth plugin doesn't work in vagrant, seemingly due to the https reverse-proxy - 10https://bugzilla.wikimedia.org/70964 (10Mukunda Modell) 3NEW p:3Unprio s:3normal a:3None When attempting to test mediawiki oauth against a test instance of mediawiki vagrant, something is stripping th... [22:02:17] (03Merged) 10jenkins-bot: PHPUnit: Add Database tags [core] - 10https://gerrit.wikimedia.org/r/154338 (owner: 10Jjanes) [22:02:38] 3MediaWiki-Vagrant / 3labs-vagrant: labs-vagrant provision failing in Mediawiki::Import_dump[labs_privacy]/Exec[import_dump_labs_privacy] - 10https://bugzilla.wikimedia.org/70959#c2 (10spage) (In reply to spage from comment #1) > (... I'm still getting 503 errors accessing the labs wiki instance.) Turns o... [22:03:52] 3MediaWiki / 3API: Protocol-independent links are not linked in the HTML output (xmlfm, jsonfm formatters) - 10https://bugzilla.wikimedia.org/54912#c3 (10Strainu) Does that include URLs in wikitext without single-brackets? [22:04:00] (03PS1) 10EBernhardson: Explicitly treat Message plaintext parameters as plaintext [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161101 [22:04:36] 3MediaWiki-Vagrant: oauth plugin doesn't work in vagrant, seemingly due to the https reverse-proxy - 10https://bugzilla.wikimedia.org/70964 (10Mukunda Modell) p:5Unprio>3Low [22:04:37] (03CR) 10jenkins-bot: [V: 04-1] Explicitly treat Message plaintext parameters as plaintext [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161101 (owner: 10EBernhardson) [22:05:21] 3MediaWiki-Vagrant: oauth plugin doesn't work in vagrant, seemingly due to the https reverse-proxy - 10https://bugzilla.wikimedia.org/70964#c1 (10Bryan Davis) (In reply to Mukunda Modell from comment #0) > ... related to the nginx reverse proxy ... Which nginx reverse proxy? Could you describe your testing en... [22:05:25] (03CR) 10MaxSem: [C: 031] Move assets/ to resources/assets/ [core] - 10https://gerrit.wikimedia.org/r/161030 (owner: 10Bartosz Dziewoński) [22:05:28] (03PS2) 10EBernhardson: Explicitly treat Message plaintext parameters as plaintext [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161101 [22:05:45] (03CR) 10Jdlrobson: [C: 04-1] "It would help if commit message pointed to where these coding standards are documented. I don't see anything wrong with existing markup..." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/160919 (owner: 10IAlex) [22:06:03] (03CR) 10EBernhardson: "Unit tests fail because the related core patch has not been merged" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161101 (owner: 10EBernhardson) [22:06:06] (03CR) 10jenkins-bot: [V: 04-1] Explicitly treat Message plaintext parameters as plaintext [extensions/Flow] - 10https://gerrit.wikimedia.org/r/161101 (owner: 10EBernhardson) [22:06:41] (03CR) 10Jdlrobson: Implement mw-ui-modal and remove jquery.ui usage (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160612 (owner: 10SG) [22:07:43] (03CR) 10Jdlrobson: [C: 04-1] Implement mw-ui-modal and remove jquery.ui usage (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160612 (owner: 10SG) [22:11:07] (03CR) 10SG: Implement mw-ui-modal and remove jquery.ui usage (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160612 (owner: 10SG) [22:11:23] 3MediaWiki / 3Logging: log_params doesn't contain the page ID of the target page in merge events - 10https://bugzilla.wikimedia.org/70966 (10Nathan Larson) 3NEW p:3Unprio s:3normal a:3None log_params doesn't contain the page ID of the target page in merge events; it just has the title of the target p... [22:11:47] (03PS7) 10SG: Implement mw-ui-modal and remove jquery.ui usage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160612 [22:12:53] 3MediaWiki-Vagrant / 3labs-vagrant: labs-vagrant: hhvm.hhbc can fill tmpfs - 10https://bugzilla.wikimedia.org/70967 (10spage) 3NEW p:3Unprio s:3normal a:3None After updating and labs-vagrant provision of a flow-tests labs instance, I was getting 503 errors. /var/log/hhvm/error.log contained [Wed Se... [22:17:07] (03CR) 10Jdlrobson: "(to be clear my main reason for -1 is the name of the class and the fact it should be in a separate file, the oojs stuff may be premature," [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160612 (owner: 10SG) [22:17:28] (03PS1) 10Legoktm: Document that MediaWiki also supports HHVM [core] - 10https://gerrit.wikimedia.org/r/161105 [22:17:36] 3Wikimedia / 3Media storage: Thumbnails for a specific PDF file on Commons not generated - 10https://bugzilla.wikimedia.org/70734#c5 (10Elitre) As an update, I tried to overwrite the image by getting a new cover to the pdf. While it now opens correctly in preview on my Mac, it still doesn't generate the thum... [22:23:23] (03PS8) 10SG: Implement mw-ui-modal and remove jquery.ui usage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160612 [22:24:00] (03CR) 10jenkins-bot: [V: 04-1] Implement mw-ui-modal and remove jquery.ui usage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160612 (owner: 10SG) [22:26:16] (03CR) 10SG: "Yeah, I wanted to use OOJS, but realized we wouldn't actually be using any of its features just yet." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160612 (owner: 10SG) [22:30:51] 3MediaWiki / 3Interface: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277#c61 (10Dan Andreescu) I'm posting the file. I just redacted all results that had <= 20 hits. There were some weird, overly-specific URLs in there. I left... [22:31:06] 3MediaWiki / 3Interface: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277#c62 (10Dan Andreescu) Created attachment 16507 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16507&action=edit hits to */skins/common/** on Septem... [22:34:22] 3MediaWiki extensions / 3SecurePoll: SecurePoll Redesign: Poll Creation should auto create GPG keys - 10https://bugzilla.wikimedia.org/68129#c6 (10James Alexander) (In reply to Chris Steipp from comment #5) > Storing the private key on the server does seem to defeat the purpose of > encrypting the results, u... [22:40:12] (03CR) 10Robmoen: "I'm not here to pile on SG. But it remains that these refactors need to be agreed on. My vote is for reverting. Like others have sai" [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG) [22:44:16] (03PS1) 10Gergő Tisza: Update MediaViewer submodule [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/161119 [22:45:44] if anyone has anything to say against https://gerrit.wikimedia.org/r/#/c/161030/ - please say it, OR I WILL MERGE :P [22:46:38] (03CR) 10Jdlrobson: "shahyar: Fact: you broke button styling from IE6-8." [core] - 10https://gerrit.wikimedia.org/r/161038 (owner: 10Mattflaschen) [22:48:02] (03PS1) 10Gergő Tisza: Update MediaViewer submodule [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161121 [22:48:11] MaxSem: why are top-level directories hard? [22:49:06] branching scripts, etc [22:49:16] * jackmcbarn has no objection then [22:49:30] not necessarily a blocker, but haz no time until tomorrow to flesh it out [22:49:42] (03PS3) 10Jdlrobson: Revert buggy MediaWiki UI change and dependent changes [core] - 10https://gerrit.wikimedia.org/r/161038 (owner: 10Mattflaschen) [22:49:44] jackmcbarn: also, everybody who has a MW wiki that isn't fully web-accessible would have to adjust [22:50:02] unnecessary effort for everyone involved, including me writing release notes [22:50:35] (03CR) 10Jdlrobson: [C: 031] "I worked it out and updated commit message." [core] - 10https://gerrit.wikimedia.org/r/161038 (owner: 10Mattflaschen) [22:51:51] (03Abandoned) 10Gergő Tisza: Update UploadWizard submodule [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/161035 (owner: 10Gergő Tisza) [22:51:57] (03CR) 10Jdlrobson: "(Note even if https://gerrit.wikimedia.org/r/161051 gets merged there is still the fact that the class will not appear for a good 30 days," [core] - 10https://gerrit.wikimedia.org/r/161038 (owner: 10Mattflaschen) [22:52:07] 3MediaWiki extensions / 3[other]: Graph extension security review - 10https://bugzilla.wikimedia.org/69623#c6 (10Yuri Astrakhan) Chris, thanks, and the defaults have always been exactly as you describe - extension sets wgEnableGraphParserTag=false and wgGraphDataDomains=[] by default. [22:54:56] (03CR) 10Ori.livneh: "I didn't realize SG was Shahyar; I thought it was a volunteer. A staff member with embedded in a group of MediaWiki developers should not " [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG) [22:56:12] (03CR) 10MaxSem: [C: 032] "*hides*" [core] - 10https://gerrit.wikimedia.org/r/161030 (owner: 10Bartosz Dziewoński) [22:57:18] (03CR) 10Legoktm: Add MultiConfig for fallback logic (032 comments) [core] - 10https://gerrit.wikimedia.org/r/153541 (https://bugzilla.wikimedia.org/69418) (owner: 10Legoktm) [22:57:35] (03PS9) 10Legoktm: Add MultiConfig for fallback logic [core] - 10https://gerrit.wikimedia.org/r/153541 (https://bugzilla.wikimedia.org/69418) [23:00:07] (03CR) 10Legoktm: Add MultiConfig for fallback logic (031 comment) [core] - 10https://gerrit.wikimedia.org/r/153541 (https://bugzilla.wikimedia.org/69418) (owner: 10Legoktm) [23:00:38] 3Wikimedia / 3Site requests: Account creation for GLAM event - 10https://bugzilla.wikimedia.org/70953#c5 (10khenningsen) Thank you so much for your time and help. Here is the IP address as it appeared via the link you sent. https://en.wikipedia.org/wiki/User:207.207.127.233 https://en.wikipedia.org/wiki... [23:00:55] (03CR) 10MarkTraceur: [C: 032] Update UploadWizard submodule [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161037 (owner: 10Gergő Tisza) [23:02:37] (03Merged) 10jenkins-bot: Move assets/ to resources/assets/ [core] - 10https://gerrit.wikimedia.org/r/161030 (owner: 10Bartosz Dziewoński) [23:03:45] (03CR) 10Jdlrobson: [C: 032] inputs.less: Use .mw-ui-input-inline for type="number" [core] - 10https://gerrit.wikimedia.org/r/161016 (https://bugzilla.wikimedia.org/70404) (owner: 10Prtksxna) [23:04:32] (03Merged) 10jenkins-bot: Update UploadWizard submodule [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161037 (owner: 10Gergő Tisza) [23:06:30] (03CR) 10Legoktm: [C: 04-1] Add $wgBetaFeatures, allowing non-hook registration of beta features (031 comment) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/161097 (owner: 10Ori.livneh) [23:06:53] AaronS: around? if so, can you answer the question at https://gerrit.wikimedia.org/r/#/c/160570/ ? [23:07:06] 3MediaWiki-Vagrant / 3labs-vagrant: labs-vagrant provision failing in Mediawiki::Import_dump[labs_privacy]/Exec[import_dump_labs_privacy] - 10https://bugzilla.wikimedia.org/70959#c3 (10Dan Duvall) Created attachment 16508 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16508&action=edit Except of pupp... [23:08:46] 404s are on https://commons.wikimedia.org/wiki/Category:Audio_files_of_females_speaking_English [23:08:50] GET https://commons.wikimedia.org/w/assets/file-type-icons/fileicon-ogg.png 404 (Not Found) fileicon-ogg.png:1 [23:09:05] (03PS5) 10Jackmcbarn: Hook TitleExists when previewing [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/160555 (https://bugzilla.wikimedia.org/70495) [23:09:15] (03CR) 10Legoktm: "Mark will know why this was actually done, but I'm assuming it was due to not depending upon extension load order since hooks can be regis" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/161097 (owner: 10Ori.livneh) [23:10:21] (03Merged) 10jenkins-bot: inputs.less: Use .mw-ui-input-inline for type="number" [core] - 10https://gerrit.wikimedia.org/r/161016 (https://bugzilla.wikimedia.org/70404) (owner: 10Prtksxna) [23:11:42] (03CR) 10Krinkle: "Fixme: Don't use wgScriptPath since 1) this directory will not exist in production, 2) even if we create it, it will point to the wrong ve" [core] - 10https://gerrit.wikimedia.org/r/161030 (owner: 10Bartosz Dziewoński) [23:13:30] (03PS1) 10Catrope: Followup 1cf5a6e: use $wgResourceBasePath to refer to resources/assets, not $wgScriptPath [core] - 10https://gerrit.wikimedia.org/r/161124 [23:13:41] (03CR) 10Catrope: "FIXME addressed in https://gerrit.wikimedia.org/r/161124" [core] - 10https://gerrit.wikimedia.org/r/161030 (owner: 10Bartosz Dziewoński) [23:13:54] MatmaRex: MaxSem: cool ^ I'll review that now [23:14:28] (03CR) 10Bartosz Dziewoński: [C: 04-1] "$gResourceBasePath can be null." [core] - 10https://gerrit.wikimedia.org/r/161124 (owner: 10Catrope) [23:15:05] 3Wikimedia / 3General/Unknown: Add ContentHandler columns to Wikimedia wikis, and set $wgContentHandlerUseDB = true - 10https://bugzilla.wikimedia.org/49193 (10Kunal Mehta (Legoktm)) [23:15:07] (03CR) 10Bartosz Dziewoński: "This needs `$wgResourceBasePath === null ? $wgScriptPath : $wgResourceBasePath` everywhere, or setting up the same in Setup.php." [core] - 10https://gerrit.wikimedia.org/r/161124 (owner: 10Catrope) [23:15:51] 3MediaWiki / 3MediaWiki UI: Remove $wgUseMediaWikiUIEverywhere dependency for button and input styling (tracking) - 10https://bugzilla.wikimedia.org/70913 (10Jon) [23:15:51] 3MediaWiki / 3MediaWiki UI: Single line input fields text baseline is too high - 10https://bugzilla.wikimedia.org/70917 (10Jon) [23:15:51] 3MediaWiki / 3MediaWiki UI: Single line input fields corner rounding is inconsistent with buttons - 10https://bugzilla.wikimedia.org/70916 (10Jon) [23:16:36] 3MediaWiki / 3MediaWiki UI: Input fields should be relative to input strings - 10https://bugzilla.wikimedia.org/70404 (10Jon) 5PATC>3RESO/FIX [23:17:39] (03CR) 10Bartosz Dziewoński: "(Also, thanks.)" [core] - 10https://gerrit.wikimedia.org/r/161124 (owner: 10Catrope) [23:18:03] legoktm: did you intentionally add yourself to the "in training" column rather than the "maintainers" column in almost all of those entries? [23:18:19] yes [23:18:55] (03CR) 10Catrope: "I thought we already did that in Setup.php , it's stupid that we currently don't. Will fix." [core] - 10https://gerrit.wikimedia.org/r/161124 (owner: 10Catrope) [23:19:04] basically "I'll review and merge patches related to these areas, but don't really know it well enough to merge breaking/controversial things" [23:20:53] 3MediaWiki / 3MediaWiki UI: Normal buttons should have a minimum width to provide accessible targets - 10https://bugzilla.wikimedia.org/70972 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None you can see on http://tools.wmflabs.org/styleguide/desktop/section-1.html#section-1.2 the button lab... [23:21:06] 3MediaWiki-Vagrant / 3labs-vagrant: labs-vagrant provision failing in Mediawiki::Import_dump[labs_privacy]/Exec[import_dump_labs_privacy] - 10https://bugzilla.wikimedia.org/70959#c4 (10Dan Duvall) MWV's mediawiki class does set the right permissions on its $cache_dir. file { [ $cache_dir, $upload_dir ]:... [23:22:38] (03PS2) 10Catrope: Followup 1cf5a6e: use $wgResourceBasePath to refer to resources/assets, not $wgScriptPath [core] - 10https://gerrit.wikimedia.org/r/161124 [23:22:48] MatmaRex, Krinkle: ---^^ [23:23:48] (03PS1) 10Yurik: Graph ext to master [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/161126 [23:23:53] (03CR) 10MarkTraceur: [C: 032] Update MediaViewer submodule [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/161119 (owner: 10Gergő Tisza) [23:23:55] (03CR) 10Krinkle: "fixme: This broke in production due to assets/ not existing, and also wgScriptPath shouldn't be used since that isn't versioned over HTTP," [core] - 10https://gerrit.wikimedia.org/r/158648 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [23:24:10] (03CR) 10Krinkle: [C: 031] "Final tests.." [core] - 10https://gerrit.wikimedia.org/r/161124 (owner: 10Catrope) [23:24:18] (03CR) 10Krinkle: "Fixed in I608435cef0." [core] - 10https://gerrit.wikimedia.org/r/158648 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [23:24:22] (03PS1) 10Yurik: Graph ext to master [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161127 [23:24:49] RoanKattouw: thanks, looks good but i'm off to sleep now [23:25:38] MatmaRex: OK. Krinkle is on it. Thanks for your help [23:26:18] (03CR) 10Jdlrobson: [C: 04-1] "You forgot to add new/mw-ui.modal.js :)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160612 (owner: 10SG) [23:27:27] (03PS1) 10Cmcmahon: QA: refactor for consistent Ruby practice [extensions/Echo] - 10https://gerrit.wikimedia.org/r/161128 [23:27:30] (03Merged) 10jenkins-bot: Update MediaViewer submodule [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/161119 (owner: 10Gergő Tisza) [23:27:32] (03CR) 10Krinkle: [C: 032] Followup 1cf5a6e: use $wgResourceBasePath to refer to resources/assets, not $wgScriptPath [core] - 10https://gerrit.wikimedia.org/r/161124 (owner: 10Catrope) [23:29:02] (03CR) 10Jdlrobson: "Code wise it is fine, but commit message should mention that developers will not be able to use the class reliably for 30 days until the c" [core] - 10https://gerrit.wikimedia.org/r/161051 (owner: 10SG) [23:29:39] 3MediaWiki / 3MediaWiki UI: Set input[type=number] width according to the maxlength attribute - 10https://bugzilla.wikimedia.org/70973 (10Prateek Saxena) 3NEW p:3Unprio s:3normal a:3None Input fields that are numbers should set the max length attribute based on the largest number that they allow. Th... [23:29:40] (03PS2) 10MarkTraceur: Update MediaViewer submodule [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161121 (owner: 10Gergő Tisza) [23:29:48] (03CR) 10MarkTraceur: [C: 032] Update MediaViewer submodule [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161121 (owner: 10Gergő Tisza) [23:32:53] 3MediaWiki / 3User preferences: maxlength html form values are not used in preferences - 10https://bugzilla.wikimedia.org/70974 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None e.g. preferences -> Editing -> columns has a maximum value of "1000" and should have a maxlength="4" since any val... [23:33:21] 3MediaWiki / 3User preferences: maxlength html form values are not used in preferences - 10https://bugzilla.wikimedia.org/70974 (10Jared Zimmerman (WMF)) [23:33:22] 3MediaWiki / 3MediaWiki UI: Set input[type=number] width according to the maxlength attribute - 10https://bugzilla.wikimedia.org/70973 (10Jared Zimmerman (WMF)) [23:33:58] (03Merged) 10jenkins-bot: Followup 1cf5a6e: use $wgResourceBasePath to refer to resources/assets, not $wgScriptPath [core] - 10https://gerrit.wikimedia.org/r/161124 (owner: 10Catrope) [23:34:00] (03Merged) 10jenkins-bot: Update MediaViewer submodule [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161121 (owner: 10Gergő Tisza) [23:35:08] 3MediaWiki / 3MediaWiki UI: preferences reset button should be destructive - 10https://bugzilla.wikimedia.org/70975 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None https://en.wikipedia.org/wiki/Special:Preferences/reset primary button should be destructive. [23:35:27] (03PS1) 10Catrope: Move assets/ to resources/assets/ [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161132 [23:35:29] (03CR) 10MarkTraceur: [C: 032] Graph ext to master [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/161126 (owner: 10Yurik) [23:35:34] (03CR) 10MarkTraceur: [C: 032] Graph ext to master [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161127 (owner: 10Yurik) [23:36:34] (03PS2) 10Catrope: Move assets/ to resources/assets/ [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161132 [23:37:45] (03PS1) 10Yurik: ZeroPortal ext to master [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161133 [23:38:25] (03CR) 10jenkins-bot: [V: 04-1] Move assets/ to resources/assets/ [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161132 (owner: 10Catrope) [23:39:08] (03PS3) 10Catrope: Move assets/ to resources/assets/ [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161132 [23:39:10] (03PS1) 10Catrope: Followup 1cf5a6e: use $wgResourceBasePath to refer to resources/assets, not $wgScriptPath [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161134 [23:40:00] (03Merged) 10jenkins-bot: Graph ext to master [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/161126 (owner: 10Yurik) [23:40:04] (03Merged) 10jenkins-bot: Graph ext to master [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161127 (owner: 10Yurik) [23:42:24] 3MediaWiki / 3MediaWiki UI: preferences reset button should be destructive - 10https://bugzilla.wikimedia.org/70975#c1 (10Jon) 5NEW>3RESO/DUP It is https://gerrit.wikimedia.org/r/157709 I suspect Matt hasn't updated the server. S *** This bug has been marked as a duplicate of bug 65317 *** [23:42:24] 3MediaWiki / 3MediaWiki UI: Preferences: Update button classes and layout to use mediawiki.ui classes and conventions - 10https://bugzilla.wikimedia.org/65317#c11 (10Jon) *** Bug 70975 has been marked as a duplicate of this bug. *** [23:43:08] 3MediaWiki-Vagrant / 3labs-vagrant: labs-vagrant provision failing in Mediawiki::Import_dump[labs_privacy]/Exec[import_dump_labs_privacy] - 10https://bugzilla.wikimedia.org/70959 (10Dan Duvall) 5NEW>3ASSI a:3Dan Duvall [23:45:05] 3MediaWiki / 3MediaWiki UI: Set input[type=number] width according to the maxlength attribute - 10https://bugzilla.wikimedia.org/70973#c1 (10Jon) I suspect we will need to use a class approach. e.g. when generating an input, take a look at the number of maxlength if maxlength < 5 add mw-ui-input-short if max... [23:46:07] 3MediaWiki / 3MediaWiki UI: Buttons have text of same colour when focused - 10https://bugzilla.wikimedia.org/70801 (10Prateek Saxena) 5NEW>3RESO/FIX [23:48:55] (03PS4) 10MarkTraceur: Move assets/ to resources/assets/ [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161132 (owner: 10Catrope) [23:50:02] (03CR) 10MarkTraceur: [C: 032] Move assets/ to resources/assets/ [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161132 (owner: 10Catrope) [23:50:55] (03PS2) 10MarkTraceur: Followup 1cf5a6e: use $wgResourceBasePath to refer to resources/assets, not $wgScriptPath [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161134 (owner: 10Catrope) [23:51:02] (03CR) 10MarkTraceur: [C: 032] Followup 1cf5a6e: use $wgResourceBasePath to refer to resources/assets, not $wgScriptPath [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161134 (owner: 10Catrope) [23:53:11] (03Merged) 10jenkins-bot: Move assets/ to resources/assets/ [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161132 (owner: 10Catrope) [23:53:37] (03CR) 10Jdlrobson: [C: 032] "Sorry but there is a branch cut off happening soon and these issues can't get on to production." [core] - 10https://gerrit.wikimedia.org/r/161038 (owner: 10Mattflaschen) [23:54:00] (03PS1) 10Gergő Tisza: Fix UploadWizard logging some more, maybe [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/161137 [23:54:48] (03Merged) 10jenkins-bot: Followup 1cf5a6e: use $wgResourceBasePath to refer to resources/assets, not $wgScriptPath [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161134 (owner: 10Catrope) [23:55:32] (03CR) 10MarkTraceur: [C: 032] Fix UploadWizard logging some more, maybe [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/161137 (owner: 10Gergő Tisza) [23:55:59] (03Merged) 10jenkins-bot: Fix UploadWizard logging some more, maybe [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/161137 (owner: 10Gergő Tisza) [23:56:05] (03CR) 10Legoktm: "(to merge this, you have to remove SG's -2 first)" [core] - 10https://gerrit.wikimedia.org/r/161038 (owner: 10Mattflaschen)