[00:00:02] 3MediaWiki extensions / 3CirrusSearch: Cirrus unable to find insource:"mazovia.pl" on pl.wp where the phrase occurs in a URL - 10https://bugzilla.wikimedia.org/70873 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None Cirrus unable to find insource:"mazovia.pl" on pl.wp where the phrase occurs in... [00:03:43] (03CR) 10Aaron Schulz: [C: 032] Improve hidden field validation [core] - 10https://gerrit.wikimedia.org/r/150871 (https://bugzilla.wikimedia.org/68132) (owner: 10Anomie) [00:06:57] (03PS2) 10Jackmcbarn: Hook TitleExists when previewing [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/160555 (https://bugzilla.wikimedia.org/70495) [00:09:06] (03PS1) 10Jackmcbarn: Add RevisionFromTitle hook [core] - 10https://gerrit.wikimedia.org/r/160570 (https://bugzilla.wikimedia.org/70495) [00:10:15] (03Merged) 10jenkins-bot: Improve hidden field validation [core] - 10https://gerrit.wikimedia.org/r/150871 (https://bugzilla.wikimedia.org/68132) (owner: 10Anomie) [00:10:40] (03CR) 10Bartosz Dziewoński: [C: 04-1] mediawiki.api.options: New module for user preferences API (action=options) [core] - 10https://gerrit.wikimedia.org/r/160308 (owner: 10Bartosz Dziewoński) [00:13:16] 3MediaWiki-Vagrant / 3labs-vagrant: Fatal error, timeout when running composer install - 10https://bugzilla.wikimedia.org/70843 (10Dan Duvall) a:3Dan Duvall [00:14:13] (03PS1) 10Dduvall: Split HHVM php.ini into common and fcgi hiera settings [vagrant] - 10https://gerrit.wikimedia.org/r/160571 (https://bugzilla.wikimedia.org/70843) [00:17:16] (03PS1) 10Jackmcbarn: Use RevisionFromTitle instead of a template callback [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/160572 (https://bugzilla.wikimedia.org/70495) [00:17:59] 3MediaWiki extensions / 3TemplateSandbox: TemplateSandbox doesn't handle things like #ifexist and Scribunto's getContent - 10https://bugzilla.wikimedia.org/70495#c9 (10Jackmcbarn) All of the patches needed to fix this are now uploaded. [00:20:25] whew! 6 patches for 1 bug [00:25:15] jackmcbarn: those are the best bugs! [00:26:32] 3MediaWiki / 3Parser: Links with attributes containing escaped right square brackets don't close properly - 10https://bugzilla.wikimedia.org/70875 (10Jackmcbarn) 3NEW p:3Unprio s:3normal a:3None In this wikitext: *hello [[Example|convert: invalid number]]... [00:27:01] legoktm: btw, i thought i had an unusually high number of open changes in gerrit, then i looked at yours. [00:28:02] >.< [00:28:18] I have a bunch of patches that I just need to rebase after the i18n migration [00:36:47] bd808: i'm helping the Multimedia team out with some perf tests and need to spin up a new labs instance. think you could admin me? [00:37:02] it's the "Multimedia" project [00:37:09] marxarel_: Sure. [00:38:04] bd808: rad. thanks! [00:40:23] (03CR) 10Legoktm: CachedGadgetRepo: Store Content objects internally instead of JSON blobs (031 comment) [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160431 (owner: 10Legoktm) [00:40:26] (03PS3) 10Legoktm: CachedGadgetRepo: Store Content objects internally instead of JSON blobs [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160431 [00:43:54] (03PS6) 10Legoktm: Add some basic tests for LocalGadgetRepo & ForeignDBGadgetRepo [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160432 [00:47:11] (03CR) 10Krinkle: "Yep" [core] - 10https://gerrit.wikimedia.org/r/156093 (owner: 10Nikerabbit) [00:47:16] (03PS1) 10Yurik: abstract CodeContent, reworked JsonContent [core] - 10https://gerrit.wikimedia.org/r/160575 [00:47:22] legoktm, ^ [00:48:10] (03PS2) 10Yurik: abstract CodeContent, reworked JsonContent [core] - 10https://gerrit.wikimedia.org/r/160575 [00:48:59] (03CR) 10Krinkle: "Yep. Remove it from @param and mention it in the description instead." [core] - 10https://gerrit.wikimedia.org/r/156093 (owner: 10Nikerabbit) [00:49:15] (03CR) 10Krinkle: [C: 032] Fix: Missing parent::tearDown() call [extensions/Math] - 10https://gerrit.wikimedia.org/r/160522 (owner: 10Physikerwelt) [00:50:31] (03PS3) 10Krinkle: tests: Add missing parent::tearDown() call [extensions/Math] - 10https://gerrit.wikimedia.org/r/160522 (owner: 10Physikerwelt) [00:51:35] (03CR) 10Krinkle: "Describe commits with the component they relate to. "Fix" is not an area of code." [extensions/Math] - 10https://gerrit.wikimedia.org/r/160522 (owner: 10Physikerwelt) [00:51:53] (03CR) 10Krinkle: "Does not relate to bug 49169 it seems. Fix topic." [extensions/Math] - 10https://gerrit.wikimedia.org/r/160522 (owner: 10Physikerwelt) [00:52:03] (03CR) 10Krinkle: [C: 032] "Added reference to commit that added it." [extensions/Math] - 10https://gerrit.wikimedia.org/r/160522 (owner: 10Physikerwelt) [00:52:58] (03Merged) 10jenkins-bot: tests: Add missing parent::tearDown() call [extensions/Math] - 10https://gerrit.wikimedia.org/r/160522 (owner: 10Physikerwelt) [00:54:43] (03CR) 10jenkins-bot: [V: 04-1] abstract CodeContent, reworked JsonContent [core] - 10https://gerrit.wikimedia.org/r/160575 (owner: 10Yurik) [00:56:35] yurikR: I'll look later tonight [00:56:41] legoktm, thx [00:58:07] legoktm: if you want, rebase https://gerrit.wikimedia.org/r/#/c/88683/ and i'll review and test it [00:59:33] (03PS3) 10Yurik: abstract CodeContent, reworked JsonContent [core] - 10https://gerrit.wikimedia.org/r/160575 [00:59:41] I think I might just re-do that one, the code around it has changed [01:03:55] (03PS1) 10Yurik: Updated mediawiki dict [core] - 10https://gerrit.wikimedia.org/r/160576 [01:04:53] (03CR) 10Yurik: [C: 032] "self+2, this is for IDEs only" [core] - 10https://gerrit.wikimedia.org/r/160576 (owner: 10Yurik) [01:06:18] (03CR) 10jenkins-bot: [V: 04-1] abstract CodeContent, reworked JsonContent [core] - 10https://gerrit.wikimedia.org/r/160575 (owner: 10Yurik) [01:11:23] (03Merged) 10jenkins-bot: Updated mediawiki dict [core] - 10https://gerrit.wikimedia.org/r/160576 (owner: 10Yurik) [01:17:56] (03PS7) 10Legoktm: Add some basic tests for LocalGadgetRepo & ForeignDBGadgetRepo [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160432 [01:19:25] (03CR) 10Legoktm: CachedGadgetRepo: Store Content objects internally instead of JSON blobs (031 comment) [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160431 (owner: 10Legoktm) [01:19:29] 3MediaWiki / 3User login and signup: Login as another user no longer works - 10https://bugzilla.wikimedia.org/70855#c6 (10Jon) To play devils advocate, why would you want to visit the login form whilst logged in? What is wrong with logging out and then visiting it? [01:21:08] [travis-ci] cssjanus/node-cssjanus#42 (master - d8eb7ba : Timo Tijhof): The build passed. [01:21:08] [travis-ci] Change view : https://github.com/cssjanus/node-cssjanus/compare/f6f50104b0c4...d8eb7baada86 [01:21:08] [travis-ci] Build details : http://travis-ci.org/cssjanus/node-cssjanus/builds/35393484 [01:22:52] (03CR) 10Jdlrobson: [C: 04-1] "sorry to be picky.. :-S" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/160551 (owner: 10Prtksxna) [01:24:44] 3MediaWiki / 3File management: Image urls should have far future expires - 10https://bugzilla.wikimedia.org/17577 (10Gabriel Wicke) [01:24:59] 3MediaWiki / 3File management: Use content hash based image / thumb URLs - 10https://bugzilla.wikimedia.org/64214 (10Gabriel Wicke) [01:25:02] 3MediaWiki-Vagrant: vagrant run-test parameter parsing is broken on Windows - 10https://bugzilla.wikimedia.org/70876 (10Yuri Astrakhan) 3NEW p:3Unprio s:3normal a:3None vagrant run-tests works fine without parameters, but breaks as follows on my Windows box: ~/mw/v/mediawiki/includes/content $ vagrant... [01:32:22] (03PS1) 10EBernhardson: Hygiene: remove outdated and incorrect documentation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160582 [01:33:00] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: remove outdated and incorrect documentation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160582 (owner: 10EBernhardson) [01:33:31] (03PS2) 10EBernhardson: Hygiene: Autogenerate wgAutoloadClasses code from Makefile [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160258 [01:53:30] (03PS3) 10Yurik: Added FormatJson::parse( $value, $options = 0 ) returning Status [core] - 10https://gerrit.wikimedia.org/r/160541 [01:53:38] (03PS4) 10Yurik: abstract CodeContent, reworked JsonContent [core] - 10https://gerrit.wikimedia.org/r/160575 [01:53:40] (03CR) 10Cscott: [C: 04-1] "The functional part of this change seems to be moving the pause immediately after creation, instead of in the 'request' signal callback." [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160552 (owner: 10GWicke) [01:56:06] (03PS5) 10Yurik: abstract CodeContent, reworked JsonContent [core] - 10https://gerrit.wikimedia.org/r/160575 [01:56:27] (03PS5) 10Withoutaname: Enforce some type hinting in Linker class [core] - 10https://gerrit.wikimedia.org/r/144646 [02:05:59] 3MediaWiki / 3User login and signup: Login as another user no longer works - 10https://bugzilla.wikimedia.org/70855#c7 (10Tyler Romeo) (In reply to Bartosz Dziewoński from comment #5) > Indeed, but it should be easy enough to show the form instead of redirecting > when the user is logged in and there's no 'r... [02:13:15] (03CR) 10Tim Starling: "> We already have that problem with the static array, don't we?" [php/luasandbox] - 10https://gerrit.wikimedia.org/r/159822 (owner: 10Anomie) [02:18:15] 3MediaWiki / 3User login and signup: Login as another user no longer works - 10https://bugzilla.wikimedia.org/70855#c8 (10Betacommand) However logging out can cause problems because it invalidates all login sessions. If a user is operating a bot and switches to remove the new message talk page notice, it log... [02:39:44] 3MediaWiki / 3User login and signup: Login as another user no longer works - 10https://bugzilla.wikimedia.org/70855#c9 (10Tyler Romeo) (In reply to Betacommand from comment #8) > However logging out can cause problems because it invalidates all login > sessions. If a user is operating a bot and switches to r... [02:46:14] 3MediaWiki / 3User login and signup: Login as another user no longer works - 10https://bugzilla.wikimedia.org/70855#c10 (10Betacommand) Actually its not. That particular issue has existed for as long as I can remember (~2006) If I log in via a bot, the cookies/session is kept and reused as needed. If I then... [02:52:39] (03PS1) 10Catrope: Update VisualEditor to wmf21 for cherry-pick of I0fb47f7c91f61 and If48555fa476 [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160602 [02:55:11] (03PS1) 10Catrope: Update VisualEditor to wmf20 for cherry-pick of I0fb47f7c91f61 and If48555fa476 [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160603 [03:01:14] 3MediaWiki / 3User login and signup: Login as another user no longer works - 10https://bugzilla.wikimedia.org/70855#c11 (10Tyler Romeo) (In reply to Betacommand from comment #10) > Actually its not. That particular issue has existed for as long as I can > remember (~2006) If I log in via a bot, the cookies/s... [03:03:31] (03CR) 10EBernhardson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160582 (owner: 10EBernhardson) [03:12:25] (03CR) 10EBernhardson: [C: 032] Hygiene: remove outdated and incorrect documentation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160582 (owner: 10EBernhardson) [03:13:00] (03Merged) 10jenkins-bot: Hygiene: remove outdated and incorrect documentation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160582 (owner: 10EBernhardson) [03:14:41] (03CR) 10Tim Starling: "Again, it can be done in the same way as SqlBagOStuff:" [core] - 10https://gerrit.wikimedia.org/r/153944 (owner: 10Aaron Schulz) [03:22:00] 3MediaWiki / 3User preferences: Simple accessibility preferences - 10https://bugzilla.wikimedia.org/70879 (10Matthew Flaschen) [03:22:03] 3MediaWiki / 3User preferences: Simple accessibility preferences - 10https://bugzilla.wikimedia.org/70879 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3None There should be easy to use accessibility options. A couple things to consider: * Options to change the main colors (e.g. regular links, vi... [03:22:14] (03CR) 10Tim Starling: [C: 04-2] "It's used by getReaderIndex() to allow the site to stay up despite the loss of a slave. If you remove the try/catch, then the site will go" [core] - 10https://gerrit.wikimedia.org/r/157488 (https://bugzilla.wikimedia.org/70223) (owner: 10saper) [03:24:59] 3MediaWiki / 3User preferences: Simple accessibility preferences - 10https://bugzilla.wikimedia.org/70879 (10Matthew Flaschen) [03:27:16] (03PS4) 10Mattflaschen: WIP: Have GettingStarted depend on CentralAuth [vagrant] - 10https://gerrit.wikimedia.org/r/134782 [03:27:33] (03CR) 10Mattflaschen: WIP: Have GettingStarted depend on CentralAuth (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/134782 (owner: 10Mattflaschen) [03:28:09] (03PS5) 10Physikerwelt: Fine grained options for wgMathDisableTeXFilter [extensions/Math] - 10https://gerrit.wikimedia.org/r/158845 [03:32:18] (03PS1) 10Jackmcbarn: Check content model instead of title [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/160605 [03:35:28] ori_, is #mediawiki-vagrant a real channel? Almost no one is there, and as I recall, we decided not to do it. [03:35:55] https://meta.wikimedia.org/wiki/IRC/Channels#mediawiki-vagrant ("MediaWiki roleplay") made me LOL a little though. [03:36:44] (03PS6) 10Tim Starling: Add language override and extra link support for dumpInterwiki [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/94593 (https://bugzilla.wikimedia.org/56207) (owner: 10TTO) [03:36:59] (03CR) 10Tim Starling: [C: 032] Add language override and extra link support for dumpInterwiki [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/94593 (https://bugzilla.wikimedia.org/56207) (owner: 10TTO) [03:37:03] (03Merged) 10jenkins-bot: Add language override and extra link support for dumpInterwiki [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/94593 (https://bugzilla.wikimedia.org/56207) (owner: 10TTO) [03:40:00] (03CR) 10TTO: "Thank you very much for your help here, Tim. Hopefully my next patch doesn't take 10 months to get +2 :)" [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/94593 (https://bugzilla.wikimedia.org/56207) (owner: 10TTO) [03:41:44] 3MediaWiki / 3User preferences: Simple accessibility preferences - 10https://bugzilla.wikimedia.org/70879#c1 (10Quiddity) There's a wireframe mockup idea, and some notes, at https://www.mediawiki.org/wiki/Talk:Requests_for_comment/Redesign_user_preferences#The_Appearance_menu Ideally it would Not be in Spe... [03:42:44] (03CR) 10Legoktm: Check content model instead of title (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/160605 (owner: 10Jackmcbarn) [03:44:04] (03CR) 10Jackmcbarn: Check content model instead of title (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/160605 (owner: 10Jackmcbarn) [03:45:59] 3Wikimedia / 3Interwiki links: Make interwiki links in br.wikimedia.org point to Portuguese projects iunstead of Breton - 10https://bugzilla.wikimedia.org/53011#c4 (10This, that and the other (TTO)) 5PATC>3NEW Will be fixed once interwiki.cdb is synched. [03:46:14] 3Wikimedia / 3Interwiki links: [[w:]] on betawikiversity points to https://beta.wikipedia.org which doesn't exist - 10https://bugzilla.wikimedia.org/55733#c4 (10This, that and the other (TTO)) 5PATC>3NEW Will be fixed once interwiki.cdb is synched. [03:48:56] (03CR) 10Tim Starling: [C: 04-1] "I don't agree with bug 43027 -- I think all two- and three-letter codes are reserved for future ISO 639 additions. The complaint on the bu" [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/141099 (https://bugzilla.wikimedia.org/43027) (owner: 10TTO) [03:48:59] 3MediaWiki / 3Language converter: Language setting keeps resetting itself at kk: - 10https://bugzilla.wikimedia.org/64440#c9 (10This, that and the other (TTO)) [1] looks suspicious. No other language converters set $wgLanguageCode... [1] http://git.wikimedia.org/blob/mediawiki%2Fcore.git/38d7a2abf1a94b3f637... [03:50:38] (03CR) 10TTO: "Fair enough. I'm tempted to WONTFIX that bug now I look back at it." [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/141099 (https://bugzilla.wikimedia.org/43027) (owner: 10TTO) [03:54:16] (03CR) 10Jackmcbarn: Check content model instead of title (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/160605 (owner: 10Jackmcbarn) [03:56:24] (03CR) 10Tim Starling: [C: 04-1] "Please add test cases for plus signs, encoded both as + and %2B." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151221 (https://bugzilla.wikimedia.org/69026) (owner: 10MaxSem) [03:56:30] 3MediaWiki / 3MediaWiki UI: Styles conflicting with GettingStarted modal buttons - 10https://bugzilla.wikimedia.org/70801 (10Matthew Flaschen) [03:57:26] (03PS4) 10Yurik: Added FormatJson::parse( $value, $options = 0 ) returning Status [core] - 10https://gerrit.wikimedia.org/r/160541 [03:57:47] (03PS6) 10Yurik: abstract CodeContent, reworked JsonContent [core] - 10https://gerrit.wikimedia.org/r/160575 [04:00:55] (03CR) 10MaxSem: "Honestly, I shudder every time I see Status. Maybe, just throw an exception?" [core] - 10https://gerrit.wikimedia.org/r/160541 (owner: 10Yurik) [04:01:29] MaxSem, i would much rather print it properly [04:01:43] exception still needs to be converted to a message [04:01:47] might as well use status [04:02:14] plus it already has value inside [04:02:23] there's nothing preventing you from making a localized exception [04:02:31] why do you object to them? seems like a good concept though [04:02:44] Status is a horrible, horrible thing [04:02:58] why is it horrible? [04:03:33] class JsonException extends Exception { function __construct($code){ switch($code) {...} } [04:04:11] MaxSem, we either use them, or we don't use them. I think exceptions in the grand schem of things might be better structurally, but we are already in the status model, without much code actually having exception handling. Thus, we would have to start wrapping everything in try/catch, which is a paint [04:04:13] pain [04:04:14] 3Wikimedia / 3Deployment systems: LocalisationUpdate failed: mwversionsinuse returned empty list - 10https://bugzilla.wikimedia.org/70844#c2 (10Bryan Davis) 5NEW>3RESO/FIX Looks to be fixed now [04:06:15] (03CR) 10Mattflaschen: [C: 04-1] "OK, I don't think we can keep styles that simply apply unconditionally for the semantic classes like mw-ui-progressive." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/155856 (https://bugzilla.wikimedia.org/69212) (owner: 10SG) [04:06:27] (03CR) 10Tim Starling: [C: 04-1] "I suggest using MapCacheLRU instead of doing it yourself. It evicts the least recently used item rather than the least recently added, whi" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/145625 (owner: 10Jackmcbarn) [04:06:56] so max, either we as a foundation, decide to abandon the status model and migrate to proper exception handling, or we keep the existing codebase and follow the current model. The worst thing is to have a patchwork of multiple approaches [04:07:45] (03CR) 10Mattflaschen: "If mw-ui-anchor is the wrong term, or over-specific, we can find another term, it's just that applying styles to the mw-ui-constructive, e" [core] - 10https://gerrit.wikimedia.org/r/155856 (https://bugzilla.wikimedia.org/69212) (owner: 10SG) [04:13:26] (03PS4) 10Santhosh: Publishing: Get revision id from Parsoid content-revision-id header [services/cxserver] - 10https://gerrit.wikimedia.org/r/160059 (https://bugzilla.wikimedia.org/70755) (owner: 10Jsahleen) [04:13:49] (03PS5) 10Santhosh: Publishing: Get revision id from Parsoid content-revision-id header [services/cxserver] - 10https://gerrit.wikimedia.org/r/160059 (https://bugzilla.wikimedia.org/70755) (owner: 10Jsahleen) [04:15:06] yurikR: I wonder if it might just be that status is very inflexible (only messages can go inside them, no support for custom values beyond setting the $value member manually, etc.), in which case it might just be a good idea to make it more flexible (possibly in a backwards compatible manner) [04:18:43] (03CR) 10Santhosh: [C: 04-1] Publishing: Get revision id from Parsoid content-revision-id header (031 comment) [services/cxserver] - 10https://gerrit.wikimedia.org/r/160059 (https://bugzilla.wikimedia.org/70755) (owner: 10Jsahleen) [04:19:22] wctaiwan, could you elaborate on what you are thinking about in terms of flexibility? Statuses can be inherited just fine (and are being inherited). And also, please note that sometimes it is a good idea to have warnings rather than errors - status being ok and having warnings [04:19:48] (03PS5) 10Jackmcbarn: Improve performance of PHP ustring [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/145625 [04:20:25] TimStarling: ^ [04:21:48] (03CR) 10Tim Starling: [C: 032] Improve performance of PHP ustring [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/145625 (owner: 10Jackmcbarn) [04:22:46] yurikR: off the top of my head, pretty much what I said in the parentheses--error messages require a message key (so it's not exactly intuitive to use them internally, where errors may be handled differently than printing a message), the $value member seems to be a catch-all "if you need some extra information, put it here" sort of thing that's pretty messy. [04:23:42] (03Merged) 10jenkins-bot: Improve performance of PHP ustring [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/145625 (owner: 10Jackmcbarn) [04:23:43] wctaiwan, from my understanding, the value is for the success data, not for the error (although it can be used that way too) [04:24:05] s/error messages/error statuses/ [04:24:33] so.. yeah; I mean, it's a nice idea, but it's not exactly flexible (though I agree doing everything over with exceptions would be "fun" in a bad way) [04:25:10] wctaiwan, i do agree that statuses are not very well optimized towards internal consumption, but rather more user-facing [04:25:33] but on the other hand, in order to handle some internal error condition, you might as well look at the error code [04:25:46] because otherwise you have to introduce some "error status" object that describes it [04:26:22] and having error messages with parameters might actually be used in that way too - i don't think status does i18n message rendering until requested [04:27:16] what error code? [04:27:19] (03PS6) 10Jsahleen: Publishing: Get revision id from Parsoid content-revision-id header [services/cxserver] - 10https://gerrit.wikimedia.org/r/160059 (https://bugzilla.wikimedia.org/70755) [04:27:24] so as a result, you get back this status object with parameters that describes what has happened, and you can analyze and handle it appropriatelly. [04:27:32] wctaiwan, the message code [04:27:33] that's sort of the issue I faced; the API gives an error code, which I can't just feed to a status object. [04:27:45] right, so you're sort of abusing it. [04:27:50] it's supposed to be a message, except it isn't. [04:27:57] it works, but it's messy. [04:27:58] that's because when api was written, we didn't have statuses [04:28:12] not exactly [04:28:20] well, maybe, but error codes make sense for internal consumption. [04:28:27] it may not always make sense to have an error message [04:28:31] but Status pretty much requires it [04:28:32] the subsystem reports an error via a message code and parameters for it [04:28:57] not really - if there is no i18n message, it simply renders it as [04:29:25] i think statuses are actually very benefitial - each subsystem is required to document all of its exit codes by the means of en.json & qqq.json [04:29:37] and each error can be both internal and external [04:29:46] and automatically renderable to the end-user [04:30:09] or it can be handled internally, because it hasn't been converted to one string yet [04:30:56] I disagree; if something is never going to be shown to the user, we shouldn't require people to write messages for it (and anything in en.json would be localisable on translatewiki) [04:31:15] and what you said was that we don't handle it properly in the api (agree), and if we did, it would have been a much easier way to handle it and consume api internally [04:31:39] wctaiwan, perhaps, but the question is - how many of those cases do we have? [04:32:18] is it more common to have some error condition from a subsystem that might need to be reported, or do we have most of the cases where status returns but we don't need a localization [04:32:25] a lot? for example, the API may have failed because we've run out of cheese. In one case, we may want to print "we have run out of cheese", in another, we might instead want "there is no cheese left" [04:32:45] more concrete pleae :) [04:33:03] what cheese are you talking about? a real example pls [04:33:26] and btw, almost ALL of the api errors need to be localized [04:33:45] because the consumer of those messages - client apps or javascript, frequently show that stuff to the end user [04:34:27] and if you look at the api change proposal, proper error reporting is part of it, and it perfectly maps to the statuses / i18n error-codes [04:34:29] anomie is working on localisation of error messages I think. [04:34:49] https://www.mediawiki.org/wiki/Requests_for_comment/API_roadmap#Internationalizing_API_warnings_and_errors [04:34:51] maybe, but I'm saying that the error message may be context dependent, may require further processing before it's shown, and shoving it down every use case's throat / forcing consumers to use message keys for error codes is just not ideal [04:35:42] and yes, that works for API, but what about internal code? [04:35:48] wctaiwan, but that's my point - please give an example of a common case when this would be bad [04:36:18] I'll see if the example still exists in massmessage. I definitely encountered this, though I might have worked around it. [04:38:28] yurikR: https://github.com/wikimedia/mediawiki-extensions-MassMessage/blob/master/includes/content/MassMessageListContentHandler.php#L136 [04:38:43] I ended up using an errors array. [04:40:27] in that case, the error message would have been different if the error was shown next to a quick-add form ("The site is invalid") or if it was shown after submitting multiple targets, and in the case of the API, the errors are returned as attributes of each entry and not printed. [04:41:51] wctaiwan, sorry, not sure i understand - context? [04:42:10] the function I linked to is called in multiple contexts [04:42:32] 1. to validate one single target the user has input 2. to validate multiple targets in a list 3. to validate multiple targets in an API request [04:42:48] the error handling would be different for all three contexts [04:42:57] and it wouldn't make sense to have one message that covers all three. [04:43:29] ok, so you return an array of errors, rigth? [04:43:33] right [04:43:46] it would have been a status if I could just put an array of error codes in it.. [04:43:46] can you return that array with status? [04:43:49] (03PS7) 10Santhosh: Publishing: Get revision id from Parsoid content-revision-id header [services/cxserver] - 10https://gerrit.wikimedia.org/r/160059 (https://bugzilla.wikimedia.org/70755) (owner: 10Jsahleen) [04:43:53] you can :) [04:43:58] yes, but the things can't be printed [04:44:01] they're not really messages [04:44:06] you get [04:44:30] I ended up doing the raw array because I wasn't comfortable misusing Status like that. [04:45:05] (also, it might very well work, but it wouldn't be meaningful to call getWikitext or whatever it is that Status has on something that isn't a message) [04:45:22] (03CR) 10Santhosh: [C: 032] Publishing: Get revision id from Parsoid content-revision-id header [services/cxserver] - 10https://gerrit.wikimedia.org/r/160059 (https://bugzilla.wikimedia.org/70755) (owner: 10Jsahleen) [04:45:50] (03Merged) 10jenkins-bot: Publishing: Get revision id from Parsoid content-revision-id header [services/cxserver] - 10https://gerrit.wikimedia.org/r/160059 (https://bugzilla.wikimedia.org/70755) (owner: 10Jsahleen) [04:45:58] but if this is your internal code, that's fine -- afterall, statuses are much better when you have subsystems communicating with each other, not one func from another inside one subsystem. You don't have to use statuses for that, and you are not [04:47:25] statuses tend to help us with most cases where we send things off, e.g. save page, validate content, read database - it works fine for all those cases [04:47:32] right; it comes down to whether you're willing to repurpose it for something it wasn't designed for. [04:47:45] I'm not saying they shouldn't be used, just that they're not really flexible enough for all use cases. [04:48:34] but you don't have to repurpose them in this case - you have your custom statuses, and that's fine. If you really wanted to make your function available to other extensions, you would probably want to use i18n status codes [04:49:01] in which case you document them and put them into i18n, thus they become somewhat permanent [04:49:35] in other words, i think that we can treat error message codes as simply error-codes [04:49:48] and i18n files is the documentation for those codes [04:50:02] that's where we differ, I think; I think if the class documentation says it should be a message code, it should be a message code (and not just an error code) [04:50:13] s/message code/message key/ [04:50:46] sorry, lets call it "status key" :) [04:51:41] point is, if its a separate subsystem, we should have a simple way to 1) analyze for it (by doing code === code), 2) get additional parameters, 3) render it to the user [04:52:28] on top of that, we can have warnings (which cannot be easily represented by the exceptions system) [04:52:47] in warnings, you have identical requirements, but also a valid result value [04:53:25] (03CR) 10Tim Starling: [C: 04-1] "It looks too slow to be usable to me. MWCryptRand can take a very long time on some systems. IIRC there was a bug report when we first dep" [core] - 10https://gerrit.wikimedia.org/r/148442 (https://bugzilla.wikimedia.org/28419) (owner: 10Parent5446) [04:56:27] (03CR) 10Yurik: "I would much rather not introduce exceptions into this. If you search for those JSON error codes among extensions, some of them already do" [core] - 10https://gerrit.wikimedia.org/r/160541 (owner: 10Yurik) [05:06:00] 3MediaWiki / 3Special pages: ChangeEmail does not always allow you to cancel if you have an invalid email - 10https://bugzilla.wikimedia.org/70676 (10Matthew Flaschen) a:3Rohan Rawat [05:09:31] (03PS1) 10Yurik: CSV content handler [core] - 10https://gerrit.wikimedia.org/r/160610 [05:35:29] (03Abandoned) 10Parent5446: Replaced hash_equals with a custom function [core] - 10https://gerrit.wikimedia.org/r/148442 (https://bugzilla.wikimedia.org/28419) (owner: 10Parent5446) [05:36:38] (03CR) 10Mattflaschen: ""adds an interface message which no one has been able to provide _single example of_ on other login forms, suggesting it's not a commonly " [core] - 10https://gerrit.wikimedia.org/r/110279 (https://bugzilla.wikimedia.org/47694) (owner: 10Bartosz Dziewoński) [05:41:14] 3MediaWiki / 3User login and signup: "Remember me" on Login interface should state duration - 10https://bugzilla.wikimedia.org/47694#c65 (10Matthew Flaschen) Created attachment 16479 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16479&action=edit Google 2-factor "remember me" text (In reply to Matt... [05:41:24] (03PS1) 10Legoktm: Add tests for CentralAuthUser::getHomeWiki() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/160611 [05:41:53] (03CR) 10jenkins-bot: [V: 04-1] Add tests for CentralAuthUser::getHomeWiki() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/160611 (owner: 10Legoktm) [05:43:05] (03PS2) 10SG: Introduce flowSpawnedBy handler to forward events from outside of FlowComponent [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160483 [05:43:08] (03PS1) 10SG: Implement mw-ui-modal and remove jquery.ui usage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160612 [05:43:42] (03CR) 10jenkins-bot: [V: 04-1] Introduce flowSpawnedBy handler to forward events from outside of FlowComponent [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160483 (owner: 10SG) [05:43:56] (03CR) 10jenkins-bot: [V: 04-1] Implement mw-ui-modal and remove jquery.ui usage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160612 (owner: 10SG) [05:44:36] (03CR) 10Mattflaschen: "Matt Walker cited, "But if you have two factor auth; it then gives you a new form that specifically says "Remember this computer for 30 da" [core] - 10https://gerrit.wikimedia.org/r/110279 (https://bugzilla.wikimedia.org/47694) (owner: 10Bartosz Dziewoński) [05:47:16] * km grumbles [05:49:54] (03PS3) 10SG: Introduce flowSpawnedBy handler to forward events from outside of FlowComponent [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160483 [05:50:49] (03PS2) 10SG: Implement mw-ui-modal and remove jquery.ui usage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160612 [05:51:24] (03CR) 10jenkins-bot: [V: 04-1] Implement mw-ui-modal and remove jquery.ui usage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160612 (owner: 10SG) [05:52:02] (03PS2) 10Legoktm: Add tests for CentralAuthUser::getHomeWiki() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/160611 [05:52:28] (03CR) 10jenkins-bot: [V: 04-1] Add tests for CentralAuthUser::getHomeWiki() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/160611 (owner: 10Legoktm) [05:53:21] (03CR) 10Legoktm: "I don't see why this is failing...it should be mocked properly..." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/160611 (owner: 10Legoktm) [05:55:37] (03PS3) 10SG: Implement mw-ui-modal and remove jquery.ui usage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160612 [05:55:46] (03PS3) 10Dan-nl: Special:Import not importing Special:Export XMLs [core] - 10https://gerrit.wikimedia.org/r/159973 (https://bugzilla.wikimedia.org/66023) [05:56:11] (03CR) 10jenkins-bot: [V: 04-1] Implement mw-ui-modal and remove jquery.ui usage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160612 (owner: 10SG) [05:57:36] (03PS4) 10SG: Implement mw-ui-modal and remove jquery.ui usage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160612 [05:59:36] (03PS2) 10Legoktm: More tests and regression fix [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/146987 (owner: 10CSteipp) [05:59:44] (03CR) 10Tim Starling: "I'm not really sure about the idea of passing $unsafe to the closure by modifying a reference to a static variable. In isolation at least," (031 comment) [core] - 10https://gerrit.wikimedia.org/r/152889 (https://bugzilla.wikimedia.org/57909) (owner: 10Anomie) [06:00:33] (03CR) 10Legoktm: [C: 032] "PS2: Rebased." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/146987 (owner: 10CSteipp) [06:01:07] (03Merged) 10jenkins-bot: More tests and regression fix [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/146987 (owner: 10CSteipp) [06:01:19] (03CR) 10Legoktm: "Is there a bug / reason behind this change?" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143192 (owner: 10CSteipp) [06:04:44] (03PS3) 10Tim Starling: Improve Parser::replaceUnusualEscapes [core] - 10https://gerrit.wikimedia.org/r/152889 (https://bugzilla.wikimedia.org/57909) (owner: 10Anomie) [06:05:05] (03CR) 10Tim Starling: [C: 04-1] "Needs unit test." [core] - 10https://gerrit.wikimedia.org/r/152889 (https://bugzilla.wikimedia.org/57909) (owner: 10Anomie) [06:05:11] (03CR) 10jenkins-bot: [V: 04-1] Improve Parser::replaceUnusualEscapes [core] - 10https://gerrit.wikimedia.org/r/152889 (https://bugzilla.wikimedia.org/57909) (owner: 10Anomie) [06:07:49] (03CR) 10Legoktm: [C: 04-1] "Hmm, this means we're now storing GadgetDefinitionContent objects in memcache...I don't think I like that." [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160431 (owner: 10Legoktm) [06:09:59] 3MediaWiki / 3MediaWiki UI: MediaWiki UI styles are applied to core instead of relevant skins - 10https://bugzilla.wikimedia.org/70351#c12 (10Matthew Flaschen) (In reply to Isarra from comment #11) > That being said, this also comes up with regard to js gadgets, which will > often use special buttons even wh... [06:12:17] (03PS8) 10Legoktm: Add some basic tests for LocalGadgetRepo & ForeignDBGadgetRepo [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160432 [06:17:59] 3MediaWiki-Vagrant: hhvmsh does not load MediaWiki's context - 10https://bugzilla.wikimedia.org/69420#c1 (10Matthew Flaschen) 5NEW>3RESO/FIX This is apparently fixed. [06:22:14] 3MediaWiki / 3User login and signup: Login as another user no longer works - 10https://bugzilla.wikimedia.org/70855#c12 (10Jon) https://bugzilla.wikimedia.org/show_bug.cgi?id=49890 There was discussion on mailing lists about killing this behaviour. [06:23:37] (03PS3) 10EBernhardson: Hygiene: Autogenerate wgAutoloadClasses code from Makefile [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160258 [06:30:08] (03Draft1) 10Physikerwelt: Add user feedback [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/160613 [06:30:15] (03PS2) 10Physikerwelt: Add user feedback [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/160613 [06:31:54] (03PS4) 10EBernhardson: Hygiene: Autogenerate wgAutoloadClasses code from Makefile [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160258 [06:32:34] (03PS4) 10EBernhardson: Hygiene: Various small cleanups [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160191 [06:32:40] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Autogenerate wgAutoloadClasses code from Makefile [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160258 (owner: 10EBernhardson) [06:33:20] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Various small cleanups [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160191 (owner: 10EBernhardson) [06:33:46] (03CR) 10Gilles: [C: 04-1] Move setSkipTutorialPreference to Tutorial class (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153413 (owner: 10MarkTraceur) [06:33:49] (03CR) 10EBernhardson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160258 (owner: 10EBernhardson) [06:34:24] (03CR) 10Gilles: [C: 04-1] Make tutorial step a controller and UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 (owner: 10MarkTraceur) [06:34:57] (03CR) 10EBernhardson: "qunit failure appears unrelated" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160258 (owner: 10EBernhardson) [06:36:07] (03PS3) 10EBernhardson: Hygiene: Remove duplication passing user data around [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160259 [06:36:51] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove duplication passing user data around [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160259 (owner: 10EBernhardson) [06:37:35] (03CR) 10Gilles: [C: 04-1] Add model base class, description model [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/121308 (owner: 10MarkTraceur) [06:40:17] (03PS4) 10EBernhardson: Hygiene: Remove duplication passing user data around [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160259 [06:40:20] (03PS5) 10EBernhardson: Hygiene: Various small cleanups [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160191 [06:40:23] (03PS5) 10EBernhardson: Hygiene: Autogenerate wgAutoloadClasses code from Makefile [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160258 [06:40:26] (03PS4) 10EBernhardson: Hygiene: Restructure Flow\\Data namepace for clarity [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160260 [07:00:04] (03PS1) 10Yurik: When cloning TextContent, include model [core] - 10https://gerrit.wikimedia.org/r/160614 [07:46:45] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT).. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/70205 (owner: 10Hashar) [07:53:46] (03PS1) 10Legoktm: Throw a "MWException" instead of the non-existent "MWError" [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/160615 [08:12:59] (03CR) 10Gilles: Add Special:MediaStatistics page for file type stats (031 comment) [core] - 10https://gerrit.wikimedia.org/r/150131 (owner: 10Brian Wolff) [08:19:54] (03CR) 10Gilles: Add Special:MediaStatistics page for file type stats (031 comment) [core] - 10https://gerrit.wikimedia.org/r/150131 (owner: 10Brian Wolff) [08:21:14] (03CR) 10Gilles: [C: 032] Split BitmapHandler into two classes. [core] - 10https://gerrit.wikimedia.org/r/147718 (owner: 10Brian Wolff) [08:21:24] (03CR) 10Gilles: [C: 04-1] "Needs rebase" [core] - 10https://gerrit.wikimedia.org/r/149791 (owner: 10Brian Wolff) [08:24:05] (03CR) 10Filippo Giunchedi: [C: 031] Add script to squash deletes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/160473 (owner: 10Manybubbles) [08:27:50] (03Merged) 10jenkins-bot: Split BitmapHandler into two classes. [core] - 10https://gerrit.wikimedia.org/r/147718 (owner: 10Brian Wolff) [08:28:44] 3MediaWiki / 3Export/Import: Importing does not work with HHVM - 10https://bugzilla.wikimedia.org/66023#c9 (10dan) 5ASSI>3PATC https://gerrit.wikimedia.org/r/#/c/159973/ [08:31:45] 3MediaWiki skins / 3Chameleon: Installing Chameleon messes up vector - 10https://bugzilla.wikimedia.org/65756#c3 (10s7eph4n) 5UNCO>3RESO/FIX Fixed in I85f3f758ec4603cb983091cd422830080b689ff2 [08:42:03] (03PS1) 10Legoktm: Add tests for SpoofUser [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/160617 [08:42:11] (03CR) 10jenkins-bot: [V: 04-1] Add tests for SpoofUser [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/160617 (owner: 10Legoktm) [08:45:03] (03PS2) 10Legoktm: Add tests for SpoofUser [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/160617 [08:45:10] (03CR) 10jenkins-bot: [V: 04-1] Add tests for SpoofUser [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/160617 (owner: 10Legoktm) [08:45:15] (03Abandoned) 10Hashar: Allows reuse of extension checkout [tools/release] - 10https://gerrit.wikimedia.org/r/92043 (owner: 10MarkAHershberger) [08:45:19] (03Abandoned) 10Hashar: Clean up [tools/release] - 10https://gerrit.wikimedia.org/r/92044 (owner: 10MarkAHershberger) [08:48:11] (03PS3) 10Legoktm: Add tests for SpoofUser [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/160617 [08:48:18] (03CR) 10jenkins-bot: [V: 04-1] Add tests for SpoofUser [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/160617 (owner: 10Legoktm) [08:56:59] (03PS4) 10Legoktm: Add tests for SpoofUser [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/160617 [08:57:07] (03CR) 10jenkins-bot: [V: 04-1] Add tests for SpoofUser [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/160617 (owner: 10Legoktm) [09:01:23] (03PS5) 10Legoktm: Add tests for SpoofUser [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/160617 [09:04:02] (03CR) 10Hashar: [C: 04-1] "The constant values are not used in the test, and I don't think we want to have it hardcoded in the test. So I guess they should be remove" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/159159 (https://bugzilla.wikimedia.org/70570) (owner: 10Dan-nl) [09:04:51] (03CR) 10Gilles: [C: 031] Add Special:MostGloballyLinkedFiles (global version Special:Mostimages) [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/143755 (owner: 10Brian Wolff) [09:06:01] (03CR) 10Legoktm: Bug 31256: a way to customize the AntiSpoof blacklist (031 comment) [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/47902 (owner: 10MaxSem) [09:13:14] (03CR) 10Bartosz Dziewoński: [C: 032] Throw a "MWException" instead of the non-existent "MWError" [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/160615 (owner: 10Legoktm) [09:13:19] (03Merged) 10jenkins-bot: Throw a "MWException" instead of the non-existent "MWError" [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/160615 (owner: 10Legoktm) [09:21:27] (03PS1) 10Legoktm: Refactor SpoofTest [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/160621 [09:26:45] 3MediaWiki / 3User preferences: Simple accessibility preferences - 10https://bugzilla.wikimedia.org/70879 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc [09:27:54] (03CR) 10Aude: [C: 031] "this works for me, verified that i no longer get timeouts :)" [vagrant] - 10https://gerrit.wikimedia.org/r/160571 (https://bugzilla.wikimedia.org/70843) (owner: 10Dduvall) [09:58:31] 3Wikimedia / 3Git/Gerrit: Run git gc --aggressive for mediawiki-extensions-Wikibase.git - 10https://bugzilla.wikimedia.org/70883 (10Aude) 3NEW p:3Unprio s:3normal a:3None the contents of .git in the Wikibase repo are 45 M. I think this can be cleaned up, for example by running "git gc --aggressive",... [09:58:59] 3Wikimedia / 3Git/Gerrit: Run git gc --aggressive for mediawiki-extensions-Wikibase.git - 10https://bugzilla.wikimedia.org/70883#c1 (10Aude) some of the other things suggested in rallydev.com/community/engineering/shrinking-git-repository-move-githubcom might be helpful and desirable, also. [10:05:08] (03CR) 10Addshore: [C: 032] Add tests for SpoofUser [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/160617 (owner: 10Legoktm) [10:05:17] (03Merged) 10jenkins-bot: Add tests for SpoofUser [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/160617 (owner: 10Legoktm) [10:06:19] (03CR) 10Addshore: [C: 032] Refactor SpoofTest [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/160621 (owner: 10Legoktm) [10:06:27] (03Merged) 10jenkins-bot: Refactor SpoofTest [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/160621 (owner: 10Legoktm) [10:09:54] qgil: around? [10:11:05] (03CR) 10Addshore: Add tests for CentralAuthUser::getHomeWiki() (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/160611 (owner: 10Legoktm) [10:12:44] (03CR) 10Addshore: [C: 04-1] "per comments on the PS" [core] - 10https://gerrit.wikimedia.org/r/152821 (owner: 10Legoktm) [10:15:17] 3MediaWiki extensions / 3SemanticForms: SemanticForms should pass jshint - 10https://bugzilla.wikimedia.org/61630#c6 (10Antoine "hashar" Musso) 5PATC>3RESO/FIX Thanks Yaron! It even has a .jshintrc file. I have made the Jenkins job voting :-) [10:17:20] (03CR) 10Helder.wiki: mediawiki.api.options: New module for user preferences API (action=options) (032 comments) [core] - 10https://gerrit.wikimedia.org/r/160308 (owner: 10Bartosz Dziewoński) [10:18:09] (03PS3) 10TTO: Add additional interwiki links as requested in various bugs [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/141099 (https://bugzilla.wikimedia.org/16962) [10:19:59] 3Wikimedia / 3Git/Gerrit: Free-form tagging in gerrit - 10https://bugzilla.wikimedia.org/35534#c24 (10Seb35) (In reply to Nemo from comment #23) > (In reply to Seb35 from comment #21) > > but it’s already > > possible to change the topic after the commit. See > > https://gerrit.wikimedia.org/r/#/c/160022/ fo... [10:20:28] (03CR) 10Calak: [C: 031] Add additional interwiki links as requested in various bugs [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/141099 (https://bugzilla.wikimedia.org/16962) (owner: 10TTO) [10:30:28] .rsnews 3 [10:30:35] !rsnews 3 [10:30:42] !news 3 [10:30:42] There is no such key, you probably want to try: !?>, !technews, !technext, [10:30:52] oops wrong channel... [10:32:14] 3Wikimedia / 3OTRS: Create OTRS patch for "1-click spam" disposal - 10https://bugzilla.wikimedia.org/54755#c10 (10Nemo) FWIW, in OTRS I usually use bulk actions after mass-checking the spam mails with an extension like https://addons.mozilla.org/firefox/addon/checkfox/ (Probably obvious to many but not to a... [10:37:29] 3Wikimedia / 3Git/Gerrit: Run git gc --aggressive for mediawiki-extensions-Wikibase.git - 10https://bugzilla.wikimedia.org/70883#c2 (10Chad H.) There is no aggressive option...gerrit gc != git gc. But yes, we can run gerrit gc. [10:53:44] 3Wikimedia / 3Git/Gerrit: Run git gc --aggressive for mediawiki-extensions-Wikibase.git - 10https://bugzilla.wikimedia.org/70883#c3 (10Aude) if gerrit gc does the trick, then sounds good and worth a try :) [11:01:59] 3Wikimedia / 3Site requests: Enable 'Comments' namespace at Test.Wikipedia.org - 10https://bugzilla.wikimedia.org/67573#c6 (10This, that and the other (TTO)) 5UNCO>3RESO/WON No reply -> closing. [11:03:44] 3MediaWiki / 3Export/Import: Special:Import needs to update site statistics - 10https://bugzilla.wikimedia.org/5703#c25 (10This, that and the other (TTO)) 5UNCO>3RESO/WOR (In reply to This, that and the other (TTO) from comment #24) > Setting to unconfirmed. No reports of this issue since 2010. Is this i... [11:07:46] 3MediaWiki extensions / 3Gadgets: Gadget usage statistics - 10https://bugzilla.wikimedia.org/19288 (10Helder) [11:10:16] 3MediaWiki extensions / 3Translate: Optimize Special:SupportedLanguages - 10https://bugzilla.wikimedia.org/52728#c10 (10Nemo) *** Bug 59497 has been marked as a duplicate of this bug. *** [11:22:45] 3MediaWiki / 3JavaScript: [jquery.textSelection] Select sample text when splitlines is true - 10https://bugzilla.wikimedia.org/70764#c3 (10Bartosz Dziewoński) 5UNCO>3NEW Hmm. Okay, that's actually reasonable. [11:23:14] 3MediaWiki / 3JavaScript: [jquery.textSelection] Select sample text when splitlines is true - 10https://bugzilla.wikimedia.org/70764 (10Bartosz Dziewoński) [11:41:14] 3MediaWiki / 3Recent changes: Make enhanced recentchanges the default - 10https://bugzilla.wikimedia.org/35785 (10Nemo) [11:43:43] (03PS8) 10Dan-nl: Add cURL constants test [core] - 10https://gerrit.wikimedia.org/r/159159 (https://bugzilla.wikimedia.org/70570) [11:44:18] (03CR) 10Dan-nl: "* addressed comments in ps8 code." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/159159 (https://bugzilla.wikimedia.org/70570) (owner: 10Dan-nl) [11:50:30] Hi! I've got a short question about OOJS UI. [11:50:34] I tried to follow the manual at https://www.mediawiki.org/wiki/OOjs_UI#Showing_a_dialog. But it seems that the call to "dlg.show()" fails because there is no such method in the "OO.ui.MessageDialog" class. [11:50:37] Can someone give me a hint? [11:52:59] The official DEMO files suggest a call to "openWindow" on the WindowManager instance. [11:53:36] https://git.wikimedia.org/blob/oojs%2Fui.git/8f511ff2bdb1942509c13914add7617877b1d5ce/demos%2Fdialogs.js#L316 [12:05:02] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/143755 (owner: 10Brian Wolff) [12:05:13] hi Osnard_ [12:05:43] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/150131 (owner: 10Brian Wolff) [12:06:14] hi YuviPanda ! [12:06:20] Just saw you email [12:06:20] hi qgil [12:06:29] thank you! [12:06:33] qgil: yw! :) anything more to do there? [12:06:35] Osnard_: it's likely that the mediawiki.org page is outdated :( the dialogs/windows code has been rewritten a bit recently [12:06:54] qgil: I don't have access to the prod instance so can't do anything there unfortunately [12:06:58] YuviPanda, let me try to register... [12:07:56] Osnard_: copying what the demo does looks like a good idea to me. [12:08:02] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/160613 (owner: 10Physikerwelt) [12:08:36] YuviPanda, it works. :) Can I has admin please? https://phab-01.wmflabs.org/p/Qgil/ [12:08:48] andre__, ^^^^ [12:09:06] qgil: no RfA process? :) [12:09:08] qgil: you're admin now [12:09:25] Thank you, this is progress. [12:09:28] oh, at least one thing that works. YuviPanda: thank you. [12:09:51] :) [12:10:06] andre__, I will prepare the homepage there with all the disclaimers [12:10:22] qgil: I'll be around for another couple of hours if you guys need anything [12:10:29] 3MediaWiki extensions / 3WikidataRepo: adapt entity suggester to new dump format - 10https://bugzilla.wikimedia.org/70335 (10Lydia Pintscher) [12:11:24] andre__, I promise not to post anything valuable in this Labs instance ;) [12:11:34] but I will start sending users willing to learn / test [12:11:49] haha [12:11:52] sounds good [12:11:58] with the same instructions: not to post anything that cannot be simply removed without any notice [12:12:02] * andre__ also registered now as 'aklapper' [12:12:04] qgil: andre__ note that if you have https *blocked*, you won't see CSS/JS. [12:12:12] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/160610 (owner: 10Yurik) [12:12:22] the alternative was non-working https, so I set it up this way instead. [12:12:31] it doesn't use protocol relative uris, causing these kinda issues [12:12:44] shouldn't cause many practical problems tho [12:12:51] (03PS12) 10Jamesmontalvo3: Add file approval and fine-tuned permissions; bump to v1.0 [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 [12:12:51] works for me, works for Labs YuviPanda [12:12:57] cool [12:13:54] (03CR) 10Jamesmontalvo3: "For review of the patch I just submitted please see comments submitted yesterday, Sept 15." [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [12:15:38] (03CR) 10Matthias Mullie: [C: 04-1] "1 nitpick." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160483 (owner: 10SG) [12:16:56] (03PS4) 10Matthias Mullie: Introduce flowSpawnedBy handler to forward events from outside of FlowComponent [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160483 (owner: 10SG) [12:18:08] (03CR) 10Matthias Mullie: [C: 032] Introduce flowSpawnedBy handler to forward events from outside of FlowComponent [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160483 (owner: 10SG) [12:18:41] (03Merged) 10jenkins-bot: Introduce flowSpawnedBy handler to forward events from outside of FlowComponent [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160483 (owner: 10SG) [12:19:55] (03CR) 10Matthias Mullie: Implement mw-ui-modal and remove jquery.ui usage (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160612 (owner: 10SG) [12:20:33] legoktm: are you familiar with code related to global renames? [12:21:29] (03PS1) 10Pwirth: Fixed unparsed greeting messages in mails [extensions/BlueSpiceFoundation] (REL1_22) - 10https://gerrit.wikimedia.org/r/160637 [12:21:52] Helder: To early to reach him [12:22:05] ok [12:22:06] I might be able to help, although I don't plan to be around for ages longer right now [12:22:27] My account was renamed, but it seems the tool didn't move user pages on Commons [12:22:59] hoo: https://commons.wikimedia.org/w/index.php?oldid=131510901 [12:23:22] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [12:23:50] (03CR) 10Matthias Mullie: [C: 032] "I didn't realize those icons were in flow - assumed they were bundled in core." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159480 (owner: 10Matthias Mullie) [12:24:03] (03CR) 10Matthias Mullie: [C: 032] Update WikiFont-Glyphs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160538 (owner: 10EBernhardson) [12:24:55] (03Merged) 10jenkins-bot: Update WikiFont-Glyphs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160538 (owner: 10EBernhardson) [12:24:58] (03Merged) 10jenkins-bot: Change close icon to lock/unlock [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159480 (owner: 10Matthias Mullie) [12:25:21] Helder: I see... some pages were moved, though [12:25:24] https://commons.wikimedia.org/w/index.php?title=User:Helder.wiki&action=history [12:25:34] hoo: yeah, the user and user talk pages were moved correctly in my home wiki for example [12:26:25] 2014-09-15 18:09:29 mw1012 commonswiki: LocalRenameUserJob Global_rename_job from=Helder.wiki to=He7d3r renamer=Vogone movepages=1 suppressredirects= t=58525 good [12:26:36] so everything should went fine [12:27:09] (03PS4) 10Dan-nl: Special:Import not importing Special:Export XMLs [core] - 10https://gerrit.wikimedia.org/r/159973 [12:28:50] (03CR) 10Dan-nl: "* attempted to clean-up line spacing so that strict linting passes." [core] - 10https://gerrit.wikimedia.org/r/159973 (owner: 10Dan-nl) [12:29:34] hoo: were did you get that log entry? [12:29:58] Helder: fluorine, the server that has most of our logs [12:30:31] hum [12:31:11] 2014-09-15 18:09:10 mw1012 commonswiki: Could not move User talk:Helder.wiki to User talk:He7d3r [12:31:39] it doesn't tell me why, though [12:31:39] (03CR) 10Matthias Mullie: [C: 04-1] "Looks mostly good" (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158618 (owner: 10Jdlrobson) [12:31:43] =/ [12:31:56] if ( $newPage->exists() && !$oldPage->isValidMoveTarget( $newPage ) ) { [12:32:39] oh, taht's stupid [12:32:42] but clear :S [12:32:45] of course [12:32:51] https://commons.wikimedia.org/w/index.php?title=User_talk:He7d3r&action=history [12:33:10] you would have to delete that first [12:33:49] :S [12:35:23] hoo: thanks for figuring it out [12:36:20] You're welcome [12:36:34] long term we plan to inform the renamer about such things, but that's not possible yet [12:36:35] hoo: any chance of checking the same logs for other wikis where this could have happend? [12:37:11] 2014-09-15 18:08:51 mw1004 enwikinews: Could not move User talk:Helder.wiki to User talk:He7d3r [12:37:24] 2014-09-15 18:09:10 mw1005 incubatorwiki: Could not move User talk:Helder.wiki to User talk:He7d3r [12:37:45] 2014-09-15 18:09:36 mw1006 metawiki: Could not move User talk:Helder.wiki to User talk:He7d3r [12:38:09] that's it [12:38:30] thanks [12:38:46] I find it strangely satisfying that the host names are mw1004, mw1005 and then mw1006 :P [12:42:00] 3Wikimedia / 3General/Unknown: Install Q&A system at ask.wikimedia.org - 10https://bugzilla.wikimedia.org/29923#c19 (10Quim Gil) ... and now you can try it out at https://phab-01.wmflabs.org/ponder/ [12:44:47] (03CR) 10Siebrand: [C: 032] Revamp classic edit toolbar not to hardcode paths in HTML [core] - 10https://gerrit.wikimedia.org/r/155442 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [12:45:06] :o [12:45:44] 3MediaWiki extensions / 3WikidataRepo: Wrong century rounding is applied when entering Time values - 10https://bugzilla.wikimedia.org/64742 (10Lydia Pintscher) [12:47:43] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (033 comments) [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/158884 (owner: 10Paladox) [12:48:39] (03CR) 10Siebrand: "i18n/L10n reviewed." [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/143828 (owner: 10Brian Wolff) [12:51:22] (03Merged) 10jenkins-bot: Revamp classic edit toolbar not to hardcode paths in HTML [core] - 10https://gerrit.wikimedia.org/r/155442 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [12:59:29] 3MediaWiki extensions / 3WikidataRepo: Do not load full entities when invoking LinkBegin hook - 10https://bugzilla.wikimedia.org/70767 (10Lydia Pintscher) [12:59:44] 3MediaWiki extensions / 3WikidataRepo: Create EntityFingerprintLookup service for use with EntityLabelFormatter and simmilar classes. - 10https://bugzilla.wikimedia.org/68026 (10Lydia Pintscher) [13:04:16] (03CR) 10Siebrand: [C: 032] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/160208 (owner: 10Shirayuki) [13:09:47] (03CR) 10Siebrand: [C: 032] Using ULS in Special:PageLanguage [core] - 10https://gerrit.wikimedia.org/r/153277 (owner: 10Kunalgrover05) [13:10:51] (03Merged) 10jenkins-bot: i18n: improve "tog-hide*" messages [core] - 10https://gerrit.wikimedia.org/r/160208 (owner: 10Shirayuki) [13:12:30] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156488 (https://bugzilla.wikimedia.org/68886) (owner: 10BryanDavis) [13:16:21] (03Merged) 10jenkins-bot: Using ULS in Special:PageLanguage [core] - 10https://gerrit.wikimedia.org/r/153277 (owner: 10Kunalgrover05) [13:19:51] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159331 (https://bugzilla.wikimedia.org/68924) (owner: 10BryanDavis) [13:20:26] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160160 (https://bugzilla.wikimedia.org/60465) (owner: 10EBernhardson) [13:22:27] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [13:24:12] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/158098 (https://bugzilla.wikimedia.org/26546) (owner: 10Jackmcbarn) [13:25:04] (03CR) 10Seb35: [C: 032 V: 032] Version 1.0 [extensions/HSTS] - 10https://gerrit.wikimedia.org/r/160022 (owner: 10Seb35) [13:25:23] (03CR) 10Siebrand: settings: Add help dialog (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/157037 (owner: 10Prtksxna) [13:26:02] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/157037 (owner: 10Prtksxna) [13:26:35] (03CR) 10Siebrand: [C: 032] "i18n/L10n reviewed." [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/157510 (owner: 10Raimond Spekking) [13:26:37] (03CR) 10jenkins-bot: [V: 04-1] Consistency tweak: Wrap variable names into [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/157510 (owner: 10Raimond Spekking) [13:27:27] (03CR) 10Siebrand: [C: 032 V: 032] Change i18n to JSON [extensions/PureWikiDeletion] - 10https://gerrit.wikimedia.org/r/159108 (owner: 10Raimond Spekking) [13:27:58] (03CR) 10Siebrand: [C: 032 V: 032] Change i18n to JSON [extensions/SacredText] - 10https://gerrit.wikimedia.org/r/159107 (owner: 10Raimond Spekking) [13:28:11] (03PS1) 10Physikerwelt: Fix: Counter in math indexing script [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/160646 [13:29:05] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/159090 (owner: 10Raimond Spekking) [13:29:46] (03PS5) 10Dan-nl: Special:Import not importing Special:Export XMLs [core] - 10https://gerrit.wikimedia.org/r/159973 [13:29:52] (03CR) 10Siebrand: [C: 032 V: 032] Change i18n to JSON [extensions/RPED] - 10https://gerrit.wikimedia.org/r/159085 (owner: 10Raimond Spekking) [13:30:28] (03CR) 10Siebrand: [C: 032 V: 032] Change i18n to JSON [extensions/Tooltip] - 10https://gerrit.wikimedia.org/r/159067 (owner: 10Raimond Spekking) [13:30:43] (03CR) 10Dan-nl: "* added a unit test for the single file upload use case." [core] - 10https://gerrit.wikimedia.org/r/159973 (owner: 10Dan-nl) [13:31:17] (03CR) 10Siebrand: [C: 032] Convert i18n to JSON [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/157508 (owner: 10Raimond Spekking) [13:31:22] (03Merged) 10jenkins-bot: Convert i18n to JSON [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/157508 (owner: 10Raimond Spekking) [13:31:58] (03CR) 10Siebrand: [C: 032 V: 032] Standardize extension description message [extensions/RecentActivityFeed] - 10https://gerrit.wikimedia.org/r/159113 (owner: 10Raimond Spekking) [13:32:15] (03CR) 10Seb35: "See I4d972e944a420cb78e48b1449dd9d8f554322bb4 for the version 1.0, similar to this one." [extensions/HSTS] - 10https://gerrit.wikimedia.org/r/82643 (owner: 10Seb35) [13:34:13] (03PS1) 10Matthias Mullie: Use postWithToken [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/160648 [13:34:46] (03CR) 10jenkins-bot: [V: 04-1] Use postWithToken [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/160648 (owner: 10Matthias Mullie) [13:37:09] (03CR) 10jenkins-bot: [V: 04-1] Special:Import not importing Special:Export XMLs [core] - 10https://gerrit.wikimedia.org/r/159973 (owner: 10Dan-nl) [13:37:51] YuviPanda, you helped de-blocking this update that I was asked to send already last Friday. :) Thanks! https://lists.wikimedia.org/pipermail/wikitech-l/2014-September/078642.html [13:38:57] qgil: \o/ [13:39:41] (03PS3) 10Physikerwelt: Add user feedback [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/160613 [13:41:33] (03CR) 10Physikerwelt: "Any updates here?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/130828 (owner: 10Esanders) [13:43:00] YuviPanda, I just realized that I didn't receive the confirmation email to verify the account [13:45:58] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/160613 (owner: 10Physikerwelt) [13:51:02] qgil: oh? [13:52:10] (03CR) 10Ottomata: [C: 031] Add script to squash deletes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/160473 (owner: 10Manybubbles) [13:52:44] 3MediaWiki extensions / 3CirrusSearch: Cirrus unable to find insource:"mazovia.pl" on pl.wp where the phrase occurs in a URL - 10https://bugzilla.wikimedia.org/70873#c1 (10Nik Everett) Its not right but not unexpected. insource:"" segments words in the same way that we segment regular text. I can't think o... [13:53:29] qgil: I'm not sure what's going wrong there [13:58:59] 3MediaWiki extensions / 3Translate: Conflict of Special:MyLanguage: Extension and MW core use the same special page name - 10https://bugzilla.wikimedia.org/69461#c3 (10Lokal_Profil) Any updates on this bug? Translation of special pages are still effectively locked down. [14:01:30] YuviPanda, I don't think it's urgent either [14:01:36] so no worries [14:01:37] cool [14:01:45] I've to go shortly, I can take a look tomorrow / later tonight [14:02:01] 3Wikimedia / 3SSL related: Allow option to uncheck "Always use a secure connection when logged in" at login.wikimedia.org/wiki/Special:Preferences - 10https://bugzilla.wikimedia.org/69319#c6 (10Cometstyles) Its less about it being slow and more about it being irritating..why should you en"forcehttps" on me (... [14:02:25] YuviPanda, Chase had to fight with the mailserver and fab.wmflabs.org in the past, if I recall correctly. Don't worry at all. [14:12:40] (03CR) 10Matthias Mullie: [C: 04-1] "Not sure about the force-logging" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159523 (owner: 10EBernhardson) [14:13:10] (03PS2) 10Jackmcbarn: Use RevisionFromTitle instead of a template callback [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/160572 (https://bugzilla.wikimedia.org/70495) [14:15:55] MatmaRex: Thank you [14:17:18] (03CR) 10Physikerwelt: [C: 032] Add user feedback [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/160613 (owner: 10Physikerwelt) [14:17:51] (03CR) 10Matthias Mullie: [C: 04-1] "1 more nitpick. Looks good otherwise - will merge once phpdoc is updated." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/159395 (https://bugzilla.wikimedia.org/66876) (owner: 10EBernhardson) [14:18:25] (03CR) 10Matthias Mullie: [C: 031] "LGTM; merge after dependency is merged" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159400 (https://bugzilla.wikimedia.org/66876) (owner: 10EBernhardson) [14:19:17] (03CR) 10Matthias Mullie: [C: 032] Auto-focus moderation popup textarea [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160162 (https://bugzilla.wikimedia.org/60196) (owner: 10EBernhardson) [14:19:22] (03CR) 10jenkins-bot: [V: 04-1] Auto-focus moderation popup textarea [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160162 (https://bugzilla.wikimedia.org/60196) (owner: 10EBernhardson) [14:23:31] (03PS2) 10Physikerwelt: Fix: Counter in math indexing script [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/160646 [14:23:38] (03PS6) 10Dan-nl: Special:Import not importing Special:Export XMLs [core] - 10https://gerrit.wikimedia.org/r/159973 [14:24:02] (03CR) 10Physikerwelt: [C: 032] Fix: Counter in math indexing script [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/160646 (owner: 10Physikerwelt) [14:24:12] (03Merged) 10jenkins-bot: Fix: Counter in math indexing script [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/160646 (owner: 10Physikerwelt) [14:24:25] (03CR) 10Anomie: Improve Parser::replaceUnusualEscapes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/152889 (https://bugzilla.wikimedia.org/57909) (owner: 10Anomie) [14:24:43] (03Abandoned) 10Matthias Mullie: Auto-focus moderation popup textarea [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160162 (https://bugzilla.wikimedia.org/60196) (owner: 10EBernhardson) [14:24:46] (03CR) 10Dan-nl: "* don’t understand the failed tests. is there something missing from the test?" [core] - 10https://gerrit.wikimedia.org/r/159973 (owner: 10Dan-nl) [14:25:44] 3MediaWiki extensions / 3Extensions requests: Annotation tool that uses Wikidata concepts to annotate statements from books - 10https://bugzilla.wikimedia.org/57812#c19 (10apsdehal) Here is the project completion report https://www.mediawiki.org/wiki/Wikidata_annotation_tool/project_completion_report [14:26:08] (03CR) 10Matthias Mullie: [C: 032] Fix preview of header edit is extra-narrow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160165 (https://bugzilla.wikimedia.org/67496) (owner: 10EBernhardson) [14:26:46] (03Merged) 10jenkins-bot: Fix preview of header edit is extra-narrow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160165 (https://bugzilla.wikimedia.org/67496) (owner: 10EBernhardson) [14:27:09] (03CR) 10Physikerwelt: "The patch can not be rebased." [extensions/Math] - 10https://gerrit.wikimedia.org/r/64523 (owner: 10TheDJ) [14:27:11] (03CR) 10Matthias Mullie: [C: 032] Output delete/suppress links on locked topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160169 (owner: 10EBernhardson) [14:27:47] (03Merged) 10jenkins-bot: Output delete/suppress links on locked topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160169 (owner: 10EBernhardson) [14:28:18] (03PS4) 10Anomie: Improve Parser::replaceUnusualEscapes [core] - 10https://gerrit.wikimedia.org/r/152889 (https://bugzilla.wikimedia.org/57909) [14:28:27] (03PS5) 10Anomie: Improve/rename Parser::replaceUnusualEscapes [core] - 10https://gerrit.wikimedia.org/r/152889 (https://bugzilla.wikimedia.org/57909) [14:28:29] 3MediaWiki extensions / 3WikidataRepo: DiffViewTest failures on travis! - 10https://bugzilla.wikimedia.org/70659 (10Aude) 5PATC>3RESO/FIX [14:28:54] (03CR) 10Anomie: "PS4: Rebase" [core] - 10https://gerrit.wikimedia.org/r/152889 (https://bugzilla.wikimedia.org/57909) (owner: 10Anomie) [14:29:13] (03CR) 10Matthias Mullie: [C: 032] Dont treat argument as wikitext [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160536 (owner: 10EBernhardson) [14:30:07] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86118 (owner: 10Hashar) [14:30:10] (03PS8) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86118 [14:30:17] (03CR) 10jenkins-bot: [V: 04-1] Special:Import not importing Special:Export XMLs [core] - 10https://gerrit.wikimedia.org/r/159973 (owner: 10Dan-nl) [14:31:29] (03CR) 10Physikerwelt: "It seems that MathJax will not support this in the near future." [extensions/Math] - 10https://gerrit.wikimedia.org/r/4060 (https://bugzilla.wikimedia.org/35186) (owner: 10TheDJ) [14:32:45] (03CR) 10jenkins-bot: [V: 04-1] Dont treat argument as wikitext [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160536 (owner: 10EBernhardson) [14:33:26] (03CR) 10Phuedx: [C: 04-1] "A handful of minor points inline." (035 comments) [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) (owner: 10Jdlrobson) [14:35:12] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86118 (owner: 10Hashar) [14:35:18] (03CR) 10Matthias Mullie: [C: 032] "Script is missing some PHPDoc here and there, but that's ok" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160258 (owner: 10EBernhardson) [14:35:45] (03CR) 10Anomie: "This change caused a PHP warning:" [core] - 10https://gerrit.wikimedia.org/r/155442 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [14:35:52] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Autogenerate wgAutoloadClasses code from Makefile [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160258 (owner: 10EBernhardson) [14:36:14] MatmaRex: ^^ [14:36:40] anomie: bah [14:36:51] i blame legoktm, he told me to do it :> [14:36:59] 3MediaWiki extensions / 3CirrusSearch: Cirrus unable to find insource:"mazovia.pl" on pl.wp where the phrase occurs in a URL - 10https://bugzilla.wikimedia.org/70873 (10Nik Everett) p:5Unprio>3Normal [14:37:15] anomie: brb, will fix in twenty minutes [14:37:29] MatmaRex: Ping me when you do and I'll review it [14:39:09] (03CR) 10Hashar: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160536 (owner: 10EBernhardson) [14:41:00] (03CR) 10Hashar: [C: 032] "gating again. I broke the job temporarily :-D" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160536 (owner: 10EBernhardson) [14:41:36] (03Merged) 10jenkins-bot: Dont treat argument as wikitext [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160536 (owner: 10EBernhardson) [14:42:07] (03CR) 10Hashar: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160258 (owner: 10EBernhardson) [14:42:38] (03CR) 10Anomie: [C: 04-1] "Doesn't work when using Special:TemplateSandbox." [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/160555 (https://bugzilla.wikimedia.org/70495) (owner: 10Jackmcbarn) [14:46:25] (03CR) 10Anomie: Add RevisionFromTitle hook (031 comment) [core] - 10https://gerrit.wikimedia.org/r/160570 (https://bugzilla.wikimedia.org/70495) (owner: 10Jackmcbarn) [14:46:33] (03PS1) 10Bartosz Dziewoński: ResourceLoaderEditToolbarModule: Fix PHP Strict Standards warning [core] - 10https://gerrit.wikimedia.org/r/160660 [14:46:42] anomie: ^ [14:46:51] (03CR) 10Bartosz Dziewoński: "Follow-up: https://gerrit.wikimedia.org/r/160660" [core] - 10https://gerrit.wikimedia.org/r/155442 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [14:47:23] (03CR) 10Jackmcbarn: Add RevisionFromTitle hook (031 comment) [core] - 10https://gerrit.wikimedia.org/r/160570 (https://bugzilla.wikimedia.org/70495) (owner: 10Jackmcbarn) [14:48:29] (03CR) 10Anomie: [C: 032] ResourceLoaderEditToolbarModule: Fix PHP Strict Standards warning [core] - 10https://gerrit.wikimedia.org/r/160660 (owner: 10Bartosz Dziewoński) [14:51:22] (03CR) 10Hashar: [C: 032] "regating. I broke jenkins :-D" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160258 (owner: 10EBernhardson) [14:51:57] (03Merged) 10jenkins-bot: Hygiene: Autogenerate wgAutoloadClasses code from Makefile [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160258 (owner: 10EBernhardson) [14:54:21] (03CR) 10Anomie: [C: 04-1] "Now you've got the preview and Special:TemplateSandbox using different methods for replacing the content. That's probably not a great idea" [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/160572 (https://bugzilla.wikimedia.org/70495) (owner: 10Jackmcbarn) [14:54:50] (03Merged) 10jenkins-bot: ResourceLoaderEditToolbarModule: Fix PHP Strict Standards warning [core] - 10https://gerrit.wikimedia.org/r/160660 (owner: 10Bartosz Dziewoński) [14:56:44] (03PS1) 10Seb35: Version 1.1 [extensions/HSTS] - 10https://gerrit.wikimedia.org/r/160665 [14:57:01] (03CR) 10Anomie: Add RevisionFromTitle hook (031 comment) [core] - 10https://gerrit.wikimedia.org/r/160570 (https://bugzilla.wikimedia.org/70495) (owner: 10Jackmcbarn) [14:57:47] (03CR) 10Jackmcbarn: Add RevisionFromTitle hook (031 comment) [core] - 10https://gerrit.wikimedia.org/r/160570 (https://bugzilla.wikimedia.org/70495) (owner: 10Jackmcbarn) [14:58:58] (03CR) 10Anomie: Add RevisionFromTitle hook (031 comment) [core] - 10https://gerrit.wikimedia.org/r/160570 (https://bugzilla.wikimedia.org/70495) (owner: 10Jackmcbarn) [15:01:30] (03CR) 10Manybubbles: [C: 032] Update VisualEditor to wmf21 for cherry-pick of I0fb47f7c91f61 and If48555fa476 [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160602 (owner: 10Catrope) [15:01:45] (03CR) 10Matthias Mullie: [C: 04-1] Hygiene: Various small cleanups (036 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160191 (owner: 10EBernhardson) [15:01:46] anyone know how i can make sure scribunto is available to a unit test? jenkins reports back with MWException: No handler for model 'Scribunto' registered in $wgContentHandlers [15:02:46] 3MediaWiki extensions / 3OAuth: OAuth uploads get logged as tools-webgrid-03.eqiad.wmflabs. - 10https://bugzilla.wikimedia.org/70885 (10Marcin Cieślak) 3NEW p:3Unprio s:3critic a:3None OAuth uploads get logged under the toolserver IP address, impacting (among others) CheckUser [15:03:18] (03PS6) 10Matthias Mullie: Hygiene: Various small cleanups [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160191 (owner: 10EBernhardson) [15:03:32] (03CR) 10Matthias Mullie: [C: 032] Hygiene: Various small cleanups [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160191 (owner: 10EBernhardson) [15:04:19] (03Merged) 10jenkins-bot: Hygiene: Various small cleanups [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160191 (owner: 10EBernhardson) [15:04:32] (03Merged) 10jenkins-bot: Update VisualEditor to wmf21 for cherry-pick of I0fb47f7c91f61 and If48555fa476 [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160602 (owner: 10Catrope) [15:05:12] (03CR) 10Anomie: [C: 04-1] "While checking that the module has the right content model is good, I disagree with supporting modules outside of the Module namespace. Th" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/160605 (owner: 10Jackmcbarn) [15:05:50] anomie: legoktm and i were talking yesterday about modules in other namespaces, and we think it's a good idea. (in fact, it was the whole point of that change) [15:06:21] (03CR) 10Anomie: Check content model instead of title (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/160605 (owner: 10Jackmcbarn) [15:06:36] jackmcbarn: Why do you think it's a good idea? [15:07:12] anomie: for global templates/modules. have a Module namespace that's local and a GlobalModule namespace. also, it would get rid of the Module:User:foo crap [15:07:16] (03CR) 10Cmcmahon: [C: 032] "To turn the build green and do some refactoring" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/160477 (owner: 10Cmcmahon) [15:08:03] (03Abandoned) 10Cmcmahon: QA: update Echo messages test [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159685 (https://bugzilla.wikimedia.org/70298) (owner: 10Spage) [15:08:31] (03CR) 10Seb35: "It can be remarked the BetaFeature depends on the 'preferhttps' preference (normal preference, not BetaFeature). This emulates the require" [extensions/HSTS] - 10https://gerrit.wikimedia.org/r/160665 (owner: 10Seb35) [15:08:43] jackmcbarn: The first seems speculative; we could as well have the Module namespace work like the File namespace. The second, I don't see why Module:Template:Foo for the module supporting Template:Foo needs breaking. [15:09:33] (03CR) 10jenkins-bot: [V: 04-1] QA: get messages test to pass properly [extensions/Echo] - 10https://gerrit.wikimedia.org/r/160477 (owner: 10Cmcmahon) [15:09:37] anomie: i've never seen Module:Template:foo to run Template:foo. it's always been Module:foo. the bad one is Module:User:foo [15:10:04] (03CR) 10Manybubbles: [C: 032] Update VisualEditor to wmf20 for cherry-pick of I0fb47f7c91f61 and If48555fa476 [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160603 (owner: 10Catrope) [15:10:15] 3MediaWiki extensions / 3OAuth: OAuth uploads get logged as tools-webgrid-03.eqiad.wmflabs. - 10https://bugzilla.wikimedia.org/70885#c1 (10Marcin Cieślak) to be clarified if this is tool-specific issue or general issue (or maybe general solution needs to be found) [15:11:59] (03CR) 10Hashar: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/160477 (owner: 10Cmcmahon) [15:12:02] (03PS2) 10Jackmcbarn: Add RevisionFromTitle hook [core] - 10https://gerrit.wikimedia.org/r/160570 (https://bugzilla.wikimedia.org/70495) [15:13:00] 3MediaWiki extensions / 3OAuth: OAuth uploads get logged as tools-webgrid-03.eqiad.wmflabs. - 10https://bugzilla.wikimedia.org/70885#c2 (10Brad Jorsch) The upload actually *is* coming from the Tool Labs IP in that case, so that's technically correct. Changing this would require the OAuth-using tool to provi... [15:13:47] (03PS3) 10Jackmcbarn: Use RevisionFromTitle instead of a template callback [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/160572 (https://bugzilla.wikimedia.org/70495) [15:13:49] (03Merged) 10jenkins-bot: Update VisualEditor to wmf20 for cherry-pick of I0fb47f7c91f61 and If48555fa476 [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160603 (owner: 10Catrope) [15:14:01] MatmaRex, anomie, do either of you know how to make sure an extension is available to a unit test? [15:14:15] (03CR) 10Jackmcbarn: [C: 04-1] "This was just to get the hook back in sync with core. The special page fix will be in the next patchset." [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/160572 (https://bugzilla.wikimedia.org/70495) (owner: 10Jackmcbarn) [15:14:22] dan-nl: i don't, ask hashar? [15:14:41] dan-nl: like this: https://gerrit.wikimedia.org/r/#/c/138612/ [15:14:51] dan-nl: Something like https://gerrit.wikimedia.org/r/#/c/56570/ ? [15:15:07] thanks! jackmcbarn and anomie [15:16:03] (03CR) 10jenkins-bot: [V: 04-1] Use RevisionFromTitle instead of a template callback [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/160572 (https://bugzilla.wikimedia.org/70495) (owner: 10Jackmcbarn) [15:16:05] (03CR) 10Matthias Mullie: [C: 04-1] Hygiene: Remove duplication passing user data around (036 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160259 (owner: 10EBernhardson) [15:16:34] (03CR) 10Jackmcbarn: "rehceck" [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/160572 (https://bugzilla.wikimedia.org/70495) (owner: 10Jackmcbarn) [15:16:40] (03CR) 10Jackmcbarn: "recheck" [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/160572 (https://bugzilla.wikimedia.org/70495) (owner: 10Jackmcbarn) [15:16:42] (03PS5) 10Matthias Mullie: Hygiene: Remove duplication passing user data around [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160259 (owner: 10EBernhardson) [15:16:52] (03CR) 10Matthias Mullie: [C: 032] Hygiene: Remove duplication passing user data around [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160259 (owner: 10EBernhardson) [15:17:38] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove duplication passing user data around [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160259 (owner: 10EBernhardson) [15:19:27] (03CR) 10Fomafix: "Is it wise to combine the two functions to one function with two signatures like usual in jQuery?" [core] - 10https://gerrit.wikimedia.org/r/160308 (owner: 10Bartosz Dziewoński) [15:22:22] (03PS6) 10Matthias Mullie: Hygiene: Remove duplication passing user data around [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160259 (owner: 10EBernhardson) [15:22:25] (03PS5) 10Matthias Mullie: Hygiene: Restructure Flow\\Data namepace for clarity [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160260 (owner: 10EBernhardson) [15:23:29] 3MediaWiki extensions / 3OAuth: OAuth uploads get logged as tools-webgrid-03.eqiad.wmflabs. - 10https://bugzilla.wikimedia.org/70885#c3 (10Trijnstel) Though another checkuser performed a check on this same toolserver IP due to an autoblock, which means that if a user is blocked other users (or only bots?) co... [15:23:45] (03CR) 10Hashar: "I did a major overhaul of the way jobs are run sorry :(" [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/160572 (https://bugzilla.wikimedia.org/70495) (owner: 10Jackmcbarn) [15:25:13] (03CR) 10Hashar: "recheck" [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/160572 (https://bugzilla.wikimedia.org/70495) (owner: 10Jackmcbarn) [15:29:00] 3MediaWiki extensions / 3CirrusSearch: Cirrus unable to find insource:"mazovia.pl" on pl.wp where the phrase occurs in a URL - 10https://bugzilla.wikimedia.org/70873#c2 (10Bartosz Dziewoński) Oh, so URLs are one "segment", and this doesn't find "substrings"? That makes sense. Splitting on these characters s... [15:29:14] 3MediaWiki extensions / 3OAuth: OAuth uploads get logged as tools-webgrid-03.eqiad.wmflabs. - 10https://bugzilla.wikimedia.org/70885#c4 (10Marius Hoch) As Brad said, there's not really something we can do here, as we don't want to make the tool providers responsible for passing on the user IPs (also they cou... [15:30:27] (03CR) 10Hashar: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86118 (owner: 10Hashar) [15:30:53] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/HSTS] - 10https://gerrit.wikimedia.org/r/160665 (owner: 10Seb35) [15:31:05] (03CR) 10Hashar: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/160648 (owner: 10Matthias Mullie) [15:31:49] (03PS1) 10Filippo Giunchedi: run php syntax in parallel with php -l [tools/scap] - 10https://gerrit.wikimedia.org/r/160668 [15:32:05] (03CR) 10jenkins-bot: [V: 04-1] run php syntax in parallel with php -l [tools/scap] - 10https://gerrit.wikimedia.org/r/160668 (owner: 10Filippo Giunchedi) [15:32:36] (03PS3) 10Jackmcbarn: Hook TitleExists when previewing [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/160555 (https://bugzilla.wikimedia.org/70495) [15:32:52] (03PS4) 10Jackmcbarn: Use RevisionFromTitle instead of a template callback [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/160572 (https://bugzilla.wikimedia.org/70495) [15:34:10] jackmcbarn, anomie, i need to add scribunto to the mediawiki-vendor-integration project, but i don't see how i could do that. it's needed for a unit test i added to ImportTest.php https://gerrit.wikimedia.org/r/#/c/159973/ [15:34:14] 3Wikimedia / 3General/Unknown: Firefox search bar not using Secure search - 10https://bugzilla.wikimedia.org/45765#c16 (10jeremyb) in progress. https://bugzilla.mozilla.org/show_bug.cgi?id=758857#c26 [15:34:42] dan-nl: are you sure a core unit test should need an extension? [15:35:00] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86118 (owner: 10Hashar) [15:35:52] jackmcbarn: well, the test i added is importing a template to make sure special:import works properly. and that needs scribunto in order to import the template properly. i guess i could try importing a template that doesn't need scribunto … i see if i can sort that out instead [15:40:34] (03CR) 10Cmcmahon: "after recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/160477 (owner: 10Cmcmahon) [15:42:47] (03PS4) 10Jackmcbarn: Hook TitleExists when previewing [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/160555 (https://bugzilla.wikimedia.org/70495) [15:43:10] jackmcbarn: well, Template:!! seems to work without the need of scribunto … guess that at least proves the upload case ... [15:45:14] 3MediaWiki extensions / 3OAuth: OAuth uploads get logged as tools-webgrid-03.eqiad.wmflabs. - 10https://bugzilla.wikimedia.org/70885#c5 (10Mormegil) As I have replied on the toolserver-l, I don’t see how this could be changed, or how is the situation different to how it worked when the tools ran on Toolserve... [15:45:40] (03PS7) 10Dan-nl: Special:Import not importing Special:Export XMLs [core] - 10https://gerrit.wikimedia.org/r/159973 [15:47:32] (03CR) 10Dan-nl: "* altered the unit test so that it uploads Template:!!, which does not require Scribunto." [core] - 10https://gerrit.wikimedia.org/r/159973 (owner: 10Dan-nl) [15:49:35] (03CR) 10BryanDavis: run php syntax in parallel with php -l (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/160668 (owner: 10Filippo Giunchedi) [15:50:26] (03PS1) 10Matthias Mullie: Revert "Introduce flowSpawnedBy handler to forward events from outside of FlowComponent" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160673 [15:50:29] 3MediaWiki extensions / 3CirrusSearch: Cirrus unable to find insource:"mazovia.pl" on pl.wp where the phrase occurs in a URL - 10https://bugzilla.wikimedia.org/70873#c3 (10Nik Everett) (In reply to Bartosz Dziewoński from comment #2) > Oh, so URLs are one "segment", and this doesn't find "substrings"? That >... [15:50:51] (03PS2) 10Matthias Mullie: Revert "Introduce flowSpawnedBy handler to forward events from outside of FlowComponent" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160673 [15:51:03] (03CR) 10Matthias Mullie: [C: 032] Revert "Introduce flowSpawnedBy handler to forward events from outside of FlowComponent" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160673 (owner: 10Matthias Mullie) [15:51:48] (03Merged) 10jenkins-bot: Revert "Introduce flowSpawnedBy handler to forward events from outside of FlowComponent" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160673 (owner: 10Matthias Mullie) [15:52:32] (03CR) 10Matthias Mullie: "I reverted this change in https://gerrit.wikimedia.org/r/#/c/160673/" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160483 (owner: 10SG) [15:52:53] (03PS1) 10Matthias Mullie: Revert "Revert "Introduce flowSpawnedBy handler to forward events from outside of FlowComponent"" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160675 [15:53:33] thanks jackmcbarn, that took care of it [15:54:08] (03CR) 10Matthias Mullie: [C: 04-1] "I had already merged this change, but have reverted it." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160675 (owner: 10Matthias Mullie) [15:57:59] https://bugzilla.wikimedia.org/show_bug.cgi?id=69319 [15:58:00] Wow. [15:58:10] > TURN OFF this pathetic option, no one cares about security on the wiki... [15:58:14] > You are sacrificing speed for security (which is unnecessary).. [15:58:23] This is really tempting to just resolve as wontfix/invalid. [15:59:15] Wow... no words [15:59:40] Krenair: Or WFM. [15:59:41] :) [15:59:51] That works too. [16:00:51] guillom: just replied via mail [16:02:07] (03CR) 10Reedy: CSV content handler (031 comment) [core] - 10https://gerrit.wikimedia.org/r/160610 (owner: 10Yurik) [16:02:13] "Https is slow and does not cache" ... really? [16:02:15] gwicke: Thanks! I'll look into your links and see if I can figure it out. If not, I'll come back to you for help :) [16:02:38] Lcawte: It's "slower", extra overhead and such. Most people wouldn't notice [16:02:50] I meant about the cache... [16:03:09] (03CR) 10Matthias Mullie: [C: 032] Hygiene: Restructure Flow\\Data namepace for clarity [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160260 (owner: 10EBernhardson) [16:03:19] Yeah, HTTPS isn't cached [16:03:22] guillom: okay, great! [16:03:39] Reedy, what? [16:03:43] it isn't? [16:03:47] Are we talking locally or on the servers, or both? [16:03:54] Not on the clients ISP etc [16:03:57] (03CR) 10Matthias Mullie: [C: 032] Hygiene: Remove duplication passing user data around [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160259 (owner: 10EBernhardson) [16:04:09] (03PS5) 10Prtksxna: settings: Add help dialog [extensions/Popups] - 10https://gerrit.wikimedia.org/r/157037 [16:04:09] But it is on the wikimedia side, right? [16:04:14] for WMF usage, HTTPS sits infront of the cache [16:04:33] (03Merged) 10jenkins-bot: Hygiene: Remove duplication passing user data around [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160259 (owner: 10EBernhardson) [16:04:36] (03Merged) 10jenkins-bot: Hygiene: Restructure Flow\\Data namepace for clarity [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160260 (owner: 10EBernhardson) [16:04:53] (03CR) 10Prtksxna: settings: Add help dialog (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/157037 (owner: 10Prtksxna) [16:05:44] (03PS4) 10Matthias Mullie: Move EmailNotification watchlist handling into helper methods [core] - 10https://gerrit.wikimedia.org/r/159395 (https://bugzilla.wikimedia.org/66876) (owner: 10EBernhardson) [16:05:50] (03PS2) 10Yurik: CSV content handler [core] - 10https://gerrit.wikimedia.org/r/160610 [16:05:58] (03CR) 10Matthias Mullie: [C: 031] "LGTM" [core] - 10https://gerrit.wikimedia.org/r/159395 (https://bugzilla.wikimedia.org/66876) (owner: 10EBernhardson) [16:06:11] (03CR) 10jenkins-bot: [V: 04-1] Move EmailNotification watchlist handling into helper methods [core] - 10https://gerrit.wikimedia.org/r/159395 (https://bugzilla.wikimedia.org/66876) (owner: 10EBernhardson) [16:06:43] (03PS2) 10Filippo Giunchedi: run php syntax in parallel with php -l [tools/scap] - 10https://gerrit.wikimedia.org/r/160668 [16:07:22] (03CR) 10jenkins-bot: [V: 04-1] run php syntax in parallel with php -l [tools/scap] - 10https://gerrit.wikimedia.org/r/160668 (owner: 10Filippo Giunchedi) [16:07:25] (03PS3) 10Filippo Giunchedi: run php syntax in parallel with php -l [tools/scap] - 10https://gerrit.wikimedia.org/r/160668 [16:07:47] (03CR) 10jenkins-bot: [V: 04-1] run php syntax in parallel with php -l [tools/scap] - 10https://gerrit.wikimedia.org/r/160668 (owner: 10Filippo Giunchedi) [16:11:00] (03PS4) 10Filippo Giunchedi: run php syntax in parallel with php -l [tools/scap] - 10https://gerrit.wikimedia.org/r/160668 [16:12:37] (03CR) 10Filippo Giunchedi: "tested on deployment-bastion, seems to work:" [tools/scap] - 10https://gerrit.wikimedia.org/r/160668 (owner: 10Filippo Giunchedi) [16:14:52] (03PS3) 10Prtksxna: buttons.less: Add multiple
s between buttons [core] - 10https://gerrit.wikimedia.org/r/160551 [16:18:51] (03PS4) 10Prtksxna: buttons.less: Add multiple
s between buttons [core] - 10https://gerrit.wikimedia.org/r/160551 [16:18:56] (03CR) 10Prtksxna: buttons.less: Add multiple
s between buttons (031 comment) [core] - 10https://gerrit.wikimedia.org/r/160551 (owner: 10Prtksxna) [16:19:44] 3MediaWiki extensions / 3OAuth: OAuth uploads get logged as tools-webgrid-03.eqiad.wmflabs. - 10https://bugzilla.wikimedia.org/70885#c6 (10Chris Steipp) 5NEW>3RESO/INV As others have said, this is how OAuth is intended to work, so I'm going to close the bug since I think the original request as I underst... [16:22:06] MatmaRex: Hmm. https://gerrit.wikimedia.org/r/#/c/154831/ and https://gerrit.wikimedia.org/r/#/c/157183/ will merge on Thursday (for 1.24wmf22, so just under the wire), but are there any other before-1.25 patches you want merged? [16:23:38] James_F: i still need to write release notes for killing skins/common/, probably nothing else [16:24:06] oh, https://gerrit.wikimedia.org/r/160224 is also related to my skins stuff and should land in 1.24 [16:25:19] James_F: backporting is easy and there'll be like a month more time for that, no? [16:25:36] MatmaRex: You say easy, I say tedious. :-) [16:26:11] MatmaRex: And sorry, my knowledge of the command line installer is… poor. [16:26:56] James_F: i think everyone's knowledge of it is like that, heh [16:27:01] * James_F grins. [16:27:06] i need to poke saper to look at it [16:27:09] (03PS5) 10BryanDavis: Check php syntax with parallel `php -l` [tools/scap] - 10https://gerrit.wikimedia.org/r/160668 (https://bugzilla.wikimedia.org/68255) (owner: 10Filippo Giunchedi) [16:27:37] (03CR) 10GWicke: "The other functional change here is to avoid rewrapping of the stream after going part-way down the response / callback route, and making " [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160552 (owner: 10GWicke) [16:27:52] MatmaRex: https://gerrit.wikimedia.org/r/#/c/137168/ is going to be fun to merge. [16:28:01] Helder: the pages not moving thing is on my list of things to fix... [16:28:27] https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/core+branch:master+topic:movepage,n,z [16:29:11] (03CR) 10Filippo Giunchedi: [C: 031] Check php syntax with parallel `php -l` [tools/scap] - 10https://gerrit.wikimedia.org/r/160668 (https://bugzilla.wikimedia.org/68255) (owner: 10Filippo Giunchedi) [16:30:43] (03CR) 10BryanDavis: "Re-tested after syntax change --" [tools/scap] - 10https://gerrit.wikimedia.org/r/160668 (https://bugzilla.wikimedia.org/68255) (owner: 10Filippo Giunchedi) [16:30:57] is this the last week for 1.24 things? [16:31:01] (03CR) 10Jforrester: [C: 032] Update path to license footer icons for MW 1.24 [extensions/PerPageLicense] - 10https://gerrit.wikimedia.org/r/159372 (https://bugzilla.wikimedia.org/70615) (owner: 10Bartosz Dziewoński) [16:31:13] legoktm: Hi! See also https://en.wikinews.org/w/index.php?oldid=2887817#User_talk_deletion_issues [16:31:32] My problem was mostly due to "welcome bots" [16:31:59] (03Abandoned) 10Anomie: API: generalized submodules for action=paraminfo [core] - 10https://gerrit.wikimedia.org/r/154148 (owner: 10Anomie) [16:32:13] bah [16:32:17] (03CR) 10Jforrester: [C: 031] Remove usage of spinner.gif [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/159370 (https://bugzilla.wikimedia.org/70615) (owner: 10Bartosz Dziewoński) [16:32:49] they should probably ignore these usurped accounts, but oh well.. [16:33:11] (03Merged) 10jenkins-bot: Update path to license footer icons for MW 1.24 [extensions/PerPageLicense] - 10https://gerrit.wikimedia.org/r/159372 (https://bugzilla.wikimedia.org/70615) (owner: 10Bartosz Dziewoński) [16:33:21] legoktm: Yes. [16:33:36] legoktm: Thursday is the last 1.24wmf* branch, apparently. [16:33:49] legoktm: But as MatmaRex says, we can always backport to REL1_24. [16:33:54] mhm [16:34:25] (03CR) 10BryanDavis: [C: 032] Check php syntax with parallel `php -l` [tools/scap] - 10https://gerrit.wikimedia.org/r/160668 (https://bugzilla.wikimedia.org/68255) (owner: 10Filippo Giunchedi) [16:34:37] (03Merged) 10jenkins-bot: Check php syntax with parallel `php -l` [tools/scap] - 10https://gerrit.wikimedia.org/r/160668 (https://bugzilla.wikimedia.org/68255) (owner: 10Filippo Giunchedi) [16:34:57] legoktm: So is the failed test related to the change at all? https://gerrit.wikimedia.org/r/#/c/154843/ [16:35:16] (03CR) 10Legoktm: "recheck" [core] - 10https://gerrit.wikimedia.org/r/154843 (owner: 10Legoktm) [16:35:27] Lcawte: if it's qunit, probably not [16:35:34] ^^ I was gonna do that :P [16:36:41] phpstorm 8 is hout [16:36:44] is out* [16:36:49] Hawt? [16:38:43] I've been using the EAPs all along [16:39:28] Hmm, is there a built in updater for it? [16:39:42] (03PS8) 10Legoktm: Add MultiConfig for fallback logic [core] - 10https://gerrit.wikimedia.org/r/153541 (https://bugzilla.wikimedia.org/69418) [16:39:52] Help --> Check for updates [16:40:03] Major versions not usually, minor usually [16:40:16] 3MediaWiki extensions / 3OAuth: OAuth should be autoblock-exempt / "IP address had been blocked automatically" in croptool - 10https://bugzilla.wikimedia.org/66639#c3 (10Steinsplitter) p:5Unprio>3High Again problems [2], therefore i [2] whitelisted 10.0.0.0/8 subnet. OAuth is using by default the toolsl... [16:40:35] (03CR) 10Hashar: "recheck" [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/159370 (https://bugzilla.wikimedia.org/70615) (owner: 10Bartosz Dziewoński) [16:40:55] Tests stalled or just slow? [16:41:30] (03CR) 10Legoktm: Add tests for CentralAuthUser::getHomeWiki() (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/160611 (owner: 10Legoktm) [16:41:56] * Lcawte looks at zuul [16:41:57] Slow... [16:42:19] (03CR) 10Legoktm: Add tests for CentralAuthUser::getHomeWiki() (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/160611 (owner: 10Legoktm) [16:44:32] (03CR) 10Legoktm: "I removed MultiConfig::newMainInstance since that's not the right place for it and we don't need it yet, and I believe that's the only obj" [core] - 10https://gerrit.wikimedia.org/r/153541 (https://bugzilla.wikimedia.org/69418) (owner: 10Legoktm) [16:45:59] 3Wikimedia / 3Deployment systems: [OPS] Jenkins: Package php5-parsekit missing in Trusty - 10https://bugzilla.wikimedia.org/68255#c18 (10Bryan Davis) 5PATC>3RESO/FIX $ scap --verbose 'No code change scap to test scap internal update' 16:45:09 Started scap: No code change scap to test scap internal update... [16:47:47] 3Wikimedia / 3Deployment systems: [OPS] Jenkins: Package php5-parsekit missing in Trusty - 10https://bugzilla.wikimedia.org/68255#c19 (10Bryan Davis) 5RESO/FIX>3REOP Maybe closed too soon? Have we removed the dependency on php5-parsekit from puppet? [16:48:20] There we go... jenkins +2'd it. Now it just needs a +2 CR :) [16:48:30] 3Wikimedia / 3Deployment systems: [OPS] Jenkins: Package php5-parsekit missing in Trusty - 10https://bugzilla.wikimedia.org/68255 (10Bryan Davis) a:3Filippo Giunchedi [16:50:33] legoktm: Has Config been in 1.23 this entire time? [16:50:39] yes [16:51:48] I don't remember if it has the broken version though.. [16:51:53] lol [16:52:05] it does >.> [16:52:33] (03CR) 10Hashar: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/160648 (owner: 10Matthias Mullie) [16:52:36] (03CR) 10Legoktm: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/160648 (owner: 10Matthias Mullie) [16:52:40] legoktm: BACKPORT ALL THE THINGS [16:52:53] That'd be why I remember some conversation somewhere about not converting code to it. [16:53:00] (03PS1) 10Legoktm: GlobalVarConfig shouldn't throw exceptions for null-valued config settings [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/160688 (https://bugzilla.wikimedia.org/66986) [16:53:18] Oh thanks gerrit, because I need that email five minutes after I've already manually checked that test recheck passed... [16:57:17] Hmm, right, so that needs merging and then a bugfix release making... or do I just download the patch, apply it against the SW codebase and start converting (see: breaking) things... [16:58:46] 3Wikimedia / 3Wikidata: Autogenerate sharedCacheKeyPrefix setting for Wikidata builds - 10https://bugzilla.wikimedia.org/70889 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs for new builds to deploy to beta, we need to update the sharedCacheKeyPrefix setting to avoid breakage such a in bug 70736... [17:00:28] (03CR) 10Legoktm: "This broke Flow Thanks tests, please fix! :( " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160259 (owner: 10EBernhardson) [17:01:10] (03CR) 10Legoktm: [C: 032] "test failures are legit now, see I10d84fbd3c5b4d899ba4bc5aafb7f85e6984acb4." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/160648 (owner: 10Matthias Mullie) [17:01:33] (03CR) 10jenkins-bot: [V: 04-1] Use postWithToken [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/160648 (owner: 10Matthias Mullie) [17:02:38] (03CR) 10Legoktm: [C: 04-1] "I'll add release notes to this later" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/160688 (https://bugzilla.wikimedia.org/66986) (owner: 10Legoktm) [17:03:44] 3Wikimedia / 3General/Unknown: Get dbpedia off OAI - 10https://bugzilla.wikimedia.org/68538 (10Sam Reed (reedy)) [17:03:59] 3Wikimedia / 3Extension setup: Review and deploy PubSubHubbubExtension - 10https://bugzilla.wikimedia.org/67623 (10Sam Reed (reedy)) [17:04:29] 3Wikimedia / 3Deployment systems: [OPS] Jenkins: Package php5-parsekit missing in Trusty - 10https://bugzilla.wikimedia.org/68255#c20 (10Filippo Giunchedi) proposed fix in puppet to remove lint https://gerrit.wikimedia.org/r/160691 [17:05:13] (03PS1) 10Jack Phoenix: Fix Catchable fatal error: Object of class WFReply could not be converted to string [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/160692 [17:05:36] (03CR) 10Jack Phoenix: [C: 032 V: 032] Fix Catchable fatal error: Object of class WFReply could not be converted to string [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/160692 (owner: 10Jack Phoenix) [17:12:14] 3MediaWiki extensions / 3OAuth: OAuth should be autoblock-exempt / "IP address had been blocked automatically" in croptool - 10https://bugzilla.wikimedia.org/66639#c4 (10Brad Jorsch) (In reply to Steinsplitter from comment #3) > OAuth is using by default the toolslabs ip? No, it's not. But just like with a... [17:15:06] (03CR) 10Daniel Kinzler: Add MultiConfig for fallback logic (031 comment) [core] - 10https://gerrit.wikimedia.org/r/153541 (https://bugzilla.wikimedia.org/69418) (owner: 10Legoktm) [17:19:15] (03CR) 10Daniel Kinzler: Add MultiConfig for fallback logic (032 comments) [core] - 10https://gerrit.wikimedia.org/r/153541 (https://bugzilla.wikimedia.org/69418) (owner: 10Legoktm) [17:20:35] legoktm, around? [17:24:16] (03PS1) 10Physikerwelt: Make Mathoid role configurable via hiera [vagrant] - 10https://gerrit.wikimedia.org/r/160694 [17:27:58] (03PS1) 10SG: Update subscribe board tooltip text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160697 [17:28:57] (03CR) 10MaxSem: Make Mathoid role configurable via hiera (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/160694 (owner: 10Physikerwelt) [17:29:17] (03CR) 10Daniel Kinzler: [C: 031] "Looks pretty good. Didn't play with it though." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/160575 (owner: 10Yurik) [17:30:54] bd808, are you sure we want to have "hiera" as a weird extra word for config? Why not just use "vagrant config ..." ? [17:32:15] yurikR: At least in part because the internals of making `vagrant config` sometimes manage one yaml file and other times manage another yaml file are a bit gross. [17:32:36] And my goal is not to hide the fact that a complex system is being managed [17:32:44] bd808, but should we expose internal working of vagrant via interface?? [17:33:20] at the end of the day, any system should be VERY easy to understand. If we introduce all this complex params, noone will use them [17:33:29] users should not be required to read manuals :) [17:33:42] first - make it simple, than, make it powerful [17:33:48] otherwise we will loose on both [17:34:03] [17:34:15] [17:34:38] yurikR: i think the primary purpose of hiera is not to make it complex for the user, but to separate configuration from puppet modules as much as possible. we'll get more portability that way [17:34:48] (03CR) 10Daniel Kinzler: "The approach is fine, though I didn't check the code closely; especially the encoding/decoding needs some poking." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/160610 (owner: 10Yurik) [17:35:30] (03CR) 10Daniel Kinzler: [C: 032] "oh, yes!" [core] - 10https://gerrit.wikimedia.org/r/160614 (owner: 10Yurik) [17:35:33] marxarelli, i am not objecting to how it is *implemented*, only how it is exposed to the users. I, as a user, do not even need to know the word "puppet" - i enable a role, and my code works :) [17:35:33] use of `vagrant hiera` is probably for very advanced use cases [17:35:46] I understand your point, but I am not sure that I agree when it comes to the tool I use to manage my development environment. [17:36:16] I would actually hope that using MWV teaches people about puppet, hiera, hhvm, apache and the crazy world of MW configuraiton [17:36:30] But in small doses. [17:36:35] look at git -- it has 3 levels of configurations -- system, user, repo, it has guzzilion config options, and yet the interface is consistent [17:36:47] ebernhardson: do you confirm this? https://translatewiki.net/w/i.php?title=MediaWiki:Flow-rev-message-locked-topic-irc/qqq&diff=prev&oldid=5770306 [17:37:04] its ok to teach, not ok to force :) [17:37:14] want to add a role - learn puppets [17:37:23] (03CR) 10Daniel Kinzler: [C: 032] Save pages content in the default format of their content type [core] - 10https://gerrit.wikimedia.org/r/157150 (owner: 10Tpt) [17:37:35] yurikR: Patches welcome. And `vagrant hiera` is a total power user feature I think [17:37:38] yurikR, bd808: i do agree that having both hiera and config commands might be confusing. maybe we should figure out a good way to unify them [17:37:53] my qualms are exclusivelly with the UI, not implementation [17:38:15] bd808, patches are useful only AFTER we decide on how to persue it :) [17:38:19] yurikR: git has a consistent interface? really? the one thing i hate about git is the confusing and inconsistent cli parameters [17:38:37] DanielK_WMDE_: And that's coming from a php developer :) [17:38:40] DanielK_WMDE_, they tried :) [17:39:44] git is somewhat consistent for the amount of stuff it is capable of. Its hard to control a spaceship via a single joystick (despite what video games teach you :) [17:40:11] bd808: not by choice... [17:41:58] (03CR) 10Physikerwelt: Make Mathoid role configurable via hiera (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/160694 (owner: 10Physikerwelt) [17:42:13] (03Merged) 10jenkins-bot: When cloning TextContent, include model [core] - 10https://gerrit.wikimedia.org/r/160614 (owner: 10Yurik) [17:42:25] (03CR) 10Yurik: "There is a lot of talks among several teams (analytics, fundraising, etc) that we need a namespace for mid-size chunks of rarelly changed " [core] - 10https://gerrit.wikimedia.org/r/160610 (owner: 10Yurik) [17:43:29] (03PS2) 10CSteipp: Add cookie path for CentralAuth cookies [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143192 (https://bugzilla.wikimedia.org/70891) [17:43:32] 3MediaWiki extensions / 3CentralAuth: Make CentralAuth cookie path configurable - 10https://bugzilla.wikimedia.org/70891 (10Chris Steipp) 3NEW p:3Unprio s:3normal a:3None I added https://gerrit.wikimedia.org/r/#/c/143192 to make CentralAuth's cookie path setting be configurable, like core's. I've ru... [17:43:47] (03Merged) 10jenkins-bot: Save pages content in the default format of their content type [core] - 10https://gerrit.wikimedia.org/r/157150 (owner: 10Tpt) [17:44:09] Hmm "Amsterdam Hackathon 2014 is a small hackathon focussing on GLAM activities and wikidata". So tempting, but I don't wikidata or glam :( [17:45:06] yurikR: I appreciate your input on this topic. I'd love to hear ideas on a coherent design for the UX. I can freely admit that I have added many features with a heads down approach where I was only concerned with fixing my problem. [17:47:29] 3MediaWiki extensions / 3OAuth: OAuth should be autoblock-exempt / "IP address had been blocked automatically" in croptool - 10https://bugzilla.wikimedia.org/66639#c5 (10Dan Michael Heggø) Hm, there must better ways to block misbehaving OAuth apps than to use IP blocks? Such as removing the authorization. [17:47:43] (03PS9) 10EBernhardson: H5: Hide reply and edit links in locked posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158618 (owner: 10Jdlrobson) [17:47:56] Nemo_bis: hmm? [17:48:33] ebernhardson: does that message really have those parameters unused? can you document the others? [17:48:57] Nemo_bis: they really are unused, its because the i18n system has numbered instead of named parameters [17:49:09] Nemo_bis: the only other option is invent new i18n key names regularly [17:53:42] (03CR) 10Matthias Mullie: [C: 031] "LGTM - will test tomorrow" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158618 (owner: 10Jdlrobson) [18:00:33] (03CR) 10Physikerwelt: "Please make sure that the following concern is resolved before merging this patch:" [extensions/Math] - 10https://gerrit.wikimedia.org/r/158845 (owner: 10Physikerwelt) [18:01:34] (03CR) 10Reedy: "The comment from maintenance/runBatchedQuery.php in core answers this fairly well:" [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/158310 (https://bugzilla.wikimedia.org/70376) (owner: 10Reedy) [18:02:08] * Reedy has no idea why that would apparently break Postgres [18:02:31] (03PS5) 10EBernhardson: Move EmailNotification watchlist handling into helper methods [core] - 10https://gerrit.wikimedia.org/r/159395 (https://bugzilla.wikimedia.org/66876) [18:08:23] (03PS1) 10Anomie: Update wfMessage doc [core] - 10https://gerrit.wikimedia.org/r/160782 [18:16:45] (03CR) 10EBernhardson: [C: 032] Update subscribe board tooltip text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160697 (owner: 10SG) [18:17:20] (03Merged) 10jenkins-bot: Update subscribe board tooltip text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160697 (owner: 10SG) [18:17:47] (03PS3) 10EBernhardson: Avoid flash of unstyled content on new topic form [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156489 (https://bugzilla.wikimedia.org/69220) (owner: 10Jdlrobson) [18:22:34] (03CR) 10Aaron Schulz: "When you use constants you have to include the extension before declaring the config so that the constant is loaded (or otherwise just har" [extensions/Math] - 10https://gerrit.wikimedia.org/r/158845 (owner: 10Physikerwelt) [18:28:27] (03PS1) 10Dduvall: WIP Support MMV perf testing [vagrant] - 10https://gerrit.wikimedia.org/r/160786 [18:33:48] (03CR) 10Physikerwelt: "Thanks for the explanation. I still don't understand how those settings can be set before they are declared. i.e. why are they not overrid" [extensions/Math] - 10https://gerrit.wikimedia.org/r/158845 (owner: 10Physikerwelt) [18:34:49] (03PS25) 10Paladox: WikiEditor: Convert .css to .less and also fixes svg issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [18:41:11] (03PS1) 10Wctaiwan: Output the number of recipients on preview [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/160787 (https://bugzilla.wikimedia.org/57472) [18:50:30] 3Wikimedia / 3General/Unknown: Firefox search bar not using Secure search - 10https://bugzilla.wikimedia.org/45765#c17 (10Andre Klapper) 5REOP>3RESO/INV And I will close it here as there is nothing code-wise on the Wikimedia site that needs to be done. All work can be followed upstream. :) [18:50:47] (03CR) 10Isarra: "Who cares what other sites do? Just because nobody else does something doesn't mean it's not a good thing to do; all good practices have a" [core] - 10https://gerrit.wikimedia.org/r/110279 (https://bugzilla.wikimedia.org/47694) (owner: 10Bartosz Dziewoński) [18:51:02] 3Wikimedia / 3General/Unknown: skwiki image table contains non existing image - 10https://bugzilla.wikimedia.org/70896 (10db) 3NEW p:3Unprio s:3normal a:3None The following query[1] gives a image, which is non existing and was deleted in 2008, see [2]. Look strange wait... typo in commit summary :P [18:59:08] (03PS2) 10Bartosz Dziewoński: Use 0x for hexadecimal prefix [core] - 10https://gerrit.wikimedia.org/r/160791 (owner: 10CSteipp) [18:59:16] (03CR) 10Bartosz Dziewoński: [C: 032] Use 0x for hexadecimal prefix [core] - 10https://gerrit.wikimedia.org/r/160791 (owner: 10CSteipp) [18:59:37] hoo: faster than you! [18:59:39] MatmaRex: +4 :D [19:00:45] (03PS1) 10Wctaiwan: Clean up SpecialMassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/160792 [19:01:18] did PHP syntax highlighting just break in gerrit? [19:05:21] (03PS1) 10Jforrester: Revert "Update VisualEditor to wmf20 for cherry-pick of I0fb47f7c91f61 and If48555fa476" [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160793 [19:05:27] (03PS1) 10Jforrester: Revert "Update VisualEditor to wmf21 for cherry-pick of I0fb47f7c91f61 and If48555fa476" [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160794 [19:06:10] (03Merged) 10jenkins-bot: Use 0x for hexadecimal prefix [core] - 10https://gerrit.wikimedia.org/r/160791 (owner: 10CSteipp) [19:06:44] (03CR) 10Catrope: [C: 032 V: 032] Revert "Update VisualEditor to wmf20 for cherry-pick of I0fb47f7c91f61 and If48555fa476" [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160793 (owner: 10Jforrester) [19:06:52] (03CR) 10Catrope: [C: 032 V: 032] Revert "Update VisualEditor to wmf21 for cherry-pick of I0fb47f7c91f61 and If48555fa476" [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160794 (owner: 10Jforrester) [19:14:20] (03PS10) 10Jdlrobson: H5: Hide reply and edit links in locked posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158618 [19:14:28] (03CR) 10Jdlrobson: [C: 032] H5: Hide reply and edit links in locked posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158618 (owner: 10Jdlrobson) [19:15:06] (03Merged) 10jenkins-bot: H5: Hide reply and edit links in locked posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158618 (owner: 10Jdlrobson) [19:16:02] 3MediaWiki / 3Maintenance scripts: maintenance/importDump.php fails for wikidatawiki XML incremental dump files - 10https://bugzilla.wikimedia.org/70898 (10wp mirror) 3NEW p:3Unprio s:3major a:3None Dear Sir, The CLI utility `maintenance/importDump.php' fails to process XML incremental data dump fil... [19:17:46] 3MediaWiki / 3Search: Search box needs some normalization for Arabic Family languages - 10https://bugzilla.wikimedia.org/70899 (10reza1615) 3NEW p:3Unprio s:3normal a:3None We have some langues such as Arabic, Persian, Urdu, Kurdish,... which uses common characters and they have similar geliphs with... [19:18:30] 3Wikimedia / 3Site requests: Creation of 'Author' namespace on Assamese Wikisource (aswikisource) - 10https://bugzilla.wikimedia.org/70464#c8 (10James Forrester) 5PATC>3RESO/FIX Should be now done. [19:20:59] 3MediaWiki extensions / 3EducationProgram: "Remove from course" button no longer works - 10https://bugzilla.wikimedia.org/70748#c3 (10Andrew Green) The problem comes from recent changes in ApiBase: https://gerrit.wikimedia.org/r/#/c/153110/ Still running into a few obstacle in getting it to work. I'll post... [19:25:10] (03PS1) 10Anomie: Implement ApiBase::getParent in ApiFlowBase [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160796 [19:26:27] (03PS1) 10Anomie: Add "bare" skin [core] - 10https://gerrit.wikimedia.org/r/160797 [19:26:39] (03PS1) 10Anomie: API: HTMLize and internationalize the help, add Special:ApiHelp [core] - 10https://gerrit.wikimedia.org/r/160798 (https://bugzilla.wikimedia.org/30936) [19:27:14] (03PS1) 10Jforrester: Revert "Revert "Update VisualEditor to wmf20 for cherry-pick of I0fb47f7c91f61 and If48555fa476"" [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160799 [19:27:16] (03PS1) 10Anomie: Update for core API changes [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/160800 [19:27:18] (03PS1) 10Jforrester: Revert "Revert "Update VisualEditor to wmf21 for cherry-pick of I0fb47f7c91f61 and If48555fa476"" [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160801 [19:27:38] (03CR) 10Jforrester: [C: 04-1] "Deploy only once the Parsoid fix is tested and live." [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160799 (owner: 10Jforrester) [19:27:44] (03CR) 10Jforrester: [C: 04-1] "Deploy only once the Parsoid fix is tested and live." [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160801 (owner: 10Jforrester) [19:27:44] 3Wikimedia / 3Site requests: Change $wgAbuseFilterAnonBlockDuration to 3 months on mediawikiwiki - 10https://bugzilla.wikimedia.org/70828 (10Jackmcbarn) 5PATC>3RESO/FIX [19:27:44] 3MediaWiki / 3Search: Search box needs some normalization for Arabic Family languages - 10https://bugzilla.wikimedia.org/70899#c1 (10Calak) Yes, we have a same problem on ckb wikipedia. It can be useful. [19:28:15] (03CR) 10Anomie: "Note I6e9344a4 should be merged before this, and I1028f56d should be merged/deployed at the same time as this." [core] - 10https://gerrit.wikimedia.org/r/160798 (https://bugzilla.wikimedia.org/30936) (owner: 10Anomie) [19:28:24] (03CR) 10jenkins-bot: [V: 04-1] API: HTMLize and internationalize the help, add Special:ApiHelp [core] - 10https://gerrit.wikimedia.org/r/160798 (https://bugzilla.wikimedia.org/30936) (owner: 10Anomie) [19:28:45] (03CR) 10Anomie: "Note this requires core change Ib14c00df, and that core change requires this (unless we want ApiSandbox broken, anyway)." [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/160800 (owner: 10Anomie) [19:33:54] (03PS5) 10Jackmcbarn: Use RevisionFromTitle instead of a template callback [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/160572 (https://bugzilla.wikimedia.org/70495) [19:34:42] (03CR) 10Bartosz Dziewoński: "I'm not sure about this. Skins pull in (and require) a lot of machinery that you probably don't want; in particular it's hard to avoid the" [core] - 10https://gerrit.wikimedia.org/r/160797 (owner: 10Anomie) [19:37:20] (03CR) 10Reedy: "recheck" [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135289 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [19:37:52] (03PS8) 10Reedy: Make PagedTiffHandler extend TransformationalImageHandler [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/86413 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [19:38:00] (03PS3) 10Reedy: Make tiff thumbnail in 2 steps. [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135289 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [19:40:31] (03CR) 10jenkins-bot: [V: 04-1] Make tiff thumbnail in 2 steps. [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135289 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [19:41:45] 3MediaWiki / 3Search: Search box needs some normalization for Arabic Family languages - 10https://bugzilla.wikimedia.org/70899#c2 (10reza1615) may be for fa.wikipedia or ckb.wikipedia we needs some normalization like https://github.com/wikimedia/mediawiki-core/blob/master/languages/classes/LanguageAr.php [19:42:19] (03CR) 10Reedy: "recheck" [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135289 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [19:42:26] (03CR) 10jenkins-bot: [V: 04-1] Make tiff thumbnail in 2 steps. [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135289 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [19:44:03] (03CR) 10Reedy: "19:42:26 1) PagedTiffHandlerTest::testDoTransform" [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135289 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [19:44:46] (03PS6) 10Jackmcbarn: Use RevisionFromTitle instead of a template callback [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/160572 (https://bugzilla.wikimedia.org/70495) [19:45:14] (03CR) 10Jforrester: "Should this be abandoned in favour of Ib14c00df or can it go ahead sooner?" [core] - 10https://gerrit.wikimedia.org/r/158546 (https://bugzilla.wikimedia.org/62905) (owner: 10Alex Monk) [19:45:33] anomie: i think i fixed everything you found in the patches for bug 70495 [19:48:15] 3MediaWiki / 3Search: Search box needs some normalization for Arabic Family languages - 10https://bugzilla.wikimedia.org/70899#c3 (10reza1615) and https://github.com/wikimedia/mediawiki-core/blob/master/maintenance/language/generateNormalizerDataAr.php [19:49:01] (03CR) 10Reedy: [C: 04-1] Make PagedTiffHandler extend TransformationalImageHandler (031 comment) [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/86413 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [19:50:07] (03PS9) 10Reedy: Make PagedTiffHandler extend TransformationalImageHandler [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/86413 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [19:50:59] (03PS2) 10Anomie: API: HTMLize and internationalize the help, add Special:ApiHelp [core] - 10https://gerrit.wikimedia.org/r/160798 (https://bugzilla.wikimedia.org/30936) [19:51:14] (03PS4) 10Reedy: Make tiff thumbnail in 2 steps. [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135289 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [19:51:35] (03CR) 10jenkins-bot: [V: 04-1] Make tiff thumbnail in 2 steps. [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135289 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [19:53:16] (03CR) 10Anomie: "The API has to set some title anyway, since so much of the rest of MediaWiki and various extension hooks requires one. If that's the only " [core] - 10https://gerrit.wikimedia.org/r/160797 (owner: 10Anomie) [19:54:30] How do I use a phpunit phar instead of pecl/pear phpunit? :) [19:54:46] (03CR) 10Legoktm: "How does this break PostgreSQL support?" [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/158310 (https://bugzilla.wikimedia.org/70376) (owner: 10Reedy) [19:55:06] * Reedy hugs legoktm [19:55:08] Reedy: --with-phpunitdir /data/project/coverage/phpunit.phar [19:59:15] (03PS1) 10Prtksxna: eventLogging: Use generateRandomSessionId [extensions/Popups] - 10https://gerrit.wikimedia.org/r/160807 [19:59:17] (03PS1) 10Prtksxna: settings: Add event logging for settings change [extensions/Popups] - 10https://gerrit.wikimedia.org/r/160808 [19:59:42] (03CR) 10jenkins-bot: [V: 04-1] settings: Add event logging for settings change [extensions/Popups] - 10https://gerrit.wikimedia.org/r/160808 (owner: 10Prtksxna) [20:01:57] Will attempt loading PHPUnit from `/var/www/wiki/mediawiki/phpunit.phar` [20:01:57] Couldn't find a usable PHPUnit. [20:01:58] pddft [20:03:06] oh, directory [20:03:22] sweet [20:03:46] 3MediaWiki / 3Internationalization: Update plural data to CLDR version 25 - 10https://bugzilla.wikimedia.org/62861#c4 (10Nemo) Would fixing this bug fix/supersede ? [20:05:18] ohhh [20:05:21] haha, only just merged [20:05:24] thanks gi11es :) [20:05:27] re: TransformationalImageHandler [20:06:38] (03CR) 10Reedy: "Not sure exactly if this is caused by this... But testing out https://gerrit.wikimedia.org/r/#/c/86413 locally:" [core] - 10https://gerrit.wikimedia.org/r/147718 (owner: 10Brian Wolff) [20:07:56] (03PS2) 10Reedy: Make GetLocalFileCopy pool counter call from tiff be generic [core] - 10https://gerrit.wikimedia.org/r/149791 (owner: 10Brian Wolff) [20:08:10] (03CR) 10Reedy: "That was easy? (TM)" [core] - 10https://gerrit.wikimedia.org/r/149791 (owner: 10Brian Wolff) [20:10:23] (03CR) 10Jdlrobson: Add mw-ui-icon (034 comments) [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) (owner: 10Jdlrobson) [20:10:33] 3MediaWiki / 3File management: Array to string conversion in TransformationalImageHandler.php:167 - 10https://bugzilla.wikimedia.org/70902 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3normal a:3None Running PHPUnit tests against PagedTiffHandler for https://gerrit.wikimedia.org/r/#/c/86413 results in diffe... [20:11:44] 3MediaWiki / 3File management: Array to string conversion in TransformationalImageHandler.php:167 - 10https://bugzilla.wikimedia.org/70902#c1 (10Sam Reed (reedy)) var_dump-ing $scaler gives: array(2) { [0]=> object(PagedTiffHandler)#620 (0) { } [1]=> string(11) "transformIM" } [20:11:57] (03CR) 10Reedy: "recheck" [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/86413 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [20:12:28] (03CR) 10Jackmcbarn: [C: 04-1] "There's a lot of unrelated whitespace changes." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/159973 (owner: 10Dan-nl) [20:15:07] (03CR) 10Jdlrobson: "Well the point of a mixin is I wouldn't use an existing class in core. I'm free to use it in anyway I choose. Using a class approach I'm f" [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx) [20:15:39] (03CR) 10Reedy: [C: 04-1] "Fails locally :/" [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/86413 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [20:16:02] (03CR) 10Reedy: "Bug: 70902" [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/86413 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [20:16:42] (03CR) 10EBernhardson: [C: 031] "I tested this locally and it appears to work correctly, it doesn't hide the new topic form in no-js for me(for action=new-topic)." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156489 (https://bugzilla.wikimedia.org/69220) (owner: 10Jdlrobson) [20:17:40] Where's Bawolff when you want him? :) [20:18:22] cannnnnnnaaaaaddddaaaaaaaaaaa [20:18:23] I think? [20:18:56] * Reedy kicks YuviPanda [20:19:54] (03CR) 10Reedy: Split BitmapHandler into two classes. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/147718 (owner: 10Brian Wolff) [20:20:34] (03PS6) 10EBernhardson: Move EmailNotification watchlist handling into helper methods [core] - 10https://gerrit.wikimedia.org/r/159395 (https://bugzilla.wikimedia.org/66876) [20:22:01] 3MediaWiki / 3File management: Array to string conversion in TransformationalImageHandler.php:167 - 10https://bugzilla.wikimedia.org/70902#c2 (10Sam Reed (reedy)) Not seemingly caused by https://gerrit.wikimedia.org/r/#/c/147718/ - the code is just moved... So presumably it's actually the extension at fault... [20:24:10] (03PS1) 10Manybubbles: Adds a cirrus-analyze api [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/160811 [20:24:26] 3MediaWiki / 3File management: Undefined $scaler in TransformationalImageHandler::rotate() - 10https://bugzilla.wikimedia.org/70903 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3trivia a:3None $scaler on line 574 is undefined in TransformationalImageHandler.php [20:24:54] (03CR) 10Reedy: Make PagedTiffHandler extend TransformationalImageHandler (031 comment) [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/86413 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [20:27:52] (03CR) 10Reedy: [C: 032] Make GetLocalFileCopy pool counter call from tiff be generic [core] - 10https://gerrit.wikimedia.org/r/149791 (owner: 10Brian Wolff) [20:28:06] (03CR) 10Aaron Schulz: [C: 04-1] "I really don't like how no sort of context object is passed in so we have to rely on global state to know if it's parsing." [core] - 10https://gerrit.wikimedia.org/r/160570 (https://bugzilla.wikimedia.org/70495) (owner: 10Jackmcbarn) [20:28:08] (03PS1) 10EBernhardson: Repair thanks tests [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/160813 [20:28:46] (03CR) 10jenkins-bot: [V: 04-1] Repair thanks tests [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/160813 (owner: 10EBernhardson) [20:29:17] (03CR) 10Jackmcbarn: "I don't see how I could give it any additional context." [core] - 10https://gerrit.wikimedia.org/r/160570 (https://bugzilla.wikimedia.org/70495) (owner: 10Jackmcbarn) [20:29:20] AaronSchulz: ^ [20:29:49] (03CR) 10Reedy: [C: 032] Add Special:GloballyWantedFiles [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/143828 (owner: 10Brian Wolff) [20:30:09] (03PS7) 10Reedy: Add Special:MostGloballyLinkedFiles (global version Special:Mostimages) [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/143755 (owner: 10Brian Wolff) [20:30:13] AaronSchulz: also, the idea (and the current use) is that the extension sets the hook, does the parse, then unsets the hook [20:30:14] (03CR) 10Reedy: [C: 032] Add Special:MostGloballyLinkedFiles (global version Special:Mostimages) [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/143755 (owner: 10Brian Wolff) [20:31:51] jackmcbarn: what if something fetching admin-editable config from a wiki page or something and hits that method in the process? We don't want that method to use the hypothetical text in that case do we? [20:32:16] I just don't like relying on global state like that...not saying it's easy to mitigate with the approach of using that hook [20:32:41] I'd rather keep it Parser specific (and to anything else that needs that, not sure wait afaik) [20:32:44] (03Merged) 10jenkins-bot: Add Special:MostGloballyLinkedFiles (global version Special:Mostimages) [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/143755 (owner: 10Brian Wolff) [20:33:03] (03PS7) 10EBernhardson: Move EmailNotification watchlist handling into helper method [core] - 10https://gerrit.wikimedia.org/r/159395 (https://bugzilla.wikimedia.org/66876) [20:33:06] (03PS5) 10Reedy: Add Special:GloballyWantedFiles [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/143828 (owner: 10Brian Wolff) [20:33:09] it's the kind of thing that "basically works" and then bites you somewhere later on [20:33:12] (03PS8) 10EBernhardson: Move EmailNotification watchlist handling into helper method [core] - 10https://gerrit.wikimedia.org/r/159395 (https://bugzilla.wikimedia.org/66876) [20:33:34] (03PS3) 10Legoktm: Add script to make a list of users who will be renamed [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159266 [20:33:39] though anomie might have a different opinion *shrug* [20:33:56] (03Merged) 10jenkins-bot: Make GetLocalFileCopy pool counter call from tiff be generic [core] - 10https://gerrit.wikimedia.org/r/149791 (owner: 10Brian Wolff) [20:34:09] AaronSchulz: so maybe add a Parser::getLatestRevision( $title ) or something, and hook that? [20:34:09] (03CR) 10jenkins-bot: [V: 04-1] Add script to make a list of users who will be renamed [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159266 (owner: 10Legoktm) [20:34:28] (or make it a popts thing like TemplateCallback?) [20:34:47] jackmcbarn: "a popts thing" is what I was thinking when I first looked at that bug [20:35:03] i'll probably do that then [20:35:08] AaronSchulz: also, do you have the same concern about https://gerrit.wikimedia.org/r/#/c/160546/ ? [20:35:10] could work [20:35:21] I didn't see that one [20:36:33] (03CR) 10Legoktm: "recheck" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159266 (owner: 10Legoktm) [20:38:07] (03PS9) 10Reedy: Make generating Parser test class names more robust [core] - 10https://gerrit.wikimedia.org/r/67098 (https://bugzilla.wikimedia.org/42174) (owner: 10Brian Wolff) [20:39:57] (03PS2) 10EBernhardson: Add "View Source" link to post actions menu [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160160 (https://bugzilla.wikimedia.org/60465) [20:40:24] (03PS3) 10EBernhardson: Add "View source" link to post actions menu [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160160 (https://bugzilla.wikimedia.org/60465) [20:40:59] (03CR) 10Reedy: [C: 032] Make generating Parser test class names more robust [core] - 10https://gerrit.wikimedia.org/r/67098 (https://bugzilla.wikimedia.org/42174) (owner: 10Brian Wolff) [20:41:20] (03CR) 10Anomie: "Configuration for translatewiki is in I90a3d1ca4e68a80cf30736e17791c18ba0e202a0" [core] - 10https://gerrit.wikimedia.org/r/160798 (https://bugzilla.wikimedia.org/30936) (owner: 10Anomie) [20:41:55] (03CR) 10Legoktm: [C: 032] Implement ApiBase::getParent in ApiFlowBase [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160796 (owner: 10Anomie) [20:42:00] 3MediaWiki extensions / 3OAuth: OAuth should be autoblock-exempt / "IP address had been blocked automatically" in croptool - 10https://bugzilla.wikimedia.org/66639#c6 (10Chris Steipp) (In reply to Dan Michael Heggø from comment #5) > Hm, there must better ways to block misbehaving OAuth apps than to use IP >... [20:42:32] (03Merged) 10jenkins-bot: Implement ApiBase::getParent in ApiFlowBase [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160796 (owner: 10Anomie) [20:45:02] (03CR) 10Reedy: [C: 032] Add Special:GloballyWantedFiles [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/143828 (owner: 10Brian Wolff) [20:45:10] (03Merged) 10jenkins-bot: Add Special:GloballyWantedFiles [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/143828 (owner: 10Brian Wolff) [20:45:44] (03PS5) 10Reedy: Make Special:Wantedfiles not include foreign false positives. [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/143835 (https://bugzilla.wikimedia.org/6220) (owner: 10Brian Wolff) [20:46:03] (03PS1) 10Anomie: API: Make jsonfm the default output format [core] - 10https://gerrit.wikimedia.org/r/160819 [20:46:54] (03CR) 10Dan-nl: "* i made them to comply with the strict linting test of < 100 characters per line." [core] - 10https://gerrit.wikimedia.org/r/159973 (owner: 10Dan-nl) [20:47:13] (03CR) 10Reedy: [C: 04-1] Make Special:Wantedfiles not include foreign false positives. (031 comment) [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/143835 (https://bugzilla.wikimedia.org/6220) (owner: 10Brian Wolff) [20:47:21] (03Merged) 10jenkins-bot: Make generating Parser test class names more robust [core] - 10https://gerrit.wikimedia.org/r/67098 (https://bugzilla.wikimedia.org/42174) (owner: 10Brian Wolff) [20:49:09] AaronSchulz: do you think i should do the same for that one, though, or is it safe? [20:49:25] (03CR) 10MaxSem: [C: 04-1] "See comments, also help page is misformatted for me: http://i60.tinypic.com/5ds3tj.png" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/160798 (https://bugzilla.wikimedia.org/30936) (owner: 10Anomie) [20:51:28] (03CR) 10MaxSem: [C: 031] "LGTM, but please add https://commons.wikimedia.org/wiki/File:Use_JSON_server_kitty.jpg to the help page." [core] - 10https://gerrit.wikimedia.org/r/160819 (owner: 10Anomie) [20:52:25] MaxSem: Behave [20:52:29] (03PS9) 10Jdlrobson: Add mw-ui-icon [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) [20:53:44] 3MediaWiki extensions / 3SecurePoll: Add UserMerge support to SecurePoll - 10https://bugzilla.wikimedia.org/67777#c2 (10Kunal Mehta (Legoktm)) I sent an email to Philippe, Jamesofur, and Tim Starling asking for their input on this. [20:54:07] (03PS10) 10Jdlrobson: Add mw-ui-icon [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) [20:54:16] (03CR) 10Legoktm: [C: 031] "+100" [core] - 10https://gerrit.wikimedia.org/r/160819 (owner: 10Anomie) [21:10:51] (03CR) 10Anomie: "Should this be abandoned in favor of Ib14c00df, now that that exists?" [core] - 10https://gerrit.wikimedia.org/r/154355 (https://bugzilla.wikimedia.org/63211) (owner: 10MarkTraceur) [21:12:16] (03PS1) 10EBernhardson: Repair `Locking a topic` browser test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160827 [21:12:19] Oh my god that's so fucking pretty [21:12:39] anomie: Have I told you lately that I love you [21:12:44] 3Wikimedia / 3Deployment systems: [OPS] Jenkins: Package php5-parsekit missing in Trusty - 10https://bugzilla.wikimedia.org/68255#c21 (10Antoine "hashar" Musso) The Jenkins job that lint PHP files reused parsekit / phplint.php so I have to adjust the jobs to xargs | php -l as well. Once done we can safely c... [21:13:01] marktraceur: No, you haven't [21:13:06] Well...I do [21:13:11] That's so nice [21:13:12] My gosh [21:13:20] (03CR) 10jenkins-bot: [V: 04-1] API: HTMLize and internationalize the help, add Special:ApiHelp [core] - 10https://gerrit.wikimedia.org/r/160798 (https://bugzilla.wikimedia.org/30936) (owner: 10Anomie) [21:13:59] (03Abandoned) 10MarkTraceur: Add help links to API documentation page [core] - 10https://gerrit.wikimedia.org/r/154355 (https://bugzilla.wikimedia.org/63211) (owner: 10MarkTraceur) [21:16:09] (03CR) 10Cmcmahon: [C: 032] Repair `Locking a topic` browser test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160827 (owner: 10EBernhardson) [21:16:43] (03Merged) 10jenkins-bot: Repair `Locking a topic` browser test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160827 (owner: 10EBernhardson) [21:16:44] 3MediaWiki / 3API: Document how to implement tokens in (extension) api modules - 10https://bugzilla.wikimedia.org/41956#c2 (10Brad Jorsch) Since Gerrit change 153110, things have gotten much simpler. Now most API modules will just implement ApiBase::needsToken public function needsToken() { return '... [21:17:45] 3MediaWiki / 3Unit tests: Generated parser test class names should be unique - 10https://bugzilla.wikimedia.org/42174#c5 (10Nemo) 5NEW>3RESO/FIX a:3Bawolff (Brian Wolff) Reedy CR ftw [21:19:36] (03PS4) 10Anomie: API: HTMLize and internationalize the help, add Special:ApiHelp [core] - 10https://gerrit.wikimedia.org/r/160798 (https://bugzilla.wikimedia.org/30936) [21:21:28] (03CR) 10EBernhardson: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/160813 (owner: 10EBernhardson) [21:25:15] (03PS2) 10Reedy: Add hook subscriber for UserMergeAccountFields [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/145216 (https://bugzilla.wikimedia.org/67757) (owner: 10Legoktm) [21:25:19] (03CR) 10Reedy: [C: 032] Add hook subscriber for UserMergeAccountFields [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/145216 (https://bugzilla.wikimedia.org/67757) (owner: 10Legoktm) [21:25:24] (03CR) 10Anomie: "We should also use the new 'APIGetDescriptionMessages' hook to add the link, 'APIGetDescription' won't do it anymore. Someone remind me to" [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/160800 (owner: 10Anomie) [21:27:26] (03PS26) 10Krinkle: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [21:28:00] (03CR) 10CSteipp: [C: 031] "Springle, is this something you want to run, or is it safe for someone else to just run the alter table on the master directly?" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159357 (owner: 10BryanDavis) [21:28:08] (03Merged) 10jenkins-bot: Add hook subscriber for UserMergeAccountFields [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/145216 (https://bugzilla.wikimedia.org/67757) (owner: 10Legoktm) [21:29:34] (03CR) 10CSteipp: [C: 032] SpecialGlobalGroupPermissions: Use css columns instead of tables [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/158998 (owner: 10Krinkle) [21:30:10] (03Merged) 10jenkins-bot: SpecialGlobalGroupPermissions: Use css columns instead of tables [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/158998 (owner: 10Krinkle) [21:30:26] (03CR) 10Reedy: "As the table is empty, I'd just run the ALTER :)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159357 (owner: 10BryanDavis) [21:30:33] 3MediaWiki extensions / 3CentralAuth: Rename of global (attached) users to existing global usernames - 10https://bugzilla.wikimedia.org/47918 (10Kunal Mehta (Legoktm)) [21:30:34] 3MediaWiki extensions / 3CirrusSearch: Exact match gets override by other biases ? - 10https://bugzilla.wikimedia.org/70905 (10Derk-Jan Hartman) 3NEW p:3Unprio s:3normal a:3None Take: https://en.wikipedia.org/w/index.php?title=Special%3ASearch&profile=advanced&search=%22above—then%22%7E0&fulltext=Sea... [21:30:34] 3MediaWiki extensions / 3AbuseFilter: Add UserMerge support to AbuseFilter - 10https://bugzilla.wikimedia.org/67757 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3Kunal Mehta (Legoktm) [21:30:50] csteipp: JFDI on the table alter. 0 rows should be very quick ;) [21:31:51] csteipp: Let me know if you want me to do it [21:35:02] superm401: Was "3ac7d14 Exclude users with null user_registration" written Friday September 12 intended to be deployed? [21:35:06] Cause it wasn't [21:35:14] (to wmf21 at least) [21:36:26] RoanKattouw, yeah, if I missed one of the branches, that was definitely unintentional. [21:38:14] 3MediaWiki extensions / 3UserMerge: can't merge/delete blocked user (Uncommitted DB writes) - 10https://bugzilla.wikimedia.org/65205#c3 (10Kunal Mehta (Legoktm)) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 39470 *** [21:38:16] superm401: OK I'll list it for the 4pm SWAT [21:38:29] 3MediaWiki extensions / 3UserMerge: Can't merge blocked users: Duplicate entry for key 'ipb_address' - 10https://bugzilla.wikimedia.org/39470#c6 (10Kunal Mehta (Legoktm)) *** Bug 65205 has been marked as a duplicate of this bug. *** [21:39:12] legoktm, let me know when we sort through the content update. [21:39:14] 3MediaWiki extensions / 3Extensions requests: Request: properties in articles (structured data) - 10https://bugzilla.wikimedia.org/1911#c18 (10Kunal Mehta (Legoktm)) 5NEW>3RESO/FIX Now that we have Wikidata, this is basically fixed. :) [21:39:28] RoanKattouw, yeah, I can see in the log, I missed the submodule update line (just for that branch), although I did the sync-dir. [21:39:36] legoktm: heh :) [21:39:44] 3MediaWiki extensions / 3CentralAuth: Error while merging accounts with MergeAccount on WikiVoyage: "1062: Duplicate entry for key 'wl_user'" - 10https://bugzilla.wikimedia.org/45035#c4 (10Kunal Mehta (Legoktm)) Was this Special:MergeAccount or Special:UserMerge? [21:39:46] Btw, it seems content serialization is used for both "to text box" and "to storage engine", which imho should be very different [21:40:32] RoanKattouw, thanks for the doing it in SWAT. [21:42:13] (03CR) 10Phuedx: "mw-notice could be a notice to the user, which is styled in a very specific way (and could respond to the browser in a very specific way)." [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx) [21:42:37] (03CR) 10CSteipp: [C: 04-1] Set a max number of users that can be merged at once (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/158258 (owner: 10Legoktm) [21:44:32] heh https://bugzilla.wikimedia.org/show_bug.cgi?id=23459 [21:44:39] AaronS: Aha, https://gerrit.wikimedia.org/r/#/c/159370/ was what I meant. [21:46:25] (03PS4) 10Legoktm: Set a max number of users that can be merged at once [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/158258 [21:46:33] (03CR) 10Legoktm: Set a max number of users that can be merged at once (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/158258 (owner: 10Legoktm) [21:46:43] 3MediaWiki extensions / 3SemanticForms: PageSchema generated XML is missing Description, DescriptionTooltipMode,TextBeforeField - 10https://bugzilla.wikimedia.org/70812#c2 (10Roland Uuesoo) 5UNCO>3RESO/FIX fixed on branch: master [21:46:59] 3MediaWiki extensions / 3SemanticForms: PageSchema: Description, DescriptionTooltipMode,TextBeforeField are not read from XML - 10https://bugzilla.wikimedia.org/70813#c1 (10Roland Uuesoo) 5UNCO>3RESO/FIX fixed on branch: master [21:47:29] 3MediaWiki extensions / 3SemanticForms: Fix invalid text location in Form generated by PageSchema - 10https://bugzilla.wikimedia.org/70811#c1 (10Roland Uuesoo) 5UNCO>3RESO/FIX fixed on branch: master [21:47:41] (03CR) 10Legoktm: [C: 032] Add cookie path for CentralAuth cookies [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143192 (https://bugzilla.wikimedia.org/70891) (owner: 10CSteipp) [21:48:07] (03CR) 10CSteipp: [C: 032] Set a ratelimit of one global merge per minute per user [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/158311 (owner: 10Legoktm) [21:48:14] (03Merged) 10jenkins-bot: Add cookie path for CentralAuth cookies [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143192 (https://bugzilla.wikimedia.org/70891) (owner: 10CSteipp) [21:48:41] (03CR) 10CSteipp: [C: 032] Set a max number of users that can be merged at once [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/158258 (owner: 10Legoktm) [21:49:00] 3MediaWiki extensions / 3CentralAuth: Make CentralAuth cookie path configurable - 10https://bugzilla.wikimedia.org/70891 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3Chris Steipp [21:49:15] (03Merged) 10jenkins-bot: Set a max number of users that can be merged at once [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/158258 (owner: 10Legoktm) [21:49:26] (03CR) 10Legoktm: SpecialGlobalUserMerge: Use HTMLFormFieldCloner instead of a textarea (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159785 (owner: 10Legoktm) [21:54:08] (03PS2) 10Legoktm: SpecialGlobalUserMerge: Use HTMLFormFieldCloner instead of a textarea [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159785 [21:55:15] (03CR) 10Legoktm: "PS2: Rebased" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159785 (owner: 10Legoktm) [21:56:46] 3MediaWiki-Vagrant: Access MultiVersion files from host - 10https://bugzilla.wikimedia.org/70907 (10Yuri Astrakhan) 3NEW p:3Unprio s:3normal a:3None In order for remote debugging to function properly, and to simplify various debugging scenarios, all files that are placed into /var/www/w should be acces... [21:58:05] (03CR) 10Yaron Koren: "Hi James," [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [21:59:29] 3MediaWiki extensions / 3CentralAuth: Rename of global (attached) users to existing global usernames - 10https://bugzilla.wikimedia.org/47918 (10Kunal Mehta (Legoktm)) [21:59:44] 3MediaWiki extensions / 3UserMerge: When user is deleted, some tables are not cleaned - 10https://bugzilla.wikimedia.org/49518 (10Kunal Mehta (Legoktm)) [21:59:45] 3MediaWiki extensions / 3CentralAuth: Rename of global (attached) users to existing global usernames - 10https://bugzilla.wikimedia.org/47918 (10Kunal Mehta (Legoktm)) [22:00:15] 3MediaWiki extensions / 3UserMerge: Can't merge blocked users: Duplicate entry for key 'ipb_address' - 10https://bugzilla.wikimedia.org/39470 (10Kunal Mehta (Legoktm)) [22:00:15] 3MediaWiki extensions / 3CentralAuth: Rename of global (attached) users to existing global usernames - 10https://bugzilla.wikimedia.org/47918 (10Kunal Mehta (Legoktm)) [22:00:45] 3MediaWiki extensions / 3CentralAuth: Identify extensions that need updates to work with user merging - 10https://bugzilla.wikimedia.org/67758 (10Kunal Mehta (Legoktm)) [22:00:45] 3MediaWiki extensions / 3CentralAuth: Rename of global (attached) users to existing global usernames - 10https://bugzilla.wikimedia.org/47918 (10Kunal Mehta (Legoktm)) [22:01:25] (03PS3) 10Jackmcbarn: Add parser callback to get a page's current revision [core] - 10https://gerrit.wikimedia.org/r/160570 (https://bugzilla.wikimedia.org/70495) [22:01:45] (03CR) 10Jackmcbarn: "Per discussion on IRC, this now uses a popts callback instead of a hook." [core] - 10https://gerrit.wikimedia.org/r/160570 (https://bugzilla.wikimedia.org/70495) (owner: 10Jackmcbarn) [22:03:40] (03PS7) 10Jackmcbarn: Use current revision callback instead of template callback [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/160572 (https://bugzilla.wikimedia.org/70495) [22:06:32] (03PS1) 10EBernhardson: H106: Locked topics should not appear collapsed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160843 [22:07:21] (03CR) 10CSteipp: [C: 031] "This is basically a noop until we change the config." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/147020 (https://bugzilla.wikimedia.org/67995) (owner: 10BryanDavis) [22:07:23] (03PS3) 10Legoktm: Don't update the entire table in one query to avoid melting servers [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/158310 (https://bugzilla.wikimedia.org/70376) (owner: 10Reedy) [22:08:57] (03CR) 10Legoktm: "I expanded the commit message a bit more to explain why we need this." [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/158310 (https://bugzilla.wikimedia.org/70376) (owner: 10Reedy) [22:09:29] 3MediaWiki extensions / 3UserMerge: UserMerge: don't update the entire table in one query - 10https://bugzilla.wikimedia.org/70376 (10Kunal Mehta (Legoktm)) [22:09:30] 3MediaWiki extensions / 3CentralAuth: Rename of global (attached) users to existing global usernames - 10https://bugzilla.wikimedia.org/47918 (10Kunal Mehta (Legoktm)) [22:12:07] (03PS2) 10Jackmcbarn: Improve compatibility with TemplateSandbox [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/160550 (https://bugzilla.wikimedia.org/70495) [22:17:36] (03CR) 10CSteipp: [C: 04-1] "I'd love to merge this, once hoo's comments are addressed" (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/155867 (owner: 10Legoktm) [22:21:26] (03CR) 10Aaron Schulz: [C: 032] Remove usage of spinner.gif [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/159370 (https://bugzilla.wikimedia.org/70615) (owner: 10Bartosz Dziewoński) [22:23:31] (03PS1) 10Legoktm: Update user_former_groups and user_properties, improve user_groups updating [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/160846 (https://bugzilla.wikimedia.org/49518) [22:23:43] (03Merged) 10jenkins-bot: Remove usage of spinner.gif [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/159370 (https://bugzilla.wikimedia.org/70615) (owner: 10Bartosz Dziewoński) [22:25:54] (03CR) 10Gergő Tisza: [C: 04-1] "Network Information is now a W3C editor's draft, with completely different properties than the old working draft." [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/132915 (owner: 10Gergő Tisza) [22:26:07] (03PS3) 10Gergő Tisza: Add network information from navigator.connection [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/132915 [22:26:09] (03CR) 10jenkins-bot: [V: 04-1] Add network information from navigator.connection [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/132915 (owner: 10Gergő Tisza) [22:32:01] (03CR) 10Jackmcbarn: "Please do that in a different patchset." [core] - 10https://gerrit.wikimedia.org/r/159973 (owner: 10Dan-nl) [22:36:00] (03PS1) 10EBernhardson: Bug 70906: Unlock fails on beta labs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160849 (https://bugzilla.wikimedia.org/70906) [22:36:16] Chrome's version of http://status.modern.ie/ is at http://www.chromestatus.com/features [22:36:31] Both are updates on what features they've shipped and are planning to. [22:36:45] 3MediaWiki / 3General/Unknown: Fix extensions depending on skins/common/ - 10https://bugzilla.wikimedia.org/70615#c26 (10James Forrester) 5PATC>3RESO/FIX All patches merged (or abandoned, in the case of the broken SemanticResultFormats): https://gerrit.wikimedia.org/r/#/q/bug:70615,n,z [22:36:59] Reedy: if both users are blocked, which block should we keep? the one of the user being merged into? [22:37:33] superm401: neither of those pages work with JS disabled :( [22:37:35] legoktm: lol [22:37:44] 3MediaWiki / 3Interface: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277#c58 (10James Forrester) Last remaining item in gerrit is https://gerrit.wikimedia.org/r/#/c/159290/ per https://gerrit.wikimedia.org/r/#/q/bug:69277,n,z – t... [22:37:46] block everyone [22:37:52] I mean [22:37:52] >.> [22:38:07] apparently the biggest use case of this extension is to merge all spambots into one user [22:38:26] haha [22:38:33] That sounds familiar [22:38:57] legoktm, longer one, probably. [22:39:13] legoktm, yeah, a lot of the features are JS-only too, though, so I don't blame them too much. [22:40:02] superm401: and if they have the same length but with different block settings? (anon only, tp access, email access?) [22:40:20] legoktm, stricter one on each individual setting? [22:40:34] E.g. if one has talk page access one doesn't, the merged doesn't. [22:41:04] That way it's not a loophole to evade anything. [22:41:13] ok [22:45:01] (03CR) 10Aaron Schulz: [C: 032] Start moving page move logic out of Title [core] - 10https://gerrit.wikimedia.org/r/160379 (owner: 10Legoktm) [22:45:12] glhf legoktm [22:45:25] ty Reedy. [22:45:36] Reedy: want to review https://gerrit.wikimedia.org/r/160846 ? [22:48:15] (03CR) 10Reedy: [C: 04-1] Update user_former_groups and user_properties, improve user_groups updating (031 comment) [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/160846 (https://bugzilla.wikimedia.org/49518) (owner: 10Legoktm) [22:48:31] legoktm: easy fixme.. want me to deal with it while you're doing block stuff? [22:48:40] (03CR) 10Spage: [C: 032] "`use Data\RecentChanges\RecentChanges as RecentChanges`" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160849 (https://bugzilla.wikimedia.org/70906) (owner: 10EBernhardson) [22:49:16] (03Merged) 10jenkins-bot: Bug 70906: Unlock fails on beta labs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160849 (https://bugzilla.wikimedia.org/70906) (owner: 10EBernhardson) [22:49:47] Reedy: oh, yes please [22:51:38] (03Merged) 10jenkins-bot: Start moving page move logic out of Title [core] - 10https://gerrit.wikimedia.org/r/160379 (owner: 10Legoktm) [22:52:02] (03CR) 10Aaron Schulz: [C: 032] MovePage::move(): Return a Status object [core] - 10https://gerrit.wikimedia.org/r/160381 (owner: 10Legoktm) [22:52:35] (03PS1) 10EBernhardson: Use updated RecentChanges class alias [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160850 [22:53:15] (03PS2) 10Reedy: Update user_former_groups and user_properties, improve user_groups updating [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/160846 (https://bugzilla.wikimedia.org/49518) (owner: 10Legoktm) [22:53:34] (03PS2) 10Reedy: Made SiteSQLStore use startAtomic() instead of DIY [core] - 10https://gerrit.wikimedia.org/r/160153 (owner: 10Aaron Schulz) [22:53:38] (03CR) 10Reedy: [C: 032] Made SiteSQLStore use startAtomic() instead of DIY [core] - 10https://gerrit.wikimedia.org/r/160153 (owner: 10Aaron Schulz) [22:55:20] (03CR) 10Reedy: [C: 032] Update user_former_groups and user_properties, improve user_groups updating [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/160846 (https://bugzilla.wikimedia.org/49518) (owner: 10Legoktm) [22:55:31] (03Merged) 10jenkins-bot: Update user_former_groups and user_properties, improve user_groups updating [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/160846 (https://bugzilla.wikimedia.org/49518) (owner: 10Legoktm) [22:56:55] ha! [22:56:57] there's a Block::chooseBlock [22:57:13] * From a list of multiple blocks, find the most exact and strongest Block. [22:57:14] interesting. [22:57:27] haha, nice [22:57:36] but that doesn't merge though [22:58:48] (03Merged) 10jenkins-bot: MovePage::move(): Return a Status object [core] - 10https://gerrit.wikimedia.org/r/160381 (owner: 10Legoktm) [22:58:50] * @param string|int|User|null $target [22:58:51] lol [22:58:55] gj PHP [22:59:14] Reedy: ContentHandler? [22:59:42] Block::parseTarget() [22:59:54] Oh, that's worse :D [23:00:01] Reedy: JIT that! [23:00:11] * AaronSchulz watches the tracelets dance [23:00:18] (03PS6) 10Tim Starling: Improve/rename Parser::replaceUnusualEscapes [core] - 10https://gerrit.wikimedia.org/r/152889 (https://bugzilla.wikimedia.org/57909) (owner: 10Anomie) [23:00:24] (03CR) 10Tim Starling: [C: 032] Improve/rename Parser::replaceUnusualEscapes [core] - 10https://gerrit.wikimedia.org/r/152889 (https://bugzilla.wikimedia.org/57909) (owner: 10Anomie) [23:00:42] sure hhvm will love it [23:00:54] (03PS1) 10Reedy: Couple of type hints for Block [core] - 10https://gerrit.wikimedia.org/r/160856 [23:01:00] (03Merged) 10jenkins-bot: Made SiteSQLStore use startAtomic() instead of DIY [core] - 10https://gerrit.wikimedia.org/r/160153 (owner: 10Aaron Schulz) [23:02:22] superm401, gimme yer patches for SWAT:) [23:02:42] also, please join #wikimedia-operations [23:02:55] blagh [23:03:03] I think it'll just be easier for me to compare the two database rows. [23:03:05] MaxSem, sorry, done. [23:03:39] superm401, or you want to just run the submodule update for what was already pulled? [23:04:07] (03PS3) 10Bartosz Dziewoński: mediawiki.api.options: New module for user preferences API (action=options) [core] - 10https://gerrit.wikimedia.org/r/160308 [23:04:11] legoktm, hmm, I didn't know there was such a method. [23:04:22] (03CR) 10Bartosz Dziewoński: mediawiki.api.options: New module for user preferences API (action=options) (032 comments) [core] - 10https://gerrit.wikimedia.org/r/160308 (owner: 10Bartosz Dziewoński) [23:04:24] Maybe that's a standard method. [23:04:39] May be a slightly different intended use case, though. [23:04:46] 3MediaWiki / 3MediaWiki UI: Scrolling list overlays should not transfer scroll action to background windows - 10https://bugzilla.wikimedia.org/70908 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None --Reposted conversation from email thread-- Check out the notification menu on pinterest new... [23:04:48] (03CR) 10Tim Starling: [C: 032] Add additional interwiki links as requested in various bugs [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/141099 (https://bugzilla.wikimedia.org/16962) (owner: 10TTO) [23:05:21] (03PS1) 10Hoo man: Update Wikidata [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160858 [23:05:42] (03PS1) 10Manas: Example change [extensions/examples] - 10https://gerrit.wikimedia.org/r/160859 [23:05:48] (03CR) 10Bartosz Dziewoński: "Fomafix, I don't know. The current way seemed more natural, but it doesn't really matter for me." [core] - 10https://gerrit.wikimedia.org/r/160308 (owner: 10Bartosz Dziewoński) [23:06:03] (03PS1) 10Hoo man: Update Wikidata [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160860 [23:07:57] (03Merged) 10jenkins-bot: Improve/rename Parser::replaceUnusualEscapes [core] - 10https://gerrit.wikimedia.org/r/152889 (https://bugzilla.wikimedia.org/57909) (owner: 10Anomie) [23:08:12] (03CR) 10MaxSem: [C: 032 V: 032] Update Wikidata [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160860 (owner: 10Hoo man) [23:08:14] (03Merged) 10jenkins-bot: Add additional interwiki links as requested in various bugs [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/141099 (https://bugzilla.wikimedia.org/16962) (owner: 10TTO) [23:08:45] (03CR) 10MaxSem: [C: 032 V: 032] Update Wikidata [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160858 (owner: 10Hoo man) [23:11:47] (03CR) 10Manas: "Looks good" [extensions/examples] - 10https://gerrit.wikimedia.org/r/160859 (owner: 10Manas) [23:13:59] 3MediaWiki / 3MediaWiki UI: Agora .mw-ui-button doesn't override anchor :visited and :active text colors - 10https://bugzilla.wikimedia.org/48184#c5 (10Jon) If it can be used in this way, please update the documentation. The documentation is like a contract. It's the only way we can ensure we support these s... [23:14:06] (03CR) 10Catrope: [C: 032 V: 032] Revert "Revert "Update VisualEditor to wmf21 for cherry-pick of I0fb47f7c91f61 and If48555fa476"" [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160801 (owner: 10Jforrester) [23:14:10] (03CR) 10Catrope: [C: 032 V: 032] Revert "Revert "Update VisualEditor to wmf20 for cherry-pick of I0fb47f7c91f61 and If48555fa476"" [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160799 (owner: 10Jforrester) [23:15:16] 3MediaWiki extensions / 3UserMerge: When user is deleted, some tables are not cleaned - 10https://bugzilla.wikimedia.org/49518 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:5T. Gries>3Kunal Mehta (Legoktm) [23:15:38] (03PS1) 10Catrope: Update VisualEditor to wmf20 for cherry-pick of I917944a [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160868 [23:17:01] superm401, Reedy: hmm, I don't like altering the block values, because it'll look like the admin who made the block did something different than they actually did. [23:17:20] (03CR) 10Jamesmontalvo3: "I'll make the mediaIsApprovable change later tonight. The userCanApprove method clearly needs to be fixed, so I'll do that, too, but I hav" [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [23:17:36] legoktm: Have we got some user account we could use to re-apply a "new" block? [23:17:43] "Abuse filter" [23:17:55] I guess in most cases, the user doing the rename would presumably have the rights... [23:18:20] (03CR) 10MaxSem: [C: 032 V: 032] Update VisualEditor to wmf20 for cherry-pick of I917944a [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160868 (owner: 10Catrope) [23:18:27] legoktm, yeah, that's a valid point, although the counter-point is that it could be mitigated by a clear log message (merged blocks by User:Admin1 and User:Admin2). [23:18:44] 3MediaWiki / 3MediaWiki UI: overriding full-width input fields in Agora mw-ui-vform - 10https://bugzilla.wikimedia.org/47520 (10Jon) 5UNCO>3RESO/INV [23:18:45] 3MediaWiki / 3Interface: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277#c59 (10Bartosz Dziewoński) 5PATC>3ASSI (In reply to James Forrester from comment #58) > Last remaining item in gerrit is https://gerrit.wikimedia.org/r/... [23:19:13] (03PS1) 10Catrope: Update VisualEditor for cherry-pick of I917944a [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160870 [23:19:15] bah, this is getting pretty complex now. [23:19:30] 3MediaWiki / 3MediaWiki UI: checkboxes hover and click and hover states are not to spec - 10https://bugzilla.wikimedia.org/70909 (10Jared Zimmerman (WMF)) [23:19:32] 3MediaWiki / 3MediaWiki UI: checkboxes hover and click and hover states are not to spec - 10https://bugzilla.wikimedia.org/70909 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None currently checkboxes do not carry the bottom border on hover, only on focus. additionally when clicked (active)... [23:19:48] how about [23:20:11] legoktm, or just use chooseBlock and give up on merging individual components of the block. [23:20:13] we use Block::chooseBlock() to avoid fatal errors, and have an enhancement bug open to actually properly merge them? [23:20:14] (03CR) 10MaxSem: [C: 032 V: 032] Update VisualEditor for cherry-pick of I917944a [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160870 (owner: 10Catrope) [23:20:14] ++ [23:20:16] okay [23:20:18] When I made that suggestion I didn't realize that even existed. [23:20:29] 3MediaWiki / 3MediaWiki UI: Create primary button with indeterminate loader - 10https://bugzilla.wikimedia.org/70417#c2 (10Jon) 5NEW>3RESO/INV This bug is not actionable and lacks a use case. Judging on the photo this looks like it might be good to be implemented as part of Multimedia viewer. [23:22:14] legoktm, one thing I don't get is why chooseBlock apparently ignores duration. [23:22:21] Also, not sure how it handles usernames as opposed to IPs. [23:23:24] Sounds like something that should have some unit tests [23:23:29] 3MediaWiki / 3MediaWiki UI: Input fields should be relative to input strings - 10https://bugzilla.wikimedia.org/70404#c5 (10Jon) I know. Width 100% = wide. What should the size be? Should small be the default or should big be the default for input fields? [23:23:47] 3Wikimedia / 3Site requests: Logout users with MD5 password hash - 10https://bugzilla.wikimedia.org/70910 (10Tyler Romeo) 3NEW p:3Unprio s:3minor a:3None With PBKDF2 being deployed, if and only if it seems to be working OK for a short while, we should reset the user tokens of users with MD5 hashes, t... [23:23:59] The current usages seem to just be XFF related [23:24:44] 3MediaWiki / 3MediaWiki UI: Buttons have text of same colour when focused - 10https://bugzilla.wikimedia.org/70801 (10Jon) [23:24:48] "logout all users across from WMF wikis" [23:25:16] 3MediaWiki / 3MediaWiki UI: Create primary button with indeterminate loader - 10https://bugzilla.wikimedia.org/70417#c3 (10Jared Zimmerman (WMF)) 5RESO/INV>3REOP Jon, not all bugs are targeted to developers first. This is a bug for design. Once assets are created and uploaded to trello or bugzilla someon... [23:25:30] 3MediaWiki / 3MediaWiki UI: Should Mediawiki UI change font-family for textareas? - 10https://bugzilla.wikimedia.org/70028 (10Jon) s:5normal>3enhanc [23:26:29] 3MediaWiki / 3MediaWiki UI: implement light inline button style in mediawiki.ui - 10https://bugzilla.wikimedia.org/62744#c9 (10Jon) I'm confused. is this issue fixed or not? If not could you more clearly explain the issue? [23:27:31] 3MediaWiki extensions / 3EducationProgram: EducationProgram: improve GENDER support in message strings - 10https://bugzilla.wikimedia.org/70911 (10Sage Ross) 3NEW p:3Unprio s:3minor a:3None In message strings for the Education Program extension, "you" and other English pronouns are mostly lacking GEN... [23:28:02] 3MediaWiki / 3MediaWiki UI: Create primary button with indeterminate loader - 10https://bugzilla.wikimedia.org/70417 (10Jared Zimmerman (WMF)) a:3May [23:30:03] (03PS1) 10Legoktm: Handle merging blocks a bit better [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/160872 (https://bugzilla.wikimedia.org/39470) [23:30:11] Reedy, superm401 ^ I haven't tested that yet [23:30:39] (03PS2) 10Legoktm: Handle merging blocks a bit better [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/160872 (https://bugzilla.wikimedia.org/39470) [23:30:59] 3MediaWiki / 3MediaWiki UI: Input fields should be relative to input strings - 10https://bugzilla.wikimedia.org/70404#c6 (10Jared Zimmerman (WMF)) The input field should suggest to the user the type of content that should be entered. There is no hard and fast rule for open ended fields, however fields with s... [23:31:46] (03CR) 10Bartosz Dziewoński: "Admittedly this is just a "feels icky" with no hard reasoning. I'd like to hear what Daniel thinks about this." [core] - 10https://gerrit.wikimedia.org/r/160797 (owner: 10Anomie) [23:39:29] 3MediaWiki / 3MediaWiki UI: MediaWiki UI styles are applied to core instead of relevant skins - 10https://bugzilla.wikimedia.org/70351#c13 (10Jon) s:5normal>3enhanc This bug doesn't seem actionable right now. I would suggest that the existing modules are adapted to use skin styles, so skins can make the... [23:40:47] 3MediaWiki / 3MediaWiki UI: MediaWiki UI styles are applied to core instead of relevant skins - 10https://bugzilla.wikimedia.org/70351 (10Matthew Flaschen) a:3Matthew Flaschen [23:42:46] 3MediaWiki / 3MediaWiki UI: Remove $wgUseMediaWikiUIEverywhere dependency for button and input styling (tracking) - 10https://bugzilla.wikimedia.org/70913 (10Jon) 3NEW p:3Unprio s:3normal a:3None As discussed on the design mailing list (Getting $wgUseMediaWikiUIEverywhere = true to be the default) a... [23:43:30] 3MediaWiki / 3MediaWiki UI: Set $wgUseMediaWikiUIEverywhere = true (tracking) - 10https://bugzilla.wikimedia.org/70424 (10Jon) [23:43:31] 3MediaWiki / 3MediaWiki UI: Remove $wgUseMediaWikiUIEverywhere dependency for button and input styling (tracking) - 10https://bugzilla.wikimedia.org/70913 (10Jon) [23:43:59] (03PS1) 10Wctaiwan: Use Title::hasContentModel() instead of a direct comparison [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/160873 [23:44:27] (03CR) 10jenkins-bot: [V: 04-1] Use Title::hasContentModel() instead of a direct comparison [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/160873 (owner: 10Wctaiwan) [23:44:32] (03PS2) 10Legoktm: GlobalVarConfig shouldn't throw exceptions for null-valued config settings [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/160688 (https://bugzilla.wikimedia.org/66986) [23:45:12] (03PS3) 10Legoktm: GlobalVarConfig shouldn't throw exceptions for null-valued config settings [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/160688 (https://bugzilla.wikimedia.org/66986) [23:45:34] (03CR) 10Legoktm: [C: 032] "Added release notes for the backport." [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/160688 (https://bugzilla.wikimedia.org/66986) (owner: 10Legoktm) [23:46:18] (03CR) 10jenkins-bot: [V: 04-1] GlobalVarConfig shouldn't throw exceptions for null-valued config settings [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/160688 (https://bugzilla.wikimedia.org/66986) (owner: 10Legoktm) [23:46:31] wat [23:46:39] 23:46:13 Error: 1 no such table: updatelog [23:46:46] (03CR) 10Legoktm: "recheck" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/160688 (https://bugzilla.wikimedia.org/66986) (owner: 10Legoktm) [23:48:17] (03CR) 10Reedy: Handle merging blocks a bit better (031 comment) [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/160872 (https://bugzilla.wikimedia.org/39470) (owner: 10Legoktm) [23:51:29] 3MediaWiki / 3MediaWiki UI: Create primary button with indeterminate loader - 10https://bugzilla.wikimedia.org/70417#c4 (10Jon) s:5normal>3enhanc All bugs should be actionable and clear to people that are outside Wikimedia. As pointed out by Matt and myself this is not clear at all. The trello card link... [23:52:29] 3MediaWiki / 3MediaWiki UI: Special:Preferences: Custom (other) input field for Time offset is too long - 10https://bugzilla.wikimedia.org/70405#c5 (10Jon) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 70404 *** [23:52:30] 3MediaWiki / 3MediaWiki UI: Input fields should be relative to input strings - 10https://bugzilla.wikimedia.org/70404#c7 (10Jon) *** Bug 70405 has been marked as a duplicate of this bug. *** [23:52:59] 3MediaWiki / 3MediaWiki UI: Input fields should be relative to input strings - 10https://bugzilla.wikimedia.org/70404#c8 (10Jon) As another example as pointed out by Jared this happens here" Special:Preferences => Appearance tab => Time offset => Other (specify offset) Then, the text field below is too long. [23:55:44] 3Wikimedia / 3Site requests: Switch Media Viewer to opt-in for default in dewp - 10https://bugzilla.wikimedia.org/69292#c10 (10Elvey) Google Translation of the German to English: Fabrice Florin's post on behalf of the WMF: https://translate.google.com/translate?sl=auto&tl=en&js=y&prev=_t&hl=en&ie=UTF-8&u=... [23:55:49] (03PS2) 10Wctaiwan: Use Title::hasContentModel() instead of a direct comparison [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/160873 [23:56:21] (03CR) 10jenkins-bot: [V: 04-1] Use Title::hasContentModel() instead of a direct comparison [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/160873 (owner: 10Wctaiwan) [23:56:44] 3MediaWiki / 3MediaWiki UI: Support
and update documentation about its usage - 10https://bugzilla.wikimedia.org/48184#c6 (10Jon) *** Bug 61886 has been marked as a duplicate of this bug. *** [23:58:44] (03CR) 10Daniel Friesen: "Me? I'm not 100% certain what Anomie is creating is supposed to look like." [core] - 10https://gerrit.wikimedia.org/r/160797 (owner: 10Anomie) [23:59:01] 3MediaWiki / 3MediaWiki UI: Single line input fields text baseline is too high - 10https://bugzilla.wikimedia.org/70917 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None Created attachment 16494 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16494&action=edit input field baseline Th... [23:59:44] 3MediaWiki / 3MediaWiki UI: Support