[00:01:03] ok, figured out what's dying, it's the require_once of the maint script [00:02:07] (03CR) 10Wctaiwan: [C: 032] Track usage of {{#target}} as well [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/159424 (owner: 10Legoktm) [00:02:37] (03Merged) 10jenkins-bot: Track usage of {{#target}} as well [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/159424 (owner: 10Legoktm) [00:08:51] hoo: ok, this was a pretty stupid bug. [00:09:21] :D That's also typical for such stuff [00:12:12] (03PS1) 10Legoktm: removeOldManualUserPages: Fix path issues when trying to determine $IP. [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/160359 [00:12:16] (03PS2) 10Wctaiwan: Override TextContentHandler::getContentClass() [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/160307 (owner: 10Legoktm) [00:12:20] hoo: ^ [00:12:52] Hmm, am I allowed to use http://code.metager.de/source/raw/chromium/media/test/data/bear-vp9-opus.webm as a test file for unit tests. I suppose its open source [00:12:54] (03CR) 10Wctaiwan: [C: 032] Override TextContentHandler::getContentClass() [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/160307 (owner: 10Legoktm) [00:13:06] (03CR) 10Hoo man: [C: 032] removeOldManualUserPages: Fix path issues when trying to determine $IP. [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/160359 (owner: 10Legoktm) [00:13:11] (03Merged) 10jenkins-bot: removeOldManualUserPages: Fix path issues when trying to determine $IP. [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/160359 (owner: 10Legoktm) [00:13:23] (03Merged) 10jenkins-bot: Override TextContentHandler::getContentClass() [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/160307 (owner: 10Legoktm) [00:13:54] (03CR) 10Bartosz Dziewoński: [C: 032] "I take it that you don't want to change anything." [extensions/HostStats] - 10https://gerrit.wikimedia.org/r/153335 (owner: 10Kghbln) [00:14:01] (03Merged) 10jenkins-bot: Several changes for version 1.3.1 [extensions/HostStats] - 10https://gerrit.wikimedia.org/r/153335 (owner: 10Kghbln) [00:14:24] bawolff: probably! [00:15:01] That's the best part of copyright things - the answer is always probably, and never a definite yes ;) [00:15:57] hoo: yay, tests pass now. :D [00:16:48] bawwwwolffffff [00:16:51] https://gerrit.wikimedia.org/r/#/c/158876/ [00:16:52] * legoktm tries running coverage again [00:17:04] (03PS2) 10Bartosz Dziewoński: Update categorylinks.cl_type when moving a page [core] - 10https://gerrit.wikimedia.org/r/158876 (https://bugzilla.wikimedia.org/69740) [00:25:21] (03CR) 10Bartosz Dziewoński: [C: 032] Use Title::hasContentModel() instead of a direct comparison [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/157011 (owner: 10Legoktm) [00:25:53] (03CR) 10jenkins-bot: [V: 04-1] Use Title::hasContentModel() instead of a direct comparison [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/157011 (owner: 10Legoktm) [00:26:33] 00:25:52 MWException: Flow\Tests\SpamFilter\SpamBlacklistTest::tearDown() must call parent::tearDown() in /srv/ssd/jenkins-slave/workspace/mwext-Thanks-testextensions-master/tests/phpunit/MediaWikiTestCase.php on line 95 [00:26:53] I blame Flow. [00:27:43] (03PS1) 10Legoktm: Call parent::tearDown() in unit tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160366 [00:27:45] hoo: ^ [00:28:19] MatmaRex: ^ [00:28:20] waiting for jeknins [00:28:23] (03CR) 10jenkins-bot: [V: 04-1] Call parent::tearDown() in unit tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160366 (owner: 10Legoktm) [00:28:23] oh, ok [00:28:25] :< [00:28:44] yaaay even more [00:29:16] (03PS2) 10Legoktm: Call parent::tearDown() in unit tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160366 [00:29:21] (03CR) 10Brian Wolff: [C: 032] "lgtm" [core] - 10https://gerrit.wikimedia.org/r/158876 (https://bugzilla.wikimedia.org/69740) (owner: 10Bartosz Dziewoński) [00:29:54] hoo: passed! [00:30:07] (03CR) 10Hoo man: [C: 032] ":)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160366 (owner: 10Legoktm) [00:30:39] (03Merged) 10jenkins-bot: Call parent::tearDown() in unit tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160366 (owner: 10Legoktm) [00:30:42] (03CR) 10MZMcBride: Update categorylinks.cl_type when moving a page (031 comment) [core] - 10https://gerrit.wikimedia.org/r/158876 (https://bugzilla.wikimedia.org/69740) (owner: 10Bartosz Dziewoński) [00:30:59] (03CR) 10Legoktm: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/157011 (owner: 10Legoktm) [00:31:55] hmm [00:32:13] (03CR) 10Legoktm: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/157011 (owner: 10Legoktm) [00:32:15] * legoktm impatient [00:32:24] (03CR) 10Brian Wolff: Update categorylinks.cl_type when moving a page (031 comment) [core] - 10https://gerrit.wikimedia.org/r/158876 (https://bugzilla.wikimedia.org/69740) (owner: 10Bartosz Dziewoński) [00:32:59] grrr [00:33:04] Louder. [00:33:08] legoktm: I thumb my nose at you, sir. [00:35:31] https://tools.wmflabs.org/coverage/GlobalCssJs/extensions_GlobalCssJs.html yay :D [00:35:52] (03Merged) 10jenkins-bot: Update categorylinks.cl_type when moving a page [core] - 10https://gerrit.wikimedia.org/r/158876 (https://bugzilla.wikimedia.org/69740) (owner: 10Bartosz Dziewoński) [00:37:17] (03PS1) 10Jackmcbarn: Let wikis disable "Allow saving code with errors" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/160367 [00:39:57] (03PS1) 10leucosticte: action=logevents now provides redirpageid for page move events [core] - 10https://gerrit.wikimedia.org/r/160368 (https://bugzilla.wikimedia.org/68930) [00:44:19] (03PS2) 10leucosticte: action=logevents now provides redirpageid for page move events [core] - 10https://gerrit.wikimedia.org/r/160368 (https://bugzilla.wikimedia.org/68930) [00:45:56] (03Abandoned) 10leucosticte: Make log_params contain null revision rev_id and moved page ID [core] - 10https://gerrit.wikimedia.org/r/150969 (https://bugzilla.wikimedia.org/68930) (owner: 10leucosticte) [00:50:04] (03PS3) 10Brian Wolff: Let TMH detect webm files using opus and VP9 codecs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108482 (https://bugzilla.wikimedia.org/60245) [00:51:54] (03CR) 10Brian Wolff: "ps3 added unit tests" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108482 (https://bugzilla.wikimedia.org/60245) (owner: 10Brian Wolff) [00:52:46] (03PS1) 10Yurik: Patched security issue per csteipp [extensions/Graph] - 10https://gerrit.wikimedia.org/r/160369 [00:52:57] (03CR) 10Legoktm: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/157011 (owner: 10Legoktm) [00:53:47] (03CR) 10Legoktm: "wtf jenkins???" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/157011 (owner: 10Legoktm) [00:54:39] legoktm: after the all tests passed messages, there were errors [00:54:51] yes, but we fixed those in flow already [00:55:03] [17:30:39] (Merged) jenkins-bot: Call parent::tearDown() in unit tests [extensions/Flow] - https://gerrit.wikimedia.org/r/160366 (owner: Legoktm) [00:55:24] 00:53:00 Git archive of 'master' from /srv/ssd/gerrit/mediawiki/extensions/Flow.git [00:55:55] er [00:55:58] but it says [00:55:59] 00:53:00 Fetching Flow [00:55:59] 00:53:00 Deleting and recreating '/srv/ssd/jenkins-slave/workspace/mwext-Thanks-testextensions-master/extensions/Flow'... [00:55:59] 00:53:00 Copying 'Flow' in '/srv/ssd/jenkins-slave/workspace/mwext-Thanks-testextensions-master/extensions/Flow' [00:57:07] it's not pulling from gerrit it seems [00:57:13] not sure how often it pulls stuff [00:57:29] 3MediaWiki extensions / 3[other]: Graph extension security review - 10https://bugzilla.wikimedia.org/69623#c4 (10Yuri Astrakhan) Graph ext patch: https://gerrit.wikimedia.org/r/#/c/160369/ Upstream pull request: https://github.com/trifacta/vega/pull/217 [01:09:30] (03PS3) 10Brian Wolff: Mark ParserOutput of MessageContent as varying by userlanguage [core] - 10https://gerrit.wikimedia.org/r/101479 (https://bugzilla.wikimedia.org/41065) [01:12:56] (03CR) 10Hoo man: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/157011 (owner: 10Legoktm) [01:14:30] (03PS2) 10Hoo man: Use Title::hasContentModel() instead of a direct comparison [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/157011 (owner: 10Legoktm) [01:14:45] (03CR) 10Legoktm: [C: 04-1] Show Captcha after click on edit over buttons on EditPage (033 comments) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/136323 (https://bugzilla.wikimedia.org/19648) (owner: 10Florianschmidtwelzow) [01:14:58] (03CR) 10jenkins-bot: [V: 04-1] Use Title::hasContentModel() instead of a direct comparison [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/157011 (owner: 10Legoktm) [01:15:03] :< [01:15:09] * hoo cries [01:15:11] -.- [01:17:05] The submodule in mediawiki/extensions also looks fine [01:17:07] mh [01:17:26] legoktm: Is there something in Flow which you can merge to test further? [01:18:01] (03CR) 10Legoktm: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160327 (owner: 10L10n-bot) [01:18:26] wonder why l10n-bot has open stuff anyways [01:18:47] strange [01:18:52] ^ well, that passed. [01:18:57] maybe it died halfway through [01:19:32] merge it? [01:19:49] (03CR) 10Legoktm: [C: 032] Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160327 (owner: 10L10n-bot) [01:20:23] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160327 (owner: 10L10n-bot) [01:21:14] well... [01:21:31] now recheck?! [01:21:41] (03CR) 10Legoktm: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/157011 (owner: 10Legoktm) [01:21:48] this is such a stupid change in the first place >.> [01:21:55] (03CR) 10Brian Wolff: [C: 032] Make image/vnd.microsoft.icon be an alias for image/x-icon mime type. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/159824 (https://bugzilla.wikimedia.org/69437) (owner: 10Gerrit Patch Uploader) [01:22:13] (03CR) 10Legoktm: [C: 032] Mark ParserOutput of MessageContent as varying by userlanguage [core] - 10https://gerrit.wikimedia.org/r/101479 (https://bugzilla.wikimedia.org/41065) (owner: 10Brian Wolff) [01:22:41] hoo: still failing :< [01:22:46] :S [01:22:51] no idea, then [01:23:04] poke hashar, maybe? [01:23:14] 3MediaWiki / 3File management: image/vnd.microsoft.icon not recognized as MIME type for .ico (can trigger error message when trying to overwrite existing icons) - 10https://bugzilla.wikimedia.org/69437#c6 (10Bawolff (Brian Wolff)) 5PATC>3RESO/FIX (In reply to Gerrit Notification Bot from comment #5) > Ch... [01:28:40] (03Merged) 10jenkins-bot: Make image/vnd.microsoft.icon be an alias for image/x-icon mime type. [core] - 10https://gerrit.wikimedia.org/r/159824 (https://bugzilla.wikimedia.org/69437) (owner: 10Gerrit Patch Uploader) [01:28:47] (03Merged) 10jenkins-bot: Mark ParserOutput of MessageContent as varying by userlanguage [core] - 10https://gerrit.wikimedia.org/r/101479 (https://bugzilla.wikimedia.org/41065) (owner: 10Brian Wolff) [01:38:42] (03PS1) 10Legoktm: Support new "assets" directory [vagrant] - 10https://gerrit.wikimedia.org/r/160373 [01:39:24] (03PS2) 10Legoktm: Support new "assets" directory [vagrant] - 10https://gerrit.wikimedia.org/r/160373 [01:41:27] (03CR) 10Ori.livneh: [C: 032] Support new "assets" directory [vagrant] - 10https://gerrit.wikimedia.org/r/160373 (owner: 10Legoktm) [01:41:32] (03Merged) 10jenkins-bot: Support new "assets" directory [vagrant] - 10https://gerrit.wikimedia.org/r/160373 (owner: 10Legoktm) [01:53:35] (03PS1) 10Hoo man: Prevent "Notice: Undefined index" in wfDiff [core] - 10https://gerrit.wikimedia.org/r/160375 [01:53:39] easy one ^ [02:01:51] (03PS1) 10Jackmcbarn: Don't list nonexistent groups as addable or removable [core] - 10https://gerrit.wikimedia.org/r/160377 [02:08:03] (03CR) 10Legoktm: [C: 032] Prevent "Notice: Undefined index" in wfDiff [core] - 10https://gerrit.wikimedia.org/r/160375 (owner: 10Hoo man) [02:08:32] ori_: do you know if prod will require any changes for the assets directory? [02:14:20] (03Merged) 10jenkins-bot: Prevent "Notice: Undefined index" in wfDiff [core] - 10https://gerrit.wikimedia.org/r/160375 (owner: 10Hoo man) [02:18:12] (03PS1) 10Legoktm: Start moving page move logic out of Title [core] - 10https://gerrit.wikimedia.org/r/160379 [02:30:47] (03PS2) 10Legoktm: Start moving page move logic out of Title [core] - 10https://gerrit.wikimedia.org/r/160379 [02:33:01] (03PS1) 10Legoktm: MovePage::move(): Return a Status object [core] - 10https://gerrit.wikimedia.org/r/160381 [02:34:31] (03PS1) 10Hoo man: Prevent "Notice: Undefined index" in ApiQuerySiteinfo [core] - 10https://gerrit.wikimedia.org/r/160382 [02:34:41] last change for today! [02:34:46] good night [02:34:57] gnite! [02:36:14] :) [02:40:20] Krenair: should we be parsing [[links]] into link tables on Gadget: namespace pages like we currently do for MediaWiki namespace js/css pages? [02:42:17] legoktm, ... why would we want to do that? [02:42:28] because we currently do? :P [02:42:37] For the MediaWiki namespace [02:42:44] it just adds to link tables, doesn't actually render them [02:42:58] Well, I guess we do need back-compat with the existing gadgets [02:43:05] So yes, we probably should. :/ [02:45:55] ok, I'll submit a patch for that after dinner [02:46:30] jackmcbarn, https://gerrit.wikimedia.org/r/#/c/160377/1/includes/api/ApiQuerySiteinfo.php - shouldn't you run User::getAllGroups before the loop? [02:47:03] It won't change so you shouldn't need to keep running it. Maybe I'm just being fussy though :p [02:47:34] Krenair: good catch [02:47:45] (03CR) 10Alex Monk: Don't list nonexistent groups as addable or removable (031 comment) [core] - 10https://gerrit.wikimedia.org/r/160377 (owner: 10Jackmcbarn) [02:48:21] (03PS2) 10Jackmcbarn: Don't list nonexistent groups as addable or removable [core] - 10https://gerrit.wikimedia.org/r/160377 [02:48:59] As for SpecialListGroupRights, that code could probably be cut down a lot. But not in this commit obviously [02:50:59] 3MediaWiki extensions / 3TemplateSandbox: TemplateSandbox doesn't handle things like #ifexist and Scribunto's getContent - 10https://bugzilla.wikimedia.org/70495#c1 (10Jackmcbarn) Changing to a TemplateSandbox bug, since this affects other things too, like #ifexist. The problem is that there's a lot of ways... [02:53:45] (03CR) 10Alex Monk: [C: 032] Don't list nonexistent groups as addable or removable [core] - 10https://gerrit.wikimedia.org/r/160377 (owner: 10Jackmcbarn) [02:56:29] legoktm: I think jenkins just hates you [03:00:30] (03Merged) 10jenkins-bot: Don't list nonexistent groups as addable or removable [core] - 10https://gerrit.wikimedia.org/r/160377 (owner: 10Jackmcbarn) [03:06:59] (03CR) 10Alex Monk: [C: 032] "This commit is fine anyway, but why does the interwiki cache not set it?" [core] - 10https://gerrit.wikimedia.org/r/160382 (owner: 10Hoo man) [03:13:41] (03Merged) 10jenkins-bot: Prevent "Notice: Undefined index" in ApiQuerySiteinfo [core] - 10https://gerrit.wikimedia.org/r/160382 (owner: 10Hoo man) [03:40:40] (03PS1) 10Gnosygnu: v1.9.3.1 [xowa] - 10https://gerrit.wikimedia.org/r/160385 [03:42:01] 3MediaWiki / 3General/Unknown: Category pages should expose the timestamp sort option - 10https://bugzilla.wikimedia.org/70819#c4 (10Gryllida) Nemo said > Sounds like a WONTFIX, this is what CategoryTree or This does not appear to be able to sort by time. Nemo said > DynamicPageList are for. DPL does not s... [03:51:00] 3MediaWiki extensions / 3Gadgets: Implement Gadgets 2.0 (tracking) - 10https://bugzilla.wikimedia.org/29272 (10Kunal Mehta (Legoktm)) [03:51:02] 3MediaWiki / 3General/Unknown: Remove assumption from MediaWiki core that JS/CSS are only in MediaWiki namespace or User subpages - 10https://bugzilla.wikimedia.org/70835 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None There are a few places in MediaWiki that assume that JS/CSS are only st... [03:51:44] 3MediaWiki / 3General/Unknown: Remove assumption from MediaWiki core that JS/CSS are only in MediaWiki namespace or User subpages - 10https://bugzilla.wikimedia.org/70835#c1 (10Kunal Mehta (Legoktm)) An example of such an assumption is I64e86c74173b1c88cac71483327cacdd8b9967b9. [03:52:17] 3MediaWiki / 3General/Unknown: Category pages should expose the timestamp sort option - 10https://bugzilla.wikimedia.org/70819#c5 (10Bawolff (Brian Wolff)) > > Bawolff said > > ... would make sense if we already have an interface for multiple collations > Sorry, I'm not sure what a "collation" *is*. I hav... [03:59:43] (03PS1) 10Legoktm: [WIP] Break up MovePage::moveToInternal() into smaller functions [core] - 10https://gerrit.wikimedia.org/r/160387 [04:13:46] (03PS1) 10Florianschmidtwelzow: Handle return value NULL of GeoCrumbs::getParserCache [extensions/GeoCrumbs] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160388 (https://bugzilla.wikimedia.org/70827) [04:14:28] (03CR) 10KartikMistry: [C: 032] "LGTM && tested." [services/cxserver] - 10https://gerrit.wikimedia.org/r/159336 (owner: 10Jsahleen) [04:15:02] (03Merged) 10jenkins-bot: Adding additional logging to ContentTranslationsService.js [services/cxserver] - 10https://gerrit.wikimedia.org/r/159336 (owner: 10Jsahleen) [04:15:43] (03PS4) 10KartikMistry: Logging: Add logging to JsonDict.js [services/cxserver] - 10https://gerrit.wikimedia.org/r/159362 (owner: 10Jsahleen) [04:16:18] (03PS5) 10KartikMistry: Logging: Add logging to JsonDict.js [services/cxserver] - 10https://gerrit.wikimedia.org/r/159362 (owner: 10Jsahleen) [04:22:38] (03CR) 10KartikMistry: [C: 032] Logging: Add logging to JsonDict.js [services/cxserver] - 10https://gerrit.wikimedia.org/r/159362 (owner: 10Jsahleen) [04:23:09] (03Merged) 10jenkins-bot: Logging: Add logging to JsonDict.js [services/cxserver] - 10https://gerrit.wikimedia.org/r/159362 (owner: 10Jsahleen) [04:23:57] (03PS3) 10KartikMistry: Logging: Updating logging on DictClient.js and Dict.js [services/cxserver] - 10https://gerrit.wikimedia.org/r/159450 (owner: 10Jsahleen) [04:26:02] (03CR) 10Alex Monk: "Shouldn't this also be done in wmf21?" [extensions/GeoCrumbs] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160388 (https://bugzilla.wikimedia.org/70827) (owner: 10Florianschmidtwelzow) [04:28:05] (03CR) 10Florianschmidtwelzow: "Argh... I wanted wmf21... Thx Alex, it's Morning here :P" [extensions/GeoCrumbs] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160388 (https://bugzilla.wikimedia.org/70827) (owner: 10Florianschmidtwelzow) [04:28:30] (03PS1) 10Florianschmidtwelzow: Handle return value NULL of GeoCrumbs::getParserCache [extensions/GeoCrumbs] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160389 (https://bugzilla.wikimedia.org/70827) [04:34:14] (03PS1) 10Legoktm: Fix some i18n/GENDER issues spotted by Protnet [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/160390 [04:37:17] (03PS2) 10Legoktm: Fix some i18n/GENDER issues spotted by Protnet [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/160390 [04:40:16] 3MediaWiki extensions / 3UserMerge: GENDER support needed for usermerge-userdeleted-log and usermerge-move-log - 10https://bugzilla.wikimedia.org/70836 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3T. Gries https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Usermerge-userdeleted-lo... [04:50:39] (03PS1) 10Legoktm: Fix incorrect casing of "ContentHandler" class name [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/160391 [04:53:59] 3MediaWiki / 3General/Unknown: Remove assumption from MediaWiki core that JS/CSS are only in MediaWiki namespace or User subpages - 10https://bugzilla.wikimedia.org/70835#c2 (10Kunal Mehta (Legoktm)) (In reply to Kunal Mehta (Legoktm) from comment #0) > basically anything that > calls Title::isCssOrJsPage()... [05:03:29] (03PS1) 10Legoktm: ResourceLoaderWikiModule: Only check content format instead of namespace [core] - 10https://gerrit.wikimedia.org/r/160392 (https://bugzilla.wikimedia.org/70835) [05:07:14] 3MediaWiki extensions / 3UserMerge: GENDER support needed for usermerge-userdeleted-log and usermerge-move-log - 10https://bugzilla.wikimedia.org/70836 (10T. Gries) p:5Unprio>3Low [05:29:25] (03CR) 10Yurik: [C: 032 V: 032] Patched security issue per csteipp [extensions/Graph] - 10https://gerrit.wikimedia.org/r/160369 (owner: 10Yurik) [05:33:59] 3MediaWiki / 3User login and signup: Private and foreign keys for password verification - 10https://bugzilla.wikimedia.org/12126 (10Kunal Mehta (Legoktm)) [05:39:17] (03PS1) 10Yurik: Proper casing for namespace, unit test stub [extensions/Graph] - 10https://gerrit.wikimedia.org/r/160395 [05:41:30] (03CR) 10Tim Starling: [C: 04-1] "If you immediately reuse a luasandbox_timer after it is freed, doesn't that risk having a timeout event delivered to the wrong LuaSandbox " (031 comment) [php/luasandbox] - 10https://gerrit.wikimedia.org/r/159822 (owner: 10Anomie) [05:42:59] (03CR) 10Tim Starling: "It seems like you are just creating a hassle for responders to shell request bugs. If the checkbox is a bad idea, can we just remove it?" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/160367 (owner: 10Jackmcbarn) [05:50:31] (03CR) 10Tim Starling: "I'm a bit wary of maintenance script bloat. It seems to me that bug 46869 can easily be done with the existing importDump.php and importIm" [core] - 10https://gerrit.wikimedia.org/r/154704 (owner: 10Yurik) [05:52:28] TimStarling, this is exactly why initially i placed that script into vagrant - when one builds a vagrant machine, it is very convinient to have the initial state of the pages as a whole bunch of files in a local dir, and running "vagrant add-pages" or something like that initializes VM to the needed state [05:52:51] but several people said that this really belongs to the maint dir [05:53:38] mantaining importDump + images xml is by far more complicated than simply having a dir of files [05:54:02] thus, the script is simple, yet the convinience is huge [05:55:40] why do you think it really belongs in maintenance/? [05:56:00] if you're planning to add a subcommand to vagrant, you'll need to add some ruby code anyway [05:56:59] ori_, this is what i did initially, but i was told to move it to core. see https://gerrit.wikimedia.org/r/#/c/153819/ [05:57:03] (03PS1) 10Legoktm: Require GadgetJs or GadgetCss pages to end in either .js or .css [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160398 [05:57:09] well, I think it is bloat [05:57:11] (03CR) 10jenkins-bot: [V: 04-1] Require GadgetJs or GadgetCss pages to end in either .js or .css [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160398 (owner: 10Legoktm) [05:57:50] TimStarling, that script has a very specific goal - simplicity for VM development. It might or might not be ok for other uses, but that's not my goal [05:58:04] if common code between edit.php, importDump.php, importImages.php etc. was nicely factored out, it would not be bloat [05:58:17] well, it would be a bit bloaty, but not so bad [05:58:47] all bloat comes from servicing specific goals without any regard for the needs of other users [05:58:56] (03PS1) 10Legoktm: Require GadgetJs or GadgetCss pages to end in either .js or .css [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/160399 [05:58:58] (03CR) 10jenkins-bot: [V: 04-1] Require GadgetJs or GadgetCss pages to end in either .js or .css [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/160399 (owner: 10Legoktm) [05:59:07] (03PS2) 10Legoktm: Require GadgetJs or GadgetCss pages to end in either .js or .css [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160398 [05:59:13] (03Abandoned) 10Legoktm: Require GadgetJs or GadgetCss pages to end in either .js or .css [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/160399 (owner: 10Legoktm) [05:59:19] I don't think that is a defence of bloat, just a definition [05:59:39] true, so if we are to somehow refactor various import methods into an "import engine"... [06:00:06] with various sources, e.g. images/xml/files... [06:00:35] we would have to ask ourselves... is it really worth spending a lot of time on maint scripts ... :) [06:00:58] the beauty of maint scripts, esp those not in core, is that we can easily delete them [06:01:57] yes, I think maintenance scripts are becoming increasingly useful, as non-SSH shared hosting becomes less popular and more people are installing MW by automated means such as vagrant [06:02:24] we could have an import.php which can import various things in various formats [06:02:40] like it could have a sharepoint mode ;) [06:03:09] it would have to be an inout.php - as we should keep the export in sync [06:03:09] well, maybe that would not be implemented in the first iteration... [06:03:31] I don't really see how that would work [06:03:51] i won't touch it unless we implement splitting/merging exports into 1.44MB chunks [06:04:47] what I'd really like is a central entry point for maintenance scripts which would be installed in /usr/bin for packaged MW [06:05:17] /w/maintain.php ? [06:05:19] then instead of "php importDump.php ..." you would have "mediawiki importDump ..." [06:05:38] /w/admin.php is better [06:05:51] i.e. each existing maintenance script would become a subcommand of the central CLI entry point [06:06:33] (03PS1) 10Legoktm: Add tests for GadgetDefinitionContentHandler [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160401 [06:06:35] yeah. And we could expose all of the api via that same interface too, since it is already command oriented :) [06:07:30] anyway, I think each additional maintenance script should bring some value to the product as a whole [06:07:45] if it doesn't, you can just maintain it separately in vagrant [06:09:23] Tim, i do see your point, and i might try to address if i have some spare cycles. At this point what we have is an "lib" model - lots of scripts reusing common CLI parsing code. What you propose is to switch to a centralized model, where CLI is processed by common manager that will launch individual processing engine [06:09:46] s [06:12:05] the benefit of the switch is a standard interface to the cli processing engines, thus making it possible to launch them some other way without cli (e.g. one engine calling another as a whole, vagrant running them via its own startup code, etc) [06:15:04] TimStarling, ^ [06:16:58] (03CR) 10Tim Starling: "I suggest abandoning this and restoring it when WMF is running PHP 5.4 or later. While we are running PHP 5.3, it just seems like clutter " [core] - 10https://gerrit.wikimedia.org/r/158895 (owner: 10Withoutaname) [06:20:05] if you like, but I think the code would be pretty much the same [06:20:30] it's already possible to share code between maintenance scripts [06:24:50] (03CR) 10Tim Starling: "If it used a separate DB connection, like SqlBagOStuff, then presumably there would not be any transaction issues." [core] - 10https://gerrit.wikimedia.org/r/153944 (owner: 10Aaron Schulz) [06:26:04] (03PS14) 10Florianschmidtwelzow: Show Captcha after click on edit over buttons on EditPage [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/136323 (https://bugzilla.wikimedia.org/19648) [06:27:53] (03CR) 10Yurik: [C: 032 V: 032] Proper casing for namespace, unit test stub [extensions/Graph] - 10https://gerrit.wikimedia.org/r/160395 (owner: 10Yurik) [06:32:11] (03PS4) 10Tim Starling: Explicitly declaring stylize.php as open source [tools/code-utils] - 10https://gerrit.wikimedia.org/r/155772 (owner: 10Rillke) [06:32:18] (03CR) 10Tim Starling: [C: 032] Explicitly declaring stylize.php as open source [tools/code-utils] - 10https://gerrit.wikimedia.org/r/155772 (owner: 10Rillke) [06:32:20] (03Merged) 10jenkins-bot: Explicitly declaring stylize.php as open source [tools/code-utils] - 10https://gerrit.wikimedia.org/r/155772 (owner: 10Rillke) [06:59:55] (03Restored) 10Nikerabbit: Prepare for composer [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/105514 (https://bugzilla.wikimedia.org/49131) (owner: 10Nemo bis) [07:01:23] (03CR) 10Tim Starling: "The script was introduced by me in June 2007, presumably because I needed to undelete something. I don't recall exactly what, but generall" [core] - 10https://gerrit.wikimedia.org/r/131431 (https://bugzilla.wikimedia.org/52887) (owner: 10Withoutaname) [07:05:16] 3MediaWiki extensions / 3SemanticForms: Autocompletion fails for a category with lowercase first letter ($wgCapitalLinks=false) - 10https://bugzilla.wikimedia.org/70837 (10planetenxin) 3NEW p:3Unprio s:3normal a:3Yaron Koren Semantic Forms parameter 'values from category' does not return autocomplete... [07:21:55] (03PS4) 10Nikerabbit: Prepare for composer [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/105514 (https://bugzilla.wikimedia.org/49131) (owner: 10Nemo bis) [07:21:57] (03PS1) 10Nikerabbit: Fix incorrect dates introduced in 3af03c04 [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/160403 [07:23:38] (03CR) 10Nikerabbit: "Dropped the "configuration" part to get the basic stuff through. Please review." [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/105514 (https://bugzilla.wikimedia.org/49131) (owner: 10Nemo bis) [07:25:05] (03CR) 10Nemo bis: [C: 031] "But the dependency is probably unintentional." [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/160403 (owner: 10Nikerabbit) [07:26:48] (03PS2) 10Nikerabbit: Fix incorrect dates introduced in 3af03c04 [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/160403 [07:27:04] (03PS1) 10Yurik: Merged common traits of Css/Json/Js contentHandlers [core] - 10https://gerrit.wikimedia.org/r/160404 [07:29:33] (03PS2) 10Yurik: Merged common traits of Css/Json/Js contentHandlers [core] - 10https://gerrit.wikimedia.org/r/160404 [07:33:23] (03CR) 10KartikMistry: [C: 032] Fix incorrect dates introduced in 3af03c04 [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/160403 (owner: 10Nikerabbit) [07:33:28] (03Merged) 10jenkins-bot: Fix incorrect dates introduced in 3af03c04 [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/160403 (owner: 10Nikerabbit) [07:41:48] (03CR) 10Legoktm: [C: 04-1] "Concept looks fine, but keep it as one class per file please." [core] - 10https://gerrit.wikimedia.org/r/160404 (owner: 10Yurik) [07:42:35] legoktm, but they are tiny, i feel its a waste, and more importantly, it IMHO overcrowds things [07:42:43] waste of what? [07:42:57] waste of time needed to navigate a huge file list [07:43:07] otoh, I feel multiple classes in one file is overcrowding :P [07:43:42] legoktm, if we start doing 2 lines of useful code per line (java style), we will have a huge number of files/directories [07:43:49] *per file [07:44:03] there are like 10 files in the directory it's not that much. [07:44:38] legoktm, fine. Will restore them. Btw, will rename JSON to Json [07:44:44] inconsistent [07:47:37] sure, just needs a temporary back/compat class JSON extends Json {} until extensions are updated. [07:54:08] legoktm, classes are case-insensitive in php :) [07:54:19] oh, right, stupid >.< [07:54:22] (in theory)... [07:54:23] :) [07:54:29] 3MediaWiki / 3JavaScript: [jquery.textSelection] Select sample text when splitlines is true - 10https://bugzilla.wikimedia.org/70764#c2 (10Michael M.) Hm. Blame tells me that I reported the bug for which this was changed: Bug 29105. Of course, when the sample text can't be selected (because it is splitted in... [07:59:27] https://bugzilla.wikimedia.org/show_bug.cgi?id=35534#c19 [07:59:27] 3Wikimedia / 3Git/Gerrit: Free-form tagging in gerrit - 10https://bugzilla.wikimedia.org/35534#c19 (10Nemo) !!! https://code.google.com/p/gerrit/issues/detail?id=287 is marked fixed !!! Upgrade upgrade upgrade upgrade upgrade upgrade upgrade [07:59:43] (03PS3) 10Yurik: Css/Json/Js contentHandler refactoring [core] - 10https://gerrit.wikimedia.org/r/160404 [08:01:48] legoktm, ^ [08:02:39] * legoktm looks [08:02:49] Nemo_bis: #upgrade #upgrade #upgrade #upgrade #upgrade #upgrade [08:03:32] 3MediaWiki extensions / 3WikidataRepo: The message wikibase-propertyedittool-counter-entrieslabel needs to include the number itself - 10https://bugzilla.wikimedia.org/70838 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3Wikidata bugs The current value of the wikibase-propertyedittool-counter-entrie... [08:04:11] (03PS1) 10Yurik: Updated JSONContent->JsonContent to match 1.24 core [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/160405 [08:05:29] 3Wikimedia / 3Git/Gerrit: Free-form tagging in gerrit - 10https://bugzilla.wikimedia.org/35534#c20 (10Nemo) (Or maybe it's a misunderstanding?) [08:05:46] yurikR: should we make getContentClass() abstract for CodeContentHandler so subclasses actually have something to implement? [08:06:25] legoktm, what's the point? [08:07:01] i am not too happy with the current system of contentHandlers + content objcets - too verbose [08:07:25] you should talk to DanielK about it then :P [08:07:31] yeah, i know [08:07:42] but lets fight the battles that are worth fighting [08:08:57] I think it should be abstract since it's something that subclasses have to override, "TextContent" will always be wrong [08:09:21] leaving, say, a comment on [[mw:Talk:ContentHandler]] for the archives' sake is certainly not picking a battle [08:09:51] legoktm, oki [08:10:13] posting some more comments, give me a minute [08:11:35] (03CR) 10Gilles: [C: 032] Code quality: Remove jscs "disallowDanglingUnderscores" over-ride and make pass [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/159955 (owner: 10Jforrester) [08:12:05] (03Merged) 10jenkins-bot: Code quality: Remove jscs "disallowDanglingUnderscores" over-ride and make pass [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/159955 (owner: 10Jforrester) [08:12:40] (03CR) 10Legoktm: [C: 04-1] Css/Json/Js contentHandler refactoring (034 comments) [core] - 10https://gerrit.wikimedia.org/r/160404 (owner: 10Yurik) [08:12:41] legoktm, actually no, can't do that [08:12:52] oh, PHP won't let you? [08:12:52] method cannot be made abstract in a subclass [08:12:55] bah [08:12:56] nope [08:13:06] and i don't think any other lang would either [08:13:19] throw new MWException('Subclass must override'); feels dirty. [08:13:42] in c# you can, but it would be a new method override chain [08:16:04] ok, maybe just a comment somewhere? [08:16:19] "subclasses should remember to override getContentClass()" [08:17:58] (03PS4) 10Yurik: Css/Json/Js contentHandler refactoring [core] - 10https://gerrit.wikimedia.org/r/160404 [08:18:13] legoktm, ^ [08:20:03] (03CR) 10Gilles: [C: 032] Read description from metadata and suggest it [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152177 (owner: 10Rillke) [08:20:31] (03Merged) 10jenkins-bot: Read description from metadata and suggest it [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152177 (owner: 10Rillke) [08:21:04] (03CR) 10Yurik: Css/Json/Js contentHandler refactoring (034 comments) [core] - 10https://gerrit.wikimedia.org/r/160404 (owner: 10Yurik) [08:23:16] (03CR) 10Gilles: [C: 031] Create title in file NS and validate as such [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) (owner: 10Rillke) [08:23:49] (03PS1) 10Adrian Lang: Cleaner PHPUnit requiring in bootstrap code [core] - 10https://gerrit.wikimedia.org/r/160406 [08:24:16] (03PS5) 10Legoktm: CSS/JSON/JavaScript ContentHandler refactoring [core] - 10https://gerrit.wikimedia.org/r/160404 (owner: 10Yurik) [08:24:37] (03CR) 10Legoktm: [C: 032] CSS/JSON/JavaScript ContentHandler refactoring [core] - 10https://gerrit.wikimedia.org/r/160404 (owner: 10Yurik) [08:24:46] 3MediaWiki extensions / 3UserMerge: Add convenience links for accessing the extension - 10https://bugzilla.wikimedia.org/70839 (10Dévai Tamás) 3UNCO p:3Unprio s:3normal a:3T. Gries Created attachment 16466 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16466&action=edit Patch to add 'merge' a... [08:24:59] yurikR: edited the commit message a bit ^ [08:26:29] 3MediaWiki extensions / 3UserMerge: Add convenience links for accessing the extension - 10https://bugzilla.wikimedia.org/70839 (10Kunal Mehta (Legoktm)) [08:31:29] (03Merged) 10jenkins-bot: CSS/JSON/JavaScript ContentHandler refactoring [core] - 10https://gerrit.wikimedia.org/r/160404 (owner: 10Yurik) [08:33:02] (03CR) 10Legoktm: [C: 032] Updated JSONContent->JsonContent to match 1.24 core [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/160405 (owner: 10Yurik) [08:33:33] legoktm, i can't for some reason update ext UploadWizard & MassMessage [08:33:44] getting git_review.cmd.CannotInstallHook: Problems encountered installing commit-msg hook [08:33:48] :o [08:33:57] I'll submit patches and you +2 then? :D [08:34:05] ok, txh [08:34:23] (03Merged) 10jenkins-bot: Updated JSONContent->JsonContent to match 1.24 core [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/160405 (owner: 10Yurik) [08:35:15] (03PS1) 10Legoktm: JSONContent --> JsonContent per rename in core [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/160407 [08:37:42] (03PS1) 10Legoktm: JSONContent --> JsonContent per rename in core [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160409 [08:37:44] yurikR1: ^ [08:38:39] (03CR) 10Gilles: [C: 032] Code quality: Remove jscs "requireCamelCaseOrUpperCaseIdentifiers" over-ride and make pass [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/159956 (owner: 10Jforrester) [08:39:05] (03Merged) 10jenkins-bot: Code quality: Remove jscs "requireCamelCaseOrUpperCaseIdentifiers" over-ride and make pass [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/159956 (owner: 10Jforrester) [08:39:50] (03CR) 10Gilles: [C: 032] JSONContent --> JsonContent per rename in core [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/160407 (owner: 10Legoktm) [08:39:56] (03CR) 10Yurik: [C: 032] JSONContent --> JsonContent per rename in core [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/160407 (owner: 10Legoktm) [08:40:15] (03Merged) 10jenkins-bot: JSONContent --> JsonContent per rename in core [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/160407 (owner: 10Legoktm) [08:40:29] (03CR) 10Yurik: [C: 032] JSONContent --> JsonContent per rename in core [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/160408 (owner: 10Legoktm) [08:40:57] (03Merged) 10jenkins-bot: JSONContent --> JsonContent per rename in core [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/160408 (owner: 10Legoktm) [08:41:02] (03CR) 10Yurik: [C: 032] JSONContent --> JsonContent per rename in core [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160409 (owner: 10Legoktm) [08:41:31] (03CR) 10Gilles: [C: 032] Let TMH detect webm files using opus and VP9 codecs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108482 (https://bugzilla.wikimedia.org/60245) (owner: 10Brian Wolff) [08:41:45] (03Merged) 10jenkins-bot: Let TMH detect webm files using opus and VP9 codecs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108482 (https://bugzilla.wikimedia.org/60245) (owner: 10Brian Wolff) [08:43:17] (03PS1) 10Lokal Profil: Improve message bs-rssfeeder-desc [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/160410 [08:43:44] (03PS1) 10Legoktm: Have ScribuntoContentHandler extend CodeContentHandler [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/160411 [08:44:17] yurikR1: ^ that too :D [08:45:37] legoktm, what about downstream users - could they be using scribuntu on the older vers? [08:45:57] making this change will force latest core, which most of them don't have yet [08:46:14] I'm not sure what the compatibility requirements for Scribunto are [08:46:16] * legoktm checks [08:46:44] 3Wikimedia / 3General/Unknown: Install Q&A system at ask.wikimedia.org - 10https://bugzilla.wikimedia.org/29923#c18 (10Quim Gil) For what is worth, Phabricator has an application called Ponder that pretty much covers what is requested here: posting questions in relation to projects (topics) and allow people... [08:47:06] https://www.mediawiki.org/wiki/Extension:Scribunto says 1.20 and up...I'm not sure whether that means use the REL_* branches or master intends to support that...(it certainly can't because of CH) [08:48:29] 3MediaWiki extensions / 3Gadgets: Provide standard way to create/run QUnit tests for Gadgets and user scripts - 10https://bugzilla.wikimedia.org/37230#c2 (10Kunal Mehta (Legoktm)) We can probably do this once the Gadgets 2.0 infrastructure is in place...making this depend upon that. [08:48:44] 3MediaWiki extensions / 3Gadgets: Implement Gadgets 2.0 (tracking) - 10https://bugzilla.wikimedia.org/29272 (10Kunal Mehta (Legoktm)) [08:58:30] legoktm, lets ask anomie tomorrow. I'm off to bed [08:58:34] its 5am ) [08:58:38] gnite :) [08:59:41] legoktm, tmrw will try to address the rest of the issues i listed, moved the html table rendering back to ext for now (until we have a nice rendering or something else), and implement CsvContent :) [09:20:44] 3MediaWiki extensions / 3WikidataRepo: GeoCoordinateFormatter interprets precision as number of decimal places - 10https://bugzilla.wikimedia.org/66653#c1 (10tobias.gritschacher) potentially duplicate of https://bugzilla.wikimedia.org/show_bug.cgi?id=64820 [09:21:00] 3MediaWiki extensions / 3WikidataRepo: coordinate precision issue - 10https://bugzilla.wikimedia.org/64820 (10tobias.gritschacher) [09:21:15] 3Wikimedia / 3Site requests: Please add the domain *.scienceimage.csiro.au to the wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/70771#c3 (10Antoine "hashar" Musso) 5PATC>3RESO/FIX a:3dan Thanks for the patch. I have deployed the configuration change: hashar@tin:/srv/mediawiki-stagi... [09:23:00] 3MediaWiki extensions / 3WikidataRepo: Displaying (and editing) the calendar model of time values is confusing - 10https://bugzilla.wikimedia.org/70395 (10tobias.gritschacher) s:5normal>3critic [09:24:07] (03CR) 10Addshore: [C: 031] "Looks good, not personally tested yet!" [core] - 10https://gerrit.wikimedia.org/r/160406 (owner: 10Adrian Lang) [09:36:20] (03CR) 10Fomafix: [C: 04-1] mediawiki.api.options: New module for user preferences API (action=options) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/160308 (owner: 10Bartosz Dziewoński) [09:45:18] (03CR) 10Siebrand: [C: 032] Improve message bs-rssfeeder-desc [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/160410 (owner: 10Lokal Profil) [09:45:39] (03Merged) 10jenkins-bot: Improve message bs-rssfeeder-desc [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/160410 (owner: 10Lokal Profil) [09:46:15] (03CR) 10Siebrand: [C: 032] "i18n/L10n reviewed." [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/160390 (owner: 10Legoktm) [09:46:21] (03Merged) 10jenkins-bot: Fix some i18n/GENDER issues spotted by Protnet [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/160390 (owner: 10Legoktm) [09:48:45] (03CR) 10Florianschmidtwelzow: Unify sub-page logic in Title and MWNamespace (031 comment) [core] - 10https://gerrit.wikimedia.org/r/147229 (https://bugzilla.wikimedia.org/69622) (owner: 10Parent5446) [09:49:09] (03Abandoned) 10Florianschmidtwelzow: Add SpecialPage namespace to namespaces with support for subpages [core] - 10https://gerrit.wikimedia.org/r/154306 (https://bugzilla.wikimedia.org/69622) (owner: 10Florianschmidtwelzow) [09:50:44] 3MediaWiki extensions / 3SemanticForms: Dropdown Input type is not picking up all property values - 10https://bugzilla.wikimedia.org/70401 (10Neill Mitchell) s:5normal>3critic [09:51:44] 3MediaWiki extensions / 3SemanticForms: Dropdown Input type is not picking up all property values - 10https://bugzilla.wikimedia.org/70401#c1 (10Neill Mitchell) Seeing this a lot now with SMW 3.0 and SMW 1.9.2. Makes properties with defined values unusable. [09:54:09] (03CR) 10Florianschmidtwelzow: "Is there any progress? :)" [core] - 10https://gerrit.wikimedia.org/r/68936 (https://bugzilla.wikimedia.org/17212) (owner: 10Brian Wolff) [10:03:36] (03CR) 10Bartosz Dziewoński: [C: 032] Fix incorrect casing of "ContentHandler" class name [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/160391 (owner: 10Legoktm) [10:03:39] (03Merged) 10jenkins-bot: Fix incorrect casing of "ContentHandler" class name [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/160391 (owner: 10Legoktm) [10:04:58] 3MediaWiki extensions / 3SemanticForms: Dropdown Input type is not picking up all property values - 10https://bugzilla.wikimedia.org/70401#c2 (10Neill Mitchell) I've hardcoded values= for now and will probably downgrade to 1.8.0.5. Going to wait until final version of SMW 2.0 (not 3.0 as stated above!) and... [10:16:28] (03CR) 10Aude: Cleaner PHPUnit requiring in bootstrap code (031 comment) [core] - 10https://gerrit.wikimedia.org/r/160406 (owner: 10Adrian Lang) [10:18:15] 3MediaWiki / 3Categories: Categories don't react well to their members moving between special-cased namespaces (Category ↔ File ↔ (other)) - 10https://bugzilla.wikimedia.org/69740 (10Bartosz Dziewoński) 5PATC>3RESO/FIX a:3Bartosz Dziewoński [10:22:27] (03PS34) 10Paladox: WikiEditor: Fix issue with SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) [10:28:41] (03CR) 10Hoo man: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/157011 (owner: 10Legoktm) [10:30:02] (03PS1) 10Gergő Tisza: Update MultimediaViewer submodule [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160418 [10:32:46] 3Wikimedia / 3Site requests: please add *.beeldbank.cultureelerfgoed.nl to the wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/70840 (10johanmmuller) 3UNCO p:3Unprio s:3normal a:3None Please add the following domain to the wgCopyUploadsDomains whitelist: *.beeldbank.cultureelerfgoe... [10:49:41] (03PS1) 10Paladox: WikiEditor: Convert .css to .less and also fixes svg issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/160421 (https://bugzilla.wikimedia.org/35342) [10:49:43] (03CR) 10jenkins-bot: [V: 04-1] WikiEditor: Convert .css to .less and also fixes svg issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/160421 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [10:50:24] (03Abandoned) 10Paladox: WikiEditor: Convert .css to .less and also fixes svg issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/160421 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [10:55:26] (03PS20) 10Paladox: WikiEditor: Convert .css to .less and also fixes svg issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [10:55:28] (03CR) 10jenkins-bot: [V: 04-1] WikiEditor: Convert .css to .less and also fixes svg issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [10:56:19] (03PS21) 10Paladox: WikiEditor: Convert .css to .less and also fixes svg issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 [10:56:21] (03CR) 10jenkins-bot: [V: 04-1] WikiEditor: Convert .css to .less and also fixes svg issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (owner: 10Paladox) [10:56:28] (03PS22) 10Paladox: WikiEditor: Convert .css to .less and also fixes svg issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [10:56:30] (03CR) 10jenkins-bot: [V: 04-1] WikiEditor: Convert .css to .less and also fixes svg issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [10:57:56] (03Abandoned) 10Hoo man: Import the populateSitesTable script from Wikibase [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/145764 (https://bugzilla.wikimedia.org/42207) (owner: 10Hoo man) [11:01:02] (03CR) 10Legoktm: "Related: bug 70468." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/158578 (https://bugzilla.wikimedia.org/70392) (owner: 10Legoktm) [11:01:59] 3MediaWiki extensions / 3WikidataRepo: Move populateSitesTable.php script to MediaWiki - 10https://bugzilla.wikimedia.org/42207#c6 (10Marius Hoch) We decided it would be best to have this in a component that people installing Wikibase have around anyway, because of that and due to the fact that the rest of t... [11:02:14] 3MediaWiki extensions / 3WikidataRepo: Move populateSitesTable.php script to MediaWiki - 10https://bugzilla.wikimedia.org/42207 (10Marius Hoch) 5PATC>3NEW [11:04:17] 3MediaWiki extensions / 3Gadgets: Document best practices for creating local overrides of global gadgets - 10https://bugzilla.wikimedia.org/70841 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None We don't want people copying entire gadgets just to change one variable or something. Instead t... [11:04:29] 3MediaWiki extensions / 3Gadgets: 2.0: Document best practices for creating local overrides of global gadgets - 10https://bugzilla.wikimedia.org/70841 (10Kunal Mehta (Legoktm)) [11:04:44] 3MediaWiki extensions / 3Gadgets: Implement Gadgets 2.0 (tracking) - 10https://bugzilla.wikimedia.org/29272 (10Kunal Mehta (Legoktm)) [11:22:14] 3MediaWiki / 3Export/Import: Import failed: Expected tag, got - 10https://bugzilla.wikimedia.org/70781#c1 (10Andre Klapper) p:5Unprio>3Low I assume that page is https://en.wikipedia.org/wiki/Talk:The_Girl_with_the_Dragon_Tattoo As you wrote "pages" (plural), does that imply this a general pr... [11:23:14] 3MediaWiki / 3Special pages: Show warning when user name is not existing or invalid on Special:ListFiles (like already on Special:Contributions) - 10https://bugzilla.wikimedia.org/70784 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc [11:34:16] 3MediaWiki skins / 3Other: PHP Fatal error: Class 'BsConfig' not found in skins/BlueSpiceSkin/includes/BlueSpiceSkinHooks.php on line 9 - 10https://bugzilla.wikimedia.org/70793#c3 (10Andre Klapper) Tried to find its bugtracker or exact maintainers. Some files say "@author Radovan Kubani, Robert Vogel, Patri... [11:34:59] 3MediaWiki / 3Installer: Command-line installer (maintenance/install.php) doesn't discover skins and add them to LocalSettings? - 10https://bugzilla.wikimedia.org/70815 (10Andre Klapper) p:5Unprio>3Normal [11:35:59] 3MediaWiki-Vagrant: 403 Forbidden when uploading file via AJAX and using hhvm role - 10https://bugzilla.wikimedia.org/65195#c3 (10Andre Klapper) p:5Unprio>3Lowest Reporter left; proposing closing as WORKSFORME if nobody can reproduce. [11:37:44] 3Wikimedia / 3Site requests: please add *.beeldbank.cultureelerfgoed.nl to the wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/70840 (10Andre Klapper) p:5Unprio>3Normal s:5normal>3enhanc [11:43:41] (03PS23) 10Paladox: WikiEditor: Convert .css to .less and also fixes svg issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [11:44:05] (03PS24) 10Paladox: WikiEditor: Convert .css to .less and also fixes svg issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [11:48:05] (03CR) 10Jackmcbarn: "I'd be okay with removing it, but I thought there was one wiki that asked you for it specifically." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/160367 (owner: 10Jackmcbarn) [11:52:35] (03PS2) 10Jackmcbarn: Remove "Allow saving code with errors" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/160367 [12:03:45] 3MediaWiki extensions / 3WikidataRepo: Move JS WikibaseAPI code into its own component - 10https://bugzilla.wikimedia.org/66419 (10tobias.gritschacher) [12:05:30] (03PS1) 10Legoktm: CachedGadgetRepo: Store Content objects internally instead of JSON blobs [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160431 [12:05:32] (03PS1) 10Legoktm: Add some basic tests for LocalGadgetRepo [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160432 [12:05:43] (03CR) 10jenkins-bot: [V: 04-1] Add some basic tests for LocalGadgetRepo [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160432 (owner: 10Legoktm) [12:07:58] (03PS2) 10Legoktm: Add some basic tests for LocalGadgetRepo [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160432 [12:08:56] (03PS2) 10Bartosz Dziewoński: Support for enabling skins in the command-line installer [core] - 10https://gerrit.wikimedia.org/r/160224 (https://bugzilla.wikimedia.org/70815) [12:09:46] (03PS2) 10Legoktm: JSONContent --> JsonContent per rename in core [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160409 [12:10:09] (03CR) 10Bartosz Dziewoński: [C: 032] JSONContent --> JsonContent per rename in core [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160409 (owner: 10Legoktm) [12:10:15] (03Merged) 10jenkins-bot: JSONContent --> JsonContent per rename in core [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160409 (owner: 10Legoktm) [12:10:28] ...I was about to +2 it! [12:10:39] ha-ha! [12:10:48] MatmaRex the stat stealer [12:10:59] 3Wikimedia / 3Site requests: Change $wgAbuseFilterAnonBlockDuration to 3 months on mediawikiwiki - 10https://bugzilla.wikimedia.org/70828 (10Andre Klapper) p:5Unprio>3Normal s:5normal>3enhanc [12:11:53] YuviPanda: well, legoktm is currently pwning everyone when it comes to merge count, gotta change that [12:11:56] MatmaRex: https://gerrit.wikimedia.org/r/#/c/160392/ is a fun RL one if you're interested, it's the only still needed to unbreak Gadgets 2.0 [12:11:59] heh [12:11:59] 3Wikimedia / 3General/Unknown: Commons icon on Special:UserLogout not transparent - 10https://bugzilla.wikimedia.org/70829 (10Andre Klapper) p:5Unprio>3Low s:5normal>3minor [12:12:14] 3MediaWiki / 3General/Unknown: Remove assumption from MediaWiki core that JS/CSS are only in MediaWiki namespace or User subpages - 10https://bugzilla.wikimedia.org/70835 (10Andre Klapper) p:5Unprio>3Normal [12:12:29] 3MediaWiki / 3ContentHandler: JSONContent should store non-pretty printed JSON, but still show pretty in the edit interface - 10https://bugzilla.wikimedia.org/70833 (10Andre Klapper) p:5Unprio>3Normal s:5normal>3enhanc [12:12:57] (03CR) 10Paladox: "Ok I have translated it for qqq file." [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/158884 (owner: 10Paladox) [12:13:40] (03CR) 10Legoktm: "This won't be necessary if Ieb9e5d045ed9b59cc83749234a9157689244c597 is merged." [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160253 (owner: 10Legoktm) [12:23:57] (03CR) 10Gergő Tisza: [C: 032] Create title in file NS and validate as such (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) (owner: 10Rillke) [12:24:27] (03Merged) 10jenkins-bot: Create title in file NS and validate as such [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) (owner: 10Rillke) [12:29:49] (03CR) 10Gergő Tisza: "The formatting test uses jscs which does not have any functionality to fix errors (nor is it intended, apparently: https://github.com/jscs" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) (owner: 10Rillke) [12:46:28] 3MediaWiki extensions / 3Gadgets: 2.0 Figure out how gadget naming collisions should work, and document it - 10https://bugzilla.wikimedia.org/70824#c1 (10Kunal Mehta (Legoktm)) Hmm, something else I thought of. Right now if a user enables a gadget "foo", and a repo higher up in the precedence chain creates... [12:56:42] (03CR) 10Bartosz Dziewoński: "I've been able to successfully set up a wiki using install.php, with the skins enabled, with this patch. I'd appreciate if someone could v" [core] - 10https://gerrit.wikimedia.org/r/160224 (https://bugzilla.wikimedia.org/70815) (owner: 10Bartosz Dziewoński) [12:57:53] > $this->findExtensions( 'skins' ); [12:58:05] legoktm: i didn't name that function. [12:58:27] I know :P [12:58:32] and renaming things is a pita and generally not worth it :P [12:59:03] (03PS2) 10Bartosz Dziewoński: mediawiki.api.options: New module for user preferences API (action=options) [core] - 10https://gerrit.wikimedia.org/r/160308 [12:59:30] 3MediaWiki extensions / 3UserMerge: Add convenience links for accessing the extension - 10https://bugzilla.wikimedia.org/70839 (10Dévai Tamás) s:5normal>3enhanc [13:02:48] (03PS5) 10Bartosz Dziewoński: ApiQuerySiteinfo: Use proper localised skin display names if available [core] - 10https://gerrit.wikimedia.org/r/157275 (https://bugzilla.wikimedia.org/48953) [13:02:51] (03CR) 10Bartosz Dziewoński: ApiQuerySiteinfo: Use proper localised skin display names if available (031 comment) [core] - 10https://gerrit.wikimedia.org/r/157275 (https://bugzilla.wikimedia.org/48953) (owner: 10Bartosz Dziewoński) [13:03:02] (03PS6) 10Bartosz Dziewoński: ApiQuerySiteinfo: Use proper localised skin display names if available [core] - 10https://gerrit.wikimedia.org/r/157275 (https://bugzilla.wikimedia.org/48953) [13:09:01] (03CR) 10Bartosz Dziewoński: "Is anybody interested in pursuing this patch? I have other bikesheds that need arguing about and can't devote attention to this one." [core] - 10https://gerrit.wikimedia.org/r/110279 (https://bugzilla.wikimedia.org/47694) (owner: 10Bartosz Dziewoński) [13:11:44] (03CR) 10Bartosz Dziewoński: "LIMITED TIME OFFER: I'm offering a beverage of their choice to whoever merges this during the next 24 hours, redeemable next time we meet!" [core] - 10https://gerrit.wikimedia.org/r/155442 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [13:13:05] oh god [13:13:57] (03CR) 10Legoktm: "I strongly disagree that legos are never the solution." [core] - 10https://gerrit.wikimedia.org/r/110279 (https://bugzilla.wikimedia.org/47694) (owner: 10Bartosz Dziewoński) [13:22:06] (03CR) 10Swidmann: [C: 031 V: 031] Added Hooks to PermissionManager [extensions/BlueSpiceExtensions] (REL1_22) - 10https://gerrit.wikimedia.org/r/157142 (owner: 10Pwirth) [13:23:09] (03CR) 10Yuvipanda: "legos are, with minor exceptions (such as 'thing to step on when walking blind'), always the solution." [core] - 10https://gerrit.wikimedia.org/r/110279 (https://bugzilla.wikimedia.org/47694) (owner: 10Bartosz Dziewoński) [13:23:51] (03PS3) 10Bartosz Dziewoński: "Keep me logged in" on Special:UserLogin should sometimes state duration [core] - 10https://gerrit.wikimedia.org/r/110279 (https://bugzilla.wikimedia.org/47694) [13:24:01] (03CR) 10Bartosz Dziewoński: "(Rebased.)" [core] - 10https://gerrit.wikimedia.org/r/110279 (https://bugzilla.wikimedia.org/47694) (owner: 10Bartosz Dziewoński) [13:34:03] 3MediaWiki-Vagrant / 3labs-vagrant: Fatal error, timeout when running composer install - 10https://bugzilla.wikimedia.org/70843 (10Aude) 3NEW p:3Unprio s:3normal a:3None when running composer install to get fresh install of Wikibase, I get fatal error due to timeout. Fatal error: Maximum execution t... [13:52:16] 3MediaWiki extensions / 3[other]: CodeMirror does not pass jshint - 10https://bugzilla.wikimedia.org/69869 (10Antoine "hashar" Musso) 5PATC>3RESO/FIX [13:52:52] (03PS3) 10Legoktm: Add some basic tests for LocalGadgetRepo [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160432 [13:53:16] (03PS4) 10Legoktm: Add some basic tests for LocalGadgetRepo & ForeignDBGadgetRepo [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160432 [13:54:40] (03CR) 10KartikMistry: [C: 032] Logging: Updating logging on DictClient.js and Dict.js [services/cxserver] - 10https://gerrit.wikimedia.org/r/159450 (owner: 10Jsahleen) [13:55:18] (03Merged) 10jenkins-bot: Logging: Updating logging on DictClient.js and Dict.js [services/cxserver] - 10https://gerrit.wikimedia.org/r/159450 (owner: 10Jsahleen) [14:00:07] (03PS8) 10Umherirrender: Add better error message for files which exceeds $wgMaxImageArea [core] - 10https://gerrit.wikimedia.org/r/142046 [14:02:01] 3Wikimedia / 3SSL related: Allow option to uncheck "Always use a secure connection when logged in" at login.wikimedia.org/wiki/Special:Preferences - 10https://bugzilla.wikimedia.org/69319#c4 (10Cometstyles) And trying to remove the "forcedHTTPS" cookies kills all my logins and i can no longer log in and then... [14:03:16] (03CR) 10Aude: [C: 032] Revert Wikidata to mw1.24-wmf19 branch [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/159943 (owner: 10Aude) [14:03:18] 3MediaWiki / 3Documentation: Doxygen: Duplicate anchor LICENSE found - 10https://bugzilla.wikimedia.org/70328#c1 (10Antoine "hashar" Musso) Several files define: * @section LICENSE That causes dupes indeed. The @section should probably be removed entirely. Moving under MediaWiki product. [14:05:52] (03PS3) 10Jsahleen: Publishing: Get revision id from Parsoid content-revision-id header [services/cxserver] - 10https://gerrit.wikimedia.org/r/160059 (https://bugzilla.wikimedia.org/70755) [14:06:14] 3MediaWiki / 3Export/Import: Import failed: Expected tag, got - 10https://bugzilla.wikimedia.org/70781#c2 (10Jon) I haven't investigated too much but I've hit it on every page I've tried to import. Seems to be a general issue. [14:07:11] (03Merged) 10jenkins-bot: Revert Wikidata to mw1.24-wmf19 branch [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/159943 (owner: 10Aude) [14:21:00] (03CR) 10Manybubbles: [C: 032] "Looks good to me. Would you mind putting together the submodule update for core? It makes my life as a deployer simpler." [extensions/GeoCrumbs] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160389 (https://bugzilla.wikimedia.org/70827) (owner: 10Florianschmidtwelzow) [14:21:19] (03Merged) 10jenkins-bot: Handle return value NULL of GeoCrumbs::getParserCache [extensions/GeoCrumbs] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160389 (https://bugzilla.wikimedia.org/70827) (owner: 10Florianschmidtwelzow) [14:21:22] (03CR) 10Manybubbles: [C: 032] "Looks good to me. Would you mind putting together the submodule update for core? It makes my life as a deployer simpler." [extensions/GeoCrumbs] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160388 (https://bugzilla.wikimedia.org/70827) (owner: 10Florianschmidtwelzow) [14:21:29] (03Merged) 10jenkins-bot: Handle return value NULL of GeoCrumbs::getParserCache [extensions/GeoCrumbs] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160388 (https://bugzilla.wikimedia.org/70827) (owner: 10Florianschmidtwelzow) [14:25:46] 3Wikimedia / 3General/Unknown: LocalisationUpdate failed: mwversionsinuse returned empty list - 10https://bugzilla.wikimedia.org/70844 (10Raimond Spekking) 3NEW p:3Unprio s:3normal a:3None Per Server Admin Log this happens on 14th and 15th of September: LocalisationUpdate failed: mwversionsinuse ret... [14:32:21] (03PS1) 10Gergő Tisza: Update MultimediaViewer submodule [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160450 [14:34:16] 3Wikimedia / 3Bugzilla: analytics project needs a dashiki 'subproject' - 10https://bugzilla.wikimedia.org/70846 (10nuria) 3NEW p:3Unprio s:3normal a:3None Analytics project needs a dashiki 'subproject. Description of what dashiki is can be found here: http://www.mediawiki.org/wiki/Analytics/Dashiki... [14:37:29] (03CR) 10Manybubbles: "I'll build the submodule update." [extensions/GeoCrumbs] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160389 (https://bugzilla.wikimedia.org/70827) (owner: 10Florianschmidtwelzow) [14:45:42] (03PS1) 10Manybubbles: SWAT update for GeoCrumbs [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160452 [14:53:51] (03CR) 10Florianschmidtwelzow: "If you give me 20 minutes i will do it. I just hoped, that this gets merged earlier ( so i can update the submodule) or you aren't so fast" [extensions/GeoCrumbs] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160389 (https://bugzilla.wikimedia.org/70827) (owner: 10Florianschmidtwelzow) [14:54:17] (03CR) 10Anomie: "> If you immediately reuse a luasandbox_timer after it is freed, doesn't that risk having a timeout event delivered to the wrong LuaSandbo" (031 comment) [php/luasandbox] - 10https://gerrit.wikimedia.org/r/159822 (owner: 10Anomie) [15:00:43] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (073f37e258) [core] - 10https://gerrit.wikimedia.org/r/160460 [15:05:29] (03CR) 10Anomie: "1 nitpick" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/157586 (https://bugzilla.wikimedia.org/55941) (owner: 10Brian Wolff) [15:05:53] (03PS1) 10Manybubbles: SWAT update GeoCrumbs [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160462 [15:06:29] 3Wikimedia / 3SSL related: Allow option to uncheck "Always use a secure connection when logged in" at login.wikimedia.org/wiki/Special:Preferences - 10https://bugzilla.wikimedia.org/69319#c5 (10Andre Klapper) (In reply to Cometstyles from comment #0) > Https is slow It's been explained on IRC already that t... [15:10:30] 3MediaWiki extensions / 3GeoCrumbs: [1.24wmf20] Fatal error: Call to a member function getProperty() on a non-object, after completely history merging a page - 10https://bugzilla.wikimedia.org/70827#c8 (10Andre Klapper) 5PATC>3RESO/FIX Patches merged to 1.24wmf21, 1.24wmf20 and master. Thanks! Closing as... [15:10:59] 3Wikimedia / 3Deployment systems: LocalisationUpdate failed: mwversionsinuse returned empty list - 10https://bugzilla.wikimedia.org/70844 (10Andre Klapper) [15:11:20] (03CR) 10MarkTraceur: [C: 032] SWAT update for GeoCrumbs [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160452 (owner: 10Manybubbles) [15:11:25] (03CR) 10MarkTraceur: [C: 032] SWAT update GeoCrumbs [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160462 (owner: 10Manybubbles) [15:14:20] (03Merged) 10jenkins-bot: SWAT update for GeoCrumbs [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160452 (owner: 10Manybubbles) [15:14:29] 3MediaWiki / 3Export/Import: Import from en.wp failed: Expected tag, got - 10https://bugzilla.wikimedia.org/70781 (10Andre Klapper) p:5Low>3Normal [15:14:39] (03Merged) 10jenkins-bot: SWAT update GeoCrumbs [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160462 (owner: 10Manybubbles) [15:14:44] 3MediaWiki / 3General/Unknown: Commons beta cannot resolve redirect URLs - 10https://bugzilla.wikimedia.org/70124 (10Antoine "hashar" Musso) [15:17:54] (03CR) 10Anomie: [C: 032] API: Add timestamp of block to blockinfo [core] - 10https://gerrit.wikimedia.org/r/143787 (https://bugzilla.wikimedia.org/63326) (owner: 10Brian Wolff) [15:22:08] (03CR) 10MarkTraceur: [C: 032] Update MultimediaViewer submodule [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160450 (owner: 10Gergő Tisza) [15:22:13] (03CR) 10MarkTraceur: [C: 032] Update MultimediaViewer submodule [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160418 (owner: 10Gergő Tisza) [15:22:59] 3MediaWiki extensions / 3GeoCrumbs: [1.24wmf20] Fatal error: Call to a member function getProperty() on a non-object, after completely history merging a page - 10https://bugzilla.wikimedia.org/70827#c9 (10Florian) And deployed to wikivoyage :) [15:23:15] 3MediaWiki extensions / 3GeoCrumbs: [1.24wmf20] Fatal error: Call to a member function getProperty() on a non-object, after completely history merging a page - 10https://bugzilla.wikimedia.org/70827 (10Florian) a:3Florian [15:24:43] (03Merged) 10jenkins-bot: API: Add timestamp of block to blockinfo [core] - 10https://gerrit.wikimedia.org/r/143787 (https://bugzilla.wikimedia.org/63326) (owner: 10Brian Wolff) [15:25:35] (03CR) 10Anomie: [C: 04-1] "On my testing system, iiurlparam=100px is working fine but iiurlparam=x100px or iiurlparam=100x100px fails." [core] - 10https://gerrit.wikimedia.org/r/140864 (owner: 10Brian Wolff) [15:25:42] (03CR) 10Anomie: [C: 032] "oops" [core] - 10https://gerrit.wikimedia.org/r/140864 (owner: 10Brian Wolff) [15:25:45] 3MediaWiki extensions / 3WikidataRepo: Wrong century rounding is applied when entering Time values - 10https://bugzilla.wikimedia.org/64742 (10Lydia Pintscher) s:5normal>3critic [15:26:02] (03Merged) 10jenkins-bot: Update MultimediaViewer submodule [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160450 (owner: 10Gergő Tisza) [15:26:17] (03Merged) 10jenkins-bot: Update MultimediaViewer submodule [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160418 (owner: 10Gergő Tisza) [15:26:19] (03CR) 10jenkins-bot: [V: 04-1] Do not require iiurlwidth when getting thumbnails. [core] - 10https://gerrit.wikimedia.org/r/140864 (owner: 10Brian Wolff) [15:27:59] 3Wikimedia / 3Deployment systems: LocalisationUpdate failed: mwversionsinuse returned empty list - 10https://bugzilla.wikimedia.org/70844#c1 (10Bryan Davis) This error message comes from the l10nupdate-1 script 3Wikimedia / 3Deployment systems: [scap] Syncing a dblist referencing a nonexistent DB should be prevented - 10https://bugzilla.wikimedia.org/70132#c2 (10Antoine "hashar" Musso) If we ever manage to publicly expose the list of database name actually deployed on the cluster, we could then add an integration t... [15:31:59] 3MediaWiki extensions / 3WikidataRepo: [time ui] years like 1400 are added with precision=7 (century) - 10https://bugzilla.wikimedia.org/63726#c4 (10Lydia Pintscher) 5NEW>3RESO/FIX I am going to close this as the first issue is fixed and I don't see us being able to solve the other one in the foreseeable... [15:39:29] 3MediaWiki extensions / 3WikidataRepo: Wikidata exception on test2.wikipedia (test.wikipedia works) - 10https://bugzilla.wikimedia.org/70747#c9 (10Greg Grossmeier) 5NEW>3RESO/FIX 14:13 logmsgbot: aude Started scap: Put test.wikidata back on mw1.24-wmf19 extension branch 14:50 logmsgbot: aude Finished s... [15:39:44] 3MediaWiki extensions / 3WikidataRepo: Unexpected non-MediaWiki exception encountered, of type "BadMethodCallException" on line 275 of Entity.php - 10https://bugzilla.wikimedia.org/70736#c2 (10Aude) ok, this can easily be reproduced. having an item stored in memcached, then deploy new code, and load a clien... [15:40:29] 3MediaWiki / 3ResourceLoader: [Regression] Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c28 (10Greg Grossmeier) Bartosz: I'm just seeing this now. No one added it this morning; you should have :) [15:45:25] (03CR) 10Anomie: [C: 031] "I don't think we completely broke compat with 1.23 yet, although I7e18d57f came close. Do we want to do so?" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/160411 (owner: 10Legoktm) [15:47:59] 3MediaWiki / 3General/Unknown: Remove assumption from MediaWiki core that JS/CSS are only in MediaWiki namespace or User subpages - 10https://bugzilla.wikimedia.org/70835#c4 (10Helder) Will this have any impact on things like the visibility of the toolbars (the classic and/or from WikiEditor)? See e.g.: * Bu... [15:49:44] 3MediaWiki extensions / 3Gadgets: 2.0: Document best practices for creating local overrides of global gadgets - 10https://bugzilla.wikimedia.org/70841#c1 (10Helder) Isn't this related to the [[mw:Gadgets 3.0]] work by Salvatore? See https://www.mediawiki.org/wiki/User:Salvatore_Ingala/Notes https://www.media... [15:51:46] (03CR) 10Anomie: [C: 032] ApiQuerySiteinfo: Use proper localised skin display names if available [core] - 10https://gerrit.wikimedia.org/r/157275 (https://bugzilla.wikimedia.org/48953) (owner: 10Bartosz Dziewoński) [15:53:14] 3MediaWiki / 3API: Add block timestamp to blockinfo - 10https://bugzilla.wikimedia.org/63326#c7 (10Brad Jorsch) 5PATC>3RESO/FIX Should be deployed to WMF wikis with 1.24wmf22, see https://www.mediawiki.org/wiki/MediaWiki_1.24/Roadmap for the schedule. [15:53:16] (03CR) 10Anomie: [C: 04-1] "Needs rebase." [core] - 10https://gerrit.wikimedia.org/r/140864 (owner: 10Brian Wolff) [15:59:56] (03Merged) 10jenkins-bot: ApiQuerySiteinfo: Use proper localised skin display names if available [core] - 10https://gerrit.wikimedia.org/r/157275 (https://bugzilla.wikimedia.org/48953) (owner: 10Bartosz Dziewoński) [16:06:16] 3MediaWiki / 3API: API siteinfo skins should use English skin names in * instead of the value in $wgValidSkinNames - 10https://bugzilla.wikimedia.org/48953 (10Bartosz Dziewoński) 5PATC>3RESO/FIX a:3Bartosz Dziewoński [16:06:17] (03PS17) 10Matthias Mullie: [WIP] search [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126996 [16:11:59] 3Wikimedia / 3SSL related: Allow option to uncheck "Always use a secure connection when logged in" at login.wikimedia.org/wiki/Special:Preferences - 10https://bugzilla.wikimedia.org/69319 (10Andre Klapper) p:5Low>3Lowest [16:12:23] (03PS2) 10Jdlrobson: Supress email validation on cancellation in SpecialChangeEmail [core] - 10https://gerrit.wikimedia.org/r/160279 (https://bugzilla.wikimedia.org/70676) (owner: 10Rohan013) [16:13:08] (03CR) 10Jdlrobson: [C: 032] Supress email validation on cancellation in SpecialChangeEmail [core] - 10https://gerrit.wikimedia.org/r/160279 (https://bugzilla.wikimedia.org/70676) (owner: 10Rohan013) [16:14:16] 3MediaWiki / 3Special pages: ChangeEmail does not always allow you to cancel if you have an invalid email - 10https://bugzilla.wikimedia.org/70676 (10Jon) 5PATC>3RESO/FIX [16:14:21] manybubbles: hey, does cirrus intentionally not search for things in links (URLs), even with insource:, or is that a bug; and how do i work around it? [16:14:36] manybubbles: https://pl.wikipedia.org/w/index.php?title=Specjalna%3ASzukaj&profile=default&search=insource%3A%22mazovia.pl%22&fulltext=Search should find https://pl.wikipedia.org/wiki/Elżbieta_Lanc , but doesn't. [16:14:58] (insource:/mazovia\.pl/, however, does find it, but takes ages to run) [16:15:45] 3Wikimedia / 3Bugzilla: analytics project needs a Dashiki component - 10https://bugzilla.wikimedia.org/70846#c1 (10Andre Klapper) 5NEW>3RESO/FIX a:3Andre Klapper Done: https://bugzilla.wikimedia.org/describecomponents.cgi?product=Analytics Enjoy! [16:19:02] 3MediaWiki extensions / 3[other]: Graph extension security review - 10https://bugzilla.wikimedia.org/69623#c5 (10Chris Steipp) 5NEW>3RESO/FIX Ok, the rest of it should be safe. I would certainly encourage you to make the extension default to safe mode, and using the local wiki as the default whitelisted... [16:21:08] (03Merged) 10jenkins-bot: Supress email validation on cancellation in SpecialChangeEmail [core] - 10https://gerrit.wikimedia.org/r/160279 (https://bugzilla.wikimedia.org/70676) (owner: 10Rohan013) [16:47:01] 3MediaWiki extensions / 3CentralAuth: Not possible to filter Special:Log/gblrename by old CentralAuth account name - 10https://bugzilla.wikimedia.org/70850 (10Vogone) 3NEW p:3Unprio s:3major a:3None When trying to filter https://meta.wikimedia.org/wiki/Special:Log/gblrename by "Target (title or user)... [16:47:16] 3MediaWiki extensions / 3CentralAuth: Global renames should leave local log entries on affected wikis - 10https://bugzilla.wikimedia.org/70851 (10Vogone) 3NEW p:3Unprio s:3normal a:3None Especially with bug 70850, it is very hard to keep track of global renames. Thus, I believe it should be considere... [16:48:56] (03CR) 10CSteipp: [C: 031] "I like this better" [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/159370 (https://bugzilla.wikimedia.org/70615) (owner: 10Bartosz Dziewoński) [16:49:29] 3MediaWiki-Vagrant / 3labs-vagrant: Fatal error, timeout when running composer install - 10https://bugzilla.wikimedia.org/70843#c1 (10Aude) despite in the php.ini settings: ; http://vanderveer.be/speed-up-composer-by-using-hhvm-including-a-slowtimer-error-fix/ hhvm.resource_limit.socket_default_timeout = 3... [16:51:44] 3MediaWiki-Vagrant / 3labs-vagrant: Fatal error, timeout when running composer install - 10https://bugzilla.wikimedia.org/70843 (10Bryan Davis) p:5Unprio>3Normal [16:58:42] (03PS2) 10Tpt: Save pages content in the default format of their content type [core] - 10https://gerrit.wikimedia.org/r/157150 [16:59:02] 3MediaWiki / 3User login and signup: Login form lacks customisable info text - 10https://bugzilla.wikimedia.org/70852 (10Isarra) 3NEW p:3Unprio s:3normal a:3None If login on a project requires special directions (such as 'use same login as blah', or 'some accounts have been lost, please recreate your... [17:00:45] (03CR) 10Tpt: Save pages content in the default format of their content type (031 comment) [core] - 10https://gerrit.wikimedia.org/r/157150 (owner: 10Tpt) [17:05:39] (03CR) 10MarkTraceur: "What are we waiting on now? gi11es? tgr? thedj?" [core] - 10https://gerrit.wikimedia.org/r/151128 (owner: 10MarkTraceur) [17:09:29] (03PS1) 10Manybubbles: Add script to squash deletes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/160473 [17:09:49] (03CR) 10Isarra: [C: 031] "This all looks sound." [core] - 10https://gerrit.wikimedia.org/r/110279 (https://bugzilla.wikimedia.org/47694) (owner: 10Bartosz Dziewoński) [17:15:35] (03PS1) 10MaxSem: WIP: refactor image addition [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/160474 [17:15:40] (03CR) 10jenkins-bot: [V: 04-1] WIP: refactor image addition [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/160474 (owner: 10MaxSem) [17:15:44] 3MediaWiki extensions / 3Collection: New PDF renderer: [[United States]] fails to render - 10https://bugzilla.wikimedia.org/68854#c3 (10C. Scott Ananian) It turns out that we're not properly escaping the first argument of \hyperlink and \hypertarget. Patch in process. [17:15:58] (03PS4) 10EBernhardson: H5: Hide reply and edit links in locked posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158618 (owner: 10Jdlrobson) [17:16:05] (03PS2) 10Isarra: Restore content text contrast (black) [core] - 10https://gerrit.wikimedia.org/r/148548 (https://bugzilla.wikimedia.org/66021) [17:16:12] (03CR) 10EBernhardson: "PS4: manual rebase, update coming soon" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158618 (owner: 10Jdlrobson) [17:16:27] (03PS3) 10Isarra: Restore content text contrast (black) [core] - 10https://gerrit.wikimedia.org/r/148548 (https://bugzilla.wikimedia.org/66021) [17:17:01] (03CR) 10jenkins-bot: [V: 04-1] Restore content text contrast (black) [core] - 10https://gerrit.wikimedia.org/r/148548 (https://bugzilla.wikimedia.org/66021) (owner: 10Isarra) [17:17:02] 3MediaWiki extensions / 3WikibaseQuery: API error on a wbgetclaims request - 10https://bugzilla.wikimedia.org/70854 (10ben.mcgee.good) 3UNCO p:3Unprio s:3normal a:3Wikidata bugs request https://www.wikidata.org/w/api.php?action=wbgetclaims&entity=Q17939676&property=P527 response (03PS1) 10Manybubbles: Lower default phrase window to 512 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/160475 [17:18:49] (03CR) 10Bartosz Dziewoński: "The only alternatives are lego messages or merging ParserFunctions into core." [core] - 10https://gerrit.wikimedia.org/r/110279 (https://bugzilla.wikimedia.org/47694) (owner: 10Bartosz Dziewoński) [17:19:44] 3Wikimedia / 3Git/Gerrit: Free-form tagging in gerrit - 10https://bugzilla.wikimedia.org/35534#c21 (10Seb35) I’m not sure if I understood correctly the bug report, but it’s already possible to change the topic after the commit. See https://gerrit.wikimedia.org/r/#/c/160022/ for an example (a comment is added... [17:26:18] (03PS1) 10Cmcmahon: QA: get messages test to pass properly [extensions/Echo] - 10https://gerrit.wikimedia.org/r/160477 [17:27:00] 3MediaWiki extensions / 3WikidataRepo: Wikidata exception on test2.wikipedia (test.wikipedia works) - 10https://bugzilla.wikimedia.org/70747#c10 (10Aude) I can easily reproduce the issues that we had on beta, and bumping the cache key we use for entities seems the solution. I think the solution is to have t... [17:29:00] 3MediaWiki extensions / 3WikidataRepo: ApiFormatXml::recXmlPrint: has integer keys without _element in wbeditentity api module - 10https://bugzilla.wikimedia.org/70299#c2 (10Aude) *** Bug 70854 has been marked as a duplicate of this bug. *** [17:29:00] 3MediaWiki extensions / 3WikibaseQuery: API error on a wbgetclaims request - 10https://bugzilla.wikimedia.org/70854#c1 (10Aude) 5UNCO>3RESO/DUP it's a known bug and we are working on fixing it. wbgetclaims and wbeditentity are affected. *** This bug has been marked as a duplicate of bug 70299 *** [17:29:29] 3Wikimedia / 3Git/Gerrit: Free-form tagging in gerrit - 10https://bugzilla.wikimedia.org/35534#c22 (10Andre Klapper) See replies on https://lists.wikimedia.org/pipermail/wikitech-l/2014-September/078626.html [17:29:38] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (073f37e258) [core] - 10https://gerrit.wikimedia.org/r/160460 (owner: 10Jforrester) [17:30:16] 3MediaWiki extensions / 3WikibaseQuery: API error on a wbgetclaims request - 10https://bugzilla.wikimedia.org/70854#c2 (10Aude) also, while the xml format should obviously not have this issue, I think that format=json will tend to be more stable. [17:31:16] (03CR) 10Gilles: "May I be a pain and suggest sample files and a test to go along? :)" [core] - 10https://gerrit.wikimedia.org/r/160304 (owner: 10Brian Wolff) [17:31:20] (03PS3) 10Bartosz Dziewoński: Use Title::hasContentModel() instead of a direct comparison [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/157011 (owner: 10Legoktm) [17:31:26] (03PS4) 10Bartosz Dziewoński: Use Title::hasContentModel() instead of a direct comparison [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/157011 (owner: 10Legoktm) [17:31:53] (03CR) 10jenkins-bot: [V: 04-1] Use Title::hasContentModel() instead of a direct comparison [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/157011 (owner: 10Legoktm) [17:31:59] 3MediaWiki / 3User login and signup: Login form lacks customisable info text - 10https://bugzilla.wikimedia.org/70852#c1 (10Isarra) 5NEW>3RESO/INV Apparently this was fixed in 1.24. Unfortunately that doesn't really help everyone on a stable version currently; I hope people will be more careful when arbi... [17:33:43] (03CR) 10Bartosz Dziewoński: "Hashar, do you know why the job is still failing? The broken tests in Flow should have been fixed with https://gerrit.wikimedia.org/r/#/c/" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/157011 (owner: 10Legoktm) [17:34:10] (03CR) 10Aaron Schulz: JobRunner: Use Config instead of globals (032 comments) [core] - 10https://gerrit.wikimedia.org/r/152821 (owner: 10Legoktm) [17:36:14] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (073f37e258) [core] - 10https://gerrit.wikimedia.org/r/160460 (owner: 10Jforrester) [17:37:40] (03PS1) 10Manybubbles: Better error messaging in maintenance scripts [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/160479 [17:37:59] 3Wikimedia / 3Git/Gerrit: Free-form tagging in gerrit - 10https://bugzilla.wikimedia.org/35534#c23 (10Nemo) (In reply to Seb35 from comment #21) > I’m not sure if I understood correctly the bug report, And I'm not sure https://code.google.com/p/gerrit/issues/detail?id=287#c16 did either, given the link htt... [17:40:24] MatmaRex, hi .. do you offhand know of extensions that provide their own css modules (and/or pages that use them) .. this is so we can test the patch that marc is wokring on. [17:41:44] 3MediaWiki extensions / 3WikidataRepo: Implement new SiteLink UI - 10https://bugzilla.wikimedia.org/68903#c1 (10Matěj) Maybe this bug blocks bug 52136? [17:42:14] (03PS11) 10Isarra: Cleanup special:interwiki intro [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/156190 [17:42:57] (03CR) 10Isarra: "This should be the same as it was, just all rebased and stuff. Can we merge it now?" [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/156190 (owner: 10Isarra) [17:43:15] subbu: syntaxhighlight_geshi is the big one [17:43:45] it is so common that we always include that module in our html. [17:43:59] so, looking for others ;) [17:44:00] hah [17:44:15] although as part of that patch, we can stop doing that. [17:44:20] and make it conditional [17:44:56] (03CR) 10Jamesmontalvo3: "I've made several changes locally, but cannot submit from my current location. I will do so this afternoon or evening, but figured I'd kee" [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [17:45:31] subbu: you can make core use additional modules by transcluding some special pages, like Recentchanges [17:46:36] i see. ok. [17:46:42] subbu: https://www.mediawiki.org/wiki/Extension:Babel has a style module, too [17:46:49] (03PS1) 10Isarra: Restore content text contrast (black) [skins/Vector] - 10https://gerrit.wikimedia.org/r/160481 (https://bugzilla.wikimedia.org/66021) [17:47:13] i'm looking, but it seems most things come with JS modules :) [17:47:28] (03Abandoned) 10Isarra: Restore content text contrast (black) [core] - 10https://gerrit.wikimedia.org/r/148548 (https://bugzilla.wikimedia.org/66021) (owner: 10Isarra) [17:47:33] that makes sense. [17:50:25] (03PS1) 10SG: Introduce flowSpawnedBy handler to forward events from outside of FlowComponent [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160483 [17:59:56] (03PS1) 10Nemo bis: Typofix in comment [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/160486 [18:01:24] (03CR) 10Gilles: [C: 032] Typofix in comment [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/160486 (owner: 10Nemo bis) [18:01:50] (03Merged) 10jenkins-bot: Typofix in comment [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/160486 (owner: 10Nemo bis) [18:02:29] 3MediaWiki-Vagrant / 3labs-vagrant: Fatal error, timeout when running composer install - 10https://bugzilla.wikimedia.org/70843#c2 (10Dan Duvall) I believe the threshold for script execution is controlled by 'max_execution_timeout' which still seems to be set at 180. [1] vagrant@mediawiki-vagrant:~$ php -r... [18:03:43] (03CR) 10Gilles: Fix API help for query=videoinfo (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/157619 (https://bugzilla.wikimedia.org/55744) (owner: 10Brian Wolff) [18:05:44] (03PS1) 10Ejegg: Update CentralNotice submodule for JSON fix [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160487 [18:06:03] (03PS1) 10Catrope: Update OOjs UI to v0.1.0-pre (073f37e258) [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160488 [18:06:18] (03CR) 10Gilles: [C: 032] Make sure processResponsiveImages checks for valid thumb object [core] - 10https://gerrit.wikimedia.org/r/154132 (owner: 10Brian Wolff) [18:07:38] (03PS1) 10Cscott: Properly escape HTML anchors and id attributes. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/160489 (https://bugzilla.wikimedia.org/68854) [18:07:52] MatmaRex, Extension:Babel is a non-issue with latest master when I tested with visual diffing [18:07:57] (03PS2) 10Cmcmahon: QA: get messages test to pass properly [extensions/Echo] - 10https://gerrit.wikimedia.org/r/160477 [18:09:14] RoanKattouw: are you trying to deploy something right now? [18:09:44] No? [18:09:46] Why? [18:10:18] Oh because I'm cherry-picking things [18:10:26] just saw a commit to core - Update OOjs to v0.1.0-pre [18:10:59] can you leave that unmerged for a wee bit while I push a CentralNotice update? [18:11:09] Yeah I wasn't going to merge it until the 4pm SWAT anyway [18:11:13] thanks! [18:11:57] (03PS1) 10Ejegg: Update CentralNotice submodule for JSON fix [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160490 [18:11:59] 3MediaWiki-Vagrant / 3labs-vagrant: Fatal error, timeout when running composer install - 10https://bugzilla.wikimedia.org/70843#c3 (10Bryan Davis) (In reply to Dan Duvall from comment #2) > I believe the threshold for script execution is controlled by > 'max_execution_timeout' which still seems to be set at... [18:12:05] (03PS2) 10Cscott: Save details of title redirects followed. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/152083 [18:12:24] (03CR) 10Arlolra: Properly escape HTML anchors and id attributes. (031 comment) [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/160489 (https://bugzilla.wikimedia.org/68854) (owner: 10Cscott) [18:13:02] (03PS1) 10GWicke: Use correct 'finish' event instead of 'close' [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160491 [18:13:06] (03CR) 10Awight: [C: 032] Update CentralNotice submodule for JSON fix [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160487 (owner: 10Ejegg) [18:13:29] 3MediaWiki / 3MediaWiki UI: MediaWiki UI styles are applied to core instead of relevant skins - 10https://bugzilla.wikimedia.org/70351#c11 (10Isarra) (In reply to Matthew Flaschen from comment #10) > (In reply to Isarra from comment #9) > > Sure, the colour-coded buttons according to their function are nice,... [18:13:41] (03CR) 10Awight: [C: 032] Update CentralNotice submodule for JSON fix [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160490 (owner: 10Ejegg) [18:13:43] (03Merged) 10jenkins-bot: Make sure processResponsiveImages checks for valid thumb object [core] - 10https://gerrit.wikimedia.org/r/154132 (owner: 10Brian Wolff) [18:13:58] gwicke: i think 'finish' is part of node 0.8 compatibility, i'll doublecheck [18:14:27] cscott: we don't need 0.8 afaik [18:14:33] (03CR) 10jenkins-bot: [V: 04-1] Save details of title redirects followed. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/152083 (owner: 10Cscott) [18:14:47] (03PS3) 10Cscott: Save details of title redirects followed. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/152083 [18:16:20] (03Merged) 10jenkins-bot: Update CentralNotice submodule for JSON fix [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160487 (owner: 10Ejegg) [18:16:54] (03Merged) 10jenkins-bot: Update CentralNotice submodule for JSON fix [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160490 (owner: 10Ejegg) [18:17:02] 3MediaWiki / 3User login and signup: Login as another user no longer works - 10https://bugzilla.wikimedia.org/70855 (10Isarra) 3NEW p:3Unprio s:3normal a:3None If you're already logged in, you can not longer directly log in as another user (such as with bots, different privilege or role accounts, soc... [18:17:20] (03CR) 10Cscott: Properly escape HTML anchors and id attributes. (031 comment) [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/160489 (https://bugzilla.wikimedia.org/68854) (owner: 10Cscott) [18:17:30] 3MediaWiki / 3Interface: "new section" tab added by __NEWSECTIONLINK__ not shown for non-view actions - 10https://bugzilla.wikimedia.org/20177#c6 (10Rummana Yasmeen) *** Bug 70848 has been marked as a duplicate of this bug. *** [18:17:40] (03PS2) 10Cscott: Properly escape HTML anchors and id attributes. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/160489 (https://bugzilla.wikimedia.org/68854) [18:18:32] (03CR) 10Aaron Schulz: [C: 032] Don't require midi output in raw mode if not linking to it (031 comment) [extensions/Score] - 10https://gerrit.wikimedia.org/r/102367 (owner: 10Brian Wolff) [18:18:41] (03Merged) 10jenkins-bot: Don't require midi output in raw mode if not linking to it [extensions/Score] - 10https://gerrit.wikimedia.org/r/102367 (owner: 10Brian Wolff) [18:19:30] cscott: is there a bug for the truncation issue? [18:19:44] no, let me open one [18:20:05] cscott: well, it might be fixed already after my patch [18:20:14] just wondered whether I should link to an existing bug [18:20:23] no, i doubt it. i actually switched from finish to close during earlier debugging of the truncation issue [18:20:33] it's fixed for me locally [18:20:44] there is no 'close' event on a writable stream according to the docs [18:20:47] because i was concerned that 'finish' might happen before the file descriptor was actually closed. [18:21:07] (03Abandoned) 10Aaron Schulz: [WIP] Removed selective restore checkboxes from Special:Undelete [core] - 10https://gerrit.wikimedia.org/r/145027 (owner: 10Aaron Schulz) [18:21:16] gwicke: let me check locally. [18:22:59] 3MediaWiki extensions / 3PageImages: the hovercard shows an image that doesn't exist on the target page - 10https://bugzilla.wikimedia.org/70807#c3 (10Max Semenik) What do you mean by doesn't exist? It's in the navbox. Looking if it's possible to score it down based on section number... [18:23:27] (03CR) 10Arlolra: [C: 032] Properly escape HTML anchors and id attributes. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/160489 (https://bugzilla.wikimedia.org/68854) (owner: 10Cscott) [18:23:39] it's possible i created this bug by trying to fix another, wouldn't be the first time. ;) [18:24:07] cscott: for some reason html fetching doesn't seem to always happen though [18:24:59] 3MediaWiki skins / 3Vector: Vector: Grey content text impairs legibility - 10https://bugzilla.wikimedia.org/66021#c10 (10Erwin Dokter) I have no clear preference between #000000 and #252525. In fact, I see little difference between the two (on a properly set CRT). I do have a problem with the arguments that... [18:25:46] (03Merged) 10jenkins-bot: Properly escape HTML anchors and id attributes. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/160489 (https://bugzilla.wikimedia.org/68854) (owner: 10Cscott) [18:27:32] (03CR) 10Aaron Schulz: "I tried that and it broke parserTest.inc so it was reverted." [core] - 10https://gerrit.wikimedia.org/r/153944 (owner: 10Aaron Schulz) [18:27:46] (03CR) 10Arlolra: [C: 032] Save details of title redirects followed. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/152083 (owner: 10Cscott) [18:29:21] (03Merged) 10jenkins-bot: Save details of title redirects followed. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/152083 (owner: 10Cscott) [18:30:15] 3MediaWiki extensions / 3PageImages: the hovercard shows an image that doesn't exist on the target page - 10https://bugzilla.wikimedia.org/70807#c4 (10Amir E. Aharoni) Ah, it's there, but the navbox hides it. Feel free to close it as INVALID or WORKSFORME unless you want to do something smart about it. Tha... [18:30:19] cscott: is this https://bugzilla.wikimedia.org/show_bug.cgi?id=68929 ? [18:31:21] 68929 is a poorly written bug. just about anything could be said to fix 68929. [18:31:29] 3MediaWiki-Vagrant / 3labs-vagrant: Fatal error, timeout when running composer install - 10https://bugzilla.wikimedia.org/70843#c4 (10Dan Duvall) (In reply to Bryan Davis from comment #3) > I think this is a bug in hhvm actually. Read that documentation link you > gave and you'll see that php5-cli defaults t... [18:31:41] but truncation doesn't fix 68929 because we've been retrying in the case of truncation for a while now. ;) [18:31:55] (03PS2) 10GWicke: Bug 68929: Use correct 'finish' event instead of 'close' [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160491 [18:32:12] I think 68929 is now "Zweiter Weltkrieg crashes" [18:32:45] cscott: image truncation was discussed in there too [18:33:01] and it's possible that retries weren't enough in every case [18:33:21] cscott: do you also see the attribution fetching sometimes not happening? [18:35:44] 3MediaWiki extensions / 3Collection: Almost any image makes the PDF rendering crash - 10https://bugzilla.wikimedia.org/68929#c13 (10C. Scott Ananian) Note that this is actually a somewhat bogus bug -- the crashes above were caused by a number of different factors, including image truncation, improper escapin... [18:36:44] well, we were retrying and then skipping the image if retries weren't enough. so no truncated images were getting through to crash latex anymore, after e12b79121df18158403ca5f0b160fc95883d0ccc [18:36:58] let me look into the attribution fetching [18:38:03] (03CR) 10Dbrant: [C: 032] Change default session sampling rate to 0. [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/160310 (owner: 10Deskana) [18:43:50] cscott: let me know if there's any other issue you'd like me to look into [18:44:27] (03PS5) 10EBernhardson: H5: Hide reply and edit links in locked posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158618 (owner: 10Jdlrobson) [18:45:06] gwicke: oh, the attribution fetching would be a good issue for you to look into, i didn't mean to take that from you [18:45:07] (03CR) 10jenkins-bot: [V: 04-1] H5: Hide reply and edit links in locked posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158618 (owner: 10Jdlrobson) [18:45:50] gwicke: i just meant that i should try to see if i can reproduce that locally. but my connection is really bad locally and I'm getting ESOCKETTIMEDOUT on http://upload.wikimedia.org/wikipedia/commons/6/69/Battle_of_Gettysburg%2C_by_Currier_and_Ives.png which is clouding my view [18:46:39] so far I haven't seen any truncation with your patch applied, which is very good news if it holds up [18:46:48] cscott: can you give me a hint on where this is orchestrated after image fetching? [18:47:23] mw-ocg-bundler/lib/attribution.js [18:47:52] search for writeAttribution in mw-ocg-bundler/lib/index.js [18:48:49] i can't imagine why that step would be skipped, unless there's some strange error-handling control flow going on [18:49:04] ok, thanks [18:49:52] looking into that [18:57:45] 3MediaWiki / 3Language converter: Language setting keeps resetting itself at kk: - 10https://bugzilla.wikimedia.org/64440 (10Stryn) [18:57:45] 3MediaWiki extensions / 3UniversalLanguageSelector: ?setlang does not change language in main namespace in kk-wiki - 10https://bugzilla.wikimedia.org/58790 (10Stryn) [18:59:59] (03PS1) 10Umherirrender: Readd word-separator between edithelp link and newwindow hint [core] - 10https://gerrit.wikimedia.org/r/160498 [19:01:18] (03PS1) 10Spage: QA: Update selenium-webdriver so Firefox 32 works [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160499 [19:01:26] (03PS8) 10Prtksxna: kss: Add js to hide non current sub-sections [core] - 10https://gerrit.wikimedia.org/r/158856 [19:01:28] (03PS9) 10Prtksxna: kss: Highlight section link based on scroll [core] - 10https://gerrit.wikimedia.org/r/158858 [19:01:57] (03CR) 10jenkins-bot: [V: 04-1] Bug 68929: Use correct 'finish' event instead of 'close' [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160491 (owner: 10GWicke) [19:03:59] 3MediaWiki skins / 3Vector: Vector: Grey content text impairs legibility - 10https://bugzilla.wikimedia.org/66021#c11 (10Isarra) (In reply to Erwin Dokter from comment #10) > I have no clear preference between #000000 and #252525. In fact, I see > little difference between the two (on a properly set CRT CRT... [19:04:02] (03CR) 10Umherirrender: Add blanket support for mediawiki ui via globals (031 comment) [core] - 10https://gerrit.wikimedia.org/r/150635 (owner: 10Jdlrobson) [19:08:09] (03PS2) 10Addshore: CachedGadgetRepo: Store Content objects internally instead of JSON blobs [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160431 (owner: 10Legoktm) [19:08:14] (03PS5) 10Addshore: Add some basic tests for LocalGadgetRepo & ForeignDBGadgetRepo [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160432 (owner: 10Legoktm) [19:08:29] 3MediaWiki extensions / 3Collection: [[Corps]], [[Comet]], [[Zweiter Weltkrieg]], [[First-move advantage in chess]], and [[United States]] make the PDF renderer crash - 10https://bugzilla.wikimedia.org/68929 (10Greg Grossmeier) [19:08:59] 3MediaWiki extensions / 3Collection: [[Corps]], [[Comet]], [[de:Zweiter Weltkrieg]], [[First-move advantage in chess]], and [[United States]] make the PDF renderer crash - 10https://bugzilla.wikimedia.org/68929 (10jeremyb) [19:09:36] jeremyb: :) re ^ [19:09:45] took me a second to find the diff [19:09:49] hah [19:10:01] working links > broken links [19:10:03] :) [19:10:14] 3MediaWiki skins / 3Vector: Vector: Grey content text impairs legibility - 10https://bugzilla.wikimedia.org/66021#c12 (10Daniel Friesen) (In reply to Isarra from comment #11) > Conceptually, text is black. We print with black ink. It may wind up > appearing as grey depending on the type of ink and how the li... [19:10:19] (03CR) 10Addshore: [C: 04-1] CachedGadgetRepo: Store Content objects internally instead of JSON blobs (031 comment) [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160431 (owner: 10Legoktm) [19:12:17] 3MediaWiki / 3General/Unknown: When I change a language I need to refresh the page before it comes into effect - 10https://bugzilla.wikimedia.org/70859 (10Stryn) 3NEW p:3Unprio s:3normal a:3None When I change a language in a certain wiki, I need to refresh the page before the language is actually cha... [19:15:35] (03PS3) 10Prtksxna: Better article link detection [extensions/Popups] - 10https://gerrit.wikimedia.org/r/146477 (https://bugzilla.wikimedia.org/68039) (owner: 10Se4598) [19:15:59] 3MediaWiki / 3User login and signup: Login as another user no longer works - 10https://bugzilla.wikimedia.org/70855#c1 (10Steven Walling) This is an odd regression. For reproducibility: 1. Visit a wiki while logged in. 2. Search for Special:UserLogin or enter in the URL manually. 3. You are redirected to t... [19:16:03] (03CR) 10jenkins-bot: [V: 04-1] Better article link detection [extensions/Popups] - 10https://gerrit.wikimedia.org/r/146477 (https://bugzilla.wikimedia.org/68039) (owner: 10Se4598) [19:17:53] (03CR) 10Addshore: [C: 04-1] "needs a manual rebase" [core] - 10https://gerrit.wikimedia.org/r/48417 (https://bugzilla.wikimedia.org/34117) (owner: 10Parent5446) [19:19:27] greg-g, jeremyb: thank you, bugzilla fairies! [19:19:37] (03PS2) 10Addshore: Declare visibility of functions explicitly [core] - 10https://gerrit.wikimedia.org/r/159537 (owner: 10Florianschmidtwelzow) [19:19:43] (03CR) 10Addshore: [C: 032] Declare visibility of functions explicitly [core] - 10https://gerrit.wikimedia.org/r/159537 (owner: 10Florianschmidtwelzow) [19:20:02] YuviPanda, ori, hi, Tim-away commented on the core maint script to import files. Basically he does'nt want it in core unless all import scripts are merged into the "import infrastructure" which accepts multiple sources (xml, files, images, etc). I agree in principle, but currently don't have the spare cycles to do it. I propose we merge this patch and when we update maintenance, simply redirect it to use core's script. https://gerrit.wikimedia.org/r [19:20:02] /#/c/153819/ [19:20:12] https://gerrit.wikimedia.org/r/#/c/153819/ [19:20:42] cscott: gnomes ;) [19:21:11] you need the little red hat to be a gnome [19:23:16] (03CR) 10Cscott: "recheck" [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160491 (owner: 10GWicke) [19:25:14] 3MediaWiki-Vagrant / 3labs-vagrant: Fatal error, timeout when running composer install - 10https://bugzilla.wikimedia.org/70843#c5 (10Bryan Davis) (In reply to Dan Duvall from comment #4) > (In reply to Bryan Davis from comment #3) > > I think this is a bug in hhvm actually. Read that documentation link you... [19:26:49] (03Merged) 10jenkins-bot: Declare visibility of functions explicitly [core] - 10https://gerrit.wikimedia.org/r/159537 (owner: 10Florianschmidtwelzow) [19:28:45] 3MediaWiki skins / 3Vector: Vector: Grey content text impairs legibility - 10https://bugzilla.wikimedia.org/66021#c13 (10Isarra) (In reply to Daniel Friesen from comment #12) > (In reply to Isarra from comment #11) > > Conceptually, text is black. We print with black ink. It may wind up > > appearing as grey... [19:31:46] (03PS2) 10Addshore: Use a mock GadgetRepo instead of LocalGadgetRepo::singleton() [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160202 (owner: 10Legoktm) [19:31:50] (03PS2) 10Addshore: Rewrite GadgetTest::testIsAllowed() to use a data provider [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160205 (owner: 10Legoktm) [19:32:29] (03CR) 10Addshore: [C: 032] Use a mock GadgetRepo instead of LocalGadgetRepo::singleton() [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160202 (owner: 10Legoktm) [19:32:35] (03Merged) 10jenkins-bot: Use a mock GadgetRepo instead of LocalGadgetRepo::singleton() [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160202 (owner: 10Legoktm) [19:33:05] (03CR) 10Addshore: [C: 032] Rewrite GadgetTest::testIsAllowed() to use a data provider [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160205 (owner: 10Legoktm) [19:33:12] (03Merged) 10jenkins-bot: Rewrite GadgetTest::testIsAllowed() to use a data provider [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160205 (owner: 10Legoktm) [19:33:24] cscott: how do you know i don't have a red hat? [19:34:15] (03PS3) 10Addshore: PHPUnit: Add Database tags [core] - 10https://gerrit.wikimedia.org/r/154338 (owner: 10Jjanes) [19:35:39] jeremyb: good point [19:37:15] (03CR) 10Gilles: [C: 032] Allow WantedQueryPage subclasses to override the existence check [core] - 10https://gerrit.wikimedia.org/r/147741 (owner: 10Brian Wolff) [19:37:28] (03PS6) 10Addshore: Add cURL constants test [core] - 10https://gerrit.wikimedia.org/r/159159 (https://bugzilla.wikimedia.org/70570) (owner: 10Dan-nl) [19:38:10] (03CR) 10Gilles: [C: 032] Better false positive detection for Special:Wantedfiles [core] - 10https://gerrit.wikimedia.org/r/147742 (owner: 10Brian Wolff) [19:39:28] (03CR) 10Gilles: "I nominate tgr for a last round of review :)" [core] - 10https://gerrit.wikimedia.org/r/151128 (owner: 10MarkTraceur) [19:40:21] And maybe later for the ice bucket challenge [19:41:53] (03CR) 10Addshore: [C: 04-1] PHPUnit: Add Database tags (033 comments) [core] - 10https://gerrit.wikimedia.org/r/154338 (owner: 10Jjanes) [19:47:04] (03Merged) 10jenkins-bot: Allow WantedQueryPage subclasses to override the existence check [core] - 10https://gerrit.wikimedia.org/r/147741 (owner: 10Brian Wolff) [19:47:06] (03Merged) 10jenkins-bot: Better false positive detection for Special:Wantedfiles [core] - 10https://gerrit.wikimedia.org/r/147742 (owner: 10Brian Wolff) [19:49:29] 3MediaWiki-Vagrant / 3labs-vagrant: Fatal error, timeout when running composer install - 10https://bugzilla.wikimedia.org/70843#c6 (10Dan Duvall) (In reply to Bryan Davis from comment #5) > The bug it is the difference in behavior between php and hhvm. Php5 ignores > any ini setting for max-execution-time wh... [19:50:01] (03PS2) 10Addshore: Remove SpecialPageAliasTest [core] - 10https://gerrit.wikimedia.org/r/121849 (owner: 10Aude) [19:52:03] (03CR) 10Jdlrobson: [C: 04-2] "I'm not convinced about the arguments on the bug. Seems Daniel shares my opinion. I don't think we should change this blindly. Some more c" [skins/Vector] - 10https://gerrit.wikimedia.org/r/160481 (https://bugzilla.wikimedia.org/66021) (owner: 10Isarra) [19:52:38] (03PS2) 10Addshore: Let BlockTest.php respect database constraints [core] - 10https://gerrit.wikimedia.org/r/100334 (https://bugzilla.wikimedia.org/58191) (owner: 10saper) [19:55:29] 3MediaWiki-Vagrant / 3labs-vagrant: Fatal error, timeout when running composer install - 10https://bugzilla.wikimedia.org/70843#c7 (10Dan Duvall) 5NEW>3ASSI Scratch that last question. I'll just go ahead and Do the Right Thing (tm). It looks easy enough to refactor. [19:56:10] (03CR) 10Addshore: "This might have basic jenkins linting now so will try a recheck" [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/38485 (owner: 10thibaultmarin) [19:56:17] (03CR) 10Addshore: "recheck" [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/38485 (owner: 10thibaultmarin) [19:58:45] (03PS7) 10Dan-nl: Add cURL constants test [core] - 10https://gerrit.wikimedia.org/r/159159 (https://bugzilla.wikimedia.org/70570) [19:59:58] (03CR) 10Dan-nl: "* removed the untested constant values." [core] - 10https://gerrit.wikimedia.org/r/159159 (https://bugzilla.wikimedia.org/70570) (owner: 10Dan-nl) [20:00:00] (03PS2) 10Cmcmahon: QA: Update selenium-webdriver so Firefox 32 works [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160499 (owner: 10Spage) [20:00:03] 3MediaWiki extensions / 3PageImages: the hovercard shows an image that doesn't exist on the target page - 10https://bugzilla.wikimedia.org/70807#c5 (10Max Semenik) Mhm, the only option I see is to add an option for explicit image blacklisting, e.g. [[File:foo.jpg|notpageimage|...]] because automatic scoring... [20:00:22] (03CR) 10Addshore: [C: 04-1] "needs manual rebase" [core] - 10https://gerrit.wikimedia.org/r/11063 (https://bugzilla.wikimedia.org/31313) (owner: 10MarkTraceur) [20:00:36] (03CR) 10Addshore: [C: 04-1] "needs manual rebase" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/11562 (owner: 10saper) [20:01:02] (03CR) 10Cmcmahon: [C: 032] QA: Update selenium-webdriver so Firefox 32 works [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160499 (owner: 10Spage) [20:01:16] (03CR) 10Addshore: [C: 04-1] "needs manual rebase" [core] - 10https://gerrit.wikimedia.org/r/20500 (https://bugzilla.wikimedia.org/39466) (owner: 10MarkAHershberger) [20:01:28] (03CR) 10Addshore: [C: 04-1] "needs manual rebase" [core] - 10https://gerrit.wikimedia.org/r/20534 (https://bugzilla.wikimedia.org/39461) (owner: 10Daniel Werner) [20:01:36] (03Merged) 10jenkins-bot: QA: Update selenium-webdriver so Firefox 32 works [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160499 (owner: 10Spage) [20:01:42] addshore: I bet some of these are just patch notes, right? [20:02:40] A lot of the really old stuff actually looks reasonbly good, if our code looked at all like that anymore! [20:02:49] (03CR) 10saper: [C: 031] "Thanks for rebase" [core] - 10https://gerrit.wikimedia.org/r/100334 (https://bugzilla.wikimedia.org/58191) (owner: 10saper) [20:03:38] Wondering how far back the most ancient commit that is actually mergeable and coder reviewable is! :P [20:04:51] addshore: Are you just bumping old commits? :P [20:04:58] certainly not :P [20:05:48] of course not [20:05:59] he's just making an army of frankencommits [20:06:31] what else could an addshore be doing? [20:07:11] (03CR) 10Aaron Schulz: [C: 032] Enforce some type hinting in Linker class [core] - 10https://gerrit.wikimedia.org/r/144646 (owner: 10Withoutaname) [20:07:33] (03CR) 10jenkins-bot: [V: 04-1] Enforce some type hinting in Linker class [core] - 10https://gerrit.wikimedia.org/r/144646 (owner: 10Withoutaname) [20:13:03] (03CR) 10Addshore: [C: 04-1] "needs a manual rebase anyway" [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160253 (owner: 10Legoktm) [20:13:30] (03PS2) 10Addshore: Add tests for GadgetDefinitionContentHandler [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160401 (owner: 10Legoktm) [20:15:20] (03PS3) 10Addshore: Empty repository, leave stub file (merged into core) [extensions/PostEdit] - 10https://gerrit.wikimedia.org/r/157205 (owner: 10Legoktm) [20:15:26] (03CR) 10Addshore: [C: 032] Empty repository, leave stub file (merged into core) [extensions/PostEdit] - 10https://gerrit.wikimedia.org/r/157205 (owner: 10Legoktm) [20:15:31] (03Merged) 10jenkins-bot: Empty repository, leave stub file (merged into core) [extensions/PostEdit] - 10https://gerrit.wikimedia.org/r/157205 (owner: 10Legoktm) [20:17:33] (03CR) 10saper: "Luckily we don't need conflicting method anymore." [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/11562 (owner: 10saper) [20:17:35] (03CR) 10Addshore: [C: 032] Add tests for GadgetDefinitionContentHandler [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160401 (owner: 10Legoktm) [20:17:41] (03Merged) 10jenkins-bot: Add tests for GadgetDefinitionContentHandler [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160401 (owner: 10Legoktm) [20:22:14] 3MediaWiki extensions / 3UniversalLanguageSelector: When I change a language I need to refresh the page before it comes into effect - 10https://bugzilla.wikimedia.org/70859#c1 (10Andre Klapper) Thanks for taking the time to report this! I could reproduce this with FF32. Wondering if ULS isn't setting someth... [20:22:48] (03PS14) 10saper: Respect CheckUser permissions when linking [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/11562 [20:23:14] anomie: around? [20:24:01] jackmcbarn: Somewhat [20:24:39] anomie: 2 quick questions: 1) is the thinig at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#Broken_wikitext something we should try to fix? 2) do you have any thoughts on the best way to fix https://bugzilla.wikimedia.org/show_bug.cgi?id=70495 ? as of now, i'm thinking of basically faking a Title [20:24:47] s/thinig/thing/ [20:25:36] (03PS6) 10EBernhardson: H5: Hide reply and edit links in locked posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158618 (owner: 10Jdlrobson) [20:26:15] (03CR) 10jenkins-bot: [V: 04-1] H5: Hide reply and edit links in locked posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158618 (owner: 10Jdlrobson) [20:27:43] jackmcbarn: 1) If it can be nicely done without risking breaking other stuff, yes. But if it would be crazy hacky code, no. 2) How would "faking a title" work? [20:29:06] anomie: i haven't thought about it in detail yet, but i'm thinking of having TemplateSandbox mess with the title object during the parse then putting it back when it's done, or if that's a bad idea, have a flag on the methods that get titles, saying whether to always get the real one, or get one that parser hooks can change [20:30:01] jackmcbarn: The problem is that is't not the currently-being-parsed title that's the problem. It's potentially *every* Title (or Revision!) object something creates. [20:31:19] anomie: right. so we'd have to add a hook to Title.* static methods to let us change the output of things like makeTitleSafe [20:31:54] (and good point, same for Revision, and any others i'm not thinking of now) [20:32:11] jackmcbarn: Not even that. You'd basically have to hijack the revision-content-fetch layer, back-translate the revision to a Title, and then decide whether to return the correct content or not. And then do the same for anything that fetches from a good number of database tables. [20:33:06] anomie: when are things asking for revisions before they ask for titles? [20:33:24] (because if they ask for a title first, we can lie about the revison) [20:33:39] jackmcbarn: Revision::newFromId? [20:33:54] anomie: i mean does anything from the parser call that? [20:33:58] (that you know of) [20:34:07] i can't think of a need to catch that case [20:34:39] (03PS7) 10EBernhardson: H5: Hide reply and edit links in locked posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158618 (owner: 10Jdlrobson) [20:35:14] (03CR) 10jenkins-bot: [V: 04-1] H5: Hide reply and edit links in locked posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158618 (owner: 10Jdlrobson) [20:35:17] (03CR) 10Cscott: "recheck" [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160491 (owner: 10GWicke) [20:35:27] jackmcbarn: IMO, it's probably best to go for the 90% solution and not worry about all the crazy edge cases. Maybe add a hook in Scribunto's getContent method, but let's not worry about faking out every #ifexists and so on. [20:36:07] #ifexist is actually a big one, when creating a new template that some other template uses crazy logic to detect existence and fallbacks of. but the others i agree probably aren't worth it [20:36:17] (03PS3) 10Cscott: Bug 68929: Use correct 'finish' event instead of 'close' [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160491 (owner: 10GWicke) [20:36:52] the other issue with using the template way is that some things (like wikidata's json pages) don't support transclusions, but getContent() does work, and we'd have to be careful not to break that [20:37:07] cscott: it seems that the Promise.all on the image stage never returns [20:38:03] gwicke: so some image is getting stuck and not downloading? [20:38:25] oh -- also, i remembered why node 0.8 matters -- it's what jenkins is running. that's why your patch is getting x'ed by jenkins. [20:38:46] it's not waiting.. node is exiting before the Promise.all resolves or rejects [20:39:05] cscott: poor Jenkins [20:39:06] oh? maybe something isn't chaining properly? [20:40:15] (03PS4) 10Cscott: Bug 68929: Use correct 'finish' event instead of 'close' [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160491 (owner: 10GWicke) [20:40:25] ^ maybe jenkins will like that better [20:41:34] honestly we should be testing on 0.10 [20:43:54] gwicke: +1 [20:44:01] (03CR) 10Cscott: WIP: Apply some of the settings from the ui (031 comment) [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/160237 (https://bugzilla.wikimedia.org/68836) (owner: 10Arlolra) [20:46:21] cscott: I suspect that it'll be hard to upgrade Jenkins with Antoine on leave etc [20:46:37] we'd have to upgrade everything [20:48:44] 3MediaWiki extensions / 3EducationProgram: "Remove from course" button no longer works - 10https://bugzilla.wikimedia.org/70748#c2 (10Andrew Green) I was able to reproduce this locally with core and the EducationProgram extension at version MediaWiki 1.24wmf21. [20:48:54] He was doing stuff this morning [20:49:42] (03PS1) 10Cscott: Updating to latest masters [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/160515 [20:51:28] (03CR) 10Cscott: [C: 032 V: 032] Updating to latest masters [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/160515 (owner: 10Cscott) [20:51:59] 3MediaWiki extensions / 3PageImages: the hovercard shows an image that doesn't exist on the target page - 10https://bugzilla.wikimedia.org/70807#c6 (10Amir E. Aharoni) 5NEW>3RESO/INV It may be a good idea in itself, but it has little to do with this non-bug and can be considered separately. [20:53:18] (03PS1) 10Cscott: Merge branch 'master' into wmf-deploy [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/160517 [20:54:12] (03CR) 10Raimond Spekking: [C: 032] Readd word-separator between edithelp link and newwindow hint [core] - 10https://gerrit.wikimedia.org/r/160498 (owner: 10Umherirrender) [20:54:34] (03CR) 10Cscott: [C: 032 V: 032] Merge branch 'master' into wmf-deploy [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/160517 (owner: 10Cscott) [20:57:44] 3MediaWiki extensions / 3RecentActivityFeed: Security review of RecentActivityFeed - 10https://bugzilla.wikimedia.org/69798#c1 (10Chris Steipp) Hey guys, I took an initial look through this. Other than following the style guide (I think someone pointed that out somewhere else too), and being updated to preve... [20:59:45] (03CR) 10Violetto: "The point where each item has to reach before it starts highlighting the section title is high or there isn't enough space at the bottom o" [core] - 10https://gerrit.wikimedia.org/r/158858 (owner: 10Prtksxna) [21:00:44] (03Merged) 10jenkins-bot: Readd word-separator between edithelp link and newwindow hint [core] - 10https://gerrit.wikimedia.org/r/160498 (owner: 10Umherirrender) [21:01:09] (03PS1) 10Foxtrott: Switch less compiler vendor [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/160519 [21:01:44] (03PS2) 10Foxtrott: Switch less compiler vendor and raise minimum version [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/160519 [21:02:00] (03CR) 10Foxtrott: [C: 032 V: 032] Switch less compiler vendor and raise minimum version [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/160519 (owner: 10Foxtrott) [21:02:34] cscott: the chaining looks fine on the surface; the only thing I could imagine would be some issue in the error path in one of the prfun methods [21:02:57] thanks much for the comments on RecentActivityFeed, csteipp [21:04:34] (03PS1) 10Foxtrott: Remove lessc from autoloader so MW core can load it's own broken compiler [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/160520 [21:04:45] (03PS2) 10Foxtrott: Remove lessc from autoloader so MW core can load it's own broken compiler [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/160520 [21:06:11] (03CR) 10Foxtrott: [C: 032 V: 032] Remove lessc from autoloader so MW core can load it's own broken compiler [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/160520 (owner: 10Foxtrott) [21:11:10] anomie: couldn't we do this really easily by moving CoreParserFunctions::getCachedRevisionObject to Parser, making it public, hooking it, then updating extensions to use it instead of getting revisions themselves? [21:11:21] then there's no hacks, no edge case worries, and it's clean [21:11:49] jackmcbarn: Maybe [21:11:55] * jackmcbarn will try that [21:16:04] (03PS4) 10Physikerwelt: Fine grained options for wgMathDisableTeXFilter [extensions/Math] - 10https://gerrit.wikimedia.org/r/158845 [21:16:28] (03CR) 10Physikerwelt: Fine grained options for wgMathDisableTeXFilter (032 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/158845 (owner: 10Physikerwelt) [21:17:14] (03CR) 10jenkins-bot: [V: 04-1] Fine grained options for wgMathDisableTeXFilter [extensions/Math] - 10https://gerrit.wikimedia.org/r/158845 (owner: 10Physikerwelt) [21:22:07] (03PS1) 10Physikerwelt: Fix: Missing parent::tearDown() call [extensions/Math] - 10https://gerrit.wikimedia.org/r/160522 [21:24:04] (03CR) 10Physikerwelt: "I'm not even sure why we need this method." [extensions/Math] - 10https://gerrit.wikimedia.org/r/160522 (owner: 10Physikerwelt) [21:24:16] (03PS8) 10EBernhardson: H5: Hide reply and edit links in locked posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158618 (owner: 10Jdlrobson) [21:24:47] Do we still not have a good way to look at less errors on the server? [21:24:52] (03PS2) 10Physikerwelt: Fix: Missing parent::tearDown() call [extensions/Math] - 10https://gerrit.wikimedia.org/r/160522 [21:25:06] marktraceur: mwscript checkLess.php ? [21:26:11] marktraceur: it requires phpunit though, so not sure if that will work in prod or not [21:27:07] (03PS5) 10Physikerwelt: Mathoid role [vagrant] - 10https://gerrit.wikimedia.org/r/156137 [21:33:56] (03PS2) 10EBernhardson: Change close icon to lock/unlock [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159480 (owner: 10Matthias Mullie) [21:33:59] 3MediaWiki extensions / 3Collection: [[Corps]], [[Comet]], [[de:Zweiter Weltkrieg]], [[First-move advantage in chess]], and [[United States]] make the PDF renderer crash - 10https://bugzilla.wikimedia.org/68929#c14 (10C. Scott Ananian) 5PATC>3ASSI The deployment today (2014-09-15) has fixed [[United Stat... [21:34:44] 3Wikimedia / 3Shop: Difference in Currencies being displayed - 10https://bugzilla.wikimedia.org/40925#c2 (10Andre Klapper) (In reply to James Alexander from comment #1) > Thanks Arnav, working on fixing this now. James: You assigned this to yourself in Oct 2012. Are you still working (or still plan to work... [21:34:45] (03PS6) 10Physikerwelt: Mathoid role [vagrant] - 10https://gerrit.wikimedia.org/r/156137 [21:35:01] 3MediaWiki extensions / 3Collection: [[Comet]] makes new PDF renderer crash. - 10https://bugzilla.wikimedia.org/70865 (10C. Scott Ananian) 3NEW p:3Unprio s:3normal a:3None "Exit code 1". [21:35:15] 3MediaWiki extensions / 3Collection: [[Corps]], [[Comet]], [[de:Zweiter Weltkrieg]], [[First-move advantage in chess]], and [[United States]] make the PDF renderer crash - 10https://bugzilla.wikimedia.org/68929 (10C. Scott Ananian) [21:35:18] 3MediaWiki extensions / 3Collection: [[Comet]] makes new PDF renderer crash. - 10https://bugzilla.wikimedia.org/70865 (10C. Scott Ananian) a:3C. Scott Ananian [21:36:46] 3MediaWiki extensions / 3Collection: [[Corps]], [[Comet]], [[de:Zweiter Weltkrieg]], [[First-move advantage in chess]], and [[United States]] make the PDF renderer crash - 10https://bugzilla.wikimedia.org/68929 (10C. Scott Ananian) [21:36:47] 3MediaWiki extensions / 3Collection: [[de:Zweiter Weltkrieg]] makes the new PDF renderer crash - 10https://bugzilla.wikimedia.org/70866 (10C. Scott Ananian) 3NEW p:3Unprio s:3normal a:3None "Exit code 1" [21:36:48] 3MediaWiki extensions / 3Collection: [[de:Zweiter Weltkrieg]] makes the new PDF renderer crash - 10https://bugzilla.wikimedia.org/70866 (10C. Scott Ananian) a:3C. Scott Ananian [21:37:18] bd808: I have a question concerning https://gerrit.wikimedia.org/r/#/c/156137/5/puppet/modules/role/manifests/mathoid.pp... what is git clone supposed to do without any custom arguments? [21:38:15] 3MediaWiki extensions / 3Collection: New PDF renderer: [[en:Integral]] fails. - 10https://bugzilla.wikimedia.org/68835 (10C. Scott Ananian) [21:38:15] 3MediaWiki extensions / 3Collection: [[Corps]], [[Comet]], [[de:Zweiter Weltkrieg]], [[First-move advantage in chess]], and [[United States]] make the PDF renderer crash - 10https://bugzilla.wikimedia.org/68929 (10C. Scott Ananian) [21:38:30] 3MediaWiki extensions / 3Collection: New PDF renderer: [[United States]] fails to render - 10https://bugzilla.wikimedia.org/68854 (10C. Scott Ananian) [21:38:30] 3MediaWiki extensions / 3Collection: [[Corps]], [[Comet]], [[de:Zweiter Weltkrieg]], [[First-move advantage in chess]], and [[United States]] make the PDF renderer crash - 10https://bugzilla.wikimedia.org/68929 (10C. Scott Ananian) [21:38:44] 3MediaWiki extensions / 3Collection: New PDF renderer: [[United States]] fails to render - 10https://bugzilla.wikimedia.org/68854#c6 (10C. Scott Ananian) 5PATC>3RESO/FIX This works with the 2014-09-15 deploy. [21:38:49] ebernhardson: I was hoping to do it for my localwiki, so that's perfect. Thanks! [21:40:47] Hm, but I guess phpunit isn't installed locally. [21:40:49] Womp womp [21:40:56] It seems like we should be able to log errors [21:42:48] (03CR) 10Jackmcbarn: [C: 04-2] "On hold pending resolution of bug #70495, to avoid having to fix it in two places." [core] - 10https://gerrit.wikimedia.org/r/137153 (https://bugzilla.wikimedia.org/5278) (owner: 10Jackmcbarn) [21:47:08] physikerwelt: git::clone in MWV will by default clone https://gerrit.wikimedia.org/r/p/%s.git with %s replaced with the title of the git::clone resource [21:48:42] bd808: so would we want to clone mathoid to /vagrant/mediawiki/services/mathoid ? [21:51:17] physikerwelt: Ah. I'd clone to /vagrant/mathoid I think. [21:51:24] (03CR) 10Cscott: [C: 032] Bug 68929: Use correct 'finish' event instead of 'close' [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160491 (owner: 10GWicke) [21:51:36] I don't remember if that is where it would go by default or not [21:52:11] Apparently the directory param is required [21:52:56] (03Merged) 10jenkins-bot: Bug 68929: Use correct 'finish' event instead of 'close' [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160491 (owner: 10GWicke) [21:56:14] (03CR) 10BryanDavis: [C: 031] "I like it. Does anyone have an objection to merging this?" [core] - 10https://gerrit.wikimedia.org/r/159159 (https://bugzilla.wikimedia.org/70570) (owner: 10Dan-nl) [21:56:35] (03PS3) 10EBernhardson: Hygiene: Delete commented out code [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159972 [21:56:41] (03PS1) 10Hoo man: Make Special:CentralAuth list local accounts in all cases [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/160526 (https://bugzilla.wikimedia.org/53919) [21:57:20] (03PS3) 10EBernhardson: Hygiene: Split off WikiTextString class [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159971 [21:58:02] (03PS2) 10EBernhardson: Hygiene: Move duplicated code to getCleanTextSnippet() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159974 [21:58:37] (03PS3) 10EBernhardson: Hygiene: Move duplicated code to getCleanTextSnippet() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159974 [21:58:45] (03PS2) 10EBernhardson: Hygiene: Use correct phpdoc parameter order [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159975 [22:05:16] bd808: sorry for asking again about this matter would I just use the string /vagrant/mathoid or would it be more common to use a variable for that [22:07:32] physikerwelt: The last time I did it I did a param on the base class and then filled it in from hiera -- https://github.com/wikimedia/mediawiki-vagrant/blob/master/puppet/modules/scholarships/manifests/init.pp#L47-L49 & https://github.com/wikimedia/mediawiki-vagrant/blob/master/puppet/hieradata/common.yaml#L54-L60 [22:09:06] I see vagrant is constantly improving [22:09:19] physikerwelt: It is indeed :) [22:13:00] Hopefully some day modules can be shared between vagrant beta and production [22:13:20] (03CR) 10MaxSem: [C: 032] Mathoid role [vagrant] - 10https://gerrit.wikimedia.org/r/156137 (owner: 10Physikerwelt) [22:13:28] (03Merged) 10jenkins-bot: Mathoid role [vagrant] - 10https://gerrit.wikimedia.org/r/156137 (owner: 10Physikerwelt) [22:14:08] physikerwelt: That's the big goal. We are taking baby steps towards it. There are some things that will be difficult to abstract completely but hiera helps a lot. [22:16:20] (03PS1) 10Foxtrott: Release version 1.0.1 [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/160534 [22:16:54] (03CR) 10Foxtrott: [C: 032 V: 032] Release version 1.0.1 [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/160534 (owner: 10Foxtrott) [22:17:45] 3Wikimedia / 3General/Unknown: Create a proposal review system for IEG and other applications - 10https://bugzilla.wikimedia.org/62170#c5 (10Bryan Davis) p:5Normal>3High a:3Bryan Davis I'm going to be working on this for the next couple of weeks with a goal of getting a working application into product... [22:18:57] (03PS1) 10Catrope: Update OOjs UI to v0.1.0-pre (49b64bdba7) [core] - 10https://gerrit.wikimedia.org/r/160535 [22:20:57] (03PS1) 10EBernhardson: Dont treat argument as wikitext [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160536 [22:22:55] (03CR) 10Jforrester: [C: 032] Update OOjs UI to v0.1.0-pre (49b64bdba7) [core] - 10https://gerrit.wikimedia.org/r/160535 (owner: 10Catrope) [22:28:22] (03PS3) 10EBernhardson: Change close icon to lock/unlock [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159480 (owner: 10Matthias Mullie) [22:28:25] (03PS1) 10EBernhardson: Update WikiFont-Glyphs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160538 [22:28:28] bd808: i'm looking at the operations hhvm manifest and all the settings seem to be in big hash structures. i thought it might make sense to move that into hiera but it would really bloat the yaml file. any thoughts on that? [22:29:19] bloat the yaml! [22:29:25] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (49b64bdba7) [core] - 10https://gerrit.wikimedia.org/r/160535 (owner: 10Catrope) [22:30:03] If it gets out of control we can figure out how to do something cooler to split it up. _joe_ may already be working on that actually for prod. [22:30:30] alrighty [22:30:46] But if we end up with a tunable hhvm install module that would be pretty cool I think [22:31:28] bd808: i agree. having it all in hiera might allow us to tune the labs configs as well, even based on instance size [22:32:08] marxarelli: You will probably want to poke ori about getting wmflib added as a submodule in our puppet code. It's "on his list" :) [22:32:42] I think the prod hhvm module uses it to generate stable files from ruby hashes [22:33:28] oh neato [22:33:40] (03PS2) 10EBernhardson: @root.submitted may not exist in flow_reply_form [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160115 (owner: 10Bsitu) [22:33:45] (03CR) 10EBernhardson: [C: 032] @root.submitted may not exist in flow_reply_form [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160115 (owner: 10Bsitu) [22:34:30] (03Merged) 10jenkins-bot: @root.submitted may not exist in flow_reply_form [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160115 (owner: 10Bsitu) [22:35:12] (03PS1) 10Yurik: Added bit options to FormatJson::decode() [core] - 10https://gerrit.wikimedia.org/r/160541 [22:35:14] bd808: so what are our options for sharing puppet modules? git submodules? :/ [22:35:23] legoktm, ^^ [22:35:51] i'm building on top of that to provide all sorts of json processing :) [22:36:06] marxarelli: yeah that's it for now. I'd be interested in finding a better solution but I'm not sure that prod is ready to do much else. [22:36:24] (03PS9) 10Prtksxna: kss: Add js to hide non current sub-sections [core] - 10https://gerrit.wikimedia.org/r/158856 [22:36:26] (03PS10) 10Prtksxna: kss: Highlight section link based on scroll [core] - 10https://gerrit.wikimedia.org/r/158858 [22:36:28] (03PS1) 10Prtksxna: kss: Fix ToC width [core] - 10https://gerrit.wikimedia.org/r/160542 [22:36:50] bd808: cool. yeah i can't think of a better way [22:37:13] marxarelli: http://librarian-puppet.com/ [22:37:57] (03CR) 10Aaron Schulz: [C: 031] API: generalized submodules for action=paraminfo [core] - 10https://gerrit.wikimedia.org/r/154148 (owner: 10Anomie) [22:38:29] 3MediaWiki / 3User login and signup: Login as another user no longer works - 10https://bugzilla.wikimedia.org/70855#c2 (10Bartosz Dziewoński) Caused by the fix for bug 15484: d0439af89f6b254cea09b3773ab139f04f81a97d. [22:38:31] (03CR) 10Bartosz Dziewoński: "Caused bug 70855." [core] - 10https://gerrit.wikimedia.org/r/148144 (https://bugzilla.wikimedia.org/15484) (owner: 10Parent5446) [22:39:44] 3MediaWiki / 3User login and signup: Login as another user no longer works - 10https://bugzilla.wikimedia.org/70855#c3 (10Bartosz Dziewoński) (If this is fixed, 5dfc57eb80098a2016ed98cbdcca8ee6e1af1c79 should be reverted.) [22:40:42] (03CR) 10Bartosz Dziewoński: [C: 032] Cleanup special:interwiki intro [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/156190 (owner: 10Isarra) [22:40:45] MaxSem, any thoughts - https://gerrit.wikimedia.org/r/#/c/160541/ [22:40:46] (03Merged) 10jenkins-bot: Cleanup special:interwiki intro [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/156190 (owner: 10Isarra) [22:42:00] (03CR) 10EBernhardson: [C: 04-1] "In addition to the comment, this really needs some unit tests to prove magical regular expressions don't break everything in corner cases." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/160541 (owner: 10Yurik) [22:42:26] yurik, tests? [22:42:38] (sorry for being boring:P) [22:42:40] MaxSem, agree, need tests :) [22:42:58] yurikR: in those tests please *try* to break your regular expression, i don't trust it by looking at it [22:43:05] MaxSem, i wanted to get some feedback before spending more time on it [22:43:13] yurikR: i feel like its going to steal some blank text from inside a string or other not-nice side effets [22:43:46] ebernhardson, i agree, might be wrong, i just need a "please go on, this is a good direction" comment :) [22:43:55] otherwise i will do a different method [22:44:09] i would rather have it as part of the jsondecode [22:44:22] once settled on that, will try to break it in every possible way [22:44:23] you could always update the jsonc parser instead ;) [22:44:27] (03PS1) 10Catrope: Update OOjs UI to v0.1.0-pre (49b64bdba7) [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160543 [22:44:31] rrright [22:44:43] yurikR: its really not that bad, and it will work 10x better than throwing regular expressions at a wall [22:44:45] so, ebernhardson, MaxSem, any objections to this approach [22:45:20] mmmm... [22:45:20] yurikR: i have tentative objections, but not enough to -2 :P [22:45:21] i won't do it in jsonc just yet, lets settle on the php side first :) [22:45:32] ebernhardson, -1.5? [22:45:37] ebernhardson, such as? [22:45:54] and yes, once we agree that this is the overall interface, we might dive deeper to jsonc [22:45:59] yurikR: adjusting json with regular expressions just feels wrong [22:46:39] yurikR: and i'm not sure how wrapping results in array's is any better than duplicating the json_last_error() style of functionality [22:46:40] ebernhardson, yes, i understand, but lets decide on the interface/functionality first, and deal with implementation details separatelly [22:46:53] (03PS1) 10Jackmcbarn: Add TitleExists hook [core] - 10https://gerrit.wikimedia.org/r/160546 (https://bugzilla.wikimedia.org/70495) [22:47:29] yurikR: if anything, a better way forward if you want guarantees would be a new method that returns a Status object? [22:47:30] bd808: oh interesting. that could really work well on the vagrant side if we integrate it into the provisioner [22:47:37] (03PS1) 10MaxSem: Deprecate HTMLFileCache::newFromTitle() in favor of constructor [core] - 10https://gerrit.wikimedia.org/r/160547 [22:47:58] (03PS1) 10Jackmcbarn: Call Title::exists() instead of checking the ID [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/160549 (https://bugzilla.wikimedia.org/70495) [22:48:40] (03PS1) 10Jackmcbarn: Call Title::exists() instead of checking the ID [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/160550 (https://bugzilla.wikimedia.org/70495) [22:48:49] marxarelli: Yeah. And we can use it as long as things are broken out into separate git repos as would be needed for submodules. [22:50:01] marxarelli: I use https://boxen.github.com/ to configure my laptop and it makes very heavy use of puppet-librarian [22:50:52] (03PS1) 10Prtksxna: buttons.less: Add multiple between buttons [core] - 10https://gerrit.wikimedia.org/r/160551 [22:52:41] bd808: wtf, that's killer! [22:52:46] 3MediaWiki / 3User login and signup: Login as another user no longer works - 10https://bugzilla.wikimedia.org/70855#c4 (10Tyler Romeo) The issue fixed by the bug is pretty important, so simply reverting the patch will not actually solve anything. IMO, the bug described (switching between accounts) should re... [22:52:56] (03PS2) 10MaxSem: Deprecate HTMLFileCache::newFromTitle() in favor of constructor [core] - 10https://gerrit.wikimedia.org/r/160547 [22:52:59] (03PS1) 10GWicke: Fix unreliable image streaming [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160552 [22:53:46] marxarelli: https://github.com/bd808/my-boxen [22:54:38] my commit history there tails off 7 months ago. I kind of lost my initial excitement in tracking every little change that way [22:55:00] I'll probably get excited again the next time I reimage my home laptop [22:57:01] (03CR) 10Violetto: "The previous state where the buttons were either sitting next to each other or stuck to each other vertically, depending on your screen si" [core] - 10https://gerrit.wikimedia.org/r/160551 (owner: 10Prtksxna) [22:58:34] ebernhardson, thx, didn't know about json_last_error / message. It would be good to wrap them with the proper i18n messages, except that i don't think the last_message is localized, so it would be int->i18n only [22:58:46] Status wrapper sounds like agood idea [22:59:15] 3MediaWiki extensions / 3CentralAuth: GlobalRename: check with global AntiSpoof and warn about possible collisions - 10https://bugzilla.wikimedia.org/70380 (10MF-Warburg) [22:59:15] 3Wikimedia / 3General/Unknown: Steward, global sysop and SWMT tasks bugs (tracking) - 10https://bugzilla.wikimedia.org/41492 (10MF-Warburg) [22:59:55] bd808: cool. well, i'm guessing ori_ might not want to deal with moving hhvm to a submodule atm. maybe i'll just mod the mwv manifest for now [23:00:53] marxarelli: Yeah. I think the opsen are not convinced that submodules are worth the change to workflow on their end in puppet. [23:00:56] at least it'll be closer to prod, and easier to replace with a shared module down the road [23:01:17] but wmflib should be relatively non-controversial I'd hope [23:07:38] (03PS1) 10Catrope: Update VisualEditor for cherry-picks of If67fe35b and I80d0632fd [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160554 [23:08:00] yurikR: i probably only know because i spent a few days shoe-horning jsonc into hhvm so we could use it(they were using the non-free json decoder, and still do by default) [23:08:13] yurikR: good luck :) [23:08:28] ebernhardson, no worries :) i'm adding json decode error messages to i18n now [23:08:53] will be something like mixed parse( $value, &$status, $options = 0 ) [23:09:02] ebernhardson, MaxSem ^ [23:11:28] (03CR) 10MaxSem: [C: 032] Update VisualEditor for cherry-picks of If67fe35b and I80d0632fd [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160554 (owner: 10Catrope) [23:11:38] (03PS1) 10Jackmcbarn: Hook TitleExists when previewing [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/160555 (https://bugzilla.wikimedia.org/70495) [23:11:40] (03CR) 10MaxSem: [V: 032] Update VisualEditor for cherry-picks of If67fe35b and I80d0632fd [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160554 (owner: 10Catrope) [23:13:29] 3MediaWiki / 3User login and signup: Login as another user no longer works - 10https://bugzilla.wikimedia.org/70855#c5 (10Bartosz Dziewoński) Indeed, but it should be easy enough to show the form instead of redirecting when the user is logged in and there's no 'returnto' parameter. [23:13:59] 3MediaWiki extensions / 3TemplateSandbox: TemplateSandbox doesn't handle things like #ifexist and Scribunto's getContent - 10https://bugzilla.wikimedia.org/70495#c6 (10Jackmcbarn) The exists problem and the getContent problem turn out to have totally separate fixes. The above 4 patches fix the exists problem... [23:17:29] yurikR: personally, i would prefer it to return the status object, rather than take a reference [23:17:45] ebernhardson, what sig are you thinking about ? [23:18:07] yurikR: Status parse( $value, $options = 0 ) [23:18:12] decode() followed by getDecodeError() ? [23:18:33] ebernhardson, and where does the decoded value go? [23:18:39] yurikR: $status->getValue() [23:19:05] oh [23:19:07] hmm [23:19:08] ok [23:19:55] yurikR: basically you either return Status::newGood( $value ); or you return Status::newFatal( $i18nKey, $param1, $param2 ... ); thats how I would do it at least [23:20:04] yep, got it [23:20:09] didn't know status had a ok value [23:20:12] thx [23:20:22] np [23:21:30] (03CR) 10MaxSem: [C: 032] Update OOjs UI to v0.1.0-pre (073f37e258) [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160488 (owner: 10Catrope) [23:21:45] (03CR) 10MaxSem: [C: 032] Update OOjs UI to v0.1.0-pre (49b64bdba7) [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160543 (owner: 10Catrope) [23:25:21] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (073f37e258) [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160488 (owner: 10Catrope) [23:29:53] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (49b64bdba7) [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160543 (owner: 10Catrope) [23:36:55] (03PS1) 10Prtksxna: kss: Add syntax highlighting [core] - 10https://gerrit.wikimedia.org/r/160558 [23:39:47] [13node-cssjanus] 15Krinkle pushed 1 new commit to 06master: 02http://git.io/j4CnkA [23:39:47] 13node-cssjanus/06master 14f6f5010 15Timo Tijhof: build: Send Travis notifications to #wikimedia-dev [23:44:49] (03CR) 10Tim Starling: "> Does the glibc implementation run one SIGEV_THREAD handler at a time, or does it start a new thread for each event and the resulting thr" [php/luasandbox] - 10https://gerrit.wikimedia.org/r/159822 (owner: 10Anomie) [23:47:07] (03CR) 10Subramanya Sastry: "https://gerrit.wikimedia.org/r/#/c/155348/ now deployed." [core] - 10https://gerrit.wikimedia.org/r/152775 (owner: 10Subramanya Sastry) [23:48:19] (03CR) 10Tim Starling: Dynamically allocate luasandbox_timer instances (031 comment) [php/luasandbox] - 10https://gerrit.wikimedia.org/r/159822 (owner: 10Anomie) [23:48:30] (03PS2) 10Prtksxna: buttons.less: Add multiple
s between buttons [core] - 10https://gerrit.wikimedia.org/r/160551 [23:54:17] (03PS2) 10Yurik: Added FormatJson::parse( $value, $options = 0 ) returning Status [core] - 10https://gerrit.wikimedia.org/r/160541 [23:55:24] (03PS1) 10MaxSem: Add a hook to allow extensions to prevent HTML file caching [core] - 10https://gerrit.wikimedia.org/r/160563 (https://bugzilla.wikimedia.org/68106)