[00:29:41] (03PS2) 10Alex Monk: ResourceLoaderWikiModule: Check content format instead of content model [core] - 10https://gerrit.wikimedia.org/r/160251 (owner: 10Legoktm) [00:30:26] (03CR) 10Alex Monk: [C: 032] "PS2: Just added a missing space" [core] - 10https://gerrit.wikimedia.org/r/160251 (owner: 10Legoktm) [00:36:51] Krenair: yay. Did you look at the necessary Gadgets changes too? [00:37:02] (03Merged) 10jenkins-bot: ResourceLoaderWikiModule: Check content format instead of content model [core] - 10https://gerrit.wikimedia.org/r/160251 (owner: 10Legoktm) [00:37:19] Was just waiting for the merge, while reading the #freenode log [00:37:35] will look [00:38:55] (03PS2) 10Alex Monk: Re-add TitleIsCssOrJsPage hook, still necessary for a few things [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160253 (owner: 10Legoktm) [00:45:30] (03PS3) 10Alex Monk: Set GadgetDefinitionContentHandler::getContentClass() [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160245 (owner: 10Legoktm) [00:45:46] (03CR) 10Alex Monk: [C: 032] Set GadgetDefinitionContentHandler::getContentClass() [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160245 (owner: 10Legoktm) [00:45:53] (03Merged) 10jenkins-bot: Set GadgetDefinitionContentHandler::getContentClass() [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160245 (owner: 10Legoktm) [00:48:16] legoktm, https://gerrit.wikimedia.org/r/#/c/160253/2/Gadgets.hooks.php - why can't we just alter that method to look at the content format? [00:48:47] would break things? [00:55:13] Krenair: content format is depenent upon content model [00:55:21] and we can't check contentmodel there due to recursion issues [00:55:35] oh [00:55:40] do you mean Title::isCssOrJsPage? [00:57:25] yes [00:58:12] we could probably do that. [00:58:39] would require some more work since I don't think LinkCache stores the content format... [01:00:58] really we should just get rid of that function because with $wgContentHandlerUseDB content models can be used on any title [01:01:31] bbl [01:04:36] (03CR) 10Alex Monk: "This was fun to unbreak. See I8b31084e, I64e86c74, I7cc6d17c and I2610f754" [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153535 (https://bugzilla.wikimedia.org/69318) (owner: 10Legoktm) [01:12:53] (03CR) 10Alex Monk: [C: 032] Gadget::__construct: Add type hint, improve tests [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160200 (owner: 10Legoktm) [01:12:59] (03Merged) 10jenkins-bot: Gadget::__construct: Add type hint, improve tests [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160200 (owner: 10Legoktm) [02:08:14] 3MediaWiki extensions / 3ProofreadPage: Add Index namespace to $wgNamespacesToBeSearchedDefault by default - 10https://bugzilla.wikimedia.org/52708#c1 (10George Orwell III) Never mind that I would not have agreed with adding those namespaces to the default search-set in the first place but hasn't this reques... [02:49:59] 3MediaWiki extensions / 3ProofreadPage: phpunit: SKIPPED: djvu binaries do not exist or are not executable - 10https://bugzilla.wikimedia.org/68638#c3 (10George Orwell III) (In reply to Nemo from comment #1) > $ ddjvu --help > DDJVU --- DjVuLibre-3.5.25 > DjVu decompression utility > $ djvudump > DJVUDUMP --... [03:45:56] (03PS2) 10Ori.livneh: Remove usage of spinner.gif [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/159370 (https://bugzilla.wikimedia.org/70615) (owner: 10Bartosz Dziewoński) [04:01:03] (03PS1) 10Foxtrott: Load MW's shared.css; add styling for img, links, lists [skins/chameleon] - 10https://gerrit.wikimedia.org/r/160255 (https://bugzilla.wikimedia.org/70808) [04:01:05] (03CR) 10jenkins-bot: [V: 04-1] Load MW's shared.css; add styling for img, links, lists [skins/chameleon] - 10https://gerrit.wikimedia.org/r/160255 (https://bugzilla.wikimedia.org/70808) (owner: 10Foxtrott) [04:01:38] (03PS2) 10Foxtrott: Load MW's shared.css; add styling for img, links, lists [skins/chameleon] - 10https://gerrit.wikimedia.org/r/160255 (https://bugzilla.wikimedia.org/70808) [04:12:46] 3MediaWiki / 3General/Unknown: Category pages should expose the timestamp sort option - 10https://bugzilla.wikimedia.org/70819 (10Gryllida) 3NEW p:3Unprio s:3normal a:3None str: 1) visit https://en.wikipedia.org/w/api.php?action=query&list=categorymembers&cmtitle=Category%3APages%20with%20script%20er... [04:16:30] (03PS3) 10Foxtrott: Load MW's shared.css; add styling for img, links, lists [skins/chameleon] - 10https://gerrit.wikimedia.org/r/160255 (https://bugzilla.wikimedia.org/70808) [04:16:32] (03CR) 10jenkins-bot: [V: 04-1] Load MW's shared.css; add styling for img, links, lists [skins/chameleon] - 10https://gerrit.wikimedia.org/r/160255 (https://bugzilla.wikimedia.org/70808) (owner: 10Foxtrott) [04:17:05] (03PS4) 10Foxtrott: Load MW's shared.css; add styling for img, links, lists [skins/chameleon] - 10https://gerrit.wikimedia.org/r/160255 (https://bugzilla.wikimedia.org/70808) [04:19:55] (03CR) 10Foxtrott: [C: 032 V: 032] Load MW's shared.css; add styling for img, links, lists [skins/chameleon] - 10https://gerrit.wikimedia.org/r/160255 (https://bugzilla.wikimedia.org/70808) (owner: 10Foxtrott) [04:21:14] 3MediaWiki skins / 3Chameleon: Standard table styles are missing (using 1.24 alpha) - 10https://bugzilla.wikimedia.org/70808#c4 (10s7eph4n) 5PATC>3RESO/FIX Imported MW's shared styles, including styles for the wikitable class. [05:28:48] (03PS3) 10EBernhardson: Hygiene: Various small cleanups [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160191 [05:28:51] (03PS1) 10EBernhardson: Hygiene: Autogenerate wgAutoloadClasses code from Makefile [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160258 [05:28:54] (03PS1) 10EBernhardson: Hygiene: Remove duplication passing user data around [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160259 [05:28:57] (03PS1) 10EBernhardson: Hygiene: Restructure Flow\\Data namepace for clarity [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160260 [05:29:52] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove duplication passing user data around [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160259 (owner: 10EBernhardson) [05:29:56] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Restructure Flow\\Data namepace for clarity [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160260 (owner: 10EBernhardson) [05:44:38] (03PS2) 10EBernhardson: Hygiene: Remove duplication passing user data around [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160259 [05:44:41] (03PS2) 10EBernhardson: Hygiene: Restructure Flow\\Data namepace for clarity [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160260 [05:45:20] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Restructure Flow\\Data namepace for clarity [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160260 (owner: 10EBernhardson) [05:57:30] 3MediaWiki extensions / 3ProofreadPage: Add Index namespace to $wgNamespacesToBeSearchedDefault by default - 10https://bugzilla.wikimedia.org/52708#c2 (10Nemo) (In reply to George Orwell III from comment #1) > hasn't this request been made moot > in the interim by the removal of search options from User pref... [06:10:49] (03CR) 10Legoktm: [C: 032] i18n: fix typo [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/160206 (owner: 10Shirayuki) [06:10:51] (03PS3) 10EBernhardson: Hygiene: Restructure Flow\\Data namepace for clarity [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160260 [06:10:54] (03Merged) 10jenkins-bot: i18n: fix typo [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/160206 (owner: 10Shirayuki) [06:33:14] 3MediaWiki extensions / 3ProofreadPage: Add Index namespace to $wgNamespacesToBeSearchedDefault by default - 10https://bugzilla.wikimedia.org/52708#c3 (10George Orwell III) If you say so.... I still don't believe forcing those one or two WS specific namespaces into the default search set - if there still is... [06:43:29] 3MediaWiki extensions / 3ProofreadPage: phpunit: SKIPPED: djvu binaries do not exist or are not executable - 10https://bugzilla.wikimedia.org/68638#c4 (10Nemo) (In reply to George Orwell III from comment #3) > Note: on typical local x86 install, this .dtd file is indeed present but > installed in the wrong f... [06:51:29] 3MediaWiki extensions / 3ProofreadPage: Add Index namespace to $wgNamespacesToBeSearchedDefault by default - 10https://bugzilla.wikimedia.org/52708#c4 (10Nemo) (In reply to George Orwell III from comment #3) > The new tick box ' Remember selection for future > searches ' allows Users to decide what & when to... [06:57:31] 3MediaWiki skins / 3Chameleon: Bullet point styles/icon and category items are displayed as rectangle - 10https://bugzilla.wikimedia.org/70822 (10MWJames) 3NEW p:3Unprio s:3normal a:3s7eph4n Bullet points and category items are displayed using a rectangle icon [0]. Using: - MediaWiki 1.24alpha (cdfa... [07:07:59] 3MediaWiki extensions / 3ProofreadPage: Add Index namespace to $wgNamespacesToBeSearchedDefault by default - 10https://bugzilla.wikimedia.org/52708#c5 (10George Orwell III) I beg to disagree - Speaking only from an en.WS point of view, I don't believe established Users search for and/or find anything useful... [07:08:20] (03PS1) 10Legoktm: Re-add syntax highlighting to Gadget namespace pages [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160268 [07:09:31] 3MediaWiki skins / 3Chameleon: Fieldset style is incomplete - 10https://bugzilla.wikimedia.org/70823 (10MWJames) 3NEW p:3Unprio s:3normal a:3s7eph4n Fieldset style is incomplete [0]. Using: - MediaWiki 1.24alpha (cdfa366) - Updating mediawiki/chameleon-skin dev-master (0099a1c => 80ff438) Checkin... [07:14:59] 3MediaWiki extensions / 3ProofreadPage: Add Index namespace to $wgNamespacesToBeSearchedDefault by default - 10https://bugzilla.wikimedia.org/52708#c6 (10Nemo) (In reply to George Orwell III from comment #5) > Speaking only from an en.WS point of view, I don't believe established Users > search for and/or fi... [07:21:14] 3MediaWiki extensions / 3ProofreadPage: phpunit: SKIPPED: djvu binaries do not exist or are not executable - 10https://bugzilla.wikimedia.org/68638#c5 (10George Orwell III) (In reply to Nemo from comment #4) > Ah. Should/can it be made so that it works out of the box? > If not, I guess this bug should be fix... [08:03:24] (03CR) 10Mvolz: [C: 032] "Ok, plan of action:" [services/citoid] - 10https://gerrit.wikimedia.org/r/157507 (owner: 10Danmichaelo) [08:04:15] (03CR) 10Mvolz: [V: 032] "Ok, plan of action:" [services/citoid] - 10https://gerrit.wikimedia.org/r/157507 (owner: 10Danmichaelo) [08:31:18] 3Wikimedia / 3General/Unknown: Install Q&A system at ask.wikimedia.org - 10https://bugzilla.wikimedia.org/29923#c17 (10Nemo) (In reply to Quim Gil from comment #16) > Is a Q&A system something that has been > discussed? Only a few hundreds times. :-P If you mean within WMF, you can read Erik's https://lists... [08:47:15] 3MediaWiki extensions / 3Gadgets: Implement Gadgets 2.0 (tracking) - 10https://bugzilla.wikimedia.org/29272 (10Kunal Mehta (Legoktm)) [08:47:17] 3MediaWiki extensions / 3Gadgets: 2.0 Figure out how gadget naming collisions should work, and document it - 10https://bugzilla.wikimedia.org/70824 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None From https://www.mediawiki.org/wiki/ResourceLoader/V2_Task_management: (RK) Figure out how ga... [08:47:29] 3MediaWiki extensions / 3Gadgets: 2.0: Split "gadgets-edit" user right into "gadgets-edit-css" and "gadgets-edit-js" - 10https://bugzilla.wikimedia.org/69911 (10Kunal Mehta (Legoktm)) p:5Unprio>3Low [08:54:07] (03PS1) 10Legoktm: Add missing @covers tag [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160269 [08:54:20] (03CR) 10Legoktm: [C: 032] Add missing @covers tag [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160269 (owner: 10Legoktm) [08:54:26] (03Merged) 10jenkins-bot: Add missing @covers tag [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160269 (owner: 10Legoktm) [09:26:15] 3MediaWiki / 3General/Unknown: Category pages should expose the timestamp sort option - 10https://bugzilla.wikimedia.org/70819#c1 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc [The ticket does not describe a bug but a request for additional functionality. Hence setting priority to "enhancement".] [09:28:44] 3MediaWiki / 3API: MW 1.19.13 with PHP 5.2 breaks ApiFormatBase.php (due to using anonymous function introduced in PHP 5.3.0) - 10https://bugzilla.wikimedia.org/63049#c9 (10Nemo) Found on several wikis (via mutante's wikistats, bug 44145): Parse error: syntax error, unexpected T_FUNCTION in /home... [09:33:44] 3MediaWiki / 3General/Unknown: Category pages should expose the timestamp sort option - 10https://bugzilla.wikimedia.org/70819#c2 (10Nemo) Sounds like a WONTFIX, this is what CategoryTree or DynamicPageList are for. Maybe move in the component of either, to offer an in-category interface as well? [09:43:13] (03PS1) 10Legoktm: migrateGadgets: Use WikiPage::doEditContent() [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160270 [09:44:10] (03PS2) 10Rohan013: Fix Special:Listusers i18n issues [core] - 10https://gerrit.wikimedia.org/r/150201 (https://bugzilla.wikimedia.org/39845) [10:25:32] 3MediaWiki-Vagrant: "vagrant up" fails with "The SSH command responded with a non-zero exit status." - 10https://bugzilla.wikimedia.org/70705 (10Željko Filipin) 3NEW p:3Unprio s:3normal a:3None I am following quick start instructions[1] on a Mac. 1: https://www.mediawiki.org/wiki/MediaWiki-Vagrant#Qui... [10:43:45] 3MediaWiki extensions / 3Extensions requests: Annotation tool that uses Wikidata concepts to annotate statements from books - 10https://bugzilla.wikimedia.org/57812#c18 (10apsdehal) Sorry for the delay. Give me a day or two, wrap up post would be there. I had put a mail on Wikidata long time ago about the co... [11:11:59] 3MediaWiki extensions / 3Gadgets: Gadgets 2.0: "hidden" doesn't work - 10https://bugzilla.wikimedia.org/39025#c1 (10Kunal Mehta (Legoktm)) 5UNCO>3NEW Confirming that this bug is still present. [11:14:09] (03CR) 10Legoktm: [C: 032] Allow preloadparams for Special:MyPage [core] - 10https://gerrit.wikimedia.org/r/158943 (owner: 10Umherirrender) [11:14:18] (03PS1) 10Rohan013: Supress email validation on cancellation in SpecialChangeEmail [core] - 10https://gerrit.wikimedia.org/r/160279 (https://bugzilla.wikimedia.org/70676) [11:14:34] Suppress [11:14:41] (03CR) 10Legoktm: [C: 032] Use local var in Action::setHeaders [core] - 10https://gerrit.wikimedia.org/r/159358 (owner: 10Umherirrender) [11:20:19] (03CR) 10Legoktm: [C: 032] Make MySQLi work with non-standard socket [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/160212 (https://bugzilla.wikimedia.org/65998) (owner: 10Martineznovo) [11:21:07] (03Merged) 10jenkins-bot: Allow preloadparams for Special:MyPage [core] - 10https://gerrit.wikimedia.org/r/158943 (owner: 10Umherirrender) [11:21:34] (03Merged) 10jenkins-bot: Use local var in Action::setHeaders [core] - 10https://gerrit.wikimedia.org/r/159358 (owner: 10Umherirrender) [11:22:44] 3MediaWiki / 3Database: mysqli: No way to specify the socket location - 10https://bugzilla.wikimedia.org/65998 (10Kunal Mehta (Legoktm)) [11:24:54] (03CR) 10Legoktm: [C: 032] "Ok, your follow up patches make it clearer, thanks." [core] - 10https://gerrit.wikimedia.org/r/154092 (owner: 10Anomie) [11:24:57] (03Merged) 10jenkins-bot: Make MySQLi work with non-standard socket [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/160212 (https://bugzilla.wikimedia.org/65998) (owner: 10Martineznovo) [11:29:27] (03CR) 10Legoktm: [C: 031] jquery.confirmable: Add a space between buttons [core] - 10https://gerrit.wikimedia.org/r/160067 (owner: 10Bartosz Dziewoński) [11:31:55] (03Merged) 10jenkins-bot: API: Add rawcontinue parameter to action=query [core] - 10https://gerrit.wikimedia.org/r/154092 (owner: 10Anomie) [11:37:15] (03CR) 10Legoktm: "If we had introduced rollback today, I think this would be a reasonable feature...but we're not. I think a lot of people would be upset th" [core] - 10https://gerrit.wikimedia.org/r/90729 (owner: 10Bartosz Dziewoński) [11:47:33] (03CR) 10Calak: [C: 031] jquery.confirmable: Add a space between buttons [core] - 10https://gerrit.wikimedia.org/r/160067 (owner: 10Bartosz Dziewoński) [11:51:57] legoktm: you could still introduce some preference for that rollback thing, no? I know many users who use .js in order to achieve some kond of 2-click-rollback, esp. those using touchscreen devices [11:52:09] *kind [11:52:21] really? [11:52:42] and yeah, we could probably add a preference... [11:52:54] I personally would enable such a preference for me if it was present [11:53:01] 3MediaWiki / 3JobRunner: hhvm jobrunner TCP socket failure error 24 too many open files - 10https://bugzilla.wikimedia.org/70825 (10Sean Pringle) 3NEW p:3Unprio s:3minor a:3None Noticed noise from mw1053 in dberror.log: Sun Sep 14 10:07:21 UTC 2014 mw1053 zhwiki Error connecting to 10.64.16.34:... [11:53:26] hmm, ok [11:53:33] (03CR) 10Martineznovo: "I think this should have a bug number assigned, to discuss this change. Not everyone have a gerrit account, and gerrit is not a good place" [core] - 10https://gerrit.wikimedia.org/r/90729 (owner: 10Bartosz Dziewoński) [11:54:47] (03CR) 10Legoktm: "I take back parts of what I said. As long as this has some kind of opt-out (user preference/JS override), I think it should be fine." [core] - 10https://gerrit.wikimedia.org/r/90729 (owner: 10Bartosz Dziewoński) [12:06:47] 3MediaWiki extensions / 3Translate: translatewiki.net so locked down I can't communicate with anyone there - 10https://bugzilla.wikimedia.org/70612#c7 (10sminthopsis84) Sorry, I misunderstood. I had thought that whoever created the account for me was working behind the scenes and thought I should proceed. Cl... [12:09:44] 3MediaWiki extensions / 3Translate: translatewiki.net so locked down I can't communicate with anyone there - 10https://bugzilla.wikimedia.org/70612#c8 (10Nemo) (In reply to sminthopsis84 from comment #7) > Sorry, I misunderstood. No problem. > I had thought that whoever created the account for > me was wo... [12:12:30] (03CR) 10Legoktm: [C: 032] Move footer icons to assets/ directory [core] - 10https://gerrit.wikimedia.org/r/158650 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [12:14:03] (03CR) 10Legoktm: [C: 032] Use .feedlink class rather than feed-icon.png file [extensions/WikiArticleFeeds] - 10https://gerrit.wikimedia.org/r/159373 (https://bugzilla.wikimedia.org/70615) (owner: 10Bartosz Dziewoński) [12:14:09] (03Merged) 10jenkins-bot: Use .feedlink class rather than feed-icon.png file [extensions/WikiArticleFeeds] - 10https://gerrit.wikimedia.org/r/159373 (https://bugzilla.wikimedia.org/70615) (owner: 10Bartosz Dziewoński) [12:19:12] (03Merged) 10jenkins-bot: Move footer icons to assets/ directory [core] - 10https://gerrit.wikimedia.org/r/158650 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [12:52:28] (03PS13) 10Florianschmidtwelzow: Show Captcha after click on edit over buttons on EditPage [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/136323 (https://bugzilla.wikimedia.org/19648) [13:44:13] (03PS1) 10Florianschmidtwelzow: Remove padding from Textbox [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/160282 (https://bugzilla.wikimedia.org/70194) [13:50:30] (03CR) 10Bartosz Dziewoński: "The dependency has been merged." [extensions/PerPageLicense] - 10https://gerrit.wikimedia.org/r/159372 (https://bugzilla.wikimedia.org/70615) (owner: 10Bartosz Dziewoński) [13:50:59] 3MediaWiki / 3JavaScript: [mediawiki.feedback.js] Add checkbox to submit user-agent info - 10https://bugzilla.wikimedia.org/41291#c10 (10Nemo) (In reply to James Forrester from comment #9) > When you post on a talk page you write every byte that gets inserted Definitely not, > (except > for ==s for new se... [13:54:44] 3MediaWiki / 3JavaScript: [mediawiki.feedback.js] Add checkbox to submit user-agent info - 10https://bugzilla.wikimedia.org/41291#c11 (10Jesús Martínez Novo (Ciencia Al Poder)) (In reply to James Forrester from comment #9) > When you post on a talk page you write every byte that gets inserted (except > for =... [13:55:10] (03CR) 10leucosticte: [C: 031] Update path to license footer icons for MW 1.24 [extensions/PerPageLicense] - 10https://gerrit.wikimedia.org/r/159372 (https://bugzilla.wikimedia.org/70615) (owner: 10Bartosz Dziewoński) [14:23:29] 3Wikimedia / 3General/Unknown: A proper catalog of extensions - 10https://bugzilla.wikimedia.org/46704#c43 (10Mark A. Hershberger) http://hexmode.com/2014/09/summer-of-code/ -- post on my blog. [14:28:31] 3MediaWiki / 3History/Diffs: "Wikimedia Error" after completely history merging a page - 10https://bugzilla.wikimedia.org/70827 (10zhuyifei1999) 3NEW p:3Unprio s:3critic a:3None 1. Module:Sandbox history splitted through delete & undelete. 2. Merged full history of Module:Sandbox to Module:Pagebanner... [14:32:44] 3MediaWiki / 3History/Diffs: Fatal "Wikimedia Foundation Error" after completely history merging a page - 10https://bugzilla.wikimedia.org/70827 (10zhuyifei1999) [14:33:18] !e GeoCrumbs [14:33:18] https://www.mediawiki.org/wiki/Extension:GeoCrumbs [14:42:23] (03PS1) 10Jack Phoenix: Removed old i18n support, replaced $dir with __DIR__ [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/160285 [14:42:46] (03CR) 10Jack Phoenix: [C: 032] Removed old i18n support, replaced $dir with __DIR__ [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/160285 (owner: 10Jack Phoenix) [14:42:50] (03Merged) 10jenkins-bot: Removed old i18n support, replaced $dir with __DIR__ [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/160285 (owner: 10Jack Phoenix) [14:44:29] 3MediaWiki extensions / 3GeoCrumbs: [1.24wmf20] Fatal error: Call to a member function getProperty() on a non-object, after completely history merging a page - 10https://bugzilla.wikimedia.org/70827#c1 (10Jesús Martínez Novo (Ciencia Al Poder)) p:5Unprio>3High The error message is: PHP fatal error in /s... [14:47:19] (03PS2) 10AndyRussG: RecentActivityFeed changes needed [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/153421 (owner: 10Nischayn22) [14:48:07] (03CR) 10AndyRussG: "Rebased" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/153421 (owner: 10Nischayn22) [14:57:42] Hi. I'm unable to install gerrit.... git_review.cmd.CannotInstallHook: Problems encountered installing commit-msg hook [14:58:02] I'm trying to run 'git review -s' [15:01:33] 3Wikimedia / 3Site requests: Change $wgAbuseFilterAnonBlockDuration to 3 months on mediawikiwiki - 10https://bugzilla.wikimedia.org/70828 (10Jackmcbarn) 3NEW p:3Unprio s:3normal a:3None Request made over 3 weeks ago with no dissenting opinions. https://www.mediawiki.org/w/index.php?oldid=1129235 [16:02:12] andre__: there and time to answer a question regarding bugzilla->phab and accounts? [16:05:55] se4598, kind of [16:05:58] https://phabricator.wikimedia.org/T419 ? [16:08:41] hi se4598 :) [16:09:37] andre__: thanks. There isn't a problem because I have 2 Bugzilla accounts? Will I be able to claim them via the different mail adresses? [16:09:41] hi hoo [16:10:10] se4598: you should be able to claim and merge them in Phab, yes [16:10:25] (merging could also be done in Bugzilla but needs to be done by admins) [16:13:21] nah, if it is able to claim multiple in phab then, I don't need a merge, otherwise that's why I ask [16:13:23] :) [16:15:35] Wikimedia Foundation [16:15:39] That's wrong. [16:16:08] :P [16:16:11] which wiki is that? [16:16:40] I clicked andre__'s link [16:20:00] Nemo_bis: file a bug^H^H^Hmaniphest? [16:20:55] * Nemo_bis shrugs [16:26:55] what's specifically wrong? [16:27:22] URL? name? rel? [16:39:31] 3MediaWiki extensions / 3GeoCrumbs: [1.24wmf20] Fatal error: Call to a member function getProperty() on a non-object, after completely history merging a page - 10https://bugzilla.wikimedia.org/70827 (10Jesús Martínez Novo (Ciencia Al Poder)) [16:39:32] 3Wikimedia / 3General/Unknown: Next wmf deployment (tracking) - 10https://bugzilla.wikimedia.org/38865 (10Jesús Martínez Novo (Ciencia Al Poder)) [17:14:19] (03CR) 10Danmichaelo: "Thanks. I guess one alternative solution could be to have Citoid take a language request parameter and format dates according to that lang" [services/citoid] - 10https://gerrit.wikimedia.org/r/157507 (owner: 10Danmichaelo) [17:14:53] (03CR) 10Danmichaelo: "https://en.wikipedia.org/wiki/Module_talk:Citation/CS1#Support_ISO_8601_dates" [services/citoid] - 10https://gerrit.wikimedia.org/r/157507 (owner: 10Danmichaelo) [17:16:48] 3MediaWiki extensions / 3CentralNotice: CentralNotice banner paging needs to be aware of banner filtering - 10https://bugzilla.wikimedia.org/39212 (10Peter Coombe) 5PATC>3RESO/FIX [17:16:48] 3MediaWiki extensions / 3CentralNotice: CentralNotice filter produces useless URLs - 10https://bugzilla.wikimedia.org/53753 (10Peter Coombe) 5PATC>3RESO/FIX [17:17:17] (03CR) 10Alex Monk: [C: 032] "Urgh, yes. This has been annoying me for a while. Thanks Florian." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/160282 (https://bugzilla.wikimedia.org/70194) (owner: 10Florianschmidtwelzow) [17:17:19] (03Merged) 10jenkins-bot: Remove padding from Textbox [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/160282 (https://bugzilla.wikimedia.org/70194) (owner: 10Florianschmidtwelzow) [17:17:29] (03CR) 10Mvolz: "Ack, I was just about to post that I think we've been hand-wringing for nothing. They do seem to accept ISO, just not with the time stamp." [services/citoid] - 10https://gerrit.wikimedia.org/r/157507 (owner: 10Danmichaelo) [17:19:50] (03CR) 10Florianschmidtwelzow: "Great, thx Alex :)" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/160282 (https://bugzilla.wikimedia.org/70194) (owner: 10Florianschmidtwelzow) [17:38:37] (03PS1) 10Foxtrott: Improve styleability of RecentChanges form [core] - 10https://gerrit.wikimedia.org/r/160288 [17:50:14] (03CR) 10Danmichaelo: "Lol, silly to not actually test it first.. Oh well, problem solved then :)" [services/citoid] - 10https://gerrit.wikimedia.org/r/157507 (owner: 10Danmichaelo) [18:21:07] (03PS1) 10Foxtrott: Fix styling for Special:RecentChanges [skins/chameleon] - 10https://gerrit.wikimedia.org/r/160290 (https://bugzilla.wikimedia.org/70823) [18:21:09] (03CR) 10jenkins-bot: [V: 04-1] Fix styling for Special:RecentChanges [skins/chameleon] - 10https://gerrit.wikimedia.org/r/160290 (https://bugzilla.wikimedia.org/70823) (owner: 10Foxtrott) [18:21:38] (03PS2) 10Foxtrott: Fix styling for Special:RecentChanges [skins/chameleon] - 10https://gerrit.wikimedia.org/r/160290 (https://bugzilla.wikimedia.org/70823) [18:23:07] (03PS3) 10Foxtrott: Fix styling for Special:RecentChanges [skins/chameleon] - 10https://gerrit.wikimedia.org/r/160290 (https://bugzilla.wikimedia.org/70823) [18:23:34] (03CR) 10Foxtrott: [C: 032 V: 032] Fix styling for Special:RecentChanges [skins/chameleon] - 10https://gerrit.wikimedia.org/r/160290 (https://bugzilla.wikimedia.org/70823) (owner: 10Foxtrott) [18:24:45] 3MediaWiki skins / 3Chameleon: Fieldset style is incomplete - 10https://bugzilla.wikimedia.org/70823 (10s7eph4n) 5PATC>3RESO/FIX [18:28:22] (03PS3) 10Umherirrender: Fix Special:Listusers i18n issues [core] - 10https://gerrit.wikimedia.org/r/150201 (https://bugzilla.wikimedia.org/39845) (owner: 10Rohan013) [18:28:30] (03CR) 10Umherirrender: [C: 032] Fix Special:Listusers i18n issues [core] - 10https://gerrit.wikimedia.org/r/150201 (https://bugzilla.wikimedia.org/39845) (owner: 10Rohan013) [18:34:59] 3MediaWiki / 3User login and signup: FOUC on signup page where CAPTCHA is in the wrong place before moving down - 10https://bugzilla.wikimedia.org/70803 (10Umherirrender) [18:35:01] (03Merged) 10jenkins-bot: Fix Special:Listusers i18n issues [core] - 10https://gerrit.wikimedia.org/r/150201 (https://bugzilla.wikimedia.org/39845) (owner: 10Rohan013) [18:36:59] 3MediaWiki / 3Categories: Entries for non-existent categories should be deleted from the 'category' table - 10https://bugzilla.wikimedia.org/26411#c15 (10Robert Morley) Is it my imagination or has this not yet been published, despite being noticed and corrected three years ago? Certainly Wikipedia's "List of... [18:38:01] 3MediaWiki / 3Internationalization: Hard coded brackets in includes/specials/SpecialListusers.php - 10https://bugzilla.wikimedia.org/39845#c3 (10Umherirrender) 5PATC>3RESO/FIX successfully merged [18:46:35] (03PS4) 10Umherirrender: Allow maxlength attribute on HTMLSelectAndOtherField [core] - 10https://gerrit.wikimedia.org/r/149590 [18:57:35] (03PS1) 10Mvolz: Add new export formats [services/citoid] - 10https://gerrit.wikimedia.org/r/160291 [18:58:48] (03Abandoned) 10Mvolz: New export format added to zoteroRequest [services/citoid] - 10https://gerrit.wikimedia.org/r/154958 (owner: 10Mvolz) [19:03:04] (03PS2) 10Addshore: Split UserMailer.php into includes/mail/ [core] - 10https://gerrit.wikimedia.org/r/160183 (owner: 10Legoktm) [19:03:15] (03PS2) 10Addshore: Add tests for MailAddress [core] - 10https://gerrit.wikimedia.org/r/160184 (owner: 10Legoktm) [19:03:20] (03PS2) 10Addshore: Add MailAddress::newFromUser() [core] - 10https://gerrit.wikimedia.org/r/160185 (owner: 10Legoktm) [19:04:41] (03CR) 10Mvolz: [C: 032 V: 032] Add new export formats [services/citoid] - 10https://gerrit.wikimedia.org/r/160291 (owner: 10Mvolz) [19:06:19] (03CR) 10Addshore: [C: 032] Split UserMailer.php into includes/mail/ [core] - 10https://gerrit.wikimedia.org/r/160183 (owner: 10Legoktm) [19:07:22] (03CR) 10Addshore: [C: 032] Add tests for MailAddress [core] - 10https://gerrit.wikimedia.org/r/160184 (owner: 10Legoktm) [19:08:00] 3MediaWiki / 3Categories: Entries for non-existent categories should be deleted from the 'category' table - 10https://bugzilla.wikimedia.org/26411#c16 (10Bawolff (Brian Wolff)) (In reply to Robert Morley from comment #15) > Is it my imagination or has this not yet been published, despite being > noticed and... [19:08:58] (03PS1) 10Hoo man: MediaWikiTestCase: Enforce children call parent::tearDown [core] - 10https://gerrit.wikimedia.org/r/160292 [19:09:37] (03CR) 10Addshore: [C: 032] Add MailAddress::newFromUser() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/160185 (owner: 10Legoktm) [19:12:42] (03CR) 10Addshore: MediaWikiTestCase: Enforce children call parent::tearDown (031 comment) [core] - 10https://gerrit.wikimedia.org/r/160292 (owner: 10Hoo man) [19:13:03] 3Wikimedia / 3General/Unknown: commons icon on Special:UserLogout not transparent - 10https://bugzilla.wikimedia.org/70829 (10db) 3NEW p:3Unprio s:3normal a:3None All the icons for the autologin from CentralAuth have transparent backgrounds except the commons icon. Should be changed to have all the s... [19:13:08] (03Merged) 10jenkins-bot: Split UserMailer.php into includes/mail/ [core] - 10https://gerrit.wikimedia.org/r/160183 (owner: 10Legoktm) [19:13:24] (03Merged) 10jenkins-bot: Add tests for MailAddress [core] - 10https://gerrit.wikimedia.org/r/160184 (owner: 10Legoktm) [19:13:48] 3MediaWiki / 3API: list=recentchanges doesn't reveal whether a page move event created a redirect - 10https://bugzilla.wikimedia.org/70830 (10Nathan Larson) 3NEW p:3Unprio s:3normal a:3None list=recentchanges doesn't reveal whether a page move event created a redirect. One can set rcprop=redirect, bu... [19:15:00] 3MediaWiki / 3API: list=recentchanges doesn't reveal whether a page move event created a redirect - 10https://bugzilla.wikimedia.org/70830 (10Nathan Larson) a:3Nathan Larson [19:16:08] (03Merged) 10jenkins-bot: Add MailAddress::newFromUser() [core] - 10https://gerrit.wikimedia.org/r/160185 (owner: 10Legoktm) [19:17:29] (03CR) 10Hoo man: MediaWikiTestCase: Enforce children call parent::tearDown (031 comment) [core] - 10https://gerrit.wikimedia.org/r/160292 (owner: 10Hoo man) [19:19:30] 3MediaWiki / 3API: list=recentchanges doesn't reveal whether a page move event created a redirect - 10https://bugzilla.wikimedia.org/70830#c1 (10db) For list=recentchanges and list=logevents there is a suppressedredirect="" attribute to indicate this (the other way round) -> WORKSFORME? [19:19:43] (03CR) 10Addshore: MediaWikiTestCase: Enforce children call parent::tearDown (031 comment) [core] - 10https://gerrit.wikimedia.org/r/160292 (owner: 10Hoo man) [19:20:05] (03PS2) 10Addshore: Use Config instead of globals, part 1 [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/159252 (owner: 10Legoktm) [19:20:25] legoktm: is GlobalCssJs really used anywhere yet? [19:20:27] (03CR) 10Hoo man: MediaWikiTestCase: Enforce children call parent::tearDown (031 comment) [core] - 10https://gerrit.wikimedia.org/r/160292 (owner: 10Hoo man) [19:20:35] addshore: How about production :P [19:20:44] meh, I mean outside of wikimedia :P [19:22:05] I'm going to say probably not per https://wikiapiary.com/wiki/Extension:GlobalCssJs ? :P [19:22:33] or do I just need to add some content to that page :p [19:22:51] (03PS2) 10Hoo man: MediaWikiTestCase: Enforce children call parent::tearDown [core] - 10https://gerrit.wikimedia.org/r/160292 [19:24:12] (03CR) 10Addshore: [C: 032] MediaWikiTestCase: Enforce children call parent::tearDown [core] - 10https://gerrit.wikimedia.org/r/160292 (owner: 10Hoo man) [19:28:23] (03CR) 10Addshore: "Shouldnt this have a note in its release notes (if it has some about a new minimum version of core to be used?)" [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/159252 (owner: 10Legoktm) [19:28:57] (03CR) 10Alex Monk: [C: 032] Re-add syntax highlighting to Gadget namespace pages [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160268 (owner: 10Legoktm) [19:29:05] (03Merged) 10jenkins-bot: Re-add syntax highlighting to Gadget namespace pages [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160268 (owner: 10Legoktm) [19:31:02] (03Merged) 10jenkins-bot: MediaWikiTestCase: Enforce children call parent::tearDown [core] - 10https://gerrit.wikimedia.org/r/160292 (owner: 10Hoo man) [19:31:29] (03PS5) 10Addshore: Remove use of deprecated $wgPasswordSenderName [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/157109 [19:32:36] addshore: Wikia uses a hack, I think [19:33:00] 3MediaWiki extensions / 3WikidataRepo: DiffViewTest failures on travis! - 10https://bugzilla.wikimedia.org/70659 (10Marius Hoch) 5PATC>3RESO/FIX [19:33:17] addshore: or a different, custom-made one http://community.wikia.com/wiki/Special:Version [19:33:37] gtg [19:36:00] 3MediaWiki extensions / 3WikidataRepo: DiffViewTest failures on travis! - 10https://bugzilla.wikimedia.org/70659#c4 (10Addshore) =] [19:49:07] (03PS1) 10Foxtrott: Rework styling of lists [skins/chameleon] - 10https://gerrit.wikimedia.org/r/160293 (https://bugzilla.wikimedia.org/70822) [19:50:14] 3MediaWiki / 3API: list=recentchanges doesn't reveal whether a page move event created a redirect - 10https://bugzilla.wikimedia.org/70830#c2 (10Nathan Larson) 5NEW>3RESO/WOR (In reply to db from comment #1) > For list=recentchanges and list=logevents there is a suppressedredirect="" > attribute to indic... [19:50:24] (03CR) 10Foxtrott: [C: 032 V: 032] Rework styling of lists [skins/chameleon] - 10https://gerrit.wikimedia.org/r/160293 (https://bugzilla.wikimedia.org/70822) (owner: 10Foxtrott) [19:51:00] 3MediaWiki skins / 3Chameleon: Bullet point styles/icon and category items are displayed as rectangle - 10https://bugzilla.wikimedia.org/70822 (10s7eph4n) 5PATC>3RESO/FIX [19:57:28] (03PS1) 10Foxtrott: Fix styling of category links [skins/chameleon] - 10https://gerrit.wikimedia.org/r/160294 [19:58:06] (03PS2) 10Foxtrott: Fix styling of category links [skins/chameleon] - 10https://gerrit.wikimedia.org/r/160294 (https://bugzilla.wikimedia.org/70822) [19:58:27] (03CR) 10Foxtrott: [C: 032 V: 032] Fix styling of category links [skins/chameleon] - 10https://gerrit.wikimedia.org/r/160294 (https://bugzilla.wikimedia.org/70822) (owner: 10Foxtrott) [19:59:00] 3MediaWiki skins / 3Chameleon: Bullet point styles/icon and category items are displayed as rectangle - 10https://bugzilla.wikimedia.org/70822 (10s7eph4n) 5PATC>3RESO/FIX [20:05:17] (03PS1) 10Mvolz: Bug fix- was returning only zotero format [services/citoid] - 10https://gerrit.wikimedia.org/r/160295 [20:06:19] (03CR) 10Mvolz: [C: 032 V: 032] Bug fix- was returning only zotero format [services/citoid] - 10https://gerrit.wikimedia.org/r/160295 (owner: 10Mvolz) [20:19:58] (03CR) 10Legoktm: "This extension is already dependent on MW 1.24 (documented on ) due to some other co" [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/159252 (owner: 10Legoktm) [20:22:33] addshore, shoutwiki.com also uses GlobalCssJs but I think an older version atm. [20:30:40] (03CR) 10SG: "With my patch, that *is* supposed to work." [core] - 10https://gerrit.wikimedia.org/r/155856 (https://bugzilla.wikimedia.org/69212) (owner: 10SG) [20:33:30] 3MediaWiki / 3Categories: Entries for non-existent categories should be deleted from the 'category' table - 10https://bugzilla.wikimedia.org/26411#c17 (10Robert Morley) I hadn't looked closely at the patch and thought he'd added both the automatic deletion functionality and the maintenance script. I see now... [20:37:46] 3MediaWiki / 3Categories: Entries for non-existent categories should be deleted from the 'category' table - 10https://bugzilla.wikimedia.org/26411 (10Andre Klapper) [20:47:52] ahh quiddity cheers :) [21:01:44] (03CR) 10Brian Wolff: Fix API help for query=videoinfo (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/157619 (https://bugzilla.wikimedia.org/55744) (owner: 10Brian Wolff) [21:03:27] (03Restored) 10Paladox: Update WikiEditor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [21:04:56] (03CR) 10Brian Wolff: Add duration field in query=imageinfo&iiprop=dimensions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/157586 (https://bugzilla.wikimedia.org/55941) (owner: 10Brian Wolff) [21:06:01] (03PS11) 10Paladox: Update WikiEditor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [21:06:03] (03CR) 10jenkins-bot: [V: 04-1] Update WikiEditor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [21:06:33] (03PS12) 10Paladox: Update WikiEditor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [21:06:36] (03CR) 10jenkins-bot: [V: 04-1] Update WikiEditor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [21:06:59] legoktm, around? [21:07:25] (03PS13) 10Paladox: WikiEditor: Convert .css to .less and also fixes svg issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [21:07:27] (03CR) 10jenkins-bot: [V: 04-1] WikiEditor: Convert .css to .less and also fixes svg issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [21:08:10] (03CR) 10Addshore: [C: 032] Use Config instead of globals, part 1 [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/159252 (owner: 10Legoktm) [21:08:16] (03Merged) 10jenkins-bot: Use Config instead of globals, part 1 [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/159252 (owner: 10Legoktm) [21:08:25] (03PS14) 10Paladox: WikiEditor: Convert .css to .less and also fixes svg issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 [21:08:27] (03CR) 10jenkins-bot: [V: 04-1] WikiEditor: Convert .css to .less and also fixes svg issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (owner: 10Paladox) [21:08:34] (03PS15) 10Paladox: WikiEditor: Convert .css to .less and also fixes svg issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [21:08:36] (03CR) 10jenkins-bot: [V: 04-1] WikiEditor: Convert .css to .less and also fixes svg issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [21:09:20] legoktm, i have been looking at your jsoncontent code, and I don't think we should include it in the 1.24 unless we fix a number of issues there - most important of which is the force-conversion to array. This is the issue the has been haunting MW API ever since the begining [21:11:01] legoktm, jsoncontent should, by default, use stdClass instead of an array for the dictionary storage, unless the subclass actually overrides it and deals with the consequences [21:11:18] (03PS16) 10Paladox: WikiEditor: Convert .css to .less and also fixes svg issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [21:11:20] (03CR) 10jenkins-bot: [V: 04-1] WikiEditor: Convert .css to .less and also fixes svg issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [21:12:00] 3Wikimedia / 3Extension setup: Security review of ImageMetrics - 10https://bugzilla.wikimedia.org/70789#c1 (10Chris Steipp) 5NEW>3RESO/FIX Nothing looks concerning to me in this. I'm assuming wgImageMetricsSamplingFactor will be kept at a sane level. If it's too high, eventlogging may get overloaded, but... [21:12:15] 3Wikimedia / 3Site requests: Review, merge and deploy chinese-collation branch - 10https://bugzilla.wikimedia.org/44667 (10Bawolff (Brian Wolff)) [21:12:15] 3MediaWiki / 3General/Unknown: Category pages should expose the timestamp sort option - 10https://bugzilla.wikimedia.org/70819#c3 (10Bawolff (Brian Wolff)) Semi related to bug 69417. I think exposing an interface would make sense if we already have an interface for multiple collations. Thus I'm going to mar... [21:12:21] legoktm, i propose that we remove this code from core until we fix it - releasing it officially might cause numerous problems in later support [21:15:15] legoktm, another minor thing - we should store json as non-prity, saves on space, and only render it pretty [21:16:11] (03PS2) 10Brian Wolff: Add duration field in query=imageinfo&iiprop=dimensions [core] - 10https://gerrit.wikimedia.org/r/157586 (https://bugzilla.wikimedia.org/55941) [21:16:43] (03CR) 10Brian Wolff: "PS2: Use cast instead, change doc for size parameter." [core] - 10https://gerrit.wikimedia.org/r/157586 (https://bugzilla.wikimedia.org/55941) (owner: 10Brian Wolff) [21:19:09] (03PS17) 10Paladox: WikiEditor: Convert .css to .less and also fixes svg issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [21:19:11] (03CR) 10jenkins-bot: [V: 04-1] WikiEditor: Convert .css to .less and also fixes svg issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [21:23:18] (03PS18) 10Paladox: WikiEditor: Convert .css to .less and also fixes svg issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 [21:23:20] (03CR) 10jenkins-bot: [V: 04-1] WikiEditor: Convert .css to .less and also fixes svg issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (owner: 10Paladox) [21:23:26] (03PS19) 10Paladox: WikiEditor: Convert .css to .less and also fixes svg issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [21:23:28] (03CR) 10jenkins-bot: [V: 04-1] WikiEditor: Convert .css to .less and also fixes svg issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [21:27:23] (03PS1) 10Gerrit Patch Uploader: jquery.accessKeyLabel: Append element into DOM on empty accessKeyLabel [core] - 10https://gerrit.wikimedia.org/r/160300 (https://bugzilla.wikimedia.org/67946) [21:27:28] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/160300 (https://bugzilla.wikimedia.org/67946) (owner: 10Gerrit Patch Uploader) [21:34:07] (03CR) 10Paladox: "Please see If12bb9dbbf52441c5494e40c2f06d7ef76bd6368 which I reopened" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [21:34:36] (03CR) 10Paladox: "Hi I have reopened If12bb9dbbf52441c5494e40c2f06d7ef76bd6368" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151616 (owner: 10Paladox) [21:37:05] (03PS1) 10Brian Wolff: Make $file->getLength() return duration of GIF and APNG files. [core] - 10https://gerrit.wikimedia.org/r/160304 [21:37:41] (03CR) 10Brian Wolff: "Note, after https://gerrit.wikimedia.org/r/160304, this change would also cause a duration to be shown for animated GIFs and APNGs" [core] - 10https://gerrit.wikimedia.org/r/157586 (https://bugzilla.wikimedia.org/55941) (owner: 10Brian Wolff) [21:37:44] 3MediaWiki extensions / 3[other]: Graph extension security review - 10https://bugzilla.wikimedia.org/69623#c2 (10Chris Steipp) The new vega library is an improvement, but I think there's a flaw in how they did the domain comparison: return vg.config.domainWhiteList.some(function(d) { return d === domain... [21:40:28] (03PS2) 10Brian Wolff: Make sure processResponsiveImages checks for valid thumb object [core] - 10https://gerrit.wikimedia.org/r/154132 [21:46:12] csteipp_afk, thx! [21:47:07] csteipp_afk, if i fix it myself, any other issues? I would like to enable it on meta on mon [21:47:44] yurikR: I don't think so. After that, I think it's ok to deploy. [21:48:15] csteipp_afk, not sure i understood - if i fix that issue you found myself, are there anything else that prevents us from using it on the security front? [21:48:43] yurikR: Sorry. Yes, if you fix that issue, then you should be ok to deploy [21:48:51] lol, ok, thx :) [21:48:59] and that was a good catch! [21:49:30] 3MediaWiki extensions / 3[other]: Graph extension security review - 10https://bugzilla.wikimedia.org/69623#c3 (10Yuri Astrakhan) thanks, good catch, fixing :) [21:49:37] Yeah, they're not really impressing me with their security chops, but nothing else looked too dangerous. [21:49:46] (03CR) 10Legoktm: [C: 04-1] "Feature itself looks fine since by default it has the same behavior." (032 comments) [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/112951 (https://bugzilla.wikimedia.org/57732) (owner: 10FreedomFighterSparrow) [21:50:17] legoktm, are you back? [21:58:14] (03PS1) 10Florianschmidtwelzow: Handle return value NULL of GeoCrumbs::getParserCache [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/160306 (https://bugzilla.wikimedia.org/70827) [21:58:40] csteipp_afk, yurikR: you guys going to make an upstream security bug about that then? [21:58:59] Krenair, i will make a pull request with a correct code too [21:59:25] will post both - the bug & the patch [21:59:34] ok [21:59:43] Krenair, already had this pending https://github.com/trifacta/vega/pull/217 [22:03:20] hi yurikR, I'm on and off right now [22:03:40] legoktm, np, i left you some comments re json content above [22:04:05] i think we should postpone with core json stuff or fix it, or else we will have a very hard time dealing with it in the future [22:04:27] I don't think we should remove it from 1.24, because stuff already uses it and it's an improvement to the current state, but I'm totally open to making breaking changes before it's released [22:04:37] like array -> stdClass [22:05:19] [14:15:15] legoktm, another minor thing - we should store json as non-prity, saves on space, and only render it pretty <-- reasonable. is there a good way to make it appear pretty in the edit window though? [22:06:08] legoktm, not sure, need to explore the code [22:06:25] (03PS2) 10Brian Wolff: Show patrol marks on Special:Contributions [core] - 10https://gerrit.wikimedia.org/r/151381 (https://bugzilla.wikimedia.org/69061) [22:06:28] the second one is more flex - we can always make it store non-pretty later [22:06:33] its the stdClass i am mostly worried [22:06:33] agreed [22:07:13] (03PS3) 10Brian Wolff: Show patrol marks on Special:Contributions [core] - 10https://gerrit.wikimedia.org/r/151381 (https://bugzilla.wikimedia.org/69061) [22:08:15] (03CR) 10Brian Wolff: "PS2: Make sure that red !'s aren't shown for revisions past the rc cut off (otherwise you could have red "!" that are impossible to patrol" [core] - 10https://gerrit.wikimedia.org/r/151381 (https://bugzilla.wikimedia.org/69061) (owner: 10Brian Wolff) [22:09:17] (03PS4) 10Brian Wolff: Relax filter attribute filtering to allow self-referential urls [core] - 10https://gerrit.wikimedia.org/r/150048 (https://bugzilla.wikimedia.org/67044) [22:10:17] 3MediaWiki / 3ContentHandler: JSONContent::getJsonData() should return an object, not array - 10https://bugzilla.wikimedia.org/70832 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None Per quick discussion with Yurik on IRC. We want to do this before the 1.24 release is stable. [22:10:28] yurikR: ^ so I don't forget [22:10:29] 3MediaWiki / 3ContentHandler: JSONContent::getJsonData() should return an object, not array - 10https://bugzilla.wikimedia.org/70832 (10Kunal Mehta (Legoktm)) p:5Unprio>3High [22:10:39] (03PS3) 10Brian Wolff: Split BitmapHandler into two classes. [core] - 10https://gerrit.wikimedia.org/r/147718 [22:13:17] 3MediaWiki / 3ContentHandler: JSONContent should store non-pretty printed JSON, but still show pretty in the edit interface - 10https://bugzilla.wikimedia.org/70833 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None To save some space, it would be a good idea to store non-pretty printed JSON,... [22:13:41] (03PS2) 10Brian Wolff: Allow WantedQueryPage subclasses to override the existence check [core] - 10https://gerrit.wikimedia.org/r/147741 [22:13:43] (03PS2) 10Brian Wolff: Better false positive detection for Special:Wantedfiles [core] - 10https://gerrit.wikimedia.org/r/147742 [22:13:52] (03CR) 10Brian Wolff: "ps2: rebase" [core] - 10https://gerrit.wikimedia.org/r/147742 (owner: 10Brian Wolff) [22:14:15] (03CR) 10Brian Wolff: "PS2: rebase" [core] - 10https://gerrit.wikimedia.org/r/147741 (owner: 10Brian Wolff) [22:14:37] is there a valid reason to set $wgAjaxWatch = false? [22:15:20] (03CR) 10Brian Wolff: "ping on this? I'd love to see this merged" [core] - 10https://gerrit.wikimedia.org/r/147718 (owner: 10Brian Wolff) [22:15:22] legoktm, thx. We could make it as a constructor param or/and a protected var so that the derived class (e.g. ori's log schema, etc) would use it as arrays since that's what they expect. Second thing is rendering - at this point, we might want to make it geshi-based instead of table - let's output it as wiki markup > [22:15:53] (03PS2) 10Brian Wolff: Have Title::makeTitleSafe decode html entities. [core] - 10https://gerrit.wikimedia.org/r/145724 (https://bugzilla.wikimedia.org/67196) [22:17:36] (03CR) 10Addshore: [C: 04-1] "needs manual rebase" [core] - 10https://gerrit.wikimedia.org/r/147058 (owner: 10Thiemo Mättig (WMDE)) [22:17:43] legoktm, the reason for that is that I think we should separate all the html rendering from content objects (currently its not well separated, but we could at least put it into a different class). Lastly, validation is not perfect - at present it is only true/false, whereas we really ought to use the status object [22:18:04] patches weclome :D [22:18:22] (or file bugs so I don't forget) [22:18:27] legoktm, of course, but its all about "breaking changes" ;) [22:20:55] (03PS1) 10Legoktm: Override TextContentHandler::getContentClass() [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/160307 [22:21:00] (03PS3) 10Brian Wolff: Degrade gracefully on missing special page description message. [core] - 10https://gerrit.wikimedia.org/r/144253 (https://bugzilla.wikimedia.org/67547) [22:21:19] (03CR) 10Brian Wolff: "PS3: rebase" [core] - 10https://gerrit.wikimedia.org/r/144253 (https://bugzilla.wikimedia.org/67547) (owner: 10Brian Wolff) [22:21:22] yurikR: sure, but I think we can make breaking changes before 1.24 goes out. there are currently only 4 extensions using it [22:21:35] (03PS1) 10Bartosz Dziewoński: mediawiki.api.options: New module for user preferences API (action=options) [core] - 10https://gerrit.wikimedia.org/r/160308 [22:21:47] legoktm, i meant that the deadline is less than 2 weeks away :) [22:22:01] (need to dblcheck when 1.24 is done) [22:22:37] https://www.mediawiki.org/wiki/MediaWiki_1.24 says Nov 2014 [22:23:15] branch will happen in ~2 weeks ish, but we can backport stuff for a while [22:23:54] (03PS6) 10Brian Wolff: Add Special:MostGloballyLinkedFiles (global version Special:Mostimages) [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/143755 [22:23:56] (03PS4) 10Brian Wolff: Make Special:Wantedfiles not include foreign false positives. [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/143835 (https://bugzilla.wikimedia.org/6220) [22:23:58] (03PS4) 10Brian Wolff: Add Special:GloballyWantedFiles [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/143828 [22:25:00] 3MediaWiki / 3JobRunner: hhvm jobrunner TCP socket failure error 24 too many open files - 10https://bugzilla.wikimedia.org/70825 (10Ori Livneh) 5PATC>3RESO/FIX a:3Ori Livneh [22:30:54] (03PS2) 10Brian Wolff: API: Add timestamp of block to blockinfo [core] - 10https://gerrit.wikimedia.org/r/143787 (https://bugzilla.wikimedia.org/63326) [22:35:33] 3MediaWiki / 3ContentHandler: Improve JSONContent before releasing 1.24 - 10https://bugzilla.wikimedia.org/70832#c1 (10Yuri Astrakhan) I will put all of my jsoncontent-related concerns here for discussion. * By default, data model should use [] <=> array, and {} <=> stdClass conversion, without forcing {}... [22:35:50] legoktm, ^^ renamed and added my thoughts [22:38:37] thanks [22:41:45] 3MediaWiki / 3Database: Store the page_id of the redirect page in log_params when a page is moved without suppressing the redirect - 10https://bugzilla.wikimedia.org/68930#c9 (10Nathan Larson) A new patch is needed, since this is one is obsolete after gerrit 157872. [23:00:42] (03PS1) 10Deskana: Change default session sampling rate to 0. [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/160310 [23:01:04] (03PS3) 10Brian Wolff: API: Add timestamp of block to blockinfo [core] - 10https://gerrit.wikimedia.org/r/143787 (https://bugzilla.wikimedia.org/63326) [23:03:50] (03CR) 10Brian Wolff: "PS2: slightly messed up rebase." [core] - 10https://gerrit.wikimedia.org/r/143787 (https://bugzilla.wikimedia.org/63326) (owner: 10Brian Wolff) [23:17:25] (03CR) 10Hoo man: [C: 032] "Trivial" [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/160306 (https://bugzilla.wikimedia.org/70827) (owner: 10Florianschmidtwelzow) [23:17:32] (03Merged) 10jenkins-bot: Handle return value NULL of GeoCrumbs::getParserCache [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/160306 (https://bugzilla.wikimedia.org/70827) (owner: 10Florianschmidtwelzow) [23:18:16] 3Wikimedia / 3General/Unknown: commons icon on Special:UserLogout not transparent - 10https://bugzilla.wikimedia.org/70829#c1 (10Bawolff (Brian Wolff)) That would be /srv/mediawiki/images/sul/commons.png I believe, but I don't see anything in the puppet repo that looks like it corresponds to that. [23:18:16] 3MediaWiki extensions / 3GeoCrumbs: [1.24wmf20] Fatal error: Call to a member function getProperty() on a non-object, after completely history merging a page - 10https://bugzilla.wikimedia.org/70827 (10Marius Hoch) 5PATC>3RESO/FIX [23:20:30] (03PS5) 10Brian Wolff: Do not require iiurlwidth when getting thumbnails. [core] - 10https://gerrit.wikimedia.org/r/140864 [23:20:58] (03CR) 10Brian Wolff: "PS5: rebase" [core] - 10https://gerrit.wikimedia.org/r/140864 (owner: 10Brian Wolff) [23:22:59] (03PS2) 10Brian Wolff: Make inputbox use fully qualified mode in action=render [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/138473 [23:33:59] 3MediaWiki / 3ContentHandler: Improve JSONContent before releasing 1.24 - 10https://bugzilla.wikimedia.org/70832#c2 (10Alex Monk) (In reply to Yuri Astrakhan from comment #1) > * By default, lets not use visualize JSON as table - this might work in some > cases, but it is not easily copiable (without hitting... [23:34:35] (03PS2) 10Brian Wolff: Fix double output of mimesearch-summary [core] - 10https://gerrit.wikimedia.org/r/138300 [23:34:42] (03CR) 10Brian Wolff: "PS2: rebase" [core] - 10https://gerrit.wikimedia.org/r/138300 (owner: 10Brian Wolff) [23:35:54] (03PS2) 10Brian Wolff: Don't require midi output in raw mode if not linking to it [extensions/Score] - 10https://gerrit.wikimedia.org/r/102367 [23:37:36] (03PS2) 10Brian Wolff: Let TMH detect webm files using opus and VP9 codecs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108482 (https://bugzilla.wikimedia.org/60245) [23:37:51] (03CR) 10jenkins-bot: [V: 04-1] Let TMH detect webm files using opus and VP9 codecs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108482 (https://bugzilla.wikimedia.org/60245) (owner: 10Brian Wolff) [23:39:04] wtf: "FAILURE in 11s" - go to test to see what failed: OK (38 tests, 69 assertions) [23:39:52] bawolff: except there's a fatal [23:39:52] oh wait, TMH tests are just horrid [23:40:16] * greg-g stops looking at it and goes AFIRC [23:41:08] Sorry, that was me earlier :D [23:44:53] hoo: Ah, I see 3cbaac08cd. I still say its TMH's fault for not calling parent::tearDown [23:44:59] sure [23:45:06] I'm preparing a patch right now [23:46:46] (03PS1) 10Hoo man: Call parent::tearDown in ApiTestCaseVideoUpload [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/160313 [23:47:13] bawolff: ^ [23:48:27] (03CR) 10Brian Wolff: [C: 032] Call parent::tearDown in ApiTestCaseVideoUpload [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/160313 (owner: 10Hoo man) [23:48:34] yay :) [23:48:38] (03Merged) 10jenkins-bot: Call parent::tearDown in ApiTestCaseVideoUpload [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/160313 (owner: 10Hoo man) [23:48:58] That will help us find some very nasty bugs [23:49:10] Spent ages just tracking down one missing parent::tearDown [23:49:55] (03CR) 10Legoktm: [C: 032] Fix double output of mimesearch-summary [core] - 10https://gerrit.wikimedia.org/r/138300 (owner: 10Brian Wolff) [23:50:04] thanks legoktm [23:52:13] np [23:52:15] speaking of tests! [23:52:24] I'm having this weird issue when running some: [23:52:40] https://dpaste.de/LyY6/raw [23:52:48] phpunit just dies with no error message [23:52:54] it's a 255 status code [23:53:00] 3MediaWiki / 3ContentHandler: Improve JSONContent before releasing 1.24 - 10https://bugzilla.wikimedia.org/70832#c3 (10Yuri Astrakhan) Alex, I am totally ok with the table, but I don't want to duplicate it - I have substantially improved upon Ori's original table code to be more extendable and support valida... [23:53:02] that's a fatal [23:53:19] I put: [23:53:19] error_reporting( -1 ); [23:53:19] ini_set( 'display_errors', 1 ); [23:53:20] $wgShowExceptionDetails = true; [23:53:26] in my LocalSettings.php, but still no info [23:53:35] then try --debug [23:54:01] hmm [23:54:06] Starting test 'RemoveOldManualUserPagesTest::testCheckJs with data set #0 ('mw.loader.load(\'//meta.wikimedia.org/w/index.php?title=User:UserName/global.js&action=raw&ctype=text/javascript\');', true, 'UserName', 'mw.loader.load with a proto-rel link')'. [23:54:07] then it dies [23:54:14] ok, lets try deleting that test for now.. [23:54:54] woot, passing now [23:55:06] but how do I get a traceback for that test? [23:55:12] it passes locally and with jenkins... [23:56:36] (03Merged) 10jenkins-bot: Fix double output of mimesearch-summary [core] - 10https://gerrit.wikimedia.org/r/138300 (owner: 10Brian Wolff) [23:57:03] Seen this all before... hard to track down at times [23:57:38] hmm [23:59:48] var_dump debugging time!