[00:08:59] (03PS1) 10EBernhardson: Output delete/suppress links on locked topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160169 [00:09:11] (03CR) 10jenkins-bot: [V: 04-1] Output delete/suppress links on locked topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160169 (owner: 10EBernhardson) [00:11:03] (03PS2) 10EBernhardson: Output delete/suppress links on locked topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160169 [00:20:34] (03CR) 10Ebe123: "Going slowly for now; my test environment is so polluted that life is unsustainable." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156048 (https://bugzilla.wikimedia.org/69053) (owner: 10Ebe123) [00:40:30] (03CR) 10Ori.livneh: [C: 032] "Very nice" [vagrant] - 10https://gerrit.wikimedia.org/r/157769 (owner: 10BryanDavis) [00:40:36] (03Merged) 10jenkins-bot: Add support for ssh access to gerrit [vagrant] - 10https://gerrit.wikimedia.org/r/157769 (owner: 10BryanDavis) [01:03:52] (03PS1) 10Reza: i18n: Native digits on 'mergehistory-success' [core] - 10https://gerrit.wikimedia.org/r/160173 [01:09:29] 3Wikimedia / 3General/Unknown: Special:MovePage disappeared from tet.wikipedia - 10https://bugzilla.wikimedia.org/70686#c14 (10MF-Warburg) I changed the alias now () to make this problem go away. Howev... [01:38:00] (03CR) 10Ori.livneh: [C: 032 V: 032] Dont treat argument as wikitext [extensions/Flow] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160175 (owner: 10EBernhardson) [01:40:00] (03PS12) 10SG: Change mw-ui anchors to require mw-ui-anchor base class [core] - 10https://gerrit.wikimedia.org/r/155856 (https://bugzilla.wikimedia.org/69212) [01:40:10] (03PS1) 10Ori.livneh: Update flow for I4da934dfe [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160176 [01:40:35] (03CR) 10Ori.livneh: [C: 032 V: 032] Update flow for I4da934dfe [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160176 (owner: 10Ori.livneh) [01:40:44] (03PS1) 10EBernhardson: Dont treat argument as wikitext [extensions/Flow] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160177 [01:41:28] (03PS2) 10Ori.livneh: Dont treat argument as wikitext [extensions/Flow] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160177 (owner: 10EBernhardson) [01:41:35] (03CR) 10Ori.livneh: [C: 032] Dont treat argument as wikitext [extensions/Flow] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160177 (owner: 10EBernhardson) [01:42:48] (03Merged) 10jenkins-bot: Dont treat argument as wikitext [extensions/Flow] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160177 (owner: 10EBernhardson) [01:44:44] (03PS1) 10Ori.livneh: Update flow for I4da934dfe [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160178 [01:44:56] (03CR) 10Ori.livneh: [C: 032 V: 032] Update flow for I4da934dfe [core] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160178 (owner: 10Ori.livneh) [01:46:14] 3MediaWiki / 3Export/Import: Importing does not work with HHVM - 10https://bugzilla.wikimedia.org/66023#c8 (10dan) via a few emails, giuseppe pointed out that the current wm hhvm: HipHop VM 3.3.0-dev (rel) Compiler: heads/master-0-g2e297ed662d6cec9368ab8bd527ac06eaeef18cc Repo schema: 4cd91499a6638cdf8f21e8... [01:53:44] (03CR) 10Cscott: "Hm, that's weird, I don't see that locally. I think the 'contributors' stuff was added fairly recently (since july-ish) to the image info" [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160156 (owner: 10Arlolra) [01:54:27] (03CR) 10Cscott: [C: 032] Code block probably needs to start on newline [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/160085 (owner: 10Arlolra) [01:54:44] (03Merged) 10jenkins-bot: Code block probably needs to start on newline [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/160085 (owner: 10Arlolra) [01:56:42] (03CR) 10Arlolra: "Yup, I pulled the latest." [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160156 (owner: 10Arlolra) [02:14:40] (03CR) 10Mattflaschen: [C: 04-2] "An alternative implementation, by Sam Smith, is at https://gerrit.wikimedia.org/r/#/c/139368 . He's on vacation but coming back Monday, s" [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) (owner: 10Jdlrobson) [02:18:19] (03CR) 10Mattflaschen: [C: 04-2] "> With the mixin approach both Flow and MobileFrontend have to define their own SVG in their own repository local to their LESS css." [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx) [02:22:30] 3MediaWiki / 3User login and signup: No margin between create account button and CAPTCHA container - 10https://bugzilla.wikimedia.org/68788 (10Matthew Flaschen) a:3Matthew Flaschen [02:26:54] (03PS2) 10Cscott: Easy-to-read filenames in the bundle when debugging. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160107 [02:26:56] (03PS2) 10Cscott: Redirect more logging through new log framework. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160106 [02:26:58] (03PS2) 10Cscott: Increase retries of truncated downloads from 3 to 5. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160109 [02:27:00] (03PS2) 10Cscott: Don't crash if a referenced image was deleted or otherwise missing. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160108 [02:37:58] (03CR) 10Cscott: "Oh! I guess the pre-baked content in a fresh Main_Page has no contributors. Makes sense I guess." [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160156 (owner: 10Arlolra) [02:42:20] (03CR) 10Cscott: [C: 032] Contributors isn't always present [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160156 (owner: 10Arlolra) [02:43:57] (03Merged) 10jenkins-bot: Contributors isn't always present [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160156 (owner: 10Arlolra) [02:55:01] 3MediaWiki / 3MediaWiki UI: styles conflicting with guided tour - 10https://bugzilla.wikimedia.org/70801 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None Created attachment 16459 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16459&action=edit guider button with incorrect rendering... [03:11:42] (03PS1) 10Mattflaschen: Add margin below CAPTCHA box (and above submit) for signup and login [core] - 10https://gerrit.wikimedia.org/r/160181 (https://bugzilla.wikimedia.org/68788) [03:14:46] (03CR) 10Mattflaschen: "Can be tested by enabling the confirmedit role on MediaWiki-Vagrant. To test the signup part, just visit the page. For the login part, e" [core] - 10https://gerrit.wikimedia.org/r/160181 (https://bugzilla.wikimedia.org/68788) (owner: 10Mattflaschen) [03:21:17] (03CR) 10Arlolra: [C: 032] Redirect more logging through new log framework. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160106 (owner: 10Cscott) [03:22:28] (03CR) 10Arlolra: [C: 032] Easy-to-read filenames in the bundle when debugging. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160107 (owner: 10Cscott) [03:22:50] (03Merged) 10jenkins-bot: Redirect more logging through new log framework. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160106 (owner: 10Cscott) [03:24:09] (03Merged) 10jenkins-bot: Easy-to-read filenames in the bundle when debugging. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160107 (owner: 10Cscott) [03:25:46] (03CR) 10Arlolra: [C: 032] Don't crash if a referenced image was deleted or otherwise missing. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160108 (owner: 10Cscott) [03:26:23] (03CR) 10Arlolra: [C: 032] Increase retries of truncated downloads from 3 to 5. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160109 (owner: 10Cscott) [03:26:59] (03PS1) 10Legoktm: Split UserMailer.php into includes/mail/ [core] - 10https://gerrit.wikimedia.org/r/160183 [03:27:01] (03PS1) 10Legoktm: Add tests for MailAddress [core] - 10https://gerrit.wikimedia.org/r/160184 [03:27:03] (03PS1) 10Legoktm: Add MailAddress::newFromUser() [core] - 10https://gerrit.wikimedia.org/r/160185 [03:27:44] (03Merged) 10jenkins-bot: Don't crash if a referenced image was deleted or otherwise missing. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160108 (owner: 10Cscott) [03:28:17] (03Merged) 10jenkins-bot: Increase retries of truncated downloads from 3 to 5. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/160109 (owner: 10Cscott) [04:16:26] (03PS1) 10Legoktm: Fix @covers tags [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/160187 [04:17:30] (03CR) 10Ori.livneh: [C: 032] Fix @covers tags [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/160187 (owner: 10Legoktm) [04:17:41] thanks ori [04:17:58] (03Merged) 10jenkins-bot: Fix @covers tags [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/160187 (owner: 10Legoktm) [04:18:07] https://tools.wmflabs.org/coverage/massmessage/extensions_MassMessage.html working on improving that :P [04:19:37] (03PS1) 10Jjanes: Import: Fix error reporting [core] - 10https://gerrit.wikimedia.org/r/160188 [04:32:05] legoktm: oh, neat, since when do we have that tool? [04:32:44] a few days ago, addshore and I have been working on it, but it's mostly manually setup right now [04:33:17] I have a patch to have jenkins to do this, but it's waiting for hashar to get back :) [04:33:23] (03CR) 10Rillke: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) (owner: 10Rillke) [04:33:31] cool; that will be useful [04:34:04] https://gerrit.wikimedia.org/r/#/c/154757/ [04:34:11] (03CR) 10Rillke: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152177 (owner: 10Rillke) [04:40:39] (03CR) 10Rillke: "Oh, thanks for the whitespace fixes. Grummel." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152177 (owner: 10Rillke) [04:55:49] (03PS10) 10Rillke: Read description from metadata and suggest it [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152177 [04:56:10] (03CR) 10Rillke: "rebase -Xignore-all-space and commit --amend" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152177 (owner: 10Rillke) [04:57:22] (03CR) 10Rillke: "!rebased after s.o. made provided us with the gift of re-indetion" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152177 (owner: 10Rillke) [05:02:36] (03PS2) 10Legoktm: Use safe attribute accessor for RecentChange [core] - 10https://gerrit.wikimedia.org/r/155738 (owner: 10BryanDavis) [05:02:55] (03CR) 10Legoktm: [C: 032] "Ok, I didn't realize that. Seems reasonable to do this then." [core] - 10https://gerrit.wikimedia.org/r/155738 (owner: 10BryanDavis) [05:04:38] (03PS4) 10Legoktm: Make MySQLi work with non-standard socket [core] - 10https://gerrit.wikimedia.org/r/136638 (https://bugzilla.wikimedia.org/65998) (owner: 10Martineznovo) [05:06:58] (03CR) 10Legoktm: "Congratulations, your test worked and was submitted to gerrit properly! I'm going to abandon it now, so it no longer shows up in the list " [extensions/examples] - 10https://gerrit.wikimedia.org/r/155040 (owner: 10Darkaico) [05:07:03] (03Abandoned) 10Legoktm: testing gerrit [extensions/examples] - 10https://gerrit.wikimedia.org/r/155040 (owner: 10Darkaico) [05:09:18] (03Merged) 10jenkins-bot: Use safe attribute accessor for RecentChange [core] - 10https://gerrit.wikimedia.org/r/155738 (owner: 10BryanDavis) [05:11:53] (03CR) 10Legoktm: [C: 031] "thanks for adding documentation!" [core] - 10https://gerrit.wikimedia.org/r/153277 (owner: 10Kunalgrover05) [05:12:12] (03CR) 10Legoktm: [C: 032] Remove duplicate code [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/154215 (owner: 10Gerrit Patch Uploader) [05:12:19] (03Merged) 10jenkins-bot: Remove duplicate code [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/154215 (owner: 10Gerrit Patch Uploader) [05:12:42] (03CR) 10Legoktm: [C: 04-1] "Needs rebase :(" [core] - 10https://gerrit.wikimedia.org/r/154338 (owner: 10Jjanes) [05:14:05] (03PS8) 10Rillke: Create title in file NS and validate as such [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) [05:14:35] (03CR) 10jenkins-bot: [V: 04-1] Create title in file NS and validate as such [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) (owner: 10Rillke) [05:15:53] (03CR) 10Rillke: "!rebased. It's ridiculous how much time I spend rebasing." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) (owner: 10Rillke) [05:17:21] (03CR) 10Legoktm: "It feels weird to me to add a parameter that intentionally does nothing. Can we have it work as an alias to "query-continue" from the begi" [core] - 10https://gerrit.wikimedia.org/r/154092 (owner: 10Anomie) [05:17:28] (03PS9) 10Rillke: Create title in file NS and validate as such [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) [05:18:06] (03PS1) 10EBernhardson: Hygiene: Various small cleanups [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160191 [05:18:17] (03CR) 10Rillke: "Instead of nagging, these beautiful tools could just apply the conventions. If they find where I have to insert a space, why don't they ju" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) (owner: 10Rillke) [05:20:04] (03CR) 10Legoktm: [C: 032] Make MySQLi work with non-standard socket [core] - 10https://gerrit.wikimedia.org/r/136638 (https://bugzilla.wikimedia.org/65998) (owner: 10Martineznovo) [05:22:35] (03CR) 10Legoktm: "Abandon?" [core] - 10https://gerrit.wikimedia.org/r/153349 (owner: 10CSteipp) [05:24:02] (03CR) 10Legoktm: [C: 031] "I don't think people will, but it's a DWIM thing." [core] - 10https://gerrit.wikimedia.org/r/147058 (owner: 10Thiemo Mättig (WMDE)) [05:24:14] (03CR) 10Legoktm: "Needs rebase :(" [core] - 10https://gerrit.wikimedia.org/r/147058 (owner: 10Thiemo Mättig (WMDE)) [05:25:02] (03PS2) 10Legoktm: Remove hypens from extension entries on Special:Version [core] - 10https://gerrit.wikimedia.org/r/137968 (owner: 10UltrasonicNXT) [05:26:23] (03Merged) 10jenkins-bot: Make MySQLi work with non-standard socket [core] - 10https://gerrit.wikimedia.org/r/136638 (https://bugzilla.wikimedia.org/65998) (owner: 10Martineznovo) [05:37:57] (03CR) 10Legoktm: [C: 04-1] SpecialEmailUser: Use Config instead of globals (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151525 (owner: 10Legoktm) [05:38:00] (03PS2) 10Legoktm: SpecialEmailUser: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151525 [05:42:56] (03PS3) 10Legoktm: SpecialEmailUser: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151525 [05:43:32] (03CR) 10Legoktm: "PS2: rebase, PS3: More back-compat friendly to avoid breaking extensions." [core] - 10https://gerrit.wikimedia.org/r/151525 (owner: 10Legoktm) [05:44:44] (03PS2) 10Legoktm: Preferences: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/155208 [05:50:12] (03PS2) 10EBernhardson: Hygiene: Various small cleanups [extensions/Flow] - 10https://gerrit.wikimedia.org/r/160191 [05:53:30] 3Wikimedia / 3Site requests: enable CategoryCollation on frwikiversity - 10https://bugzilla.wikimedia.org/69782#c3 (10David Crochet) *** Bug 70794 has been marked as a duplicate of this bug. *** [05:53:30] 3Wikimedia / 3Site requests: Setting wgCategoryCollation for the French Wikiversity - 10https://bugzilla.wikimedia.org/70794#c1 (10David Crochet) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 69782 *** [05:54:18] (03CR) 10Legoktm: Preferences: Use Config instead of globals (036 comments) [core] - 10https://gerrit.wikimedia.org/r/155208 (owner: 10Legoktm) [05:54:20] (03PS3) 10Legoktm: Preferences: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/155208 [05:54:52] (03PS3) 10Legoktm: JobRunner: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/152821 [05:56:22] (03PS3) 10Mattflaschen: WIP: Have GettingStarted depend on CentralAuth [vagrant] - 10https://gerrit.wikimedia.org/r/134782 [06:00:18] (03PS4) 10Legoktm: JobRunner: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/152821 [06:00:24] (03CR) 10Legoktm: JobRunner: Use Config instead of globals (031 comment) [core] - 10https://gerrit.wikimedia.org/r/152821 (owner: 10Legoktm) [06:03:54] (03PS2) 10Legoktm: TablePager: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/155877 [06:04:13] (03PS3) 10Legoktm: TablePager: Use wfScript() instead of $wgScript [core] - 10https://gerrit.wikimedia.org/r/155877 [06:04:29] 3MediaWiki / 3MediaWiki UI: styles conflicting with guided tour - 10https://bugzilla.wikimedia.org/70801#c1 (10Matthew Flaschen) That's GettingStarted, not GuidedTour. But it is indeed a regression in MediaWiki UI, due to the mediawiki.ui.anchor code. [06:05:47] (03CR) 10Mattflaschen: "Just to confirm:" [core] - 10https://gerrit.wikimedia.org/r/155856 (https://bugzilla.wikimedia.org/69212) (owner: 10SG) [06:06:33] 3MediaWiki / 3MediaWiki UI: styles conflicting with guided tour - 10https://bugzilla.wikimedia.org/70801#c2 (10Matthew Flaschen) Specificially, because the color is set unconditionally with .mw-ui-progressive:focus you get blue on blue. I think this may be fixed by https://gerrit.wikimedia.org/r/#/c/155856/ [06:08:59] 3MediaWiki / 3MediaWiki UI: styles conflicting with guided tour - 10https://bugzilla.wikimedia.org/70801#c3 (10Matthew Flaschen) What fixed header element are you referring to? I assume the popup is the GettingStarted modal the screenshot shows. [06:12:57] (03PS2) 10Jjanes: PHPUnit: Add Database tags [core] - 10https://gerrit.wikimedia.org/r/154338 [06:24:03] 3MediaWiki / 3User login and signup: FUOC on signup page where CAPTCHA is in the wrong place before moving down - 10https://bugzilla.wikimedia.org/70803 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3None There is a flash where the CAPTCHA is at the top before moving down. That this can happen is... [06:25:13] 3MediaWiki / 3User login and signup: FUOC on signup page where CAPTCHA is in the wrong place before moving down - 10https://bugzilla.wikimedia.org/70803#c1 (10Matthew Flaschen) I'm not sure whether the flash has been there the whole time since we did the CAPTCHA restyling. [06:31:36] (03PS1) 10Umherirrender: Typo: compatability -> compatibility [core] - 10https://gerrit.wikimedia.org/r/160194 [06:31:53] (03CR) 10Umherirrender: SpecialEmailUser: Use Config instead of globals (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151525 (owner: 10Legoktm) [06:32:13] (03PS2) 10Umherirrender: Typo: compatability -> compatibility [core] - 10https://gerrit.wikimedia.org/r/160194 [06:34:51] (03PS1) 10Legoktm: Add tests for GadgetResourceLoaderModule [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160195 [06:34:53] (03PS1) 10Legoktm: Move GadgetTest to tests/backend, and rename file to match class [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160196 [06:37:47] (03CR) 10Umherirrender: [C: 032] Preferences: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/155208 (owner: 10Legoktm) [06:40:19] (03CR) 10Legoktm: SpecialEmailUser: Use Config instead of globals (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151525 (owner: 10Legoktm) [06:40:32] (03PS4) 10Legoktm: SpecialEmailUser: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151525 [06:40:52] (03CR) 10Legoktm: [C: 032] Typo: compatability -> compatibility [core] - 10https://gerrit.wikimedia.org/r/160194 (owner: 10Umherirrender) [06:44:14] (03Merged) 10jenkins-bot: Preferences: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/155208 (owner: 10Legoktm) [06:47:34] (03CR) 10Umherirrender: [C: 032] SpecialEmailUser: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151525 (owner: 10Legoktm) [06:47:45] (03Merged) 10jenkins-bot: Typo: compatability -> compatibility [core] - 10https://gerrit.wikimedia.org/r/160194 (owner: 10Umherirrender) [06:53:46] (03Merged) 10jenkins-bot: SpecialEmailUser: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151525 (owner: 10Legoktm) [06:56:05] (03PS1) 10Legoktm: Get rid of GadgetPageList::isGadgetPage() [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160197 [07:00:32] (03PS2) 10Legoktm: Get rid of GadgetPageList::isGadgetPage() [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160197 [07:04:35] (03PS4) 10Umherirrender: TablePager: Use wfScript() instead of $wgScript [core] - 10https://gerrit.wikimedia.org/r/155877 (owner: 10Legoktm) [07:04:43] (03CR) 10Umherirrender: [C: 032] TablePager: Use wfScript() instead of $wgScript [core] - 10https://gerrit.wikimedia.org/r/155877 (owner: 10Legoktm) [07:11:42] (03Merged) 10jenkins-bot: TablePager: Use wfScript() instead of $wgScript [core] - 10https://gerrit.wikimedia.org/r/155877 (owner: 10Legoktm) [07:21:34] (03PS2) 10Umherirrender: Use local var in Action::setHeaders [core] - 10https://gerrit.wikimedia.org/r/159358 [07:35:01] 3Wikimedia / 3Site requests: Change $wgPasswordDefault to PBKDF2 on WMF wikis - 10https://bugzilla.wikimedia.org/68766#c7 (10Umherirrender) 5PATC>3RESO/FIX successfully merged [08:30:43] (03PS1) 10Legoktm: Get rid of the GadgetPageList class [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160199 [08:36:35] (03CR) 10Bartosz Dziewoński: [C: 032] Add margin below CAPTCHA box (and above submit) for signup and login [core] - 10https://gerrit.wikimedia.org/r/160181 (https://bugzilla.wikimedia.org/68788) (owner: 10Mattflaschen) [08:37:29] 3MediaWiki / 3User login and signup: No margin between create account button and CAPTCHA container - 10https://bugzilla.wikimedia.org/68788 (10Bartosz Dziewoński) 5PATC>3RESO/FIX [08:38:45] 3MediaWiki extensions / 3MarkAsHelpful: MarkAsHelpful: Don't use global delegate event handlers - 10https://bugzilla.wikimedia.org/67738 (10Andre Klapper) 5ASSI>3NEW a:5bsitu>3None [08:38:47] 3MediaWiki extensions / 3MarkAsHelpful: MarkAsHelpful should pass jshint - 10https://bugzilla.wikimedia.org/65894 (10Andre Klapper) a:5bsitu>3None [08:43:14] (03Merged) 10jenkins-bot: Add margin below CAPTCHA box (and above submit) for signup and login [core] - 10https://gerrit.wikimedia.org/r/160181 (https://bugzilla.wikimedia.org/68788) (owner: 10Mattflaschen) [08:51:03] (03PS1) 10Legoktm: Gadget::__construct: Add type hint, improve tests [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160200 [09:00:09] (03PS1) 10Legoktm: Use a mock GadgetRepo instead of LocalGadgetRepo::singleton() [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/160201 [09:00:11] (03CR) 10jenkins-bot: [V: 04-1] Use a mock GadgetRepo instead of LocalGadgetRepo::singleton() [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/160201 (owner: 10Legoktm) [09:00:16] bah [09:00:24] (03Abandoned) 10Legoktm: Use a mock GadgetRepo instead of LocalGadgetRepo::singleton() [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/160201 (owner: 10Legoktm) [09:00:33] (03PS1) 10Legoktm: Use a mock GadgetRepo instead of LocalGadgetRepo::singleton() [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160202 [09:10:24] (03CR) 10Legoktm: "Encouraging separation of code development and wiki administration is a good thing, however, for the 99% of MediaWiki installations that w" [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/155745 (owner: 10Legoktm) [09:15:01] 3Wikimedia / 3Wikidata: WikimediaBadges and Wikidata.org extension description messages missing on [[d:Special:Version]] - 10https://bugzilla.wikimedia.org/70804 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3Wikidata bugs See 3MediaWiki skins / 3Other: PHP Fatal error: Class 'BsConfig' not found in skins/BlueSpiceSkin/includes/BlueSpiceSkinHooks.php on line 9 - 10https://bugzilla.wikimedia.org/70793#c1 (10Andre Klapper) But who maintains BlueSpiceSkin? Should probably be CC'ed... [09:22:15] (03CR) 10Ori.livneh: WIP: Have GettingStarted depend on CentralAuth (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/134782 (owner: 10Mattflaschen) [09:26:29] 3MediaWiki skins / 3Other: PHP Fatal error: Class 'BsConfig' not found in skins/BlueSpiceSkin/includes/BlueSpiceSkinHooks.php on line 9 - 10https://bugzilla.wikimedia.org/70793#c2 (10T. Gries) @André: I don't know, who maintains. the rest is only marginal: I noticed this problem while upgrading my wikis t... [09:26:59] 3MediaWiki / 3General/Unknown: EditPage member variable visibility changes broke compatibility for extensions - 10https://bugzilla.wikimedia.org/67984#c10 (10Andre Klapper) (In reply to s7eph4n from comment #9) > This bug should stay open Errm, you wrote that comment while closing this ticket. :) Or you co... [09:32:59] 3MediaWiki extensions / 3Collection: GIFs not supported - 10https://bugzilla.wikimedia.org/70776 (10Andre Klapper) [09:36:14] 3MediaWiki extensions / 3CentralNotice: Show names of countries and country codes - 10https://bugzilla.wikimedia.org/70773 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc [09:39:01] 3MediaWiki / 3General/Unknown: EditPage member variable visibility changes broke compatibility for extensions - 10https://bugzilla.wikimedia.org/67984#c11 (10s7eph4n) 5RESO/FIX>3REOP Did I? Darn... Got confused with the SemanticForms specific bug, I guess. [09:43:31] 3MediaWiki / 3Interface: Show link to add a new section also next to the section edit link of the last section - 10https://bugzilla.wikimedia.org/70805 (10Michael M.) 3NEW p:3Unprio s:3enhanc a:3None On talk pages users often add a new section by editing the last section, which is a bit annoying, as... [09:49:31] 3Wiki Loves Monuments / 3Database: sk id gets truncated - 10https://bugzilla.wikimedia.org/70806 (10Maarten Dammers) 3NEW p:3Unprio s:3normal a:3None See https://git.wikimedia.org/blob/labs%2Ftools%2Fheritage.git/5c085eee5cf6c8d04868f416afbf12d9e6abcab2/erfgoedbot%2Fmonuments_config.py#L7418 code It... [10:14:42] (03PS1) 10Legoktm: Rewrite GadgetTest::testIsAllowed() to use a data provider [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160205 [10:43:14] (03CR) 10Mormegil: "I wonder, shouldn’t all have direction: ltr? Is there any kind of “computer code” written right-to-left? How do our RTL wikis handl" [core] - 10https://gerrit.wikimedia.org/r/159684 (owner: 10Amire80) [10:43:38] (03PS1) 10Shirayuki: i18n: fix typo [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/160206 [10:44:56] (03CR) 10Calak: [C: 031] i18n: Native digits on 'mergehistory-success' [core] - 10https://gerrit.wikimedia.org/r/160173 (owner: 10Reza) [10:59:01] 3MediaWiki extensions / 3Popups: the hovercard shows an image that doesn't exist on the target page - 10https://bugzilla.wikimedia.org/70807 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None 1. Go to https://he.wikipedia.org/wiki/User:Amire80/Latvian . 2. Hover over the link in the article. Obser... [11:06:13] (03CR) 10Nemo bis: "+1 on Legoktm. Consider https://wikiapiary.com/wiki/Extension:Gadgets" [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/155745 (owner: 10Legoktm) [11:10:10] qgil: betalabs does not support SSL, but labs in general definitely does :) [11:11:32] qgil: I could potentially setup a fab host on labs using our puppet code, but it seems to have a lot of prod specific stuff hardcoded in. I think I'll just wait for chase to get back before attempting that [11:12:02] oh, actually, not [11:12:08] it's pretty neatly done [11:12:22] no work needed, actually :) [11:29:35] (03PS1) 10Shirayuki: i18n: improve "tog-hide*" messages [core] - 10https://gerrit.wikimedia.org/r/160208 [11:43:59] 3MediaWiki extensions / 3AbuseFilter: Page creation with article_articleid not 0 - 10https://bugzilla.wikimedia.org/70647#c2 (10Marius Hoch) 5NEW>3RESO/WOR article_articleid still works flawless... see for example https://commons.wikimedia.org/wiki/Special:AbuseLog/559191 which describes a newly created... [11:54:16] 3MediaWiki skins / 3Chameleon: Standard table styles are missing (using 1.24 alpha) - 10https://bugzilla.wikimedia.org/70808 (10MWJames) 3NEW p:3Unprio s:3normal a:3s7eph4n As seen in [0] using MediaWiki 1.24alpha (cdfa366) and Chameleon 1.0-alpha (0099a1c) displays tables without styles (vector skin... [11:56:00] 3MediaWiki skins / 3Chameleon: Standard table styles are missing (using 1.24 alpha) - 10https://bugzilla.wikimedia.org/70808#c1 (10s7eph4n) 5NEW>3ASSI Yeah. I recently had to remove references to common.css and the like. Will have to build a replacement. Working on it. [12:08:45] 3MediaWiki / 3Interface: Show link to add a new section also next to the section edit link of the last section - 10https://bugzilla.wikimedia.org/70805#c1 (10Bartosz Dziewoński) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 5642 *** [12:08:45] 3MediaWiki / 3Page editing: Provide "add new section" link at the bottom of (discussion) pages - 10https://bugzilla.wikimedia.org/5642#c11 (10Bartosz Dziewoński) *** Bug 70805 has been marked as a duplicate of this bug. *** [12:10:16] 3MediaWiki skins / 3Chameleon: "Jump to:navigation, search" is being displayed on each single article page - 10https://bugzilla.wikimedia.org/70810 (10MWJames) 3NEW p:3Unprio s:3normal a:3s7eph4n MediaWiki 1.24alpha (cdfa366), Chameleon 1.0-alpha (0099a1c) As seen in [0], "Jump to:navigation, search... [12:10:59] 3MediaWiki / 3Page editing: MediaWiki should not prevent creation of empty pages - 10https://bugzilla.wikimedia.org/57238#c12 (10Steinsplitter) 5RESO/FIX>3REOP If this is required only for Translation NS, why was "blank pagecration" enabled for all namespaces? Please restore the old config for all Names... [12:18:16] 3MediaWiki / 3Page editing: MediaWiki should not prevent creation of empty pages - 10https://bugzilla.wikimedia.org/57238#c13 (10Bartosz Dziewoński) 5REOP>3RESO/FIX Why? The current behavior is more intuitive. If you want, please open a separate issue. This one, as described, has been fixed and does not... [12:20:59] 3MediaWiki / 3Page editing: MediaWiki should not prevent creation of empty pages - 10https://bugzilla.wikimedia.org/57238#c14 (10Vogone) (In reply to Steinsplitter from comment #12) > If this is required only for Translation NS, why was "blank pagecration" > enabled for all namespaces? > > Please restore th... [12:21:31] 3MediaWiki extensions / 3SemanticForms: Fix invalid text location in Form generated by PageSchema - 10https://bugzilla.wikimedia.org/70811 (10Roland Uuesoo) 3UNCO p:3Unprio s:3normal a:3Yaron Koren Created attachment 16460 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16460&action=edit Patch... [12:22:35] pook -.- [12:29:03] (03CR) 10Alex Monk: [C: 032] Get rid of GadgetPageList::isGadgetPage() [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160197 (owner: 10Legoktm) [12:37:59] 3MediaWiki / 3Database: mysqli: No way to specify the socket location - 10https://bugzilla.wikimedia.org/65998#c5 (10Jesús Martínez Novo (Ciencia Al Poder)) 5PATC>3RESO/FIX Merged for current master (1.24), I'll try to backport to 1.23 [12:40:44] 3MediaWiki / 3Interface: Remove user icon from personal tools in Vector and Monobook skins - 10https://bugzilla.wikimedia.org/45056#c22 (10Bartosz Dziewoński) 5RESO/FIX>3RESO/WON (The icon was changed and not removed, and it seems it's not going to be removed, so I'm changing resolution to WONTFIX.) [12:42:47] (03CR) 10Alex Monk: [C: 032] Add tests for GadgetResourceLoaderModule [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160195 (owner: 10Legoktm) [12:42:54] (03Merged) 10jenkins-bot: Add tests for GadgetResourceLoaderModule [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160195 (owner: 10Legoktm) [12:43:31] 3MediaWiki extensions / 3SemanticForms: PageSchema generated XML is missing Description, DescriptionTooltipMode,TextBeforeField - 10https://bugzilla.wikimedia.org/70812 (10Roland Uuesoo) 3UNCO p:3Unprio s:3normal a:3Yaron Koren Fix XML which is generated from PageSchemaEdit form [12:44:15] 3MediaWiki extensions / 3SemanticForms: PageSchema generated XML is missing Description, DescriptionTooltipMode,TextBeforeField - 10https://bugzilla.wikimedia.org/70812#c1 (10Roland Uuesoo) Created attachment 16461 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16461&action=edit patch [12:46:14] 3MediaWiki / 3JavaScript: [makeCollapsible.js] Provide an option to let the initial state depend on the number of collapsible elements - 10https://bugzilla.wikimedia.org/70762#c1 (10Bartosz Dziewoński) This is the 'autocollapse' option from bug 30352. [12:46:15] 3MediaWiki / 3JavaScript: jQuery.makeCollapsible.js should support 'autocollapse', 'innercollapse' and 'outercollapse' options - 10https://bugzilla.wikimedia.org/30352 (10Bartosz Dziewoński) [12:46:25] (03CR) 10Alex Monk: [C: 032] Move GadgetTest to tests/backend, and rename file to match class [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160196 (owner: 10Legoktm) [12:46:33] (03Merged) 10jenkins-bot: Move GadgetTest to tests/backend, and rename file to match class [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160196 (owner: 10Legoktm) [12:46:38] (03Merged) 10jenkins-bot: Get rid of GadgetPageList::isGadgetPage() [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160197 (owner: 10Legoktm) [12:59:44] 3MediaWiki / 3JavaScript: [jquery.textSelection] Select sample text when splitlines is true - 10https://bugzilla.wikimedia.org/70764#c1 (10Bartosz Dziewoński) 5NEW>3UNCO p:5Low>3Lowest s:5normal>3enhanc selectPeri is documented (in code) not to work with splitlines: selectPeri: true, // Select... [13:05:32] 3MediaWiki extensions / 3SemanticForms: PageSchema: Description, DescriptionTooltipMode,TextBeforeField are not read from XML - 10https://bugzilla.wikimedia.org/70813 (10Roland Uuesoo) 3UNCO p:3Unprio s:3normal a:3Yaron Koren On a category page when going to Edit Schema page, Description,Descriptio... [13:10:21] (03CR) 10Bartosz Dziewoński: "This does not work at all." [core] - 10https://gerrit.wikimedia.org/r/158505 (owner: 10Paladox) [13:10:24] (03CR) 10Bartosz Dziewoński: "This does not work at all." [skins/Vector] - 10https://gerrit.wikimedia.org/r/158515 (owner: 10Paladox) [13:10:57] (03PS1) 10Bartosz Dziewoński: Revert "Add svg version of bullet-icon" [skins/Vector] - 10https://gerrit.wikimedia.org/r/160210 [13:11:09] (03PS1) 10Bartosz Dziewoński: Revert "Add support for svg in .list-style-image" [core] - 10https://gerrit.wikimedia.org/r/160211 [13:11:17] (03CR) 10Bartosz Dziewoński: [C: 032] Revert "Add svg version of bullet-icon" [skins/Vector] - 10https://gerrit.wikimedia.org/r/160210 (owner: 10Bartosz Dziewoński) [13:11:21] (03CR) 10Bartosz Dziewoński: [C: 032] Revert "Add support for svg in .list-style-image" [core] - 10https://gerrit.wikimedia.org/r/160211 (owner: 10Bartosz Dziewoński) [13:11:24] eh. [13:11:35] (03Merged) 10jenkins-bot: Revert "Add svg version of bullet-icon" [skins/Vector] - 10https://gerrit.wikimedia.org/r/160210 (owner: 10Bartosz Dziewoński) [13:15:14] 3MediaWiki skins / 3Vector: Vector: List bullet icon should not be low-res (pixelated on HiDPI screens) - 10https://bugzilla.wikimedia.org/35338#c11 (10Bartosz Dziewoński) This was attempted in 502fffe3bf2cb6a8fccb8059436a038e21153596, but that way doesn't work. If anyone ever works on this, that is one way... [13:18:31] (03Merged) 10jenkins-bot: Revert "Add support for svg in .list-style-image" [core] - 10https://gerrit.wikimedia.org/r/160211 (owner: 10Bartosz Dziewoński) [13:22:26] (03CR) 10Bartosz Dziewoński: [C: 032] "As far as I can tell this works, no one seems to want to review it, and this is a bit of a pressing issue, so I'm just going to merge this" [core] - 10https://gerrit.wikimedia.org/r/159086 (https://bugzilla.wikimedia.org/69924) (owner: 10Krinkle) [13:29:08] (03Merged) 10jenkins-bot: resourceloader: Condition-wrap the HTML tag instead of JS response [core] - 10https://gerrit.wikimedia.org/r/159086 (https://bugzilla.wikimedia.org/69924) (owner: 10Krinkle) [13:29:30] (03PS1) 10Martineznovo: Make MySQLi work with non-standard socket [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/160212 (https://bugzilla.wikimedia.org/65998) [13:31:43] (03CR) 10Martineznovo: "It was a cherry-pick from a74881be24946a0d0fa0f2b3b0f7b403a4fa89e2 with manual conflicts resolved. I guess that's why that line didn't app" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/160212 (https://bugzilla.wikimedia.org/65998) (owner: 10Martineznovo) [13:33:24] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Cascade checkbox no longer works." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/159518 (https://bugzilla.wikimedia.org/33871) (owner: 10Alex Monk) [13:38:44] 3MediaWiki / 3ResourceLoader: [Regression] Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c27 (10Bartosz Dziewoński) 5PATC>3ASSI This is marked as "High major", so I assume that the fix will be deployed by someone on Monday? [13:40:59] 3MediaWiki / 3Database: mysqli: No way to specify the socket location - 10https://bugzilla.wikimedia.org/65998#c7 (10Jesús Martínez Novo (Ciencia Al Poder)) 5PATC>3RESO/FIX ^ this was the backport, but this is now fixed [13:46:02] 3MediaWiki extensions / 3BetaFeatures: Allowed skins are not displayed - 10https://bugzilla.wikimedia.org/70814 (10Seb35) 3NEW p:3Unprio s:3normal a:3Seb35 The list of allowed skins of the BetaFeatures extension (in $prefs[$key]['requirements']['skins']) is not displayed in the HTML code. [13:46:59] 3MediaWiki extensions / 3BetaFeatures: Allowed skins are not displayed - 10https://bugzilla.wikimedia.org/70814#c1 (10Seb35) p:5Unprio>3Normal The problem comes from BetaFeaturesHooks::getPreferences, in the code $prefs[$key]['requirements']['skins'] = array_intersect( $prefs[$key]['requirements']['sk... [13:54:07] (03CR) 10Martineznovo: "Hi Mark. Another user complained about that extension being broken in 1.23, while this change hasn't been merged yet. Would you want to me" [extensions/BlockAndNuke] (REL1_23) - 10https://gerrit.wikimedia.org/r/139593 (owner: 10MarkAHershberger) [13:56:29] spliiiiiit [13:57:56] (03PS1) 10Seb35: Display the required skins [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/160213 (https://bugzilla.wikimedia.org/70814) [14:05:43] (03PS33) 10Paladox: WikiEditor: Fix issue with SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) [14:06:03] (03PS22) 10Paladox: WikiEditor: Convert .css to .less and add SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151616 [14:07:04] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Two more instances of editToken(), in SemanticPageMaker and LiveTranslate." [core] - 10https://gerrit.wikimedia.org/r/146727 (owner: 10Withoutaname) [14:08:44] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: Validate skin requirement is installed before showing it - 10https://bugzilla.wikimedia.org/58623#c4 (10Seb35) 5RESO/FIX>3PATC The current state on the Wikimedia project is without the names of the required skins. In the case it is wanted to keep the c... [14:10:29] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: Validate skin requirement is installed before showing it - 10https://bugzilla.wikimedia.org/58623#c5 (10Seb35) 5PATC>3RESO/FIX Sorry, page error. This comment is for bug 70814. [14:10:59] 3MediaWiki extensions / 3BetaFeatures: Allowed skins are not displayed - 10https://bugzilla.wikimedia.org/70814#c3 (10Seb35) The current state on the Wikimedia project is without the names of the required skins. In the case it is wanted to keep the current state (for Wikimedia and/or for the master branch of... [14:17:02] (03CR) 10Bartosz Dziewoński: "And there's a ton of hits for "user.+getSkin\(" (some might be false positives), though." [core] - 10https://gerrit.wikimedia.org/r/146727 (owner: 10Withoutaname) [14:42:44] 3MediaWiki / 3Categories: Double-entry categorization would be helpful - 10https://bugzilla.wikimedia.org/70669#c1 (10Bawolff (Brian Wolff)) That seems kind of like an odd thing to want (To be honest). I would expect people to want things sorted in some consistent fashion. ------ Potential icky work aroun... [14:44:13] (03PS3) 10Alex Monk: Clean up mediawiki.legacy.protect a bit. [core] - 10https://gerrit.wikimedia.org/r/159518 (https://bugzilla.wikimedia.org/33871) [15:13:55] (03CR) 10Jackmcbarn: [C: 031] Grant all gadgets-*** userrights to sysop group by default [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/155745 (owner: 10Legoktm) [15:27:16] (03CR) 10Alex Monk: [C: 032] Grant all gadgets-*** userrights to sysop group by default [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/155745 (owner: 10Legoktm) [15:27:24] (03Merged) 10jenkins-bot: Grant all gadgets-*** userrights to sysop group by default [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/155745 (owner: 10Legoktm) [15:52:44] 3MediaWiki / 3General/Unknown: Fix extensions depending on skins/common/ - 10https://bugzilla.wikimedia.org/70615#c21 (10Bartosz Dziewoński) Four patches remain to be merged: * https://gerrit.wikimedia.org/r/159352 (SemanticResultFormats) * https://gerrit.wikimedia.org/r/159370 (SecurePoll) * https://gerrit.... [15:54:03] (03CR) 10Bartosz Dziewoński: "Poke? This spinner is currently not being displayed, and I suppose it had a reason to be here." [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/159370 (https://bugzilla.wikimedia.org/70615) (owner: 10Bartosz Dziewoński) [16:14:20] jackmcbarn: I have no idea what sofat is talking about [16:14:58] "sir mediawiki ui is not responsive according to device" indicates to me that he's talking about how mediawiki looks on small-screen devices, but even that's just a guess [16:15:39] he wants to implement a "benchmark performance database"? [16:16:12] i think he's just throwing out random ideas now [16:16:46] ok [16:22:03] (03CR) 10Daniel Kinzler: [C: 032] Move Config::set() to MutableConfig::set() [core] - 10https://gerrit.wikimedia.org/r/159620 (owner: 10Legoktm) [16:22:52] jackmcbarn: he seems to be all over the place [16:23:32] (03CR) 10Bartosz Dziewoński: [C: 032] Clean up mediawiki.legacy.protect a bit. [core] - 10https://gerrit.wikimedia.org/r/159518 (https://bugzilla.wikimedia.org/33871) (owner: 10Alex Monk) [16:24:40] (03PS2) 10Brian Wolff: Make image/vnd.microsoft.icon be an alias for image/x-icon mime type. [core] - 10https://gerrit.wikimedia.org/r/159824 (https://bugzilla.wikimedia.org/69437) (owner: 10Gerrit Patch Uploader) [16:28:47] MatmaRex, so the last thing on the list for that bug is "* No global ProtectionForm variable (certainly not capitalized like that)" [16:29:02] (03Merged) 10jenkins-bot: Move Config::set() to MutableConfig::set() [core] - 10https://gerrit.wikimedia.org/r/159620 (owner: 10Legoktm) [16:29:13] 3MediaWiki / 3JavaScript: Port mediawiki.legacy.protect to modern JavaScript - 10https://bugzilla.wikimedia.org/33871 (10Alex Monk) [16:30:14] (03Merged) 10jenkins-bot: Clean up mediawiki.legacy.protect a bit. [core] - 10https://gerrit.wikimedia.org/r/159518 (https://bugzilla.wikimedia.org/33871) (owner: 10Alex Monk) [16:30:50] (03CR) 10Brian Wolff: "Hi Alexia," [core] - 10https://gerrit.wikimedia.org/r/159824 (https://bugzilla.wikimedia.org/69437) (owner: 10Gerrit Patch Uploader) [16:31:26] (03Abandoned) 10Brian Wolff: Adds missing mime type for image/vnd.microsoft.icon. [core] - 10https://gerrit.wikimedia.org/r/159813 (owner: 10Gerrit Patch Uploader) [16:35:29] (03CR) 10Brian Wolff: Make image/vnd.microsoft.icon be an alias for image/x-icon mime type. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/159824 (https://bugzilla.wikimedia.org/69437) (owner: 10Gerrit Patch Uploader) [16:42:44] 3Wikimedia / 3Media storage: Thumbnails for a specific PDF file on Commons not generated - 10https://bugzilla.wikimedia.org/70734#c3 (10Bawolff (Brian Wolff)) Both evince and xpdf take a long time to display the first page of the pdf file (Although they eventually do display it). Maybe something funky with t... [16:58:01] MatmaRex: I left you a message on plwiki [17:00:09] uhm [17:00:28] ? [17:00:45] PiRSquared: that's the side box thingy, right? [17:01:23] how is it implemented? with a gadget/site script, right? [17:01:37] It's implemented in Cirrus backend [17:01:52] oh. [17:01:53] neat. [17:02:02] The config is here: https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/CirrusSearch-production.php#L25 [17:02:29] it was actually implemented in I15c8f53184 [17:02:44] https://gerrit.wikimedia.org/r/#/c/105986/ [17:04:06] eh, i don't really want to push another thing through, i have enough responsibilities already. sorry [17:04:33] (03PS3) 10Jackmcbarn: Improve performance of PHP ustring [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/145625 [17:04:34] maybe you should just ask on our village pump page [17:04:41] I don't speak Polish. [17:04:52] at least, not well [17:05:04] (proposals village pump is https://pl.wikipedia.org/wiki/Wikipedia:Kawiarenka/Propozycje ) [17:06:05] PiRSquared: most editors understand english at least at a basic level, and if people find your idea interesting they'll surely translate what you write :) [17:06:17] Okay. [17:08:33] For such things it's better to have local "champions"; but whatever [17:11:11] Bug was https://bugzilla.wikimedia.org/show_bug.cgi?id=44420 btw [17:14:15] 3MediaWiki extensions / 3CirrusSearch: Restore interwiki (sister projects) results in search queries - 10https://bugzilla.wikimedia.org/44420 (10Nemo) [17:14:15] 3Wikimedia / 3General/Unknown: Multilingual search on project portals (e.g. www.wikipedia.org) - 10https://bugzilla.wikimedia.org/24767 (10Nemo) [17:14:29] 3Wikimedia / 3General/Unknown: "No page with that title exists" message on en.wikipedia.org is too long, confusing - 10https://bugzilla.wikimedia.org/16283#c11 (10Nemo) (In reply to Nemo from comment #10) > In a Wikimania 2011 (?) workshop on interwikis/cross-wiki issues, the > recommendation emerged to make... [17:16:44] 3Wikimedia / 3General/Unknown: Multilingual search on project portals (e.g. www.wikipedia.org) - 10https://bugzilla.wikimedia.org/24767 (10Nemo) [17:17:27] (03PS4) 10Jackmcbarn: Improve performance of PHP ustring [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/145625 [17:21:37] (03CR) 10Jjanes: "This change causes a lot of phpunit tests which used to run without needing the database to now need the database. Mostly in includes/par" [core] - 10https://gerrit.wikimedia.org/r/155453 (https://bugzilla.wikimedia.org/69789) (owner: 10PleaseStand) [17:22:36] (03PS1) 10Florianschmidtwelzow: Add version check [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/160218 [17:23:20] (03PS2) 10Florianschmidtwelzow: Add version check [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/160218 [17:27:34] (03CR) 10Florianschmidtwelzow: [C: 032] Add version check [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/160218 (owner: 10Florianschmidtwelzow) [17:27:40] (03Merged) 10jenkins-bot: Add version check [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/160218 (owner: 10Florianschmidtwelzow) [17:30:51] (03PS1) 10Florianschmidtwelzow: Add version check [extensions/GoogleLogin] (v0_2_0) - 10https://gerrit.wikimedia.org/r/160219 [17:31:10] (03PS1) 10Florianschmidtwelzow: Add version check [extensions/GoogleLogin] (REL1_24) - 10https://gerrit.wikimedia.org/r/160220 [17:31:16] (03CR) 10Florianschmidtwelzow: [C: 032] Add version check [extensions/GoogleLogin] (REL1_24) - 10https://gerrit.wikimedia.org/r/160220 (owner: 10Florianschmidtwelzow) [17:31:21] (03Merged) 10jenkins-bot: Add version check [extensions/GoogleLogin] (REL1_24) - 10https://gerrit.wikimedia.org/r/160220 (owner: 10Florianschmidtwelzow) [17:31:25] (03CR) 10Florianschmidtwelzow: [C: 032] Add version check [extensions/GoogleLogin] (v0_2_0) - 10https://gerrit.wikimedia.org/r/160219 (owner: 10Florianschmidtwelzow) [17:31:30] (03Merged) 10jenkins-bot: Add version check [extensions/GoogleLogin] (v0_2_0) - 10https://gerrit.wikimedia.org/r/160219 (owner: 10Florianschmidtwelzow) [17:51:14] 3MediaWiki skins / 3Vector: Text typed into search box not visible when using white text on black. - 10https://bugzilla.wikimedia.org/62668#c2 (10Bartosz Dziewoński) The input box and everything else related to search *does* have box text color and background color set (although background in some cases is t... [17:56:45] 3MediaWiki extensions / 3Comments: Comment box does not appear in multiple pages - 10https://bugzilla.wikimedia.org/70411#c3 (10Jack Phoenix) (In reply to aman_josan2001 from comment #0) > I have tried both Stable & Master developer versions of this extension. First off, let me clarify this once again: for [... [17:58:03] 3MediaWiki / 3Interface: Create a tiny fallback skin to use when no proper skins are present - 10https://bugzilla.wikimedia.org/68332#c11 (10Bartosz Dziewoński) 5REOP>3RESO/FIX There isn't, and there will not be, any form of skin autodiscovery outside of the installer or a hypothetical wiki configuration... [17:58:04] 3MediaWiki / 3Installer: Make it possible to render the installer with any skin, or preview skins in the installer - 10https://bugzilla.wikimedia.org/68331 (10Bartosz Dziewoński) [18:02:00] 3MediaWiki / 3Installer: Whoops! The default skin for your wiki ($wgDefaultSkin), vector, is not available right after installation - 10https://bugzilla.wikimedia.org/70222#c3 (10Bartosz Dziewoński) I disagree. I think the installer is the only part of MediaWiki that should have anything to do with skin aut... [18:04:16] 3MediaWiki / 3Installer: Whoops! The default skin for your wiki ($wgDefaultSkin), vector, is not available right after installation - 10https://bugzilla.wikimedia.org/70222 (10Bartosz Dziewoński) [18:04:17] 3MediaWiki / 3Installer: Command-line installer (maintenance/install.php) doesn't discover skins and add them to LocalSettings? - 10https://bugzilla.wikimedia.org/70815 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None Per bug 70222 comment 0, command-line installer (maintenance/install.php) do... [18:04:47] 3MediaWiki / 3Installer: Command-line installer (maintenance/install.php) doesn't discover skins and add them to LocalSettings? - 10https://bugzilla.wikimedia.org/70815 (10Bartosz Dziewoński) [18:04:47] 3MediaWiki / 3General/Unknown: Move all four core skins to separate repositories and include them in the tarball - 10https://bugzilla.wikimedia.org/68333 (10Bartosz Dziewoński) [18:04:47] 3MediaWiki / 3General/Unknown: Move all four core skins to separate repositories and include them in the tarball - 10https://bugzilla.wikimedia.org/68333 (10Bartosz Dziewoński) [18:04:48] 3MediaWiki / 3Installer: Whoops! The default skin for your wiki ($wgDefaultSkin), vector, is not available right after installation - 10https://bugzilla.wikimedia.org/70222 (10Bartosz Dziewoński) [18:09:15] (03PS1) 10Jack Phoenix: Missing $extension parameter for UploadBase::detectScript() [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/160221 (https://bugzilla.wikimedia.org/65431) [18:10:05] (03CR) 10Jack Phoenix: [C: 032] Missing $extension parameter for UploadBase::detectScript() [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/160221 (https://bugzilla.wikimedia.org/65431) (owner: 10Jack Phoenix) [18:10:10] (03Merged) 10jenkins-bot: Missing $extension parameter for UploadBase::detectScript() [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/160221 (https://bugzilla.wikimedia.org/65431) (owner: 10Jack Phoenix) [18:12:59] 3MediaWiki extensions / 3SocialProfile: Special:GiftManagerLogo image upload failure - 10https://bugzilla.wikimedia.org/65431#c4 (10Jack Phoenix) 5PATC>3RESO/FIX (In reply to Papaver Josepherum from comment #0) > Hey dude, great work on the extension! I've cloned the master build to my > local wiki v1.22... [18:19:14] (03CR) 10Anomie: "There's not going to be a "query-continue" input parameter. Right now this parameter does nothing because it selects the default behavior." [core] - 10https://gerrit.wikimedia.org/r/154092 (owner: 10Anomie) [18:27:33] (03PS3) 10Anomie: API: Add rawcontinue parameter to action=query [core] - 10https://gerrit.wikimedia.org/r/154092 [18:27:35] (03PS1) 10Anomie: API: Warn when neither rawcontinue nor continue are given to action=query [core] - 10https://gerrit.wikimedia.org/r/160222 [18:27:37] (03PS1) 10Anomie: API: Change default continuation format for action=query [core] - 10https://gerrit.wikimedia.org/r/160223 [18:27:58] (03CR) 10Anomie: [C: 04-2] "Not ready to merge yet; will probably do so in 1.25." [core] - 10https://gerrit.wikimedia.org/r/160222 (owner: 10Anomie) [18:28:15] (03CR) 10Anomie: [C: 04-2] "Not ready to merge yet; will probably do so in 1.26." [core] - 10https://gerrit.wikimedia.org/r/160223 (owner: 10Anomie) [18:31:16] 3MediaWiki / 3Installer: Add support for enabling skins in the installer, the way we handle extensions - 10https://bugzilla.wikimedia.org/66440 (10Bartosz Dziewoński) [18:31:16] 3MediaWiki / 3Installer: Command-line installer (maintenance/install.php) doesn't discover skins and add them to LocalSettings? - 10https://bugzilla.wikimedia.org/70815 (10Bartosz Dziewoński) 5NEW>3ASSI a:3Bartosz Dziewoński [18:34:46] (03CR) 10jenkins-bot: [V: 04-1] API: Warn when neither rawcontinue nor continue are given to action=query [core] - 10https://gerrit.wikimedia.org/r/160222 (owner: 10Anomie) [18:35:36] (03PS1) 10Bartosz Dziewoński: Support for enabling skins in the command-line installer [core] - 10https://gerrit.wikimedia.org/r/160224 (https://bugzilla.wikimedia.org/70815) [18:36:26] (03CR) 10Bartosz Dziewoński: "Not tested at all yet." [core] - 10https://gerrit.wikimedia.org/r/160224 (https://bugzilla.wikimedia.org/70815) (owner: 10Bartosz Dziewoński) [19:12:11] (03CR) 10Edokter: "And that was the problem I was trying to remember..." [skins/Vector] - 10https://gerrit.wikimedia.org/r/158515 (owner: 10Paladox) [19:38:14] 3Wikimedia / 3Media storage: Thumbnails for a specific PDF file on Commons not generated - 10https://bugzilla.wikimedia.org/70734#c4 (10Elitre) I tried to upload it again to test but nothing changes. :/ [19:54:18] MatmaRex, hey. That 404 issue someone mentioned the other day has apparently gone. :) [20:25:00] Bug or feature? On https://www.mediawiki.org/wiki/Help:Images find the string '[[File:Example.jpg|frame|50px]]'. The picture is definitely wider than 50px. [20:31:48] FoxT: See above: "An image with frame always ignores the size specification, the original image will be reduced if it exceeds the maximum size defined in user preferences." [20:32:25] andre__: Ah, thx! [20:33:27] FoxT: So works as specified. Although I wonder about the reason for such a spec. [20:33:49] Krenair: :D [20:46:42] (03PS1) 10Prtksxna: core: Refactor selectPopupElements [extensions/Popups] - 10https://gerrit.wikimedia.org/r/160234 [20:49:40] (03CR) 10Prtksxna: "> It seems all that the JS does is hide the current section, so why not do that in the template itself and only show the sub sections for " [core] - 10https://gerrit.wikimedia.org/r/158856 (owner: 10Prtksxna) [20:51:08] (03PS1) 10Arlolra: WIP: Include settings in collection id [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/160235 (https://bugzilla.wikimedia.org/68836) [20:54:57] (03PS7) 10Prtksxna: kss: Add js to hide non current sub-sections [core] - 10https://gerrit.wikimedia.org/r/158856 [20:54:59] (03PS8) 10Prtksxna: kss: Highlight section link based on scroll [core] - 10https://gerrit.wikimedia.org/r/158858 [20:56:30] (03PS1) 10Arlolra: WIP: Apply some of the settings from the ui [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/160237 (https://bugzilla.wikimedia.org/68836) [21:04:14] 3MediaWiki extensions / 3PageImages: the hovercard shows an image that doesn't exist on the target page - 10https://bugzilla.wikimedia.org/70807#c1 (10Prateek Saxena) Seems to be a PageImages bug. [21:05:29] 3MediaWiki extensions / 3PageImages: the hovercard shows an image that doesn't exist on the target page - 10https://bugzilla.wikimedia.org/70807#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/Fd1le5dO [21:16:35] (03CR) 10Bartosz Dziewoński: Revamp classic edit toolbar not to hardcode paths in HTML (033 comments) [core] - 10https://gerrit.wikimedia.org/r/155442 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [21:16:37] (03PS9) 10Bartosz Dziewoński: Revamp classic edit toolbar not to hardcode paths in HTML [core] - 10https://gerrit.wikimedia.org/r/155442 (https://bugzilla.wikimedia.org/69277) [21:31:59] (03PS1) 10Jack Phoenix: Fix some incorrect URLs [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/160239 [21:32:15] (03CR) 10Jack Phoenix: [C: 032] Fix some incorrect URLs [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/160239 (owner: 10Jack Phoenix) [21:32:20] (03Merged) 10jenkins-bot: Fix some incorrect URLs [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/160239 (owner: 10Jack Phoenix) [21:40:37] Krenair: https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/Gadgets+branch:RL2,n,z still some more open if you're interested :D [21:40:45] Yeah. [21:40:46] (and thanks for the merges!) [21:40:50] I was trying to get your attention earlier. [21:41:05] my bouncer died in the netsplits [21:41:07] After I merged a couple that looked good, I went and checked everything. [21:41:11] what's up? [21:41:31] It seems another patch broke something. [21:41:53] "Use ContentHandler for the Gadget namespace" [21:41:59] Or... Actually does that require update.php to be run? [21:42:09] it doesn't... [21:42:20] did it break existing gadgets or when you create a new one? [21:43:20] legoktm, if I use the revision before it, gadgets get loaded. [21:43:39] But then when I checkout that commit, gadgets don't seem to take effect... [21:44:02] that's...weird. [21:44:14] * legoktm tests [21:48:46] also unrelated [21:48:55] GadgetResourceLoaderModule doesn't have an origin set [21:48:56] that's bad [21:50:45] oh wait, it is set...hm [21:53:05] good news: something is broken! [21:55:03] I don't see deletion updates for gadget definition pages running... [22:04:45] Krenair: ok, I figured out what's causing the bug [22:05:08] now to fix it... [22:11:38] (03PS1) 10Legoktm: Set GadgetDefinitionContentHandler::getContentClass() [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160245 [22:12:01] marktrac1ur: I DUNNO IF YOU ARE WORKING FOR THE WMF ANYMORE [22:12:04] * yuvipanda is SUPER CONFUSED [22:12:40] (03PS2) 10Legoktm: Set GadgetDefinitionContentHandler::getContentClass() [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160245 [22:12:52] Krenair: ^ [22:15:07] yuvipanda: Obviously not [22:24:58] (03CR) 10jenkins-bot: [V: 04-1] Merge remote-tracking branch 'origin/REL1_23' into fundraising/REL1_23 [core] (fundraising/REL1_23) - 10https://gerrit.wikimedia.org/r/160027 (owner: 10Awight) [22:29:30] (03PS1) 10Foxtrott: Styles for printing and the table of contents on pages [skins/chameleon] - 10https://gerrit.wikimedia.org/r/160247 [22:31:33] (03PS2) 10Foxtrott: Styles for printing and the table of contents on pages [skins/chameleon] - 10https://gerrit.wikimedia.org/r/160247 [22:32:16] (03CR) 10Foxtrott: [C: 032 V: 032] Styles for printing and the table of contents on pages [skins/chameleon] - 10https://gerrit.wikimedia.org/r/160247 (owner: 10Foxtrott) [22:33:05] (03PS1) 10Legoktm: Fix subclassing of CssContent and JavaScriptContent [core] - 10https://gerrit.wikimedia.org/r/160248 [22:33:14] Krenair: ^ that should fix it [22:33:15] 3MediaWiki skins / 3Chameleon: "Jump to:navigation, search" is being displayed on each single article page - 10https://bugzilla.wikimedia.org/70810 (10s7eph4n) 5NEW>3RESO/FIX [22:38:48] legoktm, hm. really? [22:39:16] as silly as it looks...yeah. [22:39:22] legoktm, did you test it? [22:39:54] yeah [22:45:00] legoktm, okay, it doesn't actually work for me... [22:46:18] when you create a Gadget:Foo.js page without the patch, after creation it'll say the content model is "JavaScript", delete, apply my patch, create a new page, and now it should say the content model is "GadgetJs" [22:46:44] Or I could change their content model :p [22:47:26] I think it would go back to "JavaScript" as soon as you edited it again. [22:50:18] legoktm, content model is sorted... still not seeing gadgets take affect. [22:52:39] (03PS3) 10Awight: Merge remote-tracking branch 'origin/REL1_23' into fundraising/REL1_22 [core] (fundraising/REL1_23) - 10https://gerrit.wikimedia.org/r/160027 [22:57:25] hmm [22:57:45] someone online who knows mwui codebase? :) [23:06:59] legoktm, can you reproduce the issue? [23:07:08] yes [23:07:11] I'm tracing right now [23:07:16] ok [23:08:15] the problem is ResourceLoaderWikiModule::getContent() [23:19:54] Krenair: will have a patch in a few minutes [23:24:14] 3MediaWiki / 3Interface: Allowing class "new" links to be styled as such in toolbox, etc. - 10https://bugzilla.wikimedia.org/25001#c2 (10Bartosz Dziewoński) 5NEW>3RESO/INV (In reply to Brett Zamir from comment #0) > Due to a selector in main-ltr.css (div#mw-panel div.portal div.body ul li > a:visited), w... [23:28:01] 3MediaWiki / 3MediaWiki UI: Set $wgUseMediaWikiUIEverywhere = true (tracking) - 10https://bugzilla.wikimedia.org/70424 (10Florian) [23:28:01] 3MediaWiki / 3MediaWiki UI: styles conflicting with guided tour - 10https://bugzilla.wikimedia.org/70801 (10Florian) [23:28:10] or not, ugh. this is more complicated than I thought [23:29:15] 3MediaWiki-Vagrant: HHVM doesn't compile on Vagrant - 10https://bugzilla.wikimedia.org/49789 (10Ori Livneh) [23:29:15] 3Wikimedia / 3Mailing lists: Get rid of HHVM (HipHop) mailing list - 10https://bugzilla.wikimedia.org/61212 (10Ori Livneh) [23:29:29] 3MediaWiki-Vagrant: HHVM role fails on provisioning - 10https://bugzilla.wikimedia.org/63683 (10Ori Livneh) [23:30:00] 3MediaWiki extensions / 3WikidataRepo: Remove class_alias or fix HHVM issues with class_alias - 10https://bugzilla.wikimedia.org/64417 (10Ori Livneh) [23:30:00] 3MediaWiki-Vagrant: phpsh fails with memory limit in hhvm - 10https://bugzilla.wikimedia.org/67747 (10Ori Livneh) [23:30:16] 3MediaWiki-Vagrant: Removing the zend role doesn't revert to hhvm - 10https://bugzilla.wikimedia.org/67683 (10Ori Livneh) [23:30:16] 3MediaWiki-Vagrant: maintenance/install.php fails on HHVM - 10https://bugzilla.wikimedia.org/67743 (10Ori Livneh) [23:30:30] 3Wikimedia / 3Interwiki links: Make interwiki links work on new testwiki HHVM server - 10https://bugzilla.wikimedia.org/69332 (10Ori Livneh) [23:30:31] 3MediaWiki-Vagrant: phpsh fails with memory limit in hhvm - 10https://bugzilla.wikimedia.org/67746 (10Ori Livneh) [23:30:47] 3MediaWiki-Vagrant: Expose both PHP and HHVM for the same wiki - 10https://bugzilla.wikimedia.org/67517 (10Ori Livneh) [23:30:47] 3MediaWiki-Vagrant: hhvmsh does not load MediaWiki's context - 10https://bugzilla.wikimedia.org/69420 (10Ori Livneh) [23:30:47] 3MediaWiki-Vagrant: 403 Forbidden when uploading file via AJAX and using hhvm role - 10https://bugzilla.wikimedia.org/65195 (10Ori Livneh) [23:31:23] sorry for the spam. i added the 'hhvm' keyword to bugs that mentioned hhvm in the summary. [23:39:51] (03PS1) 10Legoktm: ResourceLoaderWikiModule: Check content format instead of content model [core] - 10https://gerrit.wikimedia.org/r/160251 [23:41:49] (03PS1) 10Legoktm: Re-add TitleIsCssOrJsPage hook, still necessary for a few things [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/160252 [23:41:51] (03CR) 10jenkins-bot: [V: 04-1] Re-add TitleIsCssOrJsPage hook, still necessary for a few things [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/160252 (owner: 10Legoktm) [23:41:58] (03PS1) 10Legoktm: Re-add TitleIsCssOrJsPage hook, still necessary for a few things [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/160253 [23:42:09] (03Abandoned) 10Legoktm: Re-add TitleIsCssOrJsPage hook, still necessary for a few things [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/160252 (owner: 10Legoktm) [23:42:27] Krenair: https://gerrit.wikimedia.org/r/160251 and https://gerrit.wikimedia.org/r/160253 should fix it [23:43:14] (03CR) 10Alex Monk: [C: 032] Fix subclassing of CssContent and JavaScriptContent [core] - 10https://gerrit.wikimedia.org/r/160248 (owner: 10Legoktm) [23:45:24] legoktm, hm. not just $content instanceof CssContent && $content instanceof JsContent ? [23:45:32] (in https://gerrit.wikimedia.org/r/#/c/160251/1/includes/resourceloader/ResourceLoaderWikiModule.php ) [23:46:50] that would also work, but someone could technically have a content model that stores JavaScript without subclassing JavaScriptContent (or same for CSS) [23:47:07] the only thing that matters if it supports the javascript format [23:47:14] 3Wikimedia / 3General/Unknown: Ogg files stammer - 10https://bugzilla.wikimedia.org/40590#c13 (10Chuck Entz) This is being discussed at English Wiktionary [http://en.wiktionary.org/wiki/Wiktionary:Grease_pit/2014/September#Playing_audio_repeats_the_first_bit_on_the_second_play.]. I've been experiencing this... [23:49:45] (03Merged) 10jenkins-bot: Fix subclassing of CssContent and JavaScriptContent [core] - 10https://gerrit.wikimedia.org/r/160248 (owner: 10Legoktm) [23:50:03] in reality, us subclassing CssContent / JavaScriptContent didn't really do anything except it makes sense from a hierarchical standpoint [23:57:19] legoktm, hm. did that warning before actually work? [23:57:27] or did it just print '$model'? [23:58:16] Pretty sure PHP requires that to be "$model" to work... [23:58:32] nope [23:58:37] It definitely does [23:58:46] even '\n' isn't a newline [23:58:51] er, nope, it didn't work before [23:58:54] > Also fix a debug log comment that didn't work due to improper quoting.