[00:00:31] 3MediaWiki / 3Configuration: Convert things to use Config classes instead of globals (tracking) - 10https://bugzilla.wikimedia.org/69084 (10Kunal Mehta (Legoktm)) [00:00:34] 3MediaWiki / 3Special pages: Special:Version: Use Config instead of globals - 10https://bugzilla.wikimedia.org/70638 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None In master: SpecialVersion.php 56: global $IP, $wgExtensionCredits; 253: global $wgVersion, $IP; 292: g... [00:01:53] (03PS4) 10Bsitu: Add reverse chronological ordering to unread notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158239 (https://bugzilla.wikimedia.org/69919) [00:05:06] (03CR) 10Jdlrobson: [C: 04-1] "I'm fine with the ordering but I'd rather we cleaned up the Makefile to not have such a long line.." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/158850 (owner: 10Mattflaschen) [00:05:34] (03Merged) 10jenkins-bot: Apply vform styling to HTMLForm buttons [core] - 10https://gerrit.wikimedia.org/r/158800 (owner: 10BryanDavis) [00:07:45] (03CR) 10CSteipp: [C: 04-1] "Do we really need the query api for this? Can it be restricted to a right? Otherwise, this doesn't respect username suppression, so I'm wo" (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159266 (owner: 10Legoktm) [00:08:58] 3MediaWiki / 3MediaWiki UI: Deletion page has mw-ui-constructive button, Other/additional reason input is tiny - 10https://bugzilla.wikimedia.org/70134#c13 (10Matthew Flaschen) I didn't -1 it, and I don't know if I can review it today regardless, but please at least tag it with the bug. [00:09:47] (03CR) 10CSteipp: "I need to fix a couple things in I52f94b86730470997327396b6ad53fc5ea7149cf, but that's basically the same thing you would need to do. Add " [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/153983 (https://bugzilla.wikimedia.org/69250) (owner: 10Mitar) [00:09:49] (03PS6) 10Rillke: Create title in file NS and validate as such [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) [00:10:15] (03CR) 10jenkins-bot: [V: 04-1] Create title in file NS and validate as such [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) (owner: 10Rillke) [00:12:52] (03CR) 10Bsitu: [C: 032] Avoid getCleanSignature errors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159417 (owner: 10EBernhardson) [00:13:11] (03PS12) 10Jdlrobson: Fix styling of deletion page when $wgUseMediaWikiUIEverywhere enabled [core] - 10https://gerrit.wikimedia.org/r/154121 (https://bugzilla.wikimedia.org/70134) [00:13:28] (03Merged) 10jenkins-bot: Avoid getCleanSignature errors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159417 (owner: 10EBernhardson) [00:14:11] (03CR) 10Mattflaschen: Sort modules in alphabetical order and leave note about this (031 comment) [core] - 10https://gerrit.wikimedia.org/r/158850 (owner: 10Mattflaschen) [00:18:43] (03PS1) 10Legoktm: StatCounter: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/159434 [00:23:06] (03CR) 10Rillke: Create title in file NS and validate as such (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) (owner: 10Rillke) [00:29:46] 3Wikimedia / 3Site requests: [Regression] Wikitech interwiki for "wikipedia:" is missing / wiki identifies as being a Wikipedia - 10https://bugzilla.wikimedia.org/70641 (10Krinkle) 3NEW p:3Unprio s:3major a:3None Seems ever since the change to use production config lately (or shortly thereafter) the... [00:29:59] 3Wikimedia / 3Site requests: [Regression] Wikitech: Interwiki for "wikipedia:" is missing / wiki identifies as being a Wikipedia - 10https://bugzilla.wikimedia.org/70641 (10Krinkle) [00:30:29] 3Wikimedia / 3Site requests: [Regression] Wikitech: Interwiki for "wikipedia:" is missing / wiki identifies as being a Wikipedia - 10https://bugzilla.wikimedia.org/70641#c1 (10Krinkle) Ugh, there's other weird stuff as well: [00:31:59] 3Wikimedia / 3Site requests: [Regression] Wikitech should not be set up as a Wikipedia (interwiki for "wikipedia:" missing, canonical url labs.wikipedia.org) - 10https://bugzilla.wikimedia.org/70641#c2 (10Krinkle) (In reply to Krinkle from comment #1) > Ugh, there's other weird stuff as well: > > (03PS7) 10Rillke: Create title in file NS and validate as such [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) [00:32:43] 3Wikimedia / 3Site requests: [Regression] Wikitech should not be set up as a Wikipedia (interwiki for "wikipedia:" missing, canonical url labs.wikipedia.org) - 10https://bugzilla.wikimedia.org/70641#c3 (10Krinkle) s:5major>3critic Potentially affects search engine indexing and other weird stuff, bumping... [00:33:10] (03CR) 10Rillke: "console should probably show the errors by default and not the OKs" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) (owner: 10Rillke) [00:33:13] (03CR) 10jenkins-bot: [V: 04-1] Create title in file NS and validate as such [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) (owner: 10Rillke) [00:37:07] (03CR) 10Rillke: "What's the problem with patchsets without explicit dependency? Are they discouraged now? Will we have to press "rebase" before we are goin" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) (owner: 10Rillke) [00:37:32] (03PS7) 10Legoktm: Maintenance: Add an easy way to access Config instances [core] - 10https://gerrit.wikimedia.org/r/152823 [00:43:19] should we add a warning to the installer on the license selection screen that says that if you want to use content from wikipedia (or any other wmf wiki), you need to pick cc-by-sa? [00:44:40] (03CR) 10Legoktm: "PS7: Add test cases" [core] - 10https://gerrit.wikimedia.org/r/152823 (owner: 10Legoktm) [00:45:21] (03CR) 10Rillke: "Sorry, I am unable to resolve this." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) (owner: 10Rillke) [00:47:47] (03CR) 10Bsitu: [C: 04-1] "rebase is needed" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/157673 (owner: 10Lokal Profil) [00:52:02] 3Wikimedia / 3Git/Gerrit: Jenkins Bot voting Verified failed despite Gerrit says "Can Merge" yes and unable to upload rebased patchset (refused by Gerrit) - 10https://bugzilla.wikimedia.org/70642 (10Rainer Rillke @commons.wikimedia) 3NEW p:3Unprio s:3normal a:3None Original bug title: Jenkins Bot vot... [00:52:22] (03CR) 10Rillke: "Filed as Bug 70642" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) (owner: 10Rillke) [00:56:59] (03CR) 10Jackmcbarn: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) (owner: 10Rillke) [00:57:37] (03CR) 10Tim Starling: Make timer/profiler be thread-safe (031 comment) [php/luasandbox] - 10https://gerrit.wikimedia.org/r/159011 (https://bugzilla.wikimedia.org/70177) (owner: 10Tim Starling) [01:11:30] (03PS7) 10Rillke: Read description from metadata and suggest it [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152177 [01:11:57] (03CR) 10jenkins-bot: [V: 04-1] Read description from metadata and suggest it [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152177 (owner: 10Rillke) [01:13:31] (03CR) 10Rillke: "Oh my, is there some problem with JENKINS BOT?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152177 (owner: 10Rillke) [01:13:58] (03PS8) 10Rillke: Read description from metadata and suggest it [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152177 [01:14:17] (03PS9) 10Rillke: Read description from metadata and suggest it [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152177 [01:14:43] (03CR) 10jenkins-bot: [V: 04-1] Read description from metadata and suggest it [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152177 (owner: 10Rillke) [01:28:36] (03CR) 10SG: "Yeah, Jon inadvertently changed the specific naming convention of these. It's my own fault, because they are confusingly named mw-ui-ancho" [core] - 10https://gerrit.wikimedia.org/r/155856 (owner: 10SG) [01:28:46] (03PS6) 10SG: Change mw-ui anchors to require mw-ui-anchor base class [core] - 10https://gerrit.wikimedia.org/r/155856 [01:34:16] 3MediaWiki extensions / 3RecentActivityFeed: Edits with no edit summary do not show [inspect diff] link - 10https://bugzilla.wikimedia.org/70643 (10Sage Ross) 3NEW p:3Unprio s:3normal a:3None If an edit does not include an edit summary, the [inspect diff] link does not appear for that edit. [01:35:02] legoktm: around? [01:38:16] 3MediaWiki extensions / 3RecentActivityFeed: [inspect diff] does not work for the first edit to a page - 10https://bugzilla.wikimedia.org/70644 (10Sage Ross) 3NEW p:3Unprio s:3normal a:3None In cases where a page is created, there is no diff from the prior version and therefore [inspect diff] link.... [01:38:42] (03PS7) 10SG: Change mw-ui anchors to require mw-ui-anchor base class [core] - 10https://gerrit.wikimedia.org/r/155856 [01:41:16] (03CR) 10SG: "Bump. Clarification, please?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155612 (owner: 10SG) [01:43:34] (03PS3) 10Jsahleen: Adding additional logging to ContentTranslationsService.js [services/cxserver] - 10https://gerrit.wikimedia.org/r/159336 [01:45:10] (03PS2) 10Jsahleen: Logging: Add logging to JsonDict.js [services/cxserver] - 10https://gerrit.wikimedia.org/r/159362 [01:47:49] James_F|Away: Looking now. [01:53:15] 3MediaWiki / 3User preferences: Preferences saved notification should use overlay style toaster notification rather than altering the page - 10https://bugzilla.wikimedia.org/65984#c1 (10MZMcBride) JZ: Sorry, but I have no idea what "Preferences saved notification should use overlay style toaster notification... [01:55:30] 3MediaWiki / 3Interface: toaster overlay for watchlisting is inconsistent between mobile and desktop - 10https://bugzilla.wikimedia.org/65983#c6 (10MZMcBride) (In reply to Bartosz Dziewoński from comment #4) > https://i.imgur.com/LRdNoVP.jpg :D But really. I left a note at bug 65984 comment 1 that also app... [02:03:29] 3MediaWiki / 3User preferences: Changes to user preferences should be automatically saved - 10https://bugzilla.wikimedia.org/56561#c2 (10MZMcBride) (In reply to Dan Garry from comment #0) > Rather than having to click save every time a preference is changed, it > would be nice if changes would save automatic... [02:31:38] (03PS3) 10Jsahleen: Logging: Add logging to JsonDict.js [services/cxserver] - 10https://gerrit.wikimedia.org/r/159362 [02:54:29] 3MediaWiki-Vagrant: Enabling role mobilefrontend causes puppet run failures - 10https://bugzilla.wikimedia.org/70314#c8 (10Bryan Davis) It looks to me like puppet is doing this: * Run Exec['mobilewiki_check_settings'] which fails to connect to db and notifies Exec['mobile_setup'] * Run Exec['mobile_setup'] be... [02:58:17] (03PS1) 10BryanDavis: Cleanup more files on `vagrant destroy` [vagrant] - 10https://gerrit.wikimedia.org/r/159449 [03:15:45] 3MediaWiki-Vagrant: Enabling role mobilefrontend causes puppet run failures - 10https://bugzilla.wikimedia.org/70314#c9 (10Bryan Davis) Dan has a pending patch at Ia2ff2ab53966ade7bbacd705dc43369345d1b0e0 that will probably fix this as an unintended but happy side effect. I'll test that patch and see if I can... [03:18:58] (03PS1) 10Jsahleen: Logging: Updating logging on DictClient.js and Dict.js [services/cxserver] - 10https://gerrit.wikimedia.org/r/159450 [03:51:01] 3MediaWiki-Vagrant: apt-get update does not always run on initial provision of new vm - 10https://bugzilla.wikimedia.org/70646 (10Bryan Davis) 3NEW p:3Unprio s:3normal a:3None This has happened to me twice today while I've been testing a bug that only happens on during initial provisioning. * Vagrant... [04:07:00] (03PS1) 10Ori.livneh: Replace references to /u/l/a/common-local with /srv/mediawiki [tools/scap] - 10https://gerrit.wikimedia.org/r/159451 [04:07:32] 3MediaWiki / 3General/Unknown: Integrate Wikifont into Core/Extension - 10https://bugzilla.wikimedia.org/66138#c11 (10Matthew Flaschen) 5PATC>3RESO/WON Per above, the decision was to use SVG/PNG, rather than a font, on web (including mobile web). However, we can still use the actual WikiFont glyphs (whi... [04:12:42] (03CR) 10BryanDavis: [C: 032] Replace references to /u/l/a/common-local with /srv/mediawiki [tools/scap] - 10https://gerrit.wikimedia.org/r/159451 (owner: 10Ori.livneh) [04:12:58] (03Merged) 10jenkins-bot: Replace references to /u/l/a/common-local with /srv/mediawiki [tools/scap] - 10https://gerrit.wikimedia.org/r/159451 (owner: 10Ori.livneh) [04:25:56] (03PS2) 10BryanDavis: Wiki installer now conditional on existence of database [vagrant] - 10https://gerrit.wikimedia.org/r/159217 (https://bugzilla.wikimedia.org/50912) (owner: 10Dduvall) [04:26:57] (03CR) 10BryanDavis: [C: 032] "Fixes two bugs so I think the color of the bike shed can be determined later. :)" [vagrant] - 10https://gerrit.wikimedia.org/r/159217 (https://bugzilla.wikimedia.org/50912) (owner: 10Dduvall) [04:27:02] (03Merged) 10jenkins-bot: Wiki installer now conditional on existence of database [vagrant] - 10https://gerrit.wikimedia.org/r/159217 (https://bugzilla.wikimedia.org/50912) (owner: 10Dduvall) [04:31:49] (03CR) 10SG: "AFAIK all concerns have been addressed for a month now. Does anyone want to look at this again?" [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG) [04:42:58] (03CR) 10Nemo bis: "I'm interested in the choice you made for the language detection: what convinced you in guessLanguage.js? Oh but you removed it now." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152177 (owner: 10Rillke) [04:43:29] 3MediaWiki-Vagrant: Fatal PHP errors can prompt Vagrant to re-configure MediaWiki - 10https://bugzilla.wikimedia.org/50912#c6 (10Bryan Davis) 5PATC>3RESO/FIX Tested fix by deliberately introducing a syntax error in LocalSettings.php. In my particular configuration, the next puppet run failed with an error... [04:45:29] 3MediaWiki-Vagrant: Enabling role mobilefrontend causes puppet run failures - 10https://bugzilla.wikimedia.org/70314#c12 (10Bryan Davis) 5PATC>3ASSI The merged patch fixed the problem for me, but I'd like Yuri to confirm before closing. [04:49:00] (03CR) 10Ori.livneh: "Previous reviewers: any reason not to merge this?" [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG) [04:51:40] (03PS2) 10BryanDavis: Cleanup more files on `vagrant destroy` [vagrant] - 10https://gerrit.wikimedia.org/r/159449 [04:53:58] (03CR) 10Ori.livneh: [C: 032] Cleanup more files on `vagrant destroy` [vagrant] - 10https://gerrit.wikimedia.org/r/159449 (owner: 10BryanDavis) [04:54:04] (03Merged) 10jenkins-bot: Cleanup more files on `vagrant destroy` [vagrant] - 10https://gerrit.wikimedia.org/r/159449 (owner: 10BryanDavis) [05:18:46] 3MediaWiki skins / 3Vector: Vector: Default icon for "profile" in personal tools should be gender neutral and fit with other site icons look & feel - 10https://bugzilla.wikimedia.org/41484 (10Nemo) [05:18:46] 3MediaWiki / 3General/Unknown: Integrate Wikifont into Core/Extension - 10https://bugzilla.wikimedia.org/66138#c12 (10Nemo) This is closed, so it can't block open bugs. [05:18:58] 3MediaWiki extensions / 3Translate: Several resource images missing svg version - 10https://bugzilla.wikimedia.org/60948 (10Nemo) [05:19:03] 3MediaWiki / 3Interface: Watchlist icon does not match on desktop and mobile skin - 10https://bugzilla.wikimedia.org/54307 (10Nemo) [05:19:04] 3MediaWiki extensions / 3VectorBeta: CPB: Compact personal bar should have RTL version of icons - 10https://bugzilla.wikimedia.org/64789 (10Nemo) [05:19:16] 3MediaWiki extensions / 3WikidataClient: pencil icon for "Edit links" should use wikifont - 10https://bugzilla.wikimedia.org/65527 (10Nemo) [05:19:16] 3MediaWiki / 3Interface: External link Icon does not use asset from Wikifont - 10https://bugzilla.wikimedia.org/66218 (10Nemo) [05:19:17] 3MediaWiki / 3Interface: https/secure link icon does not use asset from Wikifont - 10https://bugzilla.wikimedia.org/66219 (10Nemo) [05:26:29] (03PS3) 10Yurik: Create wiki pages & images from files [core] - 10https://gerrit.wikimedia.org/r/154704 [05:26:43] (03CR) 10Yurik: Create wiki pages & images from files (031 comment) [core] - 10https://gerrit.wikimedia.org/r/154704 (owner: 10Yurik) [05:27:33] legoktm, when you have a chance - i hope i address your concerns ^ [05:28:53] yurikR: I think I fixed your provisioning bug (by merging a patch Dan wrote) [05:29:09] bd808, awesome!!! thx! [05:29:41] Puppet was choosing to do something very strange when that role was enabled. [05:29:53] I wrote a bunch of stuff about it on the bug [05:30:02] so far no bugs - btw, i suspect my biggest problem was some weird leftover config in the /settings/wikis or puppet-managed [05:30:22] so at some point it might be wise to re-gen those files on provision [05:30:42] it doesn't take long to re-generate them, but might reduce headackes [05:31:41] I added more files to the cleanup hook we run on `vagrant destroy` to try and help with that [05:32:14] bd808, i think we should do it during the regular provisioning too [05:32:29] ewww. That's dangerous [05:32:34] being "managed by puppets" implies that we can re-create them at any moment [05:32:35] why? [05:32:47] LocalSettings.php does "stuff" [05:33:17] localsettings can do all the stuff it wants - during provision we should restore all the puppet's settings to their standard at the moment [05:33:18] Things in puppet-managed directories are actively manged during provision already [05:33:53] Puppet will delete things that don't belong and ensure that things that are there have the right content [05:33:53] exactly, but i suspect older puppet versions could have different settings that might be left behind [05:34:08] e.g. if i disable or reset a role, the settings file should disapear [05:34:14] It will [05:34:30] but also, if i do a git pull, and the new version of the puppet doesn't create a file, the old one should be deleted [05:34:34] which i don't think it does [05:35:07] no. That is only done if we remember to add an "ensure => absent" for the resorce that is removed [05:35:45] The best thing to do it destroy and recrate your vm on a regular basis (once every week or two) [05:36:06] (03CR) 10Jjanes: [C: 04-1] "The commit message is rather terse. What problem is this solving?" [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/158310 (https://bugzilla.wikimedia.org/70376) (owner: 10Reedy) [05:36:10] The super paranoid thing to do it destroy and recreate after making each patch [05:36:54] right, but i suspect it would be also good to simply delete all /wikis & /puppet-managed (why do we even have 2 btw) and re-generate them on each provision. Thing is, i consider "provision" as almost identical to destroy/recreate without the DB reet [05:37:00] reset* [05:37:53] It;s not the same at all though. You've just picked up an incorrect mental model [05:39:14] yurikR is right btw that making multiwiki the default left some technical debt in the form of directory trees that are either redundant or misnamed [05:39:32] (03PS1) 10Shirayuki: i18n: remove "nowiki" tags from "en.json" [extensions/ReassignEdits] - 10https://gerrit.wikimedia.org/r/159452 [05:39:51] puppet-managed is for things that effect the whole farm. [05:40:13] but It could be moved [05:41:01] It could move under wikis easily enough [05:41:09] right, but "puppet managed" and "multiwiki" are not complementary [05:42:01] I'm not sure I follow [05:42:39] the files in multiwiki are also managed by puppet [05:43:44] Mostly. Users can put per-wiki config in there too [05:43:56] but that maybe a useless feature [05:44:23] wikis//settings.d/puppet-managed is puppet managed [05:44:49] but php files in wikis//settings.d/*.php will be loaded too [05:46:04] it's too complicated i think [05:46:13] probably [05:47:58] 3MediaWiki-Vagrant: Audit base install to see if resource footprint can be reduced - 10https://bugzilla.wikimedia.org/70421#c2 (10Bryan Davis) Start a clean vm: * vagrant destroy -f * vagrant reset-roles * vagrant up * vagrant ssh Check resources in use: $ ps ax|wc -l 95 $ free -m total u... [05:48:32] bd808, if we are to support roles and multi-wikis, we should have an extra param for them too - enable-role newrole all/wikiname, and have commands like add-wiki, remove-wiki, list-wiki [05:48:42] sorry, my connection went down [05:49:10] * yurikR is reading logs [05:49:48] So the cure for complexity is more complexity? [05:51:25] The RelEng team is going to do a survey about MWV usage to help get some better feedback about use cases. [05:51:38] oh, neat! [05:51:42] I think major changes should probably wait on that [05:51:58] Had you not been poked about that ori? [05:52:44] I'd give you a link, but it was in fab… :( [05:53:08] bd808: http://i.imgur.com/i1hRavI.png [05:53:24] ouch [05:53:29] i don't do a great job of keeping up [05:53:40] Mine has (1) unread [05:54:13] 3,515... [05:54:22] found it: https://www.mediawiki.org/wiki/Wikimedia_Release_Engineering_Team/Vagrant_survey [05:54:36] oh, sorry, that's personal. WMF is 7,930 [05:54:54] ori, i'm much worse ) [05:55:38] * bd808 archives junk obsessively with filters and probably spends too much time reading email [05:56:36] my performance review was full of "should communicate better" [05:56:57] so i probably spend too little and you're probably at the right spot [05:57:13] yurikR: ADHD? [05:58:13] 3MediaWiki extensions / 3ZeroPortal: Zero related thumbnailing error - 10https://bugzilla.wikimedia.org/70619#c2 (10Yuri Astrakhan) Meh, sounds like an internal imgmagick error. I'm contemplating switching to node.js to render the banner as an image. Would solve other problems like dealing with complex fonts. [05:59:19] ori, definitly adhd, and possibly some other *d [05:59:28] :) [06:03:28] 3MediaWiki / 3MediaWiki UI: VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages - 10https://bugzilla.wikimedia.org/56363#c13 (10Jared Zimmerman (WMF)) When I hit cancel I get the error "Enter a valid email address" which seems to imply its do... [06:06:30] (03PS1) 10Pastakhov: add highlighting section headers (v 2.1.1) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/159454 [06:07:30] (03CR) 10Pastakhov: [C: 032] add highlighting section headers (v 2.1.1) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/159454 (owner: 10Pastakhov) [06:07:35] (03Merged) 10jenkins-bot: add highlighting section headers (v 2.1.1) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/159454 (owner: 10Pastakhov) [06:08:14] 3MediaWiki / 3User preferences: Changes to user preferences should be automatically saved - 10https://bugzilla.wikimedia.org/56561#c3 (10Jared Zimmerman (WMF)) The visual cue would be the toaster style notification mentioned in in https://bugzilla.wikimedia.org/show_bug.cgi?id=65984 they are small, non-obtru... [06:10:14] 3MediaWiki / 3User preferences: Preferences saved notification should use overlay style toaster notification rather than altering the page - 10https://bugzilla.wikimedia.org/65984#c2 (10Jared Zimmerman (WMF)) Ryan, can you possibly point to the code/component used in mobile frontend for the toaster notificat... [06:14:29] 3MediaWiki / 3Export/Import: Special:Import increases NUMBEROFARTICLES for each Revision instead of each Article - 10https://bugzilla.wikimedia.org/40009#c29 (10Andyrom75) Is something that you can take care about or do you need the support of someone else? [06:16:14] 3MediaWiki / 3General/Unknown: Updating Page count doesn't work reliably when a page is moved - 10https://bugzilla.wikimedia.org/64333#c9 (10Andyrom75) Has the patch been reviewed? Let me know when is possible to perform a test on Wikivoyage. Thanks [06:45:15] (03PS1) 10Pastakhov: fix highlighting links, tags and templates in section headers (v 2.1.2) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/159456 [06:46:03] (03CR) 10Pastakhov: [C: 032] fix highlighting links, tags and templates in section headers (v 2.1.2) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/159456 (owner: 10Pastakhov) [06:46:09] (03Merged) 10jenkins-bot: fix highlighting links, tags and templates in section headers (v 2.1.2) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/159456 (owner: 10Pastakhov) [06:53:30] (03CR) 10Nemo bis: "Added the top 3 SpecialStatistics.php contributors to cc" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/147505 (https://bugzilla.wikimedia.org/65993) (owner: 10Nemo bis) [07:13:14] hi; on labs vagrant I'm getting Error: mwscript importDump.php --wiki=wiki /vagrant/puppet/modules/labs/files/labs_privacy_policy.xml returned 1 instead of one of [0] when provisioning [07:13:30] and the wiki fails to load with a Content Encoding Error in firefox [07:13:47] is this a known issue / is there a known solution? [07:22:29] 3MediaWiki extensions / 3Translate: No enabled connection [Called from CirrusSearch\ElasticsearchIntermediary::failure in /srv/vagrant/mediawiki/extensions/CirrusSearch/includes/ElasticsearchIntermediary.php at line 97] - 10https://bugzilla.wikimedia.org/68636 (10Nemo) 5PATC>3NEW [07:23:15] (03Abandoned) 10Nemo bis: Prepare for composer [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/105514 (https://bugzilla.wikimedia.org/49131) (owner: 10Nemo bis) [07:23:44] 3MediaWiki extensions / 3LocalisationUpdate: Add composer.json to LocalisationUpdate extension - 10https://bugzilla.wikimedia.org/49131 (10Nemo) 5PATC>3NEW [07:24:00] 3MediaWiki extensions / 3LocalisationUpdate: Add composer.json to LocalisationUpdate extension - 10https://bugzilla.wikimedia.org/49131 (10Nemo) a:5Nemo>3None [07:30:29] (03PS2) 10Lokal Profil: Make plural entries correct [extensions/Echo] - 10https://gerrit.wikimedia.org/r/157673 [07:41:46] 3MediaWiki extensions / 3AbuseFilter: Page creation with article_articleid not 0 - 10https://bugzilla.wikimedia.org/70647 (10Nemo) 3NEW p:3Unprio s:3normal a:3None Docs say "this is 0 for new pages" https://www.mediawiki.org/wiki/Extension:AbuseFilter/Rules_format#All_variables but the linked edit (c... [07:45:35] (03PS1) 10Lokal Profil: Improve error message [extensions/RevisionCommentSupplement] - 10https://gerrit.wikimedia.org/r/159459 [08:08:00] 3MediaWiki / 3Export/Import: Special:Import increases NUMBEROFARTICLES for each Revision instead of each Article - 10https://bugzilla.wikimedia.org/40009#c30 (10This, that and the other (TTO)) a:5This, that and the other (TTO)>3None I don't have time at the moment to look into this. It seems to me that t... [08:12:37] (03CR) 10Krinkle: Add mw-ui-icon (031 comment) [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) (owner: 10Jdlrobson) [08:31:15] 3MediaWiki extensions / 3AbuseFilter: Page creation with article_articleid not 0 - 10https://bugzilla.wikimedia.org/70647 (10Andre Klapper) p:5Unprio>3Normal [08:32:21] legoktm: ping :) [08:32:58] 3Wikimedia / 3Site requests: [Regression] Wikitech should not be set up as a Wikipedia (interwiki for "wikipedia:" missing, canonical url labs.wikipedia.org) - 10https://bugzilla.wikimedia.org/70641 (10Andre Klapper) p:5Unprio>3High [08:34:16] 3MediaWiki / 3File management: Image thumbnails don't preserve EXIF data - 10https://bugzilla.wikimedia.org/11793#c3 (10Jean-Fred) See bug 18871 [08:38:14] 3MediaWiki / 3Interface: Interface messages needing rewording or documentation and other issues with existing messages (tracking) - 10https://bugzilla.wikimedia.org/38638 (10Andre Klapper) [08:39:00] 3MediaWiki / 3Special pages: Special:Version: Use Config instead of globals - 10https://bugzilla.wikimedia.org/70638 (10Andre Klapper) p:5Unprio>3Normal [08:39:00] 3MediaWiki / 3User login and signup: Special:Userlogin: Use Config instead of globals - 10https://bugzilla.wikimedia.org/70637 (10Andre Klapper) p:5Unprio>3Normal [08:40:16] (03CR) 10Florianschmidtwelzow: [C: 031] StatCounter: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/159434 (owner: 10Legoktm) [08:41:14] 3MediaWiki / 3API: Convert ApiQueryExtLinksUsage to use Config instead of globals - 10https://bugzilla.wikimedia.org/70632 (10Andre Klapper) p:5Unprio>3Normal [08:41:47] 3Wikimedia / 3Media storage: Stuck old 1024px thumbnail version of a specific djvu image on wikisource.pl - 10https://bugzilla.wikimedia.org/70189#c7 (10Andre Klapper) 5RESO/FIX>3RESO/WOR (In reply to wieralee from comment #6) > Recently some files disappeared from commons That should be bug 70416 and b... [08:42:21] (03CR) 10Shirayuki: [C: 04-1] "occured -> occurred :)" [extensions/RevisionCommentSupplement] - 10https://gerrit.wikimedia.org/r/159459 (owner: 10Lokal Profil) [08:43:44] 3MediaWiki / 3ContentHandler: Add a special page to change a page's content model when $wgContentHandlerUseDB = true; - 10https://bugzilla.wikimedia.org/70592 (10Andre Klapper) p:5Unprio>3Normal [08:43:59] 3Wikimedia / 3Site requests: Change rights for user groups in hewiki - 10https://bugzilla.wikimedia.org/70616 (10Andre Klapper) p:5Unprio>3Normal s:5normal>3enhanc [08:44:01] 3MediaWiki / 3General/Unknown: Code quality issues (tracking) - 10https://bugzilla.wikimedia.org/700 (10Andre Klapper) [08:44:01] 3MediaWiki extensions / 3CentralAuth: Consolidate page moving code in one place (Renameuser, GlobalRename, UserMerge) - 10https://bugzilla.wikimedia.org/70624 (10Andre Klapper) p:5Unprio>3Normal [09:17:14] 3Wikimedia / 3Media storage: "Original file" seems to be missing at Commons for an image - 10https://bugzilla.wikimedia.org/70416#c3 (10Tisza Gergő) Seems like the same issue as bug 70556 (although the files there have not been deleted+restored, and for some of them even the 800px thumbnail is missing). [09:39:45] (03CR) 10Gilles: [C: 04-1] "The CSS bug doesn't look fixed: https://dl.dropboxusercontent.com/u/109867/gerrit/155833.mov" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester) [09:51:14] (03CR) 10Gilles: [C: 032] Make tutorial step a controller and UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 (owner: 10MarkTraceur) [09:52:22] (03CR) 10jenkins-bot: [V: 04-1] Make tutorial step a controller and UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 (owner: 10MarkTraceur) [10:01:18] (03CR) 10Addshore: [C: 032] StatCounter: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/159434 (owner: 10Legoktm) [10:02:40] (03PS4) 10Addshore: Add $wgExportMaxTime to set a max timelimit on Special:Export [core] - 10https://gerrit.wikimedia.org/r/154843 (owner: 10Legoktm) [10:07:59] (03Merged) 10jenkins-bot: StatCounter: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/159434 (owner: 10Legoktm) [10:09:07] (03CR) 10jenkins-bot: [V: 04-1] Add $wgExportMaxTime to set a max timelimit on Special:Export [core] - 10https://gerrit.wikimedia.org/r/154843 (owner: 10Legoktm) [10:09:46] 3MediaWiki extensions / 3WikidataClient: Badges-Labels not cached properly on client - 10https://bugzilla.wikimedia.org/70649 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Label lookup for badges is causing quite some load. [10:09:59] 3MediaWiki extensions / 3WikidataClient: Badges-Labels not cached properly on client - 10https://bugzilla.wikimedia.org/70649 (10tobias.gritschacher) 5NEW>3ASSI p:5Unprio>3High s:5normal>3critic [10:10:19] (03PS1) 10Pastakhov: add highlighting external links (v 2.1.3) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/159467 [10:11:15] (03CR) 10Pastakhov: [C: 032] add highlighting external links (v 2.1.3) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/159467 (owner: 10Pastakhov) [10:11:20] (03Merged) 10jenkins-bot: add highlighting external links (v 2.1.3) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/159467 (owner: 10Pastakhov) [10:12:00] (03CR) 10Bartosz Dziewoński: "Needs rebase." [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG) [10:53:14] (03PS21) 10SG: mw-ui-button: Revamp the LESS to be simpler, and improve cross-browser support [core] - 10https://gerrit.wikimedia.org/r/123804 [10:55:14] 3MediaWiki extensions / 3WikidataRepo: Switching options with list-rotators does not work in some cases - 10https://bugzilla.wikimedia.org/70294 (10tobias.gritschacher) 5NEW>3RESO/FIX [10:57:19] (03CR) 10SG: [C: 031] "Manually rebased." [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG) [11:01:56] drafts work nice with indexeddb ! [11:02:00] 3MediaWiki extensions / 3WikidataRepo: Autocompletion in linked page suggester missing - 10https://bugzilla.wikimedia.org/66437 (10tobias.gritschacher) p:5Highes>3Normal s:5major>3normal [11:02:08] (03PS3) 10SG: mw-ui-button revamp: Add .mw-ui-regressive color state [core] - 10https://gerrit.wikimedia.org/r/145298 [11:02:15] 3MediaWiki extensions / 3WikidataRepo: Reimplement autocompletion in property suggester - 10https://bugzilla.wikimedia.org/66838 (10tobias.gritschacher) s:5major>3normal [11:02:29] the asyncness really helps on larger pages. [11:07:12] (03PS3) 10SG: mw-ui-button revamp: Adds .mw-ui-sleeper visual type [core] - 10https://gerrit.wikimedia.org/r/145302 [11:12:07] (03PS3) 10SG: mw-ui-button revamp: Adds .mw-ui-thin visual type [core] - 10https://gerrit.wikimedia.org/r/145303 [11:12:43] (03PS4) 10SG: mw-ui-button revamp: Adds .mw-ui-sleeper visual type [core] - 10https://gerrit.wikimedia.org/r/145302 [11:12:47] (03CR) 10Matthias Mullie: [C: 031] "LGTM - since the volume of unread messages shouldn't grow really big, adding timestamp to index probably doesn't matter that much" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158239 (https://bugzilla.wikimedia.org/69919) (owner: 10Bsitu) [11:12:54] (03PS4) 10SG: mw-ui-button revamp: Adds .mw-ui-thin visual type [core] - 10https://gerrit.wikimedia.org/r/145303 [11:16:19] (03CR) 10Mvolz: "This is great, thank you!" [services/citoid] - 10https://gerrit.wikimedia.org/r/157507 (owner: 10Danmichaelo) [11:17:15] (03PS3) 10SG: mw-ui-button revamp: Add .mw-ui-buttonspacer class to mimic button spacing [core] - 10https://gerrit.wikimedia.org/r/145308 [11:26:11] (03CR) 10Daniel Kinzler: [C: 032] Maintenance: Add an easy way to access Config instances [core] - 10https://gerrit.wikimedia.org/r/152823 (owner: 10Legoktm) [11:27:24] (03PS2) 10Lokal Profil: Improve error message [extensions/RevisionCommentSupplement] - 10https://gerrit.wikimedia.org/r/159459 [11:28:25] (03CR) 10Shirayuki: [C: 031] Improve error message [extensions/RevisionCommentSupplement] - 10https://gerrit.wikimedia.org/r/159459 (owner: 10Lokal Profil) [11:29:45] (03CR) 10Lokal Profil: "Thanx, that one went slightly too quick ;)" [extensions/RevisionCommentSupplement] - 10https://gerrit.wikimedia.org/r/159459 (owner: 10Lokal Profil) [11:32:13] (03Merged) 10jenkins-bot: Maintenance: Add an easy way to access Config instances [core] - 10https://gerrit.wikimedia.org/r/152823 (owner: 10Legoktm) [11:39:31] (03CR) 10SG: [C: 032] Fix malformed UTF-8 going to query profiler [core] - 10https://gerrit.wikimedia.org/r/155832 (https://bugzilla.wikimedia.org/69926) (owner: 10SG) [11:40:44] 3MediaWiki extensions / 3WikidataRepo: InvalidArgumentException from line 339 of Item.php - 10https://bugzilla.wikimedia.org/70613#c2 (10WikidataBugzilla) Commit pushed to statements at https://github.com/wmde/WikibaseInternalSerialization https://github.com/wmde/WikibaseInternalSerialization/commit/fa15e5a... [11:44:58] 3MediaWiki extensions / 3WikidataRepo: InvalidArgumentException from line 339 of Item.php - 10https://bugzilla.wikimedia.org/70613#c3 (10Aude) The Item that fails deserializing has Claims on Items. (e.g. no 'rank' in the serialization) the LegacyClaimDeserializer deserializes it as Claim and then does Item:... [11:45:29] 3MediaWiki extensions / 3WikidataRepo: InvalidArgumentException from line 339 of Item.php - 10https://bugzilla.wikimedia.org/70613#c4 (10Aude) btw, I do not know yet how much this is an issue in Wikidata, but likely.... [11:45:50] (03Merged) 10jenkins-bot: Fix malformed UTF-8 going to query profiler [core] - 10https://gerrit.wikimedia.org/r/155832 (https://bugzilla.wikimedia.org/69926) (owner: 10SG) [12:39:00] 3MediaWiki extensions / 3WikidataRepo: InvalidArgumentException from line 339 of Item.php - 10https://bugzilla.wikimedia.org/70613#c5 (10WikidataBugzilla) Commit pushed to statements at https://github.com/wmde/WikibaseInternalSerialization https://github.com/wmde/WikibaseInternalSerialization/commit/64bbf1c... [13:03:14] 3MediaWiki extensions / 3WikidataRepo: InvalidArgumentException from line 339 of Item.php - 10https://bugzilla.wikimedia.org/70613#c6 (10WikidataBugzilla) Commit pushed to statements at https://github.com/wmde/WikibaseInternalSerialization https://github.com/wmde/WikibaseInternalSerialization/commit/3186f09... [13:33:47] 3MediaWiki extensions / 3WikidataRepo: Textbox for search appears below searchbar - 10https://bugzilla.wikimedia.org/70655 (10Zell Faze) 3UNCO p:3Unprio s:3minor a:3Wikidata bugs Created attachment 16425 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16425&action=edit Screenshot showing text... [13:36:37] (03CR) 10Anomie: [C: 04-1] "Code itself looks like it'll work. But why are you making two methods rather than just one, since "getWatchers" is so specialized that it " (034 comments) [core] - 10https://gerrit.wikimedia.org/r/159395 (https://bugzilla.wikimedia.org/66876) (owner: 10EBernhardson) [13:36:59] 3MediaWiki extensions / 3WikidataRepo: Textbox for search appears below searchbar - 10https://bugzilla.wikimedia.org/70655 (10Zell Faze) [13:37:30] (03CR) 10Anomie: Move EmailNotification watchlist handling into helper methods (031 comment) [core] - 10https://gerrit.wikimedia.org/r/159395 (https://bugzilla.wikimedia.org/66876) (owner: 10EBernhardson) [13:43:23] (03CR) 10Anomie: "The mediawiki.org link would be fine. There's only one autocomment there, and it will be picked up correctly rather than left-truncated at" [core] - 10https://gerrit.wikimedia.org/r/159326 (https://bugzilla.wikimedia.org/16530) (owner: 10Anomie) [13:50:53] (03CR) 10Bartosz Dziewoński: "(I have misunderstood what this was about, never mind me. Also, if I don't reply to something for this long, please poke me the next time " [core] - 10https://gerrit.wikimedia.org/r/137690 (https://bugzilla.wikimedia.org/48996) (owner: 10Florianschmidtwelzow) [13:52:59] 3MediaWiki extensions / 3WikidataRepo: Get rid of global events in UI - 10https://bugzilla.wikimedia.org/70172 (10tobias.gritschacher) 5PATC>3RESO/FIX [13:53:15] (03CR) 10Anomie: [C: 04-1] Expose variables (aka magic words) to Lua (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/159238 (owner: 10Jackmcbarn) [13:53:15] 3MediaWiki extensions / 3WikidataRepo: Edit mode for fingerprintlistview widget - 10https://bugzilla.wikimedia.org/69841 (10tobias.gritschacher) 5PATC>3RESO/FIX [13:56:01] 3MediaWiki / 3API: Error message is unclear. "mustposttoken: The 'token' parameter must be POSTed" - 10https://bugzilla.wikimedia.org/70656 (10Aaron Halfaker) 3NEW p:3Unprio s:3normal a:3None This error message happens when performing an edit via the API (action=edit). It means that the token param... [13:56:25] (03PS3) 10Jackmcbarn: Expose variables (aka magic words) to Lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/159238 [13:58:28] 3MediaWiki / 3API: Error message is unclear. "mustposttoken: The 'token' parameter must be POSTed" - 10https://bugzilla.wikimedia.org/70656#c1 (10Brad Jorsch) Either one of those suggestions sounds good to me. I'd prefer the second one as being clearest. If you want to patch ApiMain.php, I'll +2. Otherwise... [14:01:40] anomie: what about the enwiki link? and when would it be useful to parse more than one? [14:02:30] jackmcbarn: Apparently it's useful to someone or the bug wouldn't have been filed when it was broken. The enwiki link is a use-mention distinction, which are always fun. [14:02:44] (when you don't have escaping) [14:13:07] (03CR) 10Anomie: "@Ori:" (032 comments) [php/luasandbox] - 10https://gerrit.wikimedia.org/r/159011 (https://bugzilla.wikimedia.org/70177) (owner: 10Tim Starling) [14:24:15] 3MediaWiki extensions / 3LiquidThreads: personal edit toolbar lost - 10https://bugzilla.wikimedia.org/21692#c16 (10Helder) Ping [14:34:44] 3MediaWiki extensions / 3WikidataRepo: Textbox for search appears below searchbar - 10https://bugzilla.wikimedia.org/70655#c1 (10Andre Klapper) 5UNCO>3NEW Also confirming for Firefox 31 and Chrome 37 on wikidata.org. [14:34:59] 3MediaWiki extensions / 3ConfirmAccount: HTML entities in plain-text e-mail - 10https://bugzilla.wikimedia.org/54621#c1 (10Christie Koehler) We're experiencing this on MozillaWiki as well, where I believe we have REL_23 branch of the extension installed (commit 99f685bb8a7b2b7aa6f227b663e52162d4d537a9). [14:36:12] (03CR) 10Matthias Mullie: "I hadn't noticed because I had no unread alerts, but had unread messages. In that case, the messages tabs would be selected (but because i" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159305 (owner: 10Matthias Mullie) [14:39:31] 3Wikimedia / 3Language setup: Same page served with two different adresses, with two different rel canonical - 10https://bugzilla.wikimedia.org/70657 (10Julien) 3UNCO p:3Unprio s:3trivia a:3None I think I found two intricated "bugs": == Wikipedia accept invalid URI in HTTP requests == According to... [14:45:28] (03CR) 10Manybubbles: [C: 032] "Seeing no objections after 24 hours, +2." [core] - 10https://gerrit.wikimedia.org/r/154291 (owner: 10Aaron Schulz) [14:52:30] (03Merged) 10jenkins-bot: Added DatabaseBase::selectRowCount() method [core] - 10https://gerrit.wikimedia.org/r/154291 (owner: 10Aaron Schulz) [14:56:56] (03PS6) 10Matthias Mullie: Switch the order of Alerts and Messages tabs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159305 [14:57:18] (03CR) 10Chad: [C: 032] Add api to dump mapping and settings [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/158779 (owner: 10Manybubbles) [14:57:37] (03Merged) 10jenkins-bot: Add api to dump mapping and settings [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/158779 (owner: 10Manybubbles) [15:01:13] (03CR) 10Matthias Mullie: [C: 04-1] "Agreed; I'd also prefer to just use default watchlist star" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159332 (owner: 10Matthias Mullie) [15:17:14] 3Wikimedia / 3General/Unknown: Specific animated GIF with large number of frames has no thumbnails created - 10https://bugzilla.wikimedia.org/47409#c2 (10Andre Klapper) More examples: https://commons.wikimedia.org/wiki/File:Cigarette_sales_per_Capita_in_the_United_States,_1970_-_2012.gif https://commons.wiki... [15:20:09] (03CR) 10Matthias Mullie: [C: 032] H-4: Rename Close -> Lock [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158634 (owner: 10EBernhardson) [15:20:49] (03Merged) 10jenkins-bot: H-4: Rename Close -> Lock [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158634 (owner: 10EBernhardson) [15:22:48] (03PS1) 10Matthias Mullie: Change close icon to lock/unlock [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159480 [15:25:51] (03PS2) 10Jdlrobson: Fix missing "Given I am logged in as a new user" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159022 (owner: 10Spage) [15:26:55] (03PS3) 10Jdlrobson: QA: Fix missing "Given I am logged in as a new user" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159022 (owner: 10Spage) [15:27:02] (03CR) 10Jdlrobson: [C: 032] QA: Fix missing "Given I am logged in as a new user" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159022 (owner: 10Spage) [15:27:28] (03Merged) 10jenkins-bot: QA: Fix missing "Given I am logged in as a new user" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159022 (owner: 10Spage) [15:31:10] (03PS7) 10Jdlrobson: Switch the order of Alerts and Messages tabs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159305 (owner: 10Matthias Mullie) [15:32:09] FlorianSW: hey! [15:32:23] legoktm: hey :) [15:32:27] you pinged? [15:32:58] yeah, but i think i have found the answer to my question :) [15:33:03] about: https://gerrit.wikimedia.org/r/#/c/159414/ [15:33:35] if this get merged, jenkins vote +2 for verfied on my patches, right? [15:33:46] (if there are tests for the project) [15:39:34] yup [15:40:27] legoktm: if you're not busy, can you give a third opinion on https://gerrit.wikimedia.org/r/#/c/158943/ ? [15:40:41] * legoktm looks [15:44:12] > especially since the numbers don't match the actual numbering that the parser will use <-- what does the parser use? [15:44:42] legoktm: php's internal ordering of the array [15:45:03] (aka the order they appear in the query string) [15:46:00] 3Wikimedia / 3Media storage: "Original file" seems to be missing at Commons for an image - 10https://bugzilla.wikimedia.org/70416 (10Tisza Gergő) [15:46:00] 3Wikimedia / 3Media storage: 404 errors for three images on Commons - 10https://bugzilla.wikimedia.org/70556 (10Tisza Gergő) [15:48:41] tbh, I don't think the numbers are that much of an issue if they work [15:49:51] i'm concerned that a user will see them there, set up a query like &preloadparams[3]=blue&preloadparams[2]=green&preloadparams[1]=red, feed it to "$1 $2 $3", expect "red green blue", but get "blue green red" [15:52:15] maybe we should ksort() the parameters before using them? [15:52:28] 3Wikimedia / 3Bugzilla: gerrit->bugzilla notification broken (due to Bugzilla 4.4.3 changes in token/session passing) - 10https://bugzilla.wikimedia.org/65370#c22 (10Aric Gardner) @dan, Yeah, from the contents of the .jar I can't actually see inside the .class files to see what was changed to make the gerrit... [15:53:37] legoktm: even if we do that, someone will do &preloadparams[1]=foo&preloadparams[3]=bar into "$1 $2 $3" expecting "foo $2 bar" but getting "foo bar $3" [15:55:16] 3Wikimedia / 3Bugzilla: gerrit->bugzilla notification broken (due to Bugzilla 4.4.3 changes in token/session passing) - 10https://bugzilla.wikimedia.org/65370#c23 (10Sam Reed (reedy)) Created attachment 16426 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16426&action=edit Extracted jar [15:55:27] this is pretty stupid. [15:55:41] it's Message::params()'s fault [15:55:44] 3Wikimedia / 3Bugzilla: gerrit->bugzilla notification broken (due to Bugzilla 4.4.3 changes in token/session passing) - 10https://bugzilla.wikimedia.org/65370#c24 (10Sam Reed (reedy)) ^ Try that? Used http://jd.benow.ca/ [15:56:07] I'd say pick the least broken of all those scenarios and file a follow up bug for what's left :P [15:57:21] (03CR) 10Jackmcbarn: [C: 031] "Per discussion with Legoktm on IRC" [core] - 10https://gerrit.wikimedia.org/r/158943 (owner: 10Umherirrender) [16:05:32] 3MediaWiki extensions / 3WikidataRepo: DiffViewTest failures on travis! - 10https://bugzilla.wikimedia.org/70659 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Wikibase tests on travis have been failing on and off (mostly on) for weeks now! It has something to do with DiffViewTest (and maybe one... [16:05:43] 3MediaWiki extensions / 3WikidataRepo: DiffViewTest failures on travis! - 10https://bugzilla.wikimedia.org/70659#c1 (10Aude) https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/jobs/34913404 [16:07:22] (03PS16) 10Matthias Mullie: [WIP] search [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126996 [16:07:54] (03CR) 10Matthias Mullie: [C: 032] Localize numbers of alerts and messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159044 (owner: 10Amire80) [16:08:27] (03PS2) 10KartikMistry: Logging: Updating logging on DictClient.js and Dict.js [services/cxserver] - 10https://gerrit.wikimedia.org/r/159450 (owner: 10Jsahleen) [16:08:46] (03Merged) 10jenkins-bot: Localize numbers of alerts and messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159044 (owner: 10Amire80) [16:10:33] 3MediaWiki extensions / 3CentralAuth: Exception from line 167 of SpecialCentralLogin.php: The user account logged into does not exist. - 10https://bugzilla.wikimedia.org/70660 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3major a:3None 2014-09-10 16:00:37 mw1103 commonswiki: [9d8436e6] /wiki/Special:Central... [16:11:00] 3MediaWiki extensions / 3WikidataRepo: DiffViewTest failures on travis! - 10https://bugzilla.wikimedia.org/70659 (10tobias.gritschacher) p:5Unprio>3High s:5normal>3major [16:11:47] 3MediaWiki extensions / 3CentralAuth: Exception from line 167 of SpecialCentralLogin.php: The user account logged into does not exist. - 10https://bugzilla.wikimedia.org/70660#c1 (10Kunal Mehta (Legoktm)) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 69834 *** [16:12:01] 3MediaWiki extensions / 3CentralAuth: login when already logged in gets exception from Special:CentralLogin - 10https://bugzilla.wikimedia.org/69834#c17 (10Kunal Mehta (Legoktm)) *** Bug 70660 has been marked as a duplicate of this bug. *** [16:12:37] (03PS1) 10Reedy: Don't do central login if not POSTed [extensions/CentralAuth] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159491 (https://bugzilla.wikimedia.org/69834) [16:12:51] (03PS1) 10Reedy: Don't do central login if not POSTed [extensions/CentralAuth] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159492 (https://bugzilla.wikimedia.org/69834) [16:12:56] any idea what should be fixed in https://gerrit.wikimedia.org/r/#/c/134043/ (from May)? [16:13:26] huh: No one seems to suggest anything is broken [16:13:41] Presumably just not reviewed due to the extension not having an "owner" [16:13:51] huh: sorry, your patches are on my review backlog [16:13:58] just haven't had much time [16:14:06] Thanks for what you have reviewed [16:14:07] (03CR) 10Reedy: [C: 04-1] "Needs rebasing" [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/134043 (https://bugzilla.wikimedia.org/38367) (owner: 10Gerrit Patch Uploader) [16:16:48] (03CR) 10Reedy: Show the globally blocked range in block message (031 comment) [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/134043 (https://bugzilla.wikimedia.org/38367) (owner: 10Gerrit Patch Uploader) [16:16:52] Is checking for a slash in an "IP" good enough detection for IP ranges? [16:17:15] hm [16:17:47] huh: Nope [16:17:57] Based on the core code doing - too... Hence my comment [16:18:02] unless you validate input first [16:22:16] hoo: What about just IP::parseCIDR ? [16:23:56] huh: I'd use IP::parseRange [16:24:10] if range start and end are the same, you have no range [16:27:51] yay, code reuse [16:31:17] we should get rid of the GlobalBlocking message override hoock [16:31:18] hook [16:31:28] it's early >.< [16:36:50] legoktm: why is there a "GlobalBlockingBlockedIpRangeMsg" hook anyway? [16:36:54] It doesn't seem to be used [16:37:11] I think it's used in WikimediaMessages [16:37:12] * GlobalBlockingBlockedIpMsg [16:38:42] MatmaRex, is there any reason you didn't +2 https://gerrit.wikimedia.org/r/#/c/158677/ ? [16:39:00] Krenair: hmmm [16:39:06] probably not [16:39:21] i think i wanted to leave it for a day or two to let anybody who cares comment on it [16:39:23] and forgot [16:39:25] (03CR) 10Bartosz Dziewoński: [C: 032] Merge mediawiki.legacy.upload into mediawiki.special.upload [core] - 10https://gerrit.wikimedia.org/r/158677 (https://bugzilla.wikimedia.org/31946) (owner: 10Alex Monk) [16:39:29] there [16:39:33] MatmaRex, thanks! [16:39:43] thanks for the ping :D [16:39:59] the bug can probably be closed now? [16:40:00] We'll want to do a big sweep of core changes before the 1.24 REL branches start getting cut. [16:40:05] (Fun.) [16:40:21] sweep, as in what? [16:40:43] As in make sure we've done everything we wanted to, and merged all the things that should go out before the release. [16:40:44] 3MediaWiki / 3Uploading: mediawiki.legacy.upload should be migrated to a modern module - 10https://bugzilla.wikimedia.org/31946#c9 (10Alex Monk) 5PATC>3RESO/FIX (In reply to Alex Monk from comment #7) > * Merging the code into mediawiki.special.upload This is done. (In reply to Alex Monk from comment #... [16:40:53] Breaking changes, directory clean-up, etc. [16:41:13] I think I have a patch for https://bugzilla.wikimedia.org/show_bug.cgi?id=33871 somewhere [16:41:17] ah, yeah [16:41:59] 3MediaWiki / 3Uploading: mediawiki.legacy.upload should be migrated to a modern module - 10https://bugzilla.wikimedia.org/31946 (10Bartosz Dziewoński) [16:46:13] (03Merged) 10jenkins-bot: Merge mediawiki.legacy.upload into mediawiki.special.upload [core] - 10https://gerrit.wikimedia.org/r/158677 (https://bugzilla.wikimedia.org/31946) (owner: 10Alex Monk) [16:50:24] (03Abandoned) 10EBernhardson: Allow extensions to handle their contributions entries [core] - 10https://gerrit.wikimedia.org/r/132105 (https://bugzilla.wikimedia.org/64940) (owner: 10EBernhardson) [16:51:28] (03PS1) 10Yaron Koren: Removed 'jquery' as dependency - was never needed, causes problems for 1.24+ [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/159494 [16:52:14] (03CR) 10Yaron Koren: [C: 032 V: 031] Removed 'jquery' as dependency - was never needed, causes problems for 1.24+ [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/159494 (owner: 10Yaron Koren) [16:53:25] (03PS2) 10Umherirrender: Avoid a fatal error in maintenance/cleanupTitles.php [core] - 10https://gerrit.wikimedia.org/r/159116 (owner: 10IAlex) [16:53:42] (03CR) 10Umherirrender: [C: 032] Avoid a fatal error in maintenance/cleanupTitles.php [core] - 10https://gerrit.wikimedia.org/r/159116 (owner: 10IAlex) [16:55:29] 3Wikimedia / 3Deployment systems: Are Scap and LocalisationUpdate actually fighting over l10nupdates? - 10https://bugzilla.wikimedia.org/70446 (10Greg Grossmeier) p:5Unprio>3Normal [16:57:11] (03PS1) 10Legoktm: Add release notes for Iac37a2369 [core] - 10https://gerrit.wikimedia.org/r/159496 [16:57:24] (03CR) 10Legoktm: [C: 032] Add release notes for Iac37a2369 [core] - 10https://gerrit.wikimedia.org/r/159496 (owner: 10Legoktm) [16:58:14] 3Wikimedia / 3Deployment systems: Are Scap and LocalisationUpdate actually fighting over l10nupdates? - 10https://bugzilla.wikimedia.org/70446#c2 (10Bryan Davis) Additional analysis at http://etherpad.wikimedia.org/p/l10nupdate. I also sent an email to Ori, Roan, Sam, Dan and Mukunda to see if they were inte... [17:01:14] (03Merged) 10jenkins-bot: Avoid a fatal error in maintenance/cleanupTitles.php [core] - 10https://gerrit.wikimedia.org/r/159116 (owner: 10IAlex) [17:02:27] (03CR) 10CSteipp: [C: 031] Don't do central login if not POSTed [extensions/CentralAuth] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159491 (https://bugzilla.wikimedia.org/69834) (owner: 10Reedy) [17:04:35] (03Merged) 10jenkins-bot: Add release notes for Iac37a2369 [core] - 10https://gerrit.wikimedia.org/r/159496 (owner: 10Legoktm) [17:08:31] (03CR) 10Reedy: [C: 032] Don't do central login if not POSTed [extensions/CentralAuth] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159491 (https://bugzilla.wikimedia.org/69834) (owner: 10Reedy) [17:08:38] (03CR) 10Reedy: [C: 032] Don't do central login if not POSTed [extensions/CentralAuth] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159492 (https://bugzilla.wikimedia.org/69834) (owner: 10Reedy) [17:08:40] (03CR) 10Aaron Schulz: [C: 032] Ignore duplicate key errors in update-keys.sql [core] - 10https://gerrit.wikimedia.org/r/159119 (owner: 10MaxSem) [17:09:01] (03Merged) 10jenkins-bot: Don't do central login if not POSTed [extensions/CentralAuth] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159491 (https://bugzilla.wikimedia.org/69834) (owner: 10Reedy) [17:09:26] (03Merged) 10jenkins-bot: Don't do central login if not POSTed [extensions/CentralAuth] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159492 (https://bugzilla.wikimedia.org/69834) (owner: 10Reedy) [17:10:59] (03PS1) 10Reedy: Update CentralAuth to 1.24wmf19 HEAD [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159498 [17:12:42] (03PS1) 10Reedy: Update CentralAuth to 1.24wmf20 HEAD [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159499 [17:15:42] (03Abandoned) 10EBernhardson: Explicitly open transaction to be commited in ExternalStoreDB [core] - 10https://gerrit.wikimedia.org/r/136922 (owner: 10EBernhardson) [17:18:40] (03PS7) 10EBernhardson: Correct output of wfMessage( 'non-existent-msg' )->text() [core] - 10https://gerrit.wikimedia.org/r/137458 (https://bugzilla.wikimedia.org/66199) [17:19:07] (03CR) 10jenkins-bot: [V: 04-1] Correct output of wfMessage( 'non-existent-msg' )->text() [core] - 10https://gerrit.wikimedia.org/r/137458 (https://bugzilla.wikimedia.org/66199) (owner: 10EBernhardson) [17:20:12] (03Merged) 10jenkins-bot: Ignore duplicate key errors in update-keys.sql [core] - 10https://gerrit.wikimedia.org/r/159119 (owner: 10MaxSem) [17:21:22] (03PS8) 10EBernhardson: Correct output of wfMessage( 'non-existent-msg' )->text() [core] - 10https://gerrit.wikimedia.org/r/137458 (https://bugzilla.wikimedia.org/66199) [17:25:54] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (f9c217dfa4) [core] - 10https://gerrit.wikimedia.org/r/159502 [17:39:08] (03PS2) 10Legoktm: Add script to make a list of users who will be renamed [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159266 [17:39:19] (03CR) 10jenkins-bot: [V: 04-1] Add script to make a list of users who will be renamed [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159266 (owner: 10Legoktm) [17:39:49] Exception from line 96 of /srv/ssd/jenkins-slave/workspace/mwext-CentralAuth-testextensions-master/includes/db/CloneDatabase.php: Not dropping new table, as 'unittest_user' is name of both the old and the new table. [17:40:14] (03CR) 10Legoktm: "recheck" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159266 (owner: 10Legoktm) [17:40:21] (03CR) 10BryanDavis: [WIP] Special page to manage global rename requests (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159331 (https://bugzilla.wikimedia.org/68924) (owner: 10BryanDavis) [17:40:42] weird. [17:41:12] (03CR) 10Aaron Schulz: [C: 032] Avoid unnecessary database reads [extensions/Math] - 10https://gerrit.wikimedia.org/r/158846 (owner: 10Physikerwelt) [17:42:00] (03CR) 10Esanders: [C: 032] Update OOjs UI to v0.1.0-pre (f9c217dfa4) [core] - 10https://gerrit.wikimedia.org/r/159502 (owner: 10Jforrester) [17:42:23] (03CR) 10Legoktm: "PS2: Got rid of the API module, I was mainly using it as an easy way to test. Fixed the wfWaitForSlaves call to check the centralauth data" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159266 (owner: 10Legoktm) [17:42:33] (03CR) 10Legoktm: Add script to make a list of users who will be renamed (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159266 (owner: 10Legoktm) [17:42:35] (03Merged) 10jenkins-bot: Avoid unnecessary database reads [extensions/Math] - 10https://gerrit.wikimedia.org/r/158846 (owner: 10Physikerwelt) [17:42:37] (03PS1) 10Daniel Kinzler: Do deletion updates after commit. [core] - 10https://gerrit.wikimedia.org/r/159504 [17:46:45] (03CR) 10Daniel Kinzler: [C: 032] Remove JSONContentHandler::$contentClass [core] - 10https://gerrit.wikimedia.org/r/157772 (owner: 10Legoktm) [17:48:00] (03CR) 10Hoo man: [C: 032] "Makes sense to me, wont harm." [core] - 10https://gerrit.wikimedia.org/r/159504 (owner: 10Daniel Kinzler) [17:48:33] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (f9c217dfa4) [core] - 10https://gerrit.wikimedia.org/r/159502 (owner: 10Jforrester) [17:51:06] gwicke, hey, i have some issues rendering text to GIF using imagemagik, and was thinking if i can do the same using node.js. Basically I need a service that will convert a tiny HTML page to a GIF [17:51:17] no need to cache [17:51:47] yurikR: phantomjs can do that [17:51:56] and there's a node module for it that works quite well [17:52:11] gwicke, how hard is it to put it into prod? [17:52:35] legoktm: it seems GlobalCssJs is not updating e.g. ptwikibooks after the global.js is deleted on Meta [17:53:13] I still see a blue link on https://pt.wikibooks.org/wiki/Special:Preferences#mw-prefsection-rendering after deleting the global.js [17:53:19] he7d3r: in the page source, what's the bits.wm.o url that is loading ext.globalCssJs.user ? [17:53:23] ohhh [17:53:24] (03Merged) 10jenkins-bot: Remove JSONContentHandler::$contentClass [core] - 10https://gerrit.wikimedia.org/r/157772 (owner: 10Legoktm) [17:53:40] those are external links, so they're always blue [17:53:43] 3MediaWiki extensions / 3Babel: Allow customization of floating/alignment of the babel box - 10https://bugzilla.wikimedia.org/64164#c2 (10Waldir) (In reply to Waldir from comment #1) > Extra parameters for suppressing the header ("Babel user information"), > footer ("Users by language") and the border of the... [17:54:32] yurikR: How are you doing it currently? [17:54:51] er... more or less.. I actually have a CSS which changes the color of links to JS and CSS pages, so... [17:54:56] (03Merged) 10jenkins-bot: Do deletion updates after commit. [core] - 10https://gerrit.wikimedia.org/r/159504 (owner: 10Daniel Kinzler) [17:55:08] but it shouldn't be loading on Special Preferences if I remember correctly [17:56:06] gwicke, special page gets a request with custom params, and the special page calls shell's "convert" and sends back raw output [17:56:26] Link to the code? [17:56:52] 1 Warning: Error 0 executing convert -trim -border 3 -bordercolor '##FFCC33' -background '##FFCC33' -fill '#000000' -font '/usr/share/fonts/truetype/ttf-dejavu/DejaVuSans.ttf' -pointsize '10' 'label:Your FREE Wikipedia Access is brought to you by SUN' gif:-: convert: geometry does not contain image `Your FREE Wikipedia Access is brought to you by SUN' @ warning/attribute.c/GetImageBoundingBox/239.#012GIF89a#015#001#024 in [17:56:52] /usr/local/apache/common-local/php-1.24wmf19/includes/debug/MWDebug.php on line 302 [17:57:01] legoktm: ok.. a few minutes later, the global JS is not loaded anymore [17:57:03] he7d3r: https://bugzilla.wikimedia.org/show_bug.cgi?id=70071 is slightly related [17:57:04] It's trying ot use a string as a file name or something [17:57:45] (03CR) 10Aaron Schulz: [C: 04-1] Fine grained options for wgMathDisableTeXFilter (033 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/158845 (owner: 10Physikerwelt) [17:57:58] 3MediaWiki / 3Special pages: PHP Fatal error: Cannot use object of type stdClass as array in MobileFrontend.hooks.php on line 304 - 10https://bugzilla.wikimedia.org/67596#c8 (10Sam Reed (reedy)) So after some APC issues on a few servers causing problems for Wikidata, the number of these skyrocketed (again)... [17:58:45] sorry, that was for Reedy. http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FZeroBanner.git/0c15aff0352d38c85e6e761b7abc4eff48f71ad6/includes%2FZeroSpecialPage.php#L92 [17:59:13] (03CR) 10Chad: [C: 032] Show the revision list immediately on "umerge" log action links [core] - 10https://gerrit.wikimedia.org/r/156734 (owner: 10Aaron Schulz) [17:59:35] Reedy, strange - it was working fine for a while [17:59:52] but i would love to switch over to node.js style HTML->GIF rendering [18:00:16] 3MediaWiki / 3User login and signup: Fatal exception of type MWException on Special:CentralLogin - 10https://bugzilla.wikimedia.org/70666 (10Helder) 3NEW p:3Unprio s:3normal a:3None I was on https://bugzilla.wikimedia.org/show_bug.cgi?id=68521 and clicked in the link [[Special:UserLogin]] which appea... [18:01:14] 3MediaWiki extensions / 3CentralAuth: login when already logged in gets exception from Special:CentralLogin - 10https://bugzilla.wikimedia.org/69834#c22 (10Kunal Mehta (Legoktm)) *** Bug 70666 has been marked as a duplicate of this bug. *** [18:01:14] 3MediaWiki / 3User login and signup: Fatal exception of type MWException on Special:CentralLogin - 10https://bugzilla.wikimedia.org/70666#c1 (10Kunal Mehta (Legoktm)) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 69834 *** [18:01:29] 3MediaWiki / 3User login and signup: Fatal exception of type MWException on Special:CentralLogin - 10https://bugzilla.wikimedia.org/70666#c2 (10Sam Reed (reedy)) Due to be fixed in the SWAT deploy later today [18:01:58] 3MediaWiki / 3User login and signup: Fatal exception of type MWException on Special:CentralLogin - 10https://bugzilla.wikimedia.org/70666#c3 (10Helder) The error disappeared after reloading the page change, and then I got "The provided authentication token is either expired or invalid." but the error happene... [18:03:38] yurikR: https://www.google.co.uk/search?q=convert%3A+geometry+does+not+contain+image&oq=convert%3A+geometry+does+not+contain+image&aqs=chrome..69i57j69i58.122j0j7&sourceid=chrome&es_sm=93&ie=UTF-8 [18:05:30] 3MediaWiki extensions / 3GlobalCssJs: Global CSS and JS should not be loaded on [[Special:Preferences]] and [[Special:UserLogin]] - 10https://bugzilla.wikimedia.org/68521#c7 (10Helder) 5VERI>3REOP My global CSS is loaded on Special Preferences (both on Meta and other wikis). [18:05:30] Reedy, thx, will try it now, but this is a short term fix regardless. I don't think imagemgk is the right overall solution here. Ideally, it should be ESI, until that gets done - GIF hack [18:05:34] yurikR: It works on fenari it seems [18:05:44] "works" [18:05:50] ) [18:05:52] (03Merged) 10jenkins-bot: Show the revision list immediately on "umerge" log action links [core] - 10https://gerrit.wikimedia.org/r/156734 (owner: 10Aaron Schulz) [18:06:41] (03PS1) 10EBernhardson: Hygiene: NoIndexExceptions are now expected [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159507 [18:07:04] yurikR: I wonder if it'd be easier to make an svg and convert it [18:08:26] Reedy, good idea, might be worth a try [18:08:47] Anybody know how to edit a new repo request once you've submitted it? [18:08:54] https://www.mediawiki.org/wiki/Git/New_repositories/Requests [18:09:08] Reedy, is there a service i can call in the backend to do it? I need my code to return GIF stream directly [18:09:17] 3Wikimedia / 3Extension setup: add easy timeline extension on urdu wiki - 10https://bugzilla.wikimedia.org/70667 (10Muhammad Shuaib) 3UNCO p:3Unprio s:3normal a:3None Hi, plz install the easy timeline extension on urdu wikipedia. Community consensus page is here: https://ur.wikipedia.org/wiki/%D9%88%... [18:09:29] 3Wikimedia / 3Extension setup: add easy timeline extension on urdu wiki - 10https://bugzilla.wikimedia.org/70667 (10Muhammad Shuaib) [18:09:29] ejegg: Probably just check your contributions and see what page was actualyl changed [18:09:34] {{/Entries}} seems to pull them all in from ...somewhere [18:10:01] 3MediaWiki extensions / 3Babel: Properly align language code cells in babel box - 10https://bugzilla.wikimedia.org/70668 (10Waldir) 3NEW p:3Unprio s:3normal a:3None When the babel box features both languages that have 2-letter codes and languages that have 3-letter codes, the width of the code cells... [18:10:16] 3MediaWiki extensions / 3GlobalCssJs: Global CSS and JS should not be loaded on [[Special:Preferences]] and [[Special:UserLogin]] - 10https://bugzilla.wikimedia.org/68521#c8 (10Helder) On https://meta.wikimedia.org/wiki/Special:Preferences#mw-prefsection-rendering I get this in the console (on Firefox): > mw... [18:11:45] ejegg: https://www.mediawiki.org/w/index.php?title=Git/New_repositories/Requests/Entries&action=edit [18:11:47] he7d3r: pm [18:11:52] ejegg: /FOO is relative [18:12:14] ahh, thanks very much Reedy! [18:12:50] (03PS2) 10EBernhardson: Hygiene: NoIndexExceptions are now expected [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159507 [18:12:53] (03PS1) 10EBernhardson: Hygiene: Workflow lookup now uses workflow_type parameter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159510 [18:13:00] (03PS1) 10Yurik: Updated ZeroBanner to master [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159511 [18:13:34] (03PS1) 10Yurik: Updated ZeroBanner to master [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159512 [18:14:04] (03CR) 10Yurik: [C: 032] Updated ZeroBanner to master [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159512 (owner: 10Yurik) [18:14:07] (03PS1) 10Catrope: Update OOjs UI to v0.1.0-pre (dcd343d471) for cherry-pick [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159513 [18:14:09] (03CR) 10Yurik: [C: 032] Updated ZeroBanner to master [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159511 (owner: 10Yurik) [18:16:46] 3Wikimedia / 3Extension setup: FlaggedRevs for Norwegian (bokmål) Wikipedia - 10https://bugzilla.wikimedia.org/64726#c29 (10dyveldi) Question. At Norwegian Wikipedia we are wondering what more we have to do do get this change implemented. We have had a pretty conclusive discussion on our parliament/Storting... [18:19:08] (03Merged) 10jenkins-bot: Updated ZeroBanner to master [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159512 (owner: 10Yurik) [18:19:15] (03Merged) 10jenkins-bot: Updated ZeroBanner to master [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159511 (owner: 10Yurik) [18:20:21] 3MediaWiki / 3Categories: Double-entry categorization would be helpful - 10https://bugzilla.wikimedia.org/70669 (10Daniel U. Thibault) 3NEW p:3Unprio s:3normal a:3None The inherent conflict between strict lexicographic sort keys and analogical or bibliotechnical sort keys leads to recurrent debates o... [18:24:00] 3MediaWiki extensions / 3Babel: Properly align language code cells in babel box - 10https://bugzilla.wikimedia.org/70668#c1 (10Waldir) (In reply to Waldir from comment #0) > An easier fix would be to simply add "display: inline-block;" to the span > that surrounds the level (which was originally introduced s... [18:24:04] 3MediaWiki / 3API: Cannot save certain preferences with JavaScript - 10https://bugzilla.wikimedia.org/70670 (10Jon) 3NEW p:3Unprio s:3normal a:3None I'm trying to build an ajax preferences form. When I try to edit name action:options format:json optionname:realname optionvalue:Jon R I get the follo... [18:26:29] 3MediaWiki / 3API: Cannot save certain preferences with JavaScript - 10https://bugzilla.wikimedia.org/70670#c1 (10Kunal Mehta (Legoktm)) "realname" is considered to be a special preference (see User::getOptionKinds() and Preferences::getSaveBlacklist()( and can't be set via the API. [18:39:59] 3MediaWiki / 3API: Cannot save certain preferences with JavaScript - 10https://bugzilla.wikimedia.org/70670#c2 (10Jon) Historically why is this the case? [18:40:46] (03PS6) 10Bsitu: Add job to keep user notifications in reasonable volume [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159413 [18:41:22] (03PS1) 10Alex Monk: Clean up mediawiki.legacy.protect a bit. [core] - 10https://gerrit.wikimedia.org/r/159518 (https://bugzilla.wikimedia.org/33871) [18:41:28] MatmaRex, ^ [18:41:49] (03CR) 10jenkins-bot: [V: 04-1] Clean up mediawiki.legacy.protect a bit. [core] - 10https://gerrit.wikimedia.org/r/159518 (https://bugzilla.wikimedia.org/33871) (owner: 10Alex Monk) [18:42:20] 3MediaWiki / 3API: Cannot save certain preferences with JavaScript - 10https://bugzilla.wikimedia.org/70670#c3 (10Kunal Mehta (Legoktm)) I'm guessing because it's not a real preference and actually stored in the user table. [18:43:01] (03CR) 10Aaron Schulz: Add ability to pre-render thumbnails at upload time (032 comments) [core] - 10https://gerrit.wikimedia.org/r/157157 (owner: 10Gilles) [18:43:33] (03PS1) 10Umherirrender: Fix column alias in sql on ApiQueryAllUsers.php [core] - 10https://gerrit.wikimedia.org/r/159519 [18:44:56] (03PS2) 10Alex Monk: Clean up mediawiki.legacy.protect a bit. [core] - 10https://gerrit.wikimedia.org/r/159518 (https://bugzilla.wikimedia.org/33871) [18:45:51] (03Abandoned) 10Bsitu: [WIP]Remove old notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/157029 (owner: 10Bsitu) [18:47:46] csteipp: $wgContentHandlerUseDB = true is https://bugzilla.wikimedia.org/show_bug.cgi?id=49193 [18:47:59] 3MediaWiki / 3API: Cannot save certain preferences with JavaScript - 10https://bugzilla.wikimedia.org/70670#c4 (10Bartosz Dziewoński) Because 'realname' and 'emailaddress' are not actual user preferences stored in the (confusingly named) user_properties table, but properties of the user itself (like user nam... [18:49:57] (03CR) 10Rillke: "Nemo_bis: See Gilles' comment:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152177 (owner: 10Rillke) [18:50:14] 3MediaWiki extensions / 3GlobalCssJs: Add license information to GlobalCssJs.php - 10https://bugzilla.wikimedia.org/68863#c4 (10Kunal Mehta (Legoktm)) If we "rename" the extension to "Global CSS & JS" we no longer have that issue. Thoughts? [18:51:01] (03CR) 10Umherirrender: Use as strict comparison to check whether an user name was provided in Special:ListFiles (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156688 (owner: 10IAlex) [18:54:14] 3Wikimedia / 3Site requests: Tidy up (and perhaps kill) abusefilter.php Wikimedia configuration file - 10https://bugzilla.wikimedia.org/58247#c10 (10Marius Hoch) 5PATC>3RESO/WON IMO we can RESOLVE this as this is not worth working on anymore (also I'm actually not opposing one configuration file per exte... [18:55:17] (03PS1) 10Foxtrott: fix for MW <1.24 inserting the magnify icon directly into the page html [skins/chameleon] - 10https://gerrit.wikimedia.org/r/159522 [18:56:20] (03CR) 10Foxtrott: [C: 032 V: 032] fix for MW <1.24 inserting the magnify icon directly into the page html [skins/chameleon] - 10https://gerrit.wikimedia.org/r/159522 (owner: 10Foxtrott) [18:57:37] (03PS1) 10EBernhardson: Force logging of exceptions in Hooks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159523 [18:59:28] (03PS1) 10Foxtrott: Fix alignment of personal tools menu for navhead and fixedhead [skins/chameleon] - 10https://gerrit.wikimedia.org/r/159525 [18:59:29] 3MediaWiki / 3Configuration: Convert things to use Config classes instead of globals (tracking) - 10https://bugzilla.wikimedia.org/69084 (10Kunal Mehta (Legoktm)) [18:59:32] 3MediaWiki / 3Maintenance scripts: Convert maintenance scripts to use Config instead of globals - 10https://bugzilla.wikimedia.org/70673 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None $this->getConfig() can now be used to access Config instances if necessary. [18:59:54] (03CR) 10Umherirrender: Add duration field in query=imageinfo&iiprop=dimensions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/157586 (https://bugzilla.wikimedia.org/55941) (owner: 10Brian Wolff) [19:00:10] (03CR) 10Foxtrott: [C: 032 V: 032] Fix alignment of personal tools menu for navhead and fixedhead [skins/chameleon] - 10https://gerrit.wikimedia.org/r/159525 (owner: 10Foxtrott) [19:00:19] (03PS1) 10Reedy: Don't cast SpecialPageFactory::$list to an object [core] - 10https://gerrit.wikimedia.org/r/159526 (https://bugzilla.wikimedia.org/67596) [19:01:08] (03CR) 10jenkins-bot: [V: 04-1] Don't cast SpecialPageFactory::$list to an object [core] - 10https://gerrit.wikimedia.org/r/159526 (https://bugzilla.wikimedia.org/67596) (owner: 10Reedy) [19:01:27] (03CR) 10Reedy: "recheck" [core] - 10https://gerrit.wikimedia.org/r/159526 (https://bugzilla.wikimedia.org/67596) (owner: 10Reedy) [19:01:36] vendor and qunit? [19:01:38] gtfo jenkins [19:01:54] (03CR) 10jenkins-bot: [V: 04-1] Don't cast SpecialPageFactory::$list to an object [core] - 10https://gerrit.wikimedia.org/r/159526 (https://bugzilla.wikimedia.org/67596) (owner: 10Reedy) [19:01:57] vendor is the PHPUnit tests now [19:02:05] 19:01:06 PHP Fatal error: __clone method called on non-object in /srv/ssd/jenkins-slave/workspace/mediawiki-vendor-integration/src/includes/specialpage/SpecialPageFactory.php on line 246 [19:02:11] looks like a legit error :P [19:02:41] PhpStorm has been complaining about that for a while [19:03:21] It's not an object now [19:03:22] at least [19:03:25] This code is confusing [19:04:16] (03PS2) 10Reedy: Don't cast SpecialPageFactory::$list to an object [core] - 10https://gerrit.wikimedia.org/r/159526 (https://bugzilla.wikimedia.org/67596) [19:04:52] (03PS4) 10Ori.livneh: Under HHVM, measure resources for the thread, not calling process [core] - 10https://gerrit.wikimedia.org/r/158550 (https://bugzilla.wikimedia.org/70227) [19:06:07] legoktm: :o, it looks like you want to review https://gerrit.wikimedia.org/r/155442 [19:07:26] (03PS1) 10Amire80: Provide a service to get language pairs [services/cxserver] - 10https://gerrit.wikimedia.org/r/159528 [19:08:04] (03CR) 10jenkins-bot: [V: 04-1] Provide a service to get language pairs [services/cxserver] - 10https://gerrit.wikimedia.org/r/159528 (owner: 10Amire80) [19:08:09] (03PS1) 10Reedy: Don't cast SpecialPageFactory::$aliases to an object either [core] - 10https://gerrit.wikimedia.org/r/159529 [19:08:47] okay [19:11:17] (03CR) 10jenkins-bot: [V: 04-1] Don't cast SpecialPageFactory::$list to an object [core] - 10https://gerrit.wikimedia.org/r/159526 (https://bugzilla.wikimedia.org/67596) (owner: 10Reedy) [19:11:29] (03CR) 10Ori.livneh: "As mentioned on IRC: In timer.c, in luasandbox_timer_stop_one, you have:" [php/luasandbox] - 10https://gerrit.wikimedia.org/r/159011 (https://bugzilla.wikimedia.org/70177) (owner: 10Tim Starling) [19:11:37] ^ anomie [19:12:29] 3MediaWiki / 3API: Cannot save certain preferences with JavaScript - 10https://bugzilla.wikimedia.org/70670#c5 (10Umherirrender) When we want bug 63354 than we should not move the real name to the properties table. 'emailaddress' seems to be forgotten to remove, when the Special:ChangeEmail special page was... [19:13:19] ori: Hmm. That does seem like it could be the case. [19:13:33] (03CR) 10Aaron Schulz: [C: 032] Under HHVM, measure resources for the thread, not calling process [core] - 10https://gerrit.wikimedia.org/r/158550 (https://bugzilla.wikimedia.org/70227) (owner: 10Ori.livneh) [19:14:45] (03CR) 10jenkins-bot: [V: 04-1] Don't cast SpecialPageFactory::$aliases to an object either [core] - 10https://gerrit.wikimedia.org/r/159529 (owner: 10Reedy) [19:15:31] anomie: I was testing Tim's patch patch on osmium with this script: . It makes 20 requests to api.php?action=parse with '{{#invoke:While|busy_loop}}'; While.busy_loop is a function that gets the content of a page in an infinite loop. It works most of the time, but if I fire off enough requests, one of them hangs. [19:15:49] (03PS3) 10Reedy: Don't cast SpecialPageFactory::$list to an object [core] - 10https://gerrit.wikimedia.org/r/159526 (https://bugzilla.wikimedia.org/67596) [19:16:02] 3MediaWiki / 3Page editing: AbuseFilter is overridden when creating a blank page - 10https://bugzilla.wikimedia.org/70675 (10Sorawee Porncharoenwase) 3NEW p:3Unprio s:3normal a:3None In Thai Wikipedia, we have a filter[1] preventing creating pages which are too short. It works fine in all cases excep... [19:16:14] 3MediaWiki / 3Special pages: Cancel button constructive on Special:ChangeEmail - 10https://bugzilla.wikimedia.org/69723 (10Matthew Flaschen) [19:16:15] 3MediaWiki / 3MediaWiki UI: VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages - 10https://bugzilla.wikimedia.org/56363 (10Matthew Flaschen) [19:16:30] 3MediaWiki skins / 3Chameleon: Needs hooks - 10https://bugzilla.wikimedia.org/69738#c1 (10s7eph4n) 5NEW>3RESO/INV There actually is only one (now deprecated) hook that is called consistently by skins, which is SkinTemplateToolboxEnd. This hook is also called by Chameleon. Any other hooks are called by t... [19:16:34] MatmaRex: I think at some point we need to re-think passing RLContext to every single function versus just passing it to the module constructor... [19:17:27] legoktm: well, the design that a module doesn't need to know its contents until you try to generate the output does mostly make sense [19:17:33] know its context* [19:18:24] although on the other hand, there aren't that many interesting things a module can do without knowing its context. [19:18:37] right... [19:19:12] ori: Hangs as in the limiter never fires, or hangs somehow else? [19:20:05] (03Merged) 10jenkins-bot: Under HHVM, measure resources for the thread, not calling process [core] - 10https://gerrit.wikimedia.org/r/158550 (https://bugzilla.wikimedia.org/70227) (owner: 10Ori.livneh) [19:20:14] 3MediaWiki / 3MediaWiki UI: VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages - 10https://bugzilla.wikimedia.org/56363 (10Matthew Flaschen) [19:20:17] 3MediaWiki / 3Special pages: ChangeEmail does not always allow you to cancel if you have an invalid email - 10https://bugzilla.wikimedia.org/70676 (10Matthew Flaschen) [19:20:17] 3MediaWiki / 3Special pages: ChangeEmail does not always allow you to cancel if you have an invalid email - 10https://bugzilla.wikimedia.org/70676 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3None To reproduce: 1. Go to Special:ChangeEmail 2. Type in an invalid email (e.g. just any string withou... [19:20:22] (03CR) 10Jforrester: "Caused (?) bug 70675." [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/57238) (owner: 10Ebe123) [19:21:45] 3MediaWiki / 3MediaWiki UI: VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages - 10https://bugzilla.wikimedia.org/56363#c14 (10Matthew Flaschen) (In reply to Jared Zimmerman (WMF) from comment #13) > When I hit cancel I get the error "Enter... [19:22:28] 3MediaWiki extensions / 3AbuseFilter: AbuseFilter is overridden when creating a blank page - 10https://bugzilla.wikimedia.org/70675#c1 (10James Forrester) Probably an AF issue caused by the fix for bug 57238. [19:22:59] (03CR) 10Legoktm: "Only looked at the RL things..." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/155442 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [19:23:11] (03PS1) 10Nischayn22: Added lot of comments and fixed some styling. [extensions/RecentActivityFeed] - 10https://gerrit.wikimedia.org/r/159533 [19:23:55] (03PS1) 10Chad: Remove "related" searches [core] - 10https://gerrit.wikimedia.org/r/159534 [19:24:09] (03PS2) 10Nischayn22: Added lot of comments and fixed some styling. [extensions/RecentActivityFeed] - 10https://gerrit.wikimedia.org/r/159533 [19:24:47] (03PS2) 10Chad: Remove "related" searches [core] - 10https://gerrit.wikimedia.org/r/159534 [19:25:28] (03CR) 10Nischayn22: [C: 032 V: 032] "This guy is awesome" [extensions/RecentActivityFeed] - 10https://gerrit.wikimedia.org/r/159533 (owner: 10Nischayn22) [19:25:54] (03PS2) 10Reedy: Don't cast SpecialPageFactory::$aliases to an object either [core] - 10https://gerrit.wikimedia.org/r/159529 [19:26:00] (03CR) 10Manybubbles: [C: 031] "Yeah - I don't see this being widely used.... Happy to +2 if no one objects. I always try to give people a chance to object in core." [core] - 10https://gerrit.wikimedia.org/r/159534 (owner: 10Chad) [19:27:16] (03PS3) 10Chad: Remove "related" searches [core] - 10https://gerrit.wikimedia.org/r/159534 [19:30:17] (03PS1) 10Nischayn22: jsbeautified using jsbeautify.com [extensions/RecentActivityFeed] - 10https://gerrit.wikimedia.org/r/159535 [19:30:35] anomie: i'm not sure. i tried ltracing the process to see what it was doing and it immediately crashed w/ https://dpaste.de/uVT2/raw [19:30:39] i'll try reproducing [19:30:45] (03CR) 10Nischayn22: [C: 032 V: 032] jsbeautified using jsbeautify.com [extensions/RecentActivityFeed] - 10https://gerrit.wikimedia.org/r/159535 (owner: 10Nischayn22) [19:31:17] 3MediaWiki skins / 3Chameleon: Dropdowns in the VE toolbar opening "under" the content area - 10https://bugzilla.wikimedia.org/70678 (10s7eph4n) 3NEW p:3Unprio s:3normal a:3s7eph4n There is an issue in Chrome when using the VisualEditor extension. The dropdowns in the VE toolbar seem to be opening "u... [19:32:52] (03CR) 10jenkins-bot: [V: 04-1] Don't cast SpecialPageFactory::$aliases to an object either [core] - 10https://gerrit.wikimedia.org/r/159529 (owner: 10Reedy) [19:34:09] (03CR) 10jenkins-bot: [V: 04-1] Remove "related" searches [core] - 10https://gerrit.wikimedia.org/r/159534 (owner: 10Chad) [19:35:27] (03PS3) 10Reedy: Don't cast SpecialPageFactory::$aliases to an object either [core] - 10https://gerrit.wikimedia.org/r/159529 [19:42:37] (03PS4) 10Chad: Remove "related" searches [core] - 10https://gerrit.wikimedia.org/r/159534 [19:42:46] 3MediaWiki extensions / 3WikidataClient: update other projects sidebar in more cache-friendly way - 10https://bugzilla.wikimedia.org/70482 (10Aude) 5PATC>3RESO/FIX [19:44:57] (03CR) 10TheDJ: [C: 04-1] "Currently breaks CodeEditor, because it does not use .textSelection (contents of code editor are not yet in the form by this time)." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151128 (owner: 10MarkTraceur) [19:45:53] (03PS1) 10Florianschmidtwelzow: SpecialVersion: Use Config object instead of globals [core] - 10https://gerrit.wikimedia.org/r/159536 (https://bugzilla.wikimedia.org/70638) [19:49:30] (03PS1) 10Florianschmidtwelzow: Declare visibility of functions explicitly [core] - 10https://gerrit.wikimedia.org/r/159537 [19:50:28] (03PS2) 10Florianschmidtwelzow: SpecialVersion: Use Config object instead of globals [core] - 10https://gerrit.wikimedia.org/r/159536 (https://bugzilla.wikimedia.org/70638) [19:51:07] FlorianSW: $IP isn't really a configuration setting, so we've just been leaving it as a global. also it won't work because it doesn't start with "wg"... [19:51:42] legoktm: i thought so, too. But i have tested it :/ Maybe a local cache problem... argh [19:52:08] legoktm: First i had $IP globals, but then i thought: Give it a try :P [19:53:13] legoktm: damn cache, you're right :) [19:53:24] (03CR) 10Ori.livneh: "Test script: . About half of the time, one of the twenty requests generated by that scr" [php/luasandbox] - 10https://gerrit.wikimedia.org/r/159011 (https://bugzilla.wikimedia.org/70177) (owner: 10Tim Starling) [19:53:29] 3MediaWiki / 3API: Cannot save certain preferences with JavaScript - 10https://bugzilla.wikimedia.org/70670#c6 (10Brad Jorsch) 5NEW>3RESO/WON As far as the API goes, this is WONTFIX. We could change the error message for 'special' to the same as 'unused' ("not a valid preference") to avoid confusing peop... [19:55:13] (03CR) 10Aaron Schulz: [C: 032] TitleTest: Break secure and split test into two tests with providers [core] - 10https://gerrit.wikimedia.org/r/158646 (owner: 10Chad) [19:56:16] (03CR) 10Anomie: [C: 032] Fix column alias in sql on ApiQueryAllUsers.php [core] - 10https://gerrit.wikimedia.org/r/159519 (owner: 10Umherirrender) [19:56:56] I love cloning the mediawiki/* :| [19:57:14] 3MediaWiki / 3API: Cannot save certain preferences with JavaScript - 10https://bugzilla.wikimedia.org/70670#c7 (10Chad H.) (In reply to Bartosz Dziewoński from comment #4) > Because 'realname' and 'emailaddress' are not actual user preferences stored > in the (confusingly named) user_properties table, but pr... [19:57:41] (03PS3) 10Florianschmidtwelzow: SpecialVersion: Use Config object instead of globals [core] - 10https://gerrit.wikimedia.org/r/159536 (https://bugzilla.wikimedia.org/70638) [20:00:18] (03CR) 10Kaldari: [C: 031] "Looks good to me, haven't tested." [core] - 10https://gerrit.wikimedia.org/r/159526 (https://bugzilla.wikimedia.org/67596) (owner: 10Reedy) [20:01:38] (03Merged) 10jenkins-bot: TitleTest: Break secure and split test into two tests with providers [core] - 10https://gerrit.wikimedia.org/r/158646 (owner: 10Chad) [20:02:29] (03Merged) 10jenkins-bot: Fix column alias in sql on ApiQueryAllUsers.php [core] - 10https://gerrit.wikimedia.org/r/159519 (owner: 10Umherirrender) [20:03:22] (03PS10) 10TheDJ: Move confirmCloseWindow to core [core] - 10https://gerrit.wikimedia.org/r/151128 (owner: 10MarkTraceur) [20:04:59] (03PS1) 10Jforrester: Populate $features even if there aren't any requirements [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/159538 (https://bugzilla.wikimedia.org/69823) [20:05:30] (03CR) 10Jforrester: "Untested. I have no idea if this fixes the bug (and if so, why), but… this is a bit confusing." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/159538 (https://bugzilla.wikimedia.org/69823) (owner: 10Jforrester) [20:10:13] (03CR) 10Anomie: "I'm grepping through the logs on fluorine to see if anyone actually uses this. So far there's a decent number of hits, but it's all anons." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/159534 (owner: 10Chad) [20:11:21] (03CR) 10Chad: "Similar to when I removed score: they may have been using the param, but it's not been returning anything." [core] - 10https://gerrit.wikimedia.org/r/159534 (owner: 10Chad) [20:13:36] James_F|Away: I'm trying to imagine what a betafeature named "blacklist" would do. [20:16:04] (03CR) 10MaxSem: [C: 032] Don't cast SpecialPageFactory::$list to an object [core] - 10https://gerrit.wikimedia.org/r/159526 (https://bugzilla.wikimedia.org/67596) (owner: 10Reedy) [20:16:37] Hmmm. SWAT? [20:16:52] (03PS1) 10Chad: Properly deprecate srprop=score|hasrelated [core] - 10https://gerrit.wikimedia.org/r/159540 [20:22:44] (03Merged) 10jenkins-bot: Don't cast SpecialPageFactory::$list to an object [core] - 10https://gerrit.wikimedia.org/r/159526 (https://bugzilla.wikimedia.org/67596) (owner: 10Reedy) [20:26:05] (03PS2) 10Amire80: Provide a service to get language pairs [services/cxserver] - 10https://gerrit.wikimedia.org/r/159528 [20:30:35] (03CR) 10Legoktm: Add MultiConfig for fallback logic (032 comments) [core] - 10https://gerrit.wikimedia.org/r/153541 (https://bugzilla.wikimedia.org/69418) (owner: 10Legoktm) [20:31:19] (03PS1) 10Reedy: Don't cast SpecialPageFactory::$list to an object [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159542 (https://bugzilla.wikimedia.org/67596) [20:31:35] (03PS1) 10Reedy: Don't cast SpecialPageFactory::$list to an object [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159543 (https://bugzilla.wikimedia.org/67596) [20:32:01] 3MediaWiki-Vagrant: Exception Caught: Redis server error: Could not insert 1 ParsoidCacheUpdateJobOnDependencyChange - 10https://bugzilla.wikimedia.org/70685 (10Jon) 3NEW p:3Unprio s:3normal a:3None I get this on various edits after my wiki grows to a certain size. I then have to vagrant destroy it. I... [20:33:30] (03CR) 10Jsahleen: [C: 04-1] Provide a service to get language pairs [services/cxserver] - 10https://gerrit.wikimedia.org/r/159528 (owner: 10Amire80) [20:35:17] (03CR) 10Jsahleen: "You have the wrong return type for the new function in registry/index.js" [services/cxserver] - 10https://gerrit.wikimedia.org/r/159528 (owner: 10Amire80) [20:37:01] 3MediaWiki / 3Special pages: Special:MovePage disappeared from tet.wikipedia - 10https://bugzilla.wikimedia.org/70686 (10MF-Warburg) 3NEW p:3Unprio s:3major a:3None See (or (03PS1) 10Chad: Remove $wgGoToEdit functionality [core] - 10https://gerrit.wikimedia.org/r/159544 [20:38:27] (03CR) 10Eloquence: "Played a bit more with other wikis. In addition to the TMH cross-wiki issues, other wikis immediately throw an error -- pl.wiki, sv.wiki, " [core] - 10https://gerrit.wikimedia.org/r/157774 (owner: 10Eloquence) [20:39:28] 3MediaWiki-Vagrant: Exception Caught: Redis server error: Could not insert 1 ParsoidCacheUpdateJobOnDependencyChange - 10https://bugzilla.wikimedia.org/70685#c1 (10Bryan Davis) We have had other reports of similar sounding problems, but I can't find them in bugzilla at the moment. Have you checked to see if y... [20:42:16] 3MediaWiki / 3Special pages: Special:MovePage disappeared from tet.wikipedia - 10https://bugzilla.wikimedia.org/70686#c1 (10Jesús Martínez Novo (Ciencia Al Poder)) https://tet.wikipedia.org/w/api.php?action=query&meta=siteinfo&siprop=specialpagealiases 3MediaWiki / 3Special pages: Special:MovePage disappeared from tet.wikipedia - 10https://bugzilla.wikimedia.org/70686#c2 (10MF-Warburg) Not wtf, but "book" means move and that worked well for years. [20:45:59] 3MediaWiki / 3Special pages: Special:MovePage disappeared from tet.wikipedia - 10https://bugzilla.wikimedia.org/70686#c3 (10Sam Reed (reedy)) When did this last work/did you notice it was broken? [20:47:39] (03CR) 10Physikerwelt: [C: 04-1] "Thank you for the review" (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/158845 (owner: 10Physikerwelt) [20:47:59] 3MediaWiki / 3Special pages: Special:MovePage disappeared from tet.wikipedia - 10https://bugzilla.wikimedia.org/70686#c4 (10MF-Warburg) The last time someone moved a page was on 4 September. The same user asked on my talk page today why the Special page had suddenly disappeared. [20:49:44] 3MediaWiki / 3Special pages: Special:MovePage disappeared from tet.wikipedia - 10https://bugzilla.wikimedia.org/70686#c5 (10Jesús Martínez Novo (Ciencia Al Poder)) Ah, I though Book was also a namespace and it was somehow conflicting. Sorry about that [20:50:05] (03CR) 10Hoo man: [C: 032] "Makes sense to me (per Erik's recent comments), so let's just do this." [core] - 10https://gerrit.wikimedia.org/r/157774 (owner: 10Eloquence) [20:51:16] 3MediaWiki extensions / 3WikidataRepo: Moving article on client removes badges - 10https://bugzilla.wikimedia.org/70687 (10Bene*) 3NEW p:3Unprio s:3normal a:3Wikidata bugs When a sitelink changes on Wikidata, its badges are removed because they may not apply to the new page. However, when an article... [20:51:59] 3MediaWiki extensions / 3WikidataRepo: Moving article on client removes badges - 10https://bugzilla.wikimedia.org/70687 (10Bene*) p:5Unprio>3High s:5normal>3major [20:51:59] 3MediaWiki extensions / 3WikidataClient: Featured and good article badges - 10https://bugzilla.wikimedia.org/40810 (10Bene*) [20:52:06] (03PS3) 10Amire80: Provide a service to get language pairs [services/cxserver] - 10https://gerrit.wikimedia.org/r/159528 [20:57:01] (03Merged) 10jenkins-bot: Disable JavaScript for MSIE7 users, update tests accordingly [core] - 10https://gerrit.wikimedia.org/r/157774 (owner: 10Eloquence) [20:57:45] lololol [20:58:54] uh? [20:59:16] 3Wikimedia / 3Bugzilla: add dduvall to default cc for mediawiki vagrant - 10https://bugzilla.wikimedia.org/70688 (10Dan Duvall) 3NEW p:3Unprio s:3normal a:3None Add me to the default CC. Thanks! [20:59:30] (03CR) 10Siebrand: [C: 04-1] "L10n reviewed." (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151797 (owner: 10Mglaser) [20:59:52] hoo: Downgrading IE7 support :) [21:00:21] Although it's the best browser ever... right [21:01:09] It even had tabs... [21:01:09] ie7? i remember beta testing that in 2005 [21:01:19] if it’s still around it should be taken out back with old yeller [21:01:32] brion: [21:57:01] (Merged) jenkins-bot: Disable JavaScript for MSIE7 users, update tests accordingly [core] - https://gerrit.wikimedia.org/r/157774 (owner: Eloquence) [21:01:32] :D [21:01:39] I think the first beta didn't even have tabs or something like that :P [21:02:12] it was better than ie6 [21:02:18] i had to beta test it on my mac in virtualpc [21:02:20] was slow as shit [21:02:49] bd808: But still way behind the competitors when it came out [21:03:09] (03CR) 10Martineznovo: "-1, se inline comments" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/158865 (owner: 10Amire80) [21:03:13] Like the iPhone 6? ;) [21:04:04] Sure. But IE6 was the "corporate" browser of choice. There are still lots of government websites with a "best viewed in IE6" warning. Even worse there are some that truly only work in IE6 :( [21:04:43] I've seen terrible things within government IT :P [21:04:44] * bd808 shakes fist at bad drag-n-drop dev tools from the past [21:04:57] If one wants an "interesting" internship... do something like that [21:05:12] <^d> Heh, I did that! [21:05:21] <^d> First "real" job was interning in local gov't. [21:05:26] bd808: What's bad about creating my website in MS Word? [21:05:37] I did 7 years as a partner contractor for State of Idaho government [21:06:37] <^d> bd808: We can't work for state IT gov't in Virginia. We outsourced the whole thing to Northrop Grumman. Through at least 2019 iirc. [21:06:40] <^d> :p [21:07:25] ^d: I worked for NIC who does the web portal in VA. My boos came to Idaho from there. [21:07:29] *boss [21:08:10] Please could someone run mwgrep for "ProtectionForm" for me? [21:08:12] <^d> Heh [21:08:14] <^d> "Virginia entered into a 10-year, $2.3 billion contract with Northrop Grumman in 2005 in what was then the state’s richest-ever privatization deal. The project has been plagued at times by rocky relationships and spotty service, which reached an apex in August 2010, when a computer meltdown affected 26 of 89 executive branch agencies." [21:08:23] <^d> Krenair: On it. [21:08:34] thanks [21:09:38] ^d: http://www.egov.com/partners/Pages/Virginia.aspx [21:11:07] <^d> Krenair: http://p.defau.lt/?D2Jsovdee9DyhkcyPSoWLA [21:11:22] http://www.technologizer.com/wp-content/uploads/2010/09/bestie.jpg [21:12:24] hm. could be worse. [21:13:53] <^d> I'm guessing you were hoping for 0? [21:14:35] (03PS1) 10Jdlrobson: Kill use of super [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/159552 [21:14:37] (03PS1) 10Jdlrobson: Use OO for class inheritance [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/159553 [21:15:06] (03CR) 10jenkins-bot: [V: 04-1] Use OO for class inheritance [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/159553 (owner: 10Jdlrobson) [21:15:08] (03CR) 10Aaron Schulz: [C: 031] API: Add "batchcomplete" to simplified continuation result [core] - 10https://gerrit.wikimedia.org/r/152359 (owner: 10Anomie) [21:15:17] ^d, eh, I was expecting some. [21:15:48] The ones I've looked at so far only call functions that I want to rewrite, rather than remove completely right now [21:17:19] Seems those Gadget-LiveRC entries have their own variable called ProtectionForm and don't mess with the global, so those can be ignored. [21:23:52] So everything should be fine as long as ProtectionForm.updateExpiryList continues to work [21:24:10] (03PS4) 10Mglaser: Checklist assistant [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151797 [21:25:10] hey, anyone : does bits.wikimedia.org ever output CORS headers? [21:25:46] (03CR) 10Mglaser: "Added kbd tags as requested, also in the de file." (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151797 (owner: 10Mglaser) [21:25:58] I'm getting intermittent "Font from origin 'https://bits.wikimedia.org' has been blocked from loading by Cross-Origin Resource Sharing policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'https://en.wikipedia.org' is therefore not allowed access." [21:26:32] and the page's WikiFont-Glyphs.ttf request returns 0 bytes but status 200 OK [21:31:26] (03CR) 10Mglaser: [C: 031] "Text change seems ok. Someone from i18n must approve" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/158095 (owner: 10Tweichart) [21:35:12] (03PS1) 10Jackmcbarn: Only skip apparent null-edits when the page exists [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/159556 (https://bugzilla.wikimedia.org/70675) [21:38:08] Re: CORS bits.beta.wmflabs.org sends an "Access-Control-Allow-Origin: *" header, so it works differently [21:39:41] (03CR) 10Jforrester: [C: 031] Only skip apparent null-edits when the page exists [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/159556 (https://bugzilla.wikimedia.org/70675) (owner: 10Jackmcbarn) [21:40:36] (03PS1) 10Chad: Remove abandoned and unsupported MSSQL support [core] - 10https://gerrit.wikimedia.org/r/159581 [21:40:48] <^d> brion: héhé ^ [21:40:58] ^d: Ouch. [21:41:10] <^d> +3, -4073 [21:41:16] nommy nom [21:41:27] ^d: ehhhh, skizzerz was working on that [21:42:02] it was re-added for 1.23. [21:42:14] <^d> No, it went through a back-and-forth removal. [21:42:27] <^d> People with sql server should use sharepoint. [21:42:44] since https://gerrit.wikimedia.org/r/#/c/105138/ ? [21:43:24] <^d> That's not adding. It's trying to unbreak the mess. [21:44:10] heh [21:45:17] <^d> Anyway, we've got a WIP. I'm going to file an accompanying RfC on removing this among others. [21:45:30] 3MediaWiki extensions / 3WikidataClient: Wikibase badges (tracking) - 10https://bugzilla.wikimedia.org/40810 (10Kunal Mehta (Legoktm)) [21:50:39] (03CR) 10Chad: "Initial RfC filed on this issue: https://www.mediawiki.org/wiki/Requests_for_comment/Removing_bad_database_abstractions" [core] - 10https://gerrit.wikimedia.org/r/159581 (owner: 10Chad) [21:55:36] (03PS1) 10Legoktm: Move Config::set() to MutableConfig::set() [core] - 10https://gerrit.wikimedia.org/r/159620 [21:56:26] (03CR) 10Legoktm: "See discussion on https://gerrit.wikimedia.org/r/#/c/153541/6/includes/config/MultiConfig.php,cm which led to this." [core] - 10https://gerrit.wikimedia.org/r/159620 (owner: 10Legoktm) [21:56:41] (03CR) 10Legoktm: Add MultiConfig for fallback logic (031 comment) [core] - 10https://gerrit.wikimedia.org/r/153541 (https://bugzilla.wikimedia.org/69418) (owner: 10Legoktm) [21:59:49] (03CR) 10Jdlrobson: [C: 032] Switch the order of Alerts and Messages tabs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159305 (owner: 10Matthias Mullie) [22:00:18] (03Merged) 10jenkins-bot: Switch the order of Alerts and Messages tabs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159305 (owner: 10Matthias Mullie) [22:03:02] (03CR) 10Jdlrobson: [C: 04-1] "I don't see an icon for unlock topic ..." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159480 (owner: 10Matthias Mullie) [22:03:44] 3MediaWiki / 3User login and signup: Fatal exception of type MWException on Special:CentralLogin - 10https://bugzilla.wikimedia.org/70666#c4 (10Andre Klapper) -> please comment on bug 69834 if it's still an issue [22:04:46] 3Wikimedia / 3Extension setup: add easy timeline extension on urdu wiki - 10https://bugzilla.wikimedia.org/70667 (10Andre Klapper) 5UNCO>3NEW p:5Unprio>3Normal s:5normal>3enhanc [22:05:45] 3Wikimedia / 3Bugzilla: add dduvall to default cc for mediawiki vagrant - 10https://bugzilla.wikimedia.org/70688#c1 (10Andre Klapper) 5NEW>3RESO/FIX a:3Andre Klapper Done for both its components. [22:09:10] (03PS3) 10Jdlrobson: H9: Don't collapse topics in the topic namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159246 [22:09:18] andre__: thanks! bd808, be less vigilant, get more sleep :) [22:10:03] marxarelli: heh. will do [22:17:13] (03PS1) 10Amire80: Add more dir="ltr" to default-skin-not-found* messages [core] - 10https://gerrit.wikimedia.org/r/159622 [22:17:38] (03CR) 10Amire80: Make the PHP code snippet in SkinFallbackTemplate explicitly ltr (031 comment) [core] - 10https://gerrit.wikimedia.org/r/158865 (owner: 10Amire80) [22:23:40] <^d> I need some bikeshedding help on a message key (since reusing keys is bad yo) [22:23:53] <^d> "showingresultsheader": "{{PLURAL:$5|Result $1 of $3|Results $1 - $2 of $3}} for $4", [22:24:06] <^d> I'm removing the "for $4" bit from the end. [22:24:13] <^d> showingresultsheader2 seems like a bad name. [22:24:20] <^d> Maybe I could add dashes. [22:24:24] <^d> showing-results-header. [22:26:47] <^d> search-showingresults. [22:26:54] <^d> Seems consistent with other search-* messages. [22:29:11] (03PS3) 10Chad: Remove term from search results info [core] - 10https://gerrit.wikimedia.org/r/157276 [22:30:01] 3MediaWiki / 3API: Categorymembers query won't start listing from the desired page using sortkey - 10https://bugzilla.wikimedia.org/70690 (10Peter Bowman) 3UNCO p:3Unprio s:3normal a:3None Given i.e. the page "ácido" and its hex sortkey 272b372d4301868d08010a00 retrieved through prop=categories, then... [22:31:28] (03PS1) 10MarkTraceur: [WIP] Add override button back in [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/159625 (https://bugzilla.wikimedia.org/46741) [22:31:59] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add override button back in [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/159625 (https://bugzilla.wikimedia.org/46741) (owner: 10MarkTraceur) [22:38:51] (03PS1) 10TheDJ: Drafts: this time using indexeddb [core] - 10https://gerrit.wikimedia.org/r/159626 [22:40:58] (03CR) 10CSteipp: [C: 04-1] Add script to make a list of users who will be renamed (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159266 (owner: 10Legoktm) [22:41:34] Krinkle: https://gerrit.wikimedia.org/r/159626 the code is still a bit of a mess, but as a PoC, it works. [22:45:12] (03CR) 10jenkins-bot: [V: 04-1] Drafts: this time using indexeddb [core] - 10https://gerrit.wikimedia.org/r/159626 (owner: 10TheDJ) [22:45:33] (03CR) 10Alex Monk: Drafts: this time using indexeddb (031 comment) [core] - 10https://gerrit.wikimedia.org/r/159626 (owner: 10TheDJ) [22:47:04] (03CR) 10Skizzerz: [C: 04-1] "I'd like to hear how you arrived at the conclusion that this code is abandoned and unsupported, considering I have very recently added in " [core] - 10https://gerrit.wikimedia.org/r/159581 (owner: 10Chad) [22:47:10] (03CR) 10Alex Monk: Drafts: this time using indexeddb (031 comment) [core] - 10https://gerrit.wikimedia.org/r/159626 (owner: 10TheDJ) [22:51:31] (03CR) 10TheDJ: Drafts: this time using indexeddb (031 comment) [core] - 10https://gerrit.wikimedia.org/r/159626 (owner: 10TheDJ) [23:01:47] thedj: do we want that in core, or should it be an extension? [23:02:01] (03CR) 10MaxSem: [C: 032 V: 032] Update CentralAuth to 1.24wmf19 HEAD [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159498 (owner: 10Reedy) [23:02:16] (03CR) 10MaxSem: [C: 032 V: 032] Update CentralAuth to 1.24wmf20 HEAD [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159499 (owner: 10Reedy) [23:02:39] (03CR) 10MaxSem: [C: 032] Don't cast SpecialPageFactory::$list to an object [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159543 (https://bugzilla.wikimedia.org/67596) (owner: 10Reedy) [23:02:56] (03CR) 10MaxSem: [C: 032 V: 032] Don't cast SpecialPageFactory::$list to an object [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159542 (https://bugzilla.wikimedia.org/67596) (owner: 10Reedy) [23:03:15] (03CR) 10MaxSem: [C: 032] Update OOjs UI to v0.1.0-pre (dcd343d471) for cherry-pick [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159513 (owner: 10Catrope) [23:06:36] (03CR) 10Chad: "Let me rephrase based on my RfC: backends other than Sqlite and MySQL should be removed. We don't do them well (comparatively) and none ar" [core] - 10https://gerrit.wikimedia.org/r/159581 (owner: 10Chad) [23:10:13] (03PS1) 10Jackmcbarn: Don't output a semicolon at the end of CSS [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/159629 [23:13:29] (03Merged) 10jenkins-bot: Don't cast SpecialPageFactory::$list to an object [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159543 (https://bugzilla.wikimedia.org/67596) (owner: 10Reedy) [23:14:31] 3MediaWiki extensions / 3WikiHiero: WikiHiero looks horrible on high resolution screens - 10https://bugzilla.wikimedia.org/70693 (10Max Semenik) 3NEW p:3Unprio s:3normal a:3None Needs a bit of a facelift... [23:14:46] (03CR) 10Daniel Kinzler: Move Config::set() to MutableConfig::set() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/159620 (owner: 10Legoktm) [23:17:01] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (dcd343d471) for cherry-pick [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159513 (owner: 10Catrope) [23:19:44] James_F|Away, ^^ [23:20:02] err, wrong chan [23:22:48] (03CR) 10Hoo man: "> and some pages have enough elements with CSS that it does make an actual difference." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/159629 (owner: 10Jackmcbarn) [23:23:45] (03CR) 10Jackmcbarn: "I'm saying this won't be saving just 10 bytes per page. I know of one page where it would save 7kb." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/159629 (owner: 10Jackmcbarn) [23:25:02] jackmcbarn: wtf [23:25:05] 7k [23:25:12] that have to be like 10k , [23:25:14] * ; [23:25:16] wow [23:25:23] that sounds so broken [23:25:24] wow [23:25:44] hoo: warning, potential browser crasher: https://en.wikipedia.org/wiki/Module:Syrian_and_Iraqi_insurgency_detailed_map [23:25:56] err [23:26:02] https://en.wikipedia.org/wiki/Template:Syrian_and_Iraqi_insurgency_detailed_map [23:27:28] wtf [23:27:47] delete that page [23:27:53] * DanielK_WMDE looks [23:27:55] * DanielK_WMDE dies [23:28:09] we nede a better way to make maps and diagrams! [23:28:32] (03CR) 10Hoo man: [C: 032] "This is NOT a solution to your problem... but also it doesn't harm and is in line with the specs." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/159629 (owner: 10Jackmcbarn) [23:28:35] +1 to deleting! [23:28:50] hoo: i xfd'd it once, it got kept [23:28:55] snow kept* [23:29:04] * hoo sighs [23:29:13] Let's map the whole world as templates [23:29:18] I guess that would even be possible [23:29:48] let's... not. [23:30:07] the limit is twice the size of that page, then it hits the post-expand include size [23:30:11] at least nobody tried to use that (yet) [23:30:25] (03Merged) 10jenkins-bot: Don't output a semicolon at the end of CSS [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/159629 (owner: 10Jackmcbarn) [23:31:14] hoo: they did. just the Syria side, but that's like 3/4 of the points. https://en.wikipedia.org/wiki/Cities_and_towns_during_the_Syrian_Civil_War [23:31:52] for real [23:31:56] that is supposed to be an article? [23:32:16] Instead of suggesting that we delete the page, perhaps we can try to find a way to accomplish the same result more sanely. [23:32:32] it's called google maps :) [23:32:35] Carmela: maybe a mediawiki extension dedicated to the purpose? that way it wouldn't kill the parser [23:32:41] thedj: 2000 points on a google map? [23:32:52] thedj: remove the google from that... :P OSM could also do that [23:32:54] that people fight over every hour? [23:33:02] I think it's neat that people are making cool visualizations. [23:33:05] but well, templates might not be the perfect tool for maps... or to fix your car [23:33:08] I think we should encourage that. [23:33:35] we should, but who' is going to write the map layer we've been discussion about for 6 years. [23:33:50] (03PS1) 10EBernhardson: Require permissions against root post for post content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159632 [23:33:57] thedj: i could probably write an extension to do what [[Module:Location map]] does [23:34:01] Dunno. I hear OSM is moving to production or something? [23:34:14] removed the map now https://en.wikipedia.org/w/index.php?title=Cities_and_towns_during_the_Syrian_Civil_War&action=history [23:34:17] the hard part right now is that people manually need to make map svg's [23:34:20] hoo: why? they want it [23:34:26] I wonder how that would have shown on an Android [23:34:42] jackmcbarn: there are about 6 already [23:34:46] 3MediaWiki extensions / 3PubSubHubbub: Performance review of PubSubHubbub extension - 10https://bugzilla.wikimedia.org/67117 (10Aaron Schulz) a:5Aaron Schulz>3None [23:34:54] ...i won't be the 7th then [23:34:56] jackmcbarn: all useless, because we don't have render services, and they all depend on JS. [23:35:04] ...or maybe i will [23:35:14] Could openlayers + geoJSON/KML be used? [23:35:14] if i did, it would do all the work on the server, just like the lua module does [23:35:20] danhedron: that's what i have [23:35:21] jackmcbarn: Because articles need to be readable even on not extremely beefy systems [23:35:31] or IE [23:35:44] danhedron: and dispenser and kolossos have one too :) [23:36:00] jackmcbarn: I'm not sure why Lua is the culprit here. [23:36:05] Though I haven't looked very closely. [23:36:08] Carmela: it's not [23:36:12] but every byte counts [23:36:18] exactly [23:36:29] Not sure what you mean by byte counting. [23:36:29] that's why I removed it [23:36:37] give them more rope, they will hang themselves, the clients and eventually the servers. [23:36:41] :) [23:36:53] it's how it has always been [23:37:10] thedj: with lua, they won't hang the servers. the Syria+Iraq 2000 point version only takes 0.3 seconds to generate [23:37:14] it's alright, hhvm is around the corner ;) [23:37:15] yep... if you manage to bubble up in the fatal logs, there's going to be someone to stop you :P [23:37:20] and if they hang their browsers, tough for them [23:37:29] jackmcbarn: unless they put one in every article :) [23:37:34] And tough for any visitor? [23:37:42] Reedy: So we can safely go back to using wikitext over that overly modern Lua stuffs, right? [23:37:52] I don't think we should punish people wanting to read about the Syrian Civil War. [23:37:53] Sounds perfect [23:38:00] We can just disable lua [23:38:02] We don't need it anymore [23:38:04] thedj: What are they? (I have no idea what I'm doing) [23:38:21] btw, ie8 can read the article fine with the template in [23:38:36] jackmcbarn: On what box? [23:38:56] hoo: a decent one [23:39:27] ... go there with the cell of your choice and well... have fun [23:39:32] * jackmcbarn does just that [23:39:33] what about screen readers and e-readers? [23:39:35] (unless you have a super beefy one there either) [23:39:51] danhedron: With so many nodes? They'll probabl hang or crash [23:40:00] (03PS1) 10EBernhardson: Disable ensureFlowRevision for contributions queries [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159634 (https://bugzilla.wikimedia.org/70662) [23:41:42] fwiw, i showed that map to tim a while ago and he thought it was a really neat use of lua [23:42:02] Well, did you tell him you were to actually show that to readers? [23:42:06] I like the hack, but don't use it [23:42:13] (because I like hacks) [23:42:19] it /is/ a really neat use of Lua [23:42:24] my phone sees it fine too. and i don't remember if he saw the article [23:43:19] what part of it is a hack? [23:43:30] isn't that exactly what we're meant to use lua for? [23:43:45] Yep, it's not like a smallish Infobox or table or something like that [23:44:48] this map doesn't even fit on the page [23:45:02] what, you don't have a 4k monitor? :p [23:45:15] Like *everyone* has [23:46:22] * ebernhardson is so tired of things that treat pixels like a distance :P [23:46:41] ebernhardson: it's an equirectangular projection, so that's accurate [23:46:54] or are you talking about some other kind of distance? [23:47:15] jackmcbarn: i mean that i want a 4k 30" monitor and a 1080p 30" monitor to always show the same thing the same size [23:47:24] jackmcbarn: the 4k should be clearer, it should have no distinction on what size the thing is rendered [23:47:43] that's the concept behind a modern OS [23:47:46] i'm more of a microscope-font kind of guy [23:47:47] some of them don't get it right [23:59:29] (03CR) 10EBernhardson: [C: 032] H9: Don't collapse topics in the topic namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159246 (owner: 10Jdlrobson)