[00:01:17] (03PS1) 10Bartosz Dziewoński: Grammar fix [extensions/SandboxLink] - 10https://gerrit.wikimedia.org/r/159227 [00:01:46] (03CR) 10Bartosz Dziewoński: "https://gerrit.wikimedia.org/r/159227" (031 comment) [extensions/SandboxLink] - 10https://gerrit.wikimedia.org/r/157296 (https://bugzilla.wikimedia.org/69650) (owner: 10Bartosz Dziewoński) [00:02:25] (03CR) 10MaxSem: [C: 032] CurlHttpRequest: Check library version, not CURLOPT_REDIR_PROTOCOLS [core] - 10https://gerrit.wikimedia.org/r/159214 (https://bugzilla.wikimedia.org/70570) (owner: 10PleaseStand) [00:08:26] (03Merged) 10jenkins-bot: CurlHttpRequest: Check library version, not CURLOPT_REDIR_PROTOCOLS [core] - 10https://gerrit.wikimedia.org/r/159214 (https://bugzilla.wikimedia.org/70570) (owner: 10PleaseStand) [00:08:48] jackmcbarn: does it matter? no. I always thought that you could merge accounts without deleting is silly, but that's how it was designed. [00:09:04] legoktm: do other extensions do that and get away with it? [00:11:17] (03CR) 10Mattflaschen: "Making the standard approach to adding an icon require specifying two custom sizes is not necessarily a good thing, though." [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx) [00:11:56] is there a vagrant role for setting up varnish? [00:12:00] (03PS1) 10Bsitu: Remove (X) next to Alerts/Messages if there is one section [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159228 [00:12:02] or maybe something on labs? [00:12:22] (03CR) 10MaxSem: [C: 04-1] Require PHP 5.4.0 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/158895 (owner: 10Withoutaname) [00:15:34] (03CR) 10Bsitu: [C: 032] Use variable instead of hardcoded permission [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159092 (owner: 10EBernhardson) [00:15:34] jackmcbarn: yeah, Translate and AccountAudit are the ones off the top of my head. [00:16:10] (03Merged) 10jenkins-bot: Use variable instead of hardcoded permission [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159092 (owner: 10EBernhardson) [00:17:05] i'm not entirely happy about it... [00:17:11] * jackmcbarn goes back to testing [00:20:16] (03CR) 10Chad: Require PHP 5.4.0 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/158895 (owner: 10Withoutaname) [00:21:53] (03CR) 10Chad: [C: 04-1] "Plus: 5.4? Last time I thought we talked about it I remember us discussing going straight to 5.5/HHVM, unless I'm mistaken." [core] - 10https://gerrit.wikimedia.org/r/158895 (owner: 10Withoutaname) [00:22:19] (03CR) 10EBernhardson: "Unless there is a good reason for 5.4, 5.5 makes more sense." [core] - 10https://gerrit.wikimedia.org/r/158895 (owner: 10Withoutaname) [00:27:04] legoktm: eeww "Anonymous" is hardcoded as the new-user name? what if there really is a user with that name? [00:27:35] don't blame meeee [00:27:57] * jackmcbarn git blames [00:30:40] (03PS1) 10Legoktm: Use CONTENT_FORMAT_JSON instead of "json" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159230 [00:30:47] Tim Laqua's fault [00:30:55] when? [00:30:57] I think he's the original author [00:31:13] commit e64ab644a87bc0a5f2b06f67f2c5b1c5bd0b55bd Date: Tue Feb 12 18:38:32 2008 +0000 [00:32:24] (03CR) 10EBernhardson: "would you mind at least describing the test case in commit message so can double check it works after deploy?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159230 (owner: 10Legoktm) [00:33:12] https://mediawiki.org/wiki/Special:Code/MediaWiki/30872 [00:33:19] (03CR) 10Legoktm: [C: 04-1] "This will probably break things..." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159230 (owner: 10Legoktm) [00:33:23] (03CR) 10EBernhardson: [C: 04-1] "17:32 < legoktm> oh crap." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159230 (owner: 10Legoktm) [00:34:29] 3MediaWiki / 3Logging: Store the page_id of the moved page in log_page - 10https://bugzilla.wikimedia.org/57084 (10Matthew Flaschen) 5PATC>3RESO/FIX [00:34:46] 3MediaWiki extensions / 3UserMerge: "Anonymous" is hardcoded as the username to merge to userid 0 - 10https://bugzilla.wikimedia.org/70591 (10Jackmcbarn) 3NEW p:3Unprio s:3normal a:3T. Gries To merge a user to userid 0, you must specify "Anonymous" as the merge target. However, this is a valid userna... [00:34:59] 3MediaWiki extensions / 3WikidataClient: Typo in MediaWiki:Wikibase-otherprojects-beta-description - 10https://bugzilla.wikimedia.org/70587#c3 (10Andre Klapper) MatmaRex: Argh, thank you. I can't read obviously. :) [00:36:17] (03CR) 10GOIII: [C: 031] Adds icons in the WikiEditor style [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/157115 (owner: 10Tpt) [00:37:59] and it actually merges the edits to have "Anonymous" as the name? eewwww [00:40:14] (03PS2) 10Legoktm: Use CONTENT_FORMAT_JSON instead of "json" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159230 [00:40:28] jackmcbarn: :))))) [00:43:00] (03CR) 10Jackmcbarn: [C: 04-1] "I'd like to have the old user not keep the promote entry, but the -1 is for the inline issue." (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/146025 (https://bugzilla.wikimedia.org/67769) (owner: 10Legoktm) [00:43:08] legoktm: one minor flaw [00:44:58] (03PS1) 10Legoktm: Don't let people turn random pages into Flow pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159231 [00:48:45] 3Wikimedia / 3General/Unknown: Add ContentHandler columns to Wikimedia wikis, and set $wgContentHandlerUseDB = true - 10https://bugzilla.wikimedia.org/49193#c11 (10Kunal Mehta (Legoktm)) 5PATC>3NEW Deployed by Erik, thanks! [00:49:24] (03CR) 10EBernhardson: [C: 032] Don't let people turn random pages into Flow pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159231 (owner: 10Legoktm) [00:49:57] (03Merged) 10jenkins-bot: Don't let people turn random pages into Flow pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159231 (owner: 10Legoktm) [00:50:10] (03PS1) 10EBernhardson: Don't let people turn random pages into Flow pages [extensions/Flow] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159234 [00:52:44] 3MediaWiki / 3MediaWiki UI: VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages - 10https://bugzilla.wikimedia.org/56363#c8 (10Matthew Flaschen) (In reply to Jared Zimmerman (WMF) from comment #7) > Cancel just returns an error for me now any... [00:52:53] (03CR) 10EBernhardson: [C: 032] Don't let people turn random pages into Flow pages [extensions/Flow] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159234 (owner: 10EBernhardson) [00:53:27] (03Merged) 10jenkins-bot: Don't let people turn random pages into Flow pages [extensions/Flow] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159234 (owner: 10EBernhardson) [00:53:29] 3MediaWiki / 3MediaWiki UI: VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages - 10https://bugzilla.wikimedia.org/56363#c9 (10Matthew Flaschen) I agree a cancel button is not really useful here, but in the meantime we should not be showing e... [00:55:19] (03PS1) 10EBernhardson: Bump Flow in 1.24wmf20 for Ic448da2b58 [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159235 [00:56:18] (03CR) 10EBernhardson: [C: 032] Bump Flow in 1.24wmf20 for Ic448da2b58 [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159235 (owner: 10EBernhardson) [00:57:12] (03CR) 10Mattflaschen: "The functional difference is that the:" [core] - 10https://gerrit.wikimedia.org/r/144601 (owner: 10Mattflaschen) [00:59:12] (03Merged) 10jenkins-bot: Bump Flow in 1.24wmf20 for Ic448da2b58 [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159235 (owner: 10EBernhardson) [01:02:01] 3MediaWiki / 3ContentHandler: Add a special page to change a page's content model when $wgContentHandlerUseDB = true; - 10https://bugzilla.wikimedia.org/70592 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3enhanc a:3None Currently the only way to change a page's content model is to use the API, which is... [01:04:47] 3MediaWiki / 3API: API: action=edit, Unknown error: \"content-not-allowed-here\" - 10https://bugzilla.wikimedia.org/70593 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None { "servedby": "mw1129", "error": { "code": "unknownerror", "info": "Unknown error: \"content-not... [01:08:42] jackmcbarn: so just array_unique should fix that? [01:09:54] legoktm: it should, as long as the db write doesn't freak out that the keys aren't sequential anymore (which it has no need to) [01:09:59] 3MediaWiki / 3API: API: action=edit, Unknown error: \"content-not-allowed-here\" - 10https://bugzilla.wikimedia.org/70593#c1 (10Brad Jorsch) This is why I plan to kill ApiBase::dieUsageMsg, and generally rework the error reporting functions. [01:10:59] so should we wrap it in a sort too? [01:11:27] legoktm: i don't know whether that's necessary, but it wouldn't hurt [01:12:12] (03PS2) 10Legoktm: Add UserMerge support [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/146025 (https://bugzilla.wikimedia.org/67769) [01:12:39] (03CR) 10Legoktm: Add UserMerge support (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/146025 (https://bugzilla.wikimedia.org/67769) (owner: 10Legoktm) [01:12:48] ok, did both [01:17:25] legoktm: shouldn't array_merge(array_unique be array_unique(array_merge ? [01:17:36] uhhhh [01:17:37] yes [01:17:56] oops [01:18:06] (03PS3) 10Legoktm: Add UserMerge support [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/146025 (https://bugzilla.wikimedia.org/67769) [01:18:41] (03PS3) 10Legoktm: Use CONTENT_FORMAT_JSON instead of "json" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159230 [01:19:03] (03PS1) 10Alex Monk: Add content-not-allowed-here to API message map [core] - 10https://gerrit.wikimedia.org/r/159237 (https://bugzilla.wikimedia.org/70593) [01:19:05] (03CR) 10Legoktm: "Ok, this should no longer break things, and I made the commit message more detailed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159230 (owner: 10Legoktm) [01:20:31] (03PS1) 10Jackmcbarn: Expose variables (aka magic words) to Lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/159238 [01:20:55] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (1c5e409ab1) [core] - 10https://gerrit.wikimedia.org/r/159240 [01:21:27] (03CR) 10Esanders: [C: 032] Update OOjs UI to v0.1.0-pre (1c5e409ab1) [core] - 10https://gerrit.wikimedia.org/r/159240 (owner: 10Jforrester) [01:27:06] James_F: http://amara.org/en/videos/LyzbQUH2ljH0/info/social-machines-x-reaction/?tab=video [01:27:12] i captioned the VE session. [01:27:21] TrevorP|Away: ^ [01:27:26] RoanKattouw_away: ^ [01:27:41] thedj: Nice! Thanks. [01:27:58] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (1c5e409ab1) [core] - 10https://gerrit.wikimedia.org/r/159240 (owner: 10Jforrester) [01:28:43] James_F: i know one thing, not doing that for all the other sessions recorded in that room... [01:29:01] took hours with the bad audio :( [01:29:18] thedj: :-( [01:30:45] (03CR) 10Jackmcbarn: [C: 04-1] "One other thing: If you're merging to userid 0, the autopromote data should just be thrown away, not given to anons." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/146025 (https://bugzilla.wikimedia.org/67769) (owner: 10Legoktm) [01:30:51] legoktm: ^ [01:35:30] thedj: Is there a way to extract those subtitles and put them on Commons alongside the video/ [01:48:33] (03CR) 10BryanDavis: Wiki installer now conditional on existence of database (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/159217 (https://bugzilla.wikimedia.org/50912) (owner: 10Dduvall) [01:58:42] (03CR) 10BryanDavis: Mathoid role (032 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/156137 (owner: 10Physikerwelt) [02:26:27] (03PS1) 10Jdlrobson: H9: Don't collapse topics in the topic namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159246 [02:27:28] (03PS1) 10Jdlrobson: Align watch star correctly in Minerva [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159247 (https://bugzilla.wikimedia.org/69868) [02:27:33] (03PS1) 10Jdlrobson: Make notifications work in mobile using standard mobile delivery mechanism [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159248 [02:27:47] (03PS1) 10Jdlrobson: Do not show the currently selected sort option [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159249 (https://bugzilla.wikimedia.org/67830) [02:28:55] (03PS2) 10Jdlrobson: H5: Hide reply and edit links in locked posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158618 [02:29:01] (03CR) 10jenkins-bot: [V: 04-1] H5: Hide reply and edit links in locked posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158618 (owner: 10Jdlrobson) [02:40:09] (03CR) 10BryanDavis: [C: 032] GWToolset Role Additions [vagrant] - 10https://gerrit.wikimedia.org/r/158950 (https://bugzilla.wikimedia.org/70570) (owner: 10Dan-nl) [02:40:17] (03Merged) 10jenkins-bot: GWToolset Role Additions [vagrant] - 10https://gerrit.wikimedia.org/r/158950 (https://bugzilla.wikimedia.org/70570) (owner: 10Dan-nl) [02:50:15] (03PS3) 10BryanDavis: Add a role that converts all PHP warnings/notices into errors [vagrant] - 10https://gerrit.wikimedia.org/r/156602 (owner: 10MaxSem) [03:31:55] (03PS4) 10BryanDavis: Add a role that converts all PHP warnings/notices into errors [vagrant] - 10https://gerrit.wikimedia.org/r/156602 (owner: 10MaxSem) [03:32:01] (03CR) 10BryanDavis: [C: 032] Add a role that converts all PHP warnings/notices into errors [vagrant] - 10https://gerrit.wikimedia.org/r/156602 (owner: 10MaxSem) [03:32:06] (03Merged) 10jenkins-bot: Add a role that converts all PHP warnings/notices into errors [vagrant] - 10https://gerrit.wikimedia.org/r/156602 (owner: 10MaxSem) [03:38:41] hey bd808, do you know if any work has been done to get a varnish role for vagrant? [03:39:16] legoktm: There was a bit of work in Zürich but it didn't get very far [03:39:28] Yuvi took a shot at it long ago too [03:39:58] The tricky part is deciding what we want varnish to do in MWV [03:40:17] emulate prod? [03:40:21] The prod vcl code is not very generic. [03:40:40] :( [03:41:37] legoktm: It's a problem worth thinking about. If we had some reasonable requirements I think it could be done. [03:41:48] But "emulate prod" isn't very reasonable [03:42:00] heh [03:42:28] well, I guess it would basically be have logged out users hit varnish, and logged in ones bypass it? I don't actually know how varnish works so... [03:42:55] Everything hits it, but some things are "passed" to the backend and others check cache [03:43:13] hm [03:43:29] well, what I really want to do right now is test whether my extension will work properly with varnish, I'm guessing it won't. [03:43:40] Prod is pretty complex with multiple varnish groups and most having 2 layers of cache [03:43:46] "work properly with varnish" is ambiguous [03:43:47] way too fancy for MWV [03:43:56] yeah [03:44:32] Something that worked mostly like the misc varnish cluster might be good though [03:44:50] yeah, I don't even know how it works, so :P [03:45:35] Just having a basic "cache things unless the vary header says not to" and passing authed users through would probably help with testing basic things [03:45:54] ori: basically the GlobalUserPage extension pretends a user page exists and displays some HTML, and it does a remote db query to get the page_touched which is embedded in the cache key. But if that is cached by varnish, there is nothing that purges the caches because there are no edits on the local wiki [03:46:10] (I think) [03:46:46] eww. Yeah that might be problematic [03:47:38] varnish respects cache-control / expires / max-age headers [03:47:43] I'm thinking we can just fire off cross-wiki jobs that call Title::purgeSquid(), but it would be nice if I could test it [03:48:12] oh… there is/was a way to test that. [03:48:58] legoktm: You need this I think -- https://github.com/bd808/htcpsnoop [03:49:18] Those udp packets are way purgeSquid emits [03:49:25] s/way/what/ [03:49:27] hmm [03:49:41] well, I just visited a global user page on my test wiki logged out and it sent a Cache-Control: "private, must-revalidate, max-age=0" header [03:49:51] I made that when I was testing changes to the purge maintenance scripts [03:50:28] https://en.wikipedia.org/wiki/ThisPageDoesntExist has the same header while logged out [03:51:04] so that means it doesn't get cached by varnish? [03:51:50] yep [03:52:00] red links hit the backends [03:52:05] it's an issue [03:52:48] it's easy to check for yourself, btw: curl -I https://en.wikipedia.org/wiki/ThisPageDoesntExist | grep X-Cache [03:53:40] Why would https://en.wikipedia.org/wiki/User:BDavis_(WMF) have those headers too? [03:55:07] bd808: because you're logged in? [03:55:29] Nope. Getting them in an incognito window and via curl [03:55:52] users are special maybe? [03:56:08] well, this addresses my issues in any case [03:58:09] I'm getting "Cache-Control: private, s-maxage=0, max-age=0, must-revalidate" on all kinds of random pages in enwiki (even ones that also show X-Cache hits) [03:58:43] :/ [03:58:53] curl -sI 'http://en.wikipedia.org/wiki/Spoon' | grep Cache [03:59:00] well what are you sending? cookies? how about hosts file? [03:59:11] * jeremyb fetches laptop [03:59:31] also, don't use -I [03:59:53] use -vs >/dev/null [04:06:11] curl -vso /dev/null 'http://en.wikipedia.org/wiki/Cheese' -- still has "Cache-Control: private" on both ipv4 and ipv6. I'm confused but that's not a new thing with me and Varnish. [04:06:59] No cookies. No weird hosts file. [04:07:54] yes, something's weird there [04:08:00] new i think [04:08:17] but look at the Age: header [04:08:24] so i'm not toooo concerned [04:09:33] Yeah. The result is coming out of Varnish but with headers I wouldn't expect. [04:09:49] ohhhhhhh [04:09:54] i think i have an answer maybe [04:10:53] (03PS1) 10Damienkan: Testing my ability to commit code. [extensions/examples] - 10https://gerrit.wikimedia.org/r/159251 [04:14:48] damn `time git status -sb` takes forever [04:15:11] maybe i need ssd [04:27:50] bd808: so, not sure why we're doing this. seems not like our traditional behavior. introduced at https://gerrit.wikimedia.org/r/65541 [04:29:31] I would randomly guess that it is a trick for better click tracking by analytics [04:30:51] huh. well i wonder... [04:30:56] and then later ori added another piece. https://gerrit.wikimedia.org/r/137265 [04:31:16] 3MediaWiki / 3MediaWiki UI: componentize compact personal bar code into general list control - 10https://bugzilla.wikimedia.org/70433#c4 (10Matthew Flaschen) (In reply to Jon from comment #1) > Flow has menus and it would be good to understand if they are different and > if so why they are different. It see... [04:32:15] duh: So based on that vcl you can't trust the Cache-Control header you see returned from Varnish to decide if you will have issues or not :/ [04:33:57] bahhhhh [04:35:28] :D [04:35:59] bd808: anyway, that's not really relevant. what we need to know is are the htcp being sent [04:36:17] and for the right pages/paths [04:36:47] * bd808 nods [04:37:53] (03PS1) 10Legoktm: Use Config instead of globals, part 1 [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/159252 [04:39:15] 3MediaWiki / 3MediaWiki UI: HTMLMultiSelectField checkboxes do not use MW UI - 10https://bugzilla.wikimedia.org/70473#c1 (10Matthew Flaschen) p:5Unprio>3Normal Thanks for the report. The underlying code has a TODO, but this will help track it better. Special:EditWatchlist uses EditWatchlistCheckboxSeri... [04:39:16] 3MediaWiki / 3MediaWiki UI: Set $wgUseMediaWikiUIEverywhere = true (tracking) - 10https://bugzilla.wikimedia.org/70424 (10Matthew Flaschen) [04:41:03] (03PS1) 10Legoktm: Revert "Remove unused GlobalUserPage::isSourcePage()" [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/159253 [04:41:13] (03CR) 10Legoktm: [C: 032] Revert "Remove unused GlobalUserPage::isSourcePage()" [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/159253 (owner: 10Legoktm) [04:41:19] (03Merged) 10jenkins-bot: Revert "Remove unused GlobalUserPage::isSourcePage()" [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/159253 (owner: 10Legoktm) [05:02:04] (03PS1) 10Prtksxna: renderer: Actually use eventLogging [extensions/Popups] - 10https://gerrit.wikimedia.org/r/159256 [05:03:47] (03CR) 10Legoktm: [C: 032] "Can't wait to get rid of this." [core] - 10https://gerrit.wikimedia.org/r/159237 (https://bugzilla.wikimedia.org/70593) (owner: 10Alex Monk) [05:06:29] 3MediaWiki / 3MediaWiki UI: Inactive checkboxes create mousepointer style issues - 10https://bugzilla.wikimedia.org/70474#c1 (10Matthew Flaschen) The main part could probably be fixed with setting cursor appropriately. However, I don't know why Firefox (unless this is code somewhere else) is apparently chan... [05:07:45] 3MediaWiki / 3MediaWiki UI: Set $wgUseMediaWikiUIEverywhere = true (tracking) - 10https://bugzilla.wikimedia.org/70424 (10Matthew Flaschen) [05:07:45] 3MediaWiki / 3MediaWiki UI: Inactive checkboxes create mousepointer style issues - 10https://bugzilla.wikimedia.org/70474 (10Matthew Flaschen) [05:10:09] (03Merged) 10jenkins-bot: Add content-not-allowed-here to API message map [core] - 10https://gerrit.wikimedia.org/r/159237 (https://bugzilla.wikimedia.org/70593) (owner: 10Alex Monk) [05:13:15] (03CR) 10Gilles: "Solved by email, I was using Host: upload.wikipedia.org when I should have been using Host: upload.wikimedia.org" [core] - 10https://gerrit.wikimedia.org/r/157157 (owner: 10Gilles) [05:20:44] 3MediaWiki-Vagrant: fail to build a new machine - 10https://bugzilla.wikimedia.org/70314#c2 (10Yuri Astrakhan) http://pastebin.com/g47qTxAT Fresh machine rebuild - still fails. I listed all the enabled roles at the end. [05:21:07] (03PS3) 10Dan-nl: Add Curl Constants Test [core] - 10https://gerrit.wikimedia.org/r/159159 (https://bugzilla.wikimedia.org/70570) [05:23:05] (03CR) 10Dan-nl: "* addressed bryan’s comments in ps2" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/159159 (https://bugzilla.wikimedia.org/70570) (owner: 10Dan-nl) [05:27:20] (03PS1) 10Dan-nl: Remove CURLCURLOPT_REDIR_PROTOCOLS defined test [vagrant] - 10https://gerrit.wikimedia.org/r/159257 (https://bugzilla.wikimedia.org/70570) [05:31:51] (03CR) 10Dan-nl: "thanks PleaseStand!" [core] - 10https://gerrit.wikimedia.org/r/159214 (https://bugzilla.wikimedia.org/70570) (owner: 10PleaseStand) [05:32:14] 3MediaWiki / 3Special pages: Special:AllPages no longer has Next link (regression?) - 10https://bugzilla.wikimedia.org/69951#c1 (10JAn Dudík) There is also missing overview page. Recently there was first page with some groups like * !-Beef * Beef-Guam * Guar-Yello * Yellow-some_special_character so users we... [05:33:04] 3MediaWiki / 3MediaWiki UI: Special:Preferences: Custom (other) input field for Time offset is too long - 10https://bugzilla.wikimedia.org/70405#c4 (10Matthew Flaschen) Thanks. Special:Preferences => Appearance tab => Time offset => Other (specify offset) Then, the text field below is too long. [05:38:15] !/window 2 [05:39:01] (03PS4) 10Dan-nl: Add Curl Constants Test [core] - 10https://gerrit.wikimedia.org/r/159159 (https://bugzilla.wikimedia.org/70570) [05:39:03] (03PS3) 10Tim Starling: Make timer/profiler be thread-safe [php/luasandbox] - 10https://gerrit.wikimedia.org/r/159011 (https://bugzilla.wikimedia.org/70177) [05:40:18] (03CR) 10Dan-nl: "removed an incorrect bug reference" [core] - 10https://gerrit.wikimedia.org/r/159159 (https://bugzilla.wikimedia.org/70570) (owner: 10Dan-nl) [05:42:44] (03CR) 10Tim Starling: "The leak warning is not hit by MW in my simple testing -- maybe with the full test rig on osmium it will be hit?" [php/luasandbox] - 10https://gerrit.wikimedia.org/r/159011 (https://bugzilla.wikimedia.org/70177) (owner: 10Tim Starling) [05:43:14] 3MediaWiki / 3MediaWiki UI: componentize compact personal bar code into general list control - 10https://bugzilla.wikimedia.org/70433#c5 (10Jared Zimmerman (WMF)) Matt, I think we're saying the same thing, the CPB *is* a dropdown list, for mw.ui we just need to remove the hover expand behavior (but keep a ho... [05:43:44] 3MediaWiki / 3MediaWiki UI: Set $wgUseMediaWikiUIEverywhere = true (tracking) - 10https://bugzilla.wikimedia.org/70424 (10Jared Zimmerman (WMF)) [05:43:44] 3MediaWiki / 3MediaWiki UI: componentize compact personal bar code into general list control - 10https://bugzilla.wikimedia.org/70433 (10Jared Zimmerman (WMF)) [05:52:47] (03CR) 10Mattflaschen: [C: 04-2] "None of those changes are reason for us to upgrade. In fact, they don't affect MediaWiki in any way:" [core] - 10https://gerrit.wikimedia.org/r/158867 (owner: 10Paladox) [05:57:20] (03CR) 10Gilles: [C: 04-1] "In Firefox going to step 2 (upload), UW scrolls to some large empty space to the right of the UI. This behavior and the emtpy space itself" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester) [05:57:33] I can't tell if Gerrit or my browser are being stupid. [06:01:59] 3MediaWiki extensions / 3UserMerge: "Anonymous" is hardcoded as the username to merge to userid 0 - 10https://bugzilla.wikimedia.org/70591 (10T. Gries) p:5Unprio>3Normal [06:04:46] 3MediaWiki / 3API: API: action=edit, Unknown error: \"content-not-allowed-here\" - 10https://bugzilla.wikimedia.org/70593#c4 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3Alex Monk (In reply to Brad Jorsch from comment #1) > This is why I plan to kill ApiBase::dieUsageMsg, and generally rework the > err... [06:06:20] (03CR) 10Nikerabbit: "My reason is to get consistent error codes to make it easier to handle situations where session has expired." [core] - 10https://gerrit.wikimedia.org/r/156093 (owner: 10Nikerabbit) [06:07:12] (03PS5) 10Dan-nl: Add cURL constants test [core] - 10https://gerrit.wikimedia.org/r/159159 (https://bugzilla.wikimedia.org/70570) [06:08:11] (03CR) 10Dan-nl: "* added a code comment explaining why the test was added" [core] - 10https://gerrit.wikimedia.org/r/159159 (https://bugzilla.wikimedia.org/70570) (owner: 10Dan-nl) [06:17:46] (03CR) 10Amire80: [C: 032] Add linkTrail for Central Kurdish (ckb) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/159120 (owner: 10Calak) [06:19:36] (03CR) 10Mattflaschen: "At this time, I don't plan to review any changes to this extension." [extensions/MsUpload] (REL1_23) - 10https://gerrit.wikimedia.org/r/158888 (owner: 10Paladox) [06:23:46] (03Merged) 10jenkins-bot: Add linkTrail for Central Kurdish (ckb) [core] - 10https://gerrit.wikimedia.org/r/159120 (owner: 10Calak) [06:24:15] 3Wikimedia / 3Extension setup: Review and deploy GlobalUserPage extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/70576#c4 (10Isarra) I still don't like that border. #aaa is awfully dark when it's just white all around on both sides, especially in skins like vector with a lot of much more subtl... [06:27:58] (03CR) 10Nikerabbit: resourceloader: Condition-wrap the HTML tag instead of JS response (033 comments) [core] - 10https://gerrit.wikimedia.org/r/159086 (https://bugzilla.wikimedia.org/69924) (owner: 10Krinkle) [06:29:29] 3MediaWiki / 3MediaWiki UI: Set $wgUseMediaWikiUIEverywhere = true (tracking) - 10https://bugzilla.wikimedia.org/70424 (10Matthew Flaschen) [06:29:30] 3MediaWiki / 3MediaWiki UI: Checkboxes with multiline labels cause broken focus state - 10https://bugzilla.wikimedia.org/70551#c1 (10Matthew Flaschen) Thanks for the report. Hmm, this border is implemented differently from the main checkbox. It's on ::after rather than ::before. If it can't be fixed in CS... [06:33:04] (03CR) 10Tpt: [C: 032] "Reviewed by two people" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/157115 (owner: 10Tpt) [06:33:23] (03Merged) 10jenkins-bot: Adds icons in the WikiEditor style [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/157115 (owner: 10Tpt) [06:51:00] 3MediaWiki extensions / 3CentralAuth: login when already logged in gets exception from Special:CentralLogin - 10https://bugzilla.wikimedia.org/69834#c16 (10Matthew Flaschen) (In reply to Kunal Mehta (Legoktm) from comment #9) > I wonder if we should even be triggering the UserLoginComplete hook if the > user... [06:53:55] (03CR) 10Withoutaname: "In any case, this patch was just meant to be a demonstration, as I wasn't aware of any migration plan to either PHP 5.4 or PHP 5.5 at the " (031 comment) [core] - 10https://gerrit.wikimedia.org/r/158895 (owner: 10Withoutaname) [07:03:14] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: Some beta features are incorrectly reporting javascript is need (when it is already enabled) - 10https://bugzilla.wikimedia.org/70371#c3 (10Matthew Flaschen) That will probably workaround it, but the underlying problem seemed to be bug 69823. [07:03:18] 3MediaWiki extensions / 3BetaFeatures: wgBetaFeaturesFeatures is incomplete, causing wrong UI in preferences - 10https://bugzilla.wikimedia.org/69823 (10Matthew Flaschen) [07:04:00] 3MediaWiki extensions / 3BetaFeatures: With JavaScript disabled, BetaFeatures's "this feature requires javascript" labels are absent - 10https://bugzilla.wikimedia.org/69779 (10Matthew Flaschen) [07:04:00] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: Some beta features are incorrectly reporting javascript is need (when it is already enabled) - 10https://bugzilla.wikimedia.org/70371 (10Matthew Flaschen) [07:05:42] (03CR) 10Mattflaschen: "Even simpler (and slightly more performant)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/159098 (https://bugzilla.wikimedia.org/70371) (owner: 10Jforrester) [07:07:28] (03PS4) 10Legoktm: Add UserMerge support [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/146025 (https://bugzilla.wikimedia.org/67769) [07:07:31] jackmcbarn: ^ [07:08:30] 3MediaWiki / 3General/Unknown: MediaWiki should not expose any UI elements which require JavaScript when it is off (tracking) - 10https://bugzilla.wikimedia.org/69845 (10Matthew Flaschen) 5NEW>3RESO/FIX [07:12:17] James_F|Away: yes, that's possible. you can just downlad them as SRT [07:12:18] (03CR) 10Filippo Giunchedi: [C: 031] "also re: Gergo concerns I think we should start simple and hit varnish and keep an eye on it, switching to asking swift directly if it is " [core] - 10https://gerrit.wikimedia.org/r/157157 (owner: 10Gilles) [07:28:15] 3MediaWiki extensions / 3WikidataClient: other projects feature broken with $wgEnableSidebarCache = true - 10https://bugzilla.wikimedia.org/70234 (10tobias.gritschacher) 5PATC>3RESO/FIX [07:35:30] 3MediaWiki / 3MediaWiki UI: MediaWiki UI styles are applied to core instead of relevant skins - 10https://bugzilla.wikimedia.org/70351#c10 (10Matthew Flaschen) (In reply to Isarra from comment #9) > Sure, the colour-coded buttons according to their function are nice, but not everyone cares. And yet someone... [07:40:06] (03PS2) 10Mattflaschen: Have GettingStarted depend on PageImages [vagrant] - 10https://gerrit.wikimedia.org/r/159186 [07:40:30] (03CR) 10Mattflaschen: "Done." (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/159186 (owner: 10Mattflaschen) [07:46:36] chasemp, I don't know if you already did this, but no need to migrate the Growth board at fab.wmflabs.org. It was only for testing. [07:46:40] If you already did, no worries. [07:50:29] (03CR) 10Gilles: [C: 032] update INSTALL instructions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/158625 (owner: 10Dan-nl) [07:50:36] (03Merged) 10jenkins-bot: update INSTALL instructions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/158625 (owner: 10Dan-nl) [08:19:44] 3MediaWiki / 3MediaWiki UI: Set $wgUseMediaWikiUIEverywhere = true (tracking) - 10https://bugzilla.wikimedia.org/70424 (10Matthew Flaschen) [08:19:44] 3MediaWiki / 3MediaWiki UI: componentize compact personal bar code into general list control - 10https://bugzilla.wikimedia.org/70433#c6 (10Matthew Flaschen) Deploying a new select box control everywhere will be complex. It can't be done with just "normal" styling and the standard element (e.g. ) lik... [08:28:44] 3MediaWiki-Vagrant: fail to build a new machine - 10https://bugzilla.wikimedia.org/70314#c3 (10Yuri Astrakhan) Tried disabling vector skin just in case - http://pastebin.com/2RmrnnC2 [08:57:27] (03PS2) 10Aude: Fix undefined argument in OldChangesList [core] - 10https://gerrit.wikimedia.org/r/158881 (https://bugzilla.wikimedia.org/70407) [08:59:26] (03PS3) 10Aude: Fix undefined argument in OldChangesList [core] - 10https://gerrit.wikimedia.org/r/158881 (https://bugzilla.wikimedia.org/70407) [09:15:08] (03CR) 10Mitar: "I can wait, but can you then ping me here when you push that patches in so that I just add the checkbox?" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/153983 (https://bugzilla.wikimedia.org/69250) (owner: 10Mitar) [09:26:06] (03PS2) 10Hiong3-eng5: Special Page Add From External API [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/158842 [09:26:11] (03CR) 10jenkins-bot: [V: 04-1] Special Page Add From External API [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/158842 (owner: 10Hiong3-eng5) [09:42:53] (03PS1) 10Legoktm: Add script to make a list of users who will be renamed [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159266 [09:45:47] (03PS3) 10Paladox: Update jquery.jStorage.js [core] - 10https://gerrit.wikimedia.org/r/158866 [09:48:29] (03CR) 10Tweichart: [C: 032 V: 032] ie8 indexOf fix [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/157048 (owner: 10Tweichart) [10:31:29] 3MediaWiki extensions / 3WikidataClient: "Invalid token" error when trying to add language link from Wikipedia - 10https://bugzilla.wikimedia.org/70415 (10Robby) 5RESO/FIX>3VERI [10:31:59] 3MediaWiki extensions / 3WikidataClient: "Invalid token" error when trying to add language link from Wikipedia - 10https://bugzilla.wikimedia.org/70415 (10Robby) 5VERI>3VERI [10:36:28] (03PS1) 10Daniel Kinzler: Pass ParserOutput to SkinTemplateGetLanguageLink hook. [core] - 10https://gerrit.wikimedia.org/r/159276 [10:36:55] (03CR) 10jenkins-bot: [V: 04-1] Pass ParserOutput to SkinTemplateGetLanguageLink hook. [core] - 10https://gerrit.wikimedia.org/r/159276 (owner: 10Daniel Kinzler) [10:39:48] (03PS2) 10Daniel Kinzler: Pass ParserOutput to SkinTemplateGetLanguageLink hook. [core] - 10https://gerrit.wikimedia.org/r/159276 [10:41:57] anyone around to merge that oneliner? ---^ [10:45:58] * MatmaRex looks [10:47:33] DanielK_WMDE: isn't $this->getOutput() the OutputPage rather than ParserOutput? [10:49:53] MatmaRex: gah, you are right of course. that's what I meant. sorry, dealing with a ParserOutput object in another patch. [10:50:07] OP and PO still get me confused. [10:50:57] yeah, we're really bad at naming things [10:51:19] RequestContext and ResourceLoaderContext also confuse me to no end [10:51:52] (03PS3) 10Daniel Kinzler: Pass OutputPage to SkinTemplateGetLanguageLink hook. [core] - 10https://gerrit.wikimedia.org/r/159276 [10:52:28] (03CR) 10jenkins-bot: [V: 04-1] Pass OutputPage to SkinTemplateGetLanguageLink hook. [core] - 10https://gerrit.wikimedia.org/r/159276 (owner: 10Daniel Kinzler) [10:53:12] DanielK_WMDE: how does this help with getting the badges? (curious) it doesn't seem like something OutputPage would know about [10:53:21] (03PS4) 10Daniel Kinzler: Pass OutputPage to SkinTemplateGetLanguageLink hook. [core] - 10https://gerrit.wikimedia.org/r/159276 [10:54:20] (03CR) 10Aude: [C: 04-1] "nitpick, see patchset 3" [core] - 10https://gerrit.wikimedia.org/r/159276 (owner: 10Daniel Kinzler) [10:54:30] MatmaRex: OutputPage does not yet know about it. But the badges need to be generated and cached the same way langlinks are: Parser -> ParserOutput -> OutputPage -> Skin [10:54:35] (03CR) 10Aude: Pass OutputPage to SkinTemplateGetLanguageLink hook. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/159276 (owner: 10Daniel Kinzler) [10:55:08] MatmaRex: it's already possible, except for the last step, where i need to be able to access the OP from the skin hook. [10:55:46] (03Abandoned) 10Zfilipin: Testing my ability to commit code. [extensions/examples] - 10https://gerrit.wikimedia.org/r/159251 (owner: 10Damienkan) [10:55:49] OutputPage has access to ParserOutput [10:56:32] right, sounds reasonable [10:56:52] (03PS5) 10Daniel Kinzler: Pass OutputPage to SkinTemplateGetLanguageLink hook. [core] - 10https://gerrit.wikimedia.org/r/159276 [10:57:36] aude: OutputPage grabs info from ParserOutput, but doesn#t have a reference to a ParserOutput object [10:57:53] MatmaRex: ok, grammar fixed. merge? [10:58:03] (03CR) 10Aude: "wondering what problem is this patch trying to solve?" [core] - 10https://gerrit.wikimedia.org/r/143211 (owner: 10Withoutaname) [10:58:19] DanielK_WMDE: that's correct [10:59:30] alright [10:59:40] \o/ [10:59:44] (03CR) 10Bartosz Dziewoński: [C: 032] Pass OutputPage to SkinTemplateGetLanguageLink hook. [core] - 10https://gerrit.wikimedia.org/r/159276 (owner: 10Daniel Kinzler) [10:59:55] * DanielK_WMDE is off to lunch [11:02:17] (03CR) 10Aude: Subclass the Action class under ContextSource (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143211 (owner: 10Withoutaname) [11:05:35] (03Merged) 10jenkins-bot: Pass OutputPage to SkinTemplateGetLanguageLink hook. [core] - 10https://gerrit.wikimedia.org/r/159276 (owner: 10Daniel Kinzler) [11:12:59] 3Wikimedia / 3General/Unknown: Specific commonswiki page title too long making all scripts fail on that page - 10https://bugzilla.wikimedia.org/69243#c3 (10merl) I detected this problem because my labs database bot created links which were not linked on rendered view (example [[de:Special:Permalink/132869819... [11:32:29] 3Wikimedia / 3General/Unknown: Specific commonswiki page title too long making all scripts fail on that page - 10https://bugzilla.wikimedia.org/69243#c4 (10Bartosz Dziewoński) (In reply to merl from comment #0) > and json object contains wrong information, too: I can't reproduce this, the variables are all... [12:04:14] 3Wikimedia / 3General/Unknown: Specific commonswiki page title too long making all scripts fail on that page - 10https://bugzilla.wikimedia.org/69243#c5 (10Daniel Kinzler) Note that the limit for file names (and thus titles in the File namespace) is 240 characters, not 255 as for other pages. No idea if that... [12:16:25] (03CR) 10Matthias Mullie: [C: 04-1] H-4: Rename Close -> Lock (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158634 (owner: 10EBernhardson) [12:25:40] (03CR) 10Bartosz Dziewoński: "I'm going to split the logo part to a separate part, so that we might merge the simple stuff now and think about the logo later." [core] - 10https://gerrit.wikimedia.org/r/158650 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [12:25:53] (03PS2) 10Bartosz Dziewoński: Move remaining skin files to assets/ directory [core] - 10https://gerrit.wikimedia.org/r/158650 (https://bugzilla.wikimedia.org/69277) [12:26:06] (03CR) 10Smuggli: [C: 032 V: 032] i18n: make extension descriptions translatable [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156082 (owner: 10Shirayuki) [12:33:45] (03PS3) 10Bartosz Dziewoński: Move footer icons to assets/ directory [core] - 10https://gerrit.wikimedia.org/r/158650 (https://bugzilla.wikimedia.org/69277) [12:33:47] (03PS1) 10Bartosz Dziewoński: Move default logo to assets/ directory [core] - 10https://gerrit.wikimedia.org/r/159290 (https://bugzilla.wikimedia.org/69277) [12:33:55] (03CR) 10Bartosz Dziewoński: "Split to https://gerrit.wikimedia.org/r/159290" [core] - 10https://gerrit.wikimedia.org/r/158650 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [12:37:48] (03CR) 10MZMcBride: H-4: Rename Close -> Lock (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158634 (owner: 10EBernhardson) [12:40:01] (03PS2) 10Smuggli: css changes [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/158608 (owner: 10Tweichart) [12:41:08] (03CR) 10Smuggli: [C: 032 V: 032] css changes [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/158608 (owner: 10Tweichart) [12:52:54] (03PS1) 10Smuggli: Added missing i18n file for magic words [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/159292 [12:54:29] (03PS2) 10Smuggli: Added missing i18n file for magic words [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/159292 [13:14:35] (03PS3) 10Mglaser: Checklist assistant [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151797 [13:25:50] (03CR) 10Smuggli: [C: 032 V: 032] Added missing i18n file for magic words [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/159292 (owner: 10Smuggli) [13:36:46] 3MediaWiki extensions / 3WikidataRepo: Edit mode for fingerprintlistview widget - 10https://bugzilla.wikimedia.org/69841 (10tobias.gritschacher) [13:36:46] 3MediaWiki extensions / 3WikidataRepo: Get rid of global events in UI - 10https://bugzilla.wikimedia.org/70172 (10tobias.gritschacher) [13:36:47] 3MediaWiki extensions / 3WikidataRepo: Allow adding references for statements on properties in the UI - 10https://bugzilla.wikimedia.org/68379 (10tobias.gritschacher) [13:38:59] 3MediaWiki extensions / 3WikidataRepo: Test conformance of API modules - 10https://bugzilla.wikimedia.org/67407 (10tobias.gritschacher) [13:39:15] 3MediaWiki extensions / 3WikidataClient: Usage Tracking: implement the service - 10https://bugzilla.wikimedia.org/64587 (10tobias.gritschacher) [13:39:45] 3MediaWiki extensions / 3WikidataClient: Usage Tracking: design database schema for service that registers where data is used - 10https://bugzilla.wikimedia.org/64586 (10tobias.gritschacher) [13:42:14] 3MediaWiki extensions / 3WikidataClient: draft RfC for improving recent changes formatting - 10https://bugzilla.wikimedia.org/68028#c1 (10Aude) 5ASSI>3RESO/FIX https://www.mediawiki.org/wiki/Requests_for_comment/ChangesList_formatting [13:47:09] (03PS2) 10Matthias Mullie: H-4: Rename Close -> Lock [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158634 (owner: 10EBernhardson) [13:47:18] (03CR) 10jenkins-bot: [V: 04-1] H-4: Rename Close -> Lock [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158634 (owner: 10EBernhardson) [13:47:21] (03CR) 10Matthias Mullie: H-4: Rename Close -> Lock (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158634 (owner: 10EBernhardson) [13:52:59] https://github.com/wikimedia/mediawiki-core/pull/30 [13:53:07] (PS: I would be grateful if I become a MediaWiki developer for Wikimedia Foundation.) [13:54:44] 3MediaWiki / 3MediaWiki UI: VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages - 10https://bugzilla.wikimedia.org/56363#c10 (10Jon) ... or we could just remove the cancel button. [13:54:58] http://wayback.archive.org/web/20130515141900/https://noc.wikimedia.org/base.css [13:56:21] Doesn't seem to have terribly much value :P [13:56:59] yeah [13:57:18] comment added in 33c0d601ca7b9ea88937e1f44089800b9ad96ed2 [13:57:48] https://gerrit.wikimedia.org/r/#/c/25427/ [13:57:57] (man, we've been using gerrit for a long time.) [13:59:28] i have a changeset in the 5000 that I still need to finish :) [14:00:09] or rather, Joancreus does, but i think i sort of took it over now :) [14:01:29] 3MediaWiki / 3MediaWiki UI: VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages - 10https://bugzilla.wikimedia.org/56363#c11 (10Bartosz Dziewoński) I like the "It causes problems? Remove it!" approach, we should do this more often. I wonder w... [14:03:57] does someone want to review https://gerrit.wikimedia.org/r/#/c/158881/ ? [14:04:45] (03PS3) 10Matthias Mullie: H-4: Rename Close -> Lock [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158634 (owner: 10EBernhardson) [14:05:15] 3MediaWiki extensions / 3WikidataClient: update other projects sidebar in more cache-friendly way - 10https://bugzilla.wikimedia.org/70482 (10tobias.gritschacher) p:5Unprio>3High s:5normal>3critic [14:05:22] (03CR) 10jenkins-bot: [V: 04-1] H-4: Rename Close -> Lock [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158634 (owner: 10EBernhardson) [14:06:13] (03PS4) 10Aude: Fix undefined argument in OldChangesList [core] - 10https://gerrit.wikimedia.org/r/158881 (https://bugzilla.wikimedia.org/70407) [14:07:09] (03CR) 10Matthias Mullie: [C: 031] "PS2: added BC, mainly for users who have cached JS that, when attempting to close/lock, would still fire old API params." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158634 (owner: 10EBernhardson) [14:09:59] 3MediaWiki extensions / 3WikidataRepo: Replace old serialization code in lib with datamodel serialization - 10https://bugzilla.wikimedia.org/62188#c1 (10tobias.gritschacher) blocked by: https://github.com/wmde/WikibaseDataModelSerialization/milestones/WikibaseLib%20feature%20parity [14:11:00] 3MediaWiki extensions / 3WikidataRepo: ApiFormatXml::recXmlPrint: has integer keys without _element in wbeditentity api module - 10https://bugzilla.wikimedia.org/70299 (10tobias.gritschacher) 5NEW>3ASSI [14:13:32] 3MediaWiki extensions / 3WikidataRepo: Fix empty map serialization behaviour - 10https://bugzilla.wikimedia.org/70606 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs The problem is outlined here: https://lists.wikimedia.org/pipermail/wikidata-tech/2014-September/000575.html Issue i... [14:13:45] 3MediaWiki extensions / 3WikidataRepo: Fix empty map serialization behaviour - 10https://bugzilla.wikimedia.org/70606 (10tobias.gritschacher) 5NEW>3ASSI p:5Unprio>3High s:5normal>3major [14:14:48] (03PS1) 10Smuggli: Don't use parse() for description [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/159300 [14:15:08] (03CR) 10Smuggli: [C: 032 V: 032] Don't use parse() for description [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/159300 (owner: 10Smuggli) [14:15:15] 3MediaWiki extensions / 3WikidataRepo: Section-edit mode for SiteLinks - 10https://bugzilla.wikimedia.org/68908 (10tobias.gritschacher) [14:21:35] (03PS4) 10Matthias Mullie: H-4: Rename Close -> Lock [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158634 (owner: 10EBernhardson) [14:22:13] (03CR) 10jenkins-bot: [V: 04-1] H-4: Rename Close -> Lock [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158634 (owner: 10EBernhardson) [14:23:41] (03PS5) 10Matthias Mullie: H-4: Rename Close -> Lock [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158634 (owner: 10EBernhardson) [14:23:44] 3MediaWiki extensions / 3CirrusSearch: prefix: and insource: do not work at the same time - 10https://bugzilla.wikimedia.org/70560#c3 (10Nik Everett) Cirrus implements that <> syntax by turning everything that comes after <> into a filter that matches the same stuff that the prefix search i... [14:24:13] (03CR) 10Bartosz Dziewoński: [C: 032] Fix undefined argument in OldChangesList [core] - 10https://gerrit.wikimedia.org/r/158881 (https://bugzilla.wikimedia.org/70407) (owner: 10Aude) [14:24:49] (03CR) 10Matthias Mullie: [C: 031] "PS 4&5: fixed qunit test that was added after this patch had started." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158634 (owner: 10EBernhardson) [14:26:00] 3MediaWiki / 3Recent changes: PHP Warning: array_merge(): Argument #1 is not an array in ChangesList.php on line 555 - 10https://bugzilla.wikimedia.org/70407 (10Bartosz Dziewoński) 5PATC>3RESO/FIX a:3Aude [14:28:50] MatmaRex: thanks [14:29:01] i'd like to put that in swat [14:29:39] (03CR) 10Manybubbles: [C: 031] "Trying locally." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/159169 (owner: 10Chad) [14:30:31] (03Merged) 10jenkins-bot: Fix undefined argument in OldChangesList [core] - 10https://gerrit.wikimedia.org/r/158881 (https://bugzilla.wikimedia.org/70407) (owner: 10Aude) [14:31:28] 3MediaWiki extensions / 3CirrusSearch: prefix: and insource: do not work at the same time - 10https://bugzilla.wikimedia.org/70560#c4 (10Tisza Gergő) Indeed; using <> works fine. That's pretty confusing behavior IMO. Google used to prefix "greedy" keywords with 'all' (allinti... [14:31:30] (03CR) 10Matthias Mullie: [C: 04-1] Colors are backwards for flyout section link (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159222 (owner: 10Bsitu) [14:31:36] (03PS3) 10Matthias Mullie: Colors are backwards for flyout section link [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159222 (owner: 10Bsitu) [14:32:05] (03CR) 10Matthias Mullie: [C: 032] Colors are backwards for flyout section link [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159222 (owner: 10Bsitu) [14:32:13] (03CR) 10Matthias Mullie: [C: 032] Remove (X) next to Alerts/Messages if there is one section [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159228 (owner: 10Bsitu) [14:32:31] (03Merged) 10jenkins-bot: Colors are backwards for flyout section link [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159222 (owner: 10Bsitu) [14:33:34] (03PS1) 10Aude: Fix undefined argument in OldChangesList [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159304 (https://bugzilla.wikimedia.org/70407) [14:34:30] 3MediaWiki extensions / 3CirrusSearch: prefix: and insource: do not work at the same time - 10https://bugzilla.wikimedia.org/70560#c5 (10Nik Everett) 5NEW>3RESO/WON I wouldn't have picked this syntax myself but its how it used to work and one of the goal of CirrusSearch was to preserve backwards compatib... [14:34:44] (03CR) 10Matthias Mullie: [C: 032] Both notifyNewTopic and notifyPostChange trigger mention notif [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159203 (owner: 10Bsitu) [14:35:19] (03Merged) 10jenkins-bot: Both notifyNewTopic and notifyPostChange trigger mention notif [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159203 (owner: 10Bsitu) [14:38:01] (03CR) 10Smuggli: [C: 031] "Normal code review, no i18n/l10n" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151797 (owner: 10Mglaser) [14:38:55] (03CR) 10Matthias Mullie: Add reverse chronological ordering to unread notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158239 (owner: 10Bsitu) [14:40:46] (03PS3) 10Cscott: Use new log and status reporting framework [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/151222 (owner: 10Mwalker) [14:42:08] (03PS1) 10Matthias Mullie: Switch the order of Alerts and Messages tabs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159305 [14:42:35] (03CR) 10jenkins-bot: [V: 04-1] Switch the order of Alerts and Messages tabs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159305 (owner: 10Matthias Mullie) [14:45:23] (03PS1) 10Pastakhov: refactor css style, move it to own definition (v 2.1.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/159306 [14:46:40] (03CR) 10Pastakhov: [C: 032] refactor css style, move it to own definition (v 2.1.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/159306 (owner: 10Pastakhov) [14:46:45] (03Merged) 10jenkins-bot: refactor css style, move it to own definition (v 2.1.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/159306 (owner: 10Pastakhov) [14:49:10] (03PS2) 10Matthias Mullie: Switch the order of Alerts and Messages tabs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159305 [14:49:38] (03CR) 10jenkins-bot: [V: 04-1] Switch the order of Alerts and Messages tabs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159305 (owner: 10Matthias Mullie) [14:51:29] 3MediaWiki extensions / 3CirrusSearch: Stemming: CirrusSearch does not find Биология for a Биологии query on ru.wp (but LuceneSearch does) - 10https://bugzilla.wikimedia.org/69766#c11 (10Nik Everett) Now you've hit something else! Cirrus will only find results from cross namespace redirects if the target of... [14:52:45] 3MediaWiki extensions / 3WikidataRepo: Redesign Item UI for Wikidata repo - 10https://bugzilla.wikimedia.org/52136 (10tobias.gritschacher) [14:52:45] 3MediaWiki extensions / 3WikidataRepo: Create an edit widget to edit badges - 10https://bugzilla.wikimedia.org/67669 (10tobias.gritschacher) 5NEW>3ASSI [14:54:59] 3MediaWiki / 3Special pages: Special:AllPages no longer has Next link (regression?) - 10https://bugzilla.wikimedia.org/69951#c2 (10Donald Lancon) That was shown when the wiki had more than a certain number of articles (I don't know what the threshold was). For extremely large wikis, there were multiple level... [14:56:55] aharoni: In r109086, is there a reason the wraps the entire rest of the comment, or would it work just as well to have $post after the ''? [14:57:53] Hi manybubbles, yt? [14:57:59] (03CR) 10Manybubbles: [C: 031] "I like this. If there aren't any objections in the next day or so I'll +2 it." [core] - 10https://gerrit.wikimedia.org/r/154291 (owner: 10Aaron Schulz) [14:58:05] AndyRussG: yeah [14:59:04] (03PS4) 10Cscott: Clarify README with local development instructions. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/159101 [14:59:06] (03PS4) 10Cscott: Unify logging through the service wrapper [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/151224 (owner: 10Mwalker) [14:59:07] Hi! Do you mind if I add your name to your comment on the DI RFC? [14:59:08] (03PS3) 10Cscott: Add a human-readable help page to quickly test/check the service. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/159183 [14:59:21] (03PS4) 10Cscott: Use new log and status reporting framework [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/151215 (owner: 10Mwalker) [14:59:24] manybubbles: ^ [14:59:42] AndyRussG: oh sure - uh - I thought that tool automatically added names? [14:59:48] Also have some more thoughts/follow-up but I think the talk page is the better place to... talk about 'em [14:59:51] (03PS4) 10Cscott: Use new log and status reporting framework [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/151222 (owner: 10Mwalker) [15:00:25] Mmm sadly it does not (see discussions about Flow, tho...) [15:00:44] 3MediaWiki-Vagrant: fail to build a new machine - 10https://bugzilla.wikimedia.org/70314#c4 (10Bryan Davis) (In reply to Yuri Astrakhan from comment #2) > http://pastebin.com/g47qTxAT > > Fresh machine rebuild - still fails. I listed all the enabled roles at the > end. Your latest error output paste still ha... [15:00:45] (03CR) 10MarkTraceur: [C: 032] Fix undefined argument in OldChangesList [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159304 (https://bugzilla.wikimedia.org/70407) (owner: 10Aude) [15:01:38] (03PS3) 10BryanDavis: Have GettingStarted depend on PageImages [vagrant] - 10https://gerrit.wikimedia.org/r/159186 (owner: 10Mattflaschen) [15:01:50] (03CR) 10BryanDavis: [C: 032] Have GettingStarted depend on PageImages [vagrant] - 10https://gerrit.wikimedia.org/r/159186 (owner: 10Mattflaschen) [15:01:56] (03Merged) 10jenkins-bot: Have GettingStarted depend on PageImages [vagrant] - 10https://gerrit.wikimedia.org/r/159186 (owner: 10Mattflaschen) [15:01:59] AndyRussG: its really confusing! flow and liquidthreads add them and I don't use them enough to know when I'm using one or not [15:02:09] AndyRussG: I signed it [15:02:17] (03CR) 10jenkins-bot: [V: 04-1] Use new log and status reporting framework [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/151215 (owner: 10Mwalker) [15:02:17] Ah fantastic, thanks! [15:02:45] 3MediaWiki extensions / 3WikidataRepo: Support statements on properties in WikibaseDataModelSerialization - 10https://bugzilla.wikimedia.org/66425 (10tobias.gritschacher) [15:02:45] 3MediaWiki extensions / 3WikidataRepo: Support statements on properties in WikibaseDataModelSerialization - 10https://bugzilla.wikimedia.org/66425 (10tobias.gritschacher) 5NEW>3ASSI [15:02:46] (03CR) 10jenkins-bot: [V: 04-1] Use new log and status reporting framework [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/151222 (owner: 10Mwalker) [15:02:58] (03PS5) 10Jackmcbarn: Add UserMerge support [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/146025 (https://bugzilla.wikimedia.org/67769) (owner: 10Legoktm) [15:03:02] (03CR) 10Jackmcbarn: [C: 032] Add UserMerge support [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/146025 (https://bugzilla.wikimedia.org/67769) (owner: 10Legoktm) [15:03:38] (03Merged) 10jenkins-bot: Fix undefined argument in OldChangesList [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159304 (https://bugzilla.wikimedia.org/70407) (owner: 10Aude) [15:04:04] (03PS3) 10Matthias Mullie: Switch the order of Alerts and Messages tabs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159305 [15:04:31] (03CR) 10jenkins-bot: [V: 04-1] Switch the order of Alerts and Messages tabs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159305 (owner: 10Matthias Mullie) [15:04:40] manybubbles: cool, looking forward to talking more... (If you're interested in the talk-page confusion issues, check out the discussion on Wikimedia-l, BTW) [15:06:21] advise, don't check out wikimedia-l, like EVER. [15:06:24] :) [15:06:39] (03Merged) 10jenkins-bot: Add UserMerge support [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/146025 (https://bugzilla.wikimedia.org/67769) (owner: 10Legoktm) [15:09:34] (03PS1) 10Cscott: Use new log and status reporting framework [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/159308 [15:09:48] (03CR) 10jenkins-bot: [V: 04-1] Use new log and status reporting framework [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/159308 (owner: 10Cscott) [15:11:40] (03CR) 10Chad: "I think a patch is premature and should be the last trivial step after we get consensus to bump the required version." [core] - 10https://gerrit.wikimedia.org/r/158895 (owner: 10Withoutaname) [15:17:17] 3MediaWiki / 3Interface: give the "More" text of the dropdown its own ID - 10https://bugzilla.wikimedia.org/70610 (10Stöger Florian D. M.) 3NEW p:3Unprio s:3enhanc a:3None Please give the More in

More

... [15:17:44] 3MediaWiki / 3Interface: give the "More" text of the dropdown its own ID - 10https://bugzilla.wikimedia.org/70610 (10Stöger Florian D. M.) p:5Unprio>3Lowest [15:18:37] (03PS4) 10Matthias Mullie: Switch the order of Alerts and Messages tabs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159305 [15:19:11] thedj: Heh, I guess I can't stop now that I started... is there a better place to get just relevant discussions and without the drama-ridden bits? [15:19:59] (03PS2) 10Cscott: Use new log and status reporting framework [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/159308 [15:20:26] (03PS1) 10MarkTraceur: Update MobileFrontend [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159319 [15:20:36] (03PS5) 10Cscott: Use new log and status reporting framework [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/151222 (owner: 10Mwalker) [15:21:09] (03CR) 10MarkTraceur: [C: 032] Update MobileFrontend [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159319 (owner: 10MarkTraceur) [15:21:10] (03PS5) 10Cscott: Use new log and status reporting framework [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/151215 (owner: 10Mwalker) [15:24:32] (03Merged) 10jenkins-bot: Update MobileFrontend [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159319 (owner: 10MarkTraceur) [15:25:15] (03PS2) 10BryanDavis: Remove CURLCURLOPT_REDIR_PROTOCOLS defined test [vagrant] - 10https://gerrit.wikimedia.org/r/159257 (https://bugzilla.wikimedia.org/70570) (owner: 10Dan-nl) [15:25:33] (03CR) 10BryanDavis: [C: 032] "w00t. One less nasty hack." [vagrant] - 10https://gerrit.wikimedia.org/r/159257 (https://bugzilla.wikimedia.org/70570) (owner: 10Dan-nl) [15:25:39] (03Merged) 10jenkins-bot: Remove CURLCURLOPT_REDIR_PROTOCOLS defined test [vagrant] - 10https://gerrit.wikimedia.org/r/159257 (https://bugzilla.wikimedia.org/70570) (owner: 10Dan-nl) [15:26:47] (03PS1) 10Bartosz Dziewoński: Deprecate defunct Skin::getCommonStylePath() [core] - 10https://gerrit.wikimedia.org/r/159320 [15:35:15] 3MediaWiki extensions / 3WikidataRepo: Displaying (and editing) the calendar model of time values is confusing - 10https://bugzilla.wikimedia.org/70395 (10tobias.gritschacher) p:5Normal>3High [15:45:57] (03PS1) 10Anomie: Format multiple autocomments in edit summaries [core] - 10https://gerrit.wikimedia.org/r/159326 (https://bugzilla.wikimedia.org/16530) [15:46:09] (03CR) 10Anomie: "I like this, but I like I36c3a9e5 better." [core] - 10https://gerrit.wikimedia.org/r/147362 (https://bugzilla.wikimedia.org/68361) (owner: 10Jackmcbarn) [15:47:25] (03CR) 10Anomie: "Note I6f01771e8fd6b0fcda2cfd58fcaae334c4c075d4 is required to avoid breaking Wikibase's autocomments." [core] - 10https://gerrit.wikimedia.org/r/159326 (https://bugzilla.wikimedia.org/16530) (owner: 10Anomie) [15:49:19] (03CR) 10Edokter: "Bartosz' icon look better (though when enlarged, it looks like a giant bust...)" [skins/Vector] - 10https://gerrit.wikimedia.org/r/157990 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [15:52:38] (03PS1) 10Matthias Mullie: Messages/Alerts text is tiny in Monobook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159329 [15:54:17] (03PS3) 10Krinkle: resourceloader: Condition-wrap the HTML tag instead of JS response [core] - 10https://gerrit.wikimedia.org/r/159086 (https://bugzilla.wikimedia.org/69924) [16:02:15] (03PS2) 10Matthias Mullie: Messages/Alerts text is tiny in Monobook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159329 [16:06:14] 3Wikimedia / 3Media storage: 404 errors for three images on Commons - 10https://bugzilla.wikimedia.org/70556#c4 (10Yann Forget) Other files with the same issue: https://commons.wikimedia.org/wiki/File:%C3%89mission_JAM_-_Venessa_Lachance,_Hearst.jpg https://commons.wikimedia.org/wiki/File:%C3%89mission_JAM_-... [16:13:46] (03CR) 10Violetto: "The point where each item has to reach before it starts highlighting the section title is high or there isn't enough space at the bottom o" [core] - 10https://gerrit.wikimedia.org/r/158859 (owner: 10Prtksxna) [16:16:34] (03CR) 10Jforrester: "One comment; otherwise GTG." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/158650 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [16:16:41] (03CR) 10Manybubbles: [C: 032] "Verified locally - everything looks good." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/159169 (owner: 10Chad) [16:17:03] (03Merged) 10jenkins-bot: Remove --closeOk parameter to update(One)SearchIndexConfig [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/159169 (owner: 10Chad) [16:17:44] (03CR) 10Bartosz Dziewoński: [C: 032] Messages/Alerts text is tiny in Monobook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159329 (owner: 10Matthias Mullie) [16:18:10] (03CR) 10Anomie: [C: 04-1] "I'm not sure whether I like callParserFunction being used for non-parser-functions, but I'm not necessarily opposed to it either." (032 comments) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/159238 (owner: 10Jackmcbarn) [16:18:14] (03Merged) 10jenkins-bot: Messages/Alerts text is tiny in Monobook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159329 (owner: 10Matthias Mullie) [16:18:15] MatmaRex: Hi, yt? Got a question about ChangesListSpecialPage, so you have a sec? [16:18:32] sure, but don't expect me to know the answer [16:18:35] :) [16:18:50] Ah K :) [16:19:42] I don't know if you saw the proposed RecentActivityFeed, developed with the support of the Wiki Education Foundation and nischayn22, who is working with them [16:20:14] https://github.com/wikimedia/mediawiki-extensions-RecentActivityFeed [16:20:33] It builds a lot on ChangesListSpecialPage and actually includes some snippets of code from there [16:20:33] (03PS1) 10BryanDavis: [WIP] Special page to manage global rename requests [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159331 (https://bugzilla.wikimedia.org/68924) [16:21:12] I started reviewing it and thought that some refactoring with core might be in order [16:21:21] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Special page to manage global rename requests [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159331 (https://bugzilla.wikimedia.org/68924) (owner: 10BryanDavis) [16:21:39] We thought we'd ask you since you did a lot of work on that class [16:22:07] The purpose of the extension is a replacement for the current activity feed provided by the EducationProgram extensions [16:22:12] extension [16:22:16] 3MediaWiki extensions / 3Translate: translatewiki.net so locked down I can't communicate with anyone there - 10https://bugzilla.wikimedia.org/70612 (10sminthopsis84) 3UNCO p:3Unprio s:3normal a:3None Reporting a bug here seems to be the only way to even ask what I might be misunderstanding about tran... [16:22:29] 3MediaWiki / 3Interface: give the "More" text of the dropdown its own ID - 10https://bugzilla.wikimedia.org/70610#c1 (10Andre Klapper) #p-cactions-label>span { display: none; } or #p-cactions-label span { display: none; } don't work? [16:22:40] MatmaRex: ^ [16:22:45] (also, maybe let me know if you'd like to move to a less noisy channel :) ) [16:24:08] AndyRussG: the ChangesListSpecialPage work i did was mostly "mechanical", i didn't write much of it, but rather moved bits from somewhere else [16:24:24] (03CR) 10Dduvall: Wiki installer now conditional on existence of database (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/159217 (https://bugzilla.wikimedia.org/50912) (owner: 10Dduvall) [16:24:27] Ah hmmm [16:24:34] AndyRussG: a refactoring probably wouldn't hurt if you know what you want to do [16:24:35] (03PS2) 10BryanDavis: [WIP] Special page to manage global rename requests [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159331 (https://bugzilla.wikimedia.org/68924) [16:24:46] Yeah I think it'd be pretty straightforward [16:24:52] AndyRussG: you might want to coordinate with wikidata folks, they've been poking around changelists recently [16:25:05] (03PS1) 10Matthias Mullie: Slightly more reliable positioning of board-level watchlist star [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159332 [16:25:29] Ah OK, yeah, my next question was who would be the main "owner" (so to speak, i.e. person or team mainly responsible) of that part of core? [16:25:32] AndyRussG: i'll try to help with anything you might want, but i'm probably not more knowledgeable about what this stuff does than you :) [16:26:17] there isn't any owner i know of, but yeah, wikidata folks want to revamp it a bit to better support non-wikitext contents [16:26:43] Do you know who from wikidata has been looking at it? [16:26:46] 3MediaWiki extensions / 3WikidataRepo: InvalidArgumentException from line 339 of Item.php - 10https://bugzilla.wikimedia.org/70613 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Unexpected non-MediaWiki exception encountered, of type "InvalidArgumentException" [970bdbc2] [no req] Exception from... [16:27:14] 3MediaWiki extensions / 3WikidataRepo: InvalidArgumentException from line 339 of Item.php - 10https://bugzilla.wikimedia.org/70613#c1 (10Aude) I was trying to run refreshLinks and there is issue with unserializing content in my database. [16:27:37] Here's the bug report about enabling the extension, if you're interested https://bugzilla.wikimedia.org/show_bug.cgi?id=69785 [16:28:34] Yeah my main concern was just to coordinate work on that, check if anyone else had a roadmap that goes by there [16:28:55] (03CR) 10BryanDavis: Wiki installer now conditional on existence of database (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/159217 (https://bugzilla.wikimedia.org/50912) (owner: 10Dduvall) [16:32:28] 3MediaWiki skins / 3Vector: give the "More" text of the dropdown its own ID - 10https://bugzilla.wikimedia.org/70610 (10Bartosz Dziewoński) [16:33:06] AndyRussG: aude and hoo, maybe someone else too [16:33:39] excellent, thanks much! :) [16:34:01] what? [16:34:11] aude: hoo: if someone wanted to do some refactoring of ChangesListSpecialPage... [16:34:11] link? [16:34:16] oooooo [16:34:26] Long story :P [16:34:28] do you have a roadmap that should be coordinated with? [16:34:35] https://www.mediawiki.org/wiki/Requests_for_comment/ChangesList_formatting (not that much) [16:34:41] is what i want to do [16:34:45] 3MediaWiki extensions / 3WikidataRepo: InvalidArgumentException from line 339 of Item.php - 10https://bugzilla.wikimedia.org/70613 (10tobias.gritschacher) 5NEW>3ASSI p:5Unprio>3High s:5normal>3major [16:34:49] it's less about the special page, [16:34:58] more about how each line gets formatted and making that more flexible [16:35:24] and also how they get grouped [16:35:24] interesting [16:35:28] in enhanced mode [16:35:29] right [16:36:07] long story short: there's a proposed RecentActivityFeed, developed with the support of the Wiki Education Foundation and nischayn22, who is working with them [16:36:18] right now, for old changes (default), there is a hook at the end of the line formatting [16:36:39] so we (evil), throw it away and regenerate, without any ability to reuse formatting code from core [16:36:52] and enhanced mode, can't even do that much [16:37:13] it aims to be the new and better activity feed for the Education Program, but also to be able to hook in to a newer stuff, which is why it was proposed as a separate extension [16:37:16] potentially formatting modes could be feeds and other thing [16:37:18] s [16:37:25] * aude nods [16:37:51] The proposal ended up copy-pasting a bunch of code from core [16:37:51] https://github.com/wikimedia/mediawiki-extensions-RecentActivityFeed [16:38:10] So to avoid that I'm suggesting that some refactoring happen [16:38:11] eeek, but yeah [16:38:29] i think there is a lot of copying going on [16:38:45] would be nice for things to be reusable instead, obviously [16:38:46] 3Wikimedia / 3Site requests: Create wiki for Wikimedia Venezuela - 10https://bugzilla.wikimedia.org/70579#c2 (10John F. Lewis) 5NEW>3ASSI a:3John F. Lewis Alright. Removing shell and adding ops as it is their work in theory for patches can be added by shells. [16:38:53] Oh hmm! copying... where-ish? [16:39:49] your extension? wikibase? [16:40:09] copying from this specific class in wikibase? [16:40:17] from ChangesList etc in core [16:40:19] (03PS1) 10Manybubbles: Load settings if vagrant is run from subdirectory [vagrant] - 10https://gerrit.wikimedia.org/r/159333 [16:40:21] $list->recentChangesFlags( ) [16:40:31] that's copied a bunch of places [16:40:48] it won't know about additional flag types, for example [16:40:57] K [16:41:08] aude: AndyRussG Hey guys :) [16:41:13] hey [16:41:21] (03PS2) 10BryanDavis: Load settings if vagrant is run from subdirectory [vagrant] - 10https://gerrit.wikimedia.org/r/159333 (owner: 10Manybubbles) [16:41:43] (03PS1) 10Manybubbles: Fix elasticsearch setting [vagrant] - 10https://gerrit.wikimedia.org/r/159335 [16:41:45] (03CR) 10BryanDavis: [C: 032] "Nice catch." [vagrant] - 10https://gerrit.wikimedia.org/r/159333 (owner: 10Manybubbles) [16:41:53] (03Merged) 10jenkins-bot: Load settings if vagrant is run from subdirectory [vagrant] - 10https://gerrit.wikimedia.org/r/159333 (owner: 10Manybubbles) [16:42:05] bd808: that was driving me fucking insane [16:42:11] shit would fail for "no reason" [16:42:19] elasticsearch would get reaped by the oomkiller [16:42:25] hhvm couldn't fork [16:42:35] much nastyness [16:43:20] I didn't look back at the history but I bet that was an "easy cleanup" that caused it [16:43:30] possible [16:44:04] Our simple vagrant stuff has grown to be a massive pile of complexity :( [16:44:30] I'm probably more to blame for that than most too [16:44:33] AndyRussG: aude I think some refactoring could be done. But the person has to have more knowledge of core and then the other use cases for similar code. [16:44:41] Not sure how wikibase uses this. [16:45:04] MatmaRex: Easy review I think -- https://gerrit.wikimedia.org/r/#/c/158800/ [16:45:18] nischayn22: uses what? [16:45:54] we only uses OldChangesList (the current default) [16:46:14] we are unable to work with EnhancedChanges (grouped changes) but need / want to make that possible [16:46:20] aude: I meant reuses or depends on the code. [16:46:39] aude: where do you use OldChangesList? [16:47:15] https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FWikibase/c4e92bb0d71d5ad5973ec3b48790d1333f8def91/client%2Fincludes%2Frecentchanges%2FChangeLineFormatter.php [16:47:20] excuse the long url [16:47:58] and the code is a bit terrible [16:48:11] np and np :) [16:48:31] the user link, for example, goes to the user page on wikidata [16:49:07] the diff link goes to wikidata, but the formatting shoudl be the same [16:49:32] so whatever formats these should allow that [16:50:14] 3MediaWiki extensions / 3Translate: translatewiki.net so locked down I can't communicate with anyone there - 10https://bugzilla.wikimedia.org/70612#c1 (10Niklas Laxström) 5UNCO>3NEW I'm sorry you are having this much trouble. It certainly is not the intention. The idea is that after you fill in your use... [16:50:27] sounds reasonable [16:50:57] to start, i just want to be able to register different formatters (callbacks or whatnot) per rc_source type [16:51:19] including the enhanced formatting (block lines and block groups) [16:51:46] i don't know how much that relates to your work? [16:51:49] (03PS1) 10Jsahleen: Adding additional logging to ContentTranslationsService.js [services/cxserver] - 10https://gerrit.wikimedia.org/r/159336 [16:52:43] (03CR) 10jenkins-bot: [V: 04-1] Adding additional logging to ContentTranslationsService.js [services/cxserver] - 10https://gerrit.wikimedia.org/r/159336 (owner: 10Jsahleen) [16:53:41] aude: I'm not sure at this point how much it could be related, really just wanted to see who else was interested in/working on this corner of core before recommending anyone launch headlong into a refactoring proposal [16:53:47] ok :) [16:54:11] i added your extension to my rfc page, as see also [16:54:20] aude: ah fantastic [16:54:32] (03PS1) 10Manybubbles: Remove positions from postings for opening text [extensions/CirrusSearch] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159337 [16:54:49] nischayn22: is this a good starting point for making a proposal to refactor a bit of core to be able to remove the current copy-paste code? [16:54:56] i want to make a patch or two to go with, to give some implementation details / ideas [16:55:26] (03PS1) 10Manybubbles: Configure maximum number of shards per node [extensions/CirrusSearch] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159338 [16:55:29] (03PS2) 10Jsahleen: Adding additional logging to ContentTranslationsService.js [services/cxserver] - 10https://gerrit.wikimedia.org/r/159336 [16:55:30] for oldchanges, seems easily doable [16:55:45] with this we have an idea of possible directions that may be worth taking into account [16:55:48] (03PS1) 10Manybubbles: Add option to turn off all fields in rescore [extensions/CirrusSearch] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159339 [16:55:53] ok [16:55:59] (03CR) 10Dduvall: "So as not to bloat the inline comments:" (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/159217 (https://bugzilla.wikimedia.org/50912) (owner: 10Dduvall) [16:56:08] (03PS1) 10Manybubbles: Disable phrase rescore if rescore window is 0 [extensions/CirrusSearch] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159340 [16:56:12] AndyRussG: I think we can make a proposal. But I am not very confident on how far it goes :) [16:56:25] * aude supports it :) [16:56:33] (03PS1) 10Manybubbles: Store weighted all_near_match with freqs [extensions/CirrusSearch] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159341 [16:56:38] Someone from the core team has to take it forward. [16:56:40] aude: we can add you (and hoo also then? anyone else?) as reviewers for a proposed refactoring [16:56:45] sure [16:56:55] AndyRussG: I think we can open up a RFC page? [16:57:16] (03PS1) 10Manybubbles: Shrink the weighted all field's positions [extensions/CirrusSearch] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159342 [16:57:16] aude: Ah, you already have a rfc for this? [16:57:33] only for the formatting part of each change type [16:57:46] nischayn22: hmmm, maybe, though I'm not sure the specific needs of the RecentActivityFeed are substantial enough to warrant an RFC, maybe tho [16:57:49] if you want to add to it, go ahead [16:58:16] i don't think mine needs rfc either but just want it documented and get feedbakc [16:58:28] and then someone rages at my patches, can point them to it :) [16:58:46] aude: That's what I want to do :) [16:58:50] heh [16:58:51] heheh preventative rage management [16:59:42] AndyRussG: I think we can document some of it. If there are more implementations of these kind of ChangesList then maybe it catches on later. [16:59:56] nischayn22: that sounds good, yes [17:00:12] :) [17:00:39] Cool, I will have to go through the code again for that :( [17:01:15] dooh! racoons! [17:03:08] nischayn22: I guess use your judgement about striking a good balance between practical needs and elegant code that takes into account upcoming use cases :) [17:03:42] aude: thanks so much!!! :) K will be in touch on this sooooon... [17:03:47] AndyRussG: sure [17:03:58] AndyRussG: I think the problem arises when the balances are different for different people :) [17:04:25] heh, yes, balancing different balances [17:04:28] metabalancing [17:04:46] Lol [17:07:44] 3MediaWiki / 3Interface: Convert mediawiki.legacy.shared to LESS - 10https://bugzilla.wikimedia.org/60360#c1 (10Bartosz Dziewoński) (The file mentioned is now resources/src/mediawiki.legacy/shared.css.) [17:08:29] 3MediaWiki / 3Interface: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277 (10Bartosz Dziewoński) [17:08:31] 3MediaWiki / 3General/Unknown: Fix extensions depending on skins/common/ - 10https://bugzilla.wikimedia.org/70615 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None We need to fix extensions depending on skins/common/ before we kill it. There's a bunch that all require small changes, so I'm not... [17:13:19] (03CR) 10Krinkle: [C: 032] Add dependency on 'mediawiki.api' [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/159082 (owner: 10Helder.wiki) [17:13:27] (03Merged) 10jenkins-bot: Add dependency on 'mediawiki.api' [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/159082 (owner: 10Helder.wiki) [17:14:05] (03CR) 10Krinkle: [C: 032] Use $.ready and $.when instead of nesting callbacks [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/159084 (owner: 10Helder.wiki) [17:14:11] (03Merged) 10jenkins-bot: Use $.ready and $.when instead of nesting callbacks [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/159084 (owner: 10Helder.wiki) [17:18:12] (03CR) 10Jdlrobson: "Why on earth did the mark all as read test get removed from this?!" [extensions/Echo] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159195 (https://bugzilla.wikimedia.org/70461) (owner: 10EBernhardson) [17:18:47] (03CR) 10Jdlrobson: "Why have all these tests been removed? They are supposed to be there to protect us from breaking things..." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158820 (https://bugzilla.wikimedia.org/70461) (owner: 10EBernhardson) [17:20:14] 3MediaWiki / 3General/Unknown: Fix extensions depending on skins/common/ - 10https://bugzilla.wikimedia.org/70615#c1 (10Bartosz Dziewoński) This is the list of thing I intend to fix or at least carefully look at. The search returned a lot more results, mostly false positives. I also excluded commented-out c... [17:22:14] anomie, hey [17:22:30] hi Krenair [17:22:45] anomie, if I have a 'Category:Redirect cat' page that is a redirect, shouldn't api.php?format=jsonfm&action=query&list=allcategories&acmin=1&acprefix=Redir&acprop=hidden&redirects=true show the redirect? [17:24:45] Krenair: "show the redirect" meaning show what Category:Redirect cat redirects to? No, redirects=true only resolves redirects in the pageset (titles parameter or generator output) [17:25:30] meaning that, yes [17:25:36] Krenair: Or "show the redirect" meaning show that category from list=allcategories? Depends if Category:Redirect cat ever had any pages in it, IIRC. [17:32:31] (03CR) 10Legoktm: "Fixes bug 69873" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159329 (owner: 10Matthias Mullie) [17:33:46] 3Wikimedia / 3Site requests: Change rights for user groups in hewiki - 10https://bugzilla.wikimedia.org/70616 (10Eran Roz) 3NEW p:3Unprio s:3normal a:3None Per community decision in Village Pump (see https://he.wikipedia.org/w/index.php?title=%D7%95%D7%99%D7%A7%D7%99%D7%A4%D7%93%D7%99%D7%94:%D7%9E%D7... [17:33:55] (03CR) 10Manybubbles: [C: 04-1] Add option to turn off all fields in rescore [extensions/CirrusSearch] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159339 (owner: 10Manybubbles) [17:35:12] (03PS1) 10Manybubbles: Fix override allowing all fields in rescore [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/159349 [17:35:36] (03CR) 10Manybubbles: "Don't want to deploy this without cherry picking I4a32ddbf6e9ecacf9c90c566edbd15f05f493f31 too." [extensions/CirrusSearch] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159339 (owner: 10Manybubbles) [17:37:00] 3MediaWiki extensions / 3FlaggedRevs: Add UserMerge support to FlaggedRevs - 10https://bugzilla.wikimedia.org/67769 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3Kunal Mehta (Legoktm) [17:38:10] (03PS1) 10CSteipp: Add developer agreement [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/159350 (https://bugzilla.wikimedia.org/62688) [17:38:15] (03CR) 10jenkins-bot: [V: 04-1] Add developer agreement [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/159350 (https://bugzilla.wikimedia.org/62688) (owner: 10CSteipp) [17:38:56] (03PS1) 10Bartosz Dziewoński: Provide own magnify-clip.png image [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/159351 (https://bugzilla.wikimedia.org/70615) [17:40:44] anomie|meeting, so https://gerrit.wikimedia.org/r/#/c/135782/1/modules/ve-mw/ui/widgets/ve.ui.MWCategoryInputWidget.js would've broken support for checking category redirects then [17:43:03] (03PS2) 10BryanDavis: Fix elasticsearch setting [vagrant] - 10https://gerrit.wikimedia.org/r/159335 (owner: 10Manybubbles) [17:43:15] (03CR) 10BryanDavis: [C: 032] Fix elasticsearch setting [vagrant] - 10https://gerrit.wikimedia.org/r/159335 (owner: 10Manybubbles) [17:43:24] (03Merged) 10jenkins-bot: Fix elasticsearch setting [vagrant] - 10https://gerrit.wikimedia.org/r/159335 (owner: 10Manybubbles) [17:44:29] 3MediaWiki / 3General/Unknown: Fix extensions depending on skins/common/ - 10https://bugzilla.wikimedia.org/70615#c3 (10Bartosz Dziewoński) The ones in SemanticPageMaker seem to be dead code, or I can't figure the thing out. I'd file a bug, but it doesn't have a component. I'll let that be. [17:48:08] (03CR) 10Legoktm: [C: 031] "LGTM, but I don't know much about MediaWiki UI things..." [core] - 10https://gerrit.wikimedia.org/r/158800 (owner: 10BryanDavis) [17:55:03] (03PS1) 10Bartosz Dziewoński: Remove reference to feed.css [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/159353 (https://bugzilla.wikimedia.org/70615) [17:55:34] (03Abandoned) 10MarkTraceur: Allow "next" without completing all uploads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/11004 (https://bugzilla.wikimedia.org/37462) (owner: 10MarkTraceur) [17:55:41] (03CR) 10Legoktm: [C: 032] Remove reference to feed.css [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/159353 (https://bugzilla.wikimedia.org/70615) (owner: 10Bartosz Dziewoński) [17:55:45] (03Merged) 10jenkins-bot: Remove reference to feed.css [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/159353 (https://bugzilla.wikimedia.org/70615) (owner: 10Bartosz Dziewoński) [17:56:19] (03CR) 10Legoktm: [C: 031] Provide own magnify-clip.png image [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/159351 (https://bugzilla.wikimedia.org/70615) (owner: 10Bartosz Dziewoński) [17:56:25] legoktm: feel like helping? eight extensions left [17:56:54] I'll take a look later today if you don't get to them all by then :P [18:08:56] (03CR) 10MarkTraceur: "Rillke, rebase it and address Krinkle's comment, then ping me." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) (owner: 10Rillke) [18:08:59] Krenair: Looks like it, yes. [18:09:01] 3Wikimedia / 3Site requests: Change rights for user groups in hewiki - 10https://bugzilla.wikimedia.org/70616 (10matanya) a:3matanya [18:09:42] (03CR) 10Parent5446: "Considering setter-based dependency injection is actually a legitimate design pattern, I'm also curious as to exactly why we would want to" [core] - 10https://gerrit.wikimedia.org/r/143211 (owner: 10Withoutaname) [18:09:44] 3Wikimedia / 3Site requests: Change rights for user groups in hewiki - 10https://bugzilla.wikimedia.org/70616 (10Marius Hoch) [18:09:59] 3MediaWiki / 3Recent changes: PHP Warning: array_merge(): Argument #1 is not an array in ChangesList.php on line 555 - 10https://bugzilla.wikimedia.org/70407#c6 (10Umherirrender) 5PATC>3RESO/FIX was backported to 1.24wmf20 [18:12:51] (03PS2) 10Bsitu: Remove (X) next to Alerts/Messages if there is one section [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159228 [18:15:09] (03CR) 10Jforrester: [C: 032] preprocess: Clean up arbitrary quoting of object key 'message' [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/156880 (owner: 10Krinkle) [18:15:12] (03Merged) 10jenkins-bot: preprocess: Clean up arbitrary quoting of object key 'message' [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/156880 (owner: 10Krinkle) [18:19:18] 3MediaWiki extensions / 3ZeroPortal: Zero related thumbnailing error - 10https://bugzilla.wikimedia.org/70619 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3normal a:3None It seems there's these in production, and they're there almost constantly. Based on the text etc, it's being used by a Zero partner, so... [18:22:44] (03Abandoned) 10MarkTraceur: Redirect on all template calls [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152817 (https://bugzilla.wikimedia.org/69217) (owner: 10MarkTraceur) [18:22:44] (03CR) 10Robert Vogel: [C: 032 V: 032] Initial I18N (QQQ, EN, DE) [extensions/Teahouse] - 10https://gerrit.wikimedia.org/r/155532 (owner: 10Robert Vogel) [18:22:45] (03PS1) 10BryanDavis: Make renameuser_queue.rq_wiki nullable [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159357 [18:22:45] (03CR) 10Robert Vogel: [C: 032 V: 032] [WIP] Initial commit to the Teahouse extension [extensions/Teahouse] - 10https://gerrit.wikimedia.org/r/155526 (owner: 10Robert Vogel) [18:22:45] (03CR) 10Robert Vogel: [C: 032 V: 032] Fixed call on no object [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/159075 (owner: 10Smuggli) [18:23:08] (03PS1) 10Umherirrender: Use local var in Action::setHeaders [core] - 10https://gerrit.wikimedia.org/r/159358 [18:23:10] (03Abandoned) 10MarkTraceur: Test titles in Details step. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/50953 (https://bugzilla.wikimedia.org/42554) (owner: 10Nischayn22) [18:23:31] 3MediaWiki / 3Special pages: PHP Fatal error: Cannot use object of type stdClass as array in MobileFrontend.hooks.php on line 304 - 10https://bugzilla.wikimedia.org/67596#c3 (10Max Semenik) *** Bug 70618 has been marked as a duplicate of this bug. *** [18:26:48] (03CR) 10Robert Vogel: [C: 032 V: 032] "@Siebrand: Thank you for your comment. As this is a legacy branch commit we will keep it the way it is. In our master branch development w" [extensions/BlueSpiceExtensions] (REL1_22) - 10https://gerrit.wikimedia.org/r/159023 (owner: 10Tweichart) [18:27:16] (03CR) 10BryanDavis: "Springle, will making this column nullable cause problems with the indices that include it? I know that Oracle loves to "optimize" sparse " [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159357 (owner: 10BryanDavis) [18:27:24] (03CR) 10Legoktm: [C: 04-1] "Re static classes: Right now this code isn't very testable, short of manipulating the db, which is slow. My objection is mainly that stati" (036 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156488 (https://bugzilla.wikimedia.org/68886) (owner: 10BryanDavis) [18:34:25] hoo: ping? [18:34:55] * hoo pongs [18:35:33] (03CR) 10Umherirrender: "Use of wfArrayToCgi is indirect by Title::getFullUrl. Tests for wfArrayToCgi are testing, that the array index is outputted, so wfArrayToC" [core] - 10https://gerrit.wikimedia.org/r/158943 (owner: 10Umherirrender) [18:36:19] legoktm: ^ [18:36:24] pm [18:36:30] sure [18:39:00] (03CR) 10Robert Vogel: "@MarkAHershberger: Yes. My change adds a dedicated hook that allows manipulation of the anchor element's attributes." [core] - 10https://gerrit.wikimedia.org/r/20500 (https://bugzilla.wikimedia.org/39466) (owner: 10MarkAHershberger) [18:41:37] (03PS4) 10Umherirrender: Fix backlink for RevertAction [core] - 10https://gerrit.wikimedia.org/r/151448 [18:41:48] (03CR) 10Robert Vogel: "Make sure Sebastian knows about this when he does his 2.23 recoding." [extensions/BlueSpiceExtensions] (REL1_22) - 10https://gerrit.wikimedia.org/r/157142 (owner: 10Pwirth) [18:42:06] (03CR) 10Umherirrender: "Patch Set 4: Removed unrelated code changes" [core] - 10https://gerrit.wikimedia.org/r/151448 (owner: 10Umherirrender) [18:42:57] (03PS5) 10Umherirrender: Fix backlink for RevertAction [core] - 10https://gerrit.wikimedia.org/r/151448 [18:44:43] (03CR) 10Nemo bis: "+1 on Siebrand, this is still not looking healthy apart from skewing all the mediawiki/.* stats. https://gerrit.wikimedia.org/r/#/q/status" [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/120479 (owner: 10MarkAHershberger) [18:45:18] (03CR) 10MaxSem: [C: 032] Only mount /vagrant/logs if not using NFS [vagrant] - 10https://gerrit.wikimedia.org/r/156230 (owner: 10BryanDavis) [18:45:24] (03Merged) 10jenkins-bot: Only mount /vagrant/logs if not using NFS [vagrant] - 10https://gerrit.wikimedia.org/r/156230 (owner: 10BryanDavis) [18:46:58] (03CR) 10Cscott: [C: 032] Use `/etc/mw-collection-ocg.js` configuration file if present. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/159099 (owner: 10Cscott) [18:47:07] (03CR) 10Cscott: [C: 032] Ensure that default temp and output directories exist. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/159100 (owner: 10Cscott) [18:47:18] (03CR) 10Cscott: [C: 032] Make sure the collection id is specific to the backend selected. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/159190 (owner: 10Cscott) [18:47:19] (03Merged) 10jenkins-bot: Use `/etc/mw-collection-ocg.js` configuration file if present. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/159099 (owner: 10Cscott) [18:47:25] (03Merged) 10jenkins-bot: Ensure that default temp and output directories exist. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/159100 (owner: 10Cscott) [18:47:29] (03CR) 10Cscott: [C: 032] Clarify README with local development instructions. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/159101 (owner: 10Cscott) [18:47:35] (03CR) 10Cscott: [C: 032] Add a human-readable help page to quickly test/check the service. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/159183 (owner: 10Cscott) [18:47:41] (03Merged) 10jenkins-bot: Make sure the collection id is specific to the backend selected. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/159190 (owner: 10Cscott) [18:47:49] (03Merged) 10jenkins-bot: Clarify README with local development instructions. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/159101 (owner: 10Cscott) [18:47:52] (03Merged) 10jenkins-bot: Add a human-readable help page to quickly test/check the service. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/159183 (owner: 10Cscott) [18:47:53] (03CR) 10Cscott: [C: 032] Unify logging through the service wrapper [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/151224 (owner: 10Mwalker) [18:47:56] (03PS1) 10Bartosz Dziewoński: Correct path to fileicon-ogg.png for MW 1.24 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/159361 (https://bugzilla.wikimedia.org/70615) [18:48:10] (03CR) 10Cscott: [C: 032] Use new log and status reporting framework [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/151215 (owner: 10Mwalker) [18:48:21] (03CR) 10Cscott: [C: 032] Use new log and status reporting framework [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/151222 (owner: 10Mwalker) [18:48:24] (03Merged) 10jenkins-bot: Unify logging through the service wrapper [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/151224 (owner: 10Mwalker) [18:48:43] (03CR) 10Cscott: [C: 032] Use new log and status reporting framework [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/159308 (owner: 10Cscott) [18:48:58] 3MediaWiki / 3Special pages: PHP Fatal error: Cannot use object of type stdClass as array in MobileFrontend.hooks.php on line 304 - 10https://bugzilla.wikimedia.org/67596#c4 (10Ryan Kaldari) Yeah, it looks like the special page list is cast to an object, even though the function documentation says it return... [18:49:09] (03Merged) 10jenkins-bot: Use new log and status reporting framework [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/159308 (owner: 10Cscott) [18:49:44] MatmaRex: do we need to do anything for assets/ to work on WMF wikis? [18:49:51] (03PS1) 10Jsahleen: Logging: Add logging to JsonDict.js [services/cxserver] - 10https://gerrit.wikimedia.org/r/159362 [18:49:59] (03CR) 10Legoktm: [C: 032] Correct path to fileicon-ogg.png for MW 1.24 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/159361 (https://bugzilla.wikimedia.org/70615) (owner: 10Bartosz Dziewoński) [18:50:11] (03Merged) 10jenkins-bot: Correct path to fileicon-ogg.png for MW 1.24 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/159361 (https://bugzilla.wikimedia.org/70615) (owner: 10Bartosz Dziewoński) [18:50:27] legoktm: i sure hope not. if we do, i blame james [18:50:31] 3MediaWiki / 3General/Unknown: Fix extensions depending on skins/common/ - 10https://bugzilla.wikimedia.org/70615#c8 (10Bartosz Dziewoński) InterwikiIntegrationChangesList looks quite broken too. I'll let that be. [18:50:35] James_F: ^^ :) [18:50:52] legoktm: Ha. Good question. [18:50:58] (03CR) 10Bsitu: [C: 04-1] "-1 this for now. We will probably go with another realistic approach instead" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/157029 (owner: 10Bsitu) [18:51:06] when does it go to testwikis? [18:51:11] legoktm: I just said putting non-RL things into resources/ is not cool. [18:51:12] or is it already there? [18:51:16] legoktm: Thursday. [18:51:18] wmf21. [18:51:50] (03Merged) 10jenkins-bot: Use new log and status reporting framework [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/151222 (owner: 10Mwalker) [18:51:52] (03Merged) 10jenkins-bot: Use new log and status reporting framework [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/151215 (owner: 10Mwalker) [18:52:17] ok, I guess we'll find out then :P [18:54:59] 3Wikimedia / 3Extension setup: Review and deploy GlobalUserPage extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/70576 (10Sam Reed (reedy)) p:5Unprio>3Normal s:5normal>3enhanc [18:57:03] James_F: We (or, I, I guess) should probably find a time and sort out CiteThisPAge [18:57:30] Reedy: Yeah… it's not working quite right in Beta Labs, so I need to work out why. [18:57:50] Ah [18:57:53] Reedy: (Everything works except the alias for Special:Cite to Special:CiteThisPage doesn't seem to be loaded, and I can't see why.) [18:58:08] Breaking everyone's URLs would not be cool… [18:58:32] (03CR) 10Reedy: [C: 032] Fix: Profiler instance [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/157503 (owner: 10Physikerwelt) [18:58:35] (03Merged) 10jenkins-bot: Fix: Profiler instance [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/157503 (owner: 10Physikerwelt) [18:59:17] (03CR) 10Reedy: [C: 031] "Seeing as I re-wrote this, I probably shouldn't merge it ;)" [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/157504 (owner: 10Physikerwelt) [18:59:21] (03PS1) 10Cscott: Updating to latest masters [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/159363 [19:01:44] 3MediaWiki extensions / 3ZeroPortal: Zero related thumbnailing error - 10https://bugzilla.wikimedia.org/70619#c1 (10Sam Reed (reedy)) PHP Warning: Error 0 executing convert -trim -border 3 -bordercolor '##FFCC33' -background '##FFCC33' -fill '#000000' -font '/usr/share/fonts/truetype/ttf-dejavu/DejaVuSans.t... [19:02:26] (03CR) 10Cscott: [C: 032] Updating to latest masters [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/159363 (owner: 10Cscott) [19:04:35] (03CR) 10Reedy: [C: 032] Grammar fix [extensions/SandboxLink] - 10https://gerrit.wikimedia.org/r/159227 (owner: 10Bartosz Dziewoński) [19:05:22] (03CR) 10Cscott: [V: 032] Updating to latest masters [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/159363 (owner: 10Cscott) [19:07:03] (03CR) 10MarkAHershberger: "Thanks for the reminder. I'll try to look at this soon. I still owe the original creator of this some work on it." [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/120476 (owner: 10MarkAHershberger) [19:08:57] (03CR) 10Anomie: [C: 04-1] Make timer/profiler be thread-safe (034 comments) [php/luasandbox] - 10https://gerrit.wikimedia.org/r/159011 (https://bugzilla.wikimedia.org/70177) (owner: 10Tim Starling) [19:10:20] (03PS1) 10Jdlrobson: Restore QUnit tests to reflect alert as default tab [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159366 [19:10:49] (03CR) 10jenkins-bot: [V: 04-1] Restore QUnit tests to reflect alert as default tab [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159366 (owner: 10Jdlrobson) [19:10:59] 3MediaWiki / 3Special pages: PHP Fatal error: Cannot use object of type stdClass as array in MobileFrontend.hooks.php on line 304 - 10https://bugzilla.wikimedia.org/67596#c5 (10Ryan Kaldari) Actually, I read the code comment backwards ( 'func()[$key]' not 'func[$key]()' ). It doesn't have anything to do wit... [19:15:12] (03PS1) 10Manybubbles: Better logging on pool counter failures [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/159367 [19:15:43] (03CR) 10Manybubbles: "We can use the to get a bit more information about what is causing the pool queue to fill up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/159367 (owner: 10Manybubbles) [19:16:41] (03CR) 10Spage: [C: 04-2] "Do not merge this until we have a script running that deletes older notifications, see https://trello.com/c/5xuzwMkg/558-script-to-clean-o" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158239 (owner: 10Bsitu) [19:17:15] (03PS1) 10Bartosz Dziewoński: Provide own arrow images [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/159368 (https://bugzilla.wikimedia.org/70615) [19:21:13] (03PS1) 10Bartosz Dziewoński: Provide own arrow images [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/159369 (https://bugzilla.wikimedia.org/70615) [19:21:24] (03PS3) 10Spage: Add reverse chronological ordering to unread notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158239 (https://bugzilla.wikimedia.org/69919) (owner: 10Bsitu) [19:21:36] why do we have some much copy-pasted code. seriously. [19:21:52] MatmaRex: *gasp* [19:24:52] MatmaRex: MOAR GLOBAL FUNCTIONS [19:25:41] (03CR) 10Legoktm: [C: 032] Provide own arrow images [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/159368 (https://bugzilla.wikimedia.org/70615) (owner: 10Bartosz Dziewoński) [19:25:44] 3Wikimedia / 3Media storage: Special:Nuke on Commons creates "Error: ERR_READ_TIMEOUT, errno [No Error]" while mass-deleting about >20 files - 10https://bugzilla.wikimedia.org/38028#c7 (10Steinsplitter) Only fyi (because the last post was on 2013-11-24 19:29:19 UTC): The error (timeout) still exists. Admins... [19:25:44] (03Merged) 10jenkins-bot: Provide own arrow images [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/159368 (https://bugzilla.wikimedia.org/70615) (owner: 10Bartosz Dziewoński) [19:25:52] (03CR) 10Legoktm: [C: 032] Provide own arrow images [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/159369 (https://bugzilla.wikimedia.org/70615) (owner: 10Bartosz Dziewoński) [19:26:00] (03Merged) 10jenkins-bot: Provide own arrow images [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/159369 (https://bugzilla.wikimedia.org/70615) (owner: 10Bartosz Dziewoński) [19:26:01] legoktm: just so you know, i am not testing these. [19:26:15] 3MediaWiki / 3Special pages: PHP Fatal error: Cannot use object of type stdClass as array in MobileFrontend.hooks.php on line 304 - 10https://bugzilla.wikimedia.org/67596#c6 (10Ryan Kaldari) So if we change the code in MobileFrontend from... $list['Watchlist'] = 'SpecialMobileWatchlist'; ...to... $list->... [19:26:32] good thing jenkins checks for syntax errors at least [19:26:47] :P [19:27:06] (03CR) 10Legoktm: [V: 032] Grammar fix [extensions/SandboxLink] - 10https://gerrit.wikimedia.org/r/159227 (owner: 10Bartosz Dziewoński) [19:28:24] (03CR) 10Legoktm: [C: 032] Deprecate defunct Skin::getCommonStylePath() [core] - 10https://gerrit.wikimedia.org/r/159320 (owner: 10Bartosz Dziewoński) [19:29:41] (03PS1) 10Bartosz Dziewoński: Remove usage of spinner.gif [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/159370 (https://bugzilla.wikimedia.org/70615) [19:30:02] anomie: woah, https://www.mediawiki.org/wiki/Special:Code/MediaWiki/109086 was quite long ago. [19:30:54] o the memories of trunk/phase3 [19:31:11] aharoni: So was bug 16530 ;) In writing https://gerrit.wikimedia.org/r/#/c/159326/ to fix that bug, maintaining the at the very end would be a pain. [19:31:24] I would do it differently today. [19:31:51] Oh, I already thought something was new. :P [19:32:04] give it a class name, and apply unicode-bidi: embed on it or something. [19:32:16] (03CR) 10Legoktm: [C: 031] Move footer icons to assets/ directory (031 comment) [core] - 10https://gerrit.wikimedia.org/r/158650 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [19:32:41] (03CR) 10Nikerabbit: [C: 032] Provide own magnify-clip.png image [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/159351 (https://bugzilla.wikimedia.org/70615) (owner: 10Bartosz Dziewoński) [19:32:47] (03Merged) 10jenkins-bot: Provide own magnify-clip.png image [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/159351 (https://bugzilla.wikimedia.org/70615) (owner: 10Bartosz Dziewoński) [19:33:08] anomie: feel free to remove it, I'll redo it in a better way some time. [19:34:36] (03Merged) 10jenkins-bot: Deprecate defunct Skin::getCommonStylePath() [core] - 10https://gerrit.wikimedia.org/r/159320 (owner: 10Bartosz Dziewoński) [19:34:38] (03CR) 10Legoktm: "We could add a step to the updater to move skins/common/wiki.png --> assets/wiki.png...?" [core] - 10https://gerrit.wikimedia.org/r/159290 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [19:36:59] (03CR) 10Legoktm: [C: 032] UploadFromUrlTest: Don't reference skins/common/ (via bits.wm.o) [core] - 10https://gerrit.wikimedia.org/r/158658 (owner: 10Bartosz Dziewoński) [19:37:12] (03CR) 10Jforrester: Move footer icons to assets/ directory (031 comment) [core] - 10https://gerrit.wikimedia.org/r/158650 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [19:37:47] We have an assets directory? [19:37:58] it's james' fault. [19:39:25] Why are resources and assets seperate directories? [19:39:27] (03PS1) 10Robert Vogel: [WIP] Stub implementation [extensions/Teahouse] - 10https://gerrit.wikimedia.org/r/159371 [19:39:48] (03PS1) 10Bartosz Dziewoński: Update path to license footer icons for MW 1.24 [extensions/PerPageLicense] - 10https://gerrit.wikimedia.org/r/159372 (https://bugzilla.wikimedia.org/70615) [19:39:51] resources === loaded via RL [19:40:28] (03CR) 10Bartosz Dziewoński: "DEPENDS ON https://gerrit.wikimedia.org/r/#/c/158650/" [extensions/PerPageLicense] - 10https://gerrit.wikimedia.org/r/159372 (https://bugzilla.wikimedia.org/70615) (owner: 10Bartosz Dziewoński) [19:40:46] 3MediaWiki extensions / 3CentralAuth: Allow to automatically unify on login absent clashes - 10https://bugzilla.wikimedia.org/70392 (10Nemo) p:5Normal>3High [19:40:46] 3Wikimedia / 3General/Unknown: Migrate to SUL all non-clashing accounts - 10https://bugzilla.wikimedia.org/39817 (10Nemo) p:5High>3Normal [19:40:47] 3Wikimedia / 3Bugzilla: Add component for Extension:RecentActivityFeed - 10https://bugzilla.wikimedia.org/70622 (10Sage Ross) 3NEW p:3Unprio s:3normal a:3None Please create a Bugzilla component for Extension:RecentActivityFeed, which is being worked on for deployment to Wikipedia. https://www.mediaw... [19:40:50] Lcawte: james' fault, like i said. :> [19:41:20] MatmaRex: is https://gerrit.wikimedia.org/r/#/c/148768/ still an issue? [19:41:48] Hmm, you haven't Config'd Setup.php yet I see? [19:42:33] Lcawte: https://bugzilla.wikimedia.org/show_bug.cgi?id=69338 [19:42:47] (03CR) 10BryanDavis: "Add comment linking to DDL fix in I342c6dc" (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156488 (https://bugzilla.wikimedia.org/68886) (owner: 10BryanDavis) [19:42:49] (03CR) 10Bartosz Dziewoński: Move footer icons to assets/ directory (031 comment) [core] - 10https://gerrit.wikimedia.org/r/158650 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [19:42:56] I'm waiting for https://gerrit.wikimedia.org/r/#/c/153541/ first...which I need to work on. [19:43:09] (03Merged) 10jenkins-bot: UploadFromUrlTest: Don't reference skins/common/ (via bits.wm.o) [core] - 10https://gerrit.wikimedia.org/r/158658 (owner: 10Bartosz Dziewoński) [19:43:16] legoktm: dunno. haven't tried to run full test suite since then [19:43:48] (03CR) 10Legoktm: [C: 032] Language: s/error_log/wfWarn/ [core] - 10https://gerrit.wikimedia.org/r/148768 (owner: 10Bartosz Dziewoński) [19:43:59] heh [19:44:41] Hmm, are those YYYY-MM-DD or YYYY-DD-MM timestamps? [19:46:51] MatmaRex: good evening. [19:47:53] hi [19:48:45] Lcawte: which ones? [19:49:07] legoktm: Bugzilla (I can't find a preference for it...) [19:49:37] (03PS1) 10Bartosz Dziewoński: Use .feedlink class rather than feed-icon.png file [extensions/WikiArticleFeeds] - 10https://gerrit.wikimedia.org/r/159373 (https://bugzilla.wikimedia.org/70615) [19:50:05] (03Merged) 10jenkins-bot: Language: s/error_log/wfWarn/ [core] - 10https://gerrit.wikimedia.org/r/148768 (owner: 10Bartosz Dziewoński) [19:50:12] Lcawte: no one in their right mind would use YYYY-DD-MM for anything [19:50:14] 3MediaWiki / 3Special pages: PHP Fatal error: Cannot use object of type stdClass as array in MobileFrontend.hooks.php on line 304 - 10https://bugzilla.wikimedia.org/67596#c7 (10Ryan Kaldari) Actually, scratch that, I didn't notice the "if ( !is_object( self::$list ) ) {" outside the hook. It looks like the... [19:50:32] not even americans [19:50:34] MatmaRex: Bugzilla is written in Perl :P [19:50:41] Need I say anymore? [19:52:35] aharoni: I happen to have another q about resources/src/mediawiki.legacy/shared.css [19:52:54] .printfooter there could use a bit of vertical padding. [19:52:59] 3Wikimedia / 3Media storage: Stuck old 1024px thumbnail version of a specific djvu image on wikisource.pl - 10https://bugzilla.wikimedia.org/70189#c5 (10Bawolff (Brian Wolff)) I can confirm that image looks fixed, and that the image is now properly responding to purges. Have no idea how or why its fixed. Pe... [19:53:14] 3MediaWiki extensions / 3CentralAuth: Request global account rename from home wiki before forced SUL name change - 10https://bugzilla.wikimedia.org/68886 (10Bryan Davis) [19:53:22] 3MediaWiki extensions / 3CentralAuth: Add ajax check for name availability to Special:GlobalRenameRequest - 10https://bugzilla.wikimedia.org/70623 (10Bryan Davis) 3NEW p:3Unprio s:3enhanc a:3None Add an async javascript check for the availability of the new username. This would be similar to the chec... [19:53:29] 3MediaWiki extensions / 3CentralAuth: Add ajax check for name availability to Special:GlobalRenameRequest - 10https://bugzilla.wikimedia.org/70623 (10Bryan Davis) p:5Unprio>3Normal [19:54:01] does anybody give a damn about the printable version? :) [19:54:35] (03PS3) 10Krinkle: Upgrade jQuery JSON plugin to v2.5.1 [core] - 10https://gerrit.wikimedia.org/r/158867 (owner: 10Paladox) [19:54:57] (03PS1) 10Cscott: Merge branch 'master' into wmf-deploy [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/159374 [19:54:59] (03PS1) 10Cscott: Rebuilding dependencies [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/159375 [19:55:13] aharoni: It's not like the print stylesheet is exactly up to date :P [19:55:26] (03CR) 10Cscott: [C: 032 V: 032] Merge branch 'master' into wmf-deploy [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/159374 (owner: 10Cscott) [19:55:40] Lcawte: well yeah, that's what I mean by "does anybody give a damn" :) [19:56:01] (03CR) 10Cscott: [C: 032 V: 032] Rebuilding dependencies [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/159375 (owner: 10Cscott) [19:56:30] I'd love it to be up to date... teacher got annoyed when I handed him a copy of a page from one of my self-hosted sites I use to store my revision notes. [19:56:37] (03CR) 10Krinkle: "It's a minor update that doesn't break compatibility no have any reason to suspect it breaking something. We should upgrade, as do would w" [core] - 10https://gerrit.wikimedia.org/r/158867 (owner: 10Paladox) [19:56:58] (03Abandoned) 10Krinkle: Upgrade jQuery JSON plugin to v2.5.1 [core] - 10https://gerrit.wikimedia.org/r/158867 (owner: 10Paladox) [19:57:51] (03PS1) 10Bartosz Dziewoński: Provide own spinner image [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/159376 (https://bugzilla.wikimedia.org/70615) [20:00:32] (03CR) 10Chad: [C: 032] Remove positions from postings for opening text [extensions/CirrusSearch] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159337 (owner: 10Manybubbles) [20:00:49] (03Merged) 10jenkins-bot: Remove positions from postings for opening text [extensions/CirrusSearch] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159337 (owner: 10Manybubbles) [20:00:51] (03CR) 10Chad: [C: 032] Configure maximum number of shards per node [extensions/CirrusSearch] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159338 (owner: 10Manybubbles) [20:01:05] (03Merged) 10jenkins-bot: Configure maximum number of shards per node [extensions/CirrusSearch] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159338 (owner: 10Manybubbles) [20:01:10] (03CR) 10Chad: [C: 032] Disable phrase rescore if rescore window is 0 [extensions/CirrusSearch] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159340 (owner: 10Manybubbles) [20:01:24] (03Merged) 10jenkins-bot: Disable phrase rescore if rescore window is 0 [extensions/CirrusSearch] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159340 (owner: 10Manybubbles) [20:01:26] (03CR) 10Chad: [C: 032] Store weighted all_near_match with freqs [extensions/CirrusSearch] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159341 (owner: 10Manybubbles) [20:01:39] (03Merged) 10jenkins-bot: Store weighted all_near_match with freqs [extensions/CirrusSearch] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159341 (owner: 10Manybubbles) [20:01:44] (03CR) 10Chad: [C: 032] Shrink the weighted all field's positions [extensions/CirrusSearch] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159342 (owner: 10Manybubbles) [20:01:57] (03Merged) 10jenkins-bot: Shrink the weighted all field's positions [extensions/CirrusSearch] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159342 (owner: 10Manybubbles) [20:03:01] 3MediaWiki / 3General/Unknown: Fix extensions depending on skins/common/ - 10https://bugzilla.wikimedia.org/70615#c19 (10Bartosz Dziewoński) p:5Unprio>3High a:3Bartosz Dziewoński (This is all.) [20:03:06] (03CR) 10Chad: [C: 032] Better logging on pool counter failures [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/159367 (owner: 10Manybubbles) [20:03:19] (03Merged) 10jenkins-bot: Better logging on pool counter failures [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/159367 (owner: 10Manybubbles) [20:04:02] (03CR) 10Chad: [C: 032] Fix override allowing all fields in rescore [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/159349 (owner: 10Manybubbles) [20:04:15] (03Merged) 10jenkins-bot: Fix override allowing all fields in rescore [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/159349 (owner: 10Manybubbles) [20:06:39] (03PS1) 10Amire80: Add padding to printfooter [core] - 10https://gerrit.wikimedia.org/r/159377 [20:07:01] (03CR) 10Jack Phoenix: [C: 031] Provide own spinner image [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/159376 (https://bugzilla.wikimedia.org/70615) (owner: 10Bartosz Dziewoński) [20:08:05] (03CR) 10Manybubbles: [C: 031] "Lets merge this then cherry pick the next one." [extensions/CirrusSearch] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159339 (owner: 10Manybubbles) [20:08:38] (03CR) 10Chad: [C: 032] Add option to turn off all fields in rescore [extensions/CirrusSearch] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159339 (owner: 10Manybubbles) [20:08:52] (03Merged) 10jenkins-bot: Add option to turn off all fields in rescore [extensions/CirrusSearch] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159339 (owner: 10Manybubbles) [20:08:57] (03PS1) 10Manybubbles: Fix override allowing all fields in rescore [extensions/CirrusSearch] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159379 [20:09:37] (03CR) 10Chad: [C: 032] Fix override allowing all fields in rescore [extensions/CirrusSearch] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159379 (owner: 10Manybubbles) [20:09:50] (03Merged) 10jenkins-bot: Fix override allowing all fields in rescore [extensions/CirrusSearch] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159379 (owner: 10Manybubbles) [20:10:06] (03PS1) 10Nemo bis: README typofix [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/159380 [20:10:48] (03CR) 10Chad: [C: 032] README typofix [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/159380 (owner: 10Nemo bis) [20:11:02] (03Merged) 10jenkins-bot: README typofix [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/159380 (owner: 10Nemo bis) [20:12:29] (03CR) 10Bartosz Dziewoński: [C: 032] Add padding to printfooter [core] - 10https://gerrit.wikimedia.org/r/159377 (owner: 10Amire80) [20:14:59] 3Wikimedia / 3Bugzilla: Add component for Extension:RecentActivityFeed - 10https://bugzilla.wikimedia.org/70622#c1 (10Tyler Romeo) Who should be the default CC for the component? [20:15:47] 3MediaWiki extensions / 3CentralAuth: Consolidate page moving code in one place (Renameuser, GlobalRename, UserMerge) - 10https://bugzilla.wikimedia.org/70624 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None They're all basically the same code just copied around the place. We should consoli... [20:18:23] (03Merged) 10jenkins-bot: Add padding to printfooter [core] - 10https://gerrit.wikimedia.org/r/159377 (owner: 10Amire80) [20:19:44] (03PS1) 10Spage: Make wgFlowContentFormat = html the default [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159385 [20:22:00] 3MediaWiki-Vagrant: vagrant_ram overrides sometimes ignored/forgotten - 10https://bugzilla.wikimedia.org/69131#c4 (10Matthew Flaschen) 5NEW>3RESO/FIX a:5Dan Duvall>3Nik Everett Probably fixed by 9da72b12c40f3e7a54870da8f6ec3c235ec6c337 ("Load settings if vagrant is run from subdirectory") [20:23:29] 3MediaWiki-Vagrant: Ram and port forwarding broken again - 10https://bugzilla.wikimedia.org/69720 (10Bryan Davis) 5PATC>3RESO/FIX [20:23:43] (03PS2) 10Jdlrobson: Restore QUnit tests to reflect alert as default tab [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159366 [20:23:55] (03PS1) 10Legoktm: Add CentralAuthUser::newFromId() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159387 [20:23:58] (03PS1) 10Dduvall: Removed README from browsertests module [vagrant] - 10https://gerrit.wikimedia.org/r/159388 [20:24:05] bd808: ^ [20:28:07] (03CR) 10BryanDavis: [C: 032] "This will come in handy in Id1adb8f" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159387 (owner: 10Legoktm) [20:28:29] 3MediaWiki extensions / 3ProofreadPage: WikiEditor loads in different places in the Page namespace depending upon which user preferences are selected - 10https://bugzilla.wikimedia.org/70431#c3 (10George Orwell III) (In reply to Helder from comment #2) > We need to check this again once Ie455009df54deecc6770... [20:28:32] (03Merged) 10jenkins-bot: Add CentralAuthUser::newFromId() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159387 (owner: 10Legoktm) [20:28:36] (03PS1) 10Legoktm: Add tests for CentralAuthUser::newFromId() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159389 [20:28:43] bd808: ^ I was about to amend :P [20:28:55] heh. [20:29:03] Tests! That's crazy talk [20:30:08] (03CR) 10BryanDavis: [C: 032] Add tests for CentralAuthUser::newFromId() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159389 (owner: 10Legoktm) [20:30:35] (03Merged) 10jenkins-bot: Add tests for CentralAuthUser::newFromId() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159389 (owner: 10Legoktm) [20:32:17] (03CR) 10BryanDavis: [C: 032] Removed README from browsertests module [vagrant] - 10https://gerrit.wikimedia.org/r/159388 (owner: 10Dduvall) [20:32:22] (03Merged) 10jenkins-bot: Removed README from browsertests module [vagrant] - 10https://gerrit.wikimedia.org/r/159388 (owner: 10Dduvall) [20:34:19] (03PS10) 10Jdlrobson: Timestamp helper fixes for old things [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158100 (https://bugzilla.wikimedia.org/59919) [20:34:27] (03PS2) 10Jdlrobson: H9: Don't collapse topics in the topic namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159246 [20:35:54] (03PS3) 10Jdlrobson: H5: Hide reply and edit links in locked posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158618 [20:36:52] (03CR) 10Jdlrobson: [C: 032] Fix "Cancelling reply preview" browser test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159009 (owner: 10Spage) [20:36:57] (03PS3) 10Jdlrobson: QA: Fix "Cancelling reply preview" browser test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159009 (owner: 10Spage) [20:42:29] 3Wikimedia / 3Bugzilla: Add component for Extension:RecentActivityFeed - 10https://bugzilla.wikimedia.org/70622#c2 (10Sage Ross) Me, Nischay Nahata, and Andrew Green. (I'm adding both the CC list now.) [20:43:03] (03CR) 10Jdlrobson: [C: 04-1] "This also makes messages the default tab (alert should be default)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159305 (owner: 10Matthias Mullie) [20:43:10] (03PS5) 10Jdlrobson: Switch the order of Alerts and Messages tabs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159305 (owner: 10Matthias Mullie) [20:43:15] 3Wikimedia / 3Bugzilla: gerrit->bugzilla notification broken (due to Bugzilla 4.4.3 changes in token/session passing) - 10https://bugzilla.wikimedia.org/65370#c19 (10Aric Gardner) Hi guys, I would like to get this change pushed upstream to https://gerrit.googlesource.com/plugins/its-bugzilla/ I only see a bi... [20:44:38] (03CR) 10Legoktm: [C: 04-1] [WIP] Special page to manage global rename requests (035 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159331 (https://bugzilla.wikimedia.org/68924) (owner: 10BryanDavis) [20:45:30] (03CR) 10Spage: [C: 032] "Carrying forward Jon's +2 of PS2." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159009 (owner: 10Spage) [20:46:10] (03Merged) 10jenkins-bot: QA: Fix "Cancelling reply preview" browser test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159009 (owner: 10Spage) [20:47:07] (03CR) 10MarkTraceur: [C: 04-1] "There are a few unused variables that got commented out, I'd prefer they get deleted instead." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester) [20:48:44] 3MediaWiki extensions / 3Translate: translatewiki.net so locked down I can't communicate with anyone there - 10https://bugzilla.wikimedia.org/70612#c2 (10Nemo) Thanks for taking the time to write this! Currently the expected process for such a case is that the user figures out to click the "Not a translator?... [20:53:07] (03CR) 10BryanDavis: [WIP] Special page to manage global rename requests (034 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159331 (https://bugzilla.wikimedia.org/68924) (owner: 10BryanDavis) [20:56:44] 3Wikimedia / 3Extension setup: Review and deploy GlobalUserPage extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/70576 (10Kunal Mehta (Legoktm)) [20:57:00] 3MediaWiki extensions / 3CentralAuth: Make pages in User: namespace transparent to meta:User: - 10https://bugzilla.wikimedia.org/14759 (10Kunal Mehta (Legoktm)) [20:57:29] (03CR) 10Swalling: "I'm down with what Bartosz is proposing. Amend?" [skins/Vector] - 10https://gerrit.wikimedia.org/r/157990 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [20:59:23] (03Abandoned) 10Legoktm: Implement global user pages [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/7300 (https://bugzilla.wikimedia.org/14759) (owner: 10Szymon Świerkosz) [20:59:29] 3Wikimedia / 3Bugzilla: gerrit->bugzilla notification broken (due to Bugzilla 4.4.3 changes in token/session passing) - 10https://bugzilla.wikimedia.org/65370#c20 (10Sam Reed (reedy)) Unzip the jar? ;) [21:02:17] 3MediaWiki extensions / 3GlobalUserPage: GlobalUserPage: Improve border around footer - 10https://bugzilla.wikimedia.org/70629 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None From bug 70576 comment 4 by Isarra: > I still don't like that border. #aaa is awfully dark when it's just white >... [21:02:44] 3Wikimedia / 3Extension setup: Review and deploy GlobalUserPage extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/70576#c5 (10Kunal Mehta (Legoktm)) (In reply to Isarra from comment #4) Ok, I split that to bug 70629. I'm not sure whether it should be a blocker to this since you said it doesn't... [21:04:09] (03CR) 10Bsitu: "'html' requires Parsoid, we will need to make that a requirement just like Mantle" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159385 (owner: 10Spage) [21:05:46] 3Wikimedia / 3Bugzilla: Add component for Extension:RecentActivityFeed - 10https://bugzilla.wikimedia.org/70622 (10Tyler Romeo) 5NEW>3RESO/FIX a:3Tyler Romeo [21:05:55] (03CR) 10Gilles: [C: 032] Add Special:Log Entries [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/156243 (https://bugzilla.wikimedia.org/68277) (owner: 10Dan-nl) [21:06:04] (03Merged) 10jenkins-bot: Add Special:Log Entries [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/156243 (https://bugzilla.wikimedia.org/68277) (owner: 10Dan-nl) [21:06:44] (03CR) 10Robmoen: "I like Bartosz's icon. lets roll with it" [skins/Vector] - 10https://gerrit.wikimedia.org/r/157990 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [21:07:44] 3MediaWiki extensions / 3CentralAuth: Make pages in User: namespace transparent to meta:User: - 10https://bugzilla.wikimedia.org/14759 (10Kunal Mehta (Legoktm)) 5PATC>3ASSI [21:09:29] 3Wikimedia / 3Extension setup: Review and deploy GlobalUserPage extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/70576#c6 (10Isarra) Not a blocker, just ugly. It does apply to wikimedia projects, but won't likely ever go into ARGH MY EYES territory here, at least. [21:12:31] (03PS1) 10EBernhardson: Move EmailNotification watchlist handling into helper methods [core] - 10https://gerrit.wikimedia.org/r/159395 (https://bugzilla.wikimedia.org/66876) [21:15:48] (03CR) 10Legoktm: [C: 04-1] "Everything else looks good otherwise" (037 comments) [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/147755 (https://bugzilla.wikimedia.org/68241) (owner: 10Isarra) [21:16:07] (03PS1) 10EBernhardson: Bump Echo and Flow in 1.24wmf19 [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159396 [21:16:13] (03PS5) 10Jdlrobson: Correct button colours of preference page when $wgUseMediaWikiUIEverywhere is enabled [core] - 10https://gerrit.wikimedia.org/r/157709 (https://bugzilla.wikimedia.org/65317) [21:17:41] (03PS1) 10Cscott: Allow logging extended information from the backends. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/159398 [21:20:33] (03CR) 10Jdlrobson: Correct button colours of preference page when $wgUseMediaWikiUIEverywhere is enabled (033 comments) [core] - 10https://gerrit.wikimedia.org/r/157709 (https://bugzilla.wikimedia.org/65317) (owner: 10Jdlrobson) [21:22:42] (03PS1) 10EBernhardson: Give RC/Watchlist titles the mw-title html class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159399 [21:22:45] (03PS1) 10EBernhardson: Update wl_notificationtimestamp when updating Flow page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159400 (https://bugzilla.wikimedia.org/66876) [21:24:11] (03CR) 10EBernhardson: [C: 032] Bump Echo and Flow in 1.24wmf19 [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159396 (owner: 10EBernhardson) [21:24:36] (03PS1) 10Cscott: Pass additional details to logger on XeLaTeX failures. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/159401 [21:25:32] (03CR) 10EBernhardson: [C: 032] Restore QUnit tests to reflect alert as default tab [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159366 (owner: 10Jdlrobson) [21:25:52] (03PS1) 10Legoktm: Fix class name "Database" --> "DatabaseBase" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159402 [21:25:58] (03Merged) 10jenkins-bot: Restore QUnit tests to reflect alert as default tab [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159366 (owner: 10Jdlrobson) [21:26:10] (03PS2) 10Legoktm: Fix class name in docs: "Database" --> "DatabaseBase" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159402 [21:26:15] ^ easy merge [21:26:51] (03CR) 10Hoo man: "Y u no type hint? :D" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159402 (owner: 10Legoktm) [21:27:00] lol [21:27:01] (03Merged) 10jenkins-bot: Bump Echo and Flow in 1.24wmf19 [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159396 (owner: 10EBernhardson) [21:27:09] I didn't want to break anything [21:27:30] 3MediaWiki extensions / 3Translate: translatewiki.net so locked down I can't communicate with anyone there - 10https://bugzilla.wikimedia.org/70612#c4 (10sminthopsis84) Thanks. I did find the blue link "Not a translator? You can still join the community", which took me to "Join the community If you are a dev... [21:27:41] lol, thats generally how mw gets in its current state :P "I'm not entirely sure whats happening, and i know we have black magic somewhere that might somehow break it" [21:28:06] (and i do that same and not type-hint old code :P) [21:28:31] <^d> Type hinting in PHP lets you pretend you're working with a strictly-typed language :) [21:29:04] with hacklang you can pretend even more ;) [21:29:26] (03PS3) 10Legoktm: Fix class name "Database" --> "DatabaseBase" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159402 [21:29:43] (03CR) 10Legoktm: "okay, I added one." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159402 (owner: 10Legoktm) [21:29:50] (03CR) 10Hoo man: [C: 032] "\o/" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159402 (owner: 10Legoktm) [21:30:17] (03Merged) 10jenkins-bot: Fix class name "Database" --> "DatabaseBase" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/159402 (owner: 10Legoktm) [21:30:51] <^d> ebernhardson: Google seems to rank "hack php" nicely now. [21:31:08] <^d> When they first announced, "hack php" did not give you hacklang.org [21:31:15] <^d> :) [21:31:16] haha [21:31:54] (03CR) 10Jdlrobson: [C: 04-1] "I think we need to rethink the approach here." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159247 (https://bugzilla.wikimedia.org/69868) (owner: 10Jdlrobson) [21:32:14] (03CR) 10Jdlrobson: [C: 04-1] "I'm going to temporarily -1 this code, just as I have on https://gerrit.wikimedia.org/r/#/c/159247/" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159332 (owner: 10Matthias Mullie) [21:32:22] <^d> ebernhardson: I have a super trivial nitpicky flow bug :p [21:32:50] <^d> https://bugzilla.wikimedia.org/show_bug.cgi?id=70130 :) [21:33:38] (03PS6) 10Jdlrobson: H-4: Rename Close -> Lock [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158634 (owner: 10EBernhardson) [21:33:59] 3MediaWiki extensions / 3Translate: translatewiki.net so locked down I can't communicate with anyone there - 10https://bugzilla.wikimedia.org/70612#c5 (10Nemo) Created attachment 16422 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16422&action=edit Test as "Simple English" translator, seen from the... [21:34:22] (03PS10) 10Jdlrobson: Fix styling of deletion page when $wgUseMediaWikiUIEverywhere enabled [core] - 10https://gerrit.wikimedia.org/r/154121 [21:35:43] (03PS6) 10Jdlrobson: Correct button colours of preference page when $wgUseMediaWikiUIEverywhere is enabled [core] - 10https://gerrit.wikimedia.org/r/157709 (https://bugzilla.wikimedia.org/65317) [21:35:45] (03PS1) 10Foxtrott: More style fixes [skins/chameleon] - 10https://gerrit.wikimedia.org/r/159405 [21:36:01] 3MediaWiki / 3Unit tests: Reduce duplication for UnitTestList hook in extensions - 10https://bugzilla.wikimedia.org/70630 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None Most extensions use the same implementation of the UnitTestList hook (eg: https://github.com/wikimedia/mediawiki-extensi... [21:36:11] (03PS9) 10Jforrester: Set up an npm test pipeline for JS, CSS and banana i18n messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 [21:36:56] (03CR) 10Jforrester: "@Mark Done in PS9" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester) [21:36:59] 3Wikimedia / 3Bugzilla: gerrit->bugzilla notification broken (due to Bugzilla 4.4.3 changes in token/session passing) - 10https://bugzilla.wikimedia.org/65370#c21 (10Daniel Zahn) Binary files new/com/googlesource/gerrit/plugins/hooks/bz/BugzillaClient.class and old/com/googlesource/gerrit/plugins/hooks/bz/Bu... [21:37:00] (03CR) 10Foxtrott: [C: 032 V: 032] More style fixes [skins/chameleon] - 10https://gerrit.wikimedia.org/r/159405 (owner: 10Foxtrott) [21:38:00] (03PS1) 10EBernhardson: Merge remote-tracking branch 'origin/wmf/1.24wmf20' into 1.24wmf19 [extensions/Echo] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159406 [21:38:12] (03CR) 10Subramanya Sastry: [C: 032] Allow logging extended information from the backends. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/159398 (owner: 10Cscott) [21:38:29] (03Merged) 10jenkins-bot: Allow logging extended information from the backends. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/159398 (owner: 10Cscott) [21:38:44] (03PS1) 10EBernhardson: Merge remote-tracking branch 'origin/wmf/1.24wmf20' into HEAD [extensions/Flow] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159408 [21:39:00] (03CR) 10EBernhardson: [C: 032] Merge remote-tracking branch 'origin/wmf/1.24wmf20' into 1.24wmf19 [extensions/Echo] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159406 (owner: 10EBernhardson) [21:39:06] (03CR) 10Chad: [C: 032] Set $wgCacheDirectory = "$IP/cache" [vagrant] - 10https://gerrit.wikimedia.org/r/158923 (owner: 10Legoktm) [21:39:12] (03Merged) 10jenkins-bot: Set $wgCacheDirectory = "$IP/cache" [vagrant] - 10https://gerrit.wikimedia.org/r/158923 (owner: 10Legoktm) [21:39:16] (03CR) 10EBernhardson: [C: 032] Merge remote-tracking branch 'origin/wmf/1.24wmf20' into HEAD [extensions/Flow] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159408 (owner: 10EBernhardson) [21:39:27] (03Merged) 10jenkins-bot: Merge remote-tracking branch 'origin/wmf/1.24wmf20' into 1.24wmf19 [extensions/Echo] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159406 (owner: 10EBernhardson) [21:39:43] yay :D [21:39:51] (03Merged) 10jenkins-bot: Merge remote-tracking branch 'origin/wmf/1.24wmf20' into HEAD [extensions/Flow] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159408 (owner: 10EBernhardson) [21:40:58] 3MediaWiki extensions / 3Translate: translatewiki.net so locked down I can't communicate with anyone there - 10https://bugzilla.wikimedia.org/70612#c6 (10Nemo) (In reply to sminthopsis84 from comment #4) > It doesn't seem to be the case that Simple English is completely missing, > because there is a way to g... [21:42:01] legoktm: OMG, you abandonned 7300! The oldest outstanding commit in our repos, I think. [21:42:18] legoktm: (Good call.) [21:42:45] (03PS1) 10EBernhardson: Bump Echo and Flow in 1.24wmf19 [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159409 [21:43:13] (03CR) 10EBernhardson: [C: 032] Bump Echo and Flow in 1.24wmf19 [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159409 (owner: 10EBernhardson) [21:43:40] heh, glad to help :P [21:44:22] James_F: not the oldest, but close https://www.mediawiki.org/wiki/Gerrit/Reports/Oldest_open_changesets [21:44:38] Aha, interesting. [21:45:35] (03CR) 10Ori.livneh: "Parsing [[w:Barack Obama]] on osmium results in around 1,000 calls to timer_create, which doesn't seem right. OTOH, even when multiple re" (031 comment) [php/luasandbox] - 10https://gerrit.wikimedia.org/r/159011 (https://bugzilla.wikimedia.org/70177) (owner: 10Tim Starling) [21:46:11] (03Merged) 10jenkins-bot: Bump Echo and Flow in 1.24wmf19 [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159409 (owner: 10EBernhardson) [21:52:22] (03PS11) 10Jdlrobson: Fix styling of deletion page when $wgUseMediaWikiUIEverywhere enabled [core] - 10https://gerrit.wikimedia.org/r/154121 [21:52:46] (03CR) 10Jdlrobson: Fix styling of deletion page when $wgUseMediaWikiUIEverywhere enabled (034 comments) [core] - 10https://gerrit.wikimedia.org/r/154121 (owner: 10Jdlrobson) [21:52:57] (03CR) 10Jforrester: [C: 031] Move footer icons to assets/ directory (031 comment) [core] - 10https://gerrit.wikimedia.org/r/158650 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [21:59:46] (03CR) 10Worden.lee: [C: 032] Provide own spinner image [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/159376 (https://bugzilla.wikimedia.org/70615) (owner: 10Bartosz Dziewoński) [21:59:51] (03Merged) 10jenkins-bot: Provide own spinner image [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/159376 (https://bugzilla.wikimedia.org/70615) (owner: 10Bartosz Dziewoński) [22:01:42] (03CR) 10Jackmcbarn: "Are we sure that it's desirable to parse all of them? In the case of https://en.wikipedia.org/w/index.php?diff=617408528 and https://www.m" [core] - 10https://gerrit.wikimedia.org/r/159326 (https://bugzilla.wikimedia.org/16530) (owner: 10Anomie) [22:02:29] (03PS1) 10EBernhardson: Update convertToText.php script [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159411 [22:06:46] bd808, around? i have rebuilt my machine about 10 times by now :) [22:06:53] enabling mobile role kills it [22:07:11] (03CR) 10Spage: [C: 032] "Progress, gets past my API errors." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159411 (owner: 10EBernhardson) [22:07:46] (03Merged) 10jenkins-bot: Update convertToText.php script [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159411 (owner: 10EBernhardson) [22:07:48] yurikR1: Interesting. I don't think I've tried the mobile role for a while. I guess I should be glad. ;) [22:08:02] well duh! [22:08:02] :) [22:08:08] * bd808 looks to see if it is obviously busted [22:09:57] (03CR) 10EBernhardson: [C: 032] Use CONTENT_FORMAT_JSON instead of "json" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159230 (owner: 10Legoktm) [22:10:15] bd808, http://pastebin.com/7StsAzk2 [22:10:32] (03Merged) 10jenkins-bot: Use CONTENT_FORMAT_JSON instead of "json" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159230 (owner: 10Legoktm) [22:10:38] this is after i did vagrant destroy & reset-roles & up [22:10:52] the no-roles up works fine [22:11:30] Line 283 is the sign that something is about to go horribly wrong [22:11:46] (03PS1) 10Manybubbles: Fix another syntax error [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/159412 [22:11:54] Warning: MediaWiki tables seem to already exist. [22:12:45] (03CR) 10Legoktm: [C: 032] Reject empty lists or cats as import sources [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/158940 (https://bugzilla.wikimedia.org/70522) (owner: 10Wctaiwan) [22:13:44] (03PS1) 10Bsitu: Add job to keep user echo notifications in reasonable volume [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159413 [22:14:10] (03CR) 10jenkins-bot: [V: 04-1] Add job to keep user echo notifications in reasonable volume [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159413 (owner: 10Bsitu) [22:15:24] (03PS7) 10Jdlrobson: H-4: Rename Close -> Lock [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158634 (owner: 10EBernhardson) [22:16:20] (03CR) 10KHammerstein: [C: 031] "Its a good idea to have an icon because it follows common design patterns to show a user icon next to the username, and helps show that th" [skins/Vector] - 10https://gerrit.wikimedia.org/r/157990 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [22:16:36] (03PS2) 10Bsitu: Add job to keep user echo notifications in reasonable volume [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159413 [22:17:05] (03CR) 10jenkins-bot: [V: 04-1] Add job to keep user echo notifications in reasonable volume [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159413 (owner: 10Bsitu) [22:17:27] (03PS8) 10Legoktm: SpecialUpload: Use Config instead of global [core] - 10https://gerrit.wikimedia.org/r/152134 (https://bugzilla.wikimedia.org/69188) (owner: 10Florianschmidtwelzow) [22:17:37] (03CR) 10Legoktm: [C: 032] SpecialUpload: Use Config instead of global [core] - 10https://gerrit.wikimedia.org/r/152134 (https://bugzilla.wikimedia.org/69188) (owner: 10Florianschmidtwelzow) [22:18:20] (03CR) 10Jackmcbarn: Expose variables (aka magic words) to Lua (032 comments) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/159238 (owner: 10Jackmcbarn) [22:18:26] (03CR) 10Jdlrobson: [C: 031] "Can't run the browser test for some reason. If I could and it goes green I'd happily +2." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158634 (owner: 10EBernhardson) [22:18:29] (03PS2) 10Jackmcbarn: Expose variables (aka magic words) to Lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/159238 [22:20:46] (03CR) 10EBernhardson: Add job to keep user echo notifications in reasonable volume (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159413 (owner: 10Bsitu) [22:21:32] yurikR1: I'm testing to see if I can reproduce on OSX. [22:22:09] bd808, i have a sneaky suspiscion that you will be able to [22:22:29] (03CR) 10Bsitu: Add job to keep user echo notifications in reasonable volume (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159413 (owner: 10Bsitu) [22:22:35] That would be good because then maybe I can fix it :) [22:23:14] 3MediaWiki extensions / 3SemanticForms: SemanticForms does not work with MediaWiki 1.24 - 10https://bugzilla.wikimedia.org/70263#c8 (10Jeroen De Dauw) I've updated it now. Not needing to fork the repo like this would be great for everyone involved [22:23:53] (03Merged) 10jenkins-bot: SpecialUpload: Use Config instead of global [core] - 10https://gerrit.wikimedia.org/r/152134 (https://bugzilla.wikimedia.org/69188) (owner: 10Florianschmidtwelzow) [22:24:00] (03PS8) 10MarkTraceur: Make tutorial step a controller and UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 [22:27:03] oh wow. MW-V master is a bit messed up [22:29:11] bd808, that's what i have been saying for the past two weeks :) [22:29:46] yurikR1: The particular problem I'm seeing was just committed yesterday [22:30:23] the law of commutative errors [22:30:43] role::mediawiki is not enabled by default leading to a very quiet initial puppet run [22:30:44] 3MediaWiki / 3Uploading: SpecialUpload: Use Config instead of globals - 10https://bugzilla.wikimedia.org/69188#c4 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX Fixed all of them except for getInitialPageText, which has a @todo on it. Good enough for now. [22:31:09] I think most other roles depend on it so I probably gets pulled in most of the time if you have some role enabled. [22:31:14] Easy fix [22:31:47] But I haven't tested the mobilefrontend stuff yet [22:32:59] 3Wikimedia / 3Site requests: $wgSVGMaxSize is too low - 10https://bugzilla.wikimedia.org/70529 (10Jackmcbarn) 5PATC>3RESO/FIX [22:33:59] (03PS1) 10BryanDavis: Restore default role::mediawiki class to hieradata/common.yaml [vagrant] - 10https://gerrit.wikimedia.org/r/159416 [22:34:18] (03CR) 10BryanDavis: [C: 032] Restore default role::mediawiki class to hieradata/common.yaml [vagrant] - 10https://gerrit.wikimedia.org/r/159416 (owner: 10BryanDavis) [22:34:23] (03Merged) 10jenkins-bot: Restore default role::mediawiki class to hieradata/common.yaml [vagrant] - 10https://gerrit.wikimedia.org/r/159416 (owner: 10BryanDavis) [22:35:03] (03PS1) 10EBernhardson: Avoid getCleanSignature errors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159417 [22:36:29] 3MediaWiki extensions / 3SemanticForms: SemanticForms does not work with MediaWiki 1.24 - 10https://bugzilla.wikimedia.org/70263#c9 (10Yaron Koren) 5NEW>3RESO/INV Okay, great! I'm closing this bug now. [22:37:36] yurikR1: You will be happy to know I can reproduce. I'm going to try some other multiwiki roles to see if this is just a problem with mobilefrontend or something nastier. [22:40:29] 3MediaWiki / 3MediaWiki UI: VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages - 10https://bugzilla.wikimedia.org/56363#c12 (10Matthew Flaschen) Even if we do remove it, I would still like to know what the error is. [22:40:35] (03CR) 10Reedy: [C: 032] Refactor ApiEditMassMessageList::getEditSummary() [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/158839 (owner: 10Legoktm) [22:40:46] 3MediaWiki-Vagrant: Enabling role mobilefrontend causes puppet run failures - 10https://bugzilla.wikimedia.org/70314#c5 (10Bryan Davis) p:5Unprio>3High a:5Ori Livneh>3Bryan Davis Steps to reproduce: * vagrant destroy -f * vagrant reset-roles * vagrant git-update * vagrant up * vagrant enable-role mobi... [22:41:05] (03Merged) 10jenkins-bot: Refactor ApiEditMassMessageList::getEditSummary() [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/158839 (owner: 10Legoktm) [22:41:14] 3MediaWiki / 3Configuration: Convert things to use Config classes instead of globals (tracking) - 10https://bugzilla.wikimedia.org/69084 (10Kunal Mehta (Legoktm)) [22:41:19] 3MediaWiki / 3API: Convert ApiQueryExtLinksUsage to use Config instead of globals - 10https://bugzilla.wikimedia.org/70632 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None ApiQueryExtLinksUsage::prepareProtocols() and getProtocolPrefix() are both reading from $wgUrlProtocols directly. They'... [22:45:17] (03PS4) 10Legoktm: Merge branch 'contenthandler' into master [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/156087 [22:45:29] 3MediaWiki-Vagrant: Enabling role mobilefrontend causes puppet run failures - 10https://bugzilla.wikimedia.org/70314#c6 (10Bryan Davis) Immediately following puppet run that show creating the wiki as failing: $ mysql -e 'show databases;' +--------------------+ | Database | +--------------------+ | i... [22:47:13] (03CR) 10Reedy: [C: 032] Merge branch 'contenthandler' into master [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/156087 (owner: 10Legoktm) [22:47:41] (03Merged) 10jenkins-bot: Merge branch 'contenthandler' into master [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/156087 (owner: 10Legoktm) [22:48:30] 3Wikimedia / 3Media storage: Stuck old 1024px thumbnail version of a specific djvu image on wikisource.pl - 10https://bugzilla.wikimedia.org/70189#c6 (10wieralee) (In reply to Andre Klapper from comment #4) > wieralee: You closed this as FIXED without a comment. > How was this fixed? Any code commit? I don... [22:50:24] (03CR) 10EBernhardson: [C: 032] Make wgFlowContentFormat = html the default [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159385 (owner: 10Spage) [22:50:59] (03Merged) 10jenkins-bot: Make wgFlowContentFormat = html the default [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159385 (owner: 10Spage) [22:51:42] (03PS1) 10Legoktm: Set .gitreview back to master [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/159420 [22:52:02] (03CR) 10Legoktm: [C: 032] Set .gitreview back to master [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/159420 (owner: 10Legoktm) [22:52:28] (03CR) 10Mattflaschen: "Looks reasonable, what's a good form to test with?" [core] - 10https://gerrit.wikimedia.org/r/158800 (owner: 10BryanDavis) [22:52:30] 3MediaWiki extensions / 3CirrusSearch: Stemming: CirrusSearch does not find Биология for a Биологии query on ru.wp (but LuceneSearch does) - 10https://bugzilla.wikimedia.org/69766#c12 (10Gryllida) > Cirrus will only find results from cross namespace redirects if the target of the redirect is included in the... [22:52:35] (03Merged) 10jenkins-bot: Set .gitreview back to master [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/159420 (owner: 10Legoktm) [22:54:50] (03CR) 10BryanDavis: "superm401: I needed it for Id1adb8f. I'm not sure what other forms out in the wide world of MW maybe using these alternate submit buttons." [core] - 10https://gerrit.wikimedia.org/r/158800 (owner: 10BryanDavis) [22:55:33] (03CR) 10EBernhardson: [C: 04-1] "I don't think this is the right approach, this merely hides the links without preventing the actions from occurring." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158618 (owner: 10Jdlrobson) [22:55:45] 3MediaWiki extensions / 3MassMessage: MassMessage: Bugs related to contenthandler branch (tracking) - 10https://bugzilla.wikimedia.org/68599#c11 (10Kunal Mehta (Legoktm)) 5NEW>3RESO/FIX Marking as fixed as mm-ch is now in master. [22:56:14] 3MediaWiki extensions / 3MassMessage: Use ContentHandler based spamlist for MassMessage instead of parserfunction - 10https://bugzilla.wikimedia.org/61255#c5 (10Kunal Mehta (Legoktm)) 5ASSI>3RESO/FIX Now merged into master, yay! [22:56:24] yurikR1: If you run `vagrant provision` does it keep fialing for you, or does it just on the initial up/provision where the mobile wiki is created? [22:56:27] *failing [22:56:42] (03CR) 10Jdlrobson: "What is wrong with" [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx) [22:57:59] 3MediaWiki / 3Page editing: Editing help link goes to [[mw:Help:Editing_pages]] instead of the wiki's own [[Help:Editing]] page - 10https://bugzilla.wikimedia.org/70521#c4 (10Rob Kam) The Help link in the sidebar also links off-site to https://www.mediawiki.org/wiki/Help:Contents even though the local wiki's... [22:58:10] (03CR) 10Bartosz Dziewoński: Move footer icons to assets/ directory (031 comment) [core] - 10https://gerrit.wikimedia.org/r/158650 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [22:58:44] 3MediaWiki-Vagrant: Enabling role mobilefrontend causes puppet run failures - 10https://bugzilla.wikimedia.org/70314#c7 (10Bryan Davis) (In reply to Bryan Davis from comment #6) > > Is puppet failure a false negative somehow? Investigating further. Additional `vagrant provision` calls seem to complete with n... [22:59:04] bd808, always [22:59:17] both on initial and subsequent [22:59:43] So strangely for me it only puppet fails on the initial run and the wiki is setup properly [22:59:49] (03PS3) 10Jdlrobson: Add mw-ui-icon [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) [23:00:04] (03PS4) 10Jdlrobson: Add mw-ui-icon [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) [23:00:44] 3MediaWiki / 3Page editing: Editing help link goes to [[mw:Help:Editing_pages]] instead of the wiki's own [[Help:Editing]] page - 10https://bugzilla.wikimedia.org/70521#c5 (10Rob Kam) Edit MediaWiki:Helppage to fix it. [23:02:05] (03PS5) 10Jdlrobson: Add mw-ui-icon [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) [23:02:37] (03PS6) 10Jdlrobson: Add mw-ui-icon [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) [23:03:06] (03PS7) 10Jdlrobson: Add mw-ui-icon [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) [23:03:25] (03CR) 10Krinkle: "Manual build PASSED: https://integration.wikimedia.org/ci/job/mwext-UploadWizard-npm/2/console" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester) [23:03:33] (03PS1) 10Chad: Updating Cirrus to latest commits in 1.24wmf20 [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159421 [23:04:00] 3Wikimedia / 3General/Unknown: Cleanup and delete vewikimedia - 10https://bugzilla.wikimedia.org/55737#c9 (10TeleComNasSprVen) 5PATC>3RESO/WON Subsumed and replaced by https://bugzilla.wikimedia.org/show_bug.cgi?id=70579 [23:04:02] 3Wikimedia / 3Site requests: Create wiki for Wikimedia Venezuela - 10https://bugzilla.wikimedia.org/70579 (10TeleComNasSprVen) [23:05:20] bd808, sorry, just re-ran it, it passes on subsequent [23:05:34] (03PS3) 10Jdlrobson: kss: Add links upto depth 2 in ToC [core] - 10https://gerrit.wikimedia.org/r/158855 (owner: 10Prtksxna) [23:06:15] yurikR1: well at least we are seeing the same problem then :) [23:06:43] (03CR) 10jenkins-bot: [V: 04-1] Updating Cirrus to latest commits in 1.24wmf20 [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159421 (owner: 10Chad) [23:07:03] (03CR) 10Withoutaname: "I'm confused, are we considering Action a typeof ContextSource or that ContextSource is simply an inherent property of any type of Action?" [core] - 10https://gerrit.wikimedia.org/r/143211 (owner: 10Withoutaname) [23:07:33] (03CR) 10Chad: "stupid qunit." [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159421 (owner: 10Chad) [23:09:29] (03CR) 10Chad: [C: 032] Updating Cirrus to latest commits in 1.24wmf20 [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159421 (owner: 10Chad) [23:09:31] (03CR) 10jenkins-bot: [V: 04-1] Add mw-ui-icon [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) (owner: 10Jdlrobson) [23:10:09] (03CR) 10Jdlrobson: [C: 04-1] "The links in the table of content sub headings are incorrect. They point to the current page." [core] - 10https://gerrit.wikimedia.org/r/158855 (owner: 10Prtksxna) [23:10:13] (03CR) 10Mattflaschen: "> It's a minor update that doesn't break compatibility no" [core] - 10https://gerrit.wikimedia.org/r/158867 (owner: 10Paladox) [23:10:17] (03PS3) 10Jdlrobson: kss: Add js to hide non current sub-sections [core] - 10https://gerrit.wikimedia.org/r/158856 (owner: 10Prtksxna) [23:12:18] (03CR) 10EBernhardson: "suggestion on making the code clearer" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159246 (owner: 10Jdlrobson) [23:12:28] (03Merged) 10jenkins-bot: Updating Cirrus to latest commits in 1.24wmf20 [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159421 (owner: 10Chad) [23:12:58] (03PS2) 10EBernhardson: Remove redundant $template var from block renderAPI() method [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158825 (owner: 10Bsitu) [23:13:31] (03CR) 10GWicke: Unify logging through the service wrapper (031 comment) [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/151224 (owner: 10Mwalker) [23:14:03] (03CR) 10EBernhardson: [C: 031] "LGTM, have not tested will pull it down tonight" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158825 (owner: 10Bsitu) [23:14:15] 3MediaWiki extensions / 3MassMessage: CreateMassMessageList source text input field accepts non-existent categories - 10https://bugzilla.wikimedia.org/70522 (10Kunal Mehta (Legoktm)) a:3wctaiwan [23:14:29] (03CR) 10EBernhardson: [C: 032] "can't hurt" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159024 (owner: 10Spage) [23:14:34] (03CR) 10jenkins-bot: [V: 04-1] Annotate tests passing in phantomjs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159024 (owner: 10Spage) [23:15:59] 3MediaWiki / 3Documentation: Documentation is out of date, incomplete (tracking) - 10https://bugzilla.wikimedia.org/1 (10Kunal Mehta (Legoktm)) [23:16:02] 3MediaWiki extensions / 3MassMessage: Update documentation to incorporate mm-ch - 10https://bugzilla.wikimedia.org/70633 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None https://www.mediawiki.org/wiki/Help:Extension:MassMessage#Creating_a_page_list mainly. [23:16:08] (03PS3) 10Bsitu: [WIP]Add job to keep user notifications in reasonable volume [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159413 [23:16:26] (03CR) 10Krinkle: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester) [23:16:38] (03CR) 10Jdlrobson: [C: 04-1] kss: Add js to hide non current sub-sections (033 comments) [core] - 10https://gerrit.wikimedia.org/r/158856 (owner: 10Prtksxna) [23:17:05] (03CR) 10Jdlrobson: "(I know you use JS in the follow up patch but we want the page to be correct :-))" [core] - 10https://gerrit.wikimedia.org/r/158855 (owner: 10Prtksxna) [23:17:12] (03CR) 10GWicke: Use `/etc/mw-collection-ocg.js` configuration file if present. (031 comment) [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/159099 (owner: 10Cscott) [23:17:32] (03PS2) 10EBernhardson: Annotate tests passing in phantomjs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159024 (owner: 10Spage) [23:17:49] (03CR) 10EBernhardson: [C: 032] "PS2: manual rebase" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159024 (owner: 10Spage) [23:18:23] (03Merged) 10jenkins-bot: Annotate tests passing in phantomjs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159024 (owner: 10Spage) [23:18:32] (03PS4) 10Bsitu: [WIP]Add job to keep user notifications in reasonable volume [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159413 [23:19:18] (03PS1) 10Legoktm: Track usage of {{#target}} as well [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/159424 [23:20:26] (03CR) 10EBernhardson: "prefer positive conditional statements with === instead of !== when there is an else statement" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159249 (https://bugzilla.wikimedia.org/67830) (owner: 10Jdlrobson) [23:23:38] (03CR) 10Mattflaschen: "Please tag with bug 70134." [core] - 10https://gerrit.wikimedia.org/r/154121 (owner: 10Jdlrobson) [23:23:53] ^d: could you approve https://www.mediawiki.org/wiki/Gerrit/Project_ownership#.2B2_for_wctaiwan_in_extensions.2FMassMessage ? [23:26:48] <^d> legoktm: https://www.mediawiki.org/w/index.php?title=Gerrit%2FProject_ownership&diff=1146039&oldid=1135837 [23:26:58] thanks! [23:27:48] legoktm: \o/ [23:28:09] (03CR) 10EBernhardson: [C: 032] "re-apply Mlitn +2" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159228 (owner: 10Bsitu) [23:28:12] I just saw https://gerrit.wikimedia.org/r/#/c/156087/ [23:28:13] Woo. [23:28:27] * Carmela hugs Reedy. [23:28:34] :D [23:28:36] (03Merged) 10jenkins-bot: Remove (X) next to Alerts/Messages if there is one section [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159228 (owner: 10Bsitu) [23:28:44] it'll be live on test/test2/mw.o on thursday [23:28:55] Sweeet. [23:29:03] Are we still waiting on schema upgrades? [23:29:08] For the larger wikis. [23:29:11] for wider deployment, yes [23:29:33] MM disables the contenthandler features if the schema change isn't done [23:29:54] Right. [23:29:55] https://github.com/wikimedia/mediawiki-extensions-MassMessage/blob/master/MassMessage.hooks.php#L12 [23:29:56] Nice. [23:30:40] (03PS2) 10Jdlrobson: kss: Highlight section link based on scroll [core] - 10https://gerrit.wikimedia.org/r/158858 (owner: 10Prtksxna) [23:32:33] (03CR) 10Tim Starling: Make timer/profiler be thread-safe (035 comments) [php/luasandbox] - 10https://gerrit.wikimedia.org/r/159011 (https://bugzilla.wikimedia.org/70177) (owner: 10Tim Starling) [23:32:46] (03CR) 10Jdlrobson: [C: 04-1] kss: Highlight section link based on scroll (033 comments) [core] - 10https://gerrit.wikimedia.org/r/158858 (owner: 10Prtksxna) [23:32:49] (03PS4) 10Tim Starling: Make timer/profiler be thread-safe [php/luasandbox] - 10https://gerrit.wikimedia.org/r/159011 (https://bugzilla.wikimedia.org/70177) [23:33:29] (03CR) 10Jdlrobson: kss: Add js to hide non current sub-sections (031 comment) [core] - 10https://gerrit.wikimedia.org/r/158856 (owner: 10Prtksxna) [23:34:41] (03CR) 10GWicke: Clarify README with local development instructions. (032 comments) [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/159101 (owner: 10Cscott) [23:35:21] Carmela: Any thoughts on who might like to take on bug 56561? It feels like a quick win for users, and relatively easy to implement… [23:36:22] (03PS5) 10Bsitu: [WIP]Add job to keep user notifications in reasonable volume [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159413 [23:36:29] 3MediaWiki / 3MediaWiki UI: Deletion page has mw-ui-constructive button, Other/additional reason input is tiny - 10https://bugzilla.wikimedia.org/70134#c11 (10Matthew Flaschen) Created attachment 16423 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16423&action=edit Deletion page with wgUseMediaWikiU... [23:41:18] (03PS1) 10Jack Phoenix: Remove legacy i18n support + bump version number [extensions/UserStatus] - 10https://gerrit.wikimedia.org/r/159428 [23:42:02] (03CR) 10Jack Phoenix: [C: 032] Remove legacy i18n support + bump version number [extensions/UserStatus] - 10https://gerrit.wikimedia.org/r/159428 (owner: 10Jack Phoenix) [23:42:06] (03Merged) 10jenkins-bot: Remove legacy i18n support + bump version number [extensions/UserStatus] - 10https://gerrit.wikimedia.org/r/159428 (owner: 10Jack Phoenix) [23:42:44] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: wgBetaFeaturesFeatures is incomplete, causing wrong UI in preferences - 10https://bugzilla.wikimedia.org/69823 (10James Forrester) p:5Unprio>3High [23:43:53] (03PS1) 10Jack Phoenix: It's not paranoia if they're coming for you. [extensions/UserStatus] - 10https://gerrit.wikimedia.org/r/159429 [23:44:05] (03CR) 10Jack Phoenix: [C: 032] It's not paranoia if they're coming for you. [extensions/UserStatus] - 10https://gerrit.wikimedia.org/r/159429 (owner: 10Jack Phoenix) [23:44:11] (03Merged) 10jenkins-bot: It's not paranoia if they're coming for you. [extensions/UserStatus] - 10https://gerrit.wikimedia.org/r/159429 (owner: 10Jack Phoenix) [23:44:13] (03CR) 10GWicke: Use new log and status reporting framework (031 comment) [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/151215 (owner: 10Mwalker) [23:45:35] (03CR) 10Krinkle: "Reviewed. 2 minor things, rest looks great." (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester) [23:45:39] (03CR) 10Krinkle: [C: 04-1] Set up an npm test pipeline for JS, CSS and banana i18n messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester) [23:45:57] (03PS1) 10Jack Phoenix: Removed legacy i18n support + the $dir variable in favor of __DIR__ [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/159432 [23:46:19] (03CR) 10Jack Phoenix: [C: 032] Removed legacy i18n support + the $dir variable in favor of __DIR__ [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/159432 (owner: 10Jack Phoenix) [23:46:23] (03Merged) 10jenkins-bot: Removed legacy i18n support + the $dir variable in favor of __DIR__ [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/159432 (owner: 10Jack Phoenix) [23:48:17] chasemp, are you still setting up phabricator.wikimedia.org, or should I start filing tasks (if I can login) about issues I find? [23:49:59] 3MediaWiki / 3MediaWiki UI: Deletion page has mw-ui-constructive button, Other/additional reason input is tiny - 10https://bugzilla.wikimedia.org/70134#c12 (10Jon) Can we merge the existing patch and then raise a new bug to discuss the correct input size? Surely the use of the destructive button is a useful... [23:50:07] (03CR) 10Jforrester: Set up an npm test pipeline for JS, CSS and banana i18n messages (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester) [23:50:11] (03PS10) 10Jforrester: Set up an npm test pipeline for JS, CSS and banana i18n messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 [23:52:30] (03CR) 10Jdlrobson: "Guys I would appreciate your thoughts on this approach." [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) (owner: 10Jdlrobson) [23:53:50] (03CR) 10Bsitu: Add reverse chronological ordering to unread notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158239 (https://bugzilla.wikimedia.org/69919) (owner: 10Bsitu) [23:56:59] 3MediaWiki / 3Configuration: Convert things to use Config classes instead of globals (tracking) - 10https://bugzilla.wikimedia.org/69084 (10Kunal Mehta (Legoktm)) [23:57:01] 3MediaWiki / 3User login and signup: Special:Userlogin: Use Config instead of globals - 10https://bugzilla.wikimedia.org/70637 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None There's a lot... :( [23:59:25] (03CR) 10Jdlrobson: [C: 032] Apply vform styling to HTMLForm buttons [core] - 10https://gerrit.wikimedia.org/r/158800 (owner: 10BryanDavis)