[00:04:01] (03PS19) 10Paladox: MsUpload: Update to 9.5.1 [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/158884 [00:04:11] (03PS20) 10Paladox: MsUpload: Update to 9.5.1 [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/158884 [00:04:23] 3MediaWiki / 3User blocking: MediaWiki:Autoblocker etc. reveals to third party that a (blocked) user has used the same IP address - 10https://bugzilla.wikimedia.org/53008#c57 (10Alex Monk) I'm not sure what you guys are talking about with having powers. This is a MediaWiki feature, anyone can set up a wiki (... [00:04:47] (03PS21) 10Paladox: MsUpload: Update to 9.5.1 [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/158884 [00:05:30] (03CR) 10Paladox: [C: 031] "Hi I have now added the qqq.json file but it isent fully completed just some but in later commits it can be changed." [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/158884 (owner: 10Paladox) [00:06:09] (03PS1) 10Legoktm: Fix ArticleFromTitle hook [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/159003 [00:06:11] (03PS1) 10Legoktm: Allow opt-out via [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/159004 [00:06:29] (03CR) 10Legoktm: [C: 032] Fix ArticleFromTitle hook [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/159003 (owner: 10Legoktm) [00:06:33] (03Merged) 10jenkins-bot: Fix ArticleFromTitle hook [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/159003 (owner: 10Legoktm) [00:07:02] (03PS2) 10Legoktm: Allow opt-out via [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/159004 [00:09:33] (03PS22) 10Paladox: MsUpload: Update to 9.5.1 [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/158884 [00:09:47] (03CR) 10Jack Phoenix: [C: 032] Allow opt-out via [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/159004 (owner: 10Legoktm) [00:09:49] (03PS23) 10Paladox: MsUpload: Update to 9.5.1 [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/158884 [00:09:51] (03Merged) 10jenkins-bot: Allow opt-out via [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/159004 (owner: 10Legoktm) [00:10:08] (03PS24) 10Paladox: MsUpload: Update to 9.5.1 [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/158884 [00:11:46] (03CR) 10Paladox: [C: 031] MsUpload: Update to 9.5.1 [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/158884 (owner: 10Paladox) [00:12:51] (03PS5) 10Paladox: MsUpload: Update to 9.5.1 [extensions/MsUpload] (REL1_23) - 10https://gerrit.wikimedia.org/r/158888 [00:13:17] (03CR) 10Paladox: [C: 031] MsUpload: Update to 9.5.1 [extensions/MsUpload] (REL1_23) - 10https://gerrit.wikimedia.org/r/158888 (owner: 10Paladox) [00:13:17] [13node-cssjanus] 15Krinkle pushed 1 new commit to 06master: 02http://git.io/XusVwA [00:13:17] 13node-cssjanus/06master 146366a3e 15Timo Tijhof: test: Fix malformed multi-line test case... [00:13:23] 3MediaWiki extensions / 3GlobalUserPage: Add a link to the GlobalUserPage, from the special:GlobalPreferences menu - 10https://bugzilla.wikimedia.org/66932 (10Kunal Mehta (Legoktm)) p:5Unprio>3Low [00:14:54] [13node-cssjanus] 15Krinkle pushed 1 new commit to 06master: 02http://git.io/aHYjRw [00:14:54] 13node-cssjanus/06master 14f4f88c1 15Timo Tijhof: test: Convert test cases to JSON... [00:16:25] (03CR) 10Paladox: [C: 031] "It works I have tested it and supports .less" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151616 (owner: 10Paladox) [00:22:01] (03PS5) 10BryanDavis: [WIP] Request a global account rename [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156488 (https://bugzilla.wikimedia.org/68886) [00:22:03] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Request a global account rename [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156488 (https://bugzilla.wikimedia.org/68886) (owner: 10BryanDavis) [00:22:59] (03CR) 10Paladox: "thanks." [core] - 10https://gerrit.wikimedia.org/r/158868 (owner: 10Paladox) [00:24:38] (03CR) 10Jack Phoenix: [C: 031] Add support for the GlobalUserPage extension [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/158916 (https://bugzilla.wikimedia.org/70509) (owner: 10Legoktm) [00:25:14] (03PS6) 10BryanDavis: [WIP] Request a global account rename [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156488 (https://bugzilla.wikimedia.org/68886) [00:26:03] (03PS1) 10Yaron Koren: Added handling for CSV with trailing commas removed [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/159005 [00:26:16] (03CR) 10BryanDavis: "l10n changes addressed in PS5" (033 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156488 (https://bugzilla.wikimedia.org/68886) (owner: 10BryanDavis) [00:27:24] [13node-cssjanus] 15Krinkle pushed 1 new commit to 06master: 02http://git.io/Mu6rWA [00:27:24] 13node-cssjanus/06master 1447aa056 15Timo Tijhof: test: Omit output value in test data when the same as input... [00:28:23] [13node-cssjanus] 15Krinkle pushed 1 new commit to 06master: 02http://git.io/CDC3hA [00:28:23] 13node-cssjanus/06master 14f5dd6e2 15Timo Tijhof: readme: Fix Travis CI badge [00:29:08] 3MediaWiki / 3Parser: Internal page and file links that look like urls render as external links (e.g. [[http://]] or [[file:Example.svg]]) - 10https://bugzilla.wikimedia.org/44011 (10Jackmcbarn) 5PATC>3NEW [00:30:56] (03CR) 10Jackmcbarn: [C: 04-1] "I don't really like the magic numbers or the duplication of the logic in all 3 places." [core] - 10https://gerrit.wikimedia.org/r/158550 (https://bugzilla.wikimedia.org/70227) (owner: 10Ori.livneh) [00:36:15] (03CR) 10Yaron Koren: [C: 032 V: 031] Added handling for CSV with trailing commas removed [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/159005 (owner: 10Yaron Koren) [00:40:01] legoktm, got any examples of where an admin added tracking code via their editinterface rights? [00:40:28] not handy, but I know people have added google analytics stuff into Common.js before [00:40:52] hoo might know specifics? [00:41:11] Haven't we had something via translatewiki before too? [00:50:25] 3MediaWiki / 3User blocking: MediaWiki:Autoblocker etc. reveals to third party that a (blocked) user has used the same IP address - 10https://bugzilla.wikimedia.org/53008#c58 (10Alex Monk) It sounds to me like this issue is inherent in the design of the autoblock system, so I doubt there's any simple solutio... [00:54:08] 3MediaWiki / 3User blocking: MediaWiki:Autoblocker etc. reveals to third party that a (blocked) user has used the same IP address - 10https://bugzilla.wikimedia.org/53008#c59 (10Alex Monk) (In reply to Alex Monk from comment #58) > obviously your own IP is available to the blocked > users - i.e. the intended... [00:59:17] Krenair: what's bug 46346? [00:59:23] err [00:59:24] 43646 [01:01:29] [13node-cssjanus] 15Krinkle pushed 1 new commit to 06master: 02http://git.io/4YVZ1Q [01:01:29] 13node-cssjanus/06master 14f112f34 15Timo Tijhof: build: Use Grunt and add node-jscs [01:26:28] (03PS3) 10Alex Monk: Add option to send confirm and migrate email to already-confirmed accounts [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/153760 (https://bugzilla.wikimedia.org/54760) (owner: 10Legoktm) [01:36:18] legoktm, okay so I saw your comment about User::getTokenUrl [01:43:10] The hack there is to 'fix' https://bugzilla.wikimedia.org/show_bug.cgi?id=6957 [01:43:27] If I saw such a bug these days, I would mark it resolved invalid. [01:50:12] (03CR) 10Alex Monk: Add option to send confirm and migrate email to already-confirmed accounts (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/153760 (https://bugzilla.wikimedia.org/54760) (owner: 10Legoktm) [02:05:10] (03CR) 10Alex Monk: [C: 04-1] Convert migratePass0 to use Maintenance class (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143402 (owner: 10Legoktm) [02:18:23] 3MediaWiki / 3User blocking: MediaWiki:Autoblocker etc. reveals to third party that a (blocked) user has used the same IP address - 10https://bugzilla.wikimedia.org/53008#c60 (10Jackmcbarn) Rich, I've read your proposal. It seems that what you're basically requesting is to make it so only CheckUsers (or memb... [02:19:16] Krenair: does my interpretation ^ there match yours? [02:26:56] jackmcbarn, "Suppression of block ID number in log", yes [02:30:06] (03CR) 10Ori.livneh: "@Jackmcbarn: The magic numbers are the fault of PHP; it's hardly fair to blame this change for that. As for the repetition, what would you" [core] - 10https://gerrit.wikimedia.org/r/158550 (https://bugzilla.wikimedia.org/70227) (owner: 10Ori.livneh) [02:30:28] (03CR) 10Legoktm: Add option to send confirm and migrate email to already-confirmed accounts (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/153760 (https://bugzilla.wikimedia.org/54760) (owner: 10Legoktm) [02:30:38] 3MediaWiki / 3User blocking: MediaWiki:Autoblocker etc. reveals to third party that a (blocked) user has used the same IP address - 10https://bugzilla.wikimedia.org/53008#c61 (10Jackmcbarn) Also, keep in mind that it isn't enough to have enough information to perform the technical action of lifting the autob... [02:31:16] (03CR) 10Jackmcbarn: "In that case, I guess just add comments explaining what you're doing. That at least avoids a trip through git blame for anyone trying to m" [core] - 10https://gerrit.wikimedia.org/r/158550 (https://bugzilla.wikimedia.org/70227) (owner: 10Ori.livneh) [02:33:54] (03PS1) 10Gnosygnu: v1.9.2.1 [xowa] - 10https://gerrit.wikimedia.org/r/159008 [02:38:35] (03CR) 10Legoktm: "Can we add wfGetRusage, and have the usage in WebStart be the raw function with a comment explaining why? And then a comment in the docs o" [core] - 10https://gerrit.wikimedia.org/r/158550 (https://bugzilla.wikimedia.org/70227) (owner: 10Ori.livneh) [02:42:41] legoktm: i just saw https://gerrit.wikimedia.org/r/#/c/146025/ pop up in my queue. what's the bare minimum setup i need to test that? [02:55:50] (03PS1) 10Spage: Fix "Cancelling reply preview" browser test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159009 [03:26:00] jackmcbarn: umm, I guess you need to install E:UserMerge, do something with flagged revs to generate entries in those tables, and then merge the users with Special:UserMerge [03:26:19] so i don't need CentralAuth and a wikifarm or anything? good [03:26:28] i'll try to test and review that by tomorrow [03:27:54] nope! [03:27:55] thanks [03:38:34] (03CR) 10GWicke: "So are you saying that pure skin styles like the left column indent or borders should no longer reference div#content? Should they use .mw" [skins/Vector] - 10https://gerrit.wikimedia.org/r/158803 (owner: 10Arlolra) [03:42:08] 3MediaWiki extensions / 3Collection: Status: Bundling process died with non zero code: 1 - 10https://bugzilla.wikimedia.org/70544 (10Greg Grossmeier) p:5Unprio>3Normal [03:42:10] 3MediaWiki extensions / 3Collection: Status: Bundling process died with non zero code: 1 - 10https://bugzilla.wikimedia.org/70544 (10Greg Grossmeier) 3NEW p:3Unprio s:3normal a:3None I created a book and rendered as epub. Got that and downloaded it fine. Press back to the page of rendering choices,... [03:57:35] (03PS1) 10Tim Starling: [WIP] Make timer/profiler be thread-safe [php/luasandbox] - 10https://gerrit.wikimedia.org/r/159011 [04:07:16] (03PS2) 10Tim Starling: [WIP] Make timer/profiler be thread-safe [php/luasandbox] - 10https://gerrit.wikimedia.org/r/159011 (https://bugzilla.wikimedia.org/70177) [04:41:28] (03PS1) 10Legoktm: Use Config instead of globals, part #1 [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/159012 [04:46:53] (03PS1) 10Jamesmontalvo3: Many improvements, including new parser function "counter" * Move functions to NumerAlpha class for future updates * add README * add gitignore * add composer support * create "counter" parser function with more fine-tuned control * add first phpunit test [extensions/NumerAlpha] - 10https://gerrit.wikimedia.org/r/159013 [04:49:30] (03CR) 10Jamesmontalvo3: "From what I can tell the original author is not maintaining this extension anymore. Has anyone taken over?" [extensions/NumerAlpha] - 10https://gerrit.wikimedia.org/r/159013 (owner: 10Jamesmontalvo3) [05:20:24] (03CR) 10Ori.livneh: [WIP] Make timer/profiler be thread-safe (031 comment) [php/luasandbox] - 10https://gerrit.wikimedia.org/r/159011 (https://bugzilla.wikimedia.org/70177) (owner: 10Tim Starling) [05:27:19] (03PS1) 10tosfos: Allow newlines for jquery insert [extensions/MultimediaPlayer] - 10https://gerrit.wikimedia.org/r/159015 [05:29:34] (03PS2) 10tosfos: Allow newlines for jquery insert [extensions/MultimediaPlayer] - 10https://gerrit.wikimedia.org/r/159015 [05:50:38] (03CR) 10Gilles: [C: 031] "The change looks good, but I'll wait this one out a little bit to see if there's any objection to this change in the village pump discussi" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158887 (owner: 10TheDJ) [05:54:11] (03CR) 10tosfos: [C: 032] Allow newlines for jquery insert [extensions/MultimediaPlayer] - 10https://gerrit.wikimedia.org/r/159015 (owner: 10tosfos) [05:54:16] (03Merged) 10jenkins-bot: Allow newlines for jquery insert [extensions/MultimediaPlayer] - 10https://gerrit.wikimedia.org/r/159015 (owner: 10tosfos) [06:03:21] (03PS1) 10Legoktm: [WIP] Add tests! [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/159016 [06:03:24] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add tests! [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/159016 (owner: 10Legoktm) [06:05:18] (03PS1) 10Legoktm: Remove unused GlobalUserPage::isSourcePage() [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/159017 [06:06:22] (03PS2) 10Gilles: Chunked upload result should consistently have a "stage" value for "Poll" [core] - 10https://gerrit.wikimedia.org/r/158593 [06:15:08] (03PS1) 10Legoktm: Clean up SkinTemplateNavigationUniversal hook [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/159018 (https://bugzilla.wikimedia.org/70506) [06:15:13] (03PS1) 10Legoktm: Generalize all ShoutWiki-specific messages [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/159019 [06:15:15] (03PS1) 10Legoktm: Remove unused qqq keys [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/159020 [06:17:54] (03CR) 10Legoktm: Add support for showing a footer at the bottom of global user pages (031 comment) [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/158605 (https://bugzilla.wikimedia.org/66931) (owner: 10Legoktm) [06:18:14] (03PS3) 10Gilles: Fix TitleBlacklist support [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158337 (https://bugzilla.wikimedia.org/65624) [06:24:51] (03CR) 10Gilles: [C: 031] WikimediaMessages Role [vagrant] - 10https://gerrit.wikimedia.org/r/158922 (owner: 10Dan-nl) [06:25:46] (03CR) 10Gilles: [C: 032] Feedback: Use a proper URL for the feedback page link [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158896 (owner: 10TheDJ) [06:26:14] (03Merged) 10jenkins-bot: Feedback: Use a proper URL for the feedback page link [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158896 (owner: 10TheDJ) [06:26:33] (03Abandoned) 10Spage: Hide benefits column on narrower screens. [core] - 10https://gerrit.wikimedia.org/r/72877 (https://bugzilla.wikimedia.org/49002) (owner: 10Spage) [06:29:54] 3MediaWiki / 3User login and signup: [New version] Hide stats list on small screen sizes rather than move it - 10https://bugzilla.wikimedia.org/49002#c7 (10spage) 5PATC>3RESO/WON This is hard to fix without assuming the size of elements in the skin, and it's not the end of the world for the benefits to d... [06:34:17] (03CR) 10Gilles: "Is this still WIP?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155850 (owner: 10MarkTraceur) [06:42:54] (03CR) 10Gilles: [C: 032] Add controllers for each step - mostly stubs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151699 (owner: 10MarkTraceur) [06:43:21] (03Merged) 10jenkins-bot: Add controllers for each step - mostly stubs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151699 (owner: 10MarkTraceur) [06:43:28] (03PS7) 10Gilles: Make tutorial step a controller and UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 (owner: 10MarkTraceur) [06:44:55] (03PS6) 10Dan-nl: GWToolset Role Additions [vagrant] - 10https://gerrit.wikimedia.org/r/158950 [06:44:57] (03PS3) 10Dan-nl: WikimediaMessages Role [vagrant] - 10https://gerrit.wikimedia.org/r/158922 [06:46:10] (03CR) 10Dan-nl: "* cleaned-up whitespace in some of the XML files." [vagrant] - 10https://gerrit.wikimedia.org/r/158950 (owner: 10Dan-nl) [06:49:16] (03CR) 10Gilles: [C: 04-1] "Needs updating to follow the recent changes to the parent, I'm getting "this.ui.moveTo is not a function"" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 (owner: 10MarkTraceur) [07:08:37] (03PS1) 10Spage: Fix missing "Given I am logged in as a new user" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159022 [07:18:23] (03CR) 10Legoktm: "Category existence is weird. Categories technically exist as long as they have members, even if the page "Category:Foo" doesn't. And if th" [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/158940 (https://bugzilla.wikimedia.org/70522) (owner: 10Wctaiwan) [07:20:36] (03CR) 10Legoktm: [C: 04-1] Reject non-existent categories as import sources (031 comment) [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/158940 (https://bugzilla.wikimedia.org/70522) (owner: 10Wctaiwan) [07:32:28] (03PS1) 10Tweichart: fixed typos by champion [extensions/BlueSpiceExtensions] (REL1_22) - 10https://gerrit.wikimedia.org/r/159023 [07:47:00] (03PS3) 10Wctaiwan: Reject empty lists or cats as import sources [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/158940 (https://bugzilla.wikimedia.org/70522) [07:47:59] (03CR) 10Jforrester: "I guess it is because it doesn't yet add qqq documentation for all messages (~20 left without after this), but Mark will know better." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155850 (owner: 10MarkTraceur) [07:50:05] (03Abandoned) 10Legoktm: Mock plugin interface for Popups 2.0 [extensions/Popups] - 10https://gerrit.wikimedia.org/r/143269 (owner: 10Legoktm) [07:50:47] (03Abandoned) 10Legoktm: Load AntiSpoof for CA "extension" in a $wgExtensionFunctions [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144633 (owner: 10Legoktm) [07:55:47] (03PS2) 10Legoktm: $wgAuth is never a stub object [core] - 10https://gerrit.wikimedia.org/r/153964 [07:55:49] (03PS3) 10Legoktm: Add ApiModuleManager::getClassName() [core] - 10https://gerrit.wikimedia.org/r/154352 [08:03:33] km-mpb:mediawiki km$ ssh -x -p 29418 legoktm@gerrit.wikimedia.org gerrit query --format=JSON --current-patch-set change:153964 [08:03:33] Segmentation fault: 11 [08:03:41] waaat. [08:04:50] ssh segfaults? [08:04:54] * wctaiwan grins [08:05:09] even ssh localhost is segfaulting. [08:05:10] ugh [08:06:25] installed anything recently? [08:06:51] nope...looks like even more things are segfaulting [08:07:01] sh: line 1: 19279 Segmentation fault: 11 /Applications/Xcode.app/Contents/Developer/usr/bin/xcodebuild -version 2> /dev/null [08:07:01] sh: line 1: 19287 Segmentation fault: 11 /usr/bin/xcodebuild -version 2> /dev/null [08:07:10] reboot. [08:07:19] if that doesn't work, reinstall >_> [08:07:23] lol [08:07:27] bbl :P [08:07:31] hf [08:21:39] yay, segfaulting stopped! [08:23:52] rebooting fixed it? [08:24:56] (03CR) 10Smuggli: "The font size is too big so facet labels can break into a new line. When this happens there is a chance that the positioning also changes " [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/158608 (owner: 10Tweichart) [08:25:32] yup [08:25:51] okay [08:30:37] (03PS3) 10Legoktm: $wgAuth is no longer a stub object [core] - 10https://gerrit.wikimedia.org/r/153964 [08:31:00] (03CR) 10Legoktm: $wgAuth is no longer a stub object (031 comment) [core] - 10https://gerrit.wikimedia.org/r/153964 (owner: 10Legoktm) [08:34:48] (03PS1) 10Spage: Annotate tests passing in phantomjs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159024 [08:40:26] (03PS6) 10Legoktm: Maintenance: Add an easy way to access Config instances [core] - 10https://gerrit.wikimedia.org/r/152823 [08:47:26] (03PS3) 10Legoktm: Don't depend on hacky $wgExtDistListFile file [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/158054 [08:47:54] (03CR) 10Legoktm: Don't depend on hacky $wgExtDistListFile file (032 comments) [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/158054 (owner: 10Legoktm) [08:50:30] (03CR) 10Wctaiwan: [C: 031] Use Title::hasContentModel() instead of a direct comparison [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/157011 (owner: 10Legoktm) [08:51:33] (03CR) 10Legoktm: [C: 031] Reject empty lists or cats as import sources [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/158940 (https://bugzilla.wikimedia.org/70522) (owner: 10Wctaiwan) [09:03:20] (03PS4) 10Legoktm: Add ApiModuleManager::getClassName() [core] - 10https://gerrit.wikimedia.org/r/154352 [09:03:22] (03PS1) 10Legoktm: Add @covers tags to ApiModuleManagerTest [core] - 10https://gerrit.wikimedia.org/r/159025 [09:04:49] (03CR) 10Legoktm: "PS4: Added test cases" [core] - 10https://gerrit.wikimedia.org/r/154352 (owner: 10Legoktm) [09:06:26] 3Wikimedia / 3Wikidata: create bug reports for problems reported in logstash - 10https://bugzilla.wikimedia.org/70550 (10Jan Zerebecki) 3NEW p:3Unprio s:3enhanc a:3Wikidata bugs Create bug reports for problems reported in logstash. A starting query to find them is available at https://logstash.wikime... [09:06:38] (03PS5) 10Legoktm: Add ApiModuleManager::getClassName() [core] - 10https://gerrit.wikimedia.org/r/154352 [09:15:12] 3MediaWiki / 3MediaWiki UI: Checkboxes with multiline labels cause broken focus state - 10https://bugzilla.wikimedia.org/70551 (10Derk-Jan Hartman) 3NEW p:3Unprio s:3normal a:3None Created attachment 16400 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16400&action=edit screenshot of the prob... [09:44:23] 3Wikimedia / 3General/Unknown: Help users clean up manual importing of global.js/global.css pages across Wikimedia wikis - 10https://bugzilla.wikimedia.org/68933 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX [09:45:54] 3MediaWiki extensions / 3[other]: [IssueTracker] Use ContentHandler rather than a custom table - 10https://bugzilla.wikimedia.org/56135 (10Kunal Mehta (Legoktm)) a:5Kunal Mehta (Legoktm)>3None [09:47:56] (03PS1) 10Tweichart: fix for axis label [extensions/BlueSpiceExtensions] (REL1_22) - 10https://gerrit.wikimedia.org/r/159027 [09:56:23] 3MediaWiki extensions / 3CentralAuth: centralauth-merge-step1-title double escaping - 10https://bugzilla.wikimedia.org/70391 (10Kunal Mehta (Legoktm)) [10:32:12] 3MediaWiki extensions / 3SemanticForms: SemanticForms does not work with MediaWiki 1.24 - 10https://bugzilla.wikimedia.org/70263#c4 (10Niklas Laxström) Looks like this was indeed a false alert. You can close this or keep it as reminder to update the development version of SF in composer. [10:40:11] (03CR) 10Jdlrobson: [C: 032] Hygiene: Dont run jshint against .less files [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158822 (owner: 10EBernhardson) [10:40:39] (03Merged) 10jenkins-bot: Hygiene: Dont run jshint against .less files [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158822 (owner: 10EBernhardson) [10:40:52] (03CR) 10Jdlrobson: [C: 032] Hygiene: Give ApiStub modes names instead of numbers [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158826 (owner: 10EBernhardson) [10:41:35] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Give ApiStub modes names instead of numbers [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158826 (owner: 10EBernhardson) [10:52:13] (03PS2) 10Addshore: Add @covers tags to ApiModuleManagerTest [core] - 10https://gerrit.wikimedia.org/r/159025 (owner: 10Legoktm) [10:52:33] (03CR) 10Addshore: [C: 032] Add @covers tags to ApiModuleManagerTest [core] - 10https://gerrit.wikimedia.org/r/159025 (owner: 10Legoktm) [10:53:09] (03CR) 10Jdlrobson: [C: 04-1] Show alerts tab if active notifications and no messages (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158820 (https://bugzilla.wikimedia.org/70461) (owner: 10EBernhardson) [10:57:35] (03CR) 10Jdlrobson: "I'm copying and pasting the URL in bsitu's commit and changing mediawiki.org to localhost." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158302 (owner: 10Bsitu) [10:59:19] (03CR) 10Jdlrobson: [C: 032] "Since there seems there are 2 bugs here https://bugzilla.wikimedia.org/show_bug.cgi?id=70554" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158302 (owner: 10Bsitu) [10:59:55] (03Merged) 10jenkins-bot: Implement post history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158302 (owner: 10Bsitu) [11:00:17] (03CR) 10Jdlrobson: [C: 032] Add topic name to 'create topic' notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158264 (owner: 10Bsitu) [11:00:54] (03Merged) 10jenkins-bot: Add topic name to 'create topic' notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158264 (owner: 10Bsitu) [11:04:25] 3MediaWiki extensions / 3WikidataRepo: add test that fails when tests will not be run because of missing @group - 10https://bugzilla.wikimedia.org/70555 (10Jan Zerebecki) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Add a PHPUnit test that fails when tests will not be run by our CI because of missing @g... [11:05:27] (03CR) 10Smuggli: [C: 031] fix for axis label [extensions/BlueSpiceExtensions] (REL1_22) - 10https://gerrit.wikimedia.org/r/159027 (owner: 10Tweichart) [11:06:47] (03CR) 10Jdlrobson: [C: 04-1] Fix "Cancelling reply preview" browser test (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159009 (owner: 10Spage) [11:10:29] if I need to add a maintenance category to Commons file pages quickly (faster than the normal 1 month cache rotation time), is it feasible to use a parser hook to add the category, and run a job to force the refresh of all ~20M pages? [11:11:23] (03PS6) 10Jdlrobson: Timestamp helper fixes for old things [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158100 (https://bugzilla.wikimedia.org/59919) [11:11:29] (03CR) 10Jdlrobson: Timestamp helper fixes for old things (036 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158100 (https://bugzilla.wikimedia.org/59919) (owner: 10Jdlrobson) [11:11:36] (03PS7) 10Jdlrobson: Timestamp helper fixes for old things [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158100 (https://bugzilla.wikimedia.org/59919) [11:14:04] (03PS1) 10Dan-nl: Improve category instructions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/159036 [11:14:41] 3Wikimedia / 3Media storage: 3 images missing - 10https://bugzilla.wikimedia.org/70556 (10Yann Forget) 3NEW p:3Unprio s:3normal a:3None These 3 images are missing: https://commons.wikimedia.org/wiki/File:Bharadwaj_Dayala%27s_triumphant_return_from_his_world_tour_on_motorcycle.jpg https://commons.wiki... [11:40:55] 3Wikimedia / 3Media storage: 404 errors for three images on Commons - 10https://bugzilla.wikimedia.org/70556 (10Andre Klapper) p:5Unprio>3Normal [12:11:22] (03CR) 10Siebrand: [C: 032] Improve category instructions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/159036 (owner: 10Dan-nl) [12:11:27] (03Merged) 10jenkins-bot: Improve category instructions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/159036 (owner: 10Dan-nl) [12:23:10] (03PS8) 10Jdlrobson: Timestamp helper fixes for old things [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158100 (https://bugzilla.wikimedia.org/59919) [12:23:32] (03PS9) 10Jdlrobson: Timestamp helper fixes for old things [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158100 (https://bugzilla.wikimedia.org/59919) [12:24:19] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/158054 (owner: 10Legoktm) [12:24:52] (03PS5) 10Siebrand: Add some missing qqq messages, remove unused messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155850 (owner: 10MarkTraceur) [12:25:25] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155850 (owner: 10MarkTraceur) [12:26:42] (03PS1) 10Manybubbles: Disable phrase rescore if rescore window is 0 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/159040 [12:26:57] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." (032 comments) [extensions/BlueSpiceExtensions] (REL1_22) - 10https://gerrit.wikimedia.org/r/159023 (owner: 10Tweichart) [12:29:53] (03CR) 10Rillke: [C: 031] "We do not consider UW Flickr uploads as verified because they aren't. This also does not have something to do with "community", this is ju" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158887 (owner: 10TheDJ) [12:32:09] (03CR) 10Raimond Spekking: [C: 032] Generalize all ShoutWiki-specific messages [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/159019 (owner: 10Legoktm) [12:33:16] (03CR) 10Daniel Kinzler: [C: 032] Add ApiModuleManager::getClassName() [core] - 10https://gerrit.wikimedia.org/r/154352 (owner: 10Legoktm) [12:34:13] (03CR) 10Raimond Spekking: [C: 032] Remove unused qqq keys [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/159020 (owner: 10Legoktm) [12:35:10] (03CR) 10Manybubbles: [C: 032] Remove last of in-process caching [search/repository-swift] - 10https://gerrit.wikimedia.org/r/158908 (owner: 10Chad) [12:37:16] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/159019 (owner: 10Legoktm) [12:37:33] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/159018 (https://bugzilla.wikimedia.org/70506) (owner: 10Legoktm) [12:37:56] (03CR) 10Daniel Kinzler: [C: 04-1] "Looks good now, but please add a unit test to MaintenanceTest, testign the default/fallback as well as explicitly setting a config." [core] - 10https://gerrit.wikimedia.org/r/152823 (owner: 10Legoktm) [12:38:23] 3Wikimedia / 3Media storage: 404 errors for three images on Commons - 10https://bugzilla.wikimedia.org/70556#c1 (10Tisza Gergő) None of the files have been moved so this is unrelated to the recent swift issues. The file pages have a warning template about watermarks, so the images must have been visible orig... [12:38:29] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (033 comments) [extensions/NumerAlpha] - 10https://gerrit.wikimedia.org/r/159013 (owner: 10Jamesmontalvo3) [12:39:15] (03Merged) 10jenkins-bot: Add ApiModuleManager::getClassName() [core] - 10https://gerrit.wikimedia.org/r/154352 (owner: 10Legoktm) [12:39:25] (03Merged) 10jenkins-bot: Add @covers tags to ApiModuleManagerTest [core] - 10https://gerrit.wikimedia.org/r/159025 (owner: 10Legoktm) [12:55:55] 3Wikimedia / 3General/Unknown: Garbage stylesheets in zh-yue wikipedia - 10https://bugzilla.wikimedia.org/70557 (10yaukasin) 3UNCO p:3Unprio s:3major a:3None zh-yue wikipedia does not load the stylesheets properly. When I view the source HTML code, I discover that there are many garbage stylesheets w... [12:56:55] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156488 (https://bugzilla.wikimedia.org/68886) (owner: 10BryanDavis) [13:02:59] (03CR) 10Manybubbles: [C: 031] Provide own arrow images [extensions/LiquidThreads] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/158617 (https://bugzilla.wikimedia.org/70412) (owner: 10Jforrester) [13:07:09] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/155442 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [13:08:16] (03CR) 10Siebrand: Initial extension code (031 comment) [extensions/SandboxLink] - 10https://gerrit.wikimedia.org/r/157296 (https://bugzilla.wikimedia.org/69650) (owner: 10Bartosz Dziewoński) [13:09:20] (03CR) 10Siebrand: "i18n/L10n reviewed." (031 comment) [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/158927 (owner: 10UltrasonicNXT) [13:12:11] (03PS1) 10Helder.wiki: Run the setup whenever WikiEditor is enabled [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/159043 [13:13:18] (03CR) 10Pwirth: [C: 032 V: 032] fix for axis label [extensions/BlueSpiceExtensions] (REL1_22) - 10https://gerrit.wikimedia.org/r/159027 (owner: 10Tweichart) [13:14:00] (03PS2) 10Helder.wiki: Run the setup whenever WikiEditor is enabled [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/159043 [13:14:41] (03CR) 10Helder.wiki: "Follow-up: Ie455009df54deecc67707779e9861daf633fc690." [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/115205 (https://bugzilla.wikimedia.org/61220) (owner: 10Tpt) [13:16:04] (03CR) 10Tpt: [C: 032] "Thanks a lot!" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/159043 (owner: 10Helder.wiki) [13:16:23] (03Merged) 10jenkins-bot: Run the setup whenever WikiEditor is enabled [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/159043 (owner: 10Helder.wiki) [13:16:38] 3Wikimedia / 3Media storage: "Original file" seems to be missing at Commons for an image - 10https://bugzilla.wikimedia.org/70416#c2 (10Filippo Giunchedi) can't find it in the deleted container root@ms-fe1001:~# swift list wikipedia-commons-local-deleted.6b | grep -i 6bcb70ac391dd09ff012b78fceb7922c root@ms... [13:17:22] 3MediaWiki extensions / 3ProofreadPage: WikiEditor loads in different places in the Page namespace depending upon which user preferences are selected - 10https://bugzilla.wikimedia.org/70431 (10Helder) 5UNCO>3NEW [13:18:45] (03PS1) 10Amire80: Localize numbers of alerts and messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159044 [13:34:45] (03CR) 10Anomie: [C: 032] $wgAuth is no longer a stub object [core] - 10https://gerrit.wikimedia.org/r/153964 (owner: 10Legoktm) [13:41:23] 3MediaWiki extensions / 3WikidataRepo: Create a special page to query for badges - 10https://bugzilla.wikimedia.org/70209 (10Bene*) p:5Unprio>3High s:5normal>3major [13:41:47] (03Merged) 10jenkins-bot: $wgAuth is no longer a stub object [core] - 10https://gerrit.wikimedia.org/r/153964 (owner: 10Legoktm) [13:54:43] (03PS4) 10Ottomata: Update analytics role and cdh module to work with Trusty [vagrant] - 10https://gerrit.wikimedia.org/r/158791 [13:56:10] 3MediaWiki / 3Database: categorylinks InnoDB extended indexes behavior differs between enwiki slaves - 10https://bugzilla.wikimedia.org/70558 (10Sean Pringle) 3NEW p:3Unprio s:3normal a:3None The API runs the following query: SELECT /* ApiQueryCategoryMembers::run */ cl_from,cl_sortkey,cl_type,page... [13:58:38] 3MediaWiki extensions / 3ProofreadPage: WikiEditor loads in different places in the Page namespace depending upon which user preferences are selected - 10https://bugzilla.wikimedia.org/70431#c2 (10Helder) We need to check this again once Ie455009df54deecc67707779e9861daf633fc690 is live. [13:59:58] (03PS7) 10Dan-nl: GWToolset Role Additions [vagrant] - 10https://gerrit.wikimedia.org/r/158950 [14:00:11] 3MediaWiki / 3Database: categorylinks InnoDB extended indexes behavior differs between enwiki slaves - 10https://bugzilla.wikimedia.org/70558#c1 (10Sean Pringle) Wrong EXPLAIN output showing the filesort on 5.5.36+ slaves. Correct one: *************************** 1. row ***************************... [14:01:38] 3MediaWiki extensions / 3SemanticForms: SemanticForms does not work with MediaWiki 1.24 - 10https://bugzilla.wikimedia.org/70263#c5 (10Yaron Koren) Okay, cool. I'll close the bug, but - what is it that I need to change to fix the Composer problem? [14:02:39] 3MediaWiki / 3Database: categorylinks InnoDB extended indexes behavior differs between enwiki slaves - 10https://bugzilla.wikimedia.org/70558 (10Sean Pringle) a:3Sean Pringle [14:02:45] (03CR) 10Dan-nl: "* discovered that the CURLPROTO_HTTP, CURLPROTO_HTTPS, definitions also do not exist in the vagrant environment, so i hard coded the CURLO" [vagrant] - 10https://gerrit.wikimedia.org/r/158950 (owner: 10Dan-nl) [14:02:53] 3MediaWiki / 3Database: categorylinks InnoDB extended indexes behavior differs between enwiki slaves - 10https://bugzilla.wikimedia.org/70558 (10Sean Pringle) p:5Unprio>3High [14:06:55] hey csteipp, when you get a moment, i need some validation on what to do about CURLOPT_REDIR_PROTOCOLS for the vagrant environment. see https://gerrit.wikimedia.org/r/#/c/158950/ [14:07:08] 3MediaWiki extensions / 3SemanticForms: SemanticForms does not work with MediaWiki 1.24 - 10https://bugzilla.wikimedia.org/70263#c6 (10Nemo) (In reply to Yaron Koren from comment #5) > Okay, cool. I'll close the bug, but - what is it that I need to change to > fix the Composer problem? Update the package ht... [14:07:21] hey bd808|BUFFER, ori, when you have a moment, i’m trying to figure out how to add the vagrant admin user to the gwtoolset group. is there a command or sql command that takes care of that? [14:11:53] (03PS1) 10Jack Phoenix: Fix PHP Fatal error: Call to undefined function wfMessae() [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/159050 [14:12:27] (03CR) 10Jack Phoenix: [C: 032] Fix PHP Fatal error: Call to undefined function wfMessae() [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/159050 (owner: 10Jack Phoenix) [14:12:33] (03Merged) 10jenkins-bot: Fix PHP Fatal error: Call to undefined function wfMessae() [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/159050 (owner: 10Jack Phoenix) [14:14:35] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/158884 (owner: 10Paladox) [14:14:49] (03PS1) 10Jack Phoenix: Fix even more fatals [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/159051 [14:15:30] (03CR) 10Jack Phoenix: [C: 032] Fix even more fatals [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/159051 (owner: 10Jack Phoenix) [14:15:35] (03Merged) 10jenkins-bot: Fix even more fatals [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/159051 (owner: 10Jack Phoenix) [14:17:10] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/158880 (owner: 10Umherirrender) [14:19:38] 3MediaWiki extensions / 3SemanticForms: SemanticForms does not work with MediaWiki 1.24 - 10https://bugzilla.wikimedia.org/70263#c7 (10Yaron Koren) Oh, I see - I didn't know anyone was using it. I'm cc-ing Jeroen De Dauw, who is responsible for that package; although it might be better to wait to update it u... [14:28:51] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/154452 (https://bugzilla.wikimedia.org/70182) (owner: 10Umherirrender) [14:29:29] (03CR) 10Siebrand: [C: 032] Make the PHP code snippet in SkinFallbackTemplate explicitly ltr [core] - 10https://gerrit.wikimedia.org/r/158865 (owner: 10Amire80) [14:30:02] (03PS1) 10Manybubbles: Store weighted all_near_match with freqs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/159052 [14:35:23] 3Wikimedia / 3General/Unknown: 404 errors for CSS and HTML from Bits in zh-yue wikipedia - 10https://bugzilla.wikimedia.org/70557#c1 (10Andre Klapper) 5UNCO>3NEW p:5Unprio>3High Thanks for taking the time to report this! I went to https://zh-yue.wikipedia.org/wiki/%E9%A0%AD%E7%89%88?debug=true and u... [14:35:40] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/158842 (owner: 10Hiong3-eng5) [14:36:08] 3MediaWiki extensions / 3TwitterCards: Evaluate image handling/license compliance of Twitter cards - 10https://bugzilla.wikimedia.org/69941 (10Jean-Fred) [14:36:18] (03Merged) 10jenkins-bot: Make the PHP code snippet in SkinFallbackTemplate explicitly ltr [core] - 10https://gerrit.wikimedia.org/r/158865 (owner: 10Amire80) [14:36:39] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158403 (owner: 10EBernhardson) [14:37:32] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156947 (https://bugzilla.wikimedia.org/67995) (owner: 10CSteipp) [14:41:58] (03CR) 10Chad: [V: 032] Remove last of in-process caching [search/repository-swift] - 10https://gerrit.wikimedia.org/r/158908 (owner: 10Chad) [14:49:53] (03CR) 10Anomie: [C: 032] Set $wasPosted = true for recursive API access [extensions/WikiLove] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/158785 (https://bugzilla.wikimedia.org/70448) (owner: 10TheDJ) [14:49:58] (03CR) 10Anomie: [C: 032] Set $wasPosted = true for recursive API access [extensions/WikiLove] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/158786 (https://bugzilla.wikimedia.org/70448) (owner: 10TheDJ) [14:50:03] (03Merged) 10jenkins-bot: Set $wasPosted = true for recursive API access [extensions/WikiLove] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/158785 (https://bugzilla.wikimedia.org/70448) (owner: 10TheDJ) [14:50:06] (03Merged) 10jenkins-bot: Set $wasPosted = true for recursive API access [extensions/WikiLove] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/158786 (https://bugzilla.wikimedia.org/70448) (owner: 10TheDJ) [14:55:07] (03CR) 10Manybubbles: "Lets get this merged a bit early so we can deploy it first." [extensions/WikiLove] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/158786 (https://bugzilla.wikimedia.org/70448) (owner: 10TheDJ) [14:56:02] (03PS7) 10BryanDavis: [WIP] Request a global account rename [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156488 (https://bugzilla.wikimedia.org/68886) [14:56:43] (03CR) 10BryanDavis: [WIP] Request a global account rename (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156488 (https://bugzilla.wikimedia.org/68886) (owner: 10BryanDavis) [15:01:55] 3MediaWiki extensions / 3CirrusSearch: prefix: and insource: do not work at the same time - 10https://bugzilla.wikimedia.org/70560 (10Tisza Gergő) 3NEW p:3Unprio s:3normal a:3None When searching for "prefix:Template: insource:nuke" on Commons: https://commons.wikimedia.org/w/index.php?title=Special%... [15:02:38] 3Wikimedia / 3General/Unknown: 404 errors for CSS and HTML from Bits in zh-yue wikipedia - 10https://bugzilla.wikimedia.org/70557#c2 (10Giuseppe Lavagetto) While on varnish the url https://bits.wikimedia.org/zh-yue.wikipedia.org/load.php?debug=true&lang=yue&modules=site&only=scripts&skin=vector&* returns 4... [15:03:40] 3MediaWiki extensions / 3CirrusSearch: prefix: and insource: do not work at the same time - 10https://bugzilla.wikimedia.org/70560#c1 (10Nik Everett) p:5Unprio>3Normal a:3Nik Everett I'll have a look at this. Does <> work for you for now? [15:04:27] (03PS1) 10Anomie: Fix indentation in ParserOutput.php [core] - 10https://gerrit.wikimedia.org/r/159057 [15:04:38] 3MediaWiki / 3General/Unknown: When special pages are included, OutputPage::$mPreventClickjacking is not respected - 10https://bugzilla.wikimedia.org/65778#c13 (10Brad Jorsch) 5NEW>3RESO/FIX Looks like everything is merged to me. If I'm wrong, feel free to reopen. [15:04:58] (03PS1) 10Manybubbles: SWAT update WikiLove [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159058 [15:05:51] (03CR) 10Manybubbles: [C: 032] SWAT update WikiLove [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159058 (owner: 10Manybubbles) [15:05:54] 3MediaWiki / 3Interface: Redirect arrows missing SVG versions - 10https://bugzilla.wikimedia.org/70538 (10Andre Klapper) p:5Unprio>3Normal [15:06:41] (03CR) 10Jackmcbarn: [C: 032] Fix indentation in ParserOutput.php [core] - 10https://gerrit.wikimedia.org/r/159057 (owner: 10Anomie) [15:07:28] (03PS1) 10Manybubbles: SWAT update WikiLove [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159059 [15:08:16] (03CR) 10Manybubbles: [C: 032] "Merging so I can build the submodule update." [extensions/LiquidThreads] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/158617 (https://bugzilla.wikimedia.org/70412) (owner: 10Jforrester) [15:08:45] (03Merged) 10jenkins-bot: Provide own arrow images [extensions/LiquidThreads] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/158617 (https://bugzilla.wikimedia.org/70412) (owner: 10Jforrester) [15:09:10] (03PS1) 10Amire80: Don't let LTR usernames jumble RTL watchlists [core] - 10https://gerrit.wikimedia.org/r/159060 [15:09:49] (03Merged) 10jenkins-bot: SWAT update WikiLove [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159058 (owner: 10Manybubbles) [15:10:28] (03CR) 10Anomie: [C: 032] Chunked upload result should consistently have a "stage" value for "Poll" [core] - 10https://gerrit.wikimedia.org/r/158593 (owner: 10Gilles) [15:12:33] (03PS1) 10Aude: Update Wikidata, fix add links widget and other projects beta feature [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159064 [15:13:16] (03CR) 10Anomie: [C: 032] "Is figuring out the "Bug:" footer really that hard?" [core] - 10https://gerrit.wikimedia.org/r/156274 (https://bugzilla.wikimedia.org/64238) (owner: 10Petrb) [15:13:23] 3MediaWiki extensions / 3TwnMainPage: List of messages in the the translation view does not appear in Firefox - 10https://bugzilla.wikimedia.org/66414 (10Željko Filipin) [15:13:35] anomie: :-) [15:13:56] (03CR) 10jenkins-bot: [V: 04-1] Fix indentation in ParserOutput.php [core] - 10https://gerrit.wikimedia.org/r/159057 (owner: 10Anomie) [15:14:45] (03PS3) 10Jackmcbarn: Prefer earlier potential sections in summaries [core] - 10https://gerrit.wikimedia.org/r/147362 [15:14:51] (03PS4) 10Jackmcbarn: Prefer earlier potential sections in summaries [core] - 10https://gerrit.wikimedia.org/r/147362 (https://bugzilla.wikimedia.org/68361) [15:15:01] (03CR) 10Anomie: [C: 032] "Sigh. Resubmitting because of bogus quint failure." [core] - 10https://gerrit.wikimedia.org/r/159057 (owner: 10Anomie) [15:15:26] (03PS1) 10Aude: Update Wikidata, fix add links widget and other projects feature [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159066 [15:16:12] (03PS1) 10Raimond Spekking: Change i18n to JSON [extensions/Tooltip] - 10https://gerrit.wikimedia.org/r/159067 [15:16:40] 3MediaWiki extensions / 3LiquidThreads: LQT: [Regression 1.24wmf20] Pagination arrows have been moved - 10https://bugzilla.wikimedia.org/70412#c8 (10Jesús Martínez Novo (Ciencia Al Poder)) 5PATC>3RESO/FIX Patch merged and I also tested it on my local master [15:16:57] (03Merged) 10jenkins-bot: Chunked upload result should consistently have a "stage" value for "Poll" [core] - 10https://gerrit.wikimedia.org/r/158593 (owner: 10Gilles) [15:17:25] (03PS1) 10Manybubbles: SWAT update liquidthreads [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159068 [15:20:08] 3Wikimedia / 3Site requests: $wgSVGMaxSize is too low - 10https://bugzilla.wikimedia.org/70529#c2 (10Andre Klapper) p:5Unprio>3Normal Wondering if this would have any performance impact... [15:20:20] (03CR) 10Manybubbles: [C: 032] SWAT update WikiLove [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159059 (owner: 10Manybubbles) [15:20:32] (03Merged) 10jenkins-bot: API: created a new api to flag messages as read [core] - 10https://gerrit.wikimedia.org/r/156274 (https://bugzilla.wikimedia.org/64238) (owner: 10Petrb) [15:20:38] 3MediaWiki extensions / 3CirrusSearch: prefix: and insource: do not work at the same time - 10https://bugzilla.wikimedia.org/70560#c2 (10Tisza Gergő) (In reply to Nik Everett from comment #1) > Does <> work for you for now? That works, thanks! [15:21:16] (03PS2) 10Raimond Spekking: Change i18n to JSON [extensions/Tooltip] - 10https://gerrit.wikimedia.org/r/159067 [15:21:37] 3MediaWiki / 3ResourceLoader: [Regression] Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c23 (10Andre Klapper) Krinkle: So is there some conclusion what should be done here, and by who? [15:22:11] (03PS1) 10Jack Phoenix: Got rid of the $dir variable in favor of __DIR__ [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/159069 [15:22:13] (03CR) 10jenkins-bot: [V: 04-1] Fix indentation in ParserOutput.php [core] - 10https://gerrit.wikimedia.org/r/159057 (owner: 10Anomie) [15:22:14] ...really? [15:22:23] 3MediaWiki extensions / 3CentralAuth: login when already logged in gets exception from Special:CentralLogin - 10https://bugzilla.wikimedia.org/69834#c13 (10Andre Klapper) Patch got a +1 by legoktm; is more needed or can this get merged? [15:22:26] (03PS2) 10Jackmcbarn: Fix indentation in ParserOutput.php [core] - 10https://gerrit.wikimedia.org/r/159057 (owner: 10Anomie) [15:23:00] (03CR) 10Jack Phoenix: [C: 032] Got rid of the $dir variable in favor of __DIR__ [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/159069 (owner: 10Jack Phoenix) [15:23:08] 3MediaWiki / 3API: No way to flag your talk page as read - 10https://bugzilla.wikimedia.org/64238#c6 (10Brad Jorsch) 5PATC>3RESO/FIX (In reply to Gerrit Notification Bot from comment #5) > Change 156274 merged by jenkins-bot: > API: created a new api to flag messages as read > > https://gerrit.wikimedia... [15:23:10] (03CR) 10Jackmcbarn: Fix indentation in ParserOutput.php [core] - 10https://gerrit.wikimedia.org/r/159057 (owner: 10Anomie) [15:23:14] (03CR) 10Jackmcbarn: [C: 032] Fix indentation in ParserOutput.php [core] - 10https://gerrit.wikimedia.org/r/159057 (owner: 10Anomie) [15:23:22] (03Merged) 10jenkins-bot: SWAT update WikiLove [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159059 (owner: 10Manybubbles) [15:23:49] (03Merged) 10jenkins-bot: Got rid of the $dir variable in favor of __DIR__ [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/159069 (owner: 10Jack Phoenix) [15:25:08] 3MediaWiki extensions / 3Translate: Translation information under the page title is too obtrusive - 10https://bugzilla.wikimedia.org/51533#c26 (10Andre Klapper) Kunal: Would be awesome if you could share your plans here. If you think that you (realistically) have time to continue working on this, feel free t... [15:25:48] (03CR) 10Manybubbles: [C: 032] SWAT update liquidthreads [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159068 (owner: 10Manybubbles) [15:26:52] 3Wikimedia / 3General/Unknown: internal_api_error_DBQueryError on page edit; db1024 - 10https://bugzilla.wikimedia.org/70221#c7 (10Andre Klapper) (In reply to Brad Jorsch from comment #6) > The error itself was coming from the database layer, although the base > cause for the lock wait timeout might be else... [15:27:23] 3Wikimedia / 3Site requests: Disable Media Viewer by default for logged-in users on Wikimedia Commons - 10https://bugzilla.wikimedia.org/69363#c10 (10Andre Klapper) (In reply to Tisza Gergő from comment #8) > Fixed in https://gerrit.wikimedia.org/r/#/c/156004/ , needs DB cleanup. Tisza: Who's going to do th... [15:30:00] (03Merged) 10jenkins-bot: Fix indentation in ParserOutput.php [core] - 10https://gerrit.wikimedia.org/r/159057 (owner: 10Anomie) [15:30:02] (03Merged) 10jenkins-bot: SWAT update liquidthreads [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159068 (owner: 10Manybubbles) [15:30:26] 3MediaWiki / 3ResourceLoader: [Regression] Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c24 (10Krinkle) 5NEW>3ASSI a:3Krinkle I've proposed various solutions. None of which are field-tested, best practice and known to work cross-browser... [15:31:08] 3Wikimedia / 3Site requests: Disable Media Viewer by default for logged-in users on Wikimedia Commons - 10https://bugzilla.wikimedia.org/69363#c11 (10Tisza Gergő) (In reply to Andre Klapper from comment #10) > Tisza: Who's going to do the DB cleanup (and when)? Someone from the Multimedia team will do this.... [15:33:11] (03PS1) 10Jack Phoenix: Fix a few links [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/159071 [15:33:23] 3MediaWiki extensions / 3LiquidThreads: LQT: [Regression 1.24wmf20] Pagination arrows have been moved - 10https://bugzilla.wikimedia.org/70412#c9 (10James Forrester) Fixed and deployed. [15:33:29] (03CR) 10Jack Phoenix: [C: 032] Fix a few links [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/159071 (owner: 10Jack Phoenix) [15:33:34] (03Merged) 10jenkins-bot: Fix a few links [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/159071 (owner: 10Jack Phoenix) [15:33:39] 3MediaWiki extensions / 3LiquidThreads: LQT: [Regression 1.24wmf20] Pagination arrows have been moved - 10https://bugzilla.wikimedia.org/70412 (10Nik Everett) 5RESO/?>3VERI [15:33:39] 3MediaWiki extensions / 3LiquidThreads: LQT: [Regression 1.24wmf20] Pagination arrows have been moved - 10https://bugzilla.wikimedia.org/70412#c10 (10Nik Everett) Verified after deploy to mediawiki.org [15:34:25] (03CR) 10Manybubbles: [C: 032] Update Wikidata, fix add links widget and other projects feature [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159066 (owner: 10Aude) [15:36:40] 3MediaWiki extensions / 3CirrusSearch: Accents are not ignored by autocompletion in fr.wiktionary - 10https://bugzilla.wikimedia.org/70561 (10automatik68) 3UNCO p:3Unprio s:3normal a:3None Hi. The search http://fr.wiktionary.org/w/api.php?action=opensearch&format=json&namespace=0&search=gr%C3%AAlo d... [15:38:09] (03Merged) 10jenkins-bot: Update Wikidata, fix add links widget and other projects feature [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159066 (owner: 10Aude) [15:38:23] 3MediaWiki extensions / 3CirrusSearch: Accents are not ignored by autocompletion in fr.wiktionary - 10https://bugzilla.wikimedia.org/70561#c1 (10Nik Everett) Its a reasonably easy thing to turn on but right now its only on in English. We can turn it on if its the right thing. [15:39:57] dan-nl: What we've done for most permissions things in vagrant that I can think of is grant the needed permission to an existing group that Admin is in. I'll look for an example. [15:40:29] so add gwtoolset to sysop? [15:40:47] dan-nl: Yeah. Like https://github.com/wikimedia/mediawiki-vagrant/blob/master/puppet/modules/role/manifests/centralauth.pp#L35-L41 [15:40:56] i think i tried that eralier … will try again now … thanks for the link [15:42:32] bd808: do you happen to have any ideas on CURLOPT_REDIR_PROTOCOLS ? [15:42:51] dan-nl: I wonder if that's an HHVM issue. [15:43:39] bd808: i think that makes sense … defininig it in the settings file takes care of the issue, but i don't want to open a security hole because of it [15:44:26] The only place I can find that string in the hhvm repo is -- https://github.com/facebook/hhvm/blob/07f8201682818abdcc0aa581c9eaa991b2b04965/hphp/runtime/ext_zend_compat/oauth/php_oauth.h#L352 [15:45:53] 3MediaWiki extensions / 3CirrusSearch: Accents are not ignored by autocompletion in fr.wiktionary - 10https://bugzilla.wikimedia.org/70561#c2 (10Nik Everett) Another thing - the behavior if I turn on accent ignoring is wider then just autocomplete - its in search as well. When that is done perfect accent ma... [15:46:54] bd808: in the php manual, there's a list of the options available. in the vagrant instance none of them are defined. http://php.net/manual/en/function.curl-setopt.php search for CURLOPT_REDIR_PROTOCOLS [15:48:15] would it make sense to define them in one of the puppet settings files? [15:49:11] dan-nl: I think they need to be fixed in https://github.com/facebook/hhvm/blob/master/hphp/runtime/ext/curl/ext_curl.cpp [15:49:55] bd808: and those are just from libcurl. http://curl.haxx.se/libcurl/c/symbols-in-versions.html [15:50:32] valhallasw: Yeah. but they need to be exposed into the hhvm runtime as defines [15:50:52] (03PS1) 10Smuggli: Fixed call on no object [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/159075 [15:50:54] sure. [15:50:57] dan-nl: If you open a bug here and add the "hiphop" keyword to it we might be able to find someone to take a look. And/or you could open an upstream bug with hhvm [15:51:35] bd808 k, i'll see what i can write-up. thanks [15:51:55] Making a unit test that checks all of the defines that php 5.5 exports for curl would be an awesome place to start [15:52:12] andre__: do you know if the gadget BugStatusUpdate will continue to work after the move to Phabricator? [15:52:23] 3MediaWiki extensions / 3CirrusSearch: Accents are not ignored by autocompletion in fr.wiktionary - 10https://bugzilla.wikimedia.org/70561#c3 (10automatik68) In search, this behavior seems to be ever turned on: https://fr.wiktionary.org/w/index.php?title=Sp%C3%A9cial%3ARecherche&profile=default&search=gr%C3%... [15:52:28] Does anyone know how to fix it to work with the new system too? [15:52:37] code: https://en.wikipedia.org/wiki/MediaWiki:Gadget-BugStatusUpdate.js [15:53:20] helderwiki: somebody will need to fix it... See http://fab.wmflabs.org/T285 [15:53:23] 3MediaWiki extensions / 3CirrusSearch: Accents are not ignored by autocompletion in fr.wiktionary - 10https://bugzilla.wikimedia.org/70561#c4 (10automatik68) ever->already* [15:53:27] Help very welcome [15:55:23] 3MediaWiki extensions / 3CirrusSearch: Accents are not ignored by autocompletion in fr.wiktionary - 10https://bugzilla.wikimedia.org/70561#c5 (10Nik Everett) 5UNCO>3NEW Hmmm...... I'll investigate that - since no one has complained about that behavior I imagine its correct or at least ok. Either way -... [15:59:44] (03CR) 10BryanDavis: WikimediaMessages Role (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/158922 (owner: 10Dan-nl) [16:00:38] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: HTMLFeatureFieldTest should set $wgWellFormedXml - 10https://bugzilla.wikimedia.org/68823 (10Krinkle) [16:01:07] hoo: any chance of porting this to labs? https://meta.wikimedia.org/w/index.php?title=User_talk:Krinkle/Le_Tour_de_Wikí/2011_Resource_Walker#Global_page_history [16:01:41] helderwiki: It's on my list... but well, I don't really have a lot of time for such stuff these days :( [16:02:00] so much work on admin tools needed (despite the Wikidata stuff I'm doing) [16:02:25] ok [16:03:08] is "your list" in a wiki page/bugtracker wich I could watch? [16:04:15] helderwiki: Nope [16:08:01] (03PS1) 10Manybubbles: Shrink the weighted all field's positions [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/159079 [16:09:50] (03Restored) 10Krinkle: Always quote attribute values ending in a backslash [core] - 10https://gerrit.wikimedia.org/r/67603 (https://bugzilla.wikimedia.org/49232) (owner: 10Daniel Friesen) [16:11:22] Krinkle: given that 'mediawiki.api.edit' depends on 'mediawiki.api', in principle a script which uses postWithEditToken could add have only 'mediawiki.api.edit' as a dependency, but the script will also be using mw.Api from 'mediawiki.api', so it also depends on this module. Is it recommended to add this dependency explicitly or assume that the dependency 'mediawiki.api.edit->mediawiki.api' will never be removed? [16:11:42] Specific use case: https://gerrit.wikimedia.org/r/#/c/158664 [16:12:28] helderwiki: depend on what you use. [16:12:37] I guess that if you don't use mediawiki.api explicitly, you shouldn't require it, and let RL resolve dependencies [16:12:45] helderwiki: the edit methods are public, so their identifier is not going to change without a breaking change. [16:12:53] That means it has to be inside mw.Api [16:13:05] so if you only use methods provided by the edit plugin, that's fine. [16:13:19] But if you use mw.Api ajax, get, post, getToken etc. then depend on mediawiki.api [16:13:58] The change above uses api.post [16:14:14] so a follow-up would be good [16:14:34] you can assume mw.Api exists because mw.Api#newSection is the public interface to it. [16:14:40] (03PS8) 10Dan-nl: GWToolset Role Additions [vagrant] - 10https://gerrit.wikimedia.org/r/158950 [16:14:48] But if you use mw.Api base methods directly in your code, then also depend on mediawiki.api [16:15:01] so you can assume mw.Api exists but not mediawiki.api's public methods in general. [16:15:25] makes sense [16:15:34] Wanna add a follow up? [16:15:45] yep [16:15:49] I'll do that soon [16:16:05] do we have any special commit message for these? [16:16:14] (to link the changes somehow) [16:16:28] (03CR) 10Dan-nl: "* restored the $wgGroupPermissions values to make sure the default “Admin” account has access to Special:GWToolset." [vagrant] - 10https://gerrit.wikimedia.org/r/158950 (owner: 10Dan-nl) [16:18:05] (03PS15) 10Matthias Mullie: [WIP] search [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126996 [16:19:51] (03CR) 10Anomie: [C: 031] "Let's throw an nbsp into the unit test for this function, too." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/158872 (https://bugzilla.wikimedia.org/70475) (owner: 10Jackmcbarn) [16:22:29] (03CR) 10Isarra: "SPQRobin, legoktm: Could you guys take a look at this again, please? I really would like to see this merged this year, unless there's some" [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/147755 (https://bugzilla.wikimedia.org/68241) (owner: 10Isarra) [16:23:12] "this year" Those are very optimistic expectations :P [16:25:10] 3MediaWiki extensions / 3CirrusSearch: Accents are not ignored by autocompletion in fr.wiktionary - 10https://bugzilla.wikimedia.org/70561#c6 (10automatik68) I'm not sure what you mean by "no one complained" but I opened this bug after this point: https://fr.wiktionary.org/wiki/Wiktionnaire:Wikid%C3%A9mie/se... [16:25:52] (03PS1) 10Helder.wiki: Add dependency on 'mediawiki.api' [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/159082 [16:26:30] (03CR) 10BryanDavis: GWToolset Role Additions (032 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/158950 (owner: 10Dan-nl) [16:28:59] (03CR) 10Anomie: [C: 032] Set vary-revision appropriately with getContent() [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/158775 (owner: 10Jackmcbarn) [16:30:04] Vulpix: Not really... still like three months to go and legoktm is normally pretty good at reviewing code when asked. [16:30:35] Lcawte: I wasn't serious! [16:30:57] (03Merged) 10jenkins-bot: Set vary-revision appropriately with getContent() [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/158775 (owner: 10Jackmcbarn) [16:31:50] Vulpix: ok :P [16:33:12] (03CR) 10Krinkle: "Filed bug 69924." [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/155643 (owner: 10Ori.livneh) [16:43:23] 3MediaWiki / 3Uploading: PHP Fatal error: Call to a member function parseParamString() on a non-object in SpecialUploadStash.php on line 137 - 10https://bugzilla.wikimedia.org/53820#c10 (10Gilles Dubuc) 5ASSI>3RESO/WOR No trace of the exception in the last 30 days on logstash nor in the fluorine archives... [16:45:33] (03PS1) 10Helder.wiki: Use $.ready [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/159084 [16:46:53] (03CR) 10Legoktm: [C: 032] Don't do central login if not POSTed [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/158547 (https://bugzilla.wikimedia.org/69834) (owner: 10CSteipp) [16:47:09] (03CR) 10Anomie: [C: 032] Only set indexOffset when the function name is indexed [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/158890 (owner: 10Jackmcbarn) [16:47:27] (03Merged) 10jenkins-bot: Don't do central login if not POSTed [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/158547 (https://bugzilla.wikimedia.org/69834) (owner: 10CSteipp) [16:48:23] 3Wikimedia / 3General/Unknown: 404 errors for CSS and HTML from Bits in zh-yue wikipedia - 10https://bugzilla.wikimedia.org/70557#c3 (10Giuseppe Lavagetto) 5NEW>3PATC A patch for the problem has been created: https://gerrit.wikimedia.org/r/#/c/159080/ [16:48:25] 3MediaWiki extensions / 3Translate: Translation information under the page title is too obtrusive - 10https://bugzilla.wikimedia.org/51533#c27 (10kunalgrover05) a:3kunalgrover05 I am still willing to work on this. The latest patch fixed the Low and medium priority bugs pointed by Pau. The first implementat... [16:49:04] (03Merged) 10jenkins-bot: Only set indexOffset when the function name is indexed [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/158890 (owner: 10Jackmcbarn) [16:51:25] 3MediaWiki extensions / 3MassMessage: MassMessage: Integrate Wikidata sitelinks for building target lists - 10https://bugzilla.wikimedia.org/70563 (10Keegan Peterzell) 3NEW p:3Unprio s:3enhanc a:3None MassMessages are usually sent to one or both of two groups: self-selected sign up by users, or commu... [16:53:23] 3MediaWiki extensions / 3MassMessage: MassMessage: Integrate Wikidata sitelinks for building target lists - 10https://bugzilla.wikimedia.org/70563 (10Kunal Mehta (Legoktm)) p:5Unprio>3Normal [16:54:10] 3MediaWiki extensions / 3CentralAuth: login when already logged in gets exception from Special:CentralLogin - 10https://bugzilla.wikimedia.org/69834#c15 (10Kunal Mehta (Legoktm)) I was hoping someone else more familiar with auth stuff would look at it but I guess not. Flagging for backport... [16:55:59] (03CR) 10PiRSquared17: "What needs to be done?" [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/134043 (https://bugzilla.wikimedia.org/38367) (owner: 10Gerrit Patch Uploader) [16:57:02] (03PS5) 10Ori.livneh: Update analytics role and cdh module to work with Trusty [vagrant] - 10https://gerrit.wikimedia.org/r/158791 (owner: 10Ottomata) [16:57:06] (03CR) 10Ori.livneh: [C: 032] Update analytics role and cdh module to work with Trusty [vagrant] - 10https://gerrit.wikimedia.org/r/158791 (owner: 10Ottomata) [16:57:11] (03Merged) 10jenkins-bot: Update analytics role and cdh module to work with Trusty [vagrant] - 10https://gerrit.wikimedia.org/r/158791 (owner: 10Ottomata) [16:57:28] (03CR) 10PiRSquared17: [C: 031] "This has been open since April." [core] - 10https://gerrit.wikimedia.org/r/129095 (https://bugzilla.wikimedia.org/45221) (owner: 10Gerrit Patch Uploader) [16:58:13] (03CR) 10PiRSquared17: "Qgil: Erik could do it. I'm not sure what more there is to be done here." [extensions/timeline] - 10https://gerrit.wikimedia.org/r/130027 (https://bugzilla.wikimedia.org/4) (owner: 10Gerrit Patch Uploader) [16:58:41] (03CR) 10PiRSquared17: "Probably the PHP needs to be fixed to meet standards, but I think the Perl is OK." [extensions/timeline] - 10https://gerrit.wikimedia.org/r/130027 (https://bugzilla.wikimedia.org/4) (owner: 10Gerrit Patch Uploader) [17:00:33] (03CR) 10Legoktm: [C: 04-1] Document Special:Diff and Special:PermanentLink (034 comments) [core] - 10https://gerrit.wikimedia.org/r/129095 (https://bugzilla.wikimedia.org/45221) (owner: 10Gerrit Patch Uploader) [17:01:00] (03CR) 10Swalling: [C: 031] "Tested in Chrome, Firefox, and Safari." [skins/Vector] - 10https://gerrit.wikimedia.org/r/157990 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [17:01:15] (03PS1) 10Raimond Spekking: Change i18n to JSON [extensions/RPED] - 10https://gerrit.wikimedia.org/r/159085 [17:02:03] (03PS1) 10Krinkle: resourceloader: Do condition wrap in HTML instead of JS response [core] - 10https://gerrit.wikimedia.org/r/159086 (https://bugzilla.wikimedia.org/69924) [17:02:09] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: HTMLFeatureFieldTest should set $wgWellFormedXml - 10https://bugzilla.wikimedia.org/68823 (10Nemo) [17:02:12] (03CR) 10Ori.livneh: [C: 031] "Code looks fine." [skins/Vector] - 10https://gerrit.wikimedia.org/r/157990 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [17:02:37] (03CR) 10Dan-nl: "* answered bryan’s comment in ps3" (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/158922 (owner: 10Dan-nl) [17:02:53] 3MediaWiki extensions / 3CirrusSearch: Accents are not ignored by autocompletion in fr.wiktionary - 10https://bugzilla.wikimedia.org/70561#c7 (10Nik Everett) Sorry, I mean search flattening the accents didn't receive any complaints when we turned CirrusSearch on for frwiktionary a few months ago. At least I... [17:04:38] 3MediaWiki / 3Parser: ins or del 1st occurrence in blockquote causes bogus newline - 10https://bugzilla.wikimedia.org/15491#c14 (10ssastry) (In reply to C. Scott Ananian from comment #8) > On the other hand, if bug 6200 is fixed, the parser output would be: > >

Foo bar baz (03CR) 10BryanDavis: WikimediaMessages Role (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/158922 (owner: 10Dan-nl) [17:05:10] (03PS4) 10BryanDavis: WikimediaMessages Role [vagrant] - 10https://gerrit.wikimedia.org/r/158922 (owner: 10Dan-nl) [17:05:21] (03CR) 10BryanDavis: [C: 032] WikimediaMessages Role [vagrant] - 10https://gerrit.wikimedia.org/r/158922 (owner: 10Dan-nl) [17:05:26] (03Merged) 10jenkins-bot: WikimediaMessages Role [vagrant] - 10https://gerrit.wikimedia.org/r/158922 (owner: 10Dan-nl) [17:10:07] WikimediaMassages [massage] i have a free massage slot at office. want? [17:12:31] (03CR) 10Jack Phoenix: [C: 032] Remove unused qqq keys [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/159020 (owner: 10Legoktm) [17:12:34] (03CR) 10Jack Phoenix: [C: 032] Clean up SkinTemplateNavigationUniversal hook [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/159018 (https://bugzilla.wikimedia.org/70506) (owner: 10Legoktm) [17:12:38] (03CR) 10Jack Phoenix: [C: 032] Generalize all ShoutWiki-specific messages [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/159019 (owner: 10Legoktm) [17:13:27] (03CR) 10Jack Phoenix: [C: 032] Remove unused GlobalUserPage::isSourcePage() [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/159017 (owner: 10Legoktm) [17:14:02] lol [17:19:55] (03PS2) 10Krinkle: resourceloader: Condition-wrap the HTML tag instead of JS response [core] - 10https://gerrit.wikimedia.org/r/159086 (https://bugzilla.wikimedia.org/69924) [17:20:27] 3Wikimedia / 3Site requests: Remove namespace alias on ckb wikipedia - 10https://bugzilla.wikimedia.org/70564 (10Calak) 3NEW p:3Unprio s:3normal a:3None Please remove "MW" and "C" namespace alias on ckb wikipedia. They are same with interwikimedia links for Mediawiki ([[mw:]]) and Commons ([[c:]]) an... [17:21:34] (03CR) 10MaxSem: [C: 031] Add globaluserpage role [vagrant] - 10https://gerrit.wikimedia.org/r/158610 (owner: 10Legoktm) [17:22:08] 3Wikimedia / 3Site requests: Remove namespace alias on ckb wikipedia - 10https://bugzilla.wikimedia.org/70564 (10Calak) p:5Unprio>3Normal [17:22:17] (03PS9) 10MaxSem: GWToolset Role Additions [vagrant] - 10https://gerrit.wikimedia.org/r/158950 (owner: 10Dan-nl) [17:23:47] tgr: What do you think about https://gerrit.wikimedia.org/r/#/c/107368/ [17:24:59] (03PS10) 10Dan-nl: GWToolset Role Additions [vagrant] - 10https://gerrit.wikimedia.org/r/158950 [17:25:11] kaldari: did you see my comment on the related bug? [17:25:31] tgr: Oh, I missed that... [17:26:01] (03PS6) 10BryanDavis: Add globaluserpage role [vagrant] - 10https://gerrit.wikimedia.org/r/158610 (owner: 10Legoktm) [17:26:08] (03CR) 10BryanDavis: [C: 032] Add globaluserpage role [vagrant] - 10https://gerrit.wikimedia.org/r/158610 (owner: 10Legoktm) [17:26:14] (03Merged) 10jenkins-bot: Add globaluserpage role [vagrant] - 10https://gerrit.wikimedia.org/r/158610 (owner: 10Legoktm) [17:26:19] (03CR) 10Dan-nl: "* addressed the comments bd808 made in ps8." (032 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/158950 (owner: 10Dan-nl) [17:27:00] (03CR) 10Spage: "If this addresses" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155214 (owner: 10SG) [17:29:57] (03PS1) 10EBernhardson: Use variable instead of hardcoded permission [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159088 [17:30:14] (03Abandoned) 10EBernhardson: Use variable instead of hardcoded permission [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159088 (owner: 10EBernhardson) [17:30:57] andre__, chasemp just checking whether fab is going down soon? [17:31:08] I habe engineering management meeting right now, and someone might ask [17:31:11] have! [17:32:27] er, is it actually doing down or being locked? [17:32:39] qgil: earliest in 30min, but yeah, that should happen today [17:32:44] legoktm, we cannot easily lock it [17:32:48] I have a meeting in 30, was planning on it post that meeting [17:33:09] sooo...we just gave a bunch of people links to fab.wmflabs to learn about the timeline of the migration, but now that link won't work? [17:34:17] (03CR) 10Jack Phoenix: [C: 032] Use Config instead of globals, part #1 [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/159012 (owner: 10Legoktm) [17:34:21] yeah, I might mirror that specific timeline on the Phab page on mediawiki.org [17:34:31] (03Merged) 10jenkins-bot: Use Config instead of globals, part #1 [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/159012 (owner: 10Legoktm) [17:34:50] andre__, thank you [17:34:57] (03PS4) 10Krinkle: Make profile icon gender neutral and remove from login link in Vector [skins/Vector] - 10https://gerrit.wikimedia.org/r/157990 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [17:34:58] ok. I'm just a bit concerned that we were tracking tasks necessary for hte migration on fab.wmflabs, but now no one can see which tasks still need things done until it's too late? [17:35:28] that [17:36:11] Correct. In hindsight it wasn't the greatest idea technically to use that Labs instance. Socially it was good for dogfood'ing [17:36:27] trivia: did anyone else noticed that phabricator's default avatar is a Psyduck? [17:36:32] yep [17:36:45] I learned about this in some fab task [17:37:10] 3MediaWiki / 3Unit tests: Invalid token issue when adding links to Wikidata via wiki splash screen - 10https://bugzilla.wikimedia.org/70566 (10superyetkin) 3UNCO p:3Unprio s:3normal a:3None Trying to add a link to Wikidata (through "add link" link on the bottom left) ends up with the following error.... [17:37:22] 3MediaWiki extensions / 3GlobalUserPage: Figure out what to do with tabs on global user pages - 10https://bugzilla.wikimedia.org/70506 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX [17:37:23] hah, and that was supposed to make me end up on pokemon wiki? [17:37:54] Phabricator.org used to be quite filled with Pokémon references... [17:37:55] (03CR) 10Krinkle: "Removed redundant doctype and a bunch of more spurious attributes." [skins/Vector] - 10https://gerrit.wikimedia.org/r/157990 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [17:38:01] (03PS5) 10Krinkle: Make profile icon gender neutral and remove from login link in Vector [skins/Vector] - 10https://gerrit.wikimedia.org/r/157990 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [17:38:23] platypuses are cool though [17:38:25] I wasn't aware of that :P [17:38:52] last link under docs http://phabricator.org/support/ [17:38:54] 3MediaWiki extensions / 3WikidataClient: "Invalid token" error when trying to add language link from Wikipedia - 10https://bugzilla.wikimedia.org/70415#c16 (10Kunal Mehta (Legoktm)) *** Bug 70566 has been marked as a duplicate of this bug. *** [17:38:54] 3MediaWiki / 3Unit tests: Invalid token issue when adding links to Wikidata via wiki splash screen - 10https://bugzilla.wikimedia.org/70566#c1 (10Kunal Mehta (Legoktm)) 5UNCO>3RESO/DUP *** This bug has been marked as a duplicate of bug 70415 *** [17:39:08] (03CR) 10BryanDavis: "Inline comments about tabs vs spaces and HHVM workaround." (032 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/158950 (owner: 10Dan-nl) [17:39:16] andre__: okay so, how are people supposed to track the migration once fab.wmflabs goes down? Import to bugzilla? ;) [17:39:30] what is there to exactly track? :) [17:39:41] nice, there is a whole section of links to bulbapedia :o [17:40:10] andre__: all the blockers of http://fab.wmflabs.org/T282 ? [17:40:16] legoktm: we don't have any progress bar for that, no matter if fab.wmflabs.org is up or not :) [17:40:16] mutante: it's exactly that http://img3.wikia.nocookie.net/es.pokemon/images/2/28/Psyduck_NB.png [17:40:54] Vulpix: yea:) http://bulbapedia.bulbagarden.net/wiki/Psyduck_%28Pok%C3%A9mon%29 [17:41:25] legoktm: For T553 you could follow the upstream ticket. For T560 you could floow the RT ticket. Folks in #wikimedia-devtools can answer questions. [17:41:31] It's not a great situation, I know. [17:41:38] I'd prefer read-only but Phab does not allow that easily. [17:41:44] TIL that's a channel :( [17:42:45] (03PS1) 10Raimond Spekking: Change i18n to JSON [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/159090 [17:42:47] copy/paste to etherpad? shrug [17:42:49] <^d> eswiki abusefilter! [17:42:55] * ^d finds a rock to throw [17:43:12] <^d> "PRUEBAS - Caracteres gráficos, emoticonos y arte ASCII" [17:43:58] u mad [17:44:18] don't add smileys? [17:44:29] ^ [17:44:31] <^d> I wasn't :p [17:44:49] anything is ASCII art :p [17:47:03] (03CR) 10MaxSem: "1) It seems thatthe dumps should be in files/gwtoolset instead of files/commons." [vagrant] - 10https://gerrit.wikimedia.org/r/158950 (owner: 10Dan-nl) [17:48:14] (03CR) 10Chad: [C: 032] Update Wikidata, fix add links widget and other projects beta feature [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159064 (owner: 10Aude) [17:48:22] :) [17:49:22] (03PS11) 10Dan-nl: GWToolset Role Additions [vagrant] - 10https://gerrit.wikimedia.org/r/158950 [17:50:14] (03CR) 10Dan-nl: "* replaced the 2 space tabs in the .php.erb file with tabs per bd808’s comment in ps8." (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/158950 (owner: 10Dan-nl) [17:51:06] (03PS1) 10EBernhardson: Use variable instead of hardcoded permission [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159092 [17:51:08] 3MediaWiki extensions / 3WikidataRepo: not possible to remove sitelinks using Special:SetSitelink - 10https://bugzilla.wikimedia.org/62707 (10Bene*) p:5Low>3High [17:51:39] 3MediaWiki extensions / 3BetaFeatures: With JavaScript disabled, BetaFeatures's "this feature requires javascript" labels are absent - 10https://bugzilla.wikimedia.org/69779#c3 (10James Forrester) 5UNCO>3RESO/INV Appears to not be the case? [17:51:46] (03Merged) 10jenkins-bot: Update Wikidata, fix add links widget and other projects beta feature [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159064 (owner: 10Aude) [17:53:28] MaxSem, i placed the dumps in files/commons because that's where the dumps come from. would you rather that i switch to files/gwtoolset/ ? [17:53:52] (03CR) 10Chad: "This is completely untested." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/158771 (owner: 10Chad) [17:54:10] the subdirectories of files/ seem to be called after roles using them [17:54:42] MaxSem, k, i'll make the change [17:55:05] MaxSem: place the readme in that folder with the URLs to the pages that were dumped? [17:55:24] yes [17:55:45] dan-nl, or rather their titles... [17:55:54] k [17:56:10] so that you could just update by pasting the names into SPecial:Export [17:56:47] (03CR) 10Bsitu: "Hi Legoktm," [extensions/Echo] - 10https://gerrit.wikimedia.org/r/157029 (owner: 10Bsitu) [17:56:56] (03CR) 10Bartosz Dziewoński: [C: 032] "I was wondering if there is a better module to add this style to than mediawiki.legacy.shared, but the Linker::userLink() function (which " [core] - 10https://gerrit.wikimedia.org/r/159060 (owner: 10Amire80) [17:58:25] 3MediaWiki / 3General/Unknown: The document contains errors. Are you sure you want to save? - 10https://bugzilla.wikimedia.org/70567 (10Stryn) 3NEW p:3Unprio s:3normal a:3None When I've made some edits on my javasript file, and it contains some errors, and then I click "show changes" or "preview" (do... [17:59:23] 3MediaWiki / 3General/Unknown: When previeving .js file getting a message "The document contains errors. Are you sure you want to save?" - 10https://bugzilla.wikimedia.org/70567 (10Stryn) [17:59:55] (03CR) 10MaxSem: [C: 032] Revert "Set _SERVER['REMOTE_ADDR'] in cli mode" [vagrant] - 10https://gerrit.wikimedia.org/r/158557 (owner: 10Chad) [18:00:00] (03Merged) 10jenkins-bot: Revert "Set _SERVER['REMOTE_ADDR'] in cli mode" [vagrant] - 10https://gerrit.wikimedia.org/r/158557 (owner: 10Chad) [18:00:10] 3MediaWiki / 3General/Unknown: When previewing .js file after changes made getting a message "The document contains errors. Are you sure you want to save?" - 10https://bugzilla.wikimedia.org/70567 (10Stryn) [18:03:18] (03Merged) 10jenkins-bot: Don't let LTR usernames jumble RTL watchlists [core] - 10https://gerrit.wikimedia.org/r/159060 (owner: 10Amire80) [18:04:55] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: Some beta features are incorrectly reporting javascript is need (when it is already enabled) - 10https://bugzilla.wikimedia.org/70371#c1 (10James Forrester) 5NEW>3ASSI a:3James Forrester Can't quite work out what's going wrong here, so am putting in... [18:06:41] (03PS1) 10Jforrester: Hide the 'JavaScript needed' warning reliably [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/159098 (https://bugzilla.wikimedia.org/70371) [18:06:55] (03PS1) 10Cscott: Use `/etc/mw-collection-ocg.js` configuration file if present. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/159099 [18:06:57] (03PS1) 10Cscott: Ensure that default temp and output directories exist. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/159100 [18:06:59] (03PS1) 10Cscott: Clarify README with local development instructions. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/159101 [18:08:53] 3Wikimedia / 3General/Unknown: 404 errors for CSS and HTML from Bits in zh-yue wikipedia - 10https://bugzilla.wikimedia.org/70557#c4 (10Giuseppe Lavagetto) 5PATC>3RESO/FIX the patch has solved the problem, and now the page loads correctly. [18:09:14] (03CR) 10Bartosz Dziewoński: "Blue human has no masculine connotations unless there's a pink human alongside. The current icon looks like a chess pawn, which are indeed" [skins/Vector] - 10https://gerrit.wikimedia.org/r/157990 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [18:09:46] (03PS6) 10Aaron Schulz: Removed LCStoreDB class [core] - 10https://gerrit.wikimedia.org/r/153944 [18:11:01] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Rob, am I taking crazy pills or is the icon really suboptimal? How can we make it look better? :/" [skins/Vector] - 10https://gerrit.wikimedia.org/r/157990 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [18:11:23] 3MediaWiki-Vagrant: "Unable to determine IP" error in phpsh - 10https://bugzilla.wikimedia.org/66588#c7 (10Bryan Davis) This fix was reverted in I288974f6cb8899862eccd6dba5a37adba101855e. Hopefully most people are using hhvm and not phpsh now. [18:19:25] (03CR) 10Dduvall: [C: 04-1] "Syntax error due to a missing comma. After fixing that, it works great!" (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/158912 (owner: 10Ori.livneh) [18:26:48] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (cc3c62607c) [core] - 10https://gerrit.wikimedia.org/r/159106 [18:26:55] (03PS1) 10Raimond Spekking: Change i18n to JSON [extensions/SacredText] - 10https://gerrit.wikimedia.org/r/159107 [18:29:17] (03CR) 10Chad: [C: 032] Output more data from Elasticsearch for pages [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/158860 (owner: 10Manybubbles) [18:29:33] (03Merged) 10jenkins-bot: Output more data from Elasticsearch for pages [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/158860 (owner: 10Manybubbles) [18:30:09] (03PS1) 10Raimond Spekking: Change i18n to JSON [extensions/PureWikiDeletion] - 10https://gerrit.wikimedia.org/r/159108 [18:30:19] (03CR) 10Chad: [C: 032] Disable phrase rescore if rescore window is 0 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/159040 (owner: 10Manybubbles) [18:30:33] (03Merged) 10jenkins-bot: Disable phrase rescore if rescore window is 0 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/159040 (owner: 10Manybubbles) [18:33:38] (03PS1) 10Legoktm: Improve UnitTestsList hook [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/159109 [18:33:46] (03CR) 10jenkins-bot: [V: 04-1] Improve UnitTestsList hook [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/159109 (owner: 10Legoktm) [18:36:33] (03PS12) 10Dan-nl: GWToolset Role Additions [vagrant] - 10https://gerrit.wikimedia.org/r/158950 (https://bugzilla.wikimedia.org/70570) [18:37:46] (03CR) 10Umherirrender: "Yes, but it works and mediawiki does not care about that. The query here is builded by the global function wfArrayToCgi, so all fullurls o" [core] - 10https://gerrit.wikimedia.org/r/158943 (owner: 10Umherirrender) [18:37:48] (03PS1) 10Raimond Spekking: Define MediaWiki:GlobalUserPage.css in i18n file [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/159112 [18:37:53] (03CR) 10jenkins-bot: [V: 04-1] Define MediaWiki:GlobalUserPage.css in i18n file [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/159112 (owner: 10Raimond Spekking) [18:38:25] i like how when i leave wikidata it appends ?oldformat=true to my wikipedia url [18:38:33] eh s/wikidata/wikiwand [18:39:05] (03CR) 10Addshore: "Well, this is good as now jenkins actually runs more / all of the tests." [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/159109 (owner: 10Legoktm) [18:39:09] (03PS2) 10Raimond Spekking: Define MediaWiki:GlobalUserPage.css in i18n file [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/159112 [18:39:15] (03CR) 10Dan-nl: "* addressed bd808’s comment regarding the hhvm workaround for CURLOPT_REDIR_PROTOCOLS." (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/158950 (https://bugzilla.wikimedia.org/70570) (owner: 10Dan-nl) [18:39:21] just to rub it in how arcane our software is :) [18:41:07] PHPUnit_Framework_MockObject_Builder_InvocationMocker [18:41:25] (03CR) 10Dan-nl: "* addressed MaxSem’s comments against ps10." [vagrant] - 10https://gerrit.wikimedia.org/r/158950 (https://bugzilla.wikimedia.org/70570) (owner: 10Dan-nl) [18:41:27] since when did php become java [18:41:27] (03CR) 10Matthias Mullie: [C: 031] "LGTM." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158790 (https://bugzilla.wikimedia.org/69714) (owner: 10Bsitu) [18:41:50] (03CR) 10Aaron Schulz: [C: 032] When getting remote config, if the caller requested a single setting without an array, always do that [core] - 10https://gerrit.wikimedia.org/r/158894 (owner: 10Alex Monk) [18:43:40] (03PS3) 10Umherirrender: Show a warning if editing an site css or js page [core] - 10https://gerrit.wikimedia.org/r/158880 [18:44:29] (03CR) 10Matthias Mullie: [C: 032] Use mw.Uri to parse query instead of parsing it with regex [extensions/Flow] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/158568 (owner: 10EBernhardson) [18:44:37] (03CR) 10Matthias Mullie: Use mw.Uri to parse query instead of parsing it with regex [extensions/Flow] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/158568 (owner: 10EBernhardson) [18:45:04] (03PS1) 10Raimond Spekking: Standardize extension description message [extensions/RecentActivityFeed] - 10https://gerrit.wikimedia.org/r/159113 [18:45:09] (03CR) 10Helder.wiki: "The message lies. A change to "MediaWiki:SomeRandomPageEndingIn.css" will NOT affect anything unless someone deliberately import that page" [core] - 10https://gerrit.wikimedia.org/r/158880 (owner: 10Umherirrender) [18:45:22] (03CR) 10Matthias Mullie: [C: 031] "LGTM. Just noticed this patch is to a specific release branch so am not mergin this myself. Feel free to merge if you want to deploy it." [extensions/Flow] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/158568 (owner: 10EBernhardson) [18:45:48] (03PS4) 10Umherirrender: Show a warning if editing an site css or js page [core] - 10https://gerrit.wikimedia.org/r/158880 [18:48:07] (03Merged) 10jenkins-bot: When getting remote config, if the caller requested a single setting without an array, always do that [core] - 10https://gerrit.wikimedia.org/r/158894 (owner: 10Alex Monk) [18:48:16] (03CR) 10Krinkle: [C: 04-1] Use $.ready (031 comment) [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/159084 (owner: 10Helder.wiki) [18:48:50] (03PS2) 10Krinkle: Use $.ready and $.when instead of nesting callbacks [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/159084 (owner: 10Helder.wiki) [18:49:20] (03CR) 10Umherirrender: "Wikipedia:FooBar.js is not effected, because this change also looks for NS_MEDIAWIKI. And pages in project namespace cannot have content m" [core] - 10https://gerrit.wikimedia.org/r/158880 (owner: 10Umherirrender) [18:50:12] (03CR) 10PleaseStand: [C: 04-1] "Krinkle, that's likely because you didn't escape the backslashes in your JavaScript string literals." [core] - 10https://gerrit.wikimedia.org/r/67603 (https://bugzilla.wikimedia.org/49232) (owner: 10Daniel Friesen) [18:51:31] (03PS3) 10Helder.wiki: Use $.ready and $.when instead of nesting callbacks [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/159084 [18:53:48] (03CR) 10Matthias Mullie: [C: 031] "LGTM" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158778 (owner: 10EBernhardson) [18:54:02] MaxSem: did that change take care of your concerns? [18:54:05] (03CR) 10Matthias Mullie: [C: 031] "Other than i18n remarks, this is ok" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158403 (owner: 10EBernhardson) [18:54:45] bd808: did the changes i made take care of your concerns for https://gerrit.wikimedia.org/r/#/c/158950/ [18:54:58] dan-nl, yes [18:55:09] 3MediaWiki / 3ResourceLoader: mw.loader.store should not occupy all of localStorage - 10https://bugzilla.wikimedia.org/64721#c9 (10Ryan Kaldari) Michael M.: That sounds like a good idea, but doesn't solve the underlying issue of this bug (that mw.loader.store takes up too much of localStorage). [18:55:46] cool, are you able to +1? i think i need bd808 to give the +2 don't know if csteipp needs to also approve or not ... [18:56:09] (03PS7) 10Umherirrender: Add 'editsitejs' and 'editsitecss' user rights [core] - 10https://gerrit.wikimedia.org/r/154452 (https://bugzilla.wikimedia.org/70182) [18:56:17] (03PS1) 10EBernhardson: Mark notifications as read if they fail rendering [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159115 [18:56:39] (03PS1) 10IAlex: Avoid a fatal error in maintenance/cleanupTitles.php [core] - 10https://gerrit.wikimedia.org/r/159116 [18:56:43] (03CR) 10Umherirrender: "Patch Set 7: Broke long lines" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/154452 (https://bugzilla.wikimedia.org/70182) (owner: 10Umherirrender) [18:58:05] (03CR) 10Aaron Schulz: Minor updates to populateRevisionSha1.php to use newer available features (031 comment) [core] - 10https://gerrit.wikimedia.org/r/90431 (owner: 10Reedy) [18:58:12] (03PS3) 10Umherirrender: Add backlinks on special pages with relevant title [core] - 10https://gerrit.wikimedia.org/r/151445 [18:58:18] (03PS13) 10Dan-nl: GWToolset Role Additions [vagrant] - 10https://gerrit.wikimedia.org/r/158950 (https://bugzilla.wikimedia.org/70570) [18:58:42] (03CR) 10Dan-nl: "* replaced spaces in the README with tabs" [vagrant] - 10https://gerrit.wikimedia.org/r/158950 (https://bugzilla.wikimedia.org/70570) (owner: 10Dan-nl) [18:59:28] (03CR) 10Aaron Schulz: [C: 032] CategoryFinder: give parent category tree an accessor [core] - 10https://gerrit.wikimedia.org/r/158663 (owner: 10Chad) [18:59:40] (03PS4) 10Bsitu: [WIP]Remove old notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/157029 [18:59:58] (03PS7) 10EBernhardson: Bundle new-topic notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158403 [19:00:04] (03CR) 10jenkins-bot: [V: 04-1] Bundle new-topic notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158403 (owner: 10EBernhardson) [19:02:53] (03CR) 10Krinkle: [C: 04-1] "The bug that occurred in the previous test (due to the same token name) was fixed but the fact that that happened at all is actually a mor" [core] - 10https://gerrit.wikimedia.org/r/156093 (owner: 10Nikerabbit) [19:03:29] (03PS3) 10Krinkle: Html: Don't accept paths relative to skins/common/images/ in infoBox() [core] - 10https://gerrit.wikimedia.org/r/158655 (owner: 10Bartosz Dziewoński) [19:03:59] (03PS8) 10EBernhardson: Bundle new-topic notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158403 [19:05:53] (03Merged) 10jenkins-bot: CategoryFinder: give parent category tree an accessor [core] - 10https://gerrit.wikimedia.org/r/158663 (owner: 10Chad) [19:06:04] (03CR) 10BryanDavis: [C: 031] "Not tested but I think all of my concerns about code style have been addressed. I can test this evening if no one has had time to do so an" [vagrant] - 10https://gerrit.wikimedia.org/r/158950 (https://bugzilla.wikimedia.org/70570) (owner: 10Dan-nl) [19:06:34] (03CR) 10Krinkle: "@Aaron, @Chad Both this and 9d77a57592340 had trailing whitespace. Fixed in If1fd68a3a7355c." [core] - 10https://gerrit.wikimedia.org/r/157872 (owner: 10Aaron Schulz) [19:06:42] (03CR) 10Krinkle: "@Aaron, @Chad Both this and 9372c87888fae had trailing whitespace. Fixed in If1fd68a3a7355c." [core] - 10https://gerrit.wikimedia.org/r/158799 (owner: 10Aaron Schulz) [19:07:05] (03CR) 10Krinkle: "Rebased to resolve merge conflict." [core] - 10https://gerrit.wikimedia.org/r/158655 (owner: 10Bartosz Dziewoński) [19:08:53] 3MediaWiki extensions / 3CodeEditor: When previewing .js file after changes made getting a message "The document contains errors. Are you sure you want to save?" - 10https://bugzilla.wikimedia.org/70567#c1 (10Umherirrender) Sounds like part of the CodeEditor [19:09:23] (03CR) 10Krinkle: [C: 032] Html: Don't accept paths relative to skins/common/images/ in infoBox() [core] - 10https://gerrit.wikimedia.org/r/158655 (owner: 10Bartosz Dziewoński) [19:10:30] (03CR) 10EBernhardson: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158826 (owner: 10EBernhardson) [19:11:12] (03CR) 10EBernhardson: [C: 032] "re-apply jdlrobson +2" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158826 (owner: 10EBernhardson) [19:11:23] 3MediaWiki-Vagrant: Fatal PHP errors can prompt Vagrant to re-configure MediaWiki - 10https://bugzilla.wikimedia.org/50912 (10Dan Duvall) 5NEW>3ASSI [19:11:37] (03Merged) 10jenkins-bot: Hygiene: Give ApiStub modes names instead of numbers [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158826 (owner: 10EBernhardson) [19:12:35] (03CR) 10MarkTraceur: [C: 032] "Thanks!" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158589 (owner: 10Gilles) [19:13:06] (03Merged) 10jenkins-bot: Remove expensive synchronous template validation [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158589 (owner: 10Gilles) [19:15:52] (03Merged) 10jenkins-bot: Html: Don't accept paths relative to skins/common/images/ in infoBox() [core] - 10https://gerrit.wikimedia.org/r/158655 (owner: 10Bartosz Dziewoński) [19:16:54] 3MediaWiki / 3ResourceLoader: mw.loader.store should not occupy all of localStorage - 10https://bugzilla.wikimedia.org/64721#c10 (10Ryan Kaldari) Filed an upstream bug against Firefox at https://bugzilla.mozilla.org/show_bug.cgi?id=1064466 [19:17:07] (03PS1) 10MaxSem: Ignore duplicate key errors in update-keys.sql [core] - 10https://gerrit.wikimedia.org/r/159119 [19:18:18] (03CR) 10MarkTraceur: [C: 032] Fix TitleBlacklist support [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158337 (https://bugzilla.wikimedia.org/65624) (owner: 10Gilles) [19:19:02] (03Merged) 10jenkins-bot: Fix TitleBlacklist support [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158337 (https://bugzilla.wikimedia.org/65624) (owner: 10Gilles) [19:21:08] 3Wikimedia / 3General/Unknown: 404 errors for CSS and HTML from Bits in zh-yue wikipedia - 10https://bugzilla.wikimedia.org/70557#c5 (10Andre Klapper) Thanks for the quick investigation and fixing, Giuseppe! [19:23:08] 3MediaWiki extensions / 3CodeEditor: When previewing .js file after changes made getting a message "The document contains errors. Are you sure you want to save?" - 10https://bugzilla.wikimedia.org/70567#c2 (10Andre Klapper) 5NEW>3RESO/DUP Hi Stryn. Thanks for taking the time to report this! This particul... [19:23:09] 3MediaWiki extensions / 3CodeEditor: "Are you sure you want to save?" when trying to "show changes" - 10https://bugzilla.wikimedia.org/68765#c2 (10Andre Klapper) *** Bug 70567 has been marked as a duplicate of this bug. *** [19:23:42] (03PS2) 10Legoktm: Actually run all the tests (and fix the broken ones!) [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/159109 [19:23:47] (03CR) 10jenkins-bot: [V: 04-1] Actually run all the tests (and fix the broken ones!) [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/159109 (owner: 10Legoktm) [19:23:57] aww [19:24:41] (03PS3) 10Legoktm: Actually run all the tests (and fix the broken ones!) [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/159109 [19:24:49] hey bd808|LUNCH and MaxSem, thanks for your help! [19:25:15] (03CR) 10Helder.wiki: "Just to clarify the two issues: 1. showing the message when they are not appropriated and 2. not showing it when it may be appropriated." [core] - 10https://gerrit.wikimedia.org/r/158880 (owner: 10Umherirrender) [19:26:42] (03PS1) 10Calak: Add linkTrail for Central Kurdish (ckb) [core] - 10https://gerrit.wikimedia.org/r/159120 [19:36:21] (03CR) 10EBernhardson: Show alerts tab if active notifications and no messages (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158820 (https://bugzilla.wikimedia.org/70461) (owner: 10EBernhardson) [19:37:30] (03PS4) 10EBernhardson: Default to alerts tab [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158820 (https://bugzilla.wikimedia.org/70461) [19:39:21] (03PS2) 10MaxSem: Add a role that converts all PHP warnings/notices into errors [vagrant] - 10https://gerrit.wikimedia.org/r/156602 [19:40:43] (03PS5) 10Calak: Show a warning if editing a site css or js page [core] - 10https://gerrit.wikimedia.org/r/158880 (owner: 10Umherirrender) [19:41:26] 3Wikimedia / 3Media storage: File unavailable for an unknown reason - 10https://bugzilla.wikimedia.org/70572 (10Ankry) 3NEW p:3Unprio s:3major a:3None While attempting to download the file https://commons.wikimedia.org/wiki/File:FAO_logo.svg you get for https://upload.wikimedia.org/wikipedia/commo... [19:44:24] (03CR) 10Spage: [C: 032] "OK for today's SWAT" [extensions/Flow] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/158569 (owner: 10EBernhardson) [19:44:39] 3Wikimedia / 3Media storage: File unavailable for an unknown reason - 10https://bugzilla.wikimedia.org/70572#c1 (10Tisza Gergő) 5NEW>3RESO/DUP Nothing interesting in file history. Probably a duplicate of bug 70556. *** This bug has been marked as a duplicate of bug 70556 *** [19:44:39] 3Wikimedia / 3Media storage: 404 errors for three images on Commons - 10https://bugzilla.wikimedia.org/70556#c2 (10Tisza Gergő) *** Bug 70572 has been marked as a duplicate of this bug. *** [19:44:53] (03CR) 10Spage: [C: 032] "OK for today's SWAT" [extensions/Flow] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/158568 (owner: 10EBernhardson) [19:44:59] (03Merged) 10jenkins-bot: Use mw.Uri to parse query instead of parsing it with regex [extensions/Flow] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/158569 (owner: 10EBernhardson) [19:45:28] (03Merged) 10jenkins-bot: Use mw.Uri to parse query instead of parsing it with regex [extensions/Flow] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/158568 (owner: 10EBernhardson) [19:47:06] (03PS1) 10Dan-nl: Add Curl Constants Test [core] - 10https://gerrit.wikimedia.org/r/159159 (https://bugzilla.wikimedia.org/70570) [19:51:59] (03PS2) 10Dan-nl: Add Curl Constants Test [core] - 10https://gerrit.wikimedia.org/r/159159 (https://bugzilla.wikimedia.org/70570) [19:52:20] (03CR) 10Dan-nl: "* added additional comments to the code" [core] - 10https://gerrit.wikimedia.org/r/159159 (https://bugzilla.wikimedia.org/70570) (owner: 10Dan-nl) [19:52:48] bd808|LUNCH: wasn't sure where to add the curl constants test so i added it to core https://gerrit.wikimedia.org/r/#/c/159159/ [19:53:41] thanks again for your help [20:03:39] 3Wikimedia / 3Extension setup: Refactoring ZeroRatedMobileAccess into JsonConfig & ZeroBanner extensions - 10https://bugzilla.wikimedia.org/66133 (10Yuri Astrakhan) 5NEW>3RESO/FIX [20:04:52] 3Wikimedia / 3Extension setup: Extensions awaiting code review to be deployed on Wikimedia wikis (tracking) - 10https://bugzilla.wikimedia.org/31235 (10Kunal Mehta (Legoktm)) [20:04:55] 3MediaWiki / 3General/Unknown: Make crosswiki bits and pieces truly global (tracking) - 10https://bugzilla.wikimedia.org/64475 (10Kunal Mehta (Legoktm)) [20:04:55] 3MediaWiki extensions / 3GlobalUserPage: Make CentralAuth support GlobalUserPage - 10https://bugzilla.wikimedia.org/70509 (10Kunal Mehta (Legoktm)) [20:04:56] 3Wikimedia / 3Extension setup: Review and deploy GlobalUserPage extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/70576 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None The GlobalUserPage extension enables global user pages across a wiki farm. If a local user page does not ex... [20:06:48] (03PS2) 10Jackmcbarn: Output   instead of &#nbsp; [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/158872 (https://bugzilla.wikimedia.org/70475) [20:09:15] (03CR) 10Jackmcbarn: "It's confusing to users, though, especially since the numbers don't match the actual numbering that the parser will use. Either fix wfArra" [core] - 10https://gerrit.wikimedia.org/r/158943 (owner: 10Umherirrender) [20:14:30] (03CR) 10Bartosz Dziewoński: [C: 031] resourceloader: Condition-wrap the HTML tag instead of JS response (031 comment) [core] - 10https://gerrit.wikimedia.org/r/159086 (https://bugzilla.wikimedia.org/69924) (owner: 10Krinkle) [20:15:07] (03CR) 10Legoktm: [C: 04-1] "This message should only be displayed on the central wiki, so I think we'll have to do something like we did in GlobalCssJs with two messa" [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/159112 (owner: 10Raimond Spekking) [20:16:10] (03CR) 10BryanDavis: Add Curl Constants Test (034 comments) [core] - 10https://gerrit.wikimedia.org/r/159159 (https://bugzilla.wikimedia.org/70570) (owner: 10Dan-nl) [20:19:01] (03PS5) 10EBernhardson: Default to alerts tab [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158820 (https://bugzilla.wikimedia.org/70461) [20:19:13] (03CR) 10BryanDavis: [C: 04-1] "I'm assuming the wikimetrics submodule change snuck in here unintentionally." [vagrant] - 10https://gerrit.wikimedia.org/r/156602 (owner: 10MaxSem) [20:22:17] (03PS1) 10Cscott: Provide parsoid information to OCG if visual editor is installed. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/159161 [20:22:49] (03PS1) 10Spage: mw.echo.overlay.updateCount() no longer exists [extensions/Echo] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159162 (https://bugzilla.wikimedia.org/69714) [20:23:38] 3MediaWiki / 3JavaScript: mw.notification Usability Improvements - 10https://bugzilla.wikimedia.org/40307#c21 (10James Forrester) *** Bug 70548 has been marked as a duplicate of this bug. *** [20:23:50] (03PS2) 10Spage: mw.echo.overlay.updateCount() no longer exists [extensions/Echo] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159162 (https://bugzilla.wikimedia.org/69714) [20:24:42] (03Abandoned) 10Spage: mw.echo.overlay.updateCount() no longer exists [extensions/Echo] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159162 (https://bugzilla.wikimedia.org/69714) (owner: 10Spage) [20:26:08] 3Wikimedia / 3Media storage: 404 errors for three images on Commons - 10https://bugzilla.wikimedia.org/70556#c3 (10Ankry) Unlike the three images above, the file from bug 70572 https://commons.wikimedia.org/wiki/File:FAO_logo.svg is used in many wikis and is not intended to be deleted [20:28:23] 3MediaWiki extensions / 3AbuseFilter: Add more variables to AbuseFilter file uploading evaluation - 10https://bugzilla.wikimedia.org/19565#c9 (10Stöger Florian D. M.) This bug enables bad-faith editors to upload media files with an invalid {{permissionOTRS}} tag without anyone noticing. Therefore, in my opin... [20:28:29] (03CR) 10Aaron Schulz: Ignore duplicate key errors in update-keys.sql (031 comment) [core] - 10https://gerrit.wikimedia.org/r/159119 (owner: 10MaxSem) [20:28:53] 3MediaWiki extensions / 3AbuseFilter: Add more variables to AbuseFilter file uploading evaluation - 10https://bugzilla.wikimedia.org/19565 (10Stöger Florian D. M.) p:5Low>3High s:5enhanc>3normal [20:29:43] (03PS2) 10MaxSem: Ignore duplicate key errors in update-keys.sql [core] - 10https://gerrit.wikimedia.org/r/159119 [20:30:08] 3Wikimedia / 3Extension setup: Review and deploy GlobalUserPage extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/70576#c1 (10Helder) Can we have a helper script analogous to the one from GlobalCssJs to delete local user pages by request? [20:30:35] helderwiki: maybe if we ask Pathoschild nicely :) [20:30:48] I'm not planning on writing one though [20:31:31] ok [20:32:00] ermm.. "The bot can delete any of your user subpages (but not your main user or talk page)." [20:32:16] ...from [[meta:Synchbot]] [20:33:11] (03CR) 10Alex Monk: [C: 032] Update OOjs UI to v0.1.0-pre (cc3c62607c) [core] - 10https://gerrit.wikimedia.org/r/159106 (owner: 10Jforrester) [20:33:30] (03PS9) 10EBernhardson: Bundle new-topic notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158403 [20:33:40] 3Wikimedia / 3Site requests: Create wiki for Wikimedia Venezuela - 10https://bugzilla.wikimedia.org/70579 (10Carlos Mora) 3NEW p:3Unprio s:3enhanc a:3None Please create a wiki for Wikimedia Venezuela, the Venezuelan chapter of the Wikimedia Foundation, with the configuration options listed below. -... [20:34:23] 3Wikimedia / 3Site requests: Create wiki for Wikimedia Venezuela - 10https://bugzilla.wikimedia.org/70579 (10Carlos Mora) p:5Unprio>3Normal [20:34:37] (03CR) 10Anomie: [C: 032] Output   instead of &#nbsp; [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/158872 (https://bugzilla.wikimedia.org/70475) (owner: 10Jackmcbarn) [20:35:41] (03PS3) 10Jforrester: Make mediawiki.action.view.dblClickEdit recheck preference [core] - 10https://gerrit.wikimedia.org/r/150391 (https://bugzilla.wikimedia.org/53058) (owner: 10Alex Monk) [20:37:06] (03Merged) 10jenkins-bot: Output   instead of &#nbsp; [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/158872 (https://bugzilla.wikimedia.org/70475) (owner: 10Jackmcbarn) [20:37:53] 3MediaWiki extensions / 3Scribunto: mw.text.encode and unbreakable space - 10https://bugzilla.wikimedia.org/70475#c3 (10Jackmcbarn) 5PATC>3RESO/FIX The fix will be deployed to all WMF wikis by September 18th. [20:38:10] 3MediaWiki extensions / 3Scribunto: mw.text.encode and unbreakable space - 10https://bugzilla.wikimedia.org/70475 (10Jackmcbarn) a:3Jackmcbarn [20:39:26] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (cc3c62607c) [core] - 10https://gerrit.wikimedia.org/r/159106 (owner: 10Jforrester) [20:43:45] (03CR) 10EBernhardson: [C: 032] mw.echo.overlay.updateCount() no longer exists [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158790 (https://bugzilla.wikimedia.org/69714) (owner: 10Bsitu) [20:44:10] (03Merged) 10jenkins-bot: mw.echo.overlay.updateCount() no longer exists [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158790 (https://bugzilla.wikimedia.org/69714) (owner: 10Bsitu) [20:44:34] (03PS10) 10Bsitu: Bundle new-topic notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158403 (owner: 10EBernhardson) [20:44:39] 3Wikimedia / 3Site requests: Create wiki for Wikimedia Venezuela - 10https://bugzilla.wikimedia.org/70579#c1 (10Oscar .) Hi all, Just to note that Carlos Mora is member our tech team and the creation of this wiki was based of a consensus made by our board. Regards, Oscar Costero President - Wikimedia Ve... [20:45:13] (03Restored) 10EBernhardson: mw.echo.overlay.updateCount() no longer exists [extensions/Echo] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159162 (https://bugzilla.wikimedia.org/69714) (owner: 10Spage) [20:45:38] (03CR) 10EBernhardson: [C: 032] mw.echo.overlay.updateCount() no longer exists [extensions/Echo] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159162 (https://bugzilla.wikimedia.org/69714) (owner: 10Spage) [20:46:08] (03Merged) 10jenkins-bot: mw.echo.overlay.updateCount() no longer exists [extensions/Echo] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159162 (https://bugzilla.wikimedia.org/69714) (owner: 10Spage) [20:46:26] (03PS1) 10EBernhardson: Cascade protection from board to topic [extensions/Flow] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159165 [20:46:31] (03PS11) 10Bsitu: Bundle new-topic notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158403 (owner: 10EBernhardson) [20:46:38] (03CR) 10EBernhardson: [C: 032] Cascade protection from board to topic [extensions/Flow] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159165 (owner: 10EBernhardson) [20:47:00] (03PS1) 10EBernhardson: Cascade protection from board to topic [extensions/Flow] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159166 [20:47:35] (03CR) 10Spage: "Responded" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159009 (owner: 10Spage) [20:47:40] (03PS2) 10Spage: Fix "Cancelling reply preview" browser test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159009 [20:47:43] (03Merged) 10jenkins-bot: Cascade protection from board to topic [extensions/Flow] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159165 (owner: 10EBernhardson) [20:48:10] 3MediaWiki extensions / 3LabeledSectionTransclusion: Create a VisualEditor plugin tool to add/edit LabelledSectionTransclusion markers - 10https://bugzilla.wikimedia.org/70581 (10James Forrester) 3ASSI p:3Unprio s:3enhanc a:3James Forrester The LST markers

and 3MediaWiki extensions / 3LabeledSectionTransclusion: Create a VisualEditor plugin tool to add/edit LabelledSectionTransclusion markers - 10https://bugzilla.wikimedia.org/70581 (10James Forrester) p:5Unprio>3Normal [20:49:21] (03CR) 10EBernhardson: [C: 032] Cascade protection from board to topic [extensions/Flow] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159166 (owner: 10EBernhardson) [20:49:56] (03Merged) 10jenkins-bot: Cascade protection from board to topic [extensions/Flow] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159166 (owner: 10EBernhardson) [20:51:08] (03PS1) 10Chad: Remove --closeOk parameter to update(One)SearchIndexConfig [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/159169 [20:53:54] (03CR) 10MaxSem: [C: 032] Provide parsoid information to OCG if visual editor is installed. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/159161 (owner: 10Cscott) [20:54:00] (03Merged) 10jenkins-bot: Provide parsoid information to OCG if visual editor is installed. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/159161 (owner: 10Cscott) [20:54:40] (03PS12) 10Bsitu: Bundle new-topic notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158403 (owner: 10EBernhardson) [21:00:02] (03Abandoned) 10EBernhardson: Allow bundling by count of events [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158778 (owner: 10EBernhardson) [21:00:18] (03Abandoned) 10EBernhardson: Expose event count as a formatter parameter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158752 (owner: 10EBernhardson) [21:03:09] 3Wikimedia / 3Media storage: Stuck old 1024px thumbnail version of a specific djvu image on wikisource.pl - 10https://bugzilla.wikimedia.org/70189 (10wieralee) 5NEW>3RESO/FIX [21:03:57] (03CR) 10MarkTraceur: [C: 04-1] "One little issue, looks good otherwise." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/152134 (https://bugzilla.wikimedia.org/69188) (owner: 10Florianschmidtwelzow) [21:05:38] 3MediaWiki extensions / 3LabeledSectionTransclusion: Create a VisualEditor plugin tool to add/edit LabelledSectionTransclusion markers - 10https://bugzilla.wikimedia.org/70581 (10James Forrester) [21:09:18] (03PS1) 10Manybubbles: Allow overriding size of the phrase slop window [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/159175 [21:12:41] (03CR) 10Chad: [C: 032] Store weighted all_near_match with freqs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/159052 (owner: 10Manybubbles) [21:12:55] (03Merged) 10jenkins-bot: Store weighted all_near_match with freqs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/159052 (owner: 10Manybubbles) [21:12:57] (03PS1) 10Cscott: Link to unicode math encoding spec. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/159176 [21:13:00] (03PS1) 10Cscott: Allow rendering from unzipped bundle [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/159177 [21:13:02] (03PS1) 10Cscott: Add -T option to CLI to specify a temporary directory. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/159178 [21:15:25] (03CR) 10EBernhardson: [C: 032] "LGTM" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158403 (owner: 10EBernhardson) [21:15:52] (03CR) 10MarkTraceur: "Rebase fail." [core] - 10https://gerrit.wikimedia.org/r/90729 (owner: 10Bartosz Dziewoński) [21:16:00] (03Merged) 10jenkins-bot: Bundle new-topic notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158403 (owner: 10EBernhardson) [21:16:31] (03PS1) 10Legoktm: Add Metrolook submodule [skins] - 10https://gerrit.wikimedia.org/r/159180 [21:16:46] (03CR) 10Legoktm: [C: 032 V: 032] Add Metrolook submodule [skins] - 10https://gerrit.wikimedia.org/r/159180 (owner: 10Legoktm) [21:19:45] (03PS2) 10Cscott: Use `/etc/mw-collection-ocg.js` configuration file if present. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/159099 [21:19:47] (03PS2) 10Cscott: Clarify README with local development instructions. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/159101 [21:19:49] (03PS2) 10Cscott: Ensure that default temp and output directories exist. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/159100 [21:19:51] (03PS1) 10Cscott: Add a human-readable help page to quickly test/check the service. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/159183 [21:22:04] (03PS1) 10EBernhardson: Bundle new-topic notifications [extensions/Flow] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159184 [21:22:31] (03PS2) 10Bsitu: Mark notifications as read if they fail rendering [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159115 (owner: 10EBernhardson) [21:23:28] (03CR) 10Bsitu: [C: 031] Mark notifications as read if they fail rendering [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159115 (owner: 10EBernhardson) [21:26:33] (03PS1) 10Mattflaschen: Have GettingStarted depend on PageImages [vagrant] - 10https://gerrit.wikimedia.org/r/159186 [21:27:00] (03CR) 10EBernhardson: [C: 032] Mark notifications as read if they fail rendering [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159115 (owner: 10EBernhardson) [21:27:27] (03CR) 10Florianschmidtwelzow: SpecialUpload: Use Config instead of global (031 comment) [core] - 10https://gerrit.wikimedia.org/r/152134 (https://bugzilla.wikimedia.org/69188) (owner: 10Florianschmidtwelzow) [21:27:29] (03Merged) 10jenkins-bot: Mark notifications as read if they fail rendering [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159115 (owner: 10EBernhardson) [21:27:47] (03PS7) 10Florianschmidtwelzow: SpecialUpload: Use Config instead of global [core] - 10https://gerrit.wikimedia.org/r/152134 (https://bugzilla.wikimedia.org/69188) [21:27:56] (03PS1) 10EBernhardson: Mark notifications as read if they fail rendering [extensions/Echo] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159187 [21:28:03] (03CR) 10EBernhardson: [C: 032] Mark notifications as read if they fail rendering [extensions/Echo] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159187 (owner: 10EBernhardson) [21:28:43] (03Merged) 10jenkins-bot: Mark notifications as read if they fail rendering [extensions/Echo] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159187 (owner: 10EBernhardson) [21:29:41] (03CR) 10Chad: [C: 032] Add option to turn off all fields in rescore [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/158863 (owner: 10Manybubbles) [21:29:56] (03Merged) 10jenkins-bot: Add option to turn off all fields in rescore [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/158863 (owner: 10Manybubbles) [21:30:43] (03CR) 10Chad: [C: 032] Shrink the weighted all field's positions [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/159079 (owner: 10Manybubbles) [21:30:58] (03Merged) 10jenkins-bot: Shrink the weighted all field's positions [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/159079 (owner: 10Manybubbles) [21:33:23] 3MediaWiki-Vagrant: "Unable to determine IP" error in phpsh - 10https://bugzilla.wikimedia.org/66588#c8 (10Matthew Flaschen) Somehow phpsh is still working for me (when zend role is enabled), albeit with: --- subprocess died with return code: 0 PHP died. Restarting php --- Not sure the cause of that bug. [21:35:23] 3Wikimedia / 3Extension setup: Review and deploy GlobalUserPage extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/70576#c2 (10Kunal Mehta (Legoktm)) (In reply to Helder from comment #1) > Can we have a helper script analogous to the one from GlobalCssJs to delete > local user pages by request?... [21:38:08] 3Wikimedia / 3Extension setup: Review and deploy GlobalUserPage extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/70576 (10Kunal Mehta (Legoktm)) [21:38:15] bd808: re https://bugzilla.wikimedia.org/show_bug.cgi?id=50912 i can't seem to get puppet to include the output of mwscript in the log/stdout [21:39:56] (03CR) 10Cscott: [C: 032] Link to unicode math encoding spec. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/159176 (owner: 10Cscott) [21:40:05] (03CR) 10Cscott: [C: 032] Allow rendering from unzipped bundle [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/159177 (owner: 10Cscott) [21:40:11] (03Merged) 10jenkins-bot: Link to unicode math encoding spec. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/159176 (owner: 10Cscott) [21:40:13] (03CR) 10Cscott: [C: 032] Add -T option to CLI to specify a temporary directory. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/159178 (owner: 10Cscott) [21:40:26] (03Merged) 10jenkins-bot: Allow rendering from unzipped bundle [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/159177 (owner: 10Cscott) [21:40:27] marxarelli: Lame. logoutput => 'on_failure' doesn't at least log it as info messages? [21:40:28] (03Merged) 10jenkins-bot: Add -T option to CLI to specify a temporary directory. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/159178 (owner: 10Cscott) [21:40:56] bd808: and looking at mediawiki::wiki i'm wondering if we even need the extra check, since exec { "wiki_setup" } already specifies creates => ".../LocalSettings.php" [21:41:03] bd808: no, it didn't seem to work [21:41:25] (03PS3) 10Cscott: Clarify README with local development instructions. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/159101 [21:41:27] (03PS3) 10Cscott: Unify logging through the service wrapper [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/151224 (owner: 10Mwalker) [21:41:29] (03PS2) 10Cscott: Add a human-readable help page to quickly test/check the service. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/159183 [21:41:31] (03PS1) 10Cscott: Make sure the collection id is specific to the backend selected. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/159190 [21:41:32] bd808: i thought that maybe it wasn't capturing stderr so i put 2>&1 at the tail, to no avail [21:41:37] (03PS1) 10Cscott: Fix comment. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/159191 [21:41:39] (03PS1) 10Cscott: WIP: indic languages fixes [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/159192 [21:41:48] marxarelli: The problem is when the vm has been destroyed and then you are calling up again. In that case there is code in /vagrant/... but no db created. [21:42:03] (03CR) 10Bsitu: [C: 032] "LGTM and works as expected! I would fix the qunit in a subsequent patch" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158820 (https://bugzilla.wikimedia.org/70461) (owner: 10EBernhardson) [21:42:06] (03PS1) 10Foxtrott: Add styling for thumbnails [skins/chameleon] - 10https://gerrit.wikimedia.org/r/159193 [21:42:20] (03CR) 10Cscott: [C: 032] Fix comment. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/159191 (owner: 10Cscott) [21:42:29] bd808: oh, that's right. i think you mentioned that on friday [21:42:30] (03Merged) 10jenkins-bot: Default to alerts tab [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158820 (https://bugzilla.wikimedia.org/70461) (owner: 10EBernhardson) [21:42:38] So alternately we could add cleaning up mw/LocalSettings.php to the destroy hook we have in the plugin now [21:42:51] Back in the olden days we didn't have that hook [21:43:07] Maybe that would do it? [21:43:12] bd808: that, or check for the MYI file maybe? [21:43:53] 3Wikimedia / 3Extension setup: Review and deploy GlobalUserPage extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/70576 (10Kunal Mehta (Legoktm)) [21:44:21] marxarelli: It might be worth you talking f2f with ori for 5-10 minutes about. [21:44:21] (03CR) 10Foxtrott: [C: 032 V: 032] Add styling for thumbnails [skins/chameleon] - 10https://gerrit.wikimedia.org/r/159193 (owner: 10Foxtrott) [21:44:23] (03CR) 10Cscott: "I've rebased this on top of a stack of small fixes and documentation updates to allow me to effectively test this patch on a local mediawi" [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/151224 (owner: 10Mwalker) [21:44:24] bd808: dur... whichever file mysql creates in /var/lib/mysql// [21:47:17] bd808: cool. i think he's in a meeting atm but i'll ask when i see him [21:47:27] is wikibugs not reporting new bugs? [21:47:42] (03Merged) 10jenkins-bot: Fix comment. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/159191 (owner: 10Cscott) [21:47:48] marxarelli: He is in a meeting. I'm in it too. :) [21:49:37] (03PS2) 10Florianschmidtwelzow: Fix Warning: Invalid parameter for message [extensions/StalkerLog] - 10https://gerrit.wikimedia.org/r/151093 (https://bugzilla.wikimedia.org/68717) [21:50:12] (03PS4) 10Florianschmidtwelzow: Fix some wfMsg* [extensions/OnlineStatus] - 10https://gerrit.wikimedia.org/r/150154 (https://bugzilla.wikimedia.org/68750) [21:51:45] (03CR) 10Swalling: [C: 031] "The idea that it's not visually clear to users is not an argument I buy, considering how many similar kinds of icon exist. A quick set of " [skins/Vector] - 10https://gerrit.wikimedia.org/r/157990 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [21:52:08] (03PS1) 10Bsitu: Move flow-mention back to flow-discussion category [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159194 [21:53:15] (03PS1) 10EBernhardson: Default to alerts tab [extensions/Echo] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159195 (https://bugzilla.wikimedia.org/70461) [21:53:49] (03CR) 10EBernhardson: "cherry-picked to 1.24wmf20 with I588ad86cd29f9bc410cf240094ce6b51a9dea517" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158820 (https://bugzilla.wikimedia.org/70461) (owner: 10EBernhardson) [21:54:04] (03CR) 10EBernhardson: [C: 032] Default to alerts tab [extensions/Echo] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159195 (https://bugzilla.wikimedia.org/70461) (owner: 10EBernhardson) [21:54:28] (03Merged) 10jenkins-bot: Default to alerts tab [extensions/Echo] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159195 (https://bugzilla.wikimedia.org/70461) (owner: 10EBernhardson) [21:56:40] (03CR) 10EBernhardson: [C: 032] Move flow-mention back to flow-discussion category [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159194 (owner: 10Bsitu) [21:56:46] (03PS1) 10EBernhardson: Move flow-mention back to flow-discussion category [extensions/Flow] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159196 [21:56:52] (03CR) 10EBernhardson: [C: 032] Move flow-mention back to flow-discussion category [extensions/Flow] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159196 (owner: 10EBernhardson) [21:57:17] (03Merged) 10jenkins-bot: Move flow-mention back to flow-discussion category [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159194 (owner: 10Bsitu) [21:57:49] (03CR) 10jenkins-bot: [V: 04-1] Move flow-mention back to flow-discussion category [extensions/Flow] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159196 (owner: 10EBernhardson) [21:59:35] (03CR) 10EBernhardson: "recheck" [extensions/Flow] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159196 (owner: 10EBernhardson) [22:00:45] (03CR) 10EBernhardson: [C: 032] Move flow-mention back to flow-discussion category [extensions/Flow] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159196 (owner: 10EBernhardson) [22:01:19] (03Merged) 10jenkins-bot: Move flow-mention back to flow-discussion category [extensions/Flow] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159196 (owner: 10EBernhardson) [22:03:10] 3MediaWiki / 3Interface: Typo in MediaWiki:Wikibase-otherprojects-beta-description - 10https://bugzilla.wikimedia.org/70587 (10Stefan2) 3UNCO p:3Unprio s:3normal a:3None [[MediaWiki:Wikibase-otherprojects-beta-description]] reads "Adds a "{{int:wikibase-otherprojects}}" section to the sidebar that pr... [22:07:10] (03PS1) 10EBernhardson: Repair progressively enhanced load more [extensions/Flow] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159199 [22:07:28] (03CR) 10EBernhardson: [C: 032] Repair progressively enhanced load more [extensions/Flow] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159199 (owner: 10EBernhardson) [22:08:04] (03Merged) 10jenkins-bot: Repair progressively enhanced load more [extensions/Flow] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159199 (owner: 10EBernhardson) [22:08:55] 3MediaWiki extensions / 3GlobalCssJs: GlobalCssJs wording in preferences is unclear - 10https://bugzilla.wikimedia.org/70588 (10Gryllida) 3UNCO p:3Unprio s:3normal a:3None STR: visit special:preferences, appearance tab actual result: "Shared CSS/JavaScript for all wikis:" expected result: "Shared C... [22:15:54] (03CR) 10EBernhardson: [C: 032] Bundle new-topic notifications [extensions/Flow] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159184 (owner: 10EBernhardson) [22:16:27] (03Merged) 10jenkins-bot: Bundle new-topic notifications [extensions/Flow] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159184 (owner: 10EBernhardson) [22:18:32] (03CR) 10Addshore: [C: 032] Actually run all the tests (and fix the broken ones!) [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/159109 (owner: 10Legoktm) [22:18:35] (03PS1) 10Bsitu: Both notifyNewTopic and notifyPostChange trigger mention notif [extensions/Flow] - 10https://gerrit.wikimedia.org/r/159203 [22:18:40] (03Merged) 10jenkins-bot: Actually run all the tests (and fix the broken ones!) [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/159109 (owner: 10Legoktm) [22:19:53] 3MediaWiki / 3MediaWiki UI: MediaWiki UI styles are applied to core instead of relevant skins - 10https://bugzilla.wikimedia.org/70351#c9 (10Isarra) (In reply to Matthew Flaschen from comment #7) > (In reply to Bartosz Dziewoński from comment #5) > > I was under the impression that MediaWiki UI, while geared... [22:26:26] (03CR) 10MaxSem: [C: 032] Send thanks via POST on mobile too [extensions/Thanks] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/158911 (https://bugzilla.wikimedia.org/70503) (owner: 10Legoktm) [22:26:38] (03PS1) 10EBernhardson: Bump Echo and Flow submodules in 1.24wmf20 [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159206 [22:26:45] (03CR) 10MaxSem: [C: 032] Send thanks via POST on mobile too [extensions/Thanks] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/158910 (https://bugzilla.wikimedia.org/70503) (owner: 10Legoktm) [22:27:01] (03Merged) 10jenkins-bot: Send thanks via POST on mobile too [extensions/Thanks] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/158911 (https://bugzilla.wikimedia.org/70503) (owner: 10Legoktm) [22:27:32] (03Merged) 10jenkins-bot: Send thanks via POST on mobile too [extensions/Thanks] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/158910 (https://bugzilla.wikimedia.org/70503) (owner: 10Legoktm) [22:29:53] 3MediaWiki extensions / 3GlobalCssJs: GlobalCssJs wording in preferences is unclear - 10https://bugzilla.wikimedia.org/70588#c1 (10Kunal Mehta (Legoktm)) How is a link to [[wmf:Our_projects]] helpful? I guess we could add the help link there... [22:31:00] (03PS1) 10EBernhardson: Submodule bump for Flow in 1.24wmf19 [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159208 [22:33:08] 3MediaWiki extensions / 3CirrusSearch: Stemming: CirrusSearch does not find Биология for a Биологии query on ru.wp (but LuceneSearch does) - 10https://bugzilla.wikimedia.org/69766#c10 (10Gryllida) Presumably this is in production now. Sorry, I don't see this work as expected now. http://ru.wikinews.org/w/ap... [22:33:39] (03CR) 10MarkTraceur: [C: 032] "Blam. You can leave the whisky with my driver, Jeeves." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158240 (owner: 10Neilk) [22:34:09] (03Merged) 10jenkins-bot: wait for ajax calls to complete [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158240 (owner: 10Neilk) [22:35:51] (03PS1) 10Legoktm: Update Thanks for I340665f211 [core] - 10https://gerrit.wikimedia.org/r/159209 [22:35:59] (03PS1) 10EBernhardson: Dismiss new-topic notification when visiting related Board [extensions/Flow] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159211 [22:36:18] (03CR) 10jenkins-bot: [V: 04-1] Update Thanks for I340665f211 [core] - 10https://gerrit.wikimedia.org/r/159209 (owner: 10Legoktm) [22:36:26] wat [22:36:34] crap. [22:36:40] (03Abandoned) 10Legoktm: Update Thanks for I340665f211 [core] - 10https://gerrit.wikimedia.org/r/159209 (owner: 10Legoktm) [22:38:36] (03PS1) 10Legoktm: Update Thanks for I340665f211 [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159212 [22:39:16] (03CR) 10EBernhardson: [C: 032] Dismiss new-topic notification when visiting related Board [extensions/Flow] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159211 (owner: 10EBernhardson) [22:39:50] (03Merged) 10jenkins-bot: Dismiss new-topic notification when visiting related Board [extensions/Flow] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159211 (owner: 10EBernhardson) [22:41:00] (03PS1) 10Legoktm: Update Thanks for I340665f211 [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159213 [22:42:43] (03PS2) 10EBernhardson: Bump Echo and Flow submodules in 1.24wmf20 [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159206 [22:44:17] (03PS1) 10PleaseStand: CurlHttpRequest: Check library version, not CURLOPT_REDIR_PROTOCOLS [core] - 10https://gerrit.wikimedia.org/r/159214 (https://bugzilla.wikimedia.org/70570) [22:49:20] (03PS1) 10Foxtrott: Rework of styles [skins/chameleon] - 10https://gerrit.wikimedia.org/r/159216 [22:51:10] (03CR) 10Foxtrott: [C: 032 V: 032] Rework of styles [skins/chameleon] - 10https://gerrit.wikimedia.org/r/159216 (owner: 10Foxtrott) [22:57:09] 3MediaWiki extensions / 3AbuseFilter: Add more variables to AbuseFilter file uploading evaluation - 10https://bugzilla.wikimedia.org/19565#c10 (10Andre Klapper) p:5High>3Normal [As long as nobody works on this ticket it de-facto will be low priority, no matter what the Priority field will be set to.] [22:57:09] 3MediaWiki extensions / 3AbuseFilter: Add more variables to AbuseFilter file uploading evaluation - 10https://bugzilla.wikimedia.org/19565 (10Andre Klapper) s:5normal>3enhanc [22:58:23] 3MediaWiki / 3MediaWiki UI: Create primary button with indeterminate loader - 10https://bugzilla.wikimedia.org/70417#c1 (10Matthew Flaschen) Please clarify here how you envision this working. Mockups attached to this bug may be helpful. That card has no description and the only mockup is apparently unrelat... [22:58:37] 3Wikimedia / 3Media storage: Stuck old 1024px thumbnail version of a specific djvu image on wikisource.pl - 10https://bugzilla.wikimedia.org/70189#c4 (10Andre Klapper) wieralee: You closed this as FIXED without a comment. How was this fixed? Any code commit? [23:01:23] 3MediaWiki / 3Interface: Typo in MediaWiki:Wikibase-otherprojects-beta-description - 10https://bugzilla.wikimedia.org/70587#c1 (10Andre Klapper) p:5Unprio>3Low s:5normal>3trivia That could be fixed in https://translatewiki.net/wiki/MediaWiki:Wikibase-otherprojects-beta-description/en?action=edit if y... [23:03:26] (03CR) 10EBernhardson: [C: 032] Submodule bump for Flow in 1.24wmf19 [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159208 (owner: 10EBernhardson) [23:04:01] (03CR) 10EBernhardson: [C: 032] Bump Echo and Flow submodules in 1.24wmf20 [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159206 (owner: 10EBernhardson) [23:06:03] (03CR) 10EBernhardson: [C: 032] Update Thanks for I340665f211 [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159212 (owner: 10Legoktm) [23:06:16] (03Merged) 10jenkins-bot: Submodule bump for Flow in 1.24wmf19 [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159208 (owner: 10EBernhardson) [23:06:18] (03CR) 10EBernhardson: [C: 032] Update Thanks for I340665f211 [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159213 (owner: 10Legoktm) [23:06:38] 3Wikimedia / 3SSL related: Enable HSTS on Wikimedia sites - 10https://bugzilla.wikimedia.org/38516 (10Matthew Flaschen) [23:06:58] (03Merged) 10jenkins-bot: Bump Echo and Flow submodules in 1.24wmf20 [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159206 (owner: 10EBernhardson) [23:07:06] (03CR) 10MaxSem: Have GettingStarted depend on PageImages (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/159186 (owner: 10Mattflaschen) [23:09:30] (03Merged) 10jenkins-bot: Update Thanks for I340665f211 [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/159212 (owner: 10Legoktm) [23:10:07] (03Merged) 10jenkins-bot: Update Thanks for I340665f211 [core] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159213 (owner: 10Legoktm) [23:12:47] (03PS1) 10Dduvall: Wiki installer now conditional on existence of database [vagrant] - 10https://gerrit.wikimedia.org/r/159217 (https://bugzilla.wikimedia.org/50912) [23:14:35] (03CR) 10Bartosz Dziewoński: "The proposed resource is a poor icon that doesn't represent well the thing it's meant to represent, does not match the skin (neither by sh" [skins/Vector] - 10https://gerrit.wikimedia.org/r/157990 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [23:15:38] (03CR) 10Bartosz Dziewoński: "Here's my proposal: https://dl.dropboxusercontent.com/u/10983006/tmp/user-icon.svg – this is the current icon, but with the ugly color sch" [skins/Vector] - 10https://gerrit.wikimedia.org/r/157990 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [23:16:32] (03CR) 10Jforrester: [C: 032] Add some missing qqq messages, remove unused messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155850 (owner: 10MarkTraceur) [23:17:00] (03Merged) 10jenkins-bot: Add some missing qqq messages, remove unused messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155850 (owner: 10MarkTraceur) [23:17:22] (03CR) 10Bartosz Dziewoński: "(For this flat icon, I'd use #999 or something similar; I kept the way-too-dark #565656 for comparison's sake.)" [skins/Vector] - 10https://gerrit.wikimedia.org/r/157990 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [23:20:14] (03PS6) 10Jforrester: Set up an npm test pipeline for JS, CSS and banana i18n messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 [23:21:00] (03CR) 10Jforrester: "PS6 is a rebase." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester) [23:22:54] 3MediaWiki extensions / 3WikidataClient: Typo in MediaWiki:Wikibase-otherprojects-beta-description - 10https://bugzilla.wikimedia.org/70587#c2 (10Bartosz Dziewoński) a:3Wikidata bugs It couldn't (probably), the page says "English is the source language and must be changed in the MediaWiki code. Changes her... [23:24:36] (03CR) 10Isarra: "+1 to everything Bartosz just said." [skins/Vector] - 10https://gerrit.wikimedia.org/r/157990 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [23:26:03] (03CR) 10Rillke: "The way code-review is carried out here *****: https://gerrit.wikimedia.org/r/139592" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158337 (https://bugzilla.wikimedia.org/65624) (owner: 10Gilles) [23:27:11] (03CR) 10Jorm: "Personally, I'd like to kill the icon entirely." [skins/Vector] - 10https://gerrit.wikimedia.org/r/157990 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [23:30:30] (03CR) 10Krinkle: Set up an npm test pipeline for JS, CSS and banana i18n messages (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester) [23:31:29] (03CR) 10Rillke: "Will someone merge this patch if I rebase it or are parts of it pushed though gerrit until it is " [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) (owner: 10Rillke) [23:32:22] (03CR) 10Bartosz Dziewoński: "Some screenshots in context for easier comparison, on a non-retina screen." [skins/Vector] - 10https://gerrit.wikimedia.org/r/157990 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [23:34:21] (03CR) 10Jforrester: Set up an npm test pipeline for JS, CSS and banana i18n messages (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester) [23:35:29] (03CR) 10Krinkle: [C: 04-1] Create title in file NS and validate as such (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) (owner: 10Rillke) [23:37:53] 3Wikimedia / 3Extension setup: Review and deploy GlobalUserPage extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/70576#c3 (10Kunal Mehta (Legoktm)) > 1. Create Extension: mediawiki.org page for developers and people who will > install or configure the extension. Done > 2. Create Help:Extensi... [23:40:16] (03PS7) 10MarkTraceur: Set up an npm test pipeline for JS, CSS and banana i18n messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester) [23:40:30] jackmcbarn: hmm actually, about https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Auto-subst [23:40:39] MatmaRex: what about it? [23:41:19] jackmcbarn: i'm not saying it's a good idea, but it could be done by placing a magic word on the template page. it's just have to be in , it'd add a prop to page_props table, and we'd look forthe prop in pre-save transform [23:42:03] perverse, but i see no reason why it wouldn't work if we wanted it :D [23:42:10] i maintain it's a WONTFIX [23:42:52] and that would be 100 times worse than auto fixing double redirects or auto retargeting based on category redirects etc etc [23:43:45] :D [23:44:16] (03PS1) 10Bsitu: Colors are backwards for flyout section link [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159222 [23:44:18] next time i have an idea for an over-the-top feature in the parser, remind me to bug you for the merge :P [23:44:43] (03CR) 10jenkins-bot: [V: 04-1] Colors are backwards for flyout section link [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159222 (owner: 10Bsitu) [23:45:40] haha [23:47:23] (03PS2) 10Bsitu: Colors are backwards for flyout section link [extensions/Echo] - 10https://gerrit.wikimedia.org/r/159222 [23:48:33] also, do you remember the vandal a while back that went over moderately-highly-used templates and put obscene text/images/ascii art, etc in them? imagine if he had that magic word [23:49:29] (03PS8) 10Jforrester: Set up an npm test pipeline for JS, CSS and banana i18n messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 [23:49:56] (03CR) 10Jforrester: Set up an npm test pipeline for JS, CSS and banana i18n messages (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester) [23:50:33] legoktm: it looks like if you merge but don't delete an account, the new account gets the autopromote stats, but the old account doesn't lose them. does that matter? [23:50:42] (re the flaggedrevs change) [23:50:48] (03CR) 10Bartosz Dziewoński: "I know nothing about curl or HHVM, sorry." [core] - 10https://gerrit.wikimedia.org/r/159214 (https://bugzilla.wikimedia.org/70570) (owner: 10PleaseStand) [23:54:14] 3MediaWiki / 3MediaWiki UI: Should Mediawiki UI change font-family for textareas? - 10https://bugzilla.wikimedia.org/70028 (10Bartosz Dziewoński)