[07:41:05] (03PS1) 10Gilles: Chunked upload result should consistently have a "stage" value [core] - 10https://gerrit.wikimedia.org/r/158593 [07:44:56] (03PS1) 10Swidmann: Added batch message for Notifications [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/158594 [07:56:27] (03CR) 10Nemo bis: [C: 031] "Nice! Looks sane, didn't test." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/158578 (https://bugzilla.wikimedia.org/70392) (owner: 10Legoktm) [07:56:56] 3MediaWiki extensions / 3CentralAuth: Allow to automatically unify on login absent clashes - 10https://bugzilla.wikimedia.org/70392 (10Nemo) p:5Unprio>3Normal [07:57:12] 3MediaWiki / 3Uploading: Uppercase picture extensions like .PNG are not allowed - 10https://bugzilla.wikimedia.org/66667#c7 (10Tiziano Müller) Can confirm bug in mediawiki 1.23.3 and yes, the logic behind that preg_match is definitely false. [07:58:27] (03CR) 10Legoktm: Auto-migrate matching accounts where no global account exists (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/158578 (https://bugzilla.wikimedia.org/70392) (owner: 10Legoktm) [07:59:01] (03PS2) 10Legoktm: Auto-migrate matching accounts where no global account exists [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/158578 (https://bugzilla.wikimedia.org/70392) [08:07:27] 3MediaWiki extensions / 3WikidataRepo: Badge for quality articles on Wikidata - 10https://bugzilla.wikimedia.org/70268#c2 (10atsirlin) It would be reasonable to use the blue star for good articles and leave the gray (or white, silver, green) star for quality articles. [08:21:12] 3MediaWiki / 3MediaWiki UI: page header search and index.php?search should use advanced input search control - 10https://bugzilla.wikimedia.org/70428#c1 (10Jon) s:5normal>3enhanc I looked at making the page header search box use mw-ui and it's more complicated as it has ajax auto complete when you searc... [08:22:17] heh, false reviews still pointing to true issues :p [08:22:57] 3MediaWiki / 3MediaWiki UI: Input fields should be relative to input strings - 10https://bugzilla.wikimedia.org/70404#c4 (10Jon) *** Bug 70425 has been marked as a duplicate of this bug. *** [08:22:57] 3MediaWiki / 3MediaWiki UI: Fields are too long in Special:Log - 10https://bugzilla.wikimedia.org/70425#c2 (10Jon) 5NEW>3RESO/DUP mw-ui-input needs a modifier class for smaller input fields. *** This bug has been marked as a duplicate of bug 70404 *** [08:25:41] 3MediaWiki / 3MediaWiki UI: Should Mediawiki UI change font-family for textareas? - 10https://bugzilla.wikimedia.org/70028#c9 (10Michael M.) (In reply to Matthew Flaschen from comment #8) > I suggest we make a .mw-ui-input-wikitext-page secondary class, that > respects this preference. It should apply when... [08:27:42] 3MediaWiki / 3MediaWiki UI: VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages - 10https://bugzilla.wikimedia.org/56363#c4 (10Jon) *** Bug 70426 has been marked as a duplicate of this bug. *** [08:27:42] 3MediaWiki / 3MediaWiki UI: Special:ChangeEmail buttons are incorrect style, missing margin, and in wrong order - 10https://bugzilla.wikimedia.org/70426#c1 (10Jon) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 56363 *** [08:28:27] 3MediaWiki / 3MediaWiki UI: VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages - 10https://bugzilla.wikimedia.org/56363#c5 (10Jon) Should we also remove the cancel button as part of this? It seems strange to have a cancel button in this cont... [08:32:27] 3MediaWiki / 3MediaWiki UI: componentize compact personal bar code into general list control - 10https://bugzilla.wikimedia.org/70433#c1 (10Jon) s:5normal>3enhanc Please provide documentation for this and examples of where it is being used outside this project. * Is this mw-ui-menu? * When does one use... [08:32:34] (03PS9) 10Legoktm: Update Special:ChangeEmail to use HTMLForm [core] - 10https://gerrit.wikimedia.org/r/142878 (owner: 10IAlex) [08:34:42] 3MediaWiki extensions / 3WikidataRepo: Remove assertTag usages from tests - 10https://bugzilla.wikimedia.org/67122#c2 (10Bene*) Note that this extension introduces a new test base class while we rather need some service class to check html. As far as I can see the plugin does not add so much code so we can a... [08:37:39] (03CR) 10Legoktm: [C: 032] Update Special:ChangeEmail to use HTMLForm [core] - 10https://gerrit.wikimedia.org/r/142878 (owner: 10IAlex) [08:40:27] 3MediaWiki / 3MediaWiki UI: Advanced input type "search" is needed - 10https://bugzilla.wikimedia.org/70427#c1 (10Jon) s:5normal>3enhanc The card isn't very clear (it's just a picture). It would be good to state in the bug what is being asked. I'm going to assume from the title this is just about the sea... [08:40:54] (03CR) 10Legoktm: [C: 031] "This moves the email stuff before the SetupAfterCache hook now, I don't think that's an issue but just wanted to note that." [core] - 10https://gerrit.wikimedia.org/r/151768 (owner: 10IAlex) [08:41:18] (03PS2) 10Legoktm: Use session_id() instead of $wgSessionStarted to check for session existence [extensions/SocialLogin] - 10https://gerrit.wikimedia.org/r/121250 (owner: 10IAlex) [08:41:35] (03CR) 10Legoktm: [C: 032] Use session_id() instead of $wgSessionStarted to check for session existence [extensions/SocialLogin] - 10https://gerrit.wikimedia.org/r/121250 (owner: 10IAlex) [08:41:39] (03Merged) 10jenkins-bot: Use session_id() instead of $wgSessionStarted to check for session existence [extensions/SocialLogin] - 10https://gerrit.wikimedia.org/r/121250 (owner: 10IAlex) [08:41:41] (03PS1) 10Smuggli: Reverted some extendedsearch stylings [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/158596 [08:41:54] (03CR) 10Legoktm: [C: 04-1] "Needs rebase" [extensions/FacebookOpenGraph] - 10https://gerrit.wikimedia.org/r/121243 (owner: 10IAlex) [08:44:38] (03PS1) 10Smuggli: Improved stylings [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/158597 [08:44:46] (03CR) 10Smuggli: [C: 032 V: 032] Reverted some extendedsearch stylings [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/158596 (owner: 10Smuggli) [08:45:07] (03CR) 10Legoktm: Replace $wgConf->localVHosts by $wgLocalVirtualHosts (032 comments) [core] - 10https://gerrit.wikimedia.org/r/157712 (owner: 10IAlex) [08:45:11] (03CR) 10Smuggli: [C: 032 V: 032] Improved stylings [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/158597 (owner: 10Smuggli) [08:48:20] (03PS1) 10Pastakhov: make compatible with toolbox (v 2.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/158598 [08:48:22] (03CR) 10Legoktm: [C: 031] Use as strict comparison to check whether an user name was provided in Special:ListFiles [core] - 10https://gerrit.wikimedia.org/r/156688 (owner: 10IAlex) [08:49:50] (03PS2) 10Pastakhov: make compatible with toolbox (v 2.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/158598 [08:50:12] 3MediaWiki / 3MediaWiki UI: VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages - 10https://bugzilla.wikimedia.org/56363#c6 (10Kunal Mehta (Legoktm)) Change-Id: I629cee4264fad6cde98495c0e8daffe5ea245b48 converted Special:ChangeEmail to use HT... [08:50:38] (03CR) 10Legoktm: [C: 04-1] "Needs rebase" [core] - 10https://gerrit.wikimedia.org/r/121975 (https://bugzilla.wikimedia.org/56363) (owner: 10Ganeshaditya1) [08:51:20] (03PS3) 10Pastakhov: make compatible with toolbox (v 2.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/158598 [08:52:03] (03CR) 10Smuggli: [C: 031 V: 031] Added batch message for Notifications [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/158594 (owner: 10Swidmann) [08:52:59] (03CR) 10Smuggli: [C: 031] display for links in widgets changed [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/158592 (owner: 10Tweichart) [08:53:42] (03CR) 10Smuggli: [C: 031] Added fontweight [skins/BlueSpiceSkin] (REL1_22) - 10https://gerrit.wikimedia.org/r/158591 (owner: 10Swidmann) [08:54:37] (03CR) 10Legoktm: [C: 032] Provide own arrow images [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/158551 (https://bugzilla.wikimedia.org/70412) (owner: 10Bartosz Dziewoński) [08:54:45] (03Merged) 10jenkins-bot: Provide own arrow images [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/158551 (https://bugzilla.wikimedia.org/70412) (owner: 10Bartosz Dziewoński) [08:54:59] (03Merged) 10jenkins-bot: Update Special:ChangeEmail to use HTMLForm [core] - 10https://gerrit.wikimedia.org/r/142878 (owner: 10IAlex) [08:55:42] 3MediaWiki extensions / 3LiquidThreads: LQT: [Regression 1.24wmf20] Pagination arrows have been moved - 10https://bugzilla.wikimedia.org/70412#c4 (10Kunal Mehta (Legoktm)) Marking for WMF backport... [08:57:02] (03CR) 10Swidmann: [C: 032 V: 032] display for links in widgets changed [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/158592 (owner: 10Tweichart) [09:01:32] (03CR) 10JanZerebecki: [C: 031] "Yes hostkeys-collect is a better idea than this." [tools/scap] - 10https://gerrit.wikimedia.org/r/148112 (owner: 10BryanDavis) [09:02:14] (03PS1) 10Smuggli: Removed use of deprecated method [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/158600 [09:02:31] (03CR) 10JanZerebecki: [C: 04-1] "Err that should have been -1." [tools/scap] - 10https://gerrit.wikimedia.org/r/148112 (owner: 10BryanDavis) [09:17:55] manybubbles: ? [09:18:36] manybubbles: https://en.wikipedia.org/w/index.php?title=Special:Search&search=redirects%20for%20discussion&fulltext=Search&profile=all [09:19:01] manybubbles: note "The Rock". it shows the content of the redirected page, but links to the target of the redirect it seems.... [09:24:13] 3MediaWiki extensions / 3WikidataRepo: Rewrite SpecialMergeItems based on ItemMergeInteractor - 10https://bugzilla.wikimedia.org/69106#c1 (10tobias.gritschacher) 5NEW>3RESO/FIX https://gerrit.wikimedia.org/r/#/c/152148/ [09:24:28] 3MediaWiki extensions / 3WikidataRepo: Create jQuery fingerprintview widget - 10https://bugzilla.wikimedia.org/69840 (10tobias.gritschacher) 5PATC>3RESO/FIX [09:24:42] 3MediaWiki extensions / 3WikidataRepo: Create jQuery fingerprintlistview widget - 10https://bugzilla.wikimedia.org/69839 (10tobias.gritschacher) 5PATC>3RESO/FIX [09:24:43] 3MediaWiki extensions / 3WikidataRepo: Integrate aliases into fingerprintview - 10https://bugzilla.wikimedia.org/70033 (10tobias.gritschacher) 5PATC>3RESO/FIX [09:26:10] (03PS8) 10Jdlrobson: Hygiene: Kill ifEquals helper, use ifCond instead [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156720 [09:28:02] (03PS4) 10Pastakhov: make compatible with toolbox (v 2.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/158598 [09:31:18] (03PS1) 10Legoktm: Rewrite #2 of caching logic [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/158603 [09:31:20] (03PS1) 10Legoktm: Do some instance caching in GlobalUserPage::displayGlobalPage() [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/158604 [09:31:22] (03PS1) 10Legoktm: Add basic support for showing a footer at the bottom of global user pages [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/158605 (https://bugzilla.wikimedia.org/66931) [09:31:32] (03CR) 10jenkins-bot: [V: 04-1] Add basic support for showing a footer at the bottom of global user pages [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/158605 (https://bugzilla.wikimedia.org/66931) (owner: 10Legoktm) [09:32:23] (03PS2) 10Legoktm: Add basic support for showing a footer at the bottom of global user pages [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/158605 (https://bugzilla.wikimedia.org/66931) [09:34:06] (03CR) 10Jdlrobson: Hygiene: Kill ifEquals helper, use ifCond instead (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156720 (owner: 10Jdlrobson) [09:34:16] (03PS9) 10Jdlrobson: Update classes of topic during close/reopen actions. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156739 (https://bugzilla.wikimedia.org/68328) [09:39:43] (03CR) 10Jdlrobson: [C: 04-1] "I'm still getting an exception.." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158302 (owner: 10Bsitu) [09:41:23] (03PS2) 10Legoktm: Rewrite #2 of caching logic [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/158603 [09:41:39] (03PS2) 10Legoktm: Do some instance caching in GlobalUserPage::displayGlobalPage() [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/158604 [09:41:40] (03PS3) 10Legoktm: Add basic support for showing a footer at the bottom of global user pages [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/158605 (https://bugzilla.wikimedia.org/66931) [09:50:53] thedj: there were several changes to handling of redirects, I'd try a null edit first [09:51:12] (or dummy edit? can't remember if null is enough for reindex) [09:51:43] Nemo_bis: ? for what ? [09:51:54] (03PS4) 10Legoktm: Add basic support for showing a footer at the bottom of global user pages [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/158605 (https://bugzilla.wikimedia.org/66931) [09:52:18] (03PS5) 10Pastakhov: make compatible with toolbox (v 2.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/158598 [09:52:28] (03CR) 10Legoktm: "+71, -194!" [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/158603 (owner: 10Legoktm) [09:52:31] Nemo_bis: ah, you mean for my comment to manybubbles ... [09:53:12] Nemo_bis: sorry, i answered a few other questions on redirects as well, so got myself confused :) [09:53:59] lol, fully protected https://en.wikipedia.org/w/index.php?title=The_Rock_%28entertainer%29&action=edit [09:54:21] since 2008 [09:56:56] (03PS2) 10Jdlrobson: Preview of Summarize displays as empty [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158142 (https://bugzilla.wikimedia.org/70200) (owner: 10Bsitu) [09:57:30] (03CR) 10Jdlrobson: [C: 032] "Happy to merge with the test and on basis we will revisit this function later." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158142 (https://bugzilla.wikimedia.org/70200) (owner: 10Bsitu) [09:57:59] (03PS5) 10Legoktm: Add basic support for showing a footer at the bottom of global user pages [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/158605 (https://bugzilla.wikimedia.org/66931) [09:58:04] (03Merged) 10jenkins-bot: Preview of Summarize displays as empty [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158142 (https://bugzilla.wikimedia.org/70200) (owner: 10Bsitu) [10:00:07] (03CR) 10Legoktm: "Screenshot of the footer: http://cl.ly/image/3E2r0T062A0j" [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/158605 (https://bugzilla.wikimedia.org/66931) (owner: 10Legoktm) [10:01:31] being able to do an API request with action=parse|query would be really cool [10:05:45] (03CR) 10Jdlrobson: [C: 032] Allow .mw-echo-title-heading outside special page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158572 (owner: 10EBernhardson) [10:05:52] (03PS24) 10TheDJ: mediawiki.action.edit: Autosave edit textareas in localStorage [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [10:06:14] (03Merged) 10jenkins-bot: Allow .mw-echo-title-heading outside special page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158572 (owner: 10EBernhardson) [10:06:27] 3Wikimedia / 3Wikidata: Provide config for dispatch-lag-monitoring script - 10https://bugzilla.wikimedia.org/66070 (10Jan Zerebecki) 5PATC>3RESO/FIX [10:06:42] (03PS1) 10Tweichart: css changes [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/158608 [10:11:34] (03CR) 10Pastakhov: [C: 032] make compatible with toolbox (v 2.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/158598 (owner: 10Pastakhov) [10:11:38] (03Merged) 10jenkins-bot: make compatible with toolbox (v 2.0.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/158598 (owner: 10Pastakhov) [10:12:34] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.action.edit: Autosave edit textareas in localStorage [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [10:16:53] (03PS25) 10TheDJ: mediawiki.action.edit: Autosave edit textareas in localStorage [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [10:17:52] (03CR) 10TheDJ: "Rebased in PS24 and dealt with PS23 comments in PS25" [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [10:21:43] (03PS1) 10Legoktm: APIQueryInfo: Allow fetching the canonical url of a page [core] - 10https://gerrit.wikimedia.org/r/158609 [10:27:32] (03PS6) 10Legoktm: Add basic support for showing a footer at the bottom of global user pages [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/158605 (https://bugzilla.wikimedia.org/66931) [10:28:12] (03CR) 10Legoktm: "Does not depend upon, but will be enhanced by If0f62481d059815390b74ccf8167957bc1dbce52 in core." [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/158605 (https://bugzilla.wikimedia.org/66931) (owner: 10Legoktm) [10:31:14] 3MediaWiki extensions / 3GlobalUserPage: Help documentation should mention the cache time - 10https://bugzilla.wikimedia.org/66934#c4 (10Kunal Mehta (Legoktm)) 5NEW>3RESO/FIX a:3Quiddity I32cd876485398b5b860c375797e70bb7d8e31cd9 re-does the caching thing, but I'm closing this since it is now documented... [10:31:26] 3MediaWiki / 3Documentation: Documentation is out of date, incomplete (tracking) - 10https://bugzilla.wikimedia.org/1 (10Kunal Mehta (Legoktm)) [10:35:40] (03PS3) 10TheDJ: Add a jQuery promise lib around indexedDB [core] - 10https://gerrit.wikimedia.org/r/157818 [10:36:08] (03PS1) 10Legoktm: Add globaluserpage role [vagrant] - 10https://gerrit.wikimedia.org/r/158610 [10:36:16] (03CR) 10jenkins-bot: [V: 04-1] Add globaluserpage role [vagrant] - 10https://gerrit.wikimedia.org/r/158610 (owner: 10Legoktm) [10:36:51] (03PS2) 10Legoktm: Add globaluserpage role [vagrant] - 10https://gerrit.wikimedia.org/r/158610 [10:37:20] I didn't realize we -1 for whitespace now >.< [10:38:10] (03PS26) 10TheDJ: mediawiki.action.edit: Autosave edit textareas in localStorage [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [10:42:39] (03PS4) 10Jdlrobson: WIP: Timestamp helper fixes for old things [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158100 (https://bugzilla.wikimedia.org/59919) [10:43:15] (03CR) 10jenkins-bot: [V: 04-1] WIP: Timestamp helper fixes for old things [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158100 (https://bugzilla.wikimedia.org/59919) (owner: 10Jdlrobson) [10:43:30] (03PS1) 10Pastakhov: fix fluent Interface for Find&Replace (v 2.0.1) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/158611 [10:45:13] (03CR) 10Pastakhov: [C: 032] fix fluent Interface for Find&Replace (v 2.0.1) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/158611 (owner: 10Pastakhov) [10:45:17] (03Merged) 10jenkins-bot: fix fluent Interface for Find&Replace (v 2.0.1) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/158611 (owner: 10Pastakhov) [10:46:57] 3Wikimedia / 3Media storage: "Original file" seems to be missing at Commons for an image - 10https://bugzilla.wikimedia.org/70416 (10Andre Klapper) p:5Unprio>3Normal [10:47:39] (03CR) 10Jdlrobson: [C: 032] Replace Mantle's EventEmitter with oojs's [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/155593 (owner: 10Catrope) [10:48:04] (03Merged) 10jenkins-bot: Replace Mantle's EventEmitter with oojs's [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/155593 (owner: 10Catrope) [10:48:28] 3Wikimedia / 3General/Unknown: Deploy HHVM for all users - 10https://bugzilla.wikimedia.org/70418#c5 (10Andre Klapper) [adding "hiphop" keyword] [10:58:25] (03CR) 10Bartosz Dziewoński: [C: 04-2] Remove deprecated 1.17-1.18 Javascript functions from legacy wikibits [core] - 10https://gerrit.wikimedia.org/r/139612 (owner: 10Withoutaname) [10:59:57] 3MediaWiki / 3Email: Long article URLs in email body due to encoding for non-ASCII scripts - 10https://bugzilla.wikimedia.org/70245#c3 (10Andre Klapper) p:5Unprio>3Low I would still prefer to "make everyone suffer" to having broken links in email clients which don't interpret bytes correctly. Now if that... [11:00:27] 3MediaWiki / 3Revision deletion: Changing the visibility of a log event should also change the visibility of the corresponding null revision - 10https://bugzilla.wikimedia.org/70261 (10Andre Klapper) p:5Unprio>3Low s:5normal>3minor [11:00:42] 3MediaWiki / 3General/Unknown: POST boolean fields ignored without = - 10https://bugzilla.wikimedia.org/70260 (10Andre Klapper) p:5Normal>3Low [11:00:56] 3MediaWiki extensions / 3ProofreadPage: WikiEditor loads in different places in the Page namespace depending upon which user preferences are selected - 10https://bugzilla.wikimedia.org/70431 (10Andre Klapper) p:5Unprio>3Low [11:03:43] 3Wikimedia / 3Site requests: Set $wgLegacyJavaScriptGlobals = false on ptwiki and ptwikibooks - 10https://bugzilla.wikimedia.org/70366 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc [11:05:12] 3MediaWiki / 3General/Unknown: wfShellExec() causes web-installer (and possible more) to hang - 10https://bugzilla.wikimedia.org/70357 (10Andre Klapper) p:5Unprio>3Normal [11:05:42] 3Wikimedia / 3SSL related: Some Wikimedia servers don't send intermediary certificates - 10https://bugzilla.wikimedia.org/70326 (10Andre Klapper) p:5Unprio>3Normal [11:05:57] 3MediaWiki / 3Installer: Installer should check for posix_uname - 10https://bugzilla.wikimedia.org/70306 (10Andre Klapper) p:5Unprio>3Normal [11:21:26] 3MediaWiki / 3History/Diffs: diffs do not respect DISPLAYTITLE - 10https://bugzilla.wikimedia.org/70275 (10Andre Klapper) p:5Unprio>3Low [11:21:42] 3MediaWiki / 3History/Diffs: page revision history /<h1> do not respect DISPLAYTITLE - 10https://bugzilla.wikimedia.org/70274 (10Andre Klapper) p:5Unprio>3Low [11:24:52] <grrrit-wm> (03CR) 10Smuggli: [C: 04-1] "No more facet styling changes because they break functionality. All other changes should be made in extendedsearch.css to avoid redundant " [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/158608 (owner: 10Tweichart) [11:31:56] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Badge for quality articles on Wikidata - 10https://bugzilla.wikimedia.org/70268#c3 (10Yaroslav Blanter) Either what atsirlin says, or make a "bronze" star. Ideally, we should be able to choose symbols at the project sidebar ourselves, so that it is not as much important... [11:33:42] <wikibugs> 3MediaWiki / 3Email: Long article URLs in email body due to encoding for non-ASCII scripts - 10https://bugzilla.wikimedia.org/70245#c4 (10Nasir Khan Saikat) Hi Andre, thanks for expressing your thoughts. I believe you know that Echo (Notifications) sends email in HTML format, which is way more cleaner, us... [11:48:25] <grrrit-wm> (03CR) 10Tweichart: "this changes doesn't break functionality. it just finishes the styling once being started. and actually it makes sense to style it in the " [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/158608 (owner: 10Tweichart) [11:53:41] <grrrit-wm> (03PS2) 10Tweichart: minor renaming for the shoutbox [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/158095 [12:07:29] <wikibugs> 3MediaWiki / 3Email: Long article URLs in watchlist notification email body due to encoding for non-ASCII scripts - 10https://bugzilla.wikimedia.org/70245#c5 (10Andre Klapper) Echo: I checked the source of the last email message that I received from *Echo* on test2: Echo sends an email in both plain and HTML... [12:11:57] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Badge for quality articles on Wikidata - 10https://bugzilla.wikimedia.org/70268#c4 (10Bene*) Just a note: I'm not talking about which icons should be used on client wikis like Wikipedia because they can just do that themselves. I mean the icons used on Wikidata in the "... [12:15:42] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Badge for quality articles on Wikidata - 10https://bugzilla.wikimedia.org/70268#c5 (10Yaroslav Blanter) Exactly, this is what I mean. Either a "bronze" icon, or the default blue icon, or make GA blue and QA silver. My preferred option is "bronze", but I can live with an... [12:15:56] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Badge for quality articles on Wikidata - 10https://bugzilla.wikimedia.org/70268#c6 (10atsirlin) If featured=gold badge and good=silver badge, then quality articles should use the bronze badge. That would be logical. [12:27:44] <grrrit-wm> (03PS2) 10TTO: Add --prefix parameter to importDump.php [core] - 10https://gerrit.wikimedia.org/r/157766 (https://bugzilla.wikimedia.org/70272) (owner: 10leucosticte) [12:32:56] <wikibugs> 3Wikimedia / 3General/Unknown: Add ContentHandler columns to Wikimedia wikis, and set $wgContentHandlerUseDB = true - 10https://bugzilla.wikimedia.org/49193#c8 (10Kunal Mehta (Legoktm)) [05:29:18] <springle> legoktm: s3 content model fields are complete That'll let us turn it on testwiki, test2wiki, an... [12:36:24] <grrrit-wm> (03PS17) 10Phuedx: Add icon mixins to mediawiki.ui [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) [12:37:17] <grrrit-wm> (03PS6) 10Paladox: Add support for svg in .list-style-image [core] - 10https://gerrit.wikimedia.org/r/158505 [12:37:22] <grrrit-wm> (03Abandoned) 10Phuedx: Test .mw-ui-icon classes and mixins [core] - 10https://gerrit.wikimedia.org/r/144141 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx) [12:39:35] <grrrit-wm> (03PS7) 10Umherirrender: Parser: Clean up handling of editsections by using local variables [core] - 10https://gerrit.wikimedia.org/r/144182 [12:48:51] <grrrit-wm> (03CR) 10Smuggli: [C: 032 V: 032] Added batch message for Notifications [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/158594 (owner: 10Swidmann) [12:50:00] <grrrit-wm> (03CR) 10Phuedx: "This might not quite be what you laid out in your drawing but I think it provides a flexible foundation for people wanting to put icons on" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx) [12:52:13] <grrrit-wm> (03PS1) 10Smuggli: One suggestion is enough [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/158615 [12:52:38] <grrrit-wm> (03CR) 10Smuggli: [C: 032 V: 032] One suggestion is enough [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/158615 (owner: 10Smuggli) [12:56:29] <wikibugs> 3Wiki Loves Monuments: WML upload wizard adds {{location}} instead of {{object location}} templates - 10https://bugzilla.wikimedia.org/70437 (10Jarek Tuszynski) 3NEW p:3Unprio s:3major a:3None Expected Results: Wiki Loves Monuments upload wizard (at least the Swedish version) automatically adds {{loc... [13:01:05] <wctaiwan> hi Carmela [13:01:18] <wctaiwan> I think I might just need to do a git pull to fix it; let me check [13:03:21] <wctaiwan> Carmela: should be fixed [13:03:37] <wctaiwan> (it was the new token API) [13:04:00] <Carmela> Cool, thanks. [13:04:09] <wctaiwan> np, thanks for catching it. [13:04:13] <wikibugs> 3Wiki Loves Monuments: WML upload wizard adds {{location}} instead of {{object location}} templates - 10https://bugzilla.wikimedia.org/70437#c1 (10Maarten Dammers) 5NEW>3RESO/FIX a:3Maarten Dammers People should add the lat/lon to the upload wizard. The upload wizard expects lat/lon for {{location}} and... [13:04:30] <Carmela> wctaiwan: http://mm-ch.wmflabs.org/wiki/Special:CreateMassMessageList # The "Content:" options are still a bit wonky here. [13:04:33] <Carmela> I guess "Source:" probably should only display if you select the other option? [13:04:38] <Carmela> Maybe a drop-down menu would be cleaner. [13:05:18] <wctaiwan> Source should be disabled if you have the first option selected. [13:05:23] <wctaiwan> Firefox doesn't really make that clear :/ [13:05:37] <Carmela> Oh, yeah, it is disabled. [13:05:41] <Carmela> Perhaps it can just be hidden? [13:06:55] <Carmela> It looks like interwiki links are still allowed? [13:06:56] <Carmela> http://mm-ch.wmflabs.org/wiki/Fdsjfsdklfjsklf [13:07:12] <Carmela> Hmmm, maybe w: isn't valid there. [13:07:20] <Carmela> Ah, that's it. [13:07:29] * wctaiwan checks [13:07:48] <Carmela> wikipedia:foo was successfully blocked. [13:08:53] <wctaiwan> yeah, you shouldn't be able to add interwikis [13:09:03] <wctaiwan> if ( !$title || $title->isSpecialPage() || $title->isExternal() ) { [13:09:03] <wctaiwan> $result['errors'] = array( 'invalidtitle' ); [13:09:05] <Carmela> If I input "#fff", I get "API Error: massmessage-ch-apierror" [13:09:15] <grrrit-wm> (03PS5) 10Jdlrobson: Timestamp helper fixes for old things [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158100 (https://bugzilla.wikimedia.org/59919) [13:10:08] <Carmela> "Remove this page from the list?" could probably just be "Are you sure?" [13:10:42] <wctaiwan> I think the current wording is better (it makes the action clear), though it doesn't matter much either way [13:10:57] <Carmela> The "#fff" thing seems goofy. [13:11:07] <Carmela> We probably shouldn't expose internal errors to users directly. [13:12:02] <wctaiwan> yeah, I'm looking at that. [13:12:26] <Carmela> It also seems a bit goofy that "Media:Foo" is accepted. [13:12:32] <Carmela> Cool. [13:12:59] <wikibugs> 3MediaWiki extensions / 3BetaFeatures: BetaFeatures should have means to provide a custom note on-wiki - 10https://bugzilla.wikimedia.org/70438 (10Gryllida) 3UNCO p:3Unprio s:3normal a:3None I'd like to enable a new beta feature on a wiki, but I wouldn't like the users to enable it thoughtlessly, as... [13:14:52] <wctaiwan> hmm, I should probably talk about that with legoktm [13:15:09] <wctaiwan> previously and with the current implementation, all the namespace checks are done at delivery time (I think) [13:15:25] <wctaiwan> I'm not sure if we should stop people from adding pages that can't legally be delivered to [13:16:41] <Carmela> If we're stopping "Special:foo", we should stop "Media:foo", I think. [13:20:18] <wctaiwan> I'll go over that one with lego when he's around; special page was easier because I could just check $title->isSpecialPage() [13:21:05] <wctaiwan> I guess getNamespace and then checking against NS_MEDIA (?) would work too... [13:23:20] <wctaiwan> Carmela: okay, I can probably implement that [13:24:27] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Support statements on properties in WikibaseDataModel - 10https://bugzilla.wikimedia.org/70035#c2 (10tobias.gritschacher) 5ASSI>3PATC https://github.com/wmde/WikibaseDataModel/pull/182 [13:25:27] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Support statements on properties in WikibaseDataModel - 10https://bugzilla.wikimedia.org/70035#c3 (10tobias.gritschacher) (In reply to Jeroen De Dauw from comment #1) > > in DataModel 1.0 > > ??? Why specify the version number here? It won't be in 1.0 :) Probably will... [13:26:07] <grrrit-wm> (03CR) 10Qgil: "The last version of this changeset is now more than one year old. Is it still a candidate to be merged or should it be improved / abandone" [core] - 10https://gerrit.wikimedia.org/r/20500 (https://bugzilla.wikimedia.org/39466) (owner: 10MarkAHershberger) [13:27:12] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Badge for quality articles on Wikidata - 10https://bugzilla.wikimedia.org/70268#c7 (10Stryn) (In reply to atsirlin from comment #6) > If featured=gold badge and good=silver badge, then quality articles should > use the bronze badge. That would be logical. I agree with... [13:27:51] <grrrit-wm> (03CR) 10Qgil: "After all the work, now this review is stalled since January. Is it ready to be merged oir should it be improved / abandoned?" [core] - 10https://gerrit.wikimedia.org/r/22167 (owner: 10Parent5446) [13:29:12] <wikibugs> 3MediaWiki extensions / 3WikidataClient: "Invalid token" error when trying to add language link from Wikipedia - 10https://bugzilla.wikimedia.org/70415#c10 (10tobias.gritschacher) 5NEW>3RESO/FIX Should be fixed in https://gerrit.wikimedia.org/r/#/c/158599/ [13:29:55] <wctaiwan> okay, found the bug causing #FFF to throw an API error [13:32:14] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Support statements on properties in WikibaseDataModel - 10https://bugzilla.wikimedia.org/70035 (10tobias.gritschacher) 5PATC>3RESO/FIX [13:32:33] <grrrit-wm> (03PS2) 10IAlex: Replace $wgConf->localVHosts by $wgLocalVirtualHosts [core] - 10https://gerrit.wikimedia.org/r/157712 [13:32:36] <grrrit-wm> (03CR) 10Qgil: "The last version of this patschet is almost two years old. One of the oldest open reviews around. Is it still a candidate to be merged or " [core] - 10https://gerrit.wikimedia.org/r/24619 (owner: 10Tim Landscheidt) [13:32:42] <grrrit-wm> (03PS3) 10IAlex: Replace $wgConf->localVHosts by $wgLocalVirtualHosts [core] - 10https://gerrit.wikimedia.org/r/157712 [13:33:07] <grrrit-wm> (03PS8) 10Umherirrender: Refactor: Use local variables for editsections in Parser [core] - 10https://gerrit.wikimedia.org/r/144182 [13:33:42] <grrrit-wm> (03PS4) 10IAlex: Replace $wgConf->localVHosts by $wgLocalVirtualHosts [core] - 10https://gerrit.wikimedia.org/r/157712 [13:34:01] <grrrit-wm> (03CR) 10IAlex: Replace $wgConf->localVHosts by $wgLocalVirtualHosts (032 comments) [core] - 10https://gerrit.wikimedia.org/r/157712 (owner: 10IAlex) [13:34:16] <wctaiwan> I'll wait until the branch has been merged to upload a fix to avoid redoing the merge commit (again) since I think it's possible the merge would happen within the next couple of days [13:34:38] <grrrit-wm> (03Abandoned) 10Umherirrender: Set page_latest for ChangesListTests [core] - 10https://gerrit.wikimedia.org/r/153051 (owner: 10Umherirrender) [13:34:40] <grrrit-wm> (03CR) 10IAlex: "- Added missing @since" [core] - 10https://gerrit.wikimedia.org/r/157712 (owner: 10IAlex) [13:42:59] <wikibugs> 3Wikimedia / 3Site requests: Enable Autopatrol and patrol user group and RC patol for lv wiki - 10https://bugzilla.wikimedia.org/70441 (10Papuass) 3NEW p:3Unprio s:3normal a:3None Please enable autopatrol user group and RC patrolling as per configuration given below 'lvwiki' => array( 'pat... [13:45:29] <wikibugs> 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Allow configuration of merge settings - 10https://bugzilla.wikimedia.org/70442 (10Nik Everett) 3NEW p:3Unprio s:3normal a:3None I've manually applied segments per tier and max merge at once settings to enwiki's content index and it seemed to help s... [13:51:26] <wikibugs> 3Wikimedia / 3Site requests: Enable Autopatrol and patrol user group and RC patrol for lv wiki - 10https://bugzilla.wikimedia.org/70441 (10Papuass) [13:52:27] <wikibugs> 3MediaWiki extensions / 3BetaFeatures: BetaFeatures should have means to provide a custom note on-wiki - 10https://bugzilla.wikimedia.org/70438#c1 (10Andre Klapper) s:5normal>3enhanc Hmm. Does that sound like a common usecase, or rather like something that you could hack up yourself if really wanted? I d... [13:53:27] <wikibugs> 3Wikimedia / 3Site requests: Enable Autopatrol and patrol user group and RC patrol for lv wiki - 10https://bugzilla.wikimedia.org/70441 (10Andre Klapper) p:5Unprio>3Normal s:5normal>3enhanc [13:56:07] <grrrit-wm> (03PS1) 10Jforrester: Provide own arrow images [extensions/LiquidThreads] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/158617 (https://bugzilla.wikimedia.org/70412) [13:56:07] <grrrit-wm> (03CR) 10Qgil: "Another very very old patch that could see some move in a direction or another." [core] - 10https://gerrit.wikimedia.org/r/26958 (owner: 10Tim Landscheidt) [14:02:24] <grrrit-wm> (03PS1) 10Jdlrobson: WIP: Hide reply and edit links in locked posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158618 [14:02:28] <grrrit-wm> (03CR) 10Qgil: "Very old patch welcoming an action in a direction or another. It mentions "search", so I added Chad and Nik just in case it helps." [core] - 10https://gerrit.wikimedia.org/r/27049 (owner: 10Tim Landscheidt) [14:02:28] <grrrit-wm> (03PS1) 10Bartosz Dziewoński: Typo fix: HMTL → HTML [core] - 10https://gerrit.wikimedia.org/r/158619 [14:02:29] <wikibugs> 3MediaWiki extensions / 3WikidataClient: Cache sitelinks and other related info in ParserOutput, avoid lookups in skin hooks - 10https://bugzilla.wikimedia.org/70393 (10tobias.gritschacher) 5PATC>3RESO/FIX [14:02:31] <grrrit-wm> (03CR) 10Qgil: [C: 04-1] "1/2 was rejected by Hoo man a long time ago. Assuming that 2/2 is -1, then." [core] - 10https://gerrit.wikimedia.org/r/65310 (owner: 10Ruud Koot) [14:02:31] <grrrit-wm> (03PS2) 10Umherirrender: Add tests for User::getCanonicalName() [core] - 10https://gerrit.wikimedia.org/r/156159 [14:02:32] <grrrit-wm> (03CR) 10Qgil: "This patchset is more than a year old now. Is it still open for review or should it be improved / abandoned?" [core] - 10https://gerrit.wikimedia.org/r/71759 (owner: 10Yurik) [14:02:35] <grrrit-wm> (03CR) 10Qgil: [C: 04-1] "For some reason Nemo's -1 wasn't computed?" [core] - 10https://gerrit.wikimedia.org/r/61602 (https://bugzilla.wikimedia.org/47342) (owner: 10Prageck) [14:02:35] <grrrit-wm> (03PS2) 10Chad: Reset searchTerms[] before populating. [core] - 10https://gerrit.wikimedia.org/r/27049 (owner: 10Tim Landscheidt) [14:02:36] <grrrit-wm> (03CR) 10Chad: [C: 032] "PS2 was just a rebase." [core] - 10https://gerrit.wikimedia.org/r/27049 (owner: 10Tim Landscheidt) [14:02:36] <grrrit-wm> (03CR) 10Anomie: Chunked upload result should consistently have a "stage" value (032 comments) [core] - 10https://gerrit.wikimedia.org/r/158593 (owner: 10Gilles) [14:02:40] <grrrit-wm> (03Merged) 10jenkins-bot: Reset searchTerms[] before populating. [core] - 10https://gerrit.wikimedia.org/r/27049 (owner: 10Tim Landscheidt) [14:02:41] <grrrit-wm> (03CR) 10Anomie: Add method XmlSelect::addAttributes() and use it in HTMLSelectField (031 comment) [core] - 10https://gerrit.wikimedia.org/r/144671 (owner: 10IAlex) [14:02:43] <wikibugs> 3MediaWiki extensions / 3WikidataClient: other projects feature broken with $wgEnableSidebarCache = true - 10https://bugzilla.wikimedia.org/70234 (10tobias.gritschacher) 5PATC>3RESO/FIX [14:03:30] <grrrit-wm> (03PS1) 10Bartosz Dziewoński: Article: Localize alt text of redirect icon [core] - 10https://gerrit.wikimedia.org/r/158622 [14:05:11] <MatmaRex> ugh. [14:05:13] <MatmaRex> spot the bug: http://i.imgur.com/3u2mbll.png [14:05:48] <MatmaRex> good thing the htmlspecialchars isn't misplaced in a more insidious way :/ [14:05:57] <^d> htmlspecialchars() doesn't take $text, array(), array() as params? [14:06:01] <andre__> I can see dots! [14:08:12] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Allow adding references for statements on properties in the UI - 10https://bugzilla.wikimedia.org/68379 (10tobias.gritschacher) [14:08:13] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Support statements on properties in WikibaseDataModelSerialization - 10https://bugzilla.wikimedia.org/66425 (10tobias.gritschacher) [14:08:27] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Support statements on properties in WikibaseDataModel - 10https://bugzilla.wikimedia.org/70035 (10tobias.gritschacher) [14:08:41] <wctaiwan> MatmaRex: I'm sure there's someone out there intentionally indenting code to mislead and cackling [14:10:02] <grrrit-wm> (03CR) 10Anomie: [C: 032] APIQueryInfo: Allow fetching the canonical url of a page [core] - 10https://gerrit.wikimedia.org/r/158609 (owner: 10Legoktm) [14:12:29] <wikibugs> 3Wikimedia / 3Deployment systems: Allow scap.RebuildCdbs to only build l10n cache for 1 version of mediawiki - 10https://bugzilla.wikimedia.org/70443 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3normal a:3None Currently, it just iterates over the lot, it'd be nice (for l10nupdate usages) if we could pass a... [14:13:08] <grrrit-wm> (03CR) 10Anomie: "FYI, I'm in the middle of rewriting action=help from the ground up." [core] - 10https://gerrit.wikimedia.org/r/158546 (https://bugzilla.wikimedia.org/62905) (owner: 10Alex Monk) [14:14:27] <wikibugs> 3Wikimedia / 3Deployment systems: Allow scap.RebuildCdbs to only build l10n cache for 1 version of mediawiki - 10https://bugzilla.wikimedia.org/70443#c1 (10Sam Reed (reedy)) As a no-op for a version, it's still a tonne quicker than the current method (see https://gerrit.wikimedia.org/r/#/c/158623 for improve... [14:14:41] <grrrit-wm> (03PS2) 10Bartosz Dziewoński: Article: Localize alt text of redirect icon [core] - 10https://gerrit.wikimedia.org/r/158622 [14:16:00] <grrrit-wm> (03Merged) 10jenkins-bot: APIQueryInfo: Allow fetching the canonical url of a page [core] - 10https://gerrit.wikimedia.org/r/158609 (owner: 10Legoktm) [14:19:12] <wikibugs> 3Wikimedia / 3Deployment systems: Allow scap.RebuildCdbs to only build l10n cache for 1 version of mediawiki - 10https://bugzilla.wikimedia.org/70443#c2 (10Sam Reed (reedy)) https://github.com/wikimedia/operations-puppet/blob/production/files/misc/l10nupdate/l10nupdate-1#L68-L111 That block could nearly ju... [14:23:56] <grrrit-wm> (03CR) 10Jdlrobson: [C: 04-1] "This is not what I laid out in my drawing :(" [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx) [14:25:28] <grrrit-wm> (03CR) 10Jdlrobson: "I will knock up another version of this for comparative purposes." [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx) [14:26:57] <grrrit-wm> (03CR) 10Phuedx: "Please do. I feel a little guilty about making you :( but I couldn't help but be influenced by the (great) discussion over at Ifad5dddfb5a" [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx) [14:27:20] <grrrit-wm> (03PS2) 10Alex Monk: Make it possible for API modules to hide their documentation behind an 'includeinternal' parameter [core] - 10https://gerrit.wikimedia.org/r/158546 (https://bugzilla.wikimedia.org/62905) [14:28:58] <wikibugs> 3MediaWiki extensions / 3WikidataClient: "Invalid token" error when trying to add language link from Wikipedia - 10https://bugzilla.wikimedia.org/70415#c11 (10Aude) we plan to deploy the fix on Monday. [14:31:39] <grrrit-wm> (03CR) 10MarkAHershberger: "It was successfully rebased last month. I think it is still valid. Bartosz, could you +2 this?" [core] - 10https://gerrit.wikimedia.org/r/20500 (https://bugzilla.wikimedia.org/39466) (owner: 10MarkAHershberger) [14:32:14] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 04-1] "No, it was rebased a year ago last month. It doesn't merge currently." [core] - 10https://gerrit.wikimedia.org/r/20500 (https://bugzilla.wikimedia.org/39466) (owner: 10MarkAHershberger) [14:33:55] <grrrit-wm> (03CR) 10MarkAHershberger: "Ok, I'll see if I can fix that. Thanks for your quick reply." [core] - 10https://gerrit.wikimedia.org/r/20500 (https://bugzilla.wikimedia.org/39466) (owner: 10MarkAHershberger) [14:38:12] <wikibugs> 3MediaWiki / 3Redirects: Redirect-specific page content above target page content - 10https://bugzilla.wikimedia.org/13595#c6 (10Bartosz Dziewoński) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 2012 *** [14:38:12] <wikibugs> 3MediaWiki extensions / 3ParserFunctions: Allow text added to a redirect page to be included on the target page - 10https://bugzilla.wikimedia.org/2012#c12 (10Bartosz Dziewoński) *** Bug 13595 has been marked as a duplicate of this bug. *** [14:38:57] <wikibugs> 3MediaWiki / 3Redirects: Allow text added to a redirect page to be included on the target page - 10https://bugzilla.wikimedia.org/2012 (10Bartosz Dziewoński) [14:42:29] <grrrit-wm> (03PS18) 10Phuedx: [EXPERIMENT] Add icon mixins to mediawiki.ui [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) [14:43:34] <grrrit-wm> (03PS1) 10Dan-nl: update INSTALL instructions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/158625 [14:46:35] <grrrit-wm> (03CR) 10Jdlrobson: "I think the classes mw-ui-icon and mw-ui-icon-ok etc have value." [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx) [14:47:09] <phuedx> Jdlrobson: arg, what's yer irc nick? [14:47:16] * phuedx waves hands frantically [14:47:39] <Reedy> phuedx: jdlrobson2 it seems [14:47:46] <Reedy> but he's in #wikimedia-mobile [14:47:59] <phuedx> aha! [14:48:14] <phuedx> thanks Reedy! [14:49:29] <grrrit-wm> (03PS1) 10Matthias Mullie: Fix non-existing property [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158626 [14:50:04] <grrrit-wm> (03CR) 10MarkAHershberger: "Looks like 020fc0b6 may have taken care of this. What do you think?" [core] - 10https://gerrit.wikimedia.org/r/20500 (https://bugzilla.wikimedia.org/39466) (owner: 10MarkAHershberger) [14:50:54] <grrrit-wm> (03PS1) 10Bartosz Dziewoński: Article: Don't hardcode <img> tags on redirect page [core] - 10https://gerrit.wikimedia.org/r/158627 (https://bugzilla.wikimedia.org/69277) [14:52:02] <grrrit-wm> (03CR) 10MarkAHershberger: "Robert, could you look at this patch at see if your change at 020fc0b6 makes it obsolete?" [core] - 10https://gerrit.wikimedia.org/r/20500 (https://bugzilla.wikimedia.org/39466) (owner: 10MarkAHershberger) [14:53:12] <grrrit-wm> (03CR) 10MarkAHershberger: "Should have release notes, Maybe a ref to bug #39466" [core] - 10https://gerrit.wikimedia.org/r/120767 (owner: 10Robert Vogel) [14:54:55] <grrrit-wm> (03CR) 10MarkAHershberger: "Also see I7366f081adf6d72c83f555fc271b055897fd74be" [core] - 10https://gerrit.wikimedia.org/r/120767 (owner: 10Robert Vogel) [14:56:10] <grrrit-wm> (03PS1) 10Matthias Mullie: Only show diff & hist links in CU [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158628 [15:04:02] <grrrit-wm> (03CR) 10Phuedx: "> I think the classes mw-ui-icon and mw-ui-icon-ok etc have value." [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx) [15:13:30] <grrrit-wm> (03CR) 10Chad: [C: 04-1] "+1 to Daniel." [core] - 10https://gerrit.wikimedia.org/r/152823 (owner: 10Legoktm) [15:15:27] <wikibugs> 3Wikimedia / 3Deployment systems: Use Scap in Localisation Update - 10https://bugzilla.wikimedia.org/70443 (10Sam Reed (reedy)) [15:15:59] <grrrit-wm> (03CR) 10Chad: [C: 032] Move log log_page entries are now that of the moved page [core] - 10https://gerrit.wikimedia.org/r/157872 (owner: 10Aaron Schulz) [15:17:19] <grrrit-wm> (03PS1) 10Jdlrobson: WIP: Add mw-ui-icon [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) [15:20:22] <grrrit-wm> (03PS2) 10Jdlrobson: WIP: Add mw-ui-icon [core] - 10https://gerrit.wikimedia.org/r/158632 (https://bugzilla.wikimedia.org/55535) [15:20:29] <wikibugs> 3Wikimedia / 3Deployment systems: Are Scap and LocalisationUpdate actually fighting over l10nupdates? - 10https://bugzilla.wikimedia.org/70446 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3normal a:3None So Bryan and I were looking at the l10nupdate scripts, noticing that it's essentially a reproduction of... [15:20:42] <wikibugs> 3Wikimedia / 3Deployment systems: Use Scap in Localisation Update - 10https://bugzilla.wikimedia.org/70443 (10Sam Reed (reedy)) [15:20:56] <wikibugs> 3Wikimedia / 3Deployment systems: Are Scap and LocalisationUpdate actually fighting over l10nupdates? - 10https://bugzilla.wikimedia.org/70446#c1 (10Sam Reed (reedy)) [15:42:30] <Reedy> hey bd808 [15:43:09] -*- bd808 waves and reads backscroll [15:43:39] <Reedy> TLDR; https://github.com/wikimedia/operations-... [15:22:33] <grrrit-wm> (03Merged) 10jenkins-bot: Move log log_page entries are now that of the moved page [core] - 10https://gerrit.wikimedia.org/r/157872 (owner: 10Aaron Schulz) [15:23:52] <wikibugs> 3MediaWiki / 3Logging: Store the page_id of the moved page in log_page - 10https://bugzilla.wikimedia.org/57084#c35 (10Nemo) This is a quite drastic change, needs communication. (At least it has release notes.) I suggest to describe it as "Log entries for the move log are now stored for the target title rath... [15:33:38] <grrrit-wm> (03CR) 10PleaseStand: [C: 04-1] Add wfGetRusage(), wrapping getrusage(2) syscall (031 comment) [core] - 10https://gerrit.wikimedia.org/r/158550 (https://bugzilla.wikimedia.org/70227) (owner: 10Ori.livneh) [15:35:18] <grrrit-wm> (03CR) 10Chad: [C: 031] "Fix i18n issues Siebrand has, then lgtm." [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/158054 (owner: 10Legoktm) [15:44:29] <grrrit-wm> (03PS1) 10EBernhardson: H-4: Rename Close -> Lock [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158634 [15:48:17] <grrrit-wm> (03CR) 10MarkTraceur: "...weird." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151699 (owner: 10MarkTraceur) [15:56:03] <grrrit-wm> (03CR) 10EBernhardson: [C: 04-1] "no global variables please" (037 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158100 (https://bugzilla.wikimedia.org/59919) (owner: 10Jdlrobson) [16:19:27] <grrrit-wm> (03CR) 10EBernhardson: [C: 032] Hygiene: Kill ifEquals helper, use ifCond instead [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156720 (owner: 10Jdlrobson) [16:20:18] <grrrit-wm> (03Merged) 10jenkins-bot: Hygiene: Kill ifEquals helper, use ifCond instead [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156720 (owner: 10Jdlrobson) [16:20:51] <grrrit-wm> (03PS10) 10EBernhardson: Update classes of topic during close/reopen actions. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156739 (https://bugzilla.wikimedia.org/68328) (owner: 10Jdlrobson) [16:22:48] <grrrit-wm> (03CR) 10Krinkle: "Hm.. you plan on changing mw.loader.store to use this and drafts in localStorage or the other way around?" [core] - 10https://gerrit.wikimedia.org/r/157818 (owner: 10TheDJ) [16:22:57] <grrrit-wm> (03CR) 10EBernhardson: Update classes of topic during close/reopen actions. (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156739 (https://bugzilla.wikimedia.org/68328) (owner: 10Jdlrobson) [16:26:03] <grrrit-wm> (03PS11) 10EBernhardson: Update classes of topic during close/reopen actions. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156739 (https://bugzilla.wikimedia.org/68328) (owner: 10Jdlrobson) [16:26:11] <grrrit-wm> (03PS2) 10Krinkle: build: Bump grunt-banana-checker to 0.2.0 and fix flagged issue [core] - 10https://gerrit.wikimedia.org/r/157631 (owner: 10Jforrester) [16:26:21] <grrrit-wm> (03CR) 10Krinkle: [C: 032] build: Bump grunt-banana-checker to 0.2.0 and fix flagged issue [core] - 10https://gerrit.wikimedia.org/r/157631 (owner: 10Jforrester) [16:26:44] <grrrit-wm> (03CR) 10EBernhardson: [C: 032] "PS11: flip conditional from if (!$foo) { ... } else { ... } to the more direct if ($foo) { ... } else { ... }" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156739 (https://bugzilla.wikimedia.org/68328) (owner: 10Jdlrobson) [16:27:36] <grrrit-wm> (03Merged) 10jenkins-bot: Update classes of topic during close/reopen actions. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156739 (https://bugzilla.wikimedia.org/68328) (owner: 10Jdlrobson) [16:32:58] <grrrit-wm> (03Merged) 10jenkins-bot: build: Bump grunt-banana-checker to 0.2.0 and fix flagged issue [core] - 10https://gerrit.wikimedia.org/r/157631 (owner: 10Jforrester) [16:34:12] <grrrit-wm> (03PS2) 10Krinkle: mediawiki.api: Actually don't log request error 'abort' [core] - 10https://gerrit.wikimedia.org/r/157350 (https://bugzilla.wikimedia.org/65442) (owner: 10Bartosz Dziewoński) [16:39:26] <grrrit-wm> (03PS3) 10Krinkle: mediawiki.api: Actually don't log request error 'abort' [core] - 10https://gerrit.wikimedia.org/r/157350 (https://bugzilla.wikimedia.org/65442) (owner: 10Bartosz Dziewoński) [16:43:18] <grrrit-wm> (03CR) 10Isarra: "Comment about styling..." (031 comment) [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/158605 (https://bugzilla.wikimedia.org/66931) (owner: 10Legoktm) [16:48:05] <grrrit-wm> (03PS2) 10EBernhardson: Prevent detection of named variables inside quoted strings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158133 [16:54:33] <grrrit-wm> (03PS11) 10EBernhardson: G4: Don't collapse closedt review topics. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156719 (owner: 10Jdlrobson) [16:54:57] <grrrit-wm> (03CR) 10CSteipp: "Yeah, just another checkbox on the form, and then we go with the prefix checking that you currently have." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/153983 (https://bugzilla.wikimedia.org/69250) (owner: 10Mitar) [16:56:49] <grrrit-wm> (03CR) 10EBernhardson: [C: 031] "PS11: Manual rebase" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156719 (owner: 10Jdlrobson) [17:03:34] <grrrit-wm> (03CR) 10Jack Phoenix: "Some random thoughts inline; nothing big that would prevent me from +2'ing this changeset, though, just a few suggestions/questions." (037 comments) [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/158605 (https://bugzilla.wikimedia.org/66931) (owner: 10Legoktm) [17:07:07] <Vulpix> lots of webs are using web fonts from use.typekit.net, and that server seems down, so they are veeeeery slow [17:08:39] <Vulpix> oh, cool, the outage is affecting Spain only :( [17:14:16] <grrrit-wm> (03PS10) 10MarkTraceur: Add controllers for each step - mostly stubs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151699 [17:14:54] <grrrit-wm> (03CR) 10Krinkle: [C: 032] mediawiki.api: Actually don't log request error 'abort' [core] - 10https://gerrit.wikimedia.org/r/157350 (https://bugzilla.wikimedia.org/65442) (owner: 10Bartosz Dziewoński) [17:16:17] <grrrit-wm> (03CR) 10CSteipp: [C: 031] "I think this is good, but I'm trying to decide if we should also have a global limit, so no more than 10 in 10 minutes (or something like " [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/158311 (owner: 10Legoktm) [17:20:32] <marxarelli> bd808: thanks for the merges! using system gems turned out to be a lot easier than i thought it would be (cc ori) [17:21:04] <grrrit-wm> (03Merged) 10jenkins-bot: mediawiki.api: Actually don't log request error 'abort' [core] - 10https://gerrit.wikimedia.org/r/157350 (https://bugzilla.wikimedia.org/65442) (owner: 10Bartosz Dziewoński) [17:21:29] <bd808> It seemed to "just work" for me. I tried to rebase that other patch with the hiera turn off switch but I couldn't get it to work right [17:22:04] <bd808> The system packages were still getting installed for me and I ran out of time to track it down [17:22:13] <wikibugs> 3MediaWiki / 3JavaScript: Aborted mediawiki.api requests are logged as errors ("mw.Api error: " "http" {xhr: Object, textStatus: "abort", exception: "abort"}) - 10https://bugzilla.wikimedia.org/65442 (10Bartosz Dziewoński) 5PATC>3RESO/FIX [17:22:36] <marxarelli> oh strange [17:22:41] <grrrit-wm> (03CR) 10EBernhardson: "hmm, invalid workflow should be unrelated to this patch. That implies that the topic link you followed doesn't have a matching Workflow i" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158302 (owner: 10Bsitu) [17:22:53] <marxarelli> should we just wait to see how the improvements are received? maybe we can abandon that one [17:27:02] <Krenair> anomie, hey [17:27:46] <anomie> hi Krenair [17:27:51] <Krenair> anomie, by your comment on https://gerrit.wikimedia.org/r/#/c/158546/, do you mean this is not necessary because you're doing a much bigger patch including this soon? [17:29:29] <anomie> Krenair: I've included "isInternal()" in my bigger patch. I haven't decided whether it needs an 'includesinternal' flag or not, since by default it shows links to each submodule (in "One value: foo, bar, baz", "foo", "bad", and "baz" are linked) instead of one huge page. [17:29:37] <grrrit-wm> (03CR) 10CSteipp: [C: 032] Updated credits [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/158563 (owner: 10Aaron Schulz) [17:29:45] <grrrit-wm> (03Merged) 10jenkins-bot: Updated credits [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/158563 (owner: 10Aaron Schulz) [17:30:12] <anomie> Krenair: But I did put in a red warning on the doc for the module if isInternal() is true. [17:30:41] <Krenair> anomie, okay. are you planning to upload this patch soon? [17:30:59] <anomie> Krenair: Once I finish it. [17:31:02] <grrrit-wm> (03CR) 10TheDJ: "both possibly. i wanna start with drafts, to explore it a bit." [core] - 10https://gerrit.wikimedia.org/r/157818 (owner: 10TheDJ) [17:31:07] <ori> MatmaRex: why are we seeing req urls to bits like this: /static-1.24wmf19/skins/Vector/images/external-link-ltr-icon.png?2014-08-28T18:18:20Z [17:31:10] <ori> MatmaRex: with a timestamp [17:31:14] <ori> what's adding the timestamp? [17:32:05] <Krinkle> ori: mediawiki is [17:32:10] <Krinkle> see _security [17:32:26] <Nemo_bis> ... [17:32:59] <ori> oh, all right [17:34:05] <grrrit-wm> (03CR) 10Chad: [C: 04-1] "I think if we tweak the detect code so the pattern is:" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/153944 (owner: 10Aaron Schulz) [17:34:12] <wikibugs> 3MediaWiki / 3MediaWiki UI: Set $wgUseMediaWikiUIEverywhere = true (tracking) - 10https://bugzilla.wikimedia.org/70424 (10Matthew Flaschen) [17:34:12] <wikibugs> 3MediaWiki / 3MediaWiki UI: Input fields should be relative to input strings - 10https://bugzilla.wikimedia.org/70404 (10Matthew Flaschen) [17:36:41] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: UI broken for Julian calendar model dates - 10https://bugzilla.wikimedia.org/70398 (10JulesWinnfield-hu) [17:36:42] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: not possible to switch to Julian calendar model - 10https://bugzilla.wikimedia.org/65847#c14 (10JulesWinnfield-hu) Opened bug 70398. [17:41:31] <MatmaRex> ori: Krinkle: i am now quite curious what this has to do with security. :> [17:42:08] <Krinkle> just a precaution [17:49:01] <Vulpix> to prevent retrieving a cached content that was compromised? [17:50:02] <grrrit-wm> (03PS2) 10Aaron Schulz: Added a BloomCacheRedisTest class [core] - 10https://gerrit.wikimedia.org/r/158553 [17:51:26] <ori> MatmaRex: basically it gives us the ability to paste URLs we're seeing in the logs without having to triple-check them for things like session tokens [17:51:43] <ori> which is very useful when debugging an issue like this [17:51:53] <MatmaRex> hah, okay [17:53:23] <grrrit-wm> (03PS1) 10Chad: TitleTest: Break secure and split test into two tests with providers [core] - 10https://gerrit.wikimedia.org/r/158646 [17:55:39] <^d> Yay tests [17:56:11] <wikibugs> 3MediaWiki / 3MediaWiki UI: componentize compact personal bar code into general list control - 10https://bugzilla.wikimedia.org/70433#c2 (10Jared Zimmerman (WMF)) With small changes (click rather than hover), this is the start of the dropdown list control, which is required extensively in preferences and spe... [17:56:31] <grrrit-wm> (03CR) 10Ori.livneh: [C: 032] "Thanks!" [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/158556 (owner: 10Legoktm) [17:56:36] <grrrit-wm> (03Merged) 10jenkins-bot: Tag all recent changes entries with the HHVM tag [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/158556 (owner: 10Legoktm) [17:58:01] <grrrit-wm> (03PS1) 10Anomie: Set $wasPosted = true for recursive API access [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/158647 (https://bugzilla.wikimedia.org/70448) [17:59:57] <wikibugs> 3MediaWiki extensions / 3LiquidThreads: LQT: [Regression 1.24wmf20] Pagination arrows have been moved - 10https://bugzilla.wikimedia.org/70412#c6 (10James Forrester) Scheduled backport for SWAT on Monday morning. [18:01:12] <wikibugs> 3MediaWiki / 3MediaWiki UI: Advanced input type "search" is needed - 10https://bugzilla.wikimedia.org/70427#c2 (10Jared Zimmerman (WMF)) perhaps we should generalize this into input field with icon needed? search is one user case, displaying the IME or date picker is another. in some instances the icon is... [18:01:18] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 032] Typo fix: HMTL → HTML [core] - 10https://gerrit.wikimedia.org/r/158619 (owner: 10Bartosz Dziewoński) [18:04:31] <grrrit-wm> (03PS1) 10Bartosz Dziewoński: Move file type icons to new assets/ directory [core] - 10https://gerrit.wikimedia.org/r/158648 (https://bugzilla.wikimedia.org/69277) [18:04:37] <grrrit-wm> (03PS1) 10Bartosz Dziewoński: Move mediawiki.png to assets/ directory [core] - 10https://gerrit.wikimedia.org/r/158649 (https://bugzilla.wikimedia.org/69277) [18:04:43] <grrrit-wm> (03PS1) 10Bartosz Dziewoński: Move remaining skin files to assets/ directory [core] - 10https://gerrit.wikimedia.org/r/158650 (https://bugzilla.wikimedia.org/69277) [18:05:47] <grrrit-wm> (03PS2) 10Robmoen: Make profile icon gender neutral and remove from login link in Vector [skins/Vector] - 10https://gerrit.wikimedia.org/r/157990 (https://bugzilla.wikimedia.org/41484) [18:05:50] <grrrit-wm> (03PS1) 10GWicke: Remove Parsoid-specific padding and background [core] - 10https://gerrit.wikimedia.org/r/158651 [18:07:36] <grrrit-wm> (03Merged) 10jenkins-bot: Typo fix: HMTL → HTML [core] - 10https://gerrit.wikimedia.org/r/158619 (owner: 10Bartosz Dziewoński) [18:07:56] <wikibugs> 3MediaWiki / 3Interface: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277#c49 (10Bartosz Dziewoński) And with this, I have patches pending or merged to make MediaWiki stop using skins/common/ entirely. What remains is getting the... [18:08:06] <MatmaRex> Krinkle: https://bugzilla.wikimedia.org/show_bug.cgi?id=69277#c49 [18:08:29] <Krinkle> cool [18:09:47] <grrrit-wm> (03CR) 10Krinkle: [C: 031] Article: Localize alt text of redirect icon [core] - 10https://gerrit.wikimedia.org/r/158622 (owner: 10Bartosz Dziewoński) [18:10:34] <grrrit-wm> (03CR) 10Edokter: [C: 031] "That is better." [skins/Vector] - 10https://gerrit.wikimedia.org/r/157990 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [18:12:32] <grrrit-wm> (03CR) 10TheDJ: [C: 032] Set $wasPosted = true for recursive API access [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/158647 (https://bugzilla.wikimedia.org/70448) (owner: 10Anomie) [18:12:37] <grrrit-wm> (03Merged) 10jenkins-bot: Set $wasPosted = true for recursive API access [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/158647 (https://bugzilla.wikimedia.org/70448) (owner: 10Anomie) [18:12:57] <grrrit-wm> (03CR) 10Krinkle: [C: 04-1] "Hm.. this is an auto-generated message so it could/should be in the user language, not content language, right? (Like we do on special pag" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/158627 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [18:14:14] <grrrit-wm> (03CR) 10Jforrester: "This SVG should be run through SVGO to shrink it a bit." [skins/Vector] - 10https://gerrit.wikimedia.org/r/157990 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [18:14:57] <grrrit-wm> (03CR) 10Bartosz Dziewoński: "Currently, however, it is in "some language" (not even explicitly said to be content, heh), and switching to user language would probably " [core] - 10https://gerrit.wikimedia.org/r/158627 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [18:16:55] <grrrit-wm> (03CR) 10Krinkle: [C: 04-1] "Not sure what's going on with this SVG file but it contains CR line breaks and lots or redundant empty elements." [skins/Vector] - 10https://gerrit.wikimedia.org/r/157990 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [18:17:50] <grrrit-wm> (03PS1) 10Bartosz Dziewoński: Html: Don't accept paths relative to skins/common/images/ in infoBox() [core] - 10https://gerrit.wikimedia.org/r/158655 [18:20:13] <grrrit-wm> (03CR) 10Krinkle: "Need to think about cache life cycle. As usual when introducing yet another module for something that used to be global, this means existi" [core] - 10https://gerrit.wikimedia.org/r/158627 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [18:22:05] <grrrit-wm> (03CR) 10Bartosz Dziewoński: "I did think about it. This is good: old HTML did not load any modules which might turn out to be incompatible, new HTML requires them and " [core] - 10https://gerrit.wikimedia.org/r/158627 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [18:23:32] <grrrit-wm> (03CR) 10Krinkle: [C: 031] Html: Don't accept paths relative to skins/common/images/ in infoBox() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/158655 (owner: 10Bartosz Dziewoński) [18:24:51] <grrrit-wm> (03CR) 10Krinkle: Article: Don't hardcode <img> tags on redirect page (031 comment) [core] - 10https://gerrit.wikimedia.org/r/158627 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [18:25:58] <grrrit-wm> (03CR) 10Krinkle: Make it possible for API modules to hide their documentation behind an 'includeinternal' parameter (031 comment) [core] - 10https://gerrit.wikimedia.org/r/158546 (https://bugzilla.wikimedia.org/62905) (owner: 10Alex Monk) [18:28:53] <kaldari> marktraceur: https://gerrit.wikimedia.org/r/#/c/107368/ [18:29:41] <wikibugs> 3MediaWiki extensions / 3CirrusSearch: cl_sortkey for search enhancement - 10https://bugzilla.wikimedia.org/68452#c4 (10Eran Roz) Is there already existing configuration for $wgCirrusSearchPrefixSearchStartsWithAnyWord? If not is it hard to implement? [18:29:44] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 032] Remove Parsoid-specific padding and background [core] - 10https://gerrit.wikimedia.org/r/158651 (owner: 10GWicke) [18:30:14] * marktraceur looks [18:30:17] <grrrit-wm> (03PS3) 10Krinkle: API: Implement concept of 'internal' API modules [core] - 10https://gerrit.wikimedia.org/r/158546 (https://bugzilla.wikimedia.org/62905) (owner: 10Alex Monk) [18:30:24] <grrrit-wm> (03CR) 10Krinkle: API: Implement concept of 'internal' API modules (031 comment) [core] - 10https://gerrit.wikimedia.org/r/158546 (https://bugzilla.wikimedia.org/62905) (owner: 10Alex Monk) [18:30:53] <grrrit-wm> (03CR) 10Krinkle: "reallyMakeHelpMsg is a public function, should the new parameter have a default value?" [core] - 10https://gerrit.wikimedia.org/r/158546 (https://bugzilla.wikimedia.org/62905) (owner: 10Alex Monk) [18:31:02] <marktraceur> kaldari: I defer to tgr on that [18:31:13] <kaldari> who's tgr? [18:31:53] <Krenair> kaldari, Tisza Gergő [18:32:04] <Krenair> in this channel [18:32:24] <grrrit-wm> (03PS2) 10Bartosz Dziewoński: Html: Don't accept paths relative to skins/common/images/ in infoBox() [core] - 10https://gerrit.wikimedia.org/r/158655 [18:32:33] <grrrit-wm> (03CR) 10Bartosz Dziewoński: Html: Don't accept paths relative to skins/common/images/ in infoBox() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/158655 (owner: 10Bartosz Dziewoński) [18:32:46] <kaldari> tgr: I updated the code at https://gerrit.wikimedia.org/r/#/c/107368/ and replied to your comment there. Let me know what you think. [18:33:21] <kaldari> hmm, looks like he's idle :( [18:35:48] <grrrit-wm> (03Merged) 10jenkins-bot: Remove Parsoid-specific padding and background [core] - 10https://gerrit.wikimedia.org/r/158651 (owner: 10GWicke) [18:38:03] <grrrit-wm> (03PS1) 10Bartosz Dziewoński: UploadFromUrlTest: Don't reference skins/common/ (via bits.wm.o) [core] - 10https://gerrit.wikimedia.org/r/158658 [18:38:09] <grrrit-wm> (03Draft1) 10TheDJ: Replace deprecated wikiGetLink with mw.util.getUrl [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/158656 [18:40:50] <kaldari> marktraceur: I think it definitely needs to be changed as it nearly caused us to use the wrong data for attribution in the mobile media viewer [18:42:41] <grrrit-wm> (03PS1) 10Catrope: Followup 6c5b246: also hide #mw-notification-area upon creation [core] - 10https://gerrit.wikimedia.org/r/158659 (https://bugzilla.wikimedia.org/55457) [18:43:00] <marktraceur> kaldari: Something something documentation, I'm sure [18:43:04] <grrrit-wm> (03PS2) 10Catrope: Followup 6c5b246: also hide #mw-notification-area upon creation [core] - 10https://gerrit.wikimedia.org/r/158659 (https://bugzilla.wikimedia.org/52659) [18:43:56] <wikibugs> 3MediaWiki / 3JavaScript: mediawiki.notification: div#mw-notification-area remains visible and steals events after dismissing notification - 10https://bugzilla.wikimedia.org/55457#c3 (10Roan Kattouw) 5PATC>3RESO/DUP Wrong bug, sorry *** This bug has been marked as a duplicate of bug 52659 *** [18:43:58] <wikibugs> 3MediaWiki / 3JavaScript: [Regression] mediawiki.notification: Notification area remains visible when empty and steals pointer events - 10https://bugzilla.wikimedia.org/52659#c17 (10Roan Kattouw) *** Bug 55457 has been marked as a duplicate of this bug. *** [18:45:14] <grrrit-wm> (03CR) 10Robert Vogel: [C: 032 V: 032] Added fontweight [skins/BlueSpiceSkin] (REL1_22) - 10https://gerrit.wikimedia.org/r/158591 (owner: 10Swidmann) [18:45:51] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 032] Replace deprecated wikiGetLink with mw.util.getUrl [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/158656 (owner: 10TheDJ) [18:45:56] <grrrit-wm> (03Merged) 10jenkins-bot: Replace deprecated wikiGetLink with mw.util.getUrl [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/158656 (owner: 10TheDJ) [18:46:25] <grrrit-wm> (03CR) 10Robert Vogel: [C: 031 V: 031] Removed use of deprecated method [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/158600 (owner: 10Smuggli) [18:50:13] <wikibugs> 3MediaWiki / 3User blocking: MediaWiki:Autoblocker etc. reveals to third party that a (blocked) user has used the same IP address - 10https://bugzilla.wikimedia.org/53008#c54 (10Luis Villa (WMF Legal)) To be clear, the privacy policy allows disclosure of this sort of information when necessary to operate the... [18:54:01] <grrrit-wm> (03PS3) 10Bartosz Dziewoński: mediawiki.notification: Also hide #mw-notification-area upon creation [core] - 10https://gerrit.wikimedia.org/r/158659 (https://bugzilla.wikimedia.org/52659) (owner: 10Catrope) [18:54:10] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.notification: Also hide #mw-notification-area upon creation [core] - 10https://gerrit.wikimedia.org/r/158659 (https://bugzilla.wikimedia.org/52659) (owner: 10Catrope) [18:54:52] <grrrit-wm> (03PS1) 10EBernhardson: Truncate user supplied values stored in events [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158661 [18:58:05] <grrrit-wm> (03PS1) 10Chad: CategoryFinder: give parent category tree an accessor [core] - 10https://gerrit.wikimedia.org/r/158663 [18:59:50] <thedj> MatmaRex: i'm also rewriting wikilove to use mediawiki.api [19:00:56] <grrrit-wm> (03Merged) 10jenkins-bot: mediawiki.notification: Also hide #mw-notification-area upon creation [core] - 10https://gerrit.wikimedia.org/r/158659 (https://bugzilla.wikimedia.org/52659) (owner: 10Catrope) [19:00:57] <MatmaRex> :o [19:06:12] <grrrit-wm> (03PS1) 10TheDJ: Rewrite to use mediawiki.api [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/158664 [19:09:30] <grrrit-wm> (03CR) 10Aaron Schulz: "Looking at the en json message file, it will be very close to the apc.user_entries_hint default limit. Also when some keys are there and o" [core] - 10https://gerrit.wikimedia.org/r/153944 (owner: 10Aaron Schulz) [19:10:15] <grrrit-wm> (03PS6) 10Yurik: Split dev roles out of MobileFrontend and CirrusSearch [vagrant] - 10https://gerrit.wikimedia.org/r/155861 (owner: 10MaxSem) [19:11:44] <grrrit-wm> (03PS2) 10TheDJ: Rewrite to use mediawiki.api [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/158664 [19:15:48] <grrrit-wm> (03CR) 10Legoktm: [C: 04-1] Add basic support for showing a footer at the bottom of global user pages (033 comments) [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/158605 (https://bugzilla.wikimedia.org/66931) (owner: 10Legoktm) [19:19:28] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 032] Improve tests for OutputPage::makeResourceLoaderLink [core] - 10https://gerrit.wikimedia.org/r/156014 (owner: 10Legoktm) [19:23:41] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 032] Add tests for User::getCanonicalName() [core] - 10https://gerrit.wikimedia.org/r/156159 (owner: 10Umherirrender) [19:24:18] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 032] Refactor: Use local variables for editsections in Parser [core] - 10https://gerrit.wikimedia.org/r/144182 (owner: 10Umherirrender) [19:25:27] <grrrit-wm> (03Merged) 10jenkins-bot: Improve tests for OutputPage::makeResourceLoaderLink [core] - 10https://gerrit.wikimedia.org/r/156014 (owner: 10Legoktm) [19:26:05] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 032] Sanitizer::escapeId: Decode entity before replacing spaces [core] - 10https://gerrit.wikimedia.org/r/143477 (owner: 10Umherirrender) [19:26:52] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 032] Remove unneeded spaces inside html in NoLocalSettings.php [core] - 10https://gerrit.wikimedia.org/r/153635 (owner: 10Umherirrender) [19:26:56] <grrrit-wm> (03CR) 10Robmoen: "This output is the product of running" [skins/Vector] - 10https://gerrit.wikimedia.org/r/157990 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [19:28:08] <grrrit-wm> (03PS1) 10Paladox: Add svg version of powered by mediawiki [core] - 10https://gerrit.wikimedia.org/r/158669 [19:28:21] <grrrit-wm> (03PS2) 10Paladox: Add svg version of powered by mediawiki [core] - 10https://gerrit.wikimedia.org/r/158669 [19:29:15] <grrrit-wm> (03CR) 10Paladox: [C: 031] "1+ because it works." [core] - 10https://gerrit.wikimedia.org/r/158669 (owner: 10Paladox) [19:29:59] <grrrit-wm> (03Merged) 10jenkins-bot: Add tests for User::getCanonicalName() [core] - 10https://gerrit.wikimedia.org/r/156159 (owner: 10Umherirrender) [19:30:27] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 032] Add parser tests about building table with {{!}} [core] - 10https://gerrit.wikimedia.org/r/146732 (owner: 10Umherirrender) [19:30:32] <Krinkle> thedj: Feel like fixing jshint for WikiLove? MOst of the errors are false postives due to jshintrc itself missing [19:30:36] <grrrit-wm> (03Merged) 10jenkins-bot: Refactor: Use local variables for editsections in Parser [core] - 10https://gerrit.wikimedia.org/r/144182 (owner: 10Umherirrender) [19:30:54] <grrrit-wm> (03CR) 10Krinkle: [C: 032] Rewrite to use mediawiki.api [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/158664 (owner: 10TheDJ) [19:31:45] <grrrit-wm> (03PS3) 10Paladox: Add svg version of powered by mediawiki [core] - 10https://gerrit.wikimedia.org/r/158669 [19:31:59] <grrrit-wm> (03PS7) 10Paladox: Add support for svg in .list-style-image [core] - 10https://gerrit.wikimedia.org/r/158505 [19:32:34] <grrrit-wm> (03CR) 10Krinkle: [C: 04-1] Action: Merge getClass() into factory() and kill $wgActions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/145247 (owner: 10Withoutaname) [19:32:49] <grrrit-wm> (03Merged) 10jenkins-bot: Sanitizer::escapeId: Decode entity before replacing spaces [core] - 10https://gerrit.wikimedia.org/r/143477 (owner: 10Umherirrender) [19:33:19] <grrrit-wm> (03Merged) 10jenkins-bot: Remove unneeded spaces inside html in NoLocalSettings.php [core] - 10https://gerrit.wikimedia.org/r/153635 (owner: 10Umherirrender) [19:33:41] <grrrit-wm> (03Merged) 10jenkins-bot: Rewrite to use mediawiki.api [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/158664 (owner: 10TheDJ) [19:35:42] <grrrit-wm> (03CR) 10Krinkle: Subclass the Action class under ContextSource (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143211 (owner: 10Withoutaname) [19:35:48] <grrrit-wm> (03CR) 10Bartosz Dziewoński: "Currently .mw-ui-button has 'color: #555555', which is even darker than you propose. Whee!" [core] - 10https://gerrit.wikimedia.org/r/125980 (owner: 10Gerrit Patch Uploader) [19:35:49] <Krinkle> aude: ^ [19:35:53] <Krinkle> aude: https://gerrit.wikimedia.org/r/#/c/143211/ [19:35:54] <grrrit-wm> (03Abandoned) 10Bartosz Dziewoński: Give darker text color to mw-ui-button [core] - 10https://gerrit.wikimedia.org/r/125980 (owner: 10Gerrit Patch Uploader) [19:36:42] <grrrit-wm> (03Merged) 10jenkins-bot: Add parser tests about building table with {{!}} [core] - 10https://gerrit.wikimedia.org/r/146732 (owner: 10Umherirrender) [19:36:44] <grrrit-wm> (03CR) 10Jforrester: "We generally mergePaths – in OOUI we do:" [skins/Vector] - 10https://gerrit.wikimedia.org/r/157990 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [19:37:56] <grrrit-wm> (03Abandoned) 10Krinkle: Add svg version of powered by mediawiki [core] - 10https://gerrit.wikimedia.org/r/158669 (owner: 10Paladox) [19:38:26] <grrrit-wm> (03CR) 10Robmoen: "Agreed this is strange. I will recreate the svg" [skins/Vector] - 10https://gerrit.wikimedia.org/r/157990 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [19:41:44] <wikibugs> 3MediaWiki extensions / 3FlaggedRevs: Mark edit as pending review for all users from the same IP-address/range - 10https://bugzilla.wikimedia.org/70452 (10jeblad) 3NEW p:3Unprio s:3normal a:3None To block vandalism that is purely an attack on other users at the same IP-address (or range), like at a s... [19:41:47] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 04-1] "Should be safe now, but needs rebase." [core] - 10https://gerrit.wikimedia.org/r/146727 (owner: 10Withoutaname) [19:43:27] <wikibugs> 3MediaWiki / 3JavaScript: [Regression] mediawiki.notification: Notification area remains visible when empty and steals pointer events - 10https://bugzilla.wikimedia.org/52659 (10Roan Kattouw) 5PATC>3RESO/FIX [19:46:14] <wikibugs> 3MediaWiki extensions / 3FlaggedRevs: Reviewers should be able to hide revisions with contagious content - 10https://bugzilla.wikimedia.org/70453 (10jeblad) 3NEW p:3Unprio s:3normal a:3None The reviewers should be able to either themselves hide revisions with contagious content, or should be able to... [19:49:17] <grrrit-wm> (03PS3) 10Robmoen: Make profile icon gender neutral and remove from login link in Vector [skins/Vector] - 10https://gerrit.wikimedia.org/r/157990 (https://bugzilla.wikimedia.org/41484) [19:50:42] <grrrit-wm> (03CR) 10Addshore: Added a BloomCacheRedisTest class (031 comment) [core] - 10https://gerrit.wikimedia.org/r/158553 (owner: 10Aaron Schulz) [19:50:47] <grrrit-wm> (03CR) 10Jforrester: [C: 031] "Much better. :-)" [skins/Vector] - 10https://gerrit.wikimedia.org/r/157990 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [19:53:09] <grrrit-wm> (03PS1) 10Spage: Annotate this test so it runs. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158670 [19:54:44] <wikibugs> 3MediaWiki extensions / 3FlaggedRevs: Use Echo to give warnings to reviewers if the number of unreviewed changes goes above a limit - 10https://bugzilla.wikimedia.org/70456 (10jeblad) 3NEW p:3Unprio s:3normal a:3None Keep track of the number of unreviewed changes and try to estimate when the number r... [19:59:59] <wikibugs> 3MediaWiki extensions / 3FlaggedRevs: Set a limit on pages with forced review when there are to few active reviwers - 10https://bugzilla.wikimedia.org/70457 (10jeblad) 3NEW p:3Unprio s:3normal a:3None To avoid that the number of pending reviews gets out of control add a limit to the number of pages t... [20:01:13] <onei> how do ns translations get updated? [20:01:17] <grrrit-wm> (03CR) 10Bartosz Dziewoński: Article: Don't hardcode <img> tags on redirect page (033 comments) [core] - 10https://gerrit.wikimedia.org/r/158627 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [20:01:22] <grrrit-wm> (03PS2) 10Bartosz Dziewoński: Article: Don't hardcode <img> tags on redirect page [core] - 10https://gerrit.wikimedia.org/r/158627 (https://bugzilla.wikimedia.org/69277) [20:02:33] <grrrit-wm> (03PS4) 10Alex Monk: API: Implement concept of 'internal' API modules [core] - 10https://gerrit.wikimedia.org/r/158546 (https://bugzilla.wikimedia.org/62905) [20:03:39] <grrrit-wm> (03CR) 10MaxSem: "Is gup2 really needed - the default wiki can be used as a client?" [vagrant] - 10https://gerrit.wikimedia.org/r/158610 (owner: 10Legoktm) [20:07:59] <wikibugs> 3MediaWiki extensions / 3FlaggedRevs: Ordinary users should be able to tag contagious edits for pending changes - 10https://bugzilla.wikimedia.org/70458 (10jeblad) 3NEW p:3Unprio s:3normal a:3None If a page is vandalized and somehow is outside the forced review process it should be possible to tag th... [20:12:34] <grrrit-wm> (03PS5) 10Aaron Schulz: Added DatabaseBase::selectRowCount() method [core] - 10https://gerrit.wikimedia.org/r/154291 [20:14:03] <grrrit-wm> (03CR) 10Bsitu: Truncate user supplied values stored in events (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158661 (owner: 10EBernhardson) [20:14:30] <wikibugs> 3Wikimedia / 3Site requests: patrol and autopatroller rigts - 10https://bugzilla.wikimedia.org/70459 (10Ankry) 3NEW p:3Unprio s:3normal a:3None Please add "patrol" and "autopatrolled" right to the "editors" group on plwikisource. As the main page verification mechanism in plwikisource is FleggedRevs... [20:16:42] <thedj> Krinkle: i'm trying jshint on WikiLove... [20:16:51] <thedj> Krinkle: but it's like it cant find a single JS file.. [20:17:15] <thedj> works in all my other extension dirs, (reports an error if i break scripts). [20:17:27] <Krinkle> thedj: you're running 'jshint .' in the WikiLove/ dir? [20:17:37] <thedj> just my WikiLove extension checkout seems to totally ignored.. [20:17:46] <thedj> yup. nothing [20:17:50] <Krinkle> thedj: Do you have it inside mediawiki-core ? [20:18:14] <thedj> the extension you mean ? [20:18:18] <Krinkle> I'd recommend you don't, but if you do, the jshintignore from core applies, which ignores extensions/ [20:18:25] <thedj> ah... [20:18:44] <thedj> ah, this is my vagrant dir.. [20:18:55] <Krinkle> I'd recommend core/ and extensions/ being siblings and use $wgExtensionAssetsPath (that way you don't need symlinks, core extensions/ can just be ignored and harmlessly change with wmf branches etc.) [20:19:21] <Krinkle> to work around for now, just touch .jshintignore so it's empty [20:19:27] <Krinkle> https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript#Linting [20:19:56] <thedj> Hmm. guess we should rework vagrant a bit then. [20:20:41] <wikibugs> 3MediaWiki extensions / 3BetaFeatures: BetaFeatures should have means to provide a custom note on-wiki - 10https://bugzilla.wikimedia.org/70438#c2 (10Kunal Mehta (Legoktm)) Editing the MediaWiki messages isn't good enough? [20:25:24] <grrrit-wm> (03CR) 10Bsitu: Truncate user supplied values stored in events (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158661 (owner: 10EBernhardson) [20:31:09] <grrrit-wm> (03PS4) 10Jackmcbarn: Use preview content when it transcludes itself [core] - 10https://gerrit.wikimedia.org/r/137153 (https://bugzilla.wikimedia.org/5278) [20:33:36] <grrrit-wm> (03PS1) 10Aaron Schulz: Removed LCStoreAccel class [core] - 10https://gerrit.wikimedia.org/r/158676 [20:34:26] <grrrit-wm> (03CR) 10Legoktm: Use preview content when it transcludes itself (031 comment) [core] - 10https://gerrit.wikimedia.org/r/137153 (https://bugzilla.wikimedia.org/5278) (owner: 10Jackmcbarn) [20:37:13] <grrrit-wm> (03PS1) 10Alex Monk: Merge mediawiki.legacy.upload into mediawiki.special.upload [core] - 10https://gerrit.wikimedia.org/r/158677 (https://bugzilla.wikimedia.org/31946) [20:37:40] <grrrit-wm> (03CR) 10Yurik: "Without this patch, provisioning master shows this:" [vagrant] - 10https://gerrit.wikimedia.org/r/155861 (owner: 10MaxSem) [20:38:04] <yurikR> ori, pls +2 ^ [20:39:47] <bd808> yurikR: That output still has -- Duplicate entry 'filearchive-fa_major_mime-patch-fa_major_mime-chemical.sql' for key 'PRIMARY' () -- which is something in your source code tree [20:39:58] <wikibugs> 3Wikimedia / 3Mailing lists: HTML description page of otrs-ko mailing list broken - 10https://bugzilla.wikimedia.org/70180#c6 (10John F. Lewis) 5PATC>3RESO/FIX Deployed earlier and confirmed now! [20:40:18] <yurikR> bd808, but it dissappears when i checkout that patch [20:40:27] <bd808> and Could not resolve 'archive.ubuntu.com' [20:42:53] <thedj> Krinkle: what's a RL class do again ? [20:44:11] <thedj> ah it loads a specific RL php module [20:46:13] <grrrit-wm> (03CR) 10Dduvall: "That looks like a (possibly transient) DNS issue to me, not something this patch directly addresses." [vagrant] - 10https://gerrit.wikimedia.org/r/155861 (owner: 10MaxSem) [20:47:11] <yurikR> bd808, http://pastebin.com/hRwBy5Dz [20:48:33] <grrrit-wm> (03CR) 10Bartosz Dziewoński: Merge mediawiki.legacy.upload into mediawiki.special.upload (031 comment) [core] - 10https://gerrit.wikimedia.org/r/158677 (https://bugzilla.wikimedia.org/31946) (owner: 10Alex Monk) [20:49:03] <bd808> yurikR: Error: 1062 Duplicate entry 'filearchive-fa_major_mime-patch-fa_major_mime-chemical.sql' for key 'PRIMARY' () [20:49:27] <yurikR> bd808, could it have been done by one of the tests? [20:49:33] <marxarelli> yurikR: can you do a `dig +short archive.ubuntu.com` in your VM? [20:49:34] <grrrit-wm> (03PS2) 10Alex Monk: Merge mediawiki.legacy.upload into mediawiki.special.upload [core] - 10https://gerrit.wikimedia.org/r/158677 (https://bugzilla.wikimedia.org/31946) [20:49:38] <grrrit-wm> (03PS1) 10EBernhardson: Expose event count as a formatter parameter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158752 [20:49:59] <bd808> You have a jacked up database or a jacked up git clone. I would recommend `vagrant destroy -f` to see if it's just the db [20:50:00] <marxarelli> yurikR: actually drop the `+short`, just `dig archive.ubuntu.com` [20:50:30] <yurikR> vagrant@mediawiki-vagrant:~$ dig archive.ubuntu.com [20:50:30] <yurikR> ;; Got bad packet: bad label type [20:50:30] <yurikR> 103 bytes [20:50:56] <marxarelli> yurikR: something is up with networking on your VM i suspect [20:50:58] <yurikR> marxarelli, sorry, can't debug atm, sun ev/mon? [20:51:07] <yurikR> weird, i can ping and download just fine [20:51:13] <marxarelli> maybe it's just dns [20:51:37] <marxarelli> yurikR: what about `ping archive.ubuntu.com`? [20:51:58] <yurikR> works fine [20:52:08] <yurikR> i could curl google, ping out, etc [20:52:11] <bd808> The sql that is failing is from -- https://github.com/wikimedia/mediawiki-core/blob/master/maintenance/update-keys.sql [20:52:36] <yurikR> bd808, marxarelli, i'm very sorry, would love to get it resolved, but have to leave :( [20:52:39] <yurikR> mon? [20:52:43] <marxarelli> bd808: i think that's one issue, but the majority of what is failing seems to be apt package installation [20:53:06] <bd808> He's had this sql issue in every dump he's given in the last week [20:53:22] <bd808> His vm is borked and should be purged an rebuilt [20:53:55] <marxarelli> bd808, yurikR: not a bad idea to rebuild it then [20:53:57] <wikibugs> 3MediaWiki extensions / 3BetaFeatures: BetaFeatures should have means to provide a custom note on-wiki - 10https://bugzilla.wikimedia.org/70438#c3 (10James Forrester) 5UNCO>3RESO/WON If there are severe issues that would "break a lot of things" it's not ready to be a Beta Feature and for WMF servers we w... [20:54:02] <marxarelli> yurikR: i can pair with you on mon [20:54:20] <yurikR> thx ) [21:01:47] <grrrit-wm> (03PS1) 10Chad: WIP: Store parent categories [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/158771 [21:01:53] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] WIP: Store parent categories [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/158771 (owner: 10Chad) [21:02:13] <^d> Boo jenkins [21:03:00] <grrrit-wm> (03PS2) 10Chad: WIP: Store parent categories [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/158771 [21:03:15] <grrrit-wm> (03PS2) 10Paladox: Replace Powered by Mediawiki PNG image with SVG version [core] - 10https://gerrit.wikimedia.org/r/142860 (https://bugzilla.wikimedia.org/63872) (owner: 10M4tx) [21:03:43] <wikibugs> 3MediaWiki / 3General/Unknown: Code quality issues (tracking) - 10https://bugzilla.wikimedia.org/700 (10Krinkle) [21:03:45] <wikibugs> 3MediaWiki extensions / 3CentralNotice: CentralNotice: Don't load closeWindow19x19.png from Wikimedia servers - 10https://bugzilla.wikimedia.org/70462 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None A bit odd to see it load an image from a url. > $wgNoticeCloseButton = '//upload.wikimedia.org/wikipedia... [21:04:12] <wikibugs> 3MediaWiki extensions / 3CentralNotice: CentralNotice: $wgNoticeCloseButton shouldn't load closeWindow19x19.png from upload.wikimedia.org - 10https://bugzilla.wikimedia.org/70462 (10Krinkle) [21:04:28] <wikibugs> 3MediaWiki extensions / 3CentralNotice: CentralNotice: $wgNoticeCloseButton shouldn't load closeWindow19x19.png from upload.wikimedia.org - 10https://bugzilla.wikimedia.org/70462 (10Krinkle) p:5Unprio>3Normal [21:04:51] <grrrit-wm> (03PS1) 10TheDJ: Pass jshint [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/158774 [21:04:57] <grrrit-wm> (03PS3) 10Paladox: Replace Powered by Mediawiki PNG image with SVG version [core] - 10https://gerrit.wikimedia.org/r/142860 (https://bugzilla.wikimedia.org/63872) (owner: 10M4tx) [21:05:14] <grrrit-wm> (03PS4) 10Paladox: Replace Powered by Mediawiki PNG image with SVG version [core] - 10https://gerrit.wikimedia.org/r/142860 (https://bugzilla.wikimedia.org/63872) (owner: 10M4tx) [21:05:44] <grrrit-wm> (03PS1) 10Jackmcbarn: Set vary-revision appropriately with getContent() [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/158775 [21:08:30] <thedj> Krinkle: i moved the wikilove.local execution point to after document.ready (could see no problem in that). and i left multistr in there. [21:08:43] <Krinkle> cool [21:08:56] <Krinkle> It's no problem to disable lots of checks in jshint, as long as it passes. [21:09:04] <Krinkle> that'll still do a lot of useful stuff [21:11:54] <grrrit-wm> (03PS2) 10TheDJ: Pass jshint [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/158774 (https://bugzilla.wikimedia.org/61645) [21:14:32] <grrrit-wm> (03PS1) 10EBernhardson: Allow bundling by count of events [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158778 [21:14:59] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Allow bundling by count of events [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158778 (owner: 10EBernhardson) [21:16:06] <grrrit-wm> (03PS1) 10Manybubbles: Add api to dump mapping and settings [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/158779 [21:17:29] <wikibugs> 3MediaWiki / 3General/Unknown: Creation of 'Author' namespace - 10https://bugzilla.wikimedia.org/70464 (10Gitartha Bordoloi) 3NEW p:3Unprio s:3normal a:3None Hello, Assamese wikisource (as.wikisource.org) was created about one and half years ago and it has now over 1000 pages and a number of active c... [21:18:31] <grrrit-wm> (03CR) 10Ori.livneh: [C: 032] Make require_package() faster and leaner [vagrant] - 10https://gerrit.wikimedia.org/r/158525 (owner: 10Ori.livneh) [21:18:37] <grrrit-wm> (03Merged) 10jenkins-bot: Make require_package() faster and leaner [vagrant] - 10https://gerrit.wikimedia.org/r/158525 (owner: 10Ori.livneh) [21:18:56] <wikibugs> 3Wikimedia / 3Site requests: Creation of 'Author' namespace on Assamese Wikisource (aswikisource) - 10https://bugzilla.wikimedia.org/70464#c1 (10James Forrester) s:5normal>3enhanc Moving to Wikimedia product [21:18:58] <bd808> ori: I meant to merge that last night. Cool code changes [21:19:20] <ori> bd808: shitty commit message but i don't feel like writing a better one [21:21:40] <grrrit-wm> (03CR) 10Ori.livneh: [C: 032] Added a BloomCacheRedisTest class (031 comment) [core] - 10https://gerrit.wikimedia.org/r/158553 (owner: 10Aaron Schulz) [21:21:44] <grrrit-wm> (03CR) 10Dduvall: [C: 04-1] "I know a lot of people are frustrated with the dodginess (I almost wrote "dogginess" which also fits) of the browser test dependencies, bu" [vagrant] - 10https://gerrit.wikimedia.org/r/155861 (owner: 10MaxSem) [21:23:44] <wikibugs> 3MediaWiki extensions / 3Gadgets: Gadget definitions are bloated - 10https://bugzilla.wikimedia.org/70466 (10Ori Livneh) 3NEW p:3Unprio s:3major a:3None On (backend) page request on enwiki, 'enwiki:gadgets-definition:7' is fetched from memcached. It's 53k of data. That is excessive. [21:26:31] <grrrit-wm> (03PS1) 10MaxSem: Don't save gadget class versions, cache key is already versioned [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/158784 [21:27:04] <grrrit-wm> (03PS1) 10TheDJ: Set $wasPosted = true for recursive API access [extensions/WikiLove] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/158785 (https://bugzilla.wikimedia.org/70448) [21:27:45] <grrrit-wm> (03PS1) 10TheDJ: Set $wasPosted = true for recursive API access [extensions/WikiLove] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/158786 (https://bugzilla.wikimedia.org/70448) [21:28:01] <grrrit-wm> (03Merged) 10jenkins-bot: Added a BloomCacheRedisTest class [core] - 10https://gerrit.wikimedia.org/r/158553 (owner: 10Aaron Schulz) [21:28:37] <grrrit-wm> (03CR) 10Reedy: Don't save gadget class versions, cache key is already versioned (031 comment) [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/158784 (owner: 10MaxSem) [21:30:50] <grrrit-wm> (03PS2) 10MaxSem: Don't save gadget class versions, cache key is already versioned [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/158784 [21:31:12] <grrrit-wm> (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (8ad150e4e7) [core] - 10https://gerrit.wikimedia.org/r/158789 [21:32:05] <grrrit-wm> (03PS1) 10Bsitu: mw.echo.overlay.updateCount() not longer exists [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158790 [21:32:35] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] mw.echo.overlay.updateCount() not longer exists [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158790 (owner: 10Bsitu) [21:33:19] <grrrit-wm> (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (8ad150e4e7) [core] - 10https://gerrit.wikimedia.org/r/158789 (owner: 10Jforrester) [21:34:09] <grrrit-wm> (03PS2) 10Spage: mw.echo.overlay.updateCount() not longer exists [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158790 (https://bugzilla.wikimedia.org/69714) (owner: 10Bsitu) [21:34:36] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] mw.echo.overlay.updateCount() not longer exists [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158790 (https://bugzilla.wikimedia.org/69714) (owner: 10Bsitu) [21:35:06] <grrrit-wm> (03PS1) 10Ottomata: Update analytics role and cdh module to work with Trusty [vagrant] - 10https://gerrit.wikimedia.org/r/158791 [21:35:17] <grrrit-wm> (03PS2) 10Ottomata: Update analytics role and cdh module to work with Trusty [vagrant] - 10https://gerrit.wikimedia.org/r/158791 [21:35:19] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Update analytics role and cdh module to work with Trusty [vagrant] - 10https://gerrit.wikimedia.org/r/158791 (owner: 10Ottomata) [21:35:22] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Update analytics role and cdh module to work with Trusty [vagrant] - 10https://gerrit.wikimedia.org/r/158791 (owner: 10Ottomata) [21:35:27] <wikibugs> 3Wikimedia / 3Site requests: Creation of 'Author' namespace on Assamese Wikisource (aswikisource) - 10https://bugzilla.wikimedia.org/70464#c2 (10James Forrester) (In reply to Gitartha Bordoloi from comment #0) > Hello, > Assamese wikisource (as.wikisource.org) was created about one and half years > ago and i... [21:35:54] <grrrit-wm> (03PS3) 10Bsitu: mw.echo.overlay.updateCount() not longer exists [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158790 (https://bugzilla.wikimedia.org/69714) [21:36:58] <grrrit-wm> (03PS28) 10Parent5446: Add Uri class and Uri Query classes [core] - 10https://gerrit.wikimedia.org/r/22167 [21:37:14] <grrrit-wm> (03PS4) 10Bsitu: mw.echo.overlay.updateCount() no longer exists [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158790 (https://bugzilla.wikimedia.org/69714) [21:37:18] <grrrit-wm> (03PS3) 10EBernhardson: Bundle new-topic notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158403 [21:38:21] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Bundle new-topic notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158403 (owner: 10EBernhardson) [21:38:31] <grrrit-wm> (03PS2) 10EBernhardson: Allow bundling by count of events [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158778 [21:38:52] <grrrit-wm> (03CR) 10Parent5446: "PS28: Rebase" [core] - 10https://gerrit.wikimedia.org/r/22167 (owner: 10Parent5446) [21:39:28] <grrrit-wm> (03CR) 10EBernhardson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158403 (owner: 10EBernhardson) [21:40:07] <grrrit-wm> (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (8ad150e4e7) [core] - 10https://gerrit.wikimedia.org/r/158789 (owner: 10Jforrester) [21:41:19] <grrrit-wm> (03PS3) 10Ottomata: Update analytics role and cdh module to work with Trusty [vagrant] - 10https://gerrit.wikimedia.org/r/158791 [21:42:51] <grrrit-wm> (03PS3) 10EBernhardson: Allow bundling by count of events [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158778 [21:43:30] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Add Uri class and Uri Query classes [core] - 10https://gerrit.wikimedia.org/r/22167 (owner: 10Parent5446) [21:46:25] <grrrit-wm> (03PS4) 10EBernhardson: Bundle new-topic notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158403 [21:46:52] <Krinkle> thedj: Thx! [21:47:32] <grrrit-wm> (03PS1) 10Jsahleen: CX Registry: Enable all supported languages by default [services/cxserver] - 10https://gerrit.wikimedia.org/r/158795 [21:48:10] <grrrit-wm> (03CR) 10Chad: [C: 032] Removed LCStoreAccel class [core] - 10https://gerrit.wikimedia.org/r/158676 (owner: 10Aaron Schulz) [21:48:33] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] CX Registry: Enable all supported languages by default [services/cxserver] - 10https://gerrit.wikimedia.org/r/158795 (owner: 10Jsahleen) [21:50:53] <grrrit-wm> (03PS3) 10EBernhardson: Prevent detection of named variables inside quoted strings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158133 [21:52:25] <grrrit-wm> (03PS3) 10Krinkle: Pass jshint [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/158774 (https://bugzilla.wikimedia.org/61645) (owner: 10TheDJ) [21:52:40] <grrrit-wm> (03CR) 10Krinkle: Pass jshint (032 comments) [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/158774 (https://bugzilla.wikimedia.org/61645) (owner: 10TheDJ) [21:52:49] <grrrit-wm> (03CR) 10Krinkle: [C: 04-1] Pass jshint (031 comment) [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/158774 (https://bugzilla.wikimedia.org/61645) (owner: 10TheDJ) [21:53:14] <grrrit-wm> (03CR) 10Parent5446: [C: 04-1] "Need to:" [core] - 10https://gerrit.wikimedia.org/r/22167 (owner: 10Parent5446) [21:53:30] <grrrit-wm> (03PS4) 10EBernhardson: Prevent detection of named variables inside quoted strings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158133 [21:54:39] <grrrit-wm> (03Merged) 10jenkins-bot: Removed LCStoreAccel class [core] - 10https://gerrit.wikimedia.org/r/158676 (owner: 10Aaron Schulz) [21:54:55] <grrrit-wm> (03CR) 10MarkTraceur: "Am I reading this wrong, or is DSC not blacklisted?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158337 (https://bugzilla.wikimedia.org/65624) (owner: 10Gilles) [21:55:15] <grrrit-wm> (03CR) 10MarkTraceur: "(IMG, sorry, but DSC also doesn't return a failed check)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158337 (https://bugzilla.wikimedia.org/65624) (owner: 10Gilles) [21:55:25] <grrrit-wm> (03PS1) 10Aaron Schulz: Release notes for b1d215726e [core] - 10https://gerrit.wikimedia.org/r/158799 [21:55:27] <AaronS> ^d: ^ [21:55:37] <grrrit-wm> (03CR) 10MarkTraceur: "Oh, my bad, tbaction=create instead of upload" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158337 (https://bugzilla.wikimedia.org/65624) (owner: 10Gilles) [21:55:41] <grrrit-wm> (03CR) 10Bsitu: [C: 032] Prevent detection of named variables inside quoted strings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158133 (owner: 10EBernhardson) [21:55:45] <grrrit-wm> (03CR) 10Chad: [C: 032] Release notes for b1d215726e [core] - 10https://gerrit.wikimedia.org/r/158799 (owner: 10Aaron Schulz) [21:56:25] <grrrit-wm> (03Merged) 10jenkins-bot: Prevent detection of named variables inside quoted strings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158133 (owner: 10EBernhardson) [21:56:56] <wikibugs> 3MediaWiki / 3User preferences: Create a "Watching and notifications" tab in MediaWiki core - 10https://bugzilla.wikimedia.org/63577#c5 (10Krinkle) Right now "Watchlist" (from MediaWiki) and "Notifications" (from Echo) are separate preference tabs. Neither is particularly small or related to the other. Why s... [21:57:23] <grrrit-wm> (03CR) 10MarkTraceur: [C: 04-1] "The function documentation for the preprocess method suggests that the file: prefix should probably be added there." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158337 (https://bugzilla.wikimedia.org/65624) (owner: 10Gilles) [21:57:57] <wikibugs> 3MediaWiki / 3MediaWiki UI: VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages - 10https://bugzilla.wikimedia.org/56363#c7 (10Jared Zimmerman (WMF)) Cancel just returns an error for me now anyway. [21:58:07] <grrrit-wm> (03PS1) 10BryanDavis: Apply vform styling to HTMLForm buttons [core] - 10https://gerrit.wikimedia.org/r/158800 [21:58:41] <wikibugs> 3MediaWiki / 3User preferences: Create a "Watching and notifications" tab in MediaWiki core - 10https://bugzilla.wikimedia.org/63577#c6 (10Krinkle) (In reply to Krinkle from comment #5) > Right now "Watchlist" (from MediaWiki) and "Notifications" (from Echo) are > separate preference tabs. Neither is particu... [22:02:23] <grrrit-wm> (03Merged) 10jenkins-bot: Release notes for b1d215726e [core] - 10https://gerrit.wikimedia.org/r/158799 (owner: 10Aaron Schulz) [22:08:14] <grrrit-wm> (03CR) 10Spage: [C: 032] "Gonna +2 this and see if it works, it's just an annotation." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158670 (owner: 10Spage) [22:08:50] <grrrit-wm> (03Merged) 10jenkins-bot: Annotate this test so it runs. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158670 (owner: 10Spage) [22:09:26] <jackmcbarn> legoktm: {{sudo make me a sandwich}}? really? [22:09:33] <legoktm> :PPPP [22:09:39] <jackmcbarn> that confuses the heck out EPH [22:09:47] <legoktm> LOL [22:09:50] <jackmcbarn> (not because of the name, but because you hardcode answered=yes}} [22:10:07] <grrrit-wm> (03PS1) 10Arlolra: Revert some of Iae873906abcd8b2a986e5f728f0ce207256de770 [skins/Vector] - 10https://gerrit.wikimedia.org/r/158803 [22:11:21] <grrrit-wm> (03CR) 10Bartosz Dziewoński: Revert some of Iae873906abcd8b2a986e5f728f0ce207256de770 (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/158803 (owner: 10Arlolra) [22:13:15] <grrrit-wm> (03CR) 10Ori.livneh: [C: 04-1] Update analytics role and cdh module to work with Trusty (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/158791 (owner: 10Ottomata) [22:14:54] <grrrit-wm> (03PS5) 10EBernhardson: Bundle new-topic notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158403 [22:16:39] <grrrit-wm> (03PS3) 10Umherirrender: Add parser tests for tables with pipes and wikilinks [core] - 10https://gerrit.wikimedia.org/r/146733 [22:18:26] <grrrit-wm> (03PS2) 10EBernhardson: Expose event count as a formatter parameter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158752 [22:18:31] <grrrit-wm> (03PS4) 10EBernhardson: Allow bundling by count of events [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158778 [22:20:18] <grrrit-wm> (03PS2) 10Arlolra: Revert some of Iae873906abcd8b2a986e5f728f0ce207256de770 [skins/Vector] - 10https://gerrit.wikimedia.org/r/158803 [22:22:09] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 031] Merge mediawiki.legacy.upload into mediawiki.special.upload [core] - 10https://gerrit.wikimedia.org/r/158677 (https://bugzilla.wikimedia.org/31946) (owner: 10Alex Monk) [22:24:18] <grrrit-wm> (03CR) 10Ori.livneh: Add globaluserpage role (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/158610 (owner: 10Legoktm) [22:27:58] <mutante> !beg_for_reviews [22:28:07] <ori> mutante: which? :) [22:28:15] <grrrit-wm> (03PS13) 10Krinkle: Show deprecation notices when accessing wg* JavaScript globals [core] - 10https://gerrit.wikimedia.org/r/133162 (https://bugzilla.wikimedia.org/56550) (owner: 10Gerrit Patch Uploader) [22:28:22] <mutante> ori: in this channel, mw-config :) [22:28:25] <mutante> https://gerrit.wikimedia.org/r/#/q/project:operations/mediawiki-config+owner:dzahn+status:open,n,z [22:29:22] <mutante> ori: i figured if it's mw-config, it's platform, it's -dev . does that even make sense? [22:29:32] <ori> yeah [22:29:49] <mutante> 'k, cool, treat me like a volunteer for those [22:29:54] * ori has his 1:1 with rob, bbiab [22:30:03] <Reedy> Are we importing stuff for them etc? [22:30:16] <mutante> Reedy: yes, they want us to import [22:30:25] <Reedy> i'm a little hesistant about creating a db if then we have to import the full db [22:30:30] <mutante> and from what i've heard it's neither sqldump nor special:import [22:30:36] <mutante> but instead maintenance script [22:30:55] <Reedy> so xml dump presumably? [22:31:04] <grrrit-wm> (03PS8) 10Paladox: Add support for svg in .list-style-image [core] - 10https://gerrit.wikimedia.org/r/158505 [22:31:07] <mutante> i think so, but jeremyb has talked more to them than i have [22:31:31] <grrrit-wm> (03CR) 10GWicke: [C: 031] "LGTM. Letting others weigh in as well." [skins/Vector] - 10https://gerrit.wikimedia.org/r/158803 (owner: 10Arlolra) [22:32:13] <Reedy> mutante: has anyone done the apache config? xD [22:32:43] <Reedy> IIRC it should just be adding a ServerAlias [22:34:25] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Show deprecation notices when accessing wg* JavaScript globals [core] - 10https://gerrit.wikimedia.org/r/133162 (https://bugzilla.wikimedia.org/56550) (owner: 10Gerrit Patch Uploader) [22:37:35] <mutante> Reedy: nope, dont think so [22:38:47] * Reedy is still waiting for extensions and such to update [22:42:43] <wikibugs> 3MediaWiki / 3Parser: .editsection links should not be part of the <h#> element - 10https://bugzilla.wikimedia.org/11555 (10Bartosz Dziewoński) a:5Bartosz Dziewoński>3None [22:44:56] <wikibugs> 3MediaWiki / 3JavaScript: Set $wgLegacyJavaScriptGlobals = false by default - 10https://bugzilla.wikimedia.org/33837 (10Krinkle) [22:44:58] <wikibugs> 3MediaWiki / 3JavaScript: Show deprecation notices when accessing wg* JavaScript globals - 10https://bugzilla.wikimedia.org/56550 (10Krinkle) [22:45:00] <wikibugs> 3MediaWiki / 3JavaScript: Remove legacy javascript globals - 10https://bugzilla.wikimedia.org/70470 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None Once we have deprecation notices (bug 56550), turn them off by default (bug 33837) and leave that state as migration period (1 release cycle), we should rem... [22:47:34] <grrrit-wm> (03PS1) 10MaxSem: Ability to disable gadget caching [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/158809 [22:52:28] <bd808> Do I need to do something special when using addModules() to tell resource loader to look for .less instead of .css? [22:53:21] <bd808> I'm getting a RL error message for my new special page development stuff -- 'ResourceLoaderFileModule::readStyleFile: style file not found: "/vagrant/mediawiki/extensions/CentralAuth/modules/ext.centralauth.globalrenamerequest.css"' [22:55:19] <grrrit-wm> (03PS2) 10Jsahleen: CX Registry: Enable all supported languages by default [services/cxserver] - 10https://gerrit.wikimedia.org/r/158795 [22:56:40] <grrrit-wm> (03PS14) 10Krinkle: mw.config: Show deprecation notices when accessing wg* globals [core] - 10https://gerrit.wikimedia.org/r/133162 (https://bugzilla.wikimedia.org/56550) (owner: 10Gerrit Patch Uploader) [22:59:17] <grrrit-wm> (03CR) 10Krinkle: [C: 032] Pass Config to ResourceLoader constructor in a few places [core] - 10https://gerrit.wikimedia.org/r/155869 (owner: 10Legoktm) [22:59:46] <grrrit-wm> (03PS3) 10Krinkle: resourceloader: Pass a Config to the ResourceLoader constructor [core] - 10https://gerrit.wikimedia.org/r/155869 (owner: 10Legoktm) [23:00:02] <grrrit-wm> (03CR) 10Krinkle: [C: 032] resourceloader: Pass a Config to the ResourceLoader constructor [core] - 10https://gerrit.wikimedia.org/r/155869 (owner: 10Legoktm) [23:00:17] <grrrit-wm> (03PS3) 10Mattflaschen: mw.Debug.profile: Tweak support check to handle PhantomJS [core] - 10https://gerrit.wikimedia.org/r/144601 [23:01:31] <grrrit-wm> (03CR) 10Mattflaschen: "No, since that doesn't work, at least not on PhantomJS 1.9.7." [core] - 10https://gerrit.wikimedia.org/r/144601 (owner: 10Mattflaschen) [23:01:32] <bd808> nm. I figured out what I did wrong. No wgResourceModules declaration [23:01:38] <grrrit-wm> (03PS4) 10CSteipp: Check for renamed user on login [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156947 (https://bugzilla.wikimedia.org/67995) [23:01:40] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Check for renamed user on login [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156947 (https://bugzilla.wikimedia.org/67995) (owner: 10CSteipp) [23:02:15] <grrrit-wm> (03CR) 10Mattflaschen: "This doesn't work for me. It just throws an error immediately (see below). The issue is that this just sets createSvgElement to a functi" [core] - 10https://gerrit.wikimedia.org/r/156215 (owner: 10EBernhardson) [23:02:53] <grrrit-wm> (03PS3) 10Jsahleen: CX Registry: Enable all supported languages by default [services/cxserver] - 10https://gerrit.wikimedia.org/r/158795 [23:04:31] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] CX Registry: Enable all supported languages by default [services/cxserver] - 10https://gerrit.wikimedia.org/r/158795 (owner: 10Jsahleen) [23:05:10] <grrrit-wm> (03PS1) 10Chad: img_auth: fix mismatched profiling [core] - 10https://gerrit.wikimedia.org/r/158812 [23:05:16] <^d> AaronS: ^ [23:06:14] <wikibugs> 3MediaWiki extensions / 3MassMessage: CreateMassMessageList title input should use AJAX to warn about preëxisting titles - 10https://bugzilla.wikimedia.org/70471 (10MZMcBride) 3NEW p:3Unprio s:3enhanc a:3None If I go to <http://mm-ch.wmflabs.org/wiki/Special:CreateMassMessageList> and type in "Privac... [23:06:21] <grrrit-wm> (03PS4) 10Jsahleen: CX Registry: Enable all supported languages by default [services/cxserver] - 10https://gerrit.wikimedia.org/r/158795 [23:06:33] <grrrit-wm> (03Merged) 10jenkins-bot: resourceloader: Pass a Config to the ResourceLoader constructor [core] - 10https://gerrit.wikimedia.org/r/155869 (owner: 10Legoktm) [23:07:07] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] CX Registry: Enable all supported languages by default [services/cxserver] - 10https://gerrit.wikimedia.org/r/158795 (owner: 10Jsahleen) [23:09:02] <grrrit-wm> (03PS5) 10Jsahleen: CX Registry: Enable all supported languages by default [services/cxserver] - 10https://gerrit.wikimedia.org/r/158795 [23:11:09] <grrrit-wm> (03CR) 10Aaron Schulz: [C: 032] img_auth: fix mismatched profiling [core] - 10https://gerrit.wikimedia.org/r/158812 (owner: 10Chad) [23:14:20] <grrrit-wm> (03PS43) 10Alex Monk: Fetch cross-wiki user groups from target wiki instead of assuming local [core] - 10https://gerrit.wikimedia.org/r/36330 (https://bugzilla.wikimedia.org/12518) [23:14:52] <grrrit-wm> (03CR) 10Alex Monk: "I haven't actually tested this patch set." [core] - 10https://gerrit.wikimedia.org/r/36330 (https://bugzilla.wikimedia.org/12518) (owner: 10Alex Monk) [23:17:14] <grrrit-wm> (03Merged) 10jenkins-bot: img_auth: fix mismatched profiling [core] - 10https://gerrit.wikimedia.org/r/158812 (owner: 10Chad) [23:20:41] <grrrit-wm> (03CR) 10Krinkle: "What part of it? It looks functionally the same." [core] - 10https://gerrit.wikimedia.org/r/144601 (owner: 10Mattflaschen) [23:21:58] <grrrit-wm> (03CR) 10Krinkle: [C: 032] "Anyhow, I like centralising the feature test, and checking bind on the host method directly makes sense since browsers are known to have t" [core] - 10https://gerrit.wikimedia.org/r/144601 (owner: 10Mattflaschen) [23:22:54] <thedj> i propose we stop updating en.wp [23:23:16] <thedj> I've sort of had it with that community [23:23:31] <grrrit-wm> (03CR) 10Legoktm: [C: 031] resourceloader: Only store sources' load.php urls [core] - 10https://gerrit.wikimedia.org/r/156083 (https://bugzilla.wikimedia.org/69878) (owner: 10Legoktm) [23:23:36] <Reedy> Doesn't that become a bigger maintenance burden? ;) [23:23:38] <MatmaRex> thedj: +1 [23:23:40] <thedj> they can lock themselves in a F;ing cave if they want to so badly [23:24:00] <legoktm> the worst part is that they'd probably like that too. [23:24:08] <thedj> https://en.wikipedia.org/wiki/Wikipedia:Administrators%27_noticeboard/Incidents#Inappropriate_threats_by_User:Fram [23:24:12] <thedj> read that.. [23:24:13] <thedj> pathetic [23:28:22] <grrrit-wm> (03Merged) 10jenkins-bot: mw.Debug.profile: Tweak support check to handle PhantomJS [core] - 10https://gerrit.wikimedia.org/r/144601 (owner: 10Mattflaschen) [23:30:46] <grrrit-wm> (03PS1) 10Bsitu: Hide 'Cancel' button on preview screen [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158818 [23:31:18] <bd808> marxarelli: I think I just stumbled onto the cause of Yurik's database explosion woes. If the LocalSettings.php file gets wiped out (as happens when at some point there is a php syntax error while running vagrant provision) the next time provision runs it will try to install a new wiki into the existing database and all hell breaks loose. [23:31:22] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Hide 'Cancel' button on preview screen [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158818 (owner: 10Bsitu) [23:31:52] <bd808> marxarelli: This is https://bugzilla.wikimedia.org/show_bug.cgi?id=50912 [23:32:20] <marxarelli> bd808: oh boy! [23:32:54] <bd808> I just had it bite me on a labs instance and I have the same mysql error as Yurik had [23:33:26] <marxarelli> what introduces the bad syntax? [23:33:39] <bd808> We run sql.php to validate the database. If that fails we wipe out LocalSettings.php and try to reinstall [23:33:52] <bd808> In my case, a failed rebase that I didn't notice [23:34:37] <grrrit-wm> (03CR) 10Legoktm: [C: 04-1] "Need to fix something else first" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/158578 (https://bugzilla.wikimedia.org/70392) (owner: 10Legoktm) [23:35:10] <marxarelli> hmm.. i see [23:36:10] <marxarelli> bd808: would it be better to just check for the db with sql? [23:36:13] <grrrit-wm> (03PS2) 10Bsitu: Hide 'Cancel' button on preview screen [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158818 [23:36:47] <mutante> YuviPanda|zzzz: it works now [23:36:49] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Hide 'Cancel' button on preview screen [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158818 (owner: 10Bsitu) [23:36:53] <bd808> marxarelli: Maybe. It's a sticky problem. It might be better to make the user decide what to do manually. [23:37:30] <bd808> Run the check that we use now and abort the puppet run if it fail instead of deleting files. [23:37:54] <bd808> Tell the user to cleanup the old LocalSettings.php themselves [23:38:07] * bd808 has to duck out for a minute [23:38:16] <marxarelli> or give them the output of mwscript sql.php ? [23:38:19] <grrrit-wm> (03PS3) 10Bsitu: Hide 'Cancel' button on preview screen [extensions/Flow] - 10https://gerrit.wikimedia.org/r/158818 [23:38:31] <marxarelli> *and* give them [23:42:52] <bd808> marxarelli: Yeah. That would have helped in my case I think. [23:43:11] <grrrit-wm> (03PS1) 10EBernhardson: Show alerts tab if active notifications and no messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158820 (https://bugzilla.wikimedia.org/70461) [23:43:37] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Show alerts tab if active notifications and no messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158820 (https://bugzilla.wikimedia.org/70461) (owner: 10EBernhardson) [23:45:22] <grrrit-wm> (03PS2) 10EBernhardson: Show alerts tab if active notifications and no messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158820 (https://bugzilla.wikimedia.org/70461) [23:45:52] <grrrit-wm> (03PS1) 10EBernhardson: Hygiene: Dont run jshint against .less files [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158822 [23:45:55] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Show alerts tab if active notifications and no messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/158820 (https://bugzilla.wikimedia.org/70461) (owner: 10EBernhardson) [23:46:33] <grrrit-wm> (03CR) 10Alex Monk: "> var_dump( array_keys( $wgConf->getConfig( 'mediawiki_dev_2', 'wgImplicitGroups' ) ) );" [core] - 10https://gerrit.wikimedia.org/r/36330 (https://bugzilla.wikimedia.org/12518) (owner: 10Alex Monk) [23:47:46] <marxarelli> bd808: hmm, what's the best way to handle that in puppet. looks like we could use an exec with the logoutput option but i don't know how to prepend that with a more helpful message [23:48:36] <bd808> marxarelli: Probably by wrapping it in a shell script that is smarter about what it outputs [23:48:38] <marxarelli> i guess you could do exec { command => "echo helpful message && mwscript ..." } [23:49:01] <marxarelli> bd808: that sounds cleaner :) [23:51:08] <marxarelli> bd808: if you want to assign that to me i can tackle it on monday [23:51:49] <grrrit-wm> (03CR) 10Alex Monk: "Anyway my code broke for different reasons. Which I will fix in patch set... 44. Urgh." [core] - 10https://gerrit.wikimedia.org/r/36330 (https://bugzilla.wikimedia.org/12518) (owner: 10Alex Monk) [23:52:38] <grrrit-wm> (03PS44) 10Alex Monk: Fetch cross-wiki user groups from target wiki instead of assuming local [core] - 10https://gerrit.wikimedia.org/r/36330 (https://bugzilla.wikimedia.org/12518) [23:56:02] <grrrit-wm> (03Abandoned) 10Bartosz Dziewoński: jquery.byteLimit: Restore caret position after limiting [core] - 10https://gerrit.wikimedia.org/r/114959 (https://bugzilla.wikimedia.org/61450) (owner: 10Bartosz Dziewoński) [23:56:43] <wikibugs> 3MediaWiki / 3JavaScript: Cursor jumps to the end of the summary field after pasting more text than is allowed - 10https://bugzilla.wikimedia.org/61450 (10Bartosz Dziewoński) 5PATC>3NEW [23:56:45] <wikibugs> 3MediaWiki / 3JavaScript: Cursor jumps to the end of the summary field after pasting more text than is allowed - 10https://bugzilla.wikimedia.org/61450 (10Bartosz Dziewoński) a:5Bartosz Dziewoński>3None