[00:00:28] 3MediaWiki extensions / 3CirrusSearch: Stemming: CirrusSearch does not find Биология for a Биологии query on ru.wp (but LuceneSearch does) - 10https://bugzilla.wikimedia.org/69766#c8 (10Nik Everett) Proposed fix: https://gerrit.wikimedia.org/r/#/c/156699/ [00:02:30] 3MediaWiki-Vagrant: Vector + MWV = fucked up shit happening - 10https://bugzilla.wikimedia.org/70114 (10Steven Walling) 3NEW p:3Unprio s:3normal a:3Ori Livneh Created attachment 16302 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16302&action=edit Screenshot What this is I don't even... Mult... [00:03:35] (03PS1) 10Bsitu: Add profiling to Echo notification API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156737 [00:11:58] 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c20 (10Krinkle) (In reply to Krinkle from comment #19) > Another solution would be to return early instead of wrap the whole thing. > > While a return statement is no... [00:13:01] (03CR) 10EBernhardson: "This will help get a general idea of if average requests are slow, but to know where to focus performance efforts we would need to profile" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156737 (owner: 10Bsitu) [00:18:51] (03PS1) 10Jdlrobson: Update classes of topic during close/reopen actions. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156739 (https://bugzilla.wikimedia.org/68328) [00:18:59] StevenW: what's the output of $ ls /vagrant/mediawiki/skins [00:19:27] (03CR) 10jenkins-bot: [V: 04-1] Update classes of topic during close/reopen actions. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156739 (https://bugzilla.wikimedia.org/68328) (owner: 10Jdlrobson) [00:22:24] (03CR) 10MSyed: ".navbar-default .navbar-nav > li > a {" [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/156499 (owner: 10Prtksxna) [00:23:10] legoktm: Vector etc. are in the skins directory [00:23:28] 3MediaWiki-Vagrant: Vector + MWV = fucked up shit happening - 10https://bugzilla.wikimedia.org/70114#c1 (10Bryan Davis) Something is wonky with your mediawiki checkout and puppet won't be able to fix it I don't think. Try doing this: $ cd vagrant/mediawiki $ git pull $ cd skins $ rm -rf Vector # might not be... [00:23:48] StevenW: what about $ ls /vagrant/mediawiki/skins/Vector [00:24:01] (03CR) 10MSyed: [C: 04-1] "For the footer, align the report name with the logo." [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/156499 (owner: 10Prtksxna) [00:24:16] StevenW, legoktm: https://bugzilla.wikimedia.org/show_bug.cgi?id=70114#c1 [00:24:19] legoktm: hooks.txt i18n skinStyles [00:24:25] bd808: will try in a bit [00:24:26] ok, well that's your problem [00:24:29] thanks for helping me out [00:24:35] you probably checked out an old core which clobbered your checkout [00:24:41] my guess too [00:24:44] a $ git reset --hard in Vector should fix it [00:26:16] when i try to check out an old core with Vector, git complains and makes me fix it before it will let me checkout, so i'm not sure how that would have happened [00:27:09] I'm not sure what combination of things leads to it happening, but I had a very similar thing happen to my dev vm a couple of days ago [00:27:10] (03PS2) 10Bsitu: Add profiling to Echo notification API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156737 [00:27:41] skins/Vector was mysteriously at a very old revision that didn't work [00:28:32] I'll try the full instructions you provided on the bug bd808 [00:28:52] git just clobbers my skins/Vector when I do it [01:00:25] (03PS1) 10Vogone: Change group message on Special:CentralAuth [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156742 [01:10:58] (03PS1) 10Jackmcbarn: Fix __pairs not working in LuaStandalone serialization [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/156743 [01:17:09] (03CR) 10Jackmcbarn: [C: 04-1] Handle __pairs when marshalling Lua-to-PHP (031 comment) [php/luasandbox] - 10https://gerrit.wikimedia.org/r/84985 (owner: 10Anomie) [01:18:51] (03PS4) 10Legoktm: [WIP] Add MultiConfig for fallback logic [core] - 10https://gerrit.wikimedia.org/r/153541 (https://bugzilla.wikimedia.org/69418) [01:25:03] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add MultiConfig for fallback logic [core] - 10https://gerrit.wikimedia.org/r/153541 (https://bugzilla.wikimedia.org/69418) (owner: 10Legoktm) [01:28:35] (03CR) 10Chad: [WIP] Add MultiConfig for fallback logic (031 comment) [core] - 10https://gerrit.wikimedia.org/r/153541 (https://bugzilla.wikimedia.org/69418) (owner: 10Legoktm) [01:34:53] (03CR) 10Jackmcbarn: "I also think I figured out why the backtrace is funny. When you call luasandbox_call_lua from luasandbox_lua_to_array, you're already insi" (031 comment) [php/luasandbox] - 10https://gerrit.wikimedia.org/r/84985 (owner: 10Anomie) [01:37:22] (03CR) 10Chad: [C: 032] Use unicode regexes with character classes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156699 (https://bugzilla.wikimedia.org/69766) (owner: 10Manybubbles) [01:37:35] (03Merged) 10jenkins-bot: Use unicode regexes with character classes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156699 (https://bugzilla.wikimedia.org/69766) (owner: 10Manybubbles) [01:39:41] (03CR) 10Chad: "Move it all into a class!" [core] - 10https://gerrit.wikimedia.org/r/153744 (owner: 10Withoutaname) [01:40:29] (03CR) 10Chad: [C: 032] Consolidate parts of WebStart.php and doMaintenance.php into Initialize.php [core] - 10https://gerrit.wikimedia.org/r/156053 (owner: 10Withoutaname) [01:46:38] (03Merged) 10jenkins-bot: Consolidate parts of WebStart.php and doMaintenance.php into Initialize.php [core] - 10https://gerrit.wikimedia.org/r/156053 (owner: 10Withoutaname) [01:49:29] (03CR) 10Legoktm: [WIP] Add MultiConfig for fallback logic (031 comment) [core] - 10https://gerrit.wikimedia.org/r/153541 (https://bugzilla.wikimedia.org/69418) (owner: 10Legoktm) [01:51:37] ^d: ^ ideas welcome :D [01:52:50] <^d> This is where I got stuck last time. [01:53:01] <^d> It's the hard part to solve. Key => value stores for config is the easy part :p [01:55:47] well, ignoring wiki farm things, right now I need a way to specify array( 'defaultsettings', 'globalvar' ) somewhere for the MultiConfig to read [01:56:10] I suppose we could change $wgConfigRegistry to take more parameters than just the callback [01:56:26] <^d> That was my first thought. [01:56:48] $wgConfigRegistry['main'] = array( 'factory' => 'MultiConfig::newInstance', 'order' => array( 'defaultsettings', 'globalvar' ) ); [01:56:59] and then pass 'order' to newInstance [01:58:04] 'order [01:58:07] woops [01:58:09] ignore that [01:58:45] your input is appreciated too :) [01:59:10] 'order' is kind of MultiConfig-specific, so we'd want to make it some sort of agnostic thing where the entirety of the $wgConfigRegistry entry is passed as an array to the constructor. [01:59:38] So like $config = $wgConfigRegistry[$key]($wgConfigRegistry[$key]); [01:59:49] That's not right :/ [01:59:57] So like $config = $wgConfigRegistry[$key]['factory']($wgConfigRegistry[$key]); [02:00:02] yeah [02:01:33] though I think Daniel didn't like array constructor pattern, which is why we did factory functions [02:02:25] https://gerrit.wikimedia.org/r/#/c/109850/ his comments on PS9 [02:02:57] <^d> Oooh, callbacks. [02:02:59] <^d> I have idea. [02:03:04] <^d> $wgConfigRegistry = array( [02:03:05] <^d> 'main' => function( $configFactory ) { [02:03:05] <^d> $mainConfig = MultiConfig::newInstance( $configFactory->getConfigs() ); [02:03:07] <^d> $mainConfig->setOrder( 'defaultsettings', 'globalvarconfig' ); [02:03:08] <^d> return $mainConfig; [02:03:11] <^d> } [02:03:12] <^d> ); [02:03:20] ^Yeah that would be the solution compatible with both opinions. [02:03:30] ok [02:04:30] Who feels like fixing the gadget part of https://bugzilla.wikimedia.org/69501 ? [02:05:29] we'll just have to put the callback as a static function on the MultiConfig class (or maybe somewhere else?) because PHP segfaults with closures stored in global variables [02:05:43] I could do it, but user account policy -_- [02:05:49] Krenair: which gadget needs fixing? [02:05:55] oh https://en.wikipedia.org/wiki/MediaWiki:Gadget-edittop.js [02:06:54] that looks complicated :P [02:07:48] It should be a case of adding (|ve) to the regex which picks out §ion= to pick up &vesection= [02:10:08] though I'm not sure about the bit involving transcluded sections [02:14:59] (03PS5) 10Legoktm: [WIP] Add MultiConfig for fallback logic [core] - 10https://gerrit.wikimedia.org/r/153541 (https://bugzilla.wikimedia.org/69418) [02:15:19] ^ I did not test that :P [02:19:40] <^d> legoktm: works in hhvm :p [02:19:45] <^d> no segfault [02:20:02] (03CR) 10Spage: [C: 04-1] "Cucumber complains in e.g. features/messages.feature:6:in `Given I am logged in with no notifications' :" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152941 (owner: 10Jdlrobson) [02:20:11] the segfault is just a 5.3 thing [02:20:31] the bug was fixed in 5.4 iirc [02:20:54] <^d> time2bump [02:21:18] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add MultiConfig for fallback logic [core] - 10https://gerrit.wikimedia.org/r/153541 (https://bugzilla.wikimedia.org/69418) (owner: 10Legoktm) [02:21:31] yay, it works! [02:23:43] ok, I'll get that into a mergable state now... [02:26:28] 3MediaWiki extensions / 3Scribunto: Attempt to concatenate a nil value when using mw.html:css - 10https://bugzilla.wikimedia.org/69481#c8 (10Jackmcbarn) The difference happens when preg_split is called. var_dump( preg_split( '//us', "[\xF4\x8F\xBF\xBF]", null, PREG_SPLIT_NO_EMPTY ) ); On Linux: array(3) {... [02:29:20] (03CR) 10Bsitu: [C: 031] Freeze Flow and Echo extensions for group2 wikis [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156678 (owner: 10Spage) [02:36:08] (03CR) 10MZMcBride: "I think this now has to wait until after the ContentHandler branch is merged into master, but I'd still really like to see this implemente" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97628 (https://bugzilla.wikimedia.org/57472) (owner: 10Legoktm) [02:37:13] 3MediaWiki extensions / 3Scribunto: Attempt to concatenate a nil value when using mw.html:css - 10https://bugzilla.wikimedia.org/69481#c9 (10Jackmcbarn) That happens because U+10FFFF is considered an invalid character on Windows but not Linux. preg_match("/\xF4\x8F\xBF\xBF/u", "foobar"); produces "Warning: p... [02:43:41] (03CR) 10Legoktm: [C: 032] Add tests to Database group [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/156498 (owner: 10Wctaiwan) [02:44:09] (03Merged) 10jenkins-bot: Add tests to Database group [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/156498 (owner: 10Wctaiwan) [03:03:03] (03PS6) 10Isarra: Cleanup special:interwiki intro (some more) [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/156190 [03:03:05] (03CR) 10jenkins-bot: [V: 04-1] Cleanup special:interwiki intro (some more) [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/156190 (owner: 10Isarra) [03:05:55] (03CR) 10Gilles: "Brian, any chance you could revisit this and add tests using test files?" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108482 (https://bugzilla.wikimedia.org/60245) (owner: 10Brian Wolff) [03:06:58] 3MediaWiki extensions / 3WikidataRepo: At trying to add interwikis to the Slovene Wikipedia, the software incorrectly searches the 'sk' database instead of the 'sl' one - 10https://bugzilla.wikimedia.org/67566#c6 (10Marius Hoch) 5UNCO>3RESO/WOR I was able to create https://www.wikidata.org/wiki/Q17627755... [03:09:20] (03CR) 10Mwjames: Consolidate parts of WebStart.php and doMaintenance.php into Initialize.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156053 (owner: 10Withoutaname) [03:14:13] 3MediaWiki extensions / 3WikidataClient: Showing only language without project during linking pages to Wikidata item from client - 10https://bugzilla.wikimedia.org/69790#c2 (10Marius Hoch) 5UNCO>3NEW Mh... I'm not even sure we actually want to show links to other projects in there... is that confusing to... [03:17:52] Can anyone explain this? https://gerrit.wikimedia.org/r/#/c/156636/1/i18n/qqq.json [03:18:33] (03CR) 10PleaseStand: Consolidate parts of WebStart.php and doMaintenance.php into Initialize.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156053 (owner: 10Withoutaname) [03:20:23] (03CR) 10Hoo man: [C: 032] Add option to ignore the revision limit (031 comment) [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/156705 (owner: 10Legoktm) [03:20:31] (03Merged) 10jenkins-bot: Add option to ignore the revision limit [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/156705 (owner: 10Legoktm) [03:31:47] (03CR) 10Hoo man: "mh... not sure this actually is an improvement... it right now says "Global groups: " and not "Global group memberships: " (or something l" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156742 (owner: 10Vogone) [03:33:28] (03PS1) 10Legoktm: @var bool [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/156748 [03:33:41] hoo: ^ [03:34:40] :D [03:35:05] (03CR) 10Hoo man: [C: 032] @var bool [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/156748 (owner: 10Legoktm) [03:35:11] (03Merged) 10jenkins-bot: @var bool [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/156748 (owner: 10Legoktm) [03:36:35] (03PS10) 10Isarra: Add support for enabling and displaying global interwikis [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/147755 (https://bugzilla.wikimedia.org/68241) [03:38:36] legoktm: Want to put your enwiki Admin hat on for a second? [03:38:42] okay [03:38:47] * legoktm puts on a hat [03:38:56] https://en.wikipedia.org/wiki/Special:Contributions/69.157.76.40 [03:39:09] I think that user needs a block in order to be forced to read the talk page :S [03:41:24] I don't even get what they're doing [03:42:52] legoktm: Neither do I... but it's not always harmful [03:42:56] mostly, but not always [03:43:04] I blocked them for 24h [03:43:12] Ok, good enough, I hope [03:59:47] (03PS4) 10Prtksxna: Translations for French [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/156499 [04:20:18] (03PS1) 10Pastakhov: fix highlighting mnemonic (v 1.7.3) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156749 [04:24:34] (03PS1) 10Isarra: Put back interwiki-legend qqq string [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/156750 [04:25:37] (03CR) 10Legoktm: [C: 032] Put back interwiki-legend qqq string [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/156750 (owner: 10Isarra) [04:25:39] (03Merged) 10jenkins-bot: Put back interwiki-legend qqq string [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/156750 (owner: 10Isarra) [04:26:35] legoktm: Uh, turns out I mixed it up again. >.> [04:27:42] >.< [04:27:49] I assumed you checked :P [04:28:01] REALLY EASY TO MIX UP. [04:28:21] heh [04:28:24] submit another patch? [04:28:51] (03PS1) 10Isarra: REALLY EASY TO MIX UP. [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/156751 [04:29:21] ehhhhh [04:29:24] don't change the en key [04:29:29] because it's already on TWN [04:29:35] change the qqq key [04:29:44] rage. [04:29:45] But the en was the one I mixed up. [04:29:51] >.> [04:30:02] Also it shouldn't be translated anyway! [04:30:07] Fine. [04:30:10] oh it shoudn't? [04:30:20] then your qqq should be "{{notranslate}}" [04:30:45] It is! Well, that and some other stuff. [04:30:56] (03CR) 10Pastakhov: [C: 032] fix highlighting mnemonic (v 1.7.3) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156749 (owner: 10Pastakhov) [04:30:57] Because apparently it still needs other stuff. [04:30:59] ah [04:31:00] (03Merged) 10jenkins-bot: fix highlighting mnemonic (v 1.7.3) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156749 (owner: 10Pastakhov) [04:31:01] Though I don't know why. [04:31:01] okay [04:31:10] so changing the en should be fine [04:31:54] (03PS2) 10Isarra: REALLY EASY TO MIX UP. [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/156751 [04:32:16] (03PS3) 10Legoktm: Really fix "interwiki-legend" message key. [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/156751 (owner: 10Isarra) [04:32:21] oh [04:32:22] oops [04:32:41] XD [04:32:49] now gerrit is confused [04:32:49] Sorry. [04:32:52] >.> [04:33:20] nope, my fault [04:33:22] I don't know that I trust twn to be competent enough to handle a changed en key. [04:33:26] re upload your patchset? [04:33:28] So I just swapped the other one. [04:33:47] 'Kay. [04:33:54] Or not. [04:33:57] How do I do that now? [04:34:46] amend it, change something in the commit message like adding a . and then re-upload [04:35:52] (03PS4) 10Isarra: Really fix "interwiki-legend" message key. [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/156751 [04:36:31] There. That should work. [04:36:34] I hope. [04:39:20] legoktm: Can you merge it now? I'm reasonably sure it's right this time. [04:40:04] (03CR) 10Legoktm: [C: 032] Really fix "interwiki-legend" message key. [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/156751 (owner: 10Isarra) [04:40:06] (03Merged) 10jenkins-bot: Really fix "interwiki-legend" message key. [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/156751 (owner: 10Isarra) [04:40:24] heh [04:40:30] the commit message is "interwiki-legend" [04:41:19] o.O [04:44:57] (03PS4) 10Chad: WIP: Begin indexing file metadata [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/142692 [04:45:48] (03PS11) 10Isarra: Add support for enabling and displaying global interwikis [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/147755 (https://bugzilla.wikimedia.org/68241) [04:47:48] (03PS6) 10Legoktm: Add MultiConfig for fallback logic [core] - 10https://gerrit.wikimedia.org/r/153541 (https://bugzilla.wikimedia.org/69418) [04:48:59] (03CR) 10Isarra: "Right, this should be good now. Could everyone please recheck it so it can maybe be merged?" [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/147755 (https://bugzilla.wikimedia.org/68241) (owner: 10Isarra) [04:50:37] (03CR) 10Chad: "PS4 handles metadata properly (flattens lists, etc) and stores it as dynamic. Plus more file properties like width and so forth." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/142692 (owner: 10Chad) [04:51:21] (03CR) 10Legoktm: "PS6: Changes how MultiConfig::newMainInstance works per IRC convo with ^d and parent5446, unbroke the tests, and wrote more tests for ever" [core] - 10https://gerrit.wikimedia.org/r/153541 (https://bugzilla.wikimedia.org/69418) (owner: 10Legoktm) [04:55:54] (03CR) 10Isarra: "I forgot to actually move the log link out of the interwiki-intro before (just having it on its own line was good for a mockup, not so goo" [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/156190 (owner: 10Isarra) [05:18:31] (03PS11) 10Umherirrender: Sanitizer::escapeId: Decode entity before replacing spaces [core] - 10https://gerrit.wikimedia.org/r/143477 [05:56:44] (03CR) 10Springle: [C: 031] "Phase 1 SQL is done." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136280 (https://bugzilla.wikimedia.org/65915) (owner: 10Werdna) [06:32:29] (03PS5) 10Prtksxna: Translations for French [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/156499 [06:32:31] (03PS1) 10Prtksxna: Translations for string in JS [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/156756 [06:38:58] (03PS1) 10Pastakhov: fix highlighting text that starts with space (v 1.7.4) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156757 [06:41:13] (03CR) 10Pastakhov: [C: 032] fix highlighting text that starts with space (v 1.7.4) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156757 (owner: 10Pastakhov) [06:41:18] (03Merged) 10jenkins-bot: fix highlighting text that starts with space (v 1.7.4) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156757 (owner: 10Pastakhov) [06:57:16] (03CR) 10Gilles: [C: 031] Log time of first paint and first paint after onload event [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/132764 (https://bugzilla.wikimedia.org/65111) (owner: 10Gergő Tisza) [07:07:21] (03CR) 10Microchip08: "Can we use ISO 3166 codes for the country keys, instead of English language strings?" [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/156756 (owner: 10Prtksxna) [07:15:47] (03CR) 10Ori.livneh: [C: 032] "Sorry for letting these patches slip for so long." [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/132764 (https://bugzilla.wikimedia.org/65111) (owner: 10Gergő Tisza) [07:15:55] (03Merged) 10jenkins-bot: Log time of first paint and first paint after onload event [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/132764 (https://bugzilla.wikimedia.org/65111) (owner: 10Gergő Tisza) [07:20:17] (03CR) 10Gilles: [C: 04-1] Add code for logging image loading times (034 comments) [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/151262 (owner: 10Gergő Tisza) [07:26:46] (03CR) 10Gilles: [C: 032] "Now that I'm more familiar with campaigns, all the messages seem to be part of the defunct campaign editor. Since I couldn't find any refe" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/141871 (owner: 10Reedy) [07:27:19] (03Merged) 10jenkins-bot: Remove unused messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/141871 (owner: 10Reedy) [07:29:14] (03CR) 10Gilles: [C: 032] Check for error before outputting srcset urls [core] - 10https://gerrit.wikimedia.org/r/142172 (https://bugzilla.wikimedia.org/67081) (owner: 10Brian Wolff) [07:35:23] (03Merged) 10jenkins-bot: Check for error before outputting srcset urls [core] - 10https://gerrit.wikimedia.org/r/142172 (https://bugzilla.wikimedia.org/67081) (owner: 10Brian Wolff) [07:37:11] (03CR) 10Gilles: [C: 032] Making missing old files not try to render a thumbnail [core] - 10https://gerrit.wikimedia.org/r/151378 (https://bugzilla.wikimedia.org/22847) (owner: 10Brian Wolff) [07:40:07] (03PS1) 10Ori.livneh: Fix LuaSandboxFunction leak [php/luasandbox] - 10https://gerrit.wikimedia.org/r/156758 [07:41:31] (03PS2) 10Ori.livneh: Fix LuaSandboxFunction leak [php/luasandbox] - 10https://gerrit.wikimedia.org/r/156758 (https://bugzilla.wikimedia.org/70006) [07:43:29] (03Merged) 10jenkins-bot: Making missing old files not try to render a thumbnail [core] - 10https://gerrit.wikimedia.org/r/151378 (https://bugzilla.wikimedia.org/22847) (owner: 10Brian Wolff) [08:23:45] 3MediaWiki / 3Special pages: Special:ListGroupRights shows right column in RTL wikis with LTR user language in wrong direction - 10https://bugzilla.wikimedia.org/70117 (10Raimond Spekking) 3NEW p:3Unprio s:3normal a:3None Special:ListGroupRights shows right column in RTL wikis with LTR user language... [08:26:43] (03PS1) 10Gilles: Add ability to only run QUnit tests for a given extension [core] - 10https://gerrit.wikimedia.org/r/156759 [08:54:29] (03PS1) 10Nemo bis: Remove trailing whitespace, followup 0b1275b9e39b31b1f020ee90a8fb1134d0639c46 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156761 [08:54:39] (03CR) 10Thiemo Mättig (WMDE): [C: 031] Provide rudimentary __toString() for Status [core] - 10https://gerrit.wikimedia.org/r/156446 (owner: 10saper) [08:59:13] (03PS4) 10Yarda: Fix HTTPS protocol detection [core] - 10https://gerrit.wikimedia.org/r/116943 (https://bugzilla.wikimedia.org/46511) [09:06:12] (03PS2) 10Nemo bis: Remove trailing whitespace, followup 0b1275b9e39b31b1f020ee90a8fb1134d0639c46 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156761 [09:17:11] (03CR) 10Vogone: "Yes, this is true. Though, a comma-separated list with singular form membership messages and starting with a lower-case letter makes more " [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156742 (owner: 10Vogone) [09:23:17] 3MediaWiki / 3General/Unknown: ENotif/EConfirm & further enhancements (tracking) - 10https://bugzilla.wikimedia.org/1932 (10Nemo) [09:35:44] 3MediaWiki extensions / 3CirrusSearch: PHP Warning: Invalid argument - 10https://bugzilla.wikimedia.org/69459#c4 (10keyler) Thank you Chad an Nik, as always! [09:36:22] (03PS1) 10Pastakhov: add highlighting template variables (v 1.8.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156763 [09:37:54] (03PS2) 10Pastakhov: add highlighting template variables (v 1.8.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156763 [09:42:23] (03PS5) 10Nikerabbit: mediawiki.api: Support assert parameter in getToken and postWithToken [core] - 10https://gerrit.wikimedia.org/r/156093 [09:42:38] (03PS6) 10Nikerabbit: mediawiki.api: Support assert parameter in getToken and postWithToken [core] - 10https://gerrit.wikimedia.org/r/156093 [09:47:01] (03PS3) 10Pastakhov: add highlighting template variables (v 1.8.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156763 [09:47:47] (03CR) 10Pastakhov: [C: 032] add highlighting template variables (v 1.8.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156763 (owner: 10Pastakhov) [09:47:51] (03Merged) 10jenkins-bot: add highlighting template variables (v 1.8.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156763 (owner: 10Pastakhov) [10:17:13] 3MediaWiki extensions / 3Extensions requests: Allowing authors to send announcements and users to subscribe/unsubscribe - 10https://bugzilla.wikimedia.org/43840#c6 (10Derk-Jan Hartman) On this front, I think we need a bit more of a firehose, a bulletin board, a crossover between blog and forum, that has all... [10:27:10] (03CR) 10Matthias Mullie: [C: 031] "Looks good, but some more code can be removed (to generate the params for flow-topic-participants)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156728 (owner: 10SG) [10:29:20] (03PS2) 10Matthias Mullie: Remove flow-author from topic titlebar to reduce titlebar height [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156728 (owner: 10SG) [10:29:47] 3MediaWiki extensions / 3WikidataRepo: wbgetentities should default to ungrouped output - 10https://bugzilla.wikimedia.org/70081#c5 (10tobias.gritschacher) 5PATC>3RESO/INV per Daniel's comment. [10:30:02] 3MediaWiki extensions / 3WikidataRepo: the output of wbgetentities switched from name to title - 10https://bugzilla.wikimedia.org/70082#c3 (10tobias.gritschacher) 5ASSI>3RESO/INV per Daniel's comment. [10:30:30] (03CR) 10Gergő Tisza: Add code for logging image loading times (034 comments) [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/151262 (owner: 10Gergő Tisza) [10:30:44] (03CR) 10Matthias Mullie: [C: 032] "Also: seriously? After Jon & I spent hours fixing participants i18n? Anyway" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156728 (owner: 10SG) [10:31:25] (03Merged) 10jenkins-bot: Remove flow-author from topic titlebar to reduce titlebar height [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156728 (owner: 10SG) [10:35:04] (03CR) 10Siebrand: [C: 04-1] "Needs to be updated to use JSON based i18n." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97628 (https://bugzilla.wikimedia.org/57472) (owner: 10Legoktm) [10:37:17] 3MediaWiki extensions / 3Math: SVG height incorrect - 10https://bugzilla.wikimedia.org/70119 (10Derk-Jan Hartman) 3NEW p:3Unprio s:3normal a:3None Created attachment 16303 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16303&action=edit screenshot I tested the MathML SVG mode and it seems th... [10:38:23] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/156190 (owner: 10Isarra) [10:39:44] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/147755 (https://bugzilla.wikimedia.org/68241) (owner: 10Isarra) [10:43:38] (03PS3) 10Dan-nl: Add Special:Log Entries [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/156243 (https://bugzilla.wikimedia.org/68277) [10:44:31] (03CR) 10Dan-nl: "* rebased ps2" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/156243 (https://bugzilla.wikimedia.org/68277) (owner: 10Dan-nl) [10:47:59] 3MediaWiki / 3Maintenance scripts: deleteOldRevisions.php deletes content text from current revisions - 10https://bugzilla.wikimedia.org/66615#c16 (10sen) thank you!if anything i found i will let you know,so i guess them no more provide to take this as bug yet [11:00:45] 3MediaWiki extensions / 3WikidataRepo: the output of wbgetentities switched from name to title - 10https://bugzilla.wikimedia.org/70082#c4 (10Amir Ladsgroup) pywikibot does not use export, it uses wbgetentities I wrote that parts. [11:02:58] 3MediaWiki extensions / 3WikidataRepo: Create jQuery.wikibase.descriptionview - 10https://bugzilla.wikimedia.org/69471 (10tobias.gritschacher) 5PATC>3RESO/FIX [11:04:43] 3MediaWiki extensions / 3WikidataRepo: Integrate aliases into fingerprintview - 10https://bugzilla.wikimedia.org/70033#c1 (10tobias.gritschacher) 5ASSI>3PATC https://gerrit.wikimedia.org/r/#/c/156565/ [11:05:29] 3MediaWiki extensions / 3WikidataRepo: Create jQuery fingerprintlistview widget - 10https://bugzilla.wikimedia.org/69839#c1 (10tobias.gritschacher) 5ASSI>3PATC https://gerrit.wikimedia.org/r/#/c/156521/ [11:11:58] 3MediaWiki extensions / 3WikidataRepo: [DM 1.0 compat] Fix PropertyViewTest failures - 10https://bugzilla.wikimedia.org/70043#c1 (10tobias.gritschacher) 5ASSI>3PATC Should be fixed by changes in https://gerrit.wikimedia.org/r/#/c/153714/ [11:13:02] 3MediaWiki extensions / 3WikidataRepo: [DM 1.0 compat] Fix ChangeOpsMergeTest errors - 10https://bugzilla.wikimedia.org/70044#c3 (10tobias.gritschacher) 5ASSI>3PATC Should be fixed by changes in https://gerrit.wikimedia.org/r/#/c/153714/ [11:25:00] guillom, hi, this is old but I just saw it: https://www.mediawiki.org/wiki/Summary:Talk:How_to_contribute/Cascade_protection_against_ALL_edits_in_ALL_translations [11:37:39] (03PS1) 10Aude: Move actual OldChangesList line formatting to separate method [core] - 10https://gerrit.wikimedia.org/r/156771 [11:49:44] 3MediaWiki extensions / 3WikidataRepo: Create jQuery.wikibase.labelview - 10https://bugzilla.wikimedia.org/69472 (10tobias.gritschacher) 5PATC>3RESO/FIX [12:32:14] 3MediaWiki extensions / 3Math: SVG height incorrect - 10https://bugzilla.wikimedia.org/70119#c1 (10physikerwelt) Thanks for reporting this. I'm not sure if that's a problem of the Math extension of a problem of the SVG itself. Does the SVG http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:MathSh... [12:44:28] (03CR) 10Nemo bis: "Needs rebase" [core] - 10https://gerrit.wikimedia.org/r/131700 (https://bugzilla.wikimedia.org/64312) (owner: 1001tonythomas) [12:55:44] 3MediaWiki extensions / 3Math: SVG height incorrect - 10https://bugzilla.wikimedia.org/70119#c2 (10physikerwelt) I played a bit with the options. I think the hight is too small. If we'd add a few percent to the height the problem would be solved. Do you think that would be a good solution? [13:18:13] 3MediaWiki extensions / 3CirrusSearch: Stemming: CirrusSearch does not find Биология for a Биологии query on ru.wp (but LuceneSearch does) - 10https://bugzilla.wikimedia.org/69766#c9 (10Nik Everett) 5ASSI>3RESO/FIX Merged. It'll go to test wikis and mediawiki.org today, non-wikipedias on Tuesday, and wi... [13:21:23] (03PS3) 10saper: Provide rudimentary __toString() for Status [core] - 10https://gerrit.wikimedia.org/r/156446 [13:22:00] 3Mathoid / 3General/Unknown: Fine grained conversion status - 10https://bugzilla.wikimedia.org/70121 (10physikerwelt) 3NEW p:3Unprio s:3normal a:3None As of today Mathoid returns a boolean value that determines if the conversion was successful. In some cases no SVG images can be generated, but MathML... [13:22:44] 3Mathoid / 3General/Unknown: Fine grained conversion status - 10https://bugzilla.wikimedia.org/70121 (10physikerwelt) p:5Unprio>3Low s:5normal>3enhanc [13:34:36] (03Draft1) 10Aude: Add basic tests for EnhancedChangesList [core] - 10https://gerrit.wikimedia.org/r/156783 [13:35:51] (03CR) 10Nikerabbit: [C: 04-1] commafy: prevent infinite loop when pattern has no grouping (033 comments) [core] - 10https://gerrit.wikimedia.org/r/155890 (https://bugzilla.wikimedia.org/69835) (owner: 10Santhosh) [13:42:29] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: No enabled connection error - 10https://bugzilla.wikimedia.org/67605 (10Nik Everett) 5NEW>3ASSI a:3Nik Everett [13:46:29] 3MediaWiki extensions / 3Translate: Recover gracefully from session expiration - 10https://bugzilla.wikimedia.org/69314 (10Nemo) 5PATC>3ASSI [13:51:33] (03PS2) 10Aude: Add $logAction param for test recent changes helper [core] - 10https://gerrit.wikimedia.org/r/149340 [13:51:58] (03PS2) 10Aude: Add test case for recent changes flags in OldChangesList [core] - 10https://gerrit.wikimedia.org/r/149341 [13:52:08] (03PS2) 10Aude: Add @todo note in OldChangesListTest [core] - 10https://gerrit.wikimedia.org/r/149342 [13:54:28] 3Wikimedia / 3Deployment systems: Update wikitech wiki with deployment train - 10https://bugzilla.wikimedia.org/68751#c5 (10Giuseppe Lavagetto) @Andrew: since wikitech is not hosted on an appserver, how exactly did you think about the access/deployment rights/overall security issue that this would raise? Al... [14:01:47] 3MediaWiki extensions / 3Translate: In case of session expiry, ask the user to login and re-try saving of unsaved work - 10https://bugzilla.wikimedia.org/70122 (10Niklas Laxström) 3NEW p:3Unprio s:3normal a:3None Currently we show warnings to translators if we detect that the session has expired and... [14:03:00] 3MediaWiki extensions / 3Translate: In case of session expiry, ask the user to login and re-try saving of unsaved work - 10https://bugzilla.wikimedia.org/70122 (10Niklas Laxström) p:5Unprio>3Lowest s:5normal>3enhanc [14:03:00] 3MediaWiki / 3JavaScript: Provide JavaScript login widget - 10https://bugzilla.wikimedia.org/69596 (10Niklas Laxström) [14:04:13] 3MediaWiki extensions / 3Translate: Recover gracefully from session expiration - 10https://bugzilla.wikimedia.org/69314#c20 (10Niklas Laxström) 5ASSI>3RESO/FIX I have split the remaining part to bug 70122 as it has a blocker in core. [14:04:13] 3MediaWiki / 3JavaScript: Provide JavaScript login widget - 10https://bugzilla.wikimedia.org/69596 (10Niklas Laxström) [14:09:28] (03PS2) 10Amire80: Registry update [services/cxserver] - 10https://gerrit.wikimedia.org/r/156675 [14:09:57] (03CR) 10jenkins-bot: [V: 04-1] Registry update [services/cxserver] - 10https://gerrit.wikimedia.org/r/156675 (owner: 10Amire80) [14:14:00] (03PS6) 10Gergő Tisza: Add code for logging image loading times [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/151262 [14:14:17] (03CR) 10Bartosz Dziewoński: [C: 032] "I am not entirely happy with this (see my comments on PS9), but I guess I'll just have to fix these issues myself. (I think doing this is " [core] - 10https://gerrit.wikimedia.org/r/143173 (https://bugzilla.wikimedia.org/63521) (owner: 10Jack Phoenix) [14:18:43] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445#c27 (10Yann Forget) Why not do it as page correction and validation in Wikisource? It is a light process, and there is no need to learn a new tool. With... [14:22:32] (03PS2) 10Gergő Tisza: Track image loading time via onload [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/156475 [14:23:03] (03CR) 10Gergő Tisza: Add code for logging image loading times (031 comment) [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/151262 (owner: 10Gergő Tisza) [14:23:16] (03PS1) 10Matthias Mullie: Immediately load new topics when none could be displayed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156787 [14:24:30] (03Merged) 10jenkins-bot: Introduce mediawiki.skinning module for external link icons [core] - 10https://gerrit.wikimedia.org/r/143173 (https://bugzilla.wikimedia.org/63521) (owner: 10Jack Phoenix) [14:25:25] (03PS1) 10Bartosz Dziewoński: mediawiki.skinning.content.externallinks: Code quality tweaks [core] - 10https://gerrit.wikimedia.org/r/156789 [14:25:30] (03PS7) 10Gergő Tisza: Add code for logging image loading times [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/151262 [14:25:46] (03CR) 10Bartosz Dziewoński: "Follow-up: https://gerrit.wikimedia.org/r/156789" [core] - 10https://gerrit.wikimedia.org/r/143173 (https://bugzilla.wikimedia.org/63521) (owner: 10Jack Phoenix) [14:26:13] 3MediaWiki / 3JavaScript: Provide JavaScript login widget - 10https://bugzilla.wikimedia.org/69596 (10Nemo) [14:26:13] 3MediaWiki extensions / 3Translate: In case of session expiry, ask the user to login and re-try saving of unsaved work - 10https://bugzilla.wikimedia.org/70122 (10Nemo) [14:27:27] (03PS8) 10Gergő Tisza: Add code for logging image loading times [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/151262 [14:27:28] 3MediaWiki / 3Skin and page rendering: Default external link icons should be a module - 10https://bugzilla.wikimedia.org/63521#c5 (10Bartosz Dziewoński) 5PATC>3RESO/FIX Whee~ [14:31:14] (03CR) 10Isarra: [C: 031] mediawiki.skinning.content.externallinks: Code quality tweaks [core] - 10https://gerrit.wikimedia.org/r/156789 (owner: 10Bartosz Dziewoński) [14:32:16] Hi! Is anyone around with permission to run mw-grep? legoktm? ori ? [14:32:49] (03PS3) 10Gergő Tisza: Track image loading time via onload [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/156475 [14:33:55] <^d> helderwiki: What you looking for? [14:34:18] I would like to have a list of JS/CSS pages (in User and MediaWiki namespace) which import some of my scripts (e.g. containing "Helder.wiki/") [14:34:30] 3Wikimedia / 3Site requests: Advertise that site code (common.js and gadgets) are now maintained by WMF - 10https://bugzilla.wikimedia.org/70125 (10Rainer Rillke @commons.wikimedia) 3NEW p:3Unprio s:3normal a:3None Given the super protection of a MediaWiki:Common.js, that makes it unmaintainable for... [14:34:35] ^d: ^ [14:34:58] (03PS1) 10Physikerwelt: Unsupported characters [services/mathoid] - 10https://gerrit.wikimedia.org/r/156790 [14:36:16] <^d> helderwiki: https://gist.github.com/demon/1b7de0d3b1a70e702074 [14:39:58] 3Wikimedia / 3Site requests: Advertise that site code (common.js and gadgets) are now maintained by WMF - 10https://bugzilla.wikimedia.org/70125#c1 (10John F. Lewis) This is inappropriate. The Foundation are not preventing every single administrator from editing site-wide js pages. Erik has stated they are p... [14:41:43] 3Wikimedia / 3Site requests: Advertise that site code (common.js and gadgets) are now maintained by WMF - 10https://bugzilla.wikimedia.org/70125#c2 (10Bartosz Dziewoński) I think Rillke only intended to add such a note on the pages that have actually been superprotected, not all that might technically be som... [14:43:28] 3Wikimedia / 3Site requests: Advertise that site code (common.js and gadgets) are now maintained by WMF - 10https://bugzilla.wikimedia.org/70125#c3 (10John F. Lewis) In theory this is something a local community can do so bringing it to Bugzilla is you know :) [14:46:52] … [14:55:14] 3MediaWiki / 3Internationalization: BiDi: LTR and RTL mixed up (tracking) - 10https://bugzilla.wikimedia.org/28708 (10Andre Klapper) [14:55:14] 3MediaWiki / 3Special pages: Special:ListGroupRights shows right column in RTL wikis with LTR user language in wrong direction - 10https://bugzilla.wikimedia.org/70117 (10Andre Klapper) p:5Unprio>3Low [14:55:28] 3MediaWiki extensions / 3Scribunto: Attempt to concatenate a nil value when using mw.html:css - 10https://bugzilla.wikimedia.org/69481 (10Andre Klapper) p:5Unprio>3Normal [14:55:57] 3Wikimedia / 3General/Unknown: Unable to login and reset password: "Invalid hash given" in all cases - 10https://bugzilla.wikimedia.org/70098 (10Andre Klapper) 5UNCO>3NEW [14:57:13] 3Wikimedia / 3Site requests: Advertise that site code (common.js and gadgets) are now maintained by WMF - 10https://bugzilla.wikimedia.org/70125#c4 (10Rainer Rillke @commons.wikimedia) (In reply to Bartosz Dziewoński from comment #2) Thank you, yes, there should be some notification on each of such pages how... [14:58:13] 3MediaWiki extensions / 3UniversalLanguageSelector: Add 6 fonts for Arabic WebFonts - 10https://bugzilla.wikimedia.org/41551#c6 (10Andre Klapper) Kartik: You assigned this ticket to yourself a year ago. Are you still working (or still plan to work) on this issue? Only in case you do not plan to work on thi... [14:59:13] 3Wikimedia / 3Site requests: Advertise that site code (common.js and gadgets) are now maintained by WMF - 10https://bugzilla.wikimedia.org/70125#c5 (10Rainer Rillke @commons.wikimedia) (In reply to John F. Lewis from comment #3) Well, every local community would have to develop its own wording, so why not do... [15:03:43] 3Wikimedia / 3Site requests: Advertise that some site code (common.js and gadgets) are now protected & maintained by WMF - 10https://bugzilla.wikimedia.org/70125#c6 (10Chad H.) Tightening summary since this only applies to superprotected pages. The rest of CSS/JS is still very much in an individual wiki's co... [15:04:13] 3MediaWiki / 3Internationalization: Mixed use of Eastern vs Western numerals in Arabic Wikipedia (Page history; Compact Language Links) - 10https://bugzilla.wikimedia.org/70109#c1 (10Andre Klapper) p:5Unprio>3Normal Thanks for taking the time to report this! Confirming: On https://ar.wikipedia.org/w/ind... [15:04:13] 3Wikimedia / 3Language setup: Use "ar-u-nu-latn" instead "ar" for whole Arabic Wikipedia or just for its - 10https://bugzilla.wikimedia.org/62725 (10Andre Klapper) [15:04:43] 3Wikimedia / 3Site requests: Advertise that some site code (common.js and gadgets) are now protected & maintained by WMF - 10https://bugzilla.wikimedia.org/70125#c7 (10John F. Lewis) (In reply to Rainer Rillke @commons.wikimedia from comment #4) > > This is inappropriate. > Please be specific about what is i... [15:05:37] (03PS1) 10Jackmcbarn: Put move warning formatting inside the messages [core] - 10https://gerrit.wikimedia.org/r/156796 [15:06:28] 3Wikimedia / 3General/Unknown: JS bug : URI error - 10https://bugzilla.wikimedia.org/70097#c7 (10Andre Klapper) Please append "?debug=true" to the URL, or "&debug=true" if there already is a question mark "?" in the URL address. This should provide clearer information in your browser's error console about t... [15:10:13] 3MediaWiki extensions / 3Scribunto: Attempt to concatenate a nil value when using mw.html:css - 10https://bugzilla.wikimedia.org/69481#c10 (10Brad Jorsch) Thanks for tracking that down. At this point it doesn't seem to be a bug Scribunto, since U+10FFFF is a valid Unicode code point. Further questions: * Do... [15:15:47] (03PS1) 10Manybubbles: Connection error improvements [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/156798 [15:16:41] (03CR) 10Steinsplitter: [C: 031] Put move warning formatting inside the messages [core] - 10https://gerrit.wikimedia.org/r/156796 (owner: 10Jackmcbarn) [15:17:25] (03PS1) 10Isarra: I have no idea what is going on. [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/156799 [15:17:36] (03PS1) 10Manybubbles: When there is an error reindexing log it [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156800 [15:18:20] (03PS2) 10Isarra: Apparently some style tweaks. [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/156799 [15:18:31] (03CR) 10Isarra: [C: 032] Apparently some style tweaks. [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/156799 (owner: 10Isarra) [15:18:35] (03Merged) 10jenkins-bot: Apparently some style tweaks. [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/156799 (owner: 10Isarra) [15:18:43] 3Wikimedia / 3Site requests: Advertise that some site code (common.js and gadgets) are now protected & maintained by WMF - 10https://bugzilla.wikimedia.org/70125#c8 (10Jesús Martínez Novo (Ciencia Al Poder)) > Erik has stated they are proposing a code-review sytle system bug 69445 [15:20:00] (03PS1) 10Yaron Koren: Changed #get_soap_data to recursively get all values for each tag [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/156802 [15:20:02] (03PS1) 10Manybubbles: Increase timeout on updates [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156803 (https://bugzilla.wikimedia.org/67605) [15:21:14] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: No enabled connection error - 10https://bugzilla.wikimedia.org/67605#c4 (10Nik Everett) https://gerrit.wikimedia.org/r/#/c/156798/ and https://gerrit.wikimedia.org/r/#/c/156800/ as well. Its not stupid huge pages. Its massive influxes of updates all at o... [15:21:25] (03CR) 10Yaron Koren: [C: 032 V: 031] Changed #get_soap_data to recursively get all values for each tag [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/156802 (owner: 10Yaron Koren) [15:24:28] 3Wikimedia / 3Site requests: Advertise that some site code (common.js and gadgets) are now protected & maintained by WMF - 10https://bugzilla.wikimedia.org/70125#c9 (10Steinsplitter) (In reply to Jesús Martínez Novo (Ciencia Al Poder) from comment #8) > > Erik has stated they are proposing a code-review sytl... [15:24:43] 3MediaWiki / 3File management: If oi_archive_name = '' give error instead of linking to obviously invalid url - 10https://bugzilla.wikimedia.org/22847#c4 (10Bawolff (Brian Wolff)) 5PATC>3RESO/FIX Output changed for such a case. Once the above is deployed to commons, can you verify the new behaviour is wh... [15:24:44] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Make sure that failures during indexing cause the job to be retried - 10https://bugzilla.wikimedia.org/69606 (10Nik Everett) 5NEW>3ASSI a:3Nik Everett [15:25:40] (03PS1) 10Isarra: GETTING RID OF THE COLON [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/156804 [15:26:21] (03CR) 10Isarra: [C: 032] GETTING RID OF THE COLON [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/156804 (owner: 10Isarra) [15:26:27] (03Merged) 10jenkins-bot: GETTING RID OF THE COLON [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/156804 (owner: 10Isarra) [15:27:43] 3MediaWiki extensions / 3SemanticForms: wikiEditor not loading in a Semantic Form - 10https://bugzilla.wikimedia.org/70057#c3 (10Yaron Koren) Okay, that's good to know, thanks. [15:28:07] extreme approaches to cancer [15:29:43] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445#c28 (10Steinsplitter) (In reply to Yann Forget from comment #27) > Why not do it as page correction and validation in Wikisource? It is a light > process,... [15:32:56] (03CR) 10Gergő Tisza: [C: 04-1] Add ability to only run QUnit tests for a given extension (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156759 (owner: 10Gilles) [15:37:43] 3MediaWiki extensions / 3Scribunto: Attempt to concatenate a nil value when using mw.html:css - 10https://bugzilla.wikimedia.org/69481#c11 (10Jackmcbarn) Linux and Windows both say that U+D800 through U+DFFF are invalid. Linux doesn't complain about anything else, but Windows also complains about U+FDD0 thro... [15:39:58] 3MediaWiki extensions / 3Scribunto: Attempt to concatenate a nil value when using mw.html:css - 10https://bugzilla.wikimedia.org/69481#c12 (10Jackmcbarn) Windows PCRE version: 8.32 2012-11-30 Linux PCRE version: 8.31 2012-07-06 [15:41:00] (03CR) 10Matthias Mullie: [C: 031] "Functionality looks good to me." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156719 (owner: 10Jdlrobson) [15:43:21] (03CR) 10Matthias Mullie: [C: 04-1] Hygiene: Kill ifEquals helper, use ifCond instead (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156720 (owner: 10Jdlrobson) [15:44:21] (03CR) 10Matthias Mullie: [C: 032] Hygiene: Remove unnecessary indentation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156716 (owner: 10EBernhardson) [15:44:58] (03Merged) 10jenkins-bot: Hygiene: Remove unnecessary indentation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156716 (owner: 10EBernhardson) [15:48:23] (03CR) 10Matthias Mullie: [C: 031] "Code looks good." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156467 (owner: 10EBernhardson) [15:49:43] 3Wikimedia / 3Media storage: Swift outage caused a bunch of moved files to be "inconsistent" and "missing" - 10https://bugzilla.wikimedia.org/69311#c11 (10Tisza Gergő) Tracked in Mingle as https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/827 [15:52:49] (03CR) 10Matthias Mullie: [C: 04-1] Invalidate title for Workflow owner page (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156454 (https://bugzilla.wikimedia.org/69987) (owner: 10EBernhardson) [15:53:21] Reedy: When you have a moment can you review https://gerrit.wikimedia.org/r/#/c/156052/ for us? :) (apologies if someone else has already poked you to do so recently) [15:56:49] (03PS1) 10Isarra: Add toc styling, fix some selectors/paths [skins/Mask] - 10https://gerrit.wikimedia.org/r/156810 [15:58:07] (03PS4) 10Physikerwelt: Prevent Special:MathShowImage from showing bad content [extensions/Math] - 10https://gerrit.wikimedia.org/r/156195 (https://bugzilla.wikimedia.org/69693) [15:58:09] (03PS1) 10Physikerwelt: wip improve error message [extensions/Math] - 10https://gerrit.wikimedia.org/r/156811 [15:59:20] (03CR) 10Chad: [C: 032] When there is an error reindexing log it [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156800 (owner: 10Manybubbles) [15:59:36] (03Merged) 10jenkins-bot: When there is an error reindexing log it [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156800 (owner: 10Manybubbles) [16:01:50] (03PS2) 10Physikerwelt: wip improve error message [extensions/Math] - 10https://gerrit.wikimedia.org/r/156811 [16:02:35] (03PS6) 10Bartosz Dziewoński: Move mediawiki.legacy.* modules from skins/common/ to resources/ [core] - 10https://gerrit.wikimedia.org/r/153370 (https://bugzilla.wikimedia.org/69277) [16:02:57] (03CR) 10Physikerwelt: [C: 04-2] Prevent Special:MathShowImage from showing bad content [extensions/Math] - 10https://gerrit.wikimedia.org/r/156195 (https://bugzilla.wikimedia.org/69693) (owner: 10Physikerwelt) [16:03:02] (03CR) 10Bartosz Dziewoński: "Right. This way makes sense to me." [core] - 10https://gerrit.wikimedia.org/r/153370 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [16:03:24] (03CR) 10Chad: [C: 032] Increase timeout on updates [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156803 (https://bugzilla.wikimedia.org/67605) (owner: 10Manybubbles) [16:03:39] (03Merged) 10jenkins-bot: Increase timeout on updates [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156803 (https://bugzilla.wikimedia.org/67605) (owner: 10Manybubbles) [16:05:05] (03CR) 10Chad: Connection error improvements (031 comment) [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/156798 (owner: 10Manybubbles) [16:05:10] hmm, anybody around to do some mwgrepping for me? ^d? [16:05:19] "shared.css", "wikibits.js", "ajax.js" [16:05:47] <^d> Hmmmm [16:06:08] <^d> NS_USER or NS_MW or both? [16:06:34] ^d: MW is enough [16:08:42] (03CR) 10Reedy: [C: 04-1] Readd CAPTCHA (ConfirmEdit extension) support (032 comments) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/156052 (https://bugzilla.wikimedia.org/66811) (owner: 10Jack Phoenix) [16:09:17] (03CR) 10Isarra: [C: 032] Add toc styling, fix some selectors/paths [skins/Mask] - 10https://gerrit.wikimedia.org/r/156810 (owner: 10Isarra) [16:09:19] (03Merged) 10jenkins-bot: Add toc styling, fix some selectors/paths [skins/Mask] - 10https://gerrit.wikimedia.org/r/156810 (owner: 10Isarra) [16:09:20] <^d> MatmaRex: https://gist.github.com/demon/4254dbf1a29d1dd1b3ed [16:10:28] ^d: ew, this many? thanks [16:10:54] <^d> yw [16:10:57] ^d: wanna break the world? https://gerrit.wikimedia.org/r/#/c/153370/ [16:11:15] <^d> Not particularly :p [16:11:21] (03PS7) 10Bartosz Dziewoński: Move mediawiki.legacy.* modules from skins/common/ to resources/ [core] - 10https://gerrit.wikimedia.org/r/153370 (https://bugzilla.wikimedia.org/69277) [16:11:32] it's okay, i promise! [16:12:28] 3MediaWiki extensions / 3Scribunto: Attempt to concatenate a nil value when using mw.html:css - 10https://bugzilla.wikimedia.org/69481#c13 (10Brad Jorsch) 5NEW>3RESO/WON (In reply to Jackmcbarn from comment #11) > Linux and Windows both say that U+D800 through U+DFFF are invalid. That's not terribly sur... [16:12:39] <^d> I had a dream about a patch. [16:13:02] <^d> Don't remember who, but somebody was trying to tell me that the hitcounter patch was a BAD idea and we totally want to use it at WMF. [16:13:10] <^d> Obvs. not true. [16:13:14] 3MediaWiki extensions / 3UniversalLanguageSelector: [Compact links] Respect $wgTranslateNumerals - 10https://bugzilla.wikimedia.org/70109 (10Nemo) [16:13:44] 3MediaWiki extensions / 3UniversalLanguageSelector: [Compact links] Respect $wgTranslateNumerals - 10https://bugzilla.wikimedia.org/70109 (10Nemo) [16:13:44] 3MediaWiki extensions / 3UniversalLanguageSelector: Make compact interwikis (interlanguage wikilinks) default (tracking) - 10https://bugzilla.wikimedia.org/64793 (10Nemo) [16:13:47] ... [16:14:12] You see, trying to remove hitcounters from core may ruin your sleep/health; is it really worth it [16:14:31] <^d> == Reasons this patch should merge == [16:14:37] <^d> * Chad is losing sleep over it [16:15:59] (03CR) 10Anomie: [C: 032] Fix __pairs not working in LuaStandalone serialization [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/156743 (owner: 10Jackmcbarn) [16:17:57] (03Merged) 10jenkins-bot: Fix __pairs not working in LuaStandalone serialization [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/156743 (owner: 10Jackmcbarn) [16:27:24] (03CR) 10EBernhardson: [C: 032] Remove trailing whitespace, followup 0b1275b9e39b31b1f020ee90a8fb1134d0639c46 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156761 (owner: 10Nemo bis) [16:27:42] (03CR) 10Cmcmahon: [C: 04-2] "I think this should be abandoned. You should read https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/examples where it " [extensions/examples] - 10https://gerrit.wikimedia.org/r/156520 (owner: 10Mazzax6) [16:27:53] (03Merged) 10jenkins-bot: Remove trailing whitespace, followup 0b1275b9e39b31b1f020ee90a8fb1134d0639c46 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156761 (owner: 10Nemo bis) [16:29:27] (03PS1) 10Isarra: CSS tweaks [skins/Splash] - 10https://gerrit.wikimedia.org/r/156815 [16:30:28] 3MediaWiki extensions / 3WikidataRepo: [DM 1.0 compat] Fix ChangeOpsMergeTest errors - 10https://bugzilla.wikimedia.org/70044#c4 (10Jeroen De Dauw) That commit has nothing to do with this particular issue [16:30:30] jackmcbarn: What does this Module:84985 look like? [16:30:39] (03CR) 10Isarra: [C: 032] "Wait, what? That's it?" [skins/Splash] - 10https://gerrit.wikimedia.org/r/156815 (owner: 10Isarra) [16:30:41] (03Merged) 10jenkins-bot: CSS tweaks [skins/Splash] - 10https://gerrit.wikimedia.org/r/156815 (owner: 10Isarra) [16:31:40] legoktm, how did your script not delete https://cs.wikipedia.org/wiki/Wikipedista:Krenair/common.js ? [16:35:17] (03PS4) 10Jack Phoenix: Readd CAPTCHA (ConfirmEdit extension) support [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/156052 (https://bugzilla.wikimedia.org/66811) [16:38:28] 3Wikimedia / 3Site requests: Advertise that some site code (common.js and gadgets) are now protected & maintained by WMF - 10https://bugzilla.wikimedia.org/70125 (10Andre Klapper) p:5Unprio>3Normal s:5normal>3enhanc [16:38:50] (03PS2) 10Jack Phoenix: Madness? Madness?! THIS IS MEDIAWIKI! [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/156180 [16:39:42] (03CR) 10MaxSem: New role, installing Semantic MediaWiki (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/156708 (owner: 10Renoirb) [16:41:58] 3MediaWiki extensions / 3Math: SVG height incorrect - 10https://bugzilla.wikimedia.org/70119#c3 (10Frédéric Wang) Does MathJax still returns the image height in relative CSS units (ex)? I'm not sure we can be convert them reliably into px... [16:42:29] (03PS1) 10Cmcmahon: QA: class name locator changed [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156816 [16:43:08] (03CR) 10Bartosz Dziewoński: [C: 032] Madness? Madness?! THIS IS MEDIAWIKI! [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/156180 (owner: 10Jack Phoenix) [16:43:10] (03Merged) 10jenkins-bot: Madness? Madness?! THIS IS MEDIAWIKI! [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/156180 (owner: 10Jack Phoenix) [16:45:00] 3MediaWiki extensions / 3WikidataRepo: Error messages for Special:GoToLinkedPage - 10https://bugzilla.wikimedia.org/70127 (10Bene*) 3NEW p:3Unprio s:3normal a:3Wikidata bugs When visiting Special:GoToLinkedPage and the given item does not have a sitelink for the given site it just shows the form. We... [16:45:28] 3MediaWiki extensions / 3WikidataRepo: Error messages for Special:GoToLinkedPage - 10https://bugzilla.wikimedia.org/70127 (10Bene*) [16:46:22] (03PS4) 10Anomie: Handle __pairs when marshalling Lua-to-PHP [php/luasandbox] - 10https://gerrit.wikimedia.org/r/84985 [16:46:36] (03PS5) 10Anomie: Handle __pairs when marshalling Lua-to-PHP [php/luasandbox] - 10https://gerrit.wikimedia.org/r/84985 [16:48:11] (03CR) 10Anomie: "Note the use case requested is https://gerrit.wikimedia.org/r/#/c/156442/" [core] - 10https://gerrit.wikimedia.org/r/156441 (owner: 10Jackmcbarn) [16:48:28] 3Mathoid / 3General/Unknown: Fine grained conversion status - 10https://bugzilla.wikimedia.org/70121#c1 (10Frédéric Wang) (In reply to physikerwelt from comment #0) > The downside of this approach that different user groups would see different > output. I guess it can be considered a limitation in MathJax S... [16:50:17] (03CR) 10EBernhardson: [C: 031] Freeze Flow and Echo extensions for group2 wikis [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156678 (owner: 10Spage) [16:51:39] (03PS3) 10EBernhardson: Invalidate title for Workflow owner page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156454 (https://bugzilla.wikimedia.org/69987) [16:52:11] (03CR) 10EBernhardson: Invalidate title for Workflow owner page (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156454 (https://bugzilla.wikimedia.org/69987) (owner: 10EBernhardson) [16:52:15] (03CR) 10Jforrester: [C: 032] es5-shim: Add polyfill for Object.create [core] - 10https://gerrit.wikimedia.org/r/156046 (https://bugzilla.wikimedia.org/67590) (owner: 10Krinkle) [16:53:20] (03PS17) 10EBernhardson: G3: Mobile/nojs edit and reply full topic output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156203 [16:54:04] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (ea0172dd00) [core] - 10https://gerrit.wikimedia.org/r/156817 [16:55:13] 3MediaWiki / 3JavaScript: Ship Object.create polyfill for OOjs for compatibility with browser having ES3 engines - 10https://bugzilla.wikimedia.org/67590 (10James Forrester) 5PATC>3RESO/FIX [16:56:59] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/156052 (https://bugzilla.wikimedia.org/66811) (owner: 10Jack Phoenix) [16:57:57] (03Abandoned) 10Siebrand: added black to friday as a test. then I added grey to thurs. [extensions/examples] - 10https://gerrit.wikimedia.org/r/156520 (owner: 10Mazzax6) [16:58:28] 3Mathoid / 3General/Unknown: Fine grained conversion status - 10https://bugzilla.wikimedia.org/70121#c2 (10physikerwelt) One way to fix that is to use stix-web for now https://gerrit.wikimedia.org/r/#/c/156790/1/mathoid-worker.js I tested that on http://math-preview.wmflabs.org/wiki/Help:Formula and the thre... [16:58:40] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/156811 (owner: 10Physikerwelt) [16:58:59] (03Merged) 10jenkins-bot: es5-shim: Add polyfill for Object.create [core] - 10https://gerrit.wikimedia.org/r/156046 (https://bugzilla.wikimedia.org/67590) (owner: 10Krinkle) [17:00:27] (03CR) 10Anomie: [C: 04-1] "Also, add a release note." (038 comments) [core] - 10https://gerrit.wikimedia.org/r/156274 (owner: 10Petrb) [17:00:36] (03CR) 10Siebrand: [C: 04-2] "Wikis can override the default formatting id they really, really want by closing the class at the beginning and closing it at the end. Thi" [core] - 10https://gerrit.wikimedia.org/r/156796 (owner: 10Jackmcbarn) [17:00:51] (03CR) 10EBernhardson: [C: 032] Add profiling to Echo notification API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156737 (owner: 10Bsitu) [17:01:17] (03Merged) 10jenkins-bot: Add profiling to Echo notification API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156737 (owner: 10Bsitu) [17:01:45] Vishwanath S: .Navigate to C:\Program Files and rename Adobe folder to Adobeold. [17:01:50] Siebrand Mazeland: OSX does not have a C: drive. [17:01:57] And he's back to his KB... [17:02:13] 3Mathoid / 3General/Unknown: Fine grained conversion status - 10https://bugzilla.wikimedia.org/70121#c3 (10Frédéric Wang) OK, that seems a good option. However, that leads to the issue with people preferring Computer Modern style, like what is used for the PNG images... [17:02:53] <^d> siebrand: You could mount something under /Volumes/C if you're particularly wanting a C drive :p [17:04:08] (03CR) 10Krinkle: es5-shim: Add polyfill for Object.create (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156046 (https://bugzilla.wikimedia.org/67590) (owner: 10Krinkle) [17:04:55] (03CR) 10Jdlrobson: "Let's work this out in mediawiki ui first?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155612 (owner: 10SG) [17:06:43] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445#c29 (10Helder) What about creating the "Gadget developer" user group on WMF wikis, with the user rights which are currently given to sysops (edituserjs, e... [17:08:38] (03CR) 10Physikerwelt: wip improve error message (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/156811 (owner: 10Physikerwelt) [17:11:07] (03CR) 10Reedy: [C: 032] Update Wikidata branch to mw1.24-wmf19 [tools/release] - 10https://gerrit.wikimedia.org/r/156563 (owner: 10Aude) [17:11:17] (03Merged) 10jenkins-bot: Update Wikidata branch to mw1.24-wmf19 [tools/release] - 10https://gerrit.wikimedia.org/r/156563 (owner: 10Aude) [17:11:58] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445#c30 (10Quim Gil) (In reply to Helder from comment #29) > using a single common wiki would be the best - whatever wiki is choosen - mediawiki.org please.... [17:13:22] (03CR) 10CSteipp: Consolidate parts of WebStart.php and doMaintenance.php into Initialize.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156053 (owner: 10Withoutaname) [17:13:24] (03PS2) 10Jdlrobson: search.less: Use static width for the search button [skins/Vector] - 10https://gerrit.wikimedia.org/r/154365 (owner: 10Gerrit Patch Uploader) [17:14:58] (03CR) 10EBernhardson: [C: 032] "appears to work, implements same functionality as pre frontend rewrite." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156787 (owner: 10Matthias Mullie) [17:15:31] (03Merged) 10jenkins-bot: Immediately load new topics when none could be displayed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156787 (owner: 10Matthias Mullie) [17:15:36] (03CR) 10BryanDavis: [C: 04-1] New role, installing Semantic MediaWiki (033 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/156708 (owner: 10Renoirb) [17:16:54] (03PS3) 10Physikerwelt: Error reporting for Mathoid [extensions/Math] - 10https://gerrit.wikimedia.org/r/156811 [17:16:57] (03CR) 10Krinkle: [C: 04-1] "* Don't use empty()." [core] - 10https://gerrit.wikimedia.org/r/156759 (owner: 10Gilles) [17:17:52] Krenair: https://noc.wikimedia.org/~legoktm/globalcssjs/Krenair.log says cswiki: Wikipedista:Krenair/common.js was deleted. [17:18:19] (03PS5) 10Jack Phoenix: Readd CAPTCHA (ConfirmEdit extension) support [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/156052 (https://bugzilla.wikimedia.org/66811) [17:18:42] (03PS5) 10Physikerwelt: Prevent Special:MathShowImage from showing bad content [extensions/Math] - 10https://gerrit.wikimedia.org/r/156195 (https://bugzilla.wikimedia.org/69693) [17:18:53] (03CR) 10Jack Phoenix: "> The current one supports every browser in existence, but sometimes serves PNG to browsers that understand SVG (e.g. IE 8)." [core] - 10https://gerrit.wikimedia.org/r/156789 (owner: 10Bartosz Dziewoński) [17:19:43] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445#c31 (10Helder) (In reply to Quim Gil from comment #30) > mediawiki.org please. I'm happy to discuss the reasoning wherever > corresponds. Ideally both glo... [17:19:56] (03CR) 10Jdlrobson: [C: 031] "WFM." [skins/Vector] - 10https://gerrit.wikimedia.org/r/154365 (owner: 10Gerrit Patch Uploader) [17:21:30] 3Wikimedia / 3Site requests: Set $wgAutoconfirmCount to 10 for itwiki - 10https://bugzilla.wikimedia.org/70128 (10Melos) 3NEW p:3Unprio s:3normal a:3None According to https://it.wikipedia.org/w/index.php?title=Discussioni_Wikipedia:Livelli_di_accesso_degli_utenti#Aggiornare_i_requisiti_di_autoconvali... [17:23:09] (03PS2) 10Physikerwelt: Unsupported characters [services/mathoid] - 10https://gerrit.wikimedia.org/r/156790 [17:25:28] (03CR) 10Jdlrobson: [C: 032] "I forget why these were styled using id's. I think it was something to do with common.css but I can't see any visible issues." [skins/Vector] - 10https://gerrit.wikimedia.org/r/153775 (owner: 10Arlolra) [17:25:30] (03Merged) 10jenkins-bot: Use .mw-body instead of div#content [skins/Vector] - 10https://gerrit.wikimedia.org/r/153775 (owner: 10Arlolra) [17:26:01] Vaishakh: Please download the Adobe Cleaner Tool and run the same. [17:26:08] Siebrand Mazeland: The EULA is very long. Should I first consult my lawyer? [17:26:16] Vaishakh: No need. [17:26:22] (03CR) 10Frédéric Wang: Prevent Special:MathShowImage from showing bad content (032 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/156195 (https://bugzilla.wikimedia.org/69693) (owner: 10Physikerwelt) [17:26:24] Siebrand Mazeland: First sentence states "Please read this agreement carefully." [17:26:30] (03CR) 10Bartosz Dziewoński: "Agh, right, sorry. IE 9 :)" [core] - 10https://gerrit.wikimedia.org/r/156789 (owner: 10Bartosz Dziewoński) [17:26:33] Siebrand Mazeland: Do you mean that the EULA is now void because you say so? [17:26:39] (03PS2) 10Bartosz Dziewoński: mediawiki.skinning.content.externallinks: Code quality tweaks [core] - 10https://gerrit.wikimedia.org/r/156789 [17:26:42] Vaishakh: Please run the Adobe Cleaner tool. [17:26:44] Damnit... [17:26:45] :) [17:27:10] (03CR) 10Jdlrobson: [C: 04-1] "Apart from the minor issue this looks fine. Is it still a WIP?" (031 comment) [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/155593 (owner: 10Catrope) [17:27:14] (03CR) 10Thiemo Mättig (WMDE): [C: 031] Provide rudimentary __toString() for Status [core] - 10https://gerrit.wikimedia.org/r/156446 (owner: 10saper) [17:27:16] (03CR) 10Jdlrobson: "recheck" [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/155593 (owner: 10Catrope) [17:27:32] (03PS3) 10Krinkle: mediawiki.language: Fix infinite loop in commafy() when pattern has no grouping [core] - 10https://gerrit.wikimedia.org/r/155890 (https://bugzilla.wikimedia.org/69835) (owner: 10Santhosh) [17:27:49] (03CR) 10Krinkle: "(updated commit message, commafy() is not a component)." [core] - 10https://gerrit.wikimedia.org/r/155890 (https://bugzilla.wikimedia.org/69835) (owner: 10Santhosh) [17:28:24] (03CR) 10Jdlrobson: [WIP] Replace Mantle's EventEmitter with oojs's (031 comment) [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/155593 (owner: 10Catrope) [17:28:27] (03CR) 10Jack Phoenix: [C: 031] mediawiki.skinning.content.externallinks: Code quality tweaks [core] - 10https://gerrit.wikimedia.org/r/156789 (owner: 10Bartosz Dziewoński) [17:28:44] (03CR) 10Manybubbles: [C: 031] "Looks good to me. Can +2 if you feel it doesn't need more eyes." [core] - 10https://gerrit.wikimedia.org/r/156725 (owner: 10Chad) [17:29:15] (03CR) 10Chad: "I don't think so :)" [core] - 10https://gerrit.wikimedia.org/r/156725 (owner: 10Chad) [17:29:38] (03CR) 10Frédéric Wang: "This looks ok to me. However I don't what is worse: having a few errors or having a style different from the Computer Modern fonts used fo" [services/mathoid] - 10https://gerrit.wikimedia.org/r/156790 (owner: 10Physikerwelt) [17:29:56] (03CR) 10Manybubbles: [C: 032] Remove SpecialSearchNoResults and call SpecialSearchResults always [core] - 10https://gerrit.wikimedia.org/r/156725 (owner: 10Chad) [17:32:13] (03CR) 10Matthias Mullie: [C: 032] Invalidate title for Workflow owner page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156454 (https://bugzilla.wikimedia.org/69987) (owner: 10EBernhardson) [17:32:50] (03Merged) 10jenkins-bot: Invalidate title for Workflow owner page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156454 (https://bugzilla.wikimedia.org/69987) (owner: 10EBernhardson) [17:33:47] (03CR) 10Arlolra: "https://gerrit.wikimedia.org/r/#/c/153775/ was merged." [core] - 10https://gerrit.wikimedia.org/r/151395 (https://bugzilla.wikimedia.org/38726) (owner: 10Arlolra) [17:34:06] (03PS6) 10Physikerwelt: Prevent Special:MathShowImage from showing bad content [extensions/Math] - 10https://gerrit.wikimedia.org/r/156195 (https://bugzilla.wikimedia.org/69693) [17:35:01] legoktm, soo... what happened? [17:36:10] (03Merged) 10jenkins-bot: Remove SpecialSearchNoResults and call SpecialSearchResults always [core] - 10https://gerrit.wikimedia.org/r/156725 (owner: 10Chad) [17:37:30] Hi @all, I try to open a Git space for updates of extension:Tooltip. I have to choose between "Merge review" and "Open push". I think MR is better, and i want my ("final") code reviewed, but reading the instructions to prepare the code for MR model, i got the impression that it's very difficult. And maybe i need more time to prepare the review, than to fix the extension... Did i get something wring here, or should i use "Open push" [17:37:45] Is code review only possible with MR model? [17:39:58] (03PS2) 10Jforrester: Update OOjs UI to v0.1.0-pre (d72addbeae) [core] - 10https://gerrit.wikimedia.org/r/156817 [17:40:38] <^d> baxi: You only get code review on gerrit if you push to gerrit for review (merge push, bad name :)). [17:40:42] <^d> Open pushes skips review. [17:40:47] (03CR) 10Frédéric Wang: Error reporting for Mathoid (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/156811 (owner: 10Physikerwelt) [17:44:05] ok, using gerrit seems to me too difficult now. never worked with it... [17:46:09] (03CR) 10Physikerwelt: Prevent Special:MathShowImage from showing bad content (032 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/156195 (https://bugzilla.wikimedia.org/69693) (owner: 10Physikerwelt) [17:46:30] 3Wikimedia / 3Bugzilla: MediaWiki UI component on bugzilla - 10https://bugzilla.wikimedia.org/70129 (10Jon) 3NEW p:3Unprio s:3normal a:3None Is it possible to get a MediaWiki UI component. MediaWiki / MediaWiki UI Description: Report errors with css components that identify themselves as MediaWiki U... [17:46:58] 3MediaWiki extensions / 3Math: SVG height incorrect - 10https://bugzilla.wikimedia.org/70119#c4 (10Peter Krautzberger) I don't think the problem is in the height (increasing it will only scale the image) but other CSS effects, leading to clipping. From a quick try, stripping the style from the SVG seems to f... [17:48:07] (03CR) 10Physikerwelt: Error reporting for Mathoid (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/156811 (owner: 10Physikerwelt) [17:48:15] 3Wikimedia / 3Bugzilla: MediaWiki UI component on bugzilla - 10https://bugzilla.wikimedia.org/70129#c1 (10Jon) Probably Matt Flaschen as well.. [17:48:27] (03CR) 10Parent5446: Provide rudimentary __toString() for Status (032 comments) [core] - 10https://gerrit.wikimedia.org/r/156446 (owner: 10saper) [17:51:29] (03PS1) 10Bartosz Dziewoński: Remove some references to skins/common/ in comments [core] - 10https://gerrit.wikimedia.org/r/156824 [17:51:31] (03PS1) 10Bartosz Dziewoński: mediawiki.action.view.metadata: Include the CSS we need, don't rely on shared.css [core] - 10https://gerrit.wikimedia.org/r/156825 [17:51:48] (03Abandoned) 10Krinkle: LQT should not accept duplicate post [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/123836 (https://bugzilla.wikimedia.org/29786) (owner: 10Adi.iiita) [17:52:02] (03Abandoned) 10Jdlrobson: WIP: Introduce mw-ui-icon for icons that hide the text label [core] - 10https://gerrit.wikimedia.org/r/145140 (owner: 10Jdlrobson) [17:52:43] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/151262 (owner: 10Gergő Tisza) [17:53:22] (03CR) 10Krinkle: "Status?" [core] - 10https://gerrit.wikimedia.org/r/78500 (https://bugzilla.wikimedia.org/52697) (owner: 10TheDJ) [17:55:24] (03PS3) 10Ori.livneh: Fix LuaSandboxFunction leak [php/luasandbox] - 10https://gerrit.wikimedia.org/r/156758 (https://bugzilla.wikimedia.org/70006) [17:56:29] 3Wikimedia / 3Bugzilla: MediaWiki UI component on bugzilla - 10https://bugzilla.wikimedia.org/70129#c2 (10Tyler Romeo) 5NEW>3RESO/FIX a:3Tyler Romeo Done. [17:56:30] ori: im trying to install mw-vagrant on a new mac running os x 10.9.4 but i'm getting an error: http://pastebin.com/zhwzXKdh [17:56:43] 3Wikimedia / 3Bugzilla: MediaWiki UI component on bugzilla - 10https://bugzilla.wikimedia.org/70129#c3 (10Bartosz Dziewoński) +1, the "Skin and page rendering" component is getting bloated with mediawiki.ui things. Bugs that will need re-triaging later: https://bugzilla.wikimedia.org/buglist.cgi?quicksearch... [17:56:45] (03CR) 10Siebrand: Error reporting for Mathoid (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/156811 (owner: 10Physikerwelt) [17:56:52] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Math] - 10https://gerrit.wikimedia.org/r/156811 (owner: 10Physikerwelt) [17:57:06] ori i'm going to try and install the gem manually [17:57:07] awjr: gah the stupid nokogiri bug [17:57:14] bd808: ahha you've seen this before? [17:57:30] yeah. let me find some stuff in bugzilla [17:57:33] bd808: should i just install that gem manaully? [17:57:33] k [17:57:44] awjr: i'm really out of the loop as far as recent changes to vagrant [17:57:48] kk [17:57:54] no problem ori bd808's helping me out [17:58:13] (03PS7) 10Physikerwelt: Prevent Special:MathShowImage from showing bad content [extensions/Math] - 10https://gerrit.wikimedia.org/r/156195 (https://bugzilla.wikimedia.org/69693) [17:58:15] awjr: https://bugzilla.wikimedia.org/show_bug.cgi?id=69052 may provide some help [17:58:48] The TL:DR is that there is a crappy version of nokogiri and sometimes Vagrant tires to install it [17:58:57] *tries [17:59:13] 3MediaWiki / 3MediaWiki UI: Add mediawiki.ui dialogs - 10https://bugzilla.wikimedia.org/55534 (10Tyler Romeo) [17:59:28] 3MediaWiki / 3MediaWiki UI: Agora .mw-ui-input focus indicator uses a different blue from colorProgressive - 10https://bugzilla.wikimedia.org/69040 (10Tyler Romeo) [17:59:28] 3MediaWiki / 3MediaWiki UI: Agora .mw-ui-button doesn't override anchor :visited and :active text colors - 10https://bugzilla.wikimedia.org/48184 (10Tyler Romeo) [17:59:28] 3MediaWiki / 3MediaWiki UI: Mediawiki UI shouldn't change font-family for textareas - 10https://bugzilla.wikimedia.org/70028 (10Tyler Romeo) [17:59:29] 3MediaWiki / 3MediaWiki UI: [MediaWiki UI] Set mw.ui.button to use non-system font-family - 10https://bugzilla.wikimedia.org/70072 (10Tyler Romeo) [17:59:29] 3MediaWiki / 3MediaWiki UI: Have mediawiki.ui buttons show focus in a clear and accessible way - 10https://bugzilla.wikimedia.org/62924 (10Tyler Romeo) [17:59:30] 3MediaWiki / 3MediaWiki UI: Implement checkbox spec in mediawiki.ui - 10https://bugzilla.wikimedia.org/69200 (10Tyler Romeo) [17:59:30] (03Abandoned) 10Jdlrobson: MediaWiki UI: Style all select tags when $wgUseMediaWikiUIEverywhere [core] - 10https://gerrit.wikimedia.org/r/152195 (owner: 10Jdlrobson) [17:59:43] 3MediaWiki / 3MediaWiki UI: Document tipsy - 10https://bugzilla.wikimedia.org/68745 (10Bartosz Dziewoński) [17:59:43] 3MediaWiki / 3MediaWiki UI: Add icon support for mediawiki.ui buttons - 10https://bugzilla.wikimedia.org/55535 (10Tyler Romeo) [17:59:43] 3MediaWiki / 3MediaWiki UI: mediawiki.ui forms and buttons using system fonts (rather than Vector's font-family settings) - 10https://bugzilla.wikimedia.org/63887 (10Tyler Romeo) [17:59:43] 3MediaWiki / 3MediaWiki UI: Document menu - 10https://bugzilla.wikimedia.org/68748 (10Bartosz Dziewoński) [17:59:44] 3MediaWiki / 3MediaWiki UI: Remove button styling from mediawiki.ui - 10https://bugzilla.wikimedia.org/60322 (10Tyler Romeo) [17:59:58] 3MediaWiki / 3MediaWiki UI: MediaWiki UI: VForm only partially documented - 10https://bugzilla.wikimedia.org/69449 (10Tyler Romeo) [17:59:58] 3MediaWiki / 3MediaWiki UI: implement light inline button style in mediawiki.ui - 10https://bugzilla.wikimedia.org/62744 (10Tyler Romeo) [17:59:58] 3MediaWiki / 3MediaWiki UI: Use mediawiki.ui Constructive style button for [Save] in preferences - 10https://bugzilla.wikimedia.org/65317 (10Tyler Romeo) [17:59:58] 3MediaWiki / 3MediaWiki UI: Document in style guide how to use mw-ui-button on wiki - 10https://bugzilla.wikimedia.org/61886 (10Tyler Romeo) [17:59:59] 3MediaWiki / 3MediaWiki UI: overriding full-width input fields in Agora mw-ui-vform - 10https://bugzilla.wikimedia.org/47520 (10Tyler Romeo) [18:00:00] 3MediaWiki / 3MediaWiki UI: Document reply fields - 10https://bugzilla.wikimedia.org/68741 (10Bartosz Dziewoński) [18:00:01] 3MediaWiki / 3MediaWiki UI: implement new Agora spec in mediawiki.ui (tracking) - 10https://bugzilla.wikimedia.org/54360 (10Tyler Romeo) [18:00:02] 3MediaWiki / 3MediaWiki UI: mw-ui-button doesn't show Agora focus indicator - 10https://bugzilla.wikimedia.org/47901 (10Tyler Romeo) [18:00:03] awjr: It's a stupid thing anyway because the nokogiri gem is only used by the windows provider but installing a new plugin updates all of the existing ones for some dumb reason. [18:00:03] 3MediaWiki / 3MediaWiki UI: neutral mw-ui-quiet anchors should lighten on hover and have no outline - 10https://bugzilla.wikimedia.org/69212 (10Tyler Romeo) [18:00:18] 3MediaWiki / 3MediaWiki UI: Deprecate jquery.ui formally and transition everything to a single replacement (mediawiki.ui or whatever) - 10https://bugzilla.wikimedia.org/47145 (10Tyler Romeo) [18:01:01] (03CR) 10Frédéric Wang: [C: 032] Error reporting for Mathoid [extensions/Math] - 10https://gerrit.wikimedia.org/r/156811 (owner: 10Physikerwelt) [18:01:04] bd808: >_< i tried with sudo per the bug, same problem. [18:01:35] (03PS12) 10Petrb: API: created a new api to flag messages as read [core] - 10https://gerrit.wikimedia.org/r/156274 [18:01:37] grr. The day it happened to me I just kept trying and it eventually worked :( [18:02:07] awjr: https://bugzilla.wikimedia.org/show_bug.cgi?id=68453#c2 [18:02:14] (03CR) 10Petrb: "What release note and where" [core] - 10https://gerrit.wikimedia.org/r/156274 (owner: 10Petrb) [18:03:28] 3MediaWiki / 3MediaWiki UI: mw-ui-vform's label styling makes the login form hard to read on dark skins - 10https://bugzilla.wikimedia.org/64734 (10Bartosz Dziewoński) [18:03:57] (03CR) 10Frédéric Wang: [C: 032] Prevent Special:MathShowImage from showing bad content [extensions/Math] - 10https://gerrit.wikimedia.org/r/156195 (https://bugzilla.wikimedia.org/69693) (owner: 10Physikerwelt) [18:03:58] (03CR) 10Krinkle: "That now exists." [core] - 10https://gerrit.wikimedia.org/r/131766 (https://bugzilla.wikimedia.org/64969) (owner: 10Gerrit Patch Uploader) [18:04:34] lol bd808 [18:04:58] 3MediaWiki extensions / 3RefreshSpecial: $wgQueryPages has been removed from core - 10https://bugzilla.wikimedia.org/62786#c1 (10Lewis Cawte) 5NEW>3RESO/FIX Fixed in: 226bbb3fc292f488a27a88508516b541344cec0b [18:05:01] (03CR) 10Mwjames: New role, installing Semantic MediaWiki (032 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/156708 (owner: 10Renoirb) [18:07:16] (03PS1) 10CSteipp: Load password information when expiring [core] - 10https://gerrit.wikimedia.org/r/156827 [18:07:18] (03PS2) 10Reedy: Freeze Flow and Echo extensions for group2 wikis [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156678 (owner: 10Spage) [18:07:24] (03CR) 10Reedy: [C: 032 V: 032] Freeze Flow and Echo extensions for group2 wikis [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156678 (owner: 10Spage) [18:08:51] (03CR) 10Ori.livneh: "LuaSandbox passes luasandboxfunction_destroy as the second parameter to zend_objects_store_put:" [php/luasandbox] - 10https://gerrit.wikimedia.org/r/156758 (https://bugzilla.wikimedia.org/70006) (owner: 10Ori.livneh) [18:10:51] (03PS1) 10Jdlrobson: Fix font of mw-ui-button [core] - 10https://gerrit.wikimedia.org/r/156829 (https://bugzilla.wikimedia.org/70072) [18:12:39] (03CR) 10Bartosz Dziewoński: [C: 032] Fix font of mw-ui-button [core] - 10https://gerrit.wikimedia.org/r/156829 (https://bugzilla.wikimedia.org/70072) (owner: 10Jdlrobson) [18:15:05] (03CR) 10Krinkle: "Bump" [core] - 10https://gerrit.wikimedia.org/r/133042 (https://bugzilla.wikimedia.org/64732) (owner: 10Daniel Friesen) [18:16:40] (03CR) 10Bartosz Dziewoński: "In the RELEASE-NOTES-1.24 file in root directory." [core] - 10https://gerrit.wikimedia.org/r/156274 (owner: 10Petrb) [18:17:13] 3MediaWiki / 3MediaWiki UI: Document reply fields - 10https://bugzilla.wikimedia.org/68741#c1 (10Jon) 5NEW>3RESO/INV I'm not sure what's left to do on this. We have mw-ui-input now. Please file a new bug with details of the new component / new modifier and when it should be used if there is a use case cu... [18:17:22] (03CR) 10Bartosz Dziewoński: "Just edit the file and add a mention of this in the "API changes" section, in the same format as existing entries." [core] - 10https://gerrit.wikimedia.org/r/156274 (owner: 10Petrb) [18:17:52] (03PS1) 10Lewis Cawte: Version 1.4.0 [extensions/RefreshSpecial] - 10https://gerrit.wikimedia.org/r/156830 [18:18:13] 3MediaWiki / 3MediaWiki UI: Remove button styling from mediawiki.ui - 10https://bugzilla.wikimedia.org/60322#c1 (10Jon) 5NEW>3UNCO I think this has slipped through the cracks... this is fixed no? If not can you be clearer? [18:19:09] (03Merged) 10jenkins-bot: Fix font of mw-ui-button [core] - 10https://gerrit.wikimedia.org/r/156829 (https://bugzilla.wikimedia.org/70072) (owner: 10Jdlrobson) [18:19:43] 3MediaWiki / 3MediaWiki UI: Use mediawiki.ui Constructive style button for [Save] in preferences - 10https://bugzilla.wikimedia.org/65317#c6 (10Jon) The button is now green with $wgEnableMediaWikiUIEverywhere You can see this in action on: http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Preferences [18:20:59] 3MediaWiki / 3MediaWiki UI: [MediaWiki UI] Set mw.ui.button to use non-system font-family - 10https://bugzilla.wikimedia.org/70072 (10Bartosz Dziewoński) 5PATC>3RESO/FIX s:5normal>3minor a:3Jon [18:21:29] (03CR) 10Physikerwelt: [C: 04-1] "Needs more testing." [services/mathoid] - 10https://gerrit.wikimedia.org/r/156790 (owner: 10Physikerwelt) [18:25:47] * Lcawte gives Gerrit some red bull [18:25:55] (03PS4) 10Lewis Cawte: Use new external links skinning module. [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/156700 [18:26:57] (03CR) 10Lewis Cawte: "@legoktm - done in patchset 4." [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/156700 (owner: 10Lewis Cawte) [18:27:35] (03CR) 10BryanDavis: New role, installing Semantic MediaWiki (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/156708 (owner: 10Renoirb) [18:37:08] (03CR) 10Physikerwelt: "We also probably want to make the font configurable." [services/mathoid] - 10https://gerrit.wikimedia.org/r/156790 (owner: 10Physikerwelt) [18:38:00] 3MediaWiki / 3MediaWiki UI: Remove button styling from mediawiki.ui - 10https://bugzilla.wikimedia.org/60322#c2 (10Bartosz Dziewoński) 5UNCO>3RESO/FIX a:3Matthew Flaschen Seems to have been done by Matt in I5bd23434961497d49293956c92b46ab3a6f14a41. [18:39:25] (03PS1) 10Chad: TitleTest: fix minor todo about test naming [core] - 10https://gerrit.wikimedia.org/r/156836 [18:42:25] <^d> Easy patch if someone's bored ^ [18:44:31] (03CR) 10Legoktm: API: created a new api to flag messages as read (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156274 (owner: 10Petrb) [18:44:59] (03CR) 10Chad: Maintenance: Add an easy way to access Config instances (031 comment) [core] - 10https://gerrit.wikimedia.org/r/152823 (owner: 10Legoktm) [18:46:08] (03CR) 10Bartosz Dziewoński: [C: 032] TitleTest: fix minor todo about test naming [core] - 10https://gerrit.wikimedia.org/r/156836 (owner: 10Chad) [18:46:52] (03PS14) 10Krinkle: Implement autocompletion for Performer field on Special:Log [core] - 10https://gerrit.wikimedia.org/r/110820 (https://bugzilla.wikimedia.org/48241) (owner: 10Alex Monk) [18:47:27] (03CR) 10Krinkle: [C: 031] "Rebased. Looks good?" [core] - 10https://gerrit.wikimedia.org/r/110820 (https://bugzilla.wikimedia.org/48241) (owner: 10Alex Monk) [18:48:02] 3Wikimedia / 3Deployment systems: [scap] Syncing a dblist referencing a nonexistent DB should be prevented - 10https://bugzilla.wikimedia.org/70132 (10Bryan Davis) 3NEW p:3Unprio s:3enhanc a:3None Imported from RT #550: sync-dblist and other scripts that synchronize dblists (I think scap does this,... [18:48:04] (03PS1) 10Manybubbles: Make sure that update errors are retried [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156837 (https://bugzilla.wikimedia.org/69606) [18:50:14] 3Wikimedia / 3Site requests: Set $wgAutoconfirmCount to 10 for itwiki - 10https://bugzilla.wikimedia.org/70128 (10Andre Klapper) p:5Unprio>3Normal s:5normal>3enhanc [18:50:14] 3Wikimedia / 3Deployment systems: [scap] Syncing a dblist referencing a nonexistent DB should be prevented - 10https://bugzilla.wikimedia.org/70132 (10Bryan Davis) p:5Unprio>3Normal [18:50:42] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/RefreshSpecial] - 10https://gerrit.wikimedia.org/r/156830 (owner: 10Lewis Cawte) [18:50:59] (03PS1) 10Jdlrobson: Update preferences form buttons [core] - 10https://gerrit.wikimedia.org/r/156838 (https://bugzilla.wikimedia.org/65317) [18:51:24] (03PS3) 10Physikerwelt: Make font configurable [services/mathoid] - 10https://gerrit.wikimedia.org/r/156790 [18:51:28] (03CR) 10jenkins-bot: [V: 04-1] Update preferences form buttons [core] - 10https://gerrit.wikimedia.org/r/156838 (https://bugzilla.wikimedia.org/65317) (owner: 10Jdlrobson) [18:52:13] 3Wikimedia / 3Deployment systems: [scap] Syncing a dblist referencing a nonexistent DB should be prevented - 10https://bugzilla.wikimedia.org/70132#c1 (10Bryan Davis) 1) How do we verify that a db exists? Attempt to connect to it via a maintenance script or other means? 2) Do all dblist files need to be chec... [18:52:34] (03Merged) 10jenkins-bot: TitleTest: fix minor todo about test naming [core] - 10https://gerrit.wikimedia.org/r/156836 (owner: 10Chad) [18:52:55] (03PS2) 10Manybubbles: Connection error improvements [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/156798 [18:53:13] (03PS13) 10Petrb: API: created a new api to flag messages as read [core] - 10https://gerrit.wikimedia.org/r/156274 [18:53:26] (03PS1) 10Jdlrobson: Use correct progressive color on inputs [core] - 10https://gerrit.wikimedia.org/r/156839 (https://bugzilla.wikimedia.org/69040) [18:53:53] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/156052 (https://bugzilla.wikimedia.org/66811) (owner: 10Jack Phoenix) [18:54:13] (03CR) 10jenkins-bot: [V: 04-1] Use correct progressive color on inputs [core] - 10https://gerrit.wikimedia.org/r/156839 (https://bugzilla.wikimedia.org/69040) (owner: 10Jdlrobson) [18:54:51] (03CR) 10Reedy: Readd CAPTCHA (ConfirmEdit extension) support (031 comment) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/156052 (https://bugzilla.wikimedia.org/66811) (owner: 10Jack Phoenix) [18:56:02] (03PS14) 10Petrb: API: created a new api to flag messages as read [core] - 10https://gerrit.wikimedia.org/r/156274 [18:56:11] Reedy: According to a discussion I had with siebrand the other day, we're moving to tabs but en.json has to be touched manually and is currently done when someone remembers/feels like it. [18:56:28] (03CR) 10Siebrand: Readd CAPTCHA (ConfirmEdit extension) support (031 comment) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/156052 (https://bugzilla.wikimedia.org/66811) (owner: 10Jack Phoenix) [18:56:31] (03CR) 10jenkins-bot: [V: 04-1] API: created a new api to flag messages as read [core] - 10https://gerrit.wikimedia.org/r/156274 (owner: 10Petrb) [18:56:43] 3MediaWiki / 3MediaWiki UI: Document in style guide how to use mw-ui-button on wiki using mw-ui-button span inside an anchor - 10https://bugzilla.wikimedia.org/61886#c5 (10Jon) So.. what is the bug here? Can some [18:57:14] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/156838 (https://bugzilla.wikimedia.org/65317) (owner: 10Jdlrobson) [18:57:28] 3MediaWiki / 3MediaWiki UI: mw-ui-button doesn't show Agora focus indicator - 10https://bugzilla.wikimedia.org/47901#c1 (10Jon) 5NEW>3RESO/INV I don't think this is valid anymore. Please reopen with further information if I am wrong. [18:58:58] 3MediaWiki / 3MediaWiki UI: Agora .mw-ui-button doesn't override anchor :visited and :active text colors - 10https://bugzilla.wikimedia.org/48184 (10Jon) 5NEW>3RESO/WOR [18:59:14] (03CR) 10Siebrand: "i18n/L10n reviewed." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/156243 (https://bugzilla.wikimedia.org/68277) (owner: 10Dan-nl) [18:59:43] 3MediaWiki / 3MediaWiki UI: overriding full-width input fields in Agora mw-ui-vform - 10https://bugzilla.wikimedia.org/47520#c3 (10Jon) 5NEW>3UNCO I'm not sure I understand this bug in the current context. Can you please update with a 2014 version of this bug report? [19:00:14] (03CR) 10Siebrand: "Thanks, Matmarex." [core] - 10https://gerrit.wikimedia.org/r/155910 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [19:00:49] (03CR) 10Manybubbles: Connection error improvements (031 comment) [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/156798 (owner: 10Manybubbles) [19:01:28] 3MediaWiki / 3MediaWiki UI: Create a dark skin variant of MediaWiki UI - 10https://bugzilla.wikimedia.org/64734 (10Jon) s:5normal>3enhanc [19:03:43] 3MediaWiki / 3MediaWiki UI: mediawiki.ui forms and buttons using system fonts (rather than Vector's font-family settings) - 10https://bugzilla.wikimedia.org/63887#c3 (10Jon) 5NEW>3RESO/FIX https://gerrit.wikimedia.org/r/156829 fixes this for buttons. Please open more specific bugs for any other components. [19:05:00] (03PS7) 10Jdlrobson: Tweak checkbox sizes to be relative depending on where used. [core] - 10https://gerrit.wikimedia.org/r/154125 (https://bugzilla.wikimedia.org/70133) [19:05:00] 3MediaWiki / 3MediaWiki UI: Checkboxes are huge - 10https://bugzilla.wikimedia.org/70133 (10Jon) 3NEW p:3Unprio s:3normal a:3None When you have a form e.g. Special:Preferences with wgUseMediaWikiUIEverywhere, it is obvious that checkboxes are squashed together and too big when there are many of them... [19:05:47] ori: The patch itself could also benefit a clarification on the regex pattern thing [19:07:16] (03PS5) 10Jdlrobson: Fix styling of deletion page [core] - 10https://gerrit.wikimedia.org/r/154121 [19:09:31] (03PS6) 10Jdlrobson: Fix styling of deletion page [core] - 10https://gerrit.wikimedia.org/r/154121 (https://bugzilla.wikimedia.org/70135) [19:10:15] 3MediaWiki / 3MediaWiki UI: Delete form uses green button and small input box - 10https://bugzilla.wikimedia.org/70135 (10Jon) 3NEW p:3Unprio s:3normal a:3None Delete button on the page http://localhost:8080/wiki/Headings?action=delete is green. Expected: It should be red. Also the input field is t... [19:10:15] 3MediaWiki / 3MediaWiki UI: Deletion page has mw-ui-constructive button, Other/additional reason input is tiny - 10https://bugzilla.wikimedia.org/70134 (10Jon) 3NEW p:3Unprio s:3normal a:3None Delete button on the page http://localhost:8080/wiki/Headings?action=delete is green. Expected: It should b... [19:10:54] (03PS4) 10Physikerwelt: Make font configurable [services/mathoid] - 10https://gerrit.wikimedia.org/r/156790 [19:11:48] (03PS7) 10Jdlrobson: Fix styling of deletion page [core] - 10https://gerrit.wikimedia.org/r/154121 [19:12:35] (03CR) 10Jack Phoenix: [C: 032 V: 032] Version 1.4.0 [extensions/RefreshSpecial] - 10https://gerrit.wikimedia.org/r/156830 (owner: 10Lewis Cawte) [19:18:38] (03PS15) 10Petrb: API: created a new api to flag messages as read [core] - 10https://gerrit.wikimedia.org/r/156274 [19:20:29] (03PS2) 10Physikerwelt: Mathoid role [vagrant] - 10https://gerrit.wikimedia.org/r/156137 [19:23:14] anomie: Module:84985 is https://dpaste.de/icWU [19:23:29] do you see the same weird backtrace that i do? [19:24:01] (03PS5) 10Physikerwelt: Make font configurable [services/mathoid] - 10https://gerrit.wikimedia.org/r/156790 [19:24:37] (03Abandoned) 10Jackmcbarn: Put move warning formatting inside the messages [core] - 10https://gerrit.wikimedia.org/r/156796 (owner: 10Jackmcbarn) [19:25:08] (03CR) 10Chad: Make sure that update errors are retried (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156837 (https://bugzilla.wikimedia.org/69606) (owner: 10Manybubbles) [19:25:30] anomie: also, regarding the unicode bug, couldn't we band-aid it by backporting https://gerrit.wikimedia.org/r/#/c/145414/ ? [19:25:56] jackmcbarn: For that specific instance, yes [19:26:09] should we do that? [19:26:12] (03CR) 10Chad: [C: 032] Connection error improvements [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/156798 (owner: 10Manybubbles) [19:26:18] (03Merged) 10jenkins-bot: Connection error improvements [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/156798 (owner: 10Manybubbles) [19:26:38] (03PS8) 10Krinkle: Fix styling of deletion page [core] - 10https://gerrit.wikimedia.org/r/154121 (owner: 10Jdlrobson) [19:27:49] (03PS2) 10Manybubbles: Make sure that update errors are retried [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156837 (https://bugzilla.wikimedia.org/69606) [19:27:57] (03CR) 10Manybubbles: Make sure that update errors are retried (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156837 (https://bugzilla.wikimedia.org/69606) (owner: 10Manybubbles) [19:28:01] (03PS1) 10Yuvipanda: Strip the 'operations' prefix as well from messages [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/156877 [19:28:04] (03PS1) 10Yuvipanda: Rename jenkins-bot if it does a -1 [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/156878 [19:28:39] legoktm: ^ merrge? :) [19:29:03] (03CR) 10Krinkle: [C: 031] Strip the 'operations' prefix as well from messages [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/156877 (owner: 10Yuvipanda) [19:29:20] (03CR) 10Krinkle: "Why?" [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/156878 (owner: 10Yuvipanda) [19:29:31] (03CR) 10Jackmcbarn: [C: 04-1] "I'm not a fan of this idea." [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/156878 (owner: 10Yuvipanda) [19:29:45] (03CR) 10Yuvipanda: [C: 032] Strip the 'operations' prefix as well from messages [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/156877 (owner: 10Yuvipanda) [19:29:48] (03Merged) 10jenkins-bot: Strip the 'operations' prefix as well from messages [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/156877 (owner: 10Yuvipanda) [19:30:11] (03CR) 10Andrew Bogott: [C: 031] Rename jenkins-bot if it does a -1 [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/156878 (owner: 10Yuvipanda) [19:31:19] (03PS1) 10Krinkle: preprocess: Clean up arbitrary quoting of object key 'message' [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/156880 [19:32:03] Krinkle: I quoted it because there's a param in scope also called 'message'. I know it's not required, but it makes me feel safer :P [19:34:08] (03CR) 10Yuvipanda: [C: 031] "This is grrrit-wm, and that's why :)" [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/156878 (owner: 10Yuvipanda) [19:35:15] (03Abandoned) 10Krinkle: Initialize mw.config directly instead by module startup [core] - 10https://gerrit.wikimedia.org/r/132006 (owner: 10Gerrit Patch Uploader) [19:38:14] (03CR) 10Krinkle: Make mw.Uri support URIs with no explicit path component (031 comment) [core] - 10https://gerrit.wikimedia.org/r/139584 (owner: 10Yuvipanda) [19:38:24] (03PS3) 10Krinkle: Make mw.Uri support URIs with no explicit path component [core] - 10https://gerrit.wikimedia.org/r/139584 (owner: 10Yuvipanda) [19:39:15] 3MediaWiki / 3History/Diffs: We Need To Search For History - 10https://bugzilla.wikimedia.org/29367 (10Bartosz Dziewoński) 5REOP>3RESO/WON [19:40:15] (03PS4) 10Krinkle: mediawiki.Uri: Support URIs with no explicit path component [core] - 10https://gerrit.wikimedia.org/r/139584 (owner: 10Yuvipanda) [19:41:21] (03PS5) 10Krinkle: CodeEditor: Keep experimental Geshi editor working [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/127451 (owner: 10TheDJ) [19:42:23] (03CR) 10Legoktm: [C: 04-1] "lol" [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/156878 (owner: 10Yuvipanda) [19:43:15] (03CR) 10Krinkle: [C: 032] CodeEditor: Keep experimental Geshi editor working [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/127451 (owner: 10TheDJ) [19:43:15] (03Merged) 10jenkins-bot: CodeEditor: Keep experimental Geshi editor working [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/127451 (owner: 10TheDJ) [19:46:24] (03CR) 10MaxSem: [C: 031] "I find it very inspiring." [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/156878 (owner: 10Yuvipanda) [19:46:33] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.Uri: Support URIs with no explicit path component [core] - 10https://gerrit.wikimedia.org/r/139584 (owner: 10Yuvipanda) [19:47:24] (03CR) 10MaxSem: [C: 032] "Yuvi made me do it! :P" [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/156878 (owner: 10Yuvipanda) [19:47:27] (03Merged) 10jenkins-bot: Rename jenkins-bot if it does a -1 [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/156878 (owner: 10Yuvipanda) [19:47:30] :D [19:50:22] (03PS1) 10CSteipp: [WIP] Allow extensions to indicate rename during login [core] - 10https://gerrit.wikimedia.org/r/156887 (https://bugzilla.wikimedia.org/67995) [19:52:42] (03CR) 10Rush: "note: we discussed yesterday making sure duplicate private tasks are not created for ops-access-request type if we run this "always" when " [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/154850 (owner: 10Rush) [19:54:34] anomie: is there any circumstance that you could end up inside luasandbox_lua_to_array where you wouldn't already be in pcall with the timer running? [19:55:25] bd808|LUNCH: im banging my head over this nokogiri thing with vagrant [19:55:35] (03CR) 10Legoktm: "recheck" [core] - 10https://gerrit.wikimedia.org/r/139584 (owner: 10Yuvipanda) [19:57:07] jackmcbarn: Every call to luasandbox_lua_to_zval from luasandbox.c besides the one in luasandbox_call_php, it looks like. [19:57:54] YuviPanda: eh, it didn't change the name? [19:57:55] [12:57:28] <+grrrit-wm> (CR) jenkins-bot: [V: -1] Add testImportTranslations() and testGetOnWikiLanguages() [extensions/TranslateSvg] - https://gerrit.wikimedia.org/r/155733 (owner: Jarry1250) [19:58:32] legoktm: I don't see it here at all. [19:58:34] legoktm: unsure. [19:58:39] that was in -feed [19:58:45] your changeset should V-1 in a minute [19:58:45] maybe time has not moved forward yet [19:58:50] yea [20:00:40] bd808|LUNCH: i managed to get the nokogiri gem installed manually with some wrestling but installing the vagrant-vbguest plugin is still dying with the same error as before [20:02:07] jackmcbarn: Also, this lack of backtrace propagation isn't anything new, any Lua->PHP->Lua call is going to lose backtrace info. Without making every PHP call possibly "throw" a table rather than a string on error, I don't see a way around it. While we could probably get most of the way there by having the table have a __tostring method, there are things that specifically want strings and won't stringify tables that might break. [20:02:32] (03PS1) 10Bartosz Dziewoński: Discontinued, empty the repository [extensions/Agora] - 10https://gerrit.wikimedia.org/r/156894 [20:03:11] (03PS2) 10Krinkle: Fix for tinyint(1)'s not accepting '' [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/135762 (https://bugzilla.wikimedia.org/65807) (owner: 10Matthias Mullie) [20:04:18] (03CR) 10Legoktm: [C: 031] "Yes please" [extensions/Agora] - 10https://gerrit.wikimedia.org/r/156894 (owner: 10Bartosz Dziewoński) [20:04:47] YuviPanda: can we have the operations/ prefix only be removed in #wikimedia-operations and not in #mediawiki-feed? [20:05:19] legoktm: too complicated no? [20:09:56] anomie: does anything else lose the first frame of the backtrace? [20:11:25] (03PS1) 10Legoktm: Use POST requests for action=thanks/flowthanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/156896 (https://bugzilla.wikimedia.org/70138) [20:11:43] 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c21 (10Bartosz Dziewoński) I quite like the document.write one, seems it will have the least impact on users with non-broken user JS and should be easy to implement? [20:14:00] awjr: Vagrant has it's own ruby and is trying to install via bundler inside the Vagrant app environment [20:15:39] awjr: If you know what you did to get it installed, do the same thing via /Applications/Vagrant/embedded/bin/gem [20:16:14] awjr: Something like `/Applications/Vagrant/embedded/bin/gem install --install-dir ~/.vagrant.d/gems nokogiri -v '1.6.3.1'` [20:16:30] 3MediaWiki / 3ResourceLoader: [Regression] Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924 (10Krinkle) [20:16:43] 3MediaWiki / 3JavaScript: ResourceLoader: User scripts should not execute in global scope - 10https://bugzilla.wikimedia.org/63728 (10Krinkle) [20:16:58] legoktm, I'm nuking a user on mediawiki.org [20:17:09] legoktm, Deletion does feel quite slow... [20:17:19] how many pages? [20:17:25] (03CR) 10Jforrester: [C: 032] Use POST requests for action=thanks/flowthanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/156896 (https://bugzilla.wikimedia.org/70138) (owner: 10Legoktm) [20:17:28] (03PS7) 10Legoktm: Don't let any module depend on raw modules: 'mediawiki' & 'jquery' [core] - 10https://gerrit.wikimedia.org/r/155647 [20:17:32] awjr: Or try copying the gem that you already built to ~/.vagrant.d/gems/gems [20:17:37] 28 [20:17:48] (03PS1) 10Jforrester: Use POST requests for action=thanks/flowthanks [extensions/Thanks] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/156898 (https://bugzilla.wikimedia.org/70138) [20:17:52] (03Merged) 10jenkins-bot: Use POST requests for action=thanks/flowthanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/156896 (https://bugzilla.wikimedia.org/70138) (owner: 10Legoktm) [20:17:53] but I'm watching the feed and they're coming through more slowly than I would expect [20:18:08] (03CR) 10Bartosz Dziewoński: [C: 031] Don't let any module depend on raw modules: 'mediawiki' & 'jquery' [core] - 10https://gerrit.wikimedia.org/r/155647 (owner: 10Legoktm) [20:18:24] hopefully it doesn't timeout before Special:Nuke is finished :p [20:18:26] (03PS2) 10Legoktm: Use POST requests for action=thanks/flowthanks [extensions/Thanks] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/156898 (https://bugzilla.wikimedia.org/70138) (owner: 10Jforrester) [20:18:50] meh, done successfully in the end. [20:19:07] if it timeouts, you just reload the page and it'll keep going :D [20:19:32] it depends on how many revisions the each page has, files are even more expensive, etc [20:19:43] 3MediaWiki / 3General/Unknown: Per book, category and/or template CSS and JavaScript - 10https://bugzilla.wikimedia.org/15075#c7 (10Krinkle) This is about page rendering and the load queue of scripts (which eventually end up loaded with ResourceLoader). About as related to ResourceLoader as it is to Apache... [20:20:13] 3MediaWiki-Vagrant: Unprivileged user can't install nokogiri gem so setup.sh fails - 10https://bugzilla.wikimedia.org/69052#c16 (10Bryan Davis) Same issue reported elsewhere on the internetz: * https://github.com/mitchellh/vagrant-aws/issues/235 * https://github.com/mitchellh/vagrant/issues/3769 * https://sta... [20:20:20] legoktm, it was just a bunch of LQT threads though :/ [20:20:37] well that might require other table updates [20:20:40] maybe [20:20:54] $wgHooks['ArticleDeleteComplete'][] = 'LqtDeletionController::onArticleDeleteComplete'; [20:21:06] bd808: ahhhhha! that did it - thank you! [20:21:37] awjr: Update bug with your work around please and thank you :) [20:21:45] Krenair: which calls something named "self::recursivelyDeleteReplies" which sounds like it could be expensive! [20:21:58] no replies afaict :/ [20:22:38] (03CR) 10Chad: [C: 032] "One of these days I'll remember my operators." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156837 (https://bugzilla.wikimedia.org/69606) (owner: 10Manybubbles) [20:22:52] (03Merged) 10jenkins-bot: Make sure that update errors are retried [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156837 (https://bugzilla.wikimedia.org/69606) (owner: 10Manybubbles) [20:23:43] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Make sure that failures during indexing cause the job to be retried - 10https://bugzilla.wikimedia.org/69606 (10Nik Everett) 5PATC>3RESO/FIX [20:25:03] 3MediaWiki / 3ResourceLoader: sorting of style modules leading to arbitrary loading of files - 10https://bugzilla.wikimedia.org/69159#c3 (10Bartosz Dziewoński) 5UNCO>3RESO/DUP *** This bug has been marked as a duplicate of bug 45229 *** [20:25:03] 3MediaWiki / 3Skin and page rendering: OutputPage should not change order of stylesheet modules added by addModuleStyles - 10https://bugzilla.wikimedia.org/45229#c10 (10Bartosz Dziewoński) *** Bug 69159 has been marked as a duplicate of this bug. *** [20:26:07] ayeaye bd808 [20:26:53] (03PS2) 10Jdlrobson: Hygiene: Kill ifEquals helper, use ifCond instead [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156720 [20:27:35] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Kill ifEquals helper, use ifCond instead [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156720 (owner: 10Jdlrobson) [20:29:53] MatmaRex: OK? https://gerrit.wikimedia.org/r/#/c/155647/8/includes/resourceloader/ResourceLoaderStartUpModule.php [20:30:29] legoktm: ^ [20:30:30] (03PS8) 10Krinkle: resourceloader: Don't register raw modules client-side [core] - 10https://gerrit.wikimedia.org/r/155647 (owner: 10Legoktm) [20:30:32] Krinkle: lgtm [20:30:36] (03CR) 10MarkTraceur: "I'm not seeing any actual timing data going out in my test requests. Will test again when the inline comment is fixed." (031 comment) [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/151262 (owner: 10Gergő Tisza) [20:30:38] (03PS9) 10Krinkle: resourceloader: Don't register raw modules client-side [core] - 10https://gerrit.wikimedia.org/r/155647 (owner: 10Legoktm) [20:30:40] (03CR) 10Krinkle: [C: 032] resourceloader: Don't register raw modules client-side [core] - 10https://gerrit.wikimedia.org/r/155647 (owner: 10Legoktm) [20:30:42] (03CR) 10MarkTraceur: [C: 04-1] Add code for logging image loading times [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/151262 (owner: 10Gergő Tisza) [20:30:44] +1 [20:30:44] (03CR) 10Bartosz Dziewoński: [C: 031] resourceloader: Don't register raw modules client-side [core] - 10https://gerrit.wikimedia.org/r/155647 (owner: 10Legoktm) [20:30:54] (03CR) 10Legoktm: [C: 031] resourceloader: Don't register raw modules client-side [core] - 10https://gerrit.wikimedia.org/r/155647 (owner: 10Legoktm) [20:32:43] 3MediaWiki-Vagrant: vagrant vagrant-vbguest plugin install fails on Mac OS X - 10https://bugzilla.wikimedia.org/68453#c15 (10Arthur Richards) I ran into a similar problem with a clean install on OS X 10.9.4. I finally got it working by first installing libiconv from source, and then pointing nokogiri to the li... [20:32:43] 3Wikimedia / 3Site requests: Activate Flagged Revisions for modules namespace on Ukrainian Wikipedia - 10https://bugzilla.wikimedia.org/67748 (10Calak) 5PATC>3RESO/FIX [20:32:48] (03CR) 10Jackmcbarn: [C: 032] "I'm not thrilled about the missing first frame of the backtrace, but after discussion on IRC, it can be fixed in a follow-up (assuming it " [php/luasandbox] - 10https://gerrit.wikimedia.org/r/84985 (owner: 10Anomie) [20:33:23] (03Merged) 10jenkins-bot: Handle __pairs when marshalling Lua-to-PHP [php/luasandbox] - 10https://gerrit.wikimedia.org/r/84985 (owner: 10Anomie) [20:34:21] ARgh, ffs! If you use "Cherry-pick" to go to wmf19, it's so far down the dropdown meny that the dialog expands, then after you close the suggestion box, the window is much smaller and the cherry-pick dialog is now off-screen -top [20:34:43] 3MediaWiki-Vagrant: Unprivileged user can't install nokogiri gem so setup.sh fails - 10https://bugzilla.wikimedia.org/69052#c17 (10Bryan Davis) (Copied from Bug 68453 comment #15) > I ran into a similar problem with a clean install on OS X 10.9.4. I finally > got it working by first installing libiconv from so... [20:34:59] too many branches! [20:35:09] ^d: can we purge 1.23? [20:35:10] (03CR) 10MarkTraceur: [C: 04-1] "Little logging issue, looks good to me so far, haven't tested quite yet." (031 comment) [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/156475 (owner: 10Gergő Tisza) [20:35:33] (currently happens if you type only "wmf" if you type more, itll get smaller) [20:35:36] (03PS1) 10Krinkle: resourceloader: Don't register raw modules client-side [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/156944 [20:37:04] (03CR) 10Krinkle: [C: 032] "Fixes regression in 1.24wmf19 which just got deployed by the MediaWiki train." [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/156944 (owner: 10Krinkle) [20:37:43] (03PS1) 10MarkTraceur: Add ImageMetrics to -multimedia [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/156945 [20:37:48] YuviPanda: :DDD ^^ [20:38:03] (03Merged) 10jenkins-bot: resourceloader: Don't register raw modules client-side [core] - 10https://gerrit.wikimedia.org/r/155647 (owner: 10Legoktm) [20:38:45] (03CR) 10MarkTraceur: [C: 04-1] "I think these are still useful to have in -dev, given that the Multimedia channel is not yet all that lively. A few more months and notifi" [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/134154 (owner: 10Yuvipanda) [20:39:03] <^d> Krinkle: The branches? [20:39:21] <^d> Don't see why not. Just need someone to turn them into tags and then drop the branches. [20:40:45] (03CR) 10Gergő Tisza: "Did you set $wgImageMetricsSamplingFactor?" [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/151262 (owner: 10Gergő Tisza) [20:40:58] (03Merged) 10jenkins-bot: resourceloader: Don't register raw modules client-side [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/156944 (owner: 10Krinkle) [20:42:56] (03PS9) 10Gergő Tisza: Add code for logging image loading times [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/151262 [20:43:02] ^d: you seem to be good at that (and one of with with the right user rights and git powers) [20:43:08] I have the latter, not the former [20:43:11] (03PS4) 10Gergő Tisza: Track image loading time via onload [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/156475 [20:43:36] you should be able to push tags and delete branches. [20:43:57] (03PS2) 10Jdlrobson: Avoid flash of unstyled content on new topic form [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156489 (https://bugzilla.wikimedia.org/69220) [20:44:16] <^d> For each branch you're wanting to do, do `git tag ` and you'll get a tag with the same ref. [20:44:23] <^d> Then when you're done, `git push --tags` [20:44:25] (03PS1) 10CSteipp: Check for renamed user on login [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156947 (https://bugzilla.wikimedia.org/67995) [20:44:28] <^d> And then delete the leftover branches. [20:45:05] (03CR) 10Jdlrobson: "Why the -2?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156162 (owner: 10SG) [20:45:22] (03CR) 10Jdlrobson: "Also please rebase!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156162 (owner: 10SG) [20:46:00] (03Abandoned) 10Jdlrobson: Use i18n message in handlebar language helper function [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145490 (owner: 10Bsitu) [20:47:01] (03Abandoned) 10Jdlrobson: Update mw-ui.enhance to Core version, add support for select, radio, and checkboxes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145331 (owner: 10SG) [20:47:46] (03CR) 10Jdlrobson: [C: 032] Fix Flow entries in Special:EditWatchlist [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156121 (owner: 10Matthias Mullie) [20:47:51] (03CR) 10jenkins-bot: [V: 04-1] Fix Flow entries in Special:EditWatchlist [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156121 (owner: 10Matthias Mullie) [20:48:10] (03CR) 10Jdlrobson: [C: 04-1] "See above comment.. (not a -1 related to code itself)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155612 (owner: 10SG) [20:50:28] (03PS1) 10Aaron Schulz: Made findMissingFiles support scanning files changed in a time range [core] - 10https://gerrit.wikimedia.org/r/156951 [20:50:33] (03PS4) 10Jdlrobson: Fix Flow entries in Special:EditWatchlist [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156121 (owner: 10Matthias Mullie) [20:51:07] (03CR) 10Jdlrobson: [C: 032] "rebased" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156121 (owner: 10Matthias Mullie) [20:51:23] (03PS2) 10CSteipp: [WIP] Allow extensions to indicate rename during login [core] - 10https://gerrit.wikimedia.org/r/156887 (https://bugzilla.wikimedia.org/67995) [20:51:48] 3Wikimedia / 3Site requests: Change FlaggedRevs configuration on fa.wikipedia - 10https://bugzilla.wikimedia.org/69668 (10Calak) 5PATC>3RESO/FIX [20:51:49] (03Merged) 10jenkins-bot: Fix Flow entries in Special:EditWatchlist [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156121 (owner: 10Matthias Mullie) [20:53:49] (03CR) 10Jdlrobson: [C: 04-2] "No... this step is correct, it's just the test is failing :)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156816 (owner: 10Cmcmahon) [20:54:32] (03PS2) 10Jdlrobson: QA: class name locator changed [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156816 (owner: 10Cmcmahon) [20:54:41] (03PS5) 10Jdlrobson: QA: Add browser test for user rights change [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152941 [20:55:33] (03CR) 10Cmcmahon: "Heh. Sorry I didn't recognize this as a failure. I'm happy to abandon this change if the existing code is correct.." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156816 (owner: 10Cmcmahon) [20:56:12] (03PS5) 10Gergő Tisza: Track image loading time via onload [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/156475 [20:57:01] (03CR) 10Legoktm: "This doesn't seem to be working. I still see "jenkins-bot" in V-1 messages." [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/156878 (owner: 10Yuvipanda) [20:57:24] (03PS6) 10Jdlrobson: QA: Add browser test for user rights change [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152941 [20:58:19] (03PS2) 10Jdlrobson: Update classes of topic during close/reopen actions. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156739 (https://bugzilla.wikimedia.org/68328) [20:58:56] (03CR) 10jenkins-bot: [V: 04-1] Update classes of topic during close/reopen actions. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156739 (https://bugzilla.wikimedia.org/68328) (owner: 10Jdlrobson) [21:00:26] (03CR) 10Anomie: [C: 032] "The destructor stuff probably belongs where it is, but if we have to hack around HHVM ignoring the destructor then we have to. Ori tells m" [php/luasandbox] - 10https://gerrit.wikimedia.org/r/156758 (https://bugzilla.wikimedia.org/70006) (owner: 10Ori.livneh) [21:01:01] (03Merged) 10jenkins-bot: Fix LuaSandboxFunction leak [php/luasandbox] - 10https://gerrit.wikimedia.org/r/156758 (https://bugzilla.wikimedia.org/70006) (owner: 10Ori.livneh) [21:01:26] (03CR) 10Tpt: [C: 032] "Thanks a lot!" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/156266 (owner: 10Helder.wiki) [21:01:44] (03Merged) 10jenkins-bot: Fix a typo in the function name: toogleLayout -> toggleLayout [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/156266 (owner: 10Helder.wiki) [21:03:58] 3MediaWiki extensions / 3ProofreadPage: Consistency - 'toogleLayout' should be 'toggleLayout' - 10https://bugzilla.wikimedia.org/70017#c1 (10Tpt) 5NEW>3RESO/FIX Issue fixed by change Iaba368f7725a1564c94c2d71dc4acef932d1473e [21:05:29] (03PS2) 10Tpt: [WIP] Make sure that the scan image is displayed in a nice way in mobile skin [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/132800 [21:05:31] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Make sure that the scan image is displayed in a nice way in mobile skin [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/132800 (owner: 10Tpt) [21:06:41] (03CR) 10Helder.wiki: "Fixed bug 70017." [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/156266 (owner: 10Helder.wiki) [21:07:14] 3MediaWiki extensions / 3ProofreadPage: Consistency - 'toogleLayout' should be 'toggleLayout' - 10https://bugzilla.wikimedia.org/70017#c2 (10Helder) Fixed by I3daa77babeee46f435fa0d37c539a350bc8368a1. [21:08:00] (03PS2) 10Jdlrobson: Update preferences form buttons [core] - 10https://gerrit.wikimedia.org/r/156838 (https://bugzilla.wikimedia.org/65317) [21:08:36] (03PS2) 10Jdlrobson: Use correct progressive color on inputs [core] - 10https://gerrit.wikimedia.org/r/156839 (https://bugzilla.wikimedia.org/69040) [21:09:01] (03PS1) 10Ori.livneh: resourceloader: Don't register raw modules client-side [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156953 [21:09:21] (03Abandoned) 10Jdlrobson: Expose the count of users watching a given page [core] - 10https://gerrit.wikimedia.org/r/149478 (owner: 10Jdlrobson) [21:09:33] (03PS1) 10Giuseppe Lavagetto: version bump for the package [php/luasandbox] - 10https://gerrit.wikimedia.org/r/156954 [21:09:40] (03CR) 10Bartosz Dziewoński: [C: 031] resourceloader: Don't register raw modules client-side [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156953 (owner: 10Ori.livneh) [21:09:48] (03CR) 10Ori.livneh: [C: 031] version bump for the package [php/luasandbox] - 10https://gerrit.wikimedia.org/r/156954 (owner: 10Giuseppe Lavagetto) [21:10:08] (03CR) 10Ori.livneh: [C: 032] resourceloader: Don't register raw modules client-side [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156953 (owner: 10Ori.livneh) [21:10:23] (03CR) 10Jdlrobson: Begin deprecation of mediawiki.ui style module (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151791 (owner: 10Jdlrobson) [21:10:28] (03PS8) 10Jdlrobson: Begin deprecation of mediawiki.ui style module [core] - 10https://gerrit.wikimedia.org/r/151791 [21:11:38] (03PS9) 10Jdlrobson: Begin deprecation of mediawiki.ui style module [core] - 10https://gerrit.wikimedia.org/r/151791 [21:12:12] jackmcbarn: Pass a function that throws an error as the third arg to mw.ustring.gsub, for example. The call to Scribunto_LuaUstringLibrary::ustringGsub (which shows as "v" in the Lua backtrace) is shown as the top of the stack. [21:12:31] (03PS2) 10Giuseppe Lavagetto: version bump for the package [php/luasandbox] - 10https://gerrit.wikimedia.org/r/156954 [21:13:28] 3MediaWiki extensions / 3CentralAuth: Allow login in with pre-rename username and password - 10https://bugzilla.wikimedia.org/67995#c5 (10Chris Steipp) I added a few patchsets (gerrit 156887 and gerrit 156947) to add a hook to core and use that in CentralAuth to fix the remaining use case that Bryan's patch... [21:13:28] (03CR) 10Giuseppe Lavagetto: [C: 032 V: 032] version bump for the package [php/luasandbox] - 10https://gerrit.wikimedia.org/r/156954 (owner: 10Giuseppe Lavagetto) [21:13:38] (03PS7) 10Jdlrobson: Remove concept of a default compiler [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/149360 [21:14:00] (03CR) 10Jdlrobson: Remove concept of a default compiler (036 comments) [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/149360 (owner: 10Jdlrobson) [21:14:05] (03CR) 10jenkins-bot: [V: 04-1] Remove concept of a default compiler [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/149360 (owner: 10Jdlrobson) [21:14:15] (03PS6) 10Umherirrender: Parser: Clean up handling of editsections by using local variables [core] - 10https://gerrit.wikimedia.org/r/144182 [21:14:21] (03Merged) 10jenkins-bot: resourceloader: Don't register raw modules client-side [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156953 (owner: 10Ori.livneh) [21:17:02] anomie|away: indeed. i'll drop the issue then. i also noticed in -core that someone's already working on repackaging because of the other change that you just merged, so that means i don't have to bug anyone about this one :P [21:17:56] jgonera are you around somewhere? [21:18:43] (03PS8) 10Jdlrobson: Remove concept of a default compiler [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/149360 [21:18:47] 3Wikimedia / 3Site requests: Localizing dv.wikipedia namespace and sitename - 10https://bugzilla.wikimedia.org/48075#c11 (10Vogone) 5RESO/WOR>3PATC a:5Tomasz W. Kozlowski>3Glaisher Reopening per https://gerrit.wikimedia.org/r/156821 [21:19:09] (03CR) 10jenkins-bot: [V: 04-1] Remove concept of a default compiler [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/149360 (owner: 10Jdlrobson) [21:21:29] 3MediaWiki-Vagrant: latest mw-vagrant and labs-vagrant time out after a load.php request - 10https://bugzilla.wikimedia.org/69452#c3 (10spage) (In reply to Bryan Davis from comment #2) > What version of hhvm do you have installed? The best way to > tell at the moment is to do `dpkg -l|grep hhvm` so you can get... [21:25:39] (03CR) 10Catrope: [C: 04-1] "This one is still broken and needs to be redone the way https://gerrit.wikimedia.org/r/#/c/156820/ was" [core] - 10https://gerrit.wikimedia.org/r/156817 (owner: 10Jforrester) [21:29:02] pizzzacat, I will be in half hour or a bit more [21:29:57] (03PS1) 10Bsitu: There is no welcome notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156961 (https://bugzilla.wikimedia.org/70139) [21:30:28] 3MediaWiki / 3ResourceLoader: ResourceLoader preloads blob metadata, then does another query for blob contents - 10https://bugzilla.wikimedia.org/26398 (10Krinkle) p:5Normal>3Low [21:30:28] 3MediaWiki extensions / 3Gadgets: Implement Gadgets 2.0 (tracking) - 10https://bugzilla.wikimedia.org/29272 (10Krinkle) [21:31:21] no worries jgonera I was having a node issue but I think I resolved it. [21:33:24] pizzzacat, who are you anyway? ;) [21:34:52] <^d> jgonera: A pizza-loving cat, obviously :) [21:35:01] jgonera Sherah, who the hell else [21:36:10] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/156963 [21:36:21] heh [21:36:53] (03CR) 10Ejegg: [C: 032] Update DonationInterface submodule [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/156963 (owner: 10Ejegg) [21:37:09] jgonera who did you expect [21:37:44] 3MediaWiki extensions / 3WikibaseQuery: security review of WikibaseQuery - 10https://bugzilla.wikimedia.org/67533#c8 (10Jeroen De Dauw) > Regardless, I'm pretty sure we're not going to change our minds about security review by debating in a bug. Not sure debate is happening. I never even asked to change the... [21:38:05] pizzzacat: Your whois doesn't make it all that clear :P pizzzacat <~textual@198.73.209.2> “Textual User” [21:38:30] I like to keep an air of mystery RoanKattouw [21:39:20] (03CR) 10jenkins-bot: [V: 04-1] Update DonationInterface submodule [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/156963 (owner: 10Ejegg) [21:39:38] You've evidently succeeded [21:44:34] (03CR) 10Katie Horn: [C: 032] Update DonationInterface submodule [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/156963 (owner: 10Ejegg) [21:44:53] (03CR) 10Katie Horn: [V: 032] Update DonationInterface submodule [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/156963 (owner: 10Ejegg) [21:47:32] 3MediaWiki / 3Skin and page rendering: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277#c36 (10Bartosz Dziewoński) (In reply to Marcin Cieślak from comment #35) > Seems like a slight botched preparation of the mediawiki/skins proj... [21:50:33] 3MediaWiki extensions / 3Scribunto: LuaSandbox reports substantially higher memory utilization under HHVM - 10https://bugzilla.wikimedia.org/70006#c4 (10Ori Livneh) 5PATC>3RESO/FIX Merged, repacked, deployed, and verified. [21:51:08] (03PS3) 10Jforrester: Update OOjs UI to v0.1.0-pre (43f379c884) [core] - 10https://gerrit.wikimedia.org/r/156817 [21:52:50] (03PS4) 10Jforrester: Update OOjs UI to v0.1.0-pre (43f379c884) [core] - 10https://gerrit.wikimedia.org/r/156817 [21:55:01] (03PS1) 10Spage: New users don't get welcome notification. [extensions/Echo] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/156970 (https://bugzilla.wikimedia.org/70139) [21:55:53] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (43f379c884) [core] - 10https://gerrit.wikimedia.org/r/156817 (owner: 10Jforrester) [21:56:43] 3Wikimedia / 3General/Unknown: JS bug : URI error - 10https://bugzilla.wikimedia.org/70097#c8 (10Sacamol) Created attachment 16306 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16306&action=edit homepage console with debug=true [21:57:13] 3Wikimedia / 3General/Unknown: JS bug : URI error - 10https://bugzilla.wikimedia.org/70097#c9 (10Sacamol) Created attachment 16307 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16307&action=edit random page with debug=true [21:57:43] 3Wikimedia / 3General/Unknown: JS bug : URI error - 10https://bugzilla.wikimedia.org/70097#c10 (10Sacamol) Created attachment 16308 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16308&action=edit edit with debug=true [22:00:14] 3Wikimedia / 3General/Unknown: JS bug : URI error - 10https://bugzilla.wikimedia.org/70097#c11 (10Sacamol) Hi, i added pictures of JS console on pages with "debug=true". Hope this will help to find something :) . Thx for helping. Sacamol [22:00:14] 3MediaWiki extensions / 3CentralAuth: Allow login in with pre-rename username and password - 10https://bugzilla.wikimedia.org/67995#c6 (10Bryan Davis) (In reply to Chris Steipp from comment #5) > On a separate note, I wanted to document that this feature has slight > security implications. Since we're automa... [22:00:26] (03PS1) 10Aaron Schulz: Made findMissingFiles use preloadFileStat() on old versions too to speed it up [core] - 10https://gerrit.wikimedia.org/r/156974 [22:00:30] (03PS1) 10MaxSem: MobileFrontend: pick https://gerrit.wikimedia.org/r/156968 [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/156976 [22:00:41] (03CR) 10Jeroen De Dauw: Consolidate parts of WebStart.php and doMaintenance.php into Initialize.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156053 (owner: 10Withoutaname) [22:01:21] (03PS2) 10Spage: New users don't get welcome notification. [extensions/Echo] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/156970 (https://bugzilla.wikimedia.org/70139) [22:02:17] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (43f379c884) [core] - 10https://gerrit.wikimedia.org/r/156817 (owner: 10Jforrester) [22:04:16] (03CR) 10Chad: Made findMissingFiles support scanning files changed in a time range (032 comments) [core] - 10https://gerrit.wikimedia.org/r/156951 (owner: 10Aaron Schulz) [22:04:17] JeroenDeDauw, so https://gerrit.wikimedia.org/r/#/c/156053/ will break wikidata next week? [22:04:46] <^d> I should revert that. [22:04:48] <^d> Too many gotchas. [22:05:09] go for it, I'll SWAT it [22:05:15] (03PS1) 10Chad: Revert "Consolidate parts of WebStart.php and doMaintenance.php into Initialize.php" [core] - 10https://gerrit.wikimedia.org/r/156978 [22:05:35] (03CR) 10MaxSem: [C: 032] Revert "Consolidate parts of WebStart.php and doMaintenance.php into Initialize.php" [core] - 10https://gerrit.wikimedia.org/r/156978 (owner: 10Chad) [22:05:59] (03CR) 10Aaron Schulz: Made findMissingFiles support scanning files changed in a time range (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156951 (owner: 10Aaron Schulz) [22:06:01] <^d> MW init is so picky :p [22:06:12] also, no clear difference between Setup and Initialize :P [22:06:12] <^d> Reorder 1 thing and EVERYTHING BREAKS [22:06:28] 3MediaWiki / 3Skin and page rendering: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277#c37 (10Marcin Cieślak) (In reply to Bartosz Dziewoński from comment #36) > (In reply to Marcin Cieślak from comment #35) > > Seems like a slig... [22:06:44] 3Wikimedia / 3Site requests: Set $wgUploadNavigationUrl on eo.wikipedia - 10https://bugzilla.wikimedia.org/69055 (10This, that and the other (TTO)) 5PATC>3RESO/FIX a:3Nemo [22:06:50] (03CR) 10Chad: [C: 032] Made findMissingFiles support scanning files changed in a time range (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156951 (owner: 10Aaron Schulz) [22:06:52] (03PS10) 10Bartosz Dziewoński: TablePager: Modernize style loading [core] - 10https://gerrit.wikimedia.org/r/155903 [22:06:54] yep, $t=new Foo(); $foo->foo(); should always work:P [22:09:08] (03CR) 10Parent5446: [C: 032] Load password information when expiring [core] - 10https://gerrit.wikimedia.org/r/156827 (owner: 10CSteipp) [22:10:10] ^d: the $tables parameter is kind of non-intuitive in that regard come to think of it [22:10:24] (03PS2) 10Bartosz Dziewoński: Remove some references to skins/common/ in comments [core] - 10https://gerrit.wikimedia.org/r/156824 [22:10:31] <^d> AaronSchulz: I totally didn't realize it behaved like that :) [22:10:38] anyone wants to merge some trivial patches? [22:10:57] https://gerrit.wikimedia.org/r/156824 https://gerrit.wikimedia.org/r/156894 https://gerrit.wikimedia.org/r/156789 https://gerrit.wikimedia.org/r/156182 [22:11:21] normally use say "select from X join Y on A join Z on B", whereas we say "select from these tables X, Y, Z, join Y on A join Z on B" which implicitly makes X the reference table [22:11:49] also, some RL-related file renames and things: https://gerrit.wikimedia.org/r/155442 https://gerrit.wikimedia.org/r/155914 https://gerrit.wikimedia.org/r/153370 [22:12:12] (03Merged) 10jenkins-bot: Revert "Consolidate parts of WebStart.php and doMaintenance.php into Initialize.php" [core] - 10https://gerrit.wikimedia.org/r/156978 (owner: 10Chad) [22:12:24] (03CR) 10Legoktm: [C: 032] Remove some references to skins/common/ in comments [core] - 10https://gerrit.wikimedia.org/r/156824 (owner: 10Bartosz Dziewoński) [22:12:27] though I guess making the reference table first and the list and having $where start of with conditions on it makes it a bit clearer [22:13:30] (03CR) 10Legoktm: [C: 032] Discontinued, empty the repository [extensions/Agora] - 10https://gerrit.wikimedia.org/r/156894 (owner: 10Bartosz Dziewoński) [22:13:57] <^d> THANK YOU [22:14:01] (03PS1) 10MaxSem: Revert "Consolidate parts of WebStart.php and doMaintenance.php into Initialize.php" [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/156979 [22:14:04] putting all the table names in $tables also unifies the alias handling too [22:14:05] (03CR) 10Legoktm: [C: 032] Remove dead code for showing login form to logged-in users [core] - 10https://gerrit.wikimedia.org/r/156182 (owner: 10Bartosz Dziewoński) [22:14:05] <^d> Omg, I hated when that patch showed up in my greps. [22:14:15] <^d> s/patch/repo/ [22:14:20] ^d: my pleasure [22:14:31] <^d> Do we even need the repo? [22:14:33] <^d> At all? [22:14:41] deleting repos causes issues [22:14:57] <^d> It does? [22:14:59] <^d> I do it all the time. [22:15:02] :< [22:15:04] <^d> s/all the time/sometimes/ [22:15:04] ^d: want to show how gratefyul you are? i have patches pending [22:15:11] (03Merged) 10jenkins-bot: Made findMissingFiles support scanning files changed in a time range [core] - 10https://gerrit.wikimedia.org/r/156951 (owner: 10Aaron Schulz) [22:15:14] ^d: we probably don't need it, but who cares? [22:15:28] <^d> Nobody, really :p [22:16:08] (03Merged) 10jenkins-bot: Discontinued, empty the repository [extensions/Agora] - 10https://gerrit.wikimedia.org/r/156894 (owner: 10Bartosz Dziewoński) [22:16:19] (03PS1) 10Aaron Schulz: Made findMissingFiles support scanning files changed in a time range [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156980 [22:16:28] (03Merged) 10jenkins-bot: Load password information when expiring [core] - 10https://gerrit.wikimedia.org/r/156827 (owner: 10CSteipp) [22:16:30] (03PS1) 10Aaron Schulz: Made findMissingFiles use preloadFileStat() on old versions too to speed it up [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156981 [22:17:14] (03CR) 10Aaron Schulz: [C: 032] Made findMissingFiles support scanning files changed in a time range [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156980 (owner: 10Aaron Schulz) [22:18:49] (03CR) 10saper: Provide rudimentary __toString() for Status (032 comments) [core] - 10https://gerrit.wikimedia.org/r/156446 (owner: 10saper) [22:21:40] (03CR) 10SG: "Work what out in mediawiki ui? This is a fix for Flow. Whatever needs to happen for mw-ui is unrelated to this patch." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155612 (owner: 10SG) [22:22:12] pizzzacat, I don't know, the usual people who change nicks all the time like marktraceur or MaxSem [22:22:16] (03PS3) 10SG: Change mw-ui anchors to require mw-ui-anchor base class [core] - 10https://gerrit.wikimedia.org/r/155856 [22:23:06] (03Merged) 10jenkins-bot: Remove some references to skins/common/ in comments [core] - 10https://gerrit.wikimedia.org/r/156824 (owner: 10Bartosz Dziewoński) [22:23:17] I have always, and forever shall be, the pizzzacat [22:23:33] (03Merged) 10jenkins-bot: Remove dead code for showing login form to logged-in users [core] - 10https://gerrit.wikimedia.org/r/156182 (owner: 10Bartosz Dziewoński) [22:23:37] <^d> I want pizza. [22:24:11] jgonera: http://www.foodbeast.com/2014/08/22/japan-unveils-adorable-mock-pizza-hut-run-entirely-by-cats/ [22:24:27] (03PS1) 10Bsitu: template if / unless mismatch [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156983 [22:25:16] (03PS3) 10Jdlrobson: Hygiene: Kill ifEquals helper, use ifCond instead [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156720 [22:25:59] (03PS9) 10Jdlrobson: Remove concept of a default compiler [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/149360 [22:26:05] (03CR) 10Aaron Schulz: [C: 032] Made findMissingFiles use preloadFileStat() on old versions too to speed it up [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156981 (owner: 10Aaron Schulz) [22:26:08] aharoni, regarding https://bugzilla.wikimedia.org/show_bug.cgi?id=69465 is there an easy way to get desired text direction for a page in JS? I know I can get page language easily, but can't find direction among JS variables (unless I use VE variables, but that would mean MF depends on VE) [22:26:13] 3MediaWiki / 3ResourceLoader: ResourceLoader: Implement per module configuration - 10https://bugzilla.wikimedia.org/26901 (10Krinkle) p:5Normal>3Lowest [22:26:25] (03CR) 10Bsitu: [C: 04-1] template if / unless mismatch [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156983 (owner: 10Bsitu) [22:27:31] jgonera: I change my nick all the time [22:27:32] ? [22:27:39] jgonera: just apply things to the ltr or rtl classes? [22:27:40] News to me [22:27:53] mark, maybe not all the time, but sometimes I think [22:28:28] legoktm, things? I need to set an attribute on DOM nodes generated in JS depending on whether it's LTR or RTL [22:28:28] (03PS2) 10Bsitu: template if / unless mismatch [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156983 [22:28:55] oh, I have no idea. [22:28:59] (03PS3) 10Bsitu: template if / unless mismatch [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156983 (https://bugzilla.wikimedia.org/70137) [22:29:41] jgonera: I had rdwrer for a while, and I've been bouncing to marktraceurWMF as a joke, but that's about it I think [22:29:56] jgonera: $('body').is('.ltr') [22:30:13] 3Wikimedia / 3General/Unknown: JS bug : URI error - 10https://bugzilla.wikimedia.org/70097#c12 (10Helder) 5UNCO>3NEW When I go to https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:Accueil_principal?debug=1 using Firefox in privative navigation the error doesn't happens (so it is not something enabled by defau... [22:30:14] 3MediaWiki / 3ResourceLoader: Add configuration option to enable loading modules based on url parameter - 10https://bugzilla.wikimedia.org/27766#c3 (10Krinkle) withModule has been implemented in a snippet and used by a few wikis: https://www.mediawiki.org/wiki/Snippets/Load_JS_and_CSS_by_URL [22:30:35] MatmaRex, actually, I need page content direction, which is not the same as page direction if you set UI language to different language than the content [22:31:01] jgonera: oh, you should have started with that :D then i don't know, but let's find out [22:31:34] MatmaRex, I mean, I'm sure I can just expose it myself in MF in mw.config, but I don't want to pollute it even further... [22:31:57] jgonera: there should be a dir=ltr or dir=rtl attribute on #mw-content-text [22:32:08] jgonera: it will also be .mw-content-rtl or .mw-content-ltr [22:32:11] https://fa.wikipedia.org/wiki/صفحهٔ_اصلی?uselang=en [22:32:13] 3Wikimedia / 3General/Unknown: JS bug : URI error - 10https://bugzilla.wikimedia.org/70097#c13 (10Andre Klapper) Looking at that code (your browser's developer console offers that) and going to the line numbers offered, these are all cookie related calls. jquery.cookie.js:17 jquery.cookie.js:65 ext.dismis... [22:32:48] MatmaRex, that might be useful, I'll see if we also set it in Minerva, I hope we do [22:33:20] jgonera: it should be set by MW, so in Minerva too unless you do some terrible things [22:33:32] last time i checked, the terrible things meter in Minervawas pretty low :D [22:34:05] MatmaRex, we have #content instead of #mw-content-text but that's fine [22:34:13] yeah, that will work, why didn't I think of it [22:34:21] thanks [22:40:29] (03CR) 10SG: "What does isBoardPage have to do with if-unless mismatch? And where is the recompiled template?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156983 (https://bugzilla.wikimedia.org/70137) (owner: 10Bsitu) [22:42:14] (03CR) 10Neilk: [C: 04-1] "I eliminated mw.UploadWizard.config.apiUrl in c155475." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152817 (https://bugzilla.wikimedia.org/69217) (owner: 10MarkTraceur) [22:43:43] 3MediaWiki / 3Special pages: Make Special:ActiveUsers sortable by number of edits - 10https://bugzilla.wikimedia.org/23237#c4 (10Robin Pepermans (SPQRobin)) *** Bug 62443 has been marked as a duplicate of this bug. *** [22:43:43] 3MediaWiki / 3General/Unknown: Filter Special:ActiveUsers by number of actions - 10https://bugzilla.wikimedia.org/62443#c2 (10Robin Pepermans (SPQRobin)) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 23237 *** [22:45:40] (03CR) 10Neilk: "Okay, it's change 155475. Not sure what formatting to use with comments so it links correctly. https://gerrit.wikimedia.org/r/#/c/155475/" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152817 (https://bugzilla.wikimedia.org/69217) (owner: 10MarkTraceur) [22:47:00] (03Merged) 10jenkins-bot: Made findMissingFiles support scanning files changed in a time range [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156980 (owner: 10Aaron Schulz) [22:47:02] (03Merged) 10jenkins-bot: Made findMissingFiles use preloadFileStat() on old versions too to speed it up [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156981 (owner: 10Aaron Schulz) [22:47:13] 3MediaWiki / 3MediaWiki UI: Should Mediawiki UI change font-family for textareas? - 10https://bugzilla.wikimedia.org/70028 (10Jared Zimmerman (WMF)) [22:48:37] (03PS1) 10tosfos: Don't drop zones table before writing, improve success message [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/156989 [22:49:58] 3MediaWiki / 3MediaWiki UI: Should Mediawiki UI change font-family for textareas? - 10https://bugzilla.wikimedia.org/70028#c6 (10Jared Zimmerman (WMF)) Bartosz, its a good point, I've changed the bug description to be more neutral until me make a decision on this. [22:49:58] (03PS4) 10SG: Fix client-side watch error [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156983 (https://bugzilla.wikimedia.org/70137) (owner: 10Bsitu) [22:49:59] 3Wikimedia / 3Bugzilla: Accessing bug 9444 via XML RPC API crashes due to invalid byte sequence: "not well-formed (invalid token)" - 10https://bugzilla.wikimedia.org/69747#c8 (10Andre Klapper) 5PATC>3RESO/FIX a:3Andre Klapper Now a script querying the XML RPC API does not drop out anymore at ticket #94... [22:50:01] (03PS1) 10Ori.livneh: Inject 'wgPoweredByHHVM' JS config var if powered by HHVM [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/156990 [22:50:05] (03CR) 10SG: [C: 032] Fix client-side watch error [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156983 (https://bugzilla.wikimedia.org/70137) (owner: 10Bsitu) [22:50:13] 3MediaWiki / 3MediaWiki UI: implement updated appearance to Mediawiki.ui (tracking) - 10https://bugzilla.wikimedia.org/54360 (10Jared Zimmerman (WMF)) [22:50:49] (03Merged) 10jenkins-bot: Fix client-side watch error [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156983 (https://bugzilla.wikimedia.org/70137) (owner: 10Bsitu) [22:50:57] 3MediaWiki / 3MediaWiki UI: implement updated appearance to Mediawiki.ui (tracking) - 10https://bugzilla.wikimedia.org/54360#c9 (10Jared Zimmerman (WMF)) Updated the title since we're using "mediawiki.ui" to mean the style, not agora, to try to keep things simple [22:52:28] 3MediaWiki / 3MediaWiki UI: Create a dark skin variant of MediaWiki UI - 10https://bugzilla.wikimedia.org/64734#c1 (10Jared Zimmerman (WMF)) p:5Normal>3Lowest Updating the importance since this does not affect default skin. [22:52:35] (03PS2) 10tosfos: Don't drop zones table before writing, improve success message [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/156989 [22:55:09] (03PS3) 10tosfos: Don't drop zones table before writing, improve success message [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/156989 [22:56:01] (03PS1) 10Spage: Fix client-side watch error [extensions/Flow] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/156992 (https://bugzilla.wikimedia.org/70137) [22:59:08] (03CR) 10Aaron Schulz: [C: 032] Inject 'wgPoweredByHHVM' JS config var if powered by HHVM [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/156990 (owner: 10Ori.livneh) [22:59:12] (03Merged) 10jenkins-bot: Inject 'wgPoweredByHHVM' JS config var if powered by HHVM [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/156990 (owner: 10Ori.livneh) [23:01:14] 3MediaWiki / 3MediaWiki UI: Checkboxes are huge - 10https://bugzilla.wikimedia.org/70133#c2 (10Jared Zimmerman (WMF)) Can we get everything built as designed before we start logging bugs on the design of individual controls? Please do not alter the size of checkboxes at this time. [23:01:17] (03CR) 10SG: [C: 031] Fix client-side watch error [extensions/Flow] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/156992 (https://bugzilla.wikimedia.org/70137) (owner: 10Spage) [23:01:44] (03CR) 10Jaredzimmerman: [C: 04-1] "Can we get everything built as designed before we start logging bugs on the design (rather than implementation) of individual controls? Pl" [core] - 10https://gerrit.wikimedia.org/r/154125 (https://bugzilla.wikimedia.org/70133) (owner: 10Jdlrobson) [23:03:11] (03CR) 10Spage: [C: 032] "Shahyar can't +2." [extensions/Flow] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/156992 (https://bugzilla.wikimedia.org/70137) (owner: 10Spage) [23:03:43] (03Merged) 10jenkins-bot: Fix client-side watch error [extensions/Flow] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/156992 (https://bugzilla.wikimedia.org/70137) (owner: 10Spage) [23:04:14] (03PS3) 10Amire80: Update the registry format to support multiple providers [services/cxserver] - 10https://gerrit.wikimedia.org/r/156675 [23:04:49] (03CR) 10jenkins-bot: [V: 04-1] Update the registry format to support multiple providers [services/cxserver] - 10https://gerrit.wikimedia.org/r/156675 (owner: 10Amire80) [23:06:15] (03CR) 10MaxSem: [C: 032] Use POST requests for action=thanks/flowthanks [extensions/Thanks] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/156898 (https://bugzilla.wikimedia.org/70138) (owner: 10Jforrester) [23:06:33] Thanks Max. [23:06:46] (03Merged) 10jenkins-bot: Use POST requests for action=thanks/flowthanks [extensions/Thanks] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/156898 (https://bugzilla.wikimedia.org/70138) (owner: 10Jforrester) [23:07:06] (03PS1) 10Spage: Update Flow bug 70137 backport [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/156994 [23:07:29] (03PS1) 10Krinkle: RemoveOldManualUserPages: Document and enforce required options [extensions/GlobalCssJs] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156995 [23:07:31] (03PS4) 10Amire80: Update the registry format to support multiple providers [services/cxserver] - 10https://gerrit.wikimedia.org/r/156675 [23:07:33] (03CR) 10Krinkle: [C: 032] RemoveOldManualUserPages: Document and enforce required options [extensions/GlobalCssJs] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156995 (owner: 10Krinkle) [23:07:47] (03Merged) 10jenkins-bot: RemoveOldManualUserPages: Document and enforce required options [extensions/GlobalCssJs] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156995 (owner: 10Krinkle) [23:07:50] (03PS1) 10Krinkle: Add option to ignore the revision limit [extensions/GlobalCssJs] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156996 [23:07:55] (03CR) 10Krinkle: [C: 032] Add option to ignore the revision limit [extensions/GlobalCssJs] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156996 (owner: 10Krinkle) [23:08:00] (03Merged) 10jenkins-bot: Add option to ignore the revision limit [extensions/GlobalCssJs] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156996 (owner: 10Krinkle) [23:08:36] (03CR) 10MaxSem: [C: 032] MobileFrontend: pick https://gerrit.wikimedia.org/r/156968 [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/156976 (owner: 10MaxSem) [23:08:58] (03CR) 10MaxSem: [C: 032] Revert "Consolidate parts of WebStart.php and doMaintenance.php into Initialize.php" [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/156979 (owner: 10MaxSem) [23:09:35] csteipp: Did your patch fix bug 70098? Or was it separate? [23:10:09] (03CR) 10MaxSem: [V: 032] MobileFrontend: pick https://gerrit.wikimedia.org/r/156968 [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/156976 (owner: 10MaxSem) [23:10:52] (03CR) 10Bsitu: [C: 031] Update Flow bug 70137 backport [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/156994 (owner: 10Spage) [23:11:16] 3MediaWiki / 3MediaWiki UI: Checkboxes are huge - 10https://bugzilla.wikimedia.org/70133#c3 (10Jon) I'm confused. What do you mean by "as designed". If you are referring to https://trello.com/c/JETLmm7F/7-check-boxes then the above is working towards that design... Also this is in core and on a production... [23:11:48] parent5446: No, the patch was just something I noticed while investigating. I'm still not able to reliably reproduce 70098. [23:11:57] OK, I'll look into it later tonight [23:12:02] (03PS1) 10MaxSem: Thanks: https://gerrit.wikimedia.org/r/#/c/156898/ [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/156999 [23:12:20] (03PS1) 10Spage: Update Thanks bug 70138 backport [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/157000 [23:12:46] 3MediaWiki / 3MediaWiki UI: implement updated appearance to Mediawiki.ui (tracking) - 10https://bugzilla.wikimedia.org/54360#c10 (10Jon) Do we need this tracking bug now we have an entire component for mediawiki ui..? [23:12:55] (03CR) 10MaxSem: [C: 032 V: 032] Thanks: https://gerrit.wikimedia.org/r/#/c/156898/ [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/156999 (owner: 10MaxSem) [23:13:10] fuuuuu [23:13:42] * YuviPanda waves away [23:14:46] 3MediaWiki / 3MediaWiki UI: Checkboxes are huge - 10https://bugzilla.wikimedia.org/70133#c4 (10Jared Zimmerman (WMF)) The checkboxes height is the same as the other buttons, input boxes and dropdowns, yes, they are bigger than "normal" checkboxes but lets get everything built before we start making design ch... [23:15:33] (03Merged) 10jenkins-bot: Revert "Consolidate parts of WebStart.php and doMaintenance.php into Initialize.php" [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/156979 (owner: 10MaxSem) [23:16:28] 3MediaWiki / 3MediaWiki UI: neutral mw-ui-quiet anchors should lighten on hover and have no outline - 10https://bugzilla.wikimedia.org/69212#c3 (10Jon) 5ASSI>3NEW Shahyar this is fixed no? [23:16:42] (03CR) 10Legoktm: [C: 031] Update Thanks bug 70138 backport [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/157000 (owner: 10Spage) [23:16:56] (03PS1) 10MaxSem: Thanks: https://gerrit.wikimedia.org/r/#/c/156898/ [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/157004 [23:16:59] 3MediaWiki / 3MediaWiki UI: Have mediawiki.ui buttons show focus in a clear and accessible way - 10https://bugzilla.wikimedia.org/62924 (10Jon) 5PATC>3NEW [23:17:28] 3MediaWiki / 3MediaWiki UI: implement light inline button style in mediawiki.ui - 10https://bugzilla.wikimedia.org/62744#c6 (10Jon) 5PATC>3UNCO Is this bug still relevant? [23:18:25] (03CR) 10MaxSem: [C: 032 V: 032] Thanks: https://gerrit.wikimedia.org/r/#/c/156898/ [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/157004 (owner: 10MaxSem) [23:18:29] 3MediaWiki / 3MediaWiki UI: neutral mw-ui-quiet anchors should lighten on hover and have no outline - 10https://bugzilla.wikimedia.org/69212#c4 (10Shahyar Ghobadpour) 5NEW>3PATC It has patches in progress. https://gerrit.wikimedia.org/r/#/c/155856/ https://gerrit.wikimedia.org/r/#/c/156162/ [23:18:48] (03CR) 10Spage: [C: 032] "Seems sane." [extensions/Echo] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/156970 (https://bugzilla.wikimedia.org/70139) (owner: 10Spage) [23:19:38] (03Merged) 10jenkins-bot: New users don't get welcome notification. [extensions/Echo] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/156970 (https://bugzilla.wikimedia.org/70139) (owner: 10Spage) [23:21:59] 3MediaWiki / 3MediaWiki UI: implement updated appearance to Mediawiki.ui (tracking) - 10https://bugzilla.wikimedia.org/54360#c11 (10Jared Zimmerman (WMF)) probably not, but I'll let someone in Eng. decide that. [23:22:36] (03PS1) 10MaxSem: GlobalCssJs: https://gerrit.wikimedia.org/r/#/c/156996/ [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/157005 [23:23:23] (03PS1) 10Ori.livneh: Update WikimediaEvents to master [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/157007 [23:23:46] (03PS1) 10Spage: Update Echo bug 70139 backport [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/157008 [23:24:17] (03CR) 10MaxSem: [C: 032 V: 032] Update Flow bug 70137 backport [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/156994 (owner: 10Spage) [23:25:33] (03CR) 10Krinkle: [C: 04-1] "This is wmf19, which already has this commit, and you're updating it to 2cdbe5c3e (which is wmf18)" [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/157005 (owner: 10MaxSem) [23:25:45] OuKB: Want me to create it? Got it locally ready [23:27:12] (03PS1) 10Krinkle: Update GlobalCssJs submodule to latest wmf/1.24wmf18 [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/157009 [23:27:14] OuKB: ^ [23:27:20] thanks [23:27:47] (03CR) 10MaxSem: [C: 032 V: 032] Update GlobalCssJs submodule to latest wmf/1.24wmf18 [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/157009 (owner: 10Krinkle) [23:27:55] (03Abandoned) 10Krinkle: GlobalCssJs: https://gerrit.wikimedia.org/r/#/c/156996/ [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/157005 (owner: 10MaxSem) [23:28:22] (03PS1) 10Ori.livneh: Update WikimediaEvents to master [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/157010 [23:29:26] MaxSem: any chance https://gerrit.wikimedia.org/r/#/c/157007/ / https://gerrit.wikimedia.org/r/157010 can piggy-back on swat? [23:31:24] (03CR) 10MaxSem: [C: 032 V: 032] Update Echo bug 70139 backport [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/157008 (owner: 10Spage) [23:32:01] 3MediaWiki / 3MediaWiki UI: neutral mw-ui-quiet anchors should lighten on hover and have no outline - 10https://bugzilla.wikimedia.org/69212#c5 (10Jon) Please swap the order shahyar as per my comment so we can get this merged. [23:34:02] 3MediaWiki / 3ResourceLoader: ResourceLoader: JsMinPlus is too memory hungry (memory leaks?) - 10https://bugzilla.wikimedia.org/29784#c13 (10Krinkle) p:5Low>3Normal s:5minor>3normal Bumping priority (since this is still affecting production if you have a large gadget or user script). Mentioning JsMi... [23:34:02] (03Abandoned) 10Cmcmahon: QA: class name locator changed [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156816 (owner: 10Cmcmahon) [23:36:18] (03PS5) 10SG: Fix malformed UTF-8 going to query profiler [core] - 10https://gerrit.wikimedia.org/r/155832 (https://bugzilla.wikimedia.org/69926) [23:36:54] (03Abandoned) 10Legoktm: Update Thanks bug 70138 backport [core] (wmf/1.24wmf19) - 10https://gerrit.wikimedia.org/r/157000 (owner: 10Spage) [23:37:15] 3MediaWiki / 3ResourceLoader: ResourceLoader: Fail more gracefully when a module name is registrated multiple times - 10https://bugzilla.wikimedia.org/31626#c3 (10Krinkle) 5NEW>3RESO/INV This is the functional equivalent of two pieces of php code in MediaWiki (e.g. core and an extension, or two extension... [23:37:16] 3MediaWiki / 3ResourceLoader: ResourceLoader: Fail more gracefully when a module name is registrated multiple times - 10https://bugzilla.wikimedia.org/31626 (10Krinkle) 5RESO/INV>3RESO/WON [23:40:15] 3MediaWiki / 3ResourceLoader: ResourceLoader: Handle bad file paths more elegantly - 10https://bugzilla.wikimedia.org/25572#c8 (10Krinkle) A regular non-load.php request no longer cascades into module contents as far as I know. I don't think it ever did, but perhaps it did (based on reading this bug). Eithe... [23:40:28] 3MediaWiki / 3ResourceLoader: ResourceLoader: Handle bad file paths more elegantly - 10https://bugzilla.wikimedia.org/25572 (10Krinkle) 5NEW>3RESO/WOR [23:44:58] 3MediaWiki / 3MediaWiki UI: Checkboxes are huge - 10https://bugzilla.wikimedia.org/70133#c5 (10Jon) Jared. I'm a little confused. Buttons and inputs are not the same height. A button had top and bottom padding of 0.5em for example and usually a font size of 1em. So that means the total height is 2em. An inpu... [23:45:33] (03PS1) 10Legoktm: Use Title::hasContentModel() instead of a direct comparison [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/157011 [23:45:59] (03PS8) 10Jdlrobson: Tweak checkbox sizes to be relative depending on where used. [core] - 10https://gerrit.wikimedia.org/r/154125 (https://bugzilla.wikimedia.org/70133) [23:46:58] 3MediaWiki / 3MediaWiki UI: Checkboxes are huge - 10https://bugzilla.wikimedia.org/70133#c6 (10Jon) (To be fair my original bug report was not clear and for that I apologise). I just wanted to track the work. Hopefully comment 5 gives more clarity. [23:50:28] 3MediaWiki / 3MediaWiki UI: Dimensions of checkboxes are defined in pixels and margins are not to spec - 10https://bugzilla.wikimedia.org/70133 (10Jon) [23:51:30] 3Wikimedia / 3Site requests: Change FlaggedRevs configuration on fa.wikipedia - 10https://bugzilla.wikimedia.org/69668 (10Calak) a:3Calak [23:52:13] 3Wikimedia / 3Site requests: Add namespace alias on ckbwiki - 10https://bugzilla.wikimedia.org/69594 (10Calak) 5PATC>3RESO/FIX [23:57:57] (03CR) 10Jaredzimmerman: "Is 1.6em (rather than 24px) the same way we're specifying the height of normal buttons and other controls?" [core] - 10https://gerrit.wikimedia.org/r/154125 (https://bugzilla.wikimedia.org/70133) (owner: 10Jdlrobson) [23:59:40] (03CR) 10Isarra: [C: 031] "Shiny." [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/156700 (owner: 10Lewis Cawte)