[00:00:21] <grrrit-wm1>	 (03CR) 10EBernhardson: [C: 032] "re-apply jdlrobson +2" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156474 (owner: 10EBernhardson)
[00:00:54] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Hygiene: Remove flow-topic-comment-count from qqq [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156474 (owner: 10EBernhardson)
[00:01:28] <grrrit-wm1>	 (03CR) 10EBernhardson: [C: 032] "re-apply jdlrobson +2" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156183 (https://bugzilla.wikimedia.org/69879) (owner: 10Bsitu)
[00:02:02] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Redirect to Flow view action when url action is set to edit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156183 (https://bugzilla.wikimedia.org/69879) (owner: 10Bsitu)
[00:03:16] <wikibugs>	 3MediaWiki extensions / 3GlobalCssJs: Links to Global CSS & JS pages in Special:Preferences should not use external link styling - 10https://bugzilla.wikimedia.org/70071 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3minor a:3None It should use interwiki link styling maybe. It's currently using WikiMap:...
[00:07:50] <grrrit-wm1>	 (03CR) 10CSteipp: [C: 031] "Anomie convinced me it's good enough" [core] - 10https://gerrit.wikimedia.org/r/156336 (owner: 10Anomie)
[00:08:51] <grrrit-wm1>	 (03CR) 10Legoktm: [C: 032] Use User::matchEditToken to compare tokens [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/156338 (owner: 10Anomie)
[00:08:56] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Use User::matchEditToken to compare tokens [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/156338 (owner: 10Anomie)
[00:09:13] <grrrit-wm1>	 (03CR) 10Jforrester: [C: 032] #wikimedia-dev: No longer report integration/* [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/156269 (owner: 10Krinkle)
[00:09:16] <grrrit-wm1>	 (03Merged) 10jenkins-bot: #wikimedia-dev: No longer report integration/* [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/156269 (owner: 10Krinkle)
[00:11:28] <wikibugs>	 3MediaWiki / 3Skin and page rendering: [MediaWiki UI] Set mw.ui.button to use non-system font-family - 10https://bugzilla.wikimedia.org/70072 (10Steven Walling)
[00:11:32] <grrrit-wm>	 (03CR) 10Jforrester: "Deployed and restarted." [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/156269 (owner: 10Krinkle)
[00:11:59] <wikibugs>	 3MediaWiki / 3Skin and page rendering: [MediaWiki UI] Set mw.ui.button to use non-system font-family - 10https://bugzilla.wikimedia.org/70072 (10Steven Walling) p:5Unprio>3Normal
[00:16:23] <grrrit-wm>	 (03PS1) 10BryanDavis: [WIP] Request a global account rename [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156488 (https://bugzilla.wikimedia.org/68886) 
[00:16:36] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Request a global account rename [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156488 (https://bugzilla.wikimedia.org/68886) (owner: 10BryanDavis)
[00:18:30] <wikibugs>	 3Wikimedia / 3General/Unknown: Add ContentHandler columns to Wikimedia wikis, and set $wgContentHandlerUseDB = true - 10https://bugzilla.wikimedia.org/49193#c6 (10spage) There have been a couple of implicit and explicit requests for this, so I added bug 63885 and bug 62780. And Flow needs it to improve the w...
[00:18:39] <wikibugs>	 3Wikimedia / 3Site requests: Please enable $wgContentHandlerUseDB at Bengali Wikisource - 10https://bugzilla.wikimedia.org/63885 (10spage)
[00:18:40] <wikibugs>	 3MediaWiki / 3Export/Import: XML import problem in Page namespace - 10https://bugzilla.wikimedia.org/62780 (10spage)
[00:20:40] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "This change seems to break the mobile edit workflow. I guess it's not backwards compatible?" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/80137 (owner: 10Werdna)
[00:21:07] <grrrit-wm>	 (03CR) 10Jdlrobson: Bring API error messages for AbuseFilter in line with standard API errors (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/80137 (owner: 10Werdna)
[00:22:09] <wikibugs>	 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c14 (10Krinkle) Hm.. so yeah, that's annoying. The condition-wrap is supposed to hide an issue in old browsers, not introduce issues in modern browsers.  So far I've o...
[00:22:40] <wikibugs>	 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c15 (10Krinkle) Open to other ideas. Of neither #1 or #2 is acceptable, we may have to remove the if-wrap for the time being since modern Firefox triumps priority over...
[00:26:24] <wikibugs>	 3MediaWiki extensions / 3TwitterCards: evaluate image handling/license compliance - 10https://bugzilla.wikimedia.org/69941#c1 (10Luis Villa (WMF Legal)) From Jared in a different bug, recording here FTR. ------------ @luis, I can think of 2 options, I don't know how possible either are…  1. modify the image,...
[00:27:21] <grrrit-wm>	 (03CR) 10Trevor Parscal: Restore external links icons (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/154350 (https://bugzilla.wikimedia.org/54604) (owner: 10Bartosz Dziewoński)
[00:32:52] <grrrit-wm>	 (03PS2) 10BryanDavis: [WIP] Request a global account rename [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156488 (https://bugzilla.wikimedia.org/68886) 
[00:34:25] <grrrit-wm>	 (03PS11) 10Jdlrobson: G3: Mobile/nojs edit and reply full topic output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156203 (owner: 10EBernhardson)
[00:34:32] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] G3: Mobile/nojs edit and reply full topic output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156203 (owner: 10EBernhardson)
[00:37:44] <grrrit-wm>	 (03PS12) 10Jdlrobson: G3: Mobile/nojs edit and reply full topic output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156203 (owner: 10EBernhardson)
[00:37:50] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] G3: Mobile/nojs edit and reply full topic output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156203 (owner: 10EBernhardson)
[00:41:01] <wikibugs>	 3MediaWiki / 3Skin and page rendering: [MediaWiki UI] Set mw.ui.button to use non-system font-family - 10https://bugzilla.wikimedia.org/70072 (10Steven Walling) 3NEW p:3Unprio s:3normal a:3None Created attachment 16287   --> https://bugzilla.wikimedia.org/attachment.cgi?id=16287&action=edit Mark all...
[00:47:16] <grrrit-wm>	 (03PS1) 10Jdlrobson: Avoid flash of unstyled content on new topic form [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156489 (https://bugzilla.wikimedia.org/69220) 
[00:47:22] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Avoid flash of unstyled content on new topic form [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156489 (https://bugzilla.wikimedia.org/69220) (owner: 10Jdlrobson)
[00:48:56] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "This has effect of hiding the textarea and buttons on the non-JS topic creation page. Doh." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156489 (https://bugzilla.wikimedia.org/69220) (owner: 10Jdlrobson)
[00:57:41] <wikibugs>	 3MediaWiki / 3API: A way to get if uploads are allowed - 10https://bugzilla.wikimedia.org/70075 (10Fabian) 3NEW p:3Unprio s:3normal a:3None On Wikidata uploads aren't allowed but I couldn't find a way to determine this via the API.  For example the siteinfo property general returns a filesize larger...
[00:58:26] <wikibugs>	 3MediaWiki / 3API: A way to get if uploads are allowed - 10https://bugzilla.wikimedia.org/70075 (10Fabian)
[01:07:11] <grrrit-wm>	 (03CR) 10Legoktm: "No new static classes please :(" (0310 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156488 (https://bugzilla.wikimedia.org/68886) (owner: 10BryanDavis)
[01:07:26] <grrrit-wm>	 (03CR) 10Legoktm: [C: 04-1] "See PS1" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156488 (https://bugzilla.wikimedia.org/68886) (owner: 10BryanDavis)
[01:20:36] <grrrit-wm>	 (03PS1) 10Jforrester: Update VisualEditor for Iaccb7d0 [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156495 
[01:21:50] <grrrit-wm>	 (03PS1) 10Jforrester: Update VisualEditor for Iaccb7d0 [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/156496 
[01:29:40] <wikibugs>	 3MediaWiki / 3Database: User::loadPasswords 400% spike on wmf db masters - 10https://bugzilla.wikimedia.org/70038#c12 (10Sean Pringle) 5ASSI>3RESO/FIX Load returned to normal immediately when Reedy did:   18:53 logmsgbot: reedy Synchronized php-1.24wmf18/extensions/MassMessage: (no message) (duration: 00...
[01:44:24] <grrrit-wm>	 (03PS2) 10Jackmcbarn: Save the original arguments array of child frames [core] - 10https://gerrit.wikimedia.org/r/156441 
[01:49:26] <grrrit-wm>	 (03CR) 10BryanDavis: "> No new static classes please :(" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156488 (https://bugzilla.wikimedia.org/68886) (owner: 10BryanDavis)
[01:55:41] <wikibugs>	 3MediaWiki / 3Parser: splitArg doesn't work on arguments from newPartNodeArray with Preprocessor_DOM - 10https://bugzilla.wikimedia.org/70067#c1 (10Jackmcbarn) 5NEW>3RESO/INV This actually doesn't appear to be the root of the problem, but rather a single portion of it (that can itself be easily worked ar...
[02:00:31] <hoo>	 legoktm: Global JS/CSS stuff is live now?
[02:01:03] <Krenair>	 yes
[02:01:26] <hoo>	 meh
[02:01:39] <hoo>	 now I need to script delete all my old pages :S
[02:02:22] <hoo>	 which is going to get people mad
[02:02:28] <grrrit-wm>	 (03PS3) 10Jackmcbarn: Expose a frame's raw arguments to Lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/156442 
[02:02:29] <hoo>	 so I think I'll rather blank them
[02:02:34] <hoo>	 *sigh*
[02:02:45] <grrrit-wm>	 (03CR) 10Jackmcbarn: "I'm happy with the output format now." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/156442 (owner: 10Jackmcbarn)
[02:02:57] <jackmcbarn>	 hoo: why would that get people mad?
[02:04:18] <hoo>	 jackmcbarn: because I deleted on their(tm) Wiki
[02:04:34] <jackmcbarn>	 hoo: so add yourself to the list of people that someone else volunteered to run script-deletes for
[02:04:41] * jackmcbarn goes to find that
[02:05:50] <jackmcbarn>	 i can't find it now. legoktm knows what i'm talking about
[02:06:06] <hoo>	 yeah, pinged him
[02:08:03] <Carmela>	 https://meta.wikimedia.org/wiki/GlobalCssJs
[02:09:14] <Carmela>	 wtf at the spaces thing.
[02:09:54] <Krenair>	 jackmcbarn, the script is being run by legoktm on a server
[02:11:49] <Krenair>	 https://meta.wikimedia.org/wiki/GlobalCssJs
[02:15:39] <Carmela>	 Echo.
[02:22:23] <grrrit-wm>	 (03PS3) 10BryanDavis: [WIP] Request a global account rename [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156488 (https://bugzilla.wikimedia.org/68886) 
[02:22:46] <grrrit-wm>	 (03CR) 10BryanDavis: [WIP] Request a global account rename (0310 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156488 (https://bugzilla.wikimedia.org/68886) (owner: 10BryanDavis)
[02:26:26] <grrrit-wm>	 (03CR) 10Spage: [C: 04-1] "Most people don't have LQT enabled so they can't test this, we'll have to set it up on flow-tests." (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (owner: 10Werdna)
[02:34:15] <wikibugs>	 3MediaWiki extensions / 3Scribunto: Order of named parameters passed to parser functions is lost - 10https://bugzilla.wikimedia.org/70077 (10Jackmcbarn) 3NEW p:3Unprio s:3normal a:3None It's impossible to convert the statement "frame:preprocess('{{#switch:' .. v .. '|red|orange=1|yellow|green=2|blue|...
[02:55:22] <grrrit-wm>	 (03PS3) 10Jackmcbarn: Save the original arguments array of child frames [core] - 10https://gerrit.wikimedia.org/r/156441 
[03:04:17] <grrrit-wm>	 (03CR) 10Lilu: [WIP] PermissionManager Recode (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156244 (owner: 10Lilu)
[03:10:22] <grrrit-wm>	 (03CR) 10Helder.wiki: "Krinkle, which bot were you referring to? I though Synchbot would solve my problem, but unfortunately Pathoschild is not a steward anymore" [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/154441 (https://bugzilla.wikimedia.org/68933) (owner: 10Legoktm)
[03:13:23] <helderwiki>	 hoo: do you still have access to Synchbot? ^
[03:13:42] <helderwiki>	 (or something similar which could delete common.js pages everywhere?)
[03:13:55] <hoo>	 helderwiki: Well, I have access to Legoktm's migration script
[03:13:58] <hoo>	 and just ran it for me
[03:14:35] <helderwiki>	 yeah, but it doesn't support global scripts loaded from pt.wikibooks.org
[03:15:04] <hoo>	 mh, what do you mean with support?
[03:15:18] <helderwiki>	 it is restricted to meta
[03:16:24] <helderwiki>	 Line 157 here: https://gerrit.wikimedia.org/r/#/c/154441/6/removeOldManualUserPages.php,unified
[03:16:59] <hoo>	 helderwiki: Ah, I see
[03:17:26] <hoo>	 I hacked the version of the script I used anyway, because my name contains spaces and many of my .js pages have two or more revisions
[03:17:38] <hoo>	 (migration to proto-relative URLs and stuff)
[03:20:06] <Krenair>	 What's this issue with spaces in names?
[03:20:41] <helderwiki>	 URLs uses _, and the script probably uses the name with spaces
[03:21:04] <grrrit-wm>	 (03CR) 10Lilu: [WIP] PermissionManager Recode (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156244 (owner: 10Lilu)
[03:21:43] <Krenair>	 So str_replace( " ", "_" ) ?
[03:22:02] <helderwiki>	 yep, something like that
[03:22:05] <helderwiki>	 I think
[03:22:40] <wikibugs>	 3Wikimedia / 3General/Unknown: Resource loader ignores requested caching directives / not caching properly - 10https://bugzilla.wikimedia.org/69460#c7 (10metatron) If this is caused by this lines (as Michael M. stated):  sub vcl_deliver {    /* Override the Cache-Control header for wiki content pages */    i...
[03:23:43] <hoo>	 Krenair: Actually you probably want to match for +, %20 and _, I guess
[03:24:05] <hoo>	 not sure about the +, but wont really harm either
[03:36:39] <wikibugs>	 3Wikimedia / 3General/Unknown: Add ContentHandler columns to Wikimedia wikis, and set $wgContentHandlerUseDB = true - 10https://bugzilla.wikimedia.org/49193#c7 (10Kunal Mehta (Legoktm)) $wgContentHandlerUseDB is already set to true on testwikidatawiki and wikidatawiki, so I think we can just turn it on once...
[04:00:49] <legoktm>	 hi
[04:01:01] <legoktm>	 yeah, issue with spaces is that people had used them differently
[04:01:08] <legoktm>	 some had _, others just used " "
[04:02:59] <grrrit-wm>	 (03PS1) 10Legoktm: Better support usernames with spaces in them [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/156497 
[04:05:22] <legoktm>	 hoo: ^
[04:06:45] <hoo>	 legoktm: Isn't %20 also valid
[04:06:48] <hoo>	 or wont that work
[04:06:53] <hoo>	 and what about +?
[04:07:03] * legoktm tests
[04:08:10] <hoo>	 and I think you want ['|\"] instead of ('|\")
[04:09:04] <legoktm>	 er, no
[04:09:12] <legoktm>	 well
[04:09:27] <legoktm>	 I could use ['\"]
[04:09:30] <legoktm>	 both work really
[04:09:40] <legoktm>	 + and %20 both work
[04:10:58] <hoo>	 legoktm: Ok, so also grep for + and %20
[04:11:08] <legoktm>	 I'll just add it in
[04:11:13] <hoo>	 yep
[04:11:19] <hoo>	 can approve then, I guess
[04:11:39] <wikibugs>	 3MediaWiki extensions / 3TwitterCards: evaluate image handling/license compliance - 10https://bugzilla.wikimedia.org/69941#c2 (10Isarra) I don't really see 1 working. A big thing on Commons is to provide high-quality clean images, and it's a significant project there removing watermarks from images where leg...
[04:13:31] <grrrit-wm>	 (03PS2) 10Legoktm: Better support usernames with spaces in them [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/156497 
[04:13:43] <legoktm>	 hoo: ^
[04:16:01] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] Better support usernames with spaces in them [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/156497 (owner: 10Legoktm)
[04:16:02] <hoo>	 Nice one :)
[04:16:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: Better support usernames with spaces in them [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/156497 (owner: 10Legoktm)
[04:16:30] <hoo>	 do you want to backport or are you just running it from your home
[04:16:37] <legoktm>	 just running from my home
[04:16:43] <hoo>	 ah ok
[04:16:57] <legoktm>	 I also have a hack to hardcode the english messages because the i18n hasn't been deployed yet
[04:18:32] <hoo>	 I just stole your version and modified it slightly for my uses :P
[04:48:43] <grrrit-wm>	 (03CR) 10Isarra: Cleanup special:interwiki intro (some more) (031 comment) [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/156190 (owner: 10Isarra)
[04:53:01] <grrrit-wm>	 (03CR) 10Isarra: Add support for enabling and displaying global interwikis (031 comment) [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/147755 (https://bugzilla.wikimedia.org/68241) (owner: 10Isarra)
[04:53:05] <grrrit-wm>	 (03CR) 10Greg Grossmeier: "Re deployment: Check with Sean (just added to reviewer list) on the sql updates and how he wants to manage that." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136280 (https://bugzilla.wikimedia.org/65915) (owner: 10Werdna)
[04:57:28] <grrrit-wm>	 (03CR) 10BryanDavis: [C: 04-1 V: 04-1] "Using ::browsertests::enabled doesn't work. Hiera says:" [vagrant] - 10https://gerrit.wikimedia.org/r/156383 (owner: 10Dduvall)
[05:00:45] <grrrit-wm>	 (03PS3) 10BryanDavis: Default for provisioning of extension browser tests [vagrant] - 10https://gerrit.wikimedia.org/r/156383 (owner: 10Dduvall)
[05:02:38] <grrrit-wm>	 (03PS4) 10BryanDavis: Default for provisioning of extension browser tests [vagrant] - 10https://gerrit.wikimedia.org/r/156383 (owner: 10Dduvall)
[05:05:10] <grrrit-wm>	 (03CR) 10BryanDavis: [C: 031 V: 031] "Tested locally:" [vagrant] - 10https://gerrit.wikimedia.org/r/156383 (owner: 10Dduvall)
[05:14:09] <wikibugs>	 3MediaWiki extensions / 3TwitterCards: evaluate image handling/license compliance - 10https://bugzilla.wikimedia.org/69941#c3 (10Kunal Mehta (Legoktm)) (In reply to Luis Villa (WMF Legal) from comment #0) > As a general matter, under US law (and the extensive precedents set by > Google), text snippets and im...
[05:16:09] <wikibugs>	 3MediaWiki extensions / 3TwitterCards: evaluate image handling/license compliance - 10https://bugzilla.wikimedia.org/69941#c4 (10Kunal Mehta (Legoktm)) Created attachment 16289   --> https://bugzilla.wikimedia.org/attachment.cgi?id=16289&action=edit Example of current twittercard  Screenshot of TwitterCard o...
[05:33:08] <grrrit-wm>	 (03PS1) 10Wctaiwan: Add tests to Database group [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/156498 
[05:33:39] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add tests to Database group [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/156498 (owner: 10Wctaiwan)
[05:37:37] <grrrit-wm>	 (03PS2) 10Wctaiwan: Add tests to Database group [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/156498 
[05:41:40] <grrrit-wm>	 (03CR) 10Wctaiwan: "This can probably be merged?" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/152077 (owner: 10Legoktm)
[06:00:54] <grrrit-wm>	 (03PS1) 10Prtksxna: Translations for French [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/156499 
[06:02:02] <grrrit-wm>	 (03CR) 10Siebrand: Add support for enabling and displaying global interwikis (031 comment) [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/147755 (https://bugzilla.wikimedia.org/68241) (owner: 10Isarra)
[06:02:21] <grrrit-wm>	 (03CR) 10Nemo bis: "Where is the attribution to the author of the translation?" [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/156499 (owner: 10Prtksxna)
[06:02:31] <grrrit-wm>	 (03CR) 10Gilles: [C: 032] PHP Notice: Undefined index: contributors (031 comment) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/156248 (https://bugzilla.wikimedia.org/70024) (owner: 10Dan-nl)
[06:02:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: PHP Notice: Undefined index: contributors [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/156248 (https://bugzilla.wikimedia.org/70024) (owner: 10Dan-nl)
[06:03:09] <prtksxna>	 Nemo_bis: Do paid translators need to be attributed too? If so, I'll ask the legal team to send me the details.
[06:03:36] <Nemo_bis>	 prtksxna: depends on the contract
[06:03:57] <prtksxna>	 Nemo_bis: Alright, I'll drop them a line then. Thanks!
[06:04:07] <Nemo_bis>	 probably they transferred copyright, in which case you can write that it's (c) WMF
[06:04:59] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156096 (owner: 10Matthias Mullie)
[06:05:56] <wikibugs>	 3MediaWiki extensions / 3ApiSandbox: Warning:  sort() expects parameter 1 to be array, string given in SpecialApiSandbox.php on line 133 - 10https://bugzilla.wikimedia.org/69872#c1 (10wctaiwan) Possibly caused by https://gerrit.wikimedia.org/r/#/c/154147/
[06:07:10] <grrrit-wm>	 (03PS2) 10Isarra: Cleanup special:interwiki intro (some more) [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/156190 
[06:16:53] <grrrit-wm>	 (03PS1) 10Wctaiwan: Fix retrieval of query modules [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/156500 (https://bugzilla.wikimedia.org/69872) 
[06:21:02] <grrrit-wm>	 (03CR) 10Gilles: [C: 04-1] Add some flow events for funnel logging (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/144588 (owner: 10Gergő Tisza)
[06:24:55] <grrrit-wm>	 (03PS3) 10Isarra: Cleanup special:interwiki intro (some more) [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/156190 
[06:26:51] <grrrit-wm>	 (03PS4) 10Isarra: Cleanup special:interwiki intro (some more) [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/156190 
[06:32:26] <grrrit-wm>	 (03CR) 10Gilles: [C: 04-1] Redirect on all template calls (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152817 (https://bugzilla.wikimedia.org/69217) (owner: 10MarkTraceur)
[06:37:01] <grrrit-wm>	 (03CR) 10Gilles: [C: 032] Remove more unused code in mw.UploadWizard.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153717 (owner: 10MarkTraceur)
[06:37:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove more unused code in mw.UploadWizard.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153717 (owner: 10MarkTraceur)
[06:41:14] <wikibugs>	 3Wikimedia / 3Media storage: 404 errors after renaming files - 10https://bugzilla.wikimedia.org/70079 (10Steinsplitter) 3NEW p:3Unprio s:3normal a:3None In the process of renaming files to improve titles, four of them somehow became unviewable, in which the image doesn't display and when clicking the...
[06:46:31] <wikibugs>	 3MediaWiki extensions / 3TwitterCards: evaluate image handling/license compliance - 10https://bugzilla.wikimedia.org/69941#c5 (10Jared Zimmerman (WMF)) Issara you are totally right, I wasn't proposing that the watermark cover the image area, rather than we append a black or white stripe to the bottom of the...
[06:52:17] <wikibugs>	 3MediaWiki extensions / 3Interwiki (extension): Clean up inconsistent _ vs - formatting across i18n message keys - 10https://bugzilla.wikimedia.org/70080 (10Isarra) 3NEW p:3Unprio s:3normal a:3X! Currently old message keys use underscores and newer ones use hyphens. This has resulted in a horrible mi...
[06:53:10] <wikibugs>	 3MediaWiki extensions / 3Interwiki (extension): Clean up inconsistent _ vs - formatting across i18n message keys - 10https://bugzilla.wikimedia.org/70080#c1 (10Isarra) This sort of thing seems like it would have come up before - have any of the conversion steps been automated?
[06:53:50] <grrrit-wm>	 (03CR) 10Nikerabbit: Translations for French (031 comment) [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/156499 (owner: 10Prtksxna)
[06:59:07] <grrrit-wm>	 (03CR) 10Gilles: Add model base class, description model (035 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/121308 (owner: 10MarkTraceur)
[07:03:10] <wikibugs>	 3MediaWiki extensions / 3Interwiki (extension): Clean up inconsistent _ vs - formatting across i18n message keys - 10https://bugzilla.wikimedia.org/70080 (10Siebrand Mazeland) p:5Unprio>3Low s:5normal>3trivia
[07:07:24] <grrrit-wm>	 (03CR) 10Petrb: PostgreSQL: Fix Installer (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156350 (https://bugzilla.wikimedia.org/70030) (owner: 10Jjanes)
[07:09:46] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] "Arr, you beat me to it! :P" [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/156500 (https://bugzilla.wikimedia.org/69872) (owner: 10Wctaiwan)
[07:09:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix retrieval of query modules [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/156500 (https://bugzilla.wikimedia.org/69872) (owner: 10Wctaiwan)
[07:10:22] <grrrit-wm>	 (03PS1) 10MaxSem: Fix retrieval of query modules [extensions/ApiSandbox] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156502 (https://bugzilla.wikimedia.org/69872) 
[07:10:24] <wikibugs>	 3MediaWiki extensions / 3Interwiki (extension): Clean up inconsistent _ vs - formatting across i18n message keys - 10https://bugzilla.wikimedia.org/70080#c2 (10Niklas Laxström) Trying to fix message names en masse brings lot of disruption with little benefit. Don't forget that these messages can be customize...
[07:10:37] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Fix retrieval of query modules [extensions/ApiSandbox] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156502 (https://bugzilla.wikimedia.org/69872) (owner: 10MaxSem)
[07:10:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix retrieval of query modules [extensions/ApiSandbox] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156502 (https://bugzilla.wikimedia.org/69872) (owner: 10MaxSem)
[07:19:45] <grrrit-wm>	 (03PS8) 10Isarra: Add support for enabling and displaying global interwikis [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/147755 (https://bugzilla.wikimedia.org/68241) 
[07:21:07] <grrrit-wm>	 (03CR) 10Isarra: "Fixed the new message keys and added a default message for the interlanguage description to explain what the crap interlanguage links are." [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/147755 (https://bugzilla.wikimedia.org/68241) (owner: 10Isarra)
[07:31:06] <grrrit-wm>	 (03CR) 10Gilles: [C: 04-1] Add controllers for each step - mostly stubs (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151699 (owner: 10MarkTraceur)
[07:32:09] <grrrit-wm>	 (03PS1) 10MaxSem: ApiSandbox: pick https://gerrit.wikimedia.org/r/#/c/156500/ [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156503 
[07:34:39] <wikibugs>	 3MediaWiki extensions / 3ApiSandbox: Warning:  sort() expects parameter 1 to be array, string given in SpecialApiSandbox.php on line 133 - 10https://bugzilla.wikimedia.org/69872 (10Max Semenik) 5PATC>3RESO/FIX
[07:40:12] <grrrit-wm>	 (03CR) 10Gilles: [C: 04-1] Make tutorial step a controller and UI class (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 (owner: 10MarkTraceur)
[07:52:09] <wikibugs>	 3MediaWiki extensions / 3Interwiki (extension): Clean up inconsistent _ vs - formatting across i18n message keys - 10https://bugzilla.wikimedia.org/70080#c3 (10Nemo) 5NEW>3RESO/WON Long-standing practice is not to touch message keys unless there are compelling reasons and concrete benefits; closing to re...
[08:03:36] <grrrit-wm>	 (03CR) 10Smuggli: [C: 032 V: 032] i18n: fix message key [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156460 (owner: 10Shirayuki)
[08:04:14] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: wbgetentities should default to ungrouped output - 10https://bugzilla.wikimedia.org/70081 (10Lydia Pintscher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs We unintentionally broke the API with yesterday's deployment. wbgetentities output is grouped by property now....
[08:06:43] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: the output of wbgetentities switched from name to title - 10https://bugzilla.wikimedia.org/70082 (10Lydia Pintscher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs We unintentionally changed the output of wbgetentities. Previously it said "name" and since the last de...
[08:06:54] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: wbgetentities should default to ungrouped output - 10https://bugzilla.wikimedia.org/70081#c1 (10Daniel Kinzler) To clarify: the API was *supposed* to return grouped output for a long time, we introduced the option "ungroupedlist" for disabling this in january. But appar...
[08:22:40] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: the output of wbgetentities switched from name to title - 10https://bugzilla.wikimedia.org/70082 (10Lydia Pintscher) 5NEW>3ASSI p:5Unprio>3Immedi s:5normal>3blocke
[08:22:41] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: wbgetentities should default to ungrouped output - 10https://bugzilla.wikimedia.org/70081 (10Lydia Pintscher) p:5Unprio>3Immedi s:5normal>3blocke
[08:22:42] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: the output of wbgetentities switched from name to title - 10https://bugzilla.wikimedia.org/70082#c1 (10Daniel Kinzler) to clarify: the accidental switch to "title" is in the representation of sitelinks.
[08:22:44] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: wbgetentities should default to ungrouped output - 10https://bugzilla.wikimedia.org/70081 (10Lydia Pintscher) 5NEW>3ASSI
[08:23:10] <wikibugs>	 3MediaWiki / 3General/Unknown: Prettify permalinks - 10https://bugzilla.wikimedia.org/16659#c21 (10TeleComNasSprVen) Okay, why can't we have Apache internally rewrite https://hi.wikipedia.org/revision/188492 into https://hi.wikipedia.org/w/index.php?oldid=188492 and have MediaWiki interpret it as a GET reque...
[08:30:27] <wikibugs>	 3MediaWiki / 3Maintenance scripts: changePassword.php does not work for Usernames containing umlauts (ß, ö, ü, ä) - 10https://bugzilla.wikimedia.org/42067#c6 (10carchaias) 5UNCO>3RESO/FIX I tested again in 1.23 and there are no problems with this any more.
[08:32:09] <wikibugs>	 3MediaWiki / 3User preferences: Timezone of Windows/XAMPP server not set as default for users - 10https://bugzilla.wikimedia.org/70032#c2 (10Tony Mach) OK, I made one mistake in the bug-description: The debug output needs to be at the end of Setup.php to output the values as above. (I moved the code to Local...
[08:32:39] <wikibugs>	 3Wikimedia / 3Wikidata: https://test.wikidata.org/wiki/Special:Version is unavailable - 10https://bugzilla.wikimedia.org/69586 (10Lydia Pintscher) 5NEW>3RESO/FIX
[08:33:27] <wikibugs>	 3Wikimedia / 3Wikidata: https://test.wikidata.org/wiki/Special:Version is unavailable - 10https://bugzilla.wikimedia.org/69586 (10Lydia Pintscher)
[08:34:28] <wikibugs>	 3MediaWiki / 3User preferences: Timezone of Windows/XAMPP server not set as default for users - 10https://bugzilla.wikimedia.org/70032#c3 (10Tony Mach) One more thing: PHP/5.5.6 on Windows Server 2012  - and - PHP/5.5.11 on Windows 7 SP1
[08:44:30] <wikibugs>	 3MediaWiki / 3General/Unknown: Prettify permalinks - 10https://bugzilla.wikimedia.org/16659#c22 (10Daniel Friesen) (In reply to TeleComNasSprVen from comment #21) > Okay, why can't we have Apache internally rewrite > https://hi.wikipedia.org/revision/188492 into > https://hi.wikipedia.org/w/index.php?oldid=1...
[08:48:58] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/156190 (owner: 10Isarra)
[08:49:36] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/147755 (https://bugzilla.wikimedia.org/68241) (owner: 10Isarra)
[08:50:44] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156488 (https://bugzilla.wikimedia.org/68886) (owner: 10BryanDavis)
[08:53:31] <grrrit-wm>	 (03PS1) 10Legoktm: Refactor GadgetRepo inheritance and construction [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/156508 
[08:53:42] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Refactor GadgetRepo inheritance and construction [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/156508 (owner: 10Legoktm)
[08:59:10] <grrrit-wm>	 (03PS2) 10Legoktm: Refactor GadgetRepo inheritance and construction [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/156508 
[09:02:05] <grrrit-wm>	 (03CR) 10Siebrand: "Are there SVG/highres images available for these? If not, should a bug be opened?" [core] - 10https://gerrit.wikimedia.org/r/155910 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński)
[09:04:38] <grrrit-wm>	 (03PS1) 10Legoktm: Remove ALL the trailing whitespace! [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/156509 
[09:04:44] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remove ALL the trailing whitespace! [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/156509 (owner: 10Legoktm)
[09:05:36] <grrrit-wm>	 (03CR) 10Legoktm: "Ignore jenkins-bot, touching the js files caused it to run jslint, which is still failing." [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/156509 (owner: 10Legoktm)
[09:12:18] <grrrit-wm>	 (03PS3) 10Legoktm: Refactor GadgetRepo inheritance and construction [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/156508 
[09:17:29] <grrrit-wm>	 (03PS1) 10Shirayuki: i18n: add Special:MyLanguage [extensions/PhpTagsSMW] - 10https://gerrit.wikimedia.org/r/156511 
[09:23:25] <grrrit-wm>	 (03PS1) 10Dan-nl: Check API Page Index for Missing [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/156512 
[09:23:35] <grrrit-wm>	 (03PS1) 10Legoktm: Store $wgMemc as an instance variable in CachedGadgetRepo [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/156513 
[09:25:34] <grrrit-wm>	 (03CR) 10Dan-nl: "responded to comment in ps1" (031 comment) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/156248 (https://bugzilla.wikimedia.org/70024) (owner: 10Dan-nl)
[09:26:10] <wikibugs>	 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c16 (10Michael M.) What about only wrapping the  mw.loader.state({"user":"ready"}); at the bottom in an if-clause (or prefixing it with window.mw && ) and leaving the...
[09:29:35] <grrrit-wm>	 (03PS2) 10Dan-nl: Check API Page Index for Missing [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/156512 
[09:33:26] <grrrit-wm>	 (03PS1) 10Pastakhov: add addon active line and set size as textarea (v 1.7.1) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156514 
[09:33:34] <grrrit-wm>	 (03CR) 10Gergő Tisza: "> Don't we have a separate card for logStash-ing client side errors?" (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/144588 (owner: 10Gergő Tisza)
[09:35:59] <grrrit-wm>	 (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Most basic classes should have this, especially this one. Improvements are always possible but can not be a reason to block such patches. " (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156446 (owner: 10saper)
[09:39:09] <wikibugs>	 3MediaWiki / 3Skin and page rendering: Mediawiki UI shouldn't change font-family for textareas - 10https://bugzilla.wikimedia.org/70028#c3 (10Michael M.) I actually like the .mw-ui-input style for <textarea>s, as you can easily recognize where the focus is. I don't know how many times I tried to select/paste...
[09:40:03] <grrrit-wm>	 (03CR) 10Pastakhov: [C: 032] add addon active line and set size as textarea (v 1.7.1) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156514 (owner: 10Pastakhov)
[09:40:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: add addon active line and set size as textarea (v 1.7.1) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156514 (owner: 10Pastakhov)
[09:44:39] <wikibugs>	 3MediaWiki / 3Skin and page rendering: Mediawiki UI shouldn't change font-family for textareas - 10https://bugzilla.wikimedia.org/70028#c4 (10Derk-Jan Hartman) past experience shows that people are all but agnostic about font type on the wikieditor screen :)
[09:45:09] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: the output of wbgetentities switched from name to title - 10https://bugzilla.wikimedia.org/70082#c2 (10Daniel Kinzler) Seems like there is some confusion here: the API output didn't change, we didn't touch the serializers for the API output at all (this is scheduled for...
[09:45:10] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: wbgetentities should default to ungrouped output - 10https://bugzilla.wikimedia.org/70081#c4 (10Daniel Kinzler) Seems like there is some confusion here: the API output didn't change, we didn't touch the serializers for the API output at all (this is scheduled for the ne...
[09:46:24] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: [DM 1.0 compat] Fix ChangeOpsMergeTest errors - 10https://bugzilla.wikimedia.org/70044#c2 (10Jeroen De Dauw) That difference is caused by a recent change to DataModel. Guess the test is adding a Claim to an Item.
[09:47:48] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 031] "Looks good at a first glance. Did not test or poke at it." [core] - 10https://gerrit.wikimedia.org/r/154447 (owner: 10Legoktm)
[09:51:32] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] i18n: add Special:MyLanguage [extensions/PhpTagsSMW] - 10https://gerrit.wikimedia.org/r/156511 (owner: 10Shirayuki)
[09:51:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: i18n: add Special:MyLanguage [extensions/PhpTagsSMW] - 10https://gerrit.wikimedia.org/r/156511 (owner: 10Shirayuki)
[09:52:32] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032 V: 032] Remove ALL the trailing whitespace! [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/156509 (owner: 10Legoktm)
[09:54:15] <legoktm>	 thanks siebrand :)
[09:54:18] * legoktm rebases everything
[09:56:54] <grrrit-wm>	 (03PS5) 10Legoktm: Refactor Gadget constructor [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154750 (https://bugzilla.wikimedia.org/69368) 
[09:56:56] <grrrit-wm>	 (03PS3) 10Legoktm: Add a test for Gadget::__construct [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154751 
[09:57:15] <grrrit-wm>	 (03CR) 10Legoktm: "PS5: Rebase" [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154750 (https://bugzilla.wikimedia.org/69368) (owner: 10Legoktm)
[09:57:30] <grrrit-wm>	 (03CR) 10Legoktm: "PS3: Rebase" [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154751 (owner: 10Legoktm)
[10:01:49] <grrrit-wm>	 (03PS8) 10Legoktm: SpecialRunJobs: Use Config instead of global [core] - 10https://gerrit.wikimedia.org/r/152114 (https://bugzilla.wikimedia.org/69187) (owner: 10Florianschmidtwelzow)
[10:01:55] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: [DM 1.0 compat] Fix RemoveClaimsTest failure - 10https://bugzilla.wikimedia.org/70041 (10Thiemo Mättig) 5PATC>3RESO/FIX
[10:02:42] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: edit summary for redirects has missing parameter - 10https://bugzilla.wikimedia.org/69750 (10Thiemo Mättig) 5PATC>3RESO/FIX
[10:05:09] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] Add tests for GadgetDefinitionContent (031 comment) [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/155690 (owner: 10Legoktm)
[10:05:15] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add tests for GadgetDefinitionContent [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/155690 (owner: 10Legoktm)
[10:06:36] <grrrit-wm>	 (03PS1) 10Legoktm: Rename $result --> $expected since that's what it is [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/156517 
[10:06:42] <grrrit-wm>	 (03PS1) 10Divec: translateAnnotations with partial mapping [services/cxserver] - 10https://gerrit.wikimedia.org/r/156518 
[10:06:43] <legoktm>	 addshore: ^ :)
[10:06:53] <addshore>	 :>
[10:07:04] <grrrit-wm>	 (03CR) 10Legoktm: Add tests for GadgetDefinitionContent (031 comment) [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/155690 (owner: 10Legoktm)
[10:07:17] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] Rename $result --> $expected since that's what it is [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/156517 (owner: 10Legoktm)
[10:07:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Rename $result --> $expected since that's what it is [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/156517 (owner: 10Legoktm)
[10:07:45] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] translateAnnotations with partial mapping [services/cxserver] - 10https://gerrit.wikimedia.org/r/156518 (owner: 10Divec)
[10:09:33] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] SpecialRunJobs: Use Config instead of global [core] - 10https://gerrit.wikimedia.org/r/152114 (https://bugzilla.wikimedia.org/69187) (owner: 10Florianschmidtwelzow)
[10:12:06] <grrrit-wm>	 (03CR) 10Matthias Mullie: Fix Flow entries in Special:EditWatchlist (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156121 (owner: 10Matthias Mullie)
[10:15:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: SpecialRunJobs: Use Config instead of global [core] - 10https://gerrit.wikimedia.org/r/152114 (https://bugzilla.wikimedia.org/69187) (owner: 10Florianschmidtwelzow)
[10:19:19] <grrrit-wm>	 (03PS2) 10Divec: translateAnnotations with partial mapping [services/cxserver] - 10https://gerrit.wikimedia.org/r/156518 
[10:20:11] <grrrit-wm>	 (03PS1) 10Mazzax6: added black to friday as a test. [extensions/examples] - 10https://gerrit.wikimedia.org/r/156520 
[10:20:13] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] translateAnnotations with partial mapping [services/cxserver] - 10https://gerrit.wikimedia.org/r/156518 (owner: 10Divec)
[10:22:02] <grrrit-wm>	 (03PS3) 10Divec: translateAnnotations with partial mapping [services/cxserver] - 10https://gerrit.wikimedia.org/r/156518 
[10:31:25] <wikibugs>	 3MediaWiki / 3JobQueue: SpecialRunJobs: Use Config instead of globals - 10https://bugzilla.wikimedia.org/69187 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3Florian
[10:38:38] <grrrit-wm>	 (03CR) 10Legoktm: [C: 04-1] SpecialUpload: Use Config instead of global (031 comment) [core] - 10https://gerrit.wikimedia.org/r/152134 (https://bugzilla.wikimedia.org/69188) (owner: 10Florianschmidtwelzow)
[10:47:41] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Use descriptive key for array of in a Special:EditWatchlist line [core] - 10https://gerrit.wikimedia.org/r/156522 
[10:51:44] <grrrit-wm>	 (03PS3) 10Matthias Mullie: Fix Flow entries in Special:EditWatchlist [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156121 
[11:10:54] <wikibugs>	 3Wikimedia / 3Media storage: 404 errors after renaming specific files on Commons - 10https://bugzilla.wikimedia.org/70079#c1 (10Andre Klapper) p:5Unprio>3Normal Broken thumbnails: https://commons.wikimedia.org/wiki/File:Pizza_%287%29.jpg https://commons.wikimedia.org/wiki/File:Chimichangas.jpg  Error gen...
[11:14:25] <grrrit-wm>	 (03PS2) 10Prtksxna: Translations for French [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/156499 
[11:14:41] <grrrit-wm>	 (03CR) 10Prtksxna: Translations for French (031 comment) [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/156499 (owner: 10Prtksxna)
[11:23:54] <wikibugs>	 3MediaWiki / 3API: A way to get if uploads are allowed - 10https://bugzilla.wikimedia.org/70075 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc
[11:36:11] <wikibugs>	 3MediaWiki / 3Installer: Clean up list of default interwikis - 10https://bugzilla.wikimedia.org/69997#c3 (10This, that and the other (TTO)) It should be synced with [[m:Interwiki map]], with WMF-specific links removed. There was a discussion on wikitech-l about this a while ago.  Also, interwiki.sql should b...
[11:38:28] <wikibugs>	 3MediaWiki / 3ResourceLoader: ResourceLoader cache not properly fixable after moving MediaWiki - 10https://bugzilla.wikimedia.org/35472 (10Andre Klapper)
[11:40:09] <wikibugs>	 3MediaWiki / 3Installer: Clean up list of default interwikis - 10https://bugzilla.wikimedia.org/69997#c4 (10This, that and the other (TTO)) (In reply to Isarra from comment #0) > even some that don't even go > anywhere anymore because the target sites no longer exist.  These should all have been removed, but...
[11:41:09] <wikibugs>	 3MediaWiki extensions / 3SemanticResultFormats: Ploticus: Create Special page showing Semantic Statistics using plots/charts - 10https://bugzilla.wikimedia.org/17589#c1 (10Andre Klapper) p:5Normal>3Low [I assume this is low priority after five years of no updates here, hence dropping.]
[11:46:24] <wikibugs>	 3MediaWiki / 3Maintenance scripts: deleteOldRevisions.php deletes content text from current revisions - 10https://bugzilla.wikimedia.org/66615#c14 (10sen) that's very very wired...it could be my server problem?i will try to do a test on my server again,very thank you for the test,that's my first time use thi...
[11:46:54] <wikibugs>	 3MediaWiki / 3ResourceLoader: ResourceLoader didn't invalidate cached CSS correctly for Extension:CategoryTree change - 10https://bugzilla.wikimedia.org/55334 (10Andre Klapper) p:5High>3Normal
[11:51:25] <wikibugs>	 3MediaWiki / 3General/Unknown: Synchronize css/js caching - 10https://bugzilla.wikimedia.org/17821#c1 (10Andre Klapper) Related:  * bug 34779: add timestamp near cache key (JS/CSS minify) * bug 26338: Wikimedia JS/CSS files get an extra max-age cache-control param
[11:51:40] <wikibugs>	 3MediaWiki / 3ResourceLoader: add timestamp near cache key (JS/CSS minify) - 10https://bugzilla.wikimedia.org/34779 (10Andre Klapper)
[11:51:42] <wikibugs>	 3Wikimedia / 3General/Unknown: Wikimedia Javascript and CSS files are getting an extra max-age cache-control param - 10https://bugzilla.wikimedia.org/26338 (10Andre Klapper)
[11:52:54] <wikibugs>	 3MediaWiki extensions / 3ParserFunctions: including text elsewhere on the page - 10https://bugzilla.wikimedia.org/17757#c1 (10Andre Klapper) p:5Low>3Lowest Hi Andre! Sorry that nobody has taken a look at this report yet and given feedback.  How relevant is this nowadays? On which screen sizes there are p...
[11:59:24] <wikibugs>	 3MediaWiki / 3Watchlist: Log entries on the Watchlist should have css classes - 10https://bugzilla.wikimedia.org/17666#c1 (10Andre Klapper) Still valid in 1.24. Potentially related: On mw-changeslist each line is a table on its own (<table>) while in Watchlist they are list items (<li>).
[12:05:51] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: date in claim diff formatted as timestamp - 10https://bugzilla.wikimedia.org/70086 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs the date is formatted as a timestamp in this diff: (happens also on master)  https://www.wikidata.org/w/index.php?title=Q4913200...
[12:08:24] <wikibugs>	 3MediaWiki / 3History/Diffs: Size limit for revision and diff displays (for slow connections) - 10https://bugzilla.wikimedia.org/17697#c1 (10Andre Klapper) p:5Low>3Lowest But which size limit sounds feasible? I don't see how to define "slow" in a way that works for everybody - your slow might not be my s...
[12:10:04] <grrrit-wm>	 (03PS3) 10Prtksxna: Translations for French [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/156499 
[12:17:54] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: not possible to switch to Julian calendar model - 10https://bugzilla.wikimedia.org/65847#c5 (10WikidataBugzilla) Commit pushed to fix-calendar-switch at https://github.com/wmde/ValueView  https://github.com/wmde/ValueView/commit/eb2f8eff1fa5a824da0ec4b2ecb102a12b19371d...
[12:31:39] <wikibugs>	 3MediaWiki / 3Page deletion: Implement ability to get page title of a deleted revision by its rev_id (and use it!) - 10https://bugzilla.wikimedia.org/23489#c5 (10Helder) See also recent discussion on https://en.wikipedia.org/wiki/WP:Village_pump_%28technical%29/Archive_129#Special_Diff
[12:42:55] <Krenair>	 <rc-pmtpa> [[Special:Log/gblrename]] rename  * DerHexer *  DerHexer globally renamed <a href="/wiki/Special:CentralAuth/Vcbaustetten" title="Special:CentralAuth/Vcbaustetten">Vcbaustetten</a> to <a href="/wiki/Special:CentralAuth/Holztest09" title="Special:CentralAuth/Holztest09">Holztest09</a>: Per [[:m:Special:Permalink/9661101|:m:SRUC]]
[12:42:58] <Krenair>	 legoktm, is this known?
[12:43:22] <Carmela>	 Ouch.
[12:43:32] <Carmela>	 Translate used to do that, I think.
[12:43:47] <Krenair>	 A few extensions have done that
[12:45:39] <wikibugs>	 3MediaWiki / 3Special pages: More Special pages need a "last" link (as in (first | last)) in the pagination footer - 10https://bugzilla.wikimedia.org/17798#c1 (10Andre Klapper) Also see bug 11269 comment 3
[12:46:37] <Krenair>	 oh, it's https://bugzilla.wikimedia.org/show_bug.cgi?id=69768 Carmela 
[12:56:02] <grrrit-wm>	 (03CR) 10Matthias Mullie: Fix Flow entries in Special:EditWatchlist (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156121 (owner: 10Matthias Mullie)
[12:58:06] <grrrit-wm>	 (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT).. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/70205 (owner: 10Hashar)
[12:58:09] <grrrit-wm>	 (03PS9) 10Hashar: Jenkins job validation (DO NOT SUBMIT).. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/70205 
[12:58:16] <grrrit-wm>	 (03CR) 10Hashar: "check experimental" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/70205 (owner: 10Hashar)
[13:10:26] <wikibugs>	 3MediaWiki extensions / 3ApiSandbox: [regression] On 1.24wmf18, the list of queries is empty - 10https://bugzilla.wikimedia.org/70091 (10Helder) 3NEW p:3Unprio s:3major a:3None 1.24wmf18: https://www.mediawiki.org/wiki/Special:ApiSandbox#action=query   Lists   Properties   Meta information  1.24wmf17...
[13:11:55] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 04-1] "Hmm... I think we should either ditch the 'Special:CentralAuth/' part of it (for the feed only of course), or put the titles in '[['." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/155625 (https://bugzilla.wikimedia.org/69768) (owner: 10Legoktm)
[13:14:39] <wikibugs>	 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c17 (10Krinkle) Alternatively, we might be able to do the condition outside the script. Perhaps something like replace this:  <script src="./load.php?modules=user&only...
[13:17:41] <grrrit-wm>	 (03PS2) 10Mazzax6: added black to friday as a test. then I added grey to thurs. [extensions/examples] - 10https://gerrit.wikimedia.org/r/156520 
[13:17:54] <wikibugs>	 3MediaWiki extensions / 3ApiSandbox: [regression] On 1.24wmf18, the list of queries is empty - 10https://bugzilla.wikimedia.org/70091 (10Andre Klapper) p:5Unprio>3High
[13:18:39] <wikibugs>	 3MediaWiki extensions / 3ApiSandbox: [regression] On 1.24wmf18, the list of queries is empty - 10https://bugzilla.wikimedia.org/70091#c1 (10Max Semenik) 5NEW>3RESO/DUP   *** This bug has been marked as a duplicate of bug 69872 ***
[13:18:44] <wikibugs>	 3MediaWiki extensions / 3ApiSandbox: Warning:  sort() expects parameter 1 to be array, string given in SpecialApiSandbox.php on line 133 - 10https://bugzilla.wikimedia.org/69872#c6 (10Max Semenik) *** Bug 70091 has been marked as a duplicate of this bug. ***
[13:20:14] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 04-1] i18n: Allow translation of participants (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155827 (owner: 10Jdlrobson)
[13:21:39] <grrrit-wm>	 (03CR) 10Matthias Mullie: i18n: Allow translation of participants (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155827 (owner: 10Jdlrobson)
[13:22:03] <grrrit-wm>	 (03PS15) 10Matthias Mullie: i18n: Allow translation of participants [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155827 (owner: 10Jdlrobson)
[13:22:06] <grrrit-wm>	 (03PS10) 10Matthias Mullie: Hygiene: Standardise on time i10n parameter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155672 (owner: 10Jdlrobson)
[13:23:27] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 032] Hygiene: Standardise on time i10n parameter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155672 (owner: 10Jdlrobson)
[13:23:37] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 032] i18n: Allow translation of participants [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155827 (owner: 10Jdlrobson)
[13:24:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Standardise on time i10n parameter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155672 (owner: 10Jdlrobson)
[13:24:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: i18n: Allow translation of participants [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155827 (owner: 10Jdlrobson)
[13:24:20] <grrrit-wm>	 (03Abandoned) 10Matthias Mullie: i18n: properly translate list of topic participants [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156096 (owner: 10Matthias Mullie)
[13:34:31] <grrrit-wm>	 (03CR) 10Krinkle: "fixme: This broke output of various scripts due to quote mismatches." [core] - 10https://gerrit.wikimedia.org/r/149044 (owner: 10Umherirrender)
[13:36:11] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/154280 (owner: 10Florianschmidtwelzow)
[13:37:05] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] The static declaration must come after the visibility declaration [core] - 10https://gerrit.wikimedia.org/r/156139 (owner: 10Umherirrender)
[13:38:30] <grrrit-wm>	 (03CR) 10Krinkle: Break some long lines in maintenance, skins, tests (032 comments) [core] - 10https://gerrit.wikimedia.org/r/149044 (owner: 10Umherirrender)
[13:40:27] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Fixed spacing (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156149 (owner: 10Umherirrender)
[13:40:56] <grrrit-wm>	 (03PS1) 10Krinkle: Fix up php syntax that accidentally became part of a string literal [core] - 10https://gerrit.wikimedia.org/r/156531 
[13:41:20] <grrrit-wm>	 (03CR) 10Krinkle: "Fixed in I6104f716f7dc32d6." [core] - 10https://gerrit.wikimedia.org/r/149044 (owner: 10Umherirrender)
[13:43:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: The static declaration must come after the visibility declaration [core] - 10https://gerrit.wikimedia.org/r/156139 (owner: 10Umherirrender)
[13:43:39] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/156149 (owner: 10Umherirrender)
[13:45:12] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] Add missing @return and @param to doc blocks (032 comments) [core] - 10https://gerrit.wikimedia.org/r/156142 (owner: 10Umherirrender)
[13:45:54] <wikibugs>	 3MediaWiki / 3ResourceLoader: add timestamp near cache key (JS/CSS minify) - 10https://bugzilla.wikimedia.org/34779 (10Krinkle)
[13:45:54] <wikibugs>	 3MediaWiki / 3General/Unknown: Synchronize css/js caching - 10https://bugzilla.wikimedia.org/17821#c2 (10Krinkle) 5NEW>3RESO/WOR (In reply to Andre Klapper from comment #1) > Related:  > * bug 34779: add timestamp near cache key (JS/CSS minify) > * bug 26338: Wikimedia JS/CSS files get an extra max-age c...
[13:46:09] <wikibugs>	 3MediaWiki / 3General/Unknown: Synchronize css/js caching - 10https://bugzilla.wikimedia.org/17821 (10Krinkle)
[13:48:17] <grrrit-wm>	 (03CR) 10Gilles: [C: 032] Check API Page Index for Missing [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/156512 (owner: 10Dan-nl)
[13:48:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Check API Page Index for Missing [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/156512 (owner: 10Dan-nl)
[13:51:27] <wikibugs>	 3Wikimedia / 3Site requests: Delete all redundant "MediaWiki" pages for system messages - 10https://bugzilla.wikimedia.org/43917#c29 (10Krinkle) Ran for commonswiki per my own request there as sysop (could've deleted them by hand):   > 279 pages in the MediaWiki namespace override messages. > 1 pages are equ...
[13:53:47] <Krinkle>	 legoktm: How did you run the globalcssjs script? I don't see it in the wmf branch on tin
[13:53:53] <Krinkle>	 l /a/common/php-1.24wmf18/extensions/GlobalCssJs/
[13:57:49] <Krenair>	 Krinkle, check terbium:~legoktm ?
[13:59:52] <Krinkle>	 Ugh, overwriting MW_INSTALL_PATH and abusing mwscript with path escalation out of $IP/../../../ into /home
[14:00:10] <grrrit-wm>	 (03PS1) 10Krinkle: Add a script to delete manual user global.js/css pages [extensions/GlobalCssJs] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156533 (https://bugzilla.wikimedia.org/68933) 
[14:00:14] <Krinkle>	 Mind if I just backport it?
[14:01:21] <Krinkle>	 Ugh, GlobalCssJsHooks::loadForUser didn't exist yet..
[14:02:12] <Krinkle>	 Ah, great.
[14:03:30] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] "Backporting properly to register that Legoktm has already been running this in production 1.24wmf18 using a work-around." [extensions/GlobalCssJs] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156533 (https://bugzilla.wikimedia.org/68933) (owner: 10Krinkle)
[14:03:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add a script to delete manual user global.js/css pages [extensions/GlobalCssJs] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156533 (https://bugzilla.wikimedia.org/68933) (owner: 10Krinkle)
[14:03:41] <grrrit-wm>	 (03PS1) 10Krinkle: Better support usernames with spaces in them [extensions/GlobalCssJs] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156534 
[14:04:05] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] "Was already run in production by Legoktm, backport in git as well so that others can run it without hacks." [extensions/GlobalCssJs] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156534 (owner: 10Krinkle)
[14:04:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Better support usernames with spaces in them [extensions/GlobalCssJs] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156534 (owner: 10Krinkle)
[14:06:57] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Move flow-topic-comments message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156535 
[14:07:41] <grrrit-wm>	 (03PS1) 10Krinkle: Update GlobalCssJs to latest wmf/1.24wmf18 [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156536 
[14:07:47] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Move flow-topic-comments message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156535 (owner: 10Matthias Mullie)
[14:13:59] <Krinkle>	 siebrand: https://gerrit.wikimedia.org/r/#/c/156531/
[14:15:06] <grrrit-wm>	 (03CR) 10Phuedx: "Jdlrobson: does your -2 still stand? I think that now is a good time to revisit this given the outcome of the Icon Standardisation meeting" [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx)
[14:15:20] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Fix up php syntax that accidentally became part of a string literal [core] - 10https://gerrit.wikimedia.org/r/156531 (owner: 10Krinkle)
[14:20:57] <wikibugs>	 3MediaWiki / 3JavaScript: Ship Object.create polyfill for OOjs for compatibility with browser having ES3 engines - 10https://bugzilla.wikimedia.org/67590 (10Krinkle) 5ASSI>3PATC
[14:21:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix up php syntax that accidentally became part of a string literal [core] - 10https://gerrit.wikimedia.org/r/156531 (owner: 10Krinkle)
[14:22:47] <wikibugs>	 3Wikimedia / 3General/Unknown: ApiSandbox - query broken on Commons - 10https://bugzilla.wikimedia.org/70093 (10Lokal_Profil) 3NEW p:3Unprio s:3normal a:3None The query functionality in the ApiSandbox seems to be broken on Commons. Selecting action=query returns the headers "Lists, properties, Meta i...
[14:41:36] <baxi>	 Hi @all
[14:41:51] <baxi>	 ,Does someone know if it is possible to get in a template the pagename+ns of the "calling" page?
[14:44:20] <grrrit-wm>	 (03PS1) 10Krinkle: [WIP] mw.loader.store: Set virtual sourceURL in the globalEval calls [core] - 10https://gerrit.wikimedia.org/r/156544 
[14:47:32] <Krinkle>	 baxi: Yes. In fact you can only get the page name of the calling page, never of the template.
[14:47:42] <jackmcbarn>	 Krinkle: second part isn't true
[14:48:04] <jackmcbarn>	 baxi: {{FULLPAGENAME}} should give you what you want
[14:48:05] <Krinkle>	 jackmcbarn: It is, at best you can substitute it, but there's no magic word to yield the page being included.
[14:48:19] <jackmcbarn>	 Krinkle: there's none built in, but you can write one in lua
[14:48:34] <Krinkle>	 One could also write one in PHP.
[14:48:44] <jackmcbarn>	 yes, but the lua way works on-wiki
[14:48:48] <jackmcbarn>	 and i think enwiki does something like it now
[14:49:18] <baxi>	 no, if i use {{FULLPAGENAME}} inside a template, i get the name of the template, not the calling page in which it is included. maybe i pass the pagename with the template params, seems to be easier
[14:49:20] <Krinkle>	 One could also on-wiki write a javascript gadget, that'll execute scripts from a fake JSTemplate: and parse wikitext client-side and display it in html. 
[14:49:43] <Krinkle>	 (that's a joke)
[14:49:46] <jackmcbarn>	 baxi: no you don't
[14:49:52] <baxi>	 i tried, i got
[14:49:59] <Krinkle>	 baxi: What version of MediaWiki are you running? Can you show this on a public link for us to see?
[14:50:06] <baxi>	 1.23.2
[14:50:11] <baxi>	 smw 2.0
[14:50:51] <baxi>	 no it's a closed wiki, sry
[14:51:22] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] mw.loader.store: Set virtual sourceURL in the globalEval calls [core] - 10https://gerrit.wikimedia.org/r/156544 (owner: 10Krinkle)
[14:52:18] <grrrit-wm>	 (03PS2) 10Krinkle: [WIP] mw.loader.store: Set virtual sourceURL in the globalEval calls [core] - 10https://gerrit.wikimedia.org/r/156544 
[14:52:26] <jackmcbarn>	 baxi: do you have any custom/in-house extensions?
[14:52:38] <jackmcbarn>	 if {{FULLPAGENAME}} gives you the template name, there's something seriously wrong
[14:53:03] <baxi>	 ok, seems the cache fooled me, sry...
[14:55:10] <qgil>	 anomie, hi, whenever you have time, your opinion is welcome at http://fab.wmflabs.org/T491 
[14:55:31] <anomie>	 qgil: I'll have a look after SWAT
[14:55:42] <qgil>	 anomie, great, thank you
[14:58:20] <grrrit-wm>	 (03CR) 10Anomie: Provide rudimentary __toString() for Status (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156446 (owner: 10saper)
[15:01:58] <baxi>	 One question, maybe it's the right place here. I reworked the extension:Tooltip. As i got it tested, it works quite fine now with 1.23.2 and i thnk with a few older versions too. It seems it was not meintained last 6 years. Unitl now i published my source updates on the talk page. But i think there are better ways?
[15:02:24] <grrrit-wm>	 (03PS24) 10Paladox: WikiEditor: Fix issue with SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) 
[15:03:41] <grrrit-wm>	 (03CR) 10Anomie: [C: 032] "SWAT" [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156495 (owner: 10Jforrester)
[15:06:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VisualEditor for Iaccb7d0 [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156495 (owner: 10Jforrester)
[15:08:18] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: Add support for geoshapes as a datatype - 10https://bugzilla.wikimedia.org/55549#c4 (10Tobias) Just a reminder that efforts should be coordinated with:  https://meta.wikimedia.org/wiki/Grants:IEG/Wikimaps_Atlas
[15:08:34] <grrrit-wm>	 (03PS5) 10Florianschmidtwelzow: SpecialUpload: Use Config instead of global [core] - 10https://gerrit.wikimedia.org/r/152134 (https://bugzilla.wikimedia.org/69188) 
[15:09:18] <grrrit-wm>	 (03PS1) 10Alex Monk: Clean up mediawiki.legacy.upload a bit more [core] - 10https://gerrit.wikimedia.org/r/156552 (https://bugzilla.wikimedia.org/31946) 
[15:09:27] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] SpecialUpload: Use Config instead of global [core] - 10https://gerrit.wikimedia.org/r/152134 (https://bugzilla.wikimedia.org/69188) (owner: 10Florianschmidtwelzow)
[15:09:30] <grrrit-wm>	 (03PS2) 10Anomie: Update VisualEditor for Iaccb7d0 [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/156496 (owner: 10Jforrester)
[15:11:14] <grrrit-wm>	 (03PS6) 10Florianschmidtwelzow: SpecialUpload: Use Config instead of global [core] - 10https://gerrit.wikimedia.org/r/152134 (https://bugzilla.wikimedia.org/69188) 
[15:12:34] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Update GlobalCssJs to latest wmf/1.24wmf18 [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156536 (owner: 10Krinkle)
[15:12:53] <wikibugs>	 3MediaWiki / 3General/Unknown: Overlay of video menu blocks "use this file" - 10https://bugzilla.wikimedia.org/70094 (10Jan Ainali) 3NEW p:3Unprio s:3normal a:3None Created attachment 16291   --> https://bugzilla.wikimedia.org/attachment.cgi?id=16291&action=edit Screen cast of the sequence  1. On the...
[15:14:27] <baxi>	 ok, seems not, i ask in other chan..
[15:15:12] <grrrit-wm>	 (03CR) 10Krinkle: "format-B is now missing a doctype. And the sprite completely changed. It should probably only have the bold part replaced." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox)
[15:15:29] <grrrit-wm>	 (03CR) 10Krinkle: [C: 04-1] "I mean xml header, not doctype." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox)
[15:16:28] <wikibugs>	 3Mathoid / 3General/Unknown: Create production Mathoid instance - 10https://bugzilla.wikimedia.org/69989#c2 (10physikerwelt) I created to change   https://gerrit.wikimedia.org/r/156542 with almost no knowledge about the production environment. Fortunately, I got with great support of akosiaris.  Could someon...
[15:17:33] <FlorianSW>	 is gerrit very slow only on my computer? :/
[15:18:12] <grrrit-wm>	 (03CR) 10Anomie: [C: 032 V: 032] "SWAT" [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/156496 (owner: 10Jforrester)
[15:18:41] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: SpecialUpload: Use Config instead of global (031 comment) [core] - 10https://gerrit.wikimedia.org/r/152134 (https://bugzilla.wikimedia.org/69188) (owner: 10Florianschmidtwelzow)
[15:18:49] <wctaiwan>	 FlorianSW: seems normal here
[15:19:04] <FlorianSW>	 wctaiwan: hmm, ok thanks :)
[15:19:09] <Krenair>	 Okay what is going on at https://www.mediawiki.org/wiki/Topic:Rzrx42lg7xgbfzvc ?
[15:19:22] <wctaiwan>	 lovely url >.>
[15:19:23] <grrrit-wm>	 (03CR) 10Krinkle: [C: 04-1] Redirect on all template calls (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152817 (https://bugzilla.wikimedia.org/69217) (owner: 10MarkTraceur)
[15:19:37] <grrrit-wm>	 (03PS2) 10Anomie: ApiSandbox: pick https://gerrit.wikimedia.org/r/#/c/156500/ [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156503 (owner: 10MaxSem)
[15:21:37] <grrrit-wm>	 (03CR) 10Parent5446: [C: 04-1] "Agreed with Anomie. In a lot of cases I'd argue it should be even more verbose, since a string representation of an object should encapsul" [core] - 10https://gerrit.wikimedia.org/r/156446 (owner: 10saper)
[15:21:38] <Krenair>	 Wow that's a useless URL
[15:21:38] <Krenair>	 It's "Do we need to save space on desktop?" on Talk:Compact Personal Bar
[15:23:33] <grrrit-wm>	 (03CR) 10Anomie: [C: 032 V: 032] "SWAT" [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156503 (owner: 10MaxSem)
[15:23:50] <FlorianSW>	 Krenair: What you mean exactly? :P
[15:24:45] <wctaiwan>	 Krenair: to be fair to the flow folks, it's better than it was before (previously the specific topic was specified in the query string, so you couldn't wikilink a topic)
[15:24:53] <grrrit-wm>	 (03PS2) 10Anomie: Update GlobalCssJs to latest wmf/1.24wmf18 [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156536 (owner: 10Krinkle)
[15:24:59] <Krenair>	 FlorianSW, ?
[15:25:40] <grrrit-wm>	 (03CR) 10Anomie: [C: 032 V: 032] "SWAT" [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156536 (owner: 10Krinkle)
[15:25:48] <FlorianSW>	 [17:19] <Krenair> Okay what is going on at
[15:25:50] <Krenair>	 FlorianSW, the messages between Katieesperanzavigil  and Kong a tong i e t
[15:25:55] <FlorianSW>	 ah ok :P
[15:26:55] <Krenair>	 wctaiwan, before, we had (and still have) LQT, which provides useful ways of linking
[15:29:20] <wctaiwan>	 fair enough
[15:30:12] <grrrit-wm>	 (03PS1) 10Cmcmahon: QA: update to fix deprecated API token call [core] - 10https://gerrit.wikimedia.org/r/156556 
[15:32:00] <grrrit-wm>	 (03PS4) 10BryanDavis: [WIP] Request a global account rename [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156488 (https://bugzilla.wikimedia.org/68886) 
[15:34:12] <Nemo_bis>	 wctaiwan: I don't understand, in what circumstances one is unable to wikilink a topic?
[15:34:34] <Nemo_bis>	 I can't imaging of any single case, maybe some unsupported extension?
[15:34:44] <wctaiwan>	 Nemo_bis: the url used to be like http://mediawiki.org/Talk:Flow&workflow=uuid
[15:34:54] <wctaiwan>	 er, s/&/?/
[15:35:07] <wctaiwan>	 you can't do [[Talk:Flow?workflow=uuid]]; it just wouldn't work.
[15:35:11] <Nemo_bis>	 Ah, not in currently used stuff
[15:35:13] <wikibugs>	 3Wikimedia / 3Deployment systems: [scap] Syncing wmf-config/PrivateSettings.php syncs symlink and not file contents - 10https://bugzilla.wikimedia.org/70054#c2 (10Antoine "hashar" Musso) I can imagine how one get tricked in that:   vim symlink.txt  sync-file symlink.txt  +1 on emitting a warning that a symli...
[15:35:20] <Nemo_bis>	 oki
[15:35:23] <wctaiwan>	 yeah; the currently used stuff was in part designed to address that.
[15:35:35] <grrrit-wm>	 (03PS1) 10Krinkle: RemoveOldManualUserPages: Document and enforce required options [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/156557 
[15:36:11] <chrismcmahon>	 is git/gerrit having a problem atm? git review was really slow, git clone seems slower even
[15:37:10] <grrrit-wm>	 (03PS2) 10Krinkle: RemoveOldManualUserPages: Document and enforce required options [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/156557 
[15:40:15] <grrrit-wm>	 (03CR) 10BryanDavis: [WIP] Request a global account rename (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/156488 (https://bugzilla.wikimedia.org/68886) (owner: 10BryanDavis)
[15:43:32] <wikibugs>	 3MediaWiki extensions / 3Interwiki (extension): Clean up inconsistent _ vs - formatting across i18n message keys - 10https://bugzilla.wikimedia.org/70080#c4 (10Isarra) Long-standing practice is irrelevant. This is both poor coding practice and poor usability; by that logic there's no reason to make new ones...
[15:45:15] <wikibugs>	 3MediaWiki / 3API: token api should allow type parameters for any action name which requires a token - 10https://bugzilla.wikimedia.org/38717#c11 (10Jon) 5RESO/WOR>3RESO/WON for clarity then.. thanks for summarising :)
[15:45:38] <FlorianSW>	 Nemo_bis, wctaiwan: What is with subpages :) [[Talk:Flow/uuid]]
[15:46:04] <^d>	 Slow for me too, but I don't think it's ytterbium.
[15:46:04] <^d>	 My ssh sessions to the elastic* boxes is a tad slow too.
[15:46:04] <^d>	 And terbium
[15:46:05] <bd808>	 I've been having ssh slowness for the last hour or so
[15:46:05] <bd808>	 I had connections to beta hosts completely timeout during an active session
[15:46:05] <^d>	 I just timed out to elastic1001
[15:46:14] <wctaiwan>	 holy crap freenode lag
[15:46:25] <Nemo_bis>	 a bit here too
[15:46:28] <wctaiwan>	 FlorianSW: I think subpages was one of the main reasons they didn't go with that scheme, actually
[15:46:44] <wctaiwan>	 in case you have a subpage named exactly like a UUID
[15:46:47] <grrrit-wm>	 (03CR) 10Krinkle: [C: 04-1] PhantomJS doesn't support Function.prototype.bind (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156215 (owner: 10EBernhardson)
[15:46:48] <wctaiwan>	 unlikely, but possible
[15:46:58] <wikibugs>	 3MediaWiki / 3API: A way to get if uploads are allowed - 10https://bugzilla.wikimedia.org/70075#c1 (10Brad Jorsch) (In reply to Fabian from comment #0) > One way to have the filesize return 0 (or negative) if uploads are disabled > or let fileextensions return an empty list or introduce a new property.  A ne...
[15:47:33] <FlorianSW>	 wctaiwan: Yeah, creating of subpages for the page hosted flow has to be deactivated :)
[15:50:28] <wikibugs>	 3MediaWiki extensions / 3Interwiki (extension): Clean up inconsistent _ vs - formatting across i18n message keys - 10https://bugzilla.wikimedia.org/70080#c5 (10Isarra) (In reply to Niklas Laxström from comment #2) > Trying to fix message names en masse brings lot of disruption with little > benefit. Don't fo...
[15:50:28] <wikibugs>	 3MediaWiki extensions / 3Interwiki (extension): Clean up inconsistent _ vs - formatting across i18n message keys - 10https://bugzilla.wikimedia.org/70080 (10Isarra) 5RESO/WON>3REOP
[15:50:28] <wikibugs>	 3MediaWiki extensions / 3Capiunto: security review for Capiunto - 10https://bugzilla.wikimedia.org/69541#c7 (10Nik Everett) So "everyone I've asked" about the extension says the mw.org page needs more instructions.  A link https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FCapiunto/1441b9ab1c126d7047e18...
[15:50:43] <wikibugs>	 3MediaWiki extensions / 3WikibaseQuery: security review of WikibaseQuery - 10https://bugzilla.wikimedia.org/67533#c7 (10Nik Everett) (In reply to Chris Steipp from comment #6) > (In reply to Jeroen De Dauw from comment #5) > > Given that, I'm not sure it makes sense to do a real security review of > > these...
[15:51:41] <grrrit-wm>	 (03PS8) 10Matthias Mullie: [WIP] search [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126996 
[15:53:56] <grrrit-wm>	 (03PS4) 10Umherirrender: Add missing @return and @param to doc blocks [core] - 10https://gerrit.wikimedia.org/r/156142 
[15:54:26] <grrrit-wm>	 (03CR) 10Umherirrender: "Patch Set 4: Addressed inline comments" [core] - 10https://gerrit.wikimedia.org/r/156142 (owner: 10Umherirrender)
[15:55:13] <wikibugs>	 3MediaWiki extensions / 3WikibaseQueryEngine: performance review of WikibaseQueryEngine - 10https://bugzilla.wikimedia.org/67535#c5 (10Nik Everett) Poke for status - I'm really just looking for some general hint on Ori would be able to start the review.  Or if I should bounce to Aaron?
[15:57:47] <grrrit-wm>	 (03PS1) 10Cmcmahon: QA: update to fix deprecated API token call [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156561 
[15:58:14] <wikibugs>	 3MediaWiki / 3JobQueue: On-request job queue handling needs RELEASE NOTES mention - 10https://bugzilla.wikimedia.org/60719 (10Jesús Martínez Novo (Ciencia Al Poder)) 5PATC>3RESO/FIX a:3Mark A. Hershberger
[15:59:40] <grrrit-wm>	 (03PS1) 10Cmcmahon: QA: update to fix deprecated API token call [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156562 
[16:00:52] <grrrit-wm>	 (03PS1) 10Aude: Update Wikidata branch to mw1.24-wmf19 [tools/release] - 10https://gerrit.wikimedia.org/r/156563 
[16:01:32] <grrrit-wm>	 (03PS4) 10Florianschmidtwelzow: Improve Login page [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/154280 
[16:01:34] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Improve Login page [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/154280 (owner: 10Florianschmidtwelzow)
[16:03:43] <grrrit-wm>	 (03PS5) 10Florianschmidtwelzow: Improve Login page [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/154280 
[16:06:59] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 032] Improve Login page [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/154280 (owner: 10Florianschmidtwelzow)
[16:07:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Improve Login page [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/154280 (owner: 10Florianschmidtwelzow)
[16:11:16] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add missing @return and @param to doc blocks [core] - 10https://gerrit.wikimedia.org/r/156142 (owner: 10Umherirrender)
[16:14:12] <grrrit-wm>	 (03CR) 10Umherirrender: "recheck" [core] - 10https://gerrit.wikimedia.org/r/156142 (owner: 10Umherirrender)
[16:15:14] <grrrit-wm>	 (03CR) 10AndyRussG: "BTW, whenever you're ready for this to go through, please just rebase (so it can merge) and let me know. Thanks!" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/142481 (https://bugzilla.wikimedia.org/66114) (owner: 10Prtksxna)
[16:16:04] <wikibugs>	 3MediaWiki / 3ResourceLoader: Make ResourceLoader a standalone library - 10https://bugzilla.wikimedia.org/30956#c4 (10Krinkle) p:5Low>3Lowest Both in the design and implementation we've done pretty well in keeping ResourceLoader independent from MediaWiki, but it has been integrated a little bit here and...
[16:17:37] <wikibugs>	 3Wikimedia / 3General/Unknown: JS bug : URI error - 10https://bugzilla.wikimedia.org/70097 (10Sacamol) 3UNCO p:3Unprio s:3normal a:3None Created attachment 16292   --> https://bugzilla.wikimedia.org/attachment.cgi?id=16292&action=edit example of JS console on chrome browser as the time of bug input...
[16:19:43] <renoirb>	 Hi, is there a version of semanticmediawiki that works against wmf/1.24wmf ?  (sorry for cross posting)
[16:19:59] <wikibugs>	 3Wikimedia / 3General/Unknown: ApiSandbox - query broken on Commons - 10https://bugzilla.wikimedia.org/70093#c1 (10Umherirrender) 5NEW>3RESO/DUP Sounds same as bug 70091  *** This bug has been marked as a duplicate of bug 69872 ***
[16:20:14] <wikibugs>	 3MediaWiki extensions / 3ApiSandbox: Warning:  sort() expects parameter 1 to be array, string given in SpecialApiSandbox.php on line 133 - 10https://bugzilla.wikimedia.org/69872#c7 (10Umherirrender) *** Bug 70093 has been marked as a duplicate of this bug. ***
[16:21:17] <grrrit-wm>	 (03PS1) 10Cmcmahon: QA: update to fix deprecated API token call [extensions/Math] - 10https://gerrit.wikimedia.org/r/156569 
[16:22:27] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] QA: update to fix deprecated API token call [extensions/Math] - 10https://gerrit.wikimedia.org/r/156569 (owner: 10Cmcmahon)
[16:23:03] <grrrit-wm>	 (03PS1) 10Pastakhov: add hook EditPage::showReadOnlyForm:initial (v 1.7.2) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156571 
[16:27:53] <grrrit-wm>	 (03PS1) 10Cmcmahon: QA: update to fix deprecated API token call [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/156573 
[16:28:40] <grrrit-wm>	 (03PS2) 10Physikerwelt: QA: update to fix deprecated API token call [extensions/Math] - 10https://gerrit.wikimedia.org/r/156569 (owner: 10Cmcmahon)
[16:32:27] <grrrit-wm>	 (03PS3) 10Umherirrender: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/156149 
[16:32:50] <grrrit-wm>	 (03CR) 10Umherirrender: "Patch Set 3: Rebased" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156149 (owner: 10Umherirrender)
[16:34:04] <grrrit-wm>	 (03PS1) 10Cmcmahon: QA: update to fix deprecated API token call [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/156575 
[16:38:26] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] Use descriptive key for array of in a Special:EditWatchlist line [core] - 10https://gerrit.wikimedia.org/r/156522 (owner: 10Matthias Mullie)
[16:38:34] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] Fix Flow entries in Special:EditWatchlist [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156121 (owner: 10Matthias Mullie)
[16:40:24] <grrrit-wm>	 (03PS9) 10Isarra: Add support for enabling and displaying global interwikis [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/147755 (https://bugzilla.wikimedia.org/68241) 
[16:40:45] <grrrit-wm>	 (03CR) 10Pastakhov: [C: 032] add hook EditPage::showReadOnlyForm:initial (v 1.7.2) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156571 (owner: 10Pastakhov)
[16:40:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: add hook EditPage::showReadOnlyForm:initial (v 1.7.2) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156571 (owner: 10Pastakhov)
[16:44:35] <grrrit-wm>	 (03PS5) 10Isarra: Cleanup special:interwiki intro (some more) [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/156190 
[16:45:31] <grrrit-wm>	 (03PS13) 10EBernhardson: G3: Mobile/nojs edit and reply full topic output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156203 
[16:45:42] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] G3: Mobile/nojs edit and reply full topic output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156203 (owner: 10EBernhardson)
[16:47:28] <wikibugs>	 3MediaWiki extensions / 3Interwiki (extension): Clean up inconsistent _ vs - formatting across i18n message keys - 10https://bugzilla.wikimedia.org/70080 (10Andre Klapper) p:5Low>3Lowest
[16:51:43] <wikibugs>	 3Wikimedia / 3General/Unknown: JS bug : URI error - 10https://bugzilla.wikimedia.org/70097#c1 (10Andre Klapper) Thanks for taking the time to report this!  What are exact steps to reproduce the problem? Also, the exact error is welcome (if that arrow in your screenshot can be clicked to expand its content, d...
[16:52:10] <grrrit-wm>	 (03PS1) 10Chad: Adjust default parameters + documentation [search/repository-swift] - 10https://gerrit.wikimedia.org/r/156577 
[16:53:11] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 032] RemoveOldManualUserPages: Document and enforce required options [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/156557 (owner: 10Krinkle)
[16:53:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: RemoveOldManualUserPages: Document and enforce required options [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/156557 (owner: 10Krinkle)
[16:57:56] <grrrit-wm>	 (03CR) 10Filippo Giunchedi: [C: 031] Adjust default parameters + documentation [search/repository-swift] - 10https://gerrit.wikimedia.org/r/156577 (owner: 10Chad)
[16:59:33] <grrrit-wm>	 (03PS2) 10EBernhardson: G3: Add support for recursive progressiveEnhancement [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156473 (owner: 10SG)
[16:59:40] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] G3: Add support for recursive progressiveEnhancement [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156473 (owner: 10SG)
[17:00:16] <grrrit-wm>	 (03PS14) 10EBernhardson: G3: Mobile/nojs edit and reply full topic output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156203 
[17:00:23] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] G3: Mobile/nojs edit and reply full topic output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156203 (owner: 10EBernhardson)
[17:00:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: G3: Add support for recursive progressiveEnhancement [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156473 (owner: 10SG)
[17:04:02] <marxarelli>	 bd808: thanks for the review!
[17:04:08] <bd808>	 marxarelli: yw
[17:05:33] <wikibugs>	 3MediaWiki extensions / 3Capiunto: performance review for Capiunto - 10https://bugzilla.wikimedia.org/69540#c2 (10Brad Jorsch) Reviewing revision 1441b9ab:  Capiunto.php line 30: > # XXX: Rather use ScribuntoExternalLibraryPaths ?  ScribuntoExternalLibraryPaths is for pure-Lua libraries that are loaded using...
[17:05:58] <wikibugs>	 3Wikimedia / 3Extension setup: Review and deploy the "In other projects sidebar" beta feature (part of Wikibase extension) - 10https://bugzilla.wikimedia.org/66226 (10Lydia Pintscher) 5NEW>3RESO/FIX
[17:06:13] <wikibugs>	 3MediaWiki / 3Maintenance scripts: deleteOldRevisions.php deletes content text from current revisions - 10https://bugzilla.wikimedia.org/66615#c15 (10Jesús Martínez Novo (Ciencia Al Poder)) (In reply to sen from comment #14) > them are no such tool,to check which the mediawiki has lost content,so even > it l...
[17:06:49] <grrrit-wm>	 (03CR) 10Rush: "this will cause conflicts with upstream. PHP is trusty and 5.5 I think on this host. I am really not excited about merging this without " [phabricator/phabricator] - 10https://gerrit.wikimedia.org/r/147723 (owner: 1020after4)
[17:09:31] <renoirb>	 bd808, is it me or ::mediawiki::extension doesnt allow us to set a version?
[17:09:43] <renoirb>	 oh, right, branch. sorry
[17:10:10] <bd808>	 It may not at the moment. That should be easy to fix though
[17:11:14] <bd808>	 renoirb: $branch right?
[17:11:15] <grrrit-wm>	 (03CR) 10Jdlrobson: "@EBernhardson this should really have had tests. I'm not happy you ignored my -1 :(" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156473 (owner: 10SG)
[17:20:58] <renoirb>	 yes bd808 
[17:21:05] <renoirb>	 what is scribunto and lua sandbox?
[17:21:11] <renoirb>	 is that utilities to help with the parser?
[17:22:01] <bd808>	 renoirb: https://www.mediawiki.org/wiki/Extension:Scribunto
[17:22:14] <bd808>	 Its a system that allows lua templates
[17:22:40] <renoirb>	 oh, never used lua
[17:22:46] <renoirb>	 i heard you can use that with nginx too
[17:23:12] <bd808>	 We use it to make complex templates much much faster
[17:24:00] <grrrit-wm>	 (03PS1) 10Spage: Continue offset is missing in the read API [extensions/Echo] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156580 
[17:24:26] <bd808>	 renoirb: More info at https://www.mediawiki.org/wiki/Lua_scripting if you want to go down that rabbit hole :)
[17:25:09] <renoirb>	 I am curious, is there a way in puppet to say that I want to be sure that a class will be executed (i.e. not throwing duplicate error), but to add parameters from the settings=> array?
[17:29:40] <grrrit-wm>	 (03CR) 10Dduvall: [C: 032] QA: update to fix deprecated API token call [core] - 10https://gerrit.wikimedia.org/r/156556 (owner: 10Cmcmahon)
[17:30:09] <grrrit-wm>	 (03CR) 10Dduvall: [C: 032] QA: update to fix deprecated API token call [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/156575 (owner: 10Cmcmahon)
[17:30:10] <renoirb>	 I am curious, is there a way in puppet to say that I want to be sure that a class will be executed (i.e. not throwing error if its already existing)  but to add settings too
[17:30:49] <bd808>	 I'm not sure I exactly understand the question, but I think the answer is "no". You can have "include foo" and "class { 'foo': ... }" but not two "class { 'foo': }" definitions
[17:31:42] <grrrit-wm>	 (03CR) 10Dduvall: [C: 032] QA: update to fix deprecated API token call [extensions/Math] - 10https://gerrit.wikimedia.org/r/156569 (owner: 10Cmcmahon)
[17:31:44] <bd808>	 We are trying to move towards using the hiera settings to solve this problem to some extent
[17:32:38] <bd808>	 But if for instance 2 roles need to require the same thing, that thing should be defined as a third component and included by the two roles
[17:32:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: QA: update to fix deprecated API token call [extensions/Math] - 10https://gerrit.wikimedia.org/r/156569 (owner: 10Cmcmahon)
[17:34:55] <grrrit-wm>	 (03CR) 10Dduvall: [C: 032] QA: update to fix deprecated API token call [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/156573 (owner: 10Cmcmahon)
[17:35:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: QA: update to fix deprecated API token call [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/156573 (owner: 10Cmcmahon)
[17:36:10] <grrrit-wm>	 (03CR) 10Dduvall: [C: 032] QA: update to fix deprecated API token call [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156562 (owner: 10Cmcmahon)
[17:36:39] <grrrit-wm>	 (03CR) 10Dduvall: [C: 032] QA: update to fix deprecated API token call [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156561 (owner: 10Cmcmahon)
[17:36:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: QA: update to fix deprecated API token call [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156562 (owner: 10Cmcmahon)
[17:38:20] <^d>	 ebernhardson: I'm hitting a flow bug on vagrant, dunno if it's known. Can't seem to post a new topic (anon or logged in), get "The token parameter must be set"
[17:38:43] <wikibugs>	 3MediaWiki extensions / 3WikidataClient: Move "Data item" link outside of sidebar toolbox - 10https://bugzilla.wikimedia.org/64315#c10 (10Lydia Pintscher) 5REOP>3RESO/WON Closing for lack of proposal now.
[17:46:55] <grrrit-wm>	 (03PS1) 10Chad: New role: CategoryTree [vagrant] - 10https://gerrit.wikimedia.org/r/156585 
[17:47:07] <^d>	 :)
[17:49:31] <grrrit-wm>	 (03CR) 10BryanDavis: "I've had a local role for this for a while but never got around to submitting." (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/156585 (owner: 10Chad)
[17:50:22] <renoirb>	 oh god. Seen on Extension:Semantic_Forms "If you're using MediaWiki 1.24, you will also need to make one change to the core Mediawiki code: in /includes/EditPage, find the line (around line 221) that reads:"
[17:50:33] <renoirb>	 o_o;;;
[17:50:45] <Lcawte>	 "QA: update to fix" ... am I right in thinking the commit message guidelines say something about not adding "update to" ?
[17:51:47] <grrrit-wm>	 (03PS1) 10Chad: New role: LabledSectionTransclusion [vagrant] - 10https://gerrit.wikimedia.org/r/156587 
[17:51:55] <renoirb>	 they are using MediaWiki 1.22 http://semantic-mediawiki.org/wiki/Special:Version
[17:52:04] <grrrit-wm>	 (03CR) 10MarkTraceur: "I definitely agree that an error event is the way to go. However, I might suggest using backend logging for it - we can fire events out of" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/144588 (owner: 10Gergő Tisza)
[17:52:27] <grrrit-wm>	 (03CR) 10Chad: New role: CategoryTree (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/156585 (owner: 10Chad)
[17:52:58] <wikibugs>	 3MediaWiki / 3Uploading: Rework Special:Upload JS to use api and serverside upload checks - 10https://bugzilla.wikimedia.org/24217#c1 (10Alex Monk) Is this still valid?
[17:53:32] <grrrit-wm>	 (03CR) 10BryanDavis: [C: 032] New role: LabledSectionTransclusion [vagrant] - 10https://gerrit.wikimedia.org/r/156587 (owner: 10Chad)
[17:53:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: New role: LabledSectionTransclusion [vagrant] - 10https://gerrit.wikimedia.org/r/156587 (owner: 10Chad)
[17:54:08] <ebernhardson>	 ^d: hmm, probably new then :( same happening on beta 
[17:54:39] <grrrit-wm>	 (03PS2) 10Chad: New role: CategoryTree [vagrant] - 10https://gerrit.wikimedia.org/r/156585 
[17:54:57] <ebernhardson>	 ^d: thanks for report will fix
[17:55:04] <^d>	 yw!
[17:55:29] <bd808>	 ebernhardson: Sounds like maybe the api token change. https://lists.wikimedia.org/pipermail/mediawiki-api-announce/2014-August/000067.html
[17:56:12] <grrrit-wm>	 (03PS3) 10BryanDavis: New role: CategoryTree [vagrant] - 10https://gerrit.wikimedia.org/r/156585 (owner: 10Chad)
[17:56:19] <grrrit-wm>	 (03CR) 10BryanDavis: [C: 032] New role: CategoryTree [vagrant] - 10https://gerrit.wikimedia.org/r/156585 (owner: 10Chad)
[17:56:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: New role: CategoryTree [vagrant] - 10https://gerrit.wikimedia.org/r/156585 (owner: 10Chad)
[17:57:09] <grrrit-wm>	 (03PS1) 10Jdlrobson: Update Gemfile to use 0.2.1 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156588 
[17:57:26] <jdlrobson>	 marxarelli: can you merge https://gerrit.wikimedia.org/r/156588 ?
[17:57:37] <jdlrobson>	 I'm trying to get the Echo browser tests to pass :)
[17:58:00] <grrrit-wm>	 (03PS15) 10EBernhardson: G3: Mobile/nojs edit and reply full topic output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156203 
[17:59:43] <marxarelli>	 jdlrobson: i think chrismcmahon beat you to it https://gerrit.wikimedia.org/r/#/c/156561/
[18:00:04] <jdlrobson>	 :D
[18:00:20] <grrrit-wm>	 (03Abandoned) 10Jdlrobson: Update Gemfile to use 0.2.1 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156588 (owner: 10Jdlrobson)
[18:00:35] <chrismcmahon>	 jdlrobson: yep, marxarelli fixed the gem yesterday, I updated all the repos this morning
[18:00:43] <jdlrobson>	 all sorts of carnage on Flow still :( https://integration.wikimedia.org/ci/job/browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/182/
[18:00:49] <Lcawte>	 How are there still open patchsets that are a year+ old in gerrit?
[18:00:56] <jdlrobson>	 do we have any idea if things are actually broken or if there is an issue
[18:01:11] <jdlrobson>	 Lcawte: :-( personally I think any patch older than 3 months should be abandoned.
[18:01:23] <jdlrobson>	 (and that haven't been touched)
[18:01:27] <chrismcmahon>	 jdlrobson: I don't, I wrote the first-draft Flow tests but they've morphed a lot without much attention from me
[18:01:44] <jdlrobson>	 chrismcmahon: yeh I'm going to sit down with marxarelli soon
[18:02:04] <jdlrobson>	 chrismcmahon: most seem to be down to beta labs flakiness
[18:02:42] <chrismcmahon>	 jdlrobson: beta should actually be more or less OK as of yesterday, and we've throttled the number of browser tests builds so Jenkins should be more OK than usual
[18:03:01] <marxarelli>	 jdlrobson: the SocketErrors are usually due to jenkins running too many tests at once and/or saucelabs stalling
[18:04:00] <marxarelli>	 jdlrobson: we need to figure out when we can do some pairing. when are you leaving for vacation again?
[18:04:02] <chrismcmahon>	 hmm, bummer
[18:04:13] * marxarelli uses the tools at his disposal. it's called a calendar
[18:04:49] <jdlrobson>	 marxarelli: it should be in calendar yeh - i'm off thursday night, will be remote till 9th when i'll be back in office
[18:05:21] <jdlrobson>	 chrismcmahon: actually i think it has identified a real issue looking more closely at the browser tests
[18:05:28] <jdlrobson>	 this is why the flakiness sucks it masks real errors :-/
[18:05:56] <marxarelli>	 jdlrobson: ok. i'm working on an important new piece of mediawiki-selenium over the next week that i think will be useful for flow 
[18:06:11] <marxarelli>	 jdlrobson: maybe we could schedule something for when you get back
[18:06:15] <jdlrobson>	 marxarelli: exciting :D looking forward to working on that
[18:06:20] <grrrit-wm>	 (03PS10) 10MarkTraceur: Add some flow events for funnel logging [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/144588 (owner: 10Gergő Tisza)
[18:06:22] <jdlrobson>	 marxarelli: yeh that would be great
[18:06:24] <chrismcmahon>	 jdlrobson: yes. the RelEng theme for the next quarter is going to be PERFORMANCE.  I want to beef up beta labs and Jenkins
[18:06:27] <jdlrobson>	 marxarelli: we can also look at Echo
[18:06:27] <grrrit-wm>	 (03CR) 10MarkTraceur: Add some flow events for funnel logging (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/144588 (owner: 10Gergő Tisza)
[18:06:42] <jdlrobson>	 Echo and Flow are both interesting as the tests tend to involve more than 1 participant
[18:06:45] <Lcawte>	 jdlrobson: I'd prefer someone knowledgable to go through them, especially patchsets to say, core and other things...
[18:06:52] <grrrit-wm>	 (03CR) 10MarkTraceur: "Removed events, addressed comments." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/144588 (owner: 10Gergő Tisza)
[18:07:27] <marxarelli>	 jdlrobson: that's exactly the kind of pattern this new "environment abstraction layer" will address. multiple users, interwiki, etc.
[18:07:42] <chrismcmalunch>	 biab
[18:09:29] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Add configurable delay to our most frequent jobs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156449 (owner: 10Manybubbles)
[18:09:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add configurable delay to our most frequent jobs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156449 (owner: 10Manybubbles)
[18:12:01] <Lcawte>	 Who can abandon a commit, just the commiter of it?
[18:12:27] <jdlrobson>	 Lcawte: I think anyone who has +2 or the original commiter
[18:13:06] <jdlrobson>	 Lcawte: It's a shame the word "abandon" has such strong connotations. The patch is still on Gerrit it's just in some kind of hibernation mode  
[18:14:07] <jdlrobson>	 Lcawte: I've suggested abandoning patches older than 3 months before, but some people didn't seem to like that idea for some reason.
[18:14:13] <jdlrobson>	 I do it on MobileFrontend extension
[18:14:44] <jdlrobson>	 but if a patch has reached a bikeshed stalemate or the original author has disappeared and no one plans to finish it, I think it should just be abandoned.
[18:15:55] <grrrit-wm>	 (03PS4) 10Jdlrobson: Tweak checkbox sizes to be relative depending on where used. [core] - 10https://gerrit.wikimedia.org/r/154125 
[18:16:06] <grrrit-wm>	 (03PS5) 10Jdlrobson: Tweak checkbox sizes to be relative depending on where used. [core] - 10https://gerrit.wikimedia.org/r/154125 
[18:16:28] <wikibugs>	 3MediaWiki extensions / 3CentralAuth: CentralAuth/GlobalMerge: <action-centralauth-usermer ge> message needs a value - 10https://bugzilla.wikimedia.org/70064 (10Sam Reed (reedy))
[18:16:36] <grrrit-wm>	 (03PS6) 10Jdlrobson: Tweak checkbox sizes to be relative depending on where used. [core] - 10https://gerrit.wikimedia.org/r/154125 
[18:20:22] <StevenW>	 jdlrobson: now that we've decided we're not standardizing on WikiFont 100%, can you please rm your -2 at https://gerrit.wikimedia.org/r/#/c/139368/ ?
[18:20:48] <jdlrobson>	 StevenW: it's on my todo list. We still need to agree on markup though. That was my action point.
[18:21:05] <jdlrobson>	 This works in a completely different way to mobile.
[18:21:34] <jdlrobson>	 StevenW: I will be sending out an email shortly
[18:22:26] <StevenW>	 Please do.
[18:22:28] <grrrit-wm>	 (03CR) 10Gergő Tisza: "Can you revert the schema version too? Otherwise seems good to me." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/144588 (owner: 10Gergő Tisza)
[18:22:44] <jdlrobson>	 (The issue was never WikiFont vs SVG it was always about class names and markup)
[18:24:46] <grrrit-wm>	 (03CR) 10Jdlrobson: "Yep will send a mail out shortly with details of that meeting. One of my action points was to agree on some standard HTML across projects " [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx)
[18:26:57] <grrrit-wm>	 (03PS11) 10MarkTraceur: Add some flow events for funnel logging [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/144588 (owner: 10Gergő Tisza)
[18:29:04] <grrrit-wm>	 (03CR) 10Lewis Cawte: "And after over a year, this repository still contains nothing? Is this changeset being merged or is it waiting for a cleanup?" [extensions/PopupPages] - 10https://gerrit.wikimedia.org/r/51843 (owner: 10Hypergrove)
[18:30:53] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032] Adjust default parameters + documentation [search/repository-swift] - 10https://gerrit.wikimedia.org/r/156577 (owner: 10Chad)
[18:33:00] <grrrit-wm>	 (03PS1) 10Aaron Schulz: Tweaked cache size in getCachedRevisionObject() [core] - 10https://gerrit.wikimedia.org/r/156591 
[18:34:14] <grrrit-wm>	 (03PS1) 10MaxSem: Basic .pp formatting options for PhpStorm [vagrant] - 10https://gerrit.wikimedia.org/r/156592 
[18:36:05] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Stop using extract() [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/156240 (owner: 10Legoktm)
[18:36:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Stop using extract() [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/156240 (owner: 10Legoktm)
[18:36:54] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/156149 (owner: 10Umherirrender)
[18:39:30] <spagewmf>	 Reedy: Flow team needs to freeze Echo extension on group2 wikis at its current state "193307b Creating new wmf/1.24wmf16 branch" (note 1.24wmf*16*). How can we do that?
[18:41:34] <Reedy>	 spagewmf: For what time?
[18:41:50] <Reedy>	 Noting group2 are on wmf17 now,and are presumably using a wmf/1.24wmf17 branch of Echo currently?
[18:41:55] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "In mean time can you help me with readability of this code by using better examples?" (038 comments) [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx)
[18:42:37] <spagewmf>	 For tomorrow's deployment train. legoktm rolled back Echo in 1.24wmf17 to the 1.24wmf16 version.  Should we create a patch for 1.24wmf18 that points the Echo submodule to 193307b ?
[18:42:38] <grrrit-wm>	 (03PS1) 10Bsitu: Specify which event type to use job queue [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156594 
[18:43:01] <ebernhardson>	 anomie: i noticed with the latest master the flow code is now looking for prefixed csrf token params (such as nttoken) while the javascript postWithToken method still explicitly sets params.token = ...;  Wasn't sure which to file the bug against?
[18:43:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/156149 (owner: 10Umherirrender)
[18:43:11] <Lcawte>	 Krenair: Is https://gerrit.wikimedia.org/r/#/c/40283/ (bug: 37120) still an issue?
[18:43:21] <ebernhardson>	 anomie: (postWithToken is part of the core mediawiki.api)
[18:43:27] <legoktm>	 [06:59:52]  <Krinkle>	 Ugh, overwriting MW_INSTALL_PATH and abusing mwscript with path escalation out of $IP/../../../ into /home <-- I run most maint scripts that way :)
[18:43:29] <grrrit-wm>	 (03CR) 10Jdlrobson: Add icon support to mediawiki.ui (032 comments) [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx)
[18:43:37] <Krenair>	 Lcawte, I have no idea.
[18:43:49] <Reedy>	 spagewmf: Yeah, that's what I'd do. What about wmf19 branched tomorrow?
[18:43:57] <Krenair>	 Lcawte, it was a very obscure issue
[18:44:14] <spagewmf>	 Reedy: OK, will do.  It's fine for wmf19 to roll out to mediawiki.org as usual.
[18:45:08] <grrrit-wm>	 (03PS5) 10Umherirrender: Add missing @return and @param to doc blocks [core] - 10https://gerrit.wikimedia.org/r/156142 
[18:46:15] <anomie>	 ebernhardson: Was it ever not using prefixed tokens since legoktm fixed action=flow?
[18:46:28] <grrrit-wm>	 (03PS3) 10Umherirrender: Remove unneeded spaces inside html in NoLocalSettings.php [core] - 10https://gerrit.wikimedia.org/r/153635 
[18:46:33] * legoktm reads up
[18:46:34] <grrrit-wm>	 (03PS4) 10Umherirrender: Remove unneeded spaces inside html in NoLocalSettings.php [core] - 10https://gerrit.wikimedia.org/r/153635 
[18:46:45] <ebernhardson>	 anomie: yes, its been using unprefixed tokens even with lego's changes.  so it sounds like mediawiki.api.postWithToken should be prefixing?
[18:47:04] <legoktm>	 no, 'token' shouldn't be prefixed
[18:47:25] <Lcawte>	 Krenair: Hmm, not happy with the length of "status:open age:6month" on gerrit, just looking for people to pester about things.
[18:47:42] <legoktm>	 oh hmmmmm
[18:47:51] <Lcawte>	 legoktm: Abandon this? https://gerrit.wikimedia.org/r/#/c/97382/
[18:48:08] <grrrit-wm>	 (03Abandoned) 10Legoktm: Add bottrop variant by L. Diener [extensions/SimpleAntiSpam] (bottrop) - 10https://gerrit.wikimedia.org/r/97382 (owner: 10Legoktm)
[18:48:45] <Lcawte>	 1 down... pages to go ;)
[18:49:10] <anomie>	 ebernhardson, legoktm: Ok, I think I misunderstood what the code was doing when I wrote Ia28a8497. I'll see about fixing it.
[18:49:11] <grrrit-wm>	 (03PS1) 10Bsitu: Use job queue to process Flow notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156598 
[18:52:04] <legoktm>	 Krinkle: thanks for getting it properly deployed though
[18:52:46] <grrrit-wm>	 (03PS6) 10Umherirrender: Use Database::makeWhereFrom2d in LinkHolderArray::replaceInternal [core] - 10https://gerrit.wikimedia.org/r/143713 
[18:53:15] <grrrit-wm>	 (03CR) 10Umherirrender: "Patch Set 6: Rebased" [core] - 10https://gerrit.wikimedia.org/r/143713 (owner: 10Umherirrender)
[18:53:32] <grrrit-wm>	 (03PS1) 10EBernhardson: Temporarily override token name prefixing [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156600 
[18:54:13] <ebernhardson>	 anomie: thanks!
[18:54:18] <anomie>	 legoktm, ebernhardson: ... This would be a lot easier if action=flow could just always use a token, instead of using one sometimes and sometimes not.
[18:54:47] <ebernhardson>	 hmm, we could perhaps add a second module, so there is a read module and a write module?
[18:54:54] <ebernhardson>	 seems odd to require a csrf for reads
[18:55:04] <Reedy>	 read modules are usually action=query submodules
[18:55:23] <anomie>	 ebernhardson: ^ What Reedy said
[18:55:35] <Reedy>	 I think there might be a couple of exceptions
[18:55:39] <ebernhardson>	 legoktm: ^ ?
[18:56:00] <Krinkle>	 legoktm: I don't know of an official policy, but if it were me, I'd say *never* run scripts without !log'ing. Running scripts using that kind of hack sounds irresponsible to me, and also hard for people to track down. I think the hacks required to make it work kind of indicate that one isn't supposed to do that. Maybe quick experiments via eval.php or if it's an office action.
[18:56:21] <Krinkle>	 But if it's just a low-priority script, I'd recommend not running stuff like that, ever.
[18:56:59] <legoktm>	 making it an action=query module would be a nice thing, but the read and write modules shared a lot of common code and I couldn't really think of a good way to make that work without just having them be one large submodule
[18:57:16] <legoktm>	 also, when I first started writing it, action=flow was just write stuff, and then we added some read modules to it
[18:58:13] <wikibugs>	 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Elasticsearch 1.3 upgrade issues - 10https://bugzilla.wikimedia.org/69620#c1 (10Nik Everett) 5NEW>3RESO/FIX Noop detection didn't make it to 1.3 but we implemented it in a script and we did port all scripts to groovy.
[18:58:36] <legoktm>	 Krinkle: I did !log it, just not for every user because I thought that would have been a bit overkill:  16:36 legoktm: running removeOldManualUserPages.php (GlobalCssJs) for users who requested it
[18:58:46] <Krinkle>	 cool
[18:59:38] <renoirb>	 How did you succeed to install SMW on wikitech?
[18:59:45] <renoirb>	 Its always breaking with mine
[18:59:54] <grrrit-wm>	 (03CR) 10Lewis Cawte: [C: 04-1] "Mark, can you either update this patch or abandon it please as the code is no longer in Comment.php." [extensions/Comments] - 10https://gerrit.wikimedia.org/r/63257 (owner: 10MarkAHershberger)
[19:00:13] * renoirb is using vagrant, trying to figure out how to have it through mediawiki::extension
[19:00:31] <grrrit-wm>	 (03CR) 10Chad: [V: 032] Adjust default parameters + documentation [search/repository-swift] - 10https://gerrit.wikimedia.org/r/156577 (owner: 10Chad)
[19:01:44] <wikibugs>	 3Wikimedia / 3Site requests: Change $wgPasswordDefault to PBKDF2 on WMF wikis - 10https://bugzilla.wikimedia.org/68766#c4 (10db) Maybe it is possible to keep/set PBKDF2 on labs wikis for testing and only set to md5 for production.
[19:02:22] <grrrit-wm>	 (03PS1) 10MaxSem: Add a role that converts all PHP warnings/notices into errors [vagrant] - 10https://gerrit.wikimedia.org/r/156602 
[19:02:35] <legoktm>	 renoirb: I think SMW on wikitech is pinned to a specific version. you can ask andrewbogott in #wikimedia-labs, he's the one who maintains wikitech
[19:02:52] <renoirb>	 oh, thx legoktm !
[19:03:08] <anomie>	 legoktm, ebernhardson: Hmm. So it probably doesn't make a whole lot of sense to have the flow read actions being a query submodule, since action=query&meta=flow&flowsubmodule=... is kind of silly when we could do action=flowquery. If you want to keep them all in action=flow, it would basically mean reimplementing the core token handling because core doesn't have a way to conditionally have action=flow take a token.
[19:03:24] <renoirb>	 I'm going through a puppet call such as mediawiki::extension { 'SemanticMediaWiki': branch =>  '1.8.0.5', }
[19:03:53] <legoktm>	 +1 to flowquery
[19:04:04] <ebernhardson>	 anomie: that sounds fair,  i'll poke at a flowquery couldn't be that hard
[19:06:08] <grrrit-wm>	 (03PS2) 10Mwjames: Add composer.json [skins/Vector] - 10https://gerrit.wikimedia.org/r/152927 
[19:06:13] <grrrit-wm>	 (03CR) 10Martineznovo: "Please abandon this change since latest code already includes this modification" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/22550 (owner: 10Yaron Koren)
[19:07:16] <grrrit-wm>	 (03CR) 10Lewis Cawte: "All of these skins now have their own repositories and this one is meant to be getting blanked. Can someone split this change up and commi" [extensions/skins] - 10https://gerrit.wikimedia.org/r/154701 (owner: 10Addshore)
[19:07:41] <anomie>	 ebernhardson: With a little trickery you can have the ApiFlow implement both action=flow and action=flowquery: just check $action in the constructor to set the return value of needsToken() (false or 'csrf') and use the appropriate list of submodules. Then everything about needsToken can be removed from ApiFlowBase and all the token checking can be removed from ApiFlow::execute().
[19:08:00] <wikibugs>	 3Wikimedia / 3General/Unknown: Unable to login and reset password: "Invalid hash given" in all cases - 10https://bugzilla.wikimedia.org/70098 (10Sergei S. Rublev) 3UNCO p:3Unprio s:3major a:3None Created attachment 16294   --> https://bugzilla.wikimedia.org/attachment.cgi?id=16294&action=edit Unable...
[19:08:37] <anomie>	 Oh, and getExamples would change output too.
[19:08:43] <grrrit-wm>	 (03CR) 10Mwjames: Add composer.json (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/152927 (owner: 10Mwjames)
[19:10:58] <wikibugs>	 3Wikimedia / 3General/Unknown: Unable to login and reset password: "Invalid hash given" in all cases - 10https://bugzilla.wikimedia.org/70098 (10Jesús Martínez Novo (Ciencia Al Poder)) p:5Unprio>3High
[19:11:28] <wikibugs>	 3MediaWiki / 3Unit tests: RCCacheEntryFactoryTest causes test errors because it uses a deprecated assert method - 10https://bugzilla.wikimedia.org/69505 (10db) 5PATC>3RESO/FIX
[19:11:53] <wikibugs>	 3MediaWiki extensions / 3Scribunto: LuaSandbox reports substantially higher memory utilization under HHVM - 10https://bugzilla.wikimedia.org/70006#c1 (10Ori Livneh) Created attachment 16295   --> https://bugzilla.wikimedia.org/attachment.cgi?id=16295&action=edit pprof trace of allocations during life-cycle o...
[19:12:01] <Lcawte>	 There's like half a page of open change sets from marktraceur on UploadWizard that are 3+ months old :O
[19:12:44] <marktraceur>	 Lcawte: Only half a page?
[19:12:46] <marktraceur>	 Shocking
[19:14:20] <Lcawte>	 It's between other users and across multiple pages... but other than like gerrit and wp zero repos, I don't think I've seen that many commits to the same repo open for longer than 3 months without change by the same user...
[19:16:41] <grrrit-wm>	 (03PS2) 10EBernhardson: Temporarily override token name prefixing [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156600 
[19:16:51] <grrrit-wm>	 (03PS1) 10Manybubbles: Fix some broken tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156605 
[19:19:53] <grrrit-wm>	 (03CR) 10BryanDavis: Add a role that converts all PHP warnings/notices into errors (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/156602 (owner: 10MaxSem)
[19:19:58] <grrrit-wm>	 (03PS1) 10Manybubbles: Don't add interwiki results to null [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156607 (https://bugzilla.wikimedia.org/68887) 
[19:20:09] <marktraceur>	 Lcawte: 'cause I got caught up in other stuff....happens a lot for me
[19:21:13] <wikibugs>	 3MediaWiki extensions / 3CirrusSearch: internal_api_error_BadMethodCallException from GettingStarted morelike task type - 10https://bugzilla.wikimedia.org/68887#c4 (10Nik Everett) Thanks for the easy reproduction steps.  Sorry it took me so long to get to.
[19:21:15] <grrrit-wm>	 (03CR) 10Krinkle: [C: 04-1] Clean up mediawiki.legacy.upload a bit more (039 comments) [core] - 10https://gerrit.wikimedia.org/r/156552 (https://bugzilla.wikimedia.org/31946) (owner: 10Alex Monk)
[19:21:52] <grrrit-wm>	 (03CR) 10Legoktm: [C: 031] "Haven't tested, but I like this approach much better." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156594 (owner: 10Bsitu)
[19:26:57] <grrrit-wm>	 (03CR) 10Krinkle: [C: 04-1] Correct output of wfMessage( 'non-existent-msg' )->text() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/137458 (https://bugzilla.wikimedia.org/66199) (owner: 10EBernhardson)
[19:29:11] <qgil>	 andre__, chasemp  hi, I just created a task without being a the Triagers project: http://fab.wmflabs.org/T566
[19:29:58] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: Exception from line 84 WikiPageEntityRevisionLookup.php: Unresolved redirect - 10https://bugzilla.wikimedia.org/70034 (10John F. Lewis) p:5Unprio>3Normal
[19:30:05] <chasemp>	 qgil: we already changed the perms to make it work 
[19:30:05] <andre__>	 qgil: oh, I can also create a task in that project.
[19:30:17] <andre__>	 chasemp, oh you did? heh. :)
[19:30:19] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: Exception from line 84 WikiPageEntityRevisionLookup.php: Unresolved redirect - 10https://bugzilla.wikimedia.org/70034 (10John F. Lewis) 5PATC>3RESO/FIX
[19:30:21] <andre__>	 guess I miseed that line
[19:30:23] <grrrit-wm>	 (03CR) 10Krinkle: Temporarily override token name prefixing (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156600 (owner: 10EBernhardson)
[19:30:28] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: Exception from line 201 of EntityContentDataCodec.php when running dumpJson script - 10https://bugzilla.wikimedia.org/69846 (10John F. Lewis) 5PATC>3RESO/FIX p:5Unprio>3Normal
[19:30:29] <chasemp>	 the problem is creating a new task goes through the edit workflow
[19:30:34] <chasemp>	 under the covers I imagine
[19:30:44] <chasemp>	 so if you say only foo can edit, it seems to mean only foo can create
[19:31:29] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: Search gets disturbed by live preview - 10https://bugzilla.wikimedia.org/69674 (10John F. Lewis) 5PATC>3RESO/FIX p:5Unprio>3Normal
[19:31:45] <qgil>	 hm, let me see the policies again...
[19:31:52] <grrrit-wm>	 (03CR) 10Krinkle: Kill auto-mention in favor of subscriptions (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156467 (owner: 10EBernhardson)
[19:31:58] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: date in claim diff formatted as timestamp - 10https://bugzilla.wikimedia.org/70086 (10John F. Lewis) p:5Unprio>3Low
[19:32:17] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: Allow middle click on suggester - 10https://bugzilla.wikimedia.org/69908 (10John F. Lewis) p:5Unprio>3Low
[19:32:28] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: Allow middle click on suggester - 10https://bugzilla.wikimedia.org/69908 (10John F. Lewis) s:5normal>3minor
[19:32:55] <qgil>	 chasemp, andre__ I will touch the policies right now, and I will revert, only to test a couple of combinations
[19:33:04] <andre__>	 alright :)
[19:33:06] <chasemp>	 k
[19:34:18] <wikibugs>	 3MediaWiki extensions / 3CirrusSearch: Malayalam chillu characters in the query doesn't appear bold in results. - 10https://bugzilla.wikimedia.org/60009#c7 (10Nik Everett) 5NEW>3RESO/FIX I just tried this and it looks like it works with cirrus.  I don't think it is related to bug 22371.  At least, not an...
[19:34:27] <Lcawte>	 Is there any way to search open patchsets for say, all the skins repositories without manually adding the relevant project: for every one?
[19:34:40] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Don't add interwiki results to null [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156607 (https://bugzilla.wikimedia.org/68887) (owner: 10Manybubbles)
[19:34:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't add interwiki results to null [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156607 (https://bugzilla.wikimedia.org/68887) (owner: 10Manybubbles)
[19:36:01] <chasemp>	 qgil, andre__ what we could do is make an extension that sets teh generic permission on new tasks to edit by the user and triage, and view as public
[19:36:08] <chasemp>	 and bypass the stock default setting
[19:36:13] <wikibugs>	 3MediaWiki extensions / 3CirrusSearch: internal_api_error_BadMethodCallException from GettingStarted morelike task type - 10https://bugzilla.wikimedia.org/68887 (10Nik Everett) 5PATC>3RESO/FIX
[19:36:28] <wikibugs>	 3Wikimedia / 3General/Unknown: Unable to login and reset password: "Invalid hash given" in all cases - 10https://bugzilla.wikimedia.org/70098#c1 (10Sam Reed (reedy)) Which Wiki is he using?  I note he seems to have a :A: password on commonswiki, but on enwiki user_password is unprefixed, but user_newpassword...
[19:36:29] <chasemp>	 that would mean you can create your own tasks but once created they are not open to chicanry
[19:36:30] <chasemp>	 idk
[19:36:43] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: Redirects - Try to detect and auto fix double redirects before they happen - 10https://bugzilla.wikimedia.org/69167 (10John F. Lewis) p:5Unprio>3Low
[19:37:28] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: Replace base classes ApiWikibase, ModifyEntity, ModifyClaim, etc. with composable objects. - 10https://bugzilla.wikimedia.org/69001 (10John F. Lewis) p:5Unprio>3Normal
[19:37:37] <andre__>	 qgil, meh, your test in http://fab.wmflabs.org/T566 has Priority: 0
[19:37:45] <andre__>	 and I cannot change priority. can you?
[19:37:59] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: Refactor API tests to avoid database access - 10https://bugzilla.wikimedia.org/68917 (10John F. Lewis) p:5Unprio>3Normal
[19:38:13] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: Wikidata API for wbeditentity ignores order of claims when claims already exist? - 10https://bugzilla.wikimedia.org/68729 (10John F. Lewis) p:5Unprio>3Normal
[19:38:28] <wikibugs>	 3Wikimedia / 3General/Unknown: Unable to login and reset password: "Invalid hash given" in all cases - 10https://bugzilla.wikimedia.org/70098#c2 (10Sergei S. Rublev) The main goal now is to login to Commons. He says he remembers he was activating SUL...
[19:38:54] <andre__>	 bleh, and if I get the dropdown to change priority, I get an error that I don't have the "Can Prioritize Tasks" of course
[19:39:00] * andre__ postpones to tomorrow
[19:39:23] <chasemp>	 I can't close tasks again, etc
[19:39:25] <spagewmf>	 Trying to checkout a clean wmf18, `cd core; git checkout wmf/1.24wmf18; git submodule update vendor` fails, I think because the vendor repo moved from mediawiki/core/vendor.git to mediawiki/vendor.git.
[19:40:18] <legoktm>	 spagewmf: $ git submodule sync
[19:40:23] <legoktm>	 then try again
[19:40:31] <wikibugs>	 3MediaWiki extensions / 3WikidataClient: Special:UnconnectedPages should be includable - 10https://bugzilla.wikimedia.org/70018 (10John F. Lewis) p:5Unprio>3Normal
[19:40:53] <qgil>	 chasemp, andre__ "Edit task status" is the permission that impedes to create new tasks, I set it to All Users.
[19:41:01] <wikibugs>	 3MediaWiki extensions / 3WikidataClient: have magic word for pages which their lang link shouldn't change after move - 10https://bugzilla.wikimedia.org/68947 (10John F. Lewis) p:5Unprio>3Low
[19:41:42] <qgil>	 http://fab.wmflabs.org/T569 was created correctly 
[19:41:55] <spagewmf>	 legoktm: thanks, `git submodule sync` is new to me.   I manually edited core/.git/modules/vendor/config
[19:42:00] <grrrit-wm>	 (03PS3) 10EBernhardson: Temporarily override token name prefixing [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156600 
[19:43:09] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Add composer.json (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/152927 (owner: 10Mwjames)
[19:43:09] <qgil>	 andre__, chasemp Can Assign Tasks: Triagers | Can Prioritize Tasks: Triagers works as intended. I think we can keep it.
[19:43:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add composer.json [skins/Vector] - 10https://gerrit.wikimedia.org/r/152927 (owner: 10Mwjames)
[19:43:38] <chasemp>	 ok, I will leave how you have it unless I run into an issue then I'll let you know if I needed to change something?
[19:44:43] <wikibugs>	 3MediaWiki extensions / 3WikidataClient: Special:UnconnectedPages should show wikidata's notable pages - 10https://bugzilla.wikimedia.org/68946#c1 (10John F. Lewis) 5NEW>3RESO/WON p:5Unprio>3Normal Quick chat with Lydia. WONTFIX in favour of the depends on linked by John above.
[19:44:53] <qgil>	 chasemp, ok, if you have problems please report them at http://fab.wmflabs.org/T64
[19:45:01] <chasemp>	 will do
[19:45:05] <qgil>	 thanks
[19:45:30] <wikibugs>	 3MediaWiki extensions / 3SemanticForms: wikiEditor not loading in a Semantic Form - 10https://bugzilla.wikimedia.org/70057#c2 (10ryan.glasnapp) If I comment out the entire if statement, it still breaks.   If I just comment out the "if" parts, and leave the window.ext = {} it works.
[19:46:43] <wikibugs>	 3Datasets / 3General/Unknown: Wikidata JSON dump: better compression than gzip - 10https://bugzilla.wikimedia.org/68793 (10John F. Lewis) p:5Unprio>3Normal
[19:46:58] <grrrit-wm>	 (03PS4) 10EBernhardson: Temporarily override token name prefixing [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156600 
[19:47:28] <wikibugs>	 3MediaWiki extensions / 3Capiunto: performance review for Capiunto - 10https://bugzilla.wikimedia.org/69540 (10John F. Lewis) p:5Unprio>3Normal
[19:47:33] <qgil>	 andre__, http://fab.wmflabs.org/T566 might have gone wrong because I created it with a page that I had open with the previous permissions (stricted to Triagers) when chasemp had reverted to AllUsers. That's all. The other tests done when I was touching permissions are all NeedsTriage.
[19:47:56] <chasemp>	 seems good for restricting who can set priority for sure
[19:47:58] <chasemp>	 like that a lot
[19:49:43] * Lcawte stabs ResourceLoader
[19:50:06] <Lcawte>	 Why won't you embed my skin images :(
[19:50:07] <grrrit-wm>	 (03PS12) 10MarkTraceur: Add some flow events for funnel logging [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/144588 (owner: 10Gergő Tisza)
[19:50:25] <grrrit-wm>	 (03CR) 10Mwjames: Add composer.json (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/152927 (owner: 10Mwjames)
[19:50:32] <qgil>	 chasemp, andre__ the dropdown in comments has also less options, and of course also the "Edit task" ui. Neat.
[19:51:45] <wikibugs>	 3Wikimedia / 3General/Unknown: Unable to login and reset password: "Invalid hash given" in all cases - 10https://bugzilla.wikimedia.org/70098#c3 (10Sergei S. Rublev) Not completely sure about SUL though. He says years ago he was creating same-username account on several wikis.  He says: on commonswiki, enwik...
[19:53:29] <chasemp>	 qgil, andre.  (I spoke with andre about doing this before hand) but wanted to drop a heads up on the editing madness I had going on.  In order to really get my ducks in a row I rearranged things like this:  http://fab.wmflabs.org/tag/phabricator/ (all phabricator related tasks), http://fab.wmflabs.org/tag/wikimedia_phabricator_day_1/ (tasks that are part of a day 1 phabricator existing in production), http://fab.wmflabs
[19:53:30] <chasemp>	 .org/tag/bugzilla-migration/ (tasks that are bugzilla migration related), http://fab.wmflabs.org/tag/rt-migration/ (tasks that are rt migration related).  I believe this more accurately displays what "day 1" means, while grouping all phab things and breaking out bugzilla migration from rt migration as well.
[19:53:47] <chasemp>	 in doing all of that I am going to write up my impressions of the remaining http://fab.wmflabs.org/tag/wikimedia_phabricator_day_1/ things
[19:53:55] <andre__>	 qgil: and you probably want to watch those new projects
[19:53:57] <chasemp>	 and what to expect / what's really left
[19:54:23] <andre__>	 (and of course thanks chasemp for splitting stuff)
[19:55:28] <grrrit-wm>	 (03CR) 10Krinkle: [C: 04-1] Add missing @return and @param to doc blocks (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156142 (owner: 10Umherirrender)
[19:55:36] <grrrit-wm>	 (03CR) 10Legoktm: "I created <https://packagist.org/packages/mediawiki/vector-skin> and set up the Github service hook for it. Let me know if I need to do an" [skins/Vector] - 10https://gerrit.wikimedia.org/r/152927 (owner: 10Mwjames)
[19:55:42] <grrrit-wm>	 (03PS3) 10EBernhardson: mediawiki.debug: Fix crash in browsers without Function#bind [core] - 10https://gerrit.wikimedia.org/r/156215 
[19:56:09] <grrrit-wm>	 (03CR) 10Krinkle: Add missing @return and @param to doc blocks (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156142 (owner: 10Umherirrender)
[19:56:17] <wikibugs>	 3MediaWiki / 3General/Unknown: MediaWiki 2.0 (tracking) - 10https://bugzilla.wikimedia.org/70000 (10Étienne Beaulé)
[19:56:17] <wikibugs>	 3Wikimedia / 3General/Unknown: Unable to login and reset password: "Invalid hash given" in all cases - 10https://bugzilla.wikimedia.org/70098#c4 (10Sergei S. Rublev) He says there is no email confirmation when he tyes correct password. He immediately gets dialog presented at screenshot.
[19:56:27] <grrrit-wm>	 (03CR) 10Yaron Koren: "That's great to hear! Abandoning it now." [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/22550 (owner: 10Yaron Koren)
[19:56:36] <grrrit-wm>	 (03Abandoned) 10Yaron Koren: Fix so that Asirra can work for editing, not just user registration [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/22550 (owner: 10Yaron Koren)
[19:57:54] <grrrit-wm>	 (03PS6) 10Krinkle: Add missing @return and @param to doc blocks [core] - 10https://gerrit.wikimedia.org/r/156142 (owner: 10Umherirrender)
[19:58:02] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Add missing @return and @param to doc blocks [core] - 10https://gerrit.wikimedia.org/r/156142 (owner: 10Umherirrender)
[19:58:48] <wikibugs>	 3MediaWiki skins / 3Vector: h3 header weight makes h3s look more important than h2s - 10https://bugzilla.wikimedia.org/69998 (10Étienne Beaulé)
[19:58:48] <wikibugs>	 3MediaWiki skins / 3MonoBook: h3 header weight makes h3s look more important than h2s - 10https://bugzilla.wikimedia.org/69999 (10Étienne Beaulé)
[20:04:21] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 031] "Tested, works fine. A few minor things:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/144588 (owner: 10Gergő Tisza)
[20:05:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add missing @return and @param to doc blocks [core] - 10https://gerrit.wikimedia.org/r/156142 (owner: 10Umherirrender)
[20:07:10] <grrrit-wm>	 (03PS1) 10Lewis Cawte: Embed images + tweaks [skins/Daddio] - 10https://gerrit.wikimedia.org/r/156672 
[20:13:27] <grrrit-wm>	 (03CR) 10Jack Phoenix: [C: 032 V: 032] Embed images + tweaks [skins/Daddio] - 10https://gerrit.wikimedia.org/r/156672 (owner: 10Lewis Cawte)
[20:14:40] <grrrit-wm>	 (03PS1) 10Amire80: WIP: Registry update [services/cxserver] - 10https://gerrit.wikimedia.org/r/156675 
[20:18:24] <grrrit-wm>	 (03PS1) 10Spage: Freeze Flow and Echo extensions for group2 wikis [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156678 
[20:18:30] <grrrit-wm>	 (03PS1) 10Anomie: API: Internal cleanup [core] - 10https://gerrit.wikimedia.org/r/156679 
[20:19:30] <grrrit-wm>	 (03CR) 10Mwjames: "Thanks." [skins/Vector] - 10https://gerrit.wikimedia.org/r/152927 (owner: 10Mwjames)
[20:22:47] <jackmcbarn>	 anomie: what's the process for deploying a new version of LuaSandbox to production?
[20:24:13] <anomie>	 jackmcbarn: Someone with appropriate access (which doesn't include me) has to build a new Debian package and put it in the private repo. Then I don't know if it gets updated automatically or if they have to run some script to get everything to update to it..
[20:24:54] <jackmcbarn>	 anomie: i'm reviewing and testing your https://gerrit.wikimedia.org/r/#/c/84985/ now. assuming i +2 it, who would i bug to get it deployed?
[20:25:18] <anomie>	 jackmcbarn: Ops or Tim.
[20:25:34] <jackmcbarn>	 kk
[20:29:07] <grrrit-wm>	 (03CR) 10MaxSem: Add a role that converts all PHP warnings/notices into errors (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/156602 (owner: 10MaxSem)
[20:29:10] <grrrit-wm>	 (03CR) 10Chad: [C: 032] API: Internal cleanup [core] - 10https://gerrit.wikimedia.org/r/156679 (owner: 10Anomie)
[20:29:26] <grrrit-wm>	 (03CR) 10PleaseStand: Indicate the actual version of HHVM in use (032 comments) [core] - 10https://gerrit.wikimedia.org/r/151962 (owner: 10PleaseStand)
[20:29:40] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Fix some broken tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156605 (owner: 10Manybubbles)
[20:29:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix some broken tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156605 (owner: 10Manybubbles)
[20:30:45] <manybubbles>	 ^d: thanks!
[20:33:13] <wikibugs>	 3Wikimedia / 3General/Unknown: Unable to login and reset password: "Invalid hash given" in all cases - 10https://bugzilla.wikimedia.org/70098#c5 (10Chris Steipp) Well something is definitely wrong... Yustas'es password is :A: type, but has a salt stored with it. That shouldn't ever happen.  The password api...
[20:34:30] <grrrit-wm>	 (03CR) 10BryanDavis: Add a role that converts all PHP warnings/notices into errors (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/156602 (owner: 10MaxSem)
[20:35:14] <wikibugs>	 3Wikimedia / 3General/Unknown: Unable to login and reset password: "Invalid hash given" in all cases - 10https://bugzilla.wikimedia.org/70098#c6 (10Chris Steipp) (In reply to Sergei S. Rublev from comment #3) > Not completely sure about SUL though. He says years ago he was creating > same-username account on...
[20:35:41] <grrrit-wm>	 (03PS1) 10IAlex: Remove the sub page when using the form in Special:ListFiles [core] - 10https://gerrit.wikimedia.org/r/156684 
[20:35:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: API: Internal cleanup [core] - 10https://gerrit.wikimedia.org/r/156679 (owner: 10Anomie)
[20:38:25] <grrrit-wm>	 (03PS1) 10Manybubbles: Morelike improvements [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156686 (https://bugzilla.wikimedia.org/68541) 
[20:38:47] <grrrit-wm>	 (03PS4) 10Anomie: API: Add "batchcomplete" to simplified continuation result [core] - 10https://gerrit.wikimedia.org/r/152359 
[20:38:59] <grrrit-wm>	 (03PS3) 10Anomie: API: generalized submodules for action=paraminfo [core] - 10https://gerrit.wikimedia.org/r/154148 
[20:39:13] <grrrit-wm>	 (03PS2) 10Anomie: API: Add prop modules for backlinks [core] - 10https://gerrit.wikimedia.org/r/155592 
[20:39:28] <wikibugs>	 3Wikimedia / 3General/Unknown: Unable to login and reset password: "Invalid hash given" in all cases - 10https://bugzilla.wikimedia.org/70098#c7 (10Sergei S. Rublev) Well, we're not able to properly understand some of the technical terms. Can you please give us some simple instructions on what to do, if need...
[20:39:34] <grrrit-wm>	 (03PS1) 10Anomie: API: Organize classes [core] - 10https://gerrit.wikimedia.org/r/156687 
[20:40:43] <wikibugs>	 3MediaWiki extensions / 3CirrusSearch: "text search is disabled" error sometimes shown when morelike: is used (because it's a redirect?) - 10https://bugzilla.wikimedia.org/68541#c4 (10Nik Everett) This fixes the problem for redirects - they now resolve.  Newly created pages that have not yet been indexed wil...
[20:40:49] <grrrit-wm>	 (03PS1) 10IAlex: Use as strict comparison to check whether an user name was provided in Special:ListFiles [core] - 10https://gerrit.wikimedia.org/r/156688 
[20:41:35] <wikibugs>	 3MediaWiki extensions / 3CirrusSearch: CirrusSearch appears twice in srbackend paraminfo - 10https://bugzilla.wikimedia.org/69517 (10Nik Everett) a:3Nik Everett
[20:41:58] <wikibugs>	 3MediaWiki extensions / 3CirrusSearch: CirrusSearch appears twice in srbackend paraminfo - 10https://bugzilla.wikimedia.org/69517 (10Nik Everett) 5NEW>3ASSI
[20:43:26] <qgil>	 chasemp, believe it or not, I did check https://en.wikipedia.org/wiki/POC and I found three potential candidates  :)
[20:43:58] <wikibugs>	 3MediaWiki skins / 3Vector: Vector: h3 should appear as heavier weight than h2 - 10https://bugzilla.wikimedia.org/69998 (10Krinkle)
[20:44:18] <wikibugs>	 3MediaWiki skins / 3MonoBook: MonoBook: h3 should appear as heavier weight than h2 - 10https://bugzilla.wikimedia.org/69999 (10Krinkle)
[20:44:28] <wikibugs>	 3MediaWiki skins / 3MonoBook: MonoBook: h3 should not appear as heavier weight than h2 - 10https://bugzilla.wikimedia.org/69999 (10Krinkle)
[20:44:33] <wikibugs>	 3MediaWiki skins / 3Vector: Vector: h3 should not appear as heavier weight than h2 - 10https://bugzilla.wikimedia.org/69998 (10Krinkle)
[20:44:34] <chasemp>	 qgil: heh, in government circles it always followed rfc, we need an rfc to poc this
[20:45:40] <grrrit-wm>	 (03CR) 10Foxtrott: "FWIW and not sure you are aware of that: You don't absolutely HAVE to do use github. WMF's repos will do just as well. See https://packagi" [skins/Vector] - 10https://gerrit.wikimedia.org/r/152927 (owner: 10Mwjames)
[20:46:56] <grrrit-wm>	 (03CR) 10Legoktm: "Right, but I don't think gerrit/gitblit will automatically notify packagist when something updates like github does?" [skins/Vector] - 10https://gerrit.wikimedia.org/r/152927 (owner: 10Mwjames)
[20:47:15] <qgil>	 government circles and me...
[20:48:15] <grrrit-wm>	 (03CR) 10Krinkle: mediawiki.api: Support assert parameter in getToken and postWithToken (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156093 (owner: 10Nikerabbit)
[20:48:23] <grrrit-wm>	 (03CR) 10Alex Monk: Clean up mediawiki.legacy.upload a bit more (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156552 (https://bugzilla.wikimedia.org/31946) (owner: 10Alex Monk)
[20:48:34] <grrrit-wm>	 (03CR) 10Foxtrott: "Hmm, good point. Probably not. I usually update manually." [skins/Vector] - 10https://gerrit.wikimedia.org/r/152927 (owner: 10Mwjames)
[20:49:05] <grrrit-wm>	 (03CR) 10Krinkle: "From jenkins:" [core] - 10https://gerrit.wikimedia.org/r/156093 (owner: 10Nikerabbit)
[20:49:38] <grrrit-wm>	 (03CR) 10Jdlrobson: "Please swap the order shahyar as per my comment so we can keep this moving!" [core] - 10https://gerrit.wikimedia.org/r/155856 (owner: 10SG)
[20:50:13] <wikibugs>	 3Wikimedia / 3General/Unknown: Unable to login and reset password: "Invalid hash given" in all cases - 10https://bugzilla.wikimedia.org/70098#c8 (10Chris Steipp) (In reply to Chris Steipp from comment #6) > Yeah, we have a hook doing that, since their on the list of users who's > password hashes were leaked....
[20:50:15] <grrrit-wm>	 (03PS2) 10Jdlrobson: Change mw-ui anchors to require mw-ui-anchor base class [core] - 10https://gerrit.wikimedia.org/r/155856 (owner: 10SG)
[20:51:11] <grrrit-wm>	 (03PS2) 10Alex Monk: Clean up mediawiki.legacy.upload a bit more [core] - 10https://gerrit.wikimedia.org/r/156552 (https://bugzilla.wikimedia.org/31946) 
[20:52:02] <jackmcbarn>	 anomie: one quick question about that patch: is there a reason that an error from the next function doesn't appear in the stack trace, even though the error message itself indicates exactly where it is?
[20:52:32] <anomie>	 jackmcbarn: Offhand, I have no idea
[20:53:47] <grrrit-wm>	 (03CR) 10Jdlrobson: "if we can work towards this - http://i.imgur.com/bieQ9zn.jpg - i think this will satisfy flow, mobile and your needs." [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx)
[20:54:05] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] mediawiki.debug: Fix crash in browsers without Function#bind [core] - 10https://gerrit.wikimedia.org/r/156215 (owner: 10EBernhardson)
[20:54:30] <jackmcbarn>	 i'll leave a comment on the patchset about it
[20:54:51] <grrrit-wm>	 (03CR) 10Jackmcbarn: "Here's what an error from the next function looks like:" [php/luasandbox] - 10https://gerrit.wikimedia.org/r/84985 (owner: 10Anomie)
[20:54:56] <grrrit-wm>	 (03CR) 10saper: "Me bad - I tested the wrong branch :)" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/156350 (https://bugzilla.wikimedia.org/70030) (owner: 10Jjanes)
[20:55:19] <grrrit-wm>	 (03CR) 10Rush: [C: 04-1] "when I try I get an exception trying to create a new ticket:" [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/154850 (owner: 10Rush)
[20:55:56] <grrrit-wm>	 (03CR) 10Foxtrott: "From https://packagist.org/about:" [skins/Vector] - 10https://gerrit.wikimedia.org/r/152927 (owner: 10Mwjames)
[20:56:13] <wikibugs>	 3Wikimedia / 3General/Unknown: Unable to login and reset password: "Invalid hash given" in all cases - 10https://bugzilla.wikimedia.org/70098#c9 (10Sergei S. Rublev) Got it! He says he has successfully logged in first on commons, then on several wikis.  Thank you very much!
[20:57:16] <grrrit-wm>	 (03PS1) 10Manybubbles: Clean up options with betafeature [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156691 (https://bugzilla.wikimedia.org/69517) 
[20:58:28] <wikibugs>	 3MediaWiki extensions / 3CirrusSearch: CirrusSearch appears twice in srbackend paraminfo - 10https://bugzilla.wikimedia.org/69517#c8 (10Nik Everett) A day or two turned into two weeks but who is counting now that there is a patch.
[20:59:45] <grrrit-wm>	 (03CR) 10Rush: "that includes selecting 'none' for security so...weird" [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/154850 (owner: 10Rush)
[21:00:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: mediawiki.debug: Fix crash in browsers without Function#bind [core] - 10https://gerrit.wikimedia.org/r/156215 (owner: 10EBernhardson)
[21:00:17] <wikibugs>	 3MediaWiki extensions / 3CirrusSearch: Stemming: CirrusSearch does not find Биология for a Биологии query on ru.wp (but LuceneSearch does) - 10https://bugzilla.wikimedia.org/69766 (10Nik Everett) 5NEW>3ASSI a:3Nik Everett
[21:01:01] <Lcawte>	 Can someone point me to some docs/walk me through how to rebase something like https://gerrit.wikimedia.org/r/#/c/143173/ please?
[21:01:39] <grrrit-wm>	 (03Abandoned) 10MarkAHershberger: Allow this to work even during imports when $wgOut->getTitle() returns null [extensions/Comments] - 10https://gerrit.wikimedia.org/r/63257 (owner: 10MarkAHershberger)
[21:01:42] <legoktm>	 I think you just have to remove the changes to skins/MonoBook
[21:02:13] <wikibugs>	 3MediaWiki extensions / 3CirrusSearch: Stemming: CirrusSearch does not find Биология for a Биологии query on ru.wp (but LuceneSearch does) - 10https://bugzilla.wikimedia.org/69766#c6 (10Nik Everett) Don't worry about filing a new bug.  I've got it from here.
[21:02:25] <Lcawte>	 legoktm: So git rm when I've checked out the changeset?
[21:02:45] <legoktm>	 yeah 
[21:02:50] <legoktm>	 then amend 
[21:02:52] <legoktm>	 then rebase
[21:03:23] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 032] Clean up options with betafeature [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156691 (https://bugzilla.wikimedia.org/69517) (owner: 10Manybubbles)
[21:03:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Clean up options with betafeature [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156691 (https://bugzilla.wikimedia.org/69517) (owner: 10Manybubbles)
[21:03:39] <grrrit-wm>	 (03PS1) 10MarkTraceur: Add start/end and whileActive to the campaigns [extensions/UploadWizard] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156692 (https://bugzilla.wikimedia.org/64685) 
[21:04:02] <mutante>	 Lcawte: git review -d <gerrit number> ; git rebase -i origin/master; ..then it will eventually throw an error telling you it could not do it automatically ..; find the string "HEAD" in files you have touched, open them in text editor, fix manually .. ; git rebase --continue; .. amend.. review
[21:05:14] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "There aren't (as far as I know) and I already opened bug 69944 about this." [core] - 10https://gerrit.wikimedia.org/r/155910 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński)
[21:05:51] <grrrit-wm>	 (03CR) 10Legoktm: "Oh cool, didn't know that. I've switched it over to use git.wikimedia.org now. Thanks!" [skins/Vector] - 10https://gerrit.wikimedia.org/r/152927 (owner: 10Mwjames)
[21:05:57] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] Add start/end and whileActive to the campaigns [extensions/UploadWizard] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156692 (https://bugzilla.wikimedia.org/64685) (owner: 10MarkTraceur)
[21:06:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add start/end and whileActive to the campaigns [extensions/UploadWizard] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156692 (https://bugzilla.wikimedia.org/64685) (owner: 10MarkTraceur)
[21:06:29] <wikibugs>	 3MediaWiki extensions / 3CirrusSearch: CirrusSearch appears twice in srbackend paraminfo - 10https://bugzilla.wikimedia.org/69517#c10 (10Alex Monk) 5PATC>3RESO/FIX Should be fixed now.
[21:06:32] <grrrit-wm>	 (03PS1) 10MarkTraceur: Add beforeActive and afterActive to campaigns [extensions/UploadWizard] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156694 (https://bugzilla.wikimedia.org/64685) 
[21:06:35] <grrrit-wm>	 (03CR) 10Krinkle: Remove $wgBrowserBlackList and associated EditPage code (032 comments) [core] - 10https://gerrit.wikimedia.org/r/138840 (https://bugzilla.wikimedia.org/65297) (owner: 10PleaseStand)
[21:06:46] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] Add beforeActive and afterActive to campaigns [extensions/UploadWizard] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156694 (https://bugzilla.wikimedia.org/64685) (owner: 10MarkTraceur)
[21:07:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add beforeActive and afterActive to campaigns [extensions/UploadWizard] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156694 (https://bugzilla.wikimedia.org/64685) (owner: 10MarkTraceur)
[21:07:57] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] "appears to work as advertised" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156594 (owner: 10Bsitu)
[21:08:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: Specify which event type to use job queue [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156594 (owner: 10Bsitu)
[21:09:08] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] "works in relation to linked echo patch" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156598 (owner: 10Bsitu)
[21:09:11] <grrrit-wm>	 (03CR) 10Krinkle: [C: 04-1] findHooks.php, importSiteScripts.php: Use format=json (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143028 (owner: 10PleaseStand)
[21:09:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use job queue to process Flow notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156598 (owner: 10Bsitu)
[21:10:05] <grrrit-wm>	 (03CR) 10Krinkle: [C: 031] API: Skip XML tag highlighting for non-XML formats [core] - 10https://gerrit.wikimedia.org/r/133739 (https://bugzilla.wikimedia.org/65403) (owner: 10PleaseStand)
[21:10:09] <grrrit-wm>	 (03PS10) 10Lewis Cawte: Introduce mediawiki.skinning module for external link icons [core] - 10https://gerrit.wikimedia.org/r/143173 (https://bugzilla.wikimedia.org/63521) (owner: 10Jack Phoenix)
[21:11:04] <wikibugs>	 3MediaWiki extensions / 3CentralAuth: Create special page to manage global rename request queue - 10https://bugzilla.wikimedia.org/68924 (10Bryan Davis) p:5Normal>3High a:3Bryan Davis
[21:13:01] <wikibugs>	 3MediaWiki / 3Skin and page rendering: Mediawiki UI shouldn't change font-family for textareas - 10https://bugzilla.wikimedia.org/70028#c5 (10Bartosz Dziewoński) I think using a monospace font is pretty important for "wikitext" textareas. Trying to place the cursor next to a '[' or, even worse, a '|', in a p...
[21:13:43] <grrrit-wm>	 (03PS5) 10Jdlrobson: Temporarily override token name prefixing [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156600 (owner: 10EBernhardson)
[21:14:11] <Lcawte>	 Thanks mutante :)
[21:14:27] <grrrit-wm>	 (03CR) 10Spage: [C: 04-1] "I checked out the patch. Clicking the textarea with a "Reply to <Topic title" in it opens up the topic scrolled to the right place and I " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156203 (owner: 10EBernhardson)
[21:16:06] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Temporarily override token name prefixing [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156600 (owner: 10EBernhardson)
[21:16:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Temporarily override token name prefixing [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156600 (owner: 10EBernhardson)
[21:17:45] <grrrit-wm>	 (03CR) 10Jdlrobson: "7 is not critical" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156203 (owner: 10EBernhardson)
[21:18:14] <grrrit-wm>	 (03PS1) 10Mglaser: Updated release notes and version number to MediaWiki 1.23.3 [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/156697 
[21:18:18] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] API: Organize classes [core] - 10https://gerrit.wikimedia.org/r/156687 (owner: 10Anomie)
[21:18:21] <grrrit-wm>	 (03PS1) 10Mglaser: Updated release notes and version number for MediaWiki 1.22.10 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/156698 
[21:18:53] <grrrit-wm>	 (03PS1) 10Manybubbles: Unicode regexes everywhere! [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156699 (https://bugzilla.wikimedia.org/69766) 
[21:19:20] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 04-1] "Want to do more testing on this.............. Unicode!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156699 (https://bugzilla.wikimedia.org/69766) (owner: 10Manybubbles)
[21:20:29] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "(You might want to update the 'default-skin-not-found' and 'default-skin-not-found-no-skins' messages in core with Composery thingies.)" [skins/Vector] - 10https://gerrit.wikimedia.org/r/152927 (owner: 10Mwjames)
[21:21:03] <grrrit-wm>	 (03CR) 10saper: "90 words of review for 1 line of code, not bad... I hate Status class, I believe it's a broken piece of code (sorry Tim)." [core] - 10https://gerrit.wikimedia.org/r/156446 (owner: 10saper)
[21:21:05] <grrrit-wm>	 (03PS1) 10Lewis Cawte: Use new external links skinning module. [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/156700 
[21:21:33] <grrrit-wm>	 (03PS2) 10saper: Provide rudimentary __toString() for Status [core] - 10https://gerrit.wikimedia.org/r/156446 
[21:21:43] <wikibugs>	 3MediaWiki extensions / 3CirrusSearch: Stemming: CirrusSearch does not find Биология for a Биологии query on ru.wp (but LuceneSearch does) - 10https://bugzilla.wikimedia.org/69766#c7 (10Nik Everett) This looks to have been caused by us not using unicode style regexes when detecting the * syntax.  We have a f...
[21:24:31] <grrrit-wm>	 (03CR) 10Manybubbles: "Also: we don't actually need it in places where we aren't using character classes." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156699 (https://bugzilla.wikimedia.org/69766) (owner: 10Manybubbles)
[21:24:34] <grrrit-wm>	 (03CR) 10PleaseStand: [C: 04-1] "Needs work as described inline." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/138840 (https://bugzilla.wikimedia.org/65297) (owner: 10PleaseStand)
[21:25:12] <grrrit-wm>	 (03PS2) 10Lewis Cawte: Use new external links skinning module. [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/156700 
[21:25:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: API: Organize classes [core] - 10https://gerrit.wikimedia.org/r/156687 (owner: 10Anomie)
[21:26:45] <grrrit-wm>	 (03PS3) 10Renoirb: Improving doc. on how OAuth is integrated in MW [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/124134 
[21:28:03] <grrrit-wm>	 (03PS3) 10Lewis Cawte: Use new external links skinning module. [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/156700 
[21:28:36] * Lcawte tells grrrit-wm to ignore him
[21:29:34] <grrrit-wm>	 (03CR) 10Spage: "If I visit one of these topic action URLs with JS enabled (e.g. I right clicked on a Reply action, or I interacted with the board before J" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156203 (owner: 10EBernhardson)
[21:29:48] <grrrit-wm>	 (03CR) 10Legoktm: "You can remove the actual image files too right?" [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/156700 (owner: 10Lewis Cawte)
[21:30:43] <grrrit-wm>	 (03CR) 10Dduvall: [C: 04-2] "This needs a slight refactoring, since the `bundle config path` effects invocations of bundler on the host system as well. It's probably b" [vagrant] - 10https://gerrit.wikimedia.org/r/156207 (owner: 10Dduvall)
[21:32:10] <grrrit-wm>	 (03PS6) 10Spage: WIP: Add LQT conversion script. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna)
[21:32:25] <grrrit-wm>	 (03CR) 10MarkAHershberger: [C: 032] Updated release notes and version number for MediaWiki 1.22.10 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/156698 (owner: 10Mglaser)
[21:33:17] <chrismcmahon>	 ori-mtng: you want to check beta over?  seems to have slowed to a crawl very recently
[21:33:47] <grrrit-wm>	 (03CR) 10CSteipp: [C: 032] Improving doc. on how OAuth is integrated in MW [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/124134 (owner: 10Renoirb)
[21:33:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Improving doc. on how OAuth is integrated in MW [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/124134 (owner: 10Renoirb)
[21:35:08] <grrrit-wm>	 (03CR) 10MarkAHershberger: [C: 032] Updated release notes and version number to MediaWiki 1.23.3 [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/156697 (owner: 10Mglaser)
[21:36:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: Updated release notes and version number for MediaWiki 1.22.10 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/156698 (owner: 10Mglaser)
[21:38:03] <wikibugs>	 3MediaWiki skins / 3Vector: Large number of CSS rules for external links - 10https://bugzilla.wikimedia.org/54604#c83 (10Jon) (In reply to Bartosz Dziewoński from comment #81) > So the general agreement is that it was good in the beginning and the change > above was a bad idea.  I don't know how you have det...
[21:38:08] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-2] "I'm confused. I read through the bug again, and all I see is consensus on the /how/ we do it (e.g. don't use classes) but I see no consens" [skins/Vector] - 10https://gerrit.wikimedia.org/r/154350 (https://bugzilla.wikimedia.org/54604) (owner: 10Bartosz Dziewoński)
[21:39:12] <grrrit-wm>	 (03PS1) 10Bsitu: Turn on email bundling for post edit/reply + instructions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156702 
[21:39:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Updated release notes and version number to MediaWiki 1.23.3 [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/156697 (owner: 10Mglaser)
[21:42:56] <grrrit-wm>	 (03CR) 10Jdlrobson: "spage see 7) https://lists.wikimedia.org/pipermail/ee/2014-August/001038.html" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156203 (owner: 10EBernhardson)
[21:48:55] <renoirb>	 bd808, I got something working, its there https://github.com/webplatform/mediawiki/blob/201408-upgrade/resources/puppet/manifests/webplatformwiki.pp
[21:49:02] <renoirb>	 https://github.com/webplatform/mediawiki/blob/201408-upgrade/resources/puppet/manifests/webplatformwiki.pp#L165
[21:51:16] <grrrit-wm>	 (03PS1) 10Legoktm: Add option to ignore the revision limit [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/156705 
[21:51:37] <grrrit-wm>	 (03PS2) 10PleaseStand: findHooks.php, importSiteScripts.php: Use format=json [core] - 10https://gerrit.wikimedia.org/r/143028 
[21:52:22] <grrrit-wm>	 (03CR) 10Qgil: "What is the status of this relatively old patchset?" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/89846 (owner: 10Brion VIBBER)
[21:52:32] <grrrit-wm>	 (03CR) 10Helder.wiki: [C: 031] Add option to ignore the revision limit [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/156705 (owner: 10Legoktm)
[21:53:29] <wikibugs>	 3Wikimedia / 3General/Unknown: Unable to login and reset password: "Invalid hash given" in all cases - 10https://bugzilla.wikimedia.org/70098#c10 (10Chris Steipp) For the actual issue, I managed to reproduce the effect that caused the problem. A user with type :A: password with a hard expired password, I log...
[21:54:13] <grrrit-wm>	 (03CR) 10Qgil: "Mdale, can you review this old patch? Or who else could?" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108482 (https://bugzilla.wikimedia.org/60245) (owner: 10Brian Wolff)
[21:55:24] <grrrit-wm>	 (03CR) 10PleaseStand: findHooks.php, importSiteScripts.php: Use format=json (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143028 (owner: 10PleaseStand)
[21:56:17] <wikibugs>	 3MediaWiki / 3General/Unknown: Eastern numerals in Arabic Wikipedia - 10https://bugzilla.wikimedia.org/70109 (10Zack) 3NEW p:3Unprio s:3normal a:3None In Arabic Wikipedia, in type="number" elements (see Main Page history for instance) and the 'N more languages' line of the Compact Language Links feat...
[21:56:29] <grrrit-wm>	 (03PS3) 10Qgil: [WIP] DO NOT MERGE (bug 17168) Support interwiki articles when loading collection [extensions/Collection] - 10https://gerrit.wikimedia.org/r/44848 (owner: 10Awight)
[21:56:31] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] DO NOT MERGE (bug 17168) Support interwiki articles when loading collection [extensions/Collection] - 10https://gerrit.wikimedia.org/r/44848 (owner: 10Awight)
[21:57:10] <grrrit-wm>	 (03PS6) 10Addshore: Refactor Gadget constructor [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154750 (https://bugzilla.wikimedia.org/69368) (owner: 10Legoktm)
[21:57:15] <grrrit-wm>	 (03PS4) 10Addshore: Add a test for Gadget::__construct [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154751 (owner: 10Legoktm)
[21:59:27] <grrrit-wm>	 (03PS1) 10Renoirb: New role, installing Semantic MediaWiki [vagrant] - 10https://gerrit.wikimedia.org/r/156708 
[22:01:17] <grrrit-wm>	 (03PS1) 10Jorm: * Ensure that typography refresh is only turned on for a small set of languages (for now). TR breaks Japanese formatting (and probably a lot of other languages). [winter/snowflakes] - 10https://gerrit.wikimedia.org/r/156709 
[22:01:40] <grrrit-wm>	 (03CR) 10Jorm: [C: 032 V: 032] * Ensure that typography refresh is only turned on for a small set of languages (for now). TR breaks Japanese formatting (and probably a lo [winter/snowflakes] - 10https://gerrit.wikimedia.org/r/156709 (owner: 10Jorm)
[22:03:17] <grrrit-wm>	 (03PS2) 10Renoirb: New role, installing Semantic MediaWiki [vagrant] - 10https://gerrit.wikimedia.org/r/156708 
[22:04:12] <grrrit-wm>	 (03PS1) 10Jorm: * Minor css fixes regarding responsive code * Add in special case stuff for the Main Page [winter/snowflakes] - 10https://gerrit.wikimedia.org/r/156710 
[22:04:28] <grrrit-wm>	 (03CR) 10Jorm: [C: 032 V: 032] * Minor css fixes regarding responsive code * Add in special case stuff for the Main Page [winter/snowflakes] - 10https://gerrit.wikimedia.org/r/156710 (owner: 10Jorm)
[22:06:18] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] Refactor Gadget constructor [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154750 (https://bugzilla.wikimedia.org/69368) (owner: 10Legoktm)
[22:06:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Refactor Gadget constructor [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154750 (https://bugzilla.wikimedia.org/69368) (owner: 10Legoktm)
[22:06:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add a test for Gadget::__construct [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154751 (owner: 10Legoktm)
[22:07:43] <wikibugs>	 3Wikimedia / 3General/Unknown: JS bug : URI error - 10https://bugzilla.wikimedia.org/70097#c2 (10Sacamol) Created attachment 16298   --> https://bugzilla.wikimedia.org/attachment.cgi?id=16298&action=edit home page error 1
[22:08:14] <grrrit-wm>	 (03PS3) 10Dduvall: Central bundler gem installation path for faster provisions [vagrant] - 10https://gerrit.wikimedia.org/r/156207 
[22:09:11] <grrrit-wm>	 (03PS4) 10Legoktm: Refactor GadgetRepo inheritance and construction [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/156508 
[22:09:18] <grrrit-wm>	 (03PS2) 10Legoktm: Store $wgMemc as an instance variable in CachedGadgetRepo [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/156513 
[22:09:43] <wikibugs>	 3Wikimedia / 3General/Unknown: JS bug : URI error - 10https://bugzilla.wikimedia.org/70097#c4 (10Sacamol) Created attachment 16300   --> https://bugzilla.wikimedia.org/attachment.cgi?id=16300&action=edit Random page
[22:09:43] <wikibugs>	 3Wikimedia / 3General/Unknown: JS bug : URI error - 10https://bugzilla.wikimedia.org/70097#c3 (10Sacamol) Created attachment 16299   --> https://bugzilla.wikimedia.org/attachment.cgi?id=16299&action=edit home page error 2
[22:09:58] <wikibugs>	 3Wikimedia / 3General/Unknown: JS bug : URI error - 10https://bugzilla.wikimedia.org/70097#c5 (10Sacamol) Created attachment 16301   --> https://bugzilla.wikimedia.org/attachment.cgi?id=16301&action=edit editing a page
[22:09:58] <wikibugs>	 3MediaWiki extensions / 3Gadgets: 2.0: Remove timestamp from Gadget constructor - 10https://bugzilla.wikimedia.org/69368 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX
[22:10:07] <grrrit-wm>	 (03PS1) 10Jorm: * Minor css fixes * Alter the default set of snowflakes [winter] - 10https://gerrit.wikimedia.org/r/156711 
[22:10:32] <grrrit-wm>	 (03CR) 10Jorm: [C: 032 V: 032] * Minor css fixes * Alter the default set of snowflakes [winter] - 10https://gerrit.wikimedia.org/r/156711 (owner: 10Jorm)
[22:10:59] <wikibugs>	 3MediaWiki extensions / 3CirrusSearch: PHP Warning: Invalid argument - 10https://bugzilla.wikimedia.org/69459#c1 (10Chad H.) 5UNCO>3ASSI p:5Unprio>3Lowest a:3Chad H. CirrusSearch master generally depends on MW master and probably won't work all that well with the 1.23.x release branch. In this case...
[22:11:37] <grrrit-wm>	 (03PS1) 10Chad: Protect against older versions of HtmlFormatter [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156712 (https://bugzilla.wikimedia.org/69459) 
[22:12:45] <wikibugs>	 3MediaWiki / 3JavaScript: "Templates used in this preview" is not collapsible in Live preview - 10https://bugzilla.wikimedia.org/70110 (10Helder) 3NEW p:3Unprio s:3enhanc a:3None Enable live preview (e.g. on French Wikipedia) and go to a page containing templates and/or hidden categories. E.g.: https...
[22:13:58] <wikibugs>	 3Wikimedia / 3General/Unknown: JS bug : URI error - 10https://bugzilla.wikimedia.org/70097#c6 (10Sacamol) Hi  Thanx for reply. There is no special step. Each displaying page is producing the problem : homepage (attachements "home page"), profile page, viewing an article (attachement "random page"), editing a...
[22:14:01] <grrrit-wm>	 (03PS5) 10Dduvall: Default for provisioning of extension browser tests [vagrant] - 10https://gerrit.wikimedia.org/r/156383 
[22:15:28] <wikibugs>	 3MediaWiki / 3JavaScript: Collapsible lists on edit page footer no longer collapsible after live preview is used - 10https://bugzilla.wikimedia.org/53918#c3 (10Helder) *** Bug 70110 has been marked as a duplicate of this bug. ***
[22:15:28] <wikibugs>	 3MediaWiki / 3JavaScript: "Templates used in this preview" is not collapsible in Live preview - 10https://bugzilla.wikimedia.org/70110#c1 (10Helder) 5NEW>3RESO/DUP Er...  *** This bug has been marked as a duplicate of bug 53918 ***
[22:15:40] <grrrit-wm>	 (03CR) 10Helder.wiki: "The second part of the commit message implies this would also solve bug 69108." [core] - 10https://gerrit.wikimedia.org/r/99714 (https://bugzilla.wikimedia.org/53918) (owner: 10Bartosz Dziewoński)
[22:27:22] <grrrit-wm>	 (03PS4) 10Dduvall: Central bundler gem installation path for faster provisions [vagrant] - 10https://gerrit.wikimedia.org/r/156207 
[22:30:43] <grrrit-wm>	 (03CR) 10Dduvall: [C: 031] "Ok, refactored to use a BUNDLE_PATH environment variable over a local bundler config—the latter is problematic when you're using an absolu" (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/156207 (owner: 10Dduvall)
[22:31:15] <grrrit-wm>	 (03PS6) 10Dduvall: Default for provisioning of extension browser tests [vagrant] - 10https://gerrit.wikimedia.org/r/156383 
[22:32:20] <grrrit-wm>	 (03PS2) 10Chad: Morelike improvements [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156686 (https://bugzilla.wikimedia.org/68541) (owner: 10Manybubbles)
[22:32:44] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Morelike improvements [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156686 (https://bugzilla.wikimedia.org/68541) (owner: 10Manybubbles)
[22:32:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Morelike improvements [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156686 (https://bugzilla.wikimedia.org/68541) (owner: 10Manybubbles)
[22:35:40] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Indicate the actual version of HHVM in use [core] - 10https://gerrit.wikimedia.org/r/151962 (owner: 10PleaseStand)
[22:35:44] <grrrit-wm>	 (03CR) 10EBernhardson: "1. done" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156203 (owner: 10EBernhardson)
[22:35:58] <wikibugs>	 3MediaWiki extensions / 3CirrusSearch: "text search is disabled" error sometimes shown when morelike: is used (because it's a redirect?) - 10https://bugzilla.wikimedia.org/68541#c6 (10Steven Walling) 5PATC>3RESO/FIX Thanks for fixing this stuff Nik.
[22:37:12] <grrrit-wm>	 (03PS16) 10EBernhardson: G3: Mobile/nojs edit and reply full topic output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156203 
[22:37:15] <grrrit-wm>	 (03PS1) 10EBernhardson: Hygiene: Remove unnecessary indentation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156716 
[22:42:15] <grrrit-wm>	 (03Merged) 10jenkins-bot: Indicate the actual version of HHVM in use [core] - 10https://gerrit.wikimedia.org/r/151962 (owner: 10PleaseStand)
[22:42:17] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Revert "Remove useless $out parameter from SkinTemplate::prepareQuickTemplate()" [core] - 10https://gerrit.wikimedia.org/r/156717 
[22:42:57] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: Revert "Remove useless $out parameter from SkinTemplate::prepareQuickTemplate()" [core] - 10https://gerrit.wikimedia.org/r/156717 
[22:43:01] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Revert "Remove useless $out parameter from SkinTemplate::prepareQuickTemplate()" [core] - 10https://gerrit.wikimedia.org/r/156717 (owner: 10Bartosz Dziewoński)
[22:43:13] <grrrit-wm>	 (03CR) 10Chad: Use protocol default port with HTTP_X_FORWARDED_PROTO (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156236 (https://bugzilla.wikimedia.org/70021) (owner: 10BryanDavis)
[22:44:36] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: Remove useless $out parameter from SkinTemplate::prepareQuickTemplate() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/153636 (owner: 10IAlex)
[22:46:26] <grrrit-wm>	 (03CR) 10BryanDavis: Use protocol default port with HTTP_X_FORWARDED_PROTO (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156236 (https://bugzilla.wikimedia.org/70021) (owner: 10BryanDavis)
[22:50:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "Remove useless $out parameter from SkinTemplate::prepareQuickTemplate()" [core] - 10https://gerrit.wikimedia.org/r/156717 (owner: 10Bartosz Dziewoński)
[22:51:53] <grrrit-wm>	 (03CR) 10Chad: Use protocol default port with HTTP_X_FORWARDED_PROTO (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156236 (https://bugzilla.wikimedia.org/70021) (owner: 10BryanDavis)
[22:52:07] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Fallback to master lookup for title when lookup in slave fails [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156466 (https://bugzilla.wikimedia.org/69913) (owner: 10Bsitu)
[22:52:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fallback to master lookup for title when lookup in slave fails [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156466 (https://bugzilla.wikimedia.org/69913) (owner: 10Bsitu)
[22:56:35] <grrrit-wm>	 (03PS1) 10Jdlrobson: G4: Don't collapse closed topics. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156719 
[22:59:23] <grrrit-wm>	 (03PS2) 10Jdlrobson: G4: Don't collapse closed topics. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156719 
[23:04:24] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Kill ifEquals helper, use ifCond instead [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156720 
[23:05:31] <wikibugs>	 3MediaWiki extensions / 3CentralAuth: login when already logged in gets exception from Special:CentralLogin - 10https://bugzilla.wikimedia.org/69834#c7 (10Chris Steipp) So the cause is Idd9325374cb5dc13c4c057f45f88a33bdff523a9, and this code:   // In the case where the user is already logged in, do not show...
[23:08:38] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 04-1] "couple quick comments" (039 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna)
[23:08:43] <ebernhardson>	 AaronSchulz: i addd you as a reviewer to https://gerrit.wikimedia.org/r/119243 but its actually just a single method i wanted you to look at if you could, https://gerrit.wikimedia.org/r/#/c/119243/6/includes/Model/UUID.php in the getComparisonUUID method (any time, this is not in any way a time sensitive patch)
[23:10:56] <grrrit-wm>	 (03PS1) 10Catrope: Update UploadWizard to wmf18 for cherry-picks [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156721 
[23:11:04] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update UploadWizard to wmf18 for cherry-picks [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156721 (owner: 10Catrope)
[23:14:54] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] "afaict this does what we want." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156702 (owner: 10Bsitu)
[23:14:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update UploadWizard to wmf18 for cherry-picks [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156721 (owner: 10Catrope)
[23:15:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Turn on email bundling for post edit/reply + instructions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156702 (owner: 10Bsitu)
[23:15:30] <AaronSchulz>	 ebernhardson: do you actually rely on the timestamp embedded in the ID matching the post timestamp for some purposes?
[23:16:34] <ebernhardson>	 AaronSchulz: its currently used for converting the timestamp Special:Contributions uses for pagination into a uuid so we can just do 'rev_id < :comparrisonId' 
[23:17:00] <ebernhardson>	 AaronSchulz: oh, so the answer to your question is yes, we dont store any timestamps beyond the uuid's
[23:17:55] <ebernhardson>	 which is why the LQT->Flow conversion then needs to invent historical uuid;s
[23:19:25] <AaronSchulz>	 right
[23:19:30] <grrrit-wm>	 (03PS1) 10Aaron Schulz: Fixed UID comment [core] - 10https://gerrit.wikimedia.org/r/156724 
[23:20:05] <grrrit-wm>	 (03PS1) 10Chad: Remove SpecialSearchNoResults and call SpecialSearchResults always [core] - 10https://gerrit.wikimedia.org/r/156725 
[23:20:18] <^d>	 One less hook :)
[23:20:56] * ebernhardson should really call them uid's as well, uuid has a specific meaning
[23:24:05] <^d>	 I wonder how much faster MW would be if we yanked all the hooks out.
[23:24:37] <ebernhardson>	 i wonder how much faster MW would be if we instead implemented most functionality via evented hooks... :P
[23:25:19] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Fixed UID comment [core] - 10https://gerrit.wikimedia.org/r/156724 (owner: 10Aaron Schulz)
[23:25:48] * ^d goes back to profiling
[23:30:10] * ebernhardson meant an async evented system, ala linked in, but maye that wasn't obvious :P 
[23:30:11] <grrrit-wm>	 (03PS1) 10Chad: Profile actual request in Searcher::search() [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156727 
[23:31:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fixed UID comment [core] - 10https://gerrit.wikimedia.org/r/156724 (owner: 10Aaron Schulz)
[23:32:22] <AaronSchulz>	 ebernhardson: getTimestampedID88() already lets the time/clock seq. be injected, and you can detect any rare duplicates on INSERT (fudging the milliseconds as needed to work around), maybe you could just extend UIDGenerator as a hack
[23:34:59] <ebernhardson>	 AaronSchulz: hmm, yea that sounds much more reasonable than the existing code there.
[23:35:36] <grrrit-wm>	 (03Abandoned) 10CSteipp: Encrypt cookie which has OAuth secret [phabricator/libphutil] - 10https://gerrit.wikimedia.org/r/147686 (owner: 10CSteipp)
[23:42:45] <grrrit-wm>	 (03PS1) 10SG: Remove flow-author from topic titlebar to reduce titlebar height [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156728 
[23:43:55] <grrrit-wm>	 (03PS1) 10tosfos: allow ads in content area [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/156729 
[23:46:53] <grrrit-wm>	 (03CR) 10EBernhardson: WIP: Add LQT conversion script. (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (https://bugzilla.wikimedia.org/45088) (owner: 10Werdna)
[23:47:17] <grrrit-wm>	 (03PS2) 10tosfos: allow ads in content area [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/156729 
[23:50:00] <grrrit-wm>	 (03PS1) 10Aaron Schulz: Use addQuotes() as needed in MergeHistory pager [core] - 10https://gerrit.wikimedia.org/r/156731 
[23:52:00] <wikibugs>	 3MediaWiki extensions / 3CirrusSearch: Make sure we're doing the right thing with max_expansions - 10https://bugzilla.wikimedia.org/70113 (10Chad H.) 3NEW p:3Unprio s:3normal a:3None The default max_expansions for prefix searches is 50. We don't explicitly set it, so I imagine we're capping it at 50....
[23:53:24] <grrrit-wm>	 (03CR) 10CSteipp: [C: 032] "Thanks!" [core] - 10https://gerrit.wikimedia.org/r/156731 (owner: 10Aaron Schulz)
[23:55:58] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032] Profile actual request in Searcher::search() [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156727 (owner: 10Chad)
[23:56:02] <grrrit-wm>	 (03PS1) 10Aaron Schulz: Show the revision list immediately on "umerge" log action links [core] - 10https://gerrit.wikimedia.org/r/156734 
[23:56:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: Profile actual request in Searcher::search() [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156727 (owner: 10Chad)
[23:56:16] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032] Protect against older versions of HtmlFormatter [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156712 (https://bugzilla.wikimedia.org/69459) (owner: 10Chad)
[23:56:43] <wikibugs>	 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c18 (10Krinkle) Another solution would be to return early instead of wrap the whole thing.  While a return statement is not allowed in the global scope, a throw works...
[23:56:45] <grrrit-wm>	 (03PS2) 10Manybubbles: Use unicode regexes with character classes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156699 (https://bugzilla.wikimedia.org/69766) 
[23:56:47] <grrrit-wm>	 (03Merged) 10jenkins-bot: Protect against older versions of HtmlFormatter [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156712 (https://bugzilla.wikimedia.org/69459) (owner: 10Chad)
[23:57:28] <wikibugs>	 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c19 (10Krinkle) Another solution would be to return early instead of wrap the whole thing.  While a return statement is not allowed in the global scope, a throw works...
[23:58:37] <grrrit-wm>	 (03CR) 10Manybubbles: "Don't have a good way to write a regression test for this right now....." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156699 (https://bugzilla.wikimedia.org/69766) (owner: 10Manybubbles)
[23:58:57] <wikibugs>	 3MediaWiki extensions / 3CirrusSearch: PHP Warning: Invalid argument - 10https://bugzilla.wikimedia.org/69459 (10Nik Everett) 5PATC>3RESO/FIX
[23:59:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use addQuotes() as needed in MergeHistory pager [core] - 10https://gerrit.wikimedia.org/r/156731 (owner: 10Aaron Schulz)