[00:00:12] (03PS5) 10Jdlrobson: WIP: G3: Mobile/nojs edit and reply full topic output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156203 (owner: 10EBernhardson) [00:00:16] (03CR) 10Krinkle: "Compiled and pushed to Jenkins, https://integration.wikimedia.org/ci/job/mwext-DonationInterface-npm/" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156193 (owner: 10Jforrester) [00:01:05] (03CR) 10Jdlrobson: [C: 04-1] "Uncaught TypeError: Cannot read property 'getPrefixedText' of null" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156203 (owner: 10EBernhardson) [00:01:09] (03PS1) 10EBernhardson: Function.prototype.bind is also ECMAScript 5 [core] - 10https://gerrit.wikimedia.org/r/156215 [00:04:24] 3MediaWiki extensions / 3SecurePoll: SecurePoll Redesign: Poll Creation should auto create GPG keys - 10https://bugzilla.wikimedia.org/68129#c5 (10Chris Steipp) Storing the private key on the server does seem to defeat the purpose of encrypting the results, unless that key is itself encrypted, or stored some... [00:04:47] (03CR) 10Jdlrobson: [C: 04-1] Redirect to Flow view action when url action is set to edit (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156183 (https://bugzilla.wikimedia.org/69879) (owner: 10Bsitu) [00:08:08] (03Abandoned) 10Ori.livneh: Workaround for bug introduced by Icf6ede09b [core] - 10https://gerrit.wikimedia.org/r/155642 (owner: 10Ori.livneh) [00:20:54] 3MediaWiki / 3Installer: Updater applies patches after fresh install of MW where tables.sql already has been patched - 10https://bugzilla.wikimedia.org/66412 (10Rainer Rillke @commons.wikimedia) 5PATC>3RESO/FIX [00:24:11] 3MediaWiki extensions / 3ProofreadPage: Consistency - 'toogleLayout' should be 'toggleLayout' - 10https://bugzilla.wikimedia.org/70017 (10George Orwell III) 3UNCO p:3Unprio s:3normal a:3None In 'ext.proofreadpage.page.edit.js', the term 'toogleLayout' is found throughout the script when it should be... [00:25:03] (03CR) 10Jforrester: [C: 031] Function.prototype.bind is also ECMAScript 5 [core] - 10https://gerrit.wikimedia.org/r/156215 (owner: 10EBernhardson) [00:25:27] (03CR) 10CSteipp: [C: 031] "Works for my testing. I'll give hoo a chance to comment on those fixes, otherwise I'm happy with it." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144644 (https://bugzilla.wikimedia.org/47918) (owner: 10Legoktm) [00:26:01] (03CR) 10Bsitu: [C: 031] "Tested and worked fine" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155672 (owner: 10Jdlrobson) [00:27:17] (03CR) 10BryanDavis: "How about a compromise somewhere in the middle? I propose that Dan add a global "provision browser tests" flag via hiera that is set to tr" [vagrant] - 10https://gerrit.wikimedia.org/r/155861 (owner: 10MaxSem) [00:35:10] (03PS10) 10BryanDavis: Allow login with pre-rename username and password [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/147020 (https://bugzilla.wikimedia.org/67995) [00:37:09] 3Wikimedia / 3Deployment systems: [scap] sync-common should update l10n cdb files by default - 10https://bugzilla.wikimedia.org/69792 (10Bryan Davis) 5PATC>3RESO/FIX [00:39:26] So in Phabricator, [00:39:43] I press the "Login to Comment" button and it prompts me with a message about how you need to login. [00:39:47] With another button. [00:39:52] So I press that button and the login page loads. [00:40:05] Except it's not the login page, it's an error page that suggests reloading the page. [00:40:10] I reload the page and get a login form. [00:40:14] Brilliant. [00:40:55] it's not about the destination, it's the journey that matters [00:40:56] Also have no idea what my password is. [00:41:27] And the forgot your password only accepts e-mail addresses. [00:41:28] Le sigh. [00:43:01] Carmela: have you tried restarting? [00:44:40] sudo apache2ctl graceful [00:44:45] hunter2 [00:45:39] 3MediaWiki extensions / 3WikidataClient: Special:UnconnectedPages should show wikidata's notable pages - 10https://bugzilla.wikimedia.org/68946 (10John Mark Vandenberg) [00:45:44] 3MediaWiki extensions / 3WikidataClient: Ability to have [[Special:UnconnectedPages]] filter by namespace - 10https://bugzilla.wikimedia.org/66153 (10John Mark Vandenberg) [00:47:30] (03PS5) 10BryanDavis: [WIP] Interstitial notification page for renamed users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/148420 (https://bugzilla.wikimedia.org/67995) [00:47:58] (03CR) 10BryanDavis: "Patch set 5 was a manual rebase" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/148420 (https://bugzilla.wikimedia.org/67995) (owner: 10BryanDavis) [00:54:11] 3MediaWiki extensions / 3WikidataClient: Special:UnconnectedPages should be includable - 10https://bugzilla.wikimedia.org/70018 (10John Mark Vandenberg) 3NEW p:3Unprio s:3enhanc a:3Wikidata bugs Most special pages which return a list of pages are able to be transcluded. e.g. {{NewPages}} Unconnected... [00:54:30] (03PS2) 10Legoktm: Merge branch 'contenthandler' into master [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/156087 [00:57:28] superm401: Hey! You had pinged me earlier? [00:58:55] prtksxna, I did? [00:59:12] superm401: Last week I think (sorry, I was travelling) [00:59:45] prtksxna, sorry, I don't remember what it was. Probably HoverCards, but I would bet I commented on one of the bugs. [00:59:55] Cool [01:01:02] is there a chance I could possibly see a single project or a bug report not assigned to me at phabricator? it doesn't even let me create a project [01:01:08] the fab. test instance [01:03:25] <^d> Svetlana: http://fab.wmflabs.org/maniphest/query/open/ [01:03:38] <^d> http://fab.wmflabs.org/project/query/all/ [01:04:12] (03CR) 10JGonera: Change "Privacy policy" to "Privacy" in CPB (031 comment) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/155641 (owner: 10JGonera) [01:16:00] 3MediaWiki extensions / 3Gadgets: Add the ability to configure gadgets on a per site or wiki basis - 10https://bugzilla.wikimedia.org/70019 (10mdowdell) 3UNCO p:3Unprio s:3enhanc a:3None Something else I'd like add to the gadget feature requests is allowing users to configure a gadget to some extent.... [01:22:22] legoktm, did you write a bot to snipe bug number 70000 (https://bugzilla.wikimedia.org/show_bug.cgi?id=70000), or were you just lucky? [01:29:53] 3MediaWiki extensions / 3Gadgets: Add the ability to configure gadgets on a per site or wiki basis - 10https://bugzilla.wikimedia.org/70019#c1 (10Helder) 5UNCO>3NEW Customization of gadgets is in the roadmap for Gadgets 2.0 / 3.0: https://www.mediawiki.org/wiki/Extension:Gadgets/Roadmap#Gadgets_2.0 https... [01:29:54] 3MediaWiki extensions / 3Gadgets: 2.0: Split "gadgets-edit" user right into "gadgets-edit-css" and "gadgets-edit-js" - 10https://bugzilla.wikimedia.org/69911 (10Helder) [01:29:54] 3MediaWiki extensions / 3Gadgets: Implement Gadgets 2.0 (tracking) - 10https://bugzilla.wikimedia.org/29272 (10Helder) [01:29:54] 3MediaWiki extensions / 3Gadgets: Implement Gadgets 2.0 (tracking) - 10https://bugzilla.wikimedia.org/29272 (10Helder) [01:36:11] 3Wikimedia / 3Bugzilla: Bugzilla should have a 'test' product to test this bugzilla setup features - 10https://bugzilla.wikimedia.org/70020 (10Gryllida) 3UNCO p:3Unprio s:3normal a:3None In light of the migration to Phabricator, I'd like to test this Bugzilla install features, such as quoting in comm... [01:41:20] superm401: just planned :) [01:53:07] (03PS1) 10Helder.wiki: Do not load the module "mediawiki.action.edit" if "showtoolbar" is disabled [core] - 10https://gerrit.wikimedia.org/r/156229 [01:55:48] (03PS3) 10BryanDavis: hhvm logging and abi improvements [vagrant] - 10https://gerrit.wikimedia.org/r/156173 [01:56:40] 3Wikimedia / 3General/Unknown: Wikisource related bugs and enhancements (tracking) - 10https://bugzilla.wikimedia.org/35925 (10George Orwell III) [01:56:42] 3MediaWiki extensions / 3ProofreadPage: Consistency - 'toogleLayout' should be 'toggleLayout' - 10https://bugzilla.wikimedia.org/70017 (10George Orwell III) [01:57:24] 3Wikimedia / 3Bugzilla: Bugzilla should have a 'test' product to test this bugzilla setup features - 10https://bugzilla.wikimedia.org/70020#c1 (10Bartosz Dziewoński) We had a test instance at some point – https://boogs.wmflabs.org/ – but it seems to be down right now. (Documented at [[mw:Bug management/Bugzi... [01:58:20] (03PS4) 10BryanDavis: hhvm logging and abi improvements [vagrant] - 10https://gerrit.wikimedia.org/r/156173 [01:59:36] (03CR) 10Helder.wiki: [C: 04-1] "However, there is unrelated code in the same file =/" [core] - 10https://gerrit.wikimedia.org/r/156229 (owner: 10Helder.wiki) [02:02:52] (03CR) 10leucosticte: [C: 04-1] "TODO: Document the hooks" [core] - 10https://gerrit.wikimedia.org/r/155093 (https://bugzilla.wikimedia.org/69677) (owner: 10leucosticte) [02:02:54] (03PS1) 10BryanDavis: Only mount /vagrant/logs if not using NFS [vagrant] - 10https://gerrit.wikimedia.org/r/156230 [02:05:05] (03CR) 10BryanDavis: "This is working well for me locally, but needs testing by a wide number of people before we merge. Matt left a comment that you can see in" [vagrant] - 10https://gerrit.wikimedia.org/r/156230 (owner: 10BryanDavis) [02:07:39] anyone around with a mediawiki install that uses Preprocessor_DOM? [02:11:24] (03PS1) 10BryanDavis: Fix ruby imports for labs-vagrant [vagrant] - 10https://gerrit.wikimedia.org/r/156231 [02:11:44] (03CR) 10BryanDavis: [C: 032] Fix ruby imports for labs-vagrant [vagrant] - 10https://gerrit.wikimedia.org/r/156231 (owner: 10BryanDavis) [02:11:49] (03Merged) 10jenkins-bot: Fix ruby imports for labs-vagrant [vagrant] - 10https://gerrit.wikimedia.org/r/156231 (owner: 10BryanDavis) [02:18:34] (03PS1) 10Legoktm: AjaxDispatcher: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/156232 [02:20:47] (03PS2) 10Legoktm: AjaxDispatcher: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/156232 [02:23:31] (03CR) 10Legoktm: [C: 04-1] "Needs rebase after the file split" [core] - 10https://gerrit.wikimedia.org/r/155877 (owner: 10Legoktm) [02:28:49] (03CR) 10Legoktm: Import.php: Use Config instead of globals (031 comment) [core] - 10https://gerrit.wikimedia.org/r/155872 (owner: 10Legoktm) [02:29:15] (03PS2) 10Legoktm: Import.php: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/155872 [02:33:25] legoktm: is there a way we could turn a global into an API like tyler did for passwords [02:33:49] (03PS2) 10Helder.wiki: Do not load the toolbar code if "showtoolbar" is disabled [core] - 10https://gerrit.wikimedia.org/r/156229 [02:35:37] when you do config::get on a global it hides the wg part and makes it harder to grep for it, especially if the name conflicts with another function name or hook name [02:39:56] (03PS5) 10Helder.wiki: Remove edit toolbar from the editing form [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/120573 (https://bugzilla.wikimedia.org/53448) (owner: 10Deepali) [02:45:06] (03CR) 10Helder.wiki: "Maybe this hook could help ProofreadPage extension to add the toolbar on Page namespace?" [core] - 10https://gerrit.wikimedia.org/r/120357 (https://bugzilla.wikimedia.org/53448) (owner: 10Deepali) [02:46:14] (03CR) 10Helder.wiki: [C: 031] Remove edit toolbar from the editing form [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/120573 (https://bugzilla.wikimedia.org/53448) (owner: 10Deepali) [02:46:52] Withoutaname: um, you could grep for get( 'name' ) I guess. [02:48:45] (03CR) 10Helder.wiki: "Alternatively, we could improve" [core] - 10https://gerrit.wikimedia.org/r/156009 (https://bugzilla.wikimedia.org/69447) (owner: 10Helder.wiki) [02:49:57] (03PS2) 10Legoktm: Revert "Toolbar: Only show on WikiText pages" [core] - 10https://gerrit.wikimedia.org/r/156009 (https://bugzilla.wikimedia.org/69447) (owner: 10Helder.wiki) [02:54:39] 3MediaWiki extensions / 3Math: Math button's position unpredictible due to asynchronous load of toolbar parts - 10https://bugzilla.wikimedia.org/64745#c13 (10Helder) Maybe this could be solved by providing another hook inside of getEditToolbar to allow extensions to modify the content of $toolarray? https://... [02:59:47] (03CR) 10Helder.wiki: "Should we split also the insertTags code from the toolbar code, taking into account the intention from bug 28856?" [core] - 10https://gerrit.wikimedia.org/r/156229 (owner: 10Helder.wiki) [02:59:54] 3MediaWiki extensions / 3EducationProgram: Add UserMerge support to EducationProgram - 10https://bugzilla.wikimedia.org/67767#c2 (10Kunal Mehta (Legoktm)) Andrew, are you still planning to work on this? [03:00:45] (03CR) 10Legoktm: "Bump?" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/146025 (https://bugzilla.wikimedia.org/67769) (owner: 10Legoktm) [03:01:24] 3Wikimedia / 3General/Unknown: Wikisource related bugs and enhancements (tracking) - 10https://bugzilla.wikimedia.org/35925 (10Helder) [03:01:24] 3MediaWiki extensions / 3ProofreadPage: Unable to get old toolbar in namespace Page: whatsoever the preference request for the old toolbar - 10https://bugzilla.wikimedia.org/69447 (10Helder) [03:04:24] 3MediaWiki / 3Skin and page rendering: Edit toolbar & Edit tools (tracking) - 10https://bugzilla.wikimedia.org/17653 (10Helder) [03:04:54] 3MediaWiki / 3Skin and page rendering: Edit toolbar & Edit tools (tracking) - 10https://bugzilla.wikimedia.org/17653 (10Helder) [03:05:09] 3MediaWiki extensions / 3Math: Math button's position unpredictible due to asynchronous load of toolbar parts - 10https://bugzilla.wikimedia.org/64745 (10Helder) [03:05:09] 3MediaWiki extensions / 3BookManagerv2: Remove edit toolbar from the editing form - 10https://bugzilla.wikimedia.org/53448 (10Helder) [03:05:09] 3MediaWiki / 3Skin and page rendering: Edit toolbar & Edit tools (tracking) - 10https://bugzilla.wikimedia.org/17653 (10Helder) [03:05:09] 3MediaWiki / 3Skin and page rendering: Edit toolbar & Edit tools (tracking) - 10https://bugzilla.wikimedia.org/17653 (10Helder) [03:05:10] (03CR) 10AndyRussG: "Cool! Just minor tidbits, no blockers. (See inline comments.) :)" (032 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/142481 (https://bugzilla.wikimedia.org/66114) (owner: 10Prtksxna) [03:07:24] 3MediaWiki / 3ResourceLoader: Sporadic and unpredictable updating of (classic) toolbar via JS - 10https://bugzilla.wikimedia.org/31511 (10Helder) [03:07:24] 3MediaWiki / 3Skin and page rendering: Edit toolbar & Edit tools (tracking) - 10https://bugzilla.wikimedia.org/17653 (10Helder) [03:09:58] (03PS1) 10Legoktm: Add UserMerge support [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156233 [03:10:16] (03PS1) 10Pastakhov: fix highlighting arguments of templates and parser functions (v 1.6.1) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156234 [03:10:39] (03PS2) 10Legoktm: Add UserMerge support [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156233 (https://bugzilla.wikimedia.org/67766) [03:11:02] (03CR) 10Pastakhov: [C: 032] fix highlighting arguments of templates and parser functions (v 1.6.1) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156234 (owner: 10Pastakhov) [03:11:06] (03Merged) 10jenkins-bot: fix highlighting arguments of templates and parser functions (v 1.6.1) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156234 (owner: 10Pastakhov) [03:14:40] (03CR) 10Mattflaschen: "> This is working well for me locally, but needs testing by a" [vagrant] - 10https://gerrit.wikimedia.org/r/156230 (owner: 10BryanDavis) [03:16:54] 3MediaWiki / 3Page editing: [Regression] Dynamically added textarea within the editform no longer work in the classic edit toolbar - 10https://bugzilla.wikimedia.org/39268 (10Helder) [03:16:54] 3MediaWiki / 3Skin and page rendering: Edit toolbar & Edit tools (tracking) - 10https://bugzilla.wikimedia.org/17653 (10Helder) [03:17:11] 3MediaWiki / 3General/Unknown: WebRequest::detectServer() appends ":80" to hostname when HTTP_X_FORWARDED_PROTO == "https" - 10https://bugzilla.wikimedia.org/70021 (10Bryan Davis) 3NEW p:3Unprio s:3normal a:3None Seen in labs when running a MediaWiki-Vagrant configured wiki behind yuviproxy. Configur... [03:22:08] 3MediaWiki extensions / 3SecurePoll: Add UserMerge support to SecurePoll - 10https://bugzilla.wikimedia.org/67777#c1 (10Kunal Mehta (Legoktm)) Should we even do this? We probably shouldn't be altering the results of previous votes... securepoll_elections has el_owner securepoll_voters has voter_name (don't... [03:23:54] 3MediaWiki extensions / 3CentralAuth: login when already logged in gets exception from Special:CentralLogin - 10https://bugzilla.wikimedia.org/69834#c6 (10Matthew Flaschen) *** Bug 69947 has been marked as a duplicate of this bug. *** [03:23:54] 3MediaWiki extensions / 3CentralAuth: Sanity check fails: "The user account logged into does not exist." - 10https://bugzilla.wikimedia.org/69947#c2 (10Matthew Flaschen) 5NEW>3RESO/DUP Yeah, looks like it to me. It's the exact same error and backtrace (the superficial backtrace differents are just becau... [03:28:09] 3MediaWiki extensions / 3LiquidThreads: Edittools buttons broken in liquid threads reply and new topic - 10https://bugzilla.wikimedia.org/41220 (10Helder) [03:28:09] 3MediaWiki / 3Page editing: [Regression] Dynamically added textarea within the editform no longer work in the classic edit toolbar - 10https://bugzilla.wikimedia.org/39268#c26 (10Helder) I believe this was fixed by change Id9469f9dfcbb92854780c63252cd9c5069e94487. See also LQT bug 41220. [03:28:44] (03CR) 10Helder.wiki: "Also fixed bug 39268, I think." [core] - 10https://gerrit.wikimedia.org/r/62438 (https://bugzilla.wikimedia.org/41220) (owner: 10Alex Monk) [03:30:04] (03CR) 10AndyRussG: Force mw.popups.supportsSVG to false on InternetExplorer (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/142212 (owner: 10Prtksxna) [03:35:38] 3MediaWiki / 3Skin and page rendering: Edit toolbar & Edit tools (tracking) - 10https://bugzilla.wikimedia.org/17653 (10Helder) [03:35:39] 3MediaWiki / 3Internationalization: Allow localization of edit button images in LanguageXYZ.php - 10https://bugzilla.wikimedia.org/11732 (10Helder) [03:37:54] 3MediaWiki extensions / 3CentralAuth: BadMethodCallException with "Call to a member function getId" in SpecialCentralLogin.php on Beta Labs - 10https://bugzilla.wikimedia.org/69565#c11 (10Matthew Flaschen) 5NEW>3RESO/FIX I think this is fixed by I2488e1fd3109ce66c2cb42d9afc78097f2b7313d (the change Kunal... [03:37:55] 3MediaWiki extensions / 3CentralAuth: login when already logged in gets exception from Special:CentralLogin - 10https://bugzilla.wikimedia.org/69834 (10Matthew Flaschen) [03:37:55] 3MediaWiki extensions / 3CentralAuth: BadMethodCallException with "Call to a member function getId" in SpecialCentralLogin.php on Beta Labs - 10https://bugzilla.wikimedia.org/69565 (10Matthew Flaschen) a:3Kunal Mehta (Legoktm) [03:40:52] 3MediaWiki / 3Skin and page rendering: Bulletin board style toolbar for common editing functions should be more accessible for change and modification - 10https://bugzilla.wikimedia.org/14530 (10Helder) [03:40:54] 3MediaWiki / 3Skin and page rendering: Classic edit toolbar should be more accessible for change and modification - 10https://bugzilla.wikimedia.org/14530 (10Helder) [03:44:24] 3MediaWiki / 3Skin and page rendering: Edit toolbar & Edit tools (tracking) - 10https://bugzilla.wikimedia.org/17653 (10Helder) [03:44:24] 3MediaWiki / 3JavaScript: Native editButtons can't be removed or reordered through r86603 - 10https://bugzilla.wikimedia.org/28681#c3 (10Helder) 5RESO/FIX>3REOP The array mw.toolbar.buttons was removed again on gerrit change 16238. https://gerrit.wikimedia.org/r/#/c/16238/2/resources/mediawiki.action/med... [03:45:11] 3Wikimedia / 3Site requests: Restrict NS_FILE and NS_FILETALK edit to sysop on Korean Wikinews - 10https://bugzilla.wikimedia.org/70022 (10Revi) 3ASSI p:3Unprio s:3normal a:3Revi There is a consensus to restrict edit for NS_FILE and NS_FILE_TALK on kowikinews. Upload is already restricted to sysop pe... [03:47:07] (03CR) 10Helder.wiki: "This un-fixed bug 28681." [core] - 10https://gerrit.wikimedia.org/r/16238 (owner: 10Krinkle) [03:48:19] (03CR) 10Helder.wiki: "...as in: it removed the mw.toolbar.buttons introduced on r86942 to fix that bug." [core] - 10https://gerrit.wikimedia.org/r/16238 (owner: 10Krinkle) [03:49:54] 3MediaWiki extensions / 3Math: Math button's position unpredictible due to asynchronous load of toolbar parts - 10https://bugzilla.wikimedia.org/64745#c14 (10Helder) See also bug 28681 and r86942 (and then gerrit change 16238). [03:50:09] 3MediaWiki / 3JavaScript: Native editButtons can't be removed or reordered through r86603 - 10https://bugzilla.wikimedia.org/28681 (10Helder) [03:54:43] i don't think i've ever been so happy to see mediawiki throw a 500 error [03:55:58] (03PS1) 10BryanDavis: Use protocol default port with HTTP_X_FORWARDED_PROTO [core] - 10https://gerrit.wikimedia.org/r/156236 (https://bugzilla.wikimedia.org/70021) [03:59:09] (03CR) 10AndyRussG: [C: 032] render.article: Correctly space extract for landscape images with smaller heights (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/135779 (owner: 10Prtksxna) [03:59:11] (03CR) 10jenkins-bot: [V: 04-1] render.article: Correctly space extract for landscape images with smaller heights [extensions/Popups] - 10https://gerrit.wikimedia.org/r/135779 (owner: 10Prtksxna) [04:00:40] (03CR) 10AndyRussG: [C: 032] Reduce space between extract and timestamp [extensions/Popups] - 10https://gerrit.wikimedia.org/r/134113 (https://bugzilla.wikimedia.org/65154) (owner: 10Prtksxna) [04:01:05] (03Merged) 10jenkins-bot: Reduce space between extract and timestamp [extensions/Popups] - 10https://gerrit.wikimedia.org/r/134113 (https://bugzilla.wikimedia.org/65154) (owner: 10Prtksxna) [04:05:39] 3Wikimedia / 3Site requests: Restrict NS_FILE and NS_FILETALK edit to sysop on Korean Wikinews - 10https://bugzilla.wikimedia.org/70022#c2 (10Alex Monk) That seems strange. . . Can you explain why this is wanted? [04:06:16] (03CR) 10Mattflaschen: Change mw-ui anchors to require mw-ui-anchor base class (031 comment) [core] - 10https://gerrit.wikimedia.org/r/155856 (owner: 10SG) [04:07:08] (03CR) 10Mattflaschen: Change mw-ui anchors to require mw-ui-anchor base class (031 comment) [core] - 10https://gerrit.wikimedia.org/r/155856 (owner: 10SG) [04:11:21] (03PS1) 10Santhosh: Support nesting of expressions in parameters of explicit plural forms [core] - 10https://gerrit.wikimedia.org/r/156237 (https://bugzilla.wikimedia.org/69993) [04:11:51] (03PS2) 10Santhosh: Support nesting of expressions in parameters of explicit plural forms [core] - 10https://gerrit.wikimedia.org/r/156237 (https://bugzilla.wikimedia.org/69993) [04:18:30] how does mw interpret /wiki/ back into index.php?title=<title> when extracting the url info [04:19:00] <Carmela> MediaWiki doesn't, really. [04:19:03] <Carmela> The Web server does. [04:19:06] <Carmela> !shorturl | Withoutaname [04:19:06] <wm-bot> Withoutaname: To create simple URLs (such as the /wiki/PAGENAME style URLs on Wikimedia sites), follow the instructions at <http://www.mediawiki.org/wiki/Manual:Short_URL> or try the new beta tool at <http://shorturls.redwerks.org/>. There are instructions for most different webserver setups. If you have problems getting the rewrite rules to work, see !rewriteproblem [04:19:27] <Carmela> You configure the Web server to treat /wiki/foo as equivalent to /w/index.php?title=foo [04:19:39] <Carmela> The Web server routes the request to MediaWiki and MediaWiki is really none the wiser. [04:20:02] <Carmela> The only part you adjust in MediaWiki is telling it to generate prettier links for [[foo]] and {{fullurl:foo}} and such. [04:20:29] <Withoutaname> actually I'm trying to do https://www.mediawiki.org/wiki/Requests_for_comment/Entry_point_routing_and_404_handling [04:20:50] <Withoutaname> I'm trying to get the entry point based on the url [04:23:22] <Withoutaname> Carmela: can the web server send the "index.php" info to mw? [04:24:16] <Carmela> It does, kind of. [04:36:49] <grrrit-wm1> (03PS1) 10Legoktm: Stop using extract() [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/156240 [04:38:24] <wikibugs> 3MediaWiki extensions / 3Popups: Hovercards: Reduce the size of the lastedited div - 10https://bugzilla.wikimedia.org/65154 (10Prateek Saxena) 5PATC>3RESO/FIX [04:38:53] <wikibugs> 3MediaWiki extensions / 3Popups: settings.open() called with incorrect parameters, causing exception - 10https://bugzilla.wikimedia.org/69579 (10Prateek Saxena) 5PATC>3RESO/FIX [04:38:54] <wikibugs> 3Wikimedia / 3Site requests: Restrict NS_FILE and NS_FILETALK edit to sysop on Korean Wikinews - 10https://bugzilla.wikimedia.org/70022#c3 (10jeremyb) 5PATC>3UNCO Even if you could find some way to justify this change, a proposal by one user and response by only one other user does not a consensus make.... [04:54:27] <Withoutaname> Carmela: is there any way to extract the entry point from the short url, or does it have to always point to the right entry point file [04:56:42] <grrrit-wm1> (03PS1) 10Dan-nl: Add Special:Log Entries [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/156243 (https://bugzilla.wikimedia.org/68277) [05:17:56] <grrrit-wm1> (03PS1) 10Lilu: [WIP] PermissionManager Recode [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156244 [05:21:13] <grrrit-wm1> (03PS7) 10Nemo bis: Don't use undefined $_POST stuff, avoid isset [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/149841 [05:24:41] <grrrit-wm1> (03PS3) 10Nemo bis: Ensure $rights is defined [extensions/AccessControl] - 10https://gerrit.wikimedia.org/r/149832 [05:28:11] <grrrit-wm1> (03CR) 10Nemo bis: "Rebased. In the menawhile isset() below became is_array() and there were whitespace changes, but the if structure didn't change." [extensions/AccessControl] - 10https://gerrit.wikimedia.org/r/149832 (owner: 10Nemo bis) [05:40:59] <grrrit-wm1> (03PS6) 10EBernhardson: WIP: G3: Mobile/nojs edit and reply full topic output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156203 [05:46:53] <grrrit-wm1> (03PS2) 10Prtksxna: render.article: Correctly space extract for landscape images with smaller heights [extensions/Popups] - 10https://gerrit.wikimedia.org/r/135779 [06:15:27] <grrrit-wm1> (03CR) 10Hashar: [C: 032] "As you said yesterday :)" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/156197 (owner: 10Addshore) [06:15:30] <grrrit-wm1> (03Merged) 10jenkins-bot: Remove wdj-apply-settings.sh [integration/jenkins] - 10https://gerrit.wikimedia.org/r/156197 (owner: 10Addshore) [06:16:39] <wikibugs> 3Wikimedia / 3Etherpad: Etherpad lite unusable at about 1000 lines or more (CPU load makes it lag) - 10https://bugzilla.wikimedia.org/46637#c14 (10Nemo) Just in case someone wonders, this is still relevant and LangEng is still using Google Docs because of this bug. [06:33:16] <grrrit-wm1> (03PS3) 10Prtksxna: render.article: Correctly space extract for landscape images with smaller heights [extensions/Popups] - 10https://gerrit.wikimedia.org/r/135779 [06:33:50] <grrrit-wm1> (03CR) 10Prtksxna: render.article: Correctly space extract for landscape images with smaller heights (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/135779 (owner: 10Prtksxna) [06:42:09] <wikibugs> 3MediaWiki extensions / 3Spam Blacklist: Spam blacklist disallows addition of blacklisted links which are already there - 10https://bugzilla.wikimedia.org/69775#c10 (10Dirk Beetstra) No, it is not resolved. It gets weirder and weirder. I tried to add: '{{Blacklisted-links|1= *http://my.mail.ru/mail/sekhme... [06:42:25] <wikibugs> 3MediaWiki / 3Uploading: Uppercase picture extensions like .PNG are not allowed - 10https://bugzilla.wikimedia.org/66667#c5 (10carchaias) This happens also on other browsers I test with IE11, IE8 and Firefox 31 . This happens also with other fileextensions like jpg and JPG. This happens also with other webse... [06:55:09] <wikibugs> 3Wikimedia / 3General/Unknown: Set up dev.wikimedia.org portal - 10https://bugzilla.wikimedia.org/65074#c8 (10Quim Gil) Let's merge this discussion with the work done at https://www.mediawiki.org/wiki/dev.wikimedia.org. Sorry for the duplicity of spaces, which will go away when we merge Bugzilla with Phabric... [06:55:19] <grrrit-wm1> (03CR) 10Florianschmidtwelzow: [C: 04-1] Add option to hide and unhide file thumbnails in file history (039 comments) [core] - 10https://gerrit.wikimedia.org/r/156048 (https://bugzilla.wikimedia.org/69053) (owner: 10Ebe123) [06:59:05] <grrrit-wm1> (03PS1) 10Pastakhov: add highlighting internal link (v 1.7.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156246 [06:59:23] <wikibugs> 3MediaWiki / 3File management: Previous versions of files should be collapsible - 10https://bugzilla.wikimedia.org/69053#c2 (10Florian) Is there an opinion by design or others? In my point of view there is no need to this. The thumbs in the history are fixed to max. 120 pixel. Opinions? :) [07:01:09] <grrrit-wm1> (03PS2) 10Pastakhov: add highlighting internal link (v 1.7.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156246 [07:05:31] <grrrit-wm1> (03CR) 10Pastakhov: [C: 032] add highlighting internal link (v 1.7.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156246 (owner: 10Pastakhov) [07:05:35] <grrrit-wm1> (03Merged) 10jenkins-bot: add highlighting internal link (v 1.7.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156246 (owner: 10Pastakhov) [07:07:25] <wikibugs> 3MediaWiki / 3Uploading: Uppercase picture extensions like .PNG are not allowed - 10https://bugzilla.wikimedia.org/66667#c6 (10carchaias) Removing the ! in includes/libs/IEUrlExtension.php at line 120 brings the files back in all cases mentioned in Comment 5 [07:09:54] <wikibugs> 3Wikimedia / 3Site requests: Restrict NS_FILE and NS_FILETALK edit to sysop on Korean Wikinews - 10https://bugzilla.wikimedia.org/70022#c4 (10Revi) (In reply to Alex Monk from comment #2) > That seems strange. . . Can you explain why this is wanted? We are currently using AbuseFilter for restricting File an... [07:22:00] <RobinHood70> According to several sources, the various MediaWiki sites are supposed to generate errors given an empty User-Agent string or a blacklisted one. Is this supposed to be only on editing or all the time? I just tried sending various read-only requests with no/blacklisted User-Agents via both index.php and api.php and they all came back fine. What gives? [07:22:09] <wikibugs> 3MediaWiki / 3User preferences: Allow larger/user-specified thumbnail sizes - 10https://bugzilla.wikimedia.org/11118 (10Marco) [07:22:09] <wikibugs> 3MediaWiki / 3User preferences: Change MediaWiki default thumbnail size to 300px based on user behavior - 10https://bugzilla.wikimedia.org/67703 (10Marco) [07:22:09] <wikibugs> 3MediaWiki / 3User preferences: Allow bigger thumbnail sizes in personal settings - 10https://bugzilla.wikimedia.org/69973 (10Marco) [07:22:10] <wikibugs> 3Wikimedia / 3Site requests: Increase WMF cluster default image thumb size (tracking) - 10https://bugzilla.wikimedia.org/49357 (10Marco) [07:26:54] <wikibugs> 3Wikimedia / 3Site requests: Restrict NS_FILE and NS_FILETALK edit to sysop on Korean Wikinews - 10https://bugzilla.wikimedia.org/70022#c5 (10jeremyb) I'd also like to have a steward weigh in on this. I don't know anything about the vandalism you're seeing and maybe a case could be made for File. However, I... [07:28:04] <grrrit-wm1> (03CR) 10Siebrand: Add option to hide and unhide file thumbnails in file history (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156048 (https://bugzilla.wikimedia.org/69053) (owner: 10Ebe123) [07:29:06] <grrrit-wm1> (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156048 (https://bugzilla.wikimedia.org/69053) (owner: 10Ebe123) [07:31:53] <grrrit-wm1> (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (035 comments) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/156243 (https://bugzilla.wikimedia.org/68277) (owner: 10Dan-nl) [07:32:39] <wikibugs> 3MediaWiki / 3JavaScript: Provide JavaScript login widget - 10https://bugzilla.wikimedia.org/69596#c5 (10contrafibularity) +1! With the additional service that without having to leave the page, you can check if you're still logged in and if not, log in again. I'm not sure if this would also put an end to t... [07:32:44] <grrrit-wm1> (03CR) 10Siebrand: [C: 04-1] "Needs unit tests (and an update of the commit message after that's done)." [core] - 10https://gerrit.wikimedia.org/r/156237 (https://bugzilla.wikimedia.org/69993) (owner: 10Santhosh) [07:33:27] <grrrit-wm1> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/156087 (owner: 10Legoktm) [07:34:43] <grrrit-wm1> (03CR) 10Siebrand: Change "Privacy policy" to "Privacy" in CPB (031 comment) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/155641 (owner: 10JGonera) [07:37:54] <wikibugs> 3MediaWiki extensions / 3UniversalLanguageSelector: Requesting adding AdorshoLipi font for Bangla - 10https://bugzilla.wikimedia.org/52719#c37 (10Kartik Mistry) 5PATC>3ASSI Set to assigned until bug(s) at upstream is fixed. [07:40:24] <wikibugs> 3MediaWiki extensions / 3Spam Blacklist: Spam blacklist disallows addition of blacklisted links which are already there - 10https://bugzilla.wikimedia.org/69775#c11 (10Dirk Beetstra) I see that is what you also show in your sandbox edit. (In reply to Dirk Beetstra from comment #10) > No, it is not resolved.... [07:40:56] <grrrit-wm1> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/148420 (https://bugzilla.wikimedia.org/67995) (owner: 10BryanDavis) [07:42:23] <grrrit-wm1> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155670 (owner: 10Jdlrobson) [07:45:15] <grrrit-wm1> (03CR) 10Siebrand: "@jon: The patch wasn't confusing to me. For convenience of Mattias, I pointed out what was left. I understand incremental improvement here" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156095 (owner: 10Matthias Mullie) [07:45:36] <grrrit-wm1> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156095 (owner: 10Matthias Mullie) [07:50:39] <wikibugs> 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c7 (10Erik Moeller) Michael, if common.js is non-blank, this will lead to site-wide errors in IE6 (and other disabled browsers). That was one of the motivations for Ti... [07:50:56] <wikibugs> 3MediaWiki / 3API: Echo notifications: parameter notlang not working, messages not translated - 10https://bugzilla.wikimedia.org/70023 (10metatron) 3NEW p:3Unprio s:3normal a:3None When using "notuselang" in query:meta/notifications, the parameter seems to be ignored or doesn't work. Tried several c... [07:51:22] <grrrit-wm1> (03CR) 10Siebrand: Cleanup special:interwiki intro (some more) (031 comment) [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/156190 (owner: 10Isarra) [07:51:46] <grrrit-wm1> (03CR) 10Gilles: [C: 04-1] "I'm afraid you're going to have to redo it anyway because in my review backlog there are several higher proprity refactoring changesets do" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester) [07:52:26] <grrrit-wm1> (03CR) 10Siebrand: "Nice. It wasn't invalid JSON, was it?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156156 (owner: 10Jdlrobson) [07:55:54] <wikibugs> 3Wikimedia / 3Site requests: Restrict NS_FILE and NS_FILETALK edit to sysop on Korean Wikinews - 10https://bugzilla.wikimedia.org/70022#c6 (10Revi) (In reply to jeremyb from comment #5) > I'd also like to have a steward weigh in on this. > > I don't know anything about the vandalism you're seeing and maybe... [07:59:53] <grrrit-wm1> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/156182 (owner: 10Bartosz Dziewoński) [08:06:06] <grrrit-wm1> (03CR) 10Smuggli: [C: 031] [WIP] PermissionManager Recode (039 comments) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156244 (owner: 10Lilu) [08:06:15] <grrrit-wm1> (03CR) 10Smuggli: [C: 04-1] [WIP] PermissionManager Recode [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156244 (owner: 10Lilu) [08:06:22] <grrrit-wm1> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/156052 (https://bugzilla.wikimedia.org/66811) (owner: 10Jack Phoenix) [08:10:39] <wikibugs> 3MediaWiki / 3API: Echo notifications: parameter notuselang not working, messages not translated - 10https://bugzilla.wikimedia.org/70023 (10metatron) [08:13:57] <grrrit-wm1> (03PS3) 10Prtksxna: Use `mw.popups.settings.navPopEnabled` instead of repeating the condition [extensions/Popups] - 10https://gerrit.wikimedia.org/r/153588 [08:15:54] <wikibugs> 3MediaWiki / 3General/Unknown: MediaWiki 2.0 (tracking) - 10https://bugzilla.wikimedia.org/70000#c1 (10Liu Xin Yu) congratulations! The 70000th bug! [08:17:38] <grrrit-wm1> (03CR) 10Prtksxna: "Andy, you're right. disablePopup would not have been defined when I was assigning settings.navPopEnabled. I've moved that and render to wi" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/153588 (owner: 10Prtksxna) [08:26:09] <wikibugs> 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c8 (10Andre Klapper) Another example: https://de.wikipedia.org/w/index.php?title=Wikipedia:Technik/Werkstatt&oldid=133432119#.C3.84nderung_im_Javascript.3F [08:27:05] <grrrit-wm1> (03PS4) 10Prtksxna: Force mw.popups.supportsSVG to false on InternetExplorer [extensions/Popups] - 10https://gerrit.wikimedia.org/r/142212 [08:27:25] <grrrit-wm1> (03PS2) 10Dan-nl: Add Special:Log Entries [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/156243 (https://bugzilla.wikimedia.org/68277) [08:28:12] <grrrit-wm1> (03CR) 10Dan-nl: "* i18n comments addressed in ps2" (035 comments) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/156243 (https://bugzilla.wikimedia.org/68277) (owner: 10Dan-nl) [08:28:14] <grrrit-wm1> (03CR) 10Prtksxna: Force mw.popups.supportsSVG to false on InternetExplorer (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/142212 (owner: 10Prtksxna) [08:29:54] <wikibugs> 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c9 (10Michael M.) (In reply to Erik Moeller from comment #7) > Michael, if common.js is non-blank, this will lead to site-wide errors in > IE6 (and other disabled brow... [08:47:57] <grrrit-wm1> (03PS1) 10Dan-nl: PHP Notice: Undefined index: contributors [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/156248 (https://bugzilla.wikimedia.org/70024) [08:52:20] <grrrit-wm1> (03PS1) 10Dan-nl: Improve duplicate and other contributors messages [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/156249 [08:55:09] <grrrit-wm1> (03CR) 10Microchip08: "Do we actually want this? Protocol-relative URLs are nice and all, but there's not really any reason not to push users towards secure site" (031 comment) [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/154031 (owner: 10Prtksxna) [08:58:49] <grrrit-wm1> (03CR) 10Siebrand: [C: 032] "i18n/L10n reviewed." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/156249 (owner: 10Dan-nl) [08:58:54] <grrrit-wm1> (03Merged) 10jenkins-bot: Improve duplicate and other contributors messages [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/156249 (owner: 10Dan-nl) [08:59:58] <grrrit-wm1> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/156243 (https://bugzilla.wikimedia.org/68277) (owner: 10Dan-nl) [09:22:39] <wikibugs> 3MediaWiki / 3General/Unknown: WebRequest::detectServer() appends ":80" to hostname when HTTP_X_FORWARDED_PROTO == "https" - 10https://bugzilla.wikimedia.org/70021 (10Andre Klapper) p:5Unprio>3Normal [09:22:54] <wikibugs> 3MediaWiki / 3Internationalization: Using variables inside plural definitions doesn't work in JavaScript - 10https://bugzilla.wikimedia.org/69993 (10Andre Klapper) p:5Unprio>3Normal [09:23:54] <wikibugs> 3MediaWiki / 3Parser: ­ is filtered out? - 10https://bugzilla.wikimedia.org/70014#c1 (10Andre Klapper) Which exact template? Link welcome. [09:31:10] <wikibugs> 3Wikimedia / 3Bugzilla: Bugzilla should have a 'test' product to test this bugzilla setup features - 10https://bugzilla.wikimedia.org/70020#c2 (10Andre Klapper) 5UNCO>3RESO/WOR (In reply to Bartosz Dziewoński from comment #1) > We had a test instance at some point – https://boogs.wmflabs.org/ – but it >... [09:31:54] <wikibugs> 3MediaWiki extensions / 3ProofreadPage: Consistency - 'toogleLayout' should be 'toggleLayout' - 10https://bugzilla.wikimedia.org/70017 (10Andre Klapper) 5UNCO>3NEW p:5Unprio>3Low s:5normal>3minor [09:40:09] <wikibugs> 3Wikimedia / 3General/Unknown: Apply enum changes to (img|oi|fa)_major_mime on production - 10https://bugzilla.wikimedia.org/70005 (10Andre Klapper) p:5Unprio>3Normal [09:40:24] <wikibugs> 3MediaWiki extensions / 3Scribunto: LuaSandbox reports substantially higher memory utilization under HHVM - 10https://bugzilla.wikimedia.org/70006 (10Andre Klapper) p:5Unprio>3Normal [09:42:09] <wikibugs> 3MediaWiki / 3Installer: Clean up list of default interwikis - 10https://bugzilla.wikimedia.org/69997#c1 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc Where is that list located in the codebase (if a contributor wanted to pick this up)? [09:43:31] <wikibugs> 3MediaWiki / 3Skin and page rendering: Mediawiki UI shouldn't change font-family for textareas - 10https://bugzilla.wikimedia.org/70028 (10Michael M.) 3NEW p:3Unprio s:3normal a:3None The edit box on http://mwui.wmflabs.org/w/index.php?title=Main_Page&action=edit uses a proportional font, while the d... [09:44:09] <wikibugs> 3MediaWiki / 3Uploading: Special uploadtext for the reupload form - 10https://bugzilla.wikimedia.org/17194#c3 (10Andre Klapper) 5UNCO>3RESO/WOR Heh, alright. Thanks for the reply :) [09:46:55] <wikibugs> 3MediaWiki extensions / 3SemanticResultFormats: Ploticus: Create skin to take advantage of CSS support - 10https://bugzilla.wikimedia.org/17522#c1 (10Andre Klapper) 5ASSI>3NEW p:5Normal>3Low a:5Joel Natividad>3None Joel Natividad: I am resetting the assignee of this issue to default because there... [09:50:26] <wikibugs> 3MediaWiki / 3Skin and page rendering: Search input and search button should have same height - 10https://bugzilla.wikimedia.org/70029 (10Michael M.) 3NEW p:3Unprio s:3minor a:3None On http://mwui.wmflabs.org/w/index.php?search=&title=Special%3ASearch&go=Go the search input has a height of 26px, whil... [09:54:55] <wikibugs> 3MediaWiki extensions / 3UniversalLanguageSelector: [Interlanguage links] Collapsed language links should be actual <a> elements - 10https://bugzilla.wikimedia.org/64797 (10Nemo) [09:54:55] <wikibugs> 3MediaWiki extensions / 3UniversalLanguageSelector: [Compact links] Prioritise interwikis to featured pages - 10https://bugzilla.wikimedia.org/68071 (10Nemo) [10:03:38] <grrrit-wm1> (03CR) 10Qgil: "What now? Should this patch be abandoned as well or can it be recycled?" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/132800 (owner: 10Tpt) [10:04:39] <grrrit-wm1> (03PS2) 10Qgil: [WIP] Introduces a JSON serialization for Page: pages [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/138355 (owner: 10Tpt) [10:06:41] <grrrit-wm1> (03CR) 10Qgil: "TheDJ, are you waiting for review or is this patch still WIP?" [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/122085 (https://bugzilla.wikimedia.org/59924) (owner: 10TheDJ) [10:07:43] <qgil> thedj_cloud, hi, you have many changesets apparenty waiting for review at https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/CodeEditor,n,z [10:08:04] <qgil> thedj_cloud, but many seem to be WIP? [10:08:18] <Nemo_bis> overwhelming helpfulness [10:08:31] <thedjNotWMF> qgil: a few yes. [10:08:55] <thedjNotWMF> qgil: and some not marked as wip, are even blocked on the [wip] ones [10:09:23] <qgil> thedj_cloud, if you have time, could you specify that they are [WIP]? This would help the non-wip shine. :) [10:09:52] <grrrit-wm1> (03PS5) 10TheDJ: [WIP] CodeEditor: Add support for Editor themes [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/122085 (https://bugzilla.wikimedia.org/59924) [10:09:54] <grrrit-wm1> (03CR) 10jenkins-bot: [V: 04-1] [WIP] CodeEditor: Add support for Editor themes [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/122085 (https://bugzilla.wikimedia.org/59924) (owner: 10TheDJ) [10:10:25] <grrrit-wm1> (03PS10) 10TheDJ: [WIP] Improve the CodeEditor toolbar [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/118993 [10:10:32] <qgil> thedjNotWMF, this would also get CodeEditor away from the top 10 at http://korma.wmflabs.org/browser/gerrit_review_queue.html :) [10:10:53] <thedjNotWMF> that's it [10:11:45] <grrrit-wm1> (03PS5) 10TheDJ: Ace: Update to 08-07-2014 [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/144780 (https://bugzilla.wikimedia.org/60432) [10:12:22] <thedjNotWMF> i really wish i had more time ... [10:12:28] <thedjNotWMF> :) [10:15:23] <grrrit-wm1> (03CR) 10Qgil: "Who can help reviewing this patch? LdapAuthentication doesn't even appear at https://www.mediawiki.org/wiki/Developers/Maintainers" [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/135024 (owner: 10Bugsbunny) [10:17:10] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Create jQuery.wikibase.aliasview - 10https://bugzilla.wikimedia.org/69470 (10tobias.gritschacher) 5PATC>3RESO/FIX [10:17:24] <wikibugs> 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c10 (10Michael M.) As actually nobody explicitly quoted the relevant standards yet: * ECMAScript defines FunctionDecleration and FunctionExpression. (http://ecma-inte... [10:18:01] <grrrit-wm1> (03PS7) 10Florianschmidtwelzow: SpecialRunJobs: Use Config instead of global [core] - 10https://gerrit.wikimedia.org/r/152114 (https://bugzilla.wikimedia.org/69187) [10:50:22] <grrrit-wm1> (03CR) 10Addshore: [C: 032] includes/htmlform/: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/156019 (owner: 10Legoktm) [10:50:41] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Allow adding references for statements on properties in the UI - 10https://bugzilla.wikimedia.org/68379 (10tobias.gritschacher) [10:50:43] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Support statements on properties in WikibaseDataModelSerializat ion - 10https://bugzilla.wikimedia.org/66425 (10tobias.gritschacher) [10:54:44] <grrrit-wm1> (03CR) 10Daniel Kinzler: [C: 031] "The approach seems fine, though perhaps it would be even better to inject individual settings instead of a config object." [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/153754 (owner: 10Legoktm) [10:56:48] <grrrit-wm1> (03Merged) 10jenkins-bot: includes/htmlform/: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/156019 (owner: 10Legoktm) [10:56:50] <qgil> thedjNotWMF, thank you! [10:58:49] <grrrit-wm1> (03PS3) 10Florianschmidtwelzow: SpecialUpload: Use Config instead of global [core] - 10https://gerrit.wikimedia.org/r/152134 (https://bugzilla.wikimedia.org/69188) [10:58:55] <grrrit-wm1> (03CR) 10Robert Vogel: [C: 032 V: 032] ContextMenu (NEW) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151625 (owner: 10Tweichart) [10:59:19] <grrrit-wm1> (03CR) 10jenkins-bot: [V: 04-1] SpecialUpload: Use Config instead of global [core] - 10https://gerrit.wikimedia.org/r/152134 (https://bugzilla.wikimedia.org/69188) (owner: 10Florianschmidtwelzow) [11:00:00] <prtksxna> siebrand: Could you tell me what the right way would be? https://gerrit.wikimedia.org/r/#/c/142481/1/resources/ext.popups.core.js [11:02:10] <grrrit-wm1> (03PS4) 10Florianschmidtwelzow: SpecialUpload: Use Config instead of global [core] - 10https://gerrit.wikimedia.org/r/152134 (https://bugzilla.wikimedia.org/69188) [11:02:32] <grrrit-wm1> (03PS4) 10Prtksxna: Use protocol relative URLs for links with https [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/154031 [11:12:39] <grrrit-wm1> (03CR) 10Robert Vogel: "So far I really like the new component based code. I've not had enough time to make a full review but I like the direction we are heading " (033 comments) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156244 (owner: 10Lilu) [11:19:41] <wikibugs> 3MediaWiki / 3Database: Postgre: undefined method Status::clearFlag() - 10https://bugzilla.wikimedia.org/70030 (10Peter Bena) 3NEW p:3Unprio s:3normal a:3None When installing mw on postgre I get a blank page, in error log I see: PHP Fatal error: Call to undefined method Status::clearFlag() in /home... [11:23:54] <wikibugs> 3Wikimedia / 3Site requests: Restrict NS_FILE and NS_FILETALK edit to sysop on Korean Wikinews - 10https://bugzilla.wikimedia.org/70022#c7 (10billinghurst) I think that differing from a global default position of what a user can expect to be able to do, so is not ideal, and in looking at https://ko.wikinews... [11:26:20] <grrrit-wm1> (03CR) 10Daniel Kinzler: Add missing @return and @param to doc blocks (033 comments) [core] - 10https://gerrit.wikimedia.org/r/156142 (owner: 10Umherirrender) [11:27:09] <wikibugs> 3MediaWiki extensions / 3Translate: tvar with underscore incomplete as insertable - 10https://bugzilla.wikimedia.org/69746 (10Niklas Laxström) p:5Unprio>3Normal s:5normal>3minor [11:29:42] <grrrit-wm1> (03PS2) 10Scnd: Add jpeg quality option [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/133121 [11:33:54] <grrrit-wm1> (03PS3) 10Santhosh: Support nesting of expressions in parameters of explicit plural forms [core] - 10https://gerrit.wikimedia.org/r/156237 (https://bugzilla.wikimedia.org/69993) [11:37:40] <wikibugs> 3MediaWiki extensions / 3Translate: [TUX] Hide "Hide own translations" when nothing to hide - 10https://bugzilla.wikimedia.org/48972#c6 (10Niklas Laxström) p:5Unprio>3Low s:5normal>3enhanc I'm unable to reproduce. Please note that the default view (unreviewed) of review mode does not include your own... [11:39:24] <wikibugs> 3MediaWiki extensions / 3Translate: Conflict of Special:MyLanguage: Extension and MW core use the same special page name - 10https://bugzilla.wikimedia.org/69461 (10Niklas Laxström) p:5Unprio>3Highes s:5normal>3major [11:41:08] <wikibugs> 3MediaWiki extensions / 3Translate: [HHVM] TranslateSandboxEmailJob failing - 10https://bugzilla.wikimedia.org/69251 (10Niklas Laxström) p:5Unprio>3Low s:5major>3normal [11:42:24] <wikibugs> 3MediaWiki extensions / 3Translate: Kazakh keyboard doesn't show up in Special:TranslationStash - 10https://bugzilla.wikimedia.org/69216 (10Niklas Laxström) p:5Unprio>3High [11:44:39] <wikibugs> 3MediaWiki extensions / 3Translate: [HHVM] phpunit assertion failure: in progress after first translation - 10https://bugzilla.wikimedia.org/68675 (10Niklas Laxström) p:5Unprio>3Low s:5normal>3major [11:49:39] <wikibugs> 3MediaWiki extensions / 3Translate: Special:MyLanguage should be a valid redirect target - 10https://bugzilla.wikimedia.org/49605#c1 (10Niklas Laxström) p:5Unprio>3Lowest s:5normal>3enhanc Request is reasonable. I think a such feature request should be created in core and added as blocker for this. [11:53:39] <wikibugs> 3MediaWiki extensions / 3Translate: Allow in-page translation for typo fixes etc. - 10https://bugzilla.wikimedia.org/65723#c1 (10Niklas Laxström) p:5Unprio>3Lowest This can happen as by product of integration with parsoid and VE, see for example https://www.mediawiki.org/wiki/Internationalisation_wishlis... [11:56:54] <wikibugs> 3MediaWiki extensions / 3Translate: No enabled connection [Called from CirrusSearch\ElasticsearchIntermediary::failure in /srv/vagrant/mediawiki/extensions/CirrusSearch/includes/ElasticsearchIntermediary.php at line 97] - 10https://bugzilla.wikimedia.org/68636#c1 (10Niklas Laxström) p:5Unprio>3High Somew... [11:59:54] <wikibugs> 3Wikimedia / 3Site requests: Restrict NS_FILE and NS_FILETALK edit to sysop on Korean Wikinews - 10https://bugzilla.wikimedia.org/70022#c8 (10Revi) 5UNCO>3RESO/WON Request withdrawn, per comment 7. [12:00:25] <wikibugs> 3Wikimedia / 3Site requests: Restrict NS_FILE and NS_FILETALK edit to sysop on Korean Wikinews - 10https://bugzilla.wikimedia.org/70022#c9 (10MF-Warburg) This filter https://ko.wikinews.org/wiki/%ED%8A%B9%EC%88%98:%ED%8E%B8%EC%A7%91%ED%95%84%ED%84%B0/4 exists since February to prevent edits by non-sysops in... [12:02:49] <grrrit-wm1> (03PS1) 10Helder.wiki: Fyx a typo in the function name: toogleLayout -> toggleLayout [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/156266 [12:06:00] <grrrit-wm1> (03CR) 10Hashar: "Yeah qunit is not migrated yet :-] I was looking for a test change I guess I have just found it. Thank you Bryan!" [core] - 10https://gerrit.wikimedia.org/r/119941 (owner: 10BryanDavis) [12:07:27] <grrrit-wm1> (03PS2) 10Helder.wiki: Fix a typo in the function name: toogleLayout -> toggleLayout [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/156266 [12:12:12] <grrrit-wm1> (03PS1) 10Hashar: Migrate mediawiki-core-qunit to Zuul cloner [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156268 [12:16:04] <grrrit-wm1> (03PS2) 10Hashar: Migrate mediawiki-core-qunit to Zuul cloner [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156268 [12:19:46] <grrrit-wm1> (03CR) 10Krinkle: [C: 04-1] Function.prototype.bind is also ECMAScript 5 (032 comments) [core] - 10https://gerrit.wikimedia.org/r/156215 (owner: 10EBernhardson) [12:21:47] <grrrit-wm1> (03CR) 10Krinkle: "Also, in what browser did you run into this? I think the author thought it was safe to assume that browsers with SVG all support Function#" [core] - 10https://gerrit.wikimedia.org/r/156215 (owner: 10EBernhardson) [12:24:08] <grrrit-wm1> (03PS2) 10Krinkle: phpcs: Pass ResourceLoader.php [core] - 10https://gerrit.wikimedia.org/r/156091 [12:25:15] <grrrit-wm1> (03CR) 10Bartosz Dziewoński: phpcs: Pass ResourceLoader.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156091 (owner: 10Krinkle) [12:25:24] <wikibugs> 3MediaWiki extensions / 3Translate: Translation: <tvar> should accept multi-line content - 10https://bugzilla.wikimedia.org/68451 (10Niklas Laxström) p:5Unprio>3Low s:5normal>3enhanc [12:26:55] <wikibugs> 3MediaWiki extensions / 3Translate: TranslateDeleteJob makes edits as 127.0.0.1 - 10https://bugzilla.wikimedia.org/68234#c1 (10Niklas Laxström) p:5Unprio>3Low s:5normal>3minor It's actually supposed to use the FuzzyBot account. [12:27:13] <grrrit-wm1> (03CR) 10Hashar: "I am hacking the mediawiki-core-qunit Jenkins job so it is going to fail. Sorry." [core] - 10https://gerrit.wikimedia.org/r/156091 (owner: 10Krinkle) [12:28:15] <grrrit-wm1> (03PS3) 10Hashar: Migrate mediawiki-core-qunit to Zuul cloner [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156268 [12:30:43] <grrrit-wm1> (03CR) 10jenkins-bot: [V: 04-1] phpcs: Pass ResourceLoader.php [core] - 10https://gerrit.wikimedia.org/r/156091 (owner: 10Krinkle) [12:30:54] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Replace old serialization code in lib with datamodel serialization - 10https://bugzilla.wikimedia.org/62188 (10tobias.gritschacher) [12:34:11] <grrrit-wm1> (03CR) 10Krinkle: "Hm.. doesn't feel right to have that arbitrary stuff in -qunit. What about mw-install-sqlite and literally single other macro that operate" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156268 (owner: 10Hashar) [12:34:23] <wikibugs> 3MediaWiki extensions / 3Translate: [TUX] Editor does not handle restricted languages properly - 10https://bugzilla.wikimedia.org/48804 (10Niklas Laxström) p:5Unprio>3High [12:34:24] <wikibugs> 3MediaWiki / 3Skin and page rendering: Mediawiki UI shouldn't change font-family for textareas - 10https://bugzilla.wikimedia.org/70028#c1 (10Bartosz Dziewoński) I think .mw-ui-input just shouldn't be applied to <textarea>s. Jon disagreed with me last time I brought it up, though. [12:34:39] <wikibugs> 3MediaWiki extensions / 3Translate: Deprecated: Use of SpecialRecentChangesQuery hook (used in TranslateRcFilter::translationFilter) - 10https://bugzilla.wikimedia.org/65776#c4 (10Niklas Laxström) 5REOP>3NEW p:5Unprio>3High Marking as high because the hooks will stop working at some point if we don't... [12:34:39] <wikibugs> 3MediaWiki extensions / 3Translate: TranslateDeleteJob makes edits as 127.0.0.1 - 10https://bugzilla.wikimedia.org/68234 (10Nemo) [12:34:39] <wikibugs> 3MediaWiki / 3Logging: 127.0.0.1, ::1, localhost, loopback, lo0 bugs (tracking) - 10https://bugzilla.wikimedia.org/58272 (10Nemo) [12:36:09] <wikibugs> 3MediaWiki extensions / 3Translate: On changing page language, translated pages should be moved automatically - 10https://bugzilla.wikimedia.org/68030 (10Niklas Laxström) p:5Unprio>3Low s:5normal>3enhanc [12:36:34] <grrrit-wm1> (03PS1) 10Krinkle: These are already going to #wikimedia-qa. Since all CI people are either in both or only in #wikimedia-qa, remove from here to reduce duplicate pings and overal noise. [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/156269 [12:36:59] <grrrit-wm1> (03PS2) 10Krinkle: #wikimedia-dev: No longer report integration/* [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/156269 [12:37:09] <wikibugs> 3MediaWiki extensions / 3Translate: Translate extension shows no "edit conflict" error when two users translate the same thing - 10https://bugzilla.wikimedia.org/67745 (10Niklas Laxström) p:5Unprio>3Normal s:5normal>3enhanc [12:37:24] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Support statements on properties in WikibaseDataModelSerialization - 10https://bugzilla.wikimedia.org/66425 (10tobias.gritschacher) [12:37:26] <grrrit-wm1> (03PS1) 10Addshore: Switch from experimental to test and gate for wikibase [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156270 [12:37:58] <grrrit-wm1> (03PS2) 10Addshore: Switch from experimental to test and gate for wikibase [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156270 [12:38:22] <grrrit-wm1> (03CR) 10Hashar: "Can probably make it a bit smarter. Meanwhile I need to adjust the qunit-querystring that injects settings in $WORKSPACE/LocalSettings.ph" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156268 (owner: 10Hashar) [12:39:39] <wikibugs> 3MediaWiki extensions / 3Translate: Translate: Round percentages down (for message matching) - 10https://bugzilla.wikimedia.org/67671#c1 (10Niklas Laxström) 5NEW>3RESO/WOR Unable to reproduce. The 100% match seems to be identical to the current translation. Please reopen with more info if the issue is st... [12:39:50] <grrrit-wm1> (03PS3) 10Krinkle: phpcs: Pass ResourceLoader.php [core] - 10https://gerrit.wikimedia.org/r/156091 [12:40:54] <wikibugs> 3MediaWiki extensions / 3Translate: Add plural (.stringsdict) support to AppleFFS for iOS/Mac OS X translation files - 10https://bugzilla.wikimedia.org/67636 (10Niklas Laxström) p:5Unprio>3Normal s:5normal>3enhanc [12:41:24] <wikibugs> 3MediaWiki / 3Parser: ­ is filtered out? - 10https://bugzilla.wikimedia.org/70014#c2 (10DaB.) (In reply to Andre Klapper from comment #1) > Which exact template? Link welcome. https://de.wikipedia.org/wiki/Wikipedia:Hauptseite/Artikel_des_Tages/Dienstag for example. [12:41:45] <grrrit-wm1> (03Abandoned) 10Addshore: Add composer-install-extensions builder [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125042 (owner: 10Addshore) [12:41:49] <grrrit-wm1> (03Abandoned) 10Addshore: Add extension composer-install bash script [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125041 (owner: 10Addshore) [12:50:16] <grrrit-wm1> (03CR) 10Krinkle: "Yeah, but those other files we can find a place for when we're there. The ones you mentioned can/should be primarily accesed through Resou" [core] - 10https://gerrit.wikimedia.org/r/155771 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [12:50:40] <grrrit-wm1> (03CR) 10Matthias Mullie: Fix Flow entries in Special:EditWatchlist (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156121 (owner: 10Matthias Mullie) [12:50:43] <grrrit-wm1> (03PS2) 10Matthias Mullie: Fix Flow entries in Special:EditWatchlist [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156121 [12:51:13] <grrrit-wm1> (03CR) 10Krinkle: "(RE: technicality, yes, Chrome does as well, actually, but doesn't need it)." [core] - 10https://gerrit.wikimedia.org/r/155771 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [12:51:23] <grrrit-wm1> (03PS4) 10Krinkle: mediawiki.api: Support assert parameter in getToken and postWithToken [core] - 10https://gerrit.wikimedia.org/r/156093 (owner: 10Nikerabbit) [12:51:25] <wikibugs> 3MediaWiki extensions / 3WikidataClient: Get rid of cron script for dispatching changes - 10https://bugzilla.wikimedia.org/64592 (10tobias.gritschacher) [12:51:25] <wikibugs> 3MediaWiki extensions / 3WikidataClient: track entity usage on client pages - 10https://bugzilla.wikimedia.org/47288 (10tobias.gritschacher) [12:53:24] <wikibugs> 3MediaWiki extensions / 3WikidataClient: Usage Tracking: implement the service - 10https://bugzilla.wikimedia.org/64587 (10tobias.gritschacher) [12:53:25] <wikibugs> 3MediaWiki extensions / 3WikidataClient: Usage Tracking: design database schema for service that registers where data is used - 10https://bugzilla.wikimedia.org/64586 (10tobias.gritschacher) [12:54:09] <grrrit-wm1> (03PS4) 10Hashar: Migrate mediawiki-core-qunit to Zuul cloner [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156268 [12:54:14] <grrrit-wm1> (03CR) 10Krinkle: [C: 04-1] Script to delete manual user global.js/css pages (031 comment) [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/154441 (https://bugzilla.wikimedia.org/68933) (owner: 10Legoktm) [12:57:52] <grrrit-wm1> (03CR) 10jenkins-bot: [V: 04-1] mediawiki.api: Support assert parameter in getToken and postWithToken [core] - 10https://gerrit.wikimedia.org/r/156093 (owner: 10Nikerabbit) [12:59:26] <wikibugs> 3MediaWiki extensions / 3Translate: Deprecate mw.translateHooks in favour of mw.hook - 10https://bugzilla.wikimedia.org/70031 (10Niklas Laxström) 3NEW p:3Unprio s:3normal a:3None Since we now depend on MediaWiki 1.22 or newer, we can use the core hook facility instead of shipping our own. [12:59:39] <wikibugs> 3MediaWiki extensions / 3Translate: Upon completed translation you end up at api - 10https://bugzilla.wikimedia.org/67292 (10Niklas Laxström) [12:59:39] <wikibugs> 3MediaWiki extensions / 3Translate: Deprecate mw.translateHooks in favour of mw.hook - 10https://bugzilla.wikimedia.org/70031 (10Niklas Laxström) p:5Unprio>3Normal [12:59:54] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: not possible to switch to Julian calendar model - 10https://bugzilla.wikimedia.org/65847 (10tobias.gritschacher) [13:00:24] <wikibugs> 3MediaWiki extensions / 3Translate: Upon completed translation you end up at api - 10https://bugzilla.wikimedia.org/67292#c5 (10Niklas Laxström) p:5Unprio>3Lowest The non-TUX ui is not getting any maintenance anymore. [13:02:54] <wikibugs> 3MediaWiki extensions / 3Translate: [TUX] Blacklisted languages can still be translated - 10https://bugzilla.wikimedia.org/54627#c5 (10Niklas Laxström) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 48804 *** [13:02:54] <wikibugs> 3MediaWiki extensions / 3Translate: [TUX] Editor does not handle restricted languages properly - 10https://bugzilla.wikimedia.org/48804#c5 (10Niklas Laxström) *** Bug 54627 has been marked as a duplicate of this bug. *** [13:04:24] <wikibugs> 3MediaWiki extensions / 3Translate: Make all sections of page optionally translatable - 10https://bugzilla.wikimedia.org/66634#c4 (10Niklas Laxström) 5NEW>3RESO/INV No compelling use case. [13:05:39] <wikibugs> 3MediaWiki extensions / 3Translate: Can not make a translation - 10https://bugzilla.wikimedia.org/66415 (10Niklas Laxström) p:5Unprio>3Normal [13:06:54] <wikibugs> 3MediaWiki extensions / 3Translate: Create cleanup script for message group definitions cache - 10https://bugzilla.wikimedia.org/65193#c1 (10Niklas Laxström) p:5Unprio>3Lowest Is this still needed after moving to subdirectory for each message group? [13:08:45] <grrrit-wm1> (03PS5) 10Hashar: Migrate mediawiki-core-qunit to Zuul cloner [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156268 [13:09:42] <grrrit-wm1> (03PS1) 10Petrb: created a new api to flag messages as read [core] - 10https://gerrit.wikimedia.org/r/156274 [13:10:54] <wikibugs> 3MediaWiki / 3API: No way to flag your talk page as read - 10https://bugzilla.wikimedia.org/64238#c2 (10Peter Bena) 5NEW>3PATC https://gerrit.wikimedia.org/r/#/c/156274/ [13:14:07] <grrrit-wm1> (03PS2) 10Petrb: created a new api to flag messages as read [core] - 10https://gerrit.wikimedia.org/r/156274 [13:14:24] <wikibugs> 3MediaWiki extensions / 3Translate: Create cleanup script for message group definitions cache - 10https://bugzilla.wikimedia.org/65193 (10Siebrand Mazeland) 5NEW>3RESO/WON [13:15:01] <grrrit-wm1> (03PS3) 10Nemo bis: created a new api to flag messages as read [core] - 10https://gerrit.wikimedia.org/r/156274 (https://bugzilla.wikimedia.org/64238) (owner: 10Petrb) [13:15:56] <wikibugs> 3MediaWiki / 3Database: Postgre: undefined method Status::clearFlag() - 10https://bugzilla.wikimedia.org/70030#c1 (10Andre Klapper) p:5Unprio>3Low Do you really use old outdated 1.22.2 as written in the "Version" field? [13:16:10] <wikibugs> 3MediaWiki / 3Database: PostgreSQL/pgsql support (tracking) - 10https://bugzilla.wikimedia.org/384 (10Andre Klapper) [13:17:09] <grrrit-wm1> (03PS22) 10Paladox: WikiEditor: Fix issue with SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) [13:17:28] <grrrit-wm1> (03PS23) 10Paladox: WikiEditor: Fix issue with SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) [13:18:44] <grrrit-wm1> (03PS4) 10Petrb: API: created a new api to flag messages as read [core] - 10https://gerrit.wikimedia.org/r/156274 [13:18:47] <grrrit-wm1> (03CR) 10Paladox: [C: 031] WikiEditor: Fix issue with SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [13:18:57] <grrrit-wm1> (03CR) 10Paladox: WikiEditor: Fix issue with SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [13:19:49] <grrrit-wm1> (03PS18) 10Paladox: WikiEditor: Convert .css to .less and add SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151616 [13:20:18] <grrrit-wm1> (03PS3) 10Paladox: Update jquery.ui Vector theme to 1.9.2 [skins/Vector] - 10https://gerrit.wikimedia.org/r/154024 [13:20:37] <grrrit-wm1> (03PS10) 10Paladox: TwitterLogin: Update auth link [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/151640 [13:22:07] <grrrit-wm1> (03PS1) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156275 [13:23:16] <grrrit-wm1> (03CR) 10Krinkle: "Regarding having the your global js on another wiki or page name, you can move it to Meta/global.js now (and use the bot to update your co" [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/154441 (https://bugzilla.wikimedia.org/68933) (owner: 10Legoktm) [13:23:30] <grrrit-wm1> (03CR) 10Hashar: [C: 031] #wikimedia-dev: No longer report integration/* [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/156269 (owner: 10Krinkle) [13:24:01] <grrrit-wm1> (03CR) 10Hashar: "recheck" [core] - 10https://gerrit.wikimedia.org/r/119941 (owner: 10BryanDavis) [13:24:02] <grrrit-wm1> (03CR) 10Krinkle: [C: 04-1] "All fine, except for the phpunit/assert @return." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/156142 (owner: 10Umherirrender) [13:24:43] <grrrit-wm1> (03CR) 10Manybubbles: [C: 031] "Works for me." [vagrant] - 10https://gerrit.wikimedia.org/r/156230 (owner: 10BryanDavis) [13:25:56] <wikibugs> 3MediaWiki / 3User preferences: Timezone information not correctly handled on Windows/XAMPP - 10https://bugzilla.wikimedia.org/70032 (10Tony Mach) 3UNCO p:3Unprio s:3normal a:3None I am using a Windows server with XAMPP to host MediaWiki 1.23.2. The Windows machine is set to "Europe/Berlin" timezone... [13:26:25] <grrrit-wm1> (03CR) 10Krinkle: [C: 04-1] Support nesting of expressions in parameters of explicit plural forms (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156237 (https://bugzilla.wikimedia.org/69993) (owner: 10Santhosh) [13:27:39] <wikibugs> 3MediaWiki / 3Database: Postgre: undefined method Status::clearFlag() - 10https://bugzilla.wikimedia.org/70030#c2 (10Peter Bena) p:5Low>3Unprio no, it's latest master actually (from gerrit) idk why this version was chosen [13:28:07] <grrrit-wm1> (03CR) 10Siebrand: "i18n/L10n reviewed." (032 comments) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151625 (owner: 10Tweichart) [13:28:09] <wikibugs> 3MediaWiki / 3Database: Postgre: undefined method Status::clearFlag() - 10https://bugzilla.wikimedia.org/70030#c3 (10Peter Bena) p:5Unprio>3Low and now it even changed the priority for no reason o.O bugzilla has bugs! [13:29:49] <grrrit-wm1> (03CR) 10Hashar: [C: 032] "That fix the qunit job for a mediawiki/core change that depends on mediawiki/vendor : https://gerrit.wikimedia.org/r/#/c/119941/" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156268 (owner: 10Hashar) [13:30:22] <grrrit-wm1> (03CR) 10Siebrand: [C: 04-1] phpcs: Pass ResourceLoader.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156091 (owner: 10Krinkle) [13:31:13] <grrrit-wm1> (03CR) 10Hashar: "The qunit job is fixed by JJB change https://gerrit.wikimedia.org/r/#/c/156268/ which updates the job to use Zuul cloner and does a few r" [core] - 10https://gerrit.wikimedia.org/r/119941 (owner: 10BryanDavis) [13:31:30] <grrrit-wm1> (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156275 (owner: 10Smuggli) [13:31:48] <grrrit-wm1> (03CR) 10Hashar: "recheck" [core] - 10https://gerrit.wikimedia.org/r/119940 (owner: 10BryanDavis) [13:31:50] <grrrit-wm1> (03Merged) 10jenkins-bot: Migrate mediawiki-core-qunit to Zuul cloner [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156268 (owner: 10Hashar) [13:32:09] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Create jQuery fingerprintview widget - 10https://bugzilla.wikimedia.org/69840 (10tobias.gritschacher) [13:32:15] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Edit mode for fingerprintlistview widget - 10https://bugzilla.wikimedia.org/69841 (10tobias.gritschacher) [13:32:18] <grrrit-wm1> (03CR) 10Hashar: "recheck" [core] - 10https://gerrit.wikimedia.org/r/119942 (owner: 10BryanDavis) [13:32:25] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Create jQuery fingerprintlistview widget - 10https://bugzilla.wikimedia.org/69839 (10tobias.gritschacher) [13:32:25] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Create jQuery.wikibase.labelview - 10https://bugzilla.wikimedia.org/69472 (10tobias.gritschacher) [13:32:31] <grrrit-wm1> (03CR) 10Hashar: "recheck" [core] - 10https://gerrit.wikimedia.org/r/141599 (owner: 10BryanDavis) [13:32:38] <grrrit-wm1> (03PS4) 10Krinkle: phpcs: Pass ResourceLoader.php [core] - 10https://gerrit.wikimedia.org/r/156091 [13:32:39] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Create jQuery.wikibase.descriptionview - 10https://bugzilla.wikimedia.org/69471 (10tobias.gritschacher) [13:32:39] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Section-edit mode for SiteLinks - 10https://bugzilla.wikimedia.org/68908 (10tobias.gritschacher) [13:32:40] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Factor interaction logic out of MergeItems API module, for re-use in SpecialMergeItems - 10https://bugzilla.wikimedia.org/68730 (10tobias.gritschacher) [13:32:49] <grrrit-wm1> (03CR) 10Krinkle: phpcs: Pass ResourceLoader.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156091 (owner: 10Krinkle) [13:32:54] <wikibugs> 3MediaWiki extensions / 3WikidataClient: draft RfC for improving recent changes formatting - 10https://bugzilla.wikimedia.org/68028 (10tobias.gritschacher) [13:32:54] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: [Monolingual] Exact language code match should be first - 10https://bugzilla.wikimedia.org/67395 (10tobias.gritschacher) [13:33:10] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Test conformance of API modules - 10https://bugzilla.wikimedia.org/67407 (10tobias.gritschacher) [13:33:59] <grrrit-wm1> (03PS5) 10Petrb: created a new api to flag messages as read [core] - 10https://gerrit.wikimedia.org/r/156274 [13:34:26] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Integrate aliases into fingerprintview - 10https://bugzilla.wikimedia.org/70033 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs The fingerprintview should support editing of aliases. [13:36:13] <grrrit-wm1> (03PS6) 10Petrb: API: created a new api to flag messages as read [core] - 10https://gerrit.wikimedia.org/r/156274 [13:37:06] <grrrit-wm1> (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/147755 (https://bugzilla.wikimedia.org/68241) (owner: 10Isarra) [13:37:55] <grrrit-wm1> (03CR) 10Matthias Mullie: Batchload all data required to fix Special:EditWatchlist titles (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156122 (owner: 10Matthias Mullie) [13:38:09] <grrrit-wm1> (03PS2) 10Matthias Mullie: Batchload all data required to fix Special:EditWatchlist titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156122 [13:38:17] <grrrit-wm1> (03CR) 10Siebrand: Add support for enabling and displaying global interwikis (031 comment) [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/147755 (https://bugzilla.wikimedia.org/68241) (owner: 10Isarra) [13:38:26] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Exception from line 84 WikiPageEntityRevisionLookup.php: Unresolved redirect - 10https://bugzilla.wikimedia.org/70034 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs When requesting Special:SetSiteLink with a redirect item, such as: https://www.wikidata.org/... [13:39:29] <grrrit-wm1> (03CR) 10Siebrand: [C: 032] phpcs: Pass ResourceLoader.php [core] - 10https://gerrit.wikimedia.org/r/156091 (owner: 10Krinkle) [13:40:54] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Integrate aliases into fingerprintview - 10https://bugzilla.wikimedia.org/70033 (10tobias.gritschacher) 5NEW>3ASSI p:5Unprio>3High [13:42:56] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Support statements on properties in WikibaseDataModel - 10https://bugzilla.wikimedia.org/70035 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Add support for statements on properties in DataModel 1.0. [13:43:09] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Support statements on properties in WikibaseDataModel - 10https://bugzilla.wikimedia.org/70035 (10tobias.gritschacher) 5NEW>3ASSI p:5Unprio>3High s:5normal>3major [13:43:19] <grrrit-wm1> (03PS1) 10Hashar: mediawiki/vendor now triggers qunit job [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156277 [13:43:33] <grrrit-wm1> (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151061 (https://bugzilla.wikimedia.org/30666) (owner: 10Ebe123) [13:43:35] <grrrit-wm1> (03CR) 10Hashar: "mediawiki-core-qunit is triggered on mediawiki/vendor changes with https://gerrit.wikimedia.org/r/156277" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156268 (owner: 10Hashar) [13:43:54] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Support statements on properties in WikibaseDataModel - 10https://bugzilla.wikimedia.org/70035 (10tobias.gritschacher) [13:43:54] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Support statements on properties in WikibaseDataModelSerialization - 10https://bugzilla.wikimedia.org/66425 (10tobias.gritschacher) [13:43:58] <grrrit-wm1> (03CR) 10Hashar: [C: 032] mediawiki/vendor now triggers qunit job [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156277 (owner: 10Hashar) [13:44:11] <grrrit-wm1> (03Merged) 10jenkins-bot: mediawiki/vendor now triggers qunit job [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156277 (owner: 10Hashar) [13:44:13] <grrrit-wm1> (03PS1) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156278 [13:44:40] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Support statements on properties in WikibaseDataModel - 10https://bugzilla.wikimedia.org/70035 (10tobias.gritschacher) [13:44:55] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: allow statements on properties - 10https://bugzilla.wikimedia.org/49554 (10tobias.gritschacher) [13:45:10] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Allow adding references for statements on properties in the UI - 10https://bugzilla.wikimedia.org/68379 (10tobias.gritschacher) 5NEW>3ASSI [13:45:25] <grrrit-wm1> (03Merged) 10jenkins-bot: phpcs: Pass ResourceLoader.php [core] - 10https://gerrit.wikimedia.org/r/156091 (owner: 10Krinkle) [13:45:33] <grrrit-wm1> (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [vendor] - 10https://gerrit.wikimedia.org/r/156279 [13:46:10] <wikibugs> 3MediaWiki extensions / 3WikidataClient: Usage Tracking: design database schema for service that registers where data is used - 10https://bugzilla.wikimedia.org/64586 (10tobias.gritschacher) 5NEW>3ASSI [13:46:54] <wikibugs> 3MediaWiki extensions / 3WikidataClient: Usage Tracking: implement the service - 10https://bugzilla.wikimedia.org/64587 (10tobias.gritschacher) [13:46:55] <wikibugs> 3MediaWiki extensions / 3WikidataClient: Usage Tracking: implement the service - 10https://bugzilla.wikimedia.org/64587 (10tobias.gritschacher) 5NEW>3ASSI [13:47:46] <grrrit-wm1> (03CR) 10Addshore: [C: 032] Improve GlobalVarConfigTest [core] - 10https://gerrit.wikimedia.org/r/156005 (owner: 10Legoktm) [13:48:33] <grrrit-wm1> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156278 (owner: 10Smuggli) [13:49:02] <grrrit-wm1> (03CR) 10Siebrand: "i18n/L10n reviewed." [extensions/MultimediaPlayer] - 10https://gerrit.wikimedia.org/r/152194 (owner: 10tosfos) [13:50:39] <wikibugs> 3MediaWiki extensions / 3WikidataClient: track entity usage on client pages - 10https://bugzilla.wikimedia.org/47288 (10tobias.gritschacher) [13:50:40] <wikibugs> 3MediaWiki extensions / 3WikidataClient: Get rid of cron script for dispatching changes - 10https://bugzilla.wikimedia.org/64592 (10tobias.gritschacher) [13:50:40] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Refactor dispatch changes code - 10https://bugzilla.wikimedia.org/70036 (10tobias.gritschacher) p:5Unprio>3High [13:53:50] <grrrit-wm1> (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [vendor] - 10https://gerrit.wikimedia.org/r/156279 (owner: 10Hashar) [13:54:17] <grrrit-wm1> (03Merged) 10jenkins-bot: Improve GlobalVarConfigTest [core] - 10https://gerrit.wikimedia.org/r/156005 (owner: 10Legoktm) [13:54:42] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Automate Entity Suggester Data Updates - 10https://bugzilla.wikimedia.org/70037 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs At the moment the script that updates the entity suggester data is triggered manually. It would be nice to have a cr... [13:54:54] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Automate Entity Suggester Data Updates - 10https://bugzilla.wikimedia.org/70037 (10tobias.gritschacher) p:5Unprio>3Low [13:56:09] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: not possible to switch to Julian calendar model - 10https://bugzilla.wikimedia.org/65847 (10tobias.gritschacher) 5NEW>3ASSI [13:56:26] <wikibugs> 3MediaWiki / 3Database: User::loadPasswords 400% spike on wmf db masters - 10https://bugzilla.wikimedia.org/70038 (10Sean Pringle) 3NEW p:3Unprio s:3major a:3None Around 2014-08-21 20:00:00 all WMF master database servers experienced a permanent increase in read traffic, between 50% and 400%. Write-l... [13:56:39] <wikibugs> 3MediaWiki / 3Database: User::loadPasswords 400% spike on wmf db masters - 10https://bugzilla.wikimedia.org/70038 (10Sean Pringle) p:5Unprio>3High [13:57:24] <grrrit-wm1> (03CR) 10Siebrand: [C: 032] Check if wgAuth is set correctly [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/151444 (https://bugzilla.wikimedia.org/68962) (owner: 10Florianschmidtwelzow) [13:57:30] <grrrit-wm1> (03Merged) 10jenkins-bot: Check if wgAuth is set correctly [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/151444 (https://bugzilla.wikimedia.org/68962) (owner: 10Florianschmidtwelzow) [13:57:32] <grrrit-wm1> (03CR) 10Phe: [C: 031] "Obvious typo, I didn't find any other occurrence of toogleLayout in 1.24wmf17 proofread extension javascript." [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/156266 (owner: 10Helder.wiki) [13:57:46] <grrrit-wm1> (03PS1) 10Hashar: Give a name to mediawiki/core gating queue [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156280 [13:57:54] <grrrit-wm1> (03CR) 10Bartosz Dziewoński: [C: 04-1] "Stylistic nitpicks." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/156274 (owner: 10Petrb) [13:58:24] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Switch to DataModel 1.0 - 10https://bugzilla.wikimedia.org/70039 (10tobias.gritschacher) 5NEW>3ASSI p:5Unprio>3High s:5normal>3major [13:59:10] <grrrit-wm1> (03PS5) 10Shirayuki: i18n: make extension descriptions translatable [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156082 [13:59:15] <grrrit-wm1> (03PS2) 10Hashar: Give a name to mediawiki/core gating queue [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156280 [14:00:06] <grrrit-wm1> (03CR) 10Hashar: [C: 032] Give a name to mediawiki/core gating queue [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156280 (owner: 10Hashar) [14:00:15] <grrrit-wm1> (03Merged) 10jenkins-bot: Give a name to mediawiki/core gating queue [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156280 (owner: 10Hashar) [14:01:13] <grrrit-wm1> (03CR) 10Addshore: [C: 04-1] Add jobs for wikibase (031 comment) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156114 (owner: 10Addshore) [14:02:19] <grrrit-wm1> (03CR) 10Anomie: [C: 04-1] "In general, I don't much like the naming here. You're clearing the indicator that the user's talk page has new messages, but the name is v" (038 comments) [core] - 10https://gerrit.wikimedia.org/r/156274 (owner: 10Petrb) [14:10:09] <wikibugs> 3MediaWiki / 3General/Unknown: Bugs affecting translatewiki.net (errors from MediaWiki master) (tracking) - 10https://bugzilla.wikimedia.org/39480 (10Nemo) [14:10:10] <wikibugs> 3MediaWiki / 3Database: User::loadPasswords 400% spike on wmf db masters - 10https://bugzilla.wikimedia.org/70038#c1 (10Sean Pringle) Worth noting that SELECT /* User::loadFromDatabase ... */ has been in the top 10 queries on masters for a while, but it is barely 1/10th the volume of SELECT /* User::loadPass... [14:10:12] <wikibugs> 3MediaWiki extensions / 3LiquidThreads: PHP Notice: Undefined offset: 1198 in ThreadPermalinkView.php on line 125 - 10https://bugzilla.wikimedia.org/70040 (10Nemo) 3NEW p:3Unprio s:3normal a:3None 15.53 -rakkaus:#mediawiki-i18n- [26-Aug-2014 13:52:58 UTC] PHP Notice: Undefined offset: 1198 in... [14:10:39] <wikibugs> 3MediaWiki extensions / 3Translate: Translate: Round percentages down (for message matching) - 10https://bugzilla.wikimedia.org/67671#c2 (10Lokal_Profil) 5RESO/WOR>3REOP (In reply to Niklas Laxström from comment #1) > Unable to reproduce. The 100% match seems to be identical to the current > translation.... [14:14:38] <grrrit-wm1> (03CR) 10Smuggli: Implemented changes for translatewiki (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156275 (owner: 10Smuggli) [14:17:11] <grrrit-wm1> (03CR) 10Addshore: "Our current tests only test against master of mediawiki so no need to worry!" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156114 (owner: 10Addshore) [14:22:23] <wikibugs> 3MediaWiki extensions / 3Translate: Upon completed translation you end up at api - 10https://bugzilla.wikimedia.org/67292#c6 (10Nemo) Formerly known as bug 52541. [14:22:24] <wikibugs> 3MediaWiki extensions / 3Translate: TypeError: mw.translateHooks is undefined: qqq editor popup opens a json document and redirects to api.php after saving - 10https://bugzilla.wikimedia.org/52541 (10Nemo) [14:24:23] <grrrit-wm1> (03PS2) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156275 [14:24:45] <grrrit-wm1> (03CR) 10Smuggli: [C: 032 V: 032] Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156278 (owner: 10Smuggli) [14:26:05] <grrrit-wm1> (03PS4) 10Santhosh: Support nesting of expressions in parameters of explicit plural forms [core] - 10https://gerrit.wikimedia.org/r/156237 (https://bugzilla.wikimedia.org/69993) [14:26:31] <grrrit-wm1> (03CR) 10Santhosh: Support nesting of expressions in parameters of explicit plural forms (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156237 (https://bugzilla.wikimedia.org/69993) (owner: 10Santhosh) [14:27:34] <grrrit-wm1> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156275 (owner: 10Smuggli) [14:30:55] <wikibugs> 3MediaWiki extensions / 3Translate: Microsoft TTM returns incorrect newlines - 10https://bugzilla.wikimedia.org/58121 (10Kartik Mistry) [14:31:24] <wikibugs> 3MediaWiki / 3Database: missing 'patch-add_interwiki.sql' for the includes/installer/PostgresqlUpdater.php - 10https://bugzilla.wikimedia.org/69360#c2 (10Marcin Cieślak) 5NEW>3UNCO Is there any way you keep getting an error message? A year ago I did extensive tests attempting to upgrade pretty various o... [14:34:08] <grrrit-wm1> (03CR) 10Gergő Tisza: [C: 04-1] "Just a tiny issue, but more importantly, shouldn't we have a separate UploadWIzardErrorEvent schema? IMO errors are important enough that " (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/144588 (owner: 10Gergő Tisza) [14:34:36] <jackmcbarn> anomie: i found a fatal that i'm having trouble debugging. it happens when i run twoArgs from https://en.wikipedia.org/wiki/Module:Sandbox/Jackmcbarn [14:34:39] <wikibugs> 3MediaWiki extensions / 3Spam Blacklist: Spam blacklist disallows addition of blacklisted links which are already there - 10https://bugzilla.wikimedia.org/69775#c12 (10Jackmcbarn) That is the exact same thing. Bare links can't end with a question mark. If you want a link to end in a question mark, you have t... [14:34:55] * anomie looks [14:35:59] <jackmcbarn> the one thing i did notice is that it only happens if you use Preprocessor_DOM, not _Hash, and i get warnings about xpath being used on the wrong document [14:38:09] <wikibugs> 3MediaWiki / 3Database: User::loadPasswords 400% spike on wmf db masters - 10https://bugzilla.wikimedia.org/70038#c2 (10Jesús Martínez Novo (Ciencia Al Poder)) I doubt gerrit change 151649 is the cause, since it added $this->loadPasswords(); in setPassword and setNewpasswords, which should be called only whe... [14:40:33] <grrrit-wm1> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/146054 (https://bugzilla.wikimedia.org/51971) (owner: 10Deepali) [14:40:56] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: [DM 1.0 compat] Fix RemoveClaimsTest failure - 10https://bugzilla.wikimedia.org/70041 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs php phpunit.php --group WikibaseAPI PHPUnit 3.7.32 by Sebastian Bergmann. Configuration read from /var/lib/je... [14:41:12] <grrrit-wm1> (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/141891 (https://bugzilla.wikimedia.org/65300) (owner: 10Deepali) [14:41:39] <wikibugs> 3MediaWiki extensions / 3Translate: MicrosoftWebService mangles some newlines - 10https://bugzilla.wikimedia.org/58121#c1 (10Niklas Laxström) It's not TTM. [14:41:39] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Switch to DataModel 1.0 - 10https://bugzilla.wikimedia.org/70039 (10tobias.gritschacher) [14:41:40] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: [DM 1.0 compat] Fix RemoveClaimsTest failure - 10https://bugzilla.wikimedia.org/70041 (10tobias.gritschacher) p:5Unprio>3Normal [14:41:40] <grrrit-wm1> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/151397 (https://bugzilla.wikimedia.org/66775) (owner: 10Deepali) [14:43:23] <grrrit-wm1> (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156082 (owner: 10Shirayuki) [14:44:26] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: [DM 1.0 compat] Fix NoBadDependencyUsageTest failure - 10https://bugzilla.wikimedia.org/70042 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Wikibase\Lib\Test\NoBadDependencyUsageTest::testNoRepoUsageInLib You are not allowed to use WikibaseRe... [14:44:40] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: [DM 1.0 compat] Fix NoBadDependencyUsageTest failure - 10https://bugzilla.wikimedia.org/70042 (10tobias.gritschacher) p:5Unprio>3High [14:44:55] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Switch to DataModel 1.0 - 10https://bugzilla.wikimedia.org/70039 (10tobias.gritschacher) [14:45:48] <grrrit-wm1> (03CR) 10Bartosz Dziewoński: "Yet another rebase needed…" [core] - 10https://gerrit.wikimedia.org/r/155903 (owner: 10Bartosz Dziewoński) [14:46:11] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: [DM 1.0 compat] Fix PropertyViewTest failures - 10https://bugzilla.wikimedia.org/70043 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs 2) Wikibase\Test\PropertyViewTest::testParserOutputLinks with data set "PropertyNoValueSnak" (array(Wikibase\... [14:46:29] <grrrit-wm1> (03PS7) 10Bartosz Dziewoński: TablePager: Modernize style loading [core] - 10https://gerrit.wikimedia.org/r/155903 [14:46:39] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: [DM 1.0 compat] Fix NoBadDependencyUsageTest failure - 10https://bugzilla.wikimedia.org/70042 (10tobias.gritschacher) 5NEW>3ASSI [14:46:39] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: [DM 1.0 compat] Fix RemoveClaimsTest failure - 10https://bugzilla.wikimedia.org/70041 (10tobias.gritschacher) 5NEW>3ASSI [14:46:54] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: [DM 1.0 compat] Fix RemoveClaimsTest failure - 10https://bugzilla.wikimedia.org/70041 (10tobias.gritschacher) p:5Normal>3High [14:47:24] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: [DM 1.0 compat] Fix PropertyViewTest failures - 10https://bugzilla.wikimedia.org/70043 (10tobias.gritschacher) 5NEW>3ASSI p:5Unprio>3High [14:47:24] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Switch to DataModel 1.0 - 10https://bugzilla.wikimedia.org/70039 (10tobias.gritschacher) [14:47:41] <grrrit-wm1> (03CR) 10Chad: [C: 031] #wikimedia-dev: No longer report integration/* [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/156269 (owner: 10Krinkle) [14:48:26] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: [DM 1.0 compat] Fix ChangeOpsMergeTest errors - 10https://bugzilla.wikimedia.org/70044 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs There were 4 errors: 1) Wikibase\Test\ChangeOpsMergeTest::testCanApply with data set "claimMerge" (array(arr... [14:49:52] <grrrit-wm1> (03CR) 10Chad: [C: 032] "I long for the day we set this code on fire." [core] - 10https://gerrit.wikimedia.org/r/156232 (owner: 10Legoktm) [14:50:16] <legoktm> :o [14:50:35] <grrrit-wm1> (03PS1) 10Bartosz Dziewoński: Delete feed.css [core] - 10https://gerrit.wikimedia.org/r/156292 (https://bugzilla.wikimedia.org/69277) [14:50:39] <thedjNotWMF> MatmaRex: block formatting context :) [14:50:55] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: [DM 1.0 compat] Fix ChangeOpsMergeTest errors - 10https://bugzilla.wikimedia.org/70044 (10tobias.gritschacher) 5NEW>3ASSI p:5Unprio>3High [14:50:55] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Switch to DataModel 1.0 - 10https://bugzilla.wikimedia.org/70039 (10tobias.gritschacher) [14:50:55] <grrrit-wm1> (03CR) 10Bartosz Dziewoński: "Okay, I submitted https://gerrit.wikimedia.org/r/156292 to remove this file instead." [core] - 10https://gerrit.wikimedia.org/r/155771 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [14:51:09] <wikibugs> 3MediaWiki extensions / 3Translate: Translate: Round percentages down (for message matching) - 10https://bugzilla.wikimedia.org/67671 (10Niklas Laxström) 5REOP>3NEW p:5Unprio>3Normal s:5enhanc>3minor [14:51:39] <wikibugs> 3MediaWiki extensions / 3[other]: [Auth_remoteuser] PHP Fatal error: Call to undefined method GoogleLoginAuth::setupExtensionForRequest() in Auth_remoteuser.php on line 129 - 10https://bugzilla.wikimedia.org/68962 (10Florian) 5PATC>3RESO/FIX [14:51:44] <grrrit-wm1> (03Abandoned) 10Bartosz Dziewoński: Move feed.css to resources/, introduce resources/src/assets/ [core] - 10https://gerrit.wikimedia.org/r/155771 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [14:51:56] <MatmaRex> thedjNotWMF: be bold :) [14:52:33] <grrrit-wm1> (03PS8) 10Legoktm: Add a script to delete manual user global.js/css pages [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/154441 (https://bugzilla.wikimedia.org/68933) [14:52:56] <legoktm> Krinkle: ^ is that commit message better now? :) [14:53:06] <Krinkle> yep [14:53:33] <MatmaRex> Krinkle: hey, wanna help getting rid of skins/common/? i have a bunch more patches pending [14:53:39] <wikibugs> 3Wikimedia / 3Site requests: Restrict NS_FILE and NS_FILETALK edit to sysop on Korean Wikinews - 10https://bugzilla.wikimedia.org/70022 (10Nemo) 5RESO/WON>3RESO/INV [14:53:39] <wikibugs> 3MediaWiki / 3Database: User::loadPasswords 400% spike on wmf db masters - 10https://bugzilla.wikimedia.org/70038#c3 (10Sean Pringle) Yeah, I see, that does sound odd. Possibly https://gerrit.wikimedia.org/r/#/c/151569/ [14:53:41] <MatmaRex> Krinkle: without any pesky 'assets' directories :) [14:53:55] <Krinkle> MatmaRex: Sure, +1 at the least [14:54:11] <Krinkle> Might be too busy for confident/verified +2 though, but go ahead [14:54:18] <MatmaRex> https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/core+branch:master+topic:bug/69277,n,z this stuff, mostly [14:55:14] <grrrit-wm1> (03CR) 10Krinkle: [C: 031] "Yay :) Do we want to add release notes?" [core] - 10https://gerrit.wikimedia.org/r/156292 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [14:55:32] <grrrit-wm1> (03CR) 10Gergő Tisza: [C: 04-1] Move confirmCloseWindow to core (032 comments) [core] - 10https://gerrit.wikimedia.org/r/151128 (owner: 10MarkTraceur) [14:55:46] <grrrit-wm1> (03CR) 10Jforrester: [C: 031] Delete feed.css [core] - 10https://gerrit.wikimedia.org/r/156292 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [14:55:54] <wikibugs> 3MediaWiki / 3Database: User::loadPasswords 400% spike on wmf db masters - 10https://bugzilla.wikimedia.org/70038#c4 (10Kunal Mehta (Legoktm)) (In reply to Sean Pringle from comment #3) > Possibly https://gerrit.wikimedia.org/r/#/c/151569/ Ugh, I wonder if this is due to bug 69381. That might explain it... [14:56:06] <grrrit-wm1> (03CR) 10Bartosz Dziewoński: "We might. I'll add release notes for all removed files from skins/common/ later." [core] - 10https://gerrit.wikimedia.org/r/156292 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [14:56:30] <grrrit-wm1> (03Merged) 10jenkins-bot: AjaxDispatcher: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/156232 (owner: 10Legoktm) [14:57:22] <grrrit-wm1> (03PS2) 10Bartosz Dziewoński: Delete feed.css [core] - 10https://gerrit.wikimedia.org/r/156292 (https://bugzilla.wikimedia.org/69277) [14:58:24] <wikibugs> 3MediaWiki / 3Installer: Clean up list of default interwikis - 10https://bugzilla.wikimedia.org/69997#c2 (10Kunal Mehta (Legoktm)) core/maintenance/interwiki.list [14:59:28] <DanielK_WMDE> guys, i'm apparently too stupid to switch to the new way of installing skins. the skin directory from the tarball doesn't work for me, since it has the php files directly in skins/, not in skins/vector, etc [14:59:28] <grrrit-wm1> (03CR) 10Krinkle: TablePager: Modernize style loading (031 comment) [core] - 10https://gerrit.wikimedia.org/r/155903 (owner: 10Bartosz Dziewoński) [14:59:53] <DanielK_WMDE> i'm somewhat confused about how this is supposed to work... [15:00:04] <grrrit-wm1> (03CR) 10Krinkle: [C: 032] Delete feed.css [core] - 10https://gerrit.wikimedia.org/r/156292 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [15:00:27] <MatmaRex> DanielK_WMDE: ugh yes, the 1.23 tarball is probably not good [15:00:50] <MatmaRex> DanielK_WMDE: it will get easier when 1.24 is build, right now you should probably clone the skins from git [15:00:53] <DanielK_WMDE> MatmaRex: so, the recommended way of doing this is currently broken=? [15:01:05] <MatmaRex> the repos are mediawiki/skins/Vector, mediawiki/skins/MonoBook, and so on [15:01:29] <MatmaRex> DanielK_WMDE: that's recommended for end-users, and they aren't supposed to use master, but apart from that probably yes [15:01:43] <DanielK_WMDE> no, this is the method recommended for people who installed from git. [15:01:50] <DanielK_WMDE> it explicitly refers to developers [15:01:55] <DanielK_WMDE> that sucks. [15:02:05] <MatmaRex> really? that's silly [15:02:07] * MatmaRex looks [15:02:20] <DanielK_WMDE> the error message shown in the wiki says so [15:02:32] <DanielK_WMDE> https://www.mediawiki.org/wiki/Manual:Skin_configuration/de also sais so [15:02:48] <MatmaRex> :* Downloading the [https://www.mediawiki.org/wiki/Download tarball installer], which comes with several skins and extensions. You can copy and paste the <code>skins/</code> directory from it. [15:02:49] <MatmaRex> :* Cloning one of the <code>mediawiki/skins/*</code> repositories via git into the <code>skins/</code> directory of your MediaWiki installation. [15:03:12] <MatmaRex> hmm [15:03:26] <DanielK_WMDE> MatmaRex: the german version seems to be quite different then [15:03:30] <MatmaRex> DanielK_WMDE: would specifying tarball 1.24 or newer be a good idea? or how would you rephrase? [15:04:03] <thedjNotWMF> DanielK_WMDE: you trust translated docs ? [15:04:09] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: [DM 1.0 compat] Fix NoBadDependencyUsageTest failure - 10https://bugzilla.wikimedia.org/70042#c1 (10Jeroen De Dauw) Should be fixed by PS6 of https://gerrit.wikimedia.org/r/#/c/153714/ [15:04:09] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: [DM 1.0 compat] Fix NoBadDependencyUsageTest failure - 10https://bugzilla.wikimedia.org/70042 (10Jeroen De Dauw) 5ASSI>3PATC [15:04:14] <MatmaRex> DanielK_WMDE: the original version of this message might have been missing the part about git, and i updated it after people complained like you :) [15:04:15] <DanielK_WMDE> MatmaRex: actually, the english message seems to be ok, the german one is completely different [15:04:30] <MatmaRex> so i guess the translation might be outdated [15:04:31] <DanielK_WMDE> hrmpf. [15:04:32] <thedjNotWMF> DanielK_WMDE: guaranteed to be more outdated then the original documentation probably is already outdated :) [15:04:44] <MatmaRex> this is the message 'default-skin-not-found-no-skins', feel free to fix it :D [15:04:54] <MatmaRex> (and also 'default-skin-not-found' for a slightly different message) [15:06:13] <grrrit-wm1> (03PS1) 10Matthias Mullie: Make jqueryMsg properly parse n= prefixed PLURAL options [core] - 10https://gerrit.wikimedia.org/r/156297 [15:06:16] <DanielK_WMDE> MatmaRex: if i ever figure out how to do anything on translatewiki.net, i will fix it :/ [15:06:29] <grrrit-wm1> (03Merged) 10jenkins-bot: Delete feed.css [core] - 10https://gerrit.wikimedia.org/r/156292 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [15:06:49] <MatmaRex> DanielK_WMDE: you can ignore the stupid UI entirely and just edit MediaWiki: pages [15:06:52] <grrrit-wm1> (03PS3) 10Matthias Mullie: i18n: get rid of hardcoded 'x comments' text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156095 [15:07:22] <MatmaRex> https://translatewiki.net/wiki/MediaWiki:Default-skin-not-found-no-skins/de [15:07:28] <MatmaRex> https://translatewiki.net/wiki/MediaWiki:Default-skin-not-found/de [15:07:44] <MatmaRex> (assuming you have translator permissions) [15:07:56] <aude> poor DanielK_WMDE [15:07:57] <DanielK_WMDE> MatmaRex: i don't think i do ;) [15:08:36] <MatmaRex> DanielK_WMDE: i do, i can copy-paste if you pastebin a translation [15:09:22] <DanielK_WMDE> MatmaRex: ok, now i'm missing assets. [15:09:39] <aude> is there still stuff in skins/common ? [15:10:02] <DanielK_WMDE> hm, might have killed that when removing "old skins" [15:10:03] <MatmaRex> aude: yes. but you can help reviewing my patches which are removing more and more of it [15:10:12] * aude cry [15:10:17] <MatmaRex> https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/core+branch:master+topic:bug/69277,n,z [15:10:24] <wikibugs> 3MediaWiki extensions / 3Extensions requests: Implement global user module (Wikimedia-wide user CSS/JS) - 10https://bugzilla.wikimedia.org/13953 (10James Forrester) 5PATC>3RESO/FIX [15:10:37] <DanielK_WMDE> MatmaRex, aude: ok, restoring common/ fixed it [15:10:39] <wikibugs> 3Wikimedia / 3Extension setup: Review and deploy GlobalCssJs extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/57891 (10James Forrester) 5PATC>3RESO/FIX [15:11:03] <James_F> legoktm: ^^^ Congratulations. :-) [15:11:07] <legoktm> :) [15:11:24] <aude> i could probably +1 but not qualifeid enough about things like caching to +@ [15:11:27] <aude> 2 [15:11:37] <James_F> legoktm: Now you just need to help me delete all my "mw.loader.load('//meta.wikimedia.org/w/index.php?title=User:Jdforrester (WMF)/global.js&action=raw&ctype=text/javascript'); " lines. :-) [15:11:39] <grrrit-wm1> (03CR) 10Matthias Mullie: "The hardcoded stuff Siebrand pointed out was not introduced in this patch - it was just existing stuff that was not yet fixed in this patc" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156095 (owner: 10Matthias Mullie) [15:11:53] <MatmaRex> aude: there are no caching problems here, actually, as far as i can tell [15:12:00] <legoktm> James_F: did you sign up for the script? https://meta.wikimedia.org/wiki/GlobalCssJs [15:12:08] <MatmaRex> aude: the skins directory is "versioned" with wmf versions [15:12:36] <MatmaRex> aude: so the images referred to by older versions of pages won't disappear [15:13:00] <grrrit-wm1> (03CR) 10jenkins-bot: [V: 04-1] Make jqueryMsg properly parse n= prefixed PLURAL options [core] - 10https://gerrit.wikimedia.org/r/156297 (owner: 10Matthias Mullie) [15:13:11] <wikibugs> 3MediaWiki / 3Database: User::loadPasswords 400% spike on wmf db masters - 10https://bugzilla.wikimedia.org/70038#c5 (10Jesús Martínez Novo (Ciencia Al Poder)) Gerrit change 149658 can be related: Changed password default to PBKDF2. Bug 28419 From release notes: The default password type for MediaWiki has b... [15:13:11] <James_F> legoktm: Done. [15:13:28] <grrrit-wm1> (03CR) 10Smuggli: [C: 032 V: 032] Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156275 (owner: 10Smuggli) [15:13:39] <James_F> legoktm: Some will need selective editing rather than deleting, sadly. I guess I just have to work on those ones myself? [15:13:45] <MatmaRex> aude: y'know, if no one merges the changes, the directory isn't going to disappear by itself [15:13:57] <legoktm> James_F: yeah, I'll provide you with a list of ones the script didn't touch afterwards [15:14:04] <James_F> legoktm: Ta. You're awesome. [15:14:10] <aude> MatmaRex: i see [15:14:25] <MatmaRex> ;) [15:15:09] <grrrit-wm1> (03CR) 10Matthias Mullie: [C: 04-1] "Also need to update TemplateHelper.php to reflect these changes." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155670 (owner: 10Jdlrobson) [15:15:38] <wikibugs> 3MediaWiki extensions / 3EducationProgram: Add UserMerge support to EducationProgram - 10https://bugzilla.wikimedia.org/67767#c3 (10Andrew Green) Hi! Yeah, sorry I haven't gotten to it yet :( . Thanks for poking me about it. If you feel like taking this, please do go ahead :) . Also, maybe let's chat on IRC... [15:16:09] <grrrit-wm1> (03CR) 10Matthias Mullie: "NVM; just noticed you did so in the follow-up patch" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155670 (owner: 10Jdlrobson) [15:16:28] <anomie> jackmcbarn: Care to file a bug about that for me to refer to in the patch? [15:16:53] <grrrit-wm1> (03PS8) 10Bartosz Dziewoński: TablePager: Modernize style loading [core] - 10https://gerrit.wikimedia.org/r/155903 [15:16:59] <grrrit-wm1> (03CR) 10Bartosz Dziewoński: TablePager: Modernize style loading (031 comment) [core] - 10https://gerrit.wikimedia.org/r/155903 (owner: 10Bartosz Dziewoński) [15:17:12] <grrrit-wm1> (03PS9) 10Bartosz Dziewoński: TablePager: Modernize style loading [core] - 10https://gerrit.wikimedia.org/r/155903 [15:17:16] <jackmcbarn> anomie: kk [15:17:19] <thedjNotWMF> MatmaRex: pff, you are maing everything way too modern :) [15:17:47] <greg-g> thedjNotWMF: hah re nick :) [15:17:48] <MatmaRex> thedjNotWMF: life was simpler when we just had $wgOut and $wgTitle ;) [15:17:56] <grrrit-wm1> (03PS9) 10BryanDavis: Use MWLogger logging for wfLogProfilingData [core] - 10https://gerrit.wikimedia.org/r/119942 [15:17:59] <thedjNotWMF> greg-g: ;) [15:18:54] <grrrit-wm1> (03PS3) 10BryanDavis: Add logging context to database logs [core] - 10https://gerrit.wikimedia.org/r/141599 [15:18:56] <wikibugs> 3MediaWiki / 3Parser: Preprocessor_DOM causes fatal errors when called in certain ways - 10https://bugzilla.wikimedia.org/70046 (10Jackmcbarn) 3NEW p:3Unprio s:3normal a:3None Given the following Lua module: local p = {} function p.main(frame) return 'Hello world' end function p.fnOnly(frame)... [15:18:57] <jackmcbarn> anomie: ^ [15:18:59] <MatmaRex> thedjNotWMF: btw, i've rebased these release notes four times already. care to review? :D [15:19:09] <grrrit-wm1> (03PS4) 10Bartosz Dziewoński: TablePager: Load images via CSS backgrounds rather than HTML <img>s [core] - 10https://gerrit.wikimedia.org/r/155910 (https://bugzilla.wikimedia.org/69277) [15:19:21] <grrrit-wm1> (03PS2) 10Bartosz Dziewoński: IndexPager: Don't generate rel=first and rel=last [core] - 10https://gerrit.wikimedia.org/r/156125 [15:19:35] <grrrit-wm1> (03PS4) 10Bartosz Dziewoński: TablePager: Redo arrow icons from scratch as CSS backgrounds [core] - 10https://gerrit.wikimedia.org/r/155914 (https://bugzilla.wikimedia.org/69277) [15:19:47] <grrrit-wm1> (03PS2) 10Bartosz Dziewoński: IndexPager: Introduce constants for values of $mDefaultDirection [core] - 10https://gerrit.wikimedia.org/r/156128 [15:19:54] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: [DM 1.0 compat] Fix ChangeOpsMergeTest errors - 10https://bugzilla.wikimedia.org/70044#c1 (10Addshore) I get different errors. Argument 1 passed to Wikibase\DataModel\Statement\StatementList::addStatement() must be an instance of Wikibase\DataModel\Statement\Statement,... [15:20:20] <thedjNotWMF> MatmaRex: i'm still at work, i can't test code right now. [15:22:54] <wikibugs> 3MediaWiki / 3Database: User::loadPasswords 400% spike on wmf db masters - 10https://bugzilla.wikimedia.org/70038#c6 (10Florian) > the code is loading the password anyway to check if it's an old MD5 hash, even if it then realizes it shouldn't be changed. Hmm, but LocalSettings (CommonSettings) overrides Def... [15:22:55] <grrrit-wm1> (03PS1) 10Anomie: Handle multiple ownerDocuments for args in Preprocessor_DOM [core] - 10https://gerrit.wikimedia.org/r/156299 (https://bugzilla.wikimedia.org/70046) [15:24:48] <grrrit-wm1> (03CR) 10Bartosz Dziewoński: [C: 032] Allow custom event handlers for the click event of toolbar buttons [core] - 10https://gerrit.wikimedia.org/r/155912 (owner: 10Helder.wiki) [15:25:19] <grrrit-wm1> (03CR) 10Gergő Tisza: "TheDJ: see comments at https://gerrit.wikimedia.org/r/#/c/151128/8/resources/src/mediawiki.action/mediawiki.action.edit.editWarning.js" [core] - 10https://gerrit.wikimedia.org/r/151140 (owner: 10MarkTraceur) [15:25:50] <grrrit-wm1> (03CR) 10Gergő Tisza: "No concerns apart from that one." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151127 (owner: 10MarkTraceur) [15:26:11] <grrrit-wm1> (03CR) 10Gergő Tisza: [C: 031] Move confirmCloseWindow to core [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151127 (owner: 10MarkTraceur) [15:26:41] <grrrit-wm1> (03CR) 10jenkins-bot: [V: 04-1] Add logging context to database logs [core] - 10https://gerrit.wikimedia.org/r/141599 (owner: 10BryanDavis) [15:29:55] <jackmcbarn> anomie: it looks like Parser.php:3698 is where it's being called multiple times, right? why is that doing that that way? [15:30:08] <grrrit-wm1> (03CR) 10TheDJ: "Applause ..." [core] - 10https://gerrit.wikimedia.org/r/151128 (owner: 10MarkTraceur) [15:31:05] <grrrit-wm1> (03CR) 10Bartosz Dziewoński: [C: 04-1] "I like this." [core] - 10https://gerrit.wikimedia.org/r/156229 (owner: 10Helder.wiki) [15:31:28] <anomie> jackmcbarn: I tried to adjust that, but then merging any inputs that were already PPNodes with whatever was generated there without screwing up potentially-significant ordering seemed like more trouble. [15:31:48] <grrrit-wm1> (03Merged) 10jenkins-bot: Allow custom event handlers for the click event of toolbar buttons [core] - 10https://gerrit.wikimedia.org/r/155912 (owner: 10Helder.wiki) [15:35:07] <grrrit-wm1> (03CR) 10TheDJ: "I remember Krinkle or Catrope telling me at Zurich, that part of the reason for having it like this had to do with forcing the load order " [core] - 10https://gerrit.wikimedia.org/r/156229 (owner: 10Helder.wiki) [15:39:07] <grrrit-wm1> (03PS2) 10Jackmcbarn: Handle multiple ownerDocuments for args in Preprocessor_DOM [core] - 10https://gerrit.wikimedia.org/r/156299 (https://bugzilla.wikimedia.org/70046) (owner: 10Anomie) [15:39:14] <grrrit-wm1> (03CR) 10Jackmcbarn: [C: 032] Handle multiple ownerDocuments for args in Preprocessor_DOM [core] - 10https://gerrit.wikimedia.org/r/156299 (https://bugzilla.wikimedia.org/70046) (owner: 10Anomie) [15:41:18] <grrrit-wm1> (03CR) 10Shirayuki: "Replacing plain() by parse() causes the following error:" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156082 (owner: 10Shirayuki) [15:44:09] <wikibugs> 3MediaWiki / 3Database: Postgre: undefined method Status::clearFlag() - 10https://bugzilla.wikimedia.org/70030#c4 (10Marcin Cieślak) Full backtrace: [26-Aug-2014 17:41:00 Europe/Warsaw] PHP Fatal error: Call to undefined method Status::clearFlag() in /usr/home/saper/public_html/pg/w/includes/installer/Post... [15:44:47] <grrrit-wm1> (03PS4) 10BryanDavis: Add logging context to database logs [core] - 10https://gerrit.wikimedia.org/r/141599 [15:46:03] <grrrit-wm1> (03CR) 10MarkTraceur: Move confirmCloseWindow to core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151128 (owner: 10MarkTraceur) [15:46:10] <grrrit-wm1> (03Merged) 10jenkins-bot: Handle multiple ownerDocuments for args in Preprocessor_DOM [core] - 10https://gerrit.wikimedia.org/r/156299 (https://bugzilla.wikimedia.org/70046) (owner: 10Anomie) [15:50:11] <grrrit-wm1> (03CR) 10Jforrester: "The objective of this change was to make the repo pass quickly and then I'd rebase all outstanding patchsets, as is normal. Doing it the o" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester) [15:52:34] <grrrit-wm1> (03PS9) 10MarkTraceur: Move confirmCloseWindow to core [core] - 10https://gerrit.wikimedia.org/r/151128 [15:52:42] <grrrit-wm1> (03CR) 10MarkTraceur: Move confirmCloseWindow to core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151128 (owner: 10MarkTraceur) [15:56:12] <grrrit-wm1> (03PS2) 10Matthias Mullie: Make jqueryMsg properly parse n= prefixed PLURAL options [core] - 10https://gerrit.wikimedia.org/r/156297 [15:57:14] <renoirb> Is there a recommended endpoint I should use for Varnish health checks? [15:59:53] <grrrit-wm1> (03CR) 10Gergő Tisza: [C: 04-1] Add start/end and whileActive to the campaigns (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153818 (https://bugzilla.wikimedia.org/64685) (owner: 10MarkTraceur) [16:01:39] <wikibugs> 3MediaWiki / 3Database: User::loadPasswords 400% spike on wmf db masters - 10https://bugzilla.wikimedia.org/70038#c7 (10Sam Reed (reedy)) (In reply to Jesús Martínez Novo (Ciencia Al Poder) from comment #5) > A) the change to use MD5 on WMF isn't being applied somehow. reedy@tin:~$ mwscript eval.php mediawi... [16:01:44] <bd808> renoirb: Looks like we mostly check against "/check"; not sure what script/file that is -- https://github.com/wikimedia/operations-puppet/blob/production/modules/varnish/templates/vcl/wikimedia.vcl.erb [16:01:52] <grrrit-wm1> (03CR) 10Petrb: "Which name would you like then?" [core] - 10https://gerrit.wikimedia.org/r/156274 (owner: 10Petrb) [16:02:36] <renoirb> Oh, a "heartbeat" endpoint, nice! Let me try to find that [16:02:53] <renoirb> Maybe its an extension bd808|DEPLOY [16:02:56] <grrrit-wm1> (03CR) 10jenkins-bot: [V: 04-1] Make jqueryMsg properly parse n= prefixed PLURAL options [core] - 10https://gerrit.wikimedia.org/r/156297 (owner: 10Matthias Mullie) [16:05:11] <grrrit-wm1> (03CR) 10Matthias Mullie: Hygiene: Standardise on time i10n parameter (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155672 (owner: 10Jdlrobson) [16:07:29] <grrrit-wm1> (03PS3) 10Matthias Mullie: Make jqueryMsg properly parse n= prefixed PLURAL options [core] - 10https://gerrit.wikimedia.org/r/156297 [16:07:35] <grrrit-wm1> (03PS8) 10Matthias Mullie: Hygiene: Standardise on time i10n parameter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155672 (owner: 10Jdlrobson) [16:08:21] <grrrit-wm1> (03CR) 10Bartosz Dziewoński: "Duplicate patch: https://gerrit.wikimedia.org/r/#/c/156297/" [core] - 10https://gerrit.wikimedia.org/r/156237 (https://bugzilla.wikimedia.org/69993) (owner: 10Santhosh) [16:08:26] <grrrit-wm1> (03CR) 10Bartosz Dziewoński: "Duplicate patch: https://gerrit.wikimedia.org/r/#/c/156237/" [core] - 10https://gerrit.wikimedia.org/r/156297 (owner: 10Matthias Mullie) [16:08:30] <grrrit-wm1> (03CR) 10Matthias Mullie: [C: 031] "LGTM. Merge at will if https://gerrit.wikimedia.org/r/#/c/155672/ looks good as well" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155670 (owner: 10Jdlrobson) [16:10:53] <grrrit-wm1> (03CR) 10Matthias Mullie: [C: 031] "LGTM now. Just take another looks and see what you think about removing the stuff from TemplateHelpers.php altogether. If that's ok, go ah" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155672 (owner: 10Jdlrobson) [16:14:02] <grrrit-wm1> (03CR) 10jenkins-bot: [V: 04-1] Make jqueryMsg properly parse n= prefixed PLURAL options [core] - 10https://gerrit.wikimedia.org/r/156297 (owner: 10Matthias Mullie) [16:14:24] <wikibugs> 3MediaWiki / 3Database: User::loadPasswords 400% spike on wmf db masters - 10https://bugzilla.wikimedia.org/70038#c8 (10Chris Steipp) Any users with type :A: passwords will get their hash updated to type :B:, but that should be a pretty small segment of users. I can confirm normal users with type :B: passwor... [16:14:34] <grrrit-wm1> (03CR) 10Manybubbles: [C: 04-1] "Something wrong with my time fix." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/155339 (owner: 10Manybubbles) [16:14:44] <grrrit-wm1> (03PS9) 10Legoktm: Add a script to delete manual user global.js/css pages [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/154441 (https://bugzilla.wikimedia.org/68933) [16:19:08] <grrrit-wm1> (03CR) 10Bartosz Dziewoński: [C: 032] Add a script to delete manual user global.js/css pages [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/154441 (https://bugzilla.wikimedia.org/68933) (owner: 10Legoktm) [16:19:13] <grrrit-wm1> (03Merged) 10jenkins-bot: Add a script to delete manual user global.js/css pages [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/154441 (https://bugzilla.wikimedia.org/68933) (owner: 10Legoktm) [16:20:40] <grrrit-wm1> (03Abandoned) 10Matthias Mullie: Make jqueryMsg properly parse n= prefixed PLURAL options [core] - 10https://gerrit.wikimedia.org/r/156297 (owner: 10Matthias Mullie) [16:23:44] <grrrit-wm1> (03PS1) 10Wctaiwan: Move call to onUserGetRights [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/156307 (https://bugzilla.wikimedia.org/69381) [16:25:39] <grrrit-wm1> (03CR) 10Legoktm: [C: 04-1] Move call to onUserGetRights (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/156307 (https://bugzilla.wikimedia.org/69381) (owner: 10Wctaiwan) [16:26:14] <grrrit-wm1> (03CR) 10Florianschmidtwelzow: [C: 04-1] Move call to onUserGetRights (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/156307 (https://bugzilla.wikimedia.org/69381) (owner: 10Wctaiwan) [16:27:37] <grrrit-wm1> (03PS2) 10Wctaiwan: Move call to onUserGetRights [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/156307 (https://bugzilla.wikimedia.org/69381) [16:29:47] <grrrit-wm1> (03CR) 10CSteipp: [C: 031] "I think the benefits outweigh the downside." [core] - 10https://gerrit.wikimedia.org/r/153110 (owner: 10Anomie) [16:31:14] <grrrit-wm1> (03CR) 10Florianschmidtwelzow: [C: 031] Move call to onUserGetRights [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/156307 (https://bugzilla.wikimedia.org/69381) (owner: 10Wctaiwan) [16:31:23] <grrrit-wm1> (03CR) 10Krinkle: [C: 04-2] "No. mw.toolbar has always been presented as an unconditional call. Further handled on the client-side based on user preferences, editor of" [core] - 10https://gerrit.wikimedia.org/r/156229 (owner: 10Helder.wiki) [16:33:15] <grrrit-wm1> (03CR) 10Krinkle: [C: 04-1] "Hm.. never mind. Not what I thought it was. Yes, we should do this! Though the module is better named mediawiki.toolbar." [core] - 10https://gerrit.wikimedia.org/r/156229 (owner: 10Helder.wiki) [16:34:11] <grrrit-wm1> (03PS5) 10Krinkle: API: Overhaul token handling [core] - 10https://gerrit.wikimedia.org/r/153110 (owner: 10Anomie) [16:34:42] <grrrit-wm1> (03CR) 10Krinkle: "There is no such thing as "Depends-On". Not used by anything, not documented, not interpreted. Converted to a plain list as part of the co" [core] - 10https://gerrit.wikimedia.org/r/153110 (owner: 10Anomie) [16:35:31] <grrrit-wm1> (03CR) 10Anomie: "We tend to use pseudo-footers fairly often. I see no point to your change." [core] - 10https://gerrit.wikimedia.org/r/153110 (owner: 10Anomie) [16:36:33] <^d> Summary: This change does something [16:36:42] <^d> Bug: 1234 [16:36:46] <^d> RT: 9414 [16:37:00] <^d> See-Also: aabb5769 [16:37:17] <^d> Im: Hungry [16:38:12] <grrrit-wm1> (03CR) 10Krinkle: Allow custom event handlers for the click event of toolbar buttons (031 comment) [core] - 10https://gerrit.wikimedia.org/r/155912 (owner: 10Helder.wiki) [16:39:54] <grrrit-wm1> (03CR) 10Legoktm: [C: 032] Move call to onUserGetRights [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/156307 (https://bugzilla.wikimedia.org/69381) (owner: 10Wctaiwan) [16:40:05] <grrrit-wm1> (03Merged) 10jenkins-bot: Move call to onUserGetRights [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/156307 (https://bugzilla.wikimedia.org/69381) (owner: 10Wctaiwan) [16:40:14] <grrrit-wm1> (03PS5) 10Manybubbles: Send groovy script for updates to limit changes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/155339 [16:42:40] <grrrit-wm1> (03PS1) 10Krinkle: mw.toolbar: Don't mask the error of button.onClick being invalid [core] - 10https://gerrit.wikimedia.org/r/156310 [16:42:48] <grrrit-wm1> (03CR) 10Krinkle: "Fixed in Ie33b900f1d11." [core] - 10https://gerrit.wikimedia.org/r/155912 (owner: 10Helder.wiki) [16:44:36] <grrrit-wm1> (03CR) 10Bartosz Dziewoński: [C: 032] mw.toolbar: Don't mask the error of button.onClick being invalid [core] - 10https://gerrit.wikimedia.org/r/156310 (owner: 10Krinkle) [16:45:14] <grrrit-wm1> (03CR) 10Krinkle: "Personally, I'd go further and say that block has no business being in a mediawiki core commit message at all (better suited for a gerrit " [core] - 10https://gerrit.wikimedia.org/r/153110 (owner: 10Anomie) [16:46:31] <grrrit-wm1> (03CR) 10Krinkle: "The main thing to keep in mind is that users should not have to deal with any conditions and logic. All they do is "if (mw.toolbar) {". No" [core] - 10https://gerrit.wikimedia.org/r/156229 (owner: 10Helder.wiki) [16:49:19] <^d> awjr: Reason: Message body is too big: 674343 bytes with a limit of 225 KB [16:50:38] <grrrit-wm1> (03PS4) 10Krinkle: es5-shim: Add polyfill for Object.create [core] - 10https://gerrit.wikimedia.org/r/156046 (https://bugzilla.wikimedia.org/67590) [16:50:40] <wikibugs> 3Wikimedia / 3General/Unknown: Help users clean up manual importing of global.js/global.css pages across Wikimedia wikis - 10https://bugzilla.wikimedia.org/68933#c9 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3Kunal Mehta (Legoktm) Currently running this for users who signed up on [[m:GlobalCssJs]]... [16:50:50] <grrrit-wm1> (03Merged) 10jenkins-bot: mw.toolbar: Don't mask the error of button.onClick being invalid [core] - 10https://gerrit.wikimedia.org/r/156310 (owner: 10Krinkle) [16:50:51] <awjr> ^d ? [16:50:52] <grrrit-wm1> (03CR) 10Bartosz Dziewoński: es5-shim: Add polyfill for Object.create (032 comments) [core] - 10https://gerrit.wikimedia.org/r/156046 (https://bugzilla.wikimedia.org/67590) (owner: 10Krinkle) [16:51:10] <^d> awjr: Your e-mail to wikitech-l is held for moderation because of the big attachment :p [16:51:12] <grrrit-wm1> (03PS5) 10Bartosz Dziewoński: es5-shim: Add polyfill for Object.create [core] - 10https://gerrit.wikimedia.org/r/156046 (https://bugzilla.wikimedia.org/67590) (owner: 10Krinkle) [16:51:21] <awjr> ^d >_< [16:51:51] <grrrit-wm1> (03CR) 10Bartosz Dziewoński: "Feel a bit icky to attach this to a module for an external library." [core] - 10https://gerrit.wikimedia.org/r/156046 (https://bugzilla.wikimedia.org/67590) (owner: 10Krinkle) [16:52:04] <grrrit-wm1> (03PS9) 10Jdlrobson: i18n: Allow translation of participants and comment_count [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155827 [16:52:07] <grrrit-wm1> (03PS6) 10Krinkle: es5-shim: Add polyfill for Object.create [core] - 10https://gerrit.wikimedia.org/r/156046 (https://bugzilla.wikimedia.org/67590) [16:52:10] <legoktm> no attachments to mailing lists! use commons or mw.o >.> [16:52:12] <awjr> ^d the file i attached was ~375kb - is that really 'big'? [16:52:15] <Nemo_bis> http://xkcd.com/949/ applies [16:52:36] <awjr> hehehe [16:52:39] <awjr> again, 375kb... [16:52:42] <awjr> not 25mb [16:53:07] <grrrit-wm1> (03CR) 10Krinkle: "But also, compatibibility -> compatibility" [core] - 10https://gerrit.wikimedia.org/r/156046 (https://bugzilla.wikimedia.org/67590) (owner: 10Krinkle) [16:53:24] <^d> Maybe I could raise it to 512kb. [16:53:39] <legoktm> awjr: please don't send attachments to mailing lists, just use commons or mw.o [16:53:49] <awjr> legoktm: i will remember this for the future [16:53:53] <legoktm> marktraceur probably has the link to where it says that. [16:53:55] <^d> Well attachments are allowed through on wikitech-l, but mainly for text. [16:54:10] <^d> Hence the low limit. [16:54:11] <awjr> ^d feel free to delete the email; i'll upload the screenshot to mw.o [16:54:17] <awjr> and send again. [16:54:56] <grrrit-wm1> (03PS5) 10Jdlrobson: Support nesting of expressions in parameters of explicit plural forms [core] - 10https://gerrit.wikimedia.org/r/156237 (https://bugzilla.wikimedia.org/69993) (owner: 10Santhosh) [16:55:08] <Nemo_bis> legoktm: https://wiki.toolserver.org/view/Mailing_list_etiquette , but says "large" [16:55:41] <legoktm> oh ugh [16:55:54] <^d> If we didn't have the setting turned on at all, we have people who send out 25mb images of new hires :p [16:55:54] <legoktm> the page I was thinking of is on officewiki. [16:55:57] <^d> Maybe it was 23mb. [16:56:21] <awjr> ironically, the email to wikitech-l announcing the report has 3 attachments ;) [16:57:32] <Nemo_bis> ^d: a 50 KB jpg converted to .bmp and rescaled up? :) [16:58:21] <marktraceur> legoktm: It's not a policy, I think, yeah [16:58:39] <wikibugs> 3MediaWiki / 3Database: User::loadPasswords 400% spike on wmf db masters - 10https://bugzilla.wikimedia.org/70038#c9 (10Sean Pringle) Yep, confirmed. Looking only at enwiki sampled traffic, user 20181147 'MediaWiki message delivery' accounts for 98.6% of the User::loadPasswords queries. [16:59:16] <grrrit-wm1> (03PS10) 10Jdlrobson: i18n: Allow translation of participants and comment_count [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155827 [17:00:23] <grrrit-wm1> (03CR) 10Bartosz Dziewoński: [C: 031] "Feel a bit icky to attach this to a module for an external library, but it's mostly reasonable since this is, as I understand, a "fork" of" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156046 (https://bugzilla.wikimedia.org/67590) (owner: 10Krinkle) [17:01:11] <awjr> ^d perhaps attachments should just be disabled to the list if it is indeed policy or prevailing sentiment [17:01:53] <grrrit-wm1> (03CR) 10Krinkle: "Yeah, it's from es5-sham, which not part of the es5-shim executable, but is part of the larger es5-shim library: https://github.com/es-shi" [core] - 10https://gerrit.wikimedia.org/r/156046 (https://bugzilla.wikimedia.org/67590) (owner: 10Krinkle) [17:02:03] <^d> Not policy. I personally don't mind super-tiny attachments. [17:02:06] <^d> Like log files. [17:02:10] <^d> Other txt things [17:02:35] <awjr> the limit feels… arbitrary [17:02:43] <grrrit-wm1> (03PS1) 10Legoktm: Move call to onUserGetRights [extensions/MassMessage] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156318 (https://bugzilla.wikimedia.org/69381) [17:02:54] <^d> awjr: Probably is! From before my tenure as list admin :) [17:03:01] <awjr> ;) [17:03:04] <grrrit-wm1> (03PS1) 10Legoktm: Move call to onUserGetRights [extensions/MassMessage] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/156319 (https://bugzilla.wikimedia.org/69381) [17:06:24] <wikibugs> 3MediaWiki extensions / 3MassMessage: UserGetRights hook causes MassMessage::getMessengerUser() to be called on every pageview - 10https://bugzilla.wikimedia.org/69381 (10Kunal Mehta (Legoktm)) [17:06:24] <wikibugs> 3MediaWiki / 3Database: User::loadPasswords 400% spike on wmf db masters - 10https://bugzilla.wikimedia.org/70038#c10 (10Kunal Mehta (Legoktm)) 5NEW>3ASSI The fix for bug 69381 will go out in today afternoon's SWAT window. [17:11:53] <grrrit-wm1> (03CR) 10Manybubbles: [C: 04-1] Send groovy script for updates to limit changes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/155339 (owner: 10Manybubbles) [17:12:35] <grrrit-wm1> (03PS9) 10Ebe123: Add link to Special:PrefixIndex to Delete dialog [core] - 10https://gerrit.wikimedia.org/r/151061 (https://bugzilla.wikimedia.org/30666) [17:17:10] <grrrit-wm1> (03CR) 10saper: "This causes bug 70030: we return Status instance instead of DatabasePostgres and we fail later down the way..." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/142472 (https://bugzilla.wikimedia.org/64043) (owner: 10Skizzerz) [17:19:19] <grrrit-wm1> (03CR) 10MSyed: [C: 032 V: 032] Use protocol relative URLs for links with https [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/154031 (owner: 10Prtksxna) [17:21:31] <grrrit-wm1> (03PS9) 10MarkTraceur: Add some flow events for funnel logging [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/144588 (owner: 10Gergő Tisza) [17:21:34] <grrrit-wm1> (03PS11) 10Jdlrobson: i18n: Allow translation of participants and comment_count [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155827 [17:22:06] <grrrit-wm1> (03CR) 10MarkTraceur: "Inline comments responded to; patch incoming." (034 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/144588 (owner: 10Gergő Tisza) [17:22:36] <grrrit-wm1> (03CR) 10Jdlrobson: [C: 031] "WFM and has tests" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156237 (https://bugzilla.wikimedia.org/69993) (owner: 10Santhosh) [17:22:56] <grrrit-wm1> (03PS12) 10Jdlrobson: i18n: Allow translation of participants and comment_count [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155827 [17:23:12] <grrrit-wm1> (03CR) 10Helder.wiki: "After renaming the module to "mediawiki.toolbar", should the file stay where it is? (inside of "mediawiki.action", and having "mediawiki.*" [core] - 10https://gerrit.wikimedia.org/r/156229 (owner: 10Helder.wiki) [17:25:09] <wikibugs> 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c11 (10Krinkle) This is not a new problem. Users using older browsers have always had fatal errors because jquery/mediawiki are not loaded in blacklisted browsers not... [17:25:41] <wikibugs> 3MediaWiki extensions / 3Scribunto: Fatal exception of type Scribunto_LuaInterpreterNotFoundError - 10https://bugzilla.wikimedia.org/70051 (10Ori Livneh) 3NEW p:3Unprio s:3normal a:3None To reproduce, visit https://www.mediawiki.org/wiki/Extension:CentralNotice with HHVM enabled. 2014-08-26 16:06:... [17:29:54] <wikibugs> 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c12 (10Krinkle) > > function bar() { return 1; } > > bar(); > >> 1 > > > if (true) { > > function bar() { return 1; } > > } else { > > function bar() { return 2;... [17:30:05] <Krinkle> >> quux(); if (true) { function quux() { return 1; } } else { function quux() { return 2; } } [17:30:05] <ecmabot-wm> Krinkle: (number) 2 [17:30:24] <wikibugs> 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c13 (10Krinkle) > quux(); if (true) { function quux() { return 1; } } else { function quux() { return 2; } } V8> 2 SpiderMonkey> quux is undefined [17:37:09] <Krenair> Were JS pages sent through the wikitext parser at some point? [17:37:27] <legoktm> they still go through PST [17:39:17] <bawolff> long ago they were [17:39:24] <wikibugs> 3MediaWiki / 3Parser: ­ is filtered out? - 10https://bugzilla.wikimedia.org/70014#c3 (10Bawolff (Brian Wolff)) Weird. Special:Expandtemplates does not strip them, but they don't appear in final output. Special:Expandtemplates does tidy now, so I'm not sure what other step the main output would go through... [17:39:33] <bawolff> We used to do things like /* ==foo== */ to divide it into sections [17:40:11] <bawolff> Around the time the <source> extension was introduced, people stopped outputting that. But they still went through parser and had categorylinks extracted etc. I think that stopped after content handler [17:41:36] <Krenair> yeah, I thought it had something to do with the introduction of contenthandler [17:42:27] <Krenair> https://meta.wikimedia.org/w/index.php?title=User:Krenair/global.js&diff=3808567&oldid=3807308 :/ [17:44:32] <legoktm> but CH was fixed to still add link tables [17:44:36] <MatmaRex> bawolff: Krenair: *links are still done [17:45:29] <MatmaRex> bawolff: Krenair: if they aren't, that's a bug. i caused and then fixed a regression in this myself recently [17:45:48] <grrrit-wm1> (03CR) 10Ori.livneh: Add HTMLAutoCompleteSelectField (031 comment) [core] - 10https://gerrit.wikimedia.org/r/142668 (owner: 10Anomie) [17:45:49] <legoktm> Krenair: also you know that's going to break with GlobalCssJs since your variables aren't attached to window ? [17:46:24] <Krenair> Oh, it's no longer in the global scope, is it [17:46:30] <MatmaRex> legoktm: actually they are. it's still going to break [17:46:43] <MatmaRex> there's no 'var' anywhere, so the variable is global [17:46:44] <MatmaRex> but [17:46:54] <MatmaRex> until it's defined, trying to use it will throw an error [17:47:00] <MatmaRex> e.g. in `if ( taggerConfig === undefined )` [17:47:11] <grrrit-wm1> (03CR) 10Renoirb: [C: 04-1] "Let’s drop that changeset." [vagrant] - 10https://gerrit.wikimedia.org/r/151266 (owner: 10Renoirb) [17:47:11] <MatmaRex> it just needs the typeof back, i think [17:47:47] <MatmaRex> Krenair: the pages are definitely parsed and the links tables are done. https://meta.wikimedia.org/w/index.php?title=Special%3AWhatLinksHere&hidelinks=1&target=Template%3ADelete&namespace=2 [17:47:59] <legoktm> :o JavaScript is confusing :< [17:48:38] <MatmaRex> it's terrible [17:48:52] <MatmaRex> still better than PHP and its isset() stupidity… [17:52:31] <grrrit-wm1> (03CR) 10AndyRussG: [C: 032] "Nice, thanks!" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/142212 (owner: 10Prtksxna) [17:52:57] <grrrit-wm1> (03Merged) 10jenkins-bot: Force mw.popups.supportsSVG to false on InternetExplorer [extensions/Popups] - 10https://gerrit.wikimedia.org/r/142212 (owner: 10Prtksxna) [17:53:29] <legoktm> how do I make phabricator stop emailing me my own comments? [17:54:06] <MatmaRex> legoktm: disable "Self Actions" in prefs [17:54:10] <MatmaRex> http://fab.wmflabs.org/settings/panel/emailpreferences/ [17:54:14] <grrrit-wm1> (03CR) 10Matthias Mullie: i18n: properly translate list of topic participants (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156096 (owner: 10Matthias Mullie) [17:54:36] <legoktm> ah, thanks [17:54:41] * legoktm fiddles [17:55:48] <grrrit-wm1> (03PS2) 10Jforrester: WIP Add missing qqq messages, remove unused messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155850 (owner: 10MarkTraceur) [17:55:51] <grrrit-wm1> (03PS3) 10Jforrester: Set up an npm test pipeline for JS, CSS and banana i18n messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 [17:56:12] <grrrit-wm1> (03CR) 10Jforrester: "PS2 is a rebase." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155850 (owner: 10MarkTraceur) [17:56:32] <grrrit-wm1> (03CR) 10Jforrester: "PS3 is a rebase. Happy to sling other patches below this in the stack, of course." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester) [17:56:41] <wikibugs> 3Wikimedia / 3Deployment systems: [scap] Syncing wmf-config/PrivateSettings.php syncs symlink and not file contents - 10https://bugzilla.wikimedia.org/70054 (10Bryan Davis) 3NEW p:3Unprio s:3normal a:3None Chad tripped over this today in prod. He made a change to /a/common/wmf-config/PrivateSettings.... [17:57:10] <^d> Was someone running an mwgrep or otherwise really complex query against ES? [18:04:27] <yuvipanda> marktraceurWMF: I see http://quarry.wmflabs.org/query/343 [18:04:34] <yuvipanda> marktraceurWMF: and yeah, that data isn't public [18:04:50] <yuvipanda> marktraceurWMF: I've been getting people to do a 'email in' campaign to toby to get a quarry instance running in prod [18:05:21] <marktraceurWMF> Yeah [18:05:40] <marktraceurWMF> yuvipanda: We have *some* preference data available through the API [18:05:57] <marktraceurWMF> list=betafeatures&counts= IIRC [18:05:57] <yuvipanda> marktraceurWMF: yeah, and some of those should be available here as well [18:06:01] <marktraceurWMF> https://en.wikipedia.org/w/api.php?action=query&list=betafeatures&bfcounts= [18:06:02] <yuvipanda> marktraceurWMF: right [18:06:46] <grrrit-wm1> (03CR) 10Legoktm: "As this a write action, shouldn't it require a token?" [core] - 10https://gerrit.wikimedia.org/r/156274 (owner: 10Petrb) [18:07:09] <wikibugs> 3MediaWiki extensions / 3MirrorTools: Add mirrormove module to MirrorTools - 10https://bugzilla.wikimedia.org/68311 (10Nathan Larson) 5NEW>3RESO/FIX [18:08:56] <grrrit-wm1> (03Abandoned) 10MaxSem: Adding WebPlatformDocs role [vagrant] - 10https://gerrit.wikimedia.org/r/151266 (owner: 10Renoirb) [18:09:29] <grrrit-wm1> (03CR) 10Bartosz Dziewoński: "You should just use $this->getOutput() instead of $out. This method never takes such parameter." [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/156180 (owner: 10Jack Phoenix) [18:10:18] <grrrit-wm1> (03CR) 10Anomie: Add HTMLAutoCompleteSelectField (031 comment) [core] - 10https://gerrit.wikimedia.org/r/142668 (owner: 10Anomie) [18:11:09] <wikibugs> 3MediaWiki / 3User preferences: Allow bigger thumbnail sizes in personal settings - 10https://bugzilla.wikimedia.org/69973#c2 (10Bawolff (Brian Wolff)) Note that previously ops had some concerns about sudden load increase on the image scalers if the default thumb size changed (Not sure if that's still a conc... [18:11:10] <grrrit-wm1> (03CR) 10Bartosz Dziewoński: "This change caused a fatal in at least one skin (BlueSky). Please check the skins in mediawiki/skins repository before doing backwards-inc" [core] - 10https://gerrit.wikimedia.org/r/153636 (owner: 10IAlex) [18:12:11] <grrrit-wm1> (03CR) 10Bartosz Dziewoński: "(Fatal caused by https://gerrit.wikimedia.org/r/#/c/153636/1)" [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/156180 (owner: 10Jack Phoenix) [18:13:54] <wikibugs> 3MediaWiki / 3User preferences: Allow bigger thumbnail sizes in personal settings - 10https://bugzilla.wikimedia.org/69973#c3 (10James Forrester) (In reply to Bawolff (Brian Wolff) from comment #2) > Note that previously ops had some concerns about sudden load increase on the > image scalers if the default t... [18:16:54] <grrrit-wm1> (03CR) 10MaxSem: "I don't think every possible refactoring should be mentioned in release notes. Also, third party skins get broken/outdated with every MW r" [core] - 10https://gerrit.wikimedia.org/r/153636 (owner: 10IAlex) [18:18:02] <grrrit-wm1> (03PS1) 10Frédéric Wang: Indicate that a PNG fallback can also be used for the MathML mode [extensions/Math] - 10https://gerrit.wikimedia.org/r/156329 [18:18:09] <grrrit-wm1> (03PS2) 10MarkTraceur: Add start/end and whileActive to the campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153818 (https://bugzilla.wikimedia.org/64685) [18:18:31] <grrrit-wm1> (03CR) 10MarkTraceur: Add start/end and whileActive to the campaigns (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153818 (https://bugzilla.wikimedia.org/64685) (owner: 10MarkTraceur) [18:18:46] <wikibugs> 3MediaWiki extensions / 3MirrorTools: LocalWiki users should not be allowed to make changes to remotely live pages, other than deleting revisions - 10https://bugzilla.wikimedia.org/70055 (10Nathan Larson) 3NEW p:3Unprio s:3normal a:3None The edit, move, protect, etc. tabs should not be available on r... [18:18:54] <wikibugs> 3Wikimedia / 3Deployment systems: [scap] Syncing wmf-config/PrivateSettings.php syncs symlink and not file contents - 10https://bugzilla.wikimedia.org/70054#c1 (10Nik Everett) I like warning you here - sometimes you want to sync out a symlink? Probably. [18:19:44] <grrrit-wm1> (03CR) 10Legoktm: "Things that have the possibility to break things should be mentioned in release notes. And yes, I think the point is we want to stop break" [core] - 10https://gerrit.wikimedia.org/r/153636 (owner: 10IAlex) [18:20:02] <grrrit-wm1> (03CR) 10Bartosz Dziewoński: "Well it's about fucking time they stop being broken all the time, now that they are sanely tracked in our repositories and are finally eas" [core] - 10https://gerrit.wikimedia.org/r/153636 (owner: 10IAlex) [18:21:09] <wikibugs> 3MediaWiki / 3Database: Implement all features required for creating Inclupedia (tracking) - 10https://bugzilla.wikimedia.org/60084 (10Nathan Larson) [18:21:10] <wikibugs> 3MediaWiki extensions / 3MirrorTools: LocalWiki users should not be allowed to make changes to remotely live pages, other than deleting revisions - 10https://bugzilla.wikimedia.org/70055 (10Nathan Larson) a:3Nathan Larson [18:22:15] <grrrit-wm1> (03PS16) 10BryanDavis: Use MWLogger logging for legacy logging methods [core] - 10https://gerrit.wikimedia.org/r/119941 [18:22:17] <grrrit-wm1> (03PS14) 10BryanDavis: Add a PSR-3 based logging interface [core] - 10https://gerrit.wikimedia.org/r/119940 [18:22:21] <grrrit-wm1> (03PS10) 10BryanDavis: Use MWLogger logging for wfLogProfilingData [core] - 10https://gerrit.wikimedia.org/r/119942 [18:22:21] <grrrit-wm1> (03PS5) 10BryanDavis: Add logging context to database logs [core] - 10https://gerrit.wikimedia.org/r/141599 [18:22:24] <wikibugs> 3MediaWiki extensions / 3MirrorTools: LocalWiki users should not be allowed to make changes to remotely live pages, other than deleting revisions - 10https://bugzilla.wikimedia.org/70055 (10Nathan Larson) p:5Unprio>3Normal [18:23:08] <grrrit-wm1> (03CR) 10Bsitu: "This seems to specify the user field to update when merging a user. I assume the mergeUser code would handle null user_id case and the up" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156233 (https://bugzilla.wikimedia.org/67766) (owner: 10Legoktm) [18:23:43] <grrrit-wm1> (03CR) 10Chad: [C: 032] Highlight in chains [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/150207 (owner: 10Manybubbles) [18:24:14] <grrrit-wm1> (03Merged) 10jenkins-bot: Highlight in chains [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/150207 (owner: 10Manybubbles) [18:24:42] <grrrit-wm1> (03PS3) 10MarkTraceur: Add beforeActive and afterActive to campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155351 (https://bugzilla.wikimedia.org/64685) [18:25:39] <grrrit-wm1> (03CR) 10Raimond Spekking: [C: 031] "i18n review" [extensions/Math] - 10https://gerrit.wikimedia.org/r/156329 (owner: 10Frédéric Wang) [18:25:56] <grrrit-wm1> (03CR) 10Raimond Spekking: [C: 032] Indicate that a PNG fallback can also be used for the MathML mode [extensions/Math] - 10https://gerrit.wikimedia.org/r/156329 (owner: 10Frédéric Wang) [18:26:58] <grrrit-wm1> (03Merged) 10jenkins-bot: Indicate that a PNG fallback can also be used for the MathML mode [extensions/Math] - 10https://gerrit.wikimedia.org/r/156329 (owner: 10Frédéric Wang) [18:28:48] <grrrit-wm1> (03CR) 10Petrb: "I don't think it needs to have any token, however, I don't even know if it really needs to be "write" it does write to database, but doesn" [core] - 10https://gerrit.wikimedia.org/r/156274 (owner: 10Petrb) [18:32:24] <wikibugs> 3MediaWiki extensions / 3LiquidThreads: PHP Notice: Undefined offset: 1198 in ThreadPermalinkView.php on line 125 - 10https://bugzilla.wikimedia.org/70040 (10Andre Klapper) p:5Unprio>3Low [18:34:09] <wikibugs> 3MediaWiki / 3Database: Postgre: undefined method Status::clearFlag() - 10https://bugzilla.wikimedia.org/70030#c5 (10Andre Klapper) (In reply to Peter Bena from comment #3) > and now it even changed the priority for no reason o.O bugzilla has bugs! No, it's likely your browser caching things. [18:36:27] <grrrit-wm1> (03CR) 10Legoktm: "Minor things mainly." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/153110 (owner: 10Anomie) [18:38:08] <grrrit-wm1> (03CR) 10Reedy: [C: 032 V: 031] Move call to onUserGetRights [extensions/MassMessage] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156318 (https://bugzilla.wikimedia.org/69381) (owner: 10Legoktm) [18:38:35] <grrrit-wm1> (03CR) 10Reedy: [C: 032 V: 031] Move call to onUserGetRights [extensions/MassMessage] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/156319 (https://bugzilla.wikimedia.org/69381) (owner: 10Legoktm) [18:38:50] <grrrit-wm1> (03PS6) 10Manybubbles: Send groovy script for updates to limit changes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/155339 [18:41:22] <grrrit-wm1> (03PS1) 10Anomie: Allow for time-limited tokens [core] - 10https://gerrit.wikimedia.org/r/156336 [18:41:24] <grrrit-wm1> (03PS1) 10Anomie: Use User::matchEditToken to compare tokens [extensions/CommunityVoice] - 10https://gerrit.wikimedia.org/r/156337 [18:41:26] <grrrit-wm1> (03PS1) 10Anomie: Use User::matchEditToken to compare tokens [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/156338 [18:41:36] <Withoutaname> TimStarling: can I get the problematic archive table rows from https://bugzilla.wikimedia.org/show_bug.cgi?id=22624 because I'm not really understanding how the corruption occurred [18:41:56] <grrrit-wm1> (03CR) 10Anomie: [C: 04-2] "The following changes should be merged first: I4736dc028a4acf51c0c1196c5fa5a7f5bc98ff62 I3c1de7ae577b48fd7c10968cd14b52aedf307d35" [core] - 10https://gerrit.wikimedia.org/r/156336 (owner: 10Anomie) [18:42:53] <TimStarling> I'm not sure there is any list [18:44:34] <grrrit-wm1> (03PS7) 10Petrb: API: created a new api to flag messages as read [core] - 10https://gerrit.wikimedia.org/r/156274 [18:45:19] <grrrit-wm1> (03PS1) 10Reedy: Update MassMessage to 1.24wmf17 HEAD [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/156340 [18:45:43] <grrrit-wm1> (03PS8) 10Petrb: API: created a new api to flag messages as read [core] - 10https://gerrit.wikimedia.org/r/156274 [18:46:19] <grrrit-wm1> (03PS1) 10Reedy: Update MassMessage to 1.24wmf18 HEAD [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156341 [18:47:10] <Withoutaname> so there's currently no way to detect which hashes are corrupted? [18:47:27] <grrrit-wm1> (03CR) 10Reedy: [C: 032 V: 031] Update MassMessage to 1.24wmf17 HEAD [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/156340 (owner: 10Reedy) [18:48:06] <grrrit-wm1> (03CR) 10jenkins-bot: [V: 04-1] Allow for time-limited tokens [core] - 10https://gerrit.wikimedia.org/r/156336 (owner: 10Anomie) [18:48:08] <grrrit-wm1> (03CR) 10Reedy: [C: 032 V: 031] Update MassMessage to 1.24wmf18 HEAD [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156341 (owner: 10Reedy) [18:48:22] <Reedy> Withoutaname: How would you detect? [18:48:34] <Reedy> You'd presumably have to write a script to recompute them and write out a list of mismatches [18:49:19] <grrrit-wm1> (03PS3) 10Bsitu: Redirect to Flow view action when url action is set to edit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156183 (https://bugzilla.wikimedia.org/69879) [18:51:01] <grrrit-wm1> (03Merged) 10jenkins-bot: Update MassMessage to 1.24wmf17 HEAD [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/156340 (owner: 10Reedy) [18:51:39] <wikibugs> 3MediaWiki / 3User preferences: Timezone of Windows/XAMPP server not set as default for users - 10https://bugzilla.wikimedia.org/70032#c1 (10Andre Klapper) p:5Unprio>3Low Thanks for taking the time to report this! Which Windows version is this about, and which PHP version? Is the output of date('Z')... [18:51:56] <wikibugs> 3MediaWiki extensions / 3Scribunto: Fatal exception of type Scribunto_LuaInterpreterNotFoundError - 10https://bugzilla.wikimedia.org/70051 (10Andre Klapper) p:5Unprio>3High [18:52:14] <grrrit-wm1> (03Merged) 10jenkins-bot: Update MassMessage to 1.24wmf18 HEAD [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156341 (owner: 10Reedy) [18:52:50] <grrrit-wm1> (03PS1) 10Aaron Schulz: Made getCachedRevisionObject() use MapCacheLRU [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156342 [18:53:25] <Withoutaname> Reedy: I suppose, but atm I'm just trying to find a way to "compile a list of content hashes in affected CGZ blobs, and to match them up with broken pointers" [18:54:00] <Withoutaname> the recomputation might take awhile [18:54:08] <grrrit-wm1> (03PS6) 10Anomie: API: Overhaul token handling [core] - 10https://gerrit.wikimedia.org/r/153110 [18:54:18] <grrrit-wm1> (03PS1) 10Aude: Update Wikidata, add css for badges [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156343 [18:54:32] <grrrit-wm1> (03CR) 10Anomie: [C: 04-1] "One isn't minor." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/153110 (owner: 10Anomie) [18:58:48] <grrrit-wm1> (03CR) 10Legoktm: API: Overhaul token handling (031 comment) [core] - 10https://gerrit.wikimedia.org/r/153110 (owner: 10Anomie) [18:58:57] <grrrit-wm1> (03PS3) 10Umherirrender: Add missing @return and @param to doc blocks [core] - 10https://gerrit.wikimedia.org/r/156142 [18:59:38] <grrrit-wm1> (03CR) 10Umherirrender: "Patch Set 3: Addressed inline comments" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/156142 (owner: 10Umherirrender) [18:59:40] <grrrit-wm1> (03PS1) 10Reedy: Fix Call to protected method EchoNotificationController::isWhitelistedByUser() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156344 [18:59:44] <grrrit-wm1> (03CR) 10Bartosz Dziewoński: [C: 032] Support nesting of expressions in parameters of explicit plural forms [core] - 10https://gerrit.wikimedia.org/r/156237 (https://bugzilla.wikimedia.org/69993) (owner: 10Santhosh) [19:00:37] <wikibugs> 3MediaWiki / 3Internationalization: Using variables inside plural definitions doesn't work in JavaScript - 10https://bugzilla.wikimedia.org/69993 (10Bartosz Dziewoński) 5PATC>3RESO/FIX a:3Santhosh Thottingal [19:00:52] <grrrit-wm1> (03CR) 10Legoktm: [C: 032] Fix Call to protected method EchoNotificationController::isWhitelistedByUser() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156344 (owner: 10Reedy) [19:01:18] <grrrit-wm1> (03Merged) 10jenkins-bot: Fix Call to protected method EchoNotificationController::isWhitelistedByUser() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156344 (owner: 10Reedy) [19:01:23] <Reedy> legoktm: Can you cherry pick that into 1.24wmf18 for me please? [19:01:29] <legoktm> sure [19:01:36] <grrrit-wm1> (03PS1) 10Legoktm: Fix Call to protected method EchoNotificationController::isWhitelistedByUser() [extensions/Echo] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156345 [19:01:50] <legoktm> Reedy: if you +2 ^ I can do the submodule update [19:02:01] <grrrit-wm1> (03CR) 10Gilles: [C: 032] Add start/end and whileActive to the campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153818 (https://bugzilla.wikimedia.org/64685) (owner: 10MarkTraceur) [19:02:03] <Reedy> I've got a script to do the submodule updates ;) [19:02:06] <grrrit-wm1> (03CR) 10Gilles: [C: 032] Add beforeActive and afterActive to campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155351 (https://bugzilla.wikimedia.org/64685) (owner: 10MarkTraceur) [19:02:07] <legoktm> oh :D [19:02:09] <grrrit-wm1> (03PS2) 10Anomie: Allow for time-limited tokens [core] - 10https://gerrit.wikimedia.org/r/156336 [19:02:14] <Reedy> I just can't use the gerrit web interface atm [19:02:21] <grrrit-wm1> (03CR) 10Legoktm: [C: 032] API: Overhaul token handling [core] - 10https://gerrit.wikimedia.org/r/153110 (owner: 10Anomie) [19:02:29] <grrrit-wm1> (03Merged) 10jenkins-bot: Add start/end and whileActive to the campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153818 (https://bugzilla.wikimedia.org/64685) (owner: 10MarkTraceur) [19:02:33] <legoktm> well, I can't +2 in wmf branches [19:02:33] <grrrit-wm1> (03Merged) 10jenkins-bot: Add beforeActive and afterActive to campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155351 (https://bugzilla.wikimedia.org/64685) (owner: 10MarkTraceur) [19:02:53] <grrrit-wm1> (03CR) 10Reedy: [C: 032 V: 031] Fix Call to protected method EchoNotificationController::isWhitelistedByUser() [extensions/Echo] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156345 (owner: 10Legoktm) [19:03:46] <grrrit-wm1> (03CR) 10Ori.livneh: Add HTMLAutoCompleteSelectField (032 comments) [core] - 10https://gerrit.wikimedia.org/r/142668 (owner: 10Anomie) [19:04:08] <grrrit-wm1> (03PS1) 10Reedy: Update Echo to 1.24wmf18 HEAD [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156347 [19:04:49] <grrrit-wm1> (03CR) 10Reedy: [C: 032 V: 031] Update Echo to 1.24wmf18 HEAD [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156347 (owner: 10Reedy) [19:05:09] <grrrit-wm1> (03CR) 10Anomie: "No point to a token here, since the same effect can be had by GETting index.php?title=Special:MyTalk and following the redirect." [core] - 10https://gerrit.wikimedia.org/r/156274 (owner: 10Petrb) [19:06:25] <grrrit-wm1> (03Merged) 10jenkins-bot: Support nesting of expressions in parameters of explicit plural forms [core] - 10https://gerrit.wikimedia.org/r/156237 (https://bugzilla.wikimedia.org/69993) (owner: 10Santhosh) [19:06:41] <wikibugs> 3MediaWiki extensions / 3SemanticForms: wikiEditor not loading in a Semantic Form - 10https://bugzilla.wikimedia.org/70057 (10ryan.glasnapp) 3UNCO p:3Unprio s:3normal a:3Yaron Koren I get this error popup when trying to use wikiEditor. MW: 1.23.1 SMW: 2.0 SF: latest master (020e20e) ext.semanticfo... [19:09:02] <grrrit-wm1> (03CR) 10Petrb: "So the current name is not correct you mean?" [core] - 10https://gerrit.wikimedia.org/r/156274 (owner: 10Petrb) [19:09:23] <grrrit-wm1> (03Merged) 10jenkins-bot: API: Overhaul token handling [core] - 10https://gerrit.wikimedia.org/r/153110 (owner: 10Anomie) [19:09:26] <grrrit-wm1> (03Merged) 10jenkins-bot: Update Echo to 1.24wmf18 HEAD [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156347 (owner: 10Reedy) [19:13:40] <grrrit-wm1> (03PS5) 10Anomie: Add HTMLAutoCompleteSelectField [core] - 10https://gerrit.wikimedia.org/r/142668 [19:14:11] <grrrit-wm1> (03CR) 10jenkins-bot: [V: 04-1] Add HTMLAutoCompleteSelectField [core] - 10https://gerrit.wikimedia.org/r/142668 (owner: 10Anomie) [19:14:45] <grrrit-wm1> (03PS6) 10Anomie: Add HTMLAutoCompleteSelectField [core] - 10https://gerrit.wikimedia.org/r/142668 [19:15:19] <grrrit-wm1> (03PS9) 10Petrb: API: created a new api to flag messages as read [core] - 10https://gerrit.wikimedia.org/r/156274 [19:17:39] <grrrit-wm1> (03PS10) 10Petrb: API: created a new api to flag messages as read [core] - 10https://gerrit.wikimedia.org/r/156274 [19:18:55] <wikibugs> 3MediaWiki / 3Parser: Preprocessor_DOM causes fatal errors when called in certain ways - 10https://bugzilla.wikimedia.org/70046 (10Jackmcbarn) 5PATC>3RESO/FIX p:5Unprio>3Normal a:3Brad Jorsch [19:19:00] <grrrit-wm1> (03PS1) 10saper: Schema is not PostgreSQL connection parameter [core] - 10https://gerrit.wikimedia.org/r/156349 (https://bugzilla.wikimedia.org/70030) [19:19:41] <wikibugs> 3MediaWiki / 3User login and signup: Ajax check for username availability is not aware of global accounts that are not attached to the local wiki - 10https://bugzilla.wikimedia.org/70058 (10Bryan Davis) 3NEW p:3Unprio s:3enhanc a:3None The check in resources/src/mediawiki.special/mediawiki.special.us... [19:22:54] <wikibugs> 3Wikimedia / 3General/Unknown: Fatal exception of type Scribunto_LuaInterpreterNotFoundError - 10https://bugzilla.wikimedia.org/70051#c1 (10Brad Jorsch) This isn't a bug in Scribunto. Why is the LuaSandbox extension not being found by "extension_loaded( 'luasandbox' )" when things are using HHVM? [19:23:09] <wikibugs> 3MediaWiki / 3Database: PostgreSQL: undefined method Status::clearFlag() - 10https://bugzilla.wikimedia.org/70030 (10Marcin Cieślak) [19:23:24] <wikibugs> 3MediaWiki / 3Database: PostgreSQL: undefined method Status::clearFlag() - 10https://bugzilla.wikimedia.org/70030 (10Marcin Cieślak) p:5Low>3High [19:23:44] <grrrit-wm1> (03CR) 10Petrb: [C: 031] Schema is not PostgreSQL connection parameter [core] - 10https://gerrit.wikimedia.org/r/156349 (https://bugzilla.wikimedia.org/70030) (owner: 10saper) [19:28:42] <grrrit-wm1> (03CR) 10Aude: [C: 032] Update Wikidata, add css for badges [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156343 (owner: 10Aude) [19:30:09] <wikibugs> 3MediaWiki / 3User login and signup: Ajax check for username availability is not aware of global accounts that are not attached to the local wiki - 10https://bugzilla.wikimedia.org/70058#c1 (10Bartosz Dziewoński) Known issue, the functionality was added in 74b222230 with the comment: > The way this is done... [19:30:24] <wikibugs> 3MediaWiki / 3User login and signup: Client-side validation of the username availability, password and email - 10https://bugzilla.wikimedia.org/17544 (10Bartosz Dziewoński) [19:30:25] <wikibugs> 3MediaWiki extensions / 3CentralAuth: "Username in use by unified login system" warning not appearing until after the signup form is submitted - 10https://bugzilla.wikimedia.org/64728 (10Bartosz Dziewoński) [19:30:27] <wikibugs> 3MediaWiki / 3User login and signup: Client-side validation of the username availability, password and email - 10https://bugzilla.wikimedia.org/17544 (10Bartosz Dziewoński) [19:30:39] <wikibugs> 3MediaWiki / 3Skin and page rendering: Mediawiki UI shouldn't change font-family for textareas - 10https://bugzilla.wikimedia.org/70028#c2 (10Jon) I'm agnostic about which font to use in textareas / inputs or whether mw-ui-input should be applied solely to input elements and not text areas. This is how we a... [19:30:39] <wikibugs> 3MediaWiki / 3User login and signup: Give warning on account creation when user name is adjusted silently - 10https://bugzilla.wikimedia.org/61416 (10Bartosz Dziewoński) 5PATC>3NEW [19:30:54] <wikibugs> 3MediaWiki / 3User login and signup: Client-side validation of the username availability, password and email - 10https://bugzilla.wikimedia.org/17544 (10Bartosz Dziewoński) [19:30:54] <wikibugs> 3MediaWiki extensions / 3CentralAuth: "Username in use by unified login system" warning not appearing until after the signup form is submitted - 10https://bugzilla.wikimedia.org/64728 (10Bartosz Dziewoński) [19:30:54] <wikibugs> 3MediaWiki extensions / 3CentralAuth: "Username in use by unified login system" warning not appearing until after the signup form is submitted - 10https://bugzilla.wikimedia.org/64728 (10Bartosz Dziewoński) [19:31:11] <wikibugs> 3MediaWiki / 3API: ApiTokens should be a query module - 10https://bugzilla.wikimedia.org/36078#c10 (10Brad Jorsch) 5NEW>3RESO/FIX a:3Brad Jorsch Gerrit change 153110 [19:31:23] <grrrit-wm1> (03PS1) 10Jjanes: PostgreSQL: Fix Installer [core] - 10https://gerrit.wikimedia.org/r/156350 (https://bugzilla.wikimedia.org/70030) [19:31:39] <wikibugs> 3MediaWiki extensions / 3CentralAuth: "Username in use by unified login system" warning not appearing until after the signup form is submitted - 10https://bugzilla.wikimedia.org/64728 (10Bartosz Dziewoński) [19:31:47] <wikibugs> 3MediaWiki / 3API: API token handling needs to be less special-cased and hard-coded - 10https://bugzilla.wikimedia.org/45199#c4 (10Brad Jorsch) 5NEW>3RESO/FIX a:3Brad Jorsch Gerrit change 153110 [19:31:54] <wikibugs> 3MediaWiki / 3User login and signup: Ajax check for username availability is not aware of global accounts that are not attached to the local wiki - 10https://bugzilla.wikimedia.org/70058#c2 (10Bartosz Dziewoński) (Hmm, this might be a duplicate/dependency of bug 64728. Definitely related.) [19:31:58] <grrrit-wm1> (03Merged) 10jenkins-bot: Update Wikidata, add css for badges [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156343 (owner: 10Aude) [19:32:41] <wikibugs> 3MediaWiki / 3JavaScript: Update mediawiki.api for new API token handling - 10https://bugzilla.wikimedia.org/70059 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None See I2793a3f2dd64a4bebb0b4d065e09af1e9f63fb89. Current method (action=tokens) will still work, but emits deprecation notices. [19:33:42] <grrrit-wm1> (03PS1) 10Ori.livneh: Add a few PHPUnit tests for HTMLAutoCompleteSelectField [core] - 10https://gerrit.wikimedia.org/r/156353 [19:33:55] <grrrit-wm1> (03PS11) 10Petrb: API: created a new api to flag messages as read [core] - 10https://gerrit.wikimedia.org/r/156274 [19:34:36] <grrrit-wm1> (03CR) 10Ori.livneh: [C: 032] Add HTMLAutoCompleteSelectField [core] - 10https://gerrit.wikimedia.org/r/142668 (owner: 10Anomie) [19:37:22] <grrrit-wm1> (03CR) 10CSteipp: Allow for time-limited tokens (032 comments) [core] - 10https://gerrit.wikimedia.org/r/156336 (owner: 10Anomie) [19:38:52] <grrrit-wm1> (03PS2) 10EBernhardson: PhantomJS doesn't support Function.prototype.bind [core] - 10https://gerrit.wikimedia.org/r/156215 [19:39:24] <wikibugs> 3MediaWiki / 3API: Requesting tokens when not authenticated - 10https://bugzilla.wikimedia.org/38715#c2 (10Kunal Mehta (Legoktm)) 5NEW>3RESO/WON What Addshore said. { "warnings": { "tokens": { "*": "Action 'delete' is not allowed for the current user" } }, "tokens... [19:41:06] <grrrit-wm1> (03Merged) 10jenkins-bot: Add HTMLAutoCompleteSelectField [core] - 10https://gerrit.wikimedia.org/r/142668 (owner: 10Anomie) [19:41:39] <wikibugs> 3MediaWiki / 3API: token api should allow type parameters for any action name which requires a token - 10https://bugzilla.wikimedia.org/38717#c5 (10Kunal Mehta (Legoktm)) 5NEW>3RESO/WOR Marking as WORKSFORME because with the new API token handling you just use one token for nearly everything. [19:42:09] <wikibugs> 3MediaWiki extensions / 3SemanticForms: wikiEditor not loading in a Semantic Form - 10https://bugzilla.wikimedia.org/70057#c1 (10Yaron Koren) If you get rid of or comment out those lines, does it work for you? [19:42:14] <grrrit-wm1> (03PS3) 10Martineznovo: Add release notes for JobQueue changes in 1.22. [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/132190 (https://bugzilla.wikimedia.org/60719) (owner: 10MarkAHershberger) [19:43:11] <wikibugs> 3MediaWiki / 3API: MediaWiki API 2.0 (tracking) - 10https://bugzilla.wikimedia.org/38891 (10Kunal Mehta (Legoktm)) a:5Yuri Astrakhan>3None [19:43:19] <grrrit-wm1> (03CR) 10Martineznovo: "I've manually rebased this change. Let's merge it before REL1_22 gets unmaintained :)" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/132190 (https://bugzilla.wikimedia.org/60719) (owner: 10MarkAHershberger) [19:43:24] <wikibugs> 3MediaWiki / 3API: API token handling needs to be less special-cased and hard-coded - 10https://bugzilla.wikimedia.org/45199 (10Kunal Mehta (Legoktm)) [19:44:39] <wikibugs> 3MediaWiki / 3API: token api should allow type parameters for any action name which requires a token - 10https://bugzilla.wikimedia.org/38717#c6 (10Jon) Legoktm can you point me at a patch/wikipage for new API handling? I can't seem to request a userrights, rollback or various other tokens that I listed in #... [19:45:48] <grrrit-wm1> (03PS3) 10Bartosz Dziewoński: mediawiki.page.image.pagination: Cache last-loaded pages [core] - 10https://gerrit.wikimedia.org/r/150603 [19:46:24] <grrrit-wm1> (03CR) 10CSteipp: [C: 031] Use User::matchEditToken to compare tokens [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/156338 (owner: 10Anomie) [19:46:24] <wikibugs> 3MediaWiki / 3API: token api should allow type parameters for any action name which requires a token - 10https://bugzilla.wikimedia.org/38717#c7 (10Kunal Mehta (Legoktm)) You don't need different tokens for different things, just one token for everything (except for login/createaccount/CentralAuth). See <htt... [19:47:42] <wikibugs> 3MediaWiki / 3API: token api should allow type parameters for any action name which requires a token - 10https://bugzilla.wikimedia.org/38717#c8 (10Jon) Nice. Will we drop support for the named tokens then? Their existence is kind of confusing now... [19:47:47] <grrrit-wm1> (03PS2) 10Dduvall: Central bundler gem installation path for faster provisions [vagrant] - 10https://gerrit.wikimedia.org/r/156207 [19:47:54] <wikibugs> 3MediaWiki / 3User login and signup: Ajax check for username availability is not aware of global accounts that are not attached to the local wiki - 10https://bugzilla.wikimedia.org/70058#c3 (10Bryan Davis) 5NEW>3RESO/DUP This is definitely a dup of bug 64728 *** This bug has been marked as a duplicate o... [19:48:09] <wikibugs> 3MediaWiki / 3Maintenance scripts: deleteOldRevisions.php deletes content text from current revisions - 10https://bugzilla.wikimedia.org/66615#c13 (10Jesús Martínez Novo (Ciencia Al Poder)) How was done the last edit to those articles? I've tested it by deleting the article, and importing it with Special:Im... [19:48:21] <grrrit-wm1> (03PS1) 10Dduvall: Default for provisioning of extension browser tests [vagrant] - 10https://gerrit.wikimedia.org/r/156383 [19:48:24] <wikibugs> 3MediaWiki / 3API: Add undelete to types of action=tokens - 10https://bugzilla.wikimedia.org/63475#c2 (10Kunal Mehta (Legoktm)) 5NEW>3RESO/WON action=tokens is now deprecated, you can just use the token from meta=tokens. [19:48:29] <grrrit-wm1> (03CR) 10Bartosz Dziewoński: [C: 032] "Meh, it's just a test." [core] - 10https://gerrit.wikimedia.org/r/154806 (owner: 10Bartosz Dziewoński) [19:48:33] <grrrit-wm1> (03CR) 10Jack Phoenix: "> A brief note about what is going on would be helpful." [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/156180 (owner: 10Jack Phoenix) [19:49:08] <grrrit-wm1> (03CR) 10CSteipp: [C: 031] "Trevor, I didn't want to merge this since you're listed as the last owner of this extension. This shouldn't change anything for you, and l" [extensions/CommunityVoice] - 10https://gerrit.wikimedia.org/r/156337 (owner: 10Anomie) [19:51:25] <wikibugs> 3MediaWiki / 3API: token api should allow type parameters for any action name which requires a token - 10https://bugzilla.wikimedia.org/38717#c9 (10Kunal Mehta (Legoktm)) They are deprecated, but still supported for backwards-compatability. I'm not sure what anomie's plan/timeline on removing them is. [19:51:25] <wikibugs> 3MediaWiki extensions / 3CentralAuth: "Username in use by unified login system" warning not appearing until after the signup form is submitted - 10https://bugzilla.wikimedia.org/64728#c5 (10Bryan Davis) (From dup bug 70058) > The check in > resources/src/mediawiki.special/mediawiki.special.userlogin.signup.j... [19:51:30] <grrrit-wm1> (03CR) 10Dduvall: Default for provisioning of extension browser tests (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/156383 (owner: 10Dduvall) [19:51:39] <wikibugs> 3MediaWiki / 3API: Deprecate and (in the future) remove all old ways of getting different action tokens - 10https://bugzilla.wikimedia.org/58105#c5 (10Kunal Mehta (Legoktm)) 5NEW>3RESO/FIX In I2793a3f2dd64a4bebb0b4d065e09af1e9f63fb89, action=tokens was deprecated in favor of action=query&meta=tokens, and... [19:51:39] <grrrit-wm1> (03CR) 10saper: [C: 04-1] "Alternative proposed in the gerrit change 156349." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156350 (https://bugzilla.wikimedia.org/70030) (owner: 10Jjanes) [19:53:20] <grrrit-wm1> (03PS8) 10Jdlrobson: Hygiene: Alter how initialisation of the overlay works [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153613 [19:53:56] <MatmaRex> it really irks me when people say "mmv" and "mwv" and i need to stop reading for five seconds and figure out which of the two abbreviations this is. [19:54:33] <ori> not to mention MBV! [19:54:49] <grrrit-wm1> (03CR) 10MaxSem: [C: 04-1] "Eh, it seems to me that this will attempt to install browser tests for every extension, regardless of whether it supports them or not." [vagrant] - 10https://gerrit.wikimedia.org/r/156383 (owner: 10Dduvall) [19:54:50] <wikibugs> 3MediaWiki / 3Skin and page rendering: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277#c35 (10Marcin Cieślak) Seems like a slight botched preparation of the mediawiki/skins project :( Frankly I think it's a wasted effort here. S... [19:54:54] <wikibugs> 3Wikimedia / 3Bugzilla: Add pywikibot component(s) for other scripts - 10https://bugzilla.wikimedia.org/68542#c4 (10Andre Klapper) Has bug 68514 superseded this? if not, has this been discussed with the other maintainers? +1 welcome. For general info what's needed: https://www.mediawiki.org/wiki/Bug_managem... [19:55:08] <grrrit-wm1> (03Merged) 10jenkins-bot: Add a test for mixed /*@noflip*/ and /*@embed*/ CSS annotations [core] - 10https://gerrit.wikimedia.org/r/154806 (owner: 10Bartosz Dziewoński) [19:58:10] <wikibugs> 3Wikimedia / 3Bugzilla: Merge the two Fundraising components in Bugzilla's "Wikimedia" product and the two Fundraising Bugzilla keywords - 10https://bugzilla.wikimedia.org/62002 (10Andre Klapper) p:5Normal>3Low s:5normal>3enhanc a:5Andre Klapper>3None [19:58:24] <wikibugs> 3Wikimedia / 3Bugzilla: Reorganize "Wikipedia Apps" product - 10https://bugzilla.wikimedia.org/64621#c24 (10Andre Klapper) Yuvi, Bernd: ping I'd prefer one of the engineers to answer this with what they prefer, since Bugzilla is primarily for them. [19:58:37] <grrrit-wm1> (03PS1) 10saper: Installer: Do not use Vector skin if not installed [core] - 10https://gerrit.wikimedia.org/r/156440 [19:58:54] <grrrit-wm1> (03CR) 10MarkAHershberger: [V: 032] "Thanks, I was going to do this yesterday and got distracted." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/132190 (https://bugzilla.wikimedia.org/60719) (owner: 10MarkAHershberger) [19:58:56] <grrrit-wm1> (03PS3) 10Jdlrobson: Tweak checkbox sizes to be relative depending on where used. [core] - 10https://gerrit.wikimedia.org/r/154125 [19:59:03] <grrrit-wm1> (03CR) 10Jdlrobson: Tweak checkbox sizes to be relative depending on where used. (032 comments) [core] - 10https://gerrit.wikimedia.org/r/154125 (owner: 10Jdlrobson) [19:59:14] <grrrit-wm1> (03CR) 10Dduvall: "Since I19c19744e2ebd547eb5f88bc616fc502cbb8e785, browsertests::bundle will only attempt to provision the tests if a Gemfile exists in test" [vagrant] - 10https://gerrit.wikimedia.org/r/156383 (owner: 10Dduvall) [19:59:18] <grrrit-wm1> (03CR) 10Jdlrobson: [C: 04-1] "reminder for me to tweak to incorporate Matt's suggestions" [core] - 10https://gerrit.wikimedia.org/r/154125 (owner: 10Jdlrobson) [19:59:24] <wikibugs> 3Wikimedia / 3Bugzilla: Create additional components for PDF Rendering - 10https://bugzilla.wikimedia.org/69603#c4 (10Andre Klapper) Where exactly is the codebase for the "new" PDF renderer located? [19:59:36] <grrrit-wm1> (03PS4) 10Jdlrobson: Fix styling of deletion page [core] - 10https://gerrit.wikimedia.org/r/154121 [19:59:55] <grrrit-wm1> (03CR) 10Anomie: Allow for time-limited tokens (032 comments) [core] - 10https://gerrit.wikimedia.org/r/156336 (owner: 10Anomie) [19:59:57] <grrrit-wm1> (03PS1) 10Jackmcbarn: Save the original arguments array of child frames [core] - 10https://gerrit.wikimedia.org/r/156441 [20:00:24] <wikibugs> 3Wikimedia / 3Bugzilla: Re-evaluate label of Bugzilla's "NEW" status (rename to "OPEN"?) - 10https://bugzilla.wikimedia.org/61984#c2 (10Andre Klapper) p:5Normal>3Low This would break any externally saved Bugzilla query URLs (e.g. in browser bookmarks), hence unlikely to happen though I'd like to see it,... [20:00:36] <grrrit-wm1> (03CR) 10Jackmcbarn: "I plan to use rawArgs from outside of the preprocessor. Should I add accessors for it, instead of just making it public?" [core] - 10https://gerrit.wikimedia.org/r/156441 (owner: 10Jackmcbarn) [20:00:49] <grrrit-wm1> (03CR) 10Anomie: [C: 032] Add a few PHPUnit tests for HTMLAutoCompleteSelectField [core] - 10https://gerrit.wikimedia.org/r/156353 (owner: 10Ori.livneh) [20:01:33] <grrrit-wm1> (03PS1) 10Jackmcbarn: Expose a frame's raw arguments to Lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/156442 [20:02:18] <grrrit-wm1> (03Abandoned) 10Jackmcbarn: Allow fetching unexpanded arguments [core] - 10https://gerrit.wikimedia.org/r/123671 (owner: 10Jackmcbarn) [20:02:37] <grrrit-wm1> (03Abandoned) 10Jackmcbarn: Add frame.uargs (unexpanded arguments) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/123672 (owner: 10Jackmcbarn) [20:02:40] <wikibugs> 3Wikimedia / 3Bugzilla: Retriage all bugs in the MediaWiki extensions → Vector component and remove it - 10https://bugzilla.wikimedia.org/54871#c4 (10Andre Klapper) 5NEW>3RESO/FIX This has happened; closing. Remaining components are "MediaWiki extensions > VectorBeta" and "MediaWiki skins > Vector" [20:02:54] <wikibugs> 3Wikimedia / 3Bugzilla: Migrate "DrTrigon's tools" (pywikibot/bots/drtrigonbot) bugs from JIRA (TS) to Bugzilla (set up product etc) - 10https://bugzilla.wikimedia.org/55673#c43 (10Andre Klapper) What is left to do here? [20:03:09] <wikibugs> 3Wikimedia / 3Bugzilla: Guided bug reporting links en.wiki - 10https://bugzilla.wikimedia.org/56423 (10Andre Klapper) p:5Normal>3Low [20:03:20] <grrrit-wm1> (03CR) 10Anomie: "Probably, yes. I suspect the existing fields are only public for hysterical raisins." [core] - 10https://gerrit.wikimedia.org/r/156441 (owner: 10Jackmcbarn) [20:03:32] <grrrit-wm1> (03CR) 10Jjanes: [C: 031] "This allows the Web installer to work now. The CLI installer now gets farther before failing, for a different reason." [core] - 10https://gerrit.wikimedia.org/r/156349 (https://bugzilla.wikimedia.org/70030) (owner: 10saper) [20:04:06] <jackmcbarn> anomie: re your use-case comment, see my newest Scribunto change [20:04:55] <grrrit-wm1> (03CR) 10BryanDavis: Default for provisioning of extension browser tests (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/156383 (owner: 10Dduvall) [20:05:02] <grrrit-wm1> (03CR) 10Bartosz Dziewoński: [C: 04-1] "I like the idea, but I have issues with the execution :)" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/156440 (owner: 10saper) [20:05:37] <grrrit-wm1> (03CR) 10MaxSem: "Mmm, so you want to exec a shell command for every extension around, at all times? Also, with all this magic, $browser_tests seems redunda" [vagrant] - 10https://gerrit.wikimedia.org/r/156383 (owner: 10Dduvall) [20:06:09] <wikibugs> 3MediaWiki extensions / 3SemanticForms: Edit loss when used with Wikieditor - 10https://bugzilla.wikimedia.org/69902 (10Andre Klapper) [20:06:10] <wikibugs> 3MediaWiki extensions / 3SemanticForms: wikiEditor not loading in a Semantic Form - 10https://bugzilla.wikimedia.org/70057 (10Andre Klapper) [20:06:57] <legoktm> jackmcbarn: is there an easy way to print the contents of a lua table while using the interactive scribunto debugger? [20:07:03] <jackmcbarn> legoktm: mw.logObject [20:07:26] <legoktm> perfect, thanks [20:07:28] <jackmcbarn> np [20:08:01] <jdlrobson2> https://www.mediawiki.org/wiki/Icon_standardisation [20:08:03] <rmoen> hi [20:08:48] <grrrit-wm1> (03Merged) 10jenkins-bot: Add a few PHPUnit tests for HTMLAutoCompleteSelectField [core] - 10https://gerrit.wikimedia.org/r/156353 (owner: 10Ori.livneh) [20:09:18] <grrrit-wm1> (03PS1) 10Bsitu: Continue offset is missing in the read API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156445 [20:10:56] <jdlrobson2> rmoen: TrevorParscal edsanders http://etherpad.wikimedia.org/p/Icon_standardisation [20:12:18] <grrrit-wm1> (03PS1) 10saper: Provide rudimentary __toString() for Status [core] - 10https://gerrit.wikimedia.org/r/156446 [20:12:33] <grrrit-wm1> (03PS2) 10Bsitu: Continue offset is missing in the read API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156445 [20:13:11] <wikibugs> 3MediaWiki / 3Page protection: Changing protection on already-existing protection results in error - 10https://bugzilla.wikimedia.org/70062 (10Courcelleswiki) 3UNCO p:3Unprio s:3normal a:3None So, a page is indef protected from moves; when I go in and change the edit protection (or pending changes pr... [20:14:03] <grrrit-wm1> (03CR) 10Bartosz Dziewoński: "Jon, sorry to be blunt, but your questions are answered on the bug. General agreement refers to comments by Timo, Subbu, Scott, Gabriel an" (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/154350 (https://bugzilla.wikimedia.org/54604) (owner: 10Bartosz Dziewoński) [20:14:09] <wikibugs> 3MediaWiki / 3API: token api should allow type parameters for any action name which requires a token - 10https://bugzilla.wikimedia.org/38717#c10 (10Brad Jorsch) More specifically, most actions will use the token returned by action=query&meta=tokens (&type=csrf, but that's the default). Some will still use c... [20:15:34] <grrrit-wm1> (03PS1) 10Jforrester: browsertests: Enable VE testing on IE11 and Safari; remove Chrome on Windows XP [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/156448 [20:15:52] <grrrit-wm1> (03CR) 10Krinkle: "Yes, individual wikis shouldn't have any rules for external link icons. Except maybe if they intentionally want to change the icon (as som" [skins/Vector] - 10https://gerrit.wikimedia.org/r/154350 (https://bugzilla.wikimedia.org/54604) (owner: 10Bartosz Dziewoński) [20:17:54] <grrrit-wm1> (03PS1) 10Manybubbles: Add configurable delay to our most frequent jobs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156449 [20:18:01] <grrrit-wm1> (03CR) 10Krinkle: Restore external links icons (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/154350 (https://bugzilla.wikimedia.org/54604) (owner: 10Bartosz Dziewoński) [20:19:51] <grrrit-wm1> (03CR) 10Anomie: [C: 04-1] Provide rudimentary __toString() for Status (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156446 (owner: 10saper) [20:21:10] <helderwiki> Any ideas on how to apply a CSS rule to specific WMF wikis? (for usage with GlobalCssJs) [20:21:42] <helderwiki> Something analogous to what was described for JS on [20:21:42] <helderwiki> https://www.mediawiki.org/wiki/Help:Extension:GlobalCssJs#Per-wiki_customization [20:21:45] <legoktm> no, I was thinking we might want to add the db name as a class [20:22:14] <legoktm> <body class="mediawiki ltr sitedir-ltr ns-0 wiki-enwiki ns-subject page-Main_Page skin-monobook action-view"> [20:22:15] <thedjNotWMF> you can cheat a bit by checking the contentlanguage attribute [20:22:28] <jackmcbarn> helderwiki: if you want a hack for now, then make a separate css file for each wiki group, then use the JS way and have JS load the right css files [20:22:33] <Krinkle> helderwiki: Local css? [20:22:33] <helderwiki> yeah, exactly there ^ [20:22:40] <helderwiki> nope, [20:22:47] <Krinkle> if you want local css, why put it in global css? [20:22:55] <helderwiki> More like all Portuguese wikis, or All Wikisources [20:23:02] <helderwiki> exactly as in the JS cases above [20:23:22] <Krinkle> Anything actually meaningful should have a hook already. E.g. what is on wikisources that makes you want to add that style? Try to hook in the semantics instead of it being called wikisource. [20:24:09] <grrrit-wm1> (03CR) 10Anomie: "I have to wonder why a module would want to be trying to manually handle raw arguments, besides trying to second-guess MediaWiki's parsing" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/156442 (owner: 10Jackmcbarn) [20:25:12] <helderwiki> for now I don't have a specific use case in mind, [20:25:16] <grrrit-wm1> (03CR) 10Bartosz Dziewoński: Restore external links icons (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/154350 (https://bugzilla.wikimedia.org/54604) (owner: 10Bartosz Dziewoński) [20:25:31] <helderwiki> I was just checking if there was something which could be used, so I could add to that documentation page [20:25:39] <grrrit-wm1> (03PS2) 10Manybubbles: Add configurable delay to our most frequent jobs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156449 [20:26:39] <Krinkle> my global.js is being executed twice on mediawiki.org [20:26:51] <Krinkle> legoktm: ^ [20:27:05] <Krinkle> whatever it is, something forgot to announce or run something. [20:27:14] <legoktm> you need to remove it from https://www.mediawiki.org/wiki/User:Krinkle/common.js [20:27:27] <helderwiki> :-) [20:27:29] <legoktm> or put your name on the list at https://meta.wikimedia.org/wiki/GlobalCssJs and I'll run the script for you [20:27:38] <Krinkle> I don't need to do anything, I'm a helpless user who is willing to do anything given a fair announcement ahead. [20:27:52] <Krinkle> Not break first, ask in irc, and do some arbitrary thing while trying to get things done. [20:28:12] <legoktm> And I am just a poor sysadmin who will not muck with users personal javascript/css pages unless asked to do so :( [20:28:17] <legoktm> :) * [20:29:03] <Krinkle> Why was it enabled on mw.org (where else is it going live, when?) before announcing? I read mailing lists once a week, I haven't read about it. [20:29:04] <helderwiki> Krinkle: https://lists.wikimedia.org/pipermail/wikitech-ambassadors/2014-August/000893.html [20:29:09] <ebernhardson> legoktm: need a quick pointer, any idea where in mediawiki varnish caches for anons get invalidated? [20:29:24] <helderwiki> but yeah, I don't see something similar for wikitech-l [20:29:26] <Krinkle> Is there a way we can deploy it without it breaking temporarily for users? e.g. something I can do now that will keep it working now and after it is deployed on a wiki? [20:29:42] <legoktm> ebernhardson: $title->invalidateCache I believe [20:30:03] <legoktm> ebernhardson: or $title->purgeSquid [20:30:09] <ebernhardson> legoktm: awsome, thanks! [20:30:11] <legoktm> Krinkle: er, the extension is deployed everywhere. [20:30:21] <Krinkle> legoktm: Why didnt' we run the script then? [20:30:26] <legoktm> I'm running it right now [20:30:31] <Krinkle> Wait, peopel have to sign up to have the script run? [20:30:35] <legoktm> yes [20:30:46] <Krinkle> Is it not good enough to run unconditionally? [20:30:57] <Krinkle> for all users [20:31:05] <legoktm> It probably is, but I don't like touching people's JS/CSS unless they ask [20:31:18] <Krinkle> there can't be that many who have global.js/css on meta in user space. [20:31:27] <helderwiki> Krenair: https://meta.wikimedia.org/wiki/GlobalCssJs [20:31:32] <Krenair> Krinkle, ^ [20:31:33] <legoktm> it's about 300 [20:31:54] <wikibugs> 3MediaWiki extensions / 3CentralAuth: "Username in use by unified login system" warning not appearing until after the signup form is submitted - 10https://bugzilla.wikimedia.org/64728#c6 (10Bryan Davis) From irc: < csteipp> Yeah, there's a centralauth api that is similar to the list=users api... < cste... [20:32:08] <Krinkle> well, I can justify running it for all users if i want to. as a volunteer with global editinterface/userjscss I can tell you I think it's uncontroversial to run and support that action. [20:32:24] <grrrit-wm1> (03CR) 10saper: "I saw that coming :) Sure, it could be way better but anything is better than an exception we get right now." [core] - 10https://gerrit.wikimedia.org/r/156446 (owner: 10saper) [20:32:42] <helderwiki> oh, sorry... typed the wrong nick [20:33:14] <Krinkle> legoktm: Maybe ping those 300 users with [[User:<>]] in a secondary list on that page. [20:33:21] <Krinkle> Got the list handy? [20:33:26] <wikibugs> 3Wikimedia / 3Blog: Initial focus blocks page up/down - 10https://bugzilla.wikimedia.org/70063 (10Nemo) 3NEW p:3Unprio s:3normal a:3None 1) Load any URL to the blog, e.g. https://blog.wikimedia.org/ 2) Press page down I. Observed: nothing happens. II. Expected: the page scrolls down. 3) Click some... [20:33:29] <Krinkle> it'll create echo pings :) [20:33:47] <legoktm> echo has a max of 100 pings per edit so you'll need 3 edits [20:33:55] <legoktm> let me just run the dbquery [20:34:24] <wikibugs> 3MediaWiki extensions / 3CentralAuth: "Username in use by unified login system" warning not appearing until after the signup form is submitted - 10https://bugzilla.wikimedia.org/64728#c7 (10Bryan Davis) Switching the api would still leave the problem of AntiSpoof, TitleBlacklist and anything else hooking Abo... [20:35:58] <Krinkle> legoktm: by default it'll look for meta.wikimedia, User:<username> (english namespace prefix, being meta-wiki..), and as being the only content on that page, right? What's the 1 revision rule for? [20:36:29] <legoktm> safety I guess [20:36:41] <legoktm> typically pathoschild created the page, and it would never be edited again [20:36:45] <Krinkle> it uses wfUrlencode for the username (so pretty print ' ' as _) [20:37:09] <Krinkle> some users changed it over the years though. I think most users on that list will have run it 2 or 2 times. [20:37:48] <Krinkle> e.g. once when there were 400 wikis, and again with there were 800 wikis, the latter with mw.loader.load insteadof importSriptuIR, so it would've updated the existing one incidentally. [20:38:29] <legoktm> https://tools.wmflabs.org/legobot/global.txt [20:38:47] <helderwiki> maybe check if there was only one editor in the js page (e.g. the sync bot)? [20:38:49] <legoktm> does the unicode in that render properly for you? [20:38:55] <grrrit-wm1> (03PS1) 10Jforrester: browsertests: Make it possible to specify a browser target version [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/156452 [20:39:26] <helderwiki> legoktm: the last ~10 items are a little weird [20:39:57] <grrrit-wm1> (03CR) 10Dduvall: "What's wrong with executing a command? Every instance of exec's `if` and `unless` does the same and all pale in comparison to the overall " [vagrant] - 10https://gerrit.wikimedia.org/r/156383 (owner: 10Dduvall) [20:40:03] <legoktm> ugh [20:40:10] <legoktm> tools.legobot@tools-login:~/db_scripts$ sql metawiki_p < globalcssjs.sql > ~/public_html/global.txt [20:40:16] <legoktm> but I guess my shell doesn't like unicode [20:40:41] <wikibugs> 3MediaWiki extensions / 3CentralAuth: CentralAuth/GlobalMerge: <action-centralauth-usermerge> needs a value - 10https://bugzilla.wikimedia.org/70064 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None If you go to [[Special:GlobalUserMerge]] while logged out, you get this: You do not have permission to <... [20:40:54] <wikibugs> 3MediaWiki extensions / 3CentralAuth: CentralAuth/GlobalMerge: <action-centralauth-usermerge> needs a value - 10https://bugzilla.wikimedia.org/70064 (10Dan Garry) p:5Unprio>3Low s:5normal>3minor [20:41:48] <grrrit-wm1> (03PS1) 10EBernhardson: Invalidate title for Workflow owner page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156454 [20:42:47] <grrrit-wm1> (03PS7) 10EBernhardson: WIP: G3: Mobile/nojs edit and reply full topic output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156203 [20:42:54] <wikibugs> 3Wikimedia / 3Bugzilla: Reorganize "Wikipedia Apps" product - 10https://bugzilla.wikimedia.org/64621#c25 (10Bernd Sitzmann) I'm fine with having Android and iOS as components. I think MobileApp should probably not be a separate component since most users are not aware of it when they submit a bug in the app... [20:43:06] <MatmaRex> legoktm: it looks okay form e [20:43:12] <legoktm> :o [20:43:44] <MatmaRex> make sure your browser interprets this as UTF-8 [20:43:56] <MatmaRex> no, i don't know how to do it in these new-fangled user-friendly ones [20:44:01] <legoktm> > windows-1252 [20:44:30] <MatmaRex> my old trusty Opera 12 used UTF-8 by default anyway [20:47:13] <grrrit-wm1> (03PS2) 10EBernhardson: Invalidate title for Workflow owner page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156454 (https://bugzilla.wikimedia.org/69987) [20:47:45] <legoktm> in firefox View --> Character Encoding --> Unicode [20:47:47] <legoktm> and that fixed it [20:47:56] * legoktm goes for lunch [20:49:09] <grrrit-wm1> (03PS2) 10Jackmcbarn: Expose a frame's raw arguments to Lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/156442 [20:50:38] <grrrit-wm1> (03CR) 10BryanDavis: "Running the small shell command on each puppet invocation doesn't seem like a big deal to me at all. This means like 20-30 extra shell com" (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/156383 (owner: 10Dduvall) [20:50:59] <grrrit-wm1> (03CR) 10Deskana: [C: 04-1] "Looking good so far! Here's some comments for now:" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144644 (https://bugzilla.wikimedia.org/47918) (owner: 10Legoktm) [20:51:03] <grrrit-wm1> (03PS3) 10Manybubbles: Add configurable delay to our most frequent jobs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/156449 [20:53:47] <grrrit-wm1> (03PS2) 10Jforrester: browsertests: Enable VE testing on IE11 and Safari; remove Chrome on Windows XP [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/156448 [20:53:50] <grrrit-wm1> (03PS2) 10Jforrester: browsertests: Make it possible to specify a browser target version [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/156452 [20:54:13] <grrrit-wm1> (03CR) 10jenkins-bot: [V: 04-1] browsertests: Enable VE testing on IE11 and Safari; remove Chrome on Windows XP [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/156448 (owner: 10Jforrester) [20:54:16] <grrrit-wm1> (03CR) 10jenkins-bot: [V: 04-1] browsertests: Make it possible to specify a browser target version [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/156452 (owner: 10Jforrester) [20:58:00] <grrrit-wm1> (03PS1) 10Hashar: WIP kill jenkins slaves WIP [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156455 [20:58:20] <grrrit-wm1> (03CR) 10Hashar: [C: 04-2] "The next disrupting project of doom." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156455 (owner: 10Hashar) [21:02:43] <grrrit-wm1> (03PS1) 10IAlex: Use Config instead of globals in CategoryViewer.php [core] - 10https://gerrit.wikimedia.org/r/156456 [21:06:24] <wikibugs> 3Wikimedia / 3Bugzilla: Reorganize "Wikipedia Apps" product - 10https://bugzilla.wikimedia.org/64621#c26 (10Dmitry Brant) It really doesn't matter to me where the MobileApp component ends up. As Bernd mentioned, users of the apps are not aware of its existence, and will not file bugs against it. The patche... [21:07:41] <grrrit-wm1> (03PS2) 10saper: Installer: Do not use Vector skin if not installed [core] - 10https://gerrit.wikimedia.org/r/156440 [21:09:02] <jdlrobson2> TrevorParscal: recommencing [21:09:24] <grrrit-wm1> (03PS2) 10Umherirrender: The static declaration must come after the visibility declaration [core] - 10https://gerrit.wikimedia.org/r/156139 [21:10:28] <grrrit-wm1> (03CR) 10saper: "One thing makes me wonder. In case we don't have Vector forcibly loaded, ResourceLoader correctly recognizes that only "fallback" skin is" [core] - 10https://gerrit.wikimedia.org/r/156440 (owner: 10saper) [21:16:11] <grrrit-wm1> (03CR) 10EBernhardson: [C: 032] Continue offset is missing in the read API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156445 (owner: 10Bsitu) [21:16:37] <grrrit-wm1> (03Merged) 10jenkins-bot: Continue offset is missing in the read API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156445 (owner: 10Bsitu) [21:17:29] <grrrit-wm1> (03CR) 10MarkAHershberger: [C: 032] Add release notes for JobQueue changes in 1.22. [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/132190 (https://bugzilla.wikimedia.org/60719) (owner: 10MarkAHershberger) [21:18:49] <grrrit-wm1> (03CR) 10saper: "How to tell the developer nicely that the module required could not be loaded? (Say somebody renames RL modules and we "forget" about inst" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156440 (owner: 10saper) [21:21:31] <grrrit-wm1> (03Merged) 10jenkins-bot: Add release notes for JobQueue changes in 1.22. [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/132190 (https://bugzilla.wikimedia.org/60719) (owner: 10MarkAHershberger) [21:25:15] <grrrit-wm1> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/151061 (https://bugzilla.wikimedia.org/30666) (owner: 10Ebe123) [21:27:18] <grrrit-wm1> (03CR) 10saper: "openConnectionToAnyDB() succeeds for any username and password :(" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156350 (https://bugzilla.wikimedia.org/70030) (owner: 10Jjanes) [21:28:09] <wikibugs> 3MediaWiki / 3ResourceLoader: ResourceLoader cache not properly fixable after moving MediaWiki - 10https://bugzilla.wikimedia.org/35472#c4 (10Daniel Robbins) Bump on this. This is a pretty ugly bug when dealing with wiki migrations. See my comment above on an easy fix. [21:30:39] <wikibugs> 3MediaWiki / 3Page deletion: All the revision IDs of a page should be stored in log_params when that page is deleted - 10https://bugzilla.wikimedia.org/69049#c4 (10Nathan Larson) Another possible implementation would be to have page_original_id and ar_original_page_id fields that contain the value of what th... [21:32:19] <grrrit-wm1> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156095 (owner: 10Matthias Mullie) [21:34:05] <grrrit-wm1> (03CR) 10Legoktm: [C: 032] Use Config instead of globals in CategoryViewer.php [core] - 10https://gerrit.wikimedia.org/r/156456 (owner: 10IAlex) [21:34:08] <grrrit-wm1> (03PS3) 10Chad: Don't send rel=canonical to variant-neutral page [core] - 10https://gerrit.wikimedia.org/r/154240 (https://bugzilla.wikimedia.org/52429) (owner: 10Tim Starling) [21:34:33] <grrrit-wm1> (03CR) 10Chad: [C: 032] "PS3 was just a rebase, lgtm so merging." [core] - 10https://gerrit.wikimedia.org/r/154240 (https://bugzilla.wikimedia.org/52429) (owner: 10Tim Starling) [21:35:51] <grrrit-wm1> (03CR) 10jenkins-bot: [V: 04-1] Don't send rel=canonical to variant-neutral page [core] - 10https://gerrit.wikimedia.org/r/154240 (https://bugzilla.wikimedia.org/52429) (owner: 10Tim Starling) [21:37:49] <grrrit-wm1> (03PS1) 10Shirayuki: i18n: fix message key [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156460 [21:38:01] <legoktm> Krinkle: should I keep running the script for users or are you working on something? [21:38:26] <wikibugs> 3Wikimedia / 3Bugzilla: Add pywikibot component(s) for other scripts - 10https://bugzilla.wikimedia.org/68542#c5 (10Merlijn van Deen) +1 on a component named 'Other scripts' to separate script bugs from framework bugs. [21:38:55] <grrrit-wm1> (03PS4) 10Chad: Don't send rel=canonical to variant-neutral page [core] - 10https://gerrit.wikimedia.org/r/154240 (https://bugzilla.wikimedia.org/52429) (owner: 10Tim Starling) [21:39:16] <grrrit-wm1> (03CR) 10Chad: [C: 032] Don't send rel=canonical to variant-neutral page [core] - 10https://gerrit.wikimedia.org/r/154240 (https://bugzilla.wikimedia.org/52429) (owner: 10Tim Starling) [21:39:19] <grrrit-wm1> (03PS2) 10Shirayuki: i18n: fix message key [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156460 [21:39:59] <grrrit-wm1> (03Merged) 10jenkins-bot: Use Config instead of globals in CategoryViewer.php [core] - 10https://gerrit.wikimedia.org/r/156456 (owner: 10IAlex) [21:40:39] <wikibugs> 3Wikimedia / 3Bugzilla: Create additional components for PDF Rendering - 10https://bugzilla.wikimedia.org/69603#c5 (10Marcin Cieślak) https://git.wikimedia.org/summary/?r=mediawiki/extensions/Collection/OfflineContentGenerator.git https://git.wikimedia.org/summary/?r=mediawiki/extensions/Collection/OfflineC... [21:45:41] <grrrit-wm1> (03Merged) 10jenkins-bot: Don't send rel=canonical to variant-neutral page [core] - 10https://gerrit.wikimedia.org/r/154240 (https://bugzilla.wikimedia.org/52429) (owner: 10Tim Starling) [21:47:40] <wikibugs> 3MediaWiki / 3Categories: (semi)Automatic template transclusion via categorization or templates - 10https://bugzilla.wikimedia.org/17473 (10Andre Klapper) [21:53:56] <grrrit-wm1> (03PS2) 10Dduvall: Default for provisioning of extension browser tests [vagrant] - 10https://gerrit.wikimedia.org/r/156383 [22:04:12] <Krinkle> legoktm: I'm not doing anything [22:04:17] <Krinkle> Go ahead :) [22:04:21] <Krinkle> What're you running exactly>? [22:04:59] <Krinkle> legoktm: I was going to maybe take that list and ping users via Echo via a * [[]] list on that page under a new section heading letting them know they can request scripted removal [22:05:04] <legoktm> ah [22:05:10] <legoktm> I'm running the removeOldManualPages.php script you reviewed the commit message of :) [22:05:30] <Krinkle> for all users on meta.wikimedia? [22:05:36] <legoktm> for users that requested it [22:05:39] <Krinkle> ok, cool [22:05:53] <Krinkle> legoktm: does the script report if it skipped one (e.g. due to the revision limit)? [22:06:36] <legoktm> yes I'm logging all the runs to ~/globalcssjs/logs/$username.log on terbium, and I'll make them public via noc.wm.o once I finish the current run through of the list [22:06:52] <Krinkle> I think the revision limit isn't needed by default, but either way, since I reckon most people will read over that, would be nice to let them know they have some left and/or might need to re-request it from you without the limit if it turns out there's a couple ones left. [22:07:54] <Krinkle> If you have a minute, could you gist dump an example of such log? Curious what it contains in terms of detail/format. [22:08:50] <legoktm> https://dpaste.de/UDHa/raw [22:09:27] <legoktm> I'm running the script with foreachwiki, so it prepends the database name before each line [22:10:05] <legoktm> other error messages are "{$title->getPrefixedText()} has more than one revision, skipping.\n" or "{$title->getPrefixedText()} did not match the specified regular expression. Skipping.\n" [22:14:01] <Krinkle> legoktm: ah, I see. [22:14:13] <Krinkle> So it doesn't run with --wiki metawiki [22:14:50] <Krinkle> Ah, so that means it also removes common.js pages that import global.js that doesn't exist, e.g it doesn't use metawiki db as source of informatino [22:14:55] <Krinkle> it just scans all common.js'? [22:15:11] <legoktm> it scans all [skin].js/css pages and "common" [22:15:15] <Krinkle> Might be slightly more efficient I guess, oh well [22:15:16] <Krinkle> cool [22:15:32] <Krinkle> Oh, in that case it probably would've been a lot more efficient/speed. [22:15:35] <Krinkle> but complex. [22:15:39] <Krinkle> anyway, one-off. [22:15:49] <grrrit-wm1> (03CR) 10BryanDavis: [C: 031] "Not tested yet, but reading through looks good. I'll test tonight if it hasn't been merged yet." [vagrant] - 10https://gerrit.wikimedia.org/r/156383 (owner: 10Dduvall) [22:15:50] <legoktm> the slowest part of the script is the deletion [22:16:09] <legoktm> from my eyeballing the output [22:16:27] <Krinkle> it reports all pages that don't exist? [22:16:46] <legoktm> yes [22:17:02] <Krinkle> That's a bit verbose :D since it's most unlikely that a user would have all pages existing. I mean, nobody has skin.js and common.js on all wikis I reckon. [22:17:43] <legoktm> there was a user who had created monobook.js loading global.js, and their vector.js was "importScript( 'username/monobook.js' )" >.> [22:17:51] <Krinkle> so basically an "error" everyone has on most wikis.. But it continues either way, so we'll ctrl-f for the useful data afterwards [22:18:27] <Krinkle> Yeah [22:19:32] <Krinkle> That's quite common on local wikis actually. Quite a few power users do that on their home wiki or on a wiki they're very active on. Just lazyness I suppose :) [22:23:10] <wikibugs> 3MediaWiki / 3ResourceLoader: ResourceLoader cache not properly fixable after moving MediaWiki - 10https://bugzilla.wikimedia.org/35472#c5 (10Andre Klapper) Krinkle: Does the approach in comment 3 sound feasible? Daniel: If the approach gets an OK and if you feel like cooking up a patch, see https://www.med... [22:26:26] <wikibugs> 3Wikimedia / 3Bugzilla: Move MobileApp component under MediaWiki extension product - 10https://bugzilla.wikimedia.org/65964#c4 (10Andre Klapper) 5NEW>3RESO/WON So we'll leave it here for the time being (We won't have Bugzilla around for too long anyway as we're heading towards Phabricator). [22:26:39] <wikibugs> 3Wikimedia / 3Bugzilla: Reorganize "Wikipedia App" product - 10https://bugzilla.wikimedia.org/64621#c27 (10Andre Klapper) 5NEW>3RESO/FIX Alright, so we'll leave it here. We won't have Bugzilla around for too long anyway as we're heading towards Phabricator. (In reply to Bernd Sitzmann from comment #25)... [22:27:14] <grrrit-wm1> (03CR) 10Chad: [C: 032] Send groovy script for updates to limit changes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/155339 (owner: 10Manybubbles) [22:27:28] <grrrit-wm1> (03Merged) 10jenkins-bot: Send groovy script for updates to limit changes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/155339 (owner: 10Manybubbles) [22:31:23] <wikibugs> 3MediaWiki / 3Parser: splitArg doesn't work on arguments from newPartNodeArray with Preprocessor_DOM - 10https://bugzilla.wikimedia.org/70067 (10Jackmcbarn) 3NEW p:3Unprio s:3minor a:3None When using Preprocessor_DOM, newPartNodeArray generates DOM elements directly without wrapping them in PPNode_DO... [22:31:28] * jackmcbarn kicks wikibugs [22:33:03] <grrrit-wm1> (03PS1) 10Bsitu: Fallback to master lookup for title when lookup in slave fails [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156466 [22:33:29] <grrrit-wm1> (03PS2) 10Bsitu: Fallback to master lookup for title when lookup in slave fails [extensions/Echo] - 10https://gerrit.wikimedia.org/r/156466 (https://bugzilla.wikimedia.org/69913) [22:34:54] <grrrit-wm1> (03CR) 10Jjanes: "Saper writes:" [core] - 10https://gerrit.wikimedia.org/r/156350 (https://bugzilla.wikimedia.org/70030) (owner: 10Jjanes) [22:36:53] * bd808 just wandered into the dark pit of "how does MW render an HTMLFormField to html" [22:42:35] <wikibugs> 3MediaWiki / 3User login and signup: Password fields for account creation are marked as required when they are not - 10https://bugzilla.wikimedia.org/23769#c17 (10Bryan Davis) From comment in includes/Html.php: // Bug 23769: Blacklist all form validation attributes for now. Current // (June 2010) WebKi... [22:43:55] <Withoutaname> what does the /w mean before /index.php [22:44:00] <grrrit-wm1> (03PS8) 10EBernhardson: WIP: G3: Mobile/nojs edit and reply full topic output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156203 [22:44:00] <grrrit-wm1> (03PS1) 10EBernhardson: Kill auto-mention in favor of subscriptions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156467 [22:44:59] <Krenair> Withoutaname, I guess it's short for 'wiki'... [22:45:01] <legoktm> bd808: o.O I don't think Special:UserLogin uses HTMLForm though. [22:45:06] <bd808> legoktm: It doesn't. [22:45:10] <bd808> legoktm: But I think it does use the form elements system manually [22:45:11] <legoktm> :| [22:45:15] <bd808> http://caniuse.com/#feat=form-validation [22:45:16] <Withoutaname> Krenair: well I mean how can I retrieve it [22:45:25] <grrrit-wm1> (03PS9) 10EBernhardson: WIP: G3: Mobile/nojs edit and reply full topic output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156203 [22:45:30] <Withoutaname> I deleted my localsettings to try out the installer, and it's giving me a bogus link [22:45:31] <legoktm> Withoutaname: $wgScriptPath ? [22:45:55] <bd808> legoktm: "Partial support in Safari refers to lack of notice when form with required fields is attempted to be submitted. Partial support in IE10 mobile refers to lack of warning when blocking submission." [22:46:12] <legoktm> >.> [22:46:32] <bd808> So maybe it's still kinda borked, dunno [22:46:50] <bd808> I used html5 for scholarships and heard no complaints from users [22:46:51] <Withoutaname> script path is set to /wiki [22:48:13] <Withoutaname> legoktm: do you know the nolocalsettings.php file [22:48:55] <Krenair> Withoutaname, you should have your copy of MediaWiki core under 'w', with 'wiki' set up via web server config [22:49:11] <Krenair> And then wgScriptPath will be '/w' [22:49:45] <marktraceurWMF> LocallyProducedOrganicSettings.php [22:53:45] <Withoutaname> Krenair: it is, but DefaultSettings sets it to /w. is it not automatically detected? [22:53:55] <Withoutaname> I mean /wiki [22:54:00] <Withoutaname> I just var_dumped it [22:59:39] <grrrit-wm1> (03CR) 10SG: [C: 032] i18n the time messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155670 (owner: 10Jdlrobson) [23:00:11] <grrrit-wm1> (03Merged) 10jenkins-bot: i18n the time messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155670 (owner: 10Jdlrobson) [23:00:41] <grrrit-wm1> (03Abandoned) 10Legoktm: Adding the ability for CentralAuth to login a user with an altername username. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/61074 (owner: 10Pgehres) [23:00:55] <grrrit-wm1> (03CR) 10Jdlrobson: [C: 032] i18n: get rid of hardcoded 'x comments' text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156095 (owner: 10Matthias Mullie) [23:01:32] <grrrit-wm1> (03Merged) 10jenkins-bot: i18n: get rid of hardcoded 'x comments' text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156095 (owner: 10Matthias Mullie) [23:02:51] <grrrit-wm1> (03CR) 10Jdlrobson: [C: 032] Redirect to Flow view action when url action is set to edit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156183 (https://bugzilla.wikimedia.org/69879) (owner: 10Bsitu) [23:03:27] <grrrit-wm1> (03PS4) 10Jdlrobson: Redirect to Flow view action when url action is set to edit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156183 (https://bugzilla.wikimedia.org/69879) (owner: 10Bsitu) [23:07:27] <grrrit-wm1> (03CR) 10EBernhardson: i18n: properly translate list of topic participants (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156096 (owner: 10Matthias Mullie) [23:10:31] <grrrit-wm1> (03CR) 10Legoktm: Redirect to Flow view action when url action is set to edit (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156183 (https://bugzilla.wikimedia.org/69879) (owner: 10Bsitu) [23:10:50] <grrrit-wm1> (03CR) 10Physikerwelt: [C: 04-1] Prevent Special:MathShowImage from showing bad content (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/156195 (https://bugzilla.wikimedia.org/69693) (owner: 10Physikerwelt) [23:14:24] <grrrit-wm1> (03PS9) 10Jdlrobson: Hygiene: Standardise on time i10n parameter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155672 [23:14:46] <grrrit-wm1> (03PS2) 10Physikerwelt: Prevent Special:MathShowImage from showing bad content [extensions/Math] - 10https://gerrit.wikimedia.org/r/156195 (https://bugzilla.wikimedia.org/69693) [23:14:51] <grrrit-wm1> (03CR) 10Jdlrobson: [C: 031] "I rebased it. Reinstating the +1 of Matthias :)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155672 (owner: 10Jdlrobson) [23:16:18] <grrrit-wm1> (03PS13) 10Jdlrobson: i18n: Allow translation of participants and comment_count [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155827 [23:16:27] <grrrit-wm1> (03PS1) 10SG: Add support for recursive progressiveEnhancement [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156473 [23:16:36] <grrrit-wm1> (03PS2) 10EBernhardson: i18n: properly translate list of topic participants [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156096 (owner: 10Matthias Mullie) [23:16:39] <grrrit-wm1> (03PS1) 10EBernhardson: Remove flow-topic-comment-count from qqq [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156474 [23:18:09] <wikibugs> 3MediaWiki / 3Database: User::loadPasswords 400% spike on wmf db masters - 10https://bugzilla.wikimedia.org/70038#c11 (10Kunal Mehta (Legoktm)) It actually went out around 11 UTC. Sean, could you check if there are less queries now? [23:18:12] <wikibugs> 3MediaWiki / 3ResourceLoader: ResourceLoader cache not properly fixable after moving MediaWiki - 10https://bugzilla.wikimedia.org/35472#c6 (10Krinkle) Yes. If update.php already cleans other tables the same way, let's just add this one to it. [23:18:14] <wikibugs> 3MediaWiki extensions / 3MassMessage: UserGetRights hook causes MassMessage::getMessengerUser() to be called on every pageview - 10https://bugzilla.wikimedia.org/69381#c7 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3wctaiwan This was deployed and backported. [23:18:17] <grrrit-wm1> (03PS3) 10Physikerwelt: Prevent Special:MathShowImage from showing bad content [extensions/Math] - 10https://gerrit.wikimedia.org/r/156195 (https://bugzilla.wikimedia.org/69693) [23:20:29] <grrrit-wm1> (03CR) 10Physikerwelt: Prevent Special:MathShowImage from showing bad content (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/156195 (https://bugzilla.wikimedia.org/69693) (owner: 10Physikerwelt) [23:20:31] <grrrit-wm1> (03Abandoned) 10Jdlrobson: (bug 67714) Remove "Active x hours ago" on topic title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/146431 (https://bugzilla.wikimedia.org/67714) (owner: 10Matthias Mullie) [23:20:59] <grrrit-wm1> (03Abandoned) 10Jdlrobson: Use core mw-ui text-truncated utility mixin [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151789 (owner: 10Jdlrobson) [23:21:46] <grrrit-wm1> (03PS14) 10Jdlrobson: i18n: Allow translation of participants [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155827 [23:23:52] <grrrit-wm1> (03CR) 10Jdlrobson: "The only downside to this approach is it doesn't mention the most recent contributor... can you look at https://gerrit.wikimedia.org/r/#/c" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156096 (owner: 10Matthias Mullie) [23:24:44] <grrrit-wm1> (03PS1) 10Gergő Tisza: Track image loading time via onload [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/156475 [23:25:52] <grrrit-wm1> (03PS10) 10EBernhardson: WIP: G3: Mobile/nojs edit and reply full topic output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156203 [23:25:58] <grrrit-wm1> (03CR) 10jenkins-bot: [V: 04-1] WIP: G3: Mobile/nojs edit and reply full topic output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156203 (owner: 10EBernhardson) [23:27:17] <grrrit-wm1> (03CR) 10Jdlrobson: [C: 032] "Note this is not actually needed as the i18n scripts will remove any qqq codes which do not have entries in en automatically. No harm in m" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156474 (owner: 10EBernhardson) [23:27:24] <grrrit-wm1> (03PS2) 10Jdlrobson: Hygiene: Remove flow-topic-comment-count from qqq [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156474 (owner: 10EBernhardson) [23:27:27] <wikibugs> 3Wikimedia / 3Apache configuration: Unit tests for apache config/rewrites - 10https://bugzilla.wikimedia.org/55857#c1 (10Daniel Zahn) meanwhile the Apache config moved from apache-config to the mediawiki module [23:29:04] <grrrit-wm1> (03Abandoned) 10Jdlrobson: [WIP] Browser tests for paging nagivation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123874 (https://bugzilla.wikimedia.org/61340) (owner: 10Bencmq) [23:30:09] <wikibugs> 3Wikimedia / 3General/Unknown: apache-fast-test non existent pybal config handling - 10https://bugzilla.wikimedia.org/56013#c1 (10Daniel Zahn) meanwhile this file can be found in the operations puppet repo in: ./modules/apachesync/files/apache-fast-test so anyone could take a stab at this now and submit t... [23:31:42] <grrrit-wm1> (03CR) 10Legoktm: "I got the packagist.org credentials for MW.o, so if you rebase this, I think we'll be ready to go :D" [skins/Vector] - 10https://gerrit.wikimedia.org/r/152927 (owner: 10Mwjames) [23:32:20] <grrrit-wm1> (03Abandoned) 10Jdlrobson: Update flow.suite.xml to work with phpunit on mediawiki-vagrant [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149460 (owner: 10EBernhardson) [23:32:25] <grrrit-wm1> (03CR) 10Legoktm: "err, for the "mediawiki" account. Not sure what I was thinking a second ago." [skins/Vector] - 10https://gerrit.wikimedia.org/r/152927 (owner: 10Mwjames) [23:34:12] <grrrit-wm1> (03CR) 10Jdlrobson: [C: 04-1] "No tests, and no card so I don't know what I'm actually reviewing and what value it is adding." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156473 (owner: 10SG) [23:37:11] <wikibugs> 3MediaWiki / 3API: mw1.24wmf18 - API problem - "entity" not exist in WBgetentities - 10https://bugzilla.wikimedia.org/70069 (10Jiří Sedláček) 3UNCO p:3Unprio s:3normal a:3None Hello, at time of deployment new version of Wikidata files (26/08/2014) i get a "key error" Exception in PyWikiBot (wikipedia... [23:42:49] <grrrit-wm1> (03PS1) 10MSyed: New build [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/156479 [23:44:27] <grrrit-wm1> (03CR) 10Prtksxna: [C: 032 V: 032] New build [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/156479 (owner: 10MSyed) [23:47:13] <grrrit-wm1> (03CR) 10Jdlrobson: [C: 04-1] "This needs another rebase :-( I'm not sure what's going on here. Sorry Werdna. Maybe ask in an email whether we should be putting effort " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136280 (https://bugzilla.wikimedia.org/65915) (owner: 10Werdna) [23:48:27] <parent5446> legoktm: Thanks. For some reason I forgot you were an admin. [23:48:33] <legoktm> :) [23:50:13] <grrrit-wm1> (03CR) 10Jdlrobson: Fix Flow entries in Special:EditWatchlist (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156121 (owner: 10Matthias Mullie) [23:50:17] <grrrit-wm1> (03CR) 10Jdlrobson: Fix Flow entries in Special:EditWatchlist (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156121 (owner: 10Matthias Mullie) [23:50:22] <grrrit-wm1> (03CR) 10Jdlrobson: [C: 04-1] Fix Flow entries in Special:EditWatchlist [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156121 (owner: 10Matthias Mullie) [23:52:00] <grrrit-wm1> (03CR) 10Jackmcbarn: [C: 04-1] "I don't really like the output format of this right now. -1 while I rethink it." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/156442 (owner: 10Jackmcbarn) [23:52:18] <^d> cmjohnson1: It's a little over my head I'm afraid. Maybe we should wait until tomorrow? [23:52:44] <^d> Gah, wrong channel.