[00:06:21] wtf [00:06:35] (03PS3) 10tosfos: Inherit ContextSource [extensions/GoogleCustomWikiSearch] - 10https://gerrit.wikimedia.org/r/155616 [00:07:05] (03CR) 10Prtksxna: [C: 032 V: 032] Mark that it requires JavaScript in beta feature [extensions/Popups] - 10https://gerrit.wikimedia.org/r/155483 (https://bugzilla.wikimedia.org/69825) (owner: 10Mattflaschen) [00:10:02] (03PS4) 10tosfos: Inherit ContextSource [extensions/GoogleCustomWikiSearch] - 10https://gerrit.wikimedia.org/r/155616 [00:12:18] (03CR) 10Prtksxna: "Thanks Matt!" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/155483 (https://bugzilla.wikimedia.org/69825) (owner: 10Mattflaschen) [00:12:31] 3MediaWiki extensions / 3Popups: Should be tagged "This feature requires JavaScript." in BetaFeatures - 10https://bugzilla.wikimedia.org/69825 (10Prateek Saxena) 5PATC>3RESO/FIX [00:39:49] (03CR) 10tosfos: [C: 031] Inherit ContextSource [extensions/GoogleCustomWikiSearch] - 10https://gerrit.wikimedia.org/r/155616 (owner: 10tosfos) [00:42:35] (03CR) 10Krinkle: [C: 04-1] "These were commented out on purpose. The idea is to encourage separation of code development and wiki administration." [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/155745 (owner: 10Legoktm) [01:45:09] (03CR) 10tosfos: [C: 032] replace global MultimediaPlayer with Singleton [extensions/MultimediaPlayer] - 10https://gerrit.wikimedia.org/r/155178 (owner: 10tosfos) [01:45:13] (03Merged) 10jenkins-bot: replace global MultimediaPlayer with Singleton [extensions/MultimediaPlayer] - 10https://gerrit.wikimedia.org/r/155178 (owner: 10tosfos) [02:04:34] (03PS1) 10tosfos: add autoplay to known sources [extensions/MultimediaPlayer] - 10https://gerrit.wikimedia.org/r/156068 [02:05:45] (03CR) 10tosfos: [C: 031] add autoplay to known sources [extensions/MultimediaPlayer] - 10https://gerrit.wikimedia.org/r/156068 (owner: 10tosfos) [02:38:31] 3MediaWiki / 3User blocking: MediaWiki:Autoblocker etc. reveals to third party that a (blocked) user has used the same IP address - 10https://bugzilla.wikimedia.org/53008#c53 (10Jackmcbarn) Hiding $1 and $2 would be totally pointless, since knowing the block ID ($5) allows you to see those anyway. [02:50:23] anyone knows if the data exposed by action=info is available through API (specifically number of distinct editors and first editor)? [02:52:30] jgonera: Some data might not be [02:52:53] because code is in the InfoAction class and AFAIR not duplicated in any API module [02:53:01] I'm looking for only those two things. I can't find an API for this, I guess I'll just parse the DOM of the page [02:53:06] I see [02:53:14] so I doubt it's available via API (probably for performance reasons ... or because nobody wanted to code it yet) [02:53:24] not a problem, just didn't want to do it the stupid way (DOM parsing) if there's a better way [02:53:33] thanks [03:01:38] Reports changed/set to RESOLVED : 281 [03:01:38] Reports changed/set to VERIFIED : 7 [03:01:38] Reports created this week: 288 [03:08:07] (03CR) 10Mattflaschen: [C: 04-1] "Can you explain why you'd like to change this?" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/155856 (owner: 10SG) [03:12:41] (03PS1) 10Gnosygnu: v1.8.4.1 [xowa] - 10https://gerrit.wikimedia.org/r/156069 [03:22:35] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own commit for v1.8.4" [xowa] - 10https://gerrit.wikimedia.org/r/156069 (owner: 10Gnosygnu) [03:55:12] (03PS1) 10KartikMistry: Update CXServer [services/cxserver/deploy] - 10https://gerrit.wikimedia.org/r/156070 [03:56:48] (03PS2) 10Santhosh: commafy: prevent infinite loop when pattern has no grouping [core] - 10https://gerrit.wikimedia.org/r/155890 (https://bugzilla.wikimedia.org/69835) [04:00:30] (03PS1) 10Mattflaschen: Remove useNew (no longer any effect) from qqq messages [core] - 10https://gerrit.wikimedia.org/r/156071 [04:12:33] 3MediaWiki / 3JavaScript: mediawiki.language.numbers.js can trigger an endless loop - 10https://bugzilla.wikimedia.org/69835#c1 (10Santhosh Thottingal) 5ASSI>3PATC https://gerrit.wikimedia.org/r/155890 address this bug. --- Comment #2 from Santhosh Thottingal --- https://... [04:12:38] 3MediaWiki / 3JavaScript: mediawiki.language.numbers.js can trigger an endless loop - 10https://bugzilla.wikimedia.org/69835#c1 (10Santhosh Thottingal) 5ASSI>3PATC https://gerrit.wikimedia.org/r/155890 address this bug. --- Comment #2 from Santhosh Thottingal --- https://... [04:13:37] URGENT: what's the code at the office [04:14:47] 3MediaWiki extensions / 3UniversalLanguageSelector: Accessibility of the "more"/… button, including via keyboard - 10https://bugzilla.wikimedia.org/68075#c2 (10Santhosh Thottingal) https://gerrit.wikimedia.org/r/#/c/154041/ changed the trigger to a button. [04:15:35] 3MediaWiki extensions / 3CentralAuth: login when already logged in gets exception from Special:CentralLogin - 10https://bugzilla.wikimedia.org/69834#c3 (10Matthew Flaschen) s:5normal>3major A white screen of death on the login page is more than normal priority, even if it only happens when you're already... [04:18:00] URGENT: what's the code at the office [04:18:51] What, the alarm code yurikR? I don't think anyone will tell you here [04:19:03] Krenair, call me on my cell [04:19:10] if anyone has it that is :) [04:19:15] I don't have it [04:19:17] bummer [04:20:38] yurikR, did you set it off? [04:20:42] yes [04:20:48] by now the police should be here [04:24:19] (03PS2) 1020after4: WIP: initial SecurityPolicyEnforcerAction [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/154850 (owner: 10Rush) [04:27:48] (03CR) 1020after4: "@rush is there a custom field class that goes with this? I'd like to look into a custom form field rendering so that the custom field appe" [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/154850 (owner: 10Rush) [04:33:35] 3Wikimedia / 3General/Unknown: Desktop interface reverts to mobile after opt out - 10https://bugzilla.wikimedia.org/69967 (10Todd Allen) 3UNCO p:3Unprio s:3normal a:3None When using my mobile, there is no longer any way to permanently disable the mobile interface and use the desktop interface instead... [04:38:35] (03PS1) 10Pastakhov: fix highlighting templates and parser functions recussive (v 1.4.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156072 [04:43:01] (03PS2) 10Pastakhov: fix highlighting templates and parser functions recussive (v 1.4.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156072 [04:50:05] (03CR) 10KartikMistry: [C: 032 V: 032] "Self merge to update cxserver." [services/cxserver/deploy] - 10https://gerrit.wikimedia.org/r/156070 (owner: 10KartikMistry) [05:04:08] (03PS3) 10Prtksxna: Use protocol relative URLs for links with https [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/154031 [05:04:12] (03PS3) 10Pastakhov: fix highlighting templates and parser functions recussive (v 1.4.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156072 [05:04:42] (03CR) 10Pastakhov: [C: 032] fix highlighting templates and parser functions recussive (v 1.4.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156072 (owner: 10Pastakhov) [05:04:47] (03Merged) 10jenkins-bot: fix highlighting templates and parser functions recussive (v 1.4.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156072 (owner: 10Pastakhov) [05:05:05] (03CR) 10Prtksxna: Use protocol relative URLs for links with https (034 comments) [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/154031 (owner: 10Prtksxna) [05:08:53] (03PS1) 10Pastakhov: fix templagte argements with '=' is more that one (v 1.4.1) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156073 [05:09:30] (03CR) 10Pastakhov: [C: 032] fix templagte argements with '=' is more that one (v 1.4.1) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156073 (owner: 10Pastakhov) [05:09:35] (03Merged) 10jenkins-bot: fix templagte argements with '=' is more that one (v 1.4.1) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156073 (owner: 10Pastakhov) [05:18:37] (03PS1) 10Legoktm: findHooks: Exit with a status code of 1 if issues are found [core] - 10https://gerrit.wikimedia.org/r/156074 [05:19:11] (03PS3) 10Prtksxna: Force mw.popups.supportsSVG to false on InternetExplorer [extensions/Popups] - 10https://gerrit.wikimedia.org/r/142212 [05:21:43] (03CR) 10Chad: [C: 032] Deprecate $wgDeferredUpdateList [core] - 10https://gerrit.wikimedia.org/r/156021 (owner: 10Legoktm) [05:25:09] (03Merged) 10jenkins-bot: Deprecate $wgDeferredUpdateList [core] - 10https://gerrit.wikimedia.org/r/156021 (owner: 10Legoktm) [05:26:10] (03CR) 10Chad: [C: 04-1] Stop using $wgDeferredUpdateList (032 comments) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/156020 (owner: 10Legoktm) [05:29:49] (03CR) 10Chad: [C: 031] "1.3 is live everywhere, can land whenever." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/155068 (owner: 10Manybubbles) [05:36:04] (03CR) 10Nemo bis: "What's concretely the difference between this and https://www.mediawiki.org/wiki/Manual:$wgExportMaxHistory ?" [core] - 10https://gerrit.wikimedia.org/r/154843 (owner: 10Legoktm) [05:46:08] (03CR) 10Legoktm: "$wgExportMaxHistory checks before the export starts (if I'm reading this code correctly), and counts revisions which may not be all that u" [core] - 10https://gerrit.wikimedia.org/r/154843 (owner: 10Legoktm) [05:52:25] (03PS2) 10Legoktm: Stop using $wgDeferredUpdateList [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/156020 [05:52:50] (03CR) 10Legoktm: Stop using $wgDeferredUpdateList (032 comments) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/156020 (owner: 10Legoktm) [05:54:39] (03CR) 10Vogone: "Any progress here?" [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/94593 (https://bugzilla.wikimedia.org/56207) (owner: 10TTO) [06:17:13] (03CR) 10Siebrand: [C: 032] Remove useNew (no longer any effect) from qqq messages [core] - 10https://gerrit.wikimedia.org/r/156071 (owner: 10Mattflaschen) [06:19:15] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/156052 (https://bugzilla.wikimedia.org/66811) (owner: 10Jack Phoenix) [06:20:32] (03Merged) 10jenkins-bot: Remove useNew (no longer any effect) from qqq messages [core] - 10https://gerrit.wikimedia.org/r/156071 (owner: 10Mattflaschen) [06:21:43] (03PS4) 10Siebrand: Some cleanup and modernization. [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/155010 (owner: 10Jack Phoenix) [06:21:58] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/155010 (owner: 10Jack Phoenix) [06:25:06] (03PS3) 10Nemo bis: Add $wgExportMaxTime to set a max timelimit on Special:Export [core] - 10https://gerrit.wikimedia.org/r/154843 (owner: 10Legoktm) [06:26:26] Nemo_bis: thanks [06:27:37] (03CR) 10Nemo bis: "Thanks; added to the commit message. Was $wgExportMaxHistory tried? WMF doesn't seem to have such OOM problems." [core] - 10https://gerrit.wikimedia.org/r/154843 (owner: 10Legoktm) [06:30:22] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156048 (https://bugzilla.wikimedia.org/69053) (owner: 10Ebe123) [06:51:26] (03CR) 10Nemo bis: "Ah, forgot one thing: some wikis do this via varnish (intentionally or not), as far as I can see: wikihow.com sometimes emits a "varnish g" [core] - 10https://gerrit.wikimedia.org/r/154843 (owner: 10Legoktm) [07:04:31] Hi! I am getting trouble in running 'php maintenance/update.php' after installing an extension on my mediawiki instance. It says: php : command not found. And, I guess, this issue has resulted in the error show in this link. http://i.imgur.com/e5e7pN7.png  [07:05:02] (03CR) 10TTO: "I've tried to get Reedy's attention on this patch on numerous occasions but with no success.." [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/94593 (https://bugzilla.wikimedia.org/56207) (owner: 10TTO) [07:06:22] ritika_coder_101: did you run the command from inside vagrant? [07:06:38] Nemo_bis: yes! [07:07:01] I did cd to maintanance dir [07:07:11] maintenance* [07:09:12] that's not the same [07:09:49] Nemo_bis: I didn't get you [07:11:14] should I be in the vagrant dir ? But update.ph is in vagrant/mediawiki/maintenance [07:11:51] Arggh.. update.php* Sorry for the typos [07:38:46] 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c6 (10Michael M.) Why do user scripts have to be enveloped in that if-clause anyway? 1. In most browsers the global mw will be defined before the user script is execu... [07:57:32] 3MediaWiki extensions / 3CentralAuth: login when already logged in gets exception from Special:CentralLogin - 10https://bugzilla.wikimedia.org/69834#c4 (10Florian) (In reply to spage from comment #0) > As I recall, visiting Special:UserLogin while logged in on mediawiki.org a > week or so ago would just redi... [07:59:54] 3Wikimedia / 3General/Unknown: Wikimedia Hackathon Zürich 2014 - 10https://bugzilla.wikimedia.org/65005 (10Nemo) [07:59:55] 3MediaWiki extensions / 3UniversalLanguageSelector: [Compact links] Don't show as a beta feature option if it can't be enabled - 10https://bugzilla.wikimedia.org/62362 (10Nemo) 5PATC>3RESO/FIX a:3Nemo [08:06:15] (03CR) 10Gilles: [C: 032] Remove extra intval() calls [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/154073 (owner: 10Reedy) [08:06:30] (03Merged) 10jenkins-bot: Remove extra intval() calls [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/154073 (owner: 10Reedy) [08:11:17] (03CR) 10Krinkle: [C: 031] Explicitly declaring stylize.php as open source [tools/code-utils] - 10https://gerrit.wikimedia.org/r/155772 (owner: 10Rillke) [08:13:15] (03CR) 10IAlex: [C: 031] Explicitly declaring stylize.php as open source [tools/code-utils] - 10https://gerrit.wikimedia.org/r/155772 (owner: 10Rillke) [08:13:47] 3Wikimedia / 3Interwiki links: An interlanguage link to oldwikisource is required - 10https://bugzilla.wikimedia.org/32189 (10Tim Starling) [08:13:57] (03CR) 10Gilles: [C: 032] ignore files created when running Selenium [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155472 (owner: 10Neilk) [08:14:26] (03Merged) 10jenkins-bot: ignore files created when running Selenium [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155472 (owner: 10Neilk) [08:16:57] (03PS1) 10Shirayuki: i18n: make extension descriptions translatable [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156082 [08:17:28] (03CR) 10Gilles: [C: 032] add note on how to write tests [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155780 (owner: 10Neilk) [08:17:56] (03Merged) 10jenkins-bot: add note on how to write tests [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155780 (owner: 10Neilk) [08:21:43] (03CR) 10Gilles: "Could the spacing fixes happen in a commit of their own?" (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester) [08:28:06] (03PS69) 10Frédéric Wang: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [08:28:13] (03CR) 10jenkins-bot: [V: 04-1] Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [08:32:07] (03CR) 10Qgil: "Adding a couple of potential reviewers -- this repository has no maintainers identified at https://www.mediawiki.org/wiki/Developers/Maint" [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/133121 (owner: 10Scnd) [08:32:30] (03CR) 10Smuggli: [C: 031] "Thank you one point less on my list." [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156082 (owner: 10Shirayuki) [08:34:31] (03PS5) 10Qgil: [WIP] Replace condition limit with a time limit. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/80159 (owner: 10Werdna) [08:36:15] (03CR) 10Qgil: "What is the status of this patch, which soon will be a year old? Still a good candidate to be merged? Abandoned?" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/85675 (https://bugzilla.wikimedia.org/52919) (owner: 10Alex Monk) [08:37:39] (03CR) 10Shirayuki: ""article" came from "WantedArticle.class.php", but it should be replaced by "page"." [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156082 (owner: 10Shirayuki) [08:38:10] (03CR) 10Qgil: "Adding Jon. It would be good to know whether this patch is ready to be reviewed or still WIP (or effectively abandoned)." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/80137 (owner: 10Werdna) [08:46:39] (03PS2) 10Shirayuki: i18n: make extension descriptions translatable [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156082 [08:50:38] (03PS70) 10Frédéric Wang: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [08:50:42] (03CR) 10jenkins-bot: [V: 04-1] Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [08:50:51] (03CR) 10Qgil: "Krinkle, do your comments imply a -1 here or is this last version of the patch potentially good to be reviewed further and eventually merg" [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/120592 (owner: 10Ori.livneh) [08:51:49] (03PS2) 10Prtksxna: settings: Fix strings, copy and capitalization [extensions/Popups] - 10https://gerrit.wikimedia.org/r/155057 (https://bugzilla.wikimedia.org/68812) [08:52:08] (03CR) 10Siebrand: "Haven't tested, but looks good to me. The ->plain() call is correct, because it's processed later on, I assume?" (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156082 (owner: 10Shirayuki) [08:52:15] (03CR) 10Prtksxna: settings: Fix strings, copy and capitalization (032 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/155057 (https://bugzilla.wikimedia.org/68812) (owner: 10Prtksxna) [08:53:35] (03CR) 10Qgil: "I wonder who could help superbusy CSteipp reviewing this patch. https://www.mediawiki.org/wiki/Developers/Maintainers lists no maintainers" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/124134 (owner: 10Renoirb) [08:55:23] (03CR) 10Frédéric Wang: [C: 04-1] "Sorry, I forgot to commit my changes in patch 69." [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [08:55:31] 3MediaWiki extensions / 3OAuth: Issued at time should be returned as a number - 10https://bugzilla.wikimedia.org/65260#c1 (10Quim Gil) 5NEW>3PATC There is a patch for review at https://gerrit.wikimedia.org/r/#/c/133588/ but for some reason Gerrit didn't post here. Setting status manually. [08:58:00] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/155057 (https://bugzilla.wikimedia.org/68812) (owner: 10Prtksxna) [08:58:26] (03PS3) 10Prtksxna: settings: Fix strings, copy and capitalization [extensions/Popups] - 10https://gerrit.wikimedia.org/r/155057 (https://bugzilla.wikimedia.org/68812) [08:58:49] (03CR) 10Frédéric Wang: "Actually, my test was "\displaystyle a\mod b+c+d"." [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [08:59:00] 3MediaWiki / 3ResourceLoader: Remove 'apiScript' from $wgResourceLoaderSources - 10https://bugzilla.wikimedia.org/69878#c1 (10Kunal Mehta (Legoktm)) (In reply to Kunal Mehta (Legoktm) from comment #0) > When $wgResourceLoaderSources was introduced, it required two keys, one for > the load.php location, and a... [08:59:25] siebrand: Could you +2 it if Amir +1s it? [09:00:10] prtksxna: you mean https://gerrit.wikimedia.org/r/#/c/155057/ ? [09:00:18] siebrand: Yes [09:00:50] (03PS3) 10Shirayuki: i18n: make extension descriptions translatable [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156082 [09:00:53] prtksxna: Would you mind unfuzzying your IRC and Gerrit alias to a real name? [09:01:39] prtksxna: I see you have an @wikimedia.org email address, but https://office.wikimedia.org/wiki/Contact_list doesn't list your alias. [09:01:46] siebrand: Why? This is the handle that I use everywhere. [09:01:59] siebrand: Oh :( [09:02:24] siebrand: I do have prtksxna@wikimedia.org [09:02:47] prtksxna: yes, I see that in gerrit. [09:02:53] (03CR) 10Shirayuki: "PS3: replace single-quotation by double-quotation, about "submit bugs", "edit" and "+"." [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156082 (owner: 10Shirayuki) [09:03:18] siebrand: Would adding myself to the Contact list be enough? [09:03:27] I thought I already had… [09:03:42] prtksxna: It would help me, as I'm very confused and uncertain as to who I'm taking to. [09:08:52] prtksxna: All cleared up. [09:09:06] prtksxna: earlier to wrote you'd have to check the copy with design. Was that done? [09:09:31] siebrand: Yes, I've add a link to the trello discussion to the commit message [09:10:48] (03CR) 10Siebrand: [C: 032] settings: Fix strings, copy and capitalization [extensions/Popups] - 10https://gerrit.wikimedia.org/r/155057 (https://bugzilla.wikimedia.org/68812) (owner: 10Prtksxna) [09:11:03] (03PS1) 10Legoktm: ResourceLoader: Only store sources' load.php urls [core] - 10https://gerrit.wikimedia.org/r/156083 (https://bugzilla.wikimedia.org/69878) [09:11:09] siebrand: Should've waited for Amir's review? [09:11:13] (03Merged) 10jenkins-bot: settings: Fix strings, copy and capitalization [extensions/Popups] - 10https://gerrit.wikimedia.org/r/155057 (https://bugzilla.wikimedia.org/68812) (owner: 10Prtksxna) [09:13:11] prtksxna: pretty sure aharoni agrees. [09:13:15] (03CR) 10Amire80: "Thanks for the fix and for the merge!" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/155057 (https://bugzilla.wikimedia.org/68812) (owner: 10Prtksxna) [09:13:28] prtksxna: as can be seen one second after I claimed that :) [09:13:37] prtksxna, siebrand - thanks :) [09:13:41] I was about to +2 myself. [09:13:45] All is in order then :) [09:16:08] 3MediaWiki extensions / 3Popups: Hovercards "monitor" options are unclear and hard to translate - 10https://bugzilla.wikimedia.org/68812 (10Prateek Saxena) 5PATC>3RESO/FIX [09:18:21] (03CR) 10Siebrand: "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/136123 (https://bugzilla.wikimedia.org/69964) (owner: 10Jackmcbarn) [09:31:08] (03CR) 10Gilles: Add some flow events for funnel logging (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/144588 (owner: 10Gergő Tisza) [09:35:12] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/155914 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [09:36:42] (03CR) 10Gilles: [C: 04-1] Add beforeActive and afterActive to campaigns (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155351 (https://bugzilla.wikimedia.org/64685) (owner: 10MarkTraceur) [09:37:30] (03CR) 10Siebrand: "Is there a patch set somewhere that also updates the group names? That would ideally have been mentioned in the commit summary before this" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/156041 (owner: 10Vogone) [09:37:52] siebrand: hmm? [09:38:09] SPQRobin mentioned it I think [09:38:33] (03CR) 10Tim Starling: "It's kind of scary to merge it and run it without a simple way to test it. If dumpInterwiki.php had an option which gave sorted plain text" [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/94593 (https://bugzilla.wikimedia.org/56207) (owner: 10TTO) [09:38:44] (03CR) 10Gilles: [C: 04-1] Add start/end and whileActive to the campaigns (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153818 (https://bugzilla.wikimedia.org/64685) (owner: 10MarkTraceur) [09:38:52] "It's good to finally have standardized names for global groups. I renamed them on Meta." [09:40:45] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Math] - 10https://gerrit.wikimedia.org/r/156034 (owner: 10Frédéric Wang) [09:41:07] (03CR) 10Vogone: "No such patch set exists/is necessary, I think." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/156041 (owner: 10Vogone) [09:42:17] 3MediaWiki extensions / 3FanBoxes: FanBoxes does not support sqlite as a database backend - 10https://bugzilla.wikimedia.org/69970 (10Antoine "hashar" Musso) 3NEW p:3Unprio s:3normal a:3Jack Phoenix The Jenkins unit tests do not pass because FanBoxes does not support SQLite as a backend: 00:00:03.20... [09:42:33] 3MediaWiki / 3Database: SQLite support (tracking) - 10https://bugzilla.wikimedia.org/20257 (10Antoine "hashar" Musso) [09:43:01] (03CR) 10Siebrand: [C: 032] Remove double @return from User::isAllowedAny [core] - 10https://gerrit.wikimedia.org/r/156024 (owner: 10Umherirrender) [09:43:38] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/152682 [09:44:12] (03CR) 10Siebrand: [C: 032] Add missing @return to function docs [core] - 10https://gerrit.wikimedia.org/r/156003 (owner: 10Umherirrender) [09:44:35] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/152682 (owner: 10Hashar) [09:44:41] (03CR) 10Siebrand: [C: 032] Do not return anything on __construct [core] - 10https://gerrit.wikimedia.org/r/156028 (owner: 10Umherirrender) [09:46:50] (03Merged) 10jenkins-bot: Remove double @return from User::isAllowedAny [core] - 10https://gerrit.wikimedia.org/r/156024 (owner: 10Umherirrender) [09:47:41] (03Merged) 10jenkins-bot: Add missing @return to function docs [core] - 10https://gerrit.wikimedia.org/r/156003 (owner: 10Umherirrender) [09:47:45] (03CR) 10Siebrand: [C: 032] Add some @see to doc blocks [core] - 10https://gerrit.wikimedia.org/r/156025 (owner: 10Umherirrender) [09:48:17] (03Merged) 10jenkins-bot: Do not return anything on __construct [core] - 10https://gerrit.wikimedia.org/r/156028 (owner: 10Umherirrender) [09:49:23] (03CR) 10Siebrand: Standardise and update global group names (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/156041 (owner: 10Vogone) [09:50:10] TimStarling: hey, are you still working on https://bugzilla.wikimedia.org/show_bug.cgi?id=22624 [09:51:17] (03Merged) 10jenkins-bot: Add some @see to doc blocks [core] - 10https://gerrit.wikimedia.org/r/156025 (owner: 10Umherirrender) [09:51:48] (03CR) 10Siebrand: [C: 031] "Looks okay to me." [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156082 (owner: 10Shirayuki) [09:52:01] not at the moment, no [09:53:26] (03CR) 10Gilles: "I think that at least the language detection feature should be its own changeset. Preselecting a guessed language for users seems like an " (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152177 (owner: 10Rillke) [09:54:18] (03CR) 10Siebrand: [C: 032] Make legend easier to read [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/155696 (owner: 10Isarra) [09:56:45] (03CR) 10TTO: "If you don't set the parameter "-o", it appears to set $this->dbFile to false, which apparently means everything gets dumped to the consol" [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/94593 (https://bugzilla.wikimedia.org/56207) (owner: 10TTO) [09:57:01] (03CR) 10Siebrand: Add link to Special:PrefixIndex to Delete dialog (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151061 (https://bugzilla.wikimedia.org/30666) (owner: 10Ebe123) [09:58:36] (03Merged) 10jenkins-bot: Make legend easier to read [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/155696 (owner: 10Isarra) [09:58:42] (03CR) 10Vogone: Standardise and update global group names (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/156041 (owner: 10Vogone) [09:59:01] (03PS6) 10Legoktm: Don't let any module depend on raw modules: 'mediawiki' & 'jquery' [core] - 10https://gerrit.wikimedia.org/r/155647 [10:03:31] (03CR) 10Legoktm: "Yeah, that makes sense. In PS6, I changed mw.loader.register to not register raw modules in the registry." [core] - 10https://gerrit.wikimedia.org/r/155647 (owner: 10Legoktm) [10:06:08] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/149654 (https://bugzilla.wikimedia.org/51971) (owner: 10Deepali) [10:09:27] (03PS6) 10Hashar: create browser test builds for Echo extension [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/154070 (https://bugzilla.wikimedia.org/69130) (owner: 10Cmcmahon) [10:09:35] (03CR) 10Siebrand: [C: 031] "Pretty cool. Thanks!" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155850 (owner: 10MarkTraceur) [10:10:29] (03CR) 10Smuggli: "@Siebrand: The description messages stay the way they are outputted (->plain()). So there is no more processing later on ... is this a pro" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156082 (owner: 10Shirayuki) [10:11:16] 3MediaWiki extensions / 3Extensions requests: Handling subscriptions to newsletter through user preferences - 10https://bugzilla.wikimedia.org/57935 (10Kunal Mehta (Legoktm)) [10:11:45] 3MediaWiki extensions / 3MassMessage: MassMessage blanks the body of the message (but not list of recipients or subject message) upon preview—but only if my name is in the message content! - 10https://bugzilla.wikimedia.org/61926 (10Kunal Mehta (Legoktm)) 5NEW>3UNCO [10:11:52] (03CR) 10Hashar: [C: 032] "INFO:jenkins_jobs.builder:Creating jenkins job browsertests-Echo-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce" [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/154070 (https://bugzilla.wikimedia.org/69130) (owner: 10Cmcmahon) [10:12:17] 3MediaWiki extensions / 3MassMessage: MassMessage: Please include an easy way to add a timestamp at the end of the message - 10https://bugzilla.wikimedia.org/68513 (10Kunal Mehta (Legoktm)) 5NEW>3UNCO [10:12:19] (03Merged) 10jenkins-bot: create browser test builds for Echo extension [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/154070 (https://bugzilla.wikimedia.org/69130) (owner: 10Cmcmahon) [10:13:00] 3MediaWiki extensions / 3MassMessage: UserGetRights hook causes MassMessage::getMessengerUser() to be called on every pageview - 10https://bugzilla.wikimedia.org/69381 (10Kunal Mehta (Legoktm)) p:5Unprio>3High [10:13:37] (03CR) 10TTO: "I just tried it and this was the diff:" [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/94593 (https://bugzilla.wikimedia.org/56207) (owner: 10TTO) [10:13:55] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Oh wow, this is so obvious." [core] - 10https://gerrit.wikimedia.org/r/149340 (owner: 10Aude) [10:15:02] 3MediaWiki extensions / 3MassMessage: MassMessage: Please include an easy way to mark the language (and language direction: LTR vs RTL) for a message - 10https://bugzilla.wikimedia.org/68512#c3 (10Kunal Mehta (Legoktm)) Can we do this as a gadget or something on meta? I don't think MassMessage should be awa... [10:16:21] (03CR) 10Siebrand: "You should never output the format plain() to HTML. Always use an espcaped output mode like escaped() or parse(). See https://www.mediawik" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156082 (owner: 10Shirayuki) [10:16:34] (03CR) 10Siebrand: [C: 04-1] i18n: make extension descriptions translatable [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156082 (owner: 10Shirayuki) [10:18:10] (03CR) 10TTO: "Diff for this change, based on the output of the parent changeset:" [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/141099 (https://bugzilla.wikimedia.org/43027) (owner: 10TTO) [10:19:25] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155857 (owner: 10Jdlrobson) [10:21:18] (03Abandoned) 10Legoktm: Add the ability to send messages using the user's account [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/98469 (https://bugzilla.wikimedia.org/69954) (owner: 10Legoktm) [10:22:01] (03CR) 10Siebrand: "Benny's argument on how to order makes more sense to me than Jon's. Alphabetical ordering doesn't have any functional benefits, apparently" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155669 (owner: 10Jdlrobson) [10:25:57] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/AzharAuth] - 10https://gerrit.wikimedia.org/r/152325 (owner: 10Hashar) [10:26:01] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/152327 (owner: 10Hashar) [10:26:05] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/152332 (owner: 10Hashar) [10:26:08] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/152333 (owner: 10Hashar) [10:26:11] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/152335 (owner: 10Hashar) [10:26:15] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/CategoryMagicWords] - 10https://gerrit.wikimedia.org/r/152339 (owner: 10Hashar) [10:26:19] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/CharRangeSpan] - 10https://gerrit.wikimedia.org/r/152345 (owner: 10Hashar) [10:26:21] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Contest] - 10https://gerrit.wikimedia.org/r/152354 (owner: 10Hashar) [10:26:39] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/ContextComments] - 10https://gerrit.wikimedia.org/r/152355 (owner: 10Hashar) [10:26:43] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/CryoKey] - 10https://gerrit.wikimedia.org/r/152363 (owner: 10Hashar) [10:26:47] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/DebianISOCodes] - 10https://gerrit.wikimedia.org/r/152370 (owner: 10Hashar) [10:26:50] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/EImage] - 10https://gerrit.wikimedia.org/r/152383 (owner: 10Hashar) [10:26:54] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/ELearnware] - 10https://gerrit.wikimedia.org/r/152384 (owner: 10Hashar) [10:26:57] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/examples] - 10https://gerrit.wikimedia.org/r/152388 (owner: 10Hashar) [10:27:00] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/ExtensionStatus] - 10https://gerrit.wikimedia.org/r/152389 (owner: 10Hashar) [10:27:03] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/ExtTab] - 10https://gerrit.wikimedia.org/r/152393 (owner: 10Hashar) [10:27:07] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/152395 (owner: 10Hashar) [10:27:12] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/FlashPlayer] - 10https://gerrit.wikimedia.org/r/152399 (owner: 10Hashar) [10:27:15] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/GoogleTagManager] - 10https://gerrit.wikimedia.org/r/152416 (owner: 10Hashar) [10:27:19] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/HaloTripleStoreConnector] - 10https://gerrit.wikimedia.org/r/152418 (owner: 10Hashar) [10:27:24] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/ImportBibliography] - 10https://gerrit.wikimedia.org/r/152434 (owner: 10Hashar) [10:27:27] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/152435 (owner: 10Hashar) [10:27:30] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/InterwikiExistence] - 10https://gerrit.wikimedia.org/r/152439 (owner: 10Hashar) [10:27:33] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/InterwikiMap] - 10https://gerrit.wikimedia.org/r/152441 (owner: 10Hashar) [10:27:36] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Isbn] - 10https://gerrit.wikimedia.org/r/152444 (owner: 10Hashar) [10:27:40] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/ISO639] - 10https://gerrit.wikimedia.org/r/152445 (owner: 10Hashar) [10:27:43] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/ISO3166] - 10https://gerrit.wikimedia.org/r/152446 (owner: 10Hashar) [10:27:46] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/IssueTracker] - 10https://gerrit.wikimedia.org/r/152447 (owner: 10Hashar) [10:27:50] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/LightboxGallery] - 10https://gerrit.wikimedia.org/r/152456 (owner: 10Hashar) [10:27:53] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/ListSignup] - 10https://gerrit.wikimedia.org/r/152460 (owner: 10Hashar) [10:27:56] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/ListTransclusions] - 10https://gerrit.wikimedia.org/r/152461 (owner: 10Hashar) [10:28:04] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/MailChimpSubscription] - 10https://gerrit.wikimedia.org/r/152471 (owner: 10Hashar) [10:28:12] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Memento] - 10https://gerrit.wikimedia.org/r/152479 (owner: 10Hashar) [10:28:15] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/MirrorTools] - 10https://gerrit.wikimedia.org/r/152482 (owner: 10Hashar) [10:28:18] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/MsLinks] - 10https://gerrit.wikimedia.org/r/152487 (owner: 10Hashar) [10:28:21] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/152489 (owner: 10Hashar) [10:28:25] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/normal] - 10https://gerrit.wikimedia.org/r/152502 (owner: 10Hashar) [10:28:28] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/OnlineStatusBar] - 10https://gerrit.wikimedia.org/r/152514 (owner: 10Hashar) [10:28:31] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/152519 (owner: 10Hashar) [10:28:34] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/PageCredits] - 10https://gerrit.wikimedia.org/r/152521 (owner: 10Hashar) [10:28:38] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/PartitionQuery] - 10https://gerrit.wikimedia.org/r/152529 (owner: 10Hashar) [10:28:40] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/PDBHandler] - 10https://gerrit.wikimedia.org/r/152530 (owner: 10Hashar) [10:28:43] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/PerformanceMonitor] - 10https://gerrit.wikimedia.org/r/152533 (owner: 10Hashar) [10:28:48] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/PhpTagsDebugger] - 10https://gerrit.wikimedia.org/r/152540 (owner: 10Hashar) [10:28:51] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/PhpTagsMaps] - 10https://gerrit.wikimedia.org/r/152541 (owner: 10Hashar) [10:28:54] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/PhpTagsWidgets] - 10https://gerrit.wikimedia.org/r/152542 (owner: 10Hashar) [10:28:57] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/PictureGame] - 10https://gerrit.wikimedia.org/r/152543 (owner: 10Hashar) [10:30:16] 3MediaWiki extensions / 3WikidataClient: populateInterwiki script does not clear interwiki entries in memcached - 10https://bugzilla.wikimedia.org/69903 (10Lydia Pintscher) 5PATC>3RESO/FIX [10:32:10] (03PS1) 10Legoktm: Merge branch 'contenthandler' into master [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/156087 [10:34:32] (03CR) 10Legoktm: "Full diff for easy review: " [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/156087 (owner: 10Legoktm) [10:39:50] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/155641 (owner: 10JGonera) [10:41:13] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/151262 (owner: 10Gergő Tisza) [10:41:45] (03CR) 10Siebrand: [C: 032] Make description into a message + URL. [skins/p2wiki] - 10https://gerrit.wikimedia.org/r/155774 (owner: 10Lewis Cawte) [10:41:47] (03Merged) 10jenkins-bot: Make description into a message + URL. [skins/p2wiki] - 10https://gerrit.wikimedia.org/r/155774 (owner: 10Lewis Cawte) [10:44:08] (03CR) 10Krinkle: "Hm.. getInstance() instead of singleton()?" [core] - 10https://gerrit.wikimedia.org/r/155873 (owner: 10Legoktm) [10:45:06] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/156087 (owner: 10Legoktm) [10:54:04] (03CR) 10Legoktm: "Ok, I don't really have an opinion about that. Done." [core] - 10https://gerrit.wikimedia.org/r/155873 (owner: 10Legoktm) [10:54:06] (03PS2) 10Legoktm: Turn MessageBlobStore into a singleton instead of static functions [core] - 10https://gerrit.wikimedia.org/r/155873 [10:54:27] (03PS1) 10Pastakhov: add highlighting tag names (v 1.5.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156088 [10:57:04] (03PS2) 10Pastakhov: add highlighting tag names (v 1.5.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156088 [10:57:29] (03CR) 10Pastakhov: [C: 032] add highlighting tag names (v 1.5.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156088 (owner: 10Pastakhov) [10:57:33] (03Merged) 10jenkins-bot: add highlighting tag names (v 1.5.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156088 (owner: 10Pastakhov) [11:22:30] 3MediaWiki / 3Special pages: Special:UnwatchedPages should list unwatched pages in the content namespace(s) - 10https://bugzilla.wikimedia.org/16433#c11 (10Andre Klapper) For the records: Followup ticket in bug 16917 [11:23:30] 3MediaWiki / 3Special pages: Special:UnwatchedPages should have greater namespace options - 10https://bugzilla.wikimedia.org/16917#c1 (10Andre Klapper) Wondering if bug 4341 comment 1 from 2006 is still relevant, saying "Special:Unwatchedpages now caches for the main namespace only, by necessity". [11:35:21] (03CR) 10Krinkle: [C: 032] Turn MessageBlobStore into a singleton instead of static functions [core] - 10https://gerrit.wikimedia.org/r/155873 (owner: 10Legoktm) [11:35:38] (03PS2) 10Krinkle: MessageBlobStore: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/155874 (owner: 10Legoktm) [11:39:11] (03Merged) 10jenkins-bot: Turn MessageBlobStore into a singleton instead of static functions [core] - 10https://gerrit.wikimedia.org/r/155873 (owner: 10Legoktm) [11:41:32] (03CR) 10Krinkle: [C: 032] MessageBlobStore: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/155874 (owner: 10Legoktm) [11:42:27] (03CR) 10Physikerwelt: [C: 031] "I'll talk to Peter about that." [extensions/Math] - 10https://gerrit.wikimedia.org/r/156034 (owner: 10Frédéric Wang) [11:43:50] (03PS1) 10Krinkle: phpcs: Pass ResourceLoader.php [core] - 10https://gerrit.wikimedia.org/r/156091 [11:44:36] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/152711 (owner: 10Hashar) [11:44:41] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/152317 (owner: 10Hashar) [11:44:45] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/PlaceNewSection] - 10https://gerrit.wikimedia.org/r/152544 (owner: 10Hashar) [11:44:46] 3MediaWiki extensions / 3UniversalLanguageSelector: ULS: Fix "JQMIGRATE: jQuery.fn.attr('selected')" in ext.uls.displaysettings.js - 10https://bugzilla.wikimedia.org/68998 (10Santhosh Thottingal) a:3Santhosh Thottingal [11:44:48] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/PrefixExport] - 10https://gerrit.wikimedia.org/r/152549 (owner: 10Hashar) [11:44:52] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/ProtectedTitles] - 10https://gerrit.wikimedia.org/r/152556 (owner: 10Hashar) [11:44:54] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/ProxyListDb] - 10https://gerrit.wikimedia.org/r/152558 (owner: 10Hashar) [11:44:57] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/152559 (owner: 10Hashar) [11:45:00] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/PubSubHubbubSubscriber] - 10https://gerrit.wikimedia.org/r/152560 (owner: 10Hashar) [11:45:02] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/PurposeCentricSearch] - 10https://gerrit.wikimedia.org/r/152562 (owner: 10Hashar) [11:45:04] (03Merged) 10jenkins-bot: MessageBlobStore: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/155874 (owner: 10Legoktm) [11:45:06] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/QueryResult] - 10https://gerrit.wikimedia.org/r/152566 (owner: 10Hashar) [11:45:08] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/152568 (owner: 10Hashar) [11:45:10] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/QuizTabulate] - 10https://gerrit.wikimedia.org/r/152569 (owner: 10Hashar) [11:45:12] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Ratings] - 10https://gerrit.wikimedia.org/r/152576 (owner: 10Hashar) [11:45:16] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/RealNames] - 10https://gerrit.wikimedia.org/r/152578 (owner: 10Hashar) [11:45:19] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/RegexFun] - 10https://gerrit.wikimedia.org/r/152581 (owner: 10Hashar) [11:45:20] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/ReorderParserPhases] - 10https://gerrit.wikimedia.org/r/152584 (owner: 10Hashar) [11:45:22] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Sarcasm] - 10https://gerrit.wikimedia.org/r/152588 (owner: 10Hashar) [11:45:24] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/SearchRealnames] - 10https://gerrit.wikimedia.org/r/152590 (owner: 10Hashar) [11:45:26] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/SecurePasswords] - 10https://gerrit.wikimedia.org/r/152593 (owner: 10Hashar) [11:45:41] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/SignWritingMediaWikiPlugin] - 10https://gerrit.wikimedia.org/r/152611 (owner: 10Hashar) [11:45:43] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/SiteSettings] - 10https://gerrit.wikimedia.org/r/152617 (owner: 10Hashar) [11:45:47] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/152624 (owner: 10Hashar) [11:45:49] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/SOLRSearch] - 10https://gerrit.wikimedia.org/r/152626 (owner: 10Hashar) [11:45:51] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/152633 (owner: 10Hashar) [11:45:53] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/SSLClientAuthentication] - 10https://gerrit.wikimedia.org/r/152635 (owner: 10Hashar) [11:45:57] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/StoryParagraph] - 10https://gerrit.wikimedia.org/r/152638 (owner: 10Hashar) [11:45:59] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/SubpageWatchlist] - 10https://gerrit.wikimedia.org/r/152641 (owner: 10Hashar) [11:46:01] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/SwarmExport] - 10https://gerrit.wikimedia.org/r/152643 (owner: 10Hashar) [11:46:03] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/SwedishCollation] - 10https://gerrit.wikimedia.org/r/152644 (owner: 10Hashar) [11:46:05] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/TemplateDocumentation] - 10https://gerrit.wikimedia.org/r/152648 (owner: 10Hashar) [11:46:07] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/ThrottleOverride] - 10https://gerrit.wikimedia.org/r/152652 (owner: 10Hashar) [11:46:09] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/152662 (owner: 10Hashar) [11:46:11] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/UnitTest] - 10https://gerrit.wikimedia.org/r/152663 (owner: 10Hashar) [11:46:13] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/UpdateMediaWiki] - 10https://gerrit.wikimedia.org/r/152664 (owner: 10Hashar) [11:46:15] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/VisualChat] - 10https://gerrit.wikimedia.org/r/152680 (owner: 10Hashar) [11:46:17] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/WantedPagesFromNS] - 10https://gerrit.wikimedia.org/r/152683 (owner: 10Hashar) [11:46:19] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/WikivoteMapsYandex] - 10https://gerrit.wikimedia.org/r/152706 (owner: 10Hashar) [11:46:21] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/WikivotePageSchemas] - 10https://gerrit.wikimedia.org/r/152707 (owner: 10Hashar) [11:46:23] . [11:46:23] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/WikivoyageMessages] - 10https://gerrit.wikimedia.org/r/152708 (owner: 10Hashar) [11:46:25] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/WindowsAzureSDK] - 10https://gerrit.wikimedia.org/r/152709 (owner: 10Hashar) [11:46:34] what is it doing? [11:46:51] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/PropertySuggester] - 10https://gerrit.wikimedia.org/r/152555 (owner: 10Hashar) [11:46:55] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Widgets] - 10https://gerrit.wikimedia.org/r/152691 (owner: 10Hashar) [11:46:57] (03CR) 10Krinkle: [C: 04-1] "What's the point in adding another parameter to register(). Just omit them from the registry entirely. Passing data to startup which is th" [core] - 10https://gerrit.wikimedia.org/r/155647 (owner: 10Legoktm) [11:53:58] (03CR) 10Shirayuki: "Additionally, I think some descriptions are too long to show in Special:WikiAdmin&mode=ExtensionInfo." [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156082 (owner: 10Shirayuki) [11:58:15] 3MediaWiki / 3Special pages: Include special pages in page view counts and statistics - 10https://bugzilla.wikimedia.org/17689#c1 (10Andre Klapper) (In reply to Purodha Blissenbach from comment #0) > Special pages should be included in page view counts and > statistics, e.g. in Special:Statistics, and Specia... [11:59:15] 3MediaWiki extensions / 3UniversalLanguageSelector: Evaluate which resource loader modules really need position => top - 10https://bugzilla.wikimedia.org/47075#c8 (10Santhosh Thottingal) This is bit old, anyway, there were lot of refactoring around the RL modules of ULS. I am listing a set of bug reports and... [11:59:47] 3MediaWiki / 3JavaScript: update jQuery UI in core from 1.9 to 1.11 - 10https://bugzilla.wikimedia.org/69386 (10Krinkle) [12:01:32] 3MediaWiki extensions / 3UniversalLanguageSelector: ULS: Fix "JQMIGRATE: jQuery.fn.attr('selected')" in ext.uls.displaysettings.js - 10https://bugzilla.wikimedia.org/68998 (10Santhosh Thottingal) 5PATC>3RESO/FIX [12:04:02] 3MediaWiki / 3JavaScript: Upgrade jQuery UI from 1.9 to 1.11 - 10https://bugzilla.wikimedia.org/69386 (10Krinkle) p:5Normal>3Low [12:04:03] 3MediaWiki / 3JavaScript: update jQuery UI in core from 1.9 to 1.11 - 10https://bugzilla.wikimedia.org/69386#c2 (10Krinkle) Lowering priority. jQuery UI 1.9 is considered an LTS, and upgrading to 1.10 or 1.11 will be a major and breaking change since until recently we were on jQuery UI 1.8, and 1.9 introduce... [12:04:47] 3MediaWiki / 3Maintenance scripts: mwdocgen.php: does not include mw version - 10https://bugzilla.wikimedia.org/35665#c4 (10Antoine "hashar" Musso) (In reply to TeleComNasSprVen from comment #3) > Do we really still need > > $this->addOption( 'version', 'Pass a MediaWiki version', false, true ); > > in mwd... [12:04:48] 3Wikimedia / 3General/Unknown: JQMIGRATE: jQuery.fn.andSelf() replaced by jQuery.fn.addBack() - 10https://bugzilla.wikimedia.org/66520#c4 (10Krinkle) 5NEW>3RESO/WOR p:5Normal>3Low s:5normal>3minor Closing as WORKSFORME. See also bug 69350. [12:05:03] 3MediaWiki extensions / 3WikidataClient: Link for adding interwiki does not work on Swedish Wikipedia - 10https://bugzilla.wikimedia.org/66521 (10Krinkle) [12:05:15] 3MediaWiki extensions / 3UniversalLanguageSelector: Add small capital variant of Linux Libertine font to ULS font repository - 10https://bugzilla.wikimedia.org/49512 (10Santhosh Thottingal) [12:06:58] (03PS1) 10Nikerabbit: Allow assertions in mw.api.getToken and mw.api.postWithToken [core] - 10https://gerrit.wikimedia.org/r/156093 [12:07:01] (03PS4) 10Krinkle: startup: Blacklist Opera < 12 [core] - 10https://gerrit.wikimedia.org/r/156039 [12:07:08] (03PS5) 10Krinkle: startup: Update documentation and tests to reflect current practices [core] - 10https://gerrit.wikimedia.org/r/156040 [12:07:15] 3MediaWiki / 3Maintenance scripts: mwdocgen.php: does not include mw version - 10https://bugzilla.wikimedia.org/35665#c5 (10Krinkle) (In reply to Antoine "hashar" Musso from comment #4) > (In reply to TeleComNasSprVen from comment #3) > > Do we really still need > > > > $this->addOption( 'version', 'Pass a... [12:07:23] (03PS5) 10Krinkle: startup: Blacklist Opera < 12 [core] - 10https://gerrit.wikimedia.org/r/156039 [12:07:30] (03PS6) 10Krinkle: startup: Update documentation and tests to reflect current practices [core] - 10https://gerrit.wikimedia.org/r/156040 [12:12:20] (03CR) 10Matthias Mullie: [C: 04-1] "Also need to update TemplateHelper.php to reflect these changes." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155670 (owner: 10Jdlrobson) [12:13:34] (03PS1) 10Matthias Mullie: i18n: get rid of hardcoded 'reply' text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156094 [12:13:37] (03PS1) 10Matthias Mullie: i18n: get rid of hardcoded 'x comments' text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156095 [12:13:40] (03PS1) 10Matthias Mullie: i18n: properly translate list of topic participants [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156096 [12:13:43] (03PS1) 10Matthias Mullie: Remove unused i18n hacks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156097 [12:13:46] (03CR) 10Bartosz Dziewoński: [C: 031] startup: Blacklist Opera < 12 [core] - 10https://gerrit.wikimedia.org/r/156039 (owner: 10Krinkle) [12:15:01] (03PS1) 10Hashar: Comment for some non voting jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156099 [12:15:13] (03CR) 10Hashar: [C: 032] Comment for some non voting jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156099 (owner: 10Hashar) [12:15:26] (03Merged) 10jenkins-bot: Comment for some non voting jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156099 (owner: 10Hashar) [12:17:19] (03CR) 10Matthias Mullie: [C: 04-1] "We're already providing {{actions.reply}} to the templates, so I think we should be using that instead of creating new messages." (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155857 (owner: 10Jdlrobson) [12:20:49] ^d: https://bugzilla.wikimedia.org/show_bug.cgi?id=68054 [12:23:46] (03PS1) 10Hashar: Make mediawiki-vendor-integration voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156101 [12:25:29] (03PS2) 10Hashar: Make mediawiki-vendor-integration voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156101 [12:26:20] (03CR) 10Hashar: [C: 032] Make mediawiki-vendor-integration voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156101 (owner: 10Hashar) [12:26:28] (03Merged) 10jenkins-bot: Make mediawiki-vendor-integration voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156101 (owner: 10Hashar) [12:27:47] 3Wikimedia / 3Git/Gerrit: Gerrit: Remove duplicate mirrors on GitHub - 10https://bugzilla.wikimedia.org/68054#c2 (10Krinkle) (In reply to christian from comment #1) > > If it was a conscious choice to do this I'm curious why. > > We want all gerrit repos replicated on github. > > We could setup replication... [12:27:51] (03CR) 10Hashar: "recheck" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/155714 (owner: 10Hashar) [12:28:06] (03PS12) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/92621 [12:28:12] (03PS2) 10Krinkle: es5-shim: Add polyfill for Object.create [core] - 10https://gerrit.wikimedia.org/r/156046 (https://bugzilla.wikimedia.org/67590) [12:28:16] (03PS3) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/143591 [12:28:35] (03CR) 10Addshore: [C: 032] check-entry-points.py to verify extensions [extensions] - 10https://gerrit.wikimedia.org/r/154761 (https://bugzilla.wikimedia.org/69247) (owner: 10Hashar) [12:29:44] (03CR) 10Addshore: [V: 032] check-entry-points.py to verify extensions [extensions] - 10https://gerrit.wikimedia.org/r/154761 (https://bugzilla.wikimedia.org/69247) (owner: 10Hashar) [12:29:52] (03PS1) 10Hashar: Properly filter out mediawiki-core-install-sqlite [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156102 [12:29:58] (03PS3) 10Krinkle: es5-shim: Add polyfill for Object.create [core] - 10https://gerrit.wikimedia.org/r/156046 (https://bugzilla.wikimedia.org/67590) [12:30:00] (03CR) 10Hashar: [C: 032] Properly filter out mediawiki-core-install-sqlite [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156102 (owner: 10Hashar) [12:30:21] 3MediaWiki / 3JavaScript: Ship Object.create polyfill for OOjs for compatibility with browser having ES3 engines - 10https://bugzilla.wikimedia.org/67590 (10Krinkle) 5PATC>3ASSI p:5Normal>3High s:5normal>3minor a:5Bartosz Dziewoński>3Krinkle [12:30:32] 3MediaWiki / 3JavaScript: Loading es5-shim module causes error in IE <= 8 - 10https://bugzilla.wikimedia.org/67565 (10Krinkle) [12:30:39] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/92621 (owner: 10Hashar) [12:31:01] (03Merged) 10jenkins-bot: Properly filter out mediawiki-core-install-sqlite [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156102 (owner: 10Hashar) [12:31:08] (03CR) 10Physikerwelt: [C: 032] Remove the "best for most browsers" comment for the MathJax mode. [extensions/Math] - 10https://gerrit.wikimedia.org/r/156034 (owner: 10Frédéric Wang) [12:31:13] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/143591 (owner: 10Hashar) [12:31:17] (03CR) 10Krinkle: "This polyfill has been tested by OOjs, and is also used there when testing compat with IE6. https://github.com/wikimedia/oojs/tree/v1.0.12" [core] - 10https://gerrit.wikimedia.org/r/156046 (https://bugzilla.wikimedia.org/67590) (owner: 10Krinkle) [12:32:11] (03Merged) 10jenkins-bot: Remove the "best for most browsers" comment for the MathJax mode. [extensions/Math] - 10https://gerrit.wikimedia.org/r/156034 (owner: 10Frédéric Wang) [12:33:55] (03PS2) 10Prtksxna: Remove preventDefault from settings.open [extensions/Popups] - 10https://gerrit.wikimedia.org/r/154794 (https://bugzilla.wikimedia.org/69579) [12:34:36] (03CR) 10Krinkle: [C: 04-1] "assert obviously must be optional, however it's unconditionally used. Passing a key with value 'undefined' to $.ajax/data (which uses $.pa" [core] - 10https://gerrit.wikimedia.org/r/156093 (owner: 10Nikerabbit) [12:35:01] (03PS2) 10Krinkle: mediawiki.api: Support assert parameter in getToken and postWithToken [core] - 10https://gerrit.wikimedia.org/r/156093 (owner: 10Nikerabbit) [12:35:43] (03CR) 10Matthias Mullie: [C: 032] Hygiene: Remove templates for flow_topic_navigation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155825 (owner: 10Jdlrobson) [12:36:16] (03CR) 10Matthias Mullie: [C: 04-1] "https://gerrit.wikimedia.org/r/#/c/155825/ already does most of this. Just need to get rid op "Moderate" still." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156097 (owner: 10Matthias Mullie) [12:39:03] (03PS2) 10Matthias Mullie: Hygiene: remove unused i18n hack [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156097 [12:39:51] (03CR) 10Hashar: "recheck" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/155714 (owner: 10Hashar) [12:39:56] (03CR) 10Hashar: "recheck" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/143591 (owner: 10Hashar) [12:40:00] (03CR) 10Hashar: "recheck" [core] - 10https://gerrit.wikimedia.org/r/92621 (owner: 10Hashar) [12:40:25] (03CR) 10Nikerabbit: "Oh I was under the impression that undefined values are ignored." [core] - 10https://gerrit.wikimedia.org/r/156093 (owner: 10Nikerabbit) [12:44:17] (03PS1) 10Hashar: Always trigger mediawiki-core-qunit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156104 [12:44:33] (03CR) 10Hashar: [C: 032] Always trigger mediawiki-core-qunit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156104 (owner: 10Hashar) [12:44:36] (03PS2) 10Krinkle: ResourceLoader: Only store sources' load.php urls [core] - 10https://gerrit.wikimedia.org/r/156083 (https://bugzilla.wikimedia.org/69878) (owner: 10Legoktm) [12:44:42] (03Merged) 10jenkins-bot: Always trigger mediawiki-core-qunit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156104 (owner: 10Hashar) [12:45:46] (03CR) 10Hashar: "recheck" [core] - 10https://gerrit.wikimedia.org/r/92621 (owner: 10Hashar) [12:46:30] (03CR) 10Hashar: "recheck" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/143591 (owner: 10Hashar) [12:46:34] (03CR) 10Hashar: "recheck" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/155714 (owner: 10Hashar) [12:48:54] (03CR) 10Krinkle: [C: 04-1] "How do you propose wikis will resolve non-local sources without an API? Right now Gadgets 2.0 only uses it to fetch gadget metadata, but I" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156083 (https://bugzilla.wikimedia.org/69878) (owner: 10Legoktm) [13:01:35] (03CR) 10Matthias Mullie: [C: 04-1] Hygiene: Make reference extraction more concrete (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155805 (owner: 10EBernhardson) [13:01:41] (03PS7) 10Matthias Mullie: Hygiene: Make reference extraction more concrete [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155805 (owner: 10EBernhardson) [13:01:47] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make reference extraction more concrete [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155805 (owner: 10EBernhardson) [13:02:21] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156106 [13:02:23] (03CR) 10Krinkle: [C: 04-1] "Hm.. so it's not used by any browser we support Grade A." [core] - 10https://gerrit.wikimedia.org/r/155771 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [13:04:40] (03PS8) 10Matthias Mullie: Hygiene: Make reference extraction more concrete [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155805 (owner: 10EBernhardson) [13:05:04] (03CR) 10Matthias Mullie: [C: 031] "Fixed LinksTableTest.php, LGTM now" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155805 (owner: 10EBernhardson) [13:05:21] (03CR) 10Matthias Mullie: [C: 032] Hygiene: Make reference extraction more concrete [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155805 (owner: 10EBernhardson) [13:05:55] (03Merged) 10jenkins-bot: Hygiene: Make reference extraction more concrete [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155805 (owner: 10EBernhardson) [13:06:08] (03PS1) 10Hashar: Typo in branch: regex [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156107 [13:06:22] (03CR) 10Hashar: [C: 032] Typo in branch: regex [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156107 (owner: 10Hashar) [13:06:31] (03Merged) 10jenkins-bot: Typo in branch: regex [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156107 (owner: 10Hashar) [13:09:17] (03CR) 10Hashar: "recheck" [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156106 (owner: 10Hashar) [13:09:37] (03CR) 10Matthias Mullie: "Hadn't noticed this one before working on https://gerrit.wikimedia.org/r/#/c/156095/" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155827 (owner: 10Jdlrobson) [13:11:02] 3Wikimedia / 3Site requests: Set $wgUploadNavigationUrl on eo.wikipedia - 10https://bugzilla.wikimedia.org/69055 (10Nemo) a:5This, that and the other (TTO)>3None [13:12:53] (03CR) 10Matthias Mullie: "Sorry, pasted wrong link in previous comment." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155827 (owner: 10Jdlrobson) [13:14:19] (03CR) 10Matthias Mullie: "Looks good, just need to update TemplateHelper.php as well" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155672 (owner: 10Jdlrobson) [13:14:32] 3MediaWiki / 3Skin and page rendering: Allow bigger thumbnail sizes in personal settings - 10https://bugzilla.wikimedia.org/69973 (10Michael Schönitzer) 3UNCO p:3Unprio s:3normal a:3None In the user preference of Wikipedia & other WMF Wikis one can set the thumbnail sizes to 120, 150, 180, 200, 220,... [13:17:01] (03CR) 10Matthias Mullie: [C: 04-1] Message on diff page for post should use board title, not UUID (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155849 (owner: 10Bsitu) [13:17:07] (03PS2) 10Matthias Mullie: Message on diff page for post should use board title, not UUID [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155849 (owner: 10Bsitu) [13:17:14] (03CR) 10Bartosz Dziewoński: "I wouldn't mind dropping it, but there's basically zero cost of maintaining it. We will still need an 'assets' directory for other things " [core] - 10https://gerrit.wikimedia.org/r/155771 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [13:17:16] (03CR) 10Matthias Mullie: [C: 032] Message on diff page for post should use board title, not UUID [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155849 (owner: 10Bsitu) [13:17:58] (03Merged) 10jenkins-bot: Message on diff page for post should use board title, not UUID [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155849 (owner: 10Bsitu) [13:20:24] (03PS1) 10Hashar: Fix up mediawiki branch regex [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156109 [13:20:41] (03CR) 10Hashar: [C: 032] Fix up mediawiki branch regex [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156109 (owner: 10Hashar) [13:20:50] (03Merged) 10jenkins-bot: Fix up mediawiki branch regex [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156109 (owner: 10Hashar) [13:21:04] 3MediaWiki / 3Skin and page rendering: Allow bigger thumbnail sizes in personal settings - 10https://bugzilla.wikimedia.org/69973#c1 (10Bartosz Dziewoński) 5UNCO>3NEW I mentioned this on one of the changesets, thanks for filing a bug. I agree we should do this (both adding more big sizes and removing som... [13:21:04] 3Wikimedia / 3Site requests: Increase WMF cluster default image thumb size (tracking) - 10https://bugzilla.wikimedia.org/49357 (10Bartosz Dziewoński) [13:21:04] 3MediaWiki / 3User preferences: Change MediaWiki default thumbnail size to 300px based on user behavior - 10https://bugzilla.wikimedia.org/67703 (10Bartosz Dziewoński) [13:21:30] 3MediaWiki / 3User preferences: Allow bigger thumbnail sizes in personal settings - 10https://bugzilla.wikimedia.org/69973 (10Bartosz Dziewoński) [13:21:52] (03CR) 10Hashar: "recheck" [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156106 (owner: 10Hashar) [13:22:15] 3Wikimedia / 3Site requests: Set $wgUploadNavigationUrl on eo.wikipedia - 10https://bugzilla.wikimedia.org/69055#c3 (10Scott Starkey) Hi - I am Yekrats on the Esperanto Wikipedia, and an admin there. We currently have a toolbar on the left that gives two upload options: one to upload a file (which goes to Co... [13:31:45] 3Wikimedia / 3General/Unknown: Set up dev.wikimedia.org portal - 10https://bugzilla.wikimedia.org/65074#c7 (10Krinkle) (In reply to Krinkle from comment #0) > > developer.wikimedia.org > > The initial portal wouldn't be unlike some of these: > * https://developers.google.com/ > * https://developers.faceboo... [13:40:40] (03CR) 10Florianschmidtwelzow: [C: 031] "Looks good :)" [extensions/GoogleCustomWikiSearch] - 10https://gerrit.wikimedia.org/r/155616 (owner: 10tosfos) [13:41:20] (03CR) 10Rillke: [C: 04-1] "So be it. Marking it as -1 so it appears on my TODO-List." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152177 (owner: 10Rillke) [13:41:28] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156096 (owner: 10Matthias Mullie) [13:42:05] (03PS2) 10Krinkle: Pass Config to ResourceLoader constructor in a few places [core] - 10https://gerrit.wikimedia.org/r/155869 (owner: 10Legoktm) [13:43:16] (03PS1) 10Addshore: WIP Add 2 scripts used by wikidatajenkins [integration/jenkins] - 10https://gerrit.wikimedia.org/r/156110 [13:43:28] (03CR) 10Siebrand: "Pointed out a few more instances of hard coded UI text. Are you keeping track of these somewhere?" (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156095 (owner: 10Matthias Mullie) [13:45:43] (03CR) 10Matthias Mullie: i18n: get rid of hardcoded 'x comments' text (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156095 (owner: 10Matthias Mullie) [13:50:04] (03CR) 10Smuggli: "@Shirayuki: I think this is okay because the width of the columns is customizeable." [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156082 (owner: 10Shirayuki) [13:50:08] (03PS2) 10Umherirrender: Remove wrong @return from doc blocks [core] - 10https://gerrit.wikimedia.org/r/156027 [13:50:31] 3Wikimedia / 3Site requests: Refining typeahead search results for subpages at English Wikisource - 10https://bugzilla.wikimedia.org/69658#c2 (10Nik Everett) I talked with billinghurst about this at WMF - its not on the top of my list but its pretty easy to implement. In fact we already have the feature but... [13:50:45] 3MediaWiki extensions / 3CirrusSearch: Refining typeahead search results for subpages at English Wikisource - 10https://bugzilla.wikimedia.org/69658 (10Nik Everett) [13:51:00] 3MediaWiki extensions / 3CirrusSearch: Refining typeahead search results for subpages at English Wikisource - 10https://bugzilla.wikimedia.org/69658#c3 (10Nik Everett) Move to CirrusSearch so we can fix up Cirrus to make this work properly. [13:51:54] (03PS6) 10Ebe123: Add link to Special:PrefixIndex to Delete dialog [core] - 10https://gerrit.wikimedia.org/r/151061 (https://bugzilla.wikimedia.org/30666) [13:53:00] 3MediaWiki extensions / 3CirrusSearch: "text search is disabled" error sometimes shown when morelike: is used (because it's a redirect?) - 10https://bugzilla.wikimedia.org/68541#c2 (10Nik Everett) p:5Unprio>3Normal Thanks for filing it. I'll have a look at it at some point. I imagine it is caused by no... [14:02:23] (03PS4) 10Bartosz Dziewoński: TablePager: Modernize style loading [core] - 10https://gerrit.wikimedia.org/r/155903 [14:03:48] 3Wikimedia / 3Site requests: Enable DynamicPageList on mediawiki.org - 10https://bugzilla.wikimedia.org/69974 (10Nemo) 3NEW p:3Unprio s:3enhanc a:3None Per consensus at URL. [14:06:07] (03PS4) 10Smuggli: i18n: make extension descriptions translatable [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156082 (owner: 10Shirayuki) [14:07:15] (03CR) 10Bartosz Dziewoński: "We could cook up a new interface for a "output-encapsulating object", and implement an output class that has nothing to do with the Parser" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/155903 (owner: 10Bartosz Dziewoński) [14:07:30] (03CR) 10Smuggli: "Added htmlspecialchars instead of escaped so there can't be any problems in future." [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/156082 (owner: 10Shirayuki) [14:09:59] (03CR) 10Addshore: [C: 04-1] "wdj-get-client-extensions.sh will not be needed" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/156110 (owner: 10Addshore) [14:13:22] (03PS2) 10Addshore: WIP Add 2 scripts used by wikidatajenkins [integration/jenkins] - 10https://gerrit.wikimedia.org/r/156110 [14:14:45] (03PS1) 10Addshore: WIP add jobs for wikibase [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156114 [14:15:20] (03CR) 10jenkins-bot: [V: 04-1] WIP add jobs for wikibase [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156114 (owner: 10Addshore) [14:17:32] (03PS2) 10Addshore: WIP add jobs for wikibase [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156114 [14:18:22] (03CR) 10jenkins-bot: [V: 04-1] WIP add jobs for wikibase [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156114 (owner: 10Addshore) [14:19:41] (03PS3) 10Addshore: WIP add jobs for wikibase [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156114 [14:20:06] (03PS5) 10Bartosz Dziewoński: TablePager: Modernize style loading [core] - 10https://gerrit.wikimedia.org/r/155903 [14:20:34] (03PS2) 10Bartosz Dziewoński: TablePager: Load images via CSS backgrounds rather than HTML s [core] - 10https://gerrit.wikimedia.org/r/155910 (https://bugzilla.wikimedia.org/69277) [14:20:39] (03PS3) 10Bartosz Dziewoński: TablePager: Load images via CSS backgrounds rather than HTML s [core] - 10https://gerrit.wikimedia.org/r/155910 (https://bugzilla.wikimedia.org/69277) [14:21:22] (03PS2) 10Bartosz Dziewoński: TablePager: Redo arrow icons from scratch as CSS backgrounds [core] - 10https://gerrit.wikimedia.org/r/155914 (https://bugzilla.wikimedia.org/69277) [14:21:29] (03CR) 10Bartosz Dziewoński: [C: 04-1] TablePager: Redo arrow icons from scratch as CSS backgrounds [core] - 10https://gerrit.wikimedia.org/r/155914 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [14:22:02] (03CR) 10Renoirb: "Hey Qgil, that commit is roughly a more verbose version of the same thing. It describes how to use it." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/124134 (owner: 10Renoirb) [14:23:15] 3Wikimedia / 3Site requests: Enable DynamicPageList on mediawiki.org - 10https://bugzilla.wikimedia.org/69974 (10Andre Klapper) p:5Unprio>3Normal [14:25:00] 3MediaWiki extensions / 3CentralAuth: login when already logged in gets exception from Special:CentralLogin - 10https://bugzilla.wikimedia.org/69834#c5 (10Andre Klapper) Bug 69947 might be a dup? [14:30:58] bd808, yt? [14:31:27] renoirb: I am. What's up? [14:32:03] (03PS4) 10Addshore: WIP add jobs for wikibase [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156114 [14:33:37] (03CR) 10jenkins-bot: [V: 04-1] WIP add jobs for wikibase [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156114 (owner: 10Addshore) [14:38:47] (03PS5) 10Addshore: WIP add jobs for wikibase [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156114 [14:42:58] (03PS1) 10Matthias Mullie: Allow hook subscribers to also overwrite link to title [core] - 10https://gerrit.wikimedia.org/r/156118 [14:45:10] (03PS1) 10Matthias Mullie: Add new hook WatchlistEditorBeforeFormRender [core] - 10https://gerrit.wikimedia.org/r/156119 [14:46:09] (03PS1) 10Addshore: WIP add new zuul triggers for new wikidata jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156120 [14:53:14] (03PS1) 10Matthias Mullie: Fix Flow entries in Special:EditWatchlist [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156121 [14:53:17] (03PS1) 10Matthias Mullie: Batchload all data required to fix Special:EditWatchlist titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156122 [14:53:35] (03CR) 10Jforrester: "Yes, this could be retrospectively split up into steps if you wish, but it'd be a huge pain to re-do at this point. :-)" (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester) [14:53:50] (03CR) 10Siebrand: "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/155914 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [14:56:52] (03CR) 10Siebrand: "With a little magic, you can do with 1 message. That will require a small change in the code, too." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151061 (https://bugzilla.wikimedia.org/30666) (owner: 10Ebe123) [14:57:50] (03CR) 10Siebrand: [C: 04-1] Add link to Special:PrefixIndex to Delete dialog [core] - 10https://gerrit.wikimedia.org/r/151061 (https://bugzilla.wikimedia.org/30666) (owner: 10Ebe123) [14:59:01] 3MediaWiki / 3Revision deletion: Differentiate graphically deleted vs. suppressed revisions in history ang log - 10https://bugzilla.wikimedia.org/21272#c4 (10Andre Klapper) Pardon my ignorance, but I wonder what the "ang" stands for in the bug summary "Differentiate graphically deleted vs. suppressed revisio... [15:11:00] 3MediaWiki / 3Revision deletion: Differentiate graphically deleted vs. suppressed revisions in history and log - 10https://bugzilla.wikimedia.org/21272#c5 (10Vogone) Presumably it ought to mean "and". Adjusted. [15:13:55] (03PS3) 10Bartosz Dziewoński: TablePager: Redo arrow icons from scratch as CSS backgrounds [core] - 10https://gerrit.wikimedia.org/r/155914 (https://bugzilla.wikimedia.org/69277) [15:13:57] (03PS1) 10Bartosz Dziewoński: IndexPager: Don't generate rel=first and rel=last [core] - 10https://gerrit.wikimedia.org/r/156125 [15:14:36] (03CR) 10Bartosz Dziewoński: "PS3:" [core] - 10https://gerrit.wikimedia.org/r/155914 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [15:18:04] (03CR) 10Ebe123: Add link to Special:PrefixIndex to Delete dialog (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151061 (https://bugzilla.wikimedia.org/30666) (owner: 10Ebe123) [15:18:11] (03CR) 10Ebe123: Add link to Special:PrefixIndex to Delete dialog (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151061 (https://bugzilla.wikimedia.org/30666) (owner: 10Ebe123) [15:18:41] (03PS7) 10Ebe123: Add link to Special:PrefixIndex to Delete dialog [core] - 10https://gerrit.wikimedia.org/r/151061 (https://bugzilla.wikimedia.org/30666) [15:19:35] (03CR) 10jenkins-bot: [V: 04-1] Add link to Special:PrefixIndex to Delete dialog [core] - 10https://gerrit.wikimedia.org/r/151061 (https://bugzilla.wikimedia.org/30666) (owner: 10Ebe123) [15:21:17] 3MediaWiki / 3Page editing: new section not added on edit conflict - 10https://bugzilla.wikimedia.org/69920#c2 (10Brad Jorsch) The situation of getting an edit conflict when adding a new section is very hard to test, since it generally cannot conflict. But if it does, the user will be given the usual full-pa... [15:21:42] (03PS8) 10Ebe123: Add link to Special:PrefixIndex to Delete dialog [core] - 10https://gerrit.wikimedia.org/r/151061 (https://bugzilla.wikimedia.org/30666) [15:24:33] (03CR) 10Anomie: "Except for one style nitpick, looks good to me." (031 comment) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/133588 (https://bugzilla.wikimedia.org/65260) (owner: 10CSteipp) [15:28:55] (03PS1) 10Bartosz Dziewoński: IndexPager: Introduce constants for values of $mDefaultDirection [core] - 10https://gerrit.wikimedia.org/r/156128 [15:29:45] 3MediaWiki / 3Uploading: Allow &preload= and &editintro= parameters for templates on Special:Upload - 10https://bugzilla.wikimedia.org/11698#c1 (10Andre Klapper) Wondering how relevant this still is in times of Commons mostly using UploadWizard (see e.g. bug 49443 for those issues). [15:35:09] (03CR) 10Anomie: "Seems sane. Haven't tested. One style nitpick." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/155872 (owner: 10Legoktm) [15:41:09] (03PS1) 10Bartosz Dziewoński: No space within the ?: operator [core] - 10https://gerrit.wikimedia.org/r/156136 [15:42:09] (03CR) 10Rush: "So using a native customfield (select field) that works with this is seen here:" [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/154850 (owner: 10Rush) [15:48:47] (03CR) 10MarkTraceur: Add beforeActive and afterActive to campaigns (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155351 (https://bugzilla.wikimedia.org/64685) (owner: 10MarkTraceur) [15:49:27] (03PS1) 10Physikerwelt: wip: mathoid role [vagrant] - 10https://gerrit.wikimedia.org/r/156137 [15:50:42] (03CR) 10MarkTraceur: Add start/end and whileActive to the campaigns (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153818 (https://bugzilla.wikimedia.org/64685) (owner: 10MarkTraceur) [15:54:46] 3MediaWiki extensions / 3CentralAuth: BadMethodCallException with "Call to a member function getId" in SpecialCentralLogin.php on Beta Labs - 10https://bugzilla.wikimedia.org/69565#c10 (10Greg Grossmeier) (In reply to Andre Klapper from comment #9) > (In reply to Andre Klapper from comment #8) > > Has the Ec... [15:56:15] (03PS1) 10Vikassy: Environment variable MEDIAWIKI_API_UPLOAD_URL can now be set using build parameter in language screenshot job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/156138 [15:56:52] (03CR) 10Addshore: "@Foxtrott, we will eventually, it will just take a looooong time.." [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [15:57:46] 3Wikimedia / 3Media storage: Swift outage caused a bunch of moved files to be "inconsistent" and "missing" - 10https://bugzilla.wikimedia.org/69311#c8 (10Greg Grossmeier) Filippo: Anything you can do to help here? [15:57:53] (03CR) 10Jforrester: [C: 031] es5-shim: Add polyfill for Object.create [core] - 10https://gerrit.wikimedia.org/r/156046 (https://bugzilla.wikimedia.org/67590) (owner: 10Krinkle) [16:00:04] 3Wikimedia / 3General/Unknown: Resource loader ignores requested caching directives / not caching properly - 10https://bugzilla.wikimedia.org/69460#c5 (10Greg Grossmeier) (In reply to Andre Klapper from comment #4) > Mark: Any comments, as you worked on that change? That's an old change (2013) so he might h... [16:06:07] 3MediaWiki / 3JavaScript: Remove all uses of jQuery.browser (tracking) - 10https://bugzilla.wikimedia.org/66097#c3 (10James Forrester) 5NEW>3RESO/FIX On the basis that there are no open sub-bugs of this, I'm marking it FIXED. Please re-open if there are still issues. Thank you everyone for your work! [16:06:28] So, https://bugzilla.wikimedia.org/show_bug.cgi?id=69349 is apparently the last standing blocker to removing jQuery.Migrate for extensions. Who wants to fix WikiLove? :-) [16:06:52] (03CR) 10Hashar: [C: 04-1] "bunch of nitpicks :-)" (035 comments) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156114 (owner: 10Addshore) [16:07:16] 3Wikimedia / 3General/Unknown: Resource loader ignores requested caching directives / not caching properly - 10https://bugzilla.wikimedia.org/69460#c6 (10Mark Bergsma) That change simply puts the same behaviour in place that was there with the Squid cluster before Varnish. The problem is that we don't have... [16:14:01] (03CR) 10Hashar: [C: 04-1] "Trick: you can use the 'experimental' pipeline while the job are being setup. Will let us manually trigger them instead of on each patch " (031 comment) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156120 (owner: 10Addshore) [16:17:02] (03CR) 10Aaron Schulz: [C: 032] No space within the ?: operator [core] - 10https://gerrit.wikimedia.org/r/156136 (owner: 10Bartosz Dziewoński) [16:24:16] (03CR) 10Anomie: "I see several i18n messages that are no longer used as a result of this patch: pageinfo-views, statistics-header-views, statistics-views-t" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/150699 (owner: 10Chad) [16:24:34] (03CR) 10Hashar: [C: 04-1] "almost :)" (032 comments) [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/156138 (owner: 10Vikassy) [16:26:20] (03CR) 10Chad: "SMW calls SiteStats::views() without a guard, hence the deprecation." [core] - 10https://gerrit.wikimedia.org/r/150699 (owner: 10Chad) [16:26:22] (03PS1) 10Umherirrender: The static declaration must come after the visibility declaration [core] - 10https://gerrit.wikimedia.org/r/156139 [16:28:31] (03CR) 10Alex Monk: "I think it's still to be merged." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/85675 (https://bugzilla.wikimedia.org/52919) (owner: 10Alex Monk) [16:28:31] (03PS6) 10Addshore: WIP add jobs for wikibase [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156114 [16:29:17] (03PS3) 10Nikerabbit: mediawiki.api: Support assert parameter in getToken and postWithToken [core] - 10https://gerrit.wikimedia.org/r/156093 [16:30:18] (03CR) 10Nikerabbit: "Added test, but I do not see "assert=" in the requests so I do not know what needs fixing there." [core] - 10https://gerrit.wikimedia.org/r/156093 (owner: 10Nikerabbit) [16:30:20] (03PS2) 10Addshore: WIP add new zuul triggers for new wikidata jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156120 [16:30:23] (03CR) 10Anomie: EditPage: Reduce dependence upon global objects (031 comment) [core] - 10https://gerrit.wikimedia.org/r/155692 (owner: 10Legoktm) [16:30:31] (03CR) 10Anomie: [C: 031] "Looks sane. Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/155692 (owner: 10Legoktm) [16:35:19] (03Merged) 10jenkins-bot: No space within the ?: operator [core] - 10https://gerrit.wikimedia.org/r/156136 (owner: 10Bartosz Dziewoński) [16:35:24] (03PS2) 10MaxSem: Split dev roles out of MobileFrontend and CirrusSearch [vagrant] - 10https://gerrit.wikimedia.org/r/155861 [16:39:34] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.api: Support assert parameter in getToken and postWithToken [core] - 10https://gerrit.wikimedia.org/r/156093 (owner: 10Nikerabbit) [16:39:47] 3Wikimedia / 3Media storage: Swift outage caused a bunch of moved files to be "inconsistent" and "missing" - 10https://bugzilla.wikimedia.org/69311#c9 (10Filippo Giunchedi) Greg: at wikimania I asked Aaron the context for this and a preliminary script to find missing images has been committed in https://gerr... [16:40:22] anomie, have you seen my reply at https://gerrit.wikimedia.org/r/#/c/155622/2/includes/api/ApiPageSet.php ? [16:42:12] MaxSem: I saw it. I don't like the idea of one generator returning non-normalized page titles when all others do. [16:43:03] (03CR) 10Strix: "It's still waiting for somebody to review and approve the code, so far as I know. Evidently a few people have been asked to do so, but it" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/65797 (owner: 10Strix) [16:43:32] anomie, but that's the whole point of this generator and that's how it works presently. suggestions? [16:44:33] MaxSem: Don't use prefixsearch as a generator if you don't want the titles normalized? [16:44:48] heh [16:44:54] it has to be a generator [16:45:21] when it wasn't, it caused a horrible load on the servers due to additional API requests [16:46:38] anomie, ^ [16:47:17] (03PS2) 10Manybubbles: Send groovy script for updates to limit changes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/155339 [16:47:24] MaxSem: What were all these requests? Just list=prefixsearch and then prop=info&titles=[all the titles from list=prefixsearch]? [16:48:02] (03CR) 10Manybubbles: Port scripts to groovy [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/155068 (owner: 10Manybubbles) [16:48:17] anomie, yes, essentially. just with action=opensearch [16:48:42] (03CR) 10Manybubbles: [C: 032] "And 1.3 is now live." [vagrant] - 10https://gerrit.wikimedia.org/r/154878 (owner: 10Manybubbles) [16:48:44] (03CR) 10jenkins-bot: [V: 04-1] Update Elasticsearch plugin versions for 1.3 [vagrant] - 10https://gerrit.wikimedia.org/r/154878 (owner: 10Manybubbles) [16:49:27] ..and a different prop:) [16:50:04] (03PS2) 10Manybubbles: Update Elasticsearch plugin versions for 1.3 [vagrant] - 10https://gerrit.wikimedia.org/r/154878 [16:50:36] (03CR) 10Anomie: [C: 031] "wfWarn seems good to me." [core] - 10https://gerrit.wikimedia.org/r/148768 (owner: 10Bartosz Dziewoński) [16:50:38] (03CR) 10Manybubbles: [C: 032] Update Elasticsearch plugin versions for 1.3 [vagrant] - 10https://gerrit.wikimedia.org/r/154878 (owner: 10Manybubbles) [16:50:43] (03Merged) 10jenkins-bot: Update Elasticsearch plugin versions for 1.3 [vagrant] - 10https://gerrit.wikimedia.org/r/154878 (owner: 10Manybubbles) [16:51:03] (03PS1) 10Umherirrender: Add missing @return and @param to doc blocks [core] - 10https://gerrit.wikimedia.org/r/156142 [16:52:52] MaxSem: I'm wondering whether changing two queries to one more complicated query is going to reduce load all that much. I also wonder whether https://en.wikipedia.org/w/api.php?action=query&list=prefixsearch&pssearch=Special:Ip&generator=prefixsearch&gpssearch=Special:Ip&prop=info would work, ugly as that is. [16:53:40] !log stopping puppet on cp3021. Testing an increase of kafka.queue.buffering.max.ms in order to avoid dropping messages during broker metadata change (e.g. leader elections) [16:53:50] (03CR) 10Helder.wiki: Add es5-shim library v3.4.0 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/139308 (owner: 10Jforrester) [16:54:26] oops, wrong channel [16:55:04] (03CR) 10Jforrester: Add es5-shim library v3.4.0 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/139308 (owner: 10Jforrester) [16:56:09] anomie, actually due to bad cache hit ratio, prefixsearch halved API appserver traffic [16:58:45] (03CR) 10Gilles: Add beforeActive and afterActive to campaigns (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155351 (https://bugzilla.wikimedia.org/64685) (owner: 10MarkTraceur) [16:59:53] (03PS1) 10Pastakhov: add highlighting text that starts with space (1.6.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156145 [17:00:43] (03CR) 10Pastakhov: [C: 032] add highlighting text that starts with space (1.6.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156145 (owner: 10Pastakhov) [17:00:48] (03Merged) 10jenkins-bot: add highlighting text that starts with space (1.6.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/156145 (owner: 10Pastakhov) [17:02:01] (03CR) 10Jdlrobson: [C: 04-1] "A few minor complaints." (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156121 (owner: 10Matthias Mullie) [17:03:47] (03PS1) 10Manybubbles: Upgrade Elasticsearch [vagrant] - 10https://gerrit.wikimedia.org/r/156146 [17:04:10] (03PS2) 10MarkTraceur: Add beforeActive and afterActive to campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155351 (https://bugzilla.wikimedia.org/64685) [17:04:15] (03CR) 10Manybubbles: [C: 032] "Without this provision no longer works with cirrus since we upgraded production." [vagrant] - 10https://gerrit.wikimedia.org/r/156146 (owner: 10Manybubbles) [17:04:18] (03Merged) 10jenkins-bot: Upgrade Elasticsearch [vagrant] - 10https://gerrit.wikimedia.org/r/156146 (owner: 10Manybubbles) [17:04:39] (03CR) 10Gilles: Add start/end and whileActive to the campaigns (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153818 (https://bugzilla.wikimedia.org/64685) (owner: 10MarkTraceur) [17:05:18] (03CR) 10Jdlrobson: "@siebrand the main issue I'm trying to get around is JSON objects do not have any enforced order. (An object is an unordered set of name/v" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155669 (owner: 10Jdlrobson) [17:05:52] (03CR) 10MarkTraceur: Add start/end and whileActive to the campaigns (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153818 (https://bugzilla.wikimedia.org/64685) (owner: 10MarkTraceur) [17:07:10] (03CR) 10Manybubbles: "About to rebase and de-WIP." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/150207 (owner: 10Manybubbles) [17:11:47] (03CR) 10Chad: [C: 032] Port scripts to groovy [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/155068 (owner: 10Manybubbles) [17:12:00] (03Merged) 10jenkins-bot: Port scripts to groovy [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/155068 (owner: 10Manybubbles) [17:15:46] (03CR) 10Aaron Schulz: [C: 032] Remove wrong @return from doc blocks [core] - 10https://gerrit.wikimedia.org/r/156027 (owner: 10Umherirrender) [17:16:19] (03CR) 10CSteipp: [C: 04-1] "Still using 2 spaces instead of tabs, otherwise I would merge this right now." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/124134 (owner: 10Renoirb) [17:17:11] (03CR) 10Renoirb: "Oops. I can fix that. I didn’t know that was what’s keeping it there." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/124134 (owner: 10Renoirb) [17:21:47] (03Merged) 10jenkins-bot: Remove wrong @return from doc blocks [core] - 10https://gerrit.wikimedia.org/r/156027 (owner: 10Umherirrender) [17:22:01] 3MediaWiki-Vagrant: setup.bat ruins .settings.yaml file - 10https://bugzilla.wikimedia.org/69932#c3 (10Dan Duvall) Yuri, can you pull down the latest master and retest this? [17:22:22] (03CR) 10Chad: [C: 032] Stop using $wgDeferredUpdateList [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/156020 (owner: 10Legoktm) [17:22:45] (03CR) 10Chad: [C: 032] "XML sucks anyway." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/153868 (https://bugzilla.wikimedia.org/69442) (owner: 10Manybubbles) [17:23:01] (03Merged) 10jenkins-bot: Create endpoint to dump cirrus configuration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/153868 (https://bugzilla.wikimedia.org/69442) (owner: 10Manybubbles) [17:24:01] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Create debug and information endpoints - 10https://bugzilla.wikimedia.org/69442 (10Nik Everett) 5PATC>3RESO/FIX [17:24:15] (03Merged) 10jenkins-bot: Stop using $wgDeferredUpdateList [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/156020 (owner: 10Legoktm) [17:24:34] (03CR) 10SG: "The pseudo-selectors override those on other elements which use mw-ui-(progressive/constructive/destructive) context classes. eg. :hover s" [core] - 10https://gerrit.wikimedia.org/r/155856 (owner: 10SG) [17:25:29] (03CR) 10Chad: [C: 032] startup: Blacklist Opera < 12 [core] - 10https://gerrit.wikimedia.org/r/156039 (owner: 10Krinkle) [17:26:25] (03PS2) 10Umherirrender: Add missing @return and @param to doc blocks [core] - 10https://gerrit.wikimedia.org/r/156142 [17:28:12] qgil, hey [17:28:47] qgil, I saw your message earlier about tracking bugs in the open. What about operations & RT? [17:28:56] (03PS1) 10Umherirrender: Fix spacing [core] - 10https://gerrit.wikimedia.org/r/156149 [17:30:25] (03PS7) 10Krinkle: startup: Update documentation [core] - 10https://gerrit.wikimedia.org/r/156040 [17:30:55] (03PS2) 10Manybubbles: Highlight in chains [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/150207 [17:32:14] (03Merged) 10jenkins-bot: startup: Blacklist Opera < 12 [core] - 10https://gerrit.wikimedia.org/r/156039 (owner: 10Krinkle) [17:36:06] (03PS1) 10Umherirrender: Add missing '()' to some release notes [core] - 10https://gerrit.wikimedia.org/r/156152 [17:36:12] (03CR) 10Jforrester: "I think having Grade A and Grade B makes a lot more sense than the situation this documents…" [core] - 10https://gerrit.wikimedia.org/r/156040 (owner: 10Krinkle) [17:40:01] 3Wikimedia / 3Media storage: Swift outage caused a bunch of moved files to be "inconsistent" and "missing" - 10https://bugzilla.wikimedia.org/69311#c10 (10Greg Grossmeier) (In reply to Filippo Giunchedi from comment #9) > Greg: at wikimania I asked Aaron the context for this and a preliminary > script to fin... [17:40:18] 3MediaWiki / 3General/Unknown: When special pages are included, OutputPage::$mPreventClickjacking is not respected - 10https://bugzilla.wikimedia.org/65778 (10Chris Steipp) a:5security>3None [17:42:29] (03PS7) 10Isarra: Add support for enabling and displaying global interwikis [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/147755 (https://bugzilla.wikimedia.org/68241) [17:44:35] (03CR) 10Helder.wiki: Add es5-shim library v3.4.0 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/139308 (owner: 10Jforrester) [17:51:35] (03CR) 10AndyRussG: [C: 032] "Looks good!" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/154794 (https://bugzilla.wikimedia.org/69579) (owner: 10Prtksxna) [17:52:00] (03Merged) 10jenkins-bot: Remove preventDefault from settings.open [extensions/Popups] - 10https://gerrit.wikimedia.org/r/154794 (https://bugzilla.wikimedia.org/69579) (owner: 10Prtksxna) [17:53:31] (03CR) 10Chmarkine: [C: 031] Use protocol relative URLs for links with https [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/154031 (owner: 10Prtksxna) [17:57:36] (03PS2) 10Bsitu: Remove 'View Board' from all Flow notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155653 [17:59:55] (03CR) 10Ebe123: Add option to hide and unhide file thumbnails in file history (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156048 (https://bugzilla.wikimedia.org/69053) (owner: 10Ebe123) [18:00:02] (03PS2) 10Ebe123: Add option to hide and unhide file thumbnails in file history [core] - 10https://gerrit.wikimedia.org/r/156048 (https://bugzilla.wikimedia.org/69053) [18:03:56] (03PS3) 10Bsitu: Remove 'View Board' from all Flow notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155653 [18:05:06] (03CR) 10Jdlrobson: [C: 032] i18n: get rid of hardcoded 'reply' text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156094 (owner: 10Matthias Mullie) [18:05:10] (03CR) 10jenkins-bot: [V: 04-1] i18n: get rid of hardcoded 'reply' text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156094 (owner: 10Matthias Mullie) [18:06:42] (03CR) 10Jdlrobson: [C: 04-1] "Really if a commit message says "get rid of hardcoded 'x comments' " it should not introduce any more hardcoding." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156095 (owner: 10Matthias Mullie) [18:08:16] (03CR) 10Jdlrobson: [C: 04-1] i18n: properly translate list of topic participants (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156096 (owner: 10Matthias Mullie) [18:09:21] (03Abandoned) 10Jdlrobson: i18n: Translate reply button [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155857 (owner: 10Jdlrobson) [18:09:37] (03CR) 10Jdlrobson: i18n: Translate reply button (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155857 (owner: 10Jdlrobson) [18:11:33] 3Wikimedia / 3Extension setup: Run 1 month test of TwitterCard extension on all wikis - 10https://bugzilla.wikimedia.org/64930#c12 (10Jared Zimmerman (WMF)) @luis, I can think of 2 options, I don't know how possible either are… 1. modify the image, add a footer which contains the basic licensing req. as a w... [18:11:34] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Investigate indexing slow log - 10https://bugzilla.wikimedia.org/69923 (10Nik Everett) 5NEW>3RESO/FIX [18:12:41] (03PS1) 10Physikerwelt: MathML in default style [extensions/Math] - 10https://gerrit.wikimedia.org/r/156154 [18:13:32] (03PS1) 10Umherirrender: Simplify checks on Special:UserLogin/signup [core] - 10https://gerrit.wikimedia.org/r/156155 [18:15:07] (03PS1) 10Jdlrobson: Hygiene: i18n file Remove whitespace before colons [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156156 [18:15:12] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: i18n file Remove whitespace before colons [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156156 (owner: 10Jdlrobson) [18:25:54] (03PS1) 10Umherirrender: Add tests for User::getCanonicalName() [core] - 10https://gerrit.wikimedia.org/r/156159 [18:32:39] (03PS2) 10Umherirrender: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/156149 [18:32:48] (03PS3) 10Jdlrobson: i18n the time messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155670 [18:33:12] (03CR) 10jenkins-bot: [V: 04-1] i18n the time messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155670 (owner: 10Jdlrobson) [18:34:28] (03PS2) 10Jdlrobson: Hygiene: i18n file Remove whitespace before colons [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156156 [18:34:37] (03PS4) 10Jdlrobson: i18n the time messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155670 [18:34:48] (03PS5) 10Jdlrobson: WIP: i18n the time messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155670 [18:35:38] (03Abandoned) 10Jdlrobson: Hygiene: Alphabetise the i18n file. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155669 (owner: 10Jdlrobson) [18:38:21] (03PS6) 10Jdlrobson: i18n the time messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155670 [18:46:56] (03PS7) 10Jdlrobson: i18n the time messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155670 [18:46:59] (03PS4) 10Jdlrobson: Hygiene: Standardise on time i10n parameter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155672 [18:47:31] (03CR) 10jenkins-bot: [V: 04-1] i18n the time messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155670 (owner: 10Jdlrobson) [18:47:48] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Standardise on time i10n parameter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155672 (owner: 10Jdlrobson) [18:52:00] (03CR) 10Legoktm: "I filed RT #8198 about getting access to the 'mediawiki' packagist.org credentials." [skins/Vector] - 10https://gerrit.wikimedia.org/r/152927 (owner: 10Mwjames) [18:53:36] (03CR) 10Jdlrobson: [C: 04-1] "Update browser tests and rebase," [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155214 (owner: 10SG) [18:54:14] (03PS3) 10Manybubbles: Send groovy script for updates to limit changes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/155339 [18:54:16] (03CR) 10jenkins-bot: [V: 04-1] Send groovy script for updates to limit changes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/155339 (owner: 10Manybubbles) [18:55:25] (03PS4) 10Manybubbles: Send groovy script for updates to limit changes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/155339 [18:56:07] (03PS1) 10SG: Use mw-ui-anchor from Core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156162 [18:56:16] (03CR) 10SG: [C: 04-2] Use mw-ui-anchor from Core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156162 (owner: 10SG) [19:00:25] (03PS3) 10Jdlrobson: i18n: Allow translation of participants and comment_count [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155827 [19:01:00] (03CR) 10jenkins-bot: [V: 04-1] i18n: Allow translation of participants and comment_count [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155827 (owner: 10Jdlrobson) [19:14:50] (03PS3) 10Jack Phoenix: Readd CAPTCHA (ConfirmEdit extension) support [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/156052 (https://bugzilla.wikimedia.org/66811) [19:16:07] 3MediaWiki extensions / 3SemanticForms: Edit loss when used with Wikieditor - 10https://bugzilla.wikimedia.org/69902#c2 (10Grégoire) Hi, Thanks for your answer. I managed to reproduce the issue on a freshly installed mediawiki. - Go to http://wiki.zjyto.net/w/index.php?title=Bug - Click Edit - Click Previe... [19:16:32] (03PS7) 10Hashar: Add jobs for wikibase [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156114 (owner: 10Addshore) [19:17:46] (03CR) 10Hashar: [C: 031] "Updated commit summary message to reflect jobs being created/updated. Ran Jenkins job builder:" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156114 (owner: 10Addshore) [19:22:25] (03CR) 10Hashar: [C: 04-1] Add jobs for wikibase (031 comment) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156114 (owner: 10Addshore) [19:24:59] (03PS8) 10Addshore: Add jobs for wikibase [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156114 [19:27:24] (03PS9) 10Addshore: Add jobs for wikibase [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156114 [19:28:01] (03PS10) 10Hashar: Add jobs for wikibase [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156114 (owner: 10Addshore) [19:28:37] (03PS4) 10Jdlrobson: WIP: i18n: Allow translation of participants and comment_count [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155827 [19:28:46] (03CR) 10Hashar: "$ jenkins-jobs --conf jenkins_jobs.ini update config/ mwext-Wikibase-client-tests" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156114 (owner: 10Addshore) [19:28:58] (03CR) 10Hashar: [C: 032] WIP add new zuul triggers for new wikidata jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156120 (owner: 10Addshore) [19:29:03] (03CR) 10Jdlrobson: "I've modified my patch to kill the flowMessage usage" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156096 (owner: 10Matthias Mullie) [19:29:36] (03CR) 10Jdlrobson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155670 (owner: 10Jdlrobson) [19:30:11] (03CR) 10Dduvall: [C: 04-1] "I like what you're trying to accomplish here, but I'm not sure that splitting roles is the best pattern. Not only is it confusing to have " [vagrant] - 10https://gerrit.wikimedia.org/r/155861 (owner: 10MaxSem) [19:30:27] (03CR) 10Legoktm: "They can either use database access if the source is on the same host, or use the API if it's external. My point is that ResourceLoader sh" [core] - 10https://gerrit.wikimedia.org/r/156083 (https://bugzilla.wikimedia.org/69878) (owner: 10Legoktm) [19:31:19] (03CR) 10Isarra: [C: 032] "Could use a proper description, but without knowing what it actually is, that's a bit harder." [skins/Schulenburg] - 10https://gerrit.wikimedia.org/r/155770 (owner: 10Lewis Cawte) [19:31:21] (03Merged) 10jenkins-bot: Add extension credits. [skins/Schulenburg] - 10https://gerrit.wikimedia.org/r/155770 (owner: 10Lewis Cawte) [19:31:30] (03Merged) 10jenkins-bot: WIP add new zuul triggers for new wikidata jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156120 (owner: 10Addshore) [19:31:33] (03CR) 10jenkins-bot: [V: 04-1] WIP: i18n: Allow translation of participants and comment_count [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155827 (owner: 10Jdlrobson) [19:34:51] (03PS1) 10Jack Phoenix: New skin from ShoutWiki, based on a WordPress theme with the same name [skins/Bouquet] - 10https://gerrit.wikimedia.org/r/156166 [19:35:29] (03CR) 10Jdlrobson: [C: 032] Remove 'View Board' from all Flow notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155653 (owner: 10Bsitu) [19:35:47] (03CR) 10MaxSem: "I also consider it extremely disruptive everything Cirrus BTs inflict on me without asking when I enable this role - it prevents me from d" [vagrant] - 10https://gerrit.wikimedia.org/r/155861 (owner: 10MaxSem) [19:35:56] marxarelli, ^ [19:36:07] (03Merged) 10jenkins-bot: Remove 'View Board' from all Flow notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155653 (owner: 10Bsitu) [19:36:43] (03PS3) 10Addshore: Add script used by wikidatajenkins [integration/jenkins] - 10https://gerrit.wikimedia.org/r/156110 [19:38:12] (03PS1) 10Jack Phoenix: New skin from ShoutWiki, based on a WordPress theme with the same name [skins/DeskMessMirrored] - 10https://gerrit.wikimedia.org/r/156167 [19:39:07] (03CR) 10MaxSem: "I wonder how soon it will be when those settings will startg to actually conflict each other, e.g. Cirrus wants to disable capital links w" [vagrant] - 10https://gerrit.wikimedia.org/r/155861 (owner: 10MaxSem) [19:40:09] (03CR) 10Manybubbles: "In cirrus's case if we split it into two roles it'd be more like:" [vagrant] - 10https://gerrit.wikimedia.org/r/155861 (owner: 10MaxSem) [19:41:04] (03CR) 10Manybubbles: "I'm with Max - I support splitting Cirrus into two roles. If you are doing Cirrus development you get cursed with funky settings. If you" [vagrant] - 10https://gerrit.wikimedia.org/r/155861 (owner: 10MaxSem) [19:41:18] (03CR) 10Legoktm: [C: 04-1] New skin from ShoutWiki, based on a WordPress theme with the same name (034 comments) [skins/Bouquet] - 10https://gerrit.wikimedia.org/r/156166 (owner: 10Jack Phoenix) [19:43:56] (03PS1) 10Jack Phoenix: New skin from ShoutWiki, based on a WordPress theme with the same name [skins/DuskToDawn] - 10https://gerrit.wikimedia.org/r/156168 [19:45:19] (03CR) 10AndyRussG: "The only possible issue that I can think of is the order of execution of JS code. (Apologies if you've already got this covered.) I was ju" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/153588 (owner: 10Prtksxna) [19:46:16] (03CR) 10Legoktm: "My -1 was mainly for using globals instead of Config, but Jack says this is intended for 1.23 which can't use that yet." [skins/Bouquet] - 10https://gerrit.wikimedia.org/r/156166 (owner: 10Jack Phoenix) [19:47:38] legoktm: Is the JS blacklist (or whatever it is that blocks JS for browsers) a MW feature or Foundation magic? [19:47:48] it's in core [19:48:05] the startup module [19:48:35] Lcawte: https://github.com/wikimedia/mediawiki-core/blob/master/resources/src/startup.js#L27 [19:48:36] (03CR) 10Dduvall: "Fair point, and perhaps some extension settings _should_ go into the role—those that aren't necessary for the basic functionality of the e" [vagrant] - 10https://gerrit.wikimedia.org/r/155861 (owner: 10MaxSem) [19:49:18] legoktm: Ok, thanks :) [19:49:20] (03PS1) 10Addshore: Split mw-run-update-script from mw-setup-extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156170 [19:50:18] (03PS1) 10Jack Phoenix: New skin from ShoutWiki, based on a WordPress theme with the same name [skins/Gamepress] - 10https://gerrit.wikimedia.org/r/156171 [19:51:13] (03PS11) 10Addshore: Add jobs for wikibase [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156114 [19:51:17] (03CR) 10Brian Wolff: "I wonder if we should just hard code the jpeg quality to a higher number. As it stands we get a lot of ugly artifacts (Realistically, it p" [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/133121 (owner: 10Scnd) [19:52:06] (03PS2) 10Krinkle: Add missing '()' to some release notes [core] - 10https://gerrit.wikimedia.org/r/156152 (owner: 10Umherirrender) [19:52:11] (03CR) 10Krinkle: [C: 032] Add missing '()' to some release notes [core] - 10https://gerrit.wikimedia.org/r/156152 (owner: 10Umherirrender) [19:52:30] (03CR) 10Krinkle: [C: 031] Remove usage of deprecated Xml::escapeJsString [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/147712 (owner: 10PleaseStand) [19:54:06] (03CR) 10Krinkle: "Hm.. is it useful to pass the global singleton? Seems a lot of boilerplate that is just the default value." [core] - 10https://gerrit.wikimedia.org/r/155869 (owner: 10Legoktm) [19:55:25] (03CR) 10Hashar: [C: 032] "Wikidata related thing. Lets merge that in :)" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/156110 (owner: 10Addshore) [19:55:28] (03Merged) 10jenkins-bot: Add script used by wikidatajenkins [integration/jenkins] - 10https://gerrit.wikimedia.org/r/156110 (owner: 10Addshore) [19:56:06] 3MediaWiki extensions / 3MassMessage: MassMessage: Please include an easy way to mark the language (and language direction: LTR vs RTL) for a message - 10https://bugzilla.wikimedia.org/68512#c4 (10WhatamIdoing) Since my own talk pages haven't been broken by someone sending unmarked messages, then I'm willin... [19:57:05] 3MediaWiki extensions / 3MassMessage: MassMessage blanks the body of the message (but not list of recipients or subject message) upon preview—but only if my name is in the message content! - 10https://bugzilla.wikimedia.org/61926#c3 (10WhatamIdoing) This still happens to me every time I use MassMessage. As... [19:57:59] (03PS1) 10Jack Phoenix: New skin from ShoutWiki's SVN [skins/Truglass] - 10https://gerrit.wikimedia.org/r/156172 [19:58:43] (03Merged) 10jenkins-bot: Add missing '()' to some release notes [core] - 10https://gerrit.wikimedia.org/r/156152 (owner: 10Umherirrender) [19:58:52] (03PS1) 10BryanDavis: hhvm logging and abi improvements [vagrant] - 10https://gerrit.wikimedia.org/r/156173 [19:59:42] (03CR) 10Scnd: [C: 031] "Please no. I now use 100%. In core it's hardcoded and it's terrible. I should, on every update, edit includes/ImagePage.php and set jpeg q" [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/133121 (owner: 10Scnd) [20:00:21] (03CR) 10Hashar: [C: 04-1] "This change is essentially a noop but change two qunit-mobile jobs:" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156170 (owner: 10Addshore) [20:00:30] (03PS1) 10BryanDavis: centralauth: Give 'crats centralauth-rename rights [vagrant] - 10https://gerrit.wikimedia.org/r/156174 [20:00:52] AaronSchulz, yt? [20:01:07] Reedy: for https://bugzilla.wikimedia.org/show_bug.cgi?id=46141 can you just set the db to read_write mode [20:02:03] (03CR) 10Legoktm: "Yes, because ResourceLoader should not be aware of which Config object it is getting (right now it specifies 'main'). And eventually in th" [core] - 10https://gerrit.wikimedia.org/r/155869 (owner: 10Legoktm) [20:03:05] (03PS1) 10Addshore: -xe for wdj-apply-settings [integration/jenkins] - 10https://gerrit.wikimedia.org/r/156176 [20:03:44] (03CR) 10Legoktm: centralauth: Give 'crats centralauth-rename rights (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/156174 (owner: 10BryanDavis) [20:05:20] (03CR) 10BryanDavis: centralauth: Give 'crats centralauth-rename rights (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/156174 (owner: 10BryanDavis) [20:05:29] (03CR) 10Krinkle: [C: 031] "Sure, we don't need it for RL in core. But, to answer your concern for overhead: We do the same for InstantCommons (uses API). We don't gi" [core] - 10https://gerrit.wikimedia.org/r/156083 (https://bugzilla.wikimedia.org/69878) (owner: 10Legoktm) [20:05:45] (03CR) 10Dduvall: "IMHO, browser tests should be deterministic enough to point to any endpoint that implements the respective features and accessible enough " [vagrant] - 10https://gerrit.wikimedia.org/r/155861 (owner: 10MaxSem) [20:06:55] (03CR) 10Bartosz Dziewoński: [C: 032] New skin from ShoutWiki's SVN [skins/Truglass] - 10https://gerrit.wikimedia.org/r/156172 (owner: 10Jack Phoenix) [20:06:57] (03Merged) 10jenkins-bot: New skin from ShoutWiki's SVN [skins/Truglass] - 10https://gerrit.wikimedia.org/r/156172 (owner: 10Jack Phoenix) [20:07:03] (03CR) 10MaxSem: "You realise that not everyone who has an extension running is actually developing it so they don't need to run its tests?" [vagrant] - 10https://gerrit.wikimedia.org/r/155861 (owner: 10MaxSem) [20:07:47] (03CR) 10Bartosz Dziewoński: [C: 032 V: 032] New skin from ShoutWiki, based on a WordPress theme with the same name [skins/Bouquet] - 10https://gerrit.wikimedia.org/r/156166 (owner: 10Jack Phoenix) [20:07:51] (03CR) 10Bartosz Dziewoński: [C: 032 V: 032] New skin from ShoutWiki, based on a WordPress theme with the same name [skins/DuskToDawn] - 10https://gerrit.wikimedia.org/r/156168 (owner: 10Jack Phoenix) [20:07:56] (03CR) 10Bartosz Dziewoński: [C: 032 V: 032] New skin from ShoutWiki, based on a WordPress theme with the same name [skins/DeskMessMirrored] - 10https://gerrit.wikimedia.org/r/156167 (owner: 10Jack Phoenix) [20:08:21] (03CR) 10Bartosz Dziewoński: [C: 032 V: 032] New skin from ShoutWiki, based on a WordPress theme with the same name [skins/Gamepress] - 10https://gerrit.wikimedia.org/r/156171 (owner: 10Jack Phoenix) [20:08:32] (03CR) 10Frédéric Wang: MathML in default style (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/156154 (owner: 10Physikerwelt) [20:09:14] (03PS2) 10Physikerwelt: MathML in default style [extensions/Math] - 10https://gerrit.wikimedia.org/r/156154 [20:10:07] (03CR) 10Hashar: [C: 04-1] "make it chmod +x while at it :]" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/156176 (owner: 10Addshore) [20:11:16] (03PS2) 10Hashar: -xe for wdj-apply-settings [integration/jenkins] - 10https://gerrit.wikimedia.org/r/156176 (owner: 10Addshore) [20:11:19] (03CR) 10Dduvall: "Which is exactly why I support this refactoring albeit in a different way. :)" [vagrant] - 10https://gerrit.wikimedia.org/r/155861 (owner: 10MaxSem) [20:11:24] (03CR) 10Frédéric Wang: [C: 032] MathML in default style [extensions/Math] - 10https://gerrit.wikimedia.org/r/156154 (owner: 10Physikerwelt) [20:12:19] (03Merged) 10jenkins-bot: MathML in default style [extensions/Math] - 10https://gerrit.wikimedia.org/r/156154 (owner: 10Physikerwelt) [20:13:36] (03CR) 10MaxSem: "Nope, there are also trying out, using Labs-Vagrant and writing something that has no role (yet) use cases ;) Labs-Vagrant is especially a" [vagrant] - 10https://gerrit.wikimedia.org/r/155861 (owner: 10MaxSem) [20:14:04] (03CR) 10BryanDavis: "> Is that a bad assumption to make?" [vagrant] - 10https://gerrit.wikimedia.org/r/155861 (owner: 10MaxSem) [20:14:58] (03PS3) 10Awight: Use the verbose re flag to unminify the email_filter [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/151249 [20:15:05] (03PS12) 10Addshore: Add jobs for wikibase [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156114 [20:15:08] (03CR) 10jenkins-bot: [V: 04-1] Use the verbose re flag to unminify the email_filter [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/151249 (owner: 10Awight) [20:17:26] (03PS3) 10Addshore: -xe shebang and +x for wdj-apply-settings [integration/jenkins] - 10https://gerrit.wikimedia.org/r/156176 [20:17:33] (03CR) 10Addshore: [C: 031] -xe shebang and +x for wdj-apply-settings [integration/jenkins] - 10https://gerrit.wikimedia.org/r/156176 (owner: 10Addshore) [20:17:36] (03CR) 10Hashar: "deployed:" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156114 (owner: 10Addshore) [20:18:18] (03PS3) 10Awight: Sort the email_filter literal [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/151250 [20:18:21] (03PS4) 10Awight: Use the verbose re flag to unminify the email_filter [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/151249 [20:20:49] 3MediaWiki / 3Uploading: Special uploadtext for the reupload form - 10https://bugzilla.wikimedia.org/17194#c2 (10Lupo) André, just close this. It's a 5-year-old "bug"; I don't remember what that was about. Apparently at one time this didn't work. If it works now it's just a worksforme closure. [20:20:55] (03PS1) 10Awight: DonationInterface passes jslint now [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156179 [20:21:16] (03PS1) 10Jack Phoenix: Madness? Madness?! THIS IS MEDIAWIKI! [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/156180 [20:21:23] (03PS2) 10Awight: DonationInterface passes jslint now [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156179 [20:22:57] Wondering, how do we trigger "grunt test" jobs from zuul? Is that rolled into jslint? [20:23:53] (03CR) 10Brian Wolff: "ok, good enough for me. Could the default value be 92, as I believe that's what im uses if unspecified?" (031 comment) [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/133121 (owner: 10Scnd) [20:24:13] (03CR) 10Bartosz Dziewoński: [C: 04-1] "A brief note about what is going on would be helpful." [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/156180 (owner: 10Jack Phoenix) [20:24:40] (03CR) 10Dduvall: "> Today I'm not sure how to accomplish that other than the way that Max is attempting here." [vagrant] - 10https://gerrit.wikimedia.org/r/155861 (owner: 10MaxSem) [20:24:54] (03PS13) 10Addshore: Add jobs for wikibase [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156114 [20:25:01] I found the wmfgrunt wrapper, but don't see how that is invoked in "test" mode from macro.yaml, I only see grunt run in csslint and qunit modes. [20:25:42] what exactly is "nukeEntries.php" used for [20:28:33] where is it? [20:29:29] James_F: We finally merged your generous grunt fixes to DonationInterface--but that leaves me wondering whether we have a zuul job that invokes "grunt test"? [20:30:03] bawolff! I was looking for you earlier...I seem to remember you understand how the parser cache works? [20:30:20] I sort of understand [20:30:29] could you take a look at https://gerrit.wikimedia.org/r/#/c/154981/ ? [20:32:06] (03CR) 10tosfos: [C: 032] "Thanks! I was +1-ing to show I was done with the patches. :)" [extensions/GoogleCustomWikiSearch] - 10https://gerrit.wikimedia.org/r/155616 (owner: 10tosfos) [20:32:14] (03Merged) 10jenkins-bot: Inherit ContextSource [extensions/GoogleCustomWikiSearch] - 10https://gerrit.wikimedia.org/r/155616 (owner: 10tosfos) [20:32:30] where is what [20:32:49] (03CR) 10BryanDavis: "Yeah, hiera can do "role::cirrussearch::browser_tests: false" stuff. Then the roll could have an if block to hold the extra bits. It might" [vagrant] - 10https://gerrit.wikimedia.org/r/155861 (owner: 10MaxSem) [20:32:55] legoktm: looking [20:33:16] Withoutaname: nukeEntries.php - I've never heard of it, and couldn't find it [20:33:25] thanks! [20:33:25] (03CR) 10Bartosz Dziewoński: "Also, 906bb7795f0d98950f17fc902fadfe069dca42b4 in EducationProgram should probably be merged first unless we want fatals. I found no other" [core] - 10https://gerrit.wikimedia.org/r/155903 (owner: 10Bartosz Dziewoński) [20:33:32] oh its in mediawiki/extensions/WikimediaMaintenance [20:34:07] (03CR) 10Legoktm: [C: 032] ArticleTable: Remove useless getBody() override [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/155897 (owner: 10Bartosz Dziewoński) [20:34:20] (03Merged) 10jenkins-bot: ArticleTable: Remove useless getBody() override [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/155897 (owner: 10Bartosz Dziewoński) [20:35:23] all it does is print a bunch of stuff [20:35:37] I don't see how wfMessage( "pagetitle" )->text() is supposed to nuke anything [20:35:54] (03PS6) 10Bartosz Dziewoński: TablePager: Modernize style loading [core] - 10https://gerrit.wikimedia.org/r/155903 [20:36:09] (03PS14) 10Hashar: Add jobs for wikibase [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156114 (owner: 10Addshore) [20:36:42] looks like some performance script [20:37:03] er, performance measuring* [20:37:12] 3Mathoid / 3General/Unknown: Create production Mathoid instance - 10https://bugzilla.wikimedia.org/69989 (10physikerwelt) 3NEW p:3Unprio s:3normal a:3None Similar to https://gerrit.wikimedia.org/r/#/c/148836/16 that defines a puppet role Mathoid in beta we need to create a puppet role for producti... [20:37:24] (03CR) 10Krinkle: [C: 04-1] "See inline comment." [core] - 10https://gerrit.wikimedia.org/r/156083 (https://bugzilla.wikimedia.org/69878) (owner: 10Legoktm) [20:37:29] then it should be renamed, it's not nuking anything [20:40:24] 3Mathoid / 3General/Unknown: Assign a machine Mathoid rendering in production - 10https://bugzilla.wikimedia.org/69990 (10physikerwelt) 3NEW p:3Unprio s:3normal a:3None To use mathoid in production we can not use the newly created mathoid instance on beta. This might lead to a DOS attack from product... [20:41:49] 3Mathoid / 3General/Unknown: Assign a machine Mathoid rendering in production - 10https://bugzilla.wikimedia.org/69990 (10physikerwelt) [20:41:49] (03CR) 1020after4: "@rush so the dropdown works with herald? I was under the impression that select fields were not quite herald compatible... Is that just ra" [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/154850 (owner: 10Rush) [20:41:52] 3Mathoid / 3General/Unknown: Create production Mathoid instance - 10https://bugzilla.wikimedia.org/69989 (10physikerwelt) [20:43:35] (03CR) 10Rush: "we are cheating and checking the custom fields value manually instead of having say an extension per-select-field-option. Since we can fi" [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/154850 (owner: 10Rush) [20:45:08] 3Mathoid / 3General/Unknown: Decide on deployment strategy for Mathoid in production - 10https://bugzilla.wikimedia.org/69992 (10physikerwelt) 3NEW p:3Unprio s:3normal a:3None In betalabs mathoid is deployed manually. In this bug it should be discussed if the deployment will be done with the same mec... [20:46:41] 3Mathoid / 3General/Unknown: Decide on deployment strategy for Mathoid in production - 10https://bugzilla.wikimedia.org/69992 (10physikerwelt) [20:46:41] 3Mathoid / 3General/Unknown: Create production Mathoid instance - 10https://bugzilla.wikimedia.org/69989 (10physikerwelt) [20:47:28] (03PS2) 10CSteipp: Make iat timestamp an int instead of string [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/133588 (https://bugzilla.wikimedia.org/65260) [20:49:26] (03PS1) 10Bartosz Dziewoński: Remove dead code for showing login form to logged-in users [core] - 10https://gerrit.wikimedia.org/r/156182 [20:49:34] (03CR) 10Bartosz Dziewoński: "(Unrelated to above bug) I just realized that this means that the code that triggered when one tried to view the login form while already " [core] - 10https://gerrit.wikimedia.org/r/148144 (https://bugzilla.wikimedia.org/15484) (owner: 10Parent5446) [20:51:17] (03CR) 10Addshore: [C: 04-1] "going to change the way this is done :)" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/156176 (owner: 10Addshore) [20:52:58] (03PS1) 10Bsitu: Redirect to Flow view action when url action is set to edit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156183 [20:55:42] 3MediaWiki / 3Internationalization: Using variables inside plural definitions doesn't work in JavaScript - 10https://bugzilla.wikimedia.org/69993 (10Jon) 3NEW p:3Unprio s:3normal a:3None {{PLURAL:$1|$3 started this topic|A|0=B|2=C|3=$3}} > mw.msg( "flow-topic-participants", 3 ) > 'A' However {{PLURA... [20:55:51] (03PS2) 10Bsitu: Redirect to Flow view action when url action is set to edit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156183 (https://bugzilla.wikimedia.org/69879) [20:56:06] (03PS15) 10Addshore: Add jobs for wikibase [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156114 [20:57:29] (03CR) 10Anomie: [C: 032] Make iat timestamp an int instead of string [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/133588 (https://bugzilla.wikimedia.org/65260) (owner: 10CSteipp) [20:57:35] (03Merged) 10jenkins-bot: Make iat timestamp an int instead of string [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/133588 (https://bugzilla.wikimedia.org/65260) (owner: 10CSteipp) [20:58:28] (03PS5) 10Jdlrobson: WIP: i18n: Allow translation of participants and comment_count [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155827 [20:59:13] (03CR) 10jenkins-bot: [V: 04-1] WIP: i18n: Allow translation of participants and comment_count [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155827 (owner: 10Jdlrobson) [20:59:52] (03CR) 10Brian Wolff: [C: 032] "looks good to me" [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154981 (https://bugzilla.wikimedia.org/68603) (owner: 10Legoktm) [21:00:03] \o/ [21:00:06] thanks! [21:00:22] legoktm: Although i did get a bunch of debug warnings about something wrong with the alias file [21:00:22] (03Merged) 10jenkins-bot: Add parser cache support to MassMessageListContent [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154981 (https://bugzilla.wikimedia.org/68603) (owner: 10Legoktm) [21:00:24] 3MediaWiki extensions / 3OAuth: Issued at time should be returned as a number - 10https://bugzilla.wikimedia.org/65260#c3 (10Brad Jorsch) 5PATC>3RESO/FIX This should be deployed to WMF wikis with 1.24wmf19, see https://www.mediawiki.org/wiki/MediaWiki_1.24/Roadmap for the schedule. [21:00:40] oh [21:01:01] bawolff: does your wiki have $wgContentHandlerUseDB = false? [21:01:54] no, its true [21:02:02] I haven't changed it from default [21:02:32] hm [21:03:47] (03CR) 10Jdlrobson: [C: 04-1] Change mw-ui anchors to require mw-ui-anchor base class (031 comment) [core] - 10https://gerrit.wikimedia.org/r/155856 (owner: 10SG) [21:03:47] The alias thing looks like just a typo [21:04:12] writing 'CreateMassMessage' => array( 'CreateMassMessage' ), where it should be 'CreateMassMessageList' => array( 'CreateMassMessage' ), [21:05:03] (03CR) 10Parent5446: [C: 031] Remove dead code for showing login form to logged-in users [core] - 10https://gerrit.wikimedia.org/r/156182 (owner: 10Bartosz Dziewoński) [21:05:46] (03CR) 10Spage: [C: 04-1] "Comment it, and/or needs a better way." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/155832 (https://bugzilla.wikimedia.org/69926) (owner: 10SG) [21:05:57] ah [21:05:59] * legoktm fixes [21:06:37] (03PS1) 10Legoktm: Fix aliases for CreateMassMessageList and EditMassMessageList [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/156186 [21:06:42] bawolff: ^ [21:06:57] oh we're at bug 69993. I need to find something to create :D [21:07:06] (03CR) 10Brian Wolff: [C: 032] Fix aliases for CreateMassMessageList and EditMassMessageList [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/156186 (owner: 10Legoktm) [21:07:22] Krenair: "Review and deploy Gadgets 2.0" ;) [21:07:31] (03Merged) 10jenkins-bot: Fix aliases for CreateMassMessageList and EditMassMessageList [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/156186 (owner: 10Legoktm) [21:07:36] legoktm, heh [21:07:38] (03PS16) 10Addshore: Add jobs for wikibase [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156114 [21:08:11] legoktm, actually will we need an extra review for that? It won't be a new extension... [21:08:27] we should because it's a major re-write [21:08:55] probably, yeah [21:08:58] I guess that's just the gadgets 2.0 tracking bug though [21:08:58] hm [21:09:57] "Migrate all bugzilla bugs to phabricator" [21:09:57] (03PS17) 10Addshore: Add jobs for wikibase [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156114 [21:10:20] "MediaWiki 2.0 (tracking)" [21:10:37] oh that's perfect. [21:14:46] (03CR) 10Legoktm: "Won't this lose parameters like &fromnotif=1 ? Why not just make the EditAction the same as ViewAction so users who go to ?action=edit jus" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156183 (https://bugzilla.wikimedia.org/69879) (owner: 10Bsitu) [21:19:56] (03PS1) 10Withoutaname: Try to make renameWiki.php actually work [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/156189 (https://bugzilla.wikimedia.org/46141) [21:20:08] bd808, I just updated the page at https://www.mediawiki.org/wiki/MediaWiki-Vagrant [21:20:37] Visual editor is a pain. :/ [21:21:16] renoirb: Thanks for the edits! [21:21:49] (03PS1) 10Isarra: Cleanup special:interwiki intro (some more) [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/156190 [21:22:40] awight: Oh, awesome! [21:23:03] James_F: sorry to allow your work to languish until now! [21:23:05] awight: Yeah, it'll need a small amount of work in Jenkins and Zuul config repositories. [21:23:11] Wonder how I can configure Vagrantfile settings now though. you know how bd808 ? [21:23:18] awight: No worries at all. Other things take priority. :-) [21:23:24] James_F: yeah, it seems like there is no model of grunt test? [21:23:32] renoirb: should be able to use `vagrant config` ? [21:23:32] renoirb: `vagrant config --list`? [21:23:39] oh! right [21:23:45] otherwise, .setting.yaml is editable [21:23:51] or .settings.yaml? i dunno [21:24:02] awight: One moment. [21:24:15] this is so nice! [21:25:10] Right, but its not options so I can setup more than one mediawiki vagrant side by side :/ [21:25:19] not running in the same time though, but still. [21:25:32] (03CR) 10Bsitu: "This would require adding an edit action to a Flow block, otherwise this would throw a 'No block accepts edit action' exception. A redire" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156183 (https://bugzilla.wikimedia.org/69879) (owner: 10Bsitu) [21:25:35] James_F: I did find wmfgrunt, which is a generalized wrapper. But no projects seem to use "test" yet [21:26:41] renoirb: Ah. You should be able to make a Vagrantfile-extra.rb and it will be loaded at the end of the normal Vagrantfile [21:26:52] Side by side? [21:27:22] cp -R vagrant vagrant2; cd vagrant2; vagrant up [21:27:45] Is that what you mean? I have 4+ vagrant checkouts on my laptop [21:27:57] doing different things [21:28:31] (mw dev, deploy tools dev, mwv testing, other dev) [21:28:45] renoirb: if you want another vagrant install side by side just make a new checkout as bd808 mentioned [21:28:56] right. [21:29:04] But two VMs with the same name creates conflicts [21:29:25] wait, i didnt tried if it does with wmf vagrant [21:29:28] hostname? can probably move that into settings [21:29:38] no VM name in virtualbox [21:30:00] sorry, let me double check instead of chickening based on past experiences :) [21:30:00] vbox takes name from directory + a hash [21:30:32] You will have port conflicts that need to managed with `vagrant config` [21:31:08] awight: Yah, wmfgrunt isn't used I think. [21:31:25] (03PS1) 10Jforrester: Configure npm pipeline for DonationInterface [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156193 [21:31:29] James_F: well, there are some invocations in macro.yaml [21:32:40] I'm so sorry to disturb on that last one, it allows more than one VM. Its when you specify manually the name that it does the problem. Clearly you handled that possibility [21:32:51] (03PS1) 10Jforrester: Enable -npm pipeline voting for DonationInterface repo [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156194 [21:32:59] awight: Huh, there are? [21:33:01] * James_F looks. [21:33:21] ^d, are you there? [21:34:08] <^d> renoirb: I am, yes. [21:34:10] bd808 told me that I should ping you regarding project attributions. I am about to push updates on a few webplatform extensions and IIRC, I have not all required permissions [21:34:17] s/permissions/rights/ [21:34:19] awight|mtgjakt: Anyway, those two ^^^ are what you need, I think. [21:34:33] (03PS1) 10Physikerwelt: Prevent Special:MathShowImage from showing bad content [extensions/Math] - 10https://gerrit.wikimedia.org/r/156195 (https://bugzilla.wikimedia.org/69693) [21:34:45] (03PS2) 10BryanDavis: hhvm logging and abi improvements [vagrant] - 10https://gerrit.wikimedia.org/r/156173 [21:35:06] (03CR) 10Jforrester: "The pipeline was defined in Ib0d0f6c8, now merged." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156193 (owner: 10Jforrester) [21:35:22] (03CR) 10Jforrester: "The pipeline is configured in I8318fc49 which is not yet merged." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156194 (owner: 10Jforrester) [21:38:14] (03PS1) 10Addshore: Remove wdj-apply-settings.sh [integration/jenkins] - 10https://gerrit.wikimedia.org/r/156197 [21:38:33] (03Abandoned) 10Addshore: -xe shebang and +x for wdj-apply-settings [integration/jenkins] - 10https://gerrit.wikimedia.org/r/156176 (owner: 10Addshore) [21:41:50] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Please add documentation to your new functions to nake clear what parameters they take, what they do and what they return." [core] - 10https://gerrit.wikimedia.org/r/156048 (https://bugzilla.wikimedia.org/69053) (owner: 10Ebe123) [21:42:35] (03CR) 10BryanDavis: "FWIW, Ori's original idea with roles was that the would be specific to a development team. We have gone pretty far afield from that idea. " [vagrant] - 10https://gerrit.wikimedia.org/r/155861 (owner: 10MaxSem) [21:47:00] I have a question about an option in APC, is 240M too big% [21:47:02] ? [21:47:24] * renoirb is building an Ubuntu 14.04 VM and trying to find where I could change options [21:47:29] James_F: oh wow, thanks [21:47:49] (03CR) 10Awight: [C: 031] Enable -npm pipeline voting for DonationInterface repo [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156194 (owner: 10Jforrester) [21:48:28] (03CR) 10Awight: [C: 031] Configure npm pipeline for DonationInterface [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156193 (owner: 10Jforrester) [21:49:11] (03CR) 10Awight: [C: 032] Enable -npm pipeline voting for DonationInterface repo [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156194 (owner: 10Jforrester) [21:49:17] (03CR) 10Awight: [C: 032] Configure npm pipeline for DonationInterface [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156193 (owner: 10Jforrester) [21:49:25] (03Merged) 10jenkins-bot: Enable -npm pipeline voting for DonationInterface repo [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/156194 (owner: 10Jforrester) [21:49:33] (03CR) 10Bsitu: [C: 032] Hygiene: Move master/slave code to MWEchoDbFactory [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151272 (owner: 10EBernhardson) [21:49:49] (03CR) 10Mattflaschen: "Per S, this also needs accessibility testing. Putting it in the style guide is one way to do that. Another is adding an example commit c" [core] - 10https://gerrit.wikimedia.org/r/137888 (https://bugzilla.wikimedia.org/66138) (owner: 10Prtksxna) [21:50:03] (03Merged) 10jenkins-bot: Hygiene: Move master/slave code to MWEchoDbFactory [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151272 (owner: 10EBernhardson) [21:51:35] (03Merged) 10jenkins-bot: Configure npm pipeline for DonationInterface [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156193 (owner: 10Jforrester) [21:59:52] (03CR) 10BryanDavis: "recheck" [core] - 10https://gerrit.wikimedia.org/r/119941 (owner: 10BryanDavis) [22:06:22] (03PS3) 10Ebe123: Add option to hide and unhide file thumbnails in file history [core] - 10https://gerrit.wikimedia.org/r/156048 (https://bugzilla.wikimedia.org/69053) [22:06:25] (03CR) 10Bsitu: [C: 032] Hygiene: Move notification type detection to method (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151273 (owner: 10EBernhardson) [22:06:31] (03CR) 10Ebe123: "@Florianschmidtwelzow" [core] - 10https://gerrit.wikimedia.org/r/156048 (https://bugzilla.wikimedia.org/69053) (owner: 10Ebe123) [22:06:32] (03Merged) 10jenkins-bot: Hygiene: Move notification type detection to method [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151273 (owner: 10EBernhardson) [22:07:38] (03CR) 10Bsitu: [C: 04-1] "Jenkins is not happy about this" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155670 (owner: 10Jdlrobson) [22:08:37] (03CR) 10Bsitu: [C: 032] Hygiene: i18n file Remove whitespace before colons [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156156 (owner: 10Jdlrobson) [22:08:40] (03CR) 10Brian Wolff: [C: 032] "Lets do this!" [core] - 10https://gerrit.wikimedia.org/r/135756 (https://bugzilla.wikimedia.org/66412) (owner: 10Rillke) [22:09:01] (03CR) 10jenkins-bot: [V: 04-1] Add "chemical" major MIME type to the image tables [core] - 10https://gerrit.wikimedia.org/r/135756 (https://bugzilla.wikimedia.org/66412) (owner: 10Rillke) [22:09:09] (03Merged) 10jenkins-bot: Hygiene: i18n file Remove whitespace before colons [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156156 (owner: 10Jdlrobson) [22:09:33] (03CR) 10BryanDavis: "Bah. mediawiki-core-qunit test has not been updated to work with the vendor repo yet. So close and yet so far." [core] - 10https://gerrit.wikimedia.org/r/119941 (owner: 10BryanDavis) [22:10:09] 3MediaWiki extensions / 3OAuth: Error: bad-source-ip, tools is running on Tool Labs grid - 10https://bugzilla.wikimedia.org/69995#c4 (10metatron) And yep. it reports to api the grid-host's internal ip {"query":{"userinfo":{"id":0,"name":"10.68.17.123","anon":""}}} [22:11:39] 3MediaWiki extensions / 3OAuth: Error: bad-source-ip, tools is running on Tool Labs grid - 10https://bugzilla.wikimedia.org/69995#c5 (10Brad Jorsch) 5NEW>3RESO/INV When I hit enwiki from tools-webgrid-03, it tells me the IP address is 10.68.17.123. Thus the feature is working as intended. You might w... [22:11:41] 3MediaWiki skins / 3Vector: h4, h5, and h6 headers should not have the same styling - 10https://bugzilla.wikimedia.org/70004 (10Isarra) 3NEW p:3Unprio s:3normal a:3None Currently the h4, h5, and h6 headers are all styled with the same size and weight and subsequent apparent importance, despite being... [22:12:54] (03PS13) 10Brian Wolff: Add "chemical" major MIME type to the image tables [core] - 10https://gerrit.wikimedia.org/r/135756 (https://bugzilla.wikimedia.org/66412) (owner: 10Rillke) [22:13:30] (03CR) 10Brian Wolff: [C: 032] "PS13: rebase" [core] - 10https://gerrit.wikimedia.org/r/135756 (https://bugzilla.wikimedia.org/66412) (owner: 10Rillke) [22:13:59] (03CR) 10Bsitu: [C: 04-1] "fix qunit" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155672 (owner: 10Jdlrobson) [22:17:09] (03CR) 10Bsitu: [C: 032] Hygiene: remove unused i18n hack [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156097 (owner: 10Matthias Mullie) [22:17:46] (03Merged) 10jenkins-bot: Hygiene: remove unused i18n hack [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156097 (owner: 10Matthias Mullie) [22:18:11] 3Wikimedia / 3General/Unknown: Apply enum changes to (img|oi|fa)_major_mime on production - 10https://bugzilla.wikimedia.org/70005 (10Bawolff (Brian Wolff)) 3NEW p:3Unprio s:3normal a:3Sean Pringle With the merger of gerrit change 135756, the change to the ENUM on (img|oi|fa)_major_mime field of the... [22:18:20] (03CR) 10Brian Wolff: "Filed bug 70005 to make this happen on production." [core] - 10https://gerrit.wikimedia.org/r/135756 (https://bugzilla.wikimedia.org/66412) (owner: 10Rillke) [22:18:35] (03PS2) 10BryanDavis: centralauth: Give 'crats centralauth-rename rights [vagrant] - 10https://gerrit.wikimedia.org/r/156174 [22:19:08] (03CR) 10Legoktm: [C: 032] centralauth: Give 'crats centralauth-rename rights [vagrant] - 10https://gerrit.wikimedia.org/r/156174 (owner: 10BryanDavis) [22:19:13] (03Merged) 10jenkins-bot: centralauth: Give 'crats centralauth-rename rights [vagrant] - 10https://gerrit.wikimedia.org/r/156174 (owner: 10BryanDavis) [22:20:07] (03Merged) 10jenkins-bot: Add "chemical" major MIME type to the image tables [core] - 10https://gerrit.wikimedia.org/r/135756 (https://bugzilla.wikimedia.org/66412) (owner: 10Rillke) [22:20:30] (03PS7) 10Legoktm: Script to delete manual user global.js/css pages [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/154441 (https://bugzilla.wikimedia.org/68933) [22:20:39] (03CR) 10Legoktm: Script to delete manual user global.js/css pages (033 comments) [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/154441 (https://bugzilla.wikimedia.org/68933) (owner: 10Legoktm) [22:23:39] 3MediaWiki extensions / 3OAuth: Error: bad-source-ip, tools is running on Tool Labs grid - 10https://bugzilla.wikimedia.org/69995#c6 (10Chris Steipp) (In reply to metatron from comment #3) > Configured restriction is: > {"IPAddresses":["208.80.155.0/24","::/0"]} > and all worked until 2-4 days ago. No cha... [22:24:45] (03PS2) 10Bsitu: i18n: get rid of hardcoded 'reply' text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156094 (owner: 10Matthias Mullie) [22:29:50] (03CR) 10Bsitu: [C: 032] "Re-apply Jon's +2" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156094 (owner: 10Matthias Mullie) [22:30:23] (03Merged) 10jenkins-bot: i18n: get rid of hardcoded 'reply' text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156094 (owner: 10Matthias Mullie) [22:31:32] 3MediaWiki extensions / 3Scribunto: LuaSandbox reports substantially higher memory utilization under HHVM - 10https://bugzilla.wikimedia.org/70006 (10Ori Livneh) 3NEW p:3Unprio s:3normal a:3None Previewing a no-diff edit to the Barack Obama article on enwiki utilizes vastly more memory under HHVM tha... [22:35:43] (03PS2) 10Bsitu: i18n: get rid of hardcoded 'x comments' text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156095 (owner: 10Matthias Mullie) [22:38:11] 3Wikimedia / 3Site requests: Add "movefile" permission to "eliminator" in Japanese Wikipedia - 10https://bugzilla.wikimedia.org/70007 (10rxy) 3NEW p:3Unprio s:3normal a:3None Please add "movefile" permission to "eliminator" in Japanese Wikipedia. I got that consensus in [[w:ja:Wikipedia‐ノート:削除者]].... [22:38:55] (03PS1) 10EBernhardson: G3: Mobile/nojs edit and reply full topic output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156203 [22:39:01] (03CR) 10jenkins-bot: [V: 04-1] G3: Mobile/nojs edit and reply full topic output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156203 (owner: 10EBernhardson) [22:39:56] 3Wikimedia / 3Site requests: Add "movefile" permission to "eliminator" in Japanese Wikipedia - 10https://bugzilla.wikimedia.org/70007 (10Vogone) 5NEW>3ASSI p:5Unprio>3Normal a:3Vogone [22:40:34] (03PS2) 10EBernhardson: G3: Mobile/nojs edit and reply full topic output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156203 [22:41:09] (03CR) 10jenkins-bot: [V: 04-1] G3: Mobile/nojs edit and reply full topic output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156203 (owner: 10EBernhardson) [22:49:15] (03CR) 10Bsitu: [C: 04-1] "I actually prefer doing the conversion one-by-one like this patch does rather than having one gigantic patch converting everything. For th" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156095 (owner: 10Matthias Mullie) [22:54:09] 3MediaWiki / 3Internationalization: Using variables inside plural definitions doesn't work in JavaScript - 10https://bugzilla.wikimedia.org/69993 (10Helder) [23:03:38] (03CR) 10MaxSem: [C: 032] Fix regression: Allow HTML as checkbox label in HTMLCheckField [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156015 (owner: 10Alex Monk) [23:05:14] (03CR) 10Dzahn: "who is +2 on wikimedia/TransparencyReport? do you need ops to merge here? just wondering" [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/154031 (owner: 10Prtksxna) [23:06:37] (03Merged) 10jenkins-bot: Fix regression: Allow HTML as checkbox label in HTMLCheckField [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156015 (owner: 10Alex Monk) [23:06:51] (03CR) 10Jackmcbarn: "That would be Prtksxna, MSyed, and anyone in the WMF LDAP group." [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/154031 (owner: 10Prtksxna) [23:06:58] (03PS1) 10Dduvall: Central bundler gem installation path for faster provisions [vagrant] - 10https://gerrit.wikimedia.org/r/156207 [23:08:08] (03PS1) 10Awight: update CentralNotice submodule [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/156208 [23:08:09] MaxSem, bd808: ^ hopefully this will help reduce the provisioning cost of browser tests. do you think that's enough to justify a default browser_tests => true or am i just being stubborn? :) [23:08:37] (03PS1) 10Awight: update CentralNotice submodule [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156209 [23:08:45] marxarelli: Is that shared gem dir going to bring the permissions problems back? [23:08:53] MaxSem, bd808: correction, it _will_ reduce the cost of provisioning [23:09:07] bd808: i don't think so. most of those issues were related to an outdated bundler [23:09:27] cool. ffi is one of the big problems I hear about [23:09:43] the decentralization was sort of a stopgap until i figure out what the root cause was [23:09:46] my problem was not provisioning speed (though it sucks indeed) [23:10:30] (03CR) 10MaxSem: [C: 032 V: 032] update CentralNotice submodule [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/156208 (owner: 10Awight) [23:10:45] (03CR) 10MaxSem: [C: 032 V: 032] update CentralNotice submodule [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156209 (owner: 10Awight) [23:11:20] MaxSem: we can also work on reducing the role dependencies. i just wanted to partially remove browser tests from the equation [23:12:55] my main problem with BT is that their provisioning is too fragile, causing failed puppet runs [23:13:11] MaxSem, bd808: and we certainly allow for the disabling of them altogether via hiera. i'm just trying to figure out a way to have them enabled by default [23:13:41] this should help with the fragility as well [23:14:12] but I will still fight dependencies till death:D [23:14:38] Does each repo really have a lot of custom ruby needs? Or is just basically that we need the bits for cucumber plus the custom mw gem? [23:15:34] <^d> For Cirrus it's mainly cucumber iirc. [23:15:40] Just wondering aloud if we could have a single bunch of things installed (preferably with apt-get) [23:16:46] cucumber + mediawiki-selenium has a lot of dependencies [23:17:19] not unless we want to package mediawiki-selenium :/ [23:17:39] 3MediaWiki extensions / 3Gadgets: Gadget usage statistics - 10https://bugzilla.wikimedia.org/19288#c10 (10George Orwell III) (In reply to Yuvi Panda from comment #6) > if there's still interest. YES PLEASE! In agreement with comment #7 here too. [23:17:39] 3MediaWiki / 3General/Unknown: MediaWiki 2.0 (tracking) - 10https://bugzilla.wikimedia.org/70000 (10James Forrester) [23:17:39] 3MediaWiki / 3General/Unknown: Tracking bug (tracking) - 10https://bugzilla.wikimedia.org/2007 (10James Forrester) [23:18:09] 3Wikimedia / 3Site requests: Enable VisualEditor by default for all users of all Wikimedia wikis (tracking) - 10https://bugzilla.wikimedia.org/50000 (10James Forrester) s:5normal>3enhanc [23:19:14] MaxSem, bd808: another possible middle ground: add a vagrant setting that toggles the global default for browser tests? [23:20:01] marxarelli: sure. and set it to off by default ;) [23:20:09] damn you! [23:20:10] 3MediaWiki extensions / 3Gadgets: Gadget usage statistics - 10https://bugzilla.wikimedia.org/19288#c11 (10Yuvi Panda) My spare time has currently been taken up by providing public 'edits per country' data (see the analytics mailing list), so will try to get to this in the next few weeks. [23:20:21] The thing about browser tests is that no one is going to run them accidentally [23:20:30] prompt like we do for git_user [23:20:31] you have to read a bunch of wiki pages just to figure out how to do so [23:20:47] (03CR) 10Bsitu: [C: 04-1] Fix Flow entries in Special:EditWatchlist (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156121 (owner: 10Matthias Mullie) [23:20:59] adding one more step of "turn them on in mwv" won't be too burdensome I don't think personally [23:21:09] i know, but i'm trying to reduce the barrier to adoption, not make it harder [23:21:34] * bd808 won't fight about it in any case [23:21:56] I'm not even the BDFL for any of this. ;) [23:22:16] (03CR) 10Krinkle: "Please don't merge patches in jjb-config unless you are able, willing and have already compiled and published the config change to Jenkins" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/156193 (owner: 10Jforrester) [23:22:30] awight: ^ [23:22:56] Krinkle: yes, James_F mentioned that to me a minute ago. thanks! [23:23:00] k :) [23:23:13] secret foo! [23:24:23] Krinkle: Frankly you should probably restrict +2 in that repo to a group of people who know how to deploy there… [23:25:43] James_F: Indeed, I've raised this to Chad and Antoine. But per Erik's policy on wmf-staff having +2 everywhere this was overwritten (only ops/ got out of that revamp) [23:26:28] Krinkle: How about we fix the integration/ root to be like operations/ ? [23:26:35] I'm all for trust and enabling people, but in these cases it's just confusing and moot. Those without Jenkins push rights have no business merging there, it can't work. [23:26:48] James_F: I've e-mailed Antoine and Chad 1 minute ago again, we'll probably change it. [23:26:57] Cool. [23:27:13] You can see the remainder of the original config on https://gerrit.wikimedia.org/r/#/admin/projects/integration,access [23:27:13] it says Submit: integration only [23:27:23] (owner: ldap/wmf + integration) [23:27:24] 3MediaWiki extensions / 3OAuth: Error: bad-source-ip, tools is running on Tool Labs grid - 10https://bugzilla.wikimedia.org/69995#c7 (10metatron) 5RESO/INV>3RESO/FIX Well, the new restrictions now allow private labs addresses too. This was necessary due to the change. {"IPAddresses":["208.80.155.0/24... [23:27:32] but then integration got ldap/wmf included.. [23:27:38] https://gerrit.wikimedia.org/r/#/admin/groups/10,members [23:27:47] Yeah… [23:27:56] I'll see if I can compile/deploy that change. I'm off in a bit though. [23:28:02] anybody in the wmf ldap group has rights to change Jenkins I think. [23:28:22] bd808: Yes, but it's a policy issue, not an access issue. [23:28:51] bd808: That one should be changed too. It's escalation based on one central change made a while back. The gerrit one was made to match Jenkins. [23:28:57] * bd808 just read the wiki page and uploaded his initial changes BOLDLY [23:29:50] but even if Jenkins continues both, it's best to have gerrit match policy (I have access to tin and could circumvent all kinds of gerrit repos I don't have rights on, that doesn't mean I should be in all those gerrit groups) [23:29:51] I guess I had the advantage of not being scared of Jenkins craziness having been a Jenkins cluster admin before [23:29:58] (03PS3) 10EBernhardson: G3: Mobile/nojs edit and reply full topic output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156203 [23:30:34] (03CR) 10jenkins-bot: [V: 04-1] G3: Mobile/nojs edit and reply full topic output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156203 (owner: 10EBernhardson) [23:34:52] bd808, MaxSem: well, i'll submit a patch for the setting + hiera vars. we can argue (or not) about defaults later, or simply defer to our dictators :P [23:35:16] (03PS6) 10Jdlrobson: i18n: Allow translation of participants and comment_count [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155827 [23:35:23] (03CR) 10jenkins-bot: [V: 04-1] i18n: Allow translation of participants and comment_count [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155827 (owner: 10Jdlrobson) [23:36:48] (03CR) 10Jdlrobson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155670 (owner: 10Jdlrobson) [23:42:32] (03PS5) 10Jdlrobson: Hygiene: Standardise on time i10n parameter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155672 [23:44:25] (03PS8) 10Jdlrobson: i18n the time messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155670 [23:45:08] (03PS6) 10Jdlrobson: Hygiene: Standardise on time i10n parameter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155672 [23:45:25] (03PS7) 10Jdlrobson: i18n: Allow translation of participants and comment_count [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155827 [23:45:31] (03CR) 10jenkins-bot: [V: 04-1] i18n: Allow translation of participants and comment_count [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155827 (owner: 10Jdlrobson) [23:45:55] (03PS9) 10Jdlrobson: i18n the time messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155670 [23:46:00] (03PS7) 10Jdlrobson: Hygiene: Standardise on time i10n parameter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155672 [23:47:37] (03PS8) 10Jdlrobson: i18n: Allow translation of participants and comment_count [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155827 [23:52:34] (03CR) 10Bsitu: [C: 04-1] Batchload all data required to fix Special:EditWatchlist titles (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156122 (owner: 10Matthias Mullie) [23:54:09] (03PS4) 10Jdlrobson: G3: Mobile/nojs edit and reply full topic output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/156203 (owner: 10EBernhardson) [23:56:24] 3MediaWiki / 3General/Unknown: Tracking bug (tracking) - 10https://bugzilla.wikimedia.org/2007 (10Krinkle) [23:56:26] 3MediaWiki / 3General/Unknown: ­ is filtered out? - 10https://bugzilla.wikimedia.org/70014 (10DaB.) 3NEW p:3Unprio s:3normal a:3None Hello, can it be that after one of the last updates ­s are filtered out? The templates of the German mainpage use shys, but AFAIS they no longer work. The wikit... [23:58:39] 3Wikimedia / 3Site requests: Add "movefile" permission to "eliminator" in Japanese Wikipedia - 10https://bugzilla.wikimedia.org/70007#c3 (10Ori Livneh) 5PATC>3RESO/FIX Deployed.