[00:15:56] (03PS1) 10Helder.wiki: Do not load "ext.wikiEditor.toolbar" if the user disabled WikiEditor [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/156010 [00:40:08] (03PS5) 10Ebe123: Add link to Special:PrefixIndex to Delete dialog [core] - 10https://gerrit.wikimedia.org/r/151061 (https://bugzilla.wikimedia.org/30666) [00:40:57] (03CR) 10Ebe123: Add link to Special:PrefixIndex to Delete dialog (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151061 (https://bugzilla.wikimedia.org/30666) (owner: 10Ebe123) [00:52:30] 3MediaWiki extensions / 3ProofreadPage: Unable to get old toolbar in namespace Page: whatsoever the preference request for the old toolbar - 10https://bugzilla.wikimedia.org/69447 (10Andre Klapper) 5NEW>3PATC [01:13:23] (03PS1) 10Mattflaschen: Fix regression: Allow HTML as checkbox label in HTMLCheckField [core] - 10https://gerrit.wikimedia.org/r/156011 [01:13:56] (03CR) 10Mattflaschen: "Fixed in https://gerrit.wikimedia.org/r/156011" [core] - 10https://gerrit.wikimedia.org/r/150635 (owner: 10Jdlrobson) [01:15:48] 3MediaWiki / 3Special pages: Special:AllPages no longer has Next link (regression?) - 10https://bugzilla.wikimedia.org/69951 (10Donald Lancon) 3NEW p:3Unprio s:3normal a:3None In some recent version of MW (have noticed in 1.24wmf17, but possibly before?), the "Next" link(s) no longer appear on Specia... [01:25:08] (03CR) 10GeorgeBarnick: [C: 031] "Looks good! Sorry I couldn't make this patchset myself but it looks like you did a fine job." [core] - 10https://gerrit.wikimedia.org/r/156011 (owner: 10Mattflaschen) [01:29:34] 3MediaWiki / 3Uploading: Rework Special:Upload JS to use api and serverside upload checks - 10https://bugzilla.wikimedia.org/24217 (10Alex Monk) [01:29:34] 3MediaWiki / 3Uploading: Special:Upload JS does not consider wgCheckFileExtensions - 10https://bugzilla.wikimedia.org/23583 (10Alex Monk) [01:29:34] 3MediaWiki / 3Uploading: Special:Upload JS does not consider wgCheckFileExtensions - 10https://bugzilla.wikimedia.org/23583 (10Alex Monk) [02:03:16] 3MediaWiki extensions / 3SemanticForms: Editing template doesn't work - 10https://bugzilla.wikimedia.org/69833#c5 (10elindarie) This continues to happen. If it's my mistake, I haven't figured it out. I think it's a bug. I don't know if it's fixed in versions more recent than what referata.com has. [02:11:44] (03CR) 10Arlolra: Cleaned up workflow for fetching nodes to use Status. (031 comment) [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/62026 (owner: 10Parent5446) [02:30:48] 3MediaWiki / 3User preferences: Preferences/Gadgets values are unpredictably boolean, integers or other - 10https://bugzilla.wikimedia.org/52542 (10Helder) [02:42:10] (03CR) 10Arlolra: [C: 04-1] Added If-Modified-Since support to Onionoo loading. (031 comment) [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/62027 (owner: 10Parent5446) [02:50:18] 3Wikimedia / 3General/Unknown: Tamil Wiki projects (tracking) - 10https://bugzilla.wikimedia.org/32578 (10Sundar) [03:03:46] 3MediaWiki extensions / 3MassMessage: Use ContentHandler based spamlist for MassMessage instead of parserfunction - 10https://bugzilla.wikimedia.org/61255 (10wctaiwan) [03:04:01] 3Wikimedia / 3General/Unknown: Add ContentHandler columns to Wikimedia wikis, and set $wgContentHandlerUseDB = true - 10https://bugzilla.wikimedia.org/49193 (10wctaiwan) [03:27:01] 3MediaWiki-Vagrant: vagrant_ram overrides sometimes ignored/forgotten - 10https://bugzilla.wikimedia.org/69131#c2 (10Matthew Flaschen) I noticed that I had this problem again after a vagrant halt, vagrant up cycle. The reason I did the halt was that it was non-responsive, so it's possible it was already wrong... [03:30:32] 3MediaWiki-Vagrant: vagrant_ram overrides sometimes ignored/forgotten - 10https://bugzilla.wikimedia.org/69131#c3 (10Matthew Flaschen) Went back to: === vagrant@mediawiki-vagrant:~$ free -m total used free shared buffers cached Mem: 2001 1037 964... [03:34:33] (03PS1) 10Legoktm: Improve tests for OutputPage::makeResourceLoaderLink [core] - 10https://gerrit.wikimedia.org/r/156014 [03:52:30] (03CR) 10Alex Monk: Add blanket support for mediawiki ui via globals (034 comments) [core] - 10https://gerrit.wikimedia.org/r/150635 (owner: 10Jdlrobson) [03:58:56] (03CR) 10Alex Monk: [C: 032] Fix regression: Allow HTML as checkbox label in HTMLCheckField [core] - 10https://gerrit.wikimedia.org/r/156011 (owner: 10Mattflaschen) [04:00:07] (03PS1) 10Alex Monk: Fix regression: Allow HTML as checkbox label in HTMLCheckField [core] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156015 [04:01:50] (03Merged) 10jenkins-bot: Fix regression: Allow HTML as checkbox label in HTMLCheckField [core] - 10https://gerrit.wikimedia.org/r/156011 (owner: 10Mattflaschen) [04:12:12] (03PS1) 10Legoktm: Add feature-flag to disable ContentHandler features [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/156017 [04:14:53] (03CR) 10Ori.livneh: [C: 032] Tune nfs mount options [vagrant] - 10https://gerrit.wikimedia.org/r/155866 (owner: 10BryanDavis) [04:15:03] (03Merged) 10jenkins-bot: Tune nfs mount options [vagrant] - 10https://gerrit.wikimedia.org/r/155866 (owner: 10BryanDavis) [04:23:06] (03CR) 10Alex Monk: Add blanket support for mediawiki ui via globals (031 comment) [core] - 10https://gerrit.wikimedia.org/r/150635 (owner: 10Jdlrobson) [04:33:09] (03CR) 10Arlolra: "The bulk list doesn't return relay info, specifically the contact details required for this change. So maybe it does fit here." (033 comments) [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/53918 (owner: 10Parent5446) [04:36:21] (03CR) 10Hoo man: [C: 032] "Makes sense and is in line with HTMLFormField::getHelpTextHtmlTable" [core] - 10https://gerrit.wikimedia.org/r/156007 (owner: 10BryanDavis) [04:37:39] yay someone else is reviewing TorBlock thingies :D [04:38:45] 3MediaWiki extensions / 3Spam Blacklist: Spam blacklist disallows addition of blacklisted links which are already there - 10https://bugzilla.wikimedia.org/69775#c5 (10Dirk Beetstra) 5UNCO>3NEW (In reply to Jackmcbarn from comment #4) > I'm almost positive that the problem lies with Cyberbot II and not th... [04:39:41] legoktm, you get excited about the oddest things :) [04:39:49] (03Merged) 10jenkins-bot: Apply csshelpclass to vform help [core] - 10https://gerrit.wikimedia.org/r/156007 (owner: 10BryanDavis) [04:40:06] it means I don't have to :P [04:41:00] 3MediaWiki extensions / 3Spam Blacklist: Spam blacklist disallows addition of blacklisted links which are already there - 10https://bugzilla.wikimedia.org/69775#c6 (10Jackmcbarn) I just did it, and it wasn't blocked. See https://en.wikipedia.org/w/index.php?title=Elena_Sheynina&diff=622558252&oldid=621640815 [04:42:30] 3MediaWiki extensions / 3Spam Blacklist: Spam blacklist disallows addition of blacklisted links which are already there - 10https://bugzilla.wikimedia.org/69775#c7 (10Jackmcbarn) I think the problem you're seeing is because the link ends with a question mark, and if used as a bare link, the question mark isn... [04:51:30] 3MediaWiki extensions / 3TorBlock: Warning: Invalid argument supplied for foreach() in TorExitNodes.php on line 210 - 10https://bugzilla.wikimedia.org/69017#c2 (10Arlo Breault) The Http::get there is probably failing. Onionoo (the service it's querying) has been under a DOS sporadically the past few weeks.... [04:51:59] 3MediaWiki extensions / 3Spam Blacklist: Spam blacklist disallows addition of blacklisted links which are already there - 10https://bugzilla.wikimedia.org/69775#c8 (10Dirk Beetstra) So what blocked MY edits there, I copy-pasted the link as well (I tried another route, and was able to save as well). Somethin... [05:01:43] legoktm, I think the Gadgets 2 preferences tab should be dumping the parsed gadget description (without further escaping), like the current preferences page allows [05:01:45] Right now on the RL2 branch we use 'label' instead of 'label-raw', which escapes stuff further (even though we've already send the text through the parser) [05:02:32] ok, that sounds good to me [05:05:35] (03PS1) 10Alex Monk: Output just parsed text for gadget description, rather than escaping further [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/156018 [05:08:38] (03CR) 10Alex Monk: [C: 032] Remove unused variable quality [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/139082 (owner: 10Gerrit Patch Uploader) [05:10:13] (03PS1) 10Legoktm: includes/htmlform/: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/156019 [05:11:19] (03Merged) 10jenkins-bot: Remove unused variable quality [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/139082 (owner: 10Gerrit Patch Uploader) [05:11:35] Krenair: * @since 1.22 The 'label' attribute no longer accepts raw HTML, use 'label-raw' instead [05:11:41] that explains it :P [05:12:16] (03CR) 10Legoktm: [C: 032] "From HTMLFormField.php: @since 1.22 The 'label' attribute no longer accepts raw HTML, use 'label-raw' instead" [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/156018 (owner: 10Alex Monk) [05:12:23] (03Merged) 10jenkins-bot: Output just parsed text for gadget description, rather than escaping further [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/156018 (owner: 10Alex Monk) [05:12:31] (03CR) 10MZMcBride: "I wonder if this proposed change is meant to introduce a permanent f(ix|ea)ture." (031 comment) [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/156017 (owner: 10Legoktm) [05:12:53] (03CR) 10Alex Monk: [C: 032] Remove deprecated OutputPage::appendSubtitle() [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/146399 (owner: 10Withoutaname) [05:14:40] (03Merged) 10jenkins-bot: Remove deprecated OutputPage::appendSubtitle() [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/146399 (owner: 10Withoutaname) [05:16:45] (03PS2) 10Legoktm: Add temporary feature-flag to disable ContentHandler features [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/156017 [05:17:37] (03CR) 10Legoktm: "I explicitly specified that this is a temporary config setting just for Wikimedia deployment and will be removed once no longer necessary." [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/156017 (owner: 10Legoktm) [05:19:19] (03CR) 10Alex Monk: MediaWiki UI: Style all select tags when $wgUseMediaWikiUIEverywhere (031 comment) [core] - 10https://gerrit.wikimedia.org/r/152195 (owner: 10Jdlrobson) [05:25:51] 3MediaWiki extensions / 3MassMessage: Make it easier to figure out what message was sent using MassMessage - 10https://bugzilla.wikimedia.org/69953 (10MZMcBride) 3NEW p:3Unprio s:3enhanc a:3None As discussed at Why is bug 65778 still hidden? [05:37:26] (03CR) 10Alex Monk: "Why is that bug still hidden?" [core] - 10https://gerrit.wikimedia.org/r/150607 (https://bugzilla.wikimedia.org/65778) (owner: 10Mglaser) [05:40:18] 3MediaWiki extensions / 3MassMessage: Add support to MassMessage to allow using the sender's username for deliveries - 10https://bugzilla.wikimedia.org/69954 (10MZMcBride) 3NEW p:3Unprio s:3enhanc a:3None As mentioned at bug 57234 comment 1 (and somewhat related to bug 60119), currently MassMessage u... [05:42:32] 3MediaWiki extensions / 3MassMessage: Add support to MassMessage to allow using the sender's username for deliveries - 10https://bugzilla.wikimedia.org/69954 (10MZMcBride) [05:43:58] (03PS1) 10Legoktm: Stop using $wgDeferredUpdateList [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/156020 [05:44:27] (03PS1) 10Legoktm: Deprecate $wgDeferredUpdateList [core] - 10https://gerrit.wikimedia.org/r/156021 [05:47:21] (03CR) 10Legoktm: "Ic59c90c0d0131039295bd785280dc70ebde6e40f deprecates the global." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/156020 (owner: 10Legoktm) [06:30:32] 3Wikimedia / 3Media storage: backend-fail-internal error while deleting files - 10https://bugzilla.wikimedia.org/69760 (10Steinsplitter) 5RESO/WOR>3RESO/FIX [06:41:48] 3MediaWiki extensions / 3MassMessage: Add support to MassMessage to allow using the sender's username for deliveries - 10https://bugzilla.wikimedia.org/69954#c1 (10wctaiwan) See https://gerrit.wikimedia.org/r/#/c/98469/ for an existing patch for this, though it may need to be reworked somewhat. [06:52:47] 3MediaWiki extensions / 3MassMessage: Make it easier to figure out what message was sent using MassMessage - 10https://bugzilla.wikimedia.org/69953#c1 (10wctaiwan) I like the idea of using a page that keeps getting overwritten. One crude workaround for the message variants issue would be to just wrap the raw... [07:13:32] (03PS3) 10Legoktm: Add temporary feature-flag to disable ContentHandler features [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/156017 [07:14:22] (03PS4) 10Legoktm: Disable ContentHandler features if $wgContentHandlerUseDB = false [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/156017 [07:21:00] Hi! [07:25:00] hi [07:27:15] I have a query. I have set up MediaWiki Vagrant machine running on my local system. I wanna know How to begin understanding the code of a particular project/extension and start working on it. I mean I know how to make changes or add a patch of code and then submit it on gerrit for its review. But how can I see what results are produced on changing/fixing a patch of code. [07:29:12] (03PS5) 10Wctaiwan: Disable ContentHandler features if $wgContentHandlerUseDB = false [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/156017 (owner: 10Legoktm) [07:29:45] (03CR) 10Wctaiwan: [C: 031] "Looks good to me." [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/156017 (owner: 10Legoktm) [07:31:57] (03CR) 10Legoktm: [C: 032] "per wctaiwan." [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/156017 (owner: 10Legoktm) [07:32:23] (03Merged) 10jenkins-bot: Disable ContentHandler features if $wgContentHandlerUseDB = false [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/156017 (owner: 10Legoktm) [08:51:21] 3MediaWiki / 3Parser: Comments after === became a part of a header in xml representation - 10https://bugzilla.wikimedia.org/69791#c1 (10Nikolay Shaplov) Might be good to note that comments after normal headers are also put inside tags: = Header = = Header = (03CR) 10Bartosz Dziewoński: [C: 031] "I'll merge this in a few days if no one comments on i18n." [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/155696 (owner: 10Isarra) [09:06:14] (03PS1) 10Umherirrender: Remove double @return from User::isAllowedAny [core] - 10https://gerrit.wikimedia.org/r/156024 [09:17:29] I'm trying to set up git review, but when I run `git review -s` it gives me an error: http://pastebin.com/qvb3CaM5 which looks like it just needs the correct url [09:17:36] does anyone know where that is? [09:20:03] (03PS1) 10Umherirrender: Add some @see to doc blocks [core] - 10https://gerrit.wikimedia.org/r/156025 [09:25:27] (03PS1) 10Zhuyifei1999: Add language code to sitenotice cache key [core] - 10https://gerrit.wikimedia.org/r/156026 (https://bugzilla.wikimedia.org/69279) [09:27:21] (03PS1) 10Umherirrender: Remove wrong @return from doc blocks [core] - 10https://gerrit.wikimedia.org/r/156027 [09:28:20] onei: the url should be https://gerrit.wikimedia.org/r/tools/hooks/commit-msg [09:28:47] http://www.mediawiki.org/wiki/Gerrit/git-review#Troubleshooting_for_Windows [09:30:30] (03PS1) 10Umherirrender: Do not return anything on __construct [core] - 10https://gerrit.wikimedia.org/r/156028 [09:42:28] p858snake|l: thanks :) seems to fixed that issue. My next problem is that it gives "error: cannot spawn .git/hooks/commit-msg: No such file or directory" when running git commit -a -m "some message" [09:43:09] looks like it's trying to write to /vagrant/mediawiki/.git/hooks/commit-msg which does exist, so I'm a bit confused [09:50:12] vagrant? I have no idea [10:15:01] 3MediaWiki / 3User login and signup: Provide virtual keyboard for typing password - 10https://bugzilla.wikimedia.org/69957 (10db) 3NEW p:3Unprio s:3normal a:3None When your are not sure, if the used computer is save and has no key logger installed like on internet cafe or school computer or ..., ther... [10:44:18] 3MediaWiki / 3General/Unknown: Language settings are not delivering customized interwiki links - 10https://bugzilla.wikimedia.org/69959 (10FocalPoint) 3UNCO p:3Unprio s:3normal a:3None Intention: The Language settings are automatically showing languages of neighbouring countries, however, the system... [11:05:59] (03CR) 10Helder.wiki: Script to clean up manual user global.js/css pages (031 comment) [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/154441 (https://bugzilla.wikimedia.org/68933) (owner: 10Legoktm) [11:25:10] (03CR) 10Anomie: [C: 031] "I don't see any other errors, but another pair of eyes would be helpful." [core] - 10https://gerrit.wikimedia.org/r/156003 (owner: 10Umherirrender) [12:10:04] 3Wikimedia / 3Site requests: Rename "Reviewer" right on enwiki - 10https://bugzilla.wikimedia.org/69960 (10Mdann52) 3UNCO p:3Unprio s:3normal a:3None Over at , there is a... [12:28:21] (03PS1) 10Frédéric Wang: Remove the "best for most browsers" comment for the MathJax mode. [extensions/Math] - 10https://gerrit.wikimedia.org/r/156034 [12:29:25] (03PS2) 10Frédéric Wang: Remove the "best for most browsers" comment for the MathJax mode. [extensions/Math] - 10https://gerrit.wikimedia.org/r/156034 [13:17:15] 3Wikimedia / 3Site requests: Rename "Reviewer" right on enwiki - 10https://bugzilla.wikimedia.org/69960#c1 (10Zhaofeng Li) Some pointers on what to change if the proposal succeeds: Project pages: https://en.wikipedia.org/wiki/Wikipedia:Protection_policy#Pending_changes_protection https://en.wikipedia.org/wik... [13:18:45] 3MediaWiki extensions / 3Quiz: TestWiki (multiple choice test similar to Quiz) - 10https://bugzilla.wikimedia.org/17129#c1 (10Andre Klapper) p:5Low>3Lowest (In reply to Bernhard Fastenrath from comment #0) > but would require an Applet or JavaWebstart program to take a test. That sounds very uncommon to... [13:30:17] 3MediaWiki extensions / 3Translate: [PagePreparation] Link to edit and language in summary - 10https://bugzilla.wikimedia.org/69592#c5 (10Nemo) Is it now using a fullurl for the action=edit link? [13:30:45] 3MediaWiki extensions / 3CentralAuth: Phantom autocreated CentralAuth accounts on some Wikimedia wikis? - 10https://bugzilla.wikimedia.org/17032#c2 (10Andre Klapper) Hi Splarka! Sorry that nobody has taken a look at this report yet and given feedback. (In reply to Splarka from comment #0) > On the Toolserve... [13:31:02] 3MediaWiki extensions / 3Translate: [PagePreparation] Edit summary should use site language - 10https://bugzilla.wikimedia.org/69945#c1 (10Nemo) 5NEW>3RESO/DUP Thanks; this should have already been fixed, coming on Meta on the 26th. *** This bug has been marked as a duplicate of bug 69592 *** [13:31:06] 3MediaWiki extensions / 3Translate: [PagePreparation] Link to edit and language in summary - 10https://bugzilla.wikimedia.org/69592#c6 (10Nemo) *** Bug 69945 has been marked as a duplicate of this bug. *** [13:31:30] 3MediaWiki extensions / 3Translate: [PagePreparation] Links to Special pages should not be MyLanguage'd - 10https://bugzilla.wikimedia.org/69943 (10Nemo) p:5Unprio>3Normal [13:37:14] (03CR) 10Phe: [C: 031] "Note editing wikisource is possible at the moment but boring." [core] - 10https://gerrit.wikimedia.org/r/156009 (https://bugzilla.wikimedia.org/69447) (owner: 10Helder.wiki) [13:41:43] (03CR) 10Phe: [C: 031] Do not load "ext.wikiEditor.toolbar" if the user disabled WikiEditor [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/156010 (owner: 10Helder.wiki) [13:50:31] (03CR) 10Liangent: [C: 04-1] "$this->getLanguage() is the interface language, which can be different from content language and/or its variants, which is used when notic" [core] - 10https://gerrit.wikimedia.org/r/156026 (https://bugzilla.wikimedia.org/69279) (owner: 10Zhuyifei1999) [13:58:27] (03PS1) 10Krinkle: startup: Blacklist Opera < 12 [core] - 10https://gerrit.wikimedia.org/r/156039 [14:00:45] 3MediaWiki extensions / 3Translate: [PagePreparation] Link to edit and language in summary - 10https://bugzilla.wikimedia.org/69592#c7 (10Pratik Lahoti) Hi Nemo, > Why so? As we are saying "You can [edit] it", it would be better to take the > user to the editing window, I feel. I had mentioned this, you di... [14:04:42] (03PS1) 10Krinkle: startup: Update documentation and tests to reflect current practices [core] - 10https://gerrit.wikimedia.org/r/156040 [14:12:16] 3MediaWiki extensions / 3MassMessage: Add support to MassMessage to allow using the sender's username for deliveries - 10https://bugzilla.wikimedia.org/69954 (10Andre Klapper) 5NEW>3PATC [14:13:40] (03PS2) 10Krinkle: startup: Blacklist Opera < 12 [core] - 10https://gerrit.wikimedia.org/r/156039 [14:13:52] (03PS2) 10Krinkle: startup: Update documentation and tests to reflect current practices [core] - 10https://gerrit.wikimedia.org/r/156040 [14:14:19] 3Wikimedia / 3Site requests: Rename "Reviewer" right on enwiki - 10https://bugzilla.wikimedia.org/69960 (10Andre Klapper) 5UNCO>3NEW p:5Unprio>3Normal s:5normal>3enhanc [14:15:48] 3MediaWiki / 3General/Unknown: Language settings are not delivering customized interwiki links - 10https://bugzilla.wikimedia.org/69959#c1 (10Andre Klapper) Thanks for taking the time to report this! Please elaborate on the steps to reproduce, as I have no idea where to go (URLs, some pane) and what to do wh... [14:21:39] (03PS1) 10Vogone: [DO NOT MERGE] Fix global group i18n [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/156041 [14:22:43] (03CR) 10Vogone: [C: 04-1] "Still requires some fixes onwiki." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/156041 (owner: 10Vogone) [14:51:37] 3MediaWiki extensions / 3Translate: [PagePreparation] Link to edit and language in summary - 10https://bugzilla.wikimedia.org/69592#c8 (10Nemo) 5RESO/FIX>3REOP Ok. Please look at https://www.mediawiki.org/wiki/Help:Magic_words#URL_data again, the second example shows how an action=edit URL should look. [14:57:54] thedjNotWMF: Around? [15:22:45] 3MediaWiki extensions / 3CentralAuth: More useful links on Special:MergeAccount - 10https://bugzilla.wikimedia.org/17233#c1 (10Andre Klapper) (In reply to Umherirrender from comment #0) > If there attached accounts [[Special:MergeAccount]] shows the projects, > which account are attached. > > Please add her... [15:25:45] 3MediaWiki / 3General/Unknown: Language settings are not delivering customized interwiki links - 10https://bugzilla.wikimedia.org/69959#c2 (10FocalPoint) (In reply to Andre Klapper from comment #1) > Thanks for taking the time to report this! > Please elaborate on the steps to reproduce, as I have no idea wh... [15:30:16] 3MediaWiki / 3General/Unknown: Language settings are not delivering customized interwiki links - 10https://bugzilla.wikimedia.org/69959#c3 (10FocalPoint) ....I meant... brings up only the en-wikipedia links (which I have used), as well as several others, but it does not bring the interwiki links off the othe... [15:31:49] (03CR) 10SPQRobin: [C: 031] "It's good to finally have standardized names for global groups. I renamed them on Meta." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/156041 (owner: 10Vogone) [15:31:51] (03PS2) 10Vogone: Fix global group i18n [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/156041 [15:32:06] (03CR) 10Vogone: Fix global group i18n [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/156041 (owner: 10Vogone) [15:35:00] 3MediaWiki extensions / 3Spam Blacklist: Spam blacklist disallows addition of blacklisted links which are already there - 10https://bugzilla.wikimedia.org/69775#c9 (10Jackmcbarn) The original link in the page ended with a question mark. When you added the link, it was bare, so t he question mark wasn't picke... [15:36:46] (03PS3) 10Vogone: Standardise and update global group names [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/156041 [15:50:04] (03CR) 10SPQRobin: [C: 032] Standardise and update global group names [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/156041 (owner: 10Vogone) [15:50:11] (03Merged) 10jenkins-bot: Standardise and update global group names [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/156041 (owner: 10Vogone) [15:53:45] 3MediaWiki / 3Uploading: mediawiki.legacy.upload should be migrated to a modern module - 10https://bugzilla.wikimedia.org/31946#c4 (10Alex Monk) (In reply to Kevin Israel (PleaseStand) from comment #1) > Just a question: do we still need the AJAX destination filename check now > that we have the upload stash... [16:04:47] (03CR) 10Jforrester: [C: 04-1] "Needs a RELEASE-NOTES patch." [core] - 10https://gerrit.wikimedia.org/r/156039 (owner: 10Krinkle) [16:11:37] (03CR) 10Jforrester: [C: 04-1] "One comment about documentation." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156040 (owner: 10Krinkle) [16:12:45] 3MediaWiki / 3General/Unknown: Language settings are not delivering customized interwiki links - 10https://bugzilla.wikimedia.org/69959#c4 (10Andre Klapper) I finally found ""Compact language links"" under https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-betafeatures I guess, so this refers t... [16:19:31] 3Wiki Loves Monuments / 3Toolbox: Add tag to the "source" link - 10https://bugzilla.wikimedia.org/55657 (10Anatoliy Goncharov) p:5Low>3Normal [16:22:55] (03CR) 10Jforrester: "So much cleaner - but no title for the icons is sad." [core] - 10https://gerrit.wikimedia.org/r/155914 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [16:23:47] 3Wikimedia / 3Bugzilla: Submitting a bug for MobileFrontend does not allow to specify mobile OS/browser - 10https://bugzilla.wikimedia.org/69963 (10Axel Boldt) 3NEW p:3Unprio s:3normal a:3None Go to https://bugzilla.wikimedia.org/enter_bug.cgi and select MobileFrontend. The form that appears gives op... [16:25:15] 3MediaWiki-Vagrant: Failure building ffi during MobileFrontend browser test provisioning - 10https://bugzilla.wikimedia.org/69874#c4 (10Yuri Astrakhan) 5NEW>3RESO/WOR No idea of how, but this bug has gone away. Might have been external. [16:26:14] (03CR) 10Bartosz Dziewoński: "I don't like the sorting interface on these tables at all, myself. It would be pretty easy to keep the text for screen-readers if you thin" [core] - 10https://gerrit.wikimedia.org/r/155914 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [16:30:45] 3MediaWiki extensions / 3[other]: [PhpTags] exception in updateBytecodeCache() related to database serialization when using ExtSQI - 10https://bugzilla.wikimedia.org/69657#c4 (10Joel K. Pettersson) 5PATC>3RESO/FIX Sorry for the delay. The fix works, so I'm closing this as resolved. [16:39:25] (03CR) 10Jforrester: "That could work, yeah." [core] - 10https://gerrit.wikimedia.org/r/155914 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [16:41:31] (03PS1) 10Frédéric Wang: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/156043 [16:41:37] (03CR) 10jenkins-bot: [V: 04-1] Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/156043 (owner: 10Frédéric Wang) [16:43:06] (03PS68) 10Frédéric Wang: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [16:43:10] (03CR) 10jenkins-bot: [V: 04-1] Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [16:44:16] 3Wiki Loves Monuments / 3Toolbox: Add tag to the "source" link - 10https://bugzilla.wikimedia.org/55657#c1 (10Andre Klapper) Ahonc.ua: Do you plan to work on this? [16:45:02] (03CR) 10Frédéric Wang: "So I read the MathJax doc & code, and what Amber initially did was correct. It's just that MathJax.Ajax.config.path is only defined in Mat" [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [16:45:17] (03CR) 10Frédéric Wang: [C: 04-1] Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [16:46:55] (03CR) 10Frédéric Wang: [C: 04-2] "wrong commit ID" [extensions/Math] - 10https://gerrit.wikimedia.org/r/156043 (owner: 10Frédéric Wang) [16:47:30] 3Wikimedia / 3Bugzilla: Submitting a bug for MobileFrontend does not allow to specify mobile OS/browser - 10https://bugzilla.wikimedia.org/69963#c1 (10Andre Klapper) 5NEW>3RESO/WON p:5Unprio>3Lowest s:5normal>3minor The bug summary is incorrect/invalid. It says "Submitting a bug for MobileFronten... [16:47:34] (03Abandoned) 10Frédéric Wang: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/156043 (owner: 10Frédéric Wang) [17:00:51] (03CR) 10Tpt: [C: 032] "Thanks a lot" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/156010 (owner: 10Helder.wiki) [17:01:11] (03Merged) 10jenkins-bot: Do not load "ext.wikiEditor.toolbar" if the user disabled WikiEditor [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/156010 (owner: 10Helder.wiki) [17:01:37] (03CR) 10Tpt: [C: 032] "Thanks a lot!" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/155876 (owner: 10Legoktm) [17:01:54] (03Merged) 10jenkins-bot: Use MimeMagic::singleton() instead of instantiating a new class [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/155876 (owner: 10Legoktm) [17:23:00] 3Wikimedia / 3Bugzilla: Submitting a bug for MobileFrontend does not allow to specify mobile OS/browser - 10https://bugzilla.wikimedia.org/69963#c2 (10Axel Boldt) The behavior might be expected by the webadmin, but certainly not by the user. The convincing reasons to change are as follows: 1.) As mentioned,... [17:50:03] 3MediaWiki / 3General/Unknown: No error given for duplicate Cite template parameters - 10https://bugzilla.wikimedia.org/69964 (10andrussm) 3UNCO p:3Unprio s:3normal a:3None There are various ways that a Cite template could end up with the same parameter name coded more than once. I don't know of a le... [17:52:27] (03PS7) 10Jackmcbarn: Add a tracking category for duplicate arguments [core] - 10https://gerrit.wikimedia.org/r/136123 [17:52:42] (03PS8) 10Jackmcbarn: Add a tracking category for duplicate arguments [core] - 10https://gerrit.wikimedia.org/r/136123 (https://bugzilla.wikimedia.org/69964) [17:54:31] 3Wikimedia / 3General/Unknown: Allow users to edit via Tor while still being able to fight abuse - 10https://bugzilla.wikimedia.org/69333 (10Arlo Breault) [18:06:03] 3MediaWiki / 3General/Unknown: No error given for duplicate Cite template parameters - 10https://bugzilla.wikimedia.org/69964#c2 (10andrussm) I guess this system isn't intended for us by mere mortals like me, since I don't understand the response. I do understand what a tracking category is, and my test case... [18:10:04] 3Wiki Loves Monuments / 3Toolbox: Add tag to the "source" link - 10https://bugzilla.wikimedia.org/55657#c2 (10Anatoliy Goncharov) I have no access to fix it. But it did not fixed during 10 month, I want to make it more quickly. [18:10:33] 3MediaWiki / 3General/Unknown: No error given for duplicate Cite template parameters - 10https://bugzilla.wikimedia.org/69964#c3 (10Jackmcbarn) The category isn't there because my change isn't active yet. Someone needs to review and accept it. One to two weeks after that happens, it will become active on Wik... [18:11:31] 3MediaWiki / 3General/Unknown: No error given for duplicate Cite template parameters - 10https://bugzilla.wikimedia.org/69964#c4 (10andrussm) Very good, I'll watch for that. Thank you again. [18:12:00] 3MediaWiki extensions / 3CentralAuth: More useful links on Special:MergeAccount - 10https://bugzilla.wikimedia.org/17233#c2 (10Umherirrender) This is a old bug, in the meantime the special page [[Special:CentralAuth]] was created which shows some more informationen (but not links to the preferences or user t... [18:22:17] (03PS1) 10Krinkle: es5-shim: Add polyfill for Object.create [core] - 10https://gerrit.wikimedia.org/r/156046 [18:27:36] (03CR) 10Krinkle: "Hm.. interesting, I could've sworn that Compatibility page on mediawiki.org called it Grade B, not C. This commit was meant to make it ref" [core] - 10https://gerrit.wikimedia.org/r/156040 (owner: 10Krinkle) [18:30:53] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/FacebookOpenGraph] - 10https://gerrit.wikimedia.org/r/152394 (owner: 10Hashar) [18:37:41] (03PS3) 10Krinkle: startup: Blacklist Opera < 12 [core] - 10https://gerrit.wikimedia.org/r/156039 [18:38:00] (03CR) 10Krinkle: "Added release notes." [core] - 10https://gerrit.wikimedia.org/r/156039 (owner: 10Krinkle) [18:38:08] (03PS3) 10Krinkle: startup: Update documentation and tests to reflect current practices [core] - 10https://gerrit.wikimedia.org/r/156040 [18:40:25] (03PS4) 10Krinkle: startup: Update documentation and tests to reflect current practices [core] - 10https://gerrit.wikimedia.org/r/156040 [18:47:46] 3Wikimedia / 3Bugzilla: Submitting a bug for MobileFrontend does not allow to specify mobile OS/browser - 10https://bugzilla.wikimedia.org/69963#c3 (10Andre Klapper) (In reply to Axel Boldt from comment #2) > The behavior might be expected by the webadmin, but certainly not by the > user. The convincing reas... [18:50:22] 3MediaWiki / 3General/Unknown: No error given for duplicate Cite template parameters - 10https://bugzilla.wikimedia.org/69964#c5 (10Andre Klapper) p:5Unprio>3Normal This ticket gets closed as "resolved fixed" once the corresponding code change is *merged* in the Gerrit/Git code review system (see link in... [18:50:22] 3Wiki Loves Monuments / 3Toolbox: Add tag to the "source" link - 10https://bugzilla.wikimedia.org/55657#c3 (10Andre Klapper) p:5Normal>3Low Alright, setting back "Priority" from normal to low then, as it should reflect reality and not wishful thinking. :-/ [18:51:01] 3MediaWiki / 3General/Unknown: Language settings are not delivering customized interwiki links - 10https://bugzilla.wikimedia.org/69959#c5 (10FocalPoint) 1. Enable the beta feature "Compact language links" 2. Go to a few random articles and select (this is what I meant by "use" - sorry) the interwikis you wo... [18:51:19] 3MediaWiki / 3User preferences: Updating user preferences via API gives inconsistent results - 10https://bugzilla.wikimedia.org/69942 (10Andre Klapper) p:5Unprio>3Normal [18:51:19] 3MediaWiki / 3History/Diffs: Add "export" links in revision history. - 10https://bugzilla.wikimedia.org/15686 (10Andre Klapper) [18:52:16] 3MediaWiki / 3Special pages: Special:AllPages no longer has Next link (regression?) - 10https://bugzilla.wikimedia.org/69951 (10Andre Klapper) p:5Unprio>3Normal [18:52:45] 3MediaWiki extensions / 3CentralAuth: Sanity check fails: "The user account logged into does not exist." - 10https://bugzilla.wikimedia.org/69947#c1 (10Andre Klapper) Ori: Dup of bug 69834? [18:54:01] 3MediaWiki / 3User login and signup: Provide virtual keyboard for typing password - 10https://bugzilla.wikimedia.org/69957#c1 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc Any implementations for that known which provide sufficient I18N for layouts? [18:55:46] 3MediaWiki extensions / 3Collection: "Add linked wiki page to your book" when you hover a link interferes with screen readers. - 10https://bugzilla.wikimedia.org/69899 (10Andre Klapper) p:5Unprio>3Normal [18:56:47] 3MediaWiki / 3Page editing: new section not added on edit conflict - 10https://bugzilla.wikimedia.org/69920#c1 (10Andre Klapper) p:5Unprio>3High (In reply to Umherirrender from comment #0) > Possible regression from Gerrit change #144603 I see that anomie and Aaron are already CC'ed... Wondering how of... [18:57:32] 3Wikimedia / 3Mailing lists: Please help reset moderator password for the list Wikipedia-ne@lists.wikimedia.org - 10https://bugzilla.wikimedia.org/69935 (10Andre Klapper) 5UNCO>3NEW p:5Unprio>3Normal [18:57:45] 3MediaWiki / 3General/Unknown: Code quality issues (tracking) - 10https://bugzilla.wikimedia.org/700 (10Andre Klapper) [18:57:48] 3MediaWiki / 3General/Unknown: Deprecate direct access to class variables - 10https://bugzilla.wikimedia.org/69939 (10Andre Klapper) p:5Unprio>3Normal s:5normal>3enhanc [18:58:00] 3MediaWiki / 3Skin and page rendering: Table pager navigation arrows (used on e.g. [[Special:AllMessages]]) missing SVG versions - 10https://bugzilla.wikimedia.org/69944 (10Andre Klapper) p:5Unprio>3Normal [19:03:16] 3MediaWiki / 3User login and signup: Provide virtual keyboard for typing password - 10https://bugzilla.wikimedia.org/69957#c2 (10Bartosz Dziewoński) Depending on the "key logger" in question, using a software keyboard is likely not to help at all (if I was writing one, I'd just make it a browser extension, w... [19:05:17] 3Wikimedia / 3Mailing lists: Please help reset moderator password for the list Wikipedia-ne@lists.wikimedia.org - 10https://bugzilla.wikimedia.org/69935#c1 (10James Alexander) 5NEW>3ASSI a:3James Alexander Sure, since you're the sole registered admin I'll send a new password directly to your email. [19:08:11] (03PS3) 10Helder.wiki: Allow custom event handlers for the click event of toolbar buttons [core] - 10https://gerrit.wikimedia.org/r/155912 [19:11:16] 3Wikimedia / 3Mailing lists: Please help reset moderator password for the list Wikipedia-ne@lists.wikimedia.org - 10https://bugzilla.wikimedia.org/69935#c2 (10James Alexander) 5ASSI>3RESO/FIX This has been done, let me know if there are any issues. [19:13:16] 3MediaWiki / 3Skin and page rendering: OutputPage: Don't output mw.loader.state "loading" and mw.loader.state "ready" for the same module - 10https://bugzilla.wikimedia.org/50038#c1 (10Umherirrender) This looks fixed for me, because at the moment I will get directly mw.loader.state({"site":"ready","user":"re... [19:27:17] (03PS1) 10Ebe123: Add option to hide and unhide file thumbnails in file history [core] - 10https://gerrit.wikimedia.org/r/156048 (https://bugzilla.wikimedia.org/69053) [19:46:15] 3Wikimedia / 3Site requests: Rename "Reviewer" right on enwiki - 10https://bugzilla.wikimedia.org/69960#c2 (10Mdann52) (In reply to Zhaofeng Li from comment #1) > Some pointers on what to change if the proposal succeeds: All of these can be edited by admins on-wiki, so it may be best to centralise discussion... [19:55:47] (03PS1) 10Helder.wiki: Partially revert "Do not load "ext.wikiEditor.toolbar" if the user disabled WikiEditor" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/156049 [19:56:58] (03CR) 10Helder.wiki: "See also a related discussion on" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/156049 (owner: 10Helder.wiki) [19:59:17] (03CR) 10Helder.wiki: "I reverted this on Id19b1c0ab5831f39f2707d69bde3909038e87054, because disabling "Show edit toolbar" does not affect WikiEditor toolbar (se" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/156010 (owner: 10Helder.wiki) [20:10:16] (03CR) 10Phe: [C: 031] "+1, after talking with Helder on an IRC channel." [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/156049 (owner: 10Helder.wiki) [20:11:17] 3Wikimedia / 3Site requests: Rename "Reviewer" right on enwiki - 10https://bugzilla.wikimedia.org/69960#c3 (10Jackmcbarn) 5NEW>3RESO/INV As Mdann52 says, everything necessary for this can be done on-wiki. Shell users don't need to do anything. [20:12:45] (03CR) 10Tpt: [C: 032] "Thanks a lot!" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/156049 (owner: 10Helder.wiki) [20:13:01] (03Merged) 10jenkins-bot: Partially revert "Do not load "ext.wikiEditor.toolbar" if the user disabled WikiEditor" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/156049 (owner: 10Helder.wiki) [20:15:01] 3Wikimedia / 3Site requests: Rename "Reviewer" right on enwiki - 10https://bugzilla.wikimedia.org/69960#c4 (10Mdann52) 5RESO/INV>3REOP Ummm... No. The actual user right (unless I'm mistaken) needs renaming through this. The various messages can be edited on-wiki, but not the core request here. [20:15:31] 3Wikimedia / 3Site requests: Rename "Reviewer" right on enwiki - 10https://bugzilla.wikimedia.org/69960 (10Mdann52) [20:16:32] 3Wikimedia / 3Site requests: Rename "Reviewer" right on enwiki - 10https://bugzilla.wikimedia.org/69960#c5 (10Jackmcbarn) 5REOP>3RESO/INV We never rename the "actual" user right. Autopatrolled is still called autoreviewer, administrator is still called sysop, etc. [20:17:45] 3Wikimedia / 3Site requests: Rename "Reviewer" right on enwiki - 10https://bugzilla.wikimedia.org/69960#c6 (10Mdann52) Ah right, fair enough. [20:21:21] jackmcbarn: "Autopatrolled is still called autoreviewer" ??? [20:21:29] Autopatrolled is called autopatrolled AFAIK [20:22:13] No, autopatrolled is called autoreviewer internally [20:22:22] anyway, the "sysop" -> "admin" thing should happen someday, but that will be a lot of efforts to invest [20:22:35] see https://en.wikipedia.org/wiki/Special:ListUsers/autoreviewer [20:23:00] ah, that was enwiki-specific [20:23:03] okay [20:23:40] (03CR) 10Tpt: [C: 031] "Will be very useful for the ProofreadPage extension and for an important number of gadgets" [core] - 10https://gerrit.wikimedia.org/r/155912 (owner: 10Helder.wiki) [20:26:13] Krenair: I still wonder why it is so easy to rename internal global group names, but still nothing for local group names was implemented [20:27:17] Well they're two separate systems [20:27:43] One is DB-based, the other is set up by editing the config file [20:28:19] yeah [20:28:35] And the config files are used to configure all wikis [20:29:03] It's a bit of a pain if one wiki decides it wants the software to use a different name internally [20:29:16] MediaWiki supports renaming how they display in the interface [20:29:45] well, I'd prefer consistent internal names accross all wikis, which is not the case ATM [20:29:55] and presumably also will nevr change [20:30:37] Sounds possible, but annoying to do and with no clear gains [20:30:50] indeed [20:36:15] 3MediaWiki extensions / 3CentralAuth: login when already logged in gets exception from Special:CentralLogin - 10https://bugzilla.wikimedia.org/69834#c2 (10Kunal Mehta (Legoktm)) I think this was caused by Idd9325374cb5dc13c4c057f45f88a33bdff523a9. There have been no CA changes related to this except my patch... [20:47:25] (03CR) 10Krinkle: startup: Update documentation and tests to reflect current practices (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156040 (owner: 10Krinkle) [21:04:25] (03PS1) 10Jack Phoenix: Readd CAPTCHA (ConfirmEdit extension) support [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/156052 (https://bugzilla.wikimedia.org/66811) [21:10:03] (03CR) 10Phe: [C: 031] "More adaptable than a simple insertTag()" [core] - 10https://gerrit.wikimedia.org/r/155912 (owner: 10Helder.wiki) [21:14:14] (03PS3) 10Jack Phoenix: Some cleanup and modernization. [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/155010 [21:14:31] (03CR) 10Legoktm: "Caused bug 69834 ?" [core] - 10https://gerrit.wikimedia.org/r/148144 (https://bugzilla.wikimedia.org/15484) (owner: 10Parent5446) [21:15:56] How do I publish inline comments on gerrit O.o [21:16:42] Lcawte: go to the commit's main view (gerrit.wm.o/r/changesetidgoeshere), press "Review" and then bonk the appropriate button ("Publish Comments" IIRC) [21:17:12] (03CR) 10Lewis Cawte: Readd CAPTCHA (ConfirmEdit extension) support (032 comments) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/156052 (https://bugzilla.wikimedia.org/66811) (owner: 10Jack Phoenix) [21:17:30] Thanks ashley :P [21:26:59] (03PS1) 10Withoutaname: Consolidate parts of WebStart.php and doMaintenance.php into Initialize.php [core] - 10https://gerrit.wikimedia.org/r/156053 [21:28:31] (03PS5) 10MZMcBride: Add the ability to send messages using the user's account [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/98469 (https://bugzilla.wikimedia.org/69954) (owner: 10Legoktm) [21:28:33] (03CR) 10jenkins-bot: [V: 04-1] Add the ability to send messages using the user's account [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/98469 (https://bugzilla.wikimedia.org/69954) (owner: 10Legoktm) [21:28:43] (03PS2) 10Jack Phoenix: Readd CAPTCHA (ConfirmEdit extension) support [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/156052 (https://bugzilla.wikimedia.org/66811) [21:30:30] (03Abandoned) 10Jack Phoenix: Version 2.2: RequestContext love, spacing tweaks + position => top for CSS RL modules. [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/137170 (owner: 10Jack Phoenix) [21:30:56] (03CR) 10Legoktm: [C: 04-2] "Why? This just makes the code harder to read with no benefit." [core] - 10https://gerrit.wikimedia.org/r/153744 (owner: 10Withoutaname) [21:31:39] (03PS1) 10Jack Phoenix: Bumped version number (due to recent changes), added position => top for stand-alone CSS modules and got rid of $dir. [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/156054 [21:31:45] 3MediaWiki extensions / 3CentralAuth: Phantom autocreated CentralAuth accounts on some Wikimedia wikis? - 10https://bugzilla.wikimedia.org/17032#c3 (10MZMcBride) https://tools.wmflabs.org/quentinv57-tools/tools/sulinfo.php?username=Splarka is probably roughly equivalent these days. Or [[m:Special:CentralAuth... [21:32:22] (03CR) 10Jack Phoenix: [C: 032 V: 032] Bumped version number (due to recent changes), added position => top for stand-alone CSS modules and got rid of $dir. [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/156054 (owner: 10Jack Phoenix) [21:33:50] (03CR) 10Withoutaname: "Some of the functions are not really necessary. For example, wfMangleFlashPolicy checks for a preg_match first before doing the replace, b" [core] - 10https://gerrit.wikimedia.org/r/153744 (owner: 10Withoutaname) [21:34:13] Are i18n files supposed to be using tabs or spaces? ContactPage appears to have spaces, while Vector has tabs? [21:35:37] tabs [21:35:38] but [21:35:54] the en.json files were never converted unless someone did it manually because TWN doesn't export those [21:36:32] there were created with spaces at first during the great i18n migration on the assumption that no one cares and it was easier, then it turned out that people do indeed care about their indentation [21:37:27] * Lcawte creates an enwiki page called The Great i18n Migration [21:53:45] 3MediaWiki / 3User blocking: MediaWiki:Autoblocker etc. reveals to third party that a (blocked) user has used the same IP address - 10https://bugzilla.wikimedia.org/53008#c52 (10Rich Farmbrough) 1. The text on Autoblocker, according to translatewiki Autoblocked because your IP address has been recently used... [21:58:14] legoktm: can you re-review this one https://gerrit.wikimedia.org/r/#/c/142618/ [22:00:49] (03CR) 10Legoktm: [C: 04-1] "If this is removing or modifying hooks, the entries in docs/hooks.txt need to be updated and release notes added." [core] - 10https://gerrit.wikimedia.org/r/142618 (owner: 10Withoutaname) [22:01:54] should I revert back to patch set 5 [22:06:29] (03PS1) 10Legoktm: Add docs for MonoBookTemplateToolboxEnd hook [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/156055 [22:11:37] (03PS1) 10Legoktm: Update findHooks.php and move MonoBook hook out of docs/hooks.txt [core] - 10https://gerrit.wikimedia.org/r/156056 [22:12:43] legoktm: re:156055, if anything, we should try to get rid of hooks.txt sorta files, instead of adding *more* of 'em...or alternatively we could ditch that deprecated hook...or...do both! [22:13:12] actually, I was about to file a bug to get jenkins to run findHooks.txt when merging. [22:13:16] .php* [22:15:14] I'm not sure what added value hooks.txt provides over MediaWiki.org content [22:15:29] (03PS1) 10Vogone: Add full stops where needed to i18n [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/156058 [22:15:35] Ability to work offline? :P [22:15:55] also it forces the docs to be kept in sync with the code [22:16:20] so mw.o might be up to date with the current master, but if you want to check REL1_23, you just check it from there [22:16:21] well, by that logic we should just ship MW.org's content with MW releases and whatnot... [22:16:28] maybe! [22:16:59] * Lcawte thinks of his poor IDE drives [22:18:34] is anyone here familiar with mw's text storage system [22:20:00] (03CR) 10Bartosz Dziewoński: [C: 032] Add docs for MonoBookTemplateToolboxEnd hook [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/156055 (owner: 10Legoktm) [22:20:02] (03Merged) 10jenkins-bot: Add docs for MonoBookTemplateToolboxEnd hook [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/156055 (owner: 10Legoktm) [22:20:28] (03CR) 10Bartosz Dziewoński: [C: 032] Update findHooks.php and move MonoBook hook out of docs/hooks.txt [core] - 10https://gerrit.wikimedia.org/r/156056 (owner: 10Legoktm) [22:20:39] Withoutaname: maybe [22:20:39] !ask [22:20:40] Please feel free to ask your question: if anybody who knows the answer is around, they will surely reply. Don't ask for help or for attention before actually asking your question, that's just a waste of time – both yours and everybody else's. :) [22:21:10] ashley: people usually forget to update mw.org [22:21:22] while they rarely forgot (or are allowed to forget by reviewers) hooks.txt [22:21:25] forget* [22:21:36] that...makes no sense to me [22:21:48] the solution is you get them to update MediaWiki.org, duh [22:22:04] it's the same problem as with release notes [22:22:28] if you ask people to update docs when they push the code for review, and the code doesn't get merged (or gets merged in a modified form), the docs are incorrect now [22:22:47] if you ask them to do it after the code is merged, they won't, because the code is already merged [22:22:54] <^d> Maybe we should file a bug about documentation being incomplete, out of date. [22:23:06] ^d: get out of my head, you! ;-) [22:23:10] (and everyone forgot what the change was about in the first place, because review took three months) [22:23:14] (03CR) 10SPQRobin: [C: 032] Add full stops where needed to i18n [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/156058 (owner: 10Vogone) [22:23:16] (03Merged) 10jenkins-bot: Update findHooks.php and move MonoBook hook out of docs/hooks.txt [core] - 10https://gerrit.wikimedia.org/r/156056 (owner: 10Legoktm) [22:23:22] (03Merged) 10jenkins-bot: Add full stops where needed to i18n [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/156058 (owner: 10Vogone) [22:23:40] <^d> MatmaRex: Get jenkins to file a bug post-merge saying "update docs" :p [22:23:50] or we just block merge :) [22:23:56] you could also ask the person who merges the code to update the docs, in which case no one will merge code if that would force them to write docs for other people's code [22:24:18] kevin said in order to get to the autoloader I have to solve https://bugzilla.wikimedia.org/show_bug.cgi?id=22624 first [22:24:50] if y'all have a better solution that still keeps commit + release notes + mw.org docs atomic, then do share it [22:25:03] git --> mw.o bot! [22:25:05] which I'm guessing would require knowledge of mw's text storage system [22:25:12] <^d> MatmaRex: Keep docs in the source, build doc website from those. [22:25:13] what we do right now is reasonable to me [22:25:18] and yes, we should have a sync bot [22:25:31] but that's hard because we don't write the .txt files in wikitext right now :/ [22:25:36] perhaps that should be changed [22:25:42] <^d> That's easily fixed. [22:26:11] we could also split files like hooks.txt for one file per hook, which would nicely correspond to mw.org pages [22:26:11] RELEASE-NOTES is in wikitext-ish [22:26:16] the file has been getting too long anyway [22:26:36] legoktm: closer to markdown-ish, really [22:26:36] Wait don't split it, I'm fixing https://bugzilla.wikimedia.org/show_bug.cgi?id=20345 first. [22:26:45] <^d> Deleting hooks makes it shorter :p [22:27:23] rm -rf docs/ [22:27:35] well, the docs/ directory is pretty useless too [22:27:53] "incomplete, out of date" [22:28:15] not hooks.txt! [22:28:36] hooks.txt might not be out of date, it's just junk [22:29:15] i might be weird, but i never read any of our documentation, i just look in the code… [22:29:46] doesn't help that all the interesting parts are '@todo document' [22:29:55] I've read the code and MW.org, but the junk in docs/ dir? I only touch it when I "have" to and even then I wonder "who the hell actually uses this when you have MW.org?" [22:30:05] design.txt summarizes the whole docs/ dir rather nicely, though: [22:30:08] More thorough and up-to-date information is available on the documentation [22:30:10] wiki at https://www.mediawiki.org/ [22:30:30] <^d> globals.txt is pretty funny reading. [22:31:00] ^d: wait till you get to skin.txt. [22:31:28] i actually have a patch to kill most of that file [22:31:29] https://gerrit.wikimedia.org/r/#/c/135439/ [22:31:44] perhaps i should split it into the docs part and the DO-NOT-MERGE-YET part [22:31:47] but who cares [22:40:50] (03PS14) 10Chad: Remove hitcounters and associated code [core] - 10https://gerrit.wikimedia.org/r/150699 [22:42:15] (03CR) 10Chad: "Now includes updater entries for all backends, rebased release notes, and I didn't remove the initial hitcounter patch entry in MysqlUpdat" [core] - 10https://gerrit.wikimedia.org/r/150699 (owner: 10Chad) [22:42:32] <^d> We should merge that :p [22:43:01] 3Wikimedia / 3Media storage: Swift outage caused a bunch of moved files to be "inconsistent" and "missing" - 10https://bugzilla.wikimedia.org/69311#c7 (10555) Be aware that this additional issue occured only 20 August 2014‎, days later the first report (8 August). I'm re-uploading the two djvu files listed... [23:01:01] How do I raise needinfo on this folk here? https://bugzilla.wikimedia.org/show_bug.cgi?id=69766#c4 [23:03:24] (03CR) 10Mattflaschen: "See reply inline." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/150635 (owner: 10Jdlrobson) [23:32:27] ^d: what is needed specifically to fix https://bugzilla.wikimedia.org/show_bug.cgi?id=22624 [23:35:11] <^d> Withoutaname: Not a clue, tbh. [23:35:18] <^d> I can make some vague hand-wavy guesses. [23:40:06] (03PS2) 10tosfos: Require IContextSource [extensions/GoogleCustomWikiSearch] - 10https://gerrit.wikimedia.org/r/155616